--- Day changed Mon Oct 31 2016
00:01 -!- rebroad [~rebroad@175.145.183.215] has joined #bitcoin-core-dev     
00:29 -!- fengling [~fengling@60.10.200.118] has joined #bitcoin-core-dev     
00:31 < sipa> BlueMatt: https://github.com/bitcoin/bitcoin/pull/8930/commits/37aefff5fcf7169a1b07ff8939850f630640f7e7 <- i remember there was some discussion about the reintroduction of #ifdef ENABLE_WALLET there, but i don't know where it was or what was said
00:35 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Quit: bye]     
01:03 -!- rebroad [~rebroad@175.145.183.215] has quit [Ping timeout: 260 seconds]     
01:12 < jonasschnelli> sipa: https://github.com/bitcoin/bitcoin/pull/8977/files fixes BlueMatt's #ifdef ENABLE_WALLET
01:17 -!- rebroad [~rebroad@175.145.183.215] has joined #bitcoin-core-dev     
01:22 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]     
01:23 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev     
01:48 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has quit [Quit: DigiByteDev]     
01:58 -!- AaronvanW [~ewout@207pc74.sshunet.nl] has joined #bitcoin-core-dev     
01:58 -!- AaronvanW [~ewout@207pc74.sshunet.nl] has quit [Changing host]     
01:58 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
02:06 -!- cdecker [~quassel@2a02:aa16:1105:4a80:75e7:f91f:c99c:3a52] has joined #bitcoin-core-dev     
02:17 -!- rebroad [~rebroad@175.145.183.215] has quit [Ping timeout: 268 seconds]     
02:21 -!- jannes [~jannes@178.132.211.90] has joined #bitcoin-core-dev     
02:24 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has joined #bitcoin-core-dev     
02:26 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 250 seconds]     
02:26 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-lmnydpgbvazstyka] has joined #bitcoin-core-dev     
02:28 -!- rebroad [~rebroad@175.145.183.215] has joined #bitcoin-core-dev     
02:34 -!- rebroad [~rebroad@175.145.183.215] has quit [Ping timeout: 260 seconds]     
02:44 -!- fengling [~fengling@60.10.200.118] has quit [Ping timeout: 268 seconds]     
02:48 -!- fengling [~fengling@60.10.200.118] has joined #bitcoin-core-dev     
03:00 <@wumpus> gmaxwell: can you take a look here? https://github.com/bitcoin-dot-org/bitcoin.org/pull/1401 (re: final alert stuff)
03:01 <@wumpus> I think it can be merged but as you're going to send it, it makes sense if you sign off on it
03:06 -!- fengling [~fengling@60.10.200.118] has quit [Ping timeout: 268 seconds]     
03:07 -!- fengling [~fengling@60.10.200.118] has joined #bitcoin-core-dev     
03:50 -!- cdecker [~quassel@2a02:aa16:1105:4a80:75e7:f91f:c99c:3a52] has quit [Ping timeout: 260 seconds]     
03:59 -!- tonikt [~tonikt@unaffiliated/tonikt] has quit [Quit: Leaving]     
04:01 -!- laurentmt [~Thunderbi@80.215.210.83] has joined #bitcoin-core-dev     
04:02 -!- laurentmt [~Thunderbi@80.215.210.83] has quit [Client Quit]     
04:05 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev     
04:35 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Read error: Connection reset by peer]     
04:43 -!- DigiByteDev [~JT2@n218250011174.netvigator.com] has quit [Quit: DigiByteDev]     
05:15 < achow101> ping gmaxwell 
05:18 < Victorsueca> try to CTCP ping him? that usually shows on other tabs
05:32 < rabidus_> try ddos
05:32 < rabidus_> ehm... i didn't really say that
05:32 < rabidus_> that's not an advice
05:34 < luke-jr> …     
05:34 < rabidus_> :'(     
05:50 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
06:03 < luke-jr> https://www.reddit.com/r/Bitcoin/comments/5ac1a4/error_in_bitcoind_munmap_chunk_invalid_pointer/
06:05 -!- tulip [uid192128@gateway/web/irccloud.com/x-unkjucyjcuwsdywh] has joined #bitcoin-core-dev     
06:08 -!- atroxes [~atroxes@unaffiliated/atroxes] has quit [Ping timeout: 260 seconds]     
06:13 -!- atroxes [~atroxes@unaffiliated/atroxes] has joined #bitcoin-core-dev     
06:14 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds]     
06:31 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
06:31 < BlueMatt> sipa: I prefer adding an ifdef than having a segfault (also that was already merged in another pr)
06:38 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds]     
06:48 -!- face [~face@mail.hmel.org] has joined #bitcoin-core-dev     
06:50 -!- rebroad [~rebroad@203.106.153.15] has joined #bitcoin-core-dev     
06:51 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev     
06:51 -!- ryanofsky [~russ@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev     
06:53 -!- fengling [~fengling@60.10.200.118] has quit [Ping timeout: 268 seconds]     
07:40 -!- f0g [~foggy@95.215.44.99] has joined #bitcoin-core-dev     
07:47 < GitHub117> [bitcoin] sdaftuar opened pull request #9048: [0.13 backport] Fix handling of invalid compact blocks (0.13...fix-invalid-cb-ban-0.13) https://github.com/bitcoin/bitcoin/pull/9048
07:50 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
07:50 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
07:51 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
07:51 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
07:56 -!- otium [~otium@2a01:e35:2eeb:c00:bcf9:efd1:82b2:a034] has joined #bitcoin-core-dev     
07:57 -!- otium [~otium@2a01:e35:2eeb:c00:bcf9:efd1:82b2:a034] has quit [Client Quit]     
08:10 -!- tonikt [~tonikt@unaffiliated/tonikt] has joined #bitcoin-core-dev     
08:11 -!- tonikt [~tonikt@unaffiliated/tonikt] has quit [Remote host closed the connection]     
08:13 -!- tonikt [~tonikt@unaffiliated/tonikt] has joined #bitcoin-core-dev     
08:20 < sipa> BlueMatt: 8977 it seems
08:26 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev     
08:34 -!- berndj [~berndj@mail.azna.co.za] has quit [Quit: ZNC - http://znc.in]     
08:35 -!- berndj [~berndj@197.242.93.84] has joined #bitcoin-core-dev     
08:38 -!- berndj [~berndj@197.242.93.84] has quit [Max SendQ exceeded]     
08:43 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
08:43 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit]     
08:50 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
08:54 -!- rebroad [~rebroad@203.106.153.15] has quit [Ping timeout: 265 seconds]     
09:02 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Ping timeout: 260 seconds]     
09:08 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev     
09:16 -!- tonikt [~tonikt@unaffiliated/tonikt] has quit [Quit: Leaving]     
09:20 -!- tulip [uid192128@gateway/web/irccloud.com/x-unkjucyjcuwsdywh] has quit [Quit: Connection closed for inactivity]     
09:32 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Read error: Connection reset by peer]     
09:32 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev     
09:46 -!- jannes [~jannes@178.132.211.90] has quit [Quit: Leaving]     
09:50 < BlueMatt> gmaxwell: so i went and combined everything into one loop of txn in a block (and even combined the sigops count loops pushed into checktransaction, etc...also removed the duplicative GetSerializeSize check in CheckTransaction (which is duplicative of CheckBlock) and the only part of that whole excersize that made any noticeable performance difference was removing the duplicate-input check, which made for a significant performance 
09:50 < BlueMatt> increase (of around 1.5ms in the 3-4ms function...)
09:51 -!- jannes [~jannes@178.132.211.90] has joined #bitcoin-core-dev     
09:53 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds]     
09:54 < BlueMatt> nvm, 0.7ms
09:55 < BlueMatt> on my laptop: 8ms to deserialize, 11.1 -> 10.5ms for deserialize + checkblock
09:55 -!- fengling [~fengling@111.196.71.162] has joined #bitcoin-core-dev     
10:05 -!- wasi [~wasi@183.12.202.62.static.wline.lns.sme.cust.swisscom.ch] has joined #bitcoin-core-dev     
10:14 -!- fengling [~fengling@111.196.71.162] has quit [Ping timeout: 268 seconds]     
10:14 -!- Chris_Stewart_5 [~Chris_Ste@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
10:16 < sipa> BlueMatt: cool, so let's just get rid of the duplicates check
10:17 < BlueMatt> sipa: not so easy due to network partition risk, as sdaftuar and I just found out :(
10:18 < sipa> uh?     
10:18 < sipa> ah.     
10:18 < BlueMatt> oops, no, nvm, just makes it tricky-er to do pre-relay of compact blocks
10:18 < BlueMatt> since then CheckBlock becomes network-ban-partition-consensus
10:19 < BlueMatt> (0.13.1 will already ban you for this, so it cant get worse...)
10:20 < BlueMatt> sipa: re: #9026
10:22 < gmaxwell> bump the protocol version number. then you can decide on your behavior based on it.?
10:26 < BlueMatt> true, probably need to do that, though still really want to do for 0.13.2
10:26 < BlueMatt> and then the problem is we dont want to change too often because you would just skip pre-relay for people not on your protocol version
10:33 -!- Chris_Stewart_5 [~Chris_Ste@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 260 seconds]     
10:50 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
10:53 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 245 seconds]     
11:01 -!- CubicEarth [~cubiceart@2601:648:8301:6650:f1d0:75cc:b552:93c] has joined #bitcoin-core-dev     
11:01 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
11:06 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds]     
11:10 < sipa> BlueMatt: i'm really curious what typo you made that got corrected into "I did not Rome the hashing"
11:10 < BlueMatt> dunno how my phone converted benchmark to rome, but it appears to have
11:11 < gmaxwell> .query eragmus
11:11 < gmaxwell> oops
11:11 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has quit [Quit: Leaving.]     
11:12 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has joined #bitcoin-core-dev     
11:16 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
11:16 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit]     
11:19 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
11:19 -!- wolfspra1l [~wolfsprau@bobbin.q-ag.de] has quit [Quit: leaving]     
11:19 -!- wolfspraul [~wolfsprau@bobbin.q-ag.de] has joined #bitcoin-core-dev     
11:28 -!- echonaut [~echonaut@46.101.192.134] has quit [Remote host closed the connection]     
11:29 -!- echonaut [~echonaut@46.101.192.134] has joined #bitcoin-core-dev     
11:29 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds]     
11:38 -!- dermoth_ [~thomas@dsl-199-102-157-21.mtl.aei.ca] has joined #bitcoin-core-dev     
11:39 -!- dermoth [~thomas@dsl-66-36-159-136.mtl.aei.ca] has quit [Disconnected by services]     
11:39 -!- dermoth_ is now known as dermoth     
11:42 -!- CubicEarth [~cubiceart@2601:648:8301:6650:f1d0:75cc:b552:93c] has quit [Remote host closed the connection]     
11:45 -!- Chris_Stewart_5 [~Chris_Ste@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
11:49 -!- CubicEarth [~cubiceart@c-73-15-209-20.hsd1.ca.comcast.net] has joined #bitcoin-core-dev     
11:49 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev     
11:49 < GitHub133> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d2143dc937e3...3d69ecb4edeb
11:50 < GitHub133> bitcoin/master 7f61b49 matthias: Change all instance of 'GMT epoch' to 'Unix epoch'
11:50 < GitHub133> bitcoin/master 3d69ecb MarcoFalke: Merge #9041: keypoololdest denote Unix epoch, not GMT...
11:50 < GitHub16> [bitcoin] MarcoFalke closed pull request #9041: keypoololdest denote Unix epoch, not GMT (master...patch-8) https://github.com/bitcoin/bitcoin/pull/9041
11:51 -!- CubicEarth [~cubiceart@c-73-15-209-20.hsd1.ca.comcast.net] has quit [Remote host closed the connection]     
11:51 -!- CubicEarth [~cubiceart@c-73-15-209-20.hsd1.ca.comcast.net] has joined #bitcoin-core-dev     
11:52 -!- Chris_Stewart_5 [~Chris_Ste@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 245 seconds]     
11:52 < GitHub112> [bitcoin] TheBlueMatt opened pull request #9049: Remove duplicatble duplicate-input check from CheckTransaction (master...2016-10-bench-checkblock) https://github.com/bitcoin/bitcoin/pull/9049
11:56 -!- CubicEarth [~cubiceart@c-73-15-209-20.hsd1.ca.comcast.net] has quit [Remote host closed the connection]     
11:57 < sipa> duplicatble duplicate-input ?
11:58 -!- berndj-blackout [~berndj@mail.azna.co.za] has joined #bitcoin-core-dev     
12:02 -!- berndj-blackout is now known as berndj     
12:08 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
12:33 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has left #bitcoin-core-dev []     
12:43 -!- berndj [~berndj@mail.azna.co.za] has quit [Quit: ZNC - http://znc.in]     
12:43 -!- wasi [~wasi@183.12.202.62.static.wline.lns.sme.cust.swisscom.ch] has quit [Ping timeout: 268 seconds]     
12:46 -!- berndj [~berndj@mail.azna.co.za] has joined #bitcoin-core-dev     
12:47 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds]     
12:49 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
12:56 -!- CubicEarth [~cubiceart@c-73-15-209-20.hsd1.ca.comcast.net] has joined #bitcoin-core-dev     
13:08 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Read error: Connection reset by peer]     
13:10 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev     
13:29 -!- dermoth_ [~thomas@dsl-216-221-32-179.mtl.aei.ca] has joined #bitcoin-core-dev     
13:29 -!- dermoth [~thomas@dsl-199-102-157-21.mtl.aei.ca] has quit [Disconnected by services]     
13:29 -!- dermoth_ is now known as dermoth     
13:40 -!- jannes [~jannes@178.132.211.90] has quit [Quit: Leaving]     
13:48 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 244 seconds]     
13:52 -!- CubicEarth [~cubiceart@c-73-15-209-20.hsd1.ca.comcast.net] has quit []     
13:53 -!- owowo [ovovo@gateway/vpn/mullvad/x-ltlpvdhzaxchpkgl] has joined #bitcoin-core-dev     
13:54 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has quit [Quit: Leaving.]     
13:57 -!- owowo [ovovo@gateway/vpn/mullvad/x-ltlpvdhzaxchpkgl] has quit [Read error: Connection reset by peer]     
14:04 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev     
14:22 -!- droark [~droark@c-24-22-123-27.hsd1.or.comcast.net] has quit [Ping timeout: 250 seconds]     
14:51 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)]     
14:53 -!- silversword [~silverswo@46.166.137.213] has joined #bitcoin-core-dev     
14:54 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
14:54 -!- silversword [~silverswo@46.166.137.213] has left #bitcoin-core-dev ["I bid thee adieu"]     
14:58 -!- molz [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds]     
15:03 < GitHub106> [bitcoin] theuni opened pull request #9050: net: make a few values immutible, and use deterministic randomness for the localnonce (master...connman-const) https://github.com/bitcoin/bitcoin/pull/9050
15:09 < gmaxwell> cfields_: I haven't looked yet, but does that fix the current race condition, where if you connect to yourself then someone else connects to you then you get your own nonce, you'll not detect the connect to self?
15:10 < cfields_> gmaxwell: i believe that was fixed a while back with the initial CConnman merge.
15:10 < gmaxwell> Ah. good
15:11 < sipa> yes, that was fixed afaik
15:12 < cfields_> gmaxwell: if we're speaking of the same race, this should've fixed it: https://github.com/bitcoin/bitcoin/commit/960cf2e4058a9c195bf64e1aecb46024f9ef022a
15:13 < gmaxwell> yup! that looks good. Okay, I'd missed that.
15:13 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev     
15:16 < gmaxwell> cfields_: whats the motivation for making the nonce determinstic?
15:18 < cfields_> gmaxwell: none really, other than it's one of the few (the only?) users of Rand in there. Eliminating them could ease replay for testing.
15:19 < gmaxwell> uh. wait... you mean this is completely determinstic?
15:19  * gmaxwell goes to read the patch.
15:19 < cfields_> gmaxwell: really not much though, i just figured if it was immutible and per-connection, may as well make it deterministic if possible
15:19 < cfields_> gmaxwell: heh, no. It's seeded at startup
15:19 < cfields_> wait, i hope...
15:19 < cfields_> yes, sorry. It's a per-connman seed.
15:20 < cfields_> you made me doubt myself for a sec :)
15:23 < gmaxwell> K. yes, I see that.  Just the 'replay for testing' made me wonder!
15:24 < gmaxwell> so if someone manages to make enough connections to wrap the peer_id ... it'll repeat. OTOH if someone manages to do that lots of other things will probably break. :P
15:27 < cfields_> heh, yes. NodeId is signed, so things could go wonky way before that
15:31 < cfields_> err     
15:35 -!- cryptapus [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev     
15:35 -!- cryptapus [~cryptapus@jupiter.osmus.org] has quit [Changing host]     
15:35 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev     
15:36 < gmaxwell> sipa: cfields_ just had a spurrious travis failure caused by the overly jumpy rand_bits test in libsecp256k1.
15:37 < gmaxwell> sipa: IMO we should ifdef out the RNG tests and just run them once per release as part of a prerelease checklist or something.
15:39 < sipa> iirc i started a replacement for that at some point, but it remained too spurious
15:40 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 244 seconds]     
15:40 -!- BonyM1 [~BonyM-I@ua-83-227-211-4.cust.bredbandsbolaget.se] has quit [Ping timeout: 265 seconds]     
15:41 < BlueMatt> cfields_: hum, hashing isnt much of a bottleneck here...
15:42 < gmaxwell> sipa: I believe its the only rest with spurrious failures, and the rng tests are the only ones which _must_ have spurrious failures.
15:43 < sipa> right, but it should be doable to bring that down to 1 in a billion runs or so
15:43 < BlueMatt> well, the compact blocks stuff is somewhat spurious
15:44 < BlueMatt> though i suppose it could effect regtest during semi-normal usage
15:44 < sipa> BlueMatt: this is about libsecp256k1
15:45 < BlueMatt> oh, sorry
15:45 < BlueMatt> get your own channel!
15:45 < BlueMatt> (jk)
15:47 < cfields_> BlueMatt: i just can't think of any good reason for handling it on the socket thread, which lags more with each added connection, as opposed to on the message thread(/pool), potentially lazily, and only as needed
15:48 < BlueMatt> cfields_: oops, see my respond on github
15:49 < BlueMatt> its a latency question...our current hasher should (mostly) be able to keep up with 1Gbps of shit (ok, maybe more like 500Mbps), but putting it in the processing logic adds latency to block processing
15:51 < gmaxwell> also we do no other computation in the thread that handles the incoming data... so this should better let it run concurrently with processing given the current setup.
15:52 < cfields_> hmm     
15:53 < sipa> i would expect that in the future it's also easier to parallellize networking than it is to parallellize processing
15:54 -!- BonyM1 [~BonyM-I@ua-83-227-211-4.cust.bredbandsbolaget.se] has joined #bitcoin-core-dev     
15:55 < sipa> and the bip151 hasher should be a few times faster
15:55 < cfields_> sipa: heh, i argued the exact opposite in the PR. At the select/epoll/etc. level anyway. Though I suppose you could split the nodes into batches.
15:55 < BlueMatt> cfields_: if you're bored, #8969 can probably get another ack and a merge, then we're only about 3 commits from splitting main, altough the next one will probably have to wait until the compact block fix goes in
15:56  * BlueMatt realizes he hasnt re-reviewed 8708, oops
15:56 < cfields_> BlueMatt: you can save the poke, i owe you an ack on that one already :)
15:56 < BlueMatt> heh, ok
15:56 < BlueMatt> just trying to move things in since its gonna be a painful merge cycle to get this all in for 0.4
15:58 < sipa> cfields_: also, 8708 mentions constness... i'm addressing that to some extent in #8580, which now is queued after #9039 :)
15:59 < BlueMatt> lol, so much to review
15:59 < sipa> 9039 grew a bit beyond what i originally planned to address, but i think the result is worth it
16:00 < BlueMatt> yea, i saw there was some back-and-forth, but, indeed, I'll bet thats worth it
16:00 < BlueMatt> serialization can always use cleaning
16:00 < cfields_> sipa: ack. Your serialization changes are next on my list to review. As it relates to 8708, i removed the const hack that i justified with "but we already do this elsewhere!", so my changes won't undo your fixes.
16:01 < BlueMatt> we need an irc bot that posts pr titles after numbers are mentioned :p
16:01 < sipa> BlueMatt: yes!
16:01 < BlueMatt> where is nanotube when you need him?
16:01 < cfields_> BlueMatt: heh, yes, and links to commit ids
16:01 < BlueMatt> gribble: help me out bro
16:02 < cfields_> BlueMatt: i used that in another channel, iirc it was easy enough to setup
16:02 < BlueMatt> I'm sure, but I'm lazy...prefer if someone who's already running a bot in here does it :p
16:02 < BlueMatt> I mean its easy...4 digit number starting with a # and link to github.com/bitcoin/bitcoin/issue/#
16:03 < BlueMatt> cfields_: I'll try to get you another review on 8708 tonight, otherwise tomorrow morning
16:03 < sipa> BlueMatt, cfields_: can you two fight over the order in which 8708 and 8969?
16:03 < BlueMatt> should be minimal conflicts?
16:03 < sipa> ok     
16:03 < BlueMatt> or at least easy-to-resolve ones?
16:04 < sipa> so much easier :)
16:04 < sipa> i assumed they'd conflict a lot
16:04 < BlueMatt> 8969 is some random trivial cleanups in preparation for the big split (tm)
16:04 < BlueMatt> so souldnt conflict with much of anything
16:05 < sipa> cfields_: 9039 touches pretty much every line that deals with serialization, so it'll conflict with the beginning of 8708
16:06 < BlueMatt> sipa: I think 8708 is further along?
16:06 < cfields_> sipa: np, i don't mind rebasing that one. It'll need one more set of changes on top, in fact, so i'll take the burden there
16:06 < BlueMatt> I think cfields_ and I probably agree on it now, just need to review
16:06 < BlueMatt> heh, ok
16:07 < sipa> ok     
16:07 < sipa> i'll review 8708 in more detail too hen
16:07 < sipa> then
16:07 < cfields_> yea, it should be ready, i think, but it'll touch PushMessage again.
16:08 < cfields_> sipa: if it makes more sense to get the serialization changes in first, I could go ahead and make the other change in 8708, rather than breaking it out, that way it can be reviewed in parallel, then just rebase on the serialization changes
16:08 < cfields_> either way, doesn't matter at all to me.
16:09 < sipa> cfields_: i think it'll just boil down to removing "nType, nVersion, " everywhere in your patch
16:09 < cfields_> sipa: ah ok, that's trivial then.
16:12 < cfields_> BlueMatt: btw, i'm just a few steps away from splitting CConnman out of net, but I'll wait for the main split :)
16:12 < BlueMatt> cfields_: cool
16:13 < BlueMatt> if we get all this shit in 0.14 I'm gonna be really impressed
16:19 < BlueMatt> cfields_: you missed one of my nits - you need to move the assert in EndMessage up above the first WriteLE32
16:20 < BlueMatt> cfields_: while you're at it, just change it to assert size >= HEADER_SIZE
16:23 < cfields_> BlueMatt: hm, thought I moved it. sorry about that. will make that change.
16:23 < BlueMatt> cfields_: while you're at it, you changed the LogPrint on sending messages
16:24 < BlueMatt> it used to read "sending: ..." you removed the sending
16:24 < BlueMatt> and you got rid of the SanitizeString() call there, though i doubt that matters
16:26 < cfields_> BlueMatt: grr, not sure why those got dropped. will fix.
16:26 < cfields_> crap, got to go help with dinner. bbl.
16:26 < BlueMatt> cfields_: ok, I'll queue them in review...gotta run as well, so might have to finish tomorrow
16:42 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 250 seconds]     
16:55 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev     
17:12 < instagibbs> BlueMatt in not too long it will be 5 digits...
17:14 < sipa> at which point we'll need a bot even more
17:17 -!- echonaut3 [~echonaut@46.101.192.134] has joined #bitcoin-core-dev     
17:18 -!- echonaut [~echonaut@46.101.192.134] has quit [Remote host closed the connection]     
17:21 -!- blkdb [~blkdb@2a01:4f8:140:1407::2] has quit [Write error: Broken pipe]     
17:21 -!- blkdb [~blkdb@2a01:4f8:140:1407::2] has joined #bitcoin-core-dev     
17:33 < nanotube> BlueMatt: that can be easily arranged. 
17:43 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds]     
17:43 < GitHub141> [bitcoin] gmaxwell opened pull request #9052: Use RelevantServices instead of node_network in AttemptToEvict. (master...prefer_relevant2) https://github.com/bitcoin/bitcoin/pull/9052
17:43 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has quit [Read error: Connection reset by peer]     
17:44 -!- davec [~davec@cpe-24-243-251-52.hot.res.rr.com] has joined #bitcoin-core-dev     
17:45 -!- binns [sid105317@21/bitcoin/binns] has quit [Quit: Updating details, brb]     
17:45 -!- binns [sid105317@21/bitcoin/binns] has joined #bitcoin-core-dev     
17:47 < GitHub58> [bitcoin] gmaxwell opened pull request #9053: IBD using chainwork instead of height and not using header timestamps (master...no_checkpoint_for_ibd) https://github.com/bitcoin/bitcoin/pull/9053
17:47 < gribble> https://github.com/bitcoin/bitcoin/issues/9053 | IBD using chainwork instead of height and not using header timestamps by gmaxwell · Pull Request #9053 · bitcoin/bitcoin · GitHub
17:47 < gmaxwell> haha
17:47 -!- binns is now known as wbnns     
17:47 < nanotube> haha well... i guess gribble should ignore github >_>
17:48 < gmaxwell> so perhaps it should ignore gitub. 
17:48 < nanotube> :)     
17:48 < sipa> yay, consensus
17:48 < gmaxwell> I like Red #40 dye.
17:48 < gribble> https://github.com/bitcoin/bitcoin/issues/40 | -rpcssl help text by dooglus · Pull Request #40 · bitcoin/bitcoin · GitHub
17:49 < sipa> roses are #FF0000
17:50 < nanotube> the regex just looks for #\d+
17:50 < achow101> #10000
17:50 < gribble> https://github.com/bitcoin/bitcoin/issues/10000 | HTTP Error 404: Not Found
17:52 < sipa> so what if you refer to two in one line, like how #8708 will conflict with #9039
17:52 < gribble> https://github.com/bitcoin/bitcoin/issues/8708 | net: have CConnman handle message sending by theuni · Pull Request #8708 · bitcoin/bitcoin · GitHub
17:52 < gribble> https://github.com/bitcoin/bitcoin/issues/9039 | Various serialization simplifcations and optimizations by sipa · Pull Request #9039 · bitcoin/bitcoin · GitHub
17:52 < phantomcircuit> gmaxwell: int64_t &nOrderNextPos = nOrderNextPos in CWallet::ReorderTransactions is trying to assign a reference to itself not the member variable
17:52 < nanotube> ^ that happens :)
17:52 < phantomcircuit> i dont get this
17:52 < phantomcircuit> do you?
17:52 < sipa> phantomcircuit: ha
17:53 < sipa> phantomcircuit: yes, variables are defined during their own initializer
17:53 < phantomcircuit> ok then i understand what was wrong with #8828
17:53 < gribble> https://github.com/bitcoin/bitcoin/issues/8828 | Move CWalletDB::ReorderTransactions to CWallet by pstratem · Pull Request #8828 · bitcoin/bitcoin · GitHub
17:54 < sipa> similar to how you can call a function inside that function's body
17:59 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
18:47 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-kpwuapjdhnhmauub] has quit [Quit: Connection closed for inactivity]     
18:51 < sipa> should we introduce http://en.cppreference.com/w/cpp/language/user_literal for uint256?
18:52 < gmaxwell> sipa: would there be any benefits beyond saving a few bytes of source code for each of the couple uint256 constants we have?
18:57 < sipa> no     
18:58 < cfields_> sipa: mm, i coded that up at one point
18:59 < cfields_> gmaxwell: it's especially nice because you can initialize on the stack more quickly (and efficiently)
19:00 < sipa> cfields_: it's just an invocation to a conversion operator, instead of a function
19:00 < cfields_> (you can parse a variadic of hex chars as constexpr, so the parsing is free)
19:00 < sipa> i'm pretty sure there's no difference at runtime
19:00 < sipa> oh!     
19:00 < sipa> well we could also make uint256S constexpr then?
19:00 < cfields_> sipa: well, it only works for literals
19:01 < gmaxwell> I think in all cases they get stashed in constants, so it shouldn't really make a runtime difference.
19:02 < cfields_> yea, in reality it's negligible. I just did it to play with the variadics + user literals. But it made chainparams look prettier :)
19:02 < cfields_> i'll see if i can dig it up
19:07 < sipa> cfields_: right, but i guess you could at least have a uint256constS function, which is constexpr and does the same thing as the normal uint256S function
19:07 < sipa> which you could only pass literals or other constexpr strings
19:07 < sipa> and compared to that, a user-defined literal is purely syntactic sugar?
19:09 < cfields_> sipa: sure, i suppose so
19:11 -!- notmike [~notmike@unaffiliated/notmike] has joined #bitcoin-core-dev     
19:28 -!- notmike [~notmike@unaffiliated/notmike] has quit [Quit: This computer has gone to sleep]     
19:35 -!- notmike [~notmike@unaffiliated/notmike] has joined #bitcoin-core-dev     
19:37 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 252 seconds]     
19:39 -!- echonaut3 [~echonaut@46.101.192.134] has quit [Remote host closed the connection]     
19:39 -!- echonaut [~echonaut@46.101.192.134] has joined #bitcoin-core-dev     
19:48 -!- notmike is now known as notnick     
19:48 -!- notnick is now known as notmike     
20:17 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-jcjjnzchuwelkupo] has joined #bitcoin-core-dev     
20:40 < gmaxwell> https://github.com/bitcoin/bitcoin/pull/9053 < can someone trigger a rerun here? I'm pretty sure this change couldn't make test_bitcoin fail (and it passes locally.)
20:46 < sipa> gmaxwell: chainActive.Tip()->nChainWork may segfault before the genesis block is loaded
20:47 < sipa> almost all platforms fail, that doesn't look like a spurious error
20:48 < gmaxwell> sipa: on #1 fair comment, but they're failing in test_bitcoin prevector tests.
20:48 < gribble> https://github.com/bitcoin/bitcoin/issues/1 | JSON-RPC support for mobile devices ("ultra-lightweight" clients) · Issue #1 · bitcoin/bitcoin · GitHub
20:48 < gmaxwell> die     
20:48 < sipa> hahahaha
20:57 < luke-jr> lol     
21:10 -!- PaulCapestany [~PaulCapes@2604:5500:17:2ea:543e:871d:cfcf:dda6] has quit [Quit: .]     
21:11 -!- PaulCapestany [~PaulCapes@2604:5500:17:2ea:c183:298d:e344:642d] has joined #bitcoin-core-dev     
21:16 -!- dstadulis [~dstadulis@2602:30a:2e05:2130:348d:472e:a934:81fa] has joined #bitcoin-core-dev     
21:16 -!- PaulCapestany [~PaulCapes@2604:5500:17:2ea:c183:298d:e344:642d] has quit [Quit: .]     
21:18 -!- PaulCapestany [~PaulCapes@2604:5500:17:2ea:c183:298d:e344:642d] has joined #bitcoin-core-dev     
21:23 -!- fengling [~fengling@223.223.187.136] has joined #bitcoin-core-dev     
22:08 -!- dstadulis [~dstadulis@2602:30a:2e05:2130:348d:472e:a934:81fa] has quit [Ping timeout: 245 seconds]     
22:40 < btcdrak> #2     
22:40 < gribble> https://github.com/bitcoin/bitcoin/issues/2 | Long-term, safe, store-of-value · Issue #2 · bitcoin/bitcoin · GitHub
22:40 < btcdrak> oh thats going to get annoying
22:41 < gmaxwell> Perhaps we should as nano to change it to PR#xxxx
22:41 < sipa> or we adapt
22:41 < gmaxwell> FWIW, there is a bot that does this in #xiph run by someone no one knows, that just spends all its time banned. esp because it links to some trac instance thats hardly used.
22:42 -!- rebroad [~rebroad@175.145.246.165] has joined #bitcoin-core-dev     
22:44 -!- DigiByteDev [~JT2@218.250.11.174] has joined #bitcoin-core-dev     
22:48 < TD-Linux> gmaxwell, it's not banned sadly
22:52 -!- notmike [~notmike@unaffiliated/notmike] has quit [Quit: This computer has gone to sleep]     
23:08 -!- rebroad [~rebroad@175.145.246.165] has quit [Ping timeout: 260 seconds]     
23:36 -!- servkolhapur [31f853f5@gateway/web/freenode/ip.49.248.83.245] has joined #bitcoin-core-dev     
23:36 -!- servkolhapur [31f853f5@gateway/web/freenode/ip.49.248.83.245] has quit [Client Quit]     
23:36 -!- notmike [~notmike@unaffiliated/notmike] has joined #bitcoin-core-dev     
23:42 -!- notmike [~notmike@unaffiliated/notmike] has quit [Quit: This computer has gone to sleep]     
23:59 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving]