--- Day changed Wed Nov 02 2016 00:37 -!- harrymm [~wayne@104.222.140.92] has quit [Ping timeout: 260 seconds] 00:43 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 00:44 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:45 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 00:48 < midnightmagic> sipa: Tor-only node -- Socks5() connect to seed.bitcoin.sipa.be:8333 failed: host unreachable 00:48 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 260 seconds] 00:53 -!- harrymm [~wayne@104.222.140.118] has joined #bitcoin-core-dev 00:57 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 268 seconds] 00:58 < jonasschnelli> 8333? 00:59 < jonasschnelli> It's a DNS seeder and not a node IMO 01:00 < jonasschnelli> But dig A seed.bitcoin.sipa.be returns no IPs... 01:00 < jonasschnelli> sipa: your seeder down? 01:00 < jonasschnelli> I recently had downtime as well, but the seeder process was running (and updating the stats). Maybe a bug in the DNS serving code. 01:03 < sipa> my seeder looks up and running 01:07 < jonasschnelli> sipa: http://0bin.net/paste/Mi3qS-1E-npb7XZR#XW5vvio2WnVKrQojNA6gwt6qfAYwMYpUoK6NlJ2PLWB 01:07 < jonasschnelli> same result from a different host 01:07 < jonasschnelli> I guess your facing the same issue I recently had. 01:07 < sipa> hmm 01:07 < sipa> and with x9? 01:07 < jonasschnelli> empty response 01:08 < jonasschnelli> I guess it could be a bug in my filter PR 01:08 < jonasschnelli> something with the cache 01:08 < sipa> i already fixed a bug in it 01:08 < sipa> maybe i made it worse :) 01:08 < jonasschnelli> heh... 01:08 < jonasschnelli> Do you take a look at it or should I? 01:12 < sipa> i'm about to fall asleep :) 01:14 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 01:14 < rabidus_> where are you from? if i may ask 01:15 < sipa> i'm from belgium originally, but i'm on the us west coast now 01:16 < jonasschnelli> Yes. Have your rest,.. maybe restart your seeder if you have a chance 01:16 < jonasschnelli> Will try to track it down 01:17 < sipa> ok, restarted 01:22 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Ping timeout: 256 seconds] 01:22 -!- achow101 [~achow101@unaffiliated/achow101] has joined #bitcoin-core-dev 01:27 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 01:33 -!- AaronvanW [~ewout@207pc74.sshunet.nl] has joined #bitcoin-core-dev 01:33 -!- AaronvanW [~ewout@207pc74.sshunet.nl] has quit [Changing host] 01:33 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:40 < jonasschnelli> I have two connected peers, peer A creates a WTX and inv's that to peer B (peer B throws it away [my local change]), I stop both peers [=empty mempools], start again both peers, peer A relays WTX again, but I can't find a inv to peer B (= mempools out of sync, peer A has WTX while peer B don't) 01:41 < jonasschnelli> I guess the "known inventory" will not be persisted on disk? Why does peer A not inv the WTX again to peer B after restart/sweeping the mempool? 01:54 -!- juscamarena [~jus@47.148.176.74] has quit [Ping timeout: 260 seconds] 02:09 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev 02:23 -!- moli [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer] 02:23 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 02:27 <@wumpus> transactions are only inved when they get relayed, not at any later time, there is no re-inv for old transactions (except by the wallet) 02:27 < MarcoFalke> What is the reason for AGPL in #9049 02:28 < gribble> https://github.com/bitcoin/bitcoin/issues/9049 | Remove duplicatble duplicate-input check from CheckTransaction by TheBlueMatt · Pull Request #9049 · bitcoin/bitcoin · GitHub 02:28 < MarcoFalke> Has someone accidentally uploaded the MongoDB source code to the blockchain, block 413567? 02:28 <@wumpus> what 02:29 <@wumpus> I think he's trolling, but it can't be accepted in this state 02:31 <@wumpus> let's leave the license drama to other altcoins 02:33 < jonasschnelli> wumpus: but when I start a node and the wallet re-broadcasts a tx, it should get inved to the connected peers? Or does the connecting happens after the wallet-re-broadcast? 02:34 <@wumpus> jonasschnelli: yes, if the wallet re-broadcasts it should be inved to connected peers 02:34 <@wumpus> (unless it is known that they know of the transaction, but this information is cleared on restart/reconnect) 02:35 <@wumpus> if connecting happens after rebroadcast yea you'd have to wait until the next one 02:35 <@wumpus> (or rebroadcast it manually using sendrawtransaction) 02:44 -!- DigiByteDev [~JT2@69.167.29.35] has joined #bitcoin-core-dev 02:49 -!- moli [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer] 02:52 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 03:00 < jonasschnelli> wumpus: not sure if i'm deluded, but ReacceptWalletTransactions() does not inv/broadcast it to over the network https://github.com/bitcoin/bitcoin/blob/master/src/wallet/wallet.cpp#L1438 03:00 -!- DigiByteDev [~JT2@69.167.29.35] has quit [Quit: DigiByteDev] 03:01 < jonasschnelli> the new RelayWalletTransaction seems not to be called in that scenario https://github.com/bitcoin/bitcoin/blob/master/src/wallet/wallet.cpp#L1471 03:01 < jonasschnelli> Not sure if it's problematic,... just stumbled over this while writing an RPC test 03:03 <@wumpus> jonasschnelli: IIRC that isn't supposed to happen in ReacceptWalletTransactions, that just introduces them into the mempool 03:04 <@wumpus> there's separate logic for the rebroadcast, which doesn't do it immediately at start but periodically, this preserves a little bit of privacy 03:06 < jonasschnelli> hmm... need to track it down further... just detected that RPC sync_all() does not succeed after re-starting two nodes, the mempool wtx from node A does not get over to node B. 03:06 -!- DigiByteDev [~JT2@69.167.29.35] has joined #bitcoin-core-dev 03:07 <@wumpus> it shouldn't: there is no automatic mempool sync on start, the sync is just a wait for current transactions to be relayed, if I recall correctly 03:08 <@wumpus> it indeed doesn't handle the scenario where one of the nodes has shut down, that would need additional support 03:08 < jonasschnelli> Okay. I see. 03:09 <@wumpus> I don't think there is any logic, either inthe tests or elsewhere, for doing a node-to-node mempool sync 03:09 <@wumpus> although if the mempool is saved to disk now that'd be possible through that route 03:09 < luke-jr> FYI Knots used to have such logic, but it didn't work well, so I removed it 03:10 < luke-jr> (I'm pretty sure it delayed the real sync until download of peer mempools completed) 03:10 <@wumpus> yes it at most should be something specifically called in the tests, not used in all circumstances 03:11 <@wumpus> (and certainly not use the P2P mempool command) 03:11 -!- DigiByteDev [~JT2@69.167.29.35] has quit [Quit: DigiByteDev] 03:11 <@wumpus> oh the mempool save to disk isn't merged yet : https://github.com/bitcoin/bitcoin/pull/8448 that'd explain somethime jonasschnelli 03:12 <@wumpus> seems it can be merged 03:13 < GitHub124> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/273bde37d867...101c642bef7f 03:13 < GitHub124> bitcoin/master c3efb58 Pieter Wuille: Add feedelta to TxMempoolInfo 03:13 < GitHub124> bitcoin/master ced7c94 Pieter Wuille: Add AcceptToMemoryPoolWithTime function 03:13 < GitHub124> bitcoin/master 3f78562 Pieter Wuille: Add DumpMempool and LoadMempool 03:13 < GitHub32> [bitcoin] laanwj closed pull request #8448: Store mempool and prioritization data to disk (master...dumpmempool) https://github.com/bitcoin/bitcoin/pull/8448 03:16 < GitHub161> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/101c642bef7f...6a8be7ba999a 03:16 < GitHub161> bitcoin/master 6c5cd9d Wladimir J. van der Laan: test: Add format-dependent comparison to bctest... 03:16 < GitHub161> bitcoin/master 6a8be7b Wladimir J. van der Laan: Merge #9032: test: Add format-dependent comparison to bctest... 03:16 < GitHub160> [bitcoin] laanwj closed pull request #9032: test: Add format-dependent comparison to bctest (master...2016_10_bctest_smart_compare) https://github.com/bitcoin/bitcoin/pull/9032 03:16 < GitHub108> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/6a8be7ba999a...f8723d231812 03:16 < GitHub108> bitcoin/master 999e4c9 Wladimir J. van der Laan: wallet: Change CCrypter to use vectors with secure allocator... 03:16 < GitHub108> bitcoin/master f4d1fc2 Wladimir J. van der Laan: wallet: Get rid of LockObject and UnlockObject calls in key.h... 03:16 < GitHub108> bitcoin/master 4536148 Wladimir J. van der Laan: support: Add LockedPool... 03:17 < GitHub112> [bitcoin] laanwj closed pull request #8753: Locked memory manager (master...2016_09_lockedpool) https://github.com/bitcoin/bitcoin/pull/8753 03:43 -!- kadoban_ [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 03:43 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Ping timeout: 260 seconds] 03:48 -!- kadoban_ [~mud@unaffiliated/kadoban] has quit [Ping timeout: 245 seconds] 03:49 -!- kadoban_ [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 03:51 -!- harrymm [~wayne@104.222.140.118] has quit [Ping timeout: 268 seconds] 04:03 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has left #bitcoin-core-dev [] 04:07 -!- harrymm [~wayne@104.222.140.98] has joined #bitcoin-core-dev 04:23 -!- fengling [~fengling@223.223.187.136] has quit [Ping timeout: 268 seconds] 04:33 -!- cryptapus [~cryptapus@87.254.202.194] has joined #bitcoin-core-dev 04:33 -!- cryptapus [~cryptapus@87.254.202.194] has quit [Changing host] 04:33 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 04:49 -!- wasi [~wasi@2a02:121e:41b:0:226:c7ff:fe74:7fa6] has quit [Ping timeout: 260 seconds] 05:08 -!- wasi [~wasi@183.12.202.62.static.wline.lns.sme.cust.swisscom.ch] has joined #bitcoin-core-dev 05:16 -!- murch [~murch@p4FE3A5BE.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 05:44 -!- harrymm [~wayne@104.222.140.98] has quit [Ping timeout: 260 seconds] 05:49 -!- fengling [~fengling@223.223.187.136] has joined #bitcoin-core-dev 05:55 -!- fengling [~fengling@223.223.187.136] has quit [Ping timeout: 268 seconds] 05:55 -!- rebroad [~rebroad@118.101.155.76] has joined #bitcoin-core-dev 05:56 < GitHub111> [bitcoin] rebroad opened pull request #9062: Add -logtimemillis command line option (master...LogTimeMillisOption) https://github.com/bitcoin/bitcoin/pull/9062 05:59 -!- harrymm [~wayne@104.222.140.40] has joined #bitcoin-core-dev 06:02 -!- rebroad [~rebroad@118.101.155.76] has quit [Ping timeout: 250 seconds] 06:05 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:05 <@wumpus> gah, really... 06:08 -!- kadoban_ is now known as kadoban 06:11 < jonasschnelli> A script that truns the milli-timestamps in debug.log to micro-timestamp... meh 06:11 < jonasschnelli> *turns 06:12 <@wumpus> it's clear that there are not enough time formats for logging, what about number of Planck time units since the big bang 06:12 < jonasschnelli> heh 06:15 <@wumpus> it'd even fit into an arith_uint256 06:19 < GitHub123> [bitcoin] paveljanik opened pull request #9063: Do not shadow variable, use deprecated MAP_ANON if MAP_ANONYMOUS is not defined (master...20161102_fix_lockedpool) https://github.com/bitcoin/bitcoin/pull/9063 06:20 -!- f0g [~foggy@95.215.44.99] has quit [Ping timeout: 245 seconds] 06:21 -!- f0g [~foggy@176.223.111.92] has joined #bitcoin-core-dev 06:35 -!- DigiByteDev [~JT2@69.167.29.212] has joined #bitcoin-core-dev 06:36 -!- whphhg [whphhg@gateway/vpn/mullvad/x-qmbpnhlngoqmlrny] has joined #bitcoin-core-dev 06:39 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has quit [Remote host closed the connection] 06:40 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has joined #bitcoin-core-dev 06:41 < BlueMatt> wumpus: sorry, the license there is the FIBRE license, from which i copied that file 06:41 < BlueMatt> wumpus: just forgot to change it 06:42 < GitHub68> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f8723d231812...f2a6e8243f2a 06:42 < GitHub68> bitcoin/master 4a9f3c5 Pavel Janík: Do not shadow variable, use deprecated MAP_ANON if MAP_ANONYMOUS is not defined. 06:42 < GitHub68> bitcoin/master f2a6e82 Wladimir J. van der Laan: Merge #9063: Do not shadow variable, use deprecated MAP_ANON if MAP_ANONYMOUS is not defined... 06:42 < GitHub77> [bitcoin] laanwj closed pull request #9063: Do not shadow variable, use deprecated MAP_ANON if MAP_ANONYMOUS is not defined (master...20161102_fix_lockedpool) https://github.com/bitcoin/bitcoin/pull/9063 06:42 <@wumpus> BlueMatt: it was a good troll :) I'm happy MarcoFalke was awake 06:46 < BlueMatt> yes, wouldve been hilarious if that ended up in bitcoin 06:53 -!- fengling [~fengling@223.223.187.136] has joined #bitcoin-core-dev 07:07 -!- fengling [~fengling@223.223.187.136] has quit [Ping timeout: 268 seconds] 07:10 < GitHub165> [bitcoin] laanwj closed pull request #9062: (WIP) Add -logtimemillis command line option (master...LogTimeMillisOption) https://github.com/bitcoin/bitcoin/pull/9062 07:14 -!- abpa [~abpa@2604:5500:16:6:ece9:d971:d9f4:c713] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 07:15 < GitHub70> [bitcoin] laanwj closed pull request #7061: [Wallet] add rescanblockchain RPC command (master...2015/11/wallet_rescan_rpc) https://github.com/bitcoin/bitcoin/pull/7061 07:16 < GitHub36> [bitcoin] laanwj closed pull request #9011: 0.13.2 backports (0.13...2016_10_backports_conditional_rc3) https://github.com/bitcoin/bitcoin/pull/9011 07:16 < GitHub72> [bitcoin] laanwj pushed 8 new commits to 0.13: https://github.com/bitcoin/bitcoin/compare/2e2388a5cbb9...59ce53c13cfc 07:16 < GitHub72> bitcoin/0.13 9ef3875 Matt Corallo: Add missing cs_main lock to ::GETBLOCKTXN processing... 07:16 < GitHub72> bitcoin/0.13 ce0d817 maiiz: Fix relaypriority calculation error... 07:16 < GitHub72> bitcoin/0.13 1d048b9 jnewbery: Don't return the address of a P2SH of a P2SH.... 07:17 < GitHub101> [bitcoin] laanwj closed pull request #5872: configure: BITCOIN_SUBDIR_TO_INCLUDE: Improve compatibility with paths including space and multiline cpp output (master...subdir_incl_compat) https://github.com/bitcoin/bitcoin/pull/5872 07:22 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 252 seconds] 07:26 -!- DigiByteDev [~JT2@69.167.29.212] has left #bitcoin-core-dev [] 07:26 -!- cryptapus [~cryptapus@87.254.202.194] has joined #bitcoin-core-dev 07:26 -!- cryptapus [~cryptapus@87.254.202.194] has quit [Changing host] 07:26 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 07:28 < GitHub158> [bitcoin] laanwj closed pull request #6355: Added test-before-evict discipline in Addrman, feeler connections. (master...master) https://github.com/bitcoin/bitcoin/pull/6355 07:31 < GitHub64> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f2a6e8243f2a...1107653d05a4 07:31 < GitHub64> bitcoin/master cccf73d Robert McLaughlin: trivial: fix bloom filter init to isEmpty = true... 07:31 < GitHub64> bitcoin/master 1107653 Wladimir J. van der Laan: Merge #9060: trivial: fix bloom filter init to isEmpty = true... 07:31 < GitHub15> [bitcoin] laanwj closed pull request #9060: trivial: fix bloom filter init to isEmpty = true (master...fix-bloom-filter-empty-init) https://github.com/bitcoin/bitcoin/pull/9060 07:36 < GitHub86> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1107653d05a4...bae81b83d63f 07:36 < GitHub86> bitcoin/master 159597a isle2983: [devtools] script support for managing source file copyright headers... 07:36 < GitHub86> bitcoin/master bae81b8 Wladimir J. van der Laan: Merge #8674: tools for analyzing, updating and adding copyright headers in source files... 07:36 < GitHub54> [bitcoin] laanwj closed pull request #8674: tools for analyzing, updating and adding copyright headers in source files (master...copyright-scripts) https://github.com/bitcoin/bitcoin/pull/8674 07:38 < GitHub29> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/bae81b83d63f...a4fd8dff6836 07:38 < GitHub29> bitcoin/master 86029e7 Patrick Strateman: Move CWalletDB::ReorderTransactions to CWallet 07:38 < GitHub29> bitcoin/master a4fd8df Wladimir J. van der Laan: Merge #8828: Move CWalletDB::ReorderTransactions to CWallet... 07:38 < GitHub19> [bitcoin] laanwj closed pull request #8828: Move CWalletDB::ReorderTransactions to CWallet (master...2016-09-28-cwallet-reordertransactions) https://github.com/bitcoin/bitcoin/pull/8828 07:41 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has joined #bitcoin-core-dev 07:43 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 07:43 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer] 07:45 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has quit [Read error: Connection reset by peer] 07:46 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 07:58 < BlueMatt> heh, I hadnt looked at how much better fibre is than the old relay network.... https://imgur.com/a/CpRk8 top one is fibre, note that the top line (all nodes) is equivalent to the graph for rn (bottom), but it never reaches 200ms, whereas the dot on the rn graph is about 200ms 07:58 < BlueMatt> graph is percentile -> time-to-reach-global-coverage 07:58 < BlueMatt> log scale 08:03 -!- fengling [~fengling@223.223.187.136] has joined #bitcoin-core-dev 08:03 < achow101> gmaxwell: I just fired up a 0.12.0 node and I don't see any warning about it being obsolete 08:06 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 08:07 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 08:08 -!- fengling [~fengling@223.223.187.136] has quit [Ping timeout: 268 seconds] 08:09 < instagibbs> BlueMatt, impressive 08:16 < GitHub126> [bitcoin] s-matthew-english opened pull request #9064: unify capitalization of "bitcoin address" (master...changeCaps) https://github.com/bitcoin/bitcoin/pull/9064 08:22 -!- AaronvanW [~ewout@207pc74.sshunet.nl] has joined #bitcoin-core-dev 08:22 -!- AaronvanW [~ewout@207pc74.sshunet.nl] has quit [Changing host] 08:22 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 08:28 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 08:28 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 08:32 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Ping timeout: 264 seconds] 08:33 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 244 seconds] 08:49 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 08:50 < achow101> gmaxwell: alert time? 09:04 -!- fengling [~fengling@223.223.187.136] has joined #bitcoin-core-dev 09:09 -!- fengling [~fengling@223.223.187.136] has quit [Ping timeout: 268 seconds] 09:15 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 09:24 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 09:28 -!- molz [~molly@unaffiliated/molly] has quit [Ping timeout: 268 seconds] 09:29 < gmaxwell> achow101: about to send. 09:31 < gmaxwell> achow101: it's sent. 09:43 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 09:45 -!- jtimon [~quassel@95.131.169.251] has joined #bitcoin-core-dev 09:47 < jtimon> can I run unittests individually ? 10:01 < BlueMatt> i think so 10:02 < BlueMatt> yes, you want test_bitcoin --run_test= 10:02 < BlueMatt> see-also test_bitcoin --help 10:04 -!- jtimon [~quassel@95.131.169.251] has quit [Ping timeout: 260 seconds] 10:06 -!- fengling [~fengling@223.223.187.136] has joined #bitcoin-core-dev 10:10 -!- fengling [~fengling@223.223.187.136] has quit [Ping timeout: 268 seconds] 10:12 <@wumpus> yes, this is documented in src/test/README.md 10:14 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 265 seconds] 10:16 -!- AtashiCon [arnavion@unaffiliated/arnavion] has quit [Ping timeout: 268 seconds] 10:19 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 10:19 < GitHub191> [bitcoin] laanwj opened pull request #9065: Merge `doc/unit-tests.md` into `src/test/README.md` (master...2016_11_unit_tests_doc) https://github.com/bitcoin/bitcoin/pull/9065 10:21 -!- AtashiCon [arnavion@unaffiliated/arnavion] has joined #bitcoin-core-dev 10:21 -!- e4xit_ [~e4xit@cpc92302-cmbg19-2-0-cust1369.5-4.cable.virginm.net] has joined #bitcoin-core-dev 10:24 -!- e4xit [~e4xit@cpc92302-cmbg19-2-0-cust1369.5-4.cable.virginm.net] has quit [Ping timeout: 268 seconds] 10:24 -!- e4xit_ is now known as e4xit 10:45 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds] 10:59 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 11:07 -!- fengling [~fengling@223.223.187.136] has joined #bitcoin-core-dev 11:11 -!- fengling [~fengling@223.223.187.136] has quit [Ping timeout: 268 seconds] 11:13 -!- AtashiCon [arnavion@unaffiliated/arnavion] has quit [Remote host closed the connection] 11:14 -!- JackH [~laptop@79-73-190-13.dynamic.dsl.as9105.com] has quit [Ping timeout: 256 seconds] 11:14 -!- JackH [~laptop@79-73-190-13.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev 11:24 -!- jtimon [~quassel@186.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 11:25 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds] 11:35 < michagogo> The plan is to send a final-1 alert, wait a while, send a final alert, then post the key, right? 11:35 < achow101> michagogo: yes 11:36 < michagogo> Why not just send the pre-final one, and let the rest sort itself out? :-P 11:36 < achow101> the timeframe is something like over the course of 6 months 11:36 < achow101> the final alert is the max sequence alert which locks out any possible other alert 11:36 < michagogo> achow101: right 11:37 < michagogo> i.e. once the final-1 alert is published, there can't be any other alert but the final one 11:37 < michagogo> Which is hard-coded, right? 11:37 < achow101> right 11:37 < achow101> the final is just to thoroughly kill it off 11:39 < michagogo> Well, it's only *really* necessary to send the pre-final, then publish the key a while later 11:39 < achow101> right 11:40 < michagogo> (And the final one will surely sort itself out :-P ) 11:42 -!- Chris_Stewart_5 [~Chris_Ste@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 11:43 -!- echonaut5 [~echonaut@46.101.192.134] has joined #bitcoin-core-dev 11:43 -!- echonaut [~echonaut@46.101.192.134] has quit [Read error: Connection reset by peer] 11:43 -!- TeroxiceTheRealO [~Teroxice@47.188.185.253] has joined #bitcoin-core-dev 11:43 -!- TeroxiceTheRealO [~Teroxice@47.188.185.253] has left #bitcoin-core-dev [] 11:59 -!- Chris_Stewart_5 [~Chris_Ste@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 260 seconds] 12:00 < GitHub166> [bitcoin] domob1812 opened pull request #9066: trivial: Remove variable unused after refactoring (master...unused-variable) https://github.com/bitcoin/bitcoin/pull/9066 12:08 -!- fengling [~fengling@223.223.187.136] has joined #bitcoin-core-dev 12:12 -!- fengling [~fengling@223.223.187.136] has quit [Ping timeout: 268 seconds] 12:14 -!- Chris_Stewart_5 [~Chris_Ste@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 12:20 < GitHub152> [bitcoin] UdjinM6 opened pull request #9067: Fix exit codes (master...fixExitCodesBitcoin) https://github.com/bitcoin/bitcoin/pull/9067 12:45 -!- Chris_Stewart_5 [~Chris_Ste@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 252 seconds] 12:53 < GitHub60> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a4fd8dff6836...774db92d3936 12:53 < GitHub60> bitcoin/master 32c0d6e jnewbery: Add logging to bitcoin-util-test.py... 12:53 < GitHub60> bitcoin/master 774db92 Wladimir J. van der Laan: Merge #9023: Add logging to bitcoin-util-test.py... 12:53 < GitHub131> [bitcoin] laanwj closed pull request #9023: Add logging to bitcoin-util-test.py (master...btutiltestlogging) https://github.com/bitcoin/bitcoin/pull/9023 12:54 < GitHub4> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/774db92d3936...d316cfeb6e29 12:54 < GitHub4> bitcoin/master f91afe9 Daniel Kraft: trivial: Remove variable unused after refactoring... 12:54 < GitHub4> bitcoin/master d316cfe Wladimir J. van der Laan: Merge #9066: tests: Remove variable unused after refactoring... 12:54 < GitHub164> [bitcoin] laanwj closed pull request #9066: tests: Remove variable unused after refactoring (master...unused-variable) https://github.com/bitcoin/bitcoin/pull/9066 13:01 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 13:02 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 252 seconds] 13:04 < GitHub141> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d316cfeb6e29...bc785d71855f 13:04 < GitHub141> bitcoin/master fa32619 MarcoFalke: [rpc] ParseHash: Fail when length is not 64 13:04 < GitHub141> bitcoin/master bc785d7 Wladimir J. van der Laan: Merge #9042: [rpc] ParseHash: Fail when length is not 64... 13:05 < GitHub119> [bitcoin] laanwj closed pull request #9042: [rpc] ParseHash: Fail when length is not 64 (master...Mf1611-rpcParseHash64) https://github.com/bitcoin/bitcoin/pull/9042 13:05 -!- Cheeseo [~x@unaffiliated/cheeseo] has quit [Ping timeout: 268 seconds] 13:08 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds] 13:09 -!- fengling [~fengling@223.223.187.136] has joined #bitcoin-core-dev 13:09 < GitHub97> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/bc785d71855f...c05db8348838 13:09 < GitHub97> bitcoin/master d0b01f3 Geoffrey Tsui: Explicitly pass const CChainParams& to LoadBlockIndexDB() 13:09 < GitHub97> bitcoin/master c05db83 Wladimir J. van der Laan: Merge #9013: Trivial: Explicitly pass const CChainParams& to LoadBlockIndexDB()... 13:10 < GitHub120> [bitcoin] laanwj closed pull request #9013: Trivial: Explicitly pass const CChainParams& to LoadBlockIndexDB() (master...global-params-cleanup) https://github.com/bitcoin/bitcoin/pull/9013 13:13 -!- fengling [~fengling@223.223.187.136] has quit [Ping timeout: 268 seconds] 13:22 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 13:38 < GitHub123> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c05db8348838...6a1343f73bd0 13:38 < GitHub123> bitcoin/master cab1da7 Jonas Schnelli: [Wallet] Refactor wallet/init interaction (Reaccept wtx, flush thread) 13:38 < GitHub123> bitcoin/master 6a1343f Wladimir J. van der Laan: Merge #8977: [Wallet] Refactor wallet/init interaction (Reaccept wtx, flush thread)... 13:38 < GitHub18> [bitcoin] laanwj closed pull request #8977: [Wallet] Refactor wallet/init interaction (Reaccept wtx, flush thread) (master...2016/10/fix_wallet_init) https://github.com/bitcoin/bitcoin/pull/8977 13:41 -!- roadbone [52c78229@gateway/web/freenode/ip.82.199.130.41] has joined #bitcoin-core-dev 13:54 -!- roadbone [52c78229@gateway/web/freenode/ip.82.199.130.41] has quit [Quit: Page closed] 13:56 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Quit: Gone frying asparagus or my Windows had a BSOD (how not)] 14:08 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 14:10 -!- fengling [~fengling@223.223.187.136] has joined #bitcoin-core-dev 14:11 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 14:11 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds] 14:15 -!- fengling [~fengling@223.223.187.136] has quit [Ping timeout: 268 seconds] 14:27 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 14:40 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 15:11 -!- fengling [~fengling@223.223.187.136] has joined #bitcoin-core-dev 15:14 < gmaxwell> BlueMatt: so with no longer disconnecting on invalid compact blocks, we need to reintroduce a mechenism so that we kick peers that are on a invalid-to-us forked chain. 15:14 < BlueMatt> gmaxwell: thats still there - we still dos on AcceptBlockHeader results 15:14 < gmaxwell> BlueMatt: e.g. say we have 8 peers, and all of them are feeding us invalid blocks because they're all accepting a chain which is invalid to us. We need to kick some of them so we find peers that are on a chain we accept. 15:16 -!- fengling [~fengling@223.223.187.136] has quit [Ping timeout: 268 seconds] 15:17 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 15:37 < GitHub101> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6a1343f73bd0...c9bdf9a75f9f 15:37 < GitHub101> bitcoin/master eedc461 Wladimir J. van der Laan: Merge `doc/unit-tests.md` into `src/test/README.md`... 15:37 < GitHub101> bitcoin/master c9bdf9a MarcoFalke: Merge #9065: Merge `doc/unit-tests.md` into `src/test/README.md`... 15:37 < GitHub106> [bitcoin] MarcoFalke closed pull request #9065: Merge `doc/unit-tests.md` into `src/test/README.md` (master...2016_11_unit_tests_doc) https://github.com/bitcoin/bitcoin/pull/9065 15:41 -!- Cheeseo [~x@unaffiliated/cheeseo] has joined #bitcoin-core-dev 15:57 -!- nOgAnOo [sid146237@gateway/web/irccloud.com/x-owqiljyghzvqjcqm] has quit [Ping timeout: 250 seconds] 15:58 < GitHub151> [bitcoin] jnewbery opened pull request #9069: Clean up bctest.py and bitcoin-util-test.py (master...btutiltestcleanup) https://github.com/bitcoin/bitcoin/pull/9069 16:01 -!- nOgAnOo [sid146237@gateway/web/irccloud.com/x-qzaxushlbdelzugi] has joined #bitcoin-core-dev 16:12 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Remote host closed the connection] 16:12 -!- fengling [~fengling@223.223.187.136] has joined #bitcoin-core-dev 16:17 -!- fengling [~fengling@223.223.187.136] has quit [Ping timeout: 268 seconds] 16:20 < GitHub10> [bitcoin] kazcw opened pull request #9070: Lockedpool fixes (master...lockedpool) https://github.com/bitcoin/bitcoin/pull/9070 16:58 -!- murch [~murch@p4FE3A5BE.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 17:09 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds] 17:12 -!- zooko [~user@64.134.76.1] has joined #bitcoin-core-dev 17:13 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 17:13 -!- fengling [~fengling@223.223.187.136] has joined #bitcoin-core-dev 17:18 -!- fengling [~fengling@223.223.187.136] has quit [Ping timeout: 268 seconds] 17:21 -!- waxwing [~waxwing@62.205.214.125] has quit [Ping timeout: 256 seconds] 17:22 -!- waxwing [~waxwing@62.205.214.125] has joined #bitcoin-core-dev 17:30 < GitHub32> [bitcoin] sipa opened pull request #9071: Declare wallet.h functions inline (master...walletinline) https://github.com/bitcoin/bitcoin/pull/9071 17:47 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-aeyyjswbshpotbut] has quit [Quit: Connection closed for inactivity] 17:56 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 18:06 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds] 18:11 < luke-jr> hmm, CAddrMan::Unserialize is insane slow in valgrind 18:14 -!- fengling [~fengling@223.223.187.136] has joined #bitcoin-core-dev 18:16 -!- zooko [~user@64.134.76.1] has quit [Ping timeout: 265 seconds] 18:19 -!- fengling [~fengling@223.223.187.136] has quit [Ping timeout: 268 seconds] 18:20 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 18:25 -!- zooko [~user@64.134.76.1] has joined #bitcoin-core-dev 18:30 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-ugscqcqjdbrlsjeb] has quit [Quit: Connection closed for inactivity] 18:31 -!- zooko [~user@64.134.76.1] has quit [Ping timeout: 268 seconds] 18:37 -!- zooko [~user@64.134.76.1] has joined #bitcoin-core-dev 18:53 -!- echonaut5 [~echonaut@46.101.192.134] has quit [Remote host closed the connection] 18:53 -!- echonaut [~echonaut@46.101.192.134] has joined #bitcoin-core-dev 18:58 -!- tunafizz [~tuna@c-71-207-55-31.hsd1.pa.comcast.net] has quit [Read error: Connection reset by peer] 18:59 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds] 19:03 -!- zooko [~user@64.134.76.1] has quit [Ping timeout: 260 seconds] 19:15 -!- fengling [~fengling@223.223.187.136] has joined #bitcoin-core-dev 19:16 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 19:36 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 265 seconds] 19:42 -!- jtimon [~quassel@186.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 256 seconds] 19:49 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 20:06 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds] 20:12 -!- abpa [~abpa@199.87.86.217] has joined #bitcoin-core-dev 20:22 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 20:36 -!- Arnavion [arnavion@unaffiliated/arnavion] has quit [Ping timeout: 265 seconds] 20:37 -!- Arnavion [arnavion@unaffiliated/arnavion] has joined #bitcoin-core-dev 20:40 -!- rebroad [~rebroad@1.32.106.117] has joined #bitcoin-core-dev 20:41 < rebroad> I've enabled debugging and I'm seeing POTENTIAL DEADLOCK DETECTED messages... are these bad? 20:51 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has quit [Quit: Leaving.] 20:57 -!- To7 [~theo@cpe-158-222-222-232.nyc.res.rr.com] has quit [Quit: Whatever] 21:07 -!- rebroad [~rebroad@1.32.106.117] has quit [Ping timeout: 260 seconds] 21:52 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-salhegiybjoqgylo] has joined #bitcoin-core-dev 21:59 -!- justanotheruser is now known as justanother|CHI 22:28 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 22:29 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 22:41 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 22:42 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 22:55 -!- juscamarena [~jus@47.148.176.74] has joined #bitcoin-core-dev 23:29 -!- juscamarena [~jus@47.148.176.74] has quit [Quit: Leaving] 23:36 < GitHub5> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c9bdf9a75f9f...ed0cc50afed1 23:36 < GitHub5> bitcoin/master 0fdf810 Wladimir J. van der Laan: wallet: Change default confirm target from 2 to 6... 23:36 < GitHub5> bitcoin/master ed0cc50 Pieter Wuille: Merge #9036: wallet: Change default confirm target from 2 to 6... 23:37 < GitHub44> [bitcoin] sipa closed pull request #9036: wallet: Change default confirm target from 2 to 6 (master...2016_10_txconfirmtarget) https://github.com/bitcoin/bitcoin/pull/9036