--- Day changed Mon Nov 28 2016 00:01 -!- Atomicat [~Atomicat@unaffiliated/atomicat] has joined #bitcoin-core-dev 00:04 < BlueMatt> (though its also weird we have so many ifdef branches there....) 00:18 < jonasschnelli> BlueMatt: Haven't really looked at this, but AFAIK libevent provides portable wrappers for some of those functions.. 00:18 < BlueMatt> jonasschnelli: yes, eventually we should switch everything to libevent...for now, lets just fix the segfault in a backport-able way :p 00:19 < jonasschnelli> Yes. Makes sense. 00:21 -!- arowser [~quassel@106.120.101.38] has quit [Quit: No Ping reply in 180 seconds.] 00:23 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev 00:29 < bitcoin-git> [bitcoin] fsb4000 opened pull request #9233: Fix some typos (master...master) https://github.com/bitcoin/bitcoin/pull/9233 00:32 -!- jcorgan [~jcorgan@unaffiliated/jcorgan] has left #bitcoin-core-dev [] 00:46 -!- chatter [5fd365c4@gateway/web/cgi-irc/kiwiirc.com/ip.95.211.101.196] has joined #bitcoin-core-dev 00:49 -!- chatter [5fd365c4@gateway/web/cgi-irc/kiwiirc.com/ip.95.211.101.196] has quit [Client Quit] 00:52 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving] 00:55 -!- chatter [5fd365c4@gateway/web/cgi-irc/kiwiirc.com/ip.95.211.101.196] has joined #bitcoin-core-dev 00:59 -!- cysm [cysm@unaffiliated/paracyst] has quit [Ping timeout: 260 seconds] 01:01 < wumpus> the getaddrinfo_a issue is curious, I have a nagging feeling we're just using it wrong, it's hard to believe a standard library function to be so trivially broken. Then again, in that case it makes sense to replace its usage too. 01:07 -!- laurentmt [~Thunderbi@80.215.178.68] has joined #bitcoin-core-dev 01:08 -!- laurentmt [~Thunderbi@80.215.178.68] has quit [Client Quit] 01:09 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 248 seconds] 01:11 -!- Ginnarr [~Ginnarr@unaffiliated/ginnarr] has joined #bitcoin-core-dev 01:11 -!- shangzhou [uid156782@gateway/web/irccloud.com/x-qdrhhsejtvahlkwh] has quit [Quit: Connection closed for inactivity] 01:14 -!- jannes [~jannes@178.132.211.90] has joined #bitcoin-core-dev 01:16 -!- chatter [5fd365c4@gateway/web/cgi-irc/kiwiirc.com/ip.95.211.101.196] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client] 01:17 -!- Ginnarr [~Ginnarr@unaffiliated/ginnarr] has quit [Read error: Connection reset by peer] 01:19 -!- Ginnarr [~Ginnarr@unaffiliated/ginnarr] has joined #bitcoin-core-dev 01:20 -!- Ginnarr [~Ginnarr@unaffiliated/ginnarr] has quit [Read error: Connection reset by peer] 01:26 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 01:44 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 01:45 < wumpus> BlueMatt: I'm not suggesting any specific fix, just trying to figure out what is going wrong in the first place 01:45 < wumpus> BlueMatt: using inet_pton on systems that actually have it is great, I don't know why it falsely detects its presence on windows 01:47 < wumpus> only on windows *64 bit* at that 01:52 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 01:58 < fanquake> wumpus looks like pretty much all the code in 9229 was introduced in #4421 01:58 < gribble> https://github.com/bitcoin/bitcoin/issues/4421 | Use async name resolving to improve net thread responsiveness by 4tar · Pull Request #4421 · bitcoin/bitcoin · GitHub 02:01 < wumpus> fanquake: indeed, good find 02:10 < fanquake> wumpus re 'none required', see https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Libraries.html 02:10 < fanquake> "The result of this test is cached in the ac_cv_search_function variable as ‘none required’ if function is already available" 02:23 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 260 seconds] 02:47 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 03:04 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 03:23 -!- Atomicat [~Atomicat@unaffiliated/atomicat] has quit [Ping timeout: 248 seconds] 03:36 < jl2012> where is the code for sending block to another node through p2p network? 03:52 -!- arubi [~ese168@unaffiliated/arubi] has quit [Quit: bye] 03:52 -!- arubi [~ese168@unaffiliated/arubi] has joined #bitcoin-core-dev 03:52 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Quit: Leaving.] 03:56 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 03:59 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 250 seconds] 03:59 -!- laurentmt [~Thunderbi@80.215.178.70] has joined #bitcoin-core-dev 03:59 -!- laurentmt [~Thunderbi@80.215.178.70] has quit [Client Quit] 04:09 -!- Atomicat [~Atomicat@unaffiliated/atomicat] has joined #bitcoin-core-dev 04:26 -!- arubi [~ese168@unaffiliated/arubi] has quit [Quit: bye] 04:59 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 05:36 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 05:42 -!- laurentmt [~Thunderbi@80.215.178.70] has joined #bitcoin-core-dev 05:42 -!- laurentmt [~Thunderbi@80.215.178.70] has quit [Client Quit] 05:45 < jonasschnelli> jl2012: have a look at ProcessGetData in main.cpp 05:45 < jonasschnelli> There is a if (inv.type == MSG_BLOCK) 05:53 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev 06:07 -!- Soligor [~Soligor@unaffiliated/soligor] has quit [Ping timeout: 256 seconds] 06:11 -!- To7 [~theo@cpe-158-222-222-232.nyc.res.rr.com] has quit [Quit: Whatever] 06:15 -!- Soligor [~Soligor@unaffiliated/soligor] has joined #bitcoin-core-dev 06:27 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has left #bitcoin-core-dev [] 06:38 -!- JackH [~laptop@79-73-189-171.dynamic.dsl.as9105.com] has quit [Quit: Leaving] 06:56 -!- laurentmt [~Thunderbi@80.215.178.70] has joined #bitcoin-core-dev 06:59 -!- To7 [~theo@cpe-158-222-222-232.nyc.res.rr.com] has joined #bitcoin-core-dev 07:03 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has joined #bitcoin-core-dev 07:04 -!- laurentmt [~Thunderbi@80.215.178.70] has quit [Quit: laurentmt] 07:09 < timothy> may I ask an "ethic" question? 07:16 -!- bsm1175321 is now known as bsm117532 07:37 -!- jcorgan [~jcorgan@unaffiliated/jcorgan] has joined #bitcoin-core-dev 07:40 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Ping timeout: 265 seconds] 08:01 -!- Netsplit *.net <-> *.split quits: GreenIsMyPepper, ryanofsky, thokon00, Guest82720, jeremyrubin, wolfspraul, luke-jr, zmanian, thestringpuller 08:01 -!- Netsplit over, joins: thokon00, wolfspraul 08:02 -!- Netsplit over, joins: ryanofsky 08:02 -!- jeremyrubin [~jeremyrub@18.9.64.18] has joined #bitcoin-core-dev 08:02 -!- thestringpuller [~stevie@52.3.128.9] has joined #bitcoin-core-dev 08:02 -!- Netsplit over, joins: luke-jr 08:02 -!- Netsplit over, joins: GreenIsMyPepper 08:02 -!- thestringpuller is now known as Guest3413 08:06 -!- zmanian [sid113594@gateway/web/irccloud.com/x-qfkzzptjkqpxvgnu] has joined #bitcoin-core-dev 08:10 -!- windsok [~windsok@45.63.59.8] has quit [Ping timeout: 252 seconds] 08:11 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 08:13 -!- windsok [~windsok@45.63.59.8] has joined #bitcoin-core-dev 08:17 < bitcoin-git> [bitcoin] laanwj opened pull request #9234: torcontrol: Explicitly request RSA1024 private key (master...2016_11_torcontrol_key_ttpe) https://github.com/bitcoin/bitcoin/pull/9234 08:21 -!- ChillazZ [~ChillazZ@194.97.152.20] has joined #bitcoin-core-dev 08:22 -!- ChillazZ is now known as Guest13131 08:25 -!- k0ng [~k0ngo@95.215.44.99] has joined #bitcoin-core-dev 08:31 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 245 seconds] 08:43 -!- laurentmt [~Thunderbi@80.215.178.70] has joined #bitcoin-core-dev 08:44 -!- laurentmt [~Thunderbi@80.215.178.70] has quit [Client Quit] 09:06 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds] 09:09 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 09:10 -!- Taek [~quassel@2001:41d0:1:472e::] has joined #bitcoin-core-dev 09:19 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 09:33 -!- droark [~droark@c-24-22-123-27.hsd1.or.comcast.net] has joined #bitcoin-core-dev 10:07 -!- laurentmt [~Thunderbi@80.215.178.70] has joined #bitcoin-core-dev 10:09 -!- Guest3413 is now known as thestringpuller 10:10 -!- thestringpuller [~stevie@52.3.128.9] has quit [Changing host] 10:10 -!- thestringpuller [~stevie@unaffiliated/thestringpuller] has joined #bitcoin-core-dev 10:11 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 10:12 -!- laurentmt [~Thunderbi@80.215.178.70] has quit [Quit: laurentmt] 10:30 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 10:32 -!- molz [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 10:51 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds] 10:52 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 10:55 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 252 seconds] 10:58 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 11:00 -!- molz [~molly@unaffiliated/molly] has quit [Ping timeout: 268 seconds] 11:10 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 12:19 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 246 seconds] 13:29 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev 13:35 -!- protomar [~protomar@91.214.169.69] has joined #bitcoin-core-dev 13:37 -!- murchandamus [~murchghos@ghostdub.de] has quit [Remote host closed the connection] 13:48 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-lemglpizlpkuwjhe] has quit [Quit: Connection closed for inactivity] 13:49 -!- murchandamus [~murchghos@ghostdub.de] has joined #bitcoin-core-dev 13:52 -!- murchandamus [~murchghos@ghostdub.de] has quit [Remote host closed the connection] 14:23 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 14:24 -!- protomar [~protomar@91.214.169.69] has quit [Quit: Leaving] 14:31 -!- jannes [~jannes@178.132.211.90] has quit [Quit: Leaving] 14:57 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has left #bitcoin-core-dev [] 15:05 -!- aalex__ [~aalex@64.187.177.58] has quit [Ping timeout: 256 seconds] 15:52 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 15:59 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 16:18 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 16:44 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev 16:48 -!- owowo [ovovo@gateway/vpn/mullvad/x-avkjuayihkpazwzj] has quit [Ping timeout: 244 seconds] 16:50 -!- owowo [ovovo@gateway/vpn/mullvad/x-fotlkxptixnlfstj] has joined #bitcoin-core-dev 16:50 -!- owowo [ovovo@gateway/vpn/mullvad/x-fotlkxptixnlfstj] has quit [Changing host] 16:50 -!- owowo [ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 16:50 -!- owowo [ovovo@unaffiliated/ovovo] has quit [Changing host] 16:50 -!- owowo [ovovo@gateway/vpn/mullvad/x-fotlkxptixnlfstj] has joined #bitcoin-core-dev 17:02 -!- mrkent [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev 17:02 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-timkokhnehrtczye] has quit [Quit: Connection closed for inactivity] 17:45 -!- CubicEarth [~cubiceart@2002:329f:7e15:0:109:72d4:6c6c:4b08] has joined #bitcoin-core-dev 17:46 -!- CubicEarth [~cubiceart@2002:329f:7e15:0:109:72d4:6c6c:4b08] has quit [Remote host closed the connection] 17:49 < bitcoin-git> [bitcoin] kallewoof opened pull request #9235: Refactor: Removes all uses of `using namespace` in all source files. (master...no-using-ns2) https://github.com/bitcoin/bitcoin/pull/9235 17:53 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 248 seconds] 17:55 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 17:56 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 18:00 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-xnqfwqxbdcsbtjnn] has joined #bitcoin-core-dev 18:00 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 18:06 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 18:10 -!- 14WAAM8DN [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 18:15 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 18:20 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Ping timeout: 258 seconds] 18:22 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev 18:54 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Remote host closed the connection] 19:37 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Ping timeout: 248 seconds] 19:39 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev 19:44 -!- abpa [~abpa@2602:306:b837:dbf0:4948:52ce:f9ab:8b60] has joined #bitcoin-core-dev 19:47 -!- cysm [cysm@unaffiliated/paracyst] has joined #bitcoin-core-dev 20:40 -!- 14WAAM8DN is now known as CubicEarth 20:46 -!- abpa [~abpa@2602:306:b837:dbf0:4948:52ce:f9ab:8b60] has quit [Ping timeout: 240 seconds] 21:17 < achow101> what happened to createwitnessaddress? 21:23 -!- jtimon [~quassel@186.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 265 seconds] 21:36 < btcdrak> achow101: it was removed 21:39 < achow101> I gathered that much. I don't quite understand why it was removed. Couldn't it just have been modified to check for address validity too? 21:41 < sipa> achow101: it has no access to the wallet, so it would at least need an api change 21:41 < sipa> where you pass it the full script, pubkeys, ... 21:43 < achow101> oh. i see 21:46 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has quit [Quit: Leaving.] 22:10 -!- aalex__ [~aalex@64.187.177.58] has joined #bitcoin-core-dev 22:17 -!- aalex__ [~aalex@64.187.177.58] has quit [Ping timeout: 244 seconds] 22:18 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 22:19 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 22:27 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-iasbnfjxkmzofwwm] has joined #bitcoin-core-dev 22:31 -!- dermoth_ [~thomas@dial-216-221-44-179.mtl.aei.ca] has joined #bitcoin-core-dev 22:32 -!- dermoth [~thomas@dsl-216-221-51-181.mtl.aei.ca] has quit [Disconnected by services] 22:32 -!- dermoth_ is now known as dermoth 22:35 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 22:36 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 23:00 -!- dermoth [~thomas@dial-216-221-44-179.mtl.aei.ca] has quit [Read error: Connection reset by peer] 23:03 -!- dermoth [~thomas@dial-216-221-44-179.mtl.aei.ca] has joined #bitcoin-core-dev 23:10 -!- aalex__ [~aalex@64.187.177.58] has joined #bitcoin-core-dev 23:19 < fanquake> Finally finished a deterministic fuzzing cycle with 9172. Happy to share the outputs with anyone who'd like a look. 23:25 -!- crudel [crudel@gateway/shell/fnordserver.eu/x-amffvsnnapeceuas] has quit [Remote host closed the connection] 23:31 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 23:32 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 23:37 -!- Atomicat_ [~Atomicat@unaffiliated/atomicat] has joined #bitcoin-core-dev 23:39 -!- Atomicat [~Atomicat@unaffiliated/atomicat] has quit [Read error: Connection reset by peer] 23:39 -!- Atomicat_ is now known as Atomicat 23:43 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Ping timeout: 265 seconds] 23:48 -!- aalex__ [~aalex@64.187.177.58] has quit [Ping timeout: 252 seconds]