--- Day changed Mon Dec 12 2016 00:03 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 00:03 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:05 -!- JackH [~laptop@79-73-186-159.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev 00:08 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 250 seconds] 00:12 < bitcoin-git> [bitcoin] gmaxwell opened pull request #9326: Fix wallet/test/crypto_tests.cpp for OpenSSL 1.1 API. (master...openssl_api11) https://github.com/bitcoin/bitcoin/pull/9326 00:13 < jonasschnelli> ^ taged 00:23 -!- CubicEarth [~cubiceart@75.104.65.104] has joined #bitcoin-core-dev 00:25 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:27 -!- CubicEarth [~cubiceart@75.104.65.104] has quit [Read error: Connection reset by peer] 00:42 -!- CubicEarth [~cubiceart@75.104.65.104] has joined #bitcoin-core-dev 01:16 -!- windsok [~windsok@45.63.59.8] has quit [Ping timeout: 245 seconds] 01:20 -!- CubicEarth [~cubiceart@75.104.65.104] has quit [Read error: Connection reset by peer] 01:27 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-jmntxozuayuobkqa] has quit [Quit: Connection closed for inactivity] 01:51 -!- windsok [~windsok@45.63.59.8] has joined #bitcoin-core-dev 02:14 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:18 -!- droark [~droark@c-24-22-123-27.hsd1.or.comcast.net] has quit [Ping timeout: 268 seconds] 02:35 -!- CubicEarth [~cubiceart@63.115.34.165] has joined #bitcoin-core-dev 02:43 -!- shesek [~shesek@bzq-84-110-57-94.red.bezeqint.net] has quit [Ping timeout: 260 seconds] 02:46 -!- laurentmt [~Thunderbi@80.215.178.205] has joined #bitcoin-core-dev 02:47 -!- laurentmt [~Thunderbi@80.215.178.205] has quit [Client Quit] 02:57 -!- shesek [~shesek@bzq-84-110-53-9.cablep.bezeqint.net] has joined #bitcoin-core-dev 03:07 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Ping timeout: 248 seconds] 03:14 -!- warren [~warren@fedora/wombat/warren] has quit [Ping timeout: 265 seconds] 03:15 -!- adam3us [~adam3us@unaffiliated/adam3us] has quit [Ping timeout: 260 seconds] 03:16 -!- warren [~warren@fedora/wombat/warren] has joined #bitcoin-core-dev 03:18 -!- adam3us [~adam3us@unaffiliated/adam3us] has joined #bitcoin-core-dev 03:19 -!- laurentmt [~Thunderbi@80.215.178.205] has joined #bitcoin-core-dev 03:20 -!- laurentmt [~Thunderbi@80.215.178.205] has quit [Client Quit] 03:23 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 03:45 -!- Cheeseo [~x@unaffiliated/cheeseo] has quit [Read error: Connection reset by peer] 04:04 -!- pirate0x15 [d5583c90@gateway/web/freenode/ip.213.88.60.144] has joined #bitcoin-core-dev 04:04 -!- pirate0x15 [d5583c90@gateway/web/freenode/ip.213.88.60.144] has left #bitcoin-core-dev [] 04:05 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 04:06 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Client Quit] 04:06 -!- CubicEarth [~cubiceart@63.115.34.165] has quit [Remote host closed the connection] 04:07 -!- CubicEarth [~cubiceart@63.115.34.165] has joined #bitcoin-core-dev 04:11 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer] 04:12 -!- CubicEarth [~cubiceart@63.115.34.165] has quit [Ping timeout: 268 seconds] 04:14 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 04:22 -!- AaronvanW [~ewout@207pc74.sshunet.nl] has joined #bitcoin-core-dev 04:22 -!- AaronvanW [~ewout@207pc74.sshunet.nl] has quit [Changing host] 04:22 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:25 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 04:28 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 264 seconds] 04:29 -!- wvr [~wvr@0.red-88-15-41.dynamicip.rima-tde.net] has quit [] 05:13 -!- CubicEarth [~cubiceart@63.115.34.165] has joined #bitcoin-core-dev 05:29 -!- CubicEarth [~cubiceart@63.115.34.165] has quit [Remote host closed the connection] 05:39 -!- laurentmt [~Thunderbi@80.215.178.205] has joined #bitcoin-core-dev 05:41 -!- laurentmt [~Thunderbi@80.215.178.205] has quit [Read error: Connection reset by peer] 05:50 -!- mturquette [sid66043@gateway/web/irccloud.com/x-dnnwcuajgagjsawi] has quit [] 05:50 -!- mturquette [sid66043@gateway/web/irccloud.com/x-mpgthzcsfhvtqwio] has joined #bitcoin-core-dev 06:16 -!- MykelSIlver [~MykelSIlv@192-228-145-85.ftth.glasoperator.nl] has quit [Ping timeout: 260 seconds] 06:17 -!- nOgAnOo [sid146237@gateway/web/irccloud.com/x-bdekthemjvlvcjsu] has quit [] 06:17 -!- nOgAnOo [sid146237@gateway/web/irccloud.com/x-wlwsfqksybaxwxyk] has joined #bitcoin-core-dev 06:18 -!- da2ce7 [~da2ce7@opentransactions/dev/da2ce7] has quit [Ping timeout: 260 seconds] 06:18 -!- MykelSIlver [~MykelSIlv@192-228-145-85.ftth.glasoperator.nl] has joined #bitcoin-core-dev 06:18 -!- _mn3monic [~guido@176.9.68.68] has quit [Ping timeout: 260 seconds] 06:23 -!- da2ce7 [~da2ce7@opentransactions/dev/da2ce7] has joined #bitcoin-core-dev 06:33 -!- goregrind [~goregrind@unaffiliated/goregrind] has joined #bitcoin-core-dev 06:35 -!- laurentmt [~Thunderbi@80.215.178.205] has joined #bitcoin-core-dev 06:35 -!- echonaut [~echonaut@46.101.192.134] has quit [Read error: Connection reset by peer] 06:35 -!- laurentmt [~Thunderbi@80.215.178.205] has quit [Client Quit] 06:35 -!- echonaut10 [~echonaut@46.101.192.134] has joined #bitcoin-core-dev 06:44 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #9329: [Qt] Console: allow empty arguments (master...2016/12/fix_qt_empty_args) https://github.com/bitcoin/bitcoin/pull/9329 06:45 -!- JackH_ [~laptop@79-73-191-181.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev 06:46 -!- harrymm [~wayne@104.237.91.97] has quit [Remote host closed the connection] 06:47 -!- JackH [~laptop@79-73-186-159.dynamic.dsl.as9105.com] has quit [Ping timeout: 258 seconds] 06:54 -!- laurentmt [~Thunderbi@80.215.178.205] has joined #bitcoin-core-dev 06:55 -!- laurentmt [~Thunderbi@80.215.178.205] has quit [Client Quit] 06:55 < jonasschnelli> Can someone confirm that ./src/qt/test/test_bitcoin-qt ends with an malloc/free issue? "pointer being freed was not allocated"? 06:56 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 06:57 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 07:01 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #9330: [Qt] Console: add security warning (master...2016/12/qt_add_sec) https://github.com/bitcoin/bitcoin/pull/9330 07:02 -!- harrymm [~wayne@45.56.152.27] has joined #bitcoin-core-dev 07:02 -!- cryptapus_afk is now known as cryptapus 07:04 < ryanofsky_> src/qt/test/test_bitcoin-qt seems to be working for me, don't see freed pointer message (at 76fcd9d) 07:04 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Quit: conversation terminated!] 07:05 -!- CubicEarth [~cubiceart@75.104.65.153] has joined #bitcoin-core-dev 07:06 -!- cryptapus [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev 07:06 -!- cryptapus [~cryptapus@jupiter.osmus.org] has quit [Changing host] 07:06 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 07:08 < jonasschnelli> ryanofsky_: current master? 07:16 -!- CubicEarth [~cubiceart@75.104.65.153] has quit [] 07:31 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has joined #bitcoin-core-dev 07:38 -!- jtimon [~quassel@77.224.94.35] has joined #bitcoin-core-dev 07:38 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-hljdvudwsfpdpgdq] has quit [Quit: Connection closed for inactivity] 07:40 < jtimon> mmhmm, shouldn't https://github.com/bitcoin/bitcoin/blob/master/src/serialize.h#L259 use std::numeric_limits::max() instead of std::numeric_limits::max() ? 07:41 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 07:48 < bitcoin-git> [bitcoin] ryanofsky opened pull request #9331: [qa] Add test for rescan feature of wallet key import RPCs (master...pr/test-import-rescan) https://github.com/bitcoin/bitcoin/pull/9331 07:50 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 258 seconds] 07:52 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 07:53 < bitcoin-git> [bitcoin] ryanofsky opened pull request #9332: Let wallet importmulti RPC accept labels for standard scriptPubKeys (on top of #9331) (master...pr/script-label) https://github.com/bitcoin/bitcoin/pull/9332 08:01 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 08:18 -!- _mn3monic [~guido@176.9.68.68] has joined #bitcoin-core-dev 08:20 < afk11> Hi all, anyone with a synced testnet node able to help me? Looking for the hex of a block with testnet transactions, every API I can find returns base-data only (and my node is down) :/ 000000005ded58feee127958d6619f8fedb2e67a7524067b474449a5e908c2fa is one, just need output of `getblock [hash] false` 08:31 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-leeroqkafbzszchg] has joined #bitcoin-core-dev 08:42 < bitcoin-git> [bitcoin] ryanofsky opened pull request #9333: [trivial] Add comment documenting CWalletTx::mapValue (master...pr/comment-mapvalue) https://github.com/bitcoin/bitcoin/pull/9333 08:43 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-krlodiviuodonbpv] has joined #bitcoin-core-dev 08:44 -!- Atomicat_ [~Atomicat@unaffiliated/atomicat] has joined #bitcoin-core-dev 08:46 -!- Atomicat [~Atomicat@unaffiliated/atomicat] has quit [Read error: Connection reset by peer] 08:47 -!- Atomicat_ is now known as Atomicat 08:53 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 09:02 -!- Anduck [~Anduck@unaffiliated/anduck] has quit [Ping timeout: 246 seconds] 09:03 -!- Anduck [~Anduck@unaffiliated/anduck] has joined #bitcoin-core-dev 09:13 -!- laptop__ [~laptop@79-73-185-34.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev 09:15 -!- JackH_ [~laptop@79-73-191-181.dynamic.dsl.as9105.com] has quit [Ping timeout: 250 seconds] 09:34 -!- bsm117532 [~mcelrath@38.121.165.30] has quit [Ping timeout: 256 seconds] 09:37 -!- timothy [~quassel@archlinux/trusteduser/DrizztBSD] has quit [Ping timeout: 260 seconds] 09:37 -!- bsm117532 [~mcelrath@38.121.165.60] has joined #bitcoin-core-dev 09:38 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 09:43 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 250 seconds] 09:45 < morcos> jonasschnelli: where did we leave things on #8501? I was under the impression that you agreed it made sense to have a bit more flexible framework to support multiple timescales? 09:45 < gribble> https://github.com/bitcoin/bitcoin/issues/8501 | Add mempool statistics collector by jonasschnelli · Pull Request #8501 · bitcoin/bitcoin · GitHub 09:47 -!- JackH_ [~laptop@79-73-185-145.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev 09:48 -!- bsm117532 [~mcelrath@38.121.165.60] has quit [Read error: Connection reset by peer] 09:48 -!- bsm117532 [~mcelrath@38.121.165.60] has joined #bitcoin-core-dev 09:49 -!- laptop__ [~laptop@79-73-185-34.dynamic.dsl.as9105.com] has quit [Ping timeout: 265 seconds] 09:52 -!- timothy [~quassel@archlinux/trusteduser/DrizztBSD] has joined #bitcoin-core-dev 09:53 -!- bsm117532 [~mcelrath@38.121.165.60] has quit [Ping timeout: 258 seconds] 09:53 < instagibbs> morcos, leaving the coin selection stuff alone, sorry for all the rebasing :) 09:57 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 09:58 -!- laurentmt [~Thunderbi@80.215.178.0] has joined #bitcoin-core-dev 09:58 -!- laurentmt [~Thunderbi@80.215.178.0] has quit [Client Quit] 10:14 -!- bsm117532 [~mcelrath@38.121.165.30] has joined #bitcoin-core-dev 10:23 -!- jtimon [~quassel@77.224.94.35] has quit [Ping timeout: 250 seconds] 10:53 < btcdrak> https://github.com/bitcoin-core/bitcoincore.org/pull/289 10:59 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 10:59 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 10:59 < gmaxwell> oh jesus, some sufficiently old openssl doesn't have EVP_MD_CTX_new/EVP_MD_CTX_free 11:02 < sipa> add it to configure, and ifdef our own definition in? 11:02 < gmaxwell> I'm just going to ifdef around a version check and use heap/stack depending on the version. 11:12 < bitcoin-git> [bitcoin] sipa opened pull request #9334: Update to latest libsecp256k1 (master...secp) https://github.com/bitcoin/bitcoin/pull/9334 11:12 -!- jtimon [~quassel@77.224.94.35] has joined #bitcoin-core-dev 11:24 -!- juscamarena [~justin@47.148.176.74] has quit [Ping timeout: 260 seconds] 11:55 -!- juscamarena [~justin@47.148.176.74] has joined #bitcoin-core-dev 11:55 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 12:11 < gmaxwell> #9290 and #9302 want to be merged. Also, does someone dislike #9236? it's been ready for merge for almost two weeks. 12:11 < gribble> https://github.com/bitcoin/bitcoin/issues/9290 | Make RelayWalletTransaction attempt to AcceptToMemoryPool. by gmaxwell · Pull Request #9290 · bitcoin/bitcoin · GitHub 12:11 < gribble> https://github.com/bitcoin/bitcoin/issues/9302 | Return txid even if ATMP fails for new transaction by sipa · Pull Request #9302 · bitcoin/bitcoin · GitHub 12:11 < gribble> https://github.com/bitcoin/bitcoin/issues/9236 | Fix races for strMiscWarning and fLargeWork*Found, make QT runawayException use GetWarnings by gmaxwell · Pull Request #9236 · bitcoin/bitcoin · GitHub 12:53 -!- wvr [~wvr@0.red-88-15-41.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 12:59 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Remote host closed the connection] 13:01 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev 13:07 < bitcoin-git> [bitcoin] richardkiss opened pull request #9335: Fix spelling. (master...feature/typo) https://github.com/bitcoin/bitcoin/pull/9335 13:10 -!- cryptapus is now known as cryptapus_afk 13:11 < bitcoin-git> [bitcoin] richardkiss opened pull request #9336: Change SIG_NULLFAIL => NULLFAIL. (master...feature/unify_nullfail) https://github.com/bitcoin/bitcoin/pull/9336 13:47 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev 13:52 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 13:55 -!- grubles_ [~grubles@unaffiliated/grubles] has quit [Quit: brb] 13:57 < bitcoin-git> [bitcoin] richardkiss closed pull request #9336: Change SIG_NULLFAIL => NULLFAIL. (master...feature/unify_nullfail) https://github.com/bitcoin/bitcoin/pull/9336 13:59 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving] 13:59 -!- grubles_ [~grubles@unaffiliated/grubles] has joined #bitcoin-core-dev 14:02 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 14:17 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has left #bitcoin-core-dev [] 14:18 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Remote host closed the connection] 14:18 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-leeroqkafbzszchg] has quit [Quit: Connection closed for inactivity] 14:27 -!- brg444_ [~bergealex@qubcpq1531w-lp130-02-65-92-226-222.dsl.bell.ca] has joined #bitcoin-core-dev 14:31 -!- brg444_ [~bergealex@qubcpq1531w-lp130-02-65-92-226-222.dsl.bell.ca] has quit [Client Quit] 14:33 -!- brg444 [~bergealex@qubcpq1531w-lp130-02-65-92-226-222.dsl.bell.ca] has joined #bitcoin-core-dev 14:58 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 15:16 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Read error: Connection reset by peer] 15:16 -!- abpa_ [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 15:21 -!- brg444 [~bergealex@qubcpq1531w-lp130-02-65-92-226-222.dsl.bell.ca] has quit [Quit: brg444] 15:22 -!- JackH_ [~laptop@79-73-185-145.dynamic.dsl.as9105.com] has quit [Quit: Leaving] 15:23 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 15:37 -!- jtimon [~quassel@77.224.94.35] has quit [Ping timeout: 264 seconds] 15:40 -!- brg444 [~bergealex@qubcpq1531w-lp130-02-65-92-226-222.dsl.bell.ca] has joined #bitcoin-core-dev 15:45 -!- jtimon [~quassel@77.224.94.35] has joined #bitcoin-core-dev 16:20 -!- alpalp [~allen@cpe-24-27-58-209.austin.res.rr.com] has joined #bitcoin-core-dev 16:20 -!- alpalp [~allen@cpe-24-27-58-209.austin.res.rr.com] has quit [Changing host] 16:20 -!- alpalp [~allen@unaffiliated/alpalp] has joined #bitcoin-core-dev 16:27 -!- alpalp [~allen@unaffiliated/alpalp] has quit [Ping timeout: 248 seconds] 16:51 -!- alpalp [~allen@unaffiliated/alpalp] has joined #bitcoin-core-dev 16:59 -!- alpalp [~allen@unaffiliated/alpalp] has quit [Ping timeout: 258 seconds] 17:01 -!- alpalp [~allen@unaffiliated/alpalp] has joined #bitcoin-core-dev 17:17 -!- alpalp [~allen@unaffiliated/alpalp] has quit [Ping timeout: 256 seconds] 17:27 -!- alpalp [~allen@unaffiliated/alpalp] has joined #bitcoin-core-dev 17:31 -!- crescendo [~mozart@unaffiliated/crescendo] has quit [Ping timeout: 246 seconds] 17:38 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Remote host closed the connection] 17:39 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev 17:45 -!- abpa_ [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 17:48 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 17:58 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 18:00 < Lightsword> think it would be reasonable to remove this TestBlockValidity check in 0.13 for miners? https://github.com/bitcoin/bitcoin/blob/0.13/src/miner.cpp#L193-L195 18:01 < Lightsword> I would assume if there were any issues there someone would have hit them by now 18:07 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-krlodiviuodonbpv] has quit [Quit: Connection closed for inactivity] 18:16 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-qiamnxvpqmwdkehg] has joined #bitcoin-core-dev 18:31 -!- jtimon [~quassel@77.224.94.35] has quit [Ping timeout: 252 seconds] 19:09 -!- MykelSIlver [~MykelSIlv@192-228-145-85.ftth.glasoperator.nl] has quit [Quit: -a- Connection Timed Out] 19:09 -!- MykelSIlver [~MykelSIlv@192-228-145-85.ftth.glasoperator.nl] has joined #bitcoin-core-dev 19:11 -!- abpa [~abpa@2602:306:b837:dbf0:c4fd:4c1f:ab3:1735] has joined #bitcoin-core-dev 19:20 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 19:21 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 19:25 < morcos> Lightsword: For what purpose? Do we think its important to have block creation happen 100ms faster? I'd be hesitant to do it unless someone could make a good argument that it's really beneficial to save the time 19:26 < gmaxwell> morcos: I think it could move into the background with basically no hit on reliablity... and then get rid of the 100ms concern. 19:26 < Lightsword> morcos, to speed up GBT and potentially reduce the need for validationless mining 19:26 < morcos> I suppose after a tip change, it makes sense to get a new block 100ms faster... I wonder if we could just skip it in that case... 19:26 < Lightsword> gmaxwell, I think we couldn’t do that due to cs_main locks 19:27 < morcos> gmaxwell: i agree. we could move it to the background... but i think you just want to be a tad careful that we don't view that as free, since it still locks cs_main for 100ms 19:28 < Lightsword> I’m pretty sure the cs_main lock itself is the problem 19:29 < gmaxwell> the lock is irrelevant from the perspective of time to response for the response itself. 19:30 < morcos> anyway... this late in the game i'd view that as a bit aggressive for 0.14... 19:30 < morcos> (any of it) 19:31 < gmaxwell> Lightsword: in 0.12 we made a number of fairly agressive changes to how block construction trusts the integrity of the mempool, with the argument that the test would catch any corruption that happened. 19:31 < gmaxwell> We've had mempool corruption bugs in the past. So totally running without ever having a test seems risky-- turns random mempool optimizations into possible quiet consensus bugs. 19:31 < Lightsword> well…we haven’t had anyone get a failure of TBV yet right? 19:32 < gmaxwell> No but we had failures of the internal mempool tests that we've since removed. 19:32 < gmaxwell> In any case, what I'd prefer to do is just get the TBV out of the critical path rather than never run it. 19:33 < gmaxwell> and it would also be fine as far as I'm concerned if it ran less often. 19:36 -!- alpalp [~allen@unaffiliated/alpalp] has quit [Ping timeout: 258 seconds] 19:38 < Lightsword> gmaxwell, can we get the cs_main lock out of the critical path as well? 19:40 < Lightsword> main thing I’m noticing is a huge GBT call time variance reduction when I removed these 4 lines https://github.com/bitcoin/bitcoin/blob/0.13/src/miner.cpp#L192-L195 19:41 < Lightsword> I removed the TBV call first without removing CValidationState state; but that had minimal effect, removing CValidationState state; however seems to have made a pretty decent difference 19:41 < gmaxwell> how much time are you talking about? 19:42 < Lightsword> it seems vary a lot unless I remove CValidationState state; 19:42 < Lightsword> over 100ms gbt call time differences 19:42 < Lightsword> just between successive calls 19:42 < Lightsword> vs close to 20 with it removed 19:51 < morcos> I'm not sure what you mean about CValidationState, the only line doing anything is the TBV, but yes I think that sounds about right.... CreateNewBlock = 20ms + 100ms for TBV where there is a lot of variance in the 100ms part 19:52 < Lightsword> hmm, maybe I’m mixing that up 19:52 < Lightsword> anyways direct comparing def is much more consistant 19:53 < Lightsword> without TBV 20:13 -!- Atomicat [~Atomicat@unaffiliated/atomicat] has quit [Read error: Connection reset by peer] 20:13 -!- Atomicat [~Atomicat@unaffiliated/atomicat] has joined #bitcoin-core-dev 20:41 < bitcoin-git> [bitcoin] rebroad opened pull request #9338: Stripe downloads to reduce stallers occuring (master...ReduceStalling) https://github.com/bitcoin/bitcoin/pull/9338 20:45 -!- brg444 [~bergealex@qubcpq1531w-lp130-02-65-92-226-222.dsl.bell.ca] has quit [Quit: brg444] 20:51 -!- warren [~warren@fedora/wombat/warren] has quit [Quit: QUIT] 20:51 -!- adam3us [~adam3us@unaffiliated/adam3us] has quit [Quit: QUIT] 21:54 -!- baldur [~baldur@pool-100-2-139-91.nycmny.fios.verizon.net] has quit [Ping timeout: 250 seconds] 22:06 -!- baldur [~baldur@pool-100-2-139-91.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 22:06 -!- windsok [~windsok@45.63.59.8] has quit [Ping timeout: 264 seconds] 22:07 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 264 seconds] 22:20 -!- windsok [~windsok@45.63.59.8] has joined #bitcoin-core-dev 22:42 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 22:43 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 22:48 -!- To7 [~theo@cpe-158-222-222-232.nyc.res.rr.com] has quit [Quit: Whatever] 22:49 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-yodmonhptjwiatto] has joined #bitcoin-core-dev 23:00 -!- dermoth [~thomas@dsl-66-36-158-238.mtl.aei.ca] has quit [Read error: Connection reset by peer] 23:03 -!- dermoth [~thomas@dsl-66-36-158-238.mtl.aei.ca] has joined #bitcoin-core-dev 23:11 -!- moli [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer] 23:12 -!- moli [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 23:53 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 23:54 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 23:59 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 268 seconds]