--- Day changed Fri Dec 30 2016 00:08 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 00:30 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:36 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:39 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 258 seconds] 00:48 < jonasschnelli> Right? Finding the active headers tip with (only) getchaintips is not possible right now? 00:48 < jonasschnelli> Assume we have a split and two headers-only chains (with the same height), you can't see which headers chain has more work? 00:49 -!- Elysus [~Elysus@unaffiliated/elysus] has quit [Ping timeout: 268 seconds] 01:08 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:21 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-swkyhukkvunondym] has joined #bitcoin-core-dev 01:26 -!- jannes [~jannes@178.132.211.90] has joined #bitcoin-core-dev 01:36 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-xzofqyomvgswafbq] has joined #bitcoin-core-dev 01:41 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #9446: SetMerkleBranch: remove unused code, remove cs_main lock requirement (master...2016/12/merklebranch) https://github.com/bitcoin/bitcoin/pull/9446 02:01 -!- AaronvanW [~ewout@207pc74.sshunet.nl] has joined #bitcoin-core-dev 02:02 -!- AaronvanW [~ewout@207pc74.sshunet.nl] has quit [Changing host] 02:02 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:02 -!- rebroad_ [~rebroad@171.4.233.114] has quit [Ping timeout: 264 seconds] 02:45 -!- harrymm [~wayne@104.222.140.73] has joined #bitcoin-core-dev 02:56 -!- cannon-c [ccc23f04@gateway/web/freenode/ip.204.194.63.4] has quit [Quit: Page closed] 03:28 -!- harrymm [~wayne@104.222.140.73] has quit [Ping timeout: 246 seconds] 03:48 -!- harrymm [~wayne@104.237.91.33] has joined #bitcoin-core-dev 04:18 -!- cjamthagen [~user@h-88-153.a230.priv.bahnhof.se] has joined #bitcoin-core-dev 04:40 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [] 04:43 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 264 seconds] 04:47 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 04:52 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 04:53 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 04:57 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 258 seconds] 05:17 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 05:20 -!- Elysus [~Elysus@unaffiliated/elysus] has joined #bitcoin-core-dev 05:39 -!- LeMiner [LeMiner@unaffiliated/leminer] has quit [Read error: Connection reset by peer] 05:46 -!- LeMiner [LeMiner@unaffiliated/leminer] has joined #bitcoin-core-dev 05:55 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 06:54 -!- PaulCapestany [~PaulCapes@2604:5500:17:2ea:d097:22a8:7fcd:f6ff] has quit [Quit: .] 06:55 -!- PaulCapestany [~PaulCapes@2604:5500:17:2ea:d097:22a8:7fcd:f6ff] has joined #bitcoin-core-dev 07:15 -!- TomMc [~tom@unaffiliated/tommc] has joined #bitcoin-core-dev 07:16 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has quit [Remote host closed the connection] 07:22 -!- e4xit [~e4xit@cpc1-cmbg20-2-0-cust188.5-4.cable.virginm.net] has quit [Ping timeout: 248 seconds] 07:24 -!- e4xit [~e4xit@cpc1-cmbg20-2-0-cust188.5-4.cable.virginm.net] has joined #bitcoin-core-dev 07:34 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 07:35 -!- comakut [~comakut@92.187.228.209] has joined #bitcoin-core-dev 07:35 < bitcoin-git> [bitcoin] morcos opened pull request #9447: Allow 2 simultaneous block downloads (master...doubledownload) https://github.com/bitcoin/bitcoin/pull/9447 07:36 -!- comakut [~comakut@92.187.228.209] has left #bitcoin-core-dev [] 07:40 -!- To7 [~theo@cpe-158-222-222-232.nyc.res.rr.com] has quit [Quit: Whatever] 07:41 -!- PaulCapestany [~PaulCapes@2604:5500:17:2ea:d097:22a8:7fcd:f6ff] has quit [Quit: .] 07:41 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds] 07:42 -!- TomMc [~tom@unaffiliated/tommc] has quit [Ping timeout: 252 seconds] 07:43 -!- PaulCapestany [~PaulCapes@2604:5500:17:2ea:d097:22a8:7fcd:f6ff] has joined #bitcoin-core-dev 07:46 -!- TomMc [~tom@unaffiliated/tommc] has joined #bitcoin-core-dev 07:49 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #7522: Bugfix: Only use git for build info if the repository is actually the right one (master...bugfix_gitdir) https://github.com/bitcoin/bitcoin/pull/7522 08:17 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 09:21 -!- Elysus1 [~Elysus@host86-187-161-229.range86-187.btcentralplus.com] has joined #bitcoin-core-dev 09:24 -!- Elysus [~Elysus@unaffiliated/elysus] has quit [Ping timeout: 264 seconds] 09:55 -!- jannes [~jannes@178.132.211.90] has quit [Quit: Leaving] 10:00 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Quit: bye] 10:24 -!- Elysus1 [~Elysus@host86-187-161-229.range86-187.btcentralplus.com] has quit [Ping timeout: 264 seconds] 10:26 -!- Elysus [~Elysus@unaffiliated/elysus] has joined #bitcoin-core-dev 10:42 -!- cryptapus_afk [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev 10:42 -!- cryptapus_afk [~cryptapus@jupiter.osmus.org] has quit [Changing host] 10:42 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 10:47 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 260 seconds] 10:53 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 11:46 -!- shinobimonkey [~vagabond@107.172.254.2] has joined #bitcoin-core-dev 12:09 -!- TomMc [~tom@unaffiliated/tommc] has quit [Ping timeout: 252 seconds] 12:23 -!- TomMc [~tom@gateway/vpn/privateinternetaccess/tommc] has joined #bitcoin-core-dev 13:22 -!- Elysus1 [~Elysus@host86-187-161-229.range86-187.btcentralplus.com] has joined #bitcoin-core-dev 13:25 -!- Elysus [~Elysus@unaffiliated/elysus] has quit [Ping timeout: 265 seconds] 13:50 -!- udiWertheimer [~udiWerthe@bzq-84-111-23-225.cablep.bezeqint.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 13:53 -!- juscamarena [~justin@47.148.176.74] has quit [Ping timeout: 265 seconds] 14:03 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 14:09 -!- juscamarena [~justin@47.148.176.74] has joined #bitcoin-core-dev 14:25 -!- juscamarena [~justin@47.148.176.74] has quit [Ping timeout: 258 seconds] 14:28 -!- juscamarena [~justin@47.148.176.74] has joined #bitcoin-core-dev 14:33 -!- juscamarena [~justin@47.148.176.74] has quit [Ping timeout: 245 seconds] 14:33 -!- juscamarena [~justin@47.148.176.74] has joined #bitcoin-core-dev 14:56 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 15:35 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Ping timeout: 265 seconds] 15:51 < morcos> BlueMatt: The issue of a block request coming in before you've updated the tip is what's causing the Travis failure in 9447, it's not clear to me why it happens reliably there and not in 9375 as it seems like it should in 9375 15:52 < morcos> in the sendheaders.py test, you announce a reorg and then FindNextBlocksToDownload kicks in when you've announced enough blocks on the new chain to match nChainWork of your tip 15:53 < morcos> it turns out that the block requests generated by FindNextBlocksToDownload can actually arrive before tip is updated in the peer announcing the reorg.. it might be as simple as checking the cached block in ProcessGetData as well.. 16:20 < morcos> the reason this doesn't happen with 9375 alone is that peer 0 hasn't requested that peer 1 be a HB peer, so the reorg isn't announced via the fast mechanism, i'm guessing 9400 changed that, but haven't looked into the details 16:29 -!- harrymm [~wayne@104.237.91.33] has quit [Remote host closed the connection] 16:30 -!- harrymm [~wayne@104.237.91.81] has joined #bitcoin-core-dev 17:08 < gmaxwell> I wondered if that might also force us to cache more than one block. 17:09 < gmaxwell> e.g. what happens if we get a second block instantly after the first, since they're tied will we still advertise the second? 17:10 -!- juscamarena [~justin@47.148.176.74] has quit [Quit: Leaving] 17:10 -!- juscamarena [~justin@47.148.176.74] has joined #bitcoin-core-dev 17:10 -!- juscamarena_ [~justin@47.148.176.74] has joined #bitcoin-core-dev 17:18 -!- juscamarena_ [~justin@47.148.176.74] has quit [Quit: Leaving] 17:26 -!- Elysus1 [~Elysus@host86-187-161-229.range86-187.btcentralplus.com] has quit [Ping timeout: 256 seconds] 17:31 -!- AaronvanW [~ewout@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 17:37 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 18:34 -!- juscamarena [~justin@47.148.176.74] has quit [Remote host closed the connection] 18:56 -!- Elysus [~Elysus@unaffiliated/elysus] has joined #bitcoin-core-dev 18:57 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-xzofqyomvgswafbq] has quit [Quit: Connection closed for inactivity] 18:59 -!- arowser [~quassel@106.120.101.38] has quit [Quit: No Ping reply in 180 seconds.] 19:01 -!- fengling [~fengling@223.223.187.142] has quit [Ping timeout: 268 seconds] 19:03 -!- xiangfu [~xiangfu@223.223.187.142] has quit [Ping timeout: 268 seconds] 19:04 -!- xiangfu [~xiangfu@223.223.187.142] has joined #bitcoin-core-dev 19:05 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev 19:06 < morcos> gmaxwell: that sounds annoying. seems like maybe we need to rework the signals a bit. maybe make BlockChecked always called after ProcessNewBlock and we can hold a cache of all blocks from NewPowValidBlock until BlockChecked. 19:06 < morcos> also always cache the tip 19:07 -!- fengling [~fengling@223.223.187.142] has joined #bitcoin-core-dev 19:07 < morcos> but then we have to figure out where the right place to call MaybeSetPeer.. is 19:08 < morcos> But there is already another minor problem with the way the signals work now, mapBlockSource is never cleared of blocks which don't have BlockChecked called on them 19:09 < morcos> and valid blocks that don't become your tip don't get that I don't think.. probably rare enough not to matter much now, but if we want to be have an alternate block request mechanism for SPV/hybrid whatever or something.. 19:20 -!- juscamarena [~justin@47.148.176.74] has joined #bitcoin-core-dev 21:01 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 21:42 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Quit: bye] 21:56 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 21:57 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 22:01 -!- cannon-c [ccc23f04@gateway/web/freenode/ip.204.194.63.4] has joined #bitcoin-core-dev 22:11 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 258 seconds] 22:13 -!- TomMc [~tom@gateway/vpn/privateinternetaccess/tommc] has quit [Ping timeout: 248 seconds] 22:25 -!- Raccoon [wayward@irchelp/raccoon] has joined #bitcoin-core-dev 22:25 -!- Raccoon [wayward@irchelp/raccoon] has left #bitcoin-core-dev [] 23:20 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 258 seconds] 23:29 < cfields> sipa: if you're here, please refresh your browser. You're reviewing stale commits :) 23:31 < sipa> :( 23:31 < sipa> i was reviewing from the app 23:32 < cfields> sipa: sorry. no clue what the app sees. I split them up into much more reviewable chunks, i hope. 23:33 < sipa> i see it now 23:33 < sipa> i guess it just caches a bit more aggressively 23:33 < sipa> no worries 23:33 < sipa> that's also why the result ends up with commit comments 23:33 < sipa> rather than PR comments 23:34 < cfields> ah, that's annoying. I was just looking at the page and saw no comments on the pr. Checked my mail on my phone on a whim. 23:35 < cfields> no worries though, i'll watch for that now 23:36 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 23:49 -!- fengling [~fengling@223.223.187.142] has quit [Ping timeout: 268 seconds]