--- Day changed Mon Jan 16 2017 00:10 -!- waxwing [~waxwing@14.174.32.23] has joined #bitcoin-core-dev 00:10 -!- xinxi [~xinxi@116.87.187.139] has quit [Remote host closed the connection] 00:15 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 00:15 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:20 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 258 seconds] 00:26 -!- BitBully [~Mutter@197.210.25.37] has joined #bitcoin-core-dev 00:31 -!- xinxi [~xinxi@116.87.187.139] has joined #bitcoin-core-dev 00:35 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #bitcoin-core-dev 00:41 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has quit [Remote host closed the connection] 00:41 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:42 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has joined #bitcoin-core-dev 00:52 -!- BitBully [~Mutter@197.210.25.37] has quit [Quit: Mutter: www.mutterirc.com] 01:00 -!- waxwing [~waxwing@14.174.32.23] has quit [Ping timeout: 256 seconds] 01:12 -!- waxwing [waxwing@gateway/vpn/mullvad/x-smtxsvzkvdayuvci] has joined #bitcoin-core-dev 01:35 -!- cannon-c is now known as cannon-c_AFK 01:46 -!- xinxi [~xinxi@116.87.187.139] has quit [Remote host closed the connection] 02:02 -!- cannon-c_AFK is now known as cannon-c 02:19 -!- davec [~davec@cpe-24-243-230-253.hot.res.rr.com] has quit [Ping timeout: 240 seconds] 02:24 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 02:34 < jonasschnelli> Ping BlueMatt luke-jr: https://github.com/bitcoin/bitcoin/pull/9294 02:41 < cannon-c> Quick question, I am looking to using bitcoin core in conjunction with ssss (Shamirs secret sharing scheme) 02:42 < cannon-c> to create fragmented seed backups which can be re-created using pre-defined threshold of number of shares 02:42 < cannon-c> Does Core already have something like this? 02:42 < cannon-c> I dont want to duplicate something that already exists 02:43 -!- BitBully [~Mutter@197.210.25.35] has joined #bitcoin-core-dev 02:44 < cannon-c> One use case, creating the xpriv on airgap system, with fragmented backup as contingency of access 02:44 < cannon-c> to family if something happens to me 02:45 < cannon-c> or great for distributed backups 02:46 -!- xinxi [~xinxi@116.87.187.139] has joined #bitcoin-core-dev 02:51 -!- thermoman [~thermoman@wtf.foobar0815.de] has quit [Quit: Bye] 02:53 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 02:55 -!- xinxi [~xinxi@116.87.187.139] has quit [Ping timeout: 256 seconds] 03:19 -!- trotski2000 [uid206086@gateway/web/irccloud.com/x-hcoexleatsotfqna] has quit [Changing host] 03:19 -!- trotski2000 [uid206086@unaffiliated/trotski2000] has joined #bitcoin-core-dev 03:19 -!- trotski2000 [uid206086@unaffiliated/trotski2000] has quit [Changing host] 03:19 -!- trotski2000 [uid206086@gateway/web/irccloud.com/x-hcoexleatsotfqna] has joined #bitcoin-core-dev 03:22 -!- xinxi [~xinxi@116.87.187.139] has joined #bitcoin-core-dev 03:27 -!- To7 [~theo@cpe-158-222-222-232.nyc.res.rr.com] has quit [Quit: Whatever] 03:31 -!- xinxi [~xinxi@116.87.187.139] has quit [Ping timeout: 256 seconds] 03:33 -!- BitBully [~Mutter@197.210.25.35] has quit [Ping timeout: 240 seconds] 03:37 -!- BitBully [~Mutter@197.210.25.37] has joined #bitcoin-core-dev 03:37 -!- xinxi [~xinxi@116.87.187.139] has joined #bitcoin-core-dev 03:45 -!- To7 [~theo@cpe-158-222-222-232.nyc.res.rr.com] has joined #bitcoin-core-dev 03:57 < btcdrak> jonasschnelli: testing 04:16 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev 04:35 < jonasschnelli> btcdrak: thanks! 04:44 -!- BitBully [~Mutter@197.210.25.37] has quit [Read error: Connection reset by peer] 04:52 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has quit [Quit: MarcoFalke] 05:14 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 05:16 -!- BitBully [~Mutter@197.210.25.136] has joined #bitcoin-core-dev 05:20 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 05:20 -!- BitBully [~Mutter@197.210.25.136] has quit [Client Quit] 05:35 -!- xinxi [~xinxi@116.87.187.139] has quit [Remote host closed the connection] 05:40 -!- waxwing [waxwing@gateway/vpn/mullvad/x-smtxsvzkvdayuvci] has quit [Ping timeout: 258 seconds] 05:43 -!- xinxi [~xinxi@116.87.187.139] has joined #bitcoin-core-dev 05:45 < morcos> wumpus: I think #9380 is *almost* ready for merge, ideally it would be merged in time to keep the translation strings for -blockmintxfee. I think the only open question is if people prefer a different name for -dustrelayfee. 05:46 < gribble> https://github.com/bitcoin/bitcoin/issues/9380 | Separate different uses of minimum fees by morcos · Pull Request #9380 · bitcoin/bitcoin · GitHub 05:50 -!- BitBully [~Mutter@197.210.24.16] has joined #bitcoin-core-dev 05:58 -!- BitBully [~Mutter@197.210.24.16] has quit [Quit: Mutter: www.mutterirc.com] 06:00 -!- waxwing [~waxwing@14.174.32.23] has joined #bitcoin-core-dev 06:00 < instagibbs> cannon-c, try #bitcoin 06:00 -!- cannon-c [ccc23f04@gateway/web/freenode/ip.204.194.63.4] has quit [Quit: Page closed] 06:01 -!- BitBully [~Mutter@197.210.25.12] has joined #bitcoin-core-dev 06:06 -!- BitBully [~Mutter@197.210.25.12] has quit [Client Quit] 06:26 -!- instagibbs [~instagibb@pool-100-15-114-3.washdc.fios.verizon.net] has quit [Ping timeout: 240 seconds] 06:26 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 06:39 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 252 seconds] 06:58 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 07:07 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 07:08 -!- dmrche [0e8ba0fc@gateway/web/freenode/ip.14.139.160.252] has joined #bitcoin-core-dev 07:12 -!- xinxi [~xinxi@116.87.187.139] has quit [Quit: Leaving...] 07:18 -!- Hmbryjb [01a258c2@gateway/web/freenode/ip.1.162.88.194] has joined #bitcoin-core-dev 07:22 -!- Hmbryjb [01a258c2@gateway/web/freenode/ip.1.162.88.194] has quit [Ping timeout: 260 seconds] 07:24 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 255 seconds] 07:26 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 08:08 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 252 seconds] 08:14 -!- Netmage [~Netmage@p5B0A6A28.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 08:15 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has quit [Remote host closed the connection] 08:16 -!- cryptapus_afk [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev 08:16 -!- cryptapus_afk [~cryptapus@jupiter.osmus.org] has quit [Changing host] 08:16 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 08:23 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has quit [Quit: conversation terminated!] 08:24 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 08:35 -!- PRab [~chatzilla@c-68-62-95-247.hsd1.mi.comcast.net] has quit [Read error: Connection reset by peer] 08:39 -!- cryptapus [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev 08:39 -!- cryptapus [~cryptapus@jupiter.osmus.org] has quit [Changing host] 08:39 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 08:52 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev 09:08 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has quit [Ping timeout: 255 seconds] 09:20 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 09:21 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 09:22 -!- BitBully [~Mutter@197.210.24.47] has joined #bitcoin-core-dev 09:23 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 09:26 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 255 seconds] 09:29 -!- BitBully [~Mutter@197.210.24.47] has quit [Quit: Mutter: www.mutterirc.com] 09:40 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 09:47 -!- davec [~davec@cpe-24-243-230-253.hot.res.rr.com] has joined #bitcoin-core-dev 09:49 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 09:51 -!- waxwing [~waxwing@14.174.32.23] has quit [Ping timeout: 240 seconds] 09:54 -!- Raptor186 [~Raptor186@178.208.166.254] has joined #bitcoin-core-dev 09:58 -!- cryptapus is now known as cryptapus_afk 10:16 -!- wvr [~wvr@215.red-83-59-62.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 10:17 < jtimon> morcos: re #9380 I would leave -dustrelayfee, or change to -dustfee maybe, no strong opinion on my part 10:17 < gribble> https://github.com/bitcoin/bitcoin/issues/9380 | Separate different uses of minimum fees by morcos · Pull Request #9380 · bitcoin/bitcoin · GitHub 10:29 -!- Raptor186 [~Raptor186@178.208.166.254] has quit [] 10:33 < bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/8a445c5651ed...dd98f0453824 10:33 < bitcoin-git> bitcoin/master daec955 Alex Morcos: Introduce -blockmintxfee 10:33 < bitcoin-git> bitcoin/master 7b1add3 Alex Morcos: Introduce -incrementalrelayfee 10:33 < bitcoin-git> bitcoin/master eb30d1a Alex Morcos: Introduce -dustrelayfee 10:33 < bitcoin-git> [bitcoin] laanwj closed pull request #9380: Separate different uses of minimum fees (master...minfees) https://github.com/bitcoin/bitcoin/pull/9380 11:00 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Quit: bye] 11:18 -!- instagibbs [~instagibb@pool-100-15-114-3.washdc.fios.verizon.net] has joined #bitcoin-core-dev 11:23 -!- PRab [~chatzilla@c-68-62-95-247.hsd1.mi.comcast.net] has joined #bitcoin-core-dev 11:28 -!- mol [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer] 11:31 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds] 11:35 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 11:35 -!- dmrche [0e8ba0fc@gateway/web/freenode/ip.14.139.160.252] has quit [Ping timeout: 260 seconds] 11:41 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 11:50 < BlueMatt> morcos: the difference is that bumpfee takes us to a world where having "double spends" in your wallet is entirely supported 11:50 < morcos> It's already supported once we merged BIP 152 11:51 < morcos> uh 11:51 < morcos> 125 11:51 < morcos> whatever 11:51 < BlueMatt> instead of, previously, you'd have to do something unsupported like run your wallet on multiple machines to get it 11:51 < BlueMatt> hmm? 11:51 < morcos> actually it was supported even before that 11:51 < BlueMatt> only abandon transaction supported it? 11:51 < BlueMatt> well, you generating them, that is 11:51 < BlueMatt> you receiving them maybe 11:51 < morcos> yeah exactly 11:52 < BlueMatt> but now we are actively supporting you generating them 11:52 < BlueMatt> which is a huge difference 11:52 < BlueMatt> (is getbalance "*" broken for receiving double spends, too?) 11:52 < morcos> and previously you could generate them yourself also... 11:52 < BlueMatt> manually, sure 11:52 < BlueMatt> but "unsupported, might break getbalance" is perfectly reasonable in that case 11:53 < morcos> the only thing stopping you from doing it automatically would be if your mempool had your original spend 11:53 < morcos> so the coins didn't show up 11:53 < morcos> so if it came out of your mempool for any reason... expired after 3 days for instance 11:53 < BlueMatt> hmm? we re-add your txn to mempool? 11:53 < morcos> nothing stopping you from double spending... with 0.12, we made it so you had to abandon it first but that wasn't a requirement before that 11:54 < BlueMatt> so only abandon would stop it? 11:54 < morcos> i'm saying if you automatically created tx A, then A was evicted from your mempool, never made it in, or was expired 11:54 < BlueMatt> i mean sure, if you manually createrawtransaction/signrawtransaction you could doublespend easily 11:54 < BlueMatt> if it was expired it would be re-added 11:54 < morcos> nothing would prevent you from doing an sendtoaddress and creating A' doublespend 11:54 < morcos> no it wouldn't 11:54 < morcos> we just added that 11:54 < BlueMatt> oh? 11:54 < BlueMatt> wait, what? 11:55 < BlueMatt> we've always re-announced transactions on a regular basis? 11:55 < morcos> reannounce txs already in your mempool 11:55 < BlueMatt> I mean to be clear, I'm fine with some documentation noting that getbalance "*" is broken, and should not be used, and is made worse with bumpfee 11:55 < morcos> i'm inflating my argument slightly, since before mempool limiting, things didn't really fall out of your mempool very much 11:55 < BlueMatt> really? 11:56 < BlueMatt> yea, ok, i suppose thats why 11:56 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 11:56 < morcos> See #9290 11:56 < gribble> https://github.com/bitcoin/bitcoin/issues/9290 | Make RelayWalletTransaction attempt to AcceptToMemoryPool. by gmaxwell · Pull Request #9290 · bitcoin/bitcoin · GitHub 11:56 < BlueMatt> ahh 11:57 < morcos> Anyway, i guess my point is its not fair to accept a bumpfee PR to take on fixing years of broken code just b/c it might lead to the bugs being exposed more... 11:57 < morcos> the bugs are exposed more by allowing double spends 11:57 < morcos> we've already crossed that bridge 11:57 < morcos> its stupid to say we won't make it easier for you b/c our code is broken in some ways reporting on them 11:58 < BlueMatt> well i believe the bugs are only currently exposed if you're doing something entirely unsupported (or, in the case fixed by #9290 by bugs which we need to/did fix) 11:58 < gribble> https://github.com/bitcoin/bitcoin/issues/9290 | Make RelayWalletTransaction attempt to AcceptToMemoryPool. by gmaxwell · Pull Request #9290 · bitcoin/bitcoin · GitHub 11:58 < morcos> i don't really feel strongly about merging bumpfee for 0.14.. thats not really what i'm arguing about.. and i think your last minute concerns are a good reflection that it seems a bit rushed trying to get it in 11:58 < BlueMatt> considering its deprecated I dont see why we cant just put a note in the docs and say "this is broken" 11:59 < BlueMatt> (bumpfee "*", that is) 11:59 < morcos> i just don't think that when we decide it is ready to merge we should be weighing it down with the responsiblity of fixign eveyrthing else 11:59 < morcos> why don't you think bugs are exposed if you receive a double spend? 11:59 < BlueMatt> agreed, totally get that, but in this case I do think we are exposing bugs which were only previously exposed if the user was doing something insane 11:59 < morcos> a BIP 125 compatible one 11:59 < BlueMatt> though, really, if bumpfee slips 0.14, we should just remove accounts for 0.14 11:59 < morcos> thats not insance at all 12:00 < BlueMatt> then bumpfee isnt exposing shit :p 12:00 < BlueMatt> are the bugs exposed if you receive a bumpfee from someone else? I havent thought that far into it 12:00 < morcos> ah 12:00 < morcos> perhaps not... 12:01 < BlueMatt> no, asking, i have no idea 12:01 < BlueMatt> not saying i dont think they are, just havent looked 12:01 < morcos> well the issue is 0-confirm things reduce your balance, regardless of whether they are in the mempool or not 12:01 < morcos> if its a tx from someoen else, it won't add to yoru balance if its 0 confirm period... 12:02 < morcos> but i bet getbalance "*" 0 is broken if you receive a double spend 12:03 < BlueMatt> could see that, but getbalance "*" 1 can go negative with bumpfee, I believe 12:03 < morcos> anyway... i just don't think bumpfee CHANGES anything about this... 12:03 < BlueMatt> or maybe not? 12:04 < morcos> lets just agree it shouldn't be fixed on the bumpfee PR... i'll argue less (or none) about saying we shouldn't do a release with bumpfee before its fixed 12:04 < BlueMatt> if I'm right (and might not be), during normal use of the wallet, getbalance "*" 1 is (probaboy, I think?) correct, and is currently the only way to get your balance if you include watchonly 12:04 < BlueMatt> with bumpfee, I believe, this changes 12:04 < BlueMatt> so it is no longer correct 12:05 < BlueMatt> unrelatedly, did we document the listunspent changes for bumpfee? 12:05 < BlueMatt> I do think that needs documentation, if no code changes 12:06 < morcos> yeah.. i actually think we should probably just return the txs in listunspent 12:06 < BlueMatt> both of them? 12:06 < BlueMatt> that seems shit 12:06 < morcos> its trivial to do b/c listunspent already passes a fOnlyConfirmed bool set to fallse to AvailableCoins that no other uses of it do 12:06 < BlueMatt> (does it currently return abandoned tx or tx not in mempool?) 12:06 < morcos> i think so 12:07 < morcos> i don't know let me check 12:07 < BlueMatt> no, it just calls AvailableCoins 12:08 < BlueMatt> so only if its "trusted" and in mempool 12:08 < morcos> no it doesn't check IsTrusted 12:08 < morcos> but you are right it checks the mempool 12:08 < BlueMatt> wait, no, wtf is fOnlyConfirmed 12:08 < BlueMatt> oh, yes, you're right 12:08 < morcos> which maybe is exactly what we want? 12:09 < BlueMatt> I think if we add an fOnlyConfirmed to both of the replaces/replaced checks that would be least-surprising to users 12:09 < morcos> agreed 12:09 < BlueMatt> but, frankly, I'm open to anything that is documented 12:10 < BlueMatt> would you like me to go finish review assuming that gets fixed? if we feel it could still be merged for 0.14 I'm happy to 12:10 < BlueMatt> not sure how wumpus or sipa feel about it now 12:12 < morcos> ehh... if it was me, i'd put it in 0.14.. but i'm not going to advocate for it... maybe gmaxwell feels strongly? 12:12 < morcos> i think #9294 is maybe higher priority 12:12 < gribble> https://github.com/bitcoin/bitcoin/issues/9294 | Use internal HD chain for change outputs (hd split) by jonasschnelli · Pull Request #9294 · bitcoin/bitcoin · GitHub 12:12 < BlueMatt> I mean the way i have left to review this is to literally go read all of wallet and rpcwallet 12:12 < BlueMatt> is that still waiting on fixes? 12:12 < BlueMatt> oh, no, ok, will review that one at least 12:13 < morcos> i don't know.. i just started reading BIP 32.. ha 12:14 < sdaftuar> if we're concerned about bumpfee for 0.14, i think we could merge it and mark it as experimental? i'm also ok with merging after the 0.14 split and use the 0.15 release cycle as time to get the bugs out while it simmers in master 12:14 < BlueMatt> jonasschnelli: you around? 12:15 < sdaftuar> i'd be concerned about holding it up further though for unreleated walelt bugs that it exposes 12:15 < BlueMatt> sdaftuar: well the only thing I found so far that really is a problem, I think, is listunspent 12:15 < BlueMatt> the getbalance "*" thing I really hate, but am not sure is a reasonable fix 12:16 * BlueMatt is still hoping #9561 and #9535 get another last-minute review or two and get merged 12:16 < gribble> https://github.com/bitcoin/bitcoin/issues/9561 | Wake message handling thread when we receive a new block by TheBlueMatt · Pull Request #9561 · bitcoin/bitcoin · GitHub 12:16 < gribble> https://github.com/bitcoin/bitcoin/issues/9535 | Split CNode::cs_vSend: message processing and message sending by TheBlueMatt · Pull Request #9535 · bitcoin/bitcoin · GitHub 12:16 < BlueMatt> but it seems like no one is around today :( 12:16 < BlueMatt> damn holidays 12:16 < BlueMatt> always getting in the way 12:17 < sdaftuar> yeah i think listunspent could be a fix-by-documentation, at least for now. makes more sense if we indicate bumpfee is an experimental feature? 12:18 < BlueMatt> im fine with that 12:18 < BlueMatt> though I think the above-discussed fix might also be sufficient 12:20 < BlueMatt> would just need a quick pass to check all the other places fOnlyConfirmed is set in callers 12:20 -!- owowo [ovovo@gateway/vpn/mullvad/x-hrrhsuxnrkjiafda] has quit [Ping timeout: 256 seconds] 12:23 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 255 seconds] 12:28 < morcos> BlueMatt: i already did that, only set by listunspent 12:29 < BlueMatt> cool 12:29 < morcos> what about #9499, that is a pretty big win if you ask me... especially without multiple block downloads 12:29 < gribble> https://github.com/bitcoin/bitcoin/issues/9499 | Use recent-rejects, orphans, and recently-replaced txn for compact-block-reconstruction by TheBlueMatt · Pull Request #9499 · bitcoin/bitcoin · GitHub 12:30 < BlueMatt> yes, and probably has enough review to get a merge, I'd say 12:33 < sipa> BlueMatt: i'll do another pass today 12:33 < sipa> now meeting ethan 12:33 < BlueMatt> thanks 12:33 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/b0819c7e9b428631b806d97ff19beb2e218df31f 12:33 < bitcoin-git> bitcoin/master b0819c7 Wladimir J. van der Laan: qt: periodic translations update 12:33 < BlueMatt> cool, tell him i said hi 12:39 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 12:44 -!- PaulCapestany [~PaulCapes@2604:5500:17:2ea:cd2b:f49d:fe68:cdf9] has quit [Quit: .] 12:47 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 12:47 < sipa> he says hello 12:58 -!- owowo [ovovo@gateway/vpn/mullvad/x-qalwkplctdseibij] has joined #bitcoin-core-dev 13:03 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [] 13:04 -!- instagibbs [~instagibb@pool-100-15-114-3.washdc.fios.verizon.net] has quit [Ping timeout: 252 seconds] 13:11 -!- instagibbs [~instagibb@pool-100-15-114-3.washdc.fios.verizon.net] has joined #bitcoin-core-dev 13:13 * instagibbs attempting 9561 review 13:13 < instagibbs> 9499 is def ready 13:17 -!- kvnn [~kvnn@cpe-108-185-240-254.socal.res.rr.com] has joined #bitcoin-core-dev 13:24 -!- To7 [~theo@cpe-158-222-222-232.nyc.res.rr.com] has quit [Quit: Whatever] 13:30 < sipa> #9499 13:30 < gribble> https://github.com/bitcoin/bitcoin/issues/9499 | Use recent-rejects, orphans, and recently-replaced txn for compact-block-reconstruction by TheBlueMatt · Pull Request #9499 · bitcoin/bitcoin · GitHub 13:30 < sipa> #9561 13:30 < gribble> https://github.com/bitcoin/bitcoin/issues/9561 | Wake message handling thread when we receive a new block by TheBlueMatt · Pull Request #9561 · bitcoin/bitcoin · GitHub 13:30 < sipa> agree 13:31 < instagibbs> oops, I meant 9535 13:31 < instagibbs> for my attempted review... 13:32 < sipa> #9535 13:32 < gribble> https://github.com/bitcoin/bitcoin/issues/9535 | Split CNode::cs_vSend: message processing and message sending by TheBlueMatt · Pull Request #9535 · bitcoin/bitcoin · GitHub 13:38 < cfields> agree on all of those 13:39 < BlueMatt> #9484 obv 13:39 < gribble> https://github.com/bitcoin/bitcoin/issues/9484 | Introduce assumevalid setting to skip validation presumed valid scripts. by gmaxwell · Pull Request #9484 · bitcoin/bitcoin · GitHub 13:40 < cfields> ah right, i need to sync up and ack the hash 13:41 < cfields> (i'm sure it's fine :) 13:42 < sipa> no, you should not be sure it is fine 13:42 < sipa> (i, however, am) 13:44 < BlueMatt> I did validate that hash prior to ack 13:49 < BlueMatt> if we're willing to push a day, I think both #9294 and #8456 could make it, but not sure they're gonna make it today 13:49 < gribble> https://github.com/bitcoin/bitcoin/issues/9294 | Use internal HD chain for change outputs (hd split) by jonasschnelli · Pull Request #9294 · bitcoin/bitcoin · GitHub 13:49 < BlueMatt> well, maybe two days 13:49 < gribble> https://github.com/bitcoin/bitcoin/issues/8456 | [RPC] Simplified bumpfee command. by mrbandrews · Pull Request #8456 · bitcoin/bitcoin · GitHub 13:49 < BlueMatt> but i do think they're both super close 14:07 < bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/b0819c7e9b42...812714fd80e9 14:07 < bitcoin-git> bitcoin/master e440ac7 Gregory Maxwell: Introduce assumevalid setting to skip presumed valid scripts.... 14:07 < bitcoin-git> bitcoin/master 7b5e3fe John Newbery: Add assumevalid testcase... 14:07 < bitcoin-git> bitcoin/master 812714f Pieter Wuille: Merge #9484: Introduce assumevalid setting to skip validation presumed valid scripts.... 14:08 < bitcoin-git> [bitcoin] sipa closed pull request #9484: Introduce assumevalid setting to skip validation presumed valid scripts. (master...script_elide_verified) https://github.com/bitcoin/bitcoin/pull/9484 14:22 -!- waxwing [~waxwing@14.174.32.23] has joined #bitcoin-core-dev 14:39 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 14:40 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 14:58 < bitcoin-git> [bitcoin] theuni opened pull request #9566: threading: use std::chrono for timestamps (master...nuke-boost-chrono2) https://github.com/bitcoin/bitcoin/pull/9566 15:14 -!- cryptapus_afk is now known as cryptapus 15:31 -!- cryptapus is now known as cryptapus_afk 15:47 -!- wvr [~wvr@215.red-83-59-62.dynamicip.rima-tde.net] has quit [Quit: Leaving] 15:53 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds] 15:58 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 16:03 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 16:05 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 16:09 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 16:29 -!- kvnn [~kvnn@cpe-108-185-240-254.socal.res.rr.com] has quit [Ping timeout: 240 seconds] 16:41 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Quit: WeeChat 0.4.2] 16:47 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-pcadvggjguxiiakl] has quit [Quit: Connection closed for inactivity] 16:50 -!- abpa [~abpa@2602:306:b837:dbf0:e865:bbfd:af08:308a] has joined #bitcoin-core-dev 16:50 -!- abpa [~abpa@2602:306:b837:dbf0:e865:bbfd:af08:308a] has quit [Client Quit] 17:06 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev 17:16 -!- Netmage [~Netmage@p5B0A6A28.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds] 17:17 -!- Netmage [~Netmage@p5B0A6EA5.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 17:44 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has quit [Quit: MarcoFalke] 18:00 -!- Guest38975 [~cocks@bzq-84-108-249-232.cablep.bezeqint.net] has joined #bitcoin-core-dev 18:00 -!- Guest38975 [~cocks@bzq-84-108-249-232.cablep.bezeqint.net] has quit [] 18:07 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 18:08 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 18:12 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has quit [Ping timeout: 256 seconds] 18:19 < BlueMatt> wumpus: fwiw, i vote we hold merge window for a day or two for things already pending incl the hd split (which I think is one more set of fixups, hopefully tomorrow, away, and is not as hard to review as it looks), bumpfee pending discussion tomorrow (I'm pretty happy with it if we fix the two pending issues - listunspent, which may just be a docs change, and getbalance, which may also just be a docs change), the compact-block-orphan-r 18:19 < BlueMatt> ejects one (which looks pretty much mergeable to me) and preferably the extra message handler waker (9561, which is both trivial and a big gain) 18:19 < BlueMatt> but I'd understand if thats not a popular opinion 18:29 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 18:29 < fanquake> wummpus / sipa are you around? 18:29 < fanquake> *wumpus 18:34 < fanquake> Or anyone with admin on bitcoin/bitcoin, there is a user spamming the repo with links/comments. 18:35 < fanquake> I have deleted most for now. 18:43 < sipa> sigh 18:43 < sipa> sorry, i can't really access github now 18:53 -!- dermoth_ [~thomas@201-77.162.dsl.aei.ca] has joined #bitcoin-core-dev 18:53 -!- dermoth [~thomas@dsl-66-36-128-167.mtl.aei.ca] has quit [Disconnected by services] 18:53 -!- dermoth_ is now known as dermoth 19:25 < sipa> fanquake: blocked 19:55 < bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/812714fd80e9...6696b4635ceb 19:55 < bitcoin-git> bitcoin/master f13914a Matt Corallo: Make WakeMessageHandler public 19:55 < bitcoin-git> bitcoin/master 241d893 Matt Corallo: Wake message handling thread when we receive a new block... 19:55 < bitcoin-git> bitcoin/master 6696b46 Pieter Wuille: Merge #9561: Wake message handling thread when we receive a new block... 19:55 < bitcoin-git> [bitcoin] sipa closed pull request #9561: Wake message handling thread when we receive a new block (master...2017-01-wakeup-on-new-block) https://github.com/bitcoin/bitcoin/pull/9561 20:05 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 20:12 < sipa> BlueMatt: sorry, need sleep first 20:13 < BlueMatt> I still vote we push back freeze a day or two, given today was a holiday in the us and many folks werent working all weekend 20:13 < BlueMatt> :p 20:14 < BlueMatt> and so I can shamelessly get folks to review #9535 :p 20:14 < gribble> https://github.com/bitcoin/bitcoin/issues/9535 | Split CNode::cs_vSend: message processing and message sending by TheBlueMatt · Pull Request #9535 · bitcoin/bitcoin · GitHub 20:31 < luke-jr> I ended up being away for yesterday & today, so another day or two may be helpful 20:31 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 20:31 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 20:34 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 240 seconds] 20:48 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 21:52 -!- Squidicc [~squid@pool-173-48-116-49.bstnma.fios.verizon.net] has joined #bitcoin-core-dev 21:54 -!- Squidicuz [~squid@pool-173-48-116-49.bstnma.fios.verizon.net] has quit [Ping timeout: 240 seconds] 22:10 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Quit: Leaving.] 23:01 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-biqbxepyceufmjcf] has joined #bitcoin-core-dev 23:12 -!- waxwing [~waxwing@14.174.32.23] has quit [Ping timeout: 245 seconds]