--- Day changed Wed Jan 18 2017 00:13 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 00:14 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev 00:20 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving] 00:35 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:52 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:56 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 255 seconds] 00:57 -!- Samdney [~Samdney@81.95.5.43] has joined #bitcoin-core-dev 01:02 -!- Samdney [~Samdney@81.95.5.43] has quit [Read error: Connection reset by peer] 01:07 -!- Samdney [~Samdney@178.162.209.129] has joined #bitcoin-core-dev 01:26 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 01:26 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 01:43 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #bitcoin-core-dev 01:45 -!- timothy [~quassel@archlinux/trusteduser/DrizztBSD] has quit [Remote host closed the connection] 01:56 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6696b4635ceb...b0b57a17306a 01:56 < bitcoin-git> bitcoin/master 95bab82 practicalswift: Remove unused Python imports 01:56 < bitcoin-git> bitcoin/master b0b57a1 MarcoFalke: Merge #9508: Remove unused Python imports... 01:57 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #9508: Remove unused Python imports (master...remove-unused-python-import) https://github.com/bitcoin/bitcoin/pull/9508 02:00 -!- wvr [~wvr@215.red-83-59-62.dynamicip.rima-tde.net] has quit [Ping timeout: 240 seconds] 02:00 -!- Samdney [~Samdney@178.162.209.129] has quit [Read error: Connection reset by peer] 02:10 -!- e4xit [~e4xit@cpc1-cmbg20-2-0-cust188.5-4.cable.virginm.net] has joined #bitcoin-core-dev 02:14 -!- wvr [~wvr@116.red-88-8-192.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 02:15 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has quit [Ping timeout: 248 seconds] 02:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:26 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 02:38 -!- CubicEarth [~cubiceart@2002:329f:7e15:0:15ba:2521:69d9:50fb] has joined #bitcoin-core-dev 02:41 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 256 seconds] 03:01 -!- kittyP [~kittyP@unaffiliated/kittyp] has joined #bitcoin-core-dev 03:04 -!- kittyP [~kittyP@unaffiliated/kittyp] has left #bitcoin-core-dev [] 03:15 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 03:27 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 03:32 -!- CubicEarth [~cubiceart@2002:329f:7e15:0:15ba:2521:69d9:50fb] has quit [Remote host closed the connection] 03:36 -!- waxwing [~waxwing@14.174.32.23] has quit [Ping timeout: 240 seconds] 03:37 < bitcoin-git> [bitcoin] fanquake opened pull request #9574: [depends] Fix QT build on OSX (master...fix-osx-depends-build) https://github.com/bitcoin/bitcoin/pull/9574 03:49 -!- waxwing [waxwing@gateway/vpn/mullvad/x-tvnejrunuzkxiydr] has joined #bitcoin-core-dev 04:20 -!- cryptapus [~cryptapus@87.254.202.175] has joined #bitcoin-core-dev 04:20 -!- cryptapus [~cryptapus@87.254.202.175] has quit [Changing host] 04:20 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 04:26 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 05:01 -!- moli_ [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer] 05:08 -!- waxwing [waxwing@gateway/vpn/mullvad/x-tvnejrunuzkxiydr] has quit [Ping timeout: 264 seconds] 05:15 -!- blueyez [~AndChat52@112.198.68.10] has joined #bitcoin-core-dev 05:20 -!- waxwing [waxwing@gateway/vpn/mullvad/x-jfnyamketxfmfkgd] has joined #bitcoin-core-dev 05:27 -!- handlex [~handlex@2804:14c:658f:4dc7:9880:7b9f:e914:18d9] has joined #bitcoin-core-dev 05:38 -!- handlex [~handlex@2804:14c:658f:4dc7:9880:7b9f:e914:18d9] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 05:41 -!- paveljanik [~paveljani@79.98.72.176] has joined #bitcoin-core-dev 05:41 -!- paveljanik [~paveljani@79.98.72.176] has quit [Changing host] 05:41 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 05:48 -!- handlex [~handlex@2804:14c:658f:4dc7:9880:7b9f:e914:18d9] has joined #bitcoin-core-dev 05:49 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 06:03 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 06:04 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 06:09 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 06:15 < BlueMatt> cfields: yo 06:16 < BlueMatt> where are we on #9212 and #9278? The fix for 9212 at https://github.com/bitcoinfibre/bitcoinfibre/commit/8e2c2cf418adb3dad1479c3f8890e0a2c8b6f709 has been in production for a while (albeit not on nodes with a ton of connection churn) so I'm reasonably confident in it, but iirc you were not a fan? 06:16 < gribble> https://github.com/bitcoin/bitcoin/issues/9212 | Assertion failed: (nSendVersion != 0), function GetSendVersion, file ./net.h, line 775. · Issue #9212 · bitcoin/bitcoin · GitHub 06:16 < gribble> https://github.com/bitcoin/bitcoin/issues/9278 | test_bitcoin fails valgrind · Issue #9278 · bitcoin/bitcoin · GitHub 06:18 < BlueMatt> for those bored, #9392 should be an easy fix 06:18 < gribble> https://github.com/bitcoin/bitcoin/issues/9392 | Wallet ancestor sanity-check ignores sigops · Issue #9392 · bitcoin/bitcoin · GitHub 06:48 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev 06:53 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [] 06:53 -!- moli_ [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer] 06:58 -!- handlex [~handlex@2804:14c:658f:4dc7:9880:7b9f:e914:18d9] has quit [Quit: handlex] 07:08 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Quit: WeeChat 0.4.2] 07:18 -!- juscamarena [~justin@47.148.176.74] has quit [Remote host closed the connection] 07:18 -!- blkdb [~blkdb@2a01:4f8:140:1407::2] has quit [Write error: Broken pipe] 07:18 -!- blkdb [~blkdb@2a01:4f8:140:1407::2] has joined #bitcoin-core-dev 07:18 -!- berndj [~berndj@mail.azna.co.za] has quit [Excess Flood] --- Log closed Wed Jan 18 07:18:33 2017 --- Log opened Wed Jan 18 07:29:02 2017 07:29 -!- kanzure [~kanzure@unaffiliated/kanzure] has joined #bitcoin-core-dev 07:29 -!- Irssi: #bitcoin-core-dev: Total of 160 nicks [0 ops, 0 halfops, 0 voices, 160 normal] 07:31 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 07:31 -!- michagogo [uid14316@wikia/Michagogo] has joined #bitcoin-core-dev 07:32 -!- cfields [~quassel@unaffiliated/cfields] has quit [Quit: cfields] 07:33 -!- cfields [~quassel@unaffiliated/cfields] has joined #bitcoin-core-dev 07:36 -!- blueyez [~AndChat52@112.198.68.10] has joined #bitcoin-core-dev 07:39 -!- Irssi: Join to #bitcoin-core-dev was synced in 634 secs 07:46 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 08:02 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 08:05 -!- nickler [~nickler@185.12.46.130] has quit [Ping timeout: 255 seconds] 08:06 -!- nickler [~nickler@185.12.46.130] has joined #bitcoin-core-dev 08:11 -!- Anduck_ is now known as Anduck 08:14 -!- handlex [~handlex@2804:14c:658f:4dc7:9880:7b9f:e914:18d9] has joined #bitcoin-core-dev 08:15 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 08:15 < cfields> BlueMatt: I didn't like that change at the time because 1. We weren't always disconnecting (or checking fDisconnect) as necessary at the time, and 2. It changes the "you can only send 1 version message" semantics a bit. 1. should be fixed since fedea8a14. I think your change is probably ok, but I think we should think through 2 a little. 08:17 < BlueMatt> I know we also discussed moving off of the "nVersion is set means connected" to using the fSuccessfullyConnected flag again 08:17 < BlueMatt> they're kinda confused and redundant atm 08:18 < cfields> yea 08:19 < cfields> that would be my preference, only issue there is defining "successfully connected" 08:21 -!- moli_ [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer] 08:23 < cfields> BlueMatt: as a weird example, I think your change would allow for sending infinite version messages in which the addrMe portion fails to deserialize 08:23 < cfields> so a peer could change their nVersion a bunch of times before locking it in 08:24 < cfields> (i don't know what good that would do, but we certainly shouldn't be allowing that) 08:24 < BlueMatt> I'd file that under "undefined behavior" I believe in that case we may be required to make a best effort to eat the sender's cat 08:25 < BlueMatt> but short that, I'm not sure if we care that they can do that? 08:25 < BlueMatt> as long as we actually gate on fSuccessfullyConnected 08:25 < cfields> BlueMatt: right, that was my point. atm we don't in many places 08:25 < BlueMatt> cfields: do you have time to look at that, or should I just whip something up with fSuccessfullyConnected after I finish review of one or two others? 08:26 < BlueMatt> well atm we check nVersion != 0 pretty much everywhere, i think 08:26 < BlueMatt> as a proxy for connectedness 08:27 < cfields> BlueMatt: right, and in the above scenario, we don't consider them connected, but their nVersion is set. 08:27 < BlueMatt> ok, so replace nVersion != 0 with fSuccessfullyConnected everywhere, i guess? 08:29 < cfields> i think so. 08:29 < BlueMatt> k 08:29 < cfields> and at this point, we can remove the assert 08:29 < BlueMatt> I'll do it after lunch if you havent gotten to it 08:29 < BlueMatt> I'd prefer leaving it in? 08:29 < BlueMatt> afaict its super easy to fix 08:29 < BlueMatt> I'm incredibly confident in the above change 08:29 < BlueMatt> (as its equivalent to the change I've been running for months now) 08:30 < cfields> BlueMatt: point me at a node running it, let's see if i can bring it down :) 08:30 < BlueMatt> the fibre nodes 08:31 < BlueMatt> :p 08:31 < cfields> heh 08:31 -!- Netmage [~Netmage@p5B0A6AE4.dip0.t-ipconnect.de] has quit [Quit: Leaving] 08:32 -!- bsm117532 [~mcelrath@38.121.165.30] has joined #bitcoin-core-dev 08:34 < BlueMatt> I'll swap my public node to master soonish 08:34 < BlueMatt> it gets a shitload of connection churn 08:34 < BlueMatt> and fun spy nodes and shit which do batshit crazy things 08:48 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 08:50 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 08:52 < bitcoin-git> [bitcoin] practicalswift opened pull request #9575: [trivial] Add comment about unreachable code (master...never-executed-comment) https://github.com/bitcoin/bitcoin/pull/9575 08:52 < BlueMatt> jonasschnelli: https://github.com/bitcoin/bitcoin/pull/9461#discussion_r96680764 08:52 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 08:53 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 08:58 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 260 seconds] 09:01 < bitcoin-git> [bitcoin] practicalswift opened pull request #9576: [wallet] Remove redundant initialization (master...remove-redundant-initialization-ii) https://github.com/bitcoin/bitcoin/pull/9576 09:11 -!- waxwing [waxwing@gateway/vpn/mullvad/x-jfnyamketxfmfkgd] has quit [Ping timeout: 245 seconds] 09:12 -!- waxwing [waxwing@gateway/vpn/mullvad/x-zyxuqxqfzxbagpla] has joined #bitcoin-core-dev 09:15 -!- echonaut [~echonaut@46.101.192.134] has quit [Remote host closed the connection] 09:15 -!- echonaut [~echonaut@46.101.192.134] has joined #bitcoin-core-dev 09:26 < cfields> BlueMatt: ok, whipping something up on top of yours. Think I've got a full picture of it all in my head. 09:32 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 09:33 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 09:34 -!- waxwing [waxwing@gateway/vpn/mullvad/x-zyxuqxqfzxbagpla] has quit [Ping timeout: 245 seconds] 09:36 < BlueMatt> cfields: ok, thanks, got distracted on other things 09:46 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Quit: WeeChat 0.4.2] 09:50 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 09:50 -!- waxwing [~waxwing@14.174.32.23] has joined #bitcoin-core-dev 09:51 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has quit [Quit: Leaving] 10:12 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 10:14 -!- handlex [~handlex@2804:14c:658f:4dc7:9880:7b9f:e914:18d9] has quit [Quit: handlex] 10:17 -!- isis [~isis@abulafia.patternsinthevoid.net] has quit [Read error: Connection reset by peer] 10:19 -!- waxwing [~waxwing@14.174.32.23] has quit [Ping timeout: 240 seconds] 10:33 -!- handlex [~handlex@2804:14c:658f:4dc7:9880:7b9f:e914:18d9] has joined #bitcoin-core-dev 10:38 < BlueMatt> someone should tag #9569, #9371 and #9148 for 0.14 because they fix 0.14-tagged issues 10:38 < gribble> https://github.com/bitcoin/bitcoin/issues/9569 | Setting -blocksonly sets -maxmempool to zero. by jnewbery · Pull Request #9569 · bitcoin/bitcoin · GitHub 10:38 < gribble> https://github.com/bitcoin/bitcoin/issues/9371 | Notify on removal by morcos · Pull Request #9371 · bitcoin/bitcoin · GitHub 10:39 < gribble> https://github.com/bitcoin/bitcoin/issues/9148 | Wallet RPCs can return stale info due to ProcessNewBlock Race · Issue #9148 · bitcoin/bitcoin · GitHub 10:47 -!- BitBully [~Mutter@197.210.47.11] has joined #bitcoin-core-dev 10:55 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Quit: Konversation terminated!] 10:58 < BlueMatt> sorry, that last one should be #9570 10:58 < gribble> https://github.com/bitcoin/bitcoin/issues/9570 | Block Wallet RPCs until wallet is synced to our current chain by TheBlueMatt · Pull Request #9570 · bitcoin/bitcoin · GitHub 11:06 < bitcoin-git> [bitcoin] laanwj pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/b0b57a17306a...6012967c4746 11:06 < bitcoin-git> bitcoin/master 843c560 Pieter Wuille: Avoid unaligned access in crypto i/o 11:06 < bitcoin-git> bitcoin/master f94f3e0 Pieter Wuille: Avoid integer overflows in scriptnum tests 11:06 < bitcoin-git> bitcoin/master 6b03bfb Pieter Wuille: Fix memory leak in wallet tests 11:06 < bitcoin-git> [bitcoin] laanwj closed pull request #9512: Fix various things -fsanitize complains about (master...sanitize) https://github.com/bitcoin/bitcoin/pull/9512 11:08 < Chris_Stewart_5> Does some one mind merging in #9350? Pretty trivial, just fixing some documentation on tests 11:08 < gribble> https://github.com/bitcoin/bitcoin/issues/9350 | [Trivial] Adding label for amount inside of tx_valid/tx_invalid.json by Christewart · Pull Request #9350 · bitcoin/bitcoin · GitHub 11:19 -!- blueyez [~AndChat52@112.198.68.10] has quit [Ping timeout: 256 seconds] 11:21 < morcos> wumpus: sipa: I updated #9371 in a way that I think accomplish both of our goals 11:21 < gribble> https://github.com/bitcoin/bitcoin/issues/9371 | Notify on removal by morcos · Pull Request #9371 · bitcoin/bitcoin · GitHub 11:21 * BlueMatt likes it because I have future plans in the area...but will explain on the pr when I review in a minute :p 11:29 -!- BitBully [~Mutter@197.210.47.11] has quit [Read error: Connection reset by peer] 11:32 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 11:34 < cfields> BlueMatt: hmm, looks like that could make your recent-tx cache significantly smarter 11:36 -!- blueyez [~AndChat52@112.198.68.10] has joined #bitcoin-core-dev 11:38 < BlueMatt> yes, lots of ways it could be made smarter :) 11:38 -!- blueyez [~AndChat52@112.198.68.10] has quit [Client Quit] 11:39 -!- moli_ [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer] 11:41 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 11:50 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 11:50 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 11:52 -!- handlex [~handlex@2804:14c:658f:4dc7:9880:7b9f:e914:18d9] has quit [Quit: handlex] 11:57 < bitcoin-git> [bitcoin] jnewbery opened pull request #9577: Fix docstrings in qa tests (master...docstrings) https://github.com/bitcoin/bitcoin/pull/9577 11:58 < BlueMatt> sipa_/wumpus: so I think the only way to fix the regression introduced in #7946 without giving up the gains it gave us is to introduce a second cs_wallet - cs_wallet_locked_before_cs_main 11:58 < gribble> https://github.com/bitcoin/bitcoin/issues/7946 | Reduce cs_main locks during ConnectTip/SyncWithWallets by jonasschnelli · Pull Request #7946 · bitcoin/bitcoin · GitHub 11:58 < BlueMatt> see https://github.com/bitcoin/bitcoin/pull/9570#issuecomment-273583506 11:58 < BlueMatt> please dont kill me 12:01 < cfields> morcos: ah, i missed your comment in the description. I guess i'm requesting choice #1 :) 12:01 < gribble> https://github.com/bitcoin/bitcoin/issues/1 | JSON-RPC support for mobile devices ("ultra-lightweight" clients) · Issue #1 · bitcoin/bitcoin · GitHub 12:02 < BlueMatt> cfields: regarding SyncTransaction changes, see https://github.com/bitcoin/bitcoin/pull/9570/commits/bc4c4c66863fce718402a3f9b2da4e92c1898745 12:02 < BlueMatt> I do remove the NOT_IN_BLOCK kludge ther 12:02 < BlueMatt> e 12:02 < BlueMatt> (but this introduces the need for a second wallet lock) 12:02 < morcos> cfields: I'm trying to do the minimal required in 9371 to fix the regression though.. as it needs to be merged for 0.14... 12:03 < cfields> morcos: ok, fair enough 12:03 < morcos> so i don't want to do a new signal now b/c it will require thinking carefully about what should subscribe to it 12:03 < morcos> but i'm fine dropping the SYNC_TRANASCTION_NOT_IN_BLOCK as BlueMatt did 12:04 < cfields> ok, will look over that one too 12:10 < sipa_> BlueMatt: i'm unclear about it... can you write a simple commit that does the cs_wallet_locked_before_cs_main ? 12:10 < BlueMatt> sipa_: I think we can push off to 0.15, but I will do that, yes, one sec 12:12 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds] 12:15 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 12:21 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 12:24 -!- windsok [~windsok@45.63.59.8] has quit [Ping timeout: 260 seconds] 12:29 -!- juscamarena [~justin@47.148.176.74] has joined #bitcoin-core-dev 12:29 -!- juscamarena_ [~justin@47.148.176.74] has joined #bitcoin-core-dev 12:30 -!- juscamarena_ [~justin@47.148.176.74] has quit [Client Quit] 12:30 -!- handlex [~handlex@2804:14c:658f:4dc7:9880:7b9f:e914:18d9] has joined #bitcoin-core-dev 12:43 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 12:44 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 12:47 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 260 seconds] 12:51 -!- windsok [~windsok@45.63.59.8] has joined #bitcoin-core-dev 12:53 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 12:57 -!- handlex [~handlex@2804:14c:658f:4dc7:9880:7b9f:e914:18d9] has quit [Quit: handlex] 13:00 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 13:07 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 13:07 < luke-jr> done with reviews I think. ping me if there's anything needed priority on before 0.14 freeze. 13:09 -!- CubicEarth [~cubiceart@2002:329f:7e15:0:135:eb13:fc64:80da] has joined #bitcoin-core-dev 13:13 -!- waxwing [~waxwing@14.174.32.23] has joined #bitcoin-core-dev 13:15 -!- isis [~isis@abulafia.patternsinthevoid.net] has joined #bitcoin-core-dev 13:24 -!- wvr [~wvr@116.red-88-8-192.dynamicip.rima-tde.net] has quit [Quit: Leaving] 13:37 -!- CubicEarth [~cubiceart@2002:329f:7e15:0:135:eb13:fc64:80da] has quit [Remote host closed the connection] 13:37 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 13:45 < BlueMatt> sipa_: see https://github.com/TheBlueMatt/bitcoin/commit/c99e4d107aac573e8de892d7592b04c685186e44 13:45 < BlueMatt> specifically, this half-reverts #9570 to get to the behavior intended in #7946 without introducing the getbalance-etc-may-return-data-from-mid-block-processing regression 13:45 < gribble> https://github.com/bitcoin/bitcoin/issues/9570 | Block Wallet RPCs until wallet is synced to our current chain by TheBlueMatt · Pull Request #9570 · bitcoin/bitcoin · GitHub 13:46 < gribble> https://github.com/bitcoin/bitcoin/issues/7946 | Reduce cs_main locks during ConnectTip/SyncWithWallets by jonasschnelli · Pull Request #7946 · bitcoin/bitcoin · GitHub 13:57 -!- cryptapus_afk is now known as cryptapus 14:04 < BlueMatt> someone wanna kick https://travis-ci.org/bitcoin/bitcoin/builds/193151086 ? looks like it failed due to travis timeout because it built dependancies and not because it failed 14:15 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 14:27 -!- bsm117532 [~mcelrath@38.121.165.30] has quit [Ping timeout: 240 seconds] 14:31 < BlueMatt> https://github.com/bitcoin/bitcoin/blob/master/src/txmempool.cpp#L555 <-- that is wrong...100 block reorg and it could blow up (with the checkmempool debug instrumentation enabled) 14:32 -!- bsm117532 [~mcelrath@38.121.165.60] has joined #bitcoin-core-dev 14:34 -!- bsm1175322 [~mcelrath@38.121.165.30] has joined #bitcoin-core-dev 14:35 -!- bsm1175322 [~mcelrath@38.121.165.30] has quit [Remote host closed the connection] 14:36 -!- bsm117532 [~mcelrath@38.121.165.60] has quit [Ping timeout: 240 seconds] 14:37 -!- bsm117532 [~mcelrath@38.121.165.30] has joined #bitcoin-core-dev 14:44 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds] 14:55 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #9578: Add missing mempool lock for CalculateMemPoolAncestors (master...2017-01-fix-missing-wallet-mempool-lock) https://github.com/bitcoin/bitcoin/pull/9578 14:59 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 15:00 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 15:03 -!- cryptapus is now known as cryptapus_afk 15:08 -!- face [~face@mail.hmel.org] has quit [Ping timeout: 240 seconds] 15:08 -!- face [~face@mail.hmel.org] has joined #bitcoin-core-dev 15:10 < cfields> BlueMatt: ok, i've been staring at this for most of the day and i'm reasonably satisfied now. I'm good with your change with 2 tweaks 15:11 < cfields> 1. deserialize the whole thing locally. Same change you made for nVersion, let's go ahead and do that for everything. That way we don't end up in a weird state if something throws 15:11 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 15:11 < cfields> and 2. just a quick reordering that moves the assignment into CNode up a bit, and sets nVersion/fSuccessfullyConnected last. 15:12 -!- vidjogamer [~vidjogame@cpe-65-186-84-210.columbus.res.rr.com] has joined #bitcoin-core-dev 15:16 < cfields> BlueMatt: something like https://github.com/theuni/bitcoin/commit/ed60b005fa0b61ab4454e075e6c7d9a54e2c24a0 on top of yours 15:20 -!- LeMiner [~LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has quit [Read error: Connection reset by peer] 15:24 -!- Netsplit *.net <-> *.split quits: atroxes, jtimon, lejitz, jl2012 15:24 -!- Netsplit over, joins: jl2012, jtimon, lejitz, atroxes 15:29 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 15:45 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 15:47 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds] 16:00 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 16:00 -!- blueyez [~AndChat52@112.198.68.10] has joined #bitcoin-core-dev 16:03 -!- blueyez [~AndChat52@112.198.68.10] has quit [Client Quit] 16:17 -!- Guest88196 [8ac5c302@gateway/web/cgi-irc/kiwiirc.com/ip.138.197.195.2] has joined #bitcoin-core-dev 16:17 < Guest88196> hey guys 16:17 < Guest88196> Allah is doing 16:18 < Guest88196> sun is not doing allah is doing 16:18 < Guest88196> to accept Islam say that i bear witness that there is no deity worthy of worship except Allah and Muhammad peace be upon him is his slave and messenger 16:19 -!- sipa_ is now known as sipa 16:19 -!- sipa [~pw@vps64477.public.cloudvps.com] has quit [Changing host] 16:19 -!- sipa [~pw@unaffiliated/sipa1024] has joined #bitcoin-core-dev 16:19 < sipa> Guest88196: off topic 16:24 -!- Guest88196 [8ac5c302@gateway/web/cgi-irc/kiwiirc.com/ip.138.197.195.2] has quit [Disconnected by services] 16:35 -!- randy-waterhouse [~kiwigb@150.242.128.85] has joined #bitcoin-core-dev 16:35 -!- randy-waterhouse [~kiwigb@150.242.128.85] has quit [Changing host] 16:35 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has joined #bitcoin-core-dev 16:41 -!- cheese_ [~x@2601:985:1:ca10:d127:fce2:25f:efb0] has joined #bitcoin-core-dev 16:41 -!- cheese_ [~x@2601:985:1:ca10:d127:fce2:25f:efb0] has quit [Changing host] 16:41 -!- cheese_ [~x@unaffiliated/cheeseo] has joined #bitcoin-core-dev 16:45 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev 16:46 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 16:51 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Ping timeout: 252 seconds] 16:55 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 16:55 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 16:56 -!- aalex [~aalex@64.187.177.58] has quit [Ping timeout: 248 seconds] 17:00 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 17:00 -!- CubicEarth [~cubiceart@2002:329f:7e15:0:135:eb13:fc64:80da] has joined #bitcoin-core-dev 17:00 -!- cheese_ [~x@unaffiliated/cheeseo] has quit [Read error: Connection reset by peer] 17:37 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-rigunukqnxoybdbs] has quit [Quit: Connection closed for inactivity] 17:45 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has quit [Quit: MarcoFalke] 17:49 -!- CubicEarth [~cubiceart@2002:329f:7e15:0:135:eb13:fc64:80da] has quit [Remote host closed the connection] 17:52 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 17:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 18:00 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Remote host closed the connection] 18:01 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev 18:32 < cfields> BlueMatt: let me know if you want me to PR our combined changes, don't want to rip it out from under you 18:33 -!- e4xit_ [~e4xit@cpc1-cmbg20-2-0-cust188.5-4.cable.virginm.net] has joined #bitcoin-core-dev 18:34 -!- brg444_ [uid207215@gateway/web/irccloud.com/x-qhkhmxjynmhnvpob] has joined #bitcoin-core-dev 18:35 -!- BCBot_ [~BCBot@46.101.246.115] has joined #bitcoin-core-dev 18:35 -!- berndj-blackout [~berndj@mail.azna.co.za] has joined #bitcoin-core-dev 18:36 < BlueMatt> cfields: hummm...feel free 18:36 < BlueMatt> though I'm not a huge fan of that, actually 18:36 -!- kadoban_ [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 18:36 < BlueMatt> wellll 18:36 < BlueMatt> hum 18:36 -!- pigeons_ [~pigeons@94.242.209.214] has joined #bitcoin-core-dev 18:36 < cfields> BlueMatt: heh, one of these days we'll just agree on something and that will be that :) 18:37 -!- sdaftuar_ [~sdaftuar@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 18:37 -!- sipa_ [~pw@vps64477.public.cloudvps.com] has joined #bitcoin-core-dev 18:37 -!- crescend1 [~mozart@173.203.100.20] has joined #bitcoin-core-dev 18:37 < BlueMatt> i mean it just seems shit to do this 18:37 -!- wump [~quassel@pdpc/supporter/professional/wumpus] has joined #bitcoin-core-dev 18:37 < BlueMatt> like, we should always be checking something else 18:37 < sipa_> did i miss something? 18:37 < BlueMatt> https://github.com/theuni/bitcoin/commit/ed60b005fa0b61ab4454e075e6c7d9a54e2c24a0 18:38 < BlueMatt> based on https://github.com/bitcoinfibre/bitcoinfibre/commit/8e2c2cf418adb3dad1479c3f8890e0a2c8b6f709 18:38 < cfields> BlueMatt: well, i have a plan for going forward... 18:38 < BlueMatt> to fix #9212 18:38 < gribble> https://github.com/bitcoin/bitcoin/issues/9212 | Assertion failed: (nSendVersion != 0), function GetSendVersion, file ./net.h, line 775. · Issue #9212 · bitcoin/bitcoin · GitHub 18:38 < cfields> BlueMatt: net side will use fSuccessfullyConnected, processor will use nVersion 18:39 < BlueMatt> oh? 18:39 < cfields> BlueMatt: not sure what you mean by " we should always be checking something else" ? 18:39 < BlueMatt> i mean...ok? 18:39 -!- jyap_ [~jyap@server1.getjumbucks.com] has joined #bitcoin-core-dev 18:39 < BlueMatt> i mean my point is all of this should be redundant 18:40 -!- Lightsword_ [~Lightswor@2604:a880:1:20::1d3:9001] has joined #bitcoin-core-dev 18:40 < cfields> BlueMatt: still not sure what you mean 18:41 < BlueMatt> deserializing into temps should be redundant 18:41 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Disconnected by services] 18:41 -!- kadoban_ is now known as kadoban 18:41 < BlueMatt> ie all of those variables are supposed to be unused prior to version recv 18:42 -!- Netsplit *.net <-> *.split quits: wumpus, GreenIsMyPepper, arubi, pigeons, Chris_Stewart_5, brg444, jyap, lightningbot, TD-Linux, sipa, (+9 more, use /NETSPLIT to show all of them) 18:42 -!- e4xit_ is now known as e4xit 18:42 -!- jyap_ is now known as jyap 18:42 -!- jyap [~jyap@server1.getjumbucks.com] has quit [Changing host] 18:42 -!- jyap [~jyap@unaffiliated/jyap] has joined #bitcoin-core-dev 18:42 -!- Lightsword_ is now known as Lightsword 18:42 -!- brg444_ is now known as brg444 18:43 < cfields> BlueMatt: well sure. But i think it's just sloppy to it half-set if a deserialization throws. 18:45 < BlueMatt> not really? internal state protected by a mutex (nVersion) is allowed to be filled with garbage 18:46 -!- nanotube [~nanotube@unaffiliated/nanotube] has joined #bitcoin-core-dev 18:47 < BlueMatt> anyway, ehh, doesnt matter 18:47 < cfields> BlueMatt: ok, let's put it another way. Why would you prefer not to do them all in place? 18:48 -!- crudel [crudel@gateway/shell/fnordserver.eu/x-rymmioymisjvkbye] has joined #bitcoin-core-dev 18:48 < BlueMatt> extra variables? dont really give a shit, really 18:48 < BlueMatt> think its redundant, but ehh 18:48 < BlueMatt> doesnt matter much 18:49 -!- Netsplit over, joins: Chris_Stewart_5 18:51 -!- berndj-blackout is now known as berndj 19:01 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has joined #bitcoin-core-dev 19:03 -!- TD-Linux [~Thomas@about/essy/indecisive/TD-Linux] has joined #bitcoin-core-dev 19:07 < bitcoin-git> [bitcoin] jtimon opened pull request #9579: Net: Trivial-review: Make SendMessages easier to review (master...0.15-split-sendmessages) https://github.com/bitcoin/bitcoin/pull/9579 19:15 -!- arubi [~ese168@unaffiliated/arubi] has joined #bitcoin-core-dev 19:23 -!- GreenIsMyPepper [~GreenIsMy@2605:6400:20:11aa:189e:28a5:52ed:8948] has joined #bitcoin-core-dev 19:31 -!- pigeons_ is now known as pigeons 20:00 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has quit [Quit: Leaving.] 20:03 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has quit [Ping timeout: 255 seconds] 20:11 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 20:13 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 276 seconds] 20:28 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection] 20:29 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev 20:56 -!- xinxi [~xinxi@183.214.201.83] has joined #bitcoin-core-dev 21:00 -!- dermoth [~thomas@201-77.162.dsl.aei.ca] has quit [Read error: Connection reset by peer] 21:01 -!- dermoth [~thomas@201-77.162.dsl.aei.ca] has joined #bitcoin-core-dev 22:03 -!- wump is now known as wumpus 22:24 < bitcoin-git> [bitcoin] droark opened pull request #9580: Fix various minor linearization script issues (master...linearizefix) https://github.com/bitcoin/bitcoin/pull/9580 22:42 -!- davec [~davec@cpe-24-243-230-253.hot.res.rr.com] has quit [Quit: leaving] 22:57 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-aiucapxtvkxbkevo] has joined #bitcoin-core-dev 22:59 < bitcoin-git> [bitcoin] laanwj closed pull request #9529: Bug fix: Update the instance variable self.lastDate (not the locally scoped variable lastDate) (master...fix-bug-in-BlockDataCopier) https://github.com/bitcoin/bitcoin/pull/9529 23:02 -!- zxzzt [~prod@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Ping timeout: 246 seconds] 23:02 -!- zxzzt [~prod@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 23:02 -!- ryanofsky [~russ@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Ping timeout: 256 seconds] 23:03 -!- ryanofsky [~russ@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 23:12 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev 23:19 -!- aalex [~aalex@64.187.177.58] has quit [Ping timeout: 240 seconds] 23:21 -!- jeremyru1in is now known as jeremyrubin 23:25 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds]