--- Day changed Thu Jan 19 2017
00:00 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]     
00:04 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev     
00:04 < bitcoin-git> [bitcoin] laanwj pushed 11 new commits to master: https://github.com/bitcoin/bitcoin/compare/6012967c4746...9c9af5ab2d9e
00:04 < bitcoin-git> bitcoin/master c735540 Matt Corallo: Move ORPHAN constants from validation.h to net_processing.h
00:04 < bitcoin-git> bitcoin/master edded80 Matt Corallo: Make ATMP optionally return the CTransactionRefs it replaced
00:04 < bitcoin-git> bitcoin/master 1531652 Matt Corallo: Keep shared_ptrs to recently-replaced txn for compact blocks
00:04 < bitcoin-git> [bitcoin] laanwj closed pull request #9499: Use recent-rejects, orphans, and recently-replaced txn for compact-block-reconstruction (master...2016-12-recent-tx-cache-cmpct) https://github.com/bitcoin/bitcoin/pull/9499
00:10 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving]     
00:28 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
00:49 -!- echonaut [~echonaut@46.101.192.134] has quit [Remote host closed the connection]     
00:49 -!- echonaut [~echonaut@46.101.192.134] has joined #bitcoin-core-dev     
00:54 -!- vidjogamer [~vidjogame@cpe-65-186-84-210.columbus.res.rr.com] has quit [Remote host closed the connection]     
01:11 -!- juscamarena [~justin@47.148.176.74] has quit [Remote host closed the connection]     
01:14 < bitcoin-git> [bitcoin] practicalswift opened pull request #9581: [pep-8] Prefer "foo not in bar" to "not foo in bar" (master...test-for-membership) https://github.com/bitcoin/bitcoin/pull/9581
01:17 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #bitcoin-core-dev     
01:20 -!- echonaut [~echonaut@46.101.192.134] has quit [Remote host closed the connection]     
01:21 -!- echonaut [~echonaut@46.101.192.134] has joined #bitcoin-core-dev     
01:22 -!- waxwing [~waxwing@14.174.32.23] has quit [Ping timeout: 240 seconds]     
01:35 -!- waxwing [~waxwing@193.138.219.236] has joined #bitcoin-core-dev     
01:53 < bitcoin-git> [bitcoin] practicalswift opened pull request #9582: [pep-8] Prefer "foo is None" to "foo == None" (master...is-none) https://github.com/bitcoin/bitcoin/pull/9582
01:56 < bitcoin-git> [bitcoin] fanquake closed pull request #9582: [pep-8] Prefer "foo is None" to "foo == None" (master...is-none) https://github.com/bitcoin/bitcoin/pull/9582
01:56 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev     
02:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
02:24 -!- gabby_carol [~pride@2804:7f1:1280:b1cb:388c:f94f:3cad:86dc] has joined #bitcoin-core-dev     
02:30 -!- gabby_carol [~pride@2804:7f1:1280:b1cb:388c:f94f:3cad:86dc] has quit [Quit: Leaving]     
02:33 -!- Netsplit *.net <-> *.split quits: arubi
02:35 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev     
02:36 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection]     
02:37 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev     
02:56 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Quit: Leaving.]     
03:26 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev     
03:47 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection]     
03:48 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev     
04:02 -!- cannon-c [ccc23f04@gateway/web/freenode/ip.204.194.63.4] has joined #bitcoin-core-dev     
04:23 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev     
04:25 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev     
04:34 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev     
04:58 -!- aalex [~aalex@64.187.177.58] has quit [Ping timeout: 258 seconds]     
05:12 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9c9af5ab2d9e...41cb05cc8f3c
05:12 < bitcoin-git> bitcoin/master fc089ae James White: Add IPv6 support to qos.sh
05:12 < bitcoin-git> bitcoin/master 41cb05c Wladimir J. van der Laan: Merge #9552: Add IPv6 support to qos.sh...
05:12 < bitcoin-git> [bitcoin] laanwj closed pull request #9552: Add IPv6 support to qos.sh (master...qos-ipv6) https://github.com/bitcoin/bitcoin/pull/9552
05:25 -!- windsok [~windsok@45.63.59.8] has quit [Ping timeout: 276 seconds]     
05:45 -!- wvr [~wvr@116.red-88-8-192.dynamicip.rima-tde.net] has joined #bitcoin-core-dev     
05:52 -!- cannon-c [ccc23f04@gateway/web/freenode/ip.204.194.63.4] has quit [Quit: Page closed]     
06:08 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
06:09 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit]     
06:16 -!- windsok [~windsok@45.63.59.8] has joined #bitcoin-core-dev     
06:21 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/41cb05cc8f3c...e9e7993007a9
06:21 < bitcoin-git> bitcoin/master c70622e John Newbery: Docs: Update CONTRIBUTING.md...
06:21 < bitcoin-git> bitcoin/master e9e7993 Wladimir J. van der Laan: Merge #9542: Docs: Update CONTRIBUTING.md...
06:21 < bitcoin-git> [bitcoin] laanwj closed pull request #9542: Docs: Update CONTRIBUTING.md (master...CONTRIBUTINGcomponents) https://github.com/bitcoin/bitcoin/pull/9542
06:29 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
06:29 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/e9e7993007a9...054d664215ca
06:29 < bitcoin-git> bitcoin/master 9f03110 Jeremy Rubin: Add Basic CheckQueue Benchmark
06:29 < bitcoin-git> bitcoin/master aad4cb5 Jeremy Rubin: Address ryanofsky feedback on CCheckQueue benchmarks. Eliminated magic numbers, fixed scoping of vectors (and memory movement component of benchmark).
06:29 < bitcoin-git> bitcoin/master 054d664 Wladimir J. van der Laan: Merge #9498: Basic CCheckQueue Benchmarks...
06:29 < bitcoin-git> [bitcoin] laanwj closed pull request #9498: Basic CCheckQueue Benchmarks (master...checkqueue_bench) https://github.com/bitcoin/bitcoin/pull/9498
06:31 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit]     
06:36 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
06:44 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev     
06:46 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt]     
07:23 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev     
07:25 -!- hosiawak [~user@ip-222-90.ists.pl] has joined #bitcoin-core-dev     
07:27 -!- jnewbery1 [~Thunderbi@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev     
07:39 -!- whphhg [whphhg@gateway/vpn/mullvad/x-vfbhxndhhvtxnqoi] has quit [Ping timeout: 256 seconds]     
07:40 -!- whphhg [whphhg@gateway/vpn/mullvad/x-byfqcoscdlsujgzm] has joined #bitcoin-core-dev     
07:52 -!- hosiawak [~user@ip-222-90.ists.pl] has quit [Read error: Connection reset by peer]     
07:59 -!- xinxi [~xinxi@183.214.201.83] has quit [Read error: Connection reset by peer]     
08:01 -!- xinxi [~xinxi@183.214.201.83] has joined #bitcoin-core-dev     
08:02 < instagibbs> When is feature freeze happening? May have missed memo if changed.
08:05 < sipa_> it was postponed to today, i believe
08:06 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #9583: Move wallet callbacks into cs_main (this effectively reverts #7946) (master...2017-01-revert-7946) https://github.com/bitcoin/bitcoin/pull/9583
08:12 < BlueMatt> sorry jonasschnelli, I think we waited too long to fix all the issues #7946 caused for 0.14
08:12 < gribble> https://github.com/bitcoin/bitcoin/issues/7946 | Reduce cs_main locks during ConnectTip/SyncWithWallets by jonasschnelli · Pull Request #7946 · bitcoin/bitcoin · GitHub
08:14 < BlueMatt> in 0.15 we'll need to re-add it
08:17 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
08:17 < sipa_> all we need is that the wallet has its own idea of what the best chain is, right?
08:17 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit]     
08:17 < sipa_> so its responses are consistent
08:17 < BlueMatt> morcos: is writing up an issue with two other concerns we just found
08:18 < BlueMatt> even #9570 is a big chunk of code for 0.14
08:18 < gribble> https://github.com/bitcoin/bitcoin/issues/9570 | Block Wallet RPCs until wallet is synced to our current chain by TheBlueMatt · Pull Request #9570 · bitcoin/bitcoin · GitHub
08:18 < BlueMatt> and it would need a few more changes
08:18 < sipa_> sigh
08:19 < BlueMatt> sipa_: did you look at 9570?
08:19 < BlueMatt> its nontrivial
08:19 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]     
08:19 < sipa_> but is it needed once the wallet has its own idea about the chaintip?
08:19 < BlueMatt> 9570 gives the wallet its own idea about the chaintip
08:19 < sipa_> oh     
08:19 < BlueMatt> though not in a very full-featured way
08:19 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
08:20 < BlueMatt> but, its a bit too late to be making major changes like that for 0.14, I think
08:20 < BlueMatt> i think at the start of the 0.15 release cycle we should move the wallet callbacks into a separate thread with all these fixes and let it simmer for 0.15
08:20 < sipa_> ok     
08:21 < BlueMatt> same with multi-threaded message handler
08:21 < BlueMatt> 'cause a lot of these wallet issues on master are only realistic if you call submitblock (though some are also triggerable as a result of the additional ActivateBestChains added in #9375)
08:22 < gribble> https://github.com/bitcoin/bitcoin/issues/9375 | Relay compact block messages prior to full block connection by TheBlueMatt · Pull Request #9375 · bitcoin/bitcoin · GitHub
08:24 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 260 seconds]     
08:28 < morcos> sipa: #9584
08:28 < gribble> https://github.com/bitcoin/bitcoin/issues/9584 | Synchronization problems with wallet. · Issue #9584 · bitcoin/bitcoin · GitHub
08:29 < bitcoin-git> [bitcoin] TheBlueMatt closed pull request #9570: Block Wallet RPCs until wallet is synced to our current chain (master...2017-01-fix-wallet-rpc-stale) https://github.com/bitcoin/bitcoin/pull/9570
08:49 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev     
08:49 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
09:19 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
09:19 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit]     
09:21 -!- wvr [~wvr@116.red-88-8-192.dynamicip.rima-tde.net] has left #bitcoin-core-dev ["Leaving"]     
09:32 -!- aalex [~aalex@64.187.177.58] has quit [Ping timeout: 276 seconds]     
09:36 -!- handlex [~handlex@2804:14c:658f:4dc7:204e:6e98:8b3:982] has joined #bitcoin-core-dev     
09:38 -!- handlex [~handlex@2804:14c:658f:4dc7:204e:6e98:8b3:982] has quit [Client Quit]     
09:42 -!- waxwing [~waxwing@193.138.219.236] has quit [Ping timeout: 255 seconds]     
09:58 -!- sipa_ is now known as sipa     
10:00 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has quit [Ping timeout: 255 seconds]     
10:17 -!- MarcoFalke [~marco@2001:4ca0:0:f226:a063:75b:7f88:d780] has joined #bitcoin-core-dev     
10:22 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev     
10:23 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev     
10:35 < luke-jr> sipa: Can you give me a text-"verbal" okay for some license to put on BIPs 30, 32, 62, 66, and 103?
10:35 < luke-jr> CodeShark: ^ for BIP 123
10:39 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev     
10:43 < cfields> BlueMatt/morcos: I'm staring at the locking issue too, writing up some potential fixes (throwaways) in order to understand the issue fully
10:44 -!- norotartagen [~norotarta@71-89-76-184.dhcp.bycy.mi.charter.com] has quit [Quit: Leaving]     
10:48 < MarcoFalke> jonasschnelli: #9461 is ready for merge, if you are here right now.
10:48 < gribble> https://github.com/bitcoin/bitcoin/issues/9461 | [Qt] Improve progress display during headers-sync and peer-finding by jonasschnelli · Pull Request #9461 · bitcoin/bitcoin · GitHub
10:49 < MarcoFalke> Fixing the nit should be done for the whole src/qt tree, so you can leave it for another pull
10:50 < instagibbs> reminder: meeting in 10
10:50 < MarcoFalke> oh nice. Will be here today
10:50 < MarcoFalke> :P     
10:50 -!- norotartagen [~norotarta@71-89-76-184.dhcp.bycy.mi.charter.com] has joined #bitcoin-core-dev     
10:50 < MarcoFalke> I think #9554 is ready as well.
10:50 < gribble> https://github.com/bitcoin/bitcoin/issues/9554 | [test] Avoid potential NULL pointer dereference in addrman_tests.cpp by practicalswift · Pull Request #9554 · bitcoin/bitcoin · GitHub
10:52 < MarcoFalke> I remember someone was worried about NULL pointer derefs showing up in the release notes and they cause panic, when in fact there should be no reason to panic...
10:52 < MarcoFalke> Should I change the title before merge?
10:52 < wumpus> yes, if you change the title preferably do it before merge
10:53 < CodeShark> luke-jr: license?
10:53 < luke-jr> CodeShark: yes, for the BIP text
10:54 < CodeShark> public domain, not sure what you mean by license
10:54 < CodeShark> Example?
10:55 < luke-jr> ok, PD is acceptable since it predates BIP 2 I guess
10:55 < MarcoFalke> ugh, another 0.14 blocker: #9585
10:55 < gribble> https://github.com/bitcoin/bitcoin/issues/9585 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
10:55 < luke-jr> CodeShark: ideally it would be one of https://github.com/bitcoin/bips/blob/master/bip-0002.mediawiki#Recommended_licenses
10:55 < CodeShark> Or what would you suggest otherwise?
10:55 < cfields> MarcoFalke: Not a feature-freeze blocker, just a bug
10:56 < CodeShark> luke-jr: ok, let me look it over and get back to you then
10:56 < luke-jr> CodeShark: k thanks
10:56 < BlueMatt> any last-minute review for #8456?
10:56 < BlueMatt> or #9461?
10:56 < BlueMatt> or #9294
10:56 < gribble> https://github.com/bitcoin/bitcoin/issues/8456 | [RPC] Simplified bumpfee command. by mrbandrews · Pull Request #8456 · bitcoin/bitcoin · GitHub
10:56 < gribble> https://github.com/bitcoin/bitcoin/issues/9461 | [Qt] Improve progress display during headers-sync and peer-finding by jonasschnelli · Pull Request #9461 · bitcoin/bitcoin · GitHub
10:56 < gribble> https://github.com/bitcoin/bitcoin/issues/9294 | Use internal HD chain for change outputs (hd split) by jonasschnelli · Pull Request #9294 · bitcoin/bitcoin · GitHub
10:56 < BlueMatt> those are the 3 for feature freeze
10:56 < wumpus> MarcoFalke: well if push comes to shove we can always revert the qt version bump
10:57 < MarcoFalke> Jup     
10:57 < luke-jr> IMO 8456 can be merged
10:57 < luke-jr> 9294 is prob good too, maybe btcdrak wants to re-ACK
10:59 < sdaftuar_> cfields: when you have a chance, please see #9586
10:59 < bitcoin-git> [bitcoin] laanwj closed pull request #8456: [RPC] Simplified bumpfee command. (master...ba-rpcbumpfee) https://github.com/bitcoin/bitcoin/pull/8456
10:59 < gribble> https://github.com/bitcoin/bitcoin/issues/9586 | bip68-sequence.py failing on master after recent net changes, due to mocktime interaction · Issue #9586 · bitcoin/bitcoin · GitHub
11:00 -!- sdaftuar_ is now known as sdaftuar     
11:00 < sipa> PLOINK
11:00 < jonasschnelli> \o/     
11:00 < BlueMatt> mtg time
11:00 < wumpus> #startmeeting
11:00 < lightningbot> Meeting started Thu Jan 19 19:00:10 2017 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
11:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
11:00 < Chris_Stewart_5> ello
11:00 < MarcoFalke> cfields: If you need the gitian log for the failing build: https://bitcoin.jonasschnelli.ch/nightlybuilds/2017-01-19/build-win.log
11:00 < cfields> MarcoFalke: ah, didn't realize gitian was actually failing. Thanks.
11:00 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 instagibbs
11:00 < morcos> here
11:00 < CodeShark> Hi     
11:01 < instagibbs> prezent
11:01 < MarcoFalke> topics?
11:01 < jtimon> here
11:01 < morcos> suggested topic #9583 and #9584
11:01 < wumpus> topic: last-minute merges before feature freeze
11:01 < gribble> https://github.com/bitcoin/bitcoin/issues/9583 | Move wallet callbacks into cs_main (this effectively reverts #7946) by TheBlueMatt · Pull Request #9583 · bitcoin/bitcoin · GitHub
11:01 < gribble> https://github.com/bitcoin/bitcoin/issues/9584 | Synchronization problems with wallet. · Issue #9584 · bitcoin/bitcoin · GitHub
11:01 < instagibbs> Last stuff to shove in before freeze naturally...
11:01 < kanzure> hi.     
11:01 < jonasschnelli> I guess https://github.com/bitcoin/bitcoin/issues/9294 is ready...
11:02  * btcdrak is half here
11:02 < gmaxwell> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier
11:02 < sipa> any 0.14 milestoned PRs that we don't expect are reasonable to make it?
11:02 < jtimon> suggested topic, what's missing to branch 0.14
11:02 < BlueMatt> #9535 got thourough review from jtimon (and others) and is a big win
11:02 < wumpus> do we all agree 9294 is ready?
11:02 < gribble> https://github.com/bitcoin/bitcoin/issues/9535 | Split CNode::cs_vSend: message processing and message sending by TheBlueMatt · Pull Request #9535 · bitcoin/bitcoin · GitHub
11:02 < instagibbs> any multiwallet stuff isn't going to make it I assume
11:02 < BlueMatt> i like 9294, but i think it needs another review
11:02 < wumpus> multiwallet was already untagged 
11:02 < BlueMatt> I'm ok with merge as long as one or two folks give it a postumous ack
11:03 < sipa> i have not reviewed 9294, sorry
11:03 < gmaxwell> https://github.com/bitcoin/bitcoin/milestone/21
11:03 < sipa> (but i plan to, whether it's merged or not)
11:03 < jonasschnelli> we can always fix issues after the freeze
11:03 < instagibbs> I could give it an updated review, but not sure if that's enough
11:03 < luke-jr> there's a pre-MW PR that's probably ready, but not a prioirty
11:04 < sipa> pre-mimblewimble?
11:04 < jonasschnelli> heh     
11:04 < gmaxwell> I think #9526 should be dropped from that. (perhaps we should do something later, but it shouldn't be tagged #14)
11:04 < luke-jr> multiwallet ;)
11:04 < gribble> https://github.com/bitcoin/bitcoin/issues/9526 | -blocksonly should disable sharing of mempool with dbcache · Issue #9526 · bitcoin/bitcoin · GitHub
11:04 < gribble> https://github.com/bitcoin/bitcoin/issues/14 | bitcoin: URI and/or bitcoin-request MIME type for click-to-pay · Issue #14 · bitcoin/bitcoin · GitHub
11:04 < btcdrak> issue #14 ? 
11:04 < gribble> https://github.com/bitcoin/bitcoin/issues/14 | bitcoin: URI and/or bitcoin-request MIME type for click-to-pay · Issue #14 · bitcoin/bitcoin · GitHub
11:04 < BlueMatt> I'd consider 9526 is a bugfix, but i guess i dont care strongly either way
11:04 < luke-jr> #8775 specifically
11:04 < gribble> https://github.com/bitcoin/bitcoin/issues/8775 | RPC refactoring: Access wallet using new GetWalletForJSONRPCRequest by luke-jr · Pull Request #8775 · bitcoin/bitcoin · GitHub
11:04 < sipa> i think 9526 is a bugfix
11:04 < luke-jr> but it seems it conflicted again, so I guess less than ready anyway :x
11:05 < BlueMatt> ok, so to conclude, #9461 and #9294 - 9461 i think is ready-ish (one more look-over, please, its easy?), and 9294 I think we should merge with a few commitments to postumous reviews
11:05 < gribble> https://github.com/bitcoin/bitcoin/issues/9461 | [Qt] Improve progress display during headers-sync and peer-finding by jonasschnelli · Pull Request #9461 · bitcoin/bitcoin · GitHub
11:05 < gribble> https://github.com/bitcoin/bitcoin/issues/9294 | Use internal HD chain for change outputs (hd split) by jonasschnelli · Pull Request #9294 · bitcoin/bitcoin · GitHub
11:06 < jtimon> I generally dislike that we fork the branch knowing that some fix will be needed in both branches in advance
11:06 < BlueMatt> 9377 we agreed previously was bugfix, and 9526, if we merge it for 14, i'd call a bugfix
11:07 < MarcoFalke> jtimon: There won't be a branch today
11:07 < BlueMatt> jtimon: no, we branch in 2 weeks
11:07 < MarcoFalke> We still have next week to fix bugs
11:07 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 258 seconds]     
11:07 < jtimon> the whole "we can merge it after fork, because it's a bugfix" concept
11:07 < sipa> the fork is only in 2 weeks
11:07 < wumpus> who is talking about a fork?
11:07 < sipa> bugfixes can go in in between
11:07 < wumpus> bugfixes can be merged, by definition, after the feature freeze
11:07 < jtimon> oh, I see, just mean 0.14 git fork, ie just branching
11:07 < wumpus> because it's a feature freeze nto a bug fix freeze
11:08 < jonasschnelli> Yes. And technically 9294 is kind-of-a-fix for the missed HD chain split in 0.13. And there are no things to fix... only stuff to improve
11:08 < sipa> jtimon: today (or whenever we decide) is the feature freeze. the actual 0.14 branch is only created in 2 weeks
11:08 < BlueMatt> 9294 has string changes, so must be today or not at all
11:08 < wumpus> the branch is created at rc1 time
11:08 < jtimon> sipa: thanks I mixed feature freeze with branching
11:08 < jonasschnelli> BlueMatt: Yes. I'm happy to merge it without the Consensus::Params::nPowTargetTimespan change
11:08 < wumpus> (so that releases happen from a branch, not from master)
11:09 < jonasschnelli> If no objections...
11:09 < BlueMatt> jonasschnelli: open a new pr for that change, and then merge it, I'd say
11:09 < MarcoFalke> jonasschnelli: Agree
11:09 < BlueMatt> (merge the one without the Consensus::Params thing, then open a pr to change it)
11:09 < jonasschnelli> Okay.
11:09 < jtimon> so ideally all the bugfixes we know will be merged before branching, forget about my previous comment then
11:09 < morcos> I apologize for not reviewing 9294, but i feel like i never got up to speed enough with the code in question.  I do thik that although it's not critical and isn't already tagged 0.14, #9535 could be merged now and i know cfields wants it too
11:09 < gribble> https://github.com/bitcoin/bitcoin/issues/9535 | Split CNode::cs_vSend: message processing and message sending by TheBlueMatt · Pull Request #9535 · bitcoin/bitcoin · GitHub
11:10 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2ef52d3cf11b...b25068697fdb
11:10 < bitcoin-git> bitcoin/master 40ec7c7 Jonas Schnelli: [Qt] Improve progress display during headers-sync and peer-finding
11:10 < bitcoin-git> bitcoin/master b250686 Jonas Schnelli: Merge #9461: [Qt] Improve progress display during headers-sync and peer-finding...
11:10 < wumpus> all the bugfixes we know and can realistically make the release (or are critical enough to delay it) should be merged before rc1, yes, thus before the branch
11:10 < gmaxwell> luke-jr: multiwallet pains me. because darn, such a simple set of changes remaining.  we need to get out of this mode where all the intensity is in the week before feature freeze. :P  (maybe new major version every month. :P )
11:10 < sipa> i think 9525 is pretty trivial
11:10 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #9461: [Qt] Improve progress display during headers-sync and peer-finding (master...2017/01/qt_sync) https://github.com/bitcoin/bitcoin/pull/9461
11:10 < sipa> eh, 9535
11:11 < wumpus> all the intensity isn't in the week before feature freeze, we've merged tons of stuff in the last months
11:11 < morcos> it's got enough ack's are there any objections to 9535 sipa?
11:11 < luke-jr> it's okay
11:11 < BlueMatt> sipa: ok, so press the button? I'd call jtimon's review pretty thourough (even ignoring all the lock testing I plan on doing in the next 2 weeks)
11:11 < wumpus> and some things won't make a release, that's okay
11:12 < jtimon> BlueMatt: I wouldn't call it complete, but I noted the parts I did not do
11:12 < wumpus> priority for 0.14 is solving the nasty remaining issues, like the wallet sync problems
11:12 < BlueMatt> ok, so we need to figure out what to do about #9294, does anyone have any objections to merging so that we can freeze and getting postumous acks?
11:12 < gribble> https://github.com/bitcoin/bitcoin/issues/9294 | Use internal HD chain for change outputs (hd split) by jonasschnelli · Pull Request #9294 · bitcoin/bitcoin · GitHub
11:12 < morcos> assuming someone is about to press merge on 9535, the only open question is do we hold off the feature freeze for 9294  (what he said)
11:13 < BlueMatt> wumpus: next topic...lets finalize list of things for freeze today first :p
11:13 < wumpus> BlueMatt: I agree with the two you mentioned
11:14 < cfields> i'm afraid i'm unable to provide meaningful review on 9294. I had a few nits that weren't worth pointing out, but nothing else
11:14 < wumpus>  #9461 and #9294 
11:14 < gribble> https://github.com/bitcoin/bitcoin/issues/9461 | [Qt] Improve progress display during headers-sync and peer-finding by jonasschnelli · Pull Request #9461 · bitcoin/bitcoin · GitHub
11:14 < gribble> https://github.com/bitcoin/bitcoin/issues/9294 | Use internal HD chain for change outputs (hd split) by jonasschnelli · Pull Request #9294 · bitcoin/bitcoin · GitHub
11:14 < sipa> what about #9519 and #9377. are those bugfixes?
11:14 < jonasschnelli> 9461 is merged
11:14 < gribble> https://github.com/bitcoin/bitcoin/issues/9519 | Exclude RBF replacement txs from fee estimation by morcos · Pull Request #9519 · bitcoin/bitcoin · GitHub
11:14 < gribble> https://github.com/bitcoin/bitcoin/issues/9377 | fundrawtransaction: Keep change-output keys by default, make it optional by jonasschnelli · Pull Request #9377 · bitcoin/bitcoin · GitHub
11:14 < BlueMatt> sipa: yes, bugfixes with no translation string changes
11:14 < sipa> ok     
11:14 < morcos> 9519 is a bugfix and it's extremely simple
11:14 < BlueMatt> (if we decide to merge them, I'm confident in calling both bugfixes)
11:14  * jonasschnelli going to rebase 9377
11:15 < jtimon> cfields: same for me, I just did concept aCK for #9294
11:15 < gribble> https://github.com/bitcoin/bitcoin/issues/9294 | Use internal HD chain for change outputs (hd split) by jonasschnelli · Pull Request #9294 · bitcoin/bitcoin · GitHub
11:15 < instagibbs> If it helps hd split get in, I promise a tACK after the fact
11:16 < cfields> sipa: do you plan on needing to change any behavior or meaning of any options for #9526?
11:16 < gribble> https://github.com/bitcoin/bitcoin/issues/9526 | -blocksonly should disable sharing of mempool with dbcache · Issue #9526 · bitcoin/bitcoin · GitHub
11:16 < wumpus> ok that leaves #9294 then, let's all review that
11:16 < gribble> https://github.com/bitcoin/bitcoin/issues/9294 | Use internal HD chain for change outputs (hd split) by jonasschnelli · Pull Request #9294 · bitcoin/bitcoin · GitHub
11:16 < BlueMatt> ok, so acks on the following for today: hd split (9294), net lock split (9535)
11:16 < wumpus> #action review #9294 asap so it can still make the cut
11:16 < gribble> https://github.com/bitcoin/bitcoin/issues/9294 | Use internal HD chain for change outputs (hd split) by jonasschnelli · Pull Request #9294 · bitcoin/bitcoin · GitHub
11:16 < BlueMatt> then we can move on to next topic
11:17 < jonasschnelli> Should we touch/chat about the wallet sync issue? https://github.com/bitcoin/bitcoin/pull/9583
11:17 < BlueMatt> ok, next topic: wallet inconsistency (revert #7946 for 0.14 is pr 9583), see issue #9584 and #9148
11:17 < gribble> https://github.com/bitcoin/bitcoin/issues/7946 | Reduce cs_main locks during ConnectTip/SyncWithWallets by jonasschnelli · Pull Request #7946 · bitcoin/bitcoin · GitHub
11:17 < BlueMatt> ?     
11:17 < gribble> https://github.com/bitcoin/bitcoin/issues/9584 | Synchronization problems with wallet. · Issue #9584 · bitcoin/bitcoin · GitHub
11:17 < gribble> https://github.com/bitcoin/bitcoin/issues/9148 | Wallet RPCs can return stale info due to ProcessNewBlock Race · Issue #9148 · bitcoin/bitcoin · GitHub
11:17 < wumpus> #topic #9583 and #9584 (morcos)
11:17 < gribble> https://github.com/bitcoin/bitcoin/issues/9583 | Move wallet callbacks into cs_main (this effectively reverts #7946) by TheBlueMatt · Pull Request #9583 · bitcoin/bitcoin · GitHub
11:17 < gribble> https://github.com/bitcoin/bitcoin/issues/9584 | Synchronization problems with wallet. · Issue #9584 · bitcoin/bitcoin · GitHub
11:18 < morcos> gmaxwell: please make sure you see this so you don't complain later that you didn't realize we were sticking everything back into cs_main again
11:18 < jonasschnelli> I apologise for 7946,... I wasn't aware that this could cause sync issues
11:18 < wumpus> I tagged 9535 for 0.14 (I uess that's the intent?)
11:18 < BlueMatt> jonasschnelli: ehh, nbd, thats why it was early in a release cycle...sadly no one fixed it before now :(
11:18 < morcos> wumpus: yes or just merge. i think its ready, but not sure why it hasn't been
11:18 < BlueMatt> turns out there is complicated machinery to fix it, eg #9570
11:18 < gribble> https://github.com/bitcoin/bitcoin/issues/9570 | Block Wallet RPCs until wallet is synced to our current chain by TheBlueMatt · Pull Request #9570 · bitcoin/bitcoin · GitHub
11:18 < BlueMatt> but like x2
11:19 < BlueMatt> I'm working on a version of it, but I really dont like that much change this late in cycle
11:19 < BlueMatt> so hopefully we can get the changes in super early in 0.15, and get lots of eyes on it through that cylc
11:19 < BlueMatt> e     
11:19 < BlueMatt> ^ this is my recommendation
11:19 < wumpus> morcos: well it's not tagged for 0.14, so it has been hidden for me as that's what I've been focusing on
11:19 < BlueMatt> which is merge 9583
11:20 < BlueMatt> wumpus: the issue to track this (9148) has been tagged for 14 all along
11:20 < CodeShark> What's the target date for 0.15?
11:20 < cfields> BlueMatt: which is your recommendation? 9538?
11:20 < BlueMatt> cfields: yes
11:20 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/b25068697fdb...82274c02ed2d
11:20 < cfields> heh, laggy.
11:20 < bitcoin-git> bitcoin/master d7c58ad Matt Corallo: Split CNode::cs_vSend: message processing and message sending...
11:20 < bitcoin-git> bitcoin/master 376b3c2 Matt Corallo: Make the cs_sendProcessing a LOCK instead of a TRY_LOCK...
11:20 < bitcoin-git> bitcoin/master 82274c0 Wladimir J. van der Laan: Merge #9535: Split CNode::cs_vSend: message processing and message sending...
11:20 < bitcoin-git> [bitcoin] laanwj closed pull request #9535: Split CNode::cs_vSend: message processing and message sending (master...2017-01-cs-vsend-split) https://github.com/bitcoin/bitcoin/pull/9535
11:21 < morcos> Can anyone think of any downside for merging 9583?  Is there any chance we made further changes later that somehow were depending on the fact that we weren't holding cs_main through the wallet updates any more?
11:21 < cfields> BlueMatt: sadly, I think I agree. I've been down the rabbit hole today trying to come up with something simple, and it gets more complicated (and I become less comfortable) quickly.
11:21 < wumpus> CodeShark: see https://github.com/bitcoin/bitcoin/issues/8719
11:21 < morcos> I can't think of anything htat could make sense, but really thats the only downside I could imagine... Otherwise its just not making an improvement that would have been nice to make..
11:22 < CodeShark> wumpus: thx
11:22 < jonasschnelli> morcos: Yes. Downside is slighly slower sync/rescan
11:22 < BlueMatt> (and I do not believe it is (yet) a major performance regression because this is pretty much all called from the single ProcessMessages thread)
11:22 < gmaxwell> I don't think any design depended on not holding it, varrious testing might have.
11:22 < gmaxwell> jonasschnelli: I don't see how it could result in a slower sync, it's all in one thread.
11:22 < gmaxwell> (and the networking thread doesn't itself grab cs_main)
11:23 < cfields> morcos: isn't there still one site where it gets called without cs_main though?
11:23 < jonasschnelli> Hmm.. I guess I'm wrong. #7946 didn't and it was acctually a stepping stone for stuff that's not PRed.
11:23 < gribble> https://github.com/bitcoin/bitcoin/issues/7946 | Reduce cs_main locks during ConnectTip/SyncWithWallets by jonasschnelli · Pull Request #7946 · bitcoin/bitcoin · GitHub
11:23 < BlueMatt> my intention for 0.15 is to move these callbacks into a background thread asap
11:24 < BlueMatt> cfields: that will not be true after the revert, i think
11:24 < morcos> cfields: Do you mean after the reversion in 9583?  I don't think so?
11:25 < cfields> ok, maybe i traced it wrong. Will do again.
11:25 < BlueMatt> ok, if no one has any conceptual objections to 9583, then I dont think there is much to discuss on it now, just note that thoruough review is needed
11:25 < wumpus> any other proposed topics?
11:25 < sipa> sad, but i accept that 9583 is probably the only viable solution for 0.14
11:26 < BlueMatt> indeed
11:26 < BlueMatt> one step forward, one step back, but at least we learned something
11:26 < BlueMatt> 2 steps forward for 0.15 :)
11:26 < luke-jr> ☺     
11:27 < jonasschnelli> We could wrap it in #ifdef WALLET_ENABLED... *duck*
11:27 < BlueMatt> its used in net_processing
11:27 < jonasschnelli> I meant the cs_main lock for SyncTransaction, but just kidding. 
11:29 < wumpus> any other proposed topics?
11:30 < BlueMatt> gmaxwell: are we still doing #9501 for 0.14?
11:30 < gribble> https://github.com/bitcoin/bitcoin/issues/9501 | Final Alert for 0.14 · Issue #9501 · bitcoin/bitcoin · GitHub
11:30 < gmaxwell> AFAIK we are. When should we be sending it to the network?
11:30 < sipa> i think this is a good a time as any
11:30 < petertodd> gmaxwell: +1
11:30 < sipa> *as     
11:30 < gmaxwell> We can't PR the message send until we're ready for the message to hit the network.
11:31 < wumpus> #topic  Final Alert for 0.14 
11:31 < gmaxwell> Okay I can do that today, I don't think we need any delays or announcements given the prior alert.
11:31 < luke-jr> gmaxwell: we could PR it without the signature
11:31 < petertodd> gmaxwell: ACK
11:31 < wumpus> let's just do it
11:31 < luke-jr> fine with me
11:31 < achow101> ACK     
11:31 < petertodd> wumpus: <insert meme here>
11:32 < gmaxwell> K. well at least we don't have to discuss text for it.
11:33 < achow101> I can pr an update to the bitcoin.org post
11:33 < wumpus> hehe
11:33 < BlueMatt> 9108 needs an 0.14 tag, i believe
11:33 -!- jdjehjssidi [8fb00c79@gateway/web/freenode/ip.143.176.12.121] has joined #bitcoin-core-dev     
11:33 < jonasschnelli> BlueMatt: not necessarily 
11:33 < BlueMatt> i vote 9392 gets a non-0.14 tag
11:33 < BlueMatt> jonasschnelli: it fixes an 0.14-tagged issue
11:34 < BlueMatt> so either that or 9034 loses its tag
11:34 < jonasschnelli> WatchOnly where always with birthday 0
11:34 < sipa> https://cdn.meme.am/cache/instances/folder963/500x/74859963.jpg
11:34 < jonasschnelli> indeed
11:34 < gmaxwell> There are a number of importmulti serious bugfixes I have queued which I was waiting until after the freeze to finish.
11:35 < jonasschnelli> ack on untag #9034 for 0.14?
11:35 < gribble> https://github.com/bitcoin/bitcoin/issues/9034 | importmulti does not respect the given timestamp · Issue #9034 · bitcoin/bitcoin · GitHub
11:35 < wumpus> BlueMatt: tagged
11:35 < BlueMatt> gmaxwell: I assume that is related to #9491?
11:35 < gribble> https://github.com/bitcoin/bitcoin/issues/9491 | Importmulti api is confusing in a way that could lead to funds loss. · Issue #9491 · bitcoin/bitcoin · GitHub
11:35 < morcos> wait i'm confused...  gmaxwell you don't want those merged before 0.14 or you do?
11:36 < jonasschnelli> I guess he don't..
11:36 < morcos> nm, BlueMatt confused me...   importmulti fixes should be in 0.14, i think we all agree
11:37 < sipa> yes     
11:37 < jonasschnelli> Ah.. okay. I read it wrong.
11:37 < luke-jr> the impression I got is that gmaxwell just has more work to do on them, and was prioritising stuff before it
11:37 < sipa> agree
11:37 < BlueMatt> I'm ok with untagging #9027 for 14 - it was pointed out that we can do a simple fix to address the issue mentioned there, but there are other issues so its nontrivial to *really* fix
11:37 < gribble> https://github.com/bitcoin/bitcoin/issues/9027 | Unbounded reorg memory usage · Issue #9027 · bitcoin/bitcoin · GitHub
11:39 < morcos> so in the category of fixes
11:40 -!- To7 [~theo@cpe-158-222-222-232.nyc.res.rr.com] has joined #bitcoin-core-dev     
11:40 < morcos> wumpus and sipa when you get a chance, take a look at #9371...   i think thats the direction you wanted me to go... and if we do 9583.. its pretty clearly no change in behavior from what txConflicted would have done..
11:40 < gribble> https://github.com/bitcoin/bitcoin/issues/9371 | Notify on removal by morcos · Pull Request #9371 · bitcoin/bitcoin · GitHub
11:41 < bitcoin-git> [bitcoin] paveljanik opened pull request #9587: Do not shadow local variable named `tx`. (master...20170119_Wshadow_net_processing) https://github.com/bitcoin/bitcoin/pull/9587
11:42 < wumpus> morcos: will do
11:43 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev     
11:44 -!- jdjehjssidi [8fb00c79@gateway/web/freenode/ip.143.176.12.121] has quit [Quit: Page closed]     
11:45 < wumpus> ok, any other topics?
11:45 < sipa> i propose lunch
11:45 < BlueMatt> I'm done (finally) :p
11:45 < BlueMatt> sipa: too late, already did that
11:46 < wumpus> let's end early then
11:46 < wumpus> #endmeeting
11:46 < lightningbot> Meeting ended Thu Jan 19 19:46:06 2017 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
11:46 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2017/bitcoin-core-dev.2017-01-19-19.00.html
11:46 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2017/bitcoin-core-dev.2017-01-19-19.00.txt
11:46 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2017/bitcoin-core-dev.2017-01-19-19.00.log.html
11:46 < luke-jr> sipa: if you get a minute, can you give me at least a text-"verbal" ACK for some copyright license to put on BIPs 30, 32, 62, 66, and 103 please? is BSD-2-Clause okay?
11:46 < jonasschnelli> Anyone has an idea how to deal with https://github.com/bitcoin/bitcoin/pull/9294#pullrequestreview-17535025?
11:47 < sipa> luke-jr: ACK on 2-clause BSD for 30,32,62,66,103
11:47 < luke-jr> sipa: thanks
11:47 < sipa> (and for any other BIPs I contributed to)
11:47 < jonasschnelli> We did the same for 0.13 HD, but I actually think its a good finding by gmaxwell
11:47 < sipa> yeah, there is a race there
11:48 < sipa> that's always the case when a feature needs to be tied to a version number
11:48 < morcos> i don't see any problem leaving FEATURE_HD_SPLIT = 139900
11:48 < jonasschnelli> sipa: keeping in 139999 looks bad but is efficient?
11:48 < morcos> that seems the correct way to do it
11:48 < jonasschnelli> Agree with morcos 
11:48 < sipa> a better way would be to disentangle the wallet version number for the software version number
11:49 < sipa> so the wallet version can just be bumped in the same PR as the feature is introduced
11:49 < jonasschnelli> Yes. 
11:49 < morcos> ok.. but then you end up with a lot of version
11:49 < jonasschnelli> Together with a switch-away from BDB. :)
11:49 < morcos> i had this exact same issue with fee estimation
11:49 < morcos> for the data files it got merged with 139900
11:50 < morcos> but yeah if you ever wanted to backport something, it would be important to have different version for different feature types
11:51 < sipa> for the wallet we could just introduce a serialized set of strings
11:51 < sipa> one for each compatibility-breaking features
11:51 < BlueMatt> just set it to 14XXX and if it doesnt get merged set it to 15XXX prior to merge
11:51 < BlueMatt> i dont see whats wrong with a wallet saying 14 prior to 14
11:51 < jonasschnelli> I guess I once did that (what sipa said)
11:52 < jonasschnelli> https://github.com/bitcoin/bitcoin/pull/8369
11:52 < jonasschnelli> #8369
11:52 < gribble> https://github.com/bitcoin/bitcoin/issues/8369 | [FOR LATER USE][WIP][Wallet] add support for a flexible "set of features" by jonasschnelli · Pull Request #8369 · bitcoin/bitcoin · GitHub
11:52 < BlueMatt> ok, nvm, Ive been told I'm wrong
11:52 -!- windsok [~windsok@45.63.59.8] has quit [Ping timeout: 255 seconds]     
11:52 < BlueMatt> anyway, doesnt matter
11:52 < BlueMatt> pick a number out of a hat, I say
11:52 < BlueMatt> (and dont change it)
11:52 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #9588: qt: Use nPowTargetSpacing constant (master...Mf1701-qtParams) https://github.com/bitcoin/bitcoin/pull/9588
11:53 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
11:54 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit]     
11:58 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Read error: Connection reset by peer]     
12:00 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev     
12:05 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Quit: Konversation terminated!]     
12:09 -!- MarcoFalke [~marco@2001:4ca0:0:f226:a063:75b:7f88:d780] has left #bitcoin-core-dev []     
12:11 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
12:19 -!- Netmage [~Netmage@p5B0A666C.dip0.t-ipconnect.de] has joined #bitcoin-core-dev     
12:22 -!- windsok [~windsok@45.63.59.8] has joined #bitcoin-core-dev     
12:26 < sdaftuar> sipa: i've been thinking about PrecomputedTransactionData (prompted by jl2012's pr, #9572, where he proposed skipping the calculation for non-segwit tx's)
12:26 < gribble> https://github.com/bitcoin/bitcoin/issues/9572 | Skip witness sighash cache for non-segwit transactions by jl2012 · Pull Request #9572 · bitcoin/bitcoin · GitHub
12:28 < sdaftuar> now that we avoid copying CTransaction's around, by deserializing directly to a shared pointer, which in turn gets stored in the mempool and typically reconstructed into a block via compact block relay, that we could calculate these PrecomputedTransactionData's just once
12:28 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt]     
12:28 < sdaftuar> and store them somewhere, and avoid recalculation in ConnectBlock
12:28 < sdaftuar> my first thought was to just store them in CTransaction itself
12:29 < sdaftuar> which is not so hard to code up, but i don't know that the overhead is worth it in every situation, for instance reading a block off disk to deliver to a peer
12:29 < sdaftuar> or reading a tx off the network that we end up discarding
12:32 < sdaftuar> sipa: anyway i'd be curious to know whether you think this is worth pursuing, and if so what route you'd suggest i try.  for instance, i could try adding extra information to CTransaction that may be changed after it's deserialized, but that would undo all the effort you just went through to make it never change after deserialization!
12:32 -!- Netmage [~Netmage@p5B0A666C.dip0.t-ipconnect.de] has quit [Excess Flood]     
12:33 < gmaxwell> We should generally figure out how to cut out needless computation in reading blocks from disk generally... like we shouldn't be computing hashroots just to reply to a getdata.
12:33 < gmaxwell> (or in wallet rescan)
12:33 -!- Netmage [~Netmage@p5B0A666C.dip0.t-ipconnect.de] has joined #bitcoin-core-dev     
12:33 < sdaftuar> gmaxwell: yeah that occurred to me as well.  i think there are other situations too, though -- such as someone sends you a giant block off the network that you end up not processing (say because it's low work)
12:34 < sdaftuar> we deserialize each transaction and calculate its hash before deciding to ignore it
12:34 < sdaftuar> and my proposed code would have quadrupled the hashing...
12:35 < gmaxwell> I do like the ideal of stapling that stuff to the transaction. 
12:37 < sdaftuar> any suggestions on the best way to do it?  i've been brainstorming with ryanofsky and bluematt, some of the options that have been proposed include: keeping CTransaction as it is, but adding a new container CHashedTransaction that contains it and adds extra data, and storing that in the mempool
12:37 < sdaftuar> or, adding mutable data to the CTransaction, and possibly also some kind of synchronization primitives so that it can be updated after the fact (? ew)
12:44 < gmaxwell> I was thinking the container thing/
12:44  * gmaxwell lunch &
12:45 < ryanofsky> sdaftuar, for the mutable data approach, you could use c++11 call_once (http://en.cppreference.com/w/cpp/thread/call_once) to implement it without having to use low-level synchronization primitives directly
12:50 -!- handlex [~handlex@2804:14c:658f:4dc7:70cd:1be6:e4e8:954f] has joined #bitcoin-core-dev     
12:52 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection]     
12:52 -!- arubi [~ese168@unaffiliated/arubi] has joined #bitcoin-core-dev     
12:56 -!- arubi [~ese168@unaffiliated/arubi] has quit [Changing host]     
12:56 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev     
12:57 -!- Netmage [~Netmage@p5B0A666C.dip0.t-ipconnect.de] has quit [Quit: Leaving]     
13:04 -!- waxwing [waxwing@gateway/vpn/mullvad/x-gpqbpaytoltecraz] has joined #bitcoin-core-dev     
13:05  * luke-jr glares at Travis for being so slow
13:22 < bitcoin-git> [bitcoin] morcos opened pull request #9589: Use incrementalRelayFee for BIP 125 (RBF) replacement logic (master...incrementalFee) https://github.com/bitcoin/bitcoin/pull/9589
13:26 < bitcoin-git> [bitcoin] practicalswift opened pull request #9590: Improve readability by removing redundant casts to same type (master...remove-redundant-casts) https://github.com/bitcoin/bitcoin/pull/9590
13:47 < achow101> gmaxwell: when is the alert going out?
14:00 -!- marcoagner [~marcoagne@177.154.139.202] has joined #bitcoin-core-dev     
14:33 -!- marcoagner [~marcoagne@177.154.139.202] has quit [Ping timeout: 256 seconds]     
14:34 -!- marcoagner [~marcoagne@177.99.127.98] has joined #bitcoin-core-dev     
14:38 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 276 seconds]     
14:40 -!- aalex [~aalex@64.187.177.58] has quit [Ping timeout: 248 seconds]     
14:47 -!- waxwing [waxwing@gateway/vpn/mullvad/x-gpqbpaytoltecraz] has quit [Ping timeout: 240 seconds]     
14:48 -!- Greybits [~Greybits@unaffiliated/greybits] has joined #bitcoin-core-dev     
14:52 -!- handlex [~handlex@2804:14c:658f:4dc7:70cd:1be6:e4e8:954f] has quit [Quit: handlex]     
14:58 -!- Greybits [~Greybits@unaffiliated/greybits] has quit [Quit: Leaving]     
15:07 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev     
15:28 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)]     
15:33 < bitcoin-git> [bitcoin] jnewbery opened pull request #9591: [WIP] count mempool and extra pool matches correctly in PartiallyDownloadedBlock::InitData() (master...compactmatches) https://github.com/bitcoin/bitcoin/pull/9591
15:44 < bitcoin-git> [bitcoin] ryanofsky opened pull request #9592: [Qt] Add checkbox in the GUI to opt-in to RBF when creating a transaction (master...pr/grbf) https://github.com/bitcoin/bitcoin/pull/9592
15:53 -!- handlex [~handlex@2804:14c:658f:4dc7:70cd:1be6:e4e8:954f] has joined #bitcoin-core-dev     
15:56 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds]     
16:02 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev     
16:07 < CodeShark> luke-jr: for BIP123, I think either CC0 or GNU-all-permissive
16:08 < sipa> sdaftuar: well we do have CTransactionRef being a const reference to a CTransaction
16:08 < sipa> sdaftuar: we could have a wrapper class around CTransaction with mutable and self-synchronized fields
16:09 < sipa> that doesn't necessarily contain data that's part of CTransaction itself, but is relevant for validation
16:09 -!- windsok [~windsok@45.63.59.8] has quit [Ping timeout: 252 seconds]     
16:10 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev     
16:13 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection]     
16:14 -!- CubicEar_ [~cubiceart@2002:329f:7e15:0:5081:d026:25e8:8483] has joined #bitcoin-core-dev     
16:32 -!- CubicEar_ [~cubiceart@2002:329f:7e15:0:5081:d026:25e8:8483] has quit [Remote host closed the connection]     
16:35 -!- handlex [~handlex@2804:14c:658f:4dc7:70cd:1be6:e4e8:954f] has quit [Quit: handlex]     
16:41 -!- CubicEarth [~cubiceart@2002:329f:7e15:0:54b0:4bf9:d676:40d0] has joined #bitcoin-core-dev     
16:52 -!- Saucery [Saucery@c110-20-8-231.rivrw8.nsw.optusnet.com.au] has joined #bitcoin-core-dev     
16:53 -!- Saucery [Saucery@c110-20-8-231.rivrw8.nsw.optusnet.com.au] has quit [Client Quit]     
16:58 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com]     
17:00 -!- windsok [~windsok@45.63.59.8] has joined #bitcoin-core-dev     
17:03 -!- marcoagner [~marcoagne@177.99.127.98] has quit [Quit: Leaving]     
17:06 -!- marcoagner [~user@177.99.127.98] has joined #bitcoin-core-dev     
17:11 -!- marcoagner [~user@177.99.127.98] has quit [Quit: WeeChat 1.0.1]     
17:21 -!- CubicEarth [~cubiceart@2002:329f:7e15:0:54b0:4bf9:d676:40d0] has quit [Remote host closed the connection]     
17:35 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has quit [Quit: Leaving]     
17:43 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has left #bitcoin-core-dev []     
17:54 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev     
18:17 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-aiucapxtvkxbkevo] has quit [Quit: Connection closed for inactivity]     
18:20 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Remote host closed the connection]     
18:29 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds]     
18:53 -!- waxwing [waxwing@gateway/vpn/mullvad/x-folodrkoamyhzewx] has joined #bitcoin-core-dev     
18:55 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has quit [Ping timeout: 255 seconds]     
19:01 < bitcoin-git> [bitcoin] gmaxwell opened pull request #9594: Send final alert message to older peers after connecting. (master...send_final_alert) https://github.com/bitcoin/bitcoin/pull/9594
19:04 -!- veleiro [~veleiro@fsf/member/veleiro] has joined #bitcoin-core-dev     
19:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 248 seconds]     
19:11 < achow101> gmaxwell: did you broadcast the final alert yet?
19:14 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev     
19:17 < gmaxwell> achow101: nope. Feel free! but it is set to not relay: so each node gives it out one host at a time.
19:18 < achow101> so the peers who receive it won't broadcast it too?
19:19 < gmaxwell> Correct.
19:19 < gmaxwell> This seemed safer to me in a number of respects.
19:19 < gmaxwell> they'll display it as soon as they connect to are connected from any node running that code and continue to display until they restart.
19:20 < achow101> will you be sending one that does relay?
19:35 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]     
19:36 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev     
19:47 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Read error: Connection reset by peer]     
19:49 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev     
19:50 < bitcoin-git> [bitcoin] kallewoof opened pull request #9595: [consensus] make coinbase maturity a network parameter instead of an app-wide constant (master...consensus-coin-maturity) https://github.com/bitcoin/bitcoin/pull/9595
20:03 -!- Cory [~Cory@unaffiliated/cory] has quit [Ping timeout: 240 seconds]     
20:05 -!- harrymm [~wayne@191.96.49.80] has quit [Remote host closed the connection]     
20:07 -!- Cory [~Cory@unaffiliated/cory] has joined #bitcoin-core-dev     
20:10 -!- harrymm [~wayne@191.96.49.87] has joined #bitcoin-core-dev     
20:38 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit [Remote host closed the connection]     
20:46 < bitcoin-git> [bitcoin] morcos opened pull request #9596: [bugfix] save feeDelta instead of priorityDelta in DumpMempool (master...dumpmapdeltas) https://github.com/bitcoin/bitcoin/pull/9596
20:47 < gmaxwell> Argh.
20:48 < gmaxwell> "mapDeltas[i.first] = i.second.first;"  probably belongs on some "why C++ sucks" page.
20:48 < luke-jr> lol     
20:49 < luke-jr> wonder if there's an easy way to make a named-keys pair
20:49 < sipa> use an enum
20:49 < sipa> as key
20:50 -!- veleiro [~veleiro@fsf/member/veleiro] has quit [Ping timeout: 255 seconds]     
20:51 < sipa> or a std::tuple with an enum that lists the field positions?
21:00 -!- dermoth [~thomas@201-77.162.dsl.aei.ca] has quit [Read error: Connection reset by peer]     
21:01 -!- dermoth [~thomas@201-77.162.dsl.aei.ca] has joined #bitcoin-core-dev     
21:03 -!- veleiro [~veleiro@fsf/member/veleiro] has joined #bitcoin-core-dev     
21:17 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Quit: bye]     
21:39 -!- jyap [~jyap@unaffiliated/jyap] has quit [Ping timeout: 276 seconds]     
21:39 -!- jyap [~jyap@server1.getjumbucks.com] has joined #bitcoin-core-dev     
21:39 -!- jyap [~jyap@server1.getjumbucks.com] has quit [Changing host]     
21:39 -!- jyap [~jyap@unaffiliated/jyap] has joined #bitcoin-core-dev     
21:54 -!- To7 [~theo@cpe-158-222-222-232.nyc.res.rr.com] has quit [Quit: Whatever]     
22:01 -!- xinxi [~xinxi@183.214.201.83] has quit [Remote host closed the connection]     
22:01 -!- xinxi [~xinxi@183.214.201.83] has joined #bitcoin-core-dev     
22:07 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 240 seconds]     
22:22 -!- florpadorp [~florp@c-76-121-138-167.hsd1.wa.comcast.net] has joined #bitcoin-core-dev     
22:22 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]     
22:23 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev     
22:24 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev     
22:31 -!- xinxi [~xinxi@183.214.201.83] has quit [Remote host closed the connection]     
22:31 < cfields> grr, qt's buildsystem is an absolute nightmare
22:31 < cfields> BlueMatt: i know i owe you a PR. Just now coming up for air after battling qt all day
22:43 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 276 seconds]     
22:45 -!- windsok [~windsok@45.63.59.8] has quit [Ping timeout: 256 seconds]     
23:11 -!- whphhg [whphhg@gateway/vpn/mullvad/x-byfqcoscdlsujgzm] has quit [Ping timeout: 245 seconds]     
23:13 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev     
23:18 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev     
23:19 -!- aalex [~aalex@64.187.177.58] has quit [Ping timeout: 240 seconds]     
23:21 -!- chjj [~chjj@unaffiliated/chjj] has quit [Client Quit]     
23:21 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev     
23:23 -!- windsok [~windsok@45.63.59.8] has joined #bitcoin-core-dev     
23:31 -!- xinxi [~xinxi@183.214.201.83] has joined #bitcoin-core-dev     
23:36 -!- xinxi [~xinxi@183.214.201.83] has quit [Ping timeout: 260 seconds]     
23:37 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev     
23:37 < fanquake> cfields need a hand with anything?
23:45 -!- Lauda_ [~quassel@2a06:8ec0:3::1:b224] has joined #bitcoin-core-dev     
23:46 -!- emzy_ [~quassel@raspberry.emzy.de] has joined #bitcoin-core-dev     
23:46 -!- xhire_ [~xHire@kos.paskuli.cz] has joined #bitcoin-core-dev     
23:48 -!- xHire [~xHire@kos.paskuli.cz] has quit [Disconnected by services]     
23:48 -!- xhire_ is now known as xHire     
23:51 -!- emzy [~quassel@raspberry.emzy.de] has quit [Quit: No Ping reply in 180 seconds.]     
23:51 -!- Lauda [~quassel@unaffiliated/lauda] has quit [Ping timeout: 240 seconds]     
23:52 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-prypdekvoitlyrzb] has joined #bitcoin-core-dev