--- Day changed Mon Jan 23 2017
00:01 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]     
00:12 -!- whphhg [whphhg@gateway/vpn/mullvad/x-sfsmehauvysusdgn] has joined #bitcoin-core-dev     
00:13 -!- Soligor [~Soligor@unaffiliated/soligor] has joined #bitcoin-core-dev     
00:14 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev     
00:24 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
01:09 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev     
01:28 -!- Alopex [~bitcoin@cyber.dealing.ninja] has quit [Remote host closed the connection]     
01:29 -!- Alopex [~bitcoin@cyber.dealing.ninja] has joined #bitcoin-core-dev     
01:41 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #bitcoin-core-dev     
01:46 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
02:31 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
02:31 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit]     
02:44 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has quit []     
03:38 -!- hosiawak [~user@ip-222-90.ists.pl] has joined #bitcoin-core-dev     
03:39 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 240 seconds]     
03:39 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev     
03:43 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev     
03:54 -!- waxwing [~waxwing@14.174.32.23] has quit [Ping timeout: 240 seconds]     
04:07 -!- waxwing [~waxwing@193.138.219.236] has joined #bitcoin-core-dev     
04:18 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/eafba4e273f0...78849564144e
04:18 < bitcoin-git> bitcoin/master 116419e Alex Morcos: Don't overwrite validation state with corruption check...
04:18 < bitcoin-git> bitcoin/master 7884956 Wladimir J. van der Laan: Merge #9511: Don't overwrite validation state with corruption check...
04:19 < bitcoin-git> [bitcoin] laanwj closed pull request #9511: Don't overwrite validation state with corruption check (master...ATMPstate) https://github.com/bitcoin/bitcoin/pull/9511
04:19 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev     
04:24 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
04:27 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds]     
04:34 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
04:35 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit]     
05:03 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/78849564144e...5cf3c60fccb1
05:03 < bitcoin-git> bitcoin/master 5cdf106 practicalswift: Remove redundant semicolons in Python code
05:03 < bitcoin-git> bitcoin/master 5cf3c60 Wladimir J. van der Laan: Merge #9607: Remove redundant semicolons in Python code...
05:03 < bitcoin-git> [bitcoin] laanwj closed pull request #9607: Remove redundant semicolons in Python code (master...remove-redundant-semicolons-in-python-code) https://github.com/bitcoin/bitcoin/pull/9607
05:29 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 276 seconds]     
05:42 -!- Chris_Stewart_5 [~Chris_Ste@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
05:50 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev     
05:53 -!- ratoder [~ratoder@static.111.19.201.138.clients.your-server.de] has quit [Ping timeout: 272 seconds]     
06:08 -!- hosiawak [~user@ip-222-90.ists.pl] has quit [Ping timeout: 264 seconds]     
06:08 -!- waxwing [~waxwing@193.138.219.236] has quit [Ping timeout: 240 seconds]     
06:21 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev     
06:26 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has quit [Quit: MarcoFalke]     
06:30 < BlueMatt> ;;later tell MarcoFalke huh? why did you change the title on #9609? its super nice when titles refer to the bugs they fix.
06:30 < gribble> The operation succeeded.
06:50 -!- mol is now known as moli     
06:53 -!- Chris_Stewart_5 [~Chris_Ste@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 245 seconds]     
07:09 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
07:17 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/5cf3c60fccb1...727a79836035
07:17 < bitcoin-git> bitcoin/master ee5c1ce Karl-Johan Alm: Bug-fix: listsinceblock: use closest common ancestor when a block hash was provided for a chain that was not the main chain.
07:17 < bitcoin-git> bitcoin/master 7ba0a00 Karl-Johan Alm: Testing: listsinceblock should not use orphan block height.
07:17 < bitcoin-git> bitcoin/master 727a798 Wladimir J. van der Laan: Merge #9516: Bug-fix: listsinceblock: use fork point as reference for blocks in reorg'd chains...
07:17 < bitcoin-git> [bitcoin] laanwj closed pull request #9516: Bug-fix: listsinceblock: use fork point as reference for blocks in reorg'd chains (master...listsinceblock-reorg-fix) https://github.com/bitcoin/bitcoin/pull/9516
07:17 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 264 seconds]     
07:29 < bitcoin-git> [bitcoin] ryanofsky opened pull request #9613: [wallet] Clarify getbalance help string to explain interaction with bumpfee (master...pr/getbalance-help) https://github.com/bitcoin/bitcoin/pull/9613
07:31 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
07:35 -!- jnewbery [~Thunderbi@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev     
07:51 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]     
07:52 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
07:56 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds]     
07:57 < bitcoin-git> [bitcoin] jnewbery closed pull request #9591: [net] count mempool and extra pool matches correctly in PartiallyDownloadedBlock::InitData() (master...compactmatches) https://github.com/bitcoin/bitcoin/pull/9591
08:04 -!- JackH [~laptop@79-73-188-131.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev     
08:28 -!- wvr [~wvr@116.red-88-8-192.dynamicip.rima-tde.net] has quit [Quit: Leaving]     
08:33 -!- handlex [~handlex@189.74.9.113] has joined #bitcoin-core-dev     
08:34 -!- handlex [~handlex@189.74.9.113] has quit [Read error: Connection reset by peer]     
08:36 -!- handlex [~handlex@189.74.9.113] has joined #bitcoin-core-dev     
08:41 < BlueMatt> lol, someone might want to remove "Add support for Segregated Witness to Bitcoin Core" from the in-progress projects list....
08:43 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
08:44 < BlueMatt> also, maybe add "Rethink DoS protection methods, see #9530" and "Rethink time usage across codebase, see https://github.com/bitcoin/bitcoin/pull/9566#issuecomment-274542292 and #9606"
08:44 < gribble> https://github.com/bitcoin/bitcoin/issues/9530 | [brainstorm] DoS protection for blocks · Issue #9530 · bitcoin/bitcoin · GitHub
08:44 < gribble> https://github.com/bitcoin/bitcoin/issues/9606 | net: Consistently use GetTimeMicros() for inactivity checks by sdaftuar · Pull Request #9606 · bitcoin/bitcoin · GitHub
08:44 -!- handlex [~handlex@189.74.9.113] has quit [Ping timeout: 276 seconds]     
08:54 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev     
09:00 < bitcoin-git> [bitcoin] ryanofsky opened pull request #9614: [wallet] [refactor] Simplify getbalance implementation (master...pr/getbalance-cleanup) https://github.com/bitcoin/bitcoin/pull/9614
09:03 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving]     
09:10 < sipa> BlueMatt: is #1535 related to what you recently reported?
09:10 < gribble> https://github.com/bitcoin/bitcoin/issues/1535 | Interrupting CWallet::AddToWallet requires rescan · Issue #1535 · bitcoin/bitcoin · GitHub
09:10 -!- Kexkey [~kexkey@184.75.212.157] has joined #bitcoin-core-dev     
09:12 < BlueMatt> sipa: I dont think so?
09:12 < BlueMatt> sipa: I think that /might/ be fixed by #9583?
09:12 < gribble> https://github.com/bitcoin/bitcoin/issues/9583 | Move wallet callbacks into cs_main (this effectively reverts #7946) by TheBlueMatt · Pull Request #9583 · bitcoin/bitcoin · GitHub
09:12 < BlueMatt> no, nvm, that cantbe
09:13 < sipa> ok     
09:13 < sipa> gmaxwell: i don't understand #2265
09:13 < gribble> https://github.com/bitcoin/bitcoin/issues/2265 | signrawtransaction returns "complete" : false sometimes when it really is complete · Issue #2265 · bitcoin/bitcoin · GitHub
09:20 < BlueMatt> sipa: do we even know if #1535 is still an issue???
09:20 < gribble> https://github.com/bitcoin/bitcoin/issues/1535 | Interrupting CWallet::AddToWallet requires rescan · Issue #1535 · bitcoin/bitcoin · GitHub
09:20 < sipa> BlueMatt: no clue
09:20 < sipa> i'm going through old issues
09:21 < BlueMatt> luke-jr: or gmaxwell might know, otherwise i say close
09:21 < BlueMatt> I'll go do a code pass and see if i see anything surprising anywhere
09:38 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev     
09:41 < MarcoFalke> BlueMatt: I don't like too much references to GitHub in the commits and stuff. It is already mentioned in one of the commits. No need to put it in the title (i.e. merge commit)
09:42  * sipa has a deep philosophical objection to having PR numbers in commits
09:42 < sipa> PR and issues
09:46 < BlueMatt> ok     
09:46 < BlueMatt> i mean we fucking trust github for everything else, I'm not sure why thats the line, but ok :p
10:03 < sipa> i still see the commit history as something that exists independently from github
10:05 < midnightmagic> and independently verifiable
10:05 < gwillen> BlueMatt: if github went away tomorrow, everything would be fine and the project would recover and go elsewhere, but all those issue and PR numbers would be permanently rendered nonsense pointers to nowhere.
10:06 < midnightmagic> last I asked, there is someone mirroring all that data via either the github api or otherwise.
10:06 < BlueMatt> yea, I mean I dont really want to copy all the details of an issue into a commitmsg just to reference it
10:07 < BlueMatt> midnightmagic: I know i heard someone doing it...I assume kanzure?
10:07 < BlueMatt> him or petertodd are probably timestamping it, too
10:07 < midnightmagic> I sadly don't recall and would have to check logs.
10:07 < kanzure> no no
10:07 < kanzure> https://github.com/zw/bitcoin-gh-meta
10:08 < kanzure> i have a single timestamp of this from a few weeks ago, but it's not regularly timesstamped
10:08 < kanzure> we would need to find the person who runs that and ask them to timestamp each commit (a very simple thing to do)
10:09 < BlueMatt> i mean make petertodd do it, doesnt he already run his timestamping service thing?
10:09 < midnightmagic> is github still making the timestamping proofing thing available to anyone?
10:09 < kanzure> BlueMatt: i think it's "zw". who is that?
10:09 < BlueMatt> nfc     
10:09 < BlueMatt> "Zac Wilcox"
10:09 < kanzure> midnightmagic: github? it's a petertodd thing. https://alice.btc.calendar.opentimestamps.org/
10:10 < kanzure> https://petertodd.org//2016/opentimestamps-announcement
10:10 < midnightmagic> Huh. I looked him up for some other reason entirely like..  yesterday.
10:10 < kanzure> i think wilcox is the zooko family, but no doxxing
10:11 < BlueMatt> kanzure: this isnt reddit, you may be ok :p
10:23 < BlueMatt> I believe there is at least one case in #1535 which is an easy fix
10:23 < gribble> https://github.com/bitcoin/bitcoin/issues/1535 | Interrupting CWallet::AddToWallet requires rescan · Issue #1535 · bitcoin/bitcoin · GitHub
10:25 -!- atroxes [~atroxes@unaffiliated/atroxes] has quit [Quit: bye]     
10:26 -!- atroxes [~atroxes@unaffiliated/atroxes] has joined #bitcoin-core-dev     
10:26 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection]     
10:27 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev     
10:29 < MarcoFalke> #9596 looks ready for merge
10:29 < gribble> https://github.com/bitcoin/bitcoin/issues/9596 | [bugfix] save feeDelta instead of priorityDelta in DumpMempool by morcos · Pull Request #9596 · bitcoin/bitcoin · GitHub
10:29 < midnightmagic> Ah. I think that's iwilcox.
10:31 < sipa> i believe that's correct
10:36 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has quit [Quit: MarcoFalke]     
10:37 < midnightmagic> ;;seen iwilcox
10:37 < gribble> I have not seen iwilcox.
10:38 < BlueMatt> which version of gcc do we support?
10:38 < sipa> 4.8 and up, iirc
10:38 < BlueMatt> good
10:42 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 255 seconds]     
10:43 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/727a79836035...71148b8947fe
10:43 < bitcoin-git> bitcoin/master bd92f24 Alex Morcos: [bugfix] save feeDelta instead of priorityDelta in DumpMempool
10:43 < bitcoin-git> bitcoin/master 71148b8 Pieter Wuille: Merge #9596: [bugfix] save feeDelta instead of priorityDelta in DumpMempool...
10:43 < bitcoin-git> [bitcoin] sipa closed pull request #9596: [bugfix] save feeDelta instead of priorityDelta in DumpMempool (master...dumpmapdeltas) https://github.com/bitcoin/bitcoin/pull/9596
10:46 < bitcoin-git> [bitcoin] morcos opened pull request #9615: Wallet incremental fee (master...walletincremental) https://github.com/bitcoin/bitcoin/pull/9615
10:52 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 276 seconds]     
10:59 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
11:02 < gmaxwell> sipa: what don't you understand?  signrawtransaction is pretty eager in returning complete: false in many situations when the transaction is actually complete.
11:02 < sipa> gmaxwell: can you give an example?
11:06 < sipa> ah, i think i see... when there is a pre-existing valid signature for an input, but not the prevout information to validate it?
11:09 < gmaxwell> sipa: I think the issue mentioned one?  grab a random transaction out of a block, run signraw on it. complete will be false.
11:09 < sipa> does it also if you pass the prevouts it spends?
11:10 < gmaxwell> there are many different ways to run into it, but I think most of them reduce to not knowing the prevout. 
11:10 < gmaxwell> I believe it's still false if you do that, but I'm not sure, brain rot.
11:11 < gmaxwell> what I was trying to say in the PR is that it's okay if we don't return complete true if we don't know... but we shouldn't return false when we don't know either.
11:11 < sipa> i guess we should have made the output an array, which lists the status of each input
11:11 < gmaxwell> I've ended up wasting time while offline multisigning things with people due to it falsely returning false making us think it wasn't working when it was.
11:12 < sipa> complete/incomplete/unknown
11:12 < gmaxwell> (after wasting a bunch of time because "scriptPubkey" is not "scriptPubKey")
11:23 < bitcoin-git> [bitcoin] thedigitalpatriot opened pull request #9616: Interested in Fixing Vulnerabilities. (master...master) https://github.com/bitcoin/bitcoin/pull/9616
11:28 < gmaxwell> how are clueless people ending up doing that?
11:40 -!- waxwing [waxwing@gateway/vpn/mullvad/x-cepaitdywicoaerp] has joined #bitcoin-core-dev     
11:46 < BlueMatt> gmaxwell: apparently a ton of people get confused when you point them to github...somehow this is a common issue
11:46 < BlueMatt> :/     
11:47 < BlueMatt> i guess the "open source" thing isnt clear to people - you dont have to ask to get the code
11:48 < sipa> yes, "pull request" sounds to many like that's what they do to pull the code
11:48 < sipa> gitlab calls it a merge request
11:48 < sipa> much better
11:50 < midnightmagic> +1 merge request, -1 antiquated ideas of theirs/yours
11:50 < gmaxwell> I just don't get what sequence of buttons that person pressed.
11:51 < sipa> browsing some fork branch of bitcoin, not realizing it's a fork, and clicking "New pull request"
11:52 < sipa> https://github.com/sipa/bitcoin/tree/multilocal -> click "New pull request"
11:52 < sipa> try it!
11:55 < BlueMatt> oh, yea, he just pr'd the bu codebase, so thats what he did, i suppose
11:55 < BlueMatt> or classic? ehh, whatever
12:08 < gmaxwell> ah, for some reason I thought it only showed that button on your own branches.
12:11 < luke-jr> GitHub could sure use some improvement of terminology ;)
12:12 < BlueMatt> someone email support@?
12:13 < BlueMatt> they're pretty responsive, at least get it in their internal issue tracker
12:14 -!- waxwing__ [waxwing@gateway/vpn/mullvad/x-elrmqlyxaopmyrdp] has joined #bitcoin-core-dev     
12:14 -!- waxwing [waxwing@gateway/vpn/mullvad/x-cepaitdywicoaerp] has quit [Disconnected by services]     
12:15 -!- waxwing__ is now known as waxwing     
12:15 -!- eIks [~elks@185.86.151.126] has quit [Quit: Leaving]     
12:27 -!- droark [~droark@c-24-22-123-27.hsd1.or.comcast.net] has quit [Quit: Later.]     
12:39 -!- droark [~droark@c-24-22-123-27.hsd1.or.comcast.net] has joined #bitcoin-core-dev     
12:40 < jtimon> sipa: what does git blame -w doe?
12:40 < sipa> jtimon: ignore whitespace changes in the analysis
12:41 < jtimon> yeah, just saw it, but thanks
12:41 < jtimon> yeah, that would remove the concern for the later indent
12:51 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Ping timeout: 245 seconds]     
12:56 -!- Alina-malina [~Alina-mal@37.157.216.129] has joined #bitcoin-core-dev     
13:07 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]     
13:12 -!- Alina-malina [~Alina-mal@37.157.216.129] has quit [Changing host]     
13:12 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev     
13:35 -!- jnewbery [~Thunderbi@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Quit: jnewbery]     
14:18 -!- Cory [~Cory@unaffiliated/cory] has quit [Ping timeout: 255 seconds]     
14:20 -!- Pasha [~Cory@unaffiliated/cory] has joined #bitcoin-core-dev     
14:23 -!- Pasha is now known as Cory     
14:26 -!- nsh [~lol@2001:41d0:8:d711::1] has quit [Changing host]     
14:26 -!- nsh [~lol@wikipedia/nsh] has joined #bitcoin-core-dev     
14:36 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has quit [Remote host closed the connection]     
14:45 -!- oven [~0ven@185.86.151.126] has joined #bitcoin-core-dev     
14:50 < bitcoin-git> [bitcoin] laudaa opened pull request #9617: [Trivial] Update license year range to 2017 (master...master) https://github.com/bitcoin/bitcoin/pull/9617
14:59 -!- waxwing [waxwing@gateway/vpn/mullvad/x-elrmqlyxaopmyrdp] has quit [Ping timeout: 255 seconds]     
15:04 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-qoflonpgducthkai] has quit [Excess Flood]     
15:04 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-thqvwuqjihafgyqr] has joined #bitcoin-core-dev     
15:11 -!- tunafizz [~tuna@c-71-207-55-31.hsd1.pa.comcast.net] has quit [Ping timeout: 240 seconds]     
15:11 -!- tunafizz [tunafizz@c-71-207-55-31.hsd1.pa.comcast.net] has joined #bitcoin-core-dev     
15:32 < jtimon> mhmm, https://github.com/bitcoin/bitcoin/pull/9294 returns 500 for me...
15:34 < achow101> we've broken github
15:35 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 276 seconds]     
15:42 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)]     
15:42 < bitcoin-git> [bitcoin] luke-jr opened pull request #9619: Bugfix: RPC/Mining: GBT should return 1 MB sizelimit before segwit activates (master...bugfix_gbt_presw) https://github.com/bitcoin/bitcoin/pull/9619
15:48 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com]     
15:52 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev     
15:54 -!- tunafizz [tunafizz@c-71-207-55-31.hsd1.pa.comcast.net] has quit [Ping timeout: 240 seconds]     
15:55 -!- tunafizz [tunafizz@c-71-207-55-31.hsd1.pa.comcast.net] has joined #bitcoin-core-dev     
15:57 -!- waxwing [~waxwing@185.65.132.137] has joined #bitcoin-core-dev     
16:03 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev     
16:07 < Lightsword> think we can add an option to force bump fee even if opt-in RBF was not used? often transactions will relay regardless since they wouldn’t already be in mempools
16:12 < gmaxwell> Lightsword: ugh. forcing the creation of a transaction that we won't relay ourselves is .. a bit ugly. :(
16:12 < Lightsword> gmaxwell, well it would make sense to allow ourselves to relay it as well
16:13 < sipa> Lightsword: that is equivalent to implementing full RBF
16:14 < sipa> and we're not going to make an exception for your own transaction, as that's a privacy leak
16:14 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev     
16:18 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev     
16:29 -!- e4xit [~e4xit@cpc1-cmbg20-2-0-cust188.5-4.cable.virginm.net] has quit [Quit: Right I'm out!]     
16:30 -!- e4xit [~textual@cpc1-cmbg20-2-0-cust188.5-4.cable.virginm.net] has joined #bitcoin-core-dev     
16:56 < Lightsword> sipa, would it make sense to have it only under a force flag? I’m mainly thinking it’s better to have the bumpfee option than having to do it manually
16:58 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com]     
16:58 < sipa> i think the only reasonable way to do it is to first have someone use abandontransaction (which will only work if it's already evicted from the mempool), and then a wrapper to recreate an abandoned transaction with a higher fee (but guaranteeing that some if its inputs are spent again)
16:58 < sipa> that way you don't need an exception for relay
17:08 < luke-jr> gmaxwell: what if we would relay it ourselves because it's dropped out of our mempool?
17:08 < luke-jr> sipa: must it be abandoned explicitly?
17:09 < sipa> luke-jr: otherwise the wallet won't allow you to respend
17:09 < luke-jr> sipa: bumpfee will?
17:14 < sipa> luke-jr: bumpfee won't let you bump without it being bip125
17:15 < sipa> or are you saying that bumpfee should do that, IF the result would be acceptable to our own mempool?
17:16 < luke-jr> sipa: and if a "force" option is provided
17:17 < sipa> that seems reasonable
17:20 < Lightsword> the user can restart their node to force the transaction out of the mempool right?
17:21 -!- Kexkey [~kexkey@184.75.212.157] has quit [Ping timeout: 240 seconds]     
17:22 < sipa> if they delete mempool.dat, yes
17:26 -!- Kexkey [~kexkey@static-68-235-53-145.cust.tzulo.com] has joined #bitcoin-core-dev     
17:26 < Lightsword> is it possible to manually evict a transaction from the mempool by doing a negative prioritisetransaction call so it goes below the minfee needed to stay in the mempool?
17:35 < morcos> Lightsword: I  think that would only work if the mempool was full (and some other transaction came in to cause limiting)
17:35 < morcos> however a restart combined with a negative prioritisetransaction might work
17:36 < Lightsword> morcos, mempool is normally full with the way the limiter currently works right?
17:36 < sipa> it won't be full shortly after a new block was found
17:37 < morcos> it doesn't seem so recently..  and even if the network is busy it tends to not stay full b/c fee filter stops you getting cheap replacements
17:39 < Lightsword> isn’t fee filter mostly based on feerate of recently evicted transactions?
17:40 < morcos> sipa: i'm not around next week and #9371 or otherwise is necessary for 0.14..   could you take a look and if you agree with the approach, we could at least tag the PR 0.14 and i can give someone else repo access to carry it over the finish line
17:40 < gribble> https://github.com/bitcoin/bitcoin/issues/9371 | Notify on removal by morcos · Pull Request #9371 · bitcoin/bitcoin · GitHub
17:40 < morcos> right now just the issue is tagged for 0.14, b/c we never agreed what type of solution we want
17:41 < sipa> morcos: will do
17:41 < morcos> Lightsword: yes, but the minfee which the fee filter is set to = incrementalRelayRate (same as minRelayTxFee before 0.14) + the evicted rate.  in practice, this is 1000 sat/KB + 1000 sat/KB 
17:42 < morcos> therefore excluding all the garbage between 1000-2000 sat/KB which is the only way your mempool fills up
17:42 < morcos> so until the fee rate declines below 1000 sat/KB again...  your mempool tends to get less full...   
17:43 < morcos> that was at least true with 3 day time expiration...    with 2 week time expiration in 0.14, your mempool might stay closer to full?   depending on current tx supply
17:45 < gmaxwell> sipa: well we could allow abandond transactions to get bumped.
17:45 < gmaxwell> but we aren't very permissive with abandonment.
17:46 < morcos> i think we should try as hard as possible to not ever recommend abandoning
17:46 < morcos> not that it doens't work well
17:46 < morcos> but i think it'll inevitably lead to people spending different outputs and having both txs confirm
17:47 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-thqvwuqjihafgyqr] has quit [Quit: Connection closed for inactivity]     
17:47 < morcos> in that sense, i kind of think Lightsword is right...  if you have a "stuck" transaction and you forgot to make it opt-in RBF, it's probably better to still let you bumpfee it
17:48 < Lightsword> I think it would be a good idea to let one broadcast as well with a force flag
17:48 < morcos> otherwise you are going to use abandontransaction and try to do it manually and end up screwing yourself
17:48 < Lightsword> since it’s a major useability issue
17:48 < sipa> gmaxwell: i think what luke is suggesting is allowing /abandonable/ transactions to be bumped
17:49 < sipa> i do think that's better... first fully abandoning them would perhaps introduce a race conditions where you respend the coins in between the abandon and the bump
17:49 < gmaxwell> I think thats reasonable, but the set of abandonable transactions is so small as to make it hardly matter.
17:49 < sipa> evicted from mempool is enough, no?
17:50 < morcos> but that's basically not going to happen, unless you finagle it, and if you're going to finagle it, well why not just let you do it anyway
17:50 < morcos> whats the downside, privacy leak?
17:52 < gmaxwell> sipa: what morcos said.
17:52 < sipa> is it reasonable to expect your transaction will propagate otherwise?
17:52 < sipa> i would expect relatively similar mempool among your peers
17:53 < gmaxwell> the major downside is that we'll end up with txn in our wallet that we don't expect to relay, which is something we kind of assume doesn't happen.
17:53 < gmaxwell> sipa: well except peers change over time, so maybe not. or you might have a full rbf peer.
17:53 < morcos> or you might want to construct a tx to submit in some out of band way to a miner
17:54 < gmaxwell> yea, you might not really care about the relay at all.. just plan on extracting the hex and giving it to the antpool doublespending service (I mean free txn priority service)
18:00 < Lightsword> sipa, I think there are enough nodes with inconsistant relay policy that you have a good chance of propagation even if your own mempool doesn’t accept the transaction, for example nodes with much more strict mempool limiting may accept it
18:00 < sipa> i wonder if that's a temporary thing
18:02 < Lightsword> well extreme mempool limiting is usually due to resource limitations(reducing ram usage)
18:04 < Lightsword> I think in this case the privacy risks are far less of a risk than users messing up the feebump by trying to do it manually and using the wrong utxo’s
18:04 -!- isis [~isis@abulafia.patternsinthevoid.net] has quit [Ping timeout: 240 seconds]     
18:08 < gmaxwell> well because bumpfee can only diminish change, it's already pretty limited.
18:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]     
18:10 -!- AaronvanW [~AaronvanW@207pc74.sshunet.nl] has joined #bitcoin-core-dev     
18:10 -!- AaronvanW [~AaronvanW@207pc74.sshunet.nl] has quit [Changing host]     
18:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
18:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]     
18:20 -!- isis [~isis@abulafia.patternsinthevoid.net] has joined #bitcoin-core-dev     
18:42 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds]     
18:53 -!- dermoth_ [~thomas@dsl-199-102-159-125.mtl.aei.ca] has joined #bitcoin-core-dev     
18:54 -!- dermoth [~thomas@201-77.162.dsl.aei.ca] has quit [Disconnected by services]     
18:54 -!- dermoth_ is now known as dermoth     
18:54 -!- Kexkey [~kexkey@static-68-235-53-145.cust.tzulo.com] has quit [Remote host closed the connection]     
19:00 -!- waxwing [~waxwing@185.65.132.137] has quit [Ping timeout: 258 seconds]     
19:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
19:13 -!- waxwing [waxwing@gateway/vpn/mullvad/x-sadghlldmtvwittn] has joined #bitcoin-core-dev     
19:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]     
20:05 < bitcoin-git> [bitcoin] luke-jr opened pull request #9621: Define, check, and use MIN_TRANSACTION_SIZE as a const (master...cleanup_mintxsize) https://github.com/bitcoin/bitcoin/pull/9621
20:05 -!- chris2000 [~chris2000@p5082AC5A.dip0.t-ipconnect.de] has joined #bitcoin-core-dev     
20:08 -!- chris200_ [~chris2000@p5DCB4D17.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]     
20:18 -!- frabrunelle [frabrunell@safenetwork/frabrunelle] has joined #bitcoin-core-dev     
21:00 -!- dermoth [~thomas@dsl-199-102-159-125.mtl.aei.ca] has quit [Read error: Connection reset by peer]     
21:00 -!- waxwing [waxwing@gateway/vpn/mullvad/x-sadghlldmtvwittn] has quit [Ping timeout: 245 seconds]     
21:01 -!- dermoth [~thomas@dsl-199-102-159-125.mtl.aei.ca] has joined #bitcoin-core-dev     
21:12 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 276 seconds]     
21:13 -!- waxwing [waxwing@gateway/vpn/mullvad/x-lshjdidbkhgswaqq] has joined #bitcoin-core-dev     
21:16 -!- AaronvanW [~AaronvanW@207pc74.sshunet.nl] has joined #bitcoin-core-dev     
21:16 -!- AaronvanW [~AaronvanW@207pc74.sshunet.nl] has quit [Changing host]     
21:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
21:21 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]     
21:39 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev     
21:41 < bitcoin-git> [bitcoin] kallewoof opened pull request #9622: [rpc] Bug-fix: listsinceblock should include lost transactions when parameter is a reorg'd block (master...listsinceblock-include-lost-txs) https://github.com/bitcoin/bitcoin/pull/9622
22:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
22:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 258 seconds]     
22:27 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Quit: bye]     
22:37 -!- waxwing__ [~waxwing@14.165.235.227] has joined #bitcoin-core-dev     
22:37 -!- waxwing [waxwing@gateway/vpn/mullvad/x-lshjdidbkhgswaqq] has quit [Disconnected by services]     
22:37 -!- waxwing__ is now known as waxwing     
22:57 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-yzaepgpyjbetievf] has joined #bitcoin-core-dev     
22:59 -!- Lauda [~quassel@unaffiliated/lauda] has quit [Quit: No Ping reply in 180 seconds.]     
23:00 -!- Lauda [~quassel@unaffiliated/lauda] has joined #bitcoin-core-dev     
23:01 < gmaxwell> sipa: please close 9616
23:03 < gmaxwell> "you promised it would only be a three-line change and you delivered :)"  best pull request review comment ever.
23:17 < sipa> ?     
23:18 < bitcoin-git> [bitcoin] sipa closed pull request #9616: Interested in Fixing Vulnerabilities. (master...master) https://github.com/bitcoin/bitcoin/pull/9616
23:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
23:20 < gmaxwell> sipa: thanks
23:20 -!- Lauda [~quassel@unaffiliated/lauda] has quit [Ping timeout: 256 seconds]     
23:22 -!- Lauda [~quassel@unaffiliated/lauda] has joined #bitcoin-core-dev     
23:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 264 seconds]