--- Day changed Fri Jan 27 2017 00:02 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 00:18 < bitcoin-git> [bitcoin] kallewoof opened pull request #9643: [refactor] Remove using namespace from wallet/ & util* (master...no-using-namespace-wallet-util) https://github.com/bitcoin/bitcoin/pull/9643 00:22 -!- windsok [~windsok@45.63.59.8] has quit [Ping timeout: 260 seconds] 00:26 -!- paveljanik [~paveljani@79.98.72.176] has joined #bitcoin-core-dev 00:26 -!- paveljanik [~paveljani@79.98.72.176] has quit [Changing host] 00:26 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 00:30 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:31 -!- aguycalled [~aguycalle@2001:638:812:c00:2451:cbc:f54:63b6] has quit [Remote host closed the connection] 00:32 -!- Saucery [Saucery@c110-20-8-231.rivrw8.nsw.optusnet.com.au] has quit [] 00:45 -!- aguycalled [~aguycalle@2001:638:812:c00:65fe:c70:9e67:be68] has joined #bitcoin-core-dev 00:52 -!- windsok [~windsok@45.63.59.8] has joined #bitcoin-core-dev 01:05 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:09 < bitcoin-git> [bitcoin] kallewoof opened pull request #9644: [refactor] Remove using namespace from src/ (master...no-using-namespace-src) https://github.com/bitcoin/bitcoin/pull/9644 01:23 < Eliel_> 25 01:25 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #bitcoin-core-dev 01:36 -!- e4xit [~textual@cpc1-cmbg20-2-0-cust188.5-4.cable.virginm.net] has quit [Ping timeout: 240 seconds] 01:36 -!- isle2983 [~isle2983@gateway/vpn/privateinternetaccess/isle2983] has quit [Ping timeout: 240 seconds] 01:36 -!- e4xit [~textual@cpc1-cmbg20-2-0-cust188.5-4.cable.virginm.net] has joined #bitcoin-core-dev 01:36 -!- cannon-c is now known as cannon-c_AFK 01:54 -!- AaronvanW [~AaronvanW@207pc74.sshunet.nl] has joined #bitcoin-core-dev 01:54 -!- AaronvanW [~AaronvanW@207pc74.sshunet.nl] has quit [Changing host] 01:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:02 -!- cannon-c_AFK is now known as cannon-c 02:17 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 02:31 -!- rgrant [~rgrant@unaffiliated/rgrant] has joined #bitcoin-core-dev 02:34 < rgrant> can someone point me at the function that backfills local blockchain blocks to include witness data if user upgrades to a segwit full node after segwit activation? 02:53 < rgrant> it looks like BLOCK_OPT_WITNESS stores some activation data for the block, but it also looks like this is not queried to see if backfill is necessary. i could also use some help tracking down what happens if a segwit-capable node only finds itself connected to non-segwit nodes while receiving a block. 03:10 -!- frabrunelle [frabrunell@safenetwork/frabrunelle] has quit [Remote host closed the connection] 03:13 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 03:18 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 03:18 -!- frabrunelle [frabrunell@safenetwork/frabrunelle] has joined #bitcoin-core-dev 03:22 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving] 03:30 -!- gradient_ [~gradients@151.37.42.129] has joined #bitcoin-core-dev 03:32 -!- gradient_ [~gradients@151.37.42.129] has quit [Client Quit] 03:33 -!- gradientskier [~gradients@85.159.196.243] has joined #bitcoin-core-dev 03:36 -!- gradientskier [~gradients@85.159.196.243] has quit [] 03:42 -!- waxwing [~waxwing@14.174.34.120] has quit [Ping timeout: 240 seconds] 03:54 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [] 04:13 -!- isle2983 [~isle2983@gateway/vpn/privateinternetaccess/isle2983] has joined #bitcoin-core-dev 04:27 -!- cannon-c [ccc23f04@gateway/web/freenode/ip.204.194.63.4] has quit [Quit: Page closed] 04:34 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer] 04:34 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 04:41 -!- aguycalled [~aguycalle@2001:638:812:c00:65fe:c70:9e67:be68] has quit [Remote host closed the connection] 04:56 -!- face [~face@mail.hmel.org] has quit [Read error: Connection reset by peer] 05:03 -!- waxwing [~waxwing@14.174.34.120] has joined #bitcoin-core-dev 05:17 < sdaftuar> rgrant: see RewindBlockIndex, in validation.cpp (assuming you're looking at master) 05:27 < sdaftuar> rgrant: after segwit activates, segwit-capable nodes will only attempt to download blocks from segwit-capable peers (which is why 0.13.1 introduced outbound peering logic that would specifically seek out segwit-capable peers) 05:36 -!- JackH [~laptop@79-73-188-131.dynamic.dsl.as9105.com] has quit [Ping timeout: 245 seconds] 05:47 < rgrant> sdaftuar: thx! it does use BLOCK_OPT_WITNESS, too. not sure how i missed that in my search. 06:40 -!- windsok [~windsok@45.63.59.8] has quit [Ping timeout: 240 seconds] 06:44 -!- aguycalled [~aguycalle@2a02:2450:102d:b5:98de:3cd6:37fd:bef7] has joined #bitcoin-core-dev 06:59 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has quit [Remote host closed the connection] 07:00 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has joined #bitcoin-core-dev 07:08 -!- windsok [~windsok@45.63.59.8] has joined #bitcoin-core-dev 07:14 -!- oven [~0ven@176.223.111.92] has quit [Read error: Connection reset by peer] 07:16 -!- oven [~0ven@185.86.151.126] has joined #bitcoin-core-dev 07:18 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9b4d2673b775...d9e4d1d9fbd9 07:18 < bitcoin-git> bitcoin/master 04b8773 Jonas Schnelli: [Qt] fix transaction details output-index to reflect vout index 07:18 < bitcoin-git> bitcoin/master d9e4d1d Wladimir J. van der Laan: Merge #9637: [Qt] fix transaction details output-index to reflect vout index... 07:18 < bitcoin-git> [bitcoin] laanwj closed pull request #9637: [Qt] fix transaction details output-index to reflect vout index (master...2017/01/qt_vout) https://github.com/bitcoin/bitcoin/pull/9637 07:24 -!- rgrant [~rgrant@unaffiliated/rgrant] has left #bitcoin-core-dev [] 07:28 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 07:33 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d9e4d1d9fbd9...a7ea2f8fdbe9 07:33 < bitcoin-git> bitcoin/master fab035f MarcoFalke: qa: Actually test assertions in pruning.py... 07:33 < bitcoin-git> bitcoin/master a7ea2f8 Wladimir J. van der Laan: Merge #9638: qa: Actually test assertions in pruning.py... 07:33 < bitcoin-git> [bitcoin] laanwj closed pull request #9638: qa: Actually test assertions in pruning.py (master...Mf1701-qaPruning_try) https://github.com/bitcoin/bitcoin/pull/9638 08:41 -!- neha__ [~narula@tbilisi.csail.mit.edu] has joined #bitcoin-core-dev 08:46 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 08:46 -!- aguycall_ [~aguycalle@37.120.37.13] has joined #bitcoin-core-dev 08:46 -!- aguycalled [~aguycalle@2a02:2450:102d:b5:98de:3cd6:37fd:bef7] has quit [Ping timeout: 255 seconds] 08:52 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 08:55 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds] 08:57 -!- windsok [~windsok@45.63.59.8] has quit [Ping timeout: 264 seconds] 08:57 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 09:19 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 09:28 -!- windsok [~windsok@45.63.59.8] has joined #bitcoin-core-dev 09:51 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 10:27 -!- oven [~0ven@185.86.151.126] has quit [Quit: Leaving] 11:09 -!- instagibbs [~instagibb@pool-100-15-114-3.washdc.fios.verizon.net] has joined #bitcoin-core-dev 12:00 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 12:07 < luke-jr> is anyone else working on #9493? (I wish github let us self-assign stuff..) 12:07 < gribble> https://github.com/bitcoin/bitcoin/issues/9493 | event_set_mem_functions is not available on all libevents · Issue #9493 · bitcoin/bitcoin · GitHub 12:11 -!- waxwing [~waxwing@14.174.34.120] has quit [Ping timeout: 255 seconds] 12:16 -!- Kexkey [~kexkey@173.208.58.198] has joined #bitcoin-core-dev 12:19 < BlueMatt> luke-jr: looks like not? its either you or cfields probably 12:19 -!- norotartagen [~norotarta@71-89-76-184.dhcp.bycy.mi.charter.com] has quit [Read error: Connection reset by peer] 12:20 < cfields> luke-jr: last i looked you had a fix for it? 12:20 -!- norotartagen [~norotarta@71-89-76-184.dhcp.bycy.mi.charter.com] has joined #bitcoin-core-dev 12:21 < cfields> yea, i assumed that define was all it took. If there's more to it, i'm happy to take a look 12:32 < luke-jr> it's probably not difficult, just didn't want to step on any toes 12:33 < luke-jr> just gotta figure out how to indicate a skipped test I guess 12:47 -!- Kexkey [~kexkey@173.208.58.198] has quit [Ping timeout: 264 seconds] 12:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 12:51 -!- aguycall_ is now known as aguycalled 12:52 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 12:56 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 13:04 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 13:17 -!- Kexkey_ [~kexkey@173.208.58.198] has joined #bitcoin-core-dev 13:21 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Read error: Connection reset by peer] 13:23 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 13:36 -!- waxwing [~waxwing@14.174.34.120] has joined #bitcoin-core-dev 13:48 -!- Kexkey_ [~kexkey@173.208.58.198] has quit [Ping timeout: 240 seconds] 13:52 -!- AaronvanW [~AaronvanW@207pc74.sshunet.nl] has joined #bitcoin-core-dev 13:52 -!- AaronvanW [~AaronvanW@207pc74.sshunet.nl] has quit [Changing host] 13:52 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 13:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 13:58 -!- aguycalled [~aguycalle@37.120.37.13] has quit [Read error: Connection reset by peer] 13:59 -!- aguycalled [~aguycalle@2a02:2450:102d:b5:4e2:f368:12d:4fe7] has joined #bitcoin-core-dev 14:07 < BlueMatt> cfields: what do you want to do about hSocket? 14:08 < cfields> BlueMatt: races, you mean? 14:08 < BlueMatt> yes 14:08 < BlueMatt> well "races" 14:08 < BlueMatt> not that they actually are, but.... 14:08 < cfields> well, concurrent access 14:09 < cfields> BlueMatt: going forward, it'll all be contained to one thread. So again, it's just a matter of what we do for 0.14 14:09 < BlueMatt> it will? 14:09 < cfields> sec, taking a look. iirc it's mostly just disconnection that's problematic? 14:09 < BlueMatt> oh, you mean CloseSocketDisconnect will be? yea, ok 14:10 < BlueMatt> its entirely only CloseSocketDisconnect thats problematic, iirc 14:11 < cfields> oh, and optimistic sends 14:12 -!- aguycalled [~aguycalle@2a02:2450:102d:b5:4e2:f368:12d:4fe7] has quit [Read error: Connection reset by peer] 14:13 -!- aguycalled [~aguycalle@37.120.37.13] has joined #bitcoin-core-dev 14:13 < cfields> BlueMatt: with my async refactors, CloseSocketDisconnect always happens on the sockethandler thread, the others just set fDisconnect 14:14 < BlueMatt> yea, ok, that sounds like what we /should/ do....but what about 0.14? 14:14 < cfields> i wonder if we could do a simplified version of that for 0.14 14:14 < BlueMatt> I havent looked, can we do that easily in 14? 14:15 < cfields> uhmm, just looking at it quickly, it seems so 14:16 < gmaxwell> if the behavior involved doesn't block, add a lock and move on. 14:16 < BlueMatt> gmaxwell: might as well fix it right, though 14:18 < cfields> BlueMatt: i think we'll still need a lock for the optimistic send :( 14:18 < BlueMatt> oh valid point, yea, likely 14:19 < BlueMatt> has anyone ever figured out how much optimistic send saves us? 14:19 < BlueMatt> like, notifying the other thread and having it do the send is like a few extra syscalls 14:19 < BlueMatt> so what 14:21 < cfields> BlueMatt: i think the only downside is you can end up at the tail of the sendqueue for that loop as opposed to sending immediately 14:21 < BlueMatt> "meh" ? 14:21 < cfields> but with the locks cleaned up now, i doubt there's much consequence there 14:21 < BlueMatt> oh, true, without the lock cleanups that would've been hell 14:21 < cfields> BlueMatt: well i think that could've been substantial before, with a long hold on the send lock 14:21 < BlueMatt> but, alright, lets call that a 0.15 optimization and just add a lock for 0.14? 14:22 < cfields> BlueMatt: yes, afraid so :( 14:22 < BlueMatt> ok, well shouldnt be a big deal 14:23 < BlueMatt> if your send() is blocking, you have bigger problems :p 14:23 < cfields> heh 14:23 < cfields> true i suppose. Scope can basically be limited to send/recv/close, right? 14:24 < BlueMatt> I'd hope so? 14:24 < BlueMatt> I havent looked in a while 14:24 < cfields> mm, worth looking at select/fd_set's safety guarantees 14:25 < cfields> BlueMatt: heh, hint taken. I'll work up a patch for discussion. 14:25 < BlueMatt> are we close()ing in CloseSocketDisconnect, or just disconnect()? 14:25 < BlueMatt> sorry, wasnt a hint, just saying 14:26 < BlueMatt> oh, hum, we are 14:26 < BlueMatt> yea, that sucks 14:26 < cfields> close/closesocket 14:28 < BlueMatt> cfields: ouch, yea, then maybe we do need the full patch now, then 14:28 < BlueMatt> to avoid calling CloseSocketDisconnect on any thread but ThreadSocketHandler 14:28 < BlueMatt> hum...orrrr...no, because select will just return and we'll still get the lock when we recv or send? 14:28 < BlueMatt> i mean i guess it should be fine, but might prefer not to? 14:29 -!- aguycall_ [~aguycalle@2a02:2450:102d:b5:7c1a:b62c:4a2d:2ad9] has joined #bitcoin-core-dev 14:29 -!- aguycalled [~aguycalle@37.120.37.13] has quit [Read error: Connection reset by peer] 14:40 < cfields> BlueMatt: just for the sake of covering all angles... this concurrent access isn't new, right? much more likely maybe, but i'm pretty sure this has always been the case 14:41 < BlueMatt> yes, I believe this is very, very, very old 14:42 < BlueMatt> but havent gone back to make sure 15:04 -!- molz_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 15:06 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 255 seconds] 15:09 -!- molz_ [~molly@unaffiliated/molly] has quit [Quit: Leaving] 15:09 -!- molz_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 15:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 15:14 -!- gradientskier [~gradients@151.28.249.178] has joined #bitcoin-core-dev 15:14 -!- gradientskier [~gradients@151.28.249.178] has quit [Client Quit] 15:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 15:52 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 15:59 -!- aguycall_ [~aguycalle@2a02:2450:102d:b5:7c1a:b62c:4a2d:2ad9] has quit [Read error: Connection reset by peer] 16:00 -!- aguycalled [~aguycalle@37.120.37.13] has joined #bitcoin-core-dev 16:15 -!- BitBully [~Mutter@197.210.44.87] has joined #bitcoin-core-dev 16:22 -!- BitBully [~Mutter@197.210.44.87] has quit [Quit: Mutter: www.mutterirc.com] 16:27 -!- waxwing_ [~waxwing@14.165.226.153] has joined #bitcoin-core-dev 16:30 -!- waxwing [~waxwing@14.174.34.120] has quit [Ping timeout: 264 seconds] 17:13 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:17 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has quit [Quit: Leaving] 17:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 17:19 -!- CubicEarth [~cubiceart@2002:329f:7e15:0:ad18:b2c7:840f:aa9] has quit [Remote host closed the connection] 17:57 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-dyqixokchpoglkui] has quit [Quit: Connection closed for inactivity] 18:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:19 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 258 seconds] 18:20 -!- CubicEarth [~cubiceart@2002:329f:7e15:0:7993:5ef0:24dd:548a] has joined #bitcoin-core-dev 18:21 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 255 seconds] 18:25 -!- CubicEarth [~cubiceart@2002:329f:7e15:0:7993:5ef0:24dd:548a] has quit [Ping timeout: 276 seconds] 19:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 19:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds] 19:24 -!- molz_ [~molly@unaffiliated/molly] has quit [Remote host closed the connection] 19:26 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 19:29 -!- CubicEarth [~cubiceart@c-50-159-126-21.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 20:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 20:20 -!- gijensen [~gijensen@static.182.173.9.5.clients.your-server.de] has joined #bitcoin-core-dev 20:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 20:34 -!- waxwing_ is now known as waxwing 20:59 -!- chris200_ [~chris2000@p5DCB5DD4.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 21:00 -!- dermoth [~thomas@dsl-199-102-159-125.mtl.aei.ca] has quit [Read error: Connection reset by peer] 21:01 -!- dermoth [~thomas@dsl-199-102-159-125.mtl.aei.ca] has joined #bitcoin-core-dev 21:02 -!- chris2000 [~chris2000@p5DCB56DD.dip0.t-ipconnect.de] has quit [Ping timeout: 255 seconds] 21:17 -!- AaronvanW [~AaronvanW@207pc74.sshunet.nl] has joined #bitcoin-core-dev 21:17 -!- AaronvanW [~AaronvanW@207pc74.sshunet.nl] has quit [Changing host] 21:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 21:21 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 21:22 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has quit [Ping timeout: 245 seconds] 21:59 -!- cannon-c [ccc23f04@gateway/web/freenode/ip.204.194.63.4] has joined #bitcoin-core-dev 22:02 -!- e4xit [~textual@cpc1-cmbg20-2-0-cust188.5-4.cable.virginm.net] has quit [Ping timeout: 240 seconds] 22:03 -!- e4xit [~textual@cpc1-cmbg20-2-0-cust188.5-4.cable.virginm.net] has joined #bitcoin-core-dev 22:29 -!- aguycalled [~aguycalle@37.120.37.13] has quit [Read error: Connection reset by peer] 22:31 -!- aguycalled [~aguycalle@37.120.37.13] has joined #bitcoin-core-dev 22:42 -!- aguycalled [~aguycalle@37.120.37.13] has quit [Remote host closed the connection] 23:01 < bitcoin-git> [bitcoin] theuni opened pull request #9646: depends: Fix cross build for qt5.7 (master...fix-qt57) https://github.com/bitcoin/bitcoin/pull/9646 23:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 23:14 -!- harrymm [~wayne@191.96.49.105] has quit [Ping timeout: 260 seconds] 23:26 -!- roidster [~chatzilla@71-93-192-198.dhcp.whtr.ca.charter.com] has joined #bitcoin-core-dev 23:26 -!- roidster is now known as Guest43596 23:27 -!- Guest43596 is now known as roidster 23:28 -!- harrymm [~wayne@104.207.83.26] has joined #bitcoin-core-dev 23:57 -!- aguycalled [~aguycalle@2a02:2450:102d:b5:98be:74d8:5e48:ac3f] has joined #bitcoin-core-dev