--- Day changed Thu Feb 09 2017
00:00 < bitcoin-git> [bitcoin] laanwj opened pull request #9726: netbase: Do not print an error on connection timeouts through proxy (master...2017_02_intr_recv_error) https://github.com/bitcoin/bitcoin/pull/9726
00:03 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
00:09 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]     
00:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds]     
00:13 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
00:22 < bitcoin-git> [bitcoin] laanwj opened pull request #9727: Remove fallbacks for boost_filesystem < v3 (master...2017_02_boostfs_flailbacks) https://github.com/bitcoin/bitcoin/pull/9727
00:29 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-chvtzoekgygtbvjm] has joined #bitcoin-core-dev     
00:29 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
00:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds]     
00:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
00:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]     
00:39 -!- AaronvanW [~AaronvanW@105.red-81-33-161.dynamicip.rima-tde.net] has joined #bitcoin-core-dev     
00:39 -!- AaronvanW [~AaronvanW@105.red-81-33-161.dynamicip.rima-tde.net] has quit [Changing host]     
00:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
01:12 < bitcoin-git> [bitcoin] NicolasDorier opened pull request #9728: Can create Watch Only HD wallet with -hdwatchonly (master...watchonlyhd) https://github.com/bitcoin/bitcoin/pull/9728
01:39 -!- rickygee [~rickygee@mobile-166-176-186-120.mycingular.net] has joined #bitcoin-core-dev     
02:03 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev     
02:33 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #9730: Remove bitseed.xf2.org form the dns seed list (master...2017/02/seeds) https://github.com/bitcoin/bitcoin/pull/9730
02:33 < jonasschnelli> wumpus: yes. Lets remove it.
02:33 < jonasschnelli> Try a couple of addrs from the bitseed.xf2.org DNS response... 
02:33 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 255 seconds]     
02:33 < jonasschnelli> I could not get a single address that responsed on 8333
02:39 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has quit [Remote host closed the connection]     
02:40 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has joined #bitcoin-core-dev     
02:42 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer]     
02:43 -!- rickygee [~rickygee@mobile-166-176-186-120.mycingular.net] has quit [Quit: see ya latahz]     
02:55 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
03:06 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev     
03:12 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has quit [Ping timeout: 256 seconds]     
03:32 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev     
04:05 -!- wvr [~wvr@120.red-83-46-24.dynamicip.rima-tde.net] has joined #bitcoin-core-dev     
04:13 -!- cannon-c [ccc23f04@gateway/web/freenode/ip.204.194.63.4] has quit [Quit: Page closed]     
04:26 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)]     
04:40 -!- cannon-c [ccc23f04@gateway/web/freenode/ip.204.194.63.4] has joined #bitcoin-core-dev     
04:47 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev     
04:54 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
05:01 -!- neha [~narula@tbilisi.csail.mit.edu] has quit [Ping timeout: 255 seconds]     
05:02 -!- neha [~narula@tbilisi.csail.mit.edu] has joined #bitcoin-core-dev     
05:04 -!- lclc_ [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev     
05:05 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 240 seconds]     
05:16 -!- cannon-c [ccc23f04@gateway/web/freenode/ip.204.194.63.4] has quit [Quit: Page closed]     
05:40 -!- Sosumi [~Leon@bl10-113-190.dsl.telepac.pt] has joined #bitcoin-core-dev     
05:56 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
05:56 -!- PaulCapestany [~PaulCapes@2604:5500:17:2ea:855:1ecf:e67e:e3b7] has quit [Read error: Connection reset by peer]     
05:58 -!- PaulCapestany [~PaulCapes@2604:5500:17:2ea:14ea:26de:9b48:2fc9] has joined #bitcoin-core-dev     
06:01 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev     
06:33 < brg444> https://github.com/bitcoin/bitcoin/pull/9441 is this set to make it into 0.14?
06:44 < Lauda> brg444 I see it marked for 0.14.0?
06:45 < brg444> yeah nvm :P
06:48 -!- pigeons [~pigeons@94.242.209.214] has quit [Ping timeout: 260 seconds]     
06:58 -!- Giszmo [~leo@ip-69-233.219.201.nextelmovil.cl] has joined #bitcoin-core-dev     
06:59 -!- lclc_ [~lclc@unaffiliated/lclc] has quit [Read error: Connection reset by peer]     
07:00 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev     
07:15 -!- Giszmo [~leo@ip-69-233.219.201.nextelmovil.cl] has quit [Read error: Connection reset by peer]     
07:18 -!- pigeons [~pigeons@94.242.209.214] has joined #bitcoin-core-dev     
07:18 -!- pigeons is now known as Guest98910     
07:20 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Remote host closed the connection]     
07:20 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev     
07:23 -!- Guest98910 is now known as pigeons     
07:40 -!- Guest38580 is now known as thestringpuller     
07:40 -!- thestringpuller [~stevie@ec2-52-3-128-9.compute-1.amazonaws.com] has quit [Changing host]     
07:40 -!- thestringpuller [~stevie@unaffiliated/thestringpuller] has joined #bitcoin-core-dev     
07:54 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 264 seconds]     
07:58 -!- windsok [~windsok@45.63.59.8] has quit [Ping timeout: 240 seconds]     
08:13 -!- MarcoFalke [~marco@host53-2.natpool.mwn.de] has joined #bitcoin-core-dev     
08:19 < bitcoin-git> [bitcoin] earonesty opened pull request #9731: Bitcoin Unlimited Pull Request (master...release) https://github.com/bitcoin/bitcoin/pull/9731
08:20 < bitcoin-git> [bitcoin] earonesty closed pull request #9731: Bitcoin Unlimited Pull Request (master...release) https://github.com/bitcoin/bitcoin/pull/9731
08:20 < instagibbs> I seem to always forget, but what's the best way to get a reference(or copy) of a CScript as a unsigned char*
08:21 < instagibbs> sigh, as soon as I ask.. .front() seems to do trick
08:22 < cfields> didn't we give it a .data() ?
08:24 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt]     
08:24 < instagibbs> appears so in master, working on slightly older branch. good call.
08:32 < cfields> ah, ok
08:34 -!- windsok [~windsok@45.63.59.8] has joined #bitcoin-core-dev     
08:43 < sipa> instagibbs: you can't call front om an empty vector
08:44 < sipa> and if it isn't empty, &v[0] works fine
08:45 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev     
08:52 < instagibbs> what happens if I do call it on an empty vector?
08:52 < Chris_Stewart_5> index out of bounds? 
08:58 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev     
09:14 -!- MarcoFalke [~marco@host53-2.natpool.mwn.de] has quit [Quit: MarcoFalke]     
09:15 -!- MarcoFalke [~marco@host53-2.natpool.mwn.de] has joined #bitcoin-core-dev     
09:25 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]     
09:27 -!- Giszmo [~leo@ip-198-233.219.201.nextelmovil.cl] has joined #bitcoin-core-dev     
09:29 -!- marcoagner [~marcoagne@177.41.205.31] has joined #bitcoin-core-dev     
09:39 -!- Giszmo [~leo@ip-198-233.219.201.nextelmovil.cl] has quit [Ping timeout: 256 seconds]     
09:46 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
10:24 < sipa> instagibbs: undefined
10:25 < sipa> Chris_Stewart_5: no, operator[] does not do bounds checking. you're simply only allowed to call it for indexes that exist
10:38 < wumpus> it's one of the wacky things about c++, but we shouldn't care now that c++11 added .data()
10:39 < wumpus> we used to have begin_ptr and end_ptr functions to go from a vector to a begin/end pointer and wrap the "if empty" logic, but that's no longer necessary with data()
10:43 < Chris_Stewart_5> wumpus: Yes, coming from jvm land this has been a little confusing for me. I'll have to read more about .data()
10:45 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev     
10:48 < cfields> Chris_Stewart_5: throw .at() in for even more fun :)
10:52 < instagibbs> sigh. The More You Know
10:53 -!- molz_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
10:54 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 256 seconds]     
10:55 < wumpus> yes it's bizarre
10:56 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds]     
10:57 < MarcoFalke> meeting in 3 minutes I guess
10:57 < wumpus> yes     
11:00 < sipa> ploink
11:01 < MarcoFalke> everyone too busy reviewing code
11:01 < wumpus> #startmeeting
11:01 < lightningbot> Meeting started Thu Feb  9 19:01:39 2017 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
11:01 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
11:01 < jonasschnelli> hi     
11:02 < wumpus> topic: 0.14, I guess
11:03 < jonasschnelli> What holds the rc1 back? The open PRs with 0.14 tag?
11:03 < wumpus> there are some net issues
11:04 < jonasschnelli> #9698
11:04 < gribble> https://github.com/bitcoin/bitcoin/issues/9698 | net: fix socket close race by theuni · Pull Request #9698 · bitcoin/bitcoin · GitHub
11:04 < wumpus> #9698 #9715 #9720
11:04 < gribble> https://github.com/bitcoin/bitcoin/issues/9698 | net: fix socket close race by theuni · Pull Request #9698 · bitcoin/bitcoin · GitHub
11:04 < gribble> https://github.com/bitcoin/bitcoin/issues/9715 | Disconnect peers which we do not receive VERACKs from within 60 sec by TheBlueMatt · Pull Request #9715 · bitcoin/bitcoin · GitHub
11:04 < gribble> https://github.com/bitcoin/bitcoin/issues/9720 | net: fix banning and disallow sending messages before receiving verack by theuni · Pull Request #9720 · bitcoin/bitcoin · GitHub
11:04 < wumpus> but I'm not sure that's all; cfields here?
11:04 < cfields> and the atomics, or did those go in this morning?
11:05 < cfields> #9708
11:05 < gribble> https://github.com/bitcoin/bitcoin/issues/9708 | Clean Up all known races/platform-specific UB by TheBlueMatt · Pull Request #9708 · bitcoin/bitcoin · GitHub
11:05 < wumpus> you mean the wallet update counter?
11:05 < wumpus> that went in, I don't know about any other atomic changes
11:06 < cfields> wumpus: ^^
11:06 < cfields> not strictly necessary for 0.14, but makes it much easier to test the others
11:06 < wumpus> ok will tag that too
11:08 < wumpus> anything else?
11:08 < cfields> sorry for the last minute issues. For back-story/context, BlueMatt began testing in helgrind, and came up with a list of possible races in the net code. I wrote a quick fuzz tool to try to hit some, and managed to do so in a few cases. Some are new issues, some are long-standing
11:09 < wumpus> well, better to catch these before the release than after atleast :)
11:09 < achow101> besides these net issues there's just the importmulti stuff left, yes?
11:09 < cfields> the above PRs address all known races in the net code. By fixing even the harmless ones, it allows us to start using tools as part of c-i to avoid introducing new ones
11:09 < sipa> do we want to update the static seed IP list for 0.14?
11:10 < jonasschnelli> That would probably be a good idea.
11:10 < wumpus> yes, we usually do that before a major release
11:10 < wumpus> I'll do that
11:11 < cfields> do defaultAssumeValid/nMinimumChainWork get bumps before rc1?
11:11 < bitcoin-git> [bitcoin] jnewbery opened pull request #9732: [Trivial] Remove nonsense #undef foreach (master...removeundefforeach) https://github.com/bitcoin/bitcoin/pull/9732
11:11 < wumpus> #action update hardcoded seeds
11:12 < sipa> we can update chainTxData (only used for progress estimation) for sure
11:13 < wumpus> ok, do we have a script or something for that? I wouldn't know how to do that
11:13 < MarcoFalke> I propose we do the bumps in the commit prior to branch off. thus we don't need to redo the work for the master branch
11:14 < MarcoFalke> sipa: Is is mentioned in release process.md?
11:14 < sipa> MarcoFalke: i believe not
11:14 < sipa> MarcoFalke: i'll write a script, and add it to contrib/ ?
11:15 < MarcoFalke> Add a note to release-process.md at least, so we don't forget about it in the future.
11:15 < sipa> yeah, that too
11:15 < MarcoFalke> If the script is only for maintainers, you can add it to the maintainer repo
11:16 < sipa> it was updated in #9472, which is very recent, so i don't think it needs much adjusting, but we should have a procedure for it
11:16 < MarcoFalke> I think it helps devs if the main repo is kept lean
11:16 < sipa> ok     
11:17 < sipa> unsure what to do about defaultAssumeValid/nMinimumChainWork though
11:17 < gribble> https://github.com/bitcoin/bitcoin/issues/9472 | Disentangle progress estimation from checkpoints and update it by sipa · Pull Request #9472 · bitcoin/bitcoin · GitHub
11:18 < wumpus> yes it'd help to have the process described in any case
11:19 < gmaxwell> sipa: why unsure? there is a process documented in the relase instructions.
11:19 < gmaxwell> follow the process.
11:19 < MarcoFalke> sipa: We want those bumped as well, I guess. Would be nice to do assumevalid in a pull, so that people can review the hash.
11:20 < gmaxwell> (if the process there is somehow insufficent, -- PR's accepted.)
11:20 < sipa> gmaxwell: cool, i remember reviewing those release instructions even, just forgot about them
11:20 < gmaxwell> oh good. :P
11:21 < gmaxwell> There isn't a script but it's trivial enough that I didn't think one was needed. (it's basically 'call getblockchaininfo')
11:21 < sipa> yeah, chainTxData is a bit more complicated as it needs an estimate of the tx/s rate
11:21 < sipa> but i'll PR a release process update
11:22 < MarcoFalke> #action update release process for chainTxData
11:22 < gmaxwell> sipa: thats 'read two updatetip lines' ?
11:22 < wumpus> ideally it'd be automated with a script, especially as it's under "every minor release"
11:22 < gmaxwell> make a RPC that emits a patch. :P 
11:23 < wumpus> if it's manual work, it's probably going to be skipped for most minor releases
11:23 < wumpus> heck, weforget to update the version numbers half the time :-)
11:24 < wumpus> anyhow, any other topics?
11:24 < sipa> well what else is on the 0.14 tagged list?
11:24 < sipa> is #9392 going to be fixed?
11:24 < gribble> https://github.com/bitcoin/bitcoin/issues/9392 | Wallet ancestor sanity-check ignores sigops · Issue #9392 · bitcoin/bitcoin · GitHub
11:25 < jonasschnelli> #9108
11:25 < gribble> https://github.com/bitcoin/bitcoin/issues/9108 | Use importmulti timestamp when importing watch only keys by ryanofsky · Pull Request #9108 · bitcoin/bitcoin · GitHub
11:25 < sipa> i don't think 9392 is very high priority
11:25 < gmaxwell> I don't think 9392 is interesting at all.
11:25 < wumpus> ok, let's untag it for 0.14 then, there's enough high priority stuff to worry about
11:25 < gmaxwell> it's not something our wallet can violate.
11:25 < gmaxwell> (I think, or if so it would be super fringe)
11:26 < wumpus> ... it isn't tagged for 0.14
11:26 < wumpus> oh MarcoFalke just did that
11:26 < wumpus> :D     
11:29 < MarcoFalke> The other issues tagged for 0.14 have pulls open. I think this concludes the meeting
11:29 < achow101> does anything else need to be added to the release notes?
11:30 < jonasschnelli> Yes. https://github.com/bitcoin/bitcoin/issues/8455
11:30 < gmaxwell> I haven't been following the wiki release notes. Hows that been going?
11:31 < wumpus> from what I remember all the things on the list were done
11:31 < gmaxwell> cool.
11:31 < achow101> I added a ton of stuff a couple of weeks ago
11:31 < wumpus> yes, awesome work achow101
11:31 < sipa> nice
11:32 < jonasschnelli> thanks achow101 
11:33 < wumpus> I was planning on merging the release notes from the wiki just before the rc1 branch
11:34 < wumpus> or just after the 0.14 branch-off, in any case there's no reason to have them on master they'll be cleared there anyway
11:34 < MarcoFalke> you mean 0.14 branch or rc1 tag?
11:34 < wumpus> before the rc1 tag
11:34 < MarcoFalke> ok     
11:34 < wumpus> or after the 0.14 branch
11:34 < wumpus> doesn't matter much :)
11:34 < achow101> there's only two things on the release notes todo that aren't checked off. I can't write them because I don't understand those topics :(
11:35 < sdaftuar> the release notes currently have a recommendation to run Bitcoin Knots, for miners wishing to retain "priority" sorting for mining.  i don't think recommending other forks of the project is appropriate (as i've brought up in the past)
11:35 < sipa> sdaftuar: agree
11:35 < wumpus> I don't think that makes much sense either
11:36 < jonasschnelli> sdaftuar: definitively.
11:36 < gmaxwell> My concern is different:
11:36 < jtimon> wumpus: if they're cleared on master after the fact, yeah, it doesn't matter
11:36 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds]     
11:36 < gmaxwell> I think it's fine to recommend a compatible fork for a feature we don't care to support. BUT I think we should not be recommending priority, I think it's bad for users of the network.  
11:36 < wumpus> jtimon: master will end up with empty release notes to be filled in for 0.15
11:37 < sdaftuar> gmaxwell: my primary concern is that developers on this project have not reviewed other forks.  secondarily, i agree with your concern that we should not be recommending priority
11:37 < gmaxwell> (also, if miners do want to do priority, the best way would be using the rpc and a prioriizing daemon... but see my part (2))
11:37 < wumpus> (and, after 0.14.0 final is released, with the 0.14.0.md in historical release notes)
11:38 < gmaxwell> Part of my answer to luke when he was complaining about priority is that if miners want priority (I think ~none do) they could just use knots. I think that might motivate that release note recommendation.
11:38 < gmaxwell> But me saying "you can use knots" is not the same as the project saying it
11:38 < sdaftuar> gmaxwell: yes, i think it's fine if you or luke individually make that recommendation
11:38 < wumpus> just doesn't make sense to recommend it in the release notes
11:38 < sdaftuar> well, "fine" :)
11:39 < wumpus> would marginally make sense if it was an experimental feature we were expecting to merge in later
11:39 < jtimon> wumpus: I see, I tend to prefer to put as much in master as possible (and if it makes sense), but in this case it really doesn't matter
11:39 < gmaxwell> I could make a post about 'I think you shouldn't use priority, I think ~no one does, but if you want-- there is knots' which might make luke happier. I wouldn't mind doing that personally.
11:39 < jtimon> it's release notes
11:42 < gmaxwell> in any case, +1 for removing that from release notes.
11:42 < achow101> it's gone
11:42 < jtimon> maybe just a question in a faq or something? "we don't recomment using prioirty, but if you miss it, there's knots at..."
11:43 < gmaxwell> jtimon: infrequently asked questions
11:43 < achow101> (jonasschnelli removed it) 
11:43 < gmaxwell> never asked questions
11:43 < jtimon> gmaxwell: yeah, in some iaq.html then
11:46 < wumpus> ok, any other topics?
11:47 < wumpus> if not, let's close the meeting
11:47 < gmaxwell> I'm excited to get 0.14 out. It's got lots of great stuff. :)
11:48 < cfields> +1 :)
11:48 < sipa> indeed
11:48 < wumpus> me too, it should be close now, everyone review!: https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.14.0
11:48 < jtimon> yep, many optimizations and cleanups
11:49 < wumpus> #endmeeting
11:49 < lightningbot> Meeting ended Thu Feb  9 19:49:42 2017 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
11:49 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2017/bitcoin-core-dev.2017-02-09-19.01.html
11:49 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2017/bitcoin-core-dev.2017-02-09-19.01.txt
11:49 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2017/bitcoin-core-dev.2017-02-09-19.01.log.html
11:50 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev     
11:56 < morcos> oops sorry, the snow distracted me from the meeting
11:57 < morcos> achow101: you said there are 2 unchecked off things, but are there other things that need to be in release notes
11:57 < morcos> i think i need to mention all my new minimum fees
11:57 < sipa> morcos: comment about that on #8455 ?
11:57 < gribble> https://github.com/bitcoin/bitcoin/issues/8455 | TODO for release notes 0.14.0 · Issue #8455 · bitcoin/bitcoin · GitHub
11:57 < morcos> i can do that, but what's my deadline?  
11:58 < MarcoFalke> morcos: Probably when rc1 is tagged
11:59 < morcos> ok, i can probably do it tomorrow if not tonight
12:06 < achow101> morcos: add them to the list with links to relevant PRs
12:21 -!- Giszmo [~leo@ip-106-233.219.201.nextelmovil.cl] has joined #bitcoin-core-dev     
12:31 < achow101> do maintainer scripts have to by python scripts?
12:34 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev     
12:43 -!- Giszmo [~leo@ip-106-233.219.201.nextelmovil.cl] has quit [Read error: Connection reset by peer]     
12:48 < sipa> achow101: no, but they have to be usable by the people that tend to run them :)
12:48 < sipa> (i would object to a visual basic program, for example)
12:48 < achow101> so bash would be fine
12:48 < sipa> oh, sure
12:50 < achow101> ok. I think I'm going to write a do-the-pre-release-things script which does the version increment, seed update, etc
12:51 < achow101> (because apparently we forget to do those)
13:01 -!- Giszmo [~leo@ip-106-233.219.201.nextelmovil.cl] has joined #bitcoin-core-dev     
13:17 < sipa> achow101: that would be nice
13:30 < BlueMatt> does anyone have a 0.14-testing branch anywhere?
13:30 < BlueMatt> (ie with all the 0.14-tagged things merged)
13:39 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 255 seconds]     
13:41 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev     
13:47 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds]     
13:48 -!- MarcoFalke [~marco@host53-2.natpool.mwn.de] has quit [Quit: MarcoFalke]     
13:49 -!- wvr [~wvr@120.red-83-46-24.dynamicip.rima-tde.net] has quit [Ping timeout: 255 seconds]     
13:50 -!- wvr [~wvr@35.red-79-152-21.dynamicip.rima-tde.net] has joined #bitcoin-core-dev     
14:05 -!- marcoagner [~marcoagne@177.41.205.31] has quit [Ping timeout: 240 seconds]     
14:07 < cfields> BlueMatt: not an answer to your question, but another branch for you to look at: https://github.com/theuni/bitcoin/tree/2017-02-fix-copystats-races
14:08 < BlueMatt> cfields: what all is integrated there?
14:08 < cfields> BlueMatt: that adds threading annotations for most net vars, and verifies your race fixes
14:08 < BlueMatt> ahh     
14:08 -!- marcoagner [~marcoagne@177.41.205.31] has joined #bitcoin-core-dev     
14:08 < BlueMatt> is the first a fix for more races?
14:08 < cfields> here are the outstanding ones it turned up: https://github.com/theuni/bitcoin/commit/d185ca0840f8107b2cf4307f51d703e849532928
14:09 < BlueMatt> ahh, not actual races because of ordering of Start/Stop with other things, but, yea, should fix
14:09 < cfields> yea. i don't think we actually need to worry about most of it
14:09 < cfields> the only one with any weight is the cs_filter
14:10 < cfields> that one's still actually racy
14:10 < BlueMatt> oh, I guess i never evicted in helgrind, yea
14:11 < cfields> it's fRelayTxes and pfilter
14:11 < BlueMatt> yea     
14:11 < BlueMatt> oh pfilter too? ouch
14:12 < BlueMatt> oh, pfilter != NULL
14:12 < BlueMatt> not so bad
14:12 < BlueMatt> but, yea, race
14:13 < cfields> adding the lock there is kinda ugly, any better ideas?
14:15 < BlueMatt> cfields: I think the lock is fine? I mean it goes away two LOC later?
14:21 < cfields> BlueMatt: just that cs_filter is held with wide scope in net_processing, i'm concerned about the ordering
14:22 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev     
14:26 < BlueMatt> cfields: agreed, does clang do lockorder checking in its compile-time stuff?
14:26 < BlueMatt> (or can we make it?)
14:26 < sipa> yes     
14:27 < cfields> yea, you can tell it that a lock is not allowed here
14:27 < cfields> playing with that now
14:28 < sipa> the definitions in src/threadsafety.h
14:48 < cfields> ACQUIRED_BEFORE(...) and ACQUIRED_AFTER(...) are currently unimplemented
14:48 < cfields> fantastic.
14:49 < BlueMatt> heh     
14:49 < BlueMatt> does clang support them, though?
14:49 < cfields> https://clang.llvm.org/docs/ThreadSafetyAnalysis.html
14:50 < cfields> that's from the clang docs
14:50 -!- droark [~droark@c-24-22-123-27.hsd1.or.comcast.net] has quit [Quit: Later.]     
14:50 < BlueMatt> heh     
15:12 -!- gluytium [U2FsdGVkX1@ma.sdf.org] has joined #bitcoin-core-dev     
15:15 < cfields> mm, nope. It's not smart enough to figure it out. The fact that cs_vNodes lives in CConnman and cs_filter lives in CNode is too much.
15:16 -!- musalbas [~musalbas@2001:bc8:30c2:ff00::] has quit [Ping timeout: 256 seconds]     
15:16 -!- musalbas [~musalbas@2001:bc8:30c2:ff00::] has joined #bitcoin-core-dev     
15:16 < luke-jr> can someone reopen #7339 please?
15:16 < gribble> https://github.com/bitcoin/bitcoin/issues/7339 | Support building without libevent by luke-jr · Pull Request #7339 · bitcoin/bitcoin · GitHub
15:32 -!- jeremyrubin [~jeremyrub@biohazard-cafe.mit.edu] has quit [Ping timeout: 240 seconds]     
15:33 -!- jeremyrubin [~jeremyrub@biohazard-cafe.mit.edu] has joined #bitcoin-core-dev     
15:35 -!- harrymm1 [~wayne@104.207.83.13] has joined #bitcoin-core-dev     
15:35 -!- marcoagner [~marcoagne@177.41.205.31] has quit [Quit: Leaving]     
15:36 -!- harrymm [~wayne@191.96.49.161] has quit [Ping timeout: 240 seconds]     
15:36 < cfields> BlueMatt: how much do you hate this https://github.com/theuni/bitcoin/commit/c6a93bd5313297d7ec091988a46366cfc12fef3c ? rather just pile on more atomics instead?
15:41 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev     
16:21 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has quit [Quit: MarcoFalke]     
16:30 -!- JackH [~laptop@79-73-188-131.dynamic.dsl.as9105.com] has quit [Remote host closed the connection]     
16:40 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)]     
16:59 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Ping timeout: 240 seconds]     
17:01 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com]     
17:04 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev     
17:26 < bitcoin-git> [bitcoin] sipa opened pull request #9733: Add getchaintxstats RPC (master...chaintxstats) https://github.com/bitcoin/bitcoin/pull/9733
17:35 -!- Giszmo [~leo@ip-106-233.219.201.nextelmovil.cl] has quit [Remote host closed the connection]     
17:39 < BlueMatt> cfields: 0.15, please
17:40 < BlueMatt> cfields: lets please get simple-to-review shit so we can (finally) get 0.14 out the door
17:42 -!- wvr [~wvr@35.red-79-152-21.dynamicip.rima-tde.net] has quit [Quit: Leaving]     
17:47 < cfields> BlueMatt: see the PR. I really have no preference
17:47 < BlueMatt> wait, which pr?
17:48 < BlueMatt> oh, comment
18:00 < BlueMatt> cfields: I guess my (weak) preference is atomics
18:00 < BlueMatt> because it doesnt change the compiled code for x86 (well, ok, only if we use release/acquire, but close enough) and is more obviously correct (tm)
18:01 < cfields> BlueMatt: works for me.
18:02 < BlueMatt> cfields: want me to pull it into that pr or a new one? it already has acks....
18:02 < cfields> heh     
18:03 < BlueMatt> hmm?
18:03 < cfields> BlueMatt: well, technically commit is buggy because it doesn't fix the race as advertised. So i'd call that a fix to the PR as opposed to something new
18:04 < cfields> so I think it makes sense to just stick on top and poke for quick re-acks
18:05 < BlueMatt> I'll change the pr title, then :p
18:05 < BlueMatt> wait, no pr title was valid when opened
18:06 < BlueMatt> "Clean up all known races/platform-specific UB at the time PR was opened #9708
18:06 < BlueMatt> "     
18:06 < BlueMatt> happy now?
18:06 < gribble> https://github.com/bitcoin/bitcoin/issues/9708 | Clean up all known races/platform-specific UB at the time PR was opened by TheBlueMatt · Pull Request #9708 · bitcoin/bitcoin · GitHub
18:06 < BlueMatt> :p     
18:07 < cfields> heh, I was just making the point that it's a fix. I really don't care :)
18:07 < cfields> lol     
18:07 < cfields> ok, i'm definitely closing mine now though, since 9708 is tagged for 0.14
18:08 < BlueMatt> ok, sounds good, open another one :)
18:09 < cfields> tell you what, I'll open another one based on master if it happens to not conflict with yours
18:09 < BlueMatt> great! :)
18:09 < cfields> without looking, i'd call it 50/50 :)
18:10 < BlueMatt> conflict on git's within-3-lines shit? probably....actually conflict? no
18:13 < bitcoin-git> [bitcoin] theuni closed pull request #9695: net: fix a few races. Credit @TheBlueMatt (master...net-atomic) https://github.com/bitcoin/bitcoin/pull/9695
18:13 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-chvtzoekgygtbvjm] has quit [Quit: Connection closed for inactivity]     
18:16 < cfields> actually, I think I'll pass on it either way. I think fatigue of these race commits is starting to set in. And since it's two 1-bit comparisons that have existed in prior releases, it's just not worth holding things up
18:16 -!- da2ce7 [~da2ce7@opentransactions/dev/da2ce7] has quit [Disconnected by services]     
18:17 < BlueMatt> cfields: ok, I have no objections to that, either...when its std::string copies I'm not very happy, when its just pointer == NULL comparisons I suppose I dont care much
18:18 < cfields> BlueMatt: sure. The only reason I'd push for it is if it was the lone thing keeping valgrind/helgrind/tsan/etc. from running cleanly.
18:18 < BlueMatt> fair
18:18 < cfields> and I don't think that's the case?
18:19 -!- da2ce7 [~da2ce7@opentransactions/dev/da2ce7] has joined #bitcoin-core-dev     
18:19 < BlueMatt> my helgrind is still running cleanly :)
18:30 -!- da2ce7 [~da2ce7@opentransactions/dev/da2ce7] has quit [Ping timeout: 255 seconds]     
19:10 < bitcoin-git> [bitcoin] sipa opened pull request #9734: Add updating of chainTxData to release process (master...chaintxnotes) https://github.com/bitcoin/bitcoin/pull/9734
19:37 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has quit [Ping timeout: 258 seconds]     
19:43 < gmaxwell> Whatever patch stack I'm running with here makes tsan clean except for some startup noise.
19:43 < gmaxwell> (by noise I mean real issues, in this case.)
20:43 -!- goksinen [~goksinen@2604:2000:c591:8400:2904:ad96:63c3:2ba] has joined #bitcoin-core-dev     
20:53 -!- goksinen_ [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev     
21:01 -!- gluytium [U2FsdGVkX1@ma.sdf.org] has quit [Ping timeout: 260 seconds]     
21:04 -!- gluytium [U2FsdGVkX1@ma.sdf.org] has joined #bitcoin-core-dev     
21:07 -!- goksinen_ [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection]     
21:07 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Quit: bye]     
21:18 -!- Sosumi [~Leon@bl10-113-190.dsl.telepac.pt] has quit [Quit: Bye]     
21:19 -!- dodo [~goksinen@2604:2000:c591:8400:a180:c3e:6553:d6cd] has joined #bitcoin-core-dev     
21:19 -!- dodo is now known as Guest24942     
21:22 -!- goksinen [~goksinen@2604:2000:c591:8400:2904:ad96:63c3:2ba] has quit [Ping timeout: 255 seconds]     
21:23 -!- goksinen [~goksinen@2604:2000:c591:8400:a14c:fdca:ce8b:566] has joined #bitcoin-core-dev     
21:25 -!- Guest24942 [~goksinen@2604:2000:c591:8400:a180:c3e:6553:d6cd] has quit [Ping timeout: 255 seconds]     
21:28 -!- goksinen [~goksinen@2604:2000:c591:8400:a14c:fdca:ce8b:566] has quit [Remote host closed the connection]     
21:40 -!- cannon-c [ccc23f04@gateway/web/freenode/ip.204.194.63.4] has joined #bitcoin-core-dev     
22:04 -!- instagibbs [~instagibb@pool-100-15-114-3.washdc.fios.verizon.net] has quit [Ping timeout: 258 seconds]     
22:06 -!- instagibbs [~instagibb@pool-100-15-114-3.washdc.fios.verizon.net] has joined #bitcoin-core-dev     
22:26 -!- da2ce7 [~da2ce7@opentransactions/dev/da2ce7] has joined #bitcoin-core-dev     
22:46 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev     
23:01 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-fqjghlfhhxozstpt] has joined #bitcoin-core-dev     
23:22 -!- beyondsee [792e0581@gateway/web/freenode/ip.121.46.5.129] has joined #bitcoin-core-dev     
23:24 < beyondsee> any one here?
23:28 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev     
23:28 < sipa> nope
23:31 < cannon-c> no     
23:36 < paveljanik> haven't seen any one for a long time...
23:36 < sipa> paveljanik! what a surprise!
23:43 < paveljanik> gribble" later tell anyone Beyonce wanted to talk to you