--- Day changed Fri Feb 17 2017
00:07 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/afae75fd3dad...8dee82217708
00:07 < bitcoin-git> bitcoin/master 55c403b John Newbery: Ensure `-maxsigcachesize` is in valid range...
00:07 < bitcoin-git> bitcoin/master 8dee822 Wladimir J. van der Laan: Merge #9777: Handle unusual maxsigcachesize gracefully...
00:07 < bitcoin-git> [bitcoin] laanwj closed pull request #9777: Handle unusual maxsigcachesize gracefully (master...sigcache2) https://github.com/bitcoin/bitcoin/pull/9777
00:14 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev     
00:18 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds]     
00:35 -!- yuki-t [7697b88d@gateway/web/freenode/ip.118.151.184.141] has joined #bitcoin-core-dev     
00:36 -!- yuki-t [7697b88d@gateway/web/freenode/ip.118.151.184.141] has quit [Client Quit]     
00:46 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev     
00:50 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds]     
01:32 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev     
01:35 -!- city22 [~textual@210.13.244.130] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]     
01:36 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds]     
01:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
01:40 -!- wumpus [~quassel@pdpc/supporter/professional/wumpus] has joined #bitcoin-core-dev     
01:41 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
01:43  * wumpus running gitian builds to check pre-rc1
01:44 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds]     
01:45 < Victorsueca> wumpus: you're going to tag 0.14 rc1 today?
01:54 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
01:56 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds]     
02:00 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
02:02 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds]     
02:03 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev     
02:07 < wumpus> Victorsueca: unless there is a critical issue, that's the plan
02:07 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds]     
02:09 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #bitcoin-core-dev     
02:09 -!- zyla [~zyla@185.56.175.154] has joined #bitcoin-core-dev     
02:11 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 260 seconds]     
02:12 < Victorsueca> wumpus: anything that needs some extra testing on windows?
02:17 < wumpus> argh my dev/build machine died, that's not a good start of the day...
02:19 < Victorsueca> RIP     
02:24 -!- JackH [~laptop@79-73-188-131.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev     
02:27 -!- mrkent [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev     
02:27 -!- mrkent [~textual@unaffiliated/mrkent] has quit [Client Quit]     
02:28 -!- mrkent [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev     
02:28 -!- mrkent [~textual@unaffiliated/mrkent] has quit [Client Quit]     
02:30 -!- chris2000 [~chris2000@p5082AAC3.dip0.t-ipconnect.de] has joined #bitcoin-core-dev     
02:35 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev     
02:39 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds]     
02:48 < wumpus> building bitcoin core apparently breaks power supplies now :-) things should be back to normal, restarting testing gitian builds in a bit
02:49 < gmaxwell> libsecp256k1 easily overheats cpus.
02:51 < luke-jr> building it⁇
02:51 < gmaxwell> for libsecp256k1? running the tests... which you hopefully do at build time!
02:54 < Victorsueca> I'm making the depends and it's downloading samba ccache, is that new or it just got updated?
02:55 < Victorsueca> ffs, it's downloading everything again, not sure why
02:57 < Victorsueca> I hate building boost
02:57 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev     
03:01 < wumpus> building boost should be very quick, at least from depends, we have restricted that to only build the modules and variants that we actually use
03:02 < wumpus> building qt on the other hand...
03:02 < wumpus> we have done the same there - select only what we need, but GUI toolkits are beasts
03:05 < Victorsueca> problem with boost is not nly the time it takes, it's quiet, there's nothing more stressing than that, you don't know if it's still building or it got stuck
03:06 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev     
03:08 < wumpus> I'm pretty sure there's a flag to make it verbose, if you want that
03:10 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev     
03:11 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds]     
03:37 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev     
03:42 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8dee82217708...3c02b957402e
03:42 < bitcoin-git> bitcoin/master 3f78e46 Gregory Maxwell: Update nMinimumChainWork and defaultAssumeValid.
03:42 < bitcoin-git> bitcoin/master 3c02b95 Wladimir J. van der Laan: Merge #9779: Update nMinimumChainWork and defaultAssumeValid....
03:42 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds]     
03:42 < bitcoin-git> [bitcoin] laanwj closed pull request #9779: Update nMinimumChainWork and defaultAssumeValid. (master...update_chainparams) https://github.com/bitcoin/bitcoin/pull/9779
03:51 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3c02b957402e...ad168ef4e308
03:51 < bitcoin-git> bitcoin/master 91fb506 Alex Morcos: Add two hour buffer to manual pruning
03:51 < bitcoin-git> bitcoin/master ad168ef Wladimir J. van der Laan: Merge #9778: Add two hour buffer to manual pruning...
03:51 < bitcoin-git> [bitcoin] laanwj closed pull request #9778: Add two hour buffer to manual pruning (master...2hrprune) https://github.com/bitcoin/bitcoin/pull/9778
03:54 < bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/ad168ef4e308...9828f9a9962c
03:54 < bitcoin-git> bitcoin/master 8be0866 Russell Yanofsky: [qa] Simplify import-rescan.py...
03:54 < bitcoin-git> bitcoin/master c28583d Russell Yanofsky: [qa] Extend import-rescan.py to test specific key timestamps
03:54 < bitcoin-git> bitcoin/master 38d3e9e Russell Yanofsky: [qa] Extend import-rescan.py to test imports on pruned nodes.
03:54 < bitcoin-git> [bitcoin] laanwj closed pull request #9761: Use 2 hour grace period for key timestamps in importmulti rescans (master...pr/multigrace) https://github.com/bitcoin/bitcoin/pull/9761
04:05 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has quit [Ping timeout: 260 seconds]     
04:09 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev     
04:14 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds]     
04:14 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev     
04:40 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
04:42 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev     
04:43 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds]     
04:47 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 260 seconds]     
05:13 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev     
05:17 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds]     
05:34 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has joined #bitcoin-core-dev     
05:45 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev     
05:49 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds]     
05:53 < achow101> don't forget to increment the version number this time :p
06:07 -!- olsa [573c05a3@gateway/web/freenode/ip.87.60.5.163] has joined #bitcoin-core-dev     
06:11 -!- olsa [573c05a3@gateway/web/freenode/ip.87.60.5.163] has quit [Client Quit]     
06:15 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev     
06:20 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds]     
06:21 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Quit: WeeChat 0.4.2]     
06:24 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
06:25 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev     
06:34 -!- ibrightly [sid113387@gateway/web/irccloud.com/x-bllngketlgxuodrr] has quit [Read error: Connection reset by peer]     
06:34 -!- ibrightly [sid113387@gateway/web/irccloud.com/x-gzgcsrssreyejcty] has joined #bitcoin-core-dev     
06:36 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev     
06:40 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds]     
06:55 -!- Giszmo1 [~leo@ip-247-233.219.201.nextelmovil.cl] has joined #bitcoin-core-dev     
06:57 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has quit [Ping timeout: 240 seconds]     
06:59 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev     
07:09 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev     
07:16 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Quit: bye]     
07:49 -!- Guest84185 [~socrates1@li175-104.members.linode.com] has quit [Changing host]     
07:49 -!- Guest84185 [~socrates1@unaffiliated/socrates1024] has joined #bitcoin-core-dev     
07:50 -!- Guest84185 is now known as amiller     
07:52 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev     
07:55 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
07:58 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds]     
08:19 < wumpus> I don't think I ever forgot that for a major release, just minor releases
08:24 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/bc69f34b3537a7d34fb7f89b4acd619749bc6cc2
08:24 < bitcoin-git> bitcoin/0.14 bc69f34 Wladimir J. van der Laan: build: bump version to 0.14.0
08:26 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev     
08:27 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/f87e8f53920adfa80a3f4af9435370dc272c3783
08:27 < bitcoin-git> bitcoin/master f87e8f5 Wladimir J. van der Laan: build: bump version to 0.14.99...
08:28 < achow101> ooh branching
08:29 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev     
08:33 -!- chjj [~chjj@unaffiliated/chjj] has quit [Remote host closed the connection]     
08:38 -!- MarcoFalke_ [8af602fa@gateway/web/cgi-irc/kiwiirc.com/ip.138.246.2.250] has joined #bitcoin-core-dev     
08:39 < MarcoFalke_> branch off ''\o/''
08:40 < wumpus> yep, it's that time of the year
08:43 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/f68e4414d77aeb60d8dee1b2e53a195ff15b2c48
08:43 < bitcoin-git> bitcoin/0.14 f68e441 Wladimir J. van der Laan: qt: pre-rc1 translations update
08:46 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer]     
08:46 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev     
08:47 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
08:47 < MarcoFalke_> I think `gen-manpages.sh` needs to be run on 0.14
08:47 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev     
08:48 < wumpus> ok     
08:49 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/1a02ecc73af4b4ac36da1bd04f9e7eddf640e48f
08:49 < bitcoin-git> bitcoin/0.14 1a02ecc Wladimir J. van der Laan: doc: Update release notes from wiki
08:57 < wumpus> will do that in a bit
09:04 < cfields> did a full gitian build of linux/win/osx as of a few commits ago (afae75fd3da). So far, linux/osx test_bitcoin pass, osx gets reliable rpc test failure: http://pastebin.com/raw/7mgt7jsQ
09:04 < wumpus> argh
09:05 < cfields> will re-test from 0.14 after the latest importmulti changes
09:05 -!- Arvidt [~Arvidt@p5B2AB21C.dip0.t-ipconnect.de] has joined #bitcoin-core-dev     
09:06 < wumpus> and it doesn't happen with normal build of the same, just gitian?
09:06 < wumpus> I don't remember that issue on travis so probably
09:06 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Remote host closed the connection]     
09:06 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection]     
09:06 -!- Giszmo1 [~leo@ip-247-233.219.201.nextelmovil.cl] has quit [Quit: Leaving.]     
09:07 < cfields> wumpus: i haven't tried an osx build from the same spot, i'll do that at the same time as the 0.14 rebuild
09:08 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev     
09:09 < Arvidt> Is it better for Bitcoin to run a full node, or is it also ok ok to run a pruned node with 100 GiB (-prune=100000) ?
09:09 < wumpus> when running a pruned node it doesn't matter what the size is, no pruned node will serve blocks
09:10 < wumpus> so if you want to provide blocks to other nodes that are bootstrapping, you need to run a non-pruned node, at least currently
09:12 < Arvidt> ok, thanks for the info. There is very few information about pruned mode in the internet, only bitcoiin core release notes and some bitcointalk thread that are two years old.
09:13 < wumpus> the full node guide mentions pruning as well https://bitcoin.org/en/full-node#configuration-tuning  , though it doesn't mention that currently pruned nodes will not serve blocks
09:14 < wumpus> feel free to add it, most if not all the documents are open source
09:14 -!- MarcoFalke_ [8af602fa@gateway/web/cgi-irc/kiwiirc.com/ip.138.246.2.250] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]     
09:20 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 255 seconds]     
09:22 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/268c390d02d99a4a93a0a01221e273d2b9695ff7
09:22 < bitcoin-git> bitcoin/0.14 268c390 Wladimir J. van der Laan: doc: Update manpages for 0.14.0
09:24 < cfields> wumpus: local build passes :\. Waiting for gitian built to finish so i can compare.
09:29 -!- aalex [~aalex@64.187.177.58] has quit [Ping timeout: 268 seconds]     
09:32 < wumpus> ok, hopefully it was a false positive
09:33 < cfields> wumpus: yes, that tests passes on 0.14. Still waiting for the whole suite to finish, but looks like a false alarm
09:34 < achow101> I had an rpc test failing yesterday, I'm checking again now on master to see if it still fails
09:37 < achow101> yeah, zmq_test.py still fails for me
09:42 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev     
09:42 < cfields> ok, all osx pass
09:44 < cfields> wumpus: need to bump the gitian descriptors if we want separate package caches for 0.13/0.14. Will PR now.
09:52 < bitcoin-git> [bitcoin] theuni opened pull request #9783: release: bump gitian descriptors for a new 0.14 package cache (0.14...gitian-descriptor-bump) https://github.com/bitcoin/bitcoin/pull/9783
09:56 < Chris_Stewart_5> Will this 'normalize' function in secp256k1 strip uneccessary padding on signatures? https://github.com/bitcoin/bitcoin/blob/master/src/pubkey.cpp#L183
09:56 < Chris_Stewart_5> We have a specific test in script_tests.json that pads R values and doesn't require DERSIG flag
10:10 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has quit [Ping timeout: 260 seconds]     
10:13 < wumpus> cfields: I had no idea that we were still using the 0.13 dependencies for master
10:14 < bitcoin-git> [bitcoin] laanwj closed pull request #9783: release: bump gitian descriptors for a new 0.14 package cache (0.14...gitian-descriptor-bump) https://github.com/bitcoin/bitcoin/pull/9783
10:15 < cfields> wumpus: it doesn't matter a ton. The chain is hashed and it always grabs the right deps based on the recipe. Splitting just lets you keep them separate, so you can stash 0.13 away if you want, to save time for 0.13.3 build
10:25 < wumpus> cfields: right
10:27 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]     
10:28 < gmaxwell> release notes still say nothing about the massive performance improvements. Shall I write something?
10:28 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
10:29 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/871e19ac84ae71b3d22928d5cb3bbf4f0f013b07
10:29 < bitcoin-git> bitcoin/0.14 871e19a Wladimir J. van der Laan: doc: Add list of authors to release notes...
10:29 < wumpus> sure, that'd be very welcome, release notes can be updated until the final release
10:30 < wumpus> still need to add the big list of changes too
10:32 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds]     
10:32 < cfields> gmaxwell: i started to a few days ago but got distracted. I'm unsure if we want to just add a "performance increases" section and add a bunch of stuff, or add individual features and mention what they speed up
10:33 < gmaxwell> Perfmrnace increases with a line per improvement might be nice. 
10:34 < cfields> gmaxwell: works for me. Have you already started, or shall I?
10:35 < gmaxwell> Go ahead.  Hm. I thought I wrote release notes for assume valid.
10:35 < gmaxwell> that certantly should be release noted, esp as someone might feel its a security model change (at least without the explination)
10:36 < gmaxwell> oh  Idid and it was just all removed. :(
10:36 < cfields> gmaxwell: sure, and imo it goes under performance improvements. Not sure if that's what you were implying. But to an end-user, that's surely the benefit
10:37 < gmaxwell> It is a performance improvement but unless explained it could be understood as a significant security model change.
10:37 < gmaxwell> Can someone please explain to me why the release note for that was removed?
10:38 < wumpus> what was removed? you should edit the release notes in 0.14, not on master
10:38 < wumpus> master was completely cleaned out
10:38 < gmaxwell> wumpus: doing that means that changes that write their release notes get their notes nuked.
10:38 < sipa> gmaxwell: ?
10:39 < wumpus> gmaxwell: this has been the case for every major release
10:39 < sipa> things that are merged in 0.14 have their notes in 0.14
10:39 < wumpus> 0.14 is branched off, master is 0.15 now
10:39 < gmaxwell> The releas enote was removed for 0.14
10:39 < gmaxwell> https://github.com/bitcoin/bitcoin/commit/1a02ecc73af4b4ac36da1bd04f9e7eddf640e48f#diff-ef76fd6674f07db88c3422fdbf0bcf9fL79
10:39 < sipa> ah, update from the wiki
10:40 < gmaxwell> so was  -0.14.0 Fundrawtransaction change address reuse 
10:40 < wumpus> gmaxwell: wasn't that just moved somewhere else?
10:40 < achow101> the problem was that some things got into the release notes in the repo, and others were in the wiki
10:40 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev     
10:40 < wumpus> it's in the wrong place after all, in the section reserved for PRs
10:41 < wumpus> so my assumption was that it was moved upwards, but if it got removed it should be added back (in the right place)
10:41 < gmaxwell> wumpus: it was in the notable changes section, and no it's nowhere mentioned in the release notes now.
10:41 < wumpus> ok, re-add it then
10:42 < gmaxwell> At least I know what happened now!
10:42 < gmaxwell> I think we do want changes writing their own release notes, no? we'll just need to figure out how to merge that with the wiki.
10:42 < gmaxwell> (in the future)
10:42 < wumpus> gmaxwell: I apparently missed that when merging changes from the wiki; I saw some stuff was removed, but Ithought it were just the items in the wrong place that were merged back
10:43 < wumpus> in the future we should pay attention to changes, just like you did now, good job
10:43 < wumpus> :)     
10:45 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds]     
10:47 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
10:48 < cfields> sipa / gmaxwell: any notable perf improvements from libsecp256k1 for 0.14? I'm hazy on the timeline
10:51 < sipa> cfields: no, i don't think so
10:51 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev     
10:52 < cfields> ok, thanks
10:52 < cfields> ah, docs need ctaes reference
10:52 < sipa> oh, was ctaes new for 0.14?
10:53 < gmaxwell> No.     
10:53 -!- adiabat [~adiabat@67.205.158.84] has quit [Remote host closed the connection]     
10:54 -!- adiabat [~adiabat@67.205.158.84] has joined #bitcoin-core-dev     
10:55 < cfields> huh, seemed recent
10:55 < bitcoin-git> [bitcoin] gmaxwell opened pull request #9784: Restore removed release notes. (0.14...release_notes) https://github.com/bitcoin/bitcoin/pull/9784
10:56 < cfields> yep, present in 0.13.0. nm.
10:56 < gmaxwell> I don't know if we ever release noted. :)
10:57 < cfields> jus this: - #7689 `b89ef13` Replace OpenSSL AES with ctaes-based version (sipa)
10:57 < gribble> https://github.com/bitcoin/bitcoin/issues/7689 | Replace OpenSSL AES with ctaes-based version by sipa · Pull Request #7689 · bitcoin/bitcoin · GitHub
10:58 < wumpus> is it something that affects end users much?
10:58 < gmaxwell> yea, kinda sad because that was a relly impressive work.
10:58 < gmaxwell> a secondary purpose of release notes, its also a communication channel about what we're doing.
10:58 < gmaxwell> (and interesting to)
10:59 < gmaxwell> the only effect on users was that it avoided some build problems with openssl api changes that some people expirenced later.
10:59 < wumpus> the release notes for 0.13 were already huge, if there are too many notable changes no one is going to read everything
10:59 < wumpus> I think it's fine to not add a specific paragraph for everything
11:00 < wumpus> i'm certainly in favor of publishing awesome developer changes in bitcoin core, but I'm not sure the release notes is the right place for that
11:00 < wumpus> a tech blog on bitcoincore.org would be nice
11:00 < gmaxwell> That is fair too.
11:01 < gmaxwell> But who has the time?
11:01 < wumpus> well if you'd have the time to add it to the release notes, you'd also have time to write a blog post, those are equivalent time-wise
11:02 < gmaxwell> release note would have been one/two paragraphs, would make for a kind of lame blogpost. :P
11:02 < wumpus> brg444 did a nice writeup on bitcoin core performance improvements
11:02 < gmaxwell> but there could be summary posts, I suppose with things that weren't important enough to usage to go into the release notes.
11:02 < wumpus> why? not everything needs to be a long story
11:03 < wumpus> short, frequent updates are good too
11:03 < Chris_Stewart_5> The Chronicles of Bitcoin Core (TM) 
11:03 < gmaxwell> I hope he hasn't published that yet, it didn't have measurement last I saw and was weaker without it... unfortunately it takes so long to sync with older versions it takes a while to get numbers! :)
11:05 < wumpus> I don't think he has, but I like that it puts everything into context
11:05 < gmaxwell> wumpus: Thanks, good points.
11:06 < gmaxwell> Yea, I saw a draft too... I should check again, it was missing a bunch of stuff but I bet he's added it now.
11:24 < gmaxwell> We have two stack protector not protecting compiler warnings on 0.14 branch, might want to consider fixing in the next RC if they're trivial fixes.
11:25 < cfields> gmaxwell: ah, nice. I've been trying to figure out how to state the net performance improvements in a meaningful way. Full IBD from before/after seems pretty reasonable.
11:25 < wumpus> what causes those?
11:25 < wumpus> and I don't think I've ever seen those warnings, what gcc/clang gives them?
11:25 < gmaxwell> "running newer compilers" :P   
11:25 < gmaxwell> httprpc.cpp: In function ‘bool HTTPReq_JSONRPC(HTTPRequest*, const string&)’:
11:25 < gmaxwell> httprpc.cpp:150:13: warning: stack protector not protecting local variables: variable length buffer [-Wstack-protector] static bool HTTPReq_JSONRPC(HTTPRequest* req, const std::string &)
11:26 < gmaxwell> qt/test/paymentservertests.cpp: In member function ‘void PaymentServerTests::paymentServerTests()’:
11:26 < gmaxwell> qt/test/paymentservertests.cpp:65:6: warning: stack protector not protecting local variables: variable length buffer [-Wstack-protector]
11:26 < gmaxwell>  void PaymentServerTests::paymentServerTests()
11:26 < gmaxwell>       ^~~~~~~~~~~~~~~~~~
11:26 < wumpus> oh in the tests in not important
11:26 < gmaxwell> first one isn't in tests. httprpc.
11:27 < gmaxwell> anyways anyone running more recent gcc will get them. (I don't know how recent is required, but 6.3.0 has them)
11:27 < wumpus> variable-length buffer on the stack in httprpc/!
11:27 < gmaxwell> thats what it appears to be reporting!
11:27 < wumpus> where?
11:27 < sipa> i don't see it!
11:27 < wumpus> didn't even know that was possible in c++
11:27 < sipa> it is
11:28 < gmaxwell> well C++11 IIRC added optional VLA.
11:28 < gmaxwell> this is what it reports: 
11:28 < gmaxwell>  static bool HTTPReq_JSONRPC(HTTPRequest* req, const std::string &)
11:28 < gmaxwell>              ^~~~~~~~~~~~~~~
11:28 < gmaxwell> which made no sense to me but I figured there was some kind of over-my-head c++ magic happening.
11:28 < luke-jr> I get them with 4.9.4
11:29 < wumpus> I'm fairly sure I didn't *intend* that when writing that code at least
11:29 < wumpus> so I'm curious
11:29 < gmaxwell> I agree the test isn't so important, but the users compiling seeing warnings isn't ideal. Certantly lower priority.
11:29 < wumpus> I also think it's strange it comes up now
11:29 < sipa> i've seen that warning for months, at least
11:29 < wumpus> shouldn't that warning have been there for ages?
11:30 < gmaxwell> it's been there for a while but I ignore warnings in master because they're usually eliminated before release, didn't realize that most other people weren't seeing it.
11:30 < wumpus> oh and you just mention it now just before a release, ok :/
11:30 < gmaxwell> Actually I have mentioned it once before.
11:30 < gmaxwell> but I thought everyone else was seeing it too.
11:31 -!- mrkent [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev     
11:31 < gmaxwell> Sorry.
11:31 < sipa> building from scratch with 6.2.0 now, i'll report the warnings i get
11:31 < sipa> /usr/bin/ar: `u' modifier ignored since `D' is the default (see `U')
11:31 < wumpus> I don't think it's a big deal but I want to know what is causing a variable sized buffer there
11:31 < sipa> httprpc.cpp: In function ‘bool HTTPReq_JSONRPC(HTTPRequest*, const string&)’:
11:31 < sipa> httprpc.cpp:150:13: warning: stack protector not protecting local variables: variable length buffer [-Wstack-protector]
11:31 < sipa>  static bool HTTPReq_JSONRPC(HTTPRequest* req, const std::string &)
11:31 < sipa>              ^~~~~~~~~~~~~~~
11:31 < wumpus> variable-sized buffers on the stack are usually a code stink
11:32 < wumpus> honestly I thought the practice died in the 90's
11:32 < sipa> (several more 'u' modifier warnings)
11:32 < jonasschnelli> I think we should mention the AES change there...
11:32 < jonasschnelli> (in the release notes)
11:32 < wumpus> yes the modfifier warnings are well-known, there's an issue open for those IIRC
11:32 < gmaxwell> jonasschnelli: what aes change?
11:33 < jonasschnelli> Sorry,.. I hadn't scrolled down...
11:33 < gmaxwell> :P     
11:33 < sipa> jonasschnelli, wumpus, gmaxwell: how about we first move all the AES mode of operation code into ctaes (it's currently in crypto/aes.cpp), and then write a blog post about ctaes in general
11:33 < jonasschnelli> I just saw a discussion about ctaes
11:33 < sipa> /usr/include/boost/type_traits/detail/bool_trait_def.hpp:18:78: note: #pragma message: NOTE: Use of this header (bool_trait_def.hpp) is deprecated
11:33 < sipa>  # pragma message("NOTE: Use of this header (bool_trait_def.hpp) is deprecated")
11:33 < sipa> leveldb/db/memtable.cc: In member function ‘void leveldb::MemTable::Add(leveldb::SequenceNumber, leveldb::ValueType, const leveldb::Slice&, const leveldb::Slice&)’:
11:33 < sipa> leveldb/db/memtable.cc:104:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
11:34 < sipa>    assert((p + val_size) - buf == encoded_len);
11:34 < wumpus> yes, there are a few warnings in boost, those depend on the boost version
11:34 < wumpus> there's also warnings in leveldb those need to be fixed upstream
11:34 < cfields> heh, i have a fix for the deprecated boost thing. Will PR in a few min.
11:34 < cfields> sipa: i did a cbc ctaes over the weekend, just need to get it cleaned up
11:34 < wumpus> sipa: sounds good to me
11:35 < cfields> sipa: out of curiosity, does the rpc warning go away if you make the function non-static ?
11:36 < gmaxwell> cfields: no.
11:36 < sipa> cfields: no
11:36 < cfields> ok, thanks
11:36 < gmaxwell> I am bisecting its code.
11:37 < jonasschnelli> Hmm.. I once extended ctaes to do cbc (if that is of interest)
11:37 < jonasschnelli> https://github.com/shiftdevices/libshiftdevices/blob/master/src/aes256_cbc.c
11:38 < sipa> hah     
11:38 < sipa> there are at least 3 people who have already done that it seems
11:38 < sipa> and nobody upstreamed it!
11:38 < cfields> heh     
11:39 < cfields> sipa: i didn't like the api i came up with, planned to revisit before upstreaming
11:39 < jonasschnelli> I wanted to upstream.
11:39 < wumpus> haha!
11:40 < sipa> i found the httprpc thing
11:40 < sipa> it's the out[KEY_SIZE] in multiuserauthorized
11:40 < gmaxwell> damn I type too slow.
11:40 < wumpus> KEY_SIZE is not a constant?
11:41 < sipa> marking it const fixes it
11:41 < wumpus> damn, good catch
11:41 < gmaxwell>             unsigned int KEY_SIZE = 32;
11:41 < gmaxwell>             unsigned char out[KEY_SIZE];
11:41 < wumpus> next time you see that warning please raise an alarm immediately
11:41 < gmaxwell> I wish the compiler had flags to disable language features.
11:42 < gmaxwell> I'll open an issue, I did mention it on IRC.
11:42 < gmaxwell> (if it happens again!)
11:42 < cfields> gmaxwell: -Wvla
11:42 < gmaxwell> oh, lol.
11:42 < cfields> i think that should catch it?
11:42 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
11:43 < cfields> specifically, -Werror=vla
11:43 < bitcoin-git> [bitcoin] sipa opened pull request #9785: Make KEY_SIZE a compile-time constant (master...constkeysize) https://github.com/bitcoin/bitcoin/pull/9785
11:43 < wumpus> cfields: let's do that
11:44 < wumpus> I'm not usually for disabling language features, but I can see no good coming out of this one
11:44 < cfields> wumpus: sounds good. There was another case like that a while back wrt hashing, I guess that was fixed at one point
11:44 < gmaxwell> that one seems safe but we should be very cautious about werror... compilers change warning detection all the time and then crap won't compile for users.
11:44 < cfields> sipa / gmaxwell: can you comment on whether -Werror=vla blows up on the old code?
11:44 < sipa> cfields: let's check
11:44 < wumpus> especially if it silently makes functions vulnerable by disabling the stack cookie
11:45 < wumpus> gmaxwell: agreed, Werror certainly shouldn't be enabled generally
11:45 < cfields> gmaxwell: Werror= allows you to only error on specific warnings
11:45 < gmaxwell> VLAs aren't so bad... they have good uses, but I agree we shouldn't have them in our codebase.
11:45 < gmaxwell> cfields: yes but many warnings change their behavior. As I said, vla sounds safe.
11:45 < gmaxwell> but many other warnings change their specific triggers from version to version.
11:46 < wumpus> this one is specific enough
11:46 < sipa> $ ./configure --with-incompatible-bdb --without-gui CXXFLAGS="-Wall -Wpedantic -Werror=vla -g3 -O2"
11:46 < sipa> ok, i do not want -Wpedantic
11:47 < gmaxwell> httprpc.cpp: In function ‘bool multiUserAuthorized(std::__cxx11::string)’:
11:47 < gmaxwell> httprpc.cpp:116:39: error: variable length array ‘out’ is used [-Werror=vla]
11:47 < gmaxwell>              unsigned char out[KEY_SIZE];
11:47 < gmaxwell>                                        ^
11:47 < cfields> I remember this one getting snagged as a vla at one point: https://github.com/bitcoin/bitcoin/blob/master/src/hash.h#L30
11:47 < cfields> i think that may be up to the compiler.
11:48 < gmaxwell> qt/test/paymentservertests.cpp: In member function ‘void PaymentServerTests::paymentServerTests()’:
11:48 < gmaxwell> qt/test/paymentservertests.cpp:181:61: error: variable length array ‘randData’ is used [-Werror=vla]
11:48 < cfields> er sorry, 2 lines up
11:48 < gmaxwell>      unsigned char randData[BIP70_MAX_PAYMENTREQUEST_SIZE + 1];
11:48 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Quit: WeeChat 0.4.2]     
11:48 < gmaxwell>                                                              ^
11:49 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev     
11:49 < gmaxwell> with those two things fixed it compiles cleanly with that Werror=vla.
11:51 < wumpus> would be good to include the paymentrequest change in https://github.com/bitcoin/bitcoin/pull/9785 too
11:51 < cfields> yes, clang still dislikes the one in hash.h
11:53 < wumpus> hm, a static field that is addressed as a non-static field
11:54 < wumpus> if you make that CSHA256::OUTPUT_SIZE I'm fairly sure the warning goes away?
11:54 < cfields> wumpus: yep
11:55 -!- mrkent [~textual@unaffiliated/mrkent] has quit []     
11:55 < sipa> what if you make it just OUTPUT_SIZE ?
11:56 < cfields> sipa: works for one, breaks for ripemd
11:56 < cfields> pr coming up
11:56 < sipa> already on it
11:56 < cfields> race!
11:56 < wumpus> if you make it just OUTPUT_SIZE the meaning changes
11:57 < sipa> indeed
11:57 < wumpus> though if the numbers are the same anyway it doesn't matter
11:57 < sipa> it needs to be CSHA256::OUTPUT_SIZE
11:58 < cfields> http://pastebin.com/raw/u5uG8PbE
11:58 < cfields> no?     
12:00 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
12:00 < sipa> my battery just died
12:01 < btcdrak> RIP     
12:01 < sipa> the PR also has the paymentprotocol change, but I didn't tedt
12:01 < sipa> *test
12:01 < cfields> 0.14: destroyer of PSUs and batteries
12:01 < sipa> s/died/ran out/
12:04 < achow101> When did 0.14 destroy a PSU?
12:05 < bitcoin-git> [bitcoin] theuni opened pull request #9786: boost: remove iostreams includes (master...no-iostreams) https://github.com/bitcoin/bitcoin/pull/9786
12:05 < wumpus> achow101: mine, earlier today
12:06 < wumpus> while building w/ gitian, not while running it, mind you
12:07 < cfields> ^^ should get rid of the "NOTE: Use of this header (bool_trait_def.hpp) is deprecated")"
12:08 < achow101> wumpus: lol
12:14 -!- Kexkey [~kexkey@23.227.207.22] has joined #bitcoin-core-dev     
12:26 -!- asoltys [~adam@115.96.198.104.bc.googleusercontent.com] has joined #bitcoin-core-dev     
12:26 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 240 seconds]     
12:34 < achow101> is the tag still happening today?
12:37 < cfields> wumpus: would you like release notes additions PR'd directly to 0.14, i assume?
12:41 < wumpus> achow101: yes, in a minute
12:41 < luke-jr> "Out-of-sync Modal Info Layer" looks like something that can be removed from release notes to trim it down
12:41 < wumpus> cfields: yes, editing the wiki has little sense now, we should probaly add a warning there
12:41 < cfields> ok     
12:44 < luke-jr> " - After resetting the options by clicking the `Reset Options` button in the options dialog or with the `-resetguioptions` startup option, the user will be prompted to choose the data directory again. This  is to ensure that custom data directories will be kept after the  option reset which clears the custom data directory set via the choose  datadir dialog."
12:44 < luke-jr> ^ where did this change happen? I don't see any code for this behaviour
12:45 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/618709141147f74771da0795cf0dccb47c606d24
12:45 < bitcoin-git> bitcoin/0.14 6187091 Wladimir J. van der Laan: doc: Add changelog for 0.14.0 to release notes
12:45 < wumpus> going to pull in the warning changes and then tag
12:46 < bitcoin-git> [bitcoin] theuni opened pull request #9787: [WIP] release: add a few performance-related notes (0.14...update-release-notes) https://github.com/bitcoin/bitcoin/pull/9787
12:46 < cfields> ^^ just intended to be a starting point
12:47 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to 0.14: https://github.com/bitcoin/bitcoin/compare/618709141147...04396bcc058e
12:47 < bitcoin-git> bitcoin/0.14 1577f07 Gregory Maxwell: Restore removed release notes.
12:47 < bitcoin-git> bitcoin/0.14 04396bc Wladimir J. van der Laan: Merge #9784: Restore removed release notes....
12:47 < cfields> sipa: are you PRing the hash changes? Or did those die with your battery?
12:48 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/f87e8f53920a...df42bcdbfebe
12:48 < bitcoin-git> bitcoin/master 914fad1 Pieter Wuille: Make KEY_SIZE a compile-time constant
12:48 < bitcoin-git> bitcoin/master c801c82 Pieter Wuille: Move BIP70_MAX_PAYMENTREQUEST_SIZE to header
12:48 < bitcoin-git> bitcoin/master df42bcd Wladimir J. van der Laan: Merge #9785: Avoid variable length arrays...
12:48 < bitcoin-git> [bitcoin] laanwj closed pull request #9785: Avoid variable length arrays (master...constkeysize) https://github.com/bitcoin/bitcoin/pull/9785
12:48 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/df42bcdbfebe...12f46fa7d87d
12:48 < bitcoin-git> bitcoin/master 3301587 Cory Fields: boost: remove iostreams includes...
12:48 < bitcoin-git> bitcoin/master 12f46fa Wladimir J. van der Laan: Merge #9786: boost: remove iostreams includes...
12:49 < bitcoin-git> [bitcoin] laanwj closed pull request #9786: boost: remove iostreams includes (master...no-iostreams) https://github.com/bitcoin/bitcoin/pull/9786
12:51 < sipa> cfields: oops, right, will do
12:51 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to 0.14: https://github.com/bitcoin/bitcoin/compare/04396bcc058e...2afefeade6e6
12:51 < bitcoin-git> bitcoin/0.14 f873564 Pieter Wuille: Make KEY_SIZE a compile-time constant...
12:51 < bitcoin-git> bitcoin/0.14 973e345 Pieter Wuille: Move BIP70_MAX_PAYMENTREQUEST_SIZE to header...
12:51 < bitcoin-git> bitcoin/0.14 2afefea Cory Fields: boost: remove iostreams includes...
12:54 < wumpus> luke-jr: was that message added at the same time as the change, or later?
12:55 < wumpus> luke-jr: seems to be #8487
12:55 < gribble> https://github.com/bitcoin/bitcoin/issues/8487 | Persist the datadir after option reset by achow101 · Pull Request #8487 · bitcoin/bitcoin · GitHub
12:55 < luke-jr> but that's the opposite?
12:56 < wumpus> I'm not aware of any other changes there (and log -p confirms this)
12:56 < luke-jr> oh, does it preserve *and* reprompt? :o
12:58 < wumpus> anyhow, time to tag
12:59 < sipa> ack tag
12:59 < jonasschnelli> \O/     
12:59 < wumpus>  * [new tag]         v0.14.0rc1 -> v0.14.0rc1
13:00 < sipa> \o/ \\o o//
13:01 < wumpus> \\o//
13:01 < cfields> woohoo!
13:01 < sipa> you have 4 arms? that explains!
13:01 < wumpus> if only :)
13:02 < gmaxwell> that symbol is a tutrle on its back.
13:02 < wumpus> gitian will probably have to rebuild all dependencies as the gitian-depends version was bumped
13:02 < gmaxwell> flip him over!
13:03 < jonasschnelli> heh     
13:03 < achow101> \o/     
13:03 < wumpus> cfields: we should not forget to bump the depends version to 0.15 on master as soon as possible so that we don't have this problem next time
13:04 < cfields> wumpus: indeed. I'm cheating and symlinking for now.
13:04 < cfields> will PR that in just a min.
13:04 < wumpus> yeah I thought about that too, but I'm not doing that, want to be sure to get the right output
13:05 < wumpus> I'd be the person to symlink the wrong directory then get a wrong executable, spend hours debugging that, and lose a lot of time compared to... simply rebuilding everything :p
13:05 < achow101> luke-jr: it preserves and reprompts the datadir
13:05 < jonasschnelli> Can you just gpg sign the gitian assets file on a different machine? No need for the descriptor, right?
13:06 < wumpus> jonasschnelli: yes, see "signing externally" in gitian-building.md
13:07 < jonasschnelli> wumpus: Thanks... great.. wasn't aware of that doc part
13:08 < instagibbs> nice work :)
13:08 < wumpus> you can also pass -p true to gsign to make it skip the call to gpg complately 
13:09 < wumpus> but it doesn't matter whether you do that or let the gpg call fail, it's the last statement in gsign, in both cases you can copy the unsigned assert file and detach-sign it yourself
13:10 < bitcoin-git> [bitcoin] theuni opened pull request #9788: gitian: bump descriptors for master (master...gitian-bump-0.15) https://github.com/bitcoin/bitcoin/pull/9788
13:13  * gmaxwell sets the timer for the premature reddit release announcement. :P
13:14 < wumpus> reddit, what's that :)
13:14 -!- Sosumi [~Leon@bl10-113-190.dsl.telepac.pt] has quit [Quit: Bye]     
13:20 < instagibbs> having issues with configure on rc1:
13:20 < instagibbs> x86_64-pc-linux-gnu
13:20 < instagibbs> checking build system type... x86_64-pc-linux-gnu
13:20 < instagibbs> checking host system type... x86_64-pc-linux-gnu
13:20 < instagibbs> ./configure: line 2455: syntax error near unexpected token `no-define'
13:20 < instagibbs> ./configure: line 2455: `AM_INIT_AUTOMAKE(no-define subdir-objects foreign)'
13:21 < wumpus> instagibbs: see #bitcoin
13:21 < achow101> works fine for me
13:21 < instagibbs> wumpus, not unless it recently was removed, it's on a dev machine :P
13:21 < wumpus> no need to cross-post 
13:22 < instagibbs> eh, I tried asking, got nothing, then came here
13:22 < instagibbs> sorry
13:28 < bitcoin-git> [bitcoin] theuni opened pull request #9789: build: disallow variable length arrays (master...no-vla) https://github.com/bitcoin/bitcoin/pull/9789
13:38 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev     
13:38 < cfields> gmaxwell: i wonder if that vla was throwing off your sanitizer. didn't you have something reported from rpc code?
13:42 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Ping timeout: 260 seconds]     
13:47 < sipa> i'm running master as of a few hours ago, plus my sanitize fixes, on bitcoin.sipa.be, with tsan and ubsan enabled
13:53 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt]     
14:05 < cfields> sipa: ah, nice
14:09 < gmaxwell> cfields: I don't know why it would.
14:12 -!- e4xit [~textual@cpc1-cmbg20-2-0-cust188.5-4.cable.virginm.net] has quit [Ping timeout: 252 seconds]     
14:15 -!- bsm117532 [~mcelrath@38.121.165.30] has quit [Ping timeout: 264 seconds]     
14:34 -!- aalex [~aalex@64.187.177.58] has quit [Ping timeout: 255 seconds]     
14:40 < bitcoin-git> [bitcoin] luke-jr opened pull request #9790: doc/release-notes: Various cleanups (0.14...0.14-relnotes) https://github.com/bitcoin/bitcoin/pull/9790
14:43 -!- face [~face@mail.hmel.org] has quit [Ping timeout: 255 seconds]     
14:48 -!- face [~face@mail.hmel.org] has joined #bitcoin-core-dev     
14:51 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Ping timeout: 240 seconds]     
14:52 < achow101> first!
14:56 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev     
15:05 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev     
15:27 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-ssgxrczwxchhoiex] has quit [Quit: Connection closed for inactivity]     
15:29 < bitcoin-git> [bitcoin] sipa opened pull request #9791: Avoid VLA in hash.h (master...novla) https://github.com/bitcoin/bitcoin/pull/9791
15:34 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection]     
15:36 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev     
15:37 < gmaxwell> the CLANG vs GCC  VLA warning on hash.h is an example of why we should -Wvla but not error on it.
15:37 < sipa> gmaxwell: from investigating briefly, it seems that VLAs are standard in C99 but optional in C11. They're not specified in C++ or C++11.
15:40 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds]     
15:42 < gmaxwell> Apparently their analog is in C++14, std::dynarray and "runtime sized arrays" (exactly the same syntax as VLA but: sizeof works, and they can't be multidimensional)
15:43 < luke-jr> eh? sizeof works with C99 VLAs..
15:43 < luke-jr> or is that a GNU extension?
15:45 < gmaxwell> luke-jr: sorry, I wasn't clear, I was saying that it does not work in the C++14 spec.
15:45 < luke-jr> oh     
15:46  * luke-jr wonders if we should remove "About Qt" from the menu. It seems (without knowing the languages) translators are interpreting "Qt" as "Bitcoin-Qt"
15:47 -!- JackH [~laptop@79-73-188-131.dynamic.dsl.as9105.com] has quit [Remote host closed the connection]     
15:47 < sipa> luke-jr: i've noticed that too
15:48 < sipa> in past times, it seems "Qt" was even understood to refer to the bitcoin core program name
15:48 < gmaxwell> it's kind of confusing in any case. like... "information no one ever wants"
15:48 < luke-jr> other Qt apps used to have it, but I don't think many (if any) do anymore
15:49 < luke-jr> in KDE apps, it's just "About <app>" and "About KDE"
15:52 < achow101> I thought it was required as part of the license that Qt uses
15:52 < achow101> (that might be wrong info)
15:53 < gmaxwell> nope.
16:02 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 260 seconds]     
16:16 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev     
16:17 < luke-jr> "Syncing Headers (%1%)…" <-- is this valid?
16:21 -!- norotartagen [~norotarta@71-89-76-184.dhcp.bycy.mi.charter.com] has quit [Quit: Leaving]     
16:21 -!- norotartagen [~norotarta@71-89-76-184.dhcp.bycy.mi.charter.com] has joined #bitcoin-core-dev     
16:36 < luke-jr> wumpus: is update-translations.py not giving you an assert in check_format_specifiers for zh_TW?
16:37 < cfields> achow101: we've got a mismatch on osx. rebuilding mine.
16:40 < achow101> cfields: ok. I'll run it again too. Are we still using the osx 10.11 sdk?
16:41 < cfields> achow101: yes. I suspect that we probably have different versions of the sdk.
16:42 < achow101> I've been using the same version of the sdk for a long time now
16:43 < cfields> achow101: ah, I was thinking it was bumped from 0.13, but it's not.
16:43 < achow101> so I don't need to re-run?
16:44 < cfields> achow101: let's both re-run and see what happens
16:44 < achow101> alright
16:44 < cfields> (unless it's inconvenient for you)
16:45 < achow101> no, it's fine, I can re-run it
16:55 < achow101> cfields: I got the same results
16:56 -!- goksinen [~goksinen@2604:2000:c591:8400:55fd:582a:f3f3:a276] has joined #bitcoin-core-dev     
16:57 < cfields> achow101: me too :(
16:57 < achow101> uh oh
16:57 < cfields> we need a 3rd builder...
16:58 < cfields> achow101: can you drop your bitcoin-0.14.0-osx64.tar.gz somewhere?
16:58 < achow101> sure
16:58 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com]     
17:00 < achow101> https://drive.google.com/file/d/0Bxw3ip9QfNOUeVFSa0dyWTdHckU/view?usp=sharing
17:01 -!- goksinen [~goksinen@2604:2000:c591:8400:55fd:582a:f3f3:a276] has quit [Ping timeout: 240 seconds]     
17:01 -!- wallet42 [sid154231@gateway/web/irccloud.com/x-qwapzjhapzxyluqy] has quit [Quit: Connection closed for inactivity]     
17:02 < cfields> thank
17:02 < cfields> s     
17:06 < cfields> achow101: http://pastebin.com/raw/ZTA5Hahi
17:06 < cfields> looks like there may be non-determinism there
17:08 < achow101> maybe it's caches?
17:10 < cfields> we both had empty caches this time
17:10 < cfields> Binary files bitcoin-0.14.0-me/bin/bitcoin-qt and bitcoin-0.14.0-achow/bin/bitcoin-qt differ
17:11 < cfields> will see if i can track it down. maybe something new in qt 5.7
17:20 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/12f46fa7d87d...50a226563cd8
17:20 < bitcoin-git> bitcoin/master 8e5cca0 Cory Fields: gitian: bump descriptors for master...
17:20 < bitcoin-git> bitcoin/master 50a2265 MarcoFalke: Merge #9788: gitian: bump descriptors for master...
17:20 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #9788: gitian: bump descriptors for master (master...gitian-bump-0.15) https://github.com/bitcoin/bitcoin/pull/9788
17:34 < cfields> achow101: can you: find MacOSX10.11.sdk/ -type f -exec sha256sum {} >> sdk.sha256 \;
17:34 < cfields> in particular, i think we might have differing libobjc.A.tbd 
17:36 < achow101> where should this file/folder be?
17:37 < cfields> achow101: don't worry about it, i'll just grab a fresh sdk and rule it out
17:37 < achow101> found it (i've never extracted the sdk tar before)
17:37 < luke-jr> isn't the SDK always different?
17:38 < luke-jr> I guess that's probably just the tar format
17:38 < achow101> this is the hash for libobjc.A.tbd: ef9438dc380ce92cf82538ef483fdbf96743b5f8907c752def4a6d922f822ec6
17:39 < cfields> achow101: damn, same
17:40 < cfields> luke-jr: yea, contents should be the same
17:41 < achow101> cfields: here's the link to the entire sdk.sha256 file: https://drive.google.com/file/d/0Bxw3ip9QfNOUWWtNb2Z6VC1hRXc/view?usp=sharing
17:46 < cfields> achow101: hmm, they match up
17:46 < cfields> ok, time to dig into hex/disasm
17:51 -!- mrkent [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev     
17:52 -!- frstTimer [~1stTimer@47.204.15.213] has joined #bitcoin-core-dev     
18:07 -!- mrkent [~textual@unaffiliated/mrkent] has quit [Remote host closed the connection]     
18:09 -!- mrkent [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev     
18:09 -!- mrkent [~textual@unaffiliated/mrkent] has quit [Client Quit]     
18:11 -!- mrkent [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev     
18:13 < sipa> cfields: are there any locks protecting CAddrDB and CBanDB?
18:13 < sipa> DumpBanList or any of its callees never grab any locks
18:14 < sipa> ah, but it writes a copy
18:14 < cfields> sipa: it's only grabbed in Start() iirc
18:16 < sipa> less sure about DumpAddresses
18:16 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has quit [Quit: MarcoFalke]     
18:16 -!- mrkent [~textual@unaffiliated/mrkent] has quit [Client Quit]     
18:17 < sipa> ah, but addrman has its own lock
18:29 -!- frstTimer [~1stTimer@47.204.15.213] has quit []     
18:33 -!- mrkent [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev     
18:33 -!- mrkent [~textual@unaffiliated/mrkent] has quit [Client Quit]     
18:35 < achow101> cfields: any luck?
18:36 < cfields> achow101: not yet
19:06 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-pnwdnowetpxghoev] has joined #bitcoin-core-dev     
19:08 -!- mrkent_ [~textual@unaffiliated/mrkent] has joined #bitcoin-core-dev     
19:08 -!- mrkent_ [~textual@unaffiliated/mrkent] has quit [Client Quit]     
19:09 < bitcoin-git> [bitcoin] sipa opened pull request #9792: FastRandomContext improvements and switch to ChaCha20 (master...chacha) https://github.com/bitcoin/bitcoin/pull/9792
19:19 -!- jtimon [~quassel@245.30.134.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds]     
19:26 -!- arowser [~quassel@106.120.101.38] has quit [Quit: No Ping reply in 180 seconds.]     
19:28 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev     
19:29 -!- goksinen [~goksinen@2604:2000:c591:8400:55fd:582a:f3f3:a276] has joined #bitcoin-core-dev     
19:34 -!- goksinen [~goksinen@2604:2000:c591:8400:55fd:582a:f3f3:a276] has quit [Ping timeout: 240 seconds]     
19:37 < cfields> achow101: any chance you could grab the .o files from your gitian environment?
19:38 < gmaxwell> sipa: re random, seeding is a lot more of an interesting issue... that patch feels like sideways motion to me. sounds fine and all but doesn't obviously get rid of openssl.
19:42 < sipa> gmaxwell: sure... 1) make fastrandomcontext stronger 2) move some uses that now use getrandbytes to fastrandomcontexts 3) move everything else to a single secure RNG 4) make that single secure RNG not be OpenSSL
19:43 < sipa> when every use of the strong RNG reads from /dev/urandom etc, i feel we can avoid a lot of the complexity in it (gathering entropy etc)
19:44 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-khwwrgxnmwawglkj] has quit [Quit: Connection closed for inactivity]     
19:44 < sipa> s/gathering/background/
19:47 < achow101> cfields: I don't think so
19:47 < cfields> achow101: ok
19:51 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
19:54 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 260 seconds]     
19:55 < gmaxwell> Making fastrandomcontext robust agaist VM restore, forward/backward prediction will make it slow.
19:55 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has quit [Quit: Leaving]     
19:56 < sipa> gmaxwell: don't use fastrandomcontext in places where it needs to be robust
19:57 < sipa> we don't need VM robustness for determining the filename we temporarily write the addrman db to
19:57 < sipa> (which currently uses GetRandBytes)
20:00 < gmaxwell> We don't, I agree. But review what you just said above!
20:00 < sipa> 2) move *some* uses that now use getrandbytes to fastrandomcontexts
20:03 < gmaxwell> okay I looked through the usage of GetRand* and I'm less skeptical.
20:03 < gmaxwell> The ones where we need better properties we can use something fantastically slow.
20:05 < sipa> right, anything that constructs an actual secret key usually just runs once during the whole application (cache blinding keys, wallet keys, ...)
20:05 < sipa> for ping nonces i don't think that VM restores are that much of a deal
20:26 < cfields> sigh, best i can tell the linker is reordering some symbols
20:26 < cfields> don't know how we could be running into that now and not before, though
20:32 < achow101> it would be great if someone else could also do a gitian build :/
20:33 < cfields> yea :(
20:33 < cfields> I'm going to have to throw in the towel for tonight. I'll pick it up again tomorrow. Will be much easier with a third data point.
20:35 -!- chris200_ [~chris2000@p5DCB5C30.dip0.t-ipconnect.de] has joined #bitcoin-core-dev     
20:38 -!- chris2000 [~chris2000@p5082AAC3.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]     
20:44 -!- goksinen [~goksinen@2604:2000:c591:8400:e5ed:6cd3:eca6:2b04] has joined #bitcoin-core-dev     
20:47 -!- dodomojo [~goksinen@2604:2000:c591:8400:cc67:d387:afa4:b714] has joined #bitcoin-core-dev     
20:48 -!- goksinen_ [~goksinen@2604:2000:c591:8400:6172:9329:30ab:cf32] has joined #bitcoin-core-dev     
20:50 -!- goksinen [~goksinen@2604:2000:c591:8400:e5ed:6cd3:eca6:2b04] has quit [Ping timeout: 240 seconds]     
20:51 < bitcoin-git> [bitcoin] kobake opened pull request #9793: Vs2015 wip (master...vs2015-wip) https://github.com/bitcoin/bitcoin/pull/9793
20:52 -!- dodomojo [~goksinen@2604:2000:c591:8400:cc67:d387:afa4:b714] has quit [Ping timeout: 240 seconds]     
21:03 < bitcoin-git> [bitcoin] kobake closed pull request #9793: Vs2015 wip (master...vs2015-wip) https://github.com/bitcoin/bitcoin/pull/9793
21:13 < luke-jr> achow101: pushed my sigs
21:14 < luke-jr> which match cfields's
21:14 < achow101> :(     
21:14 < cfields> woohoo!
21:15 < achow101> nuked cache and input (except for sdk). trying again
21:16 < cfields> achow101: double-check your sdk? The only thing I can come up with other than ld64 constructing the indirect symbol table in a non-deterministic order, is that your sdk has a different stub which leads to a different layout
21:16 < luke-jr> my guess would be something with his VM
21:16 < cfields> luke-jr: thanks, btw
21:16 < luke-jr> np, sorry I'm late
21:17 < cfields> luke-jr: i'm not sure what could matter, other than filesystem or locale
21:17 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev     
21:17 < achow101> how do I check the sdk? I don't really have a way to get another one
21:17 < cfields> but i'd think those would cause many issues, not just these
21:17 < achow101> (short of someone sending me one)
21:17 < cfields> achow101: the dump you gave me matches mine. Just make sure that's really the one you're using
21:17 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-pnwdnowetpxghoev] has quit [Quit: Connection closed for inactivity]     
21:18 < cfields> achow101: lxc or kvm?
21:18 < achow101> kvm     
21:18 < cfields> ok     
21:18  * luke-jr is also KVM
21:18 < cfields> yes, same
21:18 -!- goksinen [~goksinen@2604:2000:c591:8400:55fd:582a:f3f3:a276] has joined #bitcoin-core-dev     
21:18 < achow101> lxc stopped working for me a long time ago. I still have an issue open somewhere about it
21:20 < achow101> the sdk is definitely the same. my original and the one in inputs have the same sha256sum
21:20 < fanquake> achow101 can you post the sha here?
21:20 < achow101> 9f950cd715b58b0ae002ec47bf2fe7ed76857d4f7b0b3520ae2820082b3e41ce
21:22 < fanquake> That's the sha256 of MacOSX10.11.sdk.tar.gz ?
21:22 < achow101> yep     
21:22 < fanquake> Weirdly mine does not match.
21:22 -!- goksinen [~goksinen@2604:2000:c591:8400:55fd:582a:f3f3:a276] has quit [Ping timeout: 240 seconds]     
21:22 < achow101> should it?
21:22 < fanquake> I see 57a69e69bec23aa190b9ca50726df1ca8bc3d68d70094868211dcbeeb477db91
21:23 < fanquake> I'll wait until my builds done. Should only be a few more minutes.
21:27 -!- aburan [~root@2602:304:ce71:a8f0:95c7:dcb1:104f:7b53] has joined #bitcoin-core-dev     
21:28 < luke-jr> fanquake: it doesn't normally match
21:28 < luke-jr> MacOSX10.11.sdk.tar.gz is not itself typically deterministic because we make it on our own
21:29 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-zrnathibqltmcxpf] has joined #bitcoin-core-dev     
21:29 -!- aburan [~root@2602:304:ce71:a8f0:95c7:dcb1:104f:7b53] has quit [Read error: Connection reset by peer]     
21:29 -!- aburan_ [~root@2602:304:ce71:a8f0:95c7:dcb1:104f:7b53] has joined #bitcoin-core-dev     
21:33 < achow101> build finished, got the exact same results
21:34 -!- chjj [~chjj@unaffiliated/chjj] has quit [Remote host closed the connection]     
21:40 < achow101> fanquake: your build done yet?
21:41 < fanquake> achow101 yep, one sec.
21:42 < fanquake> achow101 heh my osx sigs match yours.
21:42 < fanquake> 8c42c1f996935fc0f2a13616d8b0f557594b23588e7781f72c9ebe53ef097cbd  bitcoin-0.14.0-osx-unsigned.dmg
21:42 < achow101> well shit
21:44 -!- goksinen_ [~goksinen@2604:2000:c591:8400:6172:9329:30ab:cf32] has quit [Remote host closed the connection]     
21:45 < luke-jr> O.o     
21:45 < luke-jr> timezone?
21:46 < achow101> how would that matter?
21:46 < luke-jr> dunno, just guessing cfields and I are probably in the same one and you two might not be
21:47 < achow101> could the version of gitian matter?
21:48 < fanquake> Just PR'd my sigs, if you want to take look.
21:48 < fanquake> Not sure about timezone. I'm using latest gitian.
21:49 < achow101> I think I'm using the latest. hash: ad3f9cc4c2c8c0899961a366f5b9fbd1483b0ee3
21:49 < fanquake> Building with VirtualBox on OS X. Basically using the build-guide in doc.
21:49 < fanquake> Yep, same. "Merge #135: Fixes Debian jessie lxc-init path issue".
21:49 < gribble> https://github.com/bitcoin/bitcoin/issues/135 | [mac os x] Crash on exit · Issue #135 · bitcoin/bitcoin · GitHub
21:50 -!- myyao__ [~myyao@219.135.155.120] has joined #bitcoin-core-dev     
21:53 < luke-jr> I'm on ee1b69d Merge #122: Allow build to use sudo without a password, part deux
21:53 < gribble> https://github.com/bitcoin/bitcoin/issues/122 | Spent per txout by sipa · Pull Request #122 · bitcoin/bitcoin · GitHub
21:54 < achow101> oh well. I'm going to sleep now
21:59 < luke-jr> night
22:04 -!- dermoth [~thomas@dsl-216-221-51-3.mtl.aei.ca] has quit [Ping timeout: 268 seconds]     
22:08 -!- dermoth [~thomas@dsl-216-221-33-213.mtl.aei.ca] has joined #bitcoin-core-dev     
22:12 -!- goksinen [~goksinen@2604:2000:c591:8400:55fd:582a:f3f3:a276] has joined #bitcoin-core-dev     
22:16 -!- goksinen [~goksinen@2604:2000:c591:8400:55fd:582a:f3f3:a276] has quit [Ping timeout: 240 seconds]     
22:25 -!- cannon-c [ccc23f04@gateway/web/freenode/ip.204.194.63.4] has joined #bitcoin-core-dev     
22:28 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev     
22:33 -!- dermoth [~thomas@dsl-216-221-33-213.mtl.aei.ca] has quit [Ping timeout: 260 seconds]     
22:34 -!- dermoth [~thomas@dsl-216-221-55-141.mtl.contact.net] has joined #bitcoin-core-dev     
22:36 -!- Ginnarr [~Ginnarr@unaffiliated/ginnarr] has joined #bitcoin-core-dev     
22:45 -!- juscamarena_ [~justin@47.148.176.74] has quit [Ping timeout: 264 seconds]     
22:51 -!- Ginnarr [~Ginnarr@unaffiliated/ginnarr] has quit [Quit: Textual IRC Client: www.textualapp.com]     
23:03 -!- aalex [~aalex@64.187.177.58] has quit [Ping timeout: 240 seconds]     
23:06 -!- goksinen [~goksinen@2604:2000:c591:8400:55fd:582a:f3f3:a276] has joined #bitcoin-core-dev     
23:11 -!- goksinen [~goksinen@2604:2000:c591:8400:55fd:582a:f3f3:a276] has quit [Ping timeout: 240 seconds]     
23:12 -!- juscamarena [~justin@47.148.176.74] has joined #bitcoin-core-dev     
23:28 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Ping timeout: 260 seconds]     
23:40 -!- Victor_sueca is now known as Victorsueca     
23:43 < bitcoin-git> [bitcoin] mitchellcash opened pull request #9794: Minor update to qrencode package builder (master...minor_depends_fix) https://github.com/bitcoin/bitcoin/pull/9794