--- Day changed Tue Feb 21 2017
00:05 -!- harrymm [~wayne@104.222.140.17] has quit [Ping timeout: 240 seconds]     
00:06 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
00:20 -!- harrymm [~wayne@104.222.140.14] has joined #bitcoin-core-dev     
00:38 < bitcoin-git> [bitcoin] benma opened pull request #9815: Trivial: use EXIT_ codes instead of magic numbers (master...exitcode) https://github.com/bitcoin/bitcoin/pull/9815
00:43 < gmaxwell> I vaguely recall from some other project that there was a reason to not do that ^. ... probably on obscure platforms we don't support.
00:44 < gmaxwell> hm. perhaps I remember incorrectly.
00:59 < jonasschnelli> Still having troubles setting up gitian LXC. The LXC container can't connect to the internet. I don't have a VM for gitian. I run gbuild directly on a host. The host has a single public IPv4 addr. I'm not sure how I can setup the bridging..
01:00 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving]     
01:03 < wumpus> gmaxwell: that's pretty late to start arguing against it we've already done it for 99% of the project
01:04 < wumpus> jonasschnelli: strange.
01:05 < wumpus> jonasschnelli: did you set the GITIAN_HOST_IP and LXC_GUEST_IP?
01:05 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev     
01:06 < wumpus> jonasschnelli: there's some setup here that you need https://github.com/bitcoin/bitcoin/blob/master/doc/gitian-building.md#setting-up-debian-for-gitian-building
01:06 < fanquake> wumpus I agree with your comments re gitian building and LXC. That is what I've always used, these problems are all that I've ever had with it. I think the gitian build guide also does a, lengthy, but good job of explaining setup.
01:07 < fanquake> That's using a debian & virtualbox on osx.
01:07 < wumpus> fanquake: thanks. we should just try to fix the guide, at least the parts people stumbling on. Writing another one for KVM, which proabably gets outdated just as quickly isn't much of a  solution.
01:08 < fanquake> cfields If I start a node with those params, and quit after some syncing I get a segfault :o Investigating now.
01:09 < wumpus> also I think LXC is conceptually the right solution for this problem - what you want for building is an isolated container, not a full emulated operating system
01:09 < fanquake> wumpus yea, the guide could probably use some improving. I've tried to keep it up to date every now and then. I though we also had a gitian-building script that was meant to automate some of the setting up?
01:10 < gmaxwell> wumpus: fair enough!
01:10 < wumpus> fanquake: I'm kind of disappointed that the person adding the gitian-building script didn't update the guide to use it
01:10 < wumpus> fanquake: that kind of guarantees no one will use his script
01:11 < fanquake> We also link to that Docker setup. I checked the other day and it hasn't been updated in > 1yr. Think we could probably drop that link from the guide.
01:11 < wumpus> gmaxwell: according to the manpage it's even more portable "The  use  of EXIT_SUCCESS and EXIT_FAILURE is slightly more portable (to non-UNIX environments) than the use of 0 and some nonzero value like 1 or -1.  In particular, VMS uses a different convention." VMS!
01:11 < luke-jr> wumpus: I think UML is a better solution :p
01:11 < wumpus> luke-jr: the 90's called and want UML back? :p
01:12 < gmaxwell> maybe thats what I'm remembering! :P
01:12 < luke-jr> ☺     
01:12 < wumpus> luke-jr: more seriously, I haven't heard of anyone using UML in 10 years or so
01:12 < jonasschnelli> wumpus: I have set GITIAN_HOST_IP and LXC_GUEST_IP to the same public ipv4 addr. I'm not aware of any other IP address that could be used?!
01:12 < jonasschnelli> There is no LAN in my case
01:12 < fanquake> Can anyone confirm this. src/qt/bitcoin-qt --reindex --dbacache=8192 --par=10 --blocksonly=1 --listen=0 --disablewallet=1 quiting after any amount of time gives a segfault.
01:12 < luke-jr> wumpus: I'm surprised you remembered it
01:13 < luke-jr> well, slightly.
01:13 < wumpus> luke-jr: I remember a lot of useless things
01:14 < wumpus> jonasschnelli:i: if you set them to the same IP it will fail. The point is that the host and guest communicate with each other on this bridge network
01:15 < jonasschnelli> Hmm.. maybe I use ifconfig br0 10.0.3.2/24 up for the bridge and set 10.0.3.5 as guest IP and my public ip as host... let me try
01:15 < wumpus> jonasschnelli: so the sequence there is : set up a br0 network, assign ourlelves an IP on it and bring it up, set up masquerading for the interface to the outside, set up forwarding, then tell gitian-builder these things by the way of environment variables
01:16 < wumpus> GITIAN_HOST_IP should be the IP we assign ourselves using ifconfig br0
01:16 < wumpus> LXC_GUEST_IP is the IP that the guest should have, and should be within this subnet
01:17 < fanquake> Ok, the problem is just with —disablewallet=1 , running with that and then quitting will segfault on master.
01:17 < jonasschnelli> Okay. Then GITIAN_HOST_IP=10.0.3.2 and LXC_GUEST_IP=10.0.3.5 should work... ok let me try. I think i also enabled Ipv4 forwarding
01:18 < jonasschnelli> fanquake: Thanks for the report. Is there already an issue on github for that?
01:18 < jonasschnelli> I can try to fix this
01:18 < fanquake> jonasschnelli checking, if not ill open with some details.
01:18 < jonasschnelli> Thanks!
01:18 < fanquake> Checking with 0.14.0rc1 that is.
01:19 < jonasschnelli> Oh. Now install.log reports successful apt installed... thanks wumpus!
01:19  * jonasschnelli think he should learn the basics of net bridging...
01:20 -!- Squidicc [~squid@pool-173-48-116-49.bstnma.fios.verizon.net] has joined #bitcoin-core-dev     
01:22 -!- squidicuz [~squid@pool-173-48-116-49.bstnma.fios.verizon.net] has quit [Ping timeout: 240 seconds]     
01:24 -!- Squidicuz [~squid@pool-173-48-116-49.bstnma.fios.verizon.net] has joined #bitcoin-core-dev     
01:24 < jonasschnelli> Hmm... now I see in build.log that Fetching ccache-3.3.3.tar.bz2 has stalled (no progress at all). I guess this means the target can't connect to the internet?
01:25 < fanquake> Don't you have to clone the repositories first?
01:25 -!- Squidicc [~squid@pool-173-48-116-49.bstnma.fios.verizon.net] has quit [Ping timeout: 240 seconds]     
01:30 < jonasschnelli> fanquake. I think the nat is not working correctly..
01:31 -!- harrymm [~wayne@104.222.140.14] has quit [Ping timeout: 255 seconds]     
01:37 -!- moli_ [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds]     
01:39 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
01:42 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev     
01:46 < jonasschnelli> Can I somehow start the LXC container manually and execute commands in the container? lxc-ls returns an empy list
01:46 -!- harrymm [~wayne@104.222.140.70] has joined #bitcoin-core-dev     
01:46 < luke-jr> lxc-execute? :p
01:47 < jonasschnelli> luke-jr: lxc-execute: missing container name? And lxc-ls doesn't show any container...
01:52 -!- harrymm [~wayne@104.222.140.70] has quit [Ping timeout: 240 seconds]     
01:59 < jonasschnelli> Found it out. LXC_ARCH=amd64 LXC_SUITE=trusty on-target -u root ping 8.8.8.8
02:06 -!- harrymm [~wayne@104.222.140.93] has joined #bitcoin-core-dev     
02:08 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #bitcoin-core-dev     
02:08 < jonasschnelli> Ping to the inet from within the lxc container now worked after re-setting up the bridge with 10.0.2.2 (instead of 10.0.3.2)
02:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
02:16 -!- aalex [~aalex@64.187.177.58] has quit [Ping timeout: 240 seconds]     
02:17 < jonasschnelli> hm... dns resolving does not work in the LXC container. That's the issue.
02:17 -!- _mn3monic [~guido@176.9.68.68] has quit [Ping timeout: 240 seconds]     
02:39 < jonasschnelli> Ah. I think there is a dnsmasq conflict with the bitcoin dns-seeder
02:46 -!- lclc_ [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev     
02:46 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 255 seconds]     
02:56 -!- undo12 [~vvvvv56@p200300455D1B2800B9BF0870E2D52B74.dip0.t-ipconnect.de] has joined #bitcoin-core-dev     
02:58 -!- undo12 [~vvvvv56@p200300455D1B2800B9BF0870E2D52B74.dip0.t-ipconnect.de] has left #bitcoin-core-dev []     
03:05 -!- lclc_ [~lclc@unaffiliated/lclc] has quit [Ping timeout: 260 seconds]     
03:06 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Quit: Leaving.]     
03:22 < wumpus> yes AFAIK it uses the host as DNS server
03:28 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 260 seconds]     
03:28 < wumpus> it should be possible to make the client use a different DNS server
03:29 < wumpus> though you could avoid this with https://github.com/bitcoin/bitcoin/blob/master/doc/gitian-building.md#building-fully-offline
03:34 < wumpus> in principle the guest doesn't need a network connection to anything but the host
03:34 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7639d38f14b1...7d46b3ea8d6c
03:34 < bitcoin-git> bitcoin/master 171fc91 Pavel Janík: Read/write mempool.dat as a binary....
03:34 < bitcoin-git> bitcoin/master 7d46b3e Wladimir J. van der Laan: Merge #9813: Read/write mempool.dat as a binary....
03:35 < bitcoin-git> [bitcoin] laanwj closed pull request #9813: Read/write mempool.dat as a binary. (master...20170220_mempool_binary) https://github.com/bitcoin/bitcoin/pull/9813
03:36 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/3972a8efb2f8fd727ca045dcf89104c9f8a2f846
03:36 < bitcoin-git> bitcoin/0.14 3972a8e Pavel Janík: Read/write mempool.dat as a binary....
03:57 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev     
04:03 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev     
04:17 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev     
04:17 < fanquake> #9464 has been labelled low-priority, but I'm wondering if this is actually something we want to fix for 0.14.0 ? 
04:17 < gribble> https://github.com/bitcoin/bitcoin/issues/9464 | [GUI] "Number of blocks left" never updates when running with -reindex-chainstate · Issue #9464 · bitcoin/bitcoin · GitHub
04:17 < fanquake> You get a similar problem was running with —reindex, in that number of blocks is unknown, but both progress increase and estimated time left are both "calculating".
04:18 < fanquake> So you basically get no gui output expect for the progress bar, and when you hover over it.
04:19 < fanquake> Even the debug window doesn't update with progress.
04:19 < fanquake> Seems less than ideal, and user forced to reindex will have no idea of progress, or how long it's going to take.
04:19 < fanquake> *any
04:20 < wumpus> if it's another lock contention issue it's less than trivial to solve
04:20 < wumpus> so I would prefer not to hold up 0.14.0 for that, no
04:21 < fanquake> Something for 0.14.1 then? I'm sure the complaints of "reindexing with no progress output!" "How long is it going to take!" will roll in.
04:21 < wumpus> but if someone comes up with a solution it could be backported to 0.14
04:21 < wumpus> sure
04:22 < fanquake> I'll update the above issue with some more info, and create a 0.14.1 milestone.
04:22 < wumpus> it'd nice to not have the problem, but reindexing GUI output just isn't critical, in the way that say a crash is
04:22  * luke-jr stabs QTableView for not letting him resize the freaking columns
04:22 < wumpus> luke-jr: you should be able to resize the columns?
04:22 < luke-jr> wumpus: tried 3 or 4 different ways, none seem to work :/
04:23 < wumpus> luke-jr: we resize tables in various parts of the source, don't know by heart how though
04:23 < luke-jr> yeah, I must be missing something stupid
04:23 < wumpus> the most tricky thing is not the resizing itself
04:23 < luke-jr> ?     
04:23 < wumpus> but *how large* to make the columns
04:23 < luke-jr> QFontMetrics::width?
04:23 < wumpus> font sizes can differ, high-dpi versus normal-dpi columns, and so on
04:24 < wumpus> yeah it's possible to get it right, just tricky
04:46 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Read error: Connection reset by peer]     
04:47 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev     
04:47 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Client Quit]     
05:17 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Quit: Leaving.]     
05:20 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/ae1c4e24a6510b2ace819eccbb928a3cb0074daf
05:20 < bitcoin-git> bitcoin/0.14 ae1c4e2 Chris Moore: Fix typo in release notes.
05:22 < jonasschnelli> wumpus: thanks. I'll try to do use your offline building solution.
05:23 < bitcoin-git> [bitcoin] laanwj closed pull request #9803: Fix typo in release notes. (0.14...patch-5) https://github.com/bitcoin/bitcoin/pull/9803
05:25 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has joined #bitcoin-core-dev     
05:27 -!- goksinen_ [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev     
05:30 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds]     
05:33 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7d46b3ea8d6c...8ad31f9aa311
05:33 < bitcoin-git> bitcoin/master 40f11f8 kirit93: Fix for issue #9775. Added check for open() returning a NULL pointer.
05:33 < bitcoin-git> bitcoin/master 8ad31f9 Wladimir J. van der Laan: Merge #9798: Fix Issue #9775 (Check returned value of fopen)...
05:33 < bitcoin-git> [bitcoin] laanwj closed pull request #9798: Fix Issue #9775 (Check returned value of fopen) (master...issue) https://github.com/bitcoin/bitcoin/pull/9798
05:34 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/e22c0671c74bc4db70b3ba04d093cd110f9f22a7
05:34 < bitcoin-git> bitcoin/0.14 e22c067 kirit93: Fix for issue #9775. Added check for open() returning a NULL pointer....
05:38 -!- zyla [~zyla@185.56.175.154] has quit [Remote host closed the connection]     
05:43 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #9817: Fix segfault crash when shutdown the GUI in disablewallet mode (master...2017/02/sf_gui) https://github.com/bitcoin/bitcoin/pull/9817
05:47 -!- Sosumi [~Leon@bl10-113-190.dsl.telepac.pt] has joined #bitcoin-core-dev     
05:51 -!- _mn3monic [~guido@176.9.68.68] has joined #bitcoin-core-dev     
05:54 < jonasschnelli> wumpus: re your offline build mode in gitian: how does it can get the depends/packages in the offline mode?
05:55 < jonasschnelli> I still see "Fetching ccache-3.3.3.tar.bz2 from https://bitcoincore.org/depends-sources" in the build.log
05:56 < wumpus> jonasschnelli: the idea is that the cache is prepopulated
05:56 < wumpus> jonasschnelli: so that it won't try to download the tarballs
05:57 < jonasschnelli> wumpus: cd into the git bitcoin repository/depends and download all soucres?
05:58 < jonasschnelli> I think there is a "make download" (in the depends Makefile)
05:58 < wumpus> indeed, there is "make download"
05:59 < wumpus> you could also copy the directory from another build host, if you already have gitian-built before
05:59 < wumpus> I don't think the offline building section is very useful in that regard, it only talks about apt
06:00 < wumpus> which is the least issue as the host is used as apt-cache so that part never needs DNS lookups on the guest
06:00 -!- ryanofsky [~russ@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Remote host closed the connection]     
06:02 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
06:05 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit]     
06:13 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8ad31f9aa311...8528d6ac6d51
06:13 < bitcoin-git> bitcoin/master 312c4f1 Jonas Schnelli: Fix segfault crash when shutdown the GUI in disablewallet mode
06:13 < bitcoin-git> bitcoin/master 8528d6a Wladimir J. van der Laan: Merge #9817: Fix segfault crash when shutdown the GUI in disablewallet mode...
06:14 < bitcoin-git> [bitcoin] laanwj closed pull request #9817: Fix segfault crash when shutdown the GUI in disablewallet mode (master...2017/02/sf_gui) https://github.com/bitcoin/bitcoin/pull/9817
06:16 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/7d75a5a93c161aa4de22ac862702ba0241e8faa2
06:16 < bitcoin-git> bitcoin/0.14 7d75a5a Jonas Schnelli: Fix segfault crash when shutdown the GUI in disablewallet mode...
06:32 -!- ryanofsky [russ@2600:3c03::f03c:91ff:fe55:105d] has joined #bitcoin-core-dev     
06:33 -!- jnewbery_ [~john@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev     
06:44 -!- ryanofsky [russ@2600:3c03::f03c:91ff:fe55:105d] has quit [Quit: ZNC 1.6.4 - http://znc.in]     
06:44 -!- ryanofsky [russ@2600:3c03::f03c:91ff:fe55:105d] has joined #bitcoin-core-dev     
06:54 -!- aalex [~aalex@64.187.177.58] has joined #bitcoin-core-dev     
06:58 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 268 seconds]     
07:17 -!- Kexkey [~kexkey@23.227.207.22] has joined #bitcoin-core-dev     
07:31 -!- moli_ [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds]     
07:33 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
07:34 -!- aalex [~aalex@64.187.177.58] has quit [Quit: Connection reset by beer]     
08:00 -!- jnewbery1 [~Thunderbi@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev     
08:02 -!- jnewbery [~Thunderbi@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Ping timeout: 260 seconds]     
08:02 -!- jnewbery1 is now known as jnewbery     
08:02 -!- Kexkey [~kexkey@23.227.207.22] has quit [Ping timeout: 260 seconds]     
08:08 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8528d6ac6d51...5f0556d0326b
08:08 < bitcoin-git> bitcoin/master 056aba2 Wladimir J. van der Laan: Remove fallbacks for boost_filesystem < v3...
08:08 < bitcoin-git> bitcoin/master 5f0556d Wladimir J. van der Laan: Merge #9727: Remove fallbacks for boost_filesystem < v3...
08:09 < bitcoin-git> [bitcoin] laanwj closed pull request #9727: Remove fallbacks for boost_filesystem < v3 (master...2017_02_boostfs_flailbacks) https://github.com/bitcoin/bitcoin/pull/9727
08:11 < bitcoin-git> [bitcoin] ryanofsky opened pull request #9818: Save watch only key timestamps when reimporting keys (master...pr/multirewatch) https://github.com/bitcoin/bitcoin/pull/9818
08:16 < bitcoin-git> [bitcoin] morcos opened pull request #9819: Remove harmless read of unusued priority estimates (master...removeExtraRead) https://github.com/bitcoin/bitcoin/pull/9819
08:38 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
08:39 -!- moli_ [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds]     
08:40 -!- mol [~molly@unaffiliated/molly] has quit [Remote host closed the connection]     
08:40 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
08:51 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev     
08:51 < bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/5f0556d0326b...61a640ea9741
08:51 < bitcoin-git> bitcoin/master 5ea5368 Bob McElrath: ZMQ example using python3 and asyncio
08:51 < bitcoin-git> bitcoin/master 5406d51 Bob McElrath: Rewrite to not use Polling wrapper for asyncio, link to python2.7 example
08:51 < bitcoin-git> bitcoin/master 4bb7d1b Bob McElrath: Add python version checks and 3.4 example
08:51 < bitcoin-git> [bitcoin] laanwj closed pull request #9485: ZMQ example using python3 and asyncio (master...python3zmq) https://github.com/bitcoin/bitcoin/pull/9485
08:52 < morcos> Just a heads up that pruning.py is broken in 0.14 and master, cause seems to be the 2 hour buffer added in #9778. I think ryanofsky is working on a fix.
08:52 < gribble> https://github.com/bitcoin/bitcoin/issues/9778 | Add two hour buffer to manual pruning by morcos · Pull Request #9778 · bitcoin/bitcoin · GitHub
08:54 -!- instagibbs [~instagibb@pool-100-15-114-3.washdc.fios.verizon.net] has quit [Ping timeout: 240 seconds]     
08:59 -!- instagibbs [~instagibb@pool-100-15-114-3.washdc.fios.verizon.net] has joined #bitcoin-core-dev     
09:00 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev     
09:31 -!- Squidicuz [~squid@pool-173-48-116-49.bstnma.fios.verizon.net] has quit [Quit: Oh no, not again]     
09:35 -!- arowser [~quassel@106.120.101.38] has quit [Quit: No Ping reply in 180 seconds.]     
09:37 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev     
09:37 -!- Squidicuz [~squid@pool-173-48-116-49.bstnma.fios.verizon.net] has joined #bitcoin-core-dev     
09:41 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has quit [Ping timeout: 268 seconds]     
09:48 -!- Giszmo [~leo@ip-129-233.219.201.nextelmovil.cl] has joined #bitcoin-core-dev     
09:54 -!- Giszmo [~leo@ip-129-233.219.201.nextelmovil.cl] has quit [Ping timeout: 260 seconds]     
10:02 < bitcoin-git> [bitcoin] ryanofsky opened pull request #9820: Fix pruning test broken by 2 hour manual prune window (master...pr/prunewind) https://github.com/bitcoin/bitcoin/pull/9820
10:02 -!- Giszmo [~leo@ip-129-233.219.201.nextelmovil.cl] has joined #bitcoin-core-dev     
10:04 -!- Giszmo1 [~leo@pc-240-13-215-201.cm.vtr.net] has joined #bitcoin-core-dev     
10:06 -!- Giszmo [~leo@ip-129-233.219.201.nextelmovil.cl] has quit [Ping timeout: 240 seconds]     
10:11 -!- Giszmo1 [~leo@pc-240-13-215-201.cm.vtr.net] has quit [Ping timeout: 260 seconds]     
10:14 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev     
10:15 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]     
10:25 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has joined #bitcoin-core-dev     
10:26 < morcos> Question re fee estimation improvements.  We have two rpc calls now.  estimatefee and estimatesmartfee.  I'd like to improve estimatesmartfee to be even "more smarter" and perhaps return more data to you about how it arrived at its estimates.
10:27 < morcos> And I'd like to turn estimatefee into more of a raw call that allows you to generate your own smart estimation through repeated calls to estimatefee with various parameters
10:29 < morcos> but that would imply re-enabling estimates for a target of 1 in the estimatefee call.  does anyone think that's necessarily an issue.  seems a bit odd to disable for a release and then reenable, but it becomes more of a raw utility, it makes sense to not constrain it
10:30 < morcos> does this make sense as a way forward for improving and extending fee estimation?
10:30 < morcos> or would it perhaps make sense to make a new rpc call for low level functionality that is even more raw and could give you direct acess to the saved data?
10:32 < ryanofsky> imo, disabling and reenabling is nicer than disabling and then adding a new rpc to do what the disabled thing did
10:46 < gmaxwell> funny, I was going to say the opposite!
10:47 < gmaxwell> the purpose of it is changing, so perhaps it should have a new name. "feeestimationdata"
10:50 < ryanofsky> yeah, it's a tradeoff. personally when i am a user of an api, i just want it to be as straightforward as possible what the various options in the api do, and what the behavioral differences are
10:50 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
10:50 < ryanofsky> i care a lot more about the actual behavior of the api, than whatever the intended "purpose" of the api was when it was developed
10:54 < morcos> after some discussion i'm leaning towards this:  adding a new hidden rpc call estimaterawfee that allows raw access to the model data.  It can be useful for debugging people with fee estimate problems or for super advanced users that want to implement their own smartness
10:55 < morcos> estimatefee itself will continue as is to hopefully eventually be deprecated
10:55 -!- molz_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
10:56 < morcos> and most people will use estimatesmartfee which may return more information to help people who want to read more than one number understand the tradeoffs..   but is more user friendly and doesn't take a whole lot of parameters, just how quickly you want the damn tx confirmed
10:58 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 255 seconds]     
10:59 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has quit [Ping timeout: 240 seconds]     
11:01 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev     
11:02 -!- Guyver2_ [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev     
11:04 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Disconnected by services]     
11:04 -!- Guyver2_ is now known as Guyver2     
11:10 -!- whphhg [~whphhg@unaffiliated/whphhg] has quit [Quit: Leaving]     
11:28 -!- whphhg [whphhg@gateway/vpn/mullvad/x-chfgywkrbjbkvtge] has joined #bitcoin-core-dev     
11:42 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 260 seconds]     
11:44 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev     
11:56 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has joined #bitcoin-core-dev     
12:01 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has quit [Client Quit]     
12:01 -!- Giszmo [~leo@ip-203-233.219.201.nextelmovil.cl] has joined #bitcoin-core-dev     
12:04 -!- Giszmo1 [~leo@pc-240-13-215-201.cm.vtr.net] has joined #bitcoin-core-dev     
12:06 -!- Giszmo [~leo@ip-203-233.219.201.nextelmovil.cl] has quit [Ping timeout: 260 seconds]     
12:07 -!- Giszmo [~leo@ip-145-233.219.201.nextelmovil.cl] has joined #bitcoin-core-dev     
12:07 < bitcoin-git> [bitcoin] laanwj opened pull request #9821: util: Specific GetOSRandom for Linux/FreeBSD/OpenBSD (master...2017_02_osrandom) https://github.com/bitcoin/bitcoin/pull/9821
12:10 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
12:10 -!- Giszmo1 [~leo@pc-240-13-215-201.cm.vtr.net] has quit [Ping timeout: 260 seconds]     
12:11 -!- mol [~molly@unaffiliated/molly] has quit [Remote host closed the connection]     
12:12 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
12:12 -!- molz_ [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds]     
12:50 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
12:52 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds]     
12:53 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
12:56 -!- Sosumi [~Leon@bl10-113-190.dsl.telepac.pt] has quit [Quit: Bye]     
12:56 -!- moli_ [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds]     
12:58 -!- Giszmo [~leo@ip-145-233.219.201.nextelmovil.cl] has quit [Ping timeout: 255 seconds]     
13:14 -!- Giszmo [~leo@ip-228-233.219.201.nextelmovil.cl] has joined #bitcoin-core-dev     
13:16 -!- Guyver2_ [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev     
13:20 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Ping timeout: 260 seconds]     
13:20 -!- Guyver2_ is now known as Guyver2     
13:24 -!- Guyver2_ [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev     
13:25 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Ping timeout: 260 seconds]     
13:25 -!- Guyver2_ is now known as Guyver2     
14:03 -!- Lauda [~quassel@unaffiliated/lauda] has quit [Quit: No Ping reply in 180 seconds.]     
14:04 -!- Giszmo [~leo@ip-228-233.219.201.nextelmovil.cl] has quit [Ping timeout: 260 seconds]     
14:14 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has quit [Quit: Leaving]     
14:18 -!- Giszmo [~leo@ip-233-233.219.201.nextelmovil.cl] has joined #bitcoin-core-dev     
14:22 -!- bsm117532 [~mcelrath@135.84.167.210] has quit [Remote host closed the connection]     
14:28 -!- bsm117532 [~mcelrath@135.84.167.210] has joined #bitcoin-core-dev     
14:35 -!- Creeper is now known as slimeball     
15:02 -!- jtimon [~quassel@199.116.72.155] has joined #bitcoin-core-dev     
15:03 < jtimon> post-0.14-fork review begging https://github.com/bitcoin/bitcoin/pull/8855
15:03 < jtimon> also #8994
15:03 < gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub
15:06 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/61a640ea9741...5628c70f2a44
15:06 < bitcoin-git> bitcoin/master 41e7219 fanquake: [trivial] Add tests_config.ini to .gitignore
15:06 < bitcoin-git> bitcoin/master 851f6a3 fanquake: [qa][doc] Correct rpc test options in readme
15:06 < bitcoin-git> bitcoin/master 5628c70 MarcoFalke: Merge #9807: RPC doc fix-ups....
15:06 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #9807: RPC doc fix-ups. (master...rpc-test-trivial-fixups) https://github.com/bitcoin/bitcoin/pull/9807
15:26 -!- jtimon [~quassel@199.116.72.155] has quit [Ping timeout: 240 seconds]     
15:29 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 255 seconds]     
15:30 -!- JackH [~laptop@79-73-188-131.dynamic.dsl.as9105.com] has quit [Remote host closed the connection]     
15:33 -!- jtimon [~quassel@199.116.72.155] has joined #bitcoin-core-dev     
15:37 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Ping timeout: 260 seconds]     
15:41 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev     
17:00 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com]     
17:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []     
17:50 -!- amiller [~socrates1@unaffiliated/socrates1024] has quit [Ping timeout: 276 seconds]     
17:51 -!- jtimon [~quassel@199.116.72.155] has quit [Ping timeout: 255 seconds]     
17:58 -!- jtimon [~quassel@199.116.72.155] has joined #bitcoin-core-dev     
18:16 -!- jtimon [~quassel@199.116.72.155] has quit [Remote host closed the connection]     
18:44 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-jljakbxkxrhbqyyv] has quit [Quit: Connection closed for inactivity]     
18:47 -!- goksinen_ [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection]     
18:59 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev     
19:07 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection]     
19:07 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev     
19:08 -!- Guest47306 [~socrates1@li175-104.members.linode.com] has joined #bitcoin-core-dev     
19:08 -!- Guest47306 [~socrates1@li175-104.members.linode.com] has quit [Changing host]     
19:08 -!- Guest47306 [~socrates1@unaffiliated/socrates1024] has joined #bitcoin-core-dev     
19:08 -!- Guest47306 is now known as amiller     
19:36 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
19:39 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 240 seconds]     
19:45 -!- dodomojo [~goksinen@2604:2000:c591:8400:f92f:4280:6836:b6da] has joined #bitcoin-core-dev     
20:00 -!- dermoth [~thomas@dsl-216-221-55-141.mtl.contact.net] has quit [Read error: Connection reset by peer]     
20:00 -!- dermoth [~thomas@dsl-216-221-55-141.mtl.contact.net] has joined #bitcoin-core-dev     
20:35 -!- dodomojo [~goksinen@2604:2000:c591:8400:f92f:4280:6836:b6da] has quit [Remote host closed the connection]     
20:35 -!- shesek [~shesek@bzq-84-110-60-48.red.bezeqint.net] has quit [Ping timeout: 240 seconds]     
20:39 -!- Giszmo [~leo@ip-233-233.219.201.nextelmovil.cl] has quit [Quit: Leaving.]     
20:39 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has joined #bitcoin-core-dev     
20:52 -!- chris200_ [~chris2000@p5DCB5159.dip0.t-ipconnect.de] has joined #bitcoin-core-dev     
20:55 -!- chris2000 [~chris2000@p5DCB5CCB.dip0.t-ipconnect.de] has quit [Ping timeout: 255 seconds]     
20:57 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Read error: Connection reset by peer]     
20:58 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev     
20:58 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has quit [Ping timeout: 255 seconds]     
21:00 -!- dermoth [~thomas@dsl-216-221-55-141.mtl.contact.net] has quit [Read error: Connection reset by peer]     
21:00 -!- dermoth [~thomas@dsl-216-221-55-141.mtl.contact.net] has joined #bitcoin-core-dev     
21:22 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has quit [Remote host closed the connection]     
21:23 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has joined #bitcoin-core-dev     
22:10 -!- asoltys [~adam@115.96.198.104.bc.googleusercontent.com] has joined #bitcoin-core-dev     
22:24 < bitcoin-git> [bitcoin] benma opened pull request #9822: Refactor: Split part of AppInitMain() into a new function (master...appinitmain) https://github.com/bitcoin/bitcoin/pull/9822
22:45 -!- city22 [~textual@210.13.244.130] has joined #bitcoin-core-dev     
22:59 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 260 seconds]     
23:01 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving]     
23:06 -!- yahtoo [~myyao@219.135.155.120] has joined #bitcoin-core-dev     
23:09 < wumpus> jonasschnelli, others: any idea about OS-specific random API on OSX? I heard about "SecRandom" (https://opensource.apple.com/source/Security/Security-55471/sec/Security/SecRandom.h), is that what should be used?
23:09 < jonasschnelli> wumpus: Yes. That's simple
23:10 < wumpus> will try to add it to #9821. So SecRandomRef can be left NULL?
23:10 < gribble> https://github.com/bitcoin/bitcoin/issues/9821 | util: Specific GetOSRandom for Linux/FreeBSD/OpenBSD by laanwj · Pull Request #9821 · bitcoin/bitcoin · GitHub
23:11 < jonasschnelli> Let me look at it...
23:11 < jonasschnelli> I know there are other projects that already did this
23:13 < sipa> that's a psuedo random number
23:13 < sipa> i believe we're looking for a pseudo random number!
23:13 < wumpus> kSecRandomDefault
23:14 < sipa> defining a new name for NULL through an external symbol?
23:14 < wumpus> very random, just happens to have all the bits turned off every time
23:14 < sipa> that's pretty inefficient!
23:14 < jonasschnelli> @function SecRandomCopyBytes
23:14 < jonasschnelli> 	@abstract Return count random bytes in *bytes, allocated by the caller.
23:14 < jonasschnelli>          It is critical to check the return value for error
23:15 < jonasschnelli> "Generates an array of cryptographically secure random bytes"
23:15 < jonasschnelli> IMO SecRandomCopyBytes is CPRNG
23:15 < wumpus> it's inefficient, though that is not really our worry here, this is the slow path
23:15 -!- whphhg [whphhg@gateway/vpn/mullvad/x-chfgywkrbjbkvtge] has quit [Quit: Leaving]     
23:16 < jonasschnelli> I think this is the way to go: "if (SecRandomCopyBytes(kSecRandomDefault, entropy.length, entropy.mutableBytes) != 0) return nil;"
23:16 < wumpus> jonasschnelli: I guess MacOSX also supports the sysctl(ARND), inherited from NetBSD?
23:16 < jonasschnelli> Yes. I think so. But not sure which makes more sense. Maybe add entropy from both?
23:17 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev     
23:17 < jonasschnelli> I quickly check what apples recommends (that doesn't say it the solution we should go()
23:18 < wumpus> I'd like to keep the GetOSRandom abtraction simple - just get random from the OS, whatever a good option is for that OS. Combining shouldn't make sense there
23:19 < wumpus> an alternative way of going about this would be to check all randomness sources that are available , and somehow call all of them every time and combine them, but I'm not sure whether that's voodoo coding or sensible paranoia
23:20 < wumpus> and note we already combine the output with randomness from other sources in an outer function
23:22 < jonasschnelli> wumpus: has the idea with using fortuna for mixing all sorts of entropy died?
23:23 < wumpus> using the MacOSX API doesn't mean anything scary like using objective c++ does it? all the examples I see have NSLog and NSMutableString etc in them
23:23 < jonasschnelli> No. It's pure C
23:23 < jonasschnelli> You need to link against the Security.frameowkr
23:23 < jonasschnelli> T     
23:23 < jonasschnelli> We already link against other framework... 
23:23 < wumpus> jonasschnelli: I don't know, but I don't see a reason to combine multiple random streams coming from the OS and portrayed as cryptographic APIs
23:24 -!- whphhg [whphhg@gateway/vpn/mullvad/x-kgkgepedcbkdddsb] has joined #bitcoin-core-dev     
23:24 < jonasschnelli> wumpus: I think the only reason could be if you are enough paranoid. :)
23:24 < jonasschnelli> What speaks against using /dev/(u)random on OSX? Concurrency? It would be the simplest approach?
23:25 < jonasschnelli> Apples states that /dev/random is CPRNG
23:25 < wumpus> we already use /dev/urandom
23:25 < jonasschnelli> wumpus: So SecRandomCopyBytes would give additional entrtopy?
23:25 < wumpus> and that will remain the fallback if nothing else is availalbe, however in sandboxes it's not always available
23:26 < wumpus> that was what prompted this, not 'we don't trust /dev/urandom'
23:27 < wumpus> e.g. user created containers and chroots won't have the /dev/urandom device, some sandboxes (such as cluodabi/capsicum) don' t have file access at all (not that we can support those at the moment in bitcoin core). Direct system calls are the new way to get randomness from the OS.
23:29 < jonasschnelli> Apples says "This function reads from /dev/random to obtain an array of cryptographically-secure random bytes" about SecRandomCopyBytes
23:29 < wumpus> lol. okay, so it won't help :)
23:29 < jonasschnelli> Not sure what internal fallback mechanisms are provided
23:29 < jonasschnelli> I think that part is closed source
23:29 < wumpus> thanks for looking that up, that's very useful information
23:30 < jonasschnelli> Heres to code: https://opensource.apple.com/source/Security/Security-55179.11/sec/Security/SecFramework.c
23:30 < jonasschnelli> And yes. It reads from /dev/random :)
23:31 < jonasschnelli> If that's not available, it returns 0.
23:31 < wumpus> yup. So going through all the trouble to link another framework and calling it isn't worth it
23:31 < jonasschnelli> Yes.
23:33 < cfields> er, i don't think we link in frameworks for bitcoind do we?
23:33 < cfields> (seems the point's moot anyway now, though)
23:34 -!- yahtoo [~myyao@219.135.155.120] has quit [Quit: Leaving]     
23:35 -!- Victor_sueca is now known as Victorsueca     
23:36 -!- whphhg [whphhg@gateway/vpn/mullvad/x-kgkgepedcbkdddsb] has quit [Quit: Leaving]     
23:36 < jonasschnelli> cfields: Good point. I guess only for the Qt parts.
23:36 < wumpus> a different thing I noticed is that our code is opening and closing the /dev/urandom device every call to GetOSRand. Nothing wrong with that in itself, though reserving a fd for it would mean it's always available.
23:38 < jonasschnelli> I wonder if it would make more sense to have the random 
23:38 < jonasschnelli> ...     
23:38 < jonasschnelli> the randomness thins abstracted into a library...
23:38 < jonasschnelli> I think there are lots of other application that also wants to deal with this without openssl
23:38 < wumpus> well it's abstracted to random.o now :-)
23:38 -!- jnewbery [~Thunderbi@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Ping timeout: 260 seconds]     
23:38 < wumpus> which is sort of a one-file randomness library. Idon't think it depends on any bitcoin specific things
23:39 < jonasschnelli> Hah. indeed. What are the dependencies?
23:39 < luke-jr> jonasschnelli: gnutls? :P
23:39  * jonasschnelli stabs luke-jr
23:40 < jonasschnelli> my testnet dns seeder will be down for a couple of hours (moving location)
23:44 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]     
23:45 < wumpus> ok, thanks for letting us know
23:57 < jonasschnelli> Does anyone know how I can avoid sudo password prompt in gbuild using LXC? I have added /usr/bin/lxc-start and execute to sudoers (nopassword)
23:59 < Victorsueca> sudo -i ?
23:59 < luke-jr> jonasschnelli: check syslog
23:59 < wumpus> to have passwordless sudo you need to edit sudoers, you can either make all sudo use passwordless or specific commands
23:59 < wumpus> I don't know the syntax by heart, though. Always have to look at up (and fail at leat three times at it)
23:59 < jonasschnelli> But why does gbuild require root?
23:59 < luke-jr> also, some distros have non-root LXC now