--- Day changed Sun Feb 26 2017 00:31 -!- lclc [~lclc@unaffiliated/lclc] has quit [Read error: Connection reset by peer] 00:33 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 00:50 -!- lclc [~lclc@unaffiliated/lclc] has quit [Read error: Connection reset by peer] 00:53 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 00:54 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-fiheiyfkjffopsmk] has joined #bitcoin-core-dev 01:03 -!- lclc [~lclc@unaffiliated/lclc] has quit [Read error: Connection reset by peer] 01:05 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 01:15 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:27 -!- Victor_sueca is now known as Victorsueca 01:30 -!- lclc [~lclc@unaffiliated/lclc] has quit [Read error: Connection reset by peer] 01:32 -!- Sosumi [~Leon@bl10-113-190.dsl.telepac.pt] has joined #bitcoin-core-dev 01:32 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 01:45 -!- n1ce [~n1ce____@unaffiliated/n1ce] has joined #bitcoin-core-dev 01:50 -!- str4d [~str4d@host-78-145-23-219.as13285.net] has joined #bitcoin-core-dev 01:50 -!- trippysalmon [~trippy@cyberdynesys.org] has quit [Remote host closed the connection] 01:51 -!- lclc [~lclc@unaffiliated/lclc] has quit [Read error: Connection reset by peer] 01:52 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 02:03 -!- lclc [~lclc@unaffiliated/lclc] has quit [Read error: Connection reset by peer] 02:05 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 02:13 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 240 seconds] 02:17 -!- trippysalmon [~trippy@cyberdynesys.org] has joined #bitcoin-core-dev 02:21 -!- haakonn_ is now known as haakonn 02:22 -!- haakonn [~haakonn@146.185.155.218] has quit [Changing host] 02:22 -!- haakonn [~haakonn@pdpc/supporter/active/haakonn] has joined #bitcoin-core-dev 02:28 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 02:31 -!- vFSgrcFGBJHg [~rYUtdcvYT@2a02:2f0a:b050:eea:934a:6abb:750c:602c] has quit [Quit: Leaving] 02:32 -!- Guest54942 [~asdf@213.204.88.169] has joined #bitcoin-core-dev 02:44 -!- lclc [~lclc@unaffiliated/lclc] has quit [Read error: Connection reset by peer] 02:45 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 02:46 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 02:51 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 02:52 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 260 seconds] 02:54 -!- Guest54942 [~asdf@213.204.88.169] has quit [Ping timeout: 240 seconds] 03:01 -!- MarcoFalke [~marco@2a02:778:100:ea01:2225:64ff:fe3b:d4ca] has joined #bitcoin-core-dev 03:07 -!- nOgAnOo [sid146237@gateway/web/irccloud.com/x-lkyavnkmpgqzfvpe] has quit [Quit: Connection closed for inactivity] 03:27 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 03:41 -!- lclc [~lclc@unaffiliated/lclc] has quit [Read error: Connection reset by peer] 03:43 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 03:51 -!- MarcoFalke [~marco@2a02:778:100:ea01:2225:64ff:fe3b:d4ca] has quit [Ping timeout: 255 seconds] 03:54 -!- shesek [~shesek@bzq-84-110-58-249.cablep.bezeqint.net] has joined #bitcoin-core-dev 03:55 -!- lclc [~lclc@unaffiliated/lclc] has quit [Read error: Connection reset by peer] 03:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:58 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 04:28 -!- lclc [~lclc@unaffiliated/lclc] has quit [Read error: Connection reset by peer] 04:30 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 04:49 -!- lclc [~lclc@unaffiliated/lclc] has quit [Read error: Connection reset by peer] 04:51 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 05:01 -!- lclc [~lclc@unaffiliated/lclc] has quit [Read error: Connection reset by peer] 05:03 < bitcoin-git> [bitcoin] marijnfs opened pull request #9865: Change bitcoin address in RPC help message (master...master) https://github.com/bitcoin/bitcoin/pull/9865 05:07 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 05:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 05:13 -!- alpalp [~alpalp@unaffiliated/alpalp] has joined #bitcoin-core-dev 05:15 -!- AaronvanW [~AaronvanW@110.red-88-20-218.staticip.rima-tde.net] has joined #bitcoin-core-dev 05:15 -!- AaronvanW [~AaronvanW@110.red-88-20-218.staticip.rima-tde.net] has quit [Changing host] 05:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:23 -!- lclc_ [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 05:25 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 268 seconds] 05:32 -!- lclc_ [~lclc@unaffiliated/lclc] has quit [Read error: Connection reset by peer] 05:34 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 05:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 05:50 -!- lclc_ [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 05:50 -!- lclc [~lclc@unaffiliated/lclc] has quit [Read error: Connection reset by peer] 05:51 -!- AaronvanW [~AaronvanW@110.red-88-20-218.staticip.rima-tde.net] has joined #bitcoin-core-dev 05:51 -!- AaronvanW [~AaronvanW@110.red-88-20-218.staticip.rima-tde.net] has quit [Changing host] 05:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 06:03 -!- lclc_ [~lclc@unaffiliated/lclc] has quit [Read error: Connection reset by peer] 06:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 06:11 -!- str4d [~str4d@host-78-145-23-219.as13285.net] has quit [Ping timeout: 260 seconds] 06:17 -!- shesek [~shesek@bzq-84-110-58-249.cablep.bezeqint.net] has quit [Ping timeout: 255 seconds] 06:18 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving] 06:20 -!- paveljanik [~paveljani@79.98.72.176] has joined #bitcoin-core-dev 06:20 -!- paveljanik [~paveljani@79.98.72.176] has quit [Changing host] 06:20 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 06:24 -!- str4d [~str4d@host-78-145-18-192.as13285.net] has joined #bitcoin-core-dev 06:29 -!- shesek [~shesek@bzq-84-110-179-3.red.bezeqint.net] has joined #bitcoin-core-dev 06:41 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 06:47 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Read error: Connection reset by peer] 06:48 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 06:50 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 07:08 -!- str4d [~str4d@host-78-145-18-192.as13285.net] has quit [Ping timeout: 260 seconds] 07:11 -!- AaronvanW [~AaronvanW@110.red-88-20-218.staticip.rima-tde.net] has joined #bitcoin-core-dev 07:11 -!- AaronvanW [~AaronvanW@110.red-88-20-218.staticip.rima-tde.net] has quit [Changing host] 07:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 07:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 07:20 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection] 07:20 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev 07:27 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has joined #bitcoin-core-dev 07:28 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 07:39 -!- lclc [~lclc@unaffiliated/lclc] has quit [Read error: Connection reset by peer] 07:42 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 07:51 -!- lclc [~lclc@unaffiliated/lclc] has quit [Read error: Connection reset by peer] 07:54 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 08:08 -!- JackH [~laptop@79-73-188-131.dynamic.dsl.as9105.com] has quit [Remote host closed the connection] 08:15 -!- alpalp [~alpalp@unaffiliated/alpalp] has quit [Ping timeout: 240 seconds] 08:26 -!- lclc [~lclc@unaffiliated/lclc] has quit [Read error: Connection reset by peer] 08:28 -!- alpalp [~alpalp@unaffiliated/alpalp] has joined #bitcoin-core-dev 08:28 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 08:35 -!- alpalp [~alpalp@unaffiliated/alpalp] has quit [Ping timeout: 240 seconds] 08:41 -!- lclc [~lclc@unaffiliated/lclc] has quit [Read error: Connection reset by peer] 08:43 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 08:53 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 08:53 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 260 seconds] 09:06 -!- JackH [~laptop@79-73-188-131.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev 09:06 -!- adiabat [~adiabat@67.205.158.84] has quit [Remote host closed the connection] 09:06 -!- adiabat [~adiabat@67.205.158.84] has joined #bitcoin-core-dev 09:08 -!- alpalp [~alpalp@2605:6000:f4ea:ff00:dba:5c0f:355e:e899] has joined #bitcoin-core-dev 09:08 -!- alpalp [~alpalp@2605:6000:f4ea:ff00:dba:5c0f:355e:e899] has quit [Changing host] 09:08 -!- alpalp [~alpalp@unaffiliated/alpalp] has joined #bitcoin-core-dev 09:16 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #9866: Document increase in memory usage due to mempool/dbcache sharing (0.14...2017-02-share-mem-release-notes) https://github.com/bitcoin/bitcoin/pull/9866 09:17 -!- alpalp [~alpalp@unaffiliated/alpalp] has quit [Ping timeout: 240 seconds] 09:18 -!- MarcoFalke [~marco@2a02:778:100:ea01:2225:64ff:fe3b:d4ca] has joined #bitcoin-core-dev 09:26 -!- grubles [~grubles@unaffiliated/grubles] has quit [Quit: brb] 09:39 -!- str4d [~str4d@host-78-145-31-167.as13285.net] has joined #bitcoin-core-dev 09:49 -!- panicstr [~panicstr@89-233-121-180.dynamic.t-2.net] has quit [Ping timeout: 260 seconds] 09:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 10:16 -!- alpalp [~alpalp@unaffiliated/alpalp] has joined #bitcoin-core-dev 10:25 -!- alpalp [~alpalp@unaffiliated/alpalp] has quit [Ping timeout: 240 seconds] 10:30 -!- alpalp [~alpalp@unaffiliated/alpalp] has joined #bitcoin-core-dev 10:37 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 10:46 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:47 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 10:48 -!- MarcoFalke [~marco@2a02:778:100:ea01:2225:64ff:fe3b:d4ca] has quit [Read error: Connection reset by peer] 10:53 -!- alpalp [~alpalp@unaffiliated/alpalp] has quit [Ping timeout: 240 seconds] 11:01 -!- alpalp [~alpalp@2605:6000:f4ea:ff00:10da:b976:4aee:2c7a] has joined #bitcoin-core-dev 11:01 -!- alpalp [~alpalp@2605:6000:f4ea:ff00:10da:b976:4aee:2c7a] has quit [Changing host] 11:01 -!- alpalp [~alpalp@unaffiliated/alpalp] has joined #bitcoin-core-dev 11:14 -!- grubles [~grubles@unaffiliated/grubles] has joined #bitcoin-core-dev 11:20 -!- MarcoFalke [~marco@2a02:778:100:ea01:2225:64ff:fe3b:d4ca] has joined #bitcoin-core-dev 12:13 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has quit [Remote host closed the connection] 12:14 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has joined #bitcoin-core-dev 12:14 < bitcoin-git> [bitcoin] laanwj opened pull request #9867: Replace remaining sprintf with snprintf (master...2017_02_snprintf) https://github.com/bitcoin/bitcoin/pull/9867 12:44 -!- Sosumi [~Leon@bl10-113-190.dsl.telepac.pt] has quit [Quit: Bye] 12:44 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 13:19 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 13:20 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 268 seconds] 13:34 -!- MarcoFalke [~marco@2a02:778:100:ea01:2225:64ff:fe3b:d4ca] has quit [Ping timeout: 255 seconds] 13:37 -!- MarcoFalke [~marco@5.199.182.203] has joined #bitcoin-core-dev 14:01 -!- tadasv [ttttt@gateway/shell/panicbnc/x-hdbaafssttuhjeoq] has quit [Quit: PanicBNC account has been auto selected for removal due to the account being unused.] 14:43 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Read error: Connection reset by peer] 14:58 -!- alpalp [~alpalp@unaffiliated/alpalp] has quit [Ping timeout: 255 seconds] 15:03 -!- str4d [~str4d@host-78-145-31-167.as13285.net] has quit [Ping timeout: 260 seconds] 15:20 -!- alpalp [~alpalp@2605:6000:f4ea:ff00:10da:b976:4aee:2c7a] has joined #bitcoin-core-dev 15:20 -!- alpalp [~alpalp@2605:6000:f4ea:ff00:10da:b976:4aee:2c7a] has quit [Changing host] 15:20 -!- alpalp [~alpalp@unaffiliated/alpalp] has joined #bitcoin-core-dev 15:31 -!- alpalp [~alpalp@unaffiliated/alpalp] has quit [Ping timeout: 240 seconds] 15:33 -!- alpalp [~alpalp@2605:6000:f4ea:ff00:10da:b976:4aee:2c7a] has joined #bitcoin-core-dev 15:33 -!- alpalp [~alpalp@2605:6000:f4ea:ff00:10da:b976:4aee:2c7a] has quit [Changing host] 15:33 -!- alpalp [~alpalp@unaffiliated/alpalp] has joined #bitcoin-core-dev 15:38 -!- alpalp [~alpalp@unaffiliated/alpalp] has quit [Ping timeout: 240 seconds] 15:46 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 15:49 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 16:17 < bitcoin-git> [bitcoin] sipa opened pull request #9868: Abstract out the command line options for block assembly (master...assembleroptions) https://github.com/bitcoin/bitcoin/pull/9868 16:21 -!- rgrant [~rgrant@unaffiliated/rgrant] has joined #bitcoin-core-dev 16:25 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 16:25 < bitcoin-git> [bitcoin] RHavar opened pull request #9869: Move comment to right spot (master...comment) https://github.com/bitcoin/bitcoin/pull/9869 16:33 -!- MarcoFalke [~marco@5.199.182.203] has left #bitcoin-core-dev [] 16:37 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds] 16:41 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 16:43 -!- ebfull [~sean@c-107-2-198-133.hsd1.co.comcast.net] has joined #bitcoin-core-dev 16:45 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 16:48 < rgrant> if a guard node can protect old mining infrastructure, then nothing that old mining software normally produces makes its blocks invalid. but since segwit scripts are spendable by anyone according to the old rules, some non-segwit blocks must be reliably orphaned, should an attacker get hold of segwit "anyonecanspend" transactions and mine them to different outputs (again, under the old rules). w 16:48 < rgrant> here in the code is this tension resolved? 16:56 -!- wolfspraul [~wolfsprau@bobbin.q-ag.de] has quit [Ping timeout: 268 seconds] 16:56 < sipa> rgrant: segwit transactions are non-standard to old nodes 16:56 -!- wolfspraul [~wolfsprau@bobbin.q-ag.de] has joined #bitcoin-core-dev 16:57 < sipa> so unless the old miners intentionally bypass those checks, they'll never produce segwit-invalid blocks (but they might build on top of a segwit-invalid block that someone else produced) 16:58 < rgrant> yes, this describes an attack. but what makes the attack block invalid? 16:58 < sipa> to whom? 16:59 < rgrant> to segwit-enabled nodes and miners 16:59 < sipa> the segwit consensus rules? 16:59 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 268 seconds] 17:00 < sipa> in script/interpreter.h there is a flag SCRIPT_VERIFY_WITNESS 17:00 * rgrant follows along 17:00 < sipa> the block validation code passes this flag to the script execution code when it's invoked for a block that has BIP9 activation 17:01 < sipa> and there is conditional code that executes after the normal script execution in that case, which may fail the execution even though the normal execution succeeded 17:01 < rgrant> but the attacker doesn't set bip9 (though bip9 has activated) 17:02 < sipa> yes 17:02 < sipa> that doesn't matter 17:02 < sipa> bip9 activation isn't dependent on the signalling of the block itself 17:02 < sipa> only on the signalling in the chain's history 17:05 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 255 seconds] 17:07 < rgrant> right. so segwit has activated, and attacker mines this bad block that rewrites a segwit transaction that otherwise hasn't made it into a block yet. and i'm here in interpreter.cpp VerifyScript, where in my case i believe emptyWitness will be used. 17:08 < sipa> what do you mean by rewrites? 17:09 < rgrant> well, attacker wants to use the "anyonecanspend" interpretation of the segwit tx, under the old rules. 17:09 < rgrant> so they just thorw away the witness 17:11 < sipa> ah 17:12 < sipa> under segwit rules, a segwit output can only be spent by an input that has a witness 17:12 -!- alpalp [~alpalp@unaffiliated/alpalp] has joined #bitcoin-core-dev 17:12 < sipa> the attacker can't control whether the witness flag is set in other nodes 17:13 < rgrant> is that over in CheckInputs? 17:13 < sipa> no, in the script code 17:13 < sipa> in the case an attacker removes the witness from the spending input, you'll still call validation with the witness flag set 17:14 < sipa> and the script execution will fail if it's a witness output that is being spent withoit having a witness 17:14 < rgrant> okay, i get the mechanism. now i'm still trying to hunt down the code. 17:15 < rgrant> (also, does this make segwit outputs viral?) 17:16 < rgrant> wait, the input block needs to have a witness, or the input script? 17:17 * rgrant is confused. 17:21 < sipa> the txin spending a witness output has to have a txinwitness 17:22 < sipa> which implies that the block that that txin is in must be a witness block 17:23 < rgrant> thanks. and it can be spent to any address. it's not viral. 17:23 < sipa> right, the outputs don't care 17:30 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 17:31 < bitcoin-git> [bitcoin] sipa opened pull request #9871: [RFC] Add a tree sha512 hash to merge commits (master...merge_sha512) https://github.com/bitcoin/bitcoin/pull/9871 18:00 -!- rgrant [~rgrant@unaffiliated/rgrant] has left #bitcoin-core-dev [] 18:04 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-fiheiyfkjffopsmk] has quit [Quit: Connection closed for inactivity] 18:42 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 18:46 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 18:53 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 18:55 -!- JackH [~laptop@79-73-188-131.dynamic.dsl.as9105.com] has quit [Ping timeout: 240 seconds] 18:58 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 19:26 -!- alpalp [~alpalp@unaffiliated/alpalp] has quit [Remote host closed the connection] 19:33 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 19:38 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 19:44 < bitcoin-git> [bitcoin] kallewoof opened pull request #9872: [qa] Multi-chain support in test framework (master...qa-multi-chain-support) https://github.com/bitcoin/bitcoin/pull/9872 19:45 < gmaxwell> luke-jr: are you going to rebase the remaining multiwallet support now that 0.15 has started? 19:45 < luke-jr> gmaxwell: again? I just did yesterday O.o 19:46 < gmaxwell> oh sorry! 19:46 < luke-jr> hmm, I wonder why Travis is whining 19:48 < gmaxwell> s/are you going to rebase/are you going to fix the travis errors/ :P 19:49 < luke-jr> yes ;) 19:50 < luke-jr> assuming it's not yet another false positive anyway 19:55 -!- dodomojo [~goksinen@2604:2000:c591:8400:59c9:d161:95e5:b7ce] has joined #bitcoin-core-dev 20:02 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 268 seconds] 20:02 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:11 -!- dodomojo [~goksinen@2604:2000:c591:8400:59c9:d161:95e5:b7ce] has quit [Remote host closed the connection] 20:23 -!- alpalp [~alpalp@2605:6000:f4ea:ff00:10da:b976:4aee:2c7a] has joined #bitcoin-core-dev 20:23 -!- alpalp [~alpalp@2605:6000:f4ea:ff00:10da:b976:4aee:2c7a] has quit [Changing host] 20:23 -!- alpalp [~alpalp@unaffiliated/alpalp] has joined #bitcoin-core-dev 20:30 -!- alpalp [~alpalp@unaffiliated/alpalp] has quit [Ping timeout: 240 seconds] 21:04 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 21:23 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has quit [Quit: Leaving.] 21:26 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev 21:26 < dcousens> petertodd: lol, I guess I'll sit this one out then :) 21:27 < dcousens> Did seem difficult to find documentation/material on what you two are referring too though 21:28 -!- Guest91228 [~Cory@24-240-67-80.dhcp.mdsn.wi.charter.com] has quit [] 21:31 -!- Cory [~Cory@unaffiliated/cory] has joined #bitcoin-core-dev 21:32 < sipa> likewise 21:32 < sipa> i was confused by the same SE answer :) 21:33 < achow101> dcousens: sipa: solution - dig through git's source code: https://github.com/git/git/blob/master/gpg-interface.c#L153 21:34 < sipa> cool 21:34 < dcousens> cheers achow101 21:34 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 21:38 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 21:46 < sipa> achow101: it's not perfect w.r.t. the commit, only for the tree 21:46 < sipa> so an attack on the commit's claimed history would still apply 21:47 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 21:48 < achow101> sipa: you mean like if someone faked a commit history with a colliding parent commit hash? 21:49 < sipa> yes, and the same resulting tree 21:49 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 21:50 < sipa> which is certainly much less worrying 21:50 < achow101> ok. but isn't the point to make sure the tree is the right tree and not some colliding tree? 21:51 < sipa> well a commit object in git is both a resulting tree and a history for it 21:51 < sipa> with this method we're only avoiding SHA1 for the tree 21:52 < achow101> right. 21:56 < achow101> another thought: the client version contains part of the commit hash (at least for master). should that be changed to be the sha256 hash instead? 21:57 < sipa> interesting idea 21:58 < achow101> actually that only happens on builds of master, not any of the releases, so not particularly important 22:06 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving] 22:14 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 22:15 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev 22:17 < wumpus> it's part of the commit id - which is there to be able to look up the right revision for troubleshooting. It's not there for security. Please don't replace it with anything else. 22:18 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 22:19 < achow101> wumpus: ok 22:44 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 22:49 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 22:55 < dcousens> wumpus: true, nevermind 22:59 < dcousens> wumpus: my point for the for loop counter was more as a standard, use of `size_t` is the recommended type for when dealing with indexes... while I totally agree this is suitable as `unsigned int`, it was more of a standard 22:59 < dcousens> (e.g https://stackoverflow.com/questions/1951519/when-should-i-use-stdsize-t) 23:01 < wumpus> it just doesn't matter here 23:02 < dcousens> wumpus: *shrug*, I know, just new code, might as well avoid issues if somehow this gets pulled out later to some generic function blah blah 23:03 < dcousens> not worth discussing any further :) 23:03 < wumpus> this was meant as a quick fix to get an compileissue out of the way 23:03 < wumpus> indeed, no need to drag it out 23:07 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Quit: Lost terminal] 23:08 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev 23:08 < wumpus> whoa, did I still manage to make it fail travis? 23:09 < wumpus> oh the "recursive_mutex.hpp:113: void boost::recursive_mutex::lock(): Assertion `!pthread_mutex_lock(&m)' failed." issue again, unrelated 23:11 < wumpus> I'm in good company, even "move comment" pulls fail 23:11 < dcousens> ha 23:22 < wumpus> looks like there is another intermittent travis issue: timeouts in make check (probably test_bitcoin related too) 23:25 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 23:27 < gmaxwell> test_bitcoin is really slow... 23:28 < wumpus> well it hangs *before* the "N testcases" line... it's not supposed to spend *any* time there 23:29 < wumpus> still haven't managed to catch the test_bitcoin mutex issue, this may be a different symptom of it 23:29 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 23:33 < wumpus> this is making travis as good as useless 23:36 < gmaxwell> maybe we need to start making PRs with most of test_bitcoin commented out? 23:37 < wumpus> the problem is that it happens during initialization, not during run of the tests. So we'd need to be commenting out global variables and such 23:37 < wumpus> bisecting might work, though that's difficult with unrelabile reprodicibility 23:37 < wumpus> e.g. go way back and find the commit where this started 23:38 < wumpus> the funny thing is that #9851 is passing every single time now that I added debug information 23:38 < gribble> https://github.com/bitcoin/bitcoin/issues/9851 | [do not merge] travis gdb parachute for #9825 by laanwj · Pull Request #9851 · bitcoin/bitcoin · GitHub 23:39 < gmaxwell> it fails enough perhaps that just retrying each step 5 times might be enough. 23:39 < wumpus> if that's not a classic example of a heisenbug I don't know 23:39 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 268 seconds] 23:40 < wumpus> it seems to fail in runs, I wonder if it somehow gets cached on a PR 23:40 < wumpus> I suppose that makes sense it it's something the C compiler/ linker does - ccache caches things, which are re-used next time 23:41 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 23:46 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6206252e5073...c7e57ce98154 23:46 < bitcoin-git> bitcoin/master 864890a Russell Yanofsky: [qa] Make import-rescan.py watchonly check reliable... 23:46 < bitcoin-git> bitcoin/master c7e57ce Wladimir J. van der Laan: Merge #9839: [qa] Make import-rescan.py watchonly check reliable... 23:47 < wumpus> if it's really an initialization order fiasco, the root cause for sometimes failing could be randomization in e.g. the linker or compiler with regard to what gets put where 23:52 < wumpus> cfields: is it possible to download a PR's cache remotely?