--- Day changed Mon Feb 27 2017
00:04 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/eddaa6b35d41aefead1a57ea54e7e15ce069f79a
00:04 < bitcoin-git> bitcoin/0.14 eddaa6b Russell Yanofsky: [qa] Make import-rescan.py watchonly check reliable...
00:04 < wumpus> hm no, never mind, I don't think that's going to help at all either...
00:04 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
00:05 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev     
00:09 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds]     
00:21 < bitcoin-git> [bitcoin] laanwj opened pull request #9873: [do not merge] upload test_bitcoin executable for #9825 (master...2017_02_travis_upload) https://github.com/bitcoin/bitcoin/pull/9873
00:28 -!- str4d [~str4d@37.205.56.238] has joined #bitcoin-core-dev     
00:49 -!- paveljanik [~paveljani@14.150.broadband14.iol.cz] has joined #bitcoin-core-dev     
00:49 -!- paveljanik [~paveljani@14.150.broadband14.iol.cz] has quit [Changing host]     
00:49 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev     
00:51 -!- moli_ [~molly@unaffiliated/molly] has quit [Ping timeout: 255 seconds]     
01:13 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Ping timeout: 240 seconds]     
01:14 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 240 seconds]     
01:14 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Ping timeout: 240 seconds]     
01:22 -!- JackH [~laptop@79-73-188-131.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev     
01:27 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev     
01:27 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev     
01:27 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev     
01:29 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev     
01:30 -!- str4d [~str4d@37.205.56.238] has quit [Ping timeout: 240 seconds]     
01:35 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving]     
01:38 -!- str4d [~str4d@37.205.56.238] has joined #bitcoin-core-dev     
01:38 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-roqzqzttcyspcalg] has joined #bitcoin-core-dev     
01:44 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
01:45 < wumpus> awesome, I started debugging #9825 again and all pulls start passing! Start observing and the bug goes away, stop looking and it comes back. The unobserved state is a fog of probabilities, a window of and for error.  *wheee*
01:45 < gribble> https://github.com/bitcoin/bitcoin/issues/9825 | Intermittent FAIL: test/test_bitcoin in Travis · Issue #9825 · bitcoin/bitcoin · GitHub
01:54 -!- str4d [~str4d@37.205.56.238] has quit [Ping timeout: 268 seconds]     
02:01 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Remote host closed the connection]     
02:01 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev     
02:06 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev     
02:10 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds]     
02:33 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #bitcoin-core-dev     
02:34 < Victorsueca> wumpus: it's a quantum bug
02:46 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev     
02:46 < luke-jr> ew, we were using printf for hex strings?
02:50 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds]     
02:53 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds]     
03:06 < wumpus> yes, fairly sure that code is inherited from satoshi
03:18  * luke-jr peers at Travis giving him a restart button that doesn't work
03:18 < luke-jr> can someone restart the two non-passing https://travis-ci.org/bitcoin/bitcoin/builds/205383975 ?
03:18 < luke-jr> I can't see any issue to fix
03:19 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Remote host closed the connection]     
03:23 < wumpus> sure...
03:23 < wumpus> Victorsueca: either that or we need an exorcist
03:24 < wumpus> luke-jr: this doesn't seem the typical issue "test/rpc_tests.cpp(73): error: in "rpc_tests/rpc_rawparams": unexpected exception thrown by CallRPC(std::string("signrawtransaction ")+rawtx)"
03:24 < luke-jr> I can't reproduce it :/
03:25 < Victorsueca> maybe the code is ok and the problem is at travis?
03:25 < wumpus> luke-jr: restarting it...
03:25 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev     
03:26 < wumpus> Victorsueca: it's possible, though that doesn't explain why it always fails in the same (or similar) place
03:27 < Victorsueca> so either the code is bad or travis is using some non-standard compiler that throws shit at the fan when it hits that part
03:27 < luke-jr> hmm, I wonder..
03:29 < wumpus> it should be using stock trusty gcc - but yes it seems some non-determinism/randomization in the compiler is causing a bad test_bitcoin sometimes
03:29 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev     
03:30 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds]     
03:41 < luke-jr> is wallet_tests/rescan really acceptable? it's assigning pwalletMain for a test to a stack variable, and leaving it there?
03:42 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
04:05 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
04:06 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev     
04:07 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds]     
04:09 < wumpus> luke-jr: it'd be cleaner to reset it to NULL at the end of the test. Hopefully, though, that whole nonsense can go away when there's a better way to pass in the wallet via RPC context
04:10 < luke-jr> I wonder if that's the cause - signrawtransaction can use the wallet when available
04:10 < wumpus> but yes any test after that that assumes pwalletMain is set to something will crash or do bad things
04:10 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds]     
04:10 < luke-jr> I just can't reproduce to confirm
04:10 < wumpus> yes, thinking about it - WalletTestingSetup sets up pwalletMain. Setting it to NULL would be bad too, it needs to be restored to its original value?
04:11 < wumpus> yes, you might be on to something
04:12 < wumpus> the next test using the walletMain after that will corrupt
04:12 < wumpus> +the stack
04:16 < bitcoin-git> [bitcoin] laanwj opened pull request #9875: tests: Fix dangling pwalletMain pointer in wallet tests (master...2017_02_wallet_test_dangle) https://github.com/bitcoin/bitcoin/pull/9875
04:30 -!- alpalp [~alpalp@unaffiliated/alpalp] has joined #bitcoin-core-dev     
04:37 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has quit [Remote host closed the connection]     
04:38 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has joined #bitcoin-core-dev     
04:40 < bitcoin-git> [bitcoin] laanwj closed pull request #9875: tests: Fix dangling pwalletMain pointer in wallet tests (master...2017_02_wallet_test_dangle) https://github.com/bitcoin/bitcoin/pull/9875
04:42 < luke-jr> wumpus: so now if we restart that Travis job, it should merge in with that fix and we can tell if that was the issue?
04:43 -!- MarcoFalke [~marco@5.199.182.203] has joined #bitcoin-core-dev     
04:44 < wumpus> yes, will re-trigger after travis finishes on master
04:53 < wumpus> which it did
05:02 < wumpus> luke-jr: still the same issue in your pull, unfortunately: https://travis-ci.org/bitcoin/bitcoin/jobs/205383977#L2475
05:02 < luke-jr> :/     
05:03 < luke-jr> why doesn't it give any details on the exception?
05:04 < wumpus> yes pretty crappy. You could try adding your own catch{} around it temporarily
05:07  * luke-jr ponders why this is mingw-specific
05:15 < wumpus> luke-jr: you'll need to remove the BOOST_CHECK_NO_THROW( too
05:15 < luke-jr> oh     
05:15 < wumpus> otherwise that will catch it for you
05:18 -!- nickler [~nickler@185.12.46.130] has quit [Ping timeout: 240 seconds]     
05:21 -!- nickler [~nickler@185.12.46.130] has joined #bitcoin-core-dev     
05:31 -!- moli_ [~molly@unaffiliated/molly] has quit [Ping timeout: 255 seconds]     
05:32 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
05:33 -!- alpalp [~alpalp@unaffiliated/alpalp] has quit [Read error: Connection reset by peer]     
05:51 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
05:58 -!- moli_ [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds]     
06:03 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
06:15 < bitcoin-git> [bitcoin] jnewbery opened pull request #9876: Remove wildcard imports from qa (master...remove_wildcard_imports) https://github.com/bitcoin/bitcoin/pull/9876
06:17 -!- GreenIsMyPepper [~GreenIsMy@2605:6400:20:11aa:189e:28a5:52ed:8948] has quit [Ping timeout: 240 seconds]     
06:48 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev     
07:02 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev     
07:06 < bitcoin-git> [bitcoin] laanwj closed pull request #9851: [do not merge] travis gdb parachute for #9825 (master...2017_02_travisissue) https://github.com/bitcoin/bitcoin/pull/9851
07:06 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds]     
07:21 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has joined #bitcoin-core-dev     
07:21 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev     
07:24 -!- adiabat [~adiabat@67.205.158.84] has quit [Remote host closed the connection]     
07:25 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds]     
07:30 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev     
07:31 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 268 seconds]     
07:41 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
07:45 -!- moli_ [~molly@unaffiliated/molly] has quit [Ping timeout: 268 seconds]     
07:50 -!- eenoch_ is now known as eenoch     
07:55 -!- adiabat [~adiabat@67.205.158.84] has joined #bitcoin-core-dev     
08:03 -!- abpa [~abpa@107-131-125-191.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev     
08:03 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection]     
08:04 -!- abpa [~abpa@107-131-125-191.lightspeed.sntcca.sbcglobal.net] has quit [Client Quit]     
08:06 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev     
08:17 < morcos> wumpus: i think #9548 has enough ACK's if you want to merge
08:17 < gribble> https://github.com/bitcoin/bitcoin/issues/9548 | Remove min reasonable fee by morcos · Pull Request #9548 · bitcoin/bitcoin · GitHub
08:20 -!- nickler [~nickler@185.12.46.130] has quit [Ping timeout: 240 seconds]     
08:24 -!- nickler [~nickler@185.12.46.130] has joined #bitcoin-core-dev     
08:30 -!- harding [~harding@mail.dtrt.org] has joined #bitcoin-core-dev     
08:32 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev     
08:35 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev     
08:37 < bitcoin-git> [bitcoin] ryanofsky opened pull request #9878: Mention bumpfee in 0.14 release notes. (0.14...pr/bnote) https://github.com/bitcoin/bitcoin/pull/9878
08:52 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev     
09:12 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has quit [Ping timeout: 268 seconds]     
09:17 < luke-jr> wumpus: with the trys added, the same stuff won't fail :|
09:18  * luke-jr puts them before the try <.<
09:27 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has joined #bitcoin-core-dev     
09:36 -!- droark [~droark@c-24-22-123-27.hsd1.or.comcast.net] has quit [Quit: Later.]     
09:40 -!- adiabat [~adiabat@67.205.158.84] has quit [Quit: WeeChat 1.4]     
09:58 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]     
09:58 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection]     
10:09 -!- bsm1175322 [~mcelrath@135.84.167.210] has joined #bitcoin-core-dev     
10:21 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev     
10:29 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 240 seconds]     
10:38 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has quit [Read error: Network is unreachable]     
10:38 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has joined #bitcoin-core-dev     
10:43 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 268 seconds]     
10:59 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev     
11:35 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev     
11:48 < Chris_Stewart_5>  I have a question about partial merkle trees and extracting matches, we have this piece of code inside of 'TraverseAndExtract' https://github.com/bitcoin/bitcoin/blob/master/src/merkleblock.cpp#L121-L125
11:49 < Chris_Stewart_5> however, can't this happen if we have to duplicate a txid to make sure a node has two leaves?
11:52 -!- nickler [~nickler@185.12.46.130] has quit [Ping timeout: 260 seconds]     
11:53 -!- nickler [~nickler@185.12.46.130] has joined #bitcoin-core-dev     
11:56 -!- jnewbery [~Thunderbi@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Read error: Connection reset by peer]     
11:57 < sipa> Chris_Stewart_5: it's exactly designed to test that
11:57 < sipa> duplicate txids in the tree are invalid
12:00 < Chris_Stewart_5> sipa: Ok, and where is that duplicate txid filtered out when building the merkle tree? On this line? https://github.com/bitcoin/bitcoin/blob/master/src/merkleblock.cpp#L81-L82
12:00 < sipa> Chris_Stewart_5: "filtered out"?
12:00 < sipa> Chris_Stewart_5: a block with duplicate txids is invalid in the first place
12:01 < sipa> it can't ever occur in any block we have
12:03 < sipa> by definition such a block would have a double spend
12:03 < Chris_Stewart_5> Yeah, I guess I was getting confused with 'MerkleBlocks' and just merkle tree computations
12:05 < Chris_Stewart_5> and they aren't conceptually the same tree
12:05 < sipa> yes they are...
12:06 < sipa> a MerkleBlock is just the merkle tree of a block with some branches removed
12:07 < sipa> it couldn't prove anything if it wasn't the same tree
12:07 -!- lclc [~lclc@unaffiliated/lclc] has quit [Read error: Connection reset by peer]     
12:08 < Chris_Stewart_5> Ok, help me understand this then. 
12:08 < Chris_Stewart_5> https://github.com/bitcoin/bitcoin/blob/master/src/consensus/merkle.cpp#L14-L18 and the example below it
12:09 < Chris_Stewart_5> would not be serialized as the entire tree when sending it over the network, correct? It would prune the 'rightmost' branch 'f' right?
12:09 < Chris_Stewart_5> and just provide the hash for 'f'
12:09 < sipa> that's about how the merkle root hash is computed
12:09 < sipa> not what is in it
12:09 < sipa> it's illegal for a transaction to be repeated inside a block
12:10 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev     
12:10 < sipa> yet, if there is at any level of the tree an odd number of entries, we duplicate the last one _for the purpose of computing the root_
12:10 < sipa> that case is handled in the else branch of the MerkleBlock code you linked to
12:17 < Chris_Stewart_5> Hmm ok, so if we have a block with 3 txs in it, and we wanted to send a merkle block to a spv node to prove a tx occurred in that block, we wouldn't have to duplicate that 3rd txid to recompute the hash of the parent node? and thus prove to the SPV node the tx occurred? 
12:17 < BlueMatt> most mysterious travis failure ever: https://travis-ci.org/bitcoin/bitcoin/builds/205914634
12:18 < BlueMatt> no log?
12:18 < sipa> Chris_Stewart_5: yes?
12:18 < sipa> Chris_Stewart_5: but you're not duplicating the transaction in the tree
12:18 < sipa> Chris_Stewart_5: you're just duplicating an entry when computing the next level
12:18 < sipa> just read the code
12:19 < sipa> Chris_Stewart_5: https://github.com/bitcoin/bitcoin/blob/master/src/merkleblock.cpp#L119-L128
12:20 < sipa> that if selects whether we're in the normal case, or the 'last entry of an odd-sized level' case
12:20 < sipa> only in the first one we require the two lower level hashes to be different
12:20 < sipa> in the second case there still is only one hash, but we duplicate it for the purpose of computing the parent level
12:20 < Chris_Stewart_5> yeah, that is what i was missing. Thanks. 
12:24 -!- lclc_ [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev     
12:26 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 260 seconds]     
12:33 < luke-jr> wumpus: weird, re-pushing with a new commit-id (no code changes) passes Travis now
12:36 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
13:09 -!- lclc_ [~lclc@unaffiliated/lclc] has quit [Read error: Connection reset by peer]     
13:12 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev     
13:13 < petertodd> dcousens: don't feel bad, it's a very confusing issue; and my apologies if my answers were a bit terse! was trying to get something else done at the same time
13:14 < petertodd> dcousens, sipa: my best advice is to get a copy of the opentimestamps client and run the git integration code with the verbose switch on to see exactly what's happening under the hood
13:14 < sipa> petertodd: i don't think that's useful without reviewing that code myself :)
13:15 < petertodd> sipa: I just mean, it's an implementation of something that hooks into the low-level git signing code, so it's an easy way to see exactly what's being signed
13:16 < sipa> it seems my gpg key (which was created in 2015) used sha1 to sign the subkeys
13:16 < sipa> horror.
13:16 < petertodd> heh, yeah, I think the defaults were changed pretty recently...
13:18 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Read error: Connection reset by peer]     
13:20 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev     
13:23 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Ping timeout: 240 seconds]     
13:24 -!- lclc [~lclc@unaffiliated/lclc] has quit [Ping timeout: 240 seconds]     
13:28 -!- jtimon [~quassel@c-24-4-96-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev     
13:32 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev     
13:35 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/94e5ba9ba290...88c2ae3ed2bb
13:35 < bitcoin-git> bitcoin/master 988ce2d Chris Stewart: Adding 'amount' label to tx_valid/tx_invalid.json files
13:35 < bitcoin-git> bitcoin/master 88c2ae3 MarcoFalke: Merge #9350: [Trivial] Adding label for amount inside of tx_valid/tx_invalid.json...
13:35 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #9350: [Trivial] Adding label for amount inside of tx_valid/tx_invalid.json (master...master) https://github.com/bitcoin/bitcoin/pull/9350
13:42 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
14:02 -!- jnewbery [~Thunderbi@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev     
14:12 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has quit [Quit: Leaving]     
14:20 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt]     
14:30 -!- droark [~droark@c-24-22-123-27.hsd1.or.comcast.net] has joined #bitcoin-core-dev     
14:36 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Remote host closed the connection]     
14:36 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection]     
14:37 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev     
14:43 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds]     
14:49 < dcousens> petertodd: no problem :),  we all got there in the end :)
15:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]     
15:40 -!- MarcoFalke [~marco@5.199.182.203] has left #bitcoin-core-dev []     
15:41 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
15:41 < jeremyrubin> Is anyone else kinds surprised that github didn't have a ready to go sha256 (or whatever) version of git?
15:42 < sipa> what does github have to do with that?
15:42 < sipa> it's perhaps surprising that git itself never prioritized upgrading to a better hash function
15:42 < jeremyrubin> They have a lot of money on git
15:42 < jeremyrubin> it's like a bitcoin company not investing in any core dev ;) 
15:42 < sipa> no     
15:43 < sipa> it's like a bitcoin company not developing their own altcoin
15:43 < dcousens> haha
15:43 < jeremyrubin> Example:
15:43 < jeremyrubin> github could run an internal git chain
15:43 < jeremyrubin> using upgraded hashes
15:43 < dcousens> jeremyrubin: how do you know they don't?
15:43 < sipa> jeremyrubin: you're missing my point
15:43 < dcousens> GitHub is about compatibility with git
15:43 < jeremyrubin> could test it out pushing the broken pdfs :p 
15:44 < sipa> either changing git's hash function is easy, and a fork or branch with support for it would be sponsored, and be available, and they'd use it
15:44 -!- ebfull [~sean@c-107-2-198-133.hsd1.co.comcast.net] has quit [Quit: leaving]     
15:44 < sipa> OR switching the hash function is hard, so nobody has a working version
15:45 < sipa> suggesting that github would do so without compatibility with git itself seems ridiculous
15:46 < jeremyrubin> idk -- I would expect a large fraction of github users could pretty quickly migrate to "git2.0" if github sent them an email detailing the changes
15:46 < jeremyrubin> Maybe I don't use very many tools on top of git
15:46 < sipa> you're literally saying here that github fork their own version of git
15:46 < bsm117532> jeremyrubin: I've been very surprised there doesn't seem to exist a sha2 version of git.  I've thought about writing one myself.  Especially integrating opentimestamps and commit signing...
15:46 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds]     
15:47 < jeremyrubin> sipa:yeah, I think they should. It's not bitcoin :p 
15:47 < sipa> jeremyrubin: I think *git* should support sha2
15:47 < luke-jr> jeremyrubin: to rephrase: you're saying GitHub should stop supporting git ;)
15:47 < jeremyrubin> yeah, but it seems Linus has his head... somewhere
15:47 < cfields> Linus' mail said it's in the works.. does it not exist somewhere?
15:47 < jeremyrubin> They can support both?
15:48 < jeremyrubin> No reason to not have git and gitsha2 available simultaneously.
15:48 < sipa> i think i'd stop using github if they did that
15:48 < dcousens> jeremyrubin: I suppose it depends on how its done... maybe its a soft-fork haha
15:49 < sipa> it would feel like an embrace-and-extend
15:50 < sipa> if they truly felt sha2 is important, and willing to put money on that, they could subsidize or contribute towards sha2 support in git itself... not suddenly switch to an incompatible fork themselves
15:50 < bsm117532> Hey look it's zooko https://lwn.net/Articles/370907/
15:52 < jeremyrubin> I guess I should be more vocal as a customer :p
15:59 < jeremyrubin> emailed github support asking what they're doing :p 
16:01 -!- ensign_ [~ensign@2001:41d0:8:d711::1] has quit [Ping timeout: 245 seconds]     
16:01 -!- Taek42 [~quassel@2001:41d0:1:472e::] has joined #bitcoin-core-dev     
16:02 -!- trotski2000 [sid206086@gateway/web/irccloud.com/x-rdbikfyiuqswvexw] has quit [Ping timeout: 245 seconds]     
16:02 -!- cfields [~quassel@unaffiliated/cfields] has quit [Ping timeout: 245 seconds]     
16:02 -!- nsh [~lol@wikipedia/nsh] has quit [Ping timeout: 245 seconds]     
16:02 -!- Taek [~quassel@2001:41d0:1:472e::] has quit [Ping timeout: 245 seconds]     
16:02 < gmaxwell> I don't know why we're suddenly talking about this in here. Nothing has changed. We knew that sha1 collisions could be constructed with ~2^64 work, and the prefix that google constructed it for can't (AFAIK) be used to trouble git.
16:03 < gmaxwell> If github were to move to a propritary and incompatible version of git from git itself I would urge we drop github immediately.
16:04 -!- trotski2000 [sid206086@gateway/web/irccloud.com/x-irumhxejtzsqbyxp] has joined #bitcoin-core-dev     
16:05 < jeremyrubin> gmaxwell: i would expect it to be FOSS, although it's unclear what you mean by 'propritary'
16:05 -!- cfields [~quassel@unaffiliated/cfields] has joined #bitcoin-core-dev     
16:05 -!- profall [sid29922@gateway/web/irccloud.com/x-kifruxwzscsuhpok] has quit [Ping timeout: 240 seconds]     
16:05 < jeremyrubin> my fault for offtopicing
16:06 < sipa> gmaxwell: even if it was FOSS, it would require them to start maintaining a fork of gut
16:06 < sipa> eh     
16:06 < sipa> jeremyrubin: even if it was FOSS, it would require them to start maintaining a fork of git
16:06 < sipa> something i don't expect them to be remotely capable of (nor should they)
16:07 < jeremyrubin> I thought they already do that? I think I read a while back they have an internal git implementation, could be wrong
16:07 < gmaxwell> It took weeks of nagging just to get them to not display incorrect authorship information on our reposititory recently. Yet that didn't get 1:10th the conversation in here.
16:08 < jeremyrubin> (could be misinformed there, can't find a link)
16:08 < luke-jr> jeremyrubin: not one every user needs; in any case, unless they actually do it, it doesn't matter
16:09 < sipa> jeremyrubin: i'm sure they have some patches
16:09 < sipa> gmaxwell: not as dramatic :)
16:10 < sipa> jeremyrubin: i don't understand why you think _github_ should be doing anything at all, besides sponsoring git development
16:10 < sipa> (which i hope they're already doing)
16:11 -!- ensign_ [~ensign@2001:41d0:8:d711::1] has joined #bitcoin-core-dev     
16:11 -!- nsh [~lol@wikipedia/nsh] has joined #bitcoin-core-dev     
16:13 < bitcoin-git> [bitcoin] jtimon opened pull request #9882: RPC: Introduce -rpcamountdecimals for the RPC to use other units than BTC (master...0.14.99-rpc-amounts) https://github.com/bitcoin/bitcoin/pull/9882
16:13 -!- pindarhk [sid105966@gateway/web/irccloud.com/x-zxnqqxtfcsgjdmgi] has quit [Read error: Connection reset by peer]     
16:13 < bitcoin-git> [bitcoin] jtimon closed pull request #9855: RPC: Use integer satoshis instead BTC with decimals (master...0.15-rpc-satoshis) https://github.com/bitcoin/bitcoin/pull/9855
16:14 -!- pindarhk [sid105966@gateway/web/irccloud.com/x-xiihsjwclhbtxcnf] has joined #bitcoin-core-dev     
16:14 < gmaxwell> it just seems odd to me, we had an actual ongoing exploit of the kind that you'd worry about in the abstract from second preimage attack (much less a hash collision). Yet it could be fixed by some simple action on github's part (not a protocol rework)-- and silence.   Yet it isn't even clear if the kind of common prefix hash collision construction that people know how to do with sha1 could /ever
16:14 < gmaxwell> / be much of an interesting attack beyond perhaps undermining signed commits, and everyone is talking about it... and now there are suggestions of drastic things like total github lock-in.
16:14 < gmaxwell> This seems cultish.
16:14 < gmaxwell> "omg sha1 is broken. we must do something! this is something! it must be done!"
16:15 < jeremyrubin> jfc you're acting like github making a choice implies total github lock in
16:15 < jeremyrubin> precisely, github is free to offer improvements on the code as they see fit
16:16 < sipa> yes, but why github?
16:16 < jeremyrubin> they are a company that offers git based services
16:16 < sipa> and not say, the linux foundation
16:16 < jeremyrubin> the largest one!
16:16 < jeremyrubin> Does linux foundation offer git services? (honestly not sure? support?)
16:17 < sipa> 15:41:32 < jeremyrubin> Is anyone else kinds surprised that github didn't have a ready to go sha256  <-  i find that an incredibly offensive statement
16:17 < jeremyrubin> offensive to who?
16:17 < sipa> it sounds like you're saying "does anyone else think the git maintainers are idiots for ignoring this issue, and that github hasn't decided to fork off"
16:18 < sipa> for something that may never be exploitable
16:19 < BlueMatt> hmmmm, segfault in bitcoin-qt on startup :(
16:19 < jeremyrubin> so it's offensive to... github? or git maintainers?
16:20 < sipa> to me
16:20 < jeremyrubin> Well git is named after a stupid person, so it may be fair to call them idiots :p
16:20 -!- sipa [~pw@unaffiliated/sipa1024] has left #bitcoin-core-dev []     
16:21 < BlueMatt> on a more interesting subject..... https://0bin.net/paste/ECyDDhXzg+BH-92P#NQyXo2b457D6yx+Ezrj+-sVJcLTTFNrk1x36y/avIEA
16:21 < gmaxwell> jeremyrubin: if your question were why hasn't github subbmited some patches upstream to implement it, I would have found it less alarming.  But asking about them switching to an incompatible version? They can barely keep their site running competently. 
16:22 < gmaxwell> were they to do that it would sound a lot like embrace-extend-extinguish.
16:22 -!- sipa [~pw@unaffiliated/sipa1024] has joined #bitcoin-core-dev     
16:22 < jeremyrubin> I don't think I ever once said incompatible 
16:22 < jeremyrubin> you guys keep injecting that
16:22 < BlueMatt> so, sipa, any thoughts on my segfault?
16:23 < BlueMatt> sipa: you missed the link https://0bin.net/paste/ECyDDhXzg+BH-92P#NQyXo2b457D6yx+Ezrj+-sVJcLTTFNrk1x36y/avIEA
16:23 < sipa> jeremyrubin: i'm offended that you're suggesting github create drama where there is no need for concern
16:23 < sipa> anyway, let's drop the topic
16:26 < BlueMatt> ehh, I'll just file an issue
16:26 < sipa> BlueMatt: ugh
16:26 < sipa> thread 10 is the one that crashed?
16:26 < BlueMatt> no, thread 1
16:26 < BlueMatt> somewhere deep in Qt
16:27 < BlueMatt> thread 10 is just mempool re-acceptance, it looks liek
16:27  * BlueMatt has coredump
16:27 < gmaxwell> #2  0x00007fd6b81ee197 in QTableView::setSortingEnabled(bool) () from /usr/lib/libQt5Widgets.so.5
16:27 < gribble> https://github.com/bitcoin/bitcoin/issues/2 | Long-term, safe, store-of-value · Issue #2 · bitcoin/bitcoin · GitHub
16:27 < gmaxwell> #3  0x00005617b3a315ec in TransactionView::setModel (this=0x5617b716bc50, _model=_model@entry=0x5617b6e77530) at qt/transactionview.cpp:205
16:27 < gribble> https://github.com/bitcoin/bitcoin/issues/3 | Encrypt wallet · Issue #3 · bitcoin/bitcoin · GitHub
16:29 < sipa> BlueMatt: no clue about Qt issues
16:30 < gmaxwell> nothing in the immediate backtrace of that crash appears to have been recently changed.
16:31 < gmaxwell> BlueMatt: I assume this is a build on your system? (not a gitian binary)
16:31 < gmaxwell> BlueMatt: if it's 100% reproducable can you bisect it?
16:32 < BlueMatt> gmaxwell: it is not reproduceable, happened once
16:32 < BlueMatt> i can go restart that thing all day and see.......
16:32 < gmaxwell> BlueMatt: maybe try adding a shutdown shorty after start and leave it going in a loop?
16:34 < BlueMatt> well it crashed in the same place on ~ the 4th try
16:34 < BlueMatt> so its not exactly non-reproduceable
16:35 < gmaxwell> BlueMatt: gitian binary or not.
16:36 < BlueMatt> not     
16:36 < BlueMatt> locally-built
16:36 < gmaxwell> can you stick a shutdown right after init completes and see if you can still reproduce it?
16:36 < BlueMatt> lemme see if I can rebuild and still reproduce it first :P
16:37 < gmaxwell> yea, I guess I was also suggesting that.
16:42 < BlueMatt> yes, fresh build crashes in the same way, so thats...good?
16:45 < gmaxwell> The fresh build contains potassium benzoate.
16:52 < BlueMatt> gmaxwell: yay hisenbug :(
16:53 < BlueMatt> yup, just adding a StartShutdown() 30 seconds after start in the middle of the net code appears to fix it
16:54 < cfields> BlueMatt: is there anything in the wallet?
16:55 < BlueMatt> yes, lots 'o things
16:55 < BlueMatt> (nothing unconfirmed, though)
16:58 < BlueMatt> yup, and now even the old binary wont crash
16:58 < BlueMatt> ffs     
17:00 -!- echonaut [~echonaut@46.101.192.134] has quit [Remote host closed the connection]     
17:00 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com]     
17:01 -!- echonaut [~echonaut@46.101.192.134] has joined #bitcoin-core-dev     
17:10 < cfields> BlueMatt: seems likely to me that re-acceptance is advertising a tx early in the startup process, before the TransactionView is fully setup. So I assume you'd need a sufficiently interesting persisted mempool in order to repro.
17:10 < cfields> (catching up, not sure if you guys already looked down that path)
17:11 < BlueMatt> cfields: no one looked down any path
17:11 < BlueMatt> cfields: strange, there is definitely nothing in mempool which applies to that wallet
17:12 < cfields> BlueMatt: still reproducible if you disable mempool loading?
17:13 < cfields> i don't really see where else it'd be coming from, so i assume not
17:13 < BlueMatt> cfields: well it stoped being reproduceable, so maybe mempool dump changed
17:14 < cfields> BlueMatt: right. If you repro again, I'd be sure to make a backup
17:14 < BlueMatt> still, makes no sense as no mempool txn should apply to that wallet
17:14 < BlueMatt> sure
17:15 < cfields> i have no idea what gets blasted around, will try to trace the paths
17:17 -!- dodomojo [~goksinen@2604:2000:c591:8400:6dd0:e9f9:49fd:b4db] has joined #bitcoin-core-dev     
17:24 -!- dodomojo [~goksinen@2604:2000:c591:8400:6dd0:e9f9:49fd:b4db] has quit [Remote host closed the connection]     
17:27 -!- dodomojo [~goksinen@2604:2000:c591:8400:2d5b:5bd0:b471:b4be] has joined #bitcoin-core-dev     
17:28 -!- wudayoda [~goksinen@2604:2000:c591:8400:35dc:7d1d:93e9:ce28] has joined #bitcoin-core-dev     
17:29 -!- CubicEarth [~cubiceart@201.207.165.146] has joined #bitcoin-core-dev     
17:30 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #9884: Add Pieter's old signed commits to revsig-commits (master...2017-02-pieter-revsig) https://github.com/bitcoin/bitcoin/pull/9884
17:30 < BlueMatt> ^ will need to be merged before anything else or travis will barf
17:30 < BlueMatt> well, travis will barf in an obvious way and only on master, so nbd
17:30 < BlueMatt> but will barf
17:33 -!- CubicEarth [~cubiceart@201.207.165.146] has quit [Client Quit]     
17:54 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds]     
18:05 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev     
18:11 -!- profall [sid29922@gateway/web/irccloud.com/x-jtdslbsdvgunpqei] has joined #bitcoin-core-dev     
18:16 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Quit: Leaving.]     
18:19 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
18:42 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds]     
18:53 -!- wudayoda [~goksinen@2604:2000:c591:8400:35dc:7d1d:93e9:ce28] has quit [Read error: No route to host]     
18:54 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-roqzqzttcyspcalg] has quit [Quit: Connection closed for inactivity]     
18:54 -!- wudayoda [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev     
19:16 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
19:18 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 260 seconds]     
19:26 -!- adiabat [~adiabat@67.205.158.84] has joined #bitcoin-core-dev     
19:37 -!- jtimon [~quassel@c-24-4-96-121.hsd1.ca.comcast.net] has quit [Remote host closed the connection]     
20:02 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has quit [Quit: Leaving.]     
20:36 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has quit [Ping timeout: 240 seconds]     
20:41 -!- wudayoda [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Remote host closed the connection]     
20:44 -!- dodomojo [~goksinen@2604:2000:c591:8400:2d5b:5bd0:b471:b4be] has quit [Remote host closed the connection]     
20:54 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has joined #bitcoin-core-dev     
21:02 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has quit [Remote host closed the connection]     
21:03 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has joined #bitcoin-core-dev     
21:07 -!- cyphr_ [~cyphr@2604:2000:de47:6000:449b:8837:c945:cb8c] has joined #bitcoin-core-dev     
21:32 < bitcoin-git> [bitcoin] gmaxwell opened pull request #9886: In feerate ties, prefer larger packages first. (master...prefer_bigger_packages) https://github.com/bitcoin/bitcoin/pull/9886
22:14 -!- lclc [~lclc@unaffiliated/lclc] has joined #bitcoin-core-dev     
22:15 -!- cyphr_ [~cyphr@2604:2000:de47:6000:449b:8837:c945:cb8c] has quit [Ping timeout: 240 seconds]     
22:17 -!- JackH [~laptop@79-73-188-131.dynamic.dsl.as9105.com] has quit [Ping timeout: 260 seconds]     
22:57 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Ping timeout: 240 seconds]     
23:04 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev     
23:15 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Quit: bye]     
23:46 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]