--- Day changed Mon Mar 06 2017 00:04 -!- Kexkey [~kexkey@23.227.207.26] has quit [Ping timeout: 268 seconds] 00:06 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:08 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has quit [Remote host closed the connection] 00:09 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has joined #bitcoin-core-dev 00:11 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 00:12 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 00:13 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 00:18 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 256 seconds] 00:27 -!- cysm [cysm@gateway/shell/elitebnc/x-svfduqvoxzgjgzdw] has quit [Ping timeout: 240 seconds] 00:40 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/01b7cda91684...56ab672b59da 00:40 < bitcoin-git> bitcoin/master 343ba8f practicalswift: [wallet] Remove redundant initialization... 00:40 < bitcoin-git> bitcoin/master 56ab672 Wladimir J. van der Laan: Merge #9576: [wallet] Remove redundant initialization... 00:40 < bitcoin-git> [bitcoin] laanwj closed pull request #9576: [wallet] Remove redundant initialization (master...remove-redundant-initialization-ii) https://github.com/bitcoin/bitcoin/pull/9576 00:57 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has joined #bitcoin-core-dev 01:02 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/56ab672b59da...5a6af3172254 01:02 < bitcoin-git> bitcoin/master e57a1fd Russell Yanofsky: Define 7200 second timestamp window constant 01:02 < bitcoin-git> bitcoin/master 5a6af31 Wladimir J. van der Laan: Merge #9908: Define 7200 second timestamp window constant... 01:02 < bitcoin-git> [bitcoin] laanwj closed pull request #9908: Define 7200 second timestamp window constant (master...pr/timewin) https://github.com/bitcoin/bitcoin/pull/9908 01:04 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5a6af3172254...48c3429c50fb 01:04 < bitcoin-git> bitcoin/master 025dec0 NicolasDorier: [qa] assert_start_raises_init_error 01:04 < bitcoin-git> bitcoin/master 48c3429 Wladimir J. van der Laan: Merge #9832: [qa] assert_start_raises_init_error... 01:05 < bitcoin-git> [bitcoin] laanwj closed pull request #9832: [qa] assert_start_raises_init_error (master...assert_start_raises_init_error) https://github.com/bitcoin/bitcoin/pull/9832 01:06 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/48c3429c50fb...9d5fcbfb0889 01:06 < bitcoin-git> bitcoin/master 99c0e81 John Newbery: Fix BIP68 activation test 01:06 < bitcoin-git> bitcoin/master f5aba8a John Newbery: Move tx version 2 standardness check to after bip68 activation 01:06 < bitcoin-git> bitcoin/master 9d5fcbf Wladimir J. van der Laan: Merge #9739: Fix BIP68 activation test... 01:07 < bitcoin-git> [bitcoin] laanwj closed pull request #9739: Fix BIP68 activation test (master...fixbip68testing) https://github.com/bitcoin/bitcoin/pull/9739 01:08 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9d5fcbfb0889...d32581cc29d1 01:08 < bitcoin-git> bitcoin/master db07f91 practicalswift: Assert that what might look like a possible division by zero is actually unreachable 01:08 < bitcoin-git> bitcoin/master d32581c Wladimir J. van der Laan: Merge #9547: bench: Assert that division by zero is unreachable... 01:08 < bitcoin-git> [bitcoin] laanwj closed pull request #9547: bench: Assert that division by zero is unreachable (master...avoid-potential-division-by-zero-in-benchmark-state-keeprunning) https://github.com/bitcoin/bitcoin/pull/9547 01:16 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 01:18 < bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/d32581cc29d1...fa625b078b01 01:18 < bitcoin-git> bitcoin/master 654e044 Russell Yanofsky: [trivial] Add comment documenting CWalletTx::mapValue 01:18 < bitcoin-git> bitcoin/master a1fe944 Russell Yanofsky: Remove reference to nonexistent "version" wallet transaction mapvalue field... 01:18 < bitcoin-git> bitcoin/master 87ed396 Russell Yanofsky: [trivial] Add comment documenting bumpfee mapValues 01:18 < bitcoin-git> [bitcoin] laanwj closed pull request #9333: Document CWalletTx::mapValue entries and remove erase of nonexistent "version" entry. (master...pr/comment-mapvalue) https://github.com/bitcoin/bitcoin/pull/9333 01:20 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 01:20 -!- cysm [cysm@gateway/shell/elitebnc/x-tkrjdgxorocqnhai] has joined #bitcoin-core-dev 01:34 -!- Victor_sueca is now known as Victorsueca 01:37 < bitcoin-git> [bitcoin] kobake opened pull request #9926: Rename argument name 'data' to prevent shadowing. (master...fix-shadow-warning) https://github.com/bitcoin/bitcoin/pull/9926 01:48 < bitcoin-git> [bitcoin] kobake closed pull request #9926: Rename argument name 'data' to prevent shadowing. (master...fix-shadow-warning) https://github.com/bitcoin/bitcoin/pull/9926 01:48 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 01:53 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 256 seconds] 01:59 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #9256: Fix more CWallet/CWalletDB layer violations (master...2016/12/ref_walletdb) https://github.com/bitcoin/bitcoin/pull/9256 02:04 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 02:06 < wumpus> jonasschnelli: too bade about 9256 :( might pick it up at some point, need to be able to replace the database backend for the cloudabi port 02:07 < jonasschnelli> wumpus: Oh. Okay.. I'm currently working on #8574 (which is also a BDB abstraction). 02:07 < gribble> https://github.com/bitcoin/bitcoin/issues/8574 | [Wallet] refactor CWallet/CWalletDB/CDB by jonasschnelli · Pull Request #8574 · bitcoin/bitcoin · GitHub 02:07 < jonasschnelli> 9256 can be done afterwards.. 02:07 < wumpus> I've noticed that there is a lot of overlap between dbwrapper.h and walletdb.h 02:08 < wumpus> yeah 02:08 < jonasschnelli> Yes. We need clean layering first to support multiple db backends 02:08 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 02:08 < wumpus> I really like the dbwrapper.h. With that I've mangaed to replace the db backend multiple times. Implementing e.g. a walletdb.h for leveldb seemsto be more work 02:09 < wumpus> (as it doesn't wrap some of the objects) 02:09 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #bitcoin-core-dev 02:09 * jonasschnelli looking closer at dbwrapper.h/cpp 02:10 < wumpus> then again - a pure key/value store may not be what we eventually want for the wallet at all, maybe something like sqlite with indexes is better. But on the short term it'd be useful to switch database backends and just consider key/value stores as a given, abstracted. 02:10 < jonasschnelli> Yes. Something like that for the wallet db would be great. I first though CDBEnv follows that approach... but not really 02:11 < wumpus> I think they evolved from the same abstraction, but dbwrapper was updated time and time again to be a better abstraction, while walletdb did not :) 02:11 < jonasschnelli> Sqlite could be useful. I though about it.... but not sure if we want private keys in there.. also not sure about the compatibility between different sqlite implementations.. 02:11 -!- riemann [~riemann@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 02:12 < jonasschnelli> I still like sipa logdb approach (full in-mem mapping, no on-disk database queries, simple append only log with on-going hash) 02:12 < wumpus> sqlite actually encourages usage as an applicatiion data format in their faq 02:13 < wumpus> so I *think* that means they make a commitment to on-disk compatibility. Also their databases are single files, unlike leveldb. 02:14 < wumpus> yes sure I like that too 02:14 < wumpus> in any case, for everything we need to improve the abstractions involved 02:14 < jonasschnelli> For pure transactions and pubkey, I would probably prefere sqlite 02:15 < wumpus> right - and with HD wallets we need a lot less key storage 02:15 < jonasschnelli> Yes. Lets focus on abstraction and discuss the new persistence layer later. 02:15 < wumpus> +private 02:16 < sipa> the abstractions are complicated by the fact that BDB needs some things (flushing, locking, environment, ...) that nothing else needs 02:17 < jonasschnelli> Yes. The abstraction needs to support that (at least for the next years) 02:17 -!- e4xit [~textual@cpc1-cmbg20-2-0-cust188.5-4.cable.virginm.net] has quit [Read error: Connection reset by peer] 02:17 < sipa> no, only until we get rid of BDB 02:17 < sipa> i hope that's less than a few years 02:18 < MarcoFalke> Anyone want to review #9880? 02:18 < gribble> https://github.com/bitcoin/bitcoin/issues/9880 | Verify Tree-SHA512s in merge commits, enforce sigs are not SHA1 by TheBlueMatt · Pull Request #9880 · bitcoin/bitcoin · GitHub 02:18 < jonasschnelli> hmm.. if we offer a good migration option,... but the migration option needs BDB support... :) 02:18 < MarcoFalke> Currently only wumpus can merge on master 02:18 < sipa> jonasschnelli: that can just be a trivial "iterate the keys, convert" - not a full db abstraction 02:18 < jonasschnelli> sipa: Indeed 02:22 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 02:23 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 02:34 < jonasschnelli> wumpus, sipa: if you care for wallet db abstraction, this (#8574) could be reviewed: 02:34 < gribble> https://github.com/bitcoin/bitcoin/issues/8574 | [Wallet] refactor CWallet/CWalletDB/CDB by jonasschnelli · Pull Request #8574 · bitcoin/bitcoin · GitHub 02:38 -!- MarcoFalke [~marco@host10-2.natpool.mwn.de] has quit [Quit: MarcoFalke] 02:41 -!- BirneGetreide_ [8af6020a@gateway/web/cgi-irc/kiwiirc.com/ip.138.246.2.10] has joined #bitcoin-core-dev 02:44 < jonasschnelli> MarcoFalke: Oh. Yes. My merged broke verify-commits (and therefor travis on master): https://travis-ci.org/bitcoin/bitcoin/jobs/206917518#L513 02:51 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 02:53 -!- gK-1wm-su [~jircii@46.22.220.25] has joined #bitcoin-core-dev 02:55 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 256 seconds] 02:55 -!- gK-1wm-su [~jircii@46.22.220.25] has quit [Excess Flood] 03:00 < wumpus> jonasschnelli: I'll take a look. On the short run I just need something that can replace berkeleydb with a different k/v store, no need for any backward compatiblity or migration 03:01 < jonasschnelli> Thanks. Yes. That's a different path then... 03:04 < wumpus> jonasschnelli: not using a database or a custom database would be fine too, but that seems like a lot more work :) 03:04 < wumpus> and would require a huge patch set to maintain on top 03:06 < wumpus> which would need to be updated for every upstream wallet change 03:06 < wumpus> so yeah, switching the k/v store is probably the best option 03:12 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 03:13 < Victorsueca> I just had a question this morning while at was at shower... Is it safe to defrag while bitcoin core is running? 03:14 < wumpus> defrag? is that still a thing? 03:14 < BirneGetreide_> Just don't defrag, ever. It is a waste of time 03:15 < jonasschnelli> Oh... verify-commits.sh gave a "Segmentation fault: 11"! hah 03:16 < jonasschnelli> I hope it's not coming from gnupg 03:16 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 256 seconds] 03:17 -!- BirneGetreide_ [8af6020a@gateway/web/cgi-irc/kiwiirc.com/ip.138.246.2.10] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client] 03:17 < wumpus> but no, we can't guarantee that that is safe. Moving filesystem blocks in the background could be safe or unsafe depending on whether the OS keeps track of things properly. 03:19 < Victorsueca> it's windows so I doubt it does lol 03:25 -!- BirneGetreide_ [8af6020a@gateway/web/cgi-irc/kiwiirc.com/ip.138.246.2.10] has joined #bitcoin-core-dev 03:29 < wumpus> right, you didn't even need to ask 03:32 -!- MarcoFalke [~none@198.12.116.246] has joined #bitcoin-core-dev 03:34 -!- MarcoFalke [~none@198.12.116.246] has left #bitcoin-core-dev [] 03:34 -!- MarcoFalke [~none@198.12.116.246] has joined #bitcoin-core-dev 03:35 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 03:35 -!- MarcoFalke [~none@198.12.116.246] has quit [Read error: Connection reset by peer] 03:36 -!- MarcoFalke_ [~none@198.12.116.246] has joined #bitcoin-core-dev 03:36 -!- MarcoFalke_ is now known as MarcoFalke 03:37 -!- BirneGetreide_ [8af6020a@gateway/web/cgi-irc/kiwiirc.com/ip.138.246.2.10] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client] 03:43 < jonasschnelli> Hmm... I think the verify-commit.sh segfault 11 im getting is from /bin/sh 03:43 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 03:44 < jonasschnelli> It happens when the script calls IS_SIGNED() (recursive call) 03:44 < jonasschnelli> Happens on master was well... 03:48 < wumpus> ugh :/ 03:48 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 256 seconds] 03:50 < jonasschnelli> Can't even attach lldb to /bin/sh due to OSX's "integrity protection"... copied out sh and running now in lldb 03:51 < sipa> too many recursion levels in the shell? 03:52 < jonasschnelli> sipa: I think so. 03:52 < jonasschnelli> Stack trace: http://bitcoin.jonasschnelli.ch/st.txt 03:53 < jonasschnelli> now running in bash 03:54 < jonasschnelli> same 03:57 < jonasschnelli> I think some Ubuntu verions are also affected. http://lists.gnu.org/archive/html/bug-bash/2003-12/msg00007.html 03:58 < jonasschnelli> Would it make sense to port verify-commits.sh to python? We already rely on python for the rest, right? ping BlueMatt 03:59 < jonasschnelli> BlueMatt: it seems that the current amount of recursive calls on IS_SIGNED() seems to break some shell implementations (OSX 10.11 and I think also Ubuntu 14.04) 04:06 < wumpus> can we somehow make verify-commits.sh simpler, at least temporary? 04:06 < wumpus> e.g. do the most important check that the HEAD commit is signed, but no more, that shouldn't take any recursion 04:06 < wumpus> then after the script is fixed we can go back to the more comphrehensive one 04:18 -!- To7 [~theo@cpe-158-222-192-214.nyc.res.rr.com] has quit [Quit: Whatever] 04:19 < jonasschnelli> wumpus: Yes. That's probably a good idea... maybe we add an arg and by default, it just checks the head 04:38 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #9928: Allow verify-commit.sh to just verify the HEAD commit (Use non-recursive verification by default) (master...2017/03/vc_simple) https://github.com/bitcoin/bitcoin/pull/9928 04:38 -!- norotartagen [~norotarta@71-89-76-184.dhcp.bycy.mi.charter.com] has quit [Read error: Connection reset by peer] 04:48 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 04:52 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 256 seconds] 05:16 -!- To7 [~theo@cpe-158-222-192-214.nyc.res.rr.com] has joined #bitcoin-core-dev 05:17 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:19 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has quit [Remote host closed the connection] 05:20 -!- d9b4bef9 [~d9b4bef9@web419.webfaction.com] has joined #bitcoin-core-dev 05:20 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 05:24 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 240 seconds] 05:24 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 256 seconds] 05:26 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fa625b078b01...8a3b07529d9c 05:26 < bitcoin-git> bitcoin/master 7184e25 Jonas Schnelli: [Wallet] refactor CWallet/CWalletDB/CDB... 05:26 < bitcoin-git> bitcoin/master 8a3b075 Wladimir J. van der Laan: Merge #8574: [Wallet] refactor CWallet/CWalletDB/CDB... 05:26 < bitcoin-git> [bitcoin] laanwj closed pull request #8574: [Wallet] refactor CWallet/CWalletDB/CDB (master...2016/08/bdb_abstraction_2) https://github.com/bitcoin/bitcoin/pull/8574 05:26 -!- nanotube [~nanotube@unaffiliated/nanotube] has quit [Ping timeout: 258 seconds] 05:35 -!- nanotube [~nanotube@unaffiliated/nanotube] has joined #bitcoin-core-dev 05:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 05:39 -!- jcorgan [~jcorgan@unaffiliated/jcorgan] has quit [Quit: ZNC - 1.6.0 - http://znc.in] 05:41 -!- jcorgan [~jcorgan@unaffiliated/jcorgan] has joined #bitcoin-core-dev 05:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:52 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 05:56 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 256 seconds] 06:12 -!- Kexkey_ [~kexkey@23.227.207.26] has joined #bitcoin-core-dev 06:13 < wumpus> going to have a stab at making the RPC tests run (optionally) through UNIX sockets 06:14 < wumpus> don't think much is needed besides abstracting 'url' into 'RPC connect info' 06:29 < jonasschnelli> wumpus: haven't thought about the RPC test... great idea. 06:44 < wumpus> jonasschnelli: yep it provides an example on how to use RPC over UNIX sockets in python at the same time 06:55 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 06:55 < bitcoin-git> [bitcoin] laanwj opened pull request #9929: tests: Delete unused function _rpchost_to_args (master...2017_03_tests_unused) https://github.com/bitcoin/bitcoin/pull/9929 06:57 -!- jtimon [~quassel@70.30.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 06:59 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 256 seconds] 07:06 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 07:12 -!- JackH [~laptop@79-73-184-8.dynamic.dsl.as9105.com] has quit [Ping timeout: 258 seconds] 07:13 -!- JackH [~laptop@79-73-184-8.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev 07:17 -!- chris2000 [~chris2000@195.65.142.16] has joined #bitcoin-core-dev 07:22 -!- nemgun [~nemgun@105.99.39.169] has quit [Quit: Leaving] 07:27 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 07:29 < BlueMatt> jonasschnelli: if you want to feel free, but I wont be able to maintain it anymore :P 07:31 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 256 seconds] 07:34 < wumpus> many of us have the same problem with shellscript :p 07:34 -!- JackH [~laptop@79-73-184-8.dynamic.dsl.as9105.com] has quit [Ping timeout: 240 seconds] 07:34 < wumpus> but I don't care what language it is in, it just needs to work 07:36 -!- JackH [~laptop@85.255.233.212] has joined #bitcoin-core-dev 07:38 < wumpus> nesting recursion too deep is a problem in any language 07:39 < BlueMatt> yea, i should have removed the recursion when i made it not ever look at the second parent 07:39 < BlueMatt> should be trivial to do 07:41 -!- JackH [~laptop@85.255.233.212] has quit [Ping timeout: 240 seconds] 07:42 < bitcoin-git> [bitcoin] laanwj closed pull request #9924: [UI Styling] Left-Align Tab Bar - optionsdialog.ui (master...patch-1) https://github.com/bitcoin/bitcoin/pull/9924 07:42 < bitcoin-git> [bitcoin] laanwj closed pull request #9925: [UI Styling] Left-Align Tab Bar - debugwindow.ui (master...patch-2) https://github.com/bitcoin/bitcoin/pull/9925 07:55 -!- JackH [~laptop@79-73-184-8.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev 07:55 -!- bityogi [~textual@208-104-132-26.brvd.dsl.dyn.comporium.net] has joined #bitcoin-core-dev 08:11 -!- fengling [~fengling@223.223.187.142] has quit [Ping timeout: 252 seconds] 08:14 -!- fengling [~fengling@223.223.187.142] has joined #bitcoin-core-dev 08:19 -!- xiangfu [~xiangfu@223.223.187.142] has quit [Ping timeout: 246 seconds] 08:19 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 08:19 -!- xiangfu [~xiangfu@223.223.187.142] has joined #bitcoin-core-dev 08:19 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 08:20 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 08:20 < bitcoin-git> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/8a3b07529d9c...4df8213b98d3 08:20 < bitcoin-git> bitcoin/master be908a6 Matt Corallo: Fail merge if there are any symlinks 08:20 < bitcoin-git> bitcoin/master d9c450f Matt Corallo: Verify Tree-SHA512s in merge commits, enforce sigs are not SHA1 08:20 < bitcoin-git> bitcoin/master eddc77a Peter Todd: Add comment re: why SHA1 is disabled 08:20 < bitcoin-git> [bitcoin] laanwj closed pull request #9880: Verify Tree-SHA512s in merge commits, enforce sigs are not SHA1 (master...2017-02-validate-sha512) https://github.com/bitcoin/bitcoin/pull/9880 08:24 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 246 seconds] 08:24 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 256 seconds] 08:26 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 08:27 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 08:28 -!- riemann [~riemann@84-10-11-234.static.chello.pl] has quit [Quit: Leaving] 08:30 < BlueMatt> god damn it, how did it fail on head 08:40 -!- xiangfu [~xiangfu@223.223.187.142] has quit [Ping timeout: 268 seconds] 08:40 -!- xiangfu [~xiangfu@223.223.187.142] has joined #bitcoin-core-dev 08:41 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds] 08:43 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 08:47 -!- n1ce [~n1ce@unaffiliated/n1ce] has quit [Remote host closed the connection] 08:48 < BlueMatt> grrrr it doesnt fail locally 08:48 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 08:49 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 08:49 -!- n1ce [~n1ce@unaffiliated/n1ce] has joined #bitcoin-core-dev 08:53 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 08:58 < bitcoin-git> [bitcoin] matthias-g opened pull request #9930: Trivial: Correct indentation (master...fix-indent) https://github.com/bitcoin/bitcoin/pull/9930 09:06 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4df8213b98d3...c78adbf450be 09:06 < bitcoin-git> bitcoin/master b23dcd2 John Newbery: Fix segwit getblocktemplate test. 09:06 < bitcoin-git> bitcoin/master c78adbf Wladimir J. van der Laan: Merge #9843: Fix segwit getblocktemplate test... 09:06 < bitcoin-git> [bitcoin] laanwj closed pull request #9843: Fix segwit getblocktemplate test (master...fixsegwitgetblocktemplate) https://github.com/bitcoin/bitcoin/pull/9843 09:13 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 09:13 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 09:13 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 09:18 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 256 seconds] 09:33 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c78adbf450be...d5ce14e22338 09:33 < bitcoin-git> bitcoin/master 99fecf8 Wladimir J. van der Laan: tests: Delete unused function _rpchost_to_args... 09:33 < bitcoin-git> bitcoin/master d5ce14e Wladimir J. van der Laan: Merge #9929: tests: Delete unused function _rpchost_to_args... 09:33 < bitcoin-git> [bitcoin] laanwj closed pull request #9929: tests: Delete unused function _rpchost_to_args (master...2017_03_tests_unused) https://github.com/bitcoin/bitcoin/pull/9929 09:33 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d5ce14e22338...72fb5158b1c8 09:33 < bitcoin-git> bitcoin/master 188f89c Gregory Sanders: Disallow copy of CReserveKeys 09:33 < bitcoin-git> bitcoin/master 72fb515 Wladimir J. van der Laan: Merge #9906: Disallow copy constructor CReserveKeys... 09:34 < bitcoin-git> [bitcoin] laanwj closed pull request #9906: Disallow copy constructor CReserveKeys (master...noreservecopy) https://github.com/bitcoin/bitcoin/pull/9906 09:35 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 09:36 < morcos> Call for another set of eyes on #9602.. I think it has enough technical review now, but couldn't hurt to have some more people review the open questions in the PR message and make sure they are ok with the changes made. 09:36 < gribble> https://github.com/bitcoin/bitcoin/issues/9602 | Remove coin age priority and free transactions - implementation by morcos · Pull Request #9602 · bitcoin/bitcoin · GitHub 09:36 < morcos> And then lets get it merged please 09:36 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 09:41 -!- chris2000 [~chris2000@195.65.142.16] has quit [] 09:52 -!- shesek [~shesek@bzq-84-110-54-251.red.bezeqint.net] has quit [Read error: Connection reset by peer] 09:54 < gmaxwell> wumpus: for the unix domain socket bitcoin-cli, could you have the client behind an actual feature test? so that when the user's libevent is upgraded it starts working? 09:56 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 09:58 < wumpus> gmaxwell: once my patch lands in mainline libevent, it can be enabled based on the libevent version 09:58 < wumpus> currently there is no way to detect whether libevent can do it or not 10:00 < wumpus> if it takes a long time to be included in libevent we could add the patch to depends so that the released binaries will have it 10:01 < wumpus> can always decide on that when the 0.15 release gets close and it's still uncertain 10:02 -!- norotartagen [~norotarta@71-89-76-184.dhcp.bycy.mi.charter.com] has joined #bitcoin-core-dev 10:02 < gmaxwell> has the libevent people given any feedback suggesting if they're likely to accept the change or not? 10:02 < wumpus> nope 10:02 < gmaxwell> might be good to get that, if they wont we might want a different approach. :( 10:03 < gmaxwell> (than potentially carrying a patch with release binaries forever) 10:03 < wumpus> well it's still useful even without the client change 10:03 < wumpus> and there is no other approach to support it in bitcoin-cli anyhow 10:03 < BlueMatt> anyone able to reproduce the travis master fail? 10:03 < BlueMatt> verify-commits is failing again but not locally anymore 10:04 < wumpus> not that I know of, at least, maybe libevent people could suggest something, butI haven't had feedback on it at all 10:04 < gmaxwell> BlueMatt: verify commits is failing for me on the 0.14 branch, I haven't checked master today. 10:04 < wumpus> gmaxwell: wow that's depressing :/ 10:04 < wumpus> they've had, what, two days including a sunday to respond, I wouldn't worry about "carrying a patch forever" yet 10:05 < BlueMatt> oh wut? 10:06 < wumpus> on 0.14 it should pass now 10:06 < BlueMatt> well it should pass on master too 10:06 < BlueMatt> did it succeed on 0.14 on travis? 10:07 < wumpus> yes I think so 10:07 < BlueMatt> yes, it did 10:30 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 10:35 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 256 seconds] 10:39 -!- shesek [~shesek@bzq-84-110-234-246.red.bezeqint.net] has joined #bitcoin-core-dev 10:40 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Remote host closed the connection] 10:40 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 10:42 -!- jcorgan [~jcorgan@unaffiliated/jcorgan] has quit [Quit: ZNC - 1.6.0 - http://znc.in] 10:44 -!- jcorgan [~jcorgan@unaffiliated/jcorgan] has joined #bitcoin-core-dev 10:45 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Ping timeout: 256 seconds] 10:59 < BlueMatt> hmmm, MarcoFalke i cant reproduce your Tree-SHA512 from https://github.com/bitcoin/bitcoin/commit/f7ec7cfd38b543ba81ac7bed5b77f9a19739460b 10:59 < BlueMatt> i didnt try the python code, but the bash-based snippet doesnt work here 11:03 < wumpus> verify-commits.sh passes on master here, locally 11:05 < BlueMatt> found the issue...needs gpg 2.1 to pass --weak-digest 11:06 < BlueMatt> also the above tree-sha512 issue 11:07 < wumpus> can't reproduce that one either,tree_sha512sum() gives dc5cf61d226a16a77f32fab8abc18fd469dfe8bda59a2cb8f9eca3a60e474f180dec4fa59bb3fee86efa0e123ba8c198c7efe76bfdaa2518f4169ab0849f6694 11:07 < BlueMatt> yea, that looks like what i (and verify-commits) gets 11:07 < wumpus> it's not causing verify-commits.sh to fail here though 11:08 < BlueMatt> you have to run verify-commits with --tree-checks 11:08 < BlueMatt> (because its slowwwww) 11:08 < BlueMatt> next pr will fix all above issues, and also I think i should do --tree-checks but only for top commit 11:08 < BlueMatt> so that travis will catch this 11:08 < BlueMatt> but not for more because otherwise travis would take hours by the time we get to 0.15 11:09 < wumpus> I agree, we should avoid making the check slower 11:09 < wumpus> checking just the top commit or top two commits thoroughly should be enough, travis runs often enough 11:09 -!- droark [~droark@c-24-22-123-27.hsd1.or.comcast.net] has quit [Quit: ZZZzzz…] 11:10 < BlueMatt> yes 11:10 < BlueMatt> it should run every commit, no? 11:10 < BlueMatt> we might see it fail hours later, but at least it runs for each one 11:11 < wumpus> I don't think that's guaranteed. It runs every time it sees a new push 11:12 < BlueMatt> ahh, yes, race 11:12 < wumpus> which usually means it runs for every top-level commit as the merge script pushes them one at a time, but still 11:13 < wumpus> what is it with all those people reporting Ekiga build problems in our issue tracker 11:13 < sipa> ekiga? 11:13 < wumpus> apparently some VOIP program 11:14 < sipa> and what are they reporting? i haven't seen that 11:14 < wumpus> https://github.com/bitcoin/bitcoin/issues/3219#issuecomment-284464031 11:14 < wumpus> I first didn't notice they were talking about a different application 11:15 < gwillen> well, one person happened to get a match on the text of the error message 11:15 < sipa> hah 11:15 < BlueMatt> wtf 11:15 < wumpus> in any case, configure arguments suggestions port very badly between different applications 11:15 < gwillen> then google indexed the word 'ekiga' when they said it, and now everyone's getting linked to this bug when they google 'ekiga' and the error message :-) 11:15 < wumpus> lol that must be it 11:16 < gwillen> indeed, I just checked, that bug is the first hit for the error, and the second hit for 'ekiga' plus the error text. 11:17 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 11:22 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 256 seconds] 11:52 -!- dodomojo [~goksinen@2604:2000:c591:8400:389f:71dc:d9c9:d96d] has joined #bitcoin-core-dev 11:56 -!- dodomojo [~goksinen@2604:2000:c591:8400:389f:71dc:d9c9:d96d] has quit [Ping timeout: 246 seconds] 11:59 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 12:00 -!- molz_ [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 12:14 -!- dodomojo [~goksinen@2604:2000:c591:8400:389f:71dc:d9c9:d96d] has joined #bitcoin-core-dev 12:16 -!- dodomojo_ [~goksinen@2604:2000:c591:8400:18eb:17a1:6e5b:8675] has joined #bitcoin-core-dev 12:19 -!- dodomojo [~goksinen@2604:2000:c591:8400:389f:71dc:d9c9:d96d] has quit [Ping timeout: 246 seconds] 12:21 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 12:22 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev 12:24 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Read error: Connection reset by peer] 12:24 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev 12:25 -!- dodomojo_ [~goksinen@2604:2000:c591:8400:18eb:17a1:6e5b:8675] has quit [Ping timeout: 246 seconds] 12:25 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 256 seconds] 12:35 < BlueMatt> wumpus: i cant verify your latest sha512 either 12:39 < wumpus> sigh :/ 12:40 < wumpus> is it possible that the order is not deterministic? 12:40 < BlueMatt> hmmm, now I'm confused 12:40 < BlueMatt> i doubt it? 12:41 < wumpus> is it hashing any files which are not part of git, but linger around in the directory? 12:41 < BlueMatt> hmm, maybe I'm wrong, maybe your hash is right 12:41 < BlueMatt> cant tell from terminal history anymore :( 12:41 < wumpus> I'll check in a minute, after I push my tree 12:46 -!- jnewbery [~Thunderbi@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Read error: Connection reset by peer] 12:47 < wumpus> for me it matches 12:47 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Read error: Connection reset by peer] 12:48 < wumpus> (using the python code, output is e55ce10bf7f2dc91de9797e60ab7767fb51f25255995d62ddf358c52b7aaa23c26fbfb522e1610ff950b86804ddbc38dc0d7708bfab2c4d33ad99a275d8c77db, which matches what is in the merge commit) 12:48 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev 12:49 < wumpus> "git ls-tree --full-tree -r --name-only HEAD | LANG=C sort | xargs -n 1 sha512sum | sha512sum" gives the same output 12:49 < BlueMatt> yea, heisenbug 12:49 < BlueMatt> travis is failing on it but i cant find it 12:53 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Read error: Connection reset by peer] 12:53 -!- dodomojo [~goksinen@2604:2000:c591:8400:e913:7012:642a:71a5] has joined #bitcoin-core-dev 12:55 -!- dodomojo_ [~goksinen@2604:2000:c591:8400:449d:2137:95d3:7b02] has joined #bitcoin-core-dev 12:58 -!- dodomojo [~goksinen@2604:2000:c591:8400:e913:7012:642a:71a5] has quit [Ping timeout: 246 seconds] 13:12 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 13:15 < BlueMatt> wumpus: yes, sipa meant to say LC_ALL when he said LANG (according to the sort man page) 13:17 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 256 seconds] 13:25 < sipa> i thought i meant to say C, but maybe i thought wrong about what i meant 13:25 < BlueMatt> sipa: no, you have to set LC_ALL=C, not LANG=C 13:25 -!- droark [~droark@c-24-22-123-27.hsd1.or.comcast.net] has joined #bitcoin-core-dev 13:28 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Remote host closed the connection] 13:29 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev 13:34 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #9932: Fix verify-commits on travis and always check top commit's tree (master...2017-03-fix-verify-commits) https://github.com/bitcoin/bitcoin/pull/9932 13:35 < sipa> BlueMatt: ahh! 13:38 < wumpus> whoops, yes, stupid locales :/ 13:39 < BlueMatt> why travis has a different locale is beside me 13:39 < wumpus> the python version in github-merge.py shouldn't be affected 13:40 < wumpus> no idea what locale it sets, but it helped find this issue 13:41 < wumpus> which I suppose is good 13:41 < BlueMatt> fair 13:52 -!- jnewbery [~Thunderbi@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 13:53 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 14:05 < bitcoin-git> [bitcoin] jtimon closed pull request #9882: RPC: Introduce -rpcamountdecimals for the RPC to use other units than BTC (master...0.14.99-rpc-amounts) https://github.com/bitcoin/bitcoin/pull/9882 14:06 < jtimon> ping #9279 14:06 < gribble> https://github.com/bitcoin/bitcoin/issues/9279 | Consensus: Move CFeeRate out of libconsensus by jtimon · Pull Request #9279 · bitcoin/bitcoin · GitHub 14:15 -!- juscamarena [~justin@47.148.176.74] has quit [Remote host closed the connection] 14:17 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 14:21 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 256 seconds] 14:22 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 246 seconds] 14:35 -!- pedrobranco [~pedrobran@2001:8a0:ff62:a601:e80c:e7e9:2290:97] has joined #bitcoin-core-dev 14:39 -!- pedrobranco [~pedrobran@2001:8a0:ff62:a601:e80c:e7e9:2290:97] has quit [Ping timeout: 258 seconds] 14:48 -!- cryptapus_afk is now known as cryptapus 14:48 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Quit: conversation terminated!] 14:54 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 14:55 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has quit [Quit: Leaving] 15:00 -!- cryptapus [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev 15:00 -!- cryptapus [~cryptapus@jupiter.osmus.org] has quit [Changing host] 15:00 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 15:06 -!- cryptapus is now known as cryptapus_afk 15:47 -!- jnewbery [~Thunderbi@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Quit: jnewbery] 15:48 -!- bityogi [~textual@208-104-132-26.brvd.dsl.dyn.comporium.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 16:03 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has joined #bitcoin-core-dev 16:06 -!- dodomojo [~goksinen@cpe-74-71-4-175.nyc.res.rr.com] has quit [Read error: Connection reset by peer] 16:06 -!- dodomojo [~goksinen@2604:2000:c591:8400:4882:7427:e107:110f] has joined #bitcoin-core-dev 16:07 -!- dodomojo_ [~goksinen@2604:2000:c591:8400:449d:2137:95d3:7b02] has quit [Ping timeout: 258 seconds] 16:18 -!- handlex [~handlex@2804:14c:658f:4dc7:ed50:93b1:5611:a4d3] has joined #bitcoin-core-dev 16:24 -!- pedrobranco [~pedrobran@2001:8a0:ff62:a601:e80c:e7e9:2290:97] has joined #bitcoin-core-dev 16:27 -!- handlex [~handlex@2804:14c:658f:4dc7:ed50:93b1:5611:a4d3] has quit [Quit: handlex] 16:28 -!- pedrobranco [~pedrobran@2001:8a0:ff62:a601:e80c:e7e9:2290:97] has quit [Ping timeout: 256 seconds] 16:33 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/72fb5158b1c8...19be26afe3d0 16:33 < bitcoin-git> bitcoin/master 8455e36 practicalswift: [test] Avoid reading a potentially uninitialized variable in tx_invalid-test... 16:33 < bitcoin-git> bitcoin/master 19be26a MarcoFalke: Merge #9555: [test] Avoid reading a potentially uninitialized variable in tx_invalid-test (transaction_tests.cpp)... 16:33 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #9555: [test] Avoid reading a potentially uninitialized variable in tx_invalid-test (transaction_tests.cpp) (master...avoid-ub-in-tx_invalid-test) https://github.com/bitcoin/bitcoin/pull/9555 16:43 -!- instagibbs [~instagibb@pool-100-15-117-236.washdc.fios.verizon.net] has joined #bitcoin-core-dev 16:49 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 16:50 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 16:50 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 16:59 -!- abpa [~abpa@96-82-80-25-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 17:36 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Quit: WeeChat 0.4.2] 17:43 -!- warren [~warren@fedora/wombat/warren] has joined #bitcoin-core-dev 17:47 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds] 17:48 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 18:01 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 18:19 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 268 seconds] 18:24 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has quit [Quit: Leaving.] 18:33 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 18:40 -!- jrayhawk_ is now known as jrayhawk 18:42 -!- yujiwei [18066830@gateway/web/freenode/ip.24.6.104.48] has joined #bitcoin-core-dev 18:43 -!- yujiwei [18066830@gateway/web/freenode/ip.24.6.104.48] has left #bitcoin-core-dev [] 18:57 -!- CubicEarth [~cubiceart@200.46.122.2] has joined #bitcoin-core-dev 19:04 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-ddidnyxipqlqridq] has quit [Quit: Connection closed for inactivity] 19:04 < gmaxwell> dear god, UIs are hard. 19:04 < gmaxwell> 19:02 < pawn> gmaxwell: I have the new version. I opened the console. I ran dumpwallet, and it's not giving anything back to me. I passed wallet.dat and /Users/pawn/Library/Application\ Support/Bitcoin/wallet.dat as an argument. 19:05 -!- jtimon [~quassel@70.30.134.37.dynamic.jazztel.es] has quit [Ping timeout: 256 seconds] 19:05 < sipa> :'( 19:05 < gmaxwell> I had him back up first. 19:11 < gwillen> that is ... not a failure mode I ever would have thought of. Users find very creative ways to hurt themselves. I'm glad you had him back up. 19:18 < gmaxwell> saw things similar prior. (button for a most common symbol in my words isn't working) 19:21 -!- CubicEarth [~cubiceart@200.46.122.2] has quit [] 19:43 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 19:48 -!- wudayoda [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 256 seconds] 20:01 -!- pedrobranco [~pedrobran@2001:8a0:ff62:a601:e80c:e7e9:2290:97] has joined #bitcoin-core-dev 20:04 -!- dodomojo [~goksinen@2604:2000:c591:8400:4882:7427:e107:110f] has quit [Remote host closed the connection] 20:06 -!- pedrobranco [~pedrobran@2001:8a0:ff62:a601:e80c:e7e9:2290:97] has quit [Ping timeout: 256 seconds] 20:38 < achow101> Does anyone else have a compiler warning for wallet/db.cpp:620? 20:46 < phantomcircuit> achow101, compiler warnings are hard to reproduce because they all have different ideas of what to warn about 20:58 < gmaxwell> achow101: whats the warning? 20:58 < gmaxwell> if it's a shadow warning, mention it on #9911 20:58 < gribble> https://github.com/bitcoin/bitcoin/issues/9911 | Wshadow: various gcc fixes by paveljanik · Pull Request #9911 · bitcoin/bitcoin · GitHub 21:00 -!- ircfreak [~ircfreak@x55b33c71.dyn.telefonica.de] has joined #bitcoin-core-dev 21:01 < achow101> it is a shadow warning 21:02 < achow101> looks like paveljanik already got it and fixed it 21:11 -!- ircfreak [~ircfreak@x55b33c71.dyn.telefonica.de] has quit [] 21:26 -!- adiabat [~adiabat@67.205.158.84] has quit [Ping timeout: 240 seconds] 21:30 -!- adiabat [~adiabat@67.205.158.84] has joined #bitcoin-core-dev 21:50 < paveljanik> yup :-) 22:33 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 264 seconds] 22:34 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev 22:41 -!- pedrobranco [~pedrobran@2001:8a0:ff62:a601:e80c:e7e9:2290:97] has joined #bitcoin-core-dev 22:46 -!- pedrobranco [~pedrobran@2001:8a0:ff62:a601:e80c:e7e9:2290:97] has quit [Ping timeout: 256 seconds] 23:28 -!- phantomcircuit [~phantomci@192.241.205.97] has quit [Excess Flood] 23:29 -!- phantomcircuit [~phantomci@192.241.205.97] has joined #bitcoin-core-dev 23:48 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 23:49 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 23:53 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 260 seconds] 23:57 -!- so [~so@unaffiliated/so] has quit [Ping timeout: 240 seconds] 23:57 -!- so [~so@unaffiliated/so] has joined #bitcoin-core-dev