--- Day changed Wed May 03 2017 00:11 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:12 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/83073de4bdd8...d3dce0eb67e8 00:12 < bitcoin-git> bitcoin/master 185c7f0 Matt Corallo: Avoid reading the old hd master key during wallet encryption... 00:12 < bitcoin-git> bitcoin/master d3dce0e Wladimir J. van der Laan: Merge #10115: Avoid reading the old hd master key during wallet encryption... 00:12 < bitcoin-git> [bitcoin] laanwj closed pull request #10115: Avoid reading the old hd master key during wallet encryption (master...2017-03-cleanup-sethdmasterkey) https://github.com/bitcoin/bitcoin/pull/10115 00:23 -!- arowser [~quassel@106.120.101.38] has quit [Read error: Connection reset by peer] 00:24 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev 01:04 < bitcoin-git> [bitcoin] spencerlievens opened pull request #10324: Add OSX keystroke to clear RPCConsole (master...patch-3) https://github.com/bitcoin/bitcoin/pull/10324 01:22 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:25 -!- movrcx [~j_ybt@192.161.48.22] has joined #bitcoin-core-dev 01:37 -!- RubenSomsen [~RubenSoms@5ED2CA1D.cm-7-3d.dynamic.ziggo.nl] has joined #bitcoin-core-dev 01:38 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 260 seconds] 01:40 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 01:44 -!- vicenteH [~user@195.235.96.150] has joined #bitcoin-core-dev 02:04 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/d3dce0eb67e8...2a183de0ecb5 02:04 < bitcoin-git> bitcoin/master 91c91e1 John Newbery: Control mempool persistence using a command line parameter.... 02:04 < bitcoin-git> bitcoin/master a750d77 John Newbery: Add tests for mempool persistence... 02:04 < bitcoin-git> bitcoin/master 2a183de Wladimir J. van der Laan: Merge #9966: Control mempool persistence using a command line parameter... 02:04 < bitcoin-git> [bitcoin] laanwj closed pull request #9966: Control mempool persistence using a command line parameter (master...mempoolpersistenceoption) https://github.com/bitcoin/bitcoin/pull/9966 02:05 -!- elkalamar [~elkalamar@84.126.69.179.dyn.user.ono.com] has quit [Quit: Leaving] 02:14 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 02:26 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #bitcoin-core-dev 02:40 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2a183de0ecb5...0912620888e8 02:40 < bitcoin-git> bitcoin/master 56f09df Spencer Lievens: [Makefile] Alphabetically Reorder addrdb.cpp... 02:40 < bitcoin-git> bitcoin/master 0912620 Wladimir J. van der Laan: Merge #10302: [Makefile] Alphabetically Reorder addrdb.cpp... 02:41 < bitcoin-git> [bitcoin] laanwj closed pull request #10302: [Makefile] Alphabetically Reorder addrdb.cpp (master...patch-2) https://github.com/bitcoin/bitcoin/pull/10302 02:42 -!- RubenSomsen [~RubenSoms@5ED2CA1D.cm-7-3d.dynamic.ziggo.nl] has quit [Ping timeout: 260 seconds] 02:48 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0912620888e8...22d870016eb6 02:48 < bitcoin-git> bitcoin/master 1ff2bb4 BtcDrak: Remove unused args from GetFetchhFlags() 02:48 < bitcoin-git> bitcoin/master 22d8700 Wladimir J. van der Laan: Merge #10311: Remove unused args from GetFetchFlags()... 02:48 < bitcoin-git> [bitcoin] laanwj closed pull request #10311: Remove unused args from GetFetchFlags() (master...getflags) https://github.com/bitcoin/bitcoin/pull/10311 03:02 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 03:04 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 03:38 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 268 seconds] 03:40 < bitcoin-git> [bitcoin] fanquake opened pull request #10325: 0.15.0 Depends Updates (master...depends-0-15-0) https://github.com/bitcoin/bitcoin/pull/10325 03:52 -!- shesek [~shesek@bzq-84-110-177-73.cablep.bezeqint.net] has joined #bitcoin-core-dev 03:52 -!- shesek [~shesek@bzq-84-110-177-73.cablep.bezeqint.net] has quit [Changing host] 03:52 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 04:00 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has quit [Remote host closed the connection] 04:04 -!- tw2006 [~tw2006@2601:187:8480:2770:81cd:e7ff:57d5:425a] has quit [Remote host closed the connection] 04:04 -!- swoup [~swoup@unaffiliated/swoup] has joined #bitcoin-core-dev 04:31 -!- swoup [~swoup@unaffiliated/swoup] has left #bitcoin-core-dev [] 04:31 -!- tw2006 [~tw2006@2601:187:8480:2770:e9b7:7fba:515c:9d7e] has joined #bitcoin-core-dev 04:45 -!- Guyver2_ [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 04:48 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Ping timeout: 260 seconds] 04:48 -!- Guyver2_ is now known as Guyver2 04:51 -!- RubenSomsen [~RubenSoms@5ED2CA1D.cm-7-3d.dynamic.ziggo.nl] has joined #bitcoin-core-dev 04:51 -!- harrymm [~wayne@104.237.91.147] has quit [Ping timeout: 276 seconds] 05:15 -!- Guyver2_ [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 05:18 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Ping timeout: 260 seconds] 05:18 -!- Guyver2_ is now known as Guyver2 05:21 -!- RubenSomsen [~RubenSoms@5ED2CA1D.cm-7-3d.dynamic.ziggo.nl] has quit [Ping timeout: 260 seconds] 05:43 -!- NewLiberty [~NewLibert@wsip-24-120-54-20.lv.lv.cox.net] has quit [Ping timeout: 276 seconds] 05:57 -!- cryptapus_afk [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev 05:57 -!- cryptapus_afk [~cryptapus@jupiter.osmus.org] has quit [Changing host] 05:57 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 05:57 -!- goksinen [~goksinen@2604:2000:c591:8400:515e:6b58:e981:d9dd] has joined #bitcoin-core-dev 06:01 -!- jtimon [~quassel@9.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 06:03 < jtimon> more begging for review on https://github.com/bitcoin/bitcoin/pull/9494 06:06 < jnewbery> wumpus did you see my comment on #10225? It's causing test runs to fail intermittently for me. Can we revert it until it's had some review? 06:06 < gribble> https://github.com/bitcoin/bitcoin/issues/10225 | [test] Add aborttrescan tests by kallewoof · Pull Request #10225 · bitcoin/bitcoin · GitHub 06:07 < wumpus> jnewbery: sure 06:08 < wumpus> just commenting out the test so it doesn't run automatically would be enough I guess 06:10 < jnewbery> yes, that would solve the immediate problem, but I'd also like to make sure that the test gets some review. I had a bunch of review comments for the PR which I didn't add because it wasn't even running reliably for me 06:11 < wumpus> no matter waht, comments must be addressed in a new PR 06:11 < wumpus> it's not possible to unmerge and reopen a PR 06:12 < jnewbery> can we do something like: new PR or commit to remove the test entirely, and then PR it again 06:12 < wumpus> I guess if no one fixes it, we can remove the test again at some point 06:13 < wumpus> I don't really see how that is better than just disabling the test (so it can still be run manually) then fixing its problems while it's not blocking travis, but okay... 06:14 < jnewbery> because the test is unreviewed and untested. I think we *should* have the test, I'd just like it to go through a review process before it gets merged :) 06:18 < bitcoin-git> [bitcoin] jnewbery opened pull request #10327: [tests] remove import-abort-rescan.py (master...remove_abort_rescan) https://github.com/bitcoin/bitcoin/pull/10327 06:40 -!- questioner2 [02daf310@gateway/web/freenode/ip.2.218.243.16] has quit [Quit: Page closed] 06:44 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/22d870016eb6...35da2aeed7d4 06:44 < bitcoin-git> bitcoin/master 981e586 John Newbery: [tests] remove import-abort-rescan.py... 06:44 < bitcoin-git> bitcoin/master 35da2ae Wladimir J. van der Laan: Merge #10327: [tests] remove import-abort-rescan.py... 06:45 < bitcoin-git> [bitcoin] laanwj closed pull request #10327: [tests] remove import-abort-rescan.py (master...remove_abort_rescan) https://github.com/bitcoin/bitcoin/pull/10327 06:50 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 06:55 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Ping timeout: 261 seconds] 07:01 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10328: Update contrib/debian to latest Ubuntu PPA upload. (master...2017-05-update-debian) https://github.com/bitcoin/bitcoin/pull/10328 07:14 < BlueMatt> jonasschnelli: re: qt4: I think we need to just remove our tray icon anyway, at this point? 07:14 < BlueMatt> then the issues with qt4 should be resolved, I believe? 07:14 < jonasschnelli> BlueMatt: I think there is an option 07:15 < jonasschnelli> let me check 07:15 < jonasschnelli> setTrayIconVisible(optionsModel->getHideTrayIcon()); 07:16 < BlueMatt> can someone close #10326 as "follow up with antpool, we are not antpool support there is nothing we can do" 07:16 < gribble> https://github.com/bitcoin/bitcoin/issues/10326 | block accepted in solo mining in Antpool and never rewards in the dashboard · Issue #10326 · bitcoin/bitcoin · GitHub 07:17 < BlueMatt> jonasschnelli: i believe there was previously discussion of just always not having tray icons 07:17 < jonasschnelli> Yes. Removing the tray makes sense... though, to prevent distraction, we shouldn't hurry. The option was a good start IMO 07:19 < jonasschnelli> I mean "removing the tray icon". 07:19 < jonasschnelli> OSX has already deprecated those "global menu icons" since years. Because it looks like that every new application wants to place a icon there and mostly the space is limited to just a handfull. 07:20 < jonasschnelli> I guess it's similar on Ubuntu/Windows. 07:20 < jonasschnelli> But all new application ignore these deprecations. :) 07:20 < jonasschnelli> Dropbox / Adobe / VMWare, etc. 07:20 < wumpus> ubuntu is going to drop unity anyhow 07:20 < wumpus> so the problem will go way 07:21 < jonasschnelli> wumpus: There are no such thing like Tray icons in GNOME? 07:21 < wumpus> but yes completely removing tray icon functionality would be a possible future thing too 07:21 < wumpus> jonasschnelli: there are, but that problem shouldn't exist there 07:21 < wumpus> it's a problem specific to how unity intercepts the tray menu 07:22 < wumpus> as I understand, at least 07:22 < jonasschnelli> Okay. Yes. I think as long as users like apps that inject tray icons, we should not hurry with removing the option. 07:22 < jonasschnelli> We could first set the option to false by default 07:22 < wumpus> right 07:23 < wumpus> but as I understand it this problem is specific to unity: it doesn't exist on GNOME, nor KDE 07:24 < wumpus> haven't tested, though. 07:24 < jonasschnelli> Yes. I think so. 07:24 < jonasschnelli> BlueMatt: the current PPA is built with Qt4? Right? 07:24 < BlueMatt> yes 07:24 < jonasschnelli> Hmm... what speaks against Qt5? 07:25 < BlueMatt> wumpus: luke-jr was also complaining about qt5 not working with kde4 folks (do people still use kde4...or kde?) 07:26 < jonasschnelli> Yes. But that orthogonal to the PPA. 07:26 < BlueMatt> true, but it is further reason why we need to support Qt4 07:26 < BlueMatt> (is there even a reason to migrate to qt5) 07:26 < BlueMatt> or, quickly migrate, that is 07:28 < wumpus> well, most software moved away from qt4 by now, so requiring qt4 for the ppa pulls that in, and makes the software look different from other things 07:28 < wumpus> this is a different decision than stopping qt4 support anyhow 07:28 < BlueMatt> how do other projects support qt5 on ubuntu? just no tray icons? 07:29 -!- RubenSomsen [~RubenSoms@5ED2CA1D.cm-7-3d.dynamic.ziggo.nl] has joined #bitcoin-core-dev 07:29 < wumpus> I think so, yes 07:29 < jonasschnelli> I expect much less maintenance on the qt4 branch. Things like HiDPI, etc. which nowadays is also common on Ubuntu is only possible with Qt5. 07:29 < wumpus> software on linux that adds tray icons is kind of rare 07:29 < BlueMatt> lol, why is all software terrible 07:31 < wumpus> the "correct way" to do tray functionality on ubuntu is to register beneath one of the existing (vendor-provided) tray icons in the tray menu. They have an API for this. Of course, given that it's going to disappear it's not worth spending time on that. 07:31 < wumpus> (if it ever was) 07:31 < wumpus> but e.g. some instant messenger and email clients etc do that 07:31 < BlueMatt> ah 07:32 < wumpus> (probably, ubuntu maintains their own patches for that) 07:32 < BlueMatt> lol, why is all software terrible 07:33 < wumpus> why is all terrible 07:34 < BlueMatt> fair point 07:37 -!- kexkey [~kexkey@173.209.61.62] has joined #bitcoin-core-dev 07:49 < luke-jr> BlueMatt: Qt5 doesn't adapt to Qt4, *and vice versa*. KDE 4 is rapidly becoming Windows XP. I think we're okay to drop Qt4 entirely as soon as it becomes a burden, but changing builds to use Qt5 ASAP is a good idea. 07:50 < wumpus> the bitcoin.org builds have been using qt5 for considerable time, it's just the PPA using qt4 07:52 < luke-jr> Ubuntu is no longer Unity; I'm guessing we still support an older Unity-based version though? 07:52 -!- RubenSomsen [~RubenSoms@5ED2CA1D.cm-7-3d.dynamic.ziggo.nl] has quit [Ping timeout: 255 seconds] 07:52 < wumpus> there's no Ubuntu no-Unity release yet afaik? I just meant that starting from there we can switch it to qt5 07:53 < luke-jr> is there a way to make debs use a different version based on their target? 07:53 < luke-jr> (parazyd - the guy who opened that PR - 's target is Knots on Devuan FWIW) 07:53 < wumpus> "On 5 April 2017 Mark Shuttleworth announced that Canonical's work on Unity will end and that Ubuntu 18.04 LTS, a year away from release at the time, will abandon the Unity desktop and employ the GNOME 3 desktop instead" 07:55 < wumpus> yes he's using KDE5, which doesn't work with qt4 all too well, so I understand his concern 08:04 < BlueMatt> luke-jr: all debian builds have the release hardcoded 08:04 < BlueMatt> well, for uploads to ppa/debian builds/ubuntu builds 08:04 < BlueMatt> manual builds ignore that 08:07 < luke-jr> I thought for PPAs you upload once and it built for everything? :o 08:07 -!- tw2006 [~tw2006@2601:187:8480:2770:e9b7:7fba:515c:9d7e] has quit [Remote host closed the connection] 08:07 < BlueMatt> nope, it gets uploaded like 5 times 08:08 < luke-jr> ew 08:08 < luke-jr> BlueMatt: it would be nice if there was a gitian descriptor that produced the files to upload btw ;) 08:10 < BlueMatt> the files to upload is pretty much just the debian/ folder from contrib/debian and a copy of the git archive, all signed by my pgp key 08:10 < BlueMatt> not sure how useful it would be, then, unsigned :p 08:12 -!- tw2006 [~tw2006@2601:187:8480:2770:c87c:9639:9245:1ae] has joined #bitcoin-core-dev 08:12 < luke-jr> there isn't something that requires a Debian-based OS to generate? 08:13 < BlueMatt> I dunno, I use the debian tools to upload, but used to use the debain tools on arch, even 08:13 < BlueMatt> now its in a vm 08:14 < sipa> i thought PPA was ubuntu-spdcific 08:14 < luke-jr> it is 08:14 < BlueMatt> PPAs are, but the tools to upload to them are debian-generic 08:15 < luke-jr> BlueMatt: well, it'd be nice to have that VM turned into a gitian descriptor simply for convenience IMO; gitian as an automating tool rather that determinism tool ;)O 08:16 < BlueMatt> luke-jr: yes, but there'd be no point in anyone but me using it? 08:16 < BlueMatt> so why bother? 08:16 < BlueMatt> its already dead-simple to do 08:16 < luke-jr> BlueMatt: well, you don't want to maintain a PPA for Knots I assume? 08:16 < BlueMatt> just copy contrib/debian into debian and run dpkg-buildpackage 08:17 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 08:17 < BlueMatt> iirc dpkg-buildpackage -S -sa -d && dput ppaname *.changes 08:17 < luke-jr> k, will try that 08:18 < BlueMatt> you need to add ppaname to some config file 08:18 < BlueMatt> but ofc thats the part that is me-specific 08:18 < BlueMatt> not gitian-able 08:19 < BlueMatt> also your pgp key name has to match the top entry in debian/changelog for dpkg-buildpackage to sign it right 08:20 < luke-jr> your daily and RC PPAs seem dead since 2011 btw 08:20 < BlueMatt> im aware 08:20 < BlueMatt> they need to be deleted, probably 08:25 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 08:25 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 08:25 < Lauda> Is 'walletpassphrase' supposed to return 'null' now on correct entry of pass? 08:27 < wumpus> it always did AFAIK 08:28 < wumpus> on failure it throws an error, on success it returns NullUniValue 08:33 < Lauda> It may just be me, but I haven't noticed 'null' up until today on 0.14.1 08:33 < Lauda> Thanks for clarifying though! 08:33 < BlueMatt> luke-jr: i cant add people to the "bitcoin" team on launchpad because adding people means they get instant upload rights....so adding people needs to be a public process of "this person is gonna get PPA upload rights" 08:33 < wumpus> Lauda: might be that the GUI now displays it differently? 08:35 < Lauda> wumpus IIRC the GUI never returned 'null', that's why it surprised me (it had an empty line or something). Again, might be me :l 08:37 < luke-jr> BlueMatt: hmm, no way to add me with just a second PPA for knots? 08:37 < BlueMatt> luke-jr: I dont believe so, but may be wrong 08:38 < luke-jr> weird 08:40 -!- EagleTM [~hab@x5ce7e736.dyn.telefonica.de] has joined #bitcoin-core-dev 08:40 < wumpus> Lauda: ah I think I remember now, IIRC that was changed because an empty line was confusing people 08:41 < Lauda> maybe in 0.14.0 (just tested that one, as it also has null). Thanks :D 08:44 < luke-jr> BlueMatt: dpkg-source: error: can't build with source format '3.0 (quilt)': no upstream tarball found at ../bitcoin_0.11.0.orig.tar.{bz2,gz,lzma,xz} 08:45 < BlueMatt> luke-jr: you need to create a git archive with the listed name :p 08:47 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has quit [Ping timeout: 268 seconds] 08:48 < luke-jr> dpkg-source: info: local changes detected, the modified files are: bitcoin/source/clientversion.cpp 08:49 < BlueMatt> yes, and the source has to match the git archive exactly, so the git archive magic in clientversion.cpp needs to be updated accordingly 08:49 < BlueMatt> really you're supposed to just untar the release source (which for us is git archive) 08:49 < luke-jr> not the gitian-generated tarball? 08:50 < BlueMatt> i suppose it doesnt matter? 08:50 < BlueMatt> i mean you can upload any source you want, i use git archives 08:50 < luke-jr> the latter has clientversion correct and configure generated :D 08:51 < BlueMatt> ehh, I'll stick with autogen on launchpad, doesnt matter 08:53 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 09:03 < jtimon> mhmm, travis wasn't launched for #9494 on last rebase... wumpus can you or someone else make it happen or should I just push with a different commit id or something? 09:03 < gribble> https://github.com/bitcoin/bitcoin/issues/9494 | Introduce an ArgsManager class encapsulating cs_args, mapArgs and mapMultiArgs by jtimon · Pull Request #9494 · bitcoin/bitcoin · GitHub 09:05 < bitcoin-git> [bitcoin] RHavar closed pull request #10100: Make ApproximateBestSubset optimize for amount of inputs (master...coinselection) https://github.com/bitcoin/bitcoin/pull/10100 09:18 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 246 seconds] 09:18 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 09:23 -!- xiangfu [~xiangfu@223.223.187.142] has quit [Ping timeout: 260 seconds] 09:24 -!- xiangfu [~xiangfu@223.223.187.142] has joined #bitcoin-core-dev 09:30 -!- timothy [tredaelli@redhat/timothy] has quit [Remote host closed the connection] 09:38 < sipa> anyone know what could be happening here? https://travis-ci.org/bitcoin/bitcoin/jobs/228201960 09:38 < sipa> no output for 10 minutes while/after running bitcoin-util-test.py 09:38 < sipa> this is the second PR where I see this problem 09:40 < wumpus> no, no idea. This was after the revert of #10225? 09:40 < gribble> https://github.com/bitcoin/bitcoin/issues/10225 | [test] Add aborttrescan tests by kallewoof · Pull Request #10225 · bitcoin/bitcoin · GitHub 09:43 -!- Giszmo [~leo@201.215.13.240] has joined #bitcoin-core-dev 09:43 < sipa> let me rebase on top of that revert 09:45 -!- EagleTM [~hab@x5ce7e736.dyn.telefonica.de] has left #bitcoin-core-dev [] 09:45 < sipa> reindex-chainstate on my laptop with pertxoutcache: 1h27m to block 453354 (default assumevalid) 09:46 < sipa> (and infinite dbcache, which is larger now) 09:46 < sipa> i'll benchmark master as well 09:58 -!- heath_ is now known as heath 09:59 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 10:01 < luke-jr> BlueMatt: how to get db4.8 built? :p 10:03 < luke-jr> (maybe it should be a separate PPA that can just be used as a dep?) 10:04 < TD-Linux> which reminds me, a recent beautiful locking bug with latest glibc and libdb breaks rpm on Fedora: https://bugzilla.redhat.com/show_bug.cgi?id=1394862 10:05 < TD-Linux> I don't think this affects db4.8 or wallet btw 10:07 -!- sambhu [1b22432b@gateway/web/freenode/ip.27.34.67.43] has joined #bitcoin-core-dev 10:13 < BlueMatt> sipa: context? what is non-per-utxo? 10:13 < BlueMatt> wait, what is pertxoutcache? 10:13 < sipa> BlueMatt: pertxoutcache = #10195 10:13 < gribble> https://github.com/bitcoin/bitcoin/issues/10195 | Switch chainstate db and cache to per-txout model by sipa · Pull Request #10195 · bitcoin/bitcoin · GitHub 10:13 < sipa> sorry, i think in my own branch names rather than PRs 10:14 < BlueMatt> ah, k 10:14 < sipa> dbcache was 6.3G at that point though, and 2.7G on disk after flushing 10:22 < BlueMatt> sipa: still missing lots of context...how do those numbers compare to previously :p 10:22 < BlueMatt> (esp cache size) 10:23 -!- sambhu [1b22432b@gateway/web/freenode/ip.27.34.67.43] has quit [Quit: Page closed] 10:23 < sipa> BlueMatt: yeah, i haven't done a rigorous benchmark on this system recently, so i can't tell 10:24 < sipa> i was just surprised by a reindex of 1.5h 10:24 < sipa> maybe that's due to improvements in master i'm not aware of, or maybe my memory is faulty :) 10:29 < BlueMatt> or assumevalid 10:30 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 10:33 -!- moli_ [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 10:41 -!- harrymm [~wayne@104.237.91.235] has joined #bitcoin-core-dev 10:45 < bitcoin-git> [bitcoin] jnewbery opened pull request #10330: fix zapwallettxes interaction with persistent mempool (master...zapwallettxes) https://github.com/bitcoin/bitcoin/pull/10330 10:53 -!- vicenteH [~user@195.235.96.150] has quit [Ping timeout: 276 seconds] 10:55 < jnewbery> sipa: I may be wrong, but I think that your travis issue is with the unit tests rather than bitcoin-util-test.py. Compare: https://travis-ci.org/bitcoin/bitcoin/jobs/228344728 . I think the final line in your output: 10:55 < jnewbery> make[4]: Entering directory `/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-w64-mingw32/src' 10:55 < jnewbery> indicates that bitcoin-util-test.py has returned and you're now running the unit tests 10:58 < sipa> jnewbery: sounds plausible 11:00 < sipa> any idea on how to find out which test is the cause? 11:01 < luke-jr> I'm not sure the UAWITNESS service bit in BIP 149 is sufficient. At the very least, relying on service bits is a bad idea. 11:03 < luke-jr> what happens if a malicious node sends 0.14.1 a segwit block when BIP9 didn't activate? will it permanently flag it as invalid and never reconsider a stripped version? 11:04 < abpa> Don't you have the same issue if SegWit 2 is proposed with BIP9 over again? 11:05 < luke-jr> abpa: possibly. changing the dummy byte may workaround this. 11:06 < jnewbery> how reproducible is this on travis? Perhaps you could update the travis/make config to run the unit tests with verbose output? 11:15 -!- Dyaheon [~Dya@a91-156-192-24.elisa-laajakaista.fi] has quit [Ping timeout: 240 seconds] 11:16 < sipa> jnewbery: i have 2 PRs which reproducibly failed in 1 or 2 builds, both windows builds 11:16 < sipa> how do i run the tests verbose? 11:18 -!- Dyaheon [~Dya@a91-156-192-24.elisa-laajakaista.fi] has joined #bitcoin-core-dev 11:26 < jnewbery> sipa: test_bitcoin --log_level=all if you're running them manually, but that produces a lot of output. I haven't looked at how you'd update makefiles/travis config to do this 11:37 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Read error: Connection reset by peer] 11:37 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 11:43 -!- molz_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 11:43 < sipa> jnewbery: i cannot reproduce it locally 11:43 < sipa> ok 11:46 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 276 seconds] 11:52 < bitcoin-git> [bitcoin] jnewbery opened pull request #10331: Share config between util and functional tests (master...shared_util_function_test_config) https://github.com/bitcoin/bitcoin/pull/10331 11:59 < luke-jr> woo success https://launchpad.net/~luke-jr/+archive/ubuntu/db48 12:09 -!- molz_ [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 12:11 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 12:29 < luke-jr> FYI: release tarballs are missing contrib/debian entirely 12:55 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 12:56 -!- moli_ [~molly@unaffiliated/molly] has quit [Ping timeout: 276 seconds] 13:05 < bitcoin-git> [bitcoin] parazyd closed pull request #10316: fix contrib/debian builds; prefer qt5 (master...debian-packaging) https://github.com/bitcoin/bitcoin/pull/10316 13:17 -!- harrymm [~wayne@104.237.91.235] has quit [Ping timeout: 260 seconds] 13:36 -!- harrymm [~wayne@104.237.91.37] has joined #bitcoin-core-dev 13:37 -!- protomar [~protomar@109.232.227.133] has joined #bitcoin-core-dev 13:38 -!- vicenteH [~user@135.234.15.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 13:53 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 13:54 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 264 seconds] 13:55 -!- goksinen [~goksinen@2604:2000:c591:8400:515e:6b58:e981:d9dd] has quit [Remote host closed the connection] 13:58 -!- cryptapus_ [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev 13:58 -!- cryptapus_ [~cryptapus@jupiter.osmus.org] has quit [Changing host] 13:58 -!- cryptapus_ [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 13:58 -!- cryptapus_ is now known as cryptapus_afk 13:58 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 260 seconds] 13:59 -!- goksinen [~goksinen@2604:2000:c591:8400:515e:6b58:e981:d9dd] has joined #bitcoin-core-dev 13:59 -!- emucode [~emu@162.251.81.139] has quit [Read error: Connection reset by peer] 14:01 -!- tw2006 [~tw2006@2601:187:8480:2770:c87c:9639:9245:1ae] has quit [Remote host closed the connection] 14:01 -!- vicenteH [~user@135.234.15.37.dynamic.jazztel.es] has quit [Ping timeout: 260 seconds] 14:02 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 255 seconds] 14:04 -!- goksinen [~goksinen@2604:2000:c591:8400:515e:6b58:e981:d9dd] has quit [Ping timeout: 255 seconds] 14:05 -!- emucode [~emu@162.251.81.139] has joined #bitcoin-core-dev 14:06 -!- cryptapus_afk [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev 14:06 -!- cryptapus_afk [~cryptapus@jupiter.osmus.org] has quit [Changing host] 14:06 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 14:08 -!- molz_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 14:11 -!- str4d [~str4d@27.110.123.92] has joined #bitcoin-core-dev 14:11 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection] 14:11 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 276 seconds] 14:11 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 264 seconds] 14:12 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 14:12 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev 14:14 < bitcoin-git> [bitcoin] instagibbs opened pull request #10333: CreateTransction fee fixes: always create change, adjust value, and p… (master...fixfeefinal) https://github.com/bitcoin/bitcoin/pull/10333 14:24 < sipa> cfields: how do i go about having a #define available for the presence of clock_gettime? 14:25 -!- goksinen [~goksinen@2604:2000:c591:8400:515e:6b58:e981:d9dd] has joined #bitcoin-core-dev 14:25 < sipa> cfields: it seems configure.ac already tests for it, but there is no macro 14:27 < cfields> sipa: looks like we assume it's always there? 14:27 -!- protomar [~protomar@109.232.227.133] has quit [Quit: Leaving] 14:28 < sipa> cfields: the interwebs tell me that OSX doesn't have it 14:28 < cfields> sipa: ergh, I remember something about it changing in 10.12 14:29 -!- kexkey [~kexkey@173.209.61.62] has quit [Ping timeout: 240 seconds] 14:29 < cfields> sipa: ah right, maybe it was added and we'll have to deal with it like getentropy 14:29 < cfields> checking 14:30 < cfields> sipa: wait. What do you need it for? 14:30 < sipa> cfields: #10322 14:30 < gribble> https://github.com/bitcoin/bitcoin/issues/10322 | Use hardware timestamps in RNG seeding by sipa · Pull Request #10322 · bitcoin/bitcoin · GitHub 14:31 < sipa> ARM does not have an rdtsc instruction, and clock_gettime has much higher precision than gettimeofday 14:32 < sipa> i guess it does not matter that much... because on OSX we'll always be on a platform that does have rdtsc 14:32 < cfields> sipa: opposed to using std::chrono::high_resolution_clock ? 14:33 < sipa> ah! 14:33 < cfields> (i assume it's just an abstraction around clock_gettime for *nix) 14:34 -!- goksinen [~goksinen@2604:2000:c591:8400:515e:6b58:e981:d9dd] has quit [Remote host closed the connection] 14:34 < sipa> checking how it is implemented; thanks for the suggestion 14:34 < cfields> np 14:35 * sipa is slightly scared about these things, after seeing how useless the std::random_device implementations can be... 14:35 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection] 14:36 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev 14:37 < cfields> to answer your question, in case this doesn't work out, in the "AC_SEARCH_LIBS([clock_gettime]", just add a third argument. Do the AC_DEFINE there. 14:38 -!- goksinen [~goksinen@2604:2000:c591:8400:515e:6b58:e981:d9dd] has joined #bitcoin-core-dev 14:44 < cfields> libc++ uses: clock_gettime(CLOCK_REALTIME, &tp) 14:44 -!- elkalamar [~elkalamar@84.126.69.179.dyn.user.ono.com] has joined #bitcoin-core-dev 14:44 -!- goksinen [~goksinen@2604:2000:c591:8400:515e:6b58:e981:d9dd] has quit [Ping timeout: 260 seconds] 14:45 < cfields> but seems to round it to msecs :( 14:45 < sipa> "uses" ? 14:46 < sipa> for what? 14:46 < sipa> oh, for high_resolution_clock? 14:46 < sipa> rly? 14:47 < cfields> ah wait, that's only if there's no monotick source 14:47 < cfields> https://github.com/llvm-mirror/libcxx/blob/master/src/chrono.cpp#L137 14:48 -!- Squidicuz [~squid@pool-173-48-116-49.bstnma.fios.verizon.net] has quit [Read error: Connection reset by peer] 14:48 -!- Squidicuz [~squid@pool-173-48-116-49.bstnma.fios.verizon.net] has joined #bitcoin-core-dev 14:48 < cfields> and https://github.com/llvm-mirror/libcxx/blob/master/src/chrono.cpp#L224 14:50 < sipa> cfields: can you try compiling and running https://zerobin.net/?f8af7a8040549857#9JGDEBZvv+MQzzGCfLGyvIC5C8plMb7L/Jxg34DuCYM= ? 14:50 < gribble> https://github.com/bitcoin/bitcoin/issues/9 | Fix for GUI on Macs and latest wxWidgets by gavinandresen · Pull Request #9 · bitcoin/bitcoin · GitHub 14:50 < sipa> on linux it gives me nanosecond precision, in mingw-w64 + wine microsecond 14:50 < cfields> mmm, i'm about ready to take back that suggestion. probably not worth the risk. 14:50 < cfields> sec 14:52 < cfields> yea, I get nano 14:52 < sipa> cool 14:54 < sipa> i like c++: 14:54 < sipa> return std::chrono::duration_cast(std::chrono::high_resolution_clock::now().time_since_epoch()).count(); 14:54 < sipa> ... 14:57 < cfields> heh 14:57 < sipa> translates to a single instruction 14:57 < sipa> (a library call, to be clear... but no conversion anywhere) 14:58 < cfields> oh, nice :) 14:58 < cfields> sipa: static_assert(std::ratio_greater_equal::value == true, "no nanosecond precision"); 14:58 < cfields> zero instructions for that one :) 14:59 < sipa> cfields: that compiles fine on mingw, even though the result only has microsecond precision 15:00 < sipa> (it always returns numbers that are multiples of 1000) 15:00 < cfields> hmm 15:00 < sipa> what output do you get on osx from my snippet? 15:02 -!- tw2006 [~tw2006@2601:187:8480:2770:a11d:a3aa:6db9:7d09] has joined #bitcoin-core-dev 15:03 < cfields> nano 15:03 < cfields> 1033378907044228 15:03 < cfields> 1033378907124163 15:03 < cfields> ... 15:07 -!- tw2006 [~tw2006@2601:187:8480:2770:a11d:a3aa:6db9:7d09] has quit [Ping timeout: 246 seconds] 15:07 < cfields> oh sorry, got that static_assert backwards. That should be ratio_less_equal 15:07 < cfields> with that change, mingw fails to compile for me. 15:07 < sipa> still compiles fine here 15:08 -!- goksinen [~goksinen@2604:2000:c591:8400:515e:6b58:e981:d9dd] has joined #bitcoin-core-dev 15:12 -!- goksinen [~goksinen@2604:2000:c591:8400:515e:6b58:e981:d9dd] has quit [Ping timeout: 246 seconds] 15:19 < cfields> sipa: to avoid multiples of 1000 with microsecond precision, you can use: "auto value = std::chrono::duration_cast(epoch);" 15:19 < cfields> (though it sounds like your mingw is lying to you about precision at compile-time, so that may not help) 15:19 < cfields> works here 15:20 -!- goksinen [~goksinen@2604:2000:c591:8400:515e:6b58:e981:d9dd] has joined #bitcoin-core-dev 15:21 -!- altoz_ [~Jimmy@cpe-24-55-54-186.austin.res.rr.com] has joined #bitcoin-core-dev 15:23 -!- pindarhk_ [sid105966@gateway/web/irccloud.com/x-jztjydvqsarbetwz] has joined #bitcoin-core-dev 15:23 -!- eragmus_ [sid136308@gateway/web/irccloud.com/x-vanuekkylbapwwra] has joined #bitcoin-core-dev 15:23 -!- CodeShark_ [sid126576@gateway/web/irccloud.com/x-eugwmiyfnvabvufe] has joined #bitcoin-core-dev 15:25 -!- comboy_ [~quassel@tesuji.pl] has joined #bitcoin-core-dev 15:26 -!- xhire_ [~xHire@kos.paskuli.cz] has joined #bitcoin-core-dev 15:27 -!- comboy_ [~quassel@tesuji.pl] has quit [Client Quit] 15:27 -!- Apocalyptic_ [~Apocalypt@unaffiliated/apocalyptic] has joined #bitcoin-core-dev 15:27 -!- comboy_ [~quassel@tesuji.pl] has joined #bitcoin-core-dev 15:28 -!- CodeShark [sid126576@gateway/web/irccloud.com/x-viiyprgiyalonkdk] has quit [Ping timeout: 240 seconds] 15:28 -!- pindarhk [sid105966@gateway/web/irccloud.com/x-zhaxliabrvbgbpoe] has quit [Ping timeout: 240 seconds] 15:28 -!- Apocalyptic [~Apocalypt@unaffiliated/apocalyptic] has quit [Ping timeout: 240 seconds] 15:28 -!- btcdrak [uid226507@gateway/web/irccloud.com/x-fgndpyaorjvdbxjd] has quit [Ping timeout: 240 seconds] 15:28 -!- eragmus [sid136308@gateway/web/irccloud.com/x-lcrlxogkggnpkdpr] has quit [Ping timeout: 240 seconds] 15:28 -!- comboy [~quassel@tesuji.pl] has quit [Ping timeout: 240 seconds] 15:28 -!- xHire [~xHire@kos.paskuli.cz] has quit [Ping timeout: 240 seconds] 15:28 -!- altoz [~Jimmy@cpe-24-55-54-186.austin.res.rr.com] has quit [Ping timeout: 240 seconds] 15:28 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Killed (Sigyn (Spam is off topic on freenode.))] 15:28 -!- CodeShark_ is now known as CodeShark 15:28 -!- Apocalyptic_ is now known as Apocalyptic 15:29 -!- pindarhk_ is now known as pindarhk 15:29 -!- eragmus_ is now known as eragmus 15:29 -!- goksinen [~goksinen@2604:2000:c591:8400:515e:6b58:e981:d9dd] has quit [Remote host closed the connection] 15:30 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 15:36 -!- altoz_ is now known as altoz 15:57 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 16:01 -!- goksinen [~goksinen@2604:2000:c591:8400:515e:6b58:e981:d9dd] has joined #bitcoin-core-dev 16:03 -!- tw2006 [~tw2006@2601:187:8480:2770:10f5:58d0:5e41:aca0] has joined #bitcoin-core-dev 16:08 -!- tw2006 [~tw2006@2601:187:8480:2770:10f5:58d0:5e41:aca0] has quit [Ping timeout: 260 seconds] 16:08 -!- goksinen [~goksinen@2604:2000:c591:8400:515e:6b58:e981:d9dd] has quit [Ping timeout: 260 seconds] 16:20 -!- comboy_ is now known as comboy 16:21 -!- goksinen [~goksinen@2604:2000:c591:8400:515e:6b58:e981:d9dd] has joined #bitcoin-core-dev 16:26 -!- goksinen [~goksinen@2604:2000:c591:8400:515e:6b58:e981:d9dd] has quit [Ping timeout: 255 seconds] 16:47 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has quit [Quit: Leaving] 16:50 -!- vicenteH [~user@135.234.15.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 16:52 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 16:59 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 17:04 -!- tw2006 [~tw2006@2601:187:8480:2770:f4c7:1bdf:5818:fdc] has joined #bitcoin-core-dev 17:09 -!- tw2006 [~tw2006@2601:187:8480:2770:f4c7:1bdf:5818:fdc] has quit [Ping timeout: 260 seconds] 17:20 -!- btcdrak [uid226507@gateway/web/irccloud.com/x-ywrlkezhhabzkjxk] has joined #bitcoin-core-dev 17:22 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-rpxxzbwhqkexbflo] has quit [Quit: Connection closed for inactivity] 17:28 -!- tw2006 [~tw2006@2601:187:8480:2770:f0f8:abb2:a057:92d6] has joined #bitcoin-core-dev 17:50 -!- anthonyjd [~Anthony@2001:470:daef:e1e1:27a3:b8c8:9db:79f6] has joined #bitcoin-core-dev 17:51 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Read error: Connection reset by peer] 17:51 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 17:57 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Ping timeout: 255 seconds] 17:58 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 18:05 -!- PaulCape_ [~PaulCapes@2604:5500:17:2ea:e513:ccb3:15a6:a6a6] has joined #bitcoin-core-dev 18:05 -!- PaulCapestany [~PaulCapes@2604:5500:17:2ea:1169:ed8d:7fc7:c6a6] has quit [Ping timeout: 240 seconds] 18:06 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Ping timeout: 255 seconds] 18:06 < cfields> sipa: you're going to hate me for this... 18:07 < bitcoin-git> [bitcoin] theuni opened pull request #10335: back-compat: add fallback getentropy implementation (master...getentropy-back-compat) https://github.com/bitcoin/bitcoin/pull/10335 18:12 < sipa> cfields: we don't use getentropy on linux 18:12 < warren> cfields: btw, Ubuntu 12.04 Precise is hitting EOL, will gitian switch to a newer base soon? 18:12 < sipa> cfields: or we shouldn't, i guess 18:13 < sipa> if getrandom isn't available on linux, i think we should fallback to using /dev/urandom directly rather than through a fallback for a wrapper for a BSD function :) 18:16 < cfields> sipa: atm it's being used in linux, best i can tell 18:16 < cfields> (i get a runtime link error, so it must be) 18:17 < cfields> warren: gitian uses Trusty currently 18:17 < warren> oops 18:18 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Ping timeout: 255 seconds] 18:19 < sipa> cfields: yes, we compile in code to use getrandom whenever configure detects it 18:19 < cfields> sipa: sorry, i was referring to getentropy 18:20 < sipa> eh, i mean getentropy 18:20 < sipa> cfields: the getentropy implementation in glibc on Linux just uses SYS_getrandom, just like we already do directly 18:21 < sipa> so a fallback that just returns 0 should be fine 18:21 < sipa> we check the return status 18:21 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 18:22 < sipa> ah, no 18:22 < sipa> hmm 18:23 -!- Alina-malina [~Alina-mal@37.157.223.80] has joined #bitcoin-core-dev 18:27 < cfields> sipa: looks like getentropy needs to check for ENOSYS, and do GetDevURandom as a fallback. Then the weak getentropy just returns ENOSYS. 18:27 < cfields> I think that works? 18:28 < sipa> cfields: yup 18:28 < cfields> ok, will do. 18:28 < sipa> cfields: i think our GetOSEntropy call should always compile in the GetDevURandom fallback 18:28 < sipa> (so move it out of the #ifdef ... #elif .. #endif switch) 18:28 < cfields> yep, agreed 18:29 < sipa> then the getrandom/getentropy calls can fail without problems 18:29 < sipa> and agreed, a simple fallback returning ENOSYS is perfect then 18:57 -!- tw2006 [~tw2006@2601:187:8480:2770:f0f8:abb2:a057:92d6] has quit [Remote host closed the connection] 18:58 -!- tw2006 [~tw2006@2601:187:8480:2770:6974:d649:fbef:e5f1] has joined #bitcoin-core-dev 19:00 -!- dermoth [~thomas@dial-216-221-44-85.mtl.aei.ca] has quit [Read error: Connection reset by peer] 19:01 -!- dermoth [~thomas@dial-216-221-44-85.mtl.aei.ca] has joined #bitcoin-core-dev 19:02 -!- juscamarena_ [~justin@47.148.176.74] has joined #bitcoin-core-dev 19:06 -!- harrymm1 [~wayne@104.237.91.228] has joined #bitcoin-core-dev 19:08 -!- harrymm [~wayne@104.237.91.37] has quit [Ping timeout: 260 seconds] 19:30 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Read error: Connection reset by peer] 19:35 -!- molz_ [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 19:38 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 20:02 -!- QBcrusher__ [~QBcrusher@cpe-173-88-70-206.columbus.res.rr.com] has joined #bitcoin-core-dev 20:05 -!- vicenteH` [~user@135.234.15.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 20:08 -!- xHire [~xHire@kos.paskuli.cz] has joined #bitcoin-core-dev 20:09 -!- Dyaheon- [~Dya@a91-156-192-24.elisa-laajakaista.fi] has joined #bitcoin-core-dev 20:10 -!- kcud_dab [~arthur@2001:bc8:c087:1001::1] has joined #bitcoin-core-dev 20:11 -!- Netsplit *.net <-> *.split quits: profall, justanotheruser, Naphex, chjj, Dyaheon, vicenteH, Madars, fao3, instagibbs, bad_duck, (+2 more, use /NETSPLIT to show all of them) 20:12 -!- Netsplit over, joins: instagibbs 20:14 -!- tw2006 [~tw2006@2601:187:8480:2770:6974:d649:fbef:e5f1] has quit [Remote host closed the connection] 20:18 -!- Netsplit over, joins: chjj 20:19 -!- Netsplit over, joins: Madars 20:19 -!- Netsplit over, joins: fao3 20:22 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:32 < cfields> cfields: i think our GetOSEntropy call should always compile in the GetDevURandom fallback 20:32 < cfields> sipa: looking again, I'm not sure what you meant by that 20:33 < cfields> we always compile GetDevURandom, except for win32 20:34 < sipa> cfields: i mean the GetDevURandom call at the bottom of GetOSEntropy 20:35 < sipa> which is only compiled if getrandom and getentropy are not availablr 20:35 < sipa> that should change 20:35 < cfields> sipa: so you want early returns for any better function, and fallback if one isn't hit by the end? 20:36 < sipa> right 20:36 < cfields> makes sense, will do 20:37 < sipa> getrandom currently has a fallback already 20:37 < sipa> but not the rest 20:43 < Lightsword> so I should remove the fallback here as well? https://github.com/bitcoin/bitcoin/pull/10301/files#diff-35f8a407f8c21cda300a45f50b6e9c74R172 20:50 -!- talmai [~T@c-24-147-97-55.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 21:15 -!- tw2006 [~tw2006@2601:187:8480:2770:c5ea:5d9a:1c85:34b1] has joined #bitcoin-core-dev 21:19 -!- tw2006 [~tw2006@2601:187:8480:2770:c5ea:5d9a:1c85:34b1] has quit [Ping timeout: 255 seconds] 21:32 -!- aantonop [~aantonop@122-57-23-131.jetstream.xtra.co.nz] has joined #bitcoin-core-dev 21:43 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 22:06 -!- fao3 [~fao@106.120.101.38] has quit [Ping timeout: 264 seconds] 22:08 -!- fao3 [~fao@106.120.101.38] has joined #bitcoin-core-dev 22:11 -!- Giszmo [~leo@201.215.13.240] has quit [Quit: Leaving.] 22:13 -!- profall [sid29922@gateway/web/irccloud.com/x-tsnqautzjkmazopy] has joined #bitcoin-core-dev 22:14 -!- Dyaheon- [~Dya@a91-156-192-24.elisa-laajakaista.fi] has quit [Ping timeout: 264 seconds] 22:14 -!- Dyaheon [~Dya@a91-156-192-24.elisa-laajakaista.fi] has joined #bitcoin-core-dev 22:16 -!- tw2006 [~tw2006@2601:187:8480:2770:5940:be78:51b8:96e2] has joined #bitcoin-core-dev 22:20 -!- tw2006 [~tw2006@2601:187:8480:2770:5940:be78:51b8:96e2] has quit [Ping timeout: 246 seconds] 22:24 -!- fao3 [~fao@106.120.101.38] has quit [Ping timeout: 240 seconds] 22:24 -!- fao3 [~fao@106.120.101.38] has joined #bitcoin-core-dev 22:31 -!- PaulCape_ [~PaulCapes@2604:5500:17:2ea:e513:ccb3:15a6:a6a6] has quit [Quit: .] 22:35 -!- PaulCapestany [~PaulCapes@2604:5500:17:2ea:611c:e7bb:869d:a3e8] has joined #bitcoin-core-dev 22:39 -!- aantonop [~aantonop@122-57-23-131.jetstream.xtra.co.nz] has quit [Ping timeout: 260 seconds] 22:47 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 22:51 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 22:53 -!- moli_ [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 22:59 -!- talmai [~T@c-24-147-97-55.hsd1.ma.comcast.net] has quit [Quit: mining] 23:00 -!- RubenSomsen [~RubenSoms@5ED2CA1D.cm-7-3d.dynamic.ziggo.nl] has joined #bitcoin-core-dev 23:00 -!- dermoth [~thomas@dial-216-221-44-85.mtl.aei.ca] has quit [Read error: Connection reset by peer] 23:00 -!- dermoth [~thomas@dial-216-221-44-85.mtl.aei.ca] has joined #bitcoin-core-dev 23:07 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-hflsokifwvjuxcti] has joined #bitcoin-core-dev 23:17 -!- tw2006 [~tw2006@2601:187:8480:2770:4cbe:f7ed:11c1:91e7] has joined #bitcoin-core-dev 23:21 -!- tw2006 [~tw2006@2601:187:8480:2770:4cbe:f7ed:11c1:91e7] has quit [Ping timeout: 260 seconds] 23:25 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection] 23:26 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev 23:28 -!- Alina-malina [~Alina-mal@37.157.223.80] has quit [Changing host] 23:28 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev 23:35 < jonasschnelli> Grml... if we enforce a min HD recover gap limit (currently 20 keypool keys), all tests are broken (mosts tests run with a keypool of size 1). I guess I have to add a -hdignoregaplimit and set it to true by default for the tests. 23:35 -!- harrymm1 [~wayne@104.237.91.228] has quit [Remote host closed the connection] 23:37 -!- harrymm [~wayne@104.237.91.228] has joined #bitcoin-core-dev 23:40 -!- harrymm [~wayne@104.237.91.228] has quit [Remote host closed the connection] 23:48 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 268 seconds] 23:54 -!- JackH [~laptop@79-73-191-98.dynamic.dsl.as9105.com] has quit [Ping timeout: 260 seconds]