--- Day changed Tue May 16 2017 00:06 < cfields> jonasschnelli: I'll give it a detailed look in the morning (getting ready for bed atm). Looks ok at a glance, though. Though, I'm a bit confused about nBlocksInFlight being atomic. 00:07 < jonasschnelli> cfields: Okay. Thanks... have a rest (it's not urgent). And yes, I would like to hear why you think nBlocksInFlight as an atomic may be confusing. 00:08 < cfields> jonasschnelli: just looks like it should either be non-atomic and require the lock, or be atomic and possibly out of sync. 00:09 < jonasschnelli> Okay... let me check that again. Thanks for pointing out. 00:10 < cfields> jonasschnelli: (i haven't looked deeply, so no idea if it makes sense), maybe useful to trigger a gui event for mapBlocksInFlight.erase(), similar to the other recent changes like that? 00:10 < cfields> that way you'd keep it cached at the gui and not have to query the other way? 00:11 < jonasschnelli> cfields: But wouldn't mapBlocksInFlight.erase() not result in still downloading the blocks? 00:11 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:11 < jonasschnelli> IMO what the GUI should know is how many blocks are still "in transit" when someone pressed "pause"... 00:11 < jonasschnelli> because you won't stop a peer of sending you the already requestes blocks... 00:12 < jonasschnelli> and you should accept them,... 00:12 < jonasschnelli> *the peer should accept them 00:13 < cfields> jonasschnelli: i just mean add a gui event for when mapBlocksInFlight is added to or removed. that way the gui gets notifications for each change, and doesn't have to try to query 00:13 < jonasschnelli> aha... yeah. That would work.. though seems a bit an overkill to add a signal for that... but maybe not. 00:14 < cfields> jonasschnelli: yea, that's the part i wasn't sure about. I only mentioned because it's the direction things have been going in lately. 00:15 < jonasschnelli> Yes. That's true. Maybe its useful for other stuff as well.. 00:15 < jonasschnelli> What are the downside of the atomic approach? Calling the getter in the middle of an "update sequence"? 00:19 < cfields> yea, possible off-by-one in some future code i guess. unlikely to be an actual issue probably, just feels a bit icky to introduce a race strictly because the non-racy path would require the slow lock :( 00:20 < cfields> s/race/de-sync/, i suppose 00:22 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 00:22 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 00:33 -!- Cheeseo [~x@unaffiliated/cheeseo] has quit [Read error: Connection reset by peer] 00:48 -!- justan0theruser is now known as justanotheruser 00:56 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 00:57 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 01:05 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 01:07 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 01:10 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #bitcoin-core-dev 01:12 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 01:13 -!- JackH [~laptop@79-73-189-229.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev 01:21 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 01:22 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:32 -!- vicenteH [~user@195.235.96.150] has joined #bitcoin-core-dev 01:43 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds] 01:44 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 01:58 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 02:01 -!- gielbier [~michiel@unaffiliated/gielbier] has quit [Quit: Leaving] 02:37 -!- xczcsadsa [c6b0bfc9@gateway/web/freenode/ip.198.176.191.201] has joined #bitcoin-core-dev 02:38 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 02:42 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 02:50 -!- xczcsadsa [c6b0bfc9@gateway/web/freenode/ip.198.176.191.201] has quit [Quit: Page closed] 02:53 -!- AaronvanW [~AaronvanW@5.79.76.38] has joined #bitcoin-core-dev 02:53 -!- AaronvanW [~AaronvanW@5.79.76.38] has quit [Changing host] 02:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:57 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 02:58 -!- riemann [~riemann@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 02:58 -!- riemann [~riemann@84-10-11-234.static.chello.pl] has quit [Remote host closed the connection] 02:59 -!- riemann [~riemann@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 03:03 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 268 seconds] 03:36 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 03:37 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 03:55 -!- jcliff42 [~jcliff42@c-50-168-87-98.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 04:11 -!- jcliff42 [~jcliff42@c-50-168-87-98.hsd1.ca.comcast.net] has quit [Remote host closed the connection] 04:11 -!- jcliff42 [~jcliff42@c-50-168-87-98.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 04:16 -!- jcliff42 [~jcliff42@c-50-168-87-98.hsd1.ca.comcast.net] has quit [Ping timeout: 268 seconds] 04:30 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds] 04:31 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 272 seconds] 04:33 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 04:33 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 04:46 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 258 seconds] 04:49 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 05:08 -!- jtimon [~quassel@117.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 05:09 -!- str4d [~str4d@27.110.123.91] has joined #bitcoin-core-dev 05:27 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 05:30 -!- moli_ [~molly@unaffiliated/molly] has quit [Ping timeout: 246 seconds] 05:31 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 05:34 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 268 seconds] 05:38 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 05:42 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 05:51 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 05:53 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 05:54 -!- moli_ [~molly@unaffiliated/molly] has quit [Ping timeout: 255 seconds] 05:57 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 05:58 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 06:02 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 06:24 -!- str4d [~str4d@27.110.123.91] has quit [Quit: Leaving] 06:24 -!- str4d [~str4d@27.110.123.91] has joined #bitcoin-core-dev 06:31 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 06:31 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 06:44 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Quit: WeeChat 0.4.2] 06:46 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 06:47 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 06:50 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 06:50 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Client Quit] 07:01 -!- molz_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 07:04 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 07:06 -!- Sprh [~Sprh@12.20.48.10] has joined #bitcoin-core-dev 07:10 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 07:15 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 07:18 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 07:20 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 07:20 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 07:21 -!- str4d [~str4d@27.110.123.91] has quit [Ping timeout: 268 seconds] 07:22 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 07:22 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 07:24 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 07:24 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 07:26 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 07:28 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 07:29 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 07:34 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 268 seconds] 07:40 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 07:50 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has joined #bitcoin-core-dev 07:51 < bitcoin-git> [bitcoin] practicalswift opened pull request #10409: [tests] Add fuzz testing for BlockTransactions (BLOCKTXN) and BlockTransactionsRequest (GETBLOCKTXN) deserialization (master...fuzz-blocktransactions) https://github.com/bitcoin/bitcoin/pull/10409 08:06 -!- QBcrusher [~QBcrusher@cpe-173-88-70-206.columbus.res.rr.com] has quit [Ping timeout: 240 seconds] 08:42 -!- riemann [~riemann@84-10-11-234.static.chello.pl] has quit [Quit: Leaving] 08:44 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 08:45 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 08:48 < bitcoin-git> [bitcoin] ryanofsky opened pull request #10410: Fix importwallet edge case rescan bug (master...pr/scanimp) https://github.com/bitcoin/bitcoin/pull/10410 09:16 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 09:59 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds] 10:15 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 10:17 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 10:18 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 10:18 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 10:19 -!- molz_ [~molly@unaffiliated/molly] has quit [Ping timeout: 246 seconds] 10:29 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 10:31 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 10:31 -!- paveljanik [~paveljani@79.98.72.176] has joined #bitcoin-core-dev 10:31 -!- paveljanik [~paveljani@79.98.72.176] has quit [Changing host] 10:31 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 10:33 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev 10:42 -!- vicenteH [~user@195.235.96.150] has quit [Ping timeout: 268 seconds] 10:43 -!- d9b4bef9 [~d9b4bef9@207.38.86.239] has quit [Remote host closed the connection] 10:44 -!- d9b4bef9 [~d9b4bef9@207.38.86.239] has joined #bitcoin-core-dev 10:46 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 10:47 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 10:47 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Remote host closed the connection] 10:52 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev 11:00 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Remote host closed the connection] 11:11 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds] 11:18 -!- Cheeseo [~x@unaffiliated/cheeseo] has joined #bitcoin-core-dev 11:20 -!- Sprh [~Sprh@12.20.48.10] has quit [Read error: Connection reset by peer] 11:23 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 11:26 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 11:28 -!- twistedline_ [~quassel@unaffiliated/twistedline] has joined #bitcoin-core-dev 11:29 -!- twistedline [~quassel@unaffiliated/twistedline] has quit [Ping timeout: 246 seconds] 11:29 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev 11:29 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Remote host closed the connection] 11:29 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev 11:41 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 11:43 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 11:59 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Remote host closed the connection] 12:24 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 12:30 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 12:32 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 12:37 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 12:38 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 12:39 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 12:40 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 12:41 -!- LeMiner [LeMiner@unaffiliated/leminer] has quit [Read error: Connection reset by peer] 12:44 < Chris_Stewart_5> If I have a transaction that spends a raw witness spk and the input is already signed on the spending tx, and then I'm trying to call fundrawtransaction to add a fee. Is this currently unsupported in bitcoin core? Do I need to use P2SH(P2WSH)? 12:50 -!- vicenteH [~user@135.234.15.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 12:58 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 13:00 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 13:01 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 13:02 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 13:04 < bitcoin-git> [bitcoin] ryanofsky opened pull request #10412: Improve wallet rescan API (master...pr/scanclean) https://github.com/bitcoin/bitcoin/pull/10412 13:05 -!- moli_ [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 13:07 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev 13:09 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Remote host closed the connection] 13:17 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev 13:19 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 13:21 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Ping timeout: 245 seconds] 13:21 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds] 13:30 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev 13:30 -!- moli_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 13:32 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 246 seconds] 13:40 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 13:41 -!- moli_ [~molly@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 13:52 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 13:52 -!- cryptapus is now known as cryptapus_afk 14:30 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 14:31 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 14:36 -!- harrymm [~wayne@104.237.91.12] has quit [Read error: Connection reset by peer] 14:42 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 14:43 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 14:53 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 14:54 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 14:54 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Remote host closed the connection] 15:04 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 15:05 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 15:12 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 246 seconds] 15:12 -!- JackH [~laptop@79-73-189-229.dynamic.dsl.as9105.com] has quit [Quit: Leaving] 15:14 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev 15:16 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 15:18 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 15:21 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has quit [Quit: Leaving] 15:23 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Remote host closed the connection] 15:28 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 15:45 -!- vicenteH [~user@135.234.15.37.dynamic.jazztel.es] has quit [Ping timeout: 246 seconds] 15:45 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev 16:09 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Remote host closed the connection] 16:09 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev 16:31 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 16:35 -!- justan0theruser is now known as justanotheruser 16:40 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 16:43 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Client Quit] 16:54 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has quit [Ping timeout: 255 seconds] 16:58 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 17:05 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 17:12 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 17:15 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Remote host closed the connection] 17:15 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev 17:20 -!- twistedline_ [~quassel@unaffiliated/twistedline] has quit [Ping timeout: 240 seconds] 17:21 -!- twistedline [~quassel@unaffiliated/twistedline] has joined #bitcoin-core-dev 17:23 -!- cryptapus [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev 17:23 -!- cryptapus [~cryptapus@jupiter.osmus.org] has quit [Changing host] 17:23 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 17:23 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 268 seconds] 17:29 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 17:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:34 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev 17:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds] 17:51 -!- marcoagner [~user@187.113.151.221] has quit [Read error: Connection reset by peer] 17:52 -!- marcoagner [~user@187.113.151.221] has joined #bitcoin-core-dev 18:12 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Remote host closed the connection] 18:27 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-tywysrwbtwdekvcg] has quit [Quit: Connection closed for inactivity] 18:29 -!- PaulCape_ [~PaulCapes@136.24.141.225] has quit [Quit: .] 18:31 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 18:32 -!- PaulCapestany [~PaulCapes@2604:5500:17:2ea:61d1:8f13:8837:549b] has joined #bitcoin-core-dev 18:34 -!- juscamarena_ [~justin@47.148.176.74] has quit [Remote host closed the connection] 18:34 -!- juscamarena_ [~justin@47.148.176.74] has joined #bitcoin-core-dev 18:38 -!- Dyaheon [~Dya@a91-156-192-24.elisa-laajakaista.fi] has quit [Ping timeout: 240 seconds] 18:40 -!- Dyaheon [~Dya@a91-156-192-24.elisa-laajakaista.fi] has joined #bitcoin-core-dev 18:41 < achow101> what's everyone's thoughts on bip 148 and 149? 18:44 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Ping timeout: 268 seconds] 18:45 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 18:46 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 18:50 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Ping timeout: 272 seconds] 18:51 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 268 seconds] 18:52 -!- Alina-malina [~Alina-mal@37.157.223.80] has joined #bitcoin-core-dev 18:52 < Chris_Stewart_5> So reading more about BIP8 I don't think it is necessarily a great idea to not have the possibility for a soft fork to fail 18:53 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 18:53 -!- jcliff42 [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev 18:57 < Chris_Stewart_5> unless they fail somehow silently by not having nodes upgrade 18:57 -!- jcliff42_ [~jcliff42@4.16.87.162] has joined #bitcoin-core-dev 19:00 -!- jcliff42 [~jcliff42@4.16.87.162] has quit [Ping timeout: 268 seconds] 19:01 < Chris_Stewart_5> If I understand BIP148 correctly, it is advocating for oprhaning > 50% of the hash rates blocks? 19:01 < Chris_Stewart_5> "By orphaning non-signalling blocks during the last month of the BIP9 bit 1 "segwit" deployment, this BIP can cause the existing "segwit" deployment to activate without needing to release a new deployment. " 19:02 -!- jcliff42_ [~jcliff42@4.16.87.162] has quit [Ping timeout: 268 seconds] 19:03 < sipa> Chris_Stewart_5: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2017-April/014152.html 19:14 < bitcoin-git> [bitcoin] RHavar opened pull request #10413: Fix docs (there's no rpc command setpaytxfee) (master...patch-2) https://github.com/bitcoin/bitcoin/pull/10413 19:24 < Chris_Stewart_5> Would there be any harm in writing code to provide to miners to *avoid* selecting segwit txs to put in their blocks? That way miners that don't support segwit for whatever reason won't select them for their blocks? Or is that already the case? 19:25 < sipa> that's already the case 19:25 < sipa> if you connect miner software that doesn't support segwit to bitcoind, GBT will only include non-segwit txn 19:26 < sipa> (since 0.14) 19:31 -!- jnewshoes [~jodie@blk-215-123-241.eastlink.ca] has quit [Quit: WeeChat 1.0.1] 19:48 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 19:48 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 19:50 -!- Alina-malina [~Alina-mal@37.157.223.80] has quit [Ping timeout: 260 seconds] 19:53 -!- Alina-malina [~Alina-mal@37.157.223.80] has joined #bitcoin-core-dev 20:09 < luke-jr> Chris_Stewart_5: no, it's advocating for 100% of the hashrate to signal segwit 20:09 < luke-jr> very strongly advocating 20:10 -!- LeMiner [LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has joined #bitcoin-core-dev 20:10 -!- LeMiner [LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has quit [Changing host] 20:10 -!- LeMiner [LeMiner@unaffiliated/leminer] has joined #bitcoin-core-dev 20:14 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds] 20:15 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:39 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 20:41 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 20:43 -!- Dyaheon [~Dya@a91-156-192-24.elisa-laajakaista.fi] has quit [Ping timeout: 240 seconds] 20:43 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has quit [Quit: Leaving.] 20:45 -!- Dyaheon [~Dya@a91-156-192-24.elisa-laajakaista.fi] has joined #bitcoin-core-dev 20:47 -!- ajd_ [~Anthony@2001:470:daef:e1e1:27a3:b8c8:9db:79f6] has quit [Quit: Leaving] 20:51 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds] 20:52 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 21:58 -!- Squidicuz [~squid@pool-108-26-156-99.bstnma.fios.verizon.net] has quit [Quit: Oh no, not again] 22:21 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 22:23 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 22:27 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 22:28 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 22:29 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has joined #bitcoin-core-dev 22:30 -!- goksinen [~goksinen@rrcs-50-75-193-138.nyc.biz.rr.com] has quit [Remote host closed the connection] 22:39 -!- Squidicuz [~squid@pool-108-26-156-99.bstnma.fios.verizon.net] has joined #bitcoin-core-dev 22:44 < gmaxwell> aww 22:45 < gmaxwell> 2017-05-17 05:43:33 Recovering log #177650 22:45 < gmaxwell> 2017-05-17 05:43:35 /home/gmaxwell/.bitcoin/blocks/index/177650.log: dropping 30275 bytes; Corruption: checksum mismatch 22:45 < gribble> https://github.com/bitcoin/bitcoin/issues/177650 | HTTP Error 404: Not Found 22:45 < gmaxwell> 2017-05-17 05:43:35 Corruption: checksum mismatch 22:45 < gmaxwell> saddness. 22:45 < gmaxwell> 2017-05-17 05:43:35 Database corrupted 23:00 -!- dermoth [~thomas@dsl-199-102-159-103.mtl.aei.ca] has quit [Read error: Connection reset by peer] 23:00 -!- dermoth [~thomas@dsl-199-102-159-103.mtl.aei.ca] has joined #bitcoin-core-dev 23:05 < gmaxwell> also telling me to reindex chainstate on a blocks index corruption isn't so helpful. 23:11 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/95546c859b71...b45a52aeff0a 23:11 < bitcoin-git> bitcoin/master 1530bfc Suhas Daftuar: Add logging to FinalizeNode() 23:11 < bitcoin-git> bitcoin/master b45a52a Wladimir J. van der Laan: Merge #10404: doc: Add logging to FinalizeNode()... 23:12 < bitcoin-git> [bitcoin] laanwj closed pull request #10404: doc: Add logging to FinalizeNode() (master...2017-05-log-finalize-node) https://github.com/bitcoin/bitcoin/pull/10404 23:13 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b45a52aeff0a...541199788c10 23:13 < bitcoin-git> bitcoin/master fac79e4 MarcoFalke: qa: Warn when specified test is not found 23:13 < bitcoin-git> bitcoin/master 5411997 Wladimir J. van der Laan: Merge #10374: qa: Warn when specified test is not found... 23:13 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-nkaqwqnwixawvpnl] has joined #bitcoin-core-dev 23:13 < bitcoin-git> [bitcoin] laanwj closed pull request #10374: qa: Warn when specified test is not found (master...Mf1705-qaWarnTestNotFound) https://github.com/bitcoin/bitcoin/pull/10374 23:22 < paveljanik> jtimon, ping 23:23 < paveljanik> jtimon, GetDustThreshold's dustRelayFee is shadowing global ::dustRelayFee, but is always called with it as an argument. Do you prefer removing it and use ::dustRelayFee instead or renaming the argument name to prevent shadowing warnings? 23:24 < paveljanik> The same applies to IsDust 23:42 -!- marcoagner [~user@187.113.151.221] has quit [Ping timeout: 240 seconds] 23:54 -!- marcoagner [~user@179.177.244.150] has joined #bitcoin-core-dev 23:57 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds]