--- Day changed Sun Jun 04 2017 00:01 -!- d9b4bef9 [~d9b4bef9@207.38.86.239] has quit [Remote host closed the connection] 00:01 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 00:02 -!- d9b4bef9 [~d9b4bef9@207.38.86.239] has joined #bitcoin-core-dev 00:06 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 00:12 -!- kadoban [~mud@unaffiliated/kadoban] has quit [Quit: bye] 01:00 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds] 01:18 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 01:19 -!- chjj [~chjj@unaffiliated/chjj] has quit [Client Quit] 01:19 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 01:38 -!- Guest60935 [~john@host86-147-127-48.range86-147.btcentralplus.com] has joined #bitcoin-core-dev 01:56 -!- mkarrer [~mkarrer@158.red-83-53-16.dynamicip.rima-tde.net] has quit [Ping timeout: 272 seconds] 02:10 -!- goatturner [~Beatrootg@2a02:c7d:12e:100:d04d:ef6d:1774:2713] has joined #bitcoin-core-dev 02:34 -!- jtimon [~quassel@117.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 02:35 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 02:52 -!- tunafizz [~tuna@c-71-207-56-72.hsd1.pa.comcast.net] has quit [Ping timeout: 246 seconds] 02:52 -!- tunafizz [~tuna@c-71-207-56-72.hsd1.pa.comcast.net] has joined #bitcoin-core-dev 03:29 -!- Yogaqueef [~textual@dsl-hkibrasgw3-58c3d4-235.dhcp.inet.fi] has joined #bitcoin-core-dev 03:33 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:789f:4069:c5e5:c9f9] has joined #bitcoin-core-dev 03:37 -!- goatturner [~Beatrootg@2a02:c7d:12e:100:d04d:ef6d:1774:2713] has quit [Ping timeout: 255 seconds] 03:39 -!- Yogaqueef [~textual@dsl-hkibrasgw3-58c3d4-235.dhcp.inet.fi] has quit [Quit: My iMac has gone to sleep. ZZZzzz…] 04:10 -!- jouke [~worst@unaffiliated/komkommer] has quit [Remote host closed the connection] 04:12 -!- jouke [~worst@2001:1c02:1600:9200:2170:6453:c1e4:16e4] has joined #bitcoin-core-dev 04:12 -!- jouke [~worst@2001:1c02:1600:9200:2170:6453:c1e4:16e4] has quit [Changing host] 04:12 -!- jouke [~worst@unaffiliated/komkommer] has joined #bitcoin-core-dev 04:28 -!- btcdrak [uid230524@gateway/web/irccloud.com/x-ohjzrkakcyttkdgw] has joined #bitcoin-core-dev 04:36 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 04:37 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 04:42 -!- mkarrer [~mkarrer@158.red-83-53-16.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 05:06 -!- jtimon [~quassel@117.29.134.37.dynamic.jazztel.es] has quit [Ping timeout: 255 seconds] 05:06 -!- BobBarker [~null@2607:5300:60:1c3f::] has quit [Ping timeout: 260 seconds] 05:18 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:7026:5a50:c53:e858] has joined #bitcoin-core-dev 05:22 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:789f:4069:c5e5:c9f9] has quit [Ping timeout: 260 seconds] 05:31 -!- spudowiar [~spudowiar@unaffiliated/saleemrashid] has joined #bitcoin-core-dev 05:31 < spudowiar> What's your preference for starting a process and piping data? 05:31 < spudowiar> fork, pipe, dup2? 05:31 < spudowiar> I mean pipe, fork , dup2 05:32 < spudowiar> popen won't work because it only supports one direction 05:33 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Ping timeout: 240 seconds] 05:36 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 05:47 -!- nemgun [~nemgun@105.101.99.1] has joined #bitcoin-core-dev 05:53 < spudowiar> Actually, Boost dependency was updated to 1.64.0 which has boost::process 05:56 -!- nemgun [~nemgun@105.101.99.1] has quit [Read error: Connection reset by peer] 05:56 -!- nemgun [~nemgun@105.101.99.1] has joined #bitcoin-core-dev 06:08 -!- Alina-malina [~Alina-mal@37.157.223.80] has joined #bitcoin-core-dev 06:09 -!- Alina-malina [~Alina-mal@37.157.223.80] has quit [Changing host] 06:09 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev 06:13 -!- LeMiner [LeMiner@unaffiliated/leminer] has quit [Read error: Connection reset by peer] 06:16 -!- jtimon [~quassel@117.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 06:35 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:1993:8b4c:e1db:283b] has joined #bitcoin-core-dev 06:36 -!- LeMiner [LeMiner@unaffiliated/leminer] has joined #bitcoin-core-dev 06:38 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:7026:5a50:c53:e858] has quit [Ping timeout: 245 seconds] 06:46 -!- LeMiner [LeMiner@unaffiliated/leminer] has quit [Read error: Connection reset by peer] 06:49 -!- LeMiner [LeMiner@unaffiliated/leminer] has joined #bitcoin-core-dev 06:50 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 06:55 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Ping timeout: 255 seconds] 06:56 -!- LeMiner [LeMiner@unaffiliated/leminer] has quit [Read error: Connection reset by peer] 06:59 -!- LeMiner [LeMiner@unaffiliated/leminer] has joined #bitcoin-core-dev 07:04 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 272 seconds] 07:05 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 07:07 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev 07:08 -!- LeMiner [LeMiner@unaffiliated/leminer] has quit [Read error: Connection reset by peer] 07:10 -!- LeMiner [LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has joined #bitcoin-core-dev 07:10 -!- LeMiner [LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has quit [Changing host] 07:10 -!- LeMiner [LeMiner@unaffiliated/leminer] has joined #bitcoin-core-dev 07:24 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Ping timeout: 248 seconds] 07:25 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:3114:4abd:6cc8:1e4a] has joined #bitcoin-core-dev 07:27 -!- wasi [~wasi@gateway/tor-sasl/wasi] has joined #bitcoin-core-dev 07:29 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:1993:8b4c:e1db:283b] has quit [Ping timeout: 260 seconds] 07:30 -!- d9b4bef9 [~d9b4bef9@207.38.86.239] has quit [Remote host closed the connection] 07:33 -!- d9b4bef9 [~d9b4bef9@207.38.86.239] has joined #bitcoin-core-dev 07:34 -!- d9b4bef9 [~d9b4bef9@207.38.86.239] has quit [Remote host closed the connection] 07:35 -!- d9b4bef9 [~d9b4bef9@207.38.86.239] has joined #bitcoin-core-dev 07:56 -!- Chris_Stewart_5 [~chris@173-31-39-168.client.mchsi.com] has joined #bitcoin-core-dev 08:09 < spudowiar> One issue I have is that waiting for the output of the command is run on the UI thread, so Bitcoin Core appears to hang :/ 08:10 -!- str4d [~str4d@27.110.123.91] has quit [Ping timeout: 255 seconds] 08:12 -!- Guest60935 [~john@host86-147-127-48.range86-147.btcentralplus.com] has quit [Ping timeout: 260 seconds] 08:24 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds] 08:27 -!- Guest60935 [~john@host86-147-127-48.range86-147.btcentralplus.com] has joined #bitcoin-core-dev 08:28 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 255 seconds] 08:40 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:d8c7:28b1:a068:d420] has joined #bitcoin-core-dev 08:43 -!- goatturner [~Beatrootg@2a02:c7d:12e:100:1925:1888:5494:9da6] has joined #bitcoin-core-dev 08:44 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:3114:4abd:6cc8:1e4a] has quit [Ping timeout: 260 seconds] 08:45 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 08:46 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:d8c7:28b1:a068:d420] has quit [Ping timeout: 255 seconds] 08:55 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Read error: Connection reset by peer] 09:04 -!- owowo [~ovovo@185.183.104.83] has joined #bitcoin-core-dev 09:04 -!- owowo [~ovovo@185.183.104.83] has quit [Changing host] 09:04 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 09:04 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has quit [Ping timeout: 260 seconds] 09:09 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 246 seconds] 09:12 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 09:23 -!- kadoban [~mud@unaffiliated/kadoban] has joined #bitcoin-core-dev 09:52 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-rhiqiojxbuwtiojo] has joined #bitcoin-core-dev 10:16 -!- DCLXVI` is now known as dclxvi 10:18 < BlueMatt> luke-jr: you appear to have seemingly removed nearly all nuance 10:18 < BlueMatt> luke-jr: you should have a category like "Fine, iff there is massive community consensus that doesnt nearly yet exist" 10:18 < BlueMatt> then you could probably drop almost everyone into that category 10:31 -!- Guest34260 [~john@host86-147-127-48.range86-147.btcentralplus.com] has joined #bitcoin-core-dev 10:32 -!- Guest60935 [~john@host86-147-127-48.range86-147.btcentralplus.com] has quit [Ping timeout: 260 seconds] 10:40 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 10:42 -!- arubi is now known as `arubi 10:43 < luke-jr> BlueMatt: that's kinda chicken-and-egg. people are deferring to dev pessimism as a reason to not consent themselves. but if you have a suggestion to get more nuance on the wiki page, we can do that anyway. Perhaps a yellow "Wanting" defined as "it is acceptable, only with more community acceptance"? 10:43 -!- `arubi is now known as arubi 10:44 < BlueMatt> luke-jr: i didnt say "want", i said "fuck no, not without a massive consensus success, which appears to have about zero chance at this moment" 10:44 < BlueMatt> luke-jr: and, no, while some rando folks are deferring to devs there, a lot are not, and are flat out saying "this is stupid" 10:44 < luke-jr> I was thinking "wanting" as in "I think it is wanting for support"; alternative table-fitting words? 10:45 < luke-jr> BlueMatt: people against BIP148 on their own are a very small group 10:45 < gmaxwell> luke-jr: perhaps you should take it seriously when many people are telling you that this is a lot like Bitcoin XT or Bitcoin Classic's hardfork, but you've just defined yourself into a corner. 10:47 < BlueMatt> luke-jr: people against classic and xt initially were a very small group, fwiw, its only after it became clear that there was a lack of consensus and serious technical concern that folks started jumping ship 10:49 < BlueMatt> luke-jr: a series of people saying "this is too risky, I cannot support" (and i mean not just dev folks, also several biz folks have made similar noise) should not imply "ok, full steam ahead, they'll come around" 10:49 < luke-jr> there is no comparison. Classic/XT were hardfork proposals with serious technical problems and done by trolls who wanted to "fire Core". BIP148 is a softfork proposal with no real technical problems, and widespread community support. 10:49 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:1c74:38b3:23fb:d6a] has joined #bitcoin-core-dev 10:50 < BlueMatt> luke-jr: I was told my several of the most ardent 148 supporters last week that 148 will "fire core" cause core is now getting in the way 10:50 < luke-jr> BlueMatt: not doing BIP148 is objectively riskier than BIP148 itself, which has no risk at all given sufficient support. 10:50 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:d14d:3756:ae69:2e4e] has joined #bitcoin-core-dev 10:50 < BlueMatt> luke-jr: that is your opinion. other equally-well-informed minds strongly disagree 10:52 -!- goatturner [~Beatrootg@2a02:c7d:12e:100:1925:1888:5494:9da6] has quit [Ping timeout: 255 seconds] 10:53 < BlueMatt> luke-jr: and, key to your point is "given sufficient support", but, then, "given sufficient support" nearly any consensus change becomes incredibly easy 10:54 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:1c74:38b3:23fb:d6a] has quit [Ping timeout: 240 seconds] 10:54 < BlueMatt> luke-jr: and most of what I'm telling you is that bip 148 can not, and will not, get sufficient support in the current community 10:55 < luke-jr> it already has it; the only potential risk is people blindly following "Core" who think "Core" is opposed 10:57 < midnightmagic> Don't use language that guarantees people can't work together anymore after the resolution becomes clear. There are *actually* bad people sharpening their knives watching. 10:58 < luke-jr> midnightmagic: ? referring to what 10:59 < midnightmagic> This escalation that's going on in here right now, and jerkoffs who are going to attempt to use it to harm you all in the near future. 11:05 < sipa> luke-jr: also don't equate "against merging support for BIP148 in core" with "against BIP148" 11:07 < sipa> the bar for the first is far higher than personal preferences 11:07 < luke-jr> sipa: are you of a position that BIP148 should not be merged, but you don't oppose it personally? 11:07 < luke-jr> (the wiki page is intended to be the latter) 11:08 < sipa> if there were pervasive support for BIp148, i would encourage it 11:09 < sipa> right now, i think it is too risky (for a combination of technical reasons, too short timeframe, and me not seeing the degree of support i believe is necessary to make it a success) to encourage anyone to run it 11:09 < sipa> but i'm not opposed to it in principle... in particular, i'd like be proven wrong on the degree of support which is admitted hard to measure 11:10 < sipa> *admittedly 11:13 < luke-jr> okay, I've updated the wiki page with two new categories Deficient and Wanting, and reclassified BIP148 for Matt as Deficient and sipa as Wanting; hope this is accurate 11:13 < luke-jr> aside from BIP148, it would be helpful to get positions on the other proposals on the page 11:14 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 11:14 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 240 seconds] 11:15 < luke-jr> (and feel free to edit descriptions/colours/add new categories/etc if you think it helps improve clarity) 11:17 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 11:20 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:e4a0:1783:f402:a2d3] has joined #bitcoin-core-dev 11:21 < spudowiar> Hmm, either this transaction is totally messed up or EncodeHexTx is totally messing it up 11:22 < spudowiar> Or python-bitcoinlib is messed up 11:23 < spudowiar> Right, decoderawtransaction is working fine on this tx 11:23 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:d14d:3756:ae69:2e4e] has quit [Ping timeout: 240 seconds] 11:25 < spudowiar> Oh, wait, this is a SegWit tx 11:25 < spudowiar> I assume that python-bitcoinlib doesn't handle SegWit 11:25 < spudowiar> Right, petertodd? 11:29 < spudowiar> *celebrates* 11:32 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/098b01dc58ff...400fdd08cc95 11:32 < bitcoin-git> bitcoin/master 5f672ca Pavlos Antoniou: net: Denote some CNode functions const 11:32 < bitcoin-git> bitcoin/master 400fdd0 Pieter Wuille: Merge #10471: Denote functions CNode::GetRecvVersion() and CNode::GetRefCount() as const... 11:33 -!- BobBarker [~null@2607:5300:60:1c3f::] has joined #bitcoin-core-dev 11:33 < bitcoin-git> [bitcoin] sipa closed pull request #10471: Denote functions CNode::GetRecvVersion() and CNode::GetRefCount() as const (master...master) https://github.com/bitcoin/bitcoin/pull/10471 11:38 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 11:49 < bitcoin-git> [bitcoin] sipa opened pull request #10526: Force on-the-fly compaction during pertxout upgrade (master...compactrange) https://github.com/bitcoin/bitcoin/pull/10526 11:58 < spudowiar> GAHH 11:58 < spudowiar> It signed it, it sent it back to Core and Core failed the verification 12:10 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 12:10 -!- belcher [~belcher@unaffiliated/belcher] has quit [Remote host closed the connection] 12:15 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 255 seconds] 12:17 < spudowiar> On one hand, it's failing the verification 12:17 < spudowiar> On the other, it's doing a valid transaction that sendrawtransaction can broadcast 12:20 < spudowiar> Oh, FML 12:20 < spudowiar> I did IsHardwareWallet && !CallHardwareWallet 12:20 < spudowiar> Which means if it's successful, it will carry on and fail :( 12:20 < spudowiar> (It will do the else part) 12:21 < spudowiar> Yes! Hardware wallet support works! 12:26 < spudowiar> sipa: I ended up doing a signrawtransaction-esque API https://github.com/saleemrashid/bitcoin/blob/hardware-wallet/src/wallet/wallet.cpp#L1489-L1527 12:26 < spudowiar> But instead of privkeys, it does the hdKeypath 12:26 < spudowiar> And it adds a transaction key to each of the prevtxs with the raw transaction 12:28 < spudowiar> Here's the plugin: https://github.com/saleemrashid/bitcoin/blob/hardware-wallet/contrib/bitcoin-hww-trezor 12:28 < spudowiar> jonasschnelli, luke-jr, NicolasDorier: ^^ 12:29 < jonasschnelli> 75 lines? 12:29 < jonasschnelli> Can you make it vendor independent? :) 12:29 < spudowiar> You need another script for each vendor :) 12:30 < jonasschnelli> I guess we need a standard 12:30 < luke-jr> jonasschnelli: the whole point is that the script is the interface 12:30 < spudowiar> The command is `src/qt/bitcoin-qt -testnet -hardwarewallet=contrib/bitcoin-hww-trezor` 12:30 < spudowiar> Or bitcoind if that floats your boat :) 12:31 < jonasschnelli> ah. I see. 12:31 < jonasschnelli> I though the script is the only thing you need 12:31 < spudowiar> You have a script for each hardware wallet, and you set -hardwarewallet= to the script 12:32 < spudowiar> One issue with this patch is that it runs on the UI thread so Bitcoin-Qt hangs while you confirm it on the hardware wallet 12:32 < sipa> that sounds pretty bad :) 12:32 < luke-jr> could be worse 12:32 < luke-jr> but definitely something to fix 12:32 < spudowiar> luke-jr, always optimistic 12:33 < spudowiar> There are issues about moving stuff off the UI thread so I didn't bother with it at the moment 12:33 < spudowiar> When CreateTransaction gets moved off the UI thread, this will fix itself 12:34 < luke-jr> spudowiar: you mean sign? 12:34 < luke-jr> IMO we should prompt in GUI for fee/etc before trying to sign 12:34 < spudowiar> Well, CreateTransaction calls the signature stuff 12:35 < spudowiar> Whoops, need to add CallHardwareWallet into CWallet::SignTransaction as well 12:36 < spudowiar> Anyway, one issue is that it's not doing change addresses right ATM 12:36 < spudowiar> So, it sees them as an extra output 12:36 < sipa> is that a problem? 12:36 < spudowiar> Yes, but it's one I can fix :) 12:36 < spudowiar> Because the hardware wallet isn't meant to show the change addresses 12:37 < bitcoin-git> [bitcoin] practicalswift opened pull request #10527: Use parentheses to clarify intended precedence when using bitwise operations (master...clarify-precedence) https://github.com/bitcoin/bitcoin/pull/10527 12:37 < spudowiar> e.g. I sent 0.7 tBTC and I had 1.3 tBTC, so the TREZOR asked me to send 1.299 tBTC when it should have said 0.7 tBTC 12:38 -!- Chris_Stewart_5 [~chris@173-31-39-168.client.mchsi.com] has quit [Ping timeout: 260 seconds] 12:40 < sipa> right; i guess you should have a way to tell the hardware "output X is to derivation path Y, which is yours; don't include it in the amount" 12:40 < spudowiar> Also, this doesn't look good https://github.com/saleemrashid/bitcoin/blob/hardware-wallet/contrib/bitcoin-hww-trezor#L54 12:41 < spudowiar> I shouldn't have to reverse it 12:42 < sipa> for historical reasons, bitcoin treats txids as little-endian 256-bit numbers, and when printing them for human consumption, uses big-endian (because that's how we format numbers) 12:42 < sipa> as a result, the hex string is in the opposite order from the actual bytes 12:43 < spudowiar> I know, but this isn't a hex string 12:43 < spudowiar> I *think* 12:43 < spudowiar> Yeah, it's not a hex string 12:44 < sipa> hmm 12:44 < sipa> still may be some LE/BE confusion 12:44 < spudowiar> Maybe, I'll have a look at my code again another day, do a bit of refactoring 12:45 < spudowiar> gtg 12:45 -!- spudowiar [~spudowiar@unaffiliated/saleemrashid] has quit [Quit: WeeChat 1.8] 12:54 -!- d9b4bef9 [~d9b4bef9@207.38.86.239] has quit [Remote host closed the connection] 12:55 -!- d9b4bef9 [~d9b4bef9@207.38.86.239] has joined #bitcoin-core-dev 12:57 -!- spudowiar [~android@unaffiliated/saleemrashid] has joined #bitcoin-core-dev 13:11 < BlueMatt> luke-jr: ehh, I'm more of the "not really ok with the idea, also considers it to have insufficient community support" view 13:11 -!- betawaffle [~betawaffl@h1.kdf.io] has joined #bitcoin-core-dev 13:11 < luke-jr> BlueMatt: how is that not "No"? 13:12 < BlueMatt> luke-jr: taken separately: I'm ok going along with lots of things that I think are technically not good, if there is real community support for them. 148 falls into that category. Separately, I dont think 148 has or will get sufficient community support 13:13 < BlueMatt> luke-jr: I dunno, your putting folks into buckets idea loses all nuance 13:13 < BlueMatt> luke-jr: you should create a separate category for everyone :) 13:13 < luke-jr> BlueMatt: thoughts on BIP 149, Segwit2x, and COOP? :P 13:13 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has left #bitcoin-core-dev [] 13:14 < BlueMatt> bye andrew :( 13:17 < luke-jr> ? 13:18 < BlueMatt> andytoshi left 13:19 -!- thrasher` [~thrasher@unaffiliated/thrasher/x-7291870] has quit [Ping timeout: 268 seconds] 13:21 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 255 seconds] 13:22 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 13:23 -!- thrasher` [~thrasher@unaffiliated/thrasher/x-7291870] has joined #bitcoin-core-dev 13:35 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has quit [Disconnected by services] 13:37 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has joined #bitcoin-core-dev 13:38 -!- sipa__ [~pw@2001:19f0:ac01:2fb:5400:ff:fe5b:c3ff] has joined #bitcoin-core-dev 13:39 -!- Taek42 [~quassel@2001:41d0:1:472e::] has joined #bitcoin-core-dev 13:39 -!- Chris_Stewart_5 [~chris@173-31-39-168.client.mchsi.com] has joined #bitcoin-core-dev 13:46 -!- da2ce7_ [~da2ce7@opentransactions/dev/da2ce7] has joined #bitcoin-core-dev 13:46 -!- Netsplit *.net <-> *.split quits: profall, mappum, da2ce7, Taek, sipa, ChillazZ, wallet42, michagogo, nsh 13:47 -!- Netsplit over, joins: da2ce7, wallet42, mappum 13:47 -!- da2ce7 [~da2ce7@opentransactions/dev/da2ce7] has quit [Ping timeout: 811 seconds] 13:48 -!- profall [sid29922@gateway/web/irccloud.com/x-tatlvafnspgvcswy] has joined #bitcoin-core-dev 13:48 -!- nsh- [~lol@wikipedia/nsh] has joined #bitcoin-core-dev 13:49 -!- Netsplit over, joins: michagogo 13:49 -!- herzmeister[m] [herzmeiste@gateway/shell/matrix.org/x-sblvdleayruemcwm] has quit [Ping timeout: 255 seconds] 13:50 -!- frabrunelle [frabrunell@safenetwork/frabrunelle] has quit [Ping timeout: 276 seconds] 13:51 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-qbrywcgpbruecjxr] has quit [Ping timeout: 276 seconds] 13:52 -!- Netsplit over, joins: ChillazZ 14:03 -!- herzmeister[m] [herzmeiste@gateway/shell/matrix.org/x-yuvflccbnxgjwtsf] has joined #bitcoin-core-dev 14:07 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-kvwhgybzjxedrpgt] has joined #bitcoin-core-dev 14:07 -!- frabrunelle [frabrunell@safenetwork/frabrunelle] has joined #bitcoin-core-dev 14:39 -!- tiagotrs [~tiago@p5DC4726B.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 14:46 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 255 seconds] 15:03 -!- Guest52697 [~bitcoin@112.208.45.118] has quit [Ping timeout: 260 seconds] 15:05 < aj> luke-jr: wow, your bip148 branch got complicated 15:05 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 15:12 -!- spudowiar [~android@unaffiliated/saleemrashid] has quit [Remote host closed the connection] 15:17 < luke-jr> aj: it now has bugfixes applicable to softforks in general, not specific to BIP148 15:17 < luke-jr> (and not required for BIP148) 15:18 < aj> luke-jr: yep, i found #10512. sounds like an improvement 15:18 < gribble> https://github.com/bitcoin/bitcoin/issues/10512 | Rework same-chain from abusing DoS banning, to explicit checks by luke-jr · Pull Request #10512 · bitcoin/bitcoin · GitHub 15:25 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 255 seconds] 15:27 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 15:29 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:c5bf:fe52:437e:84a] has joined #bitcoin-core-dev 15:32 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:e4a0:1783:f402:a2d3] has quit [Ping timeout: 240 seconds] 15:35 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has joined #bitcoin-core-dev 15:39 -!- chjj_ [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 15:40 -!- PaulCape_ [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has joined #bitcoin-core-dev 15:40 -!- chjj [~chjj@unaffiliated/chjj] has quit [Disconnected by services] 15:40 -!- chjj_ is now known as chjj 15:41 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has quit [Ping timeout: 260 seconds] 15:41 -!- btcdrak [uid230524@gateway/web/irccloud.com/x-ohjzrkakcyttkdgw] has quit [Quit: Connection closed for inactivity] 15:43 -!- tiagotrs [~tiago@p5DC4726B.dip0.t-ipconnect.de] has quit [Quit: leaving] 15:47 -!- str4d [~str4d@27.110.123.91] has joined #bitcoin-core-dev 15:50 -!- Chris_Stewart_5 [~chris@173-31-39-168.client.mchsi.com] has quit [Ping timeout: 255 seconds] 15:56 -!- PaulCape_ [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has quit [Ping timeout: 272 seconds] 15:56 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has joined #bitcoin-core-dev 16:02 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has quit [Ping timeout: 258 seconds] 16:03 -!- PaulCape_ [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has joined #bitcoin-core-dev 16:11 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 16:13 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 16:13 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:81f:940b:35a:d8a8] has joined #bitcoin-core-dev 16:15 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has joined #bitcoin-core-dev 16:16 -!- PaulCape_ [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has quit [Ping timeout: 240 seconds] 16:18 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:c5bf:fe52:437e:84a] has quit [Ping timeout: 272 seconds] 16:29 -!- Guest34260 [~john@host86-147-127-48.range86-147.btcentralplus.com] has quit [Ping timeout: 240 seconds] 16:38 -!- Guest34260 [~john@host86-147-127-48.range86-147.btcentralplus.com] has joined #bitcoin-core-dev 16:48 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 255 seconds] 16:52 -!- jtimon [~quassel@117.29.134.37.dynamic.jazztel.es] has quit [Ping timeout: 268 seconds] 16:58 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has quit [Disconnected by services] 17:00 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has joined #bitcoin-core-dev 17:00 -!- davec_ [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev 17:00 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 17:01 -!- thermoman_ [~thermoman@wtf.foobar0815.de] has joined #bitcoin-core-dev 17:01 -!- thermoman [~thermoman@wtf.foobar0815.de] has quit [Remote host closed the connection] 17:01 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 17:06 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 260 seconds] 17:31 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 255 seconds] 17:32 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 17:47 -!- btcdrak [uid230524@gateway/web/irccloud.com/x-lmcsabxzefaseloo] has joined #bitcoin-core-dev 17:49 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-rhiqiojxbuwtiojo] has quit [Quit: Connection closed for inactivity] 18:14 -!- cryptapus [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev 18:14 -!- cryptapus [~cryptapus@jupiter.osmus.org] has quit [Changing host] 18:14 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 18:14 -!- cryptapus is now known as cryptapus_afk 18:18 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:e4d0:6d57:506c:e5b1] has joined #bitcoin-core-dev 18:22 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:81f:940b:35a:d8a8] has quit [Ping timeout: 272 seconds] 18:23 < NicolasDorier> spudowiar: Awesome. I think you should share that as well with Ledger (btchip), they would probably review and make a plugin. Also it might move forward the conversation about HW standard 18:36 < bitcoin-git> [bitcoin] fanquake closed pull request #10513: Trivial: grammar fix to CONTRIBUTING.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10513 19:00 -!- dermoth [~thomas@dsl-66-36-135-165.mtl.aei.ca] has quit [Read error: Connection reset by peer] 19:01 -!- dermoth [~thomas@dsl-66-36-135-165.mtl.aei.ca] has joined #bitcoin-core-dev 19:18 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 19:19 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 19:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds] 19:25 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 19:26 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Remote host closed the connection] 19:26 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 19:36 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 255 seconds] 19:37 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 19:39 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has quit [Remote host closed the connection] 19:44 -!- nemgun [~nemgun@105.101.99.1] has quit [Quit: Leaving] 20:09 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:a8e8:b322:26f9:126c] has joined #bitcoin-core-dev 20:14 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:e4d0:6d57:506c:e5b1] has quit [Ping timeout: 272 seconds] 20:19 -!- elkalamar [~elkalamar@84.126.69.179.dyn.user.ono.com] has quit [Quit: Leaving] 20:22 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:d07a:ecd:a4b7:f289] has joined #bitcoin-core-dev 20:24 -!- goatturner [~Beatrootg@2a02:c7d:12e:100:55b3:9d54:5d7a:4ed] has joined #bitcoin-core-dev 20:26 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:a8e8:b322:26f9:126c] has quit [Ping timeout: 260 seconds] 20:28 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:d07a:ecd:a4b7:f289] has quit [Ping timeout: 272 seconds] 21:05 -!- d9b4bef9 [~d9b4bef9@207.38.86.239] has quit [Remote host closed the connection] 21:06 -!- d9b4bef9 [~d9b4bef9@207.38.86.239] has joined #bitcoin-core-dev 21:07 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:78a0:500b:4573:8984] has joined #bitcoin-core-dev 21:10 -!- goatturner [~Beatrootg@2a02:c7d:12e:100:55b3:9d54:5d7a:4ed] has quit [Ping timeout: 260 seconds] 21:43 -!- Guest34260 [~john@host86-147-127-48.range86-147.btcentralplus.com] has quit [Ping timeout: 260 seconds] 22:07 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 260 seconds] 22:13 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:b552:f8c7:ddea:cff1] has joined #bitcoin-core-dev 22:17 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:78a0:500b:4573:8984] has quit [Ping timeout: 260 seconds] 22:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 22:25 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds] 22:29 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:849e:37f6:1354:b77a] has joined #bitcoin-core-dev 22:33 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:b552:f8c7:ddea:cff1] has quit [Ping timeout: 260 seconds] 23:16 -!- spudowiar [~android@unaffiliated/saleemrashid] has joined #bitcoin-core-dev 23:17 < spudowiar> NicolasDorier: Will do. I think I'll make a new RPC method (signhwwtransaction) first (because this isn't entirely compatible with signrawtransaction) and then ask him to review it 23:21 -!- spudowiar [~android@unaffiliated/saleemrashid] has quit [Remote host closed the connection] 23:44 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/21e1ed48989e1d150e9f85770fd098534e0f81f1 23:44 < bitcoin-git> bitcoin/0.14 21e1ed4 Wladimir J. van der Laan: doc: Preliminary release notes 0.14.2 23:49 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:849e:37f6:1354:b77a] has joined #bitcoin-core-dev 23:49 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev 23:50 -!- Netsplit *.net <-> *.split quits: lightningbot, davec_, goatturneer, mappum, d_t, ChillazZ, wallet42 23:50 -!- Netsplit over, joins: lightningbot 23:50 -!- Netsplit over, joins: d_t 23:50 -!- wallet42 [sid154231@gateway/web/irccloud.com/x-jlhztpeehcjzodpx] has joined #bitcoin-core-dev 23:50 -!- mappum [sid43795@gateway/web/irccloud.com/x-kuntumheanlljoda] has joined #bitcoin-core-dev 23:58 < NicolasDorier> spudowiar: what? signrawtransaction should just work. I mean the wallet already have all the info needed for a hardware wallet to sign 23:58 < NicolasDorier> so why a new rpc method needed ? oO 23:59 < NicolasDorier> the cool thing if we can reuse signrawtransaction is that moving from software hotwallet to hardware wallet is a configuration change, not a code change for users