--- Day changed Mon Jun 05 2017 00:05 < NicolasDorier> Confirmed devs right now are 00:21 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 00:24 -!- d9b4bef9 [~d9b4bef9@207.38.86.239] has quit [Remote host closed the connection] 00:25 -!- d9b4bef9 [~d9b4bef9@207.38.86.239] has joined #bitcoin-core-dev 00:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 00:32 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has joined #bitcoin-core-dev 00:48 -!- altoz_ [~Jimmy@cpe-24-55-54-186.austin.res.rr.com] has joined #bitcoin-core-dev 00:50 -!- altoz [~Jimmy@cpe-24-55-54-186.austin.res.rr.com] has quit [Ping timeout: 268 seconds] 00:54 -!- paveljanik [~paveljani@79.98.72.176] has joined #bitcoin-core-dev 00:54 -!- paveljanik [~paveljani@79.98.72.176] has quit [Changing host] 00:54 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 01:10 -!- ChillazZ [~ChillazZ@195.30.94.129] has joined #bitcoin-core-dev 01:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:12 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-whymgnqllozxbejz] has joined #bitcoin-core-dev 01:26 -!- jtimon [~quassel@117.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 01:31 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:39 -!- timothy [tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 01:44 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:46 -!- vicenteH [~user@135.234.15.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 01:51 -!- cryptapus [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev 01:51 -!- cryptapus [~cryptapus@jupiter.osmus.org] has quit [Changing host] 01:51 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 01:51 -!- cryptapus is now known as cryptapus_afk 01:54 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 01:57 < bitcoin-git> [bitcoin] Flowdalic opened pull request #10529: Improve bitcoind systemd service file (master...systemd-service) https://github.com/bitcoin/bitcoin/pull/10529 02:00 -!- Guest34260 [~john@host86-147-127-48.range86-147.btcentralplus.com] has joined #bitcoin-core-dev 02:01 < _flow_> #10529 was me, in case you have any questions 02:01 < gribble> https://github.com/bitcoin/bitcoin/issues/10529 | Improve bitcoind systemd service file by Flowdalic · Pull Request #10529 · bitcoin/bitcoin · GitHub 02:24 -!- Guest34260 [~john@host86-147-127-48.range86-147.btcentralplus.com] has quit [Quit: Guest34260] 02:48 -!- spudowiar [~cabox@unaffiliated/saleemrashid] has joined #bitcoin-core-dev 02:49 < spudowiar> NicolasDorier: I meant for the communication with the hardware wallet 02:49 < spudowiar> The hardware wallet plugins use JSON-RPC 02:49 < spudowiar> https://github.com/saleemrashid/bitcoin/blob/hardware-wallet/src/wallet/wallet.cpp#L1526 02:49 < spudowiar> I called the method signrawtransaction, but it's not compatible (as it sends hdKeypaths instead of privkeys) 02:50 < spudowiar> Also, I want to add an identifier, so we can support multiple wallets attached to the computer 02:50 < spudowiar> e.g. a serial number 02:54 < bitcoin-git> [bitcoin] pavlosantoniou opened pull request #10530: Fix possibly unsafe accesses of array in class base_uint. (master...master) https://github.com/bitcoin/bitcoin/pull/10530 02:54 < spudowiar> I'm also going to add a listhwwdevices which could be used on the first run to list all the devices so Bitcoin Core can ask the user to select one 02:54 < spudowiar> And a gethwwinfo to get the xpub for the selected device 02:55 < spudowiar> Then on first run, Bitcoin Core could allow you to select a vendor and then a device 02:55 < spudowiar> And store this in the wallet 03:07 -!- john1 [~john@host86-147-127-48.range86-147.btcentralplus.com] has joined #bitcoin-core-dev 03:16 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 03:23 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 03:28 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 03:33 -!- riemann [~riemann@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 03:42 -!- spudowiar [~cabox@unaffiliated/saleemrashid] has quit [Quit: WeeChat 0.4.2] 03:51 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:413c:cf95:4660:5198] has joined #bitcoin-core-dev 03:54 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:849e:37f6:1354:b77a] has quit [Ping timeout: 255 seconds] 03:58 -!- tiagotrs [~tiago@dhcp-213-105.vpn.tu-berlin.de] has joined #bitcoin-core-dev 04:02 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:c188:b9af:285f:3e0e] has joined #bitcoin-core-dev 04:05 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:413c:cf95:4660:5198] has quit [Ping timeout: 246 seconds] 04:06 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 04:15 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 04:16 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 04:34 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:69fa:3267:9720:f052] has joined #bitcoin-core-dev 04:37 < NicolasDorier> spudowiar: for multiple wallet, you don't need serial number. There is the multi wallet PR which use RPC User/Password as a way to selection a wallet 04:37 < NicolasDorier> and the wallet already know the keypath given the address 04:37 < NicolasDorier> so you don't need to pass it to the RPC method 04:38 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:c188:b9af:285f:3e0e] has quit [Ping timeout: 260 seconds] 04:42 -!- timothy [tredaelli@redhat/timothy] has quit [Remote host closed the connection] 04:46 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev 04:50 -!- timothy [tredaelli@redhat/timothy] has quit [Remote host closed the connection] 04:50 -!- goatturner [~Beatrootg@2a02:c7d:12e:100:39dc:11fa:6015:7ac9] has joined #bitcoin-core-dev 04:54 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:69fa:3267:9720:f052] has quit [Ping timeout: 260 seconds] 04:57 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 268 seconds] 05:01 -!- spudowiar [~cabox@unaffiliated/saleemrashid] has joined #bitcoin-core-dev 05:02 < spudowiar> NicolasDorier: How does the wallet plugin know which hardware device to connect to? 05:02 < spudowiar> NicolasDorier: You might be misunderstanding 05:02 < spudowiar> I'm not talking about the RPC interface Bitcoin Core normally uses 05:02 < spudowiar> I'm talking about JSON-RPC that is sent over stdin to the hardware wallet plugin 05:03 < NicolasDorier> oh 05:03 < NicolasDorier> yes I was misunderstanding 05:03 < spudowiar> Check out https://github.com/saleemrashid/bitcoin/blob/hardware-wallet/src/wallet/wallet.cpp#L1527 05:03 < NicolasDorier> so it will be possible to use BTC signrawtransaction as if it was keys in software ? 05:03 < spudowiar> Oh yeah 05:03 < spudowiar> The normal RPC interface won't change 05:03 < NicolasDorier> ha awesome 05:03 < spudowiar> Although I might make it compatible as a hardware wallet plugin 05:04 < NicolasDorier> that is what I meant 05:04 < spudowiar> So you could connect one instance to another :) 05:04 < spudowiar> And it thinks the other instance is a hardware wallet :) 05:05 < NicolasDorier> spudowiar: very cool. Would you mind once you tested a bit to ACK my PR about hdwatchonly ? This would make your PR a bit smaller if you plan to include what you are doing into core 05:06 < NicolasDorier> my PR is hanging around for a while, I am using it in production. But was lacking reviews 05:06 < spudowiar> If you check that branch, the first few commits are your PR 05:06 < spudowiar> I think I did ACK it, if not I'll do that when I can 05:07 < NicolasDorier> yes I saw. Just a way to make your PR smaller, so it will be easier to merge yours later 05:10 < spudowiar> The other PR we need is making signing asynchronous in Bitcoin Qt 05:10 < spudowiar> At the moment, while it is talking to the hardware wallet the GUI freezes 05:10 < spudowiar> Because the io_service is running on the UI thread 05:12 < NicolasDorier> rebasing my PR. 05:13 < spudowiar> Thanks, I'll ACK and rebase ASAP 05:13 < NicolasDorier> actually you already rebased right ? 05:13 < NicolasDorier> I can just take your branch up to my commits I think 05:14 < spudowiar> Yeah, sure but you might want to check (I had to make a few changes for merge conflicts) 05:15 < NicolasDorier> ok 05:15 < spudowiar> A three way diff should let you see what I had to change 05:27 < spudowiar> Do you think I should add a scan in the PATH for plugins? Or a scan in a folder? 05:27 < spudowiar> e.g. bitcoin-hww-* 05:28 < spudowiar> Then, on startup, the GUI wallet could display all the vendors 05:36 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 05:39 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev 05:45 < bitcoin-git> [bitcoin] colgreen opened pull request #10531: Increased startup timeout. (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10531 06:01 -!- spudowiar [~cabox@unaffiliated/saleemrashid] has quit [Quit: WeeChat 0.4.2] 06:07 < NicolasDorier> spudowiar: unsure, I like your current approach to just delegate to a child process specified by command line. 06:09 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 240 seconds] 06:10 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 06:12 < wumpus> I also like the external process approach 06:13 < wumpus> loading plugins into bitcoind/-qt 's address space seem like the wrong way, for me, and is hard harmonize with the static linking we do for distributed executables 06:13 -!- Taek42 is now known as Taek 06:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 06:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 06:15 -!- Yogaqueef [~textual@dsl-hkibrasgw3-58c3d4-235.dhcp.inet.fi] has joined #bitcoin-core-dev 06:18 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:5ca2:c99:d4ab:2f77] has joined #bitcoin-core-dev 06:21 -!- bsm1175321 [~mcelrath@static-100-38-216-231.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 06:21 -!- goatturner [~Beatrootg@2a02:c7d:12e:100:39dc:11fa:6015:7ac9] has quit [Ping timeout: 260 seconds] 06:24 -!- JackH [~laptop@78.108.139.101] has joined #bitcoin-core-dev 06:30 -!- bsm1175321 [~mcelrath@static-100-38-216-231.nycmny.fios.verizon.net] has quit [Remote host closed the connection] 06:32 -!- bsm1175321 [~mcelrath@static-100-38-216-231.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 06:34 -!- bsm1175321 [~mcelrath@static-100-38-216-231.nycmny.fios.verizon.net] has quit [Remote host closed the connection] 06:40 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/400fdd08cc95...296928eb38a4 06:40 < bitcoin-git> bitcoin/master a7e3c28 Wladimir J. van der Laan: rpc: Add listen address to incoming connections in `getpeerinfo`... 06:40 < bitcoin-git> bitcoin/master 3457331 Wladimir J. van der Laan: test: Add test for `getpeerinfo` `bindaddr` field 06:40 < bitcoin-git> bitcoin/master 296928e Wladimir J. van der Laan: Merge #10478: rpc: Add listen address to incoming connections in `getpeerinfo`... 06:41 < bitcoin-git> [bitcoin] laanwj closed pull request #10478: rpc: Add listen address to incoming connections in `getpeerinfo` (master...2017_05_peer_listenaddr) https://github.com/bitcoin/bitcoin/pull/10478 06:47 -!- bsm1175321 [~mcelrath@static-100-38-216-231.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 06:50 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 06:50 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Client Quit] 06:53 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 255 seconds] 06:58 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:8ea:d86:e1d2:b4c2] has joined #bitcoin-core-dev 07:01 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:5ca2:c99:d4ab:2f77] has quit [Ping timeout: 246 seconds] 07:07 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 07:10 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/296928eb38a4...e103b3ff1e4f 07:10 < bitcoin-git> bitcoin/master 9aa215b Pieter Wuille: Bugfixes: missing == 0 after randrange 07:10 < bitcoin-git> bitcoin/master e103b3f Wladimir J. van der Laan: Merge #10514: Bugfix: missing == 0 after randrange... 07:10 < bitcoin-git> [bitcoin] laanwj closed pull request #10514: Bugfix: missing == 0 after randrange (master...fixtests) https://github.com/bitcoin/bitcoin/pull/10514 07:15 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 07:18 -!- wangchun [~wangchun@li414-193.members.linode.com] has quit [Ping timeout: 240 seconds] 07:20 -!- yellowsphere_ [52d07c8e@gateway/web/freenode/ip.82.208.124.142] has joined #bitcoin-core-dev 07:24 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e103b3ff1e4f...cec9e1ea6174 07:24 < bitcoin-git> bitcoin/master 8d4f401 Alex Morcos: Fix timestamp in fee estimate debug message 07:24 < bitcoin-git> bitcoin/master cec9e1e Wladimir J. van der Laan: Merge #10422: Fix timestamp in fee estimate debug message... 07:25 < bitcoin-git> [bitcoin] laanwj closed pull request #10422: Fix timestamp in fee estimate debug message (master...fixtimeunits) https://github.com/bitcoin/bitcoin/pull/10422 07:25 -!- wangchun [~wangchun@li414-193.members.linode.com] has joined #bitcoin-core-dev 07:28 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/cec9e1ea6174...c871f323b418 07:28 < bitcoin-git> bitcoin/master cc36b5e Jimmy Song: [test] Add test for getchaintxstats 07:28 < bitcoin-git> bitcoin/master c871f32 MarcoFalke: Merge #10515: [test] Add test for getchaintxstats... 07:28 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #10515: [test] Add test for getchaintxstats (master...test_getchaintxstats) https://github.com/bitcoin/bitcoin/pull/10515 07:34 -!- Chris_Stewart_5 [~chris@173-31-39-168.client.mchsi.com] has joined #bitcoin-core-dev 07:38 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c871f323b418...0747d3349817 07:38 < bitcoin-git> bitcoin/master 88b8f0b Russell Yanofsky: Simplify feebumper minimum fee code slightly... 07:38 < bitcoin-git> bitcoin/master 0747d33 Wladimir J. van der Laan: Merge #10455: Simplify feebumper minimum fee code slightly... 07:39 < bitcoin-git> [bitcoin] laanwj closed pull request #10455: Simplify feebumper minimum fee code slightly (master...pr/bumpmin) https://github.com/bitcoin/bitcoin/pull/10455 07:40 -!- talmai [~T@c-76-24-28-74.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 07:41 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0747d3349817...08d0390a5fea 07:41 < bitcoin-git> bitcoin/master 4d2d604 Russell Yanofsky: Fix importmulti failure to return rescan errors... 07:41 < bitcoin-git> bitcoin/master 08d0390 Wladimir J. van der Laan: Merge #10403: Fix importmulti failure to return rescan errors... 07:41 < bitcoin-git> [bitcoin] laanwj closed pull request #10403: Fix importmulti failure to return rescan errors (master...pr/scansame) https://github.com/bitcoin/bitcoin/pull/10403 07:44 -!- talmai [~T@c-76-24-28-74.hsd1.ma.comcast.net] has quit [Ping timeout: 240 seconds] 07:47 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 260 seconds] 07:47 -!- tiagotrs [~tiago@dhcp-213-105.vpn.tu-berlin.de] has quit [Quit: leaving] 07:55 -!- JackH [~laptop@78.108.139.101] has quit [Remote host closed the connection] 08:00 -!- riemann [~riemann@84-10-11-234.static.chello.pl] has quit [Quit: Leaving] 08:00 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/08d0390a5fea...e654d61d94ee 08:00 < bitcoin-git> bitcoin/master cf390df Cory Fields: build: silence gcc7's implicit fallthrough warning... 08:00 < bitcoin-git> bitcoin/master e654d61 Wladimir J. van der Laan: Merge #10489: build: silence gcc7's implicit fallthrough warning... 08:00 < bitcoin-git> [bitcoin] laanwj closed pull request #10489: build: silence gcc7's implicit fallthrough warning (master...wimplicit-fallthrough) https://github.com/bitcoin/bitcoin/pull/10489 08:02 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 240 seconds] 08:12 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 08:15 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 08:15 -!- str4d [~str4d@27.110.123.91] has quit [Ping timeout: 255 seconds] 08:15 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 08:18 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:a460:7d62:d5da:b4e3] has joined #bitcoin-core-dev 08:19 -!- bsm1175321 [~mcelrath@static-100-38-216-231.nycmny.fios.verizon.net] has quit [Read error: Connection reset by peer] 08:20 -!- ivo___ [~ivo@mail5.sion.bg] has joined #bitcoin-core-dev 08:21 < ivo___> \disconnect 08:21 -!- ivo___ [~ivo@mail5.sion.bg] has quit [Client Quit] 08:22 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:8ea:d86:e1d2:b4c2] has quit [Ping timeout: 260 seconds] 08:22 -!- bsm1175321 [~mcelrath@static-100-38-216-231.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 08:34 -!- emzy [~quassel@unaffiliated/emzy] has quit [Quit: No Ping reply in 180 seconds.] 08:35 -!- emzy [~quassel@raspberry.emzy.de] has joined #bitcoin-core-dev 08:49 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 08:50 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e654d61d94ee...bea5b00cfe95 08:50 < bitcoin-git> bitcoin/master e4bc19f Russell Yanofsky: Remove xvfb configuration from travis... 08:50 < bitcoin-git> bitcoin/master bea5b00 MarcoFalke: Merge #10509: Remove xvfb configuration from travis... 08:50 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #10509: Remove xvfb configuration from travis (master...pr/rmfb) https://github.com/bitcoin/bitcoin/pull/10509 08:59 < bitcoin-git> [bitcoin] laanwj closed pull request #9745: [RPC] Getting confirmations command (master...add-getconfirmations-to-rpc) https://github.com/bitcoin/bitcoin/pull/9745 09:01 -!- emzy [~quassel@raspberry.emzy.de] has quit [Changing host] 09:01 -!- emzy [~quassel@unaffiliated/emzy] has joined #bitcoin-core-dev 09:06 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 09:06 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/bea5b00cfe95...9fec4da0bec9 09:06 < bitcoin-git> bitcoin/master 9f82134 aideca: Add friendly output to dumpwallet refs #9564 09:06 < bitcoin-git> bitcoin/master 164019d aideca: Add dumpwallet output test 09:06 < bitcoin-git> bitcoin/master 9fec4da Wladimir J. van der Laan: Merge #9740: Add friendly output to dumpwallet... 09:07 < bitcoin-git> [bitcoin] laanwj closed pull request #9740: Add friendly output to dumpwallet (master...dumpwallet) https://github.com/bitcoin/bitcoin/pull/9740 09:08 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:1c1a:56e8:df3e:2c46] has joined #bitcoin-core-dev 09:09 -!- spudowiar [~android@unaffiliated/saleemrashid] has joined #bitcoin-core-dev 09:09 < spudowiar> NicolasDorier, wumpus: I didn't mean changing it from an external command 09:09 < spudowiar> Just a method of detecting the available external commands 09:10 < spudowiar> But I could add it to the wallet file or something 09:10 < spudowiar> And provide an option at startup of Bitcoin-Qt to enter the command 09:12 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:a460:7d62:d5da:b4e3] has quit [Ping timeout: 260 seconds] 09:13 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 246 seconds] 09:15 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 09:19 -!- nsh- is now known as nsh 09:20 -!- spudowiar [~android@unaffiliated/saleemrashid] has quit [Quit: Leaving] 09:20 -!- spudowiar [~spudowiar@unaffiliated/saleemrashid] has joined #bitcoin-core-dev 09:24 < bitcoin-git> [bitcoin] earonesty opened pull request #10532: -bip148 option (master...bip148) https://github.com/bitcoin/bitcoin/pull/10532 09:39 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 09:40 < btcdrak> wumpus: could you restart the two failing jobs here https://travis-ci.org/bitcoin/bitcoin/builds/238932256 09:52 -!- john1 [~john@host86-147-127-48.range86-147.btcentralplus.com] has quit [Ping timeout: 240 seconds] 09:56 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 09:58 < spudowiar> sipa__: Is there some good reading about the polymod function Bech32 uses? 10:01 -!- timothy [tredaelli@redhat/timothy] has quit [Remote host closed the connection] 10:10 < BlueMatt> ;;later tell sipa sipa__ is it just my C++11-lack-of-sanity, or am I suppose to find https://github.com/bitcoin/bitcoin/blob/master/src/coins.cpp#L99 gross as fuck? std::move(it->second.coin) then a few lines later it->second.coin.function_call()? 10:10 < gribble> The operation succeeded. 10:13 < cfields> BlueMatt: after a move, contents are usually undefined, but valid 10:13 < cfields> BlueMatt: a clear after a move makes them defined and valid :) 10:13 < BlueMatt> cfields: ugh, that just feels super gros 10:13 < BlueMatt> s 10:13 < BlueMatt> since that line depends on the exact behavior of CScript::Clear(), prevector, and CTxOut 10:15 < cfields> BlueMatt: the alternative would be defining an explicit move ctor which does the clear and leaves it in a valid state 10:15 < cfields> (or, i suppose, you'd rather just have it not used after the move) 10:15 < BlueMatt> yea, I mean I generally read std::move(X) as "X will not be touched again" 10:15 < BlueMatt> maybe thats just my naivete on C++11 10:15 < cfields> BlueMatt: well, that's not really feasible with a container :\ 10:16 < cfields> std::move(foo[0]), foo still exists just fine. 10:16 < cfields> In many cases, this one included i think, it's the only way to avoid incurring the copy when moving the contents of a member 10:17 < BlueMatt> cfields: well obv destructor must run fine after std::move(), but to me I read that as, "I wont touch the 0th element of foo anymore after this, except to destruct" 10:18 < sipa__> BlueMatt: typically the definition os that you're allowed to do anything that foesn't depend on otd prior state 10:18 < sipa__> so you can assign, clear, ... 10:19 < sipa__> in a vector, a move-from + .clear() is well specified 10:19 < sipa__> doesn't 10:20 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 10:21 < MarcoFalke> btcdrak: done. Looks like they hit the 50 min timeout :( 10:25 < sipa__> BlueMatt: https://stackoverflow.com/a/7028318 10:25 -!- sipa__ is now known as sipa 10:25 < BlueMatt> sipa__: yea, but coin.Clear() is super strange, it calls CScript::clear() which doesnot prevector::clear(), instead it prevector().swap(*this), essentially 10:25 < BlueMatt> which is...wat 10:25 < BlueMatt> sipa: can we make it it->second.coin = CCoin() instead? 10:26 < BlueMatt> should be +/- identical performance, but without feeling so yucky 10:26 -!- sipa [~pw@2001:19f0:ac01:2fb:5400:ff:fe5b:c3ff] has quit [Changing host] 10:26 -!- sipa [~pw@unaffiliated/sipa1024] has joined #bitcoin-core-dev 10:27 < sipa> i don't see the difference 10:27 < sipa> both the Clear method and assignment operator can be user defined 10:28 < BlueMatt> sure, swap just feels worse to me...I'll shut up if no one else thinks it feels strange, though :) 10:29 < cfields> BlueMatt: the swap idiom comes from pre-c++11 when there was no shrink_to_fit(). 10:30 < cfields> imo the clear shouldn't be forcing mem dealloc, it should just be clearing, and we should be using shrink_to_fit() more liberally at higher layers. 10:30 < sipa> right 10:30 < BlueMatt> yes, prevector clear() doesnt, script clear() does 10:31 < BlueMatt> could make script more vector-like by pushing it up to CCoin Clear() 10:31 < BlueMatt> or CTxOut 10:31 < sipa> script clear could be changed into prevector clear + shrink to fit 10:31 < sipa> though i think prevector clear automatocally shrinks 10:31 < BlueMatt> std::move() + clear() + shrink_to_fit()? 10:32 < BlueMatt> i do not believe so 10:32 < cfields> oh right. prevector essentially has no shrink_to_fit because it never over-allocs 10:32 < BlueMatt> ohoh, true 10:33 < BlueMatt> ehh, no, wait, i dont think so? 10:34 < BlueMatt> erase(it, it) doesnt do any shrinking, i believe 10:37 < sipa> when usimg direct allocation, the capacity is always equal to the object size 10:37 < sipa> when using indirect allocation, the capacity is variable 10:37 < BlueMatt> yes, but if its grown, clear() doesnt shrink_to_fit 10:38 < sipa> so resizing to something less than the inline capacity always has a deallocation as a result 10:38 < sipa> or at least should have 10:38 < MarcoFalke> cfields: I had the impression that the wallet-block_tip race is still a thing. Otherwise we could get rid of waitforblockheight as well 10:38 < sipa> as there is no way to represent the alternative 10:40 < cfields> MarcoFalke: yes, that's right. But we don't have any tests that rely on the other 2 things being atomic. 10:40 < sipa> i'm now questioning whether the prevector code is correct... 10:40 < cfields> sipa: i was just thinking the same. that seems leaky :\ 10:41 < BlueMatt> sipa: yes, there is a bug on erase(begin(), end()), but not on clear()/resize(0) 10:42 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 10:42 < sipa> clear() just calls erase all the thing 10:42 < sipa> erase has no change capacity call at all 10:48 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 10:51 -!- john1 [~john@host86-147-127-48.range86-147.btcentralplus.com] has joined #bitcoin-core-dev 10:52 -!- ula [~kvirc@b2b-78-94-11-194.unitymedia.biz] has joined #bitcoin-core-dev 10:52 -!- chjj [~chjj@unaffiliated/chjj] has quit [Client Quit] 10:52 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 10:56 -!- QBcrusher [~QBcrusher@cpe-71-72-244-36.insight.res.rr.com] has joined #bitcoin-core-dev 10:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 10:57 -!- yellowsphere_ [52d07c8e@gateway/web/freenode/ip.82.208.124.142] has quit [Ping timeout: 260 seconds] 10:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:58 -!- QBcrusher_ [~QBcrusher@cpe-71-72-244-36.insight.res.rr.com] has quit [Ping timeout: 240 seconds] 11:07 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 255 seconds] 11:09 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 11:16 < jtimon> https://github.com/bitcoin/bitcoin/pull/10502 was created 4 days ago and laready needed rebase twice 11:16 < jtimon> already 11:17 < sipa> jtimon: thankfully, it's a scripted diff mostly, so should be easy 11:17 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 246 seconds] 11:17 < jtimon> it is disruptive (+296 −300 at this point), so it is likely to require more 11:17 < jtimon> sipa: yeah, I think we can get it reviewed fast too 11:20 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 11:21 < jtimon> #10463 has some utACKs already and is easy to review as well 11:21 < gribble> https://github.com/bitcoin/bitcoin/issues/10463 | Names: BIP9 vs versionbits by jtimon · Pull Request #10463 · bitcoin/bitcoin · GitHub 11:22 < bitcoin-git> [bitcoin] achow101 opened pull request #10533: [tests] Use cookie auth instead of rpcuser and rpcpassword (master...tests-use-cookie-auth) https://github.com/bitcoin/bitcoin/pull/10533 11:22 -!- john1 [~john@host86-147-127-48.range86-147.btcentralplus.com] has quit [Ping timeout: 240 seconds] 11:24 -!- JackH [~laptop@92-111-16-187.static.chello.nl] has joined #bitcoin-core-dev 11:34 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 258 seconds] 11:38 -!- Chris_Stewart_5 [~chris@173-31-39-168.client.mchsi.com] has quit [Ping timeout: 246 seconds] 11:40 -!- harrymm [~wayne@104.237.91.72] has quit [Ping timeout: 268 seconds] 11:42 -!- talmai [~T@c-24-147-97-55.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 11:46 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 11:47 -!- Chris_Stewart_5 [~chris@173-31-39-168.client.mchsi.com] has joined #bitcoin-core-dev 11:49 -!- john1 [~john@host86-147-127-48.range86-147.btcentralplus.com] has joined #bitcoin-core-dev 11:56 -!- harrymm [~wayne@104.237.91.123] has joined #bitcoin-core-dev 12:01 -!- JackH [~laptop@92-111-16-187.static.chello.nl] has quit [Ping timeout: 255 seconds] 12:06 < BlueMatt> sipa: ah, indeed, no bug in prevector, I was misreading the meaning of _size 12:06 < jtimon> sipa: regarding https://github.com/bitcoin/bitcoin/pull/10502#issuecomment-306275178 perhaps you can help me find out what's wrong with https://github.com/bitcoin/bitcoin/pull/10193/commits/0f151d6a1b5b048ca78879e367f7a18f91126066#diff-c295474658e4ef7a9f5324199375edaf 12:07 < sipa> BlueMatt: oh, good 12:10 < jtimon> well, except for the reverse lop thing breaking the unittests... 12:11 < jtimon> loop 12:12 < sipa> ah i see 12:13 < jtimon> I haven't been able to understand what's going on there 12:13 < sipa> https://status.github.com/ 12:13 < jtimon> oh, http://downforeveryoneorjustme.com/https://github.com/bitcoin/bitcoin/ said it was just me 12:14 < sipa> it's up again 12:15 < jtimon> nice, thanks 12:18 < bitcoin-git> [bitcoin] sipa opened pull request #10534: Clarify prevector::erase and avoid swap-to-clear (master...clarify_erase) https://github.com/bitcoin/bitcoin/pull/10534 12:19 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 246 seconds] 12:23 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 240 seconds] 12:25 -!- JackH [~laptop@92-111-16-187.static.chello.nl] has joined #bitcoin-core-dev 12:28 < cfields> jtimon: i think your expression goes out of scope after the first iteration 12:31 < jtimon> cfields: mhmm, I don't follow 12:31 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:9d6d:ec1c:7724:bc0a] has joined #bitcoin-core-dev 12:33 < cfields> jtimon: try: https://pastebin.com/raw/USdQhE36 12:34 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 12:35 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:1c1a:56e8:df3e:2c46] has quit [Ping timeout: 246 seconds] 12:42 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 240 seconds] 12:45 < spudowiar> I added some stuff to the Intro Qt form for hardware wallet support... Qt Designer made me cry :( 12:46 < jtimon> cfields: awesome, I'll have a look, thanks 12:49 < BlueMatt> sipa: would you be upset if I PRd making AccessCoin return a CoinAccessor which just asserts if you modify the coinscache while holding a reference? I know its not illegal 12:49 < BlueMatt> cause map, but I'm afraid jeremy or I will at some point suggest using a different map 12:49 < BlueMatt> and then introduce a bug 12:49 < BlueMatt> should be +/- free performance wise 12:49 < sipa> BlueMatt: that seems more something for a sanity checker 12:50 < sipa> why specifically for CCoinsViewCache and not every other map? 12:50 < BlueMatt> sipa: cause I have a strong suspicion over the next release or two someone is gonna realize std::unordered_map is not the ideal map and decide to suggest a hand-written one 12:51 -!- spudowiar [~spudowiar@unaffiliated/saleemrashid] has quit [Quit: WeeChat 1.8] 12:51 < sipa> yes, so? 12:51 < BlueMatt> and then suddenly using the std sanity-check mode wont help? 12:51 < sipa> yes, so? 12:52 < sipa> i mean things like valgrind exist to find bugs like that 12:52 < sipa> i plan to work on replacing the std::unordered_map myself there, btw 12:52 < BlueMatt> cause I'd be not at all surprised if it were very difficult to tickle that issue during valgrind 12:52 < jeremyrubin> Can also use a weak reference or something 12:52 < BlueMatt> lol, figured someone would 12:53 < sipa> i don't understand why you're specifically worried about this map 12:53 < BlueMatt> jeremyrubin: that may be incompatible with a smarter map, sadly :( 12:53 < jeremyrubin> Can just add an "updates" counter to the map 12:53 < jeremyrubin> and the weak ref is invalid if counter != weakref.counter 12:53 < sipa> it's a big and important one, but hardly the only complex data structure around 12:54 < gmaxwell> BlueMatt: please rebase #10192; review #10148 12:54 < BlueMatt> sipa: well we hold references into that map in rpc functions...I'm not aware of any other map where we do anything like that? 12:54 < gribble> https://github.com/bitcoin/bitcoin/issues/10192 | Cache full script execution results in addition to signatures by TheBlueMatt · Pull Request #10192 · bitcoin/bitcoin · GitHub 12:54 < gribble> https://github.com/bitcoin/bitcoin/issues/10148 | [WIP] Use non-atomic flushing with block replay by sipa · Pull Request #10148 · bitcoin/bitcoin · GitHub 12:54 < sipa> BlueMatt: example? 12:54 < BlueMatt> gmaxwell: yesyes, I'm working on a few small things i wanted in per-utxo first 12:54 < jeremyrubin> anyways, I'm generally sympathetic to Matt's request; long held iterators to maps -> bugs 12:54 < BlueMatt> well, luckily for now we have no "long held" ones 12:54 < BlueMatt> but we do have ones in RPC 12:54 < sipa> jtimon: not long held iterators; references to elements 12:54 < sipa> eh, jeremyrubin 12:55 < sipa> iterators are encapsulated 12:55 < BlueMatt> sipa: AccessCoin is called in rpc/rawtransaction 12:55 < BlueMatt> in several places 12:55 < sipa> in many places we also hold an iterator that comes out of mapBlockIndex.find 12:55 < BlueMatt> sipa: I'm sure this comes back to your "objects are transparent holders of data" vs my "objects should be opaque, where possible" 12:56 < gmaxwell> BlueMatt: k. other people's review is blocked on that rebase. 12:56 < BlueMatt> gmaxwell: hey, you're the one who got me to focus on fibre for two weeks :p 12:56 < BlueMatt> gmaxwell: but will try to circle around today 12:57 < BlueMatt> sipa: hmm, somehow i feel better about that cause its clear its a map, unlike CCoinsViewCache, where its an encapsulated datastructure that is actually private 12:57 < sipa> BlueMatt: it does return a reference, which is always a worry 12:57 < gmaxwell> BlueMatt: I know, I know. 12:58 < jeremyrubin> BlueMatt: at a higher level, I see what you're trying to do, trying to get me to write a better map and I'm maybe falling for it 12:58 < BlueMatt> jeremyrubin: sipa already said he was working on it :p 12:58 < sipa> if you're worried about particular call sites, you can always use Coin coin = view.Accessor(outpoint) ... instead of Coin& coin = ... 12:58 < BlueMatt> sipa: our disagreement is clearly a disagreement about encapsulation 12:59 < sipa> BlueMatt: i'm just so glad i got rid of that CCoinsModifier... and now you want to introduce it again :) 12:59 < sipa> the interface got so much easier 12:59 < BlueMatt> sipa: CCoinsViewModifier *did* things, there I agree that is gross 12:59 < BlueMatt> I'm proposing something who's only value is to assert with litte/no performance impact 13:00 < BlueMatt> so as to act as a sanity checker on callsites to a function I cant say I'm sold on 13:00 < gmaxwell> BlueMatt: what sanity check will it do? 13:00 < sipa> gmaxwell: check that no references are held while a modify happens 13:01 < BlueMatt> gmaxwell: technically assert something that is currently allowed, but something I assume will be come unallowed when sipa (or someone) writes a custom map for mapCoins 13:01 < gmaxwell> that doesn't sound free to verify. 13:02 < sipa> BlueMatt: also, i don't think it's technically illegal to hold a reference to a deleted object 13:02 < BlueMatt> hmm? just a boolean/int to set when you AccessCoins and assert() on in function calls 13:02 < sipa> only using it is 13:02 < jeremyrubin> what if you have a templated thing that doesn't check that property if the type of map used is the current one ;p 13:02 < BlueMatt> gmaxwell: compared to looking up in the map it is free :) 13:03 < gmaxwell> BlueMatt: not necessarily compared to an alternative data structure (also, I doubt it's free even compared to a map) 13:03 < BlueMatt> sipa: sure, but cutting hairs, I'm asking if you're ok adding a class which is more strict than it needs to be, cause its easy to write and, imo, a useful sanity check 13:03 < ryanofsky> sipa, not directly related but #9384 also adds back a version of the modifier 13:03 < gribble> https://github.com/bitcoin/bitcoin/issues/9384 | CCoinsViewCache code cleanup & deduplication by ryanofsky · Pull Request #9384 · bitcoin/bitcoin · GitHub 13:03 -!- JackH [~laptop@92-111-16-187.static.chello.nl] has quit [Ping timeout: 258 seconds] 13:03 < BlueMatt> gmaxwell: assert(nAccessors == 0); ? 13:03 < sipa> ryanofsky: yes... but not an exposed one 13:03 < ryanofsky> yeah 13:03 < BlueMatt> gmaxwell: that sounds like something that the cpu will run without any attached preconditions and will easily run free since you're informing the branch predictor what is unlikely 13:04 < sipa> ryanofsky: i like that 9384 reduces logic duplication, i dislike that it does not actually reduce the amount of code :) 13:05 < ryanofsky> i think that could be because i wrote it in an intentionally verbose style with lots of comments and named variables 13:06 < sipa> ryanofsky: yeah, will review 13:06 < sipa> that was just a quick comment 13:07 < sipa> BlueMatt: so, an accessor object may have another advantage at some point... if we'd want to make CCoinsViewCache have split storage for txids and CCoins 13:07 < sipa> eh, Coins 13:07 < sipa> i don't know if that's a good idea or not, but it may reduce memory usage a fair bit (or not) 13:07 < BlueMatt> you mean to hold a ptr to uint256? 13:08 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 260 seconds] 13:08 < sipa> well the point is that encapsulating it may give freedom to change the representation more liberally 13:08 < BlueMatt> sipa: if you really dont want an accessor object, I'ma add a nice long comment to AccessCoin describing the preciditions...which I'm ok with, but not as much a fan 13:08 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 13:08 < BlueMatt> hence the q 13:08 < BlueMatt> fair 13:08 < sipa> so how about we benchmark whether it has an effect? 13:08 < BlueMatt> do we have a decent way to benchmark? 13:09 < BlueMatt> i mean could reindex 13:09 < sipa> reindex chainstate on a -connect=0 node with fixed CPU clockrate 13:09 < BlueMatt> but that nearly definitely wont show it 13:09 < sipa> works very accurately 13:09 < BlueMatt> I so dont want to do that....I can haz ssh? 13:10 < sipa> i can set things up 13:22 -!- harrymm [~wayne@104.237.91.123] has quit [Ping timeout: 246 seconds] 13:24 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 260 seconds] 13:24 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 13:29 < BlueMatt> sipa: well, went and did it and no clear way to enforce semantics cause you can take reference and then drop the accessor too easily when writing cleints. it is nice cause it forces back to a ptr and restores a bunch of effectively-assert-cause-nullptrs that you removed in per-utxo 13:29 < BlueMatt> maybe I'll just re-add asserts and a long comment 13:30 < bitcoin-git> [bitcoin] practicalswift closed pull request #10527: Use parentheses to clarify intended precedence when using bitwise operations (master...clarify-precedence) https://github.com/bitcoin/bitcoin/pull/10527 13:35 < Chris_Stewart_5> FYI: You can install bitcoind as a dependency now on travis ci, previously it had been black listed. 13:36 -!- harrymm [~wayne@104.237.91.123] has joined #bitcoin-core-dev 13:37 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:79bb:f708:9002:c8b6] has joined #bitcoin-core-dev 13:40 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:9d6d:ec1c:7724:bc0a] has quit [Ping timeout: 246 seconds] 13:41 -!- goatturner [~Beatrootg@2a02:c7d:12e:100:6c90:c46b:ec42:9874] has joined #bitcoin-core-dev 13:44 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:79bb:f708:9002:c8b6] has quit [Ping timeout: 246 seconds] 13:44 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 13:45 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 13:47 < jtimon> cfields: thanks a lot! with your suggestion and another small change it seems the problem is gone 13:47 < jtimon> re #10193 13:47 < gribble> https://github.com/bitcoin/bitcoin/issues/10193 | scripted-diff: Remove #include foreach.hpp> by jtimon · Pull Request #10193 · bitcoin bitcoin · GitHub 13:47 < jtimon> will update 13:53 < jtimon> done 14:01 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 14:06 -!- btcdrak [uid230524@gateway/web/irccloud.com/x-lmcsabxzefaseloo] has quit [Quit: Connection closed for inactivity] 14:14 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 14:29 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds] 14:39 -!- Chris_Stewart_5 [~chris@173-31-39-168.client.mchsi.com] has quit [Ping timeout: 240 seconds] 14:43 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 14:48 < cfields> jtimon: great :) 14:49 < jtimon> :) 14:50 < cfields> jtimon: err, you need to use the reverser thing everywhere, not just in tests 14:50 < jtimon> maybe now it doesn't make sense for them to be separated, but maybe if I hadn't separated them I would still be stuck, so no regrets 14:50 < jtimon> oh, I see 14:52 < jtimon> I didn't run the python tests, but they should fail in that case, I'll wait for travis to fail 14:52 < jtimon> then edit the scripted-diff commit to do the same thing everywhere 14:53 < jtimon> although prevector tests will still need something different for the const reverse loop 14:53 < jtimon> or I think so 14:54 < jtimon> thanks for the heads up, I really thought it was just there because of how templates are used there 14:55 < cfields> np. no, it's because of how a range-based-for binds to the expression 14:55 < jtimon> then the new class sucks a little bit, perhaps I can do the same with auto and rbegin rend inlined 14:55 < cfields> though I can't say that I 100% understand the semantics 14:55 < jtimon> without needing a new class 14:55 < jtimon> alright, let's wait for travis 14:56 < jtimon> if it passes and you are still right maybe we can spot some missing tests 14:56 < jtimon> I can run the python tests locally too, I'll do that 15:05 < jtimon> jnewbery: what do you think about changing /tmp/bitcoin_test_runner_20170605_235927 to /tmp/bitcoin_test_runner/20170605_235927 ? 15:06 < jtimon> not a big deal, just slightly easier to remove the whole folder, kudos for the clearer prefix 15:06 < jnewbery> mildly against. Why add an extra directory layer? It just means I need to press the tab key one more time :) 15:06 < jnewbery> why easier to remove the whole folder? 15:06 < jtimon> fair enough, that was the question 15:07 < jtimon> it wasn't unlikely that it was only more convenient for me 15:07 < jtimon> the current prefix is good enough anyway 15:09 < jtimon> cfields: I don't know about travis, but this passes python3 ./test/functional/test_runner.py -j56 --extended -x pruning,smartfees,maxuploadtarget 15:10 < jnewbery> jtimon: cool. Thanks 15:10 < cfields> jtimon: I think you need a new set of tests for reverse_iterator. I don't trust it with the simple for construct :( 15:15 < jtimon> cfields: yep, more reason to simply rewrite the scripted-diff into something that uses rbegin/rend direclty instead of adding the new template 15:15 < cfields> agreed 15:15 < jtimon> but, still, if this shouldn't pass tests and it passes, perhaps we should open an issue asking for more tests 15:17 < cfields> agree with that too :) 15:17 < jtimon> I will try the version without the new class either way, it'll probably look smaller, just a more complex script to read if you use scripted-diff for review 15:18 < jtimon> but the diff should look very simple as well 15:19 < jtimon> cool 15:24 -!- trippysalmon [~trippy@cyberdynesys.org] has quit [Ping timeout: 245 seconds] 15:26 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 246 seconds] 15:29 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 15:32 -!- trippysalmon [~trippy@cyberdynesys.org] has joined #bitcoin-core-dev 15:52 -!- talmai [~T@c-24-147-97-55.hsd1.ma.comcast.net] has quit [Quit: mining] 16:18 -!- jnewbery [~Thunderbi@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Quit: jnewbery] 16:20 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:50a:4941:8807:322f] has joined #bitcoin-core-dev 16:21 -!- jnewbery_ [~john@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Remote host closed the connection] 16:23 -!- goatturner [~Beatrootg@2a02:c7d:12e:100:6c90:c46b:ec42:9874] has quit [Ping timeout: 246 seconds] 16:26 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #10535: [qa] fundrawtx: Fix shutdown race (master...Mf1706-qaFundrawRace) https://github.com/bitcoin/bitcoin/pull/10535 16:29 < midnightmagic> wait was there an rc that I missed a gitian for..? 16:29 < BlueMatt> 14.2? maybe? 16:30 < midnightmagic> argh 16:32 < achow101> midnightmagic: might as well not build it now since an rc2 is guaranteed and the rc1 codesigned bins won't be made 16:32 < achow101> the version number wasn't bumped 16:34 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:6815:da86:9de5:477a] has joined #bitcoin-core-dev 16:34 -!- talmai [~T@c-24-147-97-55.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 16:35 < midnightmagic> achow101: I have the time, and I am one of those completionists you see sometimes who opens every crate in the game just because there might be a coupla gold in there.. 16:35 < luke-jr> but there is no chance of gold in this case? :p 16:36 < midnightmagic> The gold is figurative! 16:38 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:50a:4941:8807:322f] has quit [Ping timeout: 255 seconds] 16:46 < luke-jr> midnightmagic: what does it represent in this case? 16:56 < bitcoin-git> [bitcoin] practicalswift opened pull request #10536: Remove unreachable or otherwise redundant code (master...unreachable) https://github.com/bitcoin/bitcoin/pull/10536 16:56 < midnightmagic> luke-jr: The reward of having opened every case. :) Also, I can say to people that I've built almost every gitian and therefore personally verified that almost every build is represented by source code as it is in the repo. 17:00 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 17:01 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 17:23 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10537: Few Minor per-utxo assert-semantics re-adds and tweak (master...2017-06-per-utxo-fixes) https://github.com/bitcoin/bitcoin/pull/10537 17:24 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-whymgnqllozxbejz] has quit [Quit: Connection closed for inactivity] 17:41 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 17:41 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 240 seconds] 17:42 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 17:44 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 255 seconds] 17:57 -!- bitbee [~bitbee@138.197.209.248] has joined #bitcoin-core-dev 17:59 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 18:01 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Remote host closed the connection] 18:02 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev 18:15 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:ac32:6f30:9bbd:24d5] has joined #bitcoin-core-dev 18:19 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:6815:da86:9de5:477a] has quit [Ping timeout: 260 seconds] 18:24 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:3828:6f0a:2c3:7300] has joined #bitcoin-core-dev 18:27 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:ac32:6f30:9bbd:24d5] has quit [Ping timeout: 246 seconds] 18:27 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 18:29 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 18:30 -!- dermoth [~thomas@dsl-66-36-135-165.mtl.aei.ca] has quit [Read error: Connection reset by peer] 18:31 -!- dermoth [~thomas@dsl-66-36-135-165.mtl.aei.ca] has joined #bitcoin-core-dev 18:33 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:d4d3:fc16:ff67:ce75] has joined #bitcoin-core-dev 18:37 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:3828:6f0a:2c3:7300] has quit [Ping timeout: 246 seconds] 18:37 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 18:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:46 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 18:52 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Quit: Leaving.] 19:16 -!- btcdrak [uid230524@gateway/web/irccloud.com/x-fixdhajsrtyzpzry] has joined #bitcoin-core-dev 19:23 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 19:30 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:3cfe:984b:2fa9:6b52] has joined #bitcoin-core-dev 19:34 -!- goatturneer [~Beatrootg@2a02:c7d:12e:100:d4d3:fc16:ff67:ce75] has quit [Ping timeout: 246 seconds] 19:44 < da2ce7_> Good Morning -core-dev. I have a draft-mailing list post that I would like some pre-posting review. 19:44 < da2ce7_> https://0bin.net/paste/kDmSQW8Lvw3Va5zP#jbdTlOKgja4yk7ZbXObSsgjRqTIGyeW2KeslIG-KPhH 19:44 < da2ce7_> Wallet and Exchange Proposal Best Practices for Schism Forks 19:46 < da2ce7_> * Proposed Wallet and Exchange Best Practices for the case of Schism Forks 19:46 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 258 seconds] 19:47 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 19:49 -!- Lightsword [~Lightswor@2604:a880:1:20::1d3:9001] has quit [Ping timeout: 255 seconds] 19:50 -!- Chris_Stewart_5 [~chris@173-31-39-168.client.mchsi.com] has joined #bitcoin-core-dev 19:57 < luke-jr> da2ce7_: I disagree that softforks can be the *cause* of a schism fork. In the case of BIP148, for example, the split is caused by miners violating the protocol rules. This is really no different than a split when the rule isn't newly added. 19:58 < luke-jr> and if nodes wilfully choose to follow the invalid chain, that removal of the rule is an attempted hardfork (and probably contentious) 19:58 < da2ce7_> Yes, miners can choose to cause a schism fork at any time if they wish to use checkpoints, the soft-fork is just an excuse. 19:59 < luke-jr> "pre-schism tokens" should be defined. Does it mean a UTXO valid on all chains? (or better, for fungibility, a claim to the same amount on all chains) 19:59 < luke-jr> da2ce7_: checkpoints are not needed either; they could for example choose to mine a larger-than-allowed subsidy 20:00 < da2ce7_> If we had evil-softfork implemented by the miners, then users could choose to create a schism to to reject this soft-forkl 20:01 < da2ce7_> Yes. I agree that the pre-schism tokens should be more-well-defined. 20:03 < luke-jr> evilforks aren't softforks :p 20:03 < da2ce7_> Maybe the virtual tokens should be something like 'spendable balance' on both chains. (utxo outputs, minus fees required to spend). So if somebody deposits 10000x small outputs is doesn't unbalance the pair. 20:04 < luke-jr> da2ce7_: what if Joe Schmo makes a schism fork of his own and doesn't tell exchanges? they owe JoeSchmocoins? 20:06 < da2ce7_> yes, we need some significance clause in the document. 20:06 < luke-jr> "Make sure that transaction replay protection has been implemented." I disagree this should be the standard case. If people want to withdraw "pre-schism tokens", replay should be intentionally enabled if anything. 20:07 < da2ce7_> no. you are forbidden to withdrawal pre-schism virtual tokens. 20:07 < luke-jr> that's dumb :P 20:07 < luke-jr> "Withdrawals MUST only be enabled until transaction relay protection has been added for both sides of the schism." <-- doesn't make sense 20:08 < da2ce7_> they don't exist. They are only virtually exist for accounting purposes. 20:08 < luke-jr> da2ce7_: before the schism, all withdrawls are pre-schism tokens 20:09 < da2ce7_> yup. post-schism pre-schism tokens don't exist. Only their virtual counterparts exist. 20:09 < luke-jr> the ideal for a neutral merchant/user is to wait for receives to confirm on both chains; this is only possible if replay is standard 20:09 < da2ce7_> Ok... I'll rephrase that part. 20:09 < luke-jr> preventing replay should only be done when the sender and recipient are taking a position 20:10 < da2ce7_> luke-jr no, because there are all sorts of attacks that may happen. For example, it may be not the same transaction that confirms because of transaction malleability. 20:11 < luke-jr> I don't see how that's a concern 20:11 < luke-jr> if I'm expecting a payment, and I have no bias as to which side of the schism, I simply wait for it to confirm on both sides. txids don't matter 20:12 < luke-jr> otoh, I guess if we assume market values on each side will differ, perhaps this neutral ideal is impractical 20:20 < da2ce7_> only if you are dealing with pre-schism tokens exclusively. However I wish make it clear to the users that there is now indeed two distinct coins, if they love that fact or not is besides the point. 20:24 -!- john1 [~john@host86-147-127-48.range86-147.btcentralplus.com] has quit [Ping timeout: 240 seconds] 20:42 -!- Lightsword [~Lightswor@2604:a880:1:20::1d3:9001] has joined #bitcoin-core-dev 20:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 20:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds] 20:52 -!- Chris_Stewart_5 [~chris@173-31-39-168.client.mchsi.com] has quit [Ping timeout: 268 seconds] 21:33 -!- beatrootfarmer [~Beatrootg@2a02:c7d:12e:100:3cfe:984b:2fa9:6b52] has quit [Ping timeout: 246 seconds] 21:33 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 22:21 -!- d_t [~textual@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 22:21 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 260 seconds] 22:21 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 22:33 -!- talmai [~T@c-24-147-97-55.hsd1.ma.comcast.net] has quit [Quit: mining] 22:42 -!- hephaestus [~hephaestu@217.78.102.135] has joined #bitcoin-core-dev 22:46 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 22:49 < wumpus> btcdrak: restarted 22:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 22:55 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 260 seconds] 22:55 -!- v3d [~hephaestu@217.78.97.15] has joined #bitcoin-core-dev 22:57 -!- hephaestus [~hephaestu@217.78.102.135] has quit [Ping timeout: 260 seconds] 22:58 -!- v3d [~hephaestu@217.78.97.15] has quit [Read error: Connection reset by peer] 22:59 -!- hephaestus [~hephaestu@217.78.97.15] has joined #bitcoin-core-dev 23:00 -!- dermoth [~thomas@dsl-66-36-135-165.mtl.aei.ca] has quit [Read error: Connection reset by peer] 23:00 -!- dermoth [~thomas@dsl-66-36-135-165.mtl.aei.ca] has joined #bitcoin-core-dev 23:25 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 23:30 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving] 23:30 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 255 seconds] 23:33 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 23:35 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 246 seconds] 23:36 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-qhilpafkzurohczk] has joined #bitcoin-core-dev 23:40 -!- JackH [~laptop@46.231.18.66] has joined #bitcoin-core-dev 23:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 23:48 -!- k4y4mm [~km@pastasuta.pro] has quit [Ping timeout: 245 seconds] 23:50 -!- kayamm [~km@pastasuta.pro] has joined #bitcoin-core-dev 23:50 -!- kayamm [~km@pastasuta.pro] has quit [Changing host] 23:50 -!- kayamm [~km@unaffiliated/kayamm] has joined #bitcoin-core-dev 23:52 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds] 23:59 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev