--- Day changed Wed Jun 21 2017 00:02 -!- neel [~neel@79.184.233.62.ipv4.supernova.orange.pl] has joined #bitcoin-core-dev 00:07 -!- neel [~neel@79.184.233.62.ipv4.supernova.orange.pl] has quit [Remote host closed the connection] 00:07 -!- neel [~neel@79.184.233.62.ipv4.supernova.orange.pl] has joined #bitcoin-core-dev 00:23 -!- neel [~neel@79.184.233.62.ipv4.supernova.orange.pl] has quit [Remote host closed the connection] 00:29 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-fxkmziqrrvqcuxpl] has joined #bitcoin-core-dev 00:30 -!- griswaalt [~griswaalt@ip5f5bd0d9.dynamic.kabel-deutschland.de] has quit [] 00:32 -!- sturles_ is now known as sturles 00:58 -!- neel [~neel@static-78-10-119-91.ssp.dialog.net.pl] has joined #bitcoin-core-dev 01:01 -!- goatpig [5a5c653a@gateway/web/freenode/ip.90.92.101.58] has joined #bitcoin-core-dev 01:01 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 01:02 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 01:07 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Ping timeout: 268 seconds] 01:07 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 01:13 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:19 -!- imposter [~kyle@99-105-22-176.lightspeed.miamfl.sbcglobal.net] has quit [Ping timeout: 260 seconds] 01:19 -!- neel [~neel@static-78-10-119-91.ssp.dialog.net.pl] has quit [Remote host closed the connection] 01:21 -!- neel [~neel@static-78-10-119-91.ssp.dialog.net.pl] has joined #bitcoin-core-dev 01:27 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 01:29 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 01:44 -!- vicenteH [~user@195.235.96.150] has joined #bitcoin-core-dev 02:23 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 02:25 -!- neel [~neel@static-78-10-119-91.ssp.dialog.net.pl] has quit [Remote host closed the connection] 02:27 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 02:28 -!- riemann [~riemann@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 02:35 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 248 seconds] 02:38 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 02:40 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 02:56 -!- neel [~neel@static-78-10-119-91.ssp.dialog.net.pl] has joined #bitcoin-core-dev 02:56 -!- neel [~neel@static-78-10-119-91.ssp.dialog.net.pl] has quit [Read error: Connection reset by peer] 02:57 -!- neel [~neel@static-78-10-119-91.ssp.dialog.net.pl] has joined #bitcoin-core-dev 03:04 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 03:06 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 03:08 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 03:08 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds] 03:13 -!- nemgun [~nemgun@105.101.144.71] has joined #bitcoin-core-dev 03:18 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 03:20 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 03:22 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 03:25 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection] 03:25 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev 03:34 -!- bordeaux_facile [~a@128.199.208.178] has quit [Quit: ZNC 1.6.3+deb1+xenial0 - http://znc.in] 03:37 -!- bordeaux_facile [~a@128.199.208.178] has joined #bitcoin-core-dev 03:40 -!- neel [~neel@static-78-10-119-91.ssp.dialog.net.pl] has quit [Remote host closed the connection] 03:41 -!- neel [~neel@static-78-10-119-91.ssp.dialog.net.pl] has joined #bitcoin-core-dev 03:43 -!- neel [~neel@static-78-10-119-91.ssp.dialog.net.pl] has quit [Remote host closed the connection] 03:44 -!- bordeaux_facile [~a@128.199.208.178] has quit [Quit: ZNC 1.6.3+deb1+xenial0 - http://znc.in] 03:45 -!- bordeaux_facile [~a@128.199.208.178] has joined #bitcoin-core-dev 03:47 -!- bordeaux_facile [~a@128.199.208.178] has quit [Client Quit] 03:48 -!- bordeaux_facile [~a@128.199.208.178] has joined #bitcoin-core-dev 03:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:02 -!- neel_ [~neel@static-78-10-119-91.ssp.dialog.net.pl] has joined #bitcoin-core-dev 04:05 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 04:09 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Ping timeout: 258 seconds] 04:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 04:13 -!- neel_ [~neel@static-78-10-119-91.ssp.dialog.net.pl] has quit [Remote host closed the connection] 04:20 -!- [b__b] [~b__b]@ec2-54-85-45-223.compute-1.amazonaws.com] has quit [Ping timeout: 260 seconds] 04:22 < bitcoin-git> [bitcoin] practicalswift opened pull request #10642: Use the _MSC_VER macro only if it is defined (master...undefined-msc-ver) https://github.com/bitcoin/bitcoin/pull/10642 04:28 -!- [b__b] [~b__b]@ec2-54-85-45-223.compute-1.amazonaws.com] has joined #bitcoin-core-dev 04:39 -!- roasbeef_ is now known as roasbeef 04:54 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 04:56 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:00 -!- neel [~neel@static-78-10-119-91.ssp.dialog.net.pl] has joined #bitcoin-core-dev 05:02 -!- talmai [~T@c-24-147-97-55.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 05:02 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection] 05:05 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 05:10 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds] 05:16 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 260 seconds] 05:17 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 05:31 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 05:42 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 05:44 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 05:52 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 05:53 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:54 < bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/b3eb0d648551...d083bd9b9c52 05:54 < bitcoin-git> bitcoin/master c53c983 Andrew Chow: Replace cookie auth in tests... 05:54 < bitcoin-git> bitcoin/master 3ec5ad8 Andrew Chow: Add test for rpcuser/rpcpassword 05:54 < bitcoin-git> bitcoin/master 279fde5 Andrew Chow: Check for rpcuser/rpcpassword first then for cookie... 05:55 < bitcoin-git> [bitcoin] laanwj closed pull request #10533: [tests] Use cookie auth instead of rpcuser and rpcpassword (master...tests-use-cookie-auth) https://github.com/bitcoin/bitcoin/pull/10533 06:04 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 06:17 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #bitcoin-core-dev 06:25 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:30 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 06:41 -!- dunatotatos [~dunatotat@109.171.130.211] has joined #bitcoin-core-dev 06:49 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 06:51 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 06:55 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 07:03 -!- talmai [~T@c-24-147-97-55.hsd1.ma.comcast.net] has quit [Quit: mining] 07:07 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 07:11 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Ping timeout: 268 seconds] 07:13 -!- neel [~neel@static-78-10-119-91.ssp.dialog.net.pl] has quit [Remote host closed the connection] 07:14 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 07:18 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 07:23 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 07:26 -!- neel [~neel@static-78-10-119-91.ssp.dialog.net.pl] has joined #bitcoin-core-dev 07:31 -!- neel [~neel@static-78-10-119-91.ssp.dialog.net.pl] has quit [Ping timeout: 240 seconds] 07:31 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 07:35 < bitcoin-git> [bitcoin] rexuslexus opened pull request #10643: TestCoin 0.0.1 (master...master) https://github.com/bitcoin/bitcoin/pull/10643 07:36 < bitcoin-git> [bitcoin] rexuslexus closed pull request #10643: TestCoin 0.0.1 (master...master) https://github.com/bitcoin/bitcoin/pull/10643 07:38 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 07:40 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 07:52 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 07:53 -!- Guyver2 [~Guyver2@guyver2.xs4all.nl] has quit [Quit: :)] 07:54 -!- riemann [~riemann@84-10-11-234.static.chello.pl] has quit [Quit: Leaving] 07:56 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has joined #bitcoin-core-dev 08:02 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 260 seconds] 08:03 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 08:10 -!- talmai [~T@c-76-24-28-74.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 08:12 -!- talmai [~T@c-76-24-28-74.hsd1.ma.comcast.net] has quit [Read error: Connection reset by peer] 08:17 -!- neel [~neel@static-78-10-119-91.ssp.dialog.net.pl] has joined #bitcoin-core-dev 08:18 -!- harrymm [~wayne@104.237.91.143] has quit [Ping timeout: 268 seconds] 08:22 -!- neel [~neel@static-78-10-119-91.ssp.dialog.net.pl] has quit [Ping timeout: 240 seconds] 08:28 -!- JackH [~laptop@46.231.18.66] has quit [Ping timeout: 255 seconds] 08:29 -!- dermoth [~thomas@2002:c766:9c06:dead::987] has quit [Ping timeout: 258 seconds] 08:33 -!- neel [~neel@static-78-10-119-91.ssp.dialog.net.pl] has joined #bitcoin-core-dev 08:37 -!- harrymm [~wayne@104.237.91.163] has joined #bitcoin-core-dev 08:40 -!- JackH [~laptop@217.149.140.177] has joined #bitcoin-core-dev 08:50 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 09:06 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev 09:08 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 09:09 -!- goatpig [5a5c653a@gateway/web/freenode/ip.90.92.101.58] has quit [Ping timeout: 260 seconds] 09:09 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 09:11 -!- RoyceX [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Ping timeout: 260 seconds] 09:13 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Ping timeout: 255 seconds] 09:13 -!- goatpig [c4345451@gateway/web/freenode/ip.196.52.84.81] has joined #bitcoin-core-dev 09:23 -!- neel [~neel@static-78-10-119-91.ssp.dialog.net.pl] has quit [Remote host closed the connection] 09:37 -!- imposter [~kyle@99-105-22-176.lightspeed.miamfl.sbcglobal.net] has joined #bitcoin-core-dev 09:46 -!- neel [~neel@79.184.219.112.ipv4.supernova.orange.pl] has joined #bitcoin-core-dev 09:49 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Read error: Connection reset by peer] 09:50 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 09:54 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 10:05 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 246 seconds] 10:10 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 10:10 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 10:14 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Ping timeout: 246 seconds] 10:15 -!- timothy [tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 10:19 -!- neel [~neel@79.184.219.112.ipv4.supernova.orange.pl] has quit [Remote host closed the connection] 10:20 -!- JackH [~laptop@217.149.140.177] has quit [Ping timeout: 240 seconds] 10:22 -!- paracyst_ [paracyst@unaffiliated/paracyst] has quit [Quit: bye] 10:22 -!- paracyst [paracyst@unaffiliated/paracyst] has joined #bitcoin-core-dev 10:23 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds] 10:27 -!- neel [~neel@79.184.219.112.ipv4.supernova.orange.pl] has joined #bitcoin-core-dev 10:32 -!- altoz [~Jimmy@cpe-24-55-54-186.austin.res.rr.com] has joined #bitcoin-core-dev 10:36 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 10:36 -!- vicenteH [~user@195.235.96.150] has quit [Ping timeout: 268 seconds] 10:38 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Ping timeout: 240 seconds] 10:42 < achow101> anyone know what's up with travis failing on #10637? 10:43 < gribble> https://github.com/bitcoin/bitcoin/issues/10637 | Coin Selection with Murchs algorithm by achow101 · Pull Request #10637 · bitcoin/bitcoin · GitHub 10:45 -!- Alina-malina [~Alina-mal@37.157.223.80] has joined #bitcoin-core-dev 10:45 -!- LeMiner [LeMiner@unaffiliated/leminer] has quit [Read error: Connection reset by peer] 10:49 -!- Alina-malina [~Alina-mal@37.157.223.80] has quit [Changing host] 10:49 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev 11:06 < jonasschnelli> achow101: unknown location(0): fatal error: in "coin_selection_tests/bnb_search_test": std::out_of_range: vector::_M_range_check 11:06 < jonasschnelli> mempool_limit.py | ✖ Failed | 4 s 11:06 < jonasschnelli> fundrawtransaction.py | ✖ Failed | 12 s 11:07 < sipa> sounds like an out of bounds access of a vector 11:07 < jonasschnelli> The rpc test failures are reported here: https://travis-ci.org/bitcoin/bitcoin/jobs/245174021 11:07 < achow101> jonasschnelli: there's also a build failure too 11:07 < jonasschnelli> unknown location(0): fatal error: in "coin_selection_tests/bnb_search_test": signal: SIGABRT (application abort requested) 11:08 < jonasschnelli> test_bitcoin: key.cpp:292: void ECC_Start(): Assertion `secp256k1_context_sign == __null' failed. 11:08 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 11:08 < jonasschnelli> haven't spotted the build error so far 11:08 < achow101> it's in one of the other travis builds 11:09 < achow101> https://travis-ci.org/bitcoin/bitcoin/jobs/245174020 11:09 < gmaxwell> some of the builds run with instrumented STL that detect things like out of range accesses to vectors. (often accessing [0] in an empty vector.) 11:09 < jonasschnelli> achow101: I guess compiling on a Trusty 14.04 VM and valgrund/lldb|gdb could help 11:09 < jonasschnelli> *valgrind 11:09 < gmaxwell> you can skip the vm stuff and just run valgrind on your test, it'll likely turn it up. 11:10 < achow101> I'll try 11:11 -!- LeMiner [LeMiner@unaffiliated/leminer] has joined #bitcoin-core-dev 11:27 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 268 seconds] 11:28 -!- neel [~neel@79.184.219.112.ipv4.supernova.orange.pl] has quit [Remote host closed the connection] 11:30 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has quit [Quit: Leaving] 11:37 -!- goatpig [c4345451@gateway/web/freenode/ip.196.52.84.81] has quit [Quit: Page closed] 11:38 < achow101> valgrind reported no problems 11:39 < jonasschnelli> achow101: OSX? 11:39 < achow101> no, on ubuntu 17.04 11:39 < achow101> I don't have a windows or osx machine readily available 11:39 < jonasschnelli> I had this before and IIRC I could also not reproduce some of the test failures... maybe VM Trusty 14.04 11:41 < jonasschnelli> achow101: maybe double check the travis build env (see what gmaxwell mentioned above "some of the builds run with instrumented STL")? 11:41 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 11:47 < gmaxwell> achow101: https://stackoverflow.com/questions/5594686/gcc-stl-bound-checking 11:48 -!- neel [~neel@79.184.219.112.ipv4.supernova.orange.pl] has joined #bitcoin-core-dev 11:50 < jonasschnelli> sipa: the txdb update skipper prework is here: https://github.com/bitcoin/bitcoin/compare/master...jonasschnelli:2017/06/chainstate_update_prog?expand=1 11:50 < jonasschnelli> The progress is fake.. 11:51 < jonasschnelli> And it's a bit hackish... I hope someone has a better design for the callback 11:52 < jonasschnelli> I detected db corruption when building a UTXO db on regtest with 0.14.2 (generate 100) and then exit on ShutdownRequested() in CCoinsViewDB::Upgrade() 11:52 < jonasschnelli> * exit on master + the work above 11:52 < cfields> achow101: note that the last time this came up, it was an issue of: memcpy(foo, bar[0], 0), where bar was empty. Valgrind won't report it because the out-of-bounds memory isn't actually copied, but it's still a bad an idea to [0] an empty container. 11:53 < achow101> I'm pretty sure I don't have anything like that in my changes 11:54 < sipa> jonasschnelli: i recently fixed a bug that could cause that 11:55 < jonasschnelli> sipa: already merged? Then I guess I should retest 11:55 < sipa> jonasschnelli: a few days ago 11:55 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 11:56 < jonasschnelli> Not sure if the approach of a "c" keypress in splashscreen to abort the UTXO-set upgrade makes sense.. 11:56 < jonasschnelli> Though adding buttons on splashscreen is – with the current design – cumbersome 11:58 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 11:58 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 255 seconds] 12:10 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #10644: Slightly overhaul NSI pixmaps (master...2017/06/cleanup) https://github.com/bitcoin/bitcoin/pull/10644 12:11 -!- jamesob [~jamesob@73.241.180.136] has joined #bitcoin-core-dev 12:11 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 12:12 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 240 seconds] 12:12 < bitcoin-git> [bitcoin] practicalswift opened pull request #10645: Use nullptr instead of zero (0) as the null pointer constant (master...welcome-nullptr-goodbye-0) https://github.com/bitcoin/bitcoin/pull/10645 12:16 -!- jamesob [~jamesob@73.241.180.136] has quit [Ping timeout: 276 seconds] 12:17 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 12:23 < achow101> it seems that the problem may be due to my use of long instead of CAmount in one of the tests I wrote 12:24 -!- ananteris [~user@unaffiliated/ananteris] has quit [Ping timeout: 240 seconds] 12:24 < sipa> jonasschnelli: what is the sleep for? 12:24 < jonasschnelli> sipa: dummy progress 12:24 < jonasschnelli> only to test 12:25 -!- ananteris [~user@185.149.90.91] has joined #bitcoin-core-dev 12:25 < sipa> oh 12:25 < jonasschnelli> jonasschnelli: you should add the right code and replace "progress += 0.00001;" 12:25 < jonasschnelli> Now I start to ping myself 12:25 < jonasschnelli> sipa: ... and remove the sleep 12:26 < sipa> you should not remove sleep from yourself 12:27 < sipa> or you'll end up doing things like pining yourself 12:27 < jonasschnelli> hahaa 12:28 * jonasschnelli feels like "progress += 0.00001;" in reallife 12:31 < sipa> jonasschnelli: uh... nvm 12:32 < sipa> the bug i was talking about is in the non-atomic upgrade PR 12:32 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds] 12:32 < sipa> not in master 12:32 < jonasschnelli> okay. Because I just tested with master and still have the corruption.. 12:33 < sipa> :( 12:33 < jonasschnelli> reminds me that we should have a strategy of how to test upgrades (chainstate-db, old wallet files) in functional tests 12:33 < sipa> that's very hard, unless you store an old version's chainstate inside the test.. 12:33 < sipa> just logistically 12:33 < jonasschnelli> I think that would be the simplest solution. 12:33 < jonasschnelli> Compiling an old version will not be possible (at lest not in travis CI) 12:34 < sdaftuar> yeah its hard to get to work in travis, but not so hard conceptually to write the test in our test framework. passing in a custom binary to a functional test works fine. 12:34 < jonasschnelli> I think having some test old blobs fixtures may be okay 12:35 < sdaftuar> i believe i wrote a test like this in p2p-segwit (before we supported modifying bip9 parameters on the command line) 12:35 < jonasschnelli> It's one of the most lacking things in our test framework (migrations) 12:35 < sipa> those blobs could even be dependencies (as in, for the depends framework) 12:35 < sipa> with known hashes, but downloaded at build time 12:36 < jonasschnelli> yes.. sure. 12:36 < jonasschnelli> Especially if they are large... 12:36 < jonasschnelli> for wallet files, I don't mind having a couple of 20kb bdb 4.8 files in our test framework 12:38 -!- ananteris [~user@185.149.90.91] has quit [Changing host] 12:38 -!- ananteris [~user@unaffiliated/ananteris] has joined #bitcoin-core-dev 12:45 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 13:04 -!- Dizzle [~dizzle@108.171.182.16] has quit [Ping timeout: 240 seconds] 13:05 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 13:31 -!- vicenteH [~user@135.234.15.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 13:38 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds] 13:42 -!- heyjude [a2fbb9ae@gateway/web/freenode/ip.162.251.185.174] has joined #bitcoin-core-dev 13:44 -!- heyjude [a2fbb9ae@gateway/web/freenode/ip.162.251.185.174] has quit [Client Quit] 13:46 -!- imposter [~kyle@99-105-22-176.lightspeed.miamfl.sbcglobal.net] has quit [Ping timeout: 240 seconds] 13:48 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev 13:50 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 13:53 -!- cheese_ [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 13:55 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Ping timeout: 260 seconds] 14:05 -!- lifeofguenter [~lifeofgue@bnc.pro.to.co.ls] has quit [Excess Flood] 14:05 -!- neel [~neel@79.184.219.112.ipv4.supernova.orange.pl] has quit [Remote host closed the connection] 14:05 -!- lifeofguenter [~lifeofgue@bnc.pro.to.co.ls] has joined #bitcoin-core-dev 14:12 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 14:17 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds] 14:19 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 14:20 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 14:35 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds] 14:39 -!- neel [~neel@79.184.219.112.ipv4.supernova.orange.pl] has joined #bitcoin-core-dev 14:48 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 14:55 -!- dunatotatos [~dunatotat@109.171.130.211] has quit [Remote host closed the connection] 14:55 -!- dunatotatos [~dunatotat@109.171.130.211] has joined #bitcoin-core-dev 14:58 -!- dunatotatos [~dunatotat@109.171.130.211] has quit [Remote host closed the connection] 14:58 -!- dunatotatos [~dunatotat@109.171.130.211] has joined #bitcoin-core-dev 15:01 -!- dunatotatos [~dunatotat@109.171.130.211] has quit [Remote host closed the connection] 15:02 -!- dunatotatos [~dunatotat@109.171.130.211] has joined #bitcoin-core-dev 15:05 -!- dunatotatos [~dunatotat@109.171.130.211] has quit [Remote host closed the connection] 15:05 -!- dunatotatos [~dunatotat@109.171.130.211] has joined #bitcoin-core-dev 15:08 -!- dunatotatos [~dunatotat@109.171.130.211] has quit [Remote host closed the connection] 15:09 -!- dunatotatos [~dunatotat@109.171.130.211] has joined #bitcoin-core-dev 15:11 -!- neel [~neel@79.184.219.112.ipv4.supernova.orange.pl] has quit [Remote host closed the connection] 15:12 -!- dunatotatos [~dunatotat@109.171.130.211] has quit [Read error: Connection reset by peer] 15:12 -!- dunatotatos [~dunatotat@109.171.130.211] has joined #bitcoin-core-dev 15:14 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 15:15 -!- dunatotatos [~dunatotat@109.171.130.211] has quit [Remote host closed the connection] 15:15 -!- dunatotatos [~dunatotat@109.171.130.211] has joined #bitcoin-core-dev 15:18 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Ping timeout: 255 seconds] 15:18 -!- dunatotatos [~dunatotat@109.171.130.211] has quit [Remote host closed the connection] 15:19 -!- dunatotatos [~dunatotat@109.171.130.211] has joined #bitcoin-core-dev 15:19 -!- Dizzle [~dizzle@108.171.182.16] has quit [Remote host closed the connection] 15:22 -!- dunatotatos [~dunatotat@109.171.130.211] has quit [Remote host closed the connection] 15:42 -!- nemgun [~nemgun@105.101.144.71] has quit [Read error: Connection reset by peer] 15:43 -!- nemgun [~nemgun@105.101.158.11] has joined #bitcoin-core-dev 15:44 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 15:47 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds] 16:00 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 16:05 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Ping timeout: 260 seconds] 16:28 -!- Cheeseo [~Cheeseo@unaffiliated/cheeseo] has joined #bitcoin-core-dev 16:35 -!- Cheeseo [~Cheeseo@unaffiliated/cheeseo] has quit [Read error: Connection reset by peer] 16:52 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 255 seconds] 16:58 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 17:06 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 17:11 < sipa> jonasschnelli: https://github.com/sipa/bitcoin/commits/progress 17:11 -!- neel [~neel@79.184.219.112.ipv4.supernova.orange.pl] has joined #bitcoin-core-dev 17:12 < sipa> jonasschnelli: you were just returning from Upgrade without shutting down... no wonder you get a corruption :) 17:15 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 17:16 -!- unholymachine [~quassel@2601:8c:c003:9f16:4891:37ef:9ad0:e1ee] has quit [Quit: No Ping reply in 180 seconds.] 17:16 -!- unholymachine [~quassel@2601:8c:c003:9f16:20cf:db87:f7dd:a8ca] has joined #bitcoin-core-dev 17:16 -!- neel [~neel@79.184.219.112.ipv4.supernova.orange.pl] has quit [Ping timeout: 260 seconds] 17:19 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds] 17:44 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has joined #bitcoin-core-dev 18:02 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-fxkmziqrrvqcuxpl] has quit [Quit: Connection closed for inactivity] 18:10 -!- goatpig [68a01504@gateway/web/freenode/ip.104.160.21.4] has joined #bitcoin-core-dev 18:14 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 240 seconds] 18:16 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 18:22 -!- marcoagn1 [~user@187.113.159.77] has quit [Ping timeout: 260 seconds] 18:34 -!- marcoagn1 [~user@177.99.120.94] has joined #bitcoin-core-dev 18:58 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 18:59 -!- neel [~neel@79.184.220.5.ipv4.supernova.orange.pl] has joined #bitcoin-core-dev 19:00 -!- echonaut [~echonaut@46.101.192.134] has quit [Remote host closed the connection] 19:01 -!- echonaut3 [~echonaut@46.101.192.134] has joined #bitcoin-core-dev 19:05 -!- neel [~neel@79.184.220.5.ipv4.supernova.orange.pl] has quit [Ping timeout: 240 seconds] 19:13 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds] 19:28 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev 19:29 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 19:44 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 20:26 -!- nemgun [~nemgun@105.101.158.11] has quit [Quit: Leaving] 20:41 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds] 20:44 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:44 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Client Quit] 20:45 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:46 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 21:11 -!- imposter [~kyle@99-105-22-176.lightspeed.miamfl.sbcglobal.net] has joined #bitcoin-core-dev 21:23 -!- marcoagn1 [~user@177.99.120.94] has quit [Ping timeout: 276 seconds] 21:34 -!- marcoagn1 [~user@177.41.193.43] has joined #bitcoin-core-dev 21:39 -!- randy-waterhouse [~randy-wat@opentransactions/dev/randy-waterhouse] has joined #bitcoin-core-dev 21:42 -!- sogo [74fe6442@gateway/web/freenode/ip.116.254.100.66] has joined #bitcoin-core-dev 22:00 -!- imposter [~kyle@99-105-22-176.lightspeed.miamfl.sbcglobal.net] has quit [Ping timeout: 240 seconds] 22:01 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Remote host closed the connection] 22:01 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 22:06 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds] 22:10 -!- sogo [74fe6442@gateway/web/freenode/ip.116.254.100.66] has quit [Ping timeout: 260 seconds] 22:26 -!- randy-waterhouse [~randy-wat@opentransactions/dev/randy-waterhouse] has quit [Quit: Leaving.] 22:40 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving] 22:53 -!- CubicEarth [~cubiceart@50-1-104-188.dsl.dynamic.fusionbroadband.com] has joined #bitcoin-core-dev 22:57 -!- Deadhand [~deadhand@CPEf0f249a14e43-CMf0f249a14e40.cpe.net.cable.rogers.com] has quit [Ping timeout: 260 seconds] 22:58 -!- Deadhand [~deadhand@CPEf0f249a14e43-CMf0f249a14e40.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev 23:02 < jonasschnelli> sipa: okay. I see. :/ 23:22 -!- CubicEarth [~cubiceart@50-1-104-188.dsl.dynamic.fusionbroadband.com] has quit [] 23:40 -!- vicenteH [~user@135.234.15.37.dynamic.jazztel.es] has quit [Read error: Connection reset by peer] 23:40 -!- vicenteH [~user@135.234.15.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 23:47 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-vtgbmkbyomnovnoi] has joined #bitcoin-core-dev 23:49 -!- JackH [~laptop@46.231.18.66] has joined #bitcoin-core-dev