--- Day changed Wed Jun 28 2017
00:00 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection]     
00:00 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev     
00:06 < bitcoin-git> [bitcoin] laanwj opened pull request #10688: contrib: Update laanwj key (master...2017_06_laanwj_key) https://github.com/bitcoin/bitcoin/pull/10688
00:15 < wumpus> PRab: yes, upgrades are not persistent, it happens every gbuild on the copied image
00:15 < wumpus> there's no documented way to upgrade the base image - I tried it last time but ended up with 3 versions of gcc installed and a wrong gitian output :)
00:22 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/acb11535cb84...a381f6a5bdc2
00:22 < bitcoin-git> bitcoin/master 22378ad Alex Morcos: Remove no longer used mempool.exists(outpoint)
00:22 < bitcoin-git> bitcoin/master a381f6a Wladimir J. van der Laan: Merge #10684: Remove no longer used mempool.exists(outpoint)...
00:22 < bitcoin-git> [bitcoin] laanwj closed pull request #10684: Remove no longer used mempool.exists(outpoint) (master...lessHaveCoin) https://github.com/bitcoin/bitcoin/pull/10684
00:32 < luke-jr> (but that's what the apt cacher is for)
00:33 < wumpus> which caches the download, but not the install itself, which still takes some time
00:33 < wumpus> especially when a release gets older and more updates pile up
00:45 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev     
00:49 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds]     
00:57 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Quit: WeeChat 1.7.1]     
00:57 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev     
01:07 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev     
01:11 -!- Yogaqueef [~textual@dsl-hkibng42-5673c3-32.dhcp.inet.fi] has joined #bitcoin-core-dev     
01:23 -!- spinza [~spin@196.212.164.26] has quit [Ping timeout: 255 seconds]     
01:24 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has quit [Quit: Leaving.]     
01:31 -!- spinza [~spin@196.212.164.26] has joined #bitcoin-core-dev     
02:07 -!- aj [aj@139.162.42.226] has quit [Ping timeout: 240 seconds]     
02:07 -!- aj [aj@cerulean.erisian.com.au] has joined #bitcoin-core-dev     
02:16 -!- rockhouse [~rockhouse@h54110.upc-h.chello.nl] has joined #bitcoin-core-dev     
02:18 -!- Gabo [~Gabo@cust-218-142-109-94.dyn.as47377.net] has joined #bitcoin-core-dev     
02:21 -!- Gabo [~Gabo@cust-218-142-109-94.dyn.as47377.net] has quit [Remote host closed the connection]     
03:20 -!- talmai [~T@c-76-24-28-74.hsd1.ma.comcast.net] has joined #bitcoin-core-dev     
03:22 -!- marcoagner [~user@177.41.202.62] has quit [Ping timeout: 260 seconds]     
03:33 -!- marcoagner [~user@177.99.123.164] has joined #bitcoin-core-dev     
03:43 -!- JackH [~laptop@46.231.18.66] has joined #bitcoin-core-dev     
03:49 -!- riemann [~riemann@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev     
03:51 -!- Victor_sueca is now known as Victorsueca     
04:08 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
04:23 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt]     
04:28 < bitcoin-git> [bitcoin] tiagmoraismorgado opened pull request #10689: fixing a couple of typos (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10689
04:29 < morcos> As an RPC argument, fundrawtransaction uses optIntoRbf, bumpfee uses replaceable, my recent PR used opt_in_rbf for sendtoaddress and sendmany.  Should I instead use replaceable?  (I felt that was maybe too general a word)  Or should I change the preexisting argument names?
04:54 < wumpus> morcos: from the developer notes, RPC interface guidelines: Argument naming: use snake case `fee_delta` (and not, e.g. camel case `feeDelta`)
04:54 < wumpus> so opt_in_rbf or replaceable are ok
04:56 < wumpus> it's unfortunate that there is such a zoo of different argument names for the same
04:59 < wumpus> for API changes introduced since 0.14 there's still the possibility of normalizing them
05:04 -!- talmai [~T@c-76-24-28-74.hsd1.ma.comcast.net] has quit [Ping timeout: 246 seconds]     
05:07 < morcos> wumpus: oh looks like optIntoRbf was just merged
05:07 < morcos> so what do you think, make them all replaceable?  and not worry that it sounds a bit too generic
05:07 < morcos> seems fine to me, the help can always clarify it means BIP-125 replaceable
05:07 < morcos> and we don't have any other notion for now
05:07 < wumpus> sounds good to me 
05:08 < morcos> ok will do
05:08 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection]     
05:08 < wumpus> general is good from an API viewpoint I guess - the user might not care how the replacement works, just that the transaction can be replaced
05:12 < wumpus> (on the other hand, if different kinds of replacement would be supported, they might want to choose a certain one based on their specific properties... but meh, could always add an additional field for replacement type)
05:19 < morcos> luke-jr: you ok with changing optIntoRbf and optintorbf that you added in #9672 to replaceable?  should i also change rbfoptin from bitcoin-tx (same PR) ?
05:19 < gribble> https://github.com/bitcoin/bitcoin/issues/9672 | Opt-into-RBF for RPC & bitcoin-tx by luke-jr · Pull Request #9672 · bitcoin/bitcoin · GitHub
05:32 -!- PRab [~chatzilla@c-68-56-234-28.hsd1.mi.comcast.net] has quit [Ping timeout: 276 seconds]     
05:57 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev     
06:02 -!- drizztbsd [tredaelli@redhat/timothy] has joined #bitcoin-core-dev     
06:03 -!- timothy [tredaelli@redhat/timothy] has quit [Ping timeout: 276 seconds]     
06:06 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a381f6a5bdc2...9a941a10101d
06:06 < bitcoin-git> bitcoin/master aa95947 practicalswift: Use the override specifier (C++11) where we expect to be overriding the virtual function of a base class
06:06 < bitcoin-git> bitcoin/master 9a941a1 Wladimir J. van der Laan: Merge #10631: Use the override specifier (C++11) where we expect to be overriding the virtual function of a base class...
06:06 < bitcoin-git> [bitcoin] laanwj closed pull request #10631: Use the override specifier (C++11) where we expect to be overriding the virtual function of a base class (master...overrides-ii) https://github.com/bitcoin/bitcoin/pull/10631
06:25 < bitcoin-git> [bitcoin] laanwj closed pull request #9527: Enable RBF transactions in wallet by default (master...pr/walletrbf) https://github.com/bitcoin/bitcoin/pull/9527
06:27 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
06:29 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev     
06:55 -!- Guyver2_ [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev     
06:57 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 260 seconds]     
06:57 -!- Guyver2_ is now known as Guyver2     
07:00 -!- drizztbsd [tredaelli@redhat/timothy] has quit [Ping timeout: 276 seconds]     
07:01 < bitcoin-git> [bitcoin] fanquake closed pull request #10689: fixing a couple of typos (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10689
07:01 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 240 seconds]     
07:03 < bitcoin-git> [bitcoin] sdaftuar opened pull request #10690: [qa] Bugfix: allow overriding extra_args in ComparisonTestFramework (master...2017-06-comp-framework-extraargs) https://github.com/bitcoin/bitcoin/pull/10690
07:03 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev     
07:17 -!- drizztbsd [tredaelli@redhat/timothy] has joined #bitcoin-core-dev     
07:18 -!- drizztbsd is now known as timothy     
07:24 < Chris_Stewart_5> There isn't any consensus rule that says coinbase transaction's can't spend outputs is there? 
07:30 < wumpus> coinbase tranactions's input is ignored
07:30 < instagibbs> Chris_Stewart_5, https://github.com/bitcoin/bitcoin/blob/08a7316c144f9f2516db8fa62400893f4358c5ae/src/primitives/transaction.h#L336
07:35 -!- Greybits is now known as _Sam--     
07:38 < sdaftuar> sipa: i think i agree with you that it'd be nice to assert if DISCOURAGE_UPGRADABLE_NOPS is given, but CLTV/CSV are not
07:39 < sdaftuar> also i assume (someday) DISCOURAGE_UPGRADABLE_WITNESS_PROGRAM could have the same issue
07:40 < sdaftuar> BlueMatt: i think testing is more complicated, not less, by allowing that combination of script flags
07:58 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev     
08:14 -!- JackH [~laptop@46.231.18.66] has quit [Quit: Leaving]     
08:15 < BlueMatt> sdaftuar: fair
08:30 < sipa> sdaftuar: so, say we adopt a new OP_NOP4 at some point, and a softfork is proposed to deal with it
08:31 < sipa> we'd make it subject to DISCOURAGE_UPGRADABLE_NOPS only when the new flag is not set
08:32 < sipa> with an assert that requires upgradable_nops to also have the new SF active, it means you can't enforce a policy of rejecting such transactions in the mempool before the SF happens
08:33 < sipa> i wonder if that's how we've always done softforks
08:33 < sdaftuar> i don't think i follow --
08:33 < sdaftuar> presumably the software that introduces the new OP_NOP4 thing will immediately enforce it in the mempool?
08:34 < sipa> sure
08:34 < sdaftuar> upgradable_nops doesn't require the new SF is active, it just requires that your new policy is active
08:34 < sdaftuar> since upgradable_nops is only ever policy
08:34 < sipa> sure
08:34 < sdaftuar> oh!     
08:34 < sdaftuar> now i understand
08:34 < sipa> but i mean: it seems strange to allow (valid) OP_NOP4 transactions in the mempool before the SF activates
08:35 < sipa> they'd be mined too
08:35 < sdaftuar> right, we had this issue with CSV i think
08:35 < sdaftuar> where we added a special rule on version 2 transactions being rejected pre-activation
08:36 < sdaftuar> for CLTV, i think we just allowed valid CLTV transactions in the mempool pre-activation
08:36 < sdaftuar> well, i think what we did for CSV was the right thing.
08:37 < sipa> for CSV it worked by keeping v2 transactions nonstandard until needed, i think
08:37 < sdaftuar> yep     
08:37 < sipa> that won't work for every SF
08:37 < sdaftuar> well the OP_NOP style of SF is probably not long for this world, no?
08:38 < sdaftuar> i think the question is how do we envision it working in segwit
08:38 < sipa> same applies to upgradable_witness_program
08:39 < sdaftuar> so upgradable_witness_program definitely shouldn't be in the mempool pre-activation, i think.
08:39 < sipa> right
08:39 < sipa> but i think that requires 3 script flags
08:40 < sipa> 1) discourage_upgradable_witness_program (which does not apply anymore to v1 witness programs)
08:40 < sipa> 2) discourage v1 witness programs
08:41 < sipa> 3) enforce v1 witness program rules
08:42 < sipa> chain uses none before activation, (3) after
08:42 < sipa> mempool uses (1)+(2) before activation, (2)+(3) after
08:44 < sipa> eh, (1)+(3) after
08:46 < sdaftuar> i think that makes sense, conceptually.  it would be nice if (2) didn't need to waste a script flag bit, though.
08:49 < sipa> (2) could be twmporary i guess
08:49 < sipa> as logic for the pre-activation mempool case isn't needed long term
08:49 < sdaftuar> agreed
08:49 < sipa> though it may be of longer term use in tests
09:01 -!- riemann [~riemann@84-10-11-234.static.chello.pl] has quit [Quit: Leaving]     
09:12 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9a941a10101d...416af3edf5b5
09:12 < bitcoin-git> bitcoin/master 4ed3653 Suhas Daftuar: [qa] Bugfix: allow overriding extra_args in ComparisonTestFramework
09:12 < bitcoin-git> bitcoin/master 416af3e MarcoFalke: Merge #10690: [qa] Bugfix: allow overriding extra_args in ComparisonTestFramework...
09:13 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #10690: [qa] Bugfix: allow overriding extra_args in ComparisonTestFramework (master...2017-06-comp-framework-extraargs) https://github.com/bitcoin/bitcoin/pull/10690
09:27 < bitcoin-git> [bitcoin] laanwj pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/416af3edf5b5...d4e551adfec2
09:27 < bitcoin-git> bitcoin/master b3a279c Pieter Wuille: [MOVEONLY] Move LastCommonAncestor to chain
09:27 < bitcoin-git> bitcoin/master 013a56a Pieter Wuille: Non-atomic flushing using the blockchain as replay journal
09:27 < bitcoin-git> bitcoin/master 0580ee0 Pieter Wuille: Adapt memory usage estimation for flushing
09:27 < bitcoin-git> [bitcoin] laanwj closed pull request #10148: Use non-atomic flushing with block replay (master...non_atomic_flush) https://github.com/bitcoin/bitcoin/pull/10148
09:28 < bitcoin-git> [bitcoin] wraith7 opened pull request #10691: Trivial: Properly comment about shutdown process in init.cpp file. (master...master) https://github.com/bitcoin/bitcoin/pull/10691
09:33 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
09:35 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds]     
09:38 -!- goatpig [5a5c653a@gateway/web/freenode/ip.90.92.101.58] has quit [Quit: Page closed]     
09:45 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt]     
09:50 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10692: Make mapBlockIndex and chainActive and all CBlockIndex*es const outside of validation/CChainState (master...2017-04-const-mapblockindex) https://github.com/bitcoin/bitcoin/pull/10692
09:51 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 255 seconds]     
10:04 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev     
10:09 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev     
10:10 -!- timothy [tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]     
10:42 -!- spinza [~spin@196.212.164.26] has quit [Quit: Coyote finally caught up with me...]     
10:55 -!- atroxes [~atroxes@unaffiliated/atroxes] has quit [Quit: bye]     
10:55 -!- spinza [~spin@196.212.164.26] has joined #bitcoin-core-dev     
10:57 -!- atroxes [~atroxes@unaffiliated/atroxes] has joined #bitcoin-core-dev     
10:58 -!- annanay25 [~csbtech@geekon.tech] has left #bitcoin-core-dev []     
10:58 -!- annanay25 [~csbtech@geekon.tech] has joined #bitcoin-core-dev     
11:02 < bitcoin-git> [bitcoin] practicalswift opened pull request #10694: Remove redundant code in MutateTxSign(CMutableTransaction&, const std::string&) (master...remove-redundant-code-in-MutateTxSign) https://github.com/bitcoin/bitcoin/pull/10694
11:11 < morcos> I'm trying to clean up some of the wallet fee logic around minimums and maximums and set fees vs estimates.
11:11 < morcos> When should we obey the global maxtxfee?
11:11 < morcos> Right now we do not obey that for fundrawtransaction, but the changes I was lookign at making would refactor so that fundrawtransaction does obey that
11:12 < BlueMatt> sounds good
11:12 < BlueMatt> consistency above all, imo
11:12 < BlueMatt> actual decision isnt critical, consistency is
11:12 < morcos> But I could see how fundrawtransction is a different beast that maybe you want to be able to ignore that setting for.
11:16 < morcos> similar question for obeying minimums
11:18 < instagibbs> Consistency is my expectation as a user of that api
11:20 < instagibbs> (controls to override are totally fine ofc)
11:22 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d4e551adfec2...30c21306c171
11:22 < bitcoin-git> bitcoin/master 381b8fc Matt Corallo: Clarify CCoinsViewMemPool documentation....
11:22 < bitcoin-git> bitcoin/master 30c2130 Pieter Wuille: Merge #10685: Clarify CCoinsViewMemPool documentation....
11:22 < bitcoin-git> [bitcoin] sipa closed pull request #10685: Clarify CCoinsViewMemPool documentation. (master...2017-06-ccoinsviewmempool-doc-cleanup) https://github.com/bitcoin/bitcoin/pull/10685
11:26 < instagibbs> my effective feerate did the split out of the max fee check, IIRC you didn't like it at the time
11:42 < luke-jr> morcos: not really. that would break compatibility, and gives a false impression that other transactions aren't replacable.
11:43 < luke-jr> but in terms of normalising to use underscores, IIRC we support multiple names now..
11:44 < luke-jr> so we could do opt_into_rbf|optintorbf?
11:44 < luke-jr> (and the same for older params)
11:44 < bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/30c21306c171...90a002ea647d
11:44 < bitcoin-git> bitcoin/master 3c8a9ae Alex Morcos: Add belt-and-suspenders in DisconnectBlock...
11:44 < bitcoin-git> bitcoin/master 21d4afa Alex Morcos: Comment clarifications in coins.cpp
11:44 < bitcoin-git> bitcoin/master 90a002e Pieter Wuille: Merge #10558: Address nits from per-utxo change...
11:45 < bitcoin-git> [bitcoin] sipa closed pull request #10558: Address nits from per-utxo change (master...10195nits) https://github.com/bitcoin/bitcoin/pull/10558
11:46 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has joined #bitcoin-core-dev     
12:01 -!- Dizzle [~dizzle@108.171.182.16] has quit [Quit: brb]     
12:09 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-fgajuiiqnzzovftn] has quit [Quit: Connection closed for inactivity]     
12:17 -!- _Sam-- [~greybits@unaffiliated/greybits] has quit [Quit: Leaving]     
12:25 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev     
12:47 < bitcoin-git> [bitcoin] sdaftuar opened pull request #10695: [qa] Rewrite BIP65 functional tests (master...2017-06-fix-bip65-test) https://github.com/bitcoin/bitcoin/pull/10695
12:50 -!- nakaluna [~nakaluna@gateway/vpn/privateinternetaccess/nakaluna] has joined #bitcoin-core-dev     
13:31 -!- talmai [~T@c-76-24-28-74.hsd1.ma.comcast.net] has joined #bitcoin-core-dev     
13:39 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
13:39 < morcos> luke-jr: the main issue is the only argument name already in release is part of bumpfee and it's already called replaceable
13:40 < morcos> so while i agree that opt_in_rbf or similar would be even better
13:40 < morcos> i'm not sure its worth breaking existing API or having multiple names that mean the same thing
13:40 < morcos> and i think perhaps we should just go with replaceable for now?
13:40 -!- Murch [~murch@208.66.24.182] has joined #bitcoin-core-dev     
13:40 -!- Yogaqueef [~textual@dsl-hkibng42-5673c3-32.dhcp.inet.fi] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]     
13:40 < morcos> but i could be convinced otherwise
13:46 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt]     
13:47 -!- nakaluna [~nakaluna@gateway/vpn/privateinternetaccess/nakaluna] has quit [Quit: -]     
13:53 -!- Murch [~murch@208.66.24.182] has quit [Quit: Snoozing.]     
13:55 -!- mol [~IRCIdent@unaffiliated/molly] has quit [Quit: ZNC 1.6.5 - http://znc.in]     
14:02 < luke-jr> morcos: they're all in release (Knots)
14:03 < luke-jr> but as long as the current name is retained as an alias, it doesn't really break the API
14:10 < BlueMatt> bitcoin core does not support Knots releases, so I dont think you can argue we're tied to Knots' API - Knots can apply patches if it likes
14:14 < luke-jr> Bitcoin Core doesn't NOT support Knots releases either. Knots APIs are not necessarily guaranteed, but we should try to maintain compatibility when reasonable.
14:16 < cfields> BlueMatt: I'm looking at #10652 now. Can you give a bit of context for "Turn mapBlocksInFlight into a multimap" ?
14:16 < gribble> https://github.com/bitcoin/bitcoin/issues/10652 | Small step towards demangling cs_main from CNodeState by TheBlueMatt · Pull Request #10652 · bitcoin/bitcoin · GitHub
14:17 < BlueMatt> cfields: sec, redoing pr
14:17 < BlueMatt> give me 30 seconds
14:17 < BlueMatt> i mean not really, just splitting
14:17 < cfields> ok. same one?
14:18 < bitcoin-git> [bitcoin] practicalswift opened pull request #10696: Remove redundant nullptr checks before deallocation (master...delete-nullptr) https://github.com/bitcoin/bitcoin/pull/10696
14:18 < cfields> if so, please consider ^^ a request for a more thorough commit message :)
14:19 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10697: Do not hold cs_vNodes when making ForEachNode Callbacks (master...2017-06-cnodestateaccessors-5) https://github.com/bitcoin/bitcoin/pull/10697
14:19 < BlueMatt> heh, naa, I was just splitting the pr
14:20 < BlueMatt> cfields: those commits are rebased from #9447
14:20 < gribble> https://github.com/bitcoin/bitcoin/issues/9447 | Allow 2 simultaneous block downloads by morcos · Pull Request #9447 · bitcoin/bitcoin · GitHub
14:21 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Ping timeout: 276 seconds]     
14:21 < cfields> ah ok, thanks
14:22 < BlueMatt> cfields: lemme take a crack at a more expansive commit message since they now lack the context of actually adding simultaneous block downloads
14:22 < cfields> BlueMatt: thanks. the PR title answers my question, though. I just wasn't sure what exactly it was setting the stage for.
14:23 < BlueMatt> yea, its setting the stage for two things - parallel block downloads but also having per-CNodeState locks
14:24 < BlueMatt> the per-CNodeState locks need that change so that you dont hold two at the same time (which would be a lockorder violation)
14:24 < BlueMatt> so you need to MarkBlockAsReceived in the background (ie via CValidationInterface callbacks) and not access the mapBlocksInFlight entries of other peers when you go to download a block
14:27 -!- ProfMac_ [43c671dc@gateway/web/freenode/ip.67.198.113.220] has quit [Ping timeout: 260 seconds]     
14:28 < BlueMatt> cfields: https://github.com/bitcoin/bitcoin/pull/10652#issuecomment-311797355 sufficient?
14:28 < cfields> yes, thanks
14:56 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has quit [Quit: .]     
15:00 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10698: Be consistent in calling transactions "replaceable" for Opt-In RBF (master...2017-06-replaceable-rpc-args) https://github.com/bitcoin/bitcoin/pull/10698
15:00 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has joined #bitcoin-core-dev     
15:18 -!- Deadhand [~deadhand@CPEf0f249a14e43-CMf0f249a14e40.cpe.net.cable.rogers.com] has quit [Ping timeout: 260 seconds]     
15:20 -!- Dizzle [~dizzle@108.171.182.16] has quit [Quit: Leaving...]     
15:20 -!- Deadhand [~deadhand@2607:fea8:e3a0:84b::3] has joined #bitcoin-core-dev     
15:36 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds]     
15:41 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
15:41 -!- Gabo [~Gabo@104.red-83-55-53.dynamicip.rima-tde.net] has joined #bitcoin-core-dev     
15:44 < cfields> BlueMatt: you beat me to 10697 by a day. would it irritate you if i PR'd an alternative? switches to shared/weak ptrs and drops the manual refcounting.
15:46 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev     
15:47 < BlueMatt> cfields: no, please do!
15:47 -!- Gabo [~Gabo@104.red-83-55-53.dynamicip.rima-tde.net] has quit [Ping timeout: 260 seconds]     
15:47 < BlueMatt> cfields: my only deadline is...uhh...long after 0.15 :p
15:47 < cfields> BlueMatt: ok. I've been trying to work out how to do it safely (stupid threading), but I think I worked out something dead-simple
15:48 < BlueMatt> cool, sounds good
15:48 < cfields> BlueMatt: well, if I don't get it pushed today/tomorrow, I'll go ahead and ACK yours.
15:48 < BlueMatt> not sure what to do with https://github.com/bitcoin/bitcoin/pull/10697/commits/e4f477b6b02b4a6778ba516edfca5b508ef5a90b though
15:48 < BlueMatt> i guess i can pr it loose
15:49 < cfields> can you explain why it's needed?
15:49 < BlueMatt> heh, see code comment :p
15:49 < BlueMatt> our deadlock detection assumes it is the case, and will otherwise give useless results
15:50 < BlueMatt> because we appear to currently never violate that requirement, better to enforce now instead of risking it breaking in the future and ending up with no working deadlock detection (without running ThreadSanitizer
15:50 < BlueMatt> )     
15:50 < cfields> oh, so atm if we have 2 locked, and we invert the unlocks, it just sees that they're both unlocked and doesn't complain?
15:51 < BlueMatt> if we lock A, then lock B, then unlock A, then re-lock A, that may create a deadlock, but will not be detected
15:51 < BlueMatt> cause when we unlocked A, DEBUG_LOCKORDER just assumed that we were unlocking B cause it was the most recent lock
15:52 < cfields> ah, ok
15:52 < BlueMatt> if we ever need it we can tweak DEBUG_LOCKORDER, but we dont now, so easier to just assert correctness in our debug tool and move on
15:53 < sipa> we can easily add a test to verify that an unlock is in fact the last-locked mutex
15:54 < BlueMatt> sipa: yup, thats what I did, just added an assert...its only in debug code anyway
16:04 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 240 seconds]     
16:05 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev     
16:07 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]     
16:11 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 260 seconds]     
16:15 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Read error: Connection reset by peer]     
16:15 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev     
16:16 < gmaxwell> ::sigh:: master isn't compiling for me.
16:16 < gmaxwell> qt/libbitcoinqt.a(qt_libbitcoinqt_a-paymentserver.o): In function `payments::Payment::set_merchant_data(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)':
16:16 < gmaxwell> /home/gmaxwell/bq/src/qt/paymentrequest.pb.h:1600: undefined reference to `google::protobuf::internal::kEmptyString[abi:cxx11]'
16:18 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
16:19 -!- Deadhand [~deadhand@2607:fea8:e3a0:84b::3] has quit [Ping timeout: 246 seconds]     
16:20 -!- PRab [~chatzilla@c-68-56-234-28.hsd1.mi.comcast.net] has joined #bitcoin-core-dev     
16:24 -!- talmai [~T@c-76-24-28-74.hsd1.ma.comcast.net] has quit [Quit: mining]     
16:26 -!- Deadhand [~deadhand@2607:fea8:e3a0:84b::5] has joined #bitcoin-core-dev     
16:27 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []     
16:37 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 277 seconds]     
16:37 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev     
16:38 < bitcoin-git> [bitcoin] sipa opened pull request #10699: Make all script validation flags backward compatible (master...20170628_softflags) https://github.com/bitcoin/bitcoin/pull/10699
16:40 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
16:42 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 268 seconds]     
16:44 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
16:45 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 260 seconds]     
17:13 -!- IRC-Source_13446 [2f9883de@gateway/web/cgi-irc/kiwiirc.com/ip.47.152.131.222] has joined #bitcoin-core-dev     
17:13 -!- IRC-Source_13446 [2f9883de@gateway/web/cgi-irc/kiwiirc.com/ip.47.152.131.222] has quit [Client Quit]     
17:21 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 240 seconds]     
17:32 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds]     
17:35 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
17:36 -!- mol [~IRCIdent@unaffiliated/molly] has joined #bitcoin-core-dev     
18:00 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev     
18:16 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Read error: No route to host]     
18:16 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev     
18:18 < phantomcircuit> gmaxwell, btw master compiles for me
18:31 < phantomcircuit> why did the pull testing stuff get changed?
18:31 < phantomcircuit> oh travis changed
19:04 -!- elkalamar [~elkalamar@84.126.69.179.dyn.user.ono.com] has joined #bitcoin-core-dev     
19:19 -!- mol [~IRCIdent@unaffiliated/molly] has quit [Quit: ZNC 1.6.5 - http://znc.in]     
19:30 -!- goatpig [5a5c653a@gateway/web/freenode/ip.90.92.101.58] has joined #bitcoin-core-dev     
20:11 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]     
20:27 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Ping timeout: 260 seconds]     
20:32 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev     
20:37 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Remote host closed the connection]     
20:38 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev     
20:42 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds]     
21:11 -!- movrcx [~j_ybt@192.161.48.22] has quit [Ping timeout: 246 seconds]     
21:12 -!- fizzwont [~irc3@unaffiliated/fizzwont] has quit [Ping timeout: 240 seconds]     
21:12 -!- j_ybt [~j_ybt@192.161.48.22] has joined #bitcoin-core-dev     
21:13 -!- fizzwont [~irc3@192.169.7.153] has joined #bitcoin-core-dev     
21:14 -!- fizzwont is now known as Guest7920     
21:16 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 255 seconds]     
21:18 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection]     
21:19 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev     
21:20 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection]     
21:21 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev     
21:23 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev     
21:26 -!- Guest7920 [~irc3@192.169.7.153] has quit [Ping timeout: 260 seconds]     
21:27 -!- fizzwont_ [~irc3@192.169.7.153] has joined #bitcoin-core-dev     
21:28 -!- j_ybt [~j_ybt@192.161.48.22] has quit [Ping timeout: 268 seconds]     
21:30 -!- j_ybt [~j_ybt@192.161.48.22] has joined #bitcoin-core-dev     
21:54 -!- Giszmo [~leo@pc-240-13-215-201.cm.vtr.net] has quit [Quit: Leaving.]     
22:00 -!- fizzwont_ is now known as fizzwont     
22:00 -!- fizzwont [~irc3@192.169.7.153] has quit [Changing host]     
22:00 -!- fizzwont [~irc3@unaffiliated/fizzwont] has joined #bitcoin-core-dev     
22:03 -!- ProfMac [43c671dc@gateway/web/freenode/ip.67.198.113.220] has joined #bitcoin-core-dev     
22:10 -!- unholymachine [~quassel@2601:8c:c003:9f16:86d:c55c:99ed:6171] has quit [Ping timeout: 246 seconds]     
23:03 -!- harrymm [~wayne@61-216-34-211.HINET-IP.hinet.net] has quit [Ping timeout: 240 seconds]     
23:25 -!- harrymm [~wayne@60-249-19-76.HINET-IP.hinet.net] has joined #bitcoin-core-dev     
23:40 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #9722: GUI: Display warning when attempting address reuse (master...reuse) https://github.com/bitcoin/bitcoin/pull/9722