--- Day changed Sun Jul 16 2017 00:05 -!- discreteunit [~discreteu@2601:14d:8701:d6a0:8561:dbbb:7e34:dab8] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 00:11 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-kksxufkscwwuenbb] has joined #bitcoin-core-dev 00:13 -!- Squidicuz [~squid@pool-173-48-113-37.bstnma.fios.verizon.net] has joined #bitcoin-core-dev 00:13 -!- Squidicuz [~squid@pool-173-48-113-37.bstnma.fios.verizon.net] has quit [Client Quit] 00:14 -!- Squidicuz [~squid@pool-173-48-113-37.bstnma.fios.verizon.net] has joined #bitcoin-core-dev 01:27 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Ping timeout: 248 seconds] 01:45 -!- RUrsu [~RUrsu@197.211.62.34] has joined #bitcoin-core-dev 01:45 -!- RUrsu [~RUrsu@197.211.62.34] has left #bitcoin-core-dev [] 01:49 -!- mryandao [~mryandao@unaffiliated/mryandao] has joined #bitcoin-core-dev 01:52 -!- blznblzn2 [~blzn@2605:6001:f28d:e600:cf36:4af4:2baf:900a] has quit [Quit: Leaving] 02:09 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Ping timeout: 260 seconds] 02:19 -!- mmgen [~mmgen@178-175-130-19.ip.as43289.net] has joined #bitcoin-core-dev 02:25 -!- jtimon [~quassel@216.100.78.188.dynamic.jazztel.es] has joined #bitcoin-core-dev 02:49 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 248 seconds] 02:50 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 02:51 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 03:06 -!- corebob [~corebob@2a02:fe0:c150:1a00:8958:6277:6ca3:b2cf] has quit [Quit: WeeChat 1.9] 03:22 < bitcoin-git> [bitcoin] practicalswift opened pull request #10842: Fix incorrect Doxygen tag (@ince → @since) (master...doxygen-since) https://github.com/bitcoin/bitcoin/pull/10842 03:43 -!- goatpig [56f75436@gateway/web/freenode/ip.86.247.84.54] has joined #bitcoin-core-dev 03:58 -!- jtimon [~quassel@216.100.78.188.dynamic.jazztel.es] has quit [Ping timeout: 268 seconds] 04:20 -!- arowser [~quassel@45.32.248.113] has quit [Remote host closed the connection] 04:27 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 04:51 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 04:55 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 05:00 -!- marcoagner [~user@187.113.150.230] has quit [Ping timeout: 268 seconds] 05:00 -!- marcoagner [~user@187.113.150.230] has joined #bitcoin-core-dev 05:36 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 06:03 -!- vicenteH [~user@135.234.15.37.dynamic.jazztel.es] has quit [Ping timeout: 260 seconds] 06:04 -!- CubicEarth [~cubiceart@host-69-144-45-132.static.bresnan.net] has joined #bitcoin-core-dev 06:07 < bitcoin-git> [bitcoin] practicalswift opened pull request #10843: Add attribute [[noreturn]] (C++11) to functions that will not return (master...noreturn) https://github.com/bitcoin/bitcoin/pull/10843 06:09 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 06:10 -!- marcoagner [~user@187.113.150.230] has quit [Ping timeout: 255 seconds] 06:20 -!- hsmiths [uid95325@gateway/web/irccloud.com/x-bujtoinstpmfstcc] has quit [Quit: Connection closed for inactivity] 06:23 -!- marcoagner [~user@191.249.243.186] has joined #bitcoin-core-dev 06:28 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 255 seconds] 06:30 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 06:31 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 06:32 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 06:39 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 06:40 -!- CubicEarth [~cubiceart@host-69-144-45-132.static.bresnan.net] has quit [Remote host closed the connection] 06:40 -!- CubicEarth [~cubiceart@host-69-144-45-132.static.bresnan.net] has joined #bitcoin-core-dev 06:42 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:45 -!- CubicEarth [~cubiceart@host-69-144-45-132.static.bresnan.net] has quit [Ping timeout: 260 seconds] 06:48 -!- terjegun [804d4621@gateway/web/freenode/ip.128.77.70.33] has joined #bitcoin-core-dev 06:48 < terjegun> Hello! I was wondering, is there any reward for contributing translations to the project? 06:50 < Lauda> No. 06:50 < instagibbs> terjegun, satisfaction in knowing you helped others? 06:53 -!- terjegun [804d4621@gateway/web/freenode/ip.128.77.70.33] has quit [Client Quit] 06:55 < bitcoin-git> [bitcoin] ReneNyffenegger opened pull request #10844: Use range based for loop (master...dbwrapper_tests-for) https://github.com/bitcoin/bitcoin/pull/10844 06:58 -!- CubicEarth [~cubiceart@206.54.118.113] has joined #bitcoin-core-dev 06:59 -!- CubicEarth [~cubiceart@206.54.118.113] has quit [Remote host closed the connection] 07:02 -!- CubicEarth [~cubiceart@206.54.118.113] has joined #bitcoin-core-dev 07:08 -!- vicenteH [~user@13.232.15.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 07:08 -!- hsmiths [uid95325@gateway/web/irccloud.com/x-guyckrjeqctypsff] has joined #bitcoin-core-dev 07:19 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 255 seconds] 07:21 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 07:23 -!- CubicEarth [~cubiceart@206.54.118.113] has quit [Remote host closed the connection] 08:17 -!- harrymm [~wayne@60-249-12-114.HINET-IP.hinet.net] has quit [Ping timeout: 260 seconds] 08:34 -!- fanquake [~fanquake@unaffiliated/fanquake] has left #bitcoin-core-dev [] 08:37 -!- harrymm [~wayne@61.216.166.212] has joined #bitcoin-core-dev 08:38 -!- [b__b] [~b__b]@ec2-54-85-45-223.compute-1.amazonaws.com] has quit [Ping timeout: 268 seconds] 09:18 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 255 seconds] 09:24 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer] 09:25 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 09:32 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 09:47 -!- sdaftuar [~sdaftuar@unaffiliated/sdaftuar] has quit [Ping timeout: 276 seconds] 09:47 -!- zxzzt [~prod@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Ping timeout: 276 seconds] 09:47 -!- morcos [~morcos@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Ping timeout: 255 seconds] 09:49 -!- zxzzt [~prod@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 09:49 -!- sdaftuar [~sdaftuar@unaffiliated/sdaftuar] has joined #bitcoin-core-dev 09:49 -!- morcos [~morcos@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 09:49 < bitcoin-git> [bitcoin] TheBlueMatt closed pull request #10838: (finally) remove the longest-ever-deprecated RPC call getinfo (master...2017-07-seriously-fuck-getinfo) https://github.com/bitcoin/bitcoin/pull/10838 10:10 -!- mmgen [~mmgen@178-175-130-19.ip.as43289.net] has quit [Ping timeout: 246 seconds] 10:16 -!- deep-book-gk_ [~1wm_su@194.242.11.14] has joined #bitcoin-core-dev 10:18 -!- deep-book-gk_ [~1wm_su@194.242.11.14] has left #bitcoin-core-dev [] 10:20 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:21 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds] 10:27 -!- Cheeseo [~Cheeseo@unaffiliated/cheeseo] has joined #bitcoin-core-dev 10:30 -!- RoyceX [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 10:33 -!- Cheeseo [~Cheeseo@unaffiliated/cheeseo] has quit [Ping timeout: 240 seconds] 10:37 -!- [b__b] [~b__b]@ec2-54-85-45-223.compute-1.amazonaws.com] has joined #bitcoin-core-dev 10:37 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 10:38 -!- mmgen [~mmgen@178-175-130-19.ip.as43289.net] has joined #bitcoin-core-dev 10:39 -!- AdrianG is now known as Aleph0 10:40 -!- harrymm [~wayne@61.216.166.212] has quit [Ping timeout: 240 seconds] 10:44 < bitcoin-git> [bitcoin] practicalswift opened pull request #10845: Remove unreachable code (master...remove-unreachable-code) https://github.com/bitcoin/bitcoin/pull/10845 10:50 -!- mmgen [~mmgen@178-175-130-19.ip.as43289.net] has quit [Ping timeout: 260 seconds] 10:54 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 255 seconds] 10:59 -!- harrymm [~wayne@125-227-70-105.HINET-IP.hinet.net] has joined #bitcoin-core-dev 11:03 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10846: Add stdlib include in qt/test/test_main (for setenv) (master...2017-07-env-include) https://github.com/bitcoin/bitcoin/pull/10846 11:04 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer] 11:05 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 11:21 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 11:24 < bitcoin-git> [bitcoin] TheBlueMatt closed pull request #10846: Add stdlib include in qt/test/test_main (for setenv) (master...2017-07-env-include) https://github.com/bitcoin/bitcoin/pull/10846 11:32 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 11:36 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.] 11:48 -!- bincap [~vd@85-222-72-154.dynamic.chello.pl] has joined #bitcoin-core-dev 11:51 < bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/5cfdda2503c9...ef37f2033c4a 11:51 < bitcoin-git> bitcoin/master a9e82f6 Pieter Wuille: Use cpuid intrinsics instead of asm code 11:51 < bitcoin-git> bitcoin/master 674848f Pieter Wuille: Clarify entropy source 11:51 < bitcoin-git> bitcoin/master ef37f20 Pieter Wuille: Merge #10820: Use cpuid intrinsics instead of asm code... 11:51 < bitcoin-git> [bitcoin] sipa closed pull request #10820: Use cpuid intrinsics instead of asm code (master...20170717_cpuid) https://github.com/bitcoin/bitcoin/pull/10820 11:52 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 11:56 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ef37f2033c4a...b4d03be3cac0 11:56 < bitcoin-git> bitcoin/master 912da1d René Nyffenegger: Use AC_ARG_VAR to set ARFLAGS.... 11:56 < bitcoin-git> bitcoin/master b4d03be Pieter Wuille: Merge #10766: Building Environment: Set ARFLAGS to cr... 11:57 < bitcoin-git> [bitcoin] sipa closed pull request #10766: Building Environment: Set ARFLAGS to cr (master...ARFLAGS) https://github.com/bitcoin/bitcoin/pull/10766 12:00 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b4d03be3cac0...99c7db8731cc 12:00 < bitcoin-git> bitcoin/master c53369c practicalswift: Remove duplicate include 12:00 < bitcoin-git> bitcoin/master 99c7db8 Pieter Wuille: Merge #10840: Remove duplicate include... 12:01 < bitcoin-git> [bitcoin] sipa closed pull request #10840: Remove duplicate include (master...remove-duplicate-include) https://github.com/bitcoin/bitcoin/pull/10840 12:03 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/99c7db8731cc...ad6fce67b9bb 12:03 < bitcoin-git> bitcoin/master d0413c6 René Nyffenegger: Use range based for loop... 12:03 < bitcoin-git> bitcoin/master ad6fce6 Pieter Wuille: Merge #10844: Use range based for loop... 12:04 < bitcoin-git> [bitcoin] sipa closed pull request #10844: Use range based for loop (master...dbwrapper_tests-for) https://github.com/bitcoin/bitcoin/pull/10844 12:06 -!- mmgen [~mmgen@178-175-130-19.ip.as43289.net] has joined #bitcoin-core-dev 12:11 -!- JackH [~laptop@178.197.231.176] has joined #bitcoin-core-dev 12:13 -!- arowser [~quassel@45.32.248.113] has quit [Remote host closed the connection] 12:15 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ad6fce67b9bb...565494619d80 12:15 < bitcoin-git> bitcoin/master 6835cb0 practicalswift: Avoid static analyzer warnings regarding uninitialized arguments... 12:15 < bitcoin-git> bitcoin/master 5654946 Pieter Wuille: Merge #10735: Avoid static analyzer warnings regarding uninitialized arguments... 12:16 < bitcoin-git> [bitcoin] sipa closed pull request #10735: Avoid static analyzer warnings regarding uninitialized arguments (master...std-array) https://github.com/bitcoin/bitcoin/pull/10735 12:19 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 12:28 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 260 seconds] 12:29 < sipa> do we know about this: https://bitcoin.stackexchange.com/questions/56750/autogen-sh-not-working-on-ubuntu-on-windows ? 12:30 < BlueMatt> that seems to indicate it doesnt support "seg -e"??? 12:31 < BlueMatt> that sounds like an ubuntu-on-windows issue 12:31 < sipa> I vaguely remember that there were known issues when building on Ubuntu-in-Windows, but I don't remember whether it was this. 12:32 < BlueMatt> not this, no 12:32 < BlueMatt> well, afair 12:35 -!- arowser [~quassel@45.32.248.113] has quit [Remote host closed the connection] 12:39 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev 12:41 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 12:47 -!- sam_c [~sam_c@unaffiliated/cmpct] has joined #bitcoin-core-dev 12:48 < cfields> IIRC the last round of problems was caused by an update that borked the default path 12:51 < sipa> cfields: what is the option to make gcc emit every function in its own section? 12:51 < cfields> sipa: ffunction-section 12:51 < cfields> er, there's another s in there somewhere though 12:52 < cfields> -ffunction-sections 12:52 < sipa> do we enable -Wl,--gc-sections by default? 12:52 < cfields> sipa: and you want to link with -gc-sections 12:52 < cfields> no 12:54 < sipa> any reason not to? 12:56 < cfields> sipa: i think default-hidden-visibility accomplishes the same thing without the section bloat? 12:59 < sipa> cfields: is that always set for us? 13:00 -!- arowser [~quassel@45.32.248.113] has quit [Remote host closed the connection] 13:01 < sipa> cfields: a build with CFLAGS/CXXFLAGS/LDFLAGS all set to "-O2 -g0", results in a 6MB stripped bitcoind 13:02 < sipa> cfields: a build with CFLAGS/CXXFLAGS/LDFLAGS all set to "-O2 -g0 -ffunction-sections -fdata-sections -Wl,--gc-sections", results in a 5.4MB stripped bitcoind 13:03 < cfields> sipa: it's not set auto, --enable-reduced-exports 13:03 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Remote host closed the connection] 13:03 < cfields> mind comparing with that? 13:03 < gmaxwell> why don't we do that by default 13:03 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 13:04 < cfields> gmaxwell: there's a visibility issue with some boost versions 13:04 < gmaxwell> ah 13:04 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Remote host closed the connection] 13:04 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 13:05 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Remote host closed the connection] 13:05 < sipa> cfields: that option makes no difference; 6.0MB again 13:05 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 13:05 < cfields> huh 13:06 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Remote host closed the connection] 13:06 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 13:06 < sipa> make clean && ./configure --with-incompatible-bdb --without-gui --enable-reduced-exports && make -j9 src/bitcoind && strip src/bitcoind && wc -c src/bitcoind 13:06 < sipa> 6008256 src/bitcoind 13:06 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Remote host closed the connection] 13:06 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 13:07 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 13:07 < cfields> sipa: sounds promising then, though I'm kinda confused as to why 13:07 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Remote host closed the connection] 13:07 < sipa> make clean && COMMON="-O2" && ./configure --with-incompatible-bdb --without-gui CFLAGS="$COMMON" CXXFLAGS="$COMMON" LDFLAGS="$COMMON" && make -j9 src/bitcoind && strip src/bitcoind && wc -c src/bitcoind 13:07 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 13:08 < sipa> 6008256 src/bitcoind 13:08 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Remote host closed the connection] 13:08 < sipa> ^ exactly the same 13:08 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 13:08 < sipa> make clean && COMMON="-O2 -ffunction-sections -fdata-sections -Wl,--gc-sections" && ./configure --with-incompatible-bdb --without-gui CFLAGS="$COMMON" CXXFLAGS="$COMMON" LDFLAGS="$COMMON" && make -j9 src/bitcoind && strip src/bitcoind && wc -c src/bitcoind 13:08 < sipa> 5397952 src/bitcoind 13:09 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Remote host closed the connection] 13:09 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 13:10 < cfields> sipa: i wonder if there are any downsides wrt locality? 13:10 < sipa> cfields: i can run a reindex benchmark 13:12 -!- arowser [~quassel@45.32.248.113] has quit [Ping timeout: 240 seconds] 13:14 < sipa> cfields: should --enable-reduced-exports affect the CXXFLAGS/LDFLAGS that get printed in any way? 13:14 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds] 13:14 < cfields> sipa: sigh, probably not 13:15 < cfields> that needs to be cleaned up. There's lots of stuff not reported 13:16 < gmaxwell> sipa: you mean when doing a V=1 build so you can see the arguments it actually uses 13:16 < cfields> sipa: aurgh! 13:17 < cfields> wait, hmm 13:18 < cfields> sipa: sorry, i lied to you :( 13:18 < cfields> --enable-reduce-exports 13:18 < sipa> shouldn't it complain if i make a typo? 13:19 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 13:19 < cfields> sipa: it used to, but we can't anymore because config options get forwarded to subconfigs 13:19 < sipa> heh, i always wondered how it dealt with that... 13:21 < sipa> -rwxr-xr-x 1 pw pw 6008256 Jul 16 13:15 src/bitcoind-shasse-O2 13:21 < sipa> -rwxr-xr-x 1 pw pw 5979584 Jul 16 13:21 src/bitcoind-shasse-O2reduce 13:21 < sipa> -rwxr-xr-x 1 pw pw 5397952 Jul 16 13:19 src/bitcoind-shasse-O2sections 13:22 < sipa> the middle one is with CXXFLAGS="-O2" --enable-reduce-exports 13:23 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 13:26 < sipa> benchmarking those 3 13:26 < cfields> sipa: may as well try with -fdata-sections too 13:27 < sipa> cfields: yeah, that's with both 13:27 < gmaxwell> sipa: why would you expect a performance difference? 13:27 < cfields> ah ok 13:30 < sipa> gmaxwell: cfields asked if there could be a locality impact 13:50 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/565494619d80...1fc783fc08bc 13:50 < bitcoin-git> bitcoin/master 5618b7d Pavel Janík: Do not shadow upper local variable `state`. 13:50 < bitcoin-git> bitcoin/master 1fc783f MarcoFalke: Merge #10739: test: Move variable `state` down where it is used... 13:50 -!- promag [~joao@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 13:50 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #10739: test: Move variable `state` down where it is used (master...20170704_Wshadow_txvalidationcache_tests) https://github.com/bitcoin/bitcoin/pull/10739 13:51 -!- mmgen [~mmgen@178-175-130-19.ip.as43289.net] has quit [Quit: leaving] 13:53 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Remote host closed the connection] 13:53 -!- sam_c [~sam_c@unaffiliated/cmpct] has quit [Quit: ZNC - http://znc.in] 13:55 < cfields> sipa: if we're using ffunction-sections, we can use -Wl,--icf=safe too 13:56 -!- sam_c [~sam_c@unaffiliated/cmpct] has joined #bitcoin-core-dev 13:56 < cfields> shaves off another ~70k for me 13:56 < sipa> cfields: i don't see that in man ld 13:56 < cfields> sipa: man ld.gold 13:57 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 13:57 < sipa> ah 14:00 -!- arowser [~quassel@45.32.248.113] has quit [Remote host closed the connection] 14:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 14:05 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 14:06 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 14:14 -!- arowser [~quassel@45.32.248.113] has quit [Ping timeout: 240 seconds] 14:19 < bincap> given two gitian.signs asserts (from two people) is there a quick command to compare if their out_manifest is identical? 14:20 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 14:23 < bitcoin-git> [bitcoin] practicalswift opened pull request #10847: Enable devirtualization opportunities by using the final specifier (C++11) (master...devirtualization) https://github.com/bitcoin/bitcoin/pull/10847 14:24 -!- Squidicc [~squid@pool-173-48-113-37.bstnma.fios.verizon.net] has joined #bitcoin-core-dev 14:24 -!- Squidicc [~squid@pool-173-48-113-37.bstnma.fios.verizon.net] has quit [Client Quit] 14:25 -!- arowser [~quassel@45.32.248.113] has quit [Remote host closed the connection] 14:38 -!- QBcrusher [~QBcrusher@cpe-71-72-246-231.insight.res.rr.com] has joined #bitcoin-core-dev 14:39 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 14:40 -!- arowser [~quassel@45.32.248.113] has quit [Remote host closed the connection] 14:44 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1fc783fc08bc...3895e25a7736 14:44 < bitcoin-git> bitcoin/master 2c2e90d practicalswift: Fix incorrect Doxygen tag (@ince → @since). Make Doxygen parameter names match actual parameter names. 14:44 < bitcoin-git> bitcoin/master 3895e25 MarcoFalke: Merge #10842: Fix incorrect Doxygen tag (@ince → @since). Doxygen parameter name matching.... 14:45 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #10842: Fix incorrect Doxygen tag (@ince → @since). Doxygen parameter name matching. (master...doxygen-since) https://github.com/bitcoin/bitcoin/pull/10842 14:46 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 14:59 -!- arowser [~quassel@45.32.248.113] has quit [Remote host closed the connection] 15:01 < Chris_Stewart_5> In the test framework, using node.generate() will propogate the block to another peer right? 15:01 < sipa> it'll propagate to whatever other peer it is connected to 15:01 < sipa> who will do the same 15:02 < Chris_Stewart_5> Do I need to use some sort of sleep mechanism if I need it to propogate before runnign the next line? 15:02 < sipa> no, you need to use wait_for_block 15:02 < sipa> or something similar 15:02 < Chris_Stewart_5> oh, cool. I'll check that out. Thanks. 15:05 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 15:05 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer] 15:06 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 15:08 -!- promag [~joao@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 260 seconds] 15:11 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 15:14 -!- rubensayshi [sid201751@gateway/web/irccloud.com/x-sfzlexmbjqshqnpr] has quit [Remote host closed the connection] 15:16 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds] 15:21 -!- marcoagner [~user@191.249.243.186] has quit [Ping timeout: 240 seconds] 15:22 -!- wallet42 [sid154231@gateway/web/irccloud.com/x-fsocvcvdygedcazt] has joined #bitcoin-core-dev 15:26 -!- marcoagner [~user@191.249.243.186] has joined #bitcoin-core-dev 15:26 -!- robby938 [sid238281@gateway/web/irccloud.com/x-gnglqcrlfgxakpuc] has joined #bitcoin-core-dev 15:30 -!- coredump_ [~quassel@vpn-qld171.vpnsolutions.com.au] has joined #bitcoin-core-dev 15:31 -!- rubensayshi [sid201751@gateway/web/irccloud.com/x-edlmatijwpoxozzo] has joined #bitcoin-core-dev 15:33 < BlueMatt> cfields: gonna update 10809? 15:35 < sipa> BlueMatt: care to investigate #10758? 15:35 < gribble> https://github.com/bitcoin/bitcoin/issues/10758 | Fix some chainstate-init-order bugs. by TheBlueMatt · Pull Request #10758 · bitcoin/bitcoin · GitHub 15:35 < sipa> (it seems to forget progress when continuing a reindex) 15:36 < BlueMatt> oh, yes, thats next on my list 15:36 < sipa> actually, i may be an idiot there 15:37 < BlueMatt> hmm, did that not used to happen? I have no idea 15:38 < sipa> it is supposed to start over from scratch, but go faster through the parts it has already done 15:39 < sipa> i guess the thing to make sure is that it does not wipe the block index when contonuing a reindex 15:40 -!- arowser [~quassel@45.32.248.113] has quit [Ping timeout: 240 seconds] 15:41 < BlueMatt> it shouldnt, though 15:41 < BlueMatt> hmm 15:41 < BlueMatt> (thats the section where you commented on the comment you found confusing 15:41 < BlueMatt> (it says explicitly that we dont want to clear the db even if we're setting fReindex unless its a new reindex...) 15:42 < sipa> well i failed to understand what it was trying to say :) 15:43 < BlueMatt> sipa: try now? 15:43 < BlueMatt> (comment, that is) 15:43 < BlueMatt> didnt change the code 15:43 < sipa> ok, will have a look soon 15:43 < BlueMatt> so, wait, do you think there is a bug that i should go hunt or do you think you mis-read? 15:45 < sipa> i thought there was a bug, but i'm less sure now 15:45 < sipa> i'll verify 15:46 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 15:48 -!- marcoagner [~user@191.249.243.186] has quit [Ping timeout: 260 seconds] 15:51 -!- marcoagner [~user@191.249.243.186] has joined #bitcoin-core-dev 15:53 < BlueMatt> hmmm...this client-side getinfo thing scares me 15:54 < BlueMatt> our rpcs are always atomic elements, but if you start calling getinfo, then getwalletinfo, then getmininginfo separately, they could return results based on different views of the current chain 15:54 < BlueMatt> which would be astoundingly confusing for users 15:54 < sipa> i'm totally fine with deprecating and then deleting 15:55 < BlueMatt> well I'm curious what the previously-mentioned "IRC discussion" was that resulted in the pr getting reopened 15:55 < BlueMatt> i dont want to show up late to the party and shit on it and say it shouldnt happen, but I'm really uneasy about the idea 15:58 < BlueMatt> sipa: do you want the asm sha in for 15? 15:58 < BlueMatt> should i bother reviewing it? 15:58 < BlueMatt> (yet) 15:58 < sipa> BlueMatt: i think it's a great and easy performance win, and i think it's ready 15:59 < sipa> whether we want it in 0.15 depends on reviewer interest 16:00 < BlueMatt> k 16:00 < BlueMatt> i'll try to get to it 16:01 < sipa> awesome 16:01 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 16:01 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 16:01 < cfields> BlueMatt: yea, will do in a bit. I'm frantically trying to bump qt atm. 16:02 < cfields> +1 for sha asm in 0.15 16:07 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 16:09 < cfields> sipa: any theories as to what slows down the lto build? 16:10 -!- ula [~kvirc@b2b-78-94-11-194.unitymedia.biz] has joined #bitcoin-core-dev 16:11 < sipa> cfields: over-eager inlining across objects? 16:13 -!- RoyceX [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Ping timeout: 268 seconds] 16:14 < cfields> makes sense 16:14 < gmaxwell> sipa: wumpus had a comment about where the detection was being triggered for the asm. 16:14 < cfields> i could see how it might make a mess of our serialization 16:14 < sipa> gmaxwell: i've long since addressed that and commented about it 16:14 < gmaxwell> I only haven't acked it because I didn't think the patch was in its final state yet... I've tried it on a few hosts, works as expected. 16:14 < gmaxwell> sipa: oh 16:15 < gmaxwell> oh I see there are more commits now 16:15 < sipa> gmaxwell: where 'long' means 15 hours ago 16:16 < sipa> it also prints which implementation is being used 16:17 < sipa> the only unaddressed comment is BlueMatt's concern about printing copyright information for binary-only distributions 16:17 < BlueMatt> we do it for openssl for qt - we have it in the about dialog or smth iirc 16:18 < gmaxwell> I don't believe matt is correct in any case; we don't have a "binary only distribution" -- sure you don't have to download the source, but thats up to you. 16:18 < sipa> easy enough to add something there, if needed 16:18 < gmaxwell> BlueMatt: openssl is 4-clause BSD 16:20 < cfields> \o/ a self-test 16:20 < sipa> cfields: actually, you should test whether reintroducing the foldgers crystals bug in the sse asm causes it to select the basic sha256 implementation at run time 16:20 < sipa> it should 16:22 < gmaxwell> sipa: I was thinking of suggesting logging that failure, when cpu id and selftest disagree... 16:22 < cfields> sipa: hmm, i wonder if we should still fail in that case though, and require a --software-sha256 flag or something 16:22 < sipa> gmaxwell: the crypto code doesn't have access to logging 16:22 < cfields> if that's happening in the wild, we really want to know about it 16:23 < sipa> we could assert in case the selftest doesn't go as expected 16:23 < sipa> i agree that this may hide bugs 16:23 < sipa> though in a pretty safe way... i don't think it's easy to screw up SHA256 in a way that wouldn't be detectable with a single test 16:24 < gmaxwell> sipa: one thing the selftest doesn't extensively test is sensitivity to alignent. 16:24 < sipa> ok, i can fix that 16:24 < sipa> i can also extend it to test 0 and/or 2 blocks rather than just a single block 16:25 < BlueMatt> gmaxwell: hmm? bitcoin.org/bin has binary distributions 16:25 < BlueMatt> we ship binary-only stuff, at least on windows 16:25 < BlueMatt> iirc 16:26 < sipa> BlueMatt: i think gmaxwell's point is that the source code is still available for those 16:26 < sipa> i have no idea whether that matters, IANAL 16:27 < BlueMatt> ah, ok 16:27 < BlueMatt> wellt hen I dont care 16:27 < BlueMatt> as long as his point isnt "we dont ship binary-only" and is instead "but source is freely available", then he would know :) 16:27 < gmaxwell> BlueMatt: if it meant what you thought, it wouldn't be GPL compatible. You're interperting the license in the same way that 4-clause bsd is written. 16:28 < BlueMatt> k :) 16:28 < gmaxwell> BlueMatt: my point was we always make the source available. 16:28 -!- promag [~joao@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 16:29 -!- arowser [~quassel@45.32.248.113] has quit [Remote host closed the connection] 16:30 < bitcoin-git> [bitcoin] TheBlueMatt reopened pull request #10838: (finally) remove the longest-ever-deprecated RPC call getinfo (master...2017-07-seriously-fuck-getinfo) https://github.com/bitcoin/bitcoin/pull/10838 16:30 < BlueMatt> gmaxwell: we dont always *ship* the source along with the binary 16:30 < BlueMatt> was my point 16:30 < BlueMatt> as long as I'm misreading the liscense, I withdraw my concern :) 16:31 < BlueMatt> we just make it available 16:36 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 16:53 < gmaxwell> sipa: not something to fix now, but I see that the multiblock code doesn't really make a heroic effort to transform multiple blocks at a time. This may disavantage the avx2-rorx code, which really wants 2 blocks at a time (as it vector processes the initial expander in both blocks) 16:54 < sipa> gmaxwell: that's not too hard to fix 16:55 < gmaxwell> ya, I know. e.g. change the buffering to buffer two blocks. 16:55 < sipa> yeah 16:56 < gmaxwell> similar, the 8m rorx code is setup for 8 blocks. 16:59 -!- arowser [~quassel@45.32.248.113] has quit [Remote host closed the connection] 17:10 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 17:10 -!- rhavar [uid237883@gateway/web/irccloud.com/x-nfkyduyxalzivvne] has joined #bitcoin-core-dev 17:10 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Client Quit] 17:12 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 17:13 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 17:15 < sipa> gmaxwell: we likely want that to be dynamic, based on the chosen implementation 17:16 < gmaxwell> I don't think always buffering two would hurt, other than a slight latency hit. 17:17 < gmaxwell> 8 would be kinda nuts 17:17 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Ping timeout: 248 seconds] 17:17 < sipa> well, we can benchmark 17:19 < gmaxwell> I could be wrong about it mattering at all too. Though I don't think so. 17:23 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 17:25 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 17:32 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 260 seconds] 17:35 -!- arowser [~quassel@45.32.248.113] has quit [Remote host closed the connection] 17:38 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 17:40 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Client Quit] 17:42 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 17:56 -!- arowser [~quassel@45.32.248.113] has quit [Remote host closed the connection] 17:58 -!- goatpig [56f75436@gateway/web/freenode/ip.86.247.84.54] has quit [Quit: Page closed] 18:00 < sipa> hmm, i wonder why i think that sse 4.2 is needed for that asm code 18:00 < sipa> it seems to only use sse 4.1 instructions 18:00 < sipa> crc32 needs sse 4.2 18:06 -!- promag [~joao@bl22-247-244.dsl.telepac.pt] has quit [Quit: Leaving.] 18:18 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 18:21 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 18:25 -!- discreteunit [~discreteu@2601:14d:8701:d6a0:8c57:7afc:e59e:bffe] has joined #bitcoin-core-dev 18:28 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 248 seconds] 18:31 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 18:34 -!- discreteunit [~discreteu@2601:14d:8701:d6a0:8c57:7afc:e59e:bffe] has quit [Quit: Textual IRC Client: www.textualapp.com] 18:42 -!- arowser [~quassel@45.32.248.113] has quit [Remote host closed the connection] 18:49 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-kksxufkscwwuenbb] has quit [Quit: Connection closed for inactivity] 18:51 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 19:05 -!- arowser [~quassel@45.32.248.113] has quit [Remote host closed the connection] 19:11 -!- arowser [~quassel@45.32.248.113] has joined #bitcoin-core-dev 19:14 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 19:18 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Ping timeout: 268 seconds] 19:26 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/3895e25a7736...bf0a08be281d 19:26 < bitcoin-git> bitcoin/master ff7365e John Newbery: [tests] fix flake8 warnings in zapwallettxes.py 19:26 < bitcoin-git> bitcoin/master e7a2181 John Newbery: [wallet] fix zapwallettxes interaction with persistent mempool... 19:26 < bitcoin-git> bitcoin/master 4c3b538 John Newbery: [logs] fix zapwallettxes startup logs 19:26 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 19:26 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #10330: [wallet] fix zapwallettxes interaction with persistent mempool (master...zapwallettxes) https://github.com/bitcoin/bitcoin/pull/10330 19:27 -!- rhavar [uid237883@gateway/web/irccloud.com/x-nfkyduyxalzivvne] has quit [Quit: Connection closed for inactivity] 19:34 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 260 seconds] 19:40 -!- handlex [~handlex@189.6.32.254] has joined #bitcoin-core-dev 19:40 -!- twistedline [~quassel@unaffiliated/twistedline] has quit [Ping timeout: 246 seconds] 19:40 -!- twistedline_ [~quassel@unaffiliated/twistedline] has joined #bitcoin-core-dev 19:44 -!- twistedline_ [~quassel@unaffiliated/twistedline] has quit [Ping timeout: 240 seconds] 19:44 -!- twistedline [~quassel@unaffiliated/twistedline] has joined #bitcoin-core-dev 19:48 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 19:48 -!- twistedline [~quassel@unaffiliated/twistedline] has quit [Ping timeout: 246 seconds] 19:52 -!- twistedline [~quassel@unaffiliated/twistedline] has joined #bitcoin-core-dev 20:08 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 20:08 -!- handlex [~handlex@189.6.32.254] has quit [Quit: handlex] 20:11 -!- handlex [~handlex@2804:14c:658f:4ac1:e4bd:b2ce:3e7c:b00c] has joined #bitcoin-core-dev 20:17 -!- Giszmo [~leo@pc-249-180-45-190.cm.vtr.net] has quit [Ping timeout: 260 seconds] 20:32 -!- Giszmo [~leo@pc-249-180-45-190.cm.vtr.net] has joined #bitcoin-core-dev 20:40 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 260 seconds] 20:55 -!- handlex [~handlex@2804:14c:658f:4ac1:e4bd:b2ce:3e7c:b00c] has quit [Quit: handlex] 21:18 < bitcoin-git> [bitcoin] jnewbery closed pull request #10802: [tests] skip zapwallettxes.py (master...skip_zapwallettxes) https://github.com/bitcoin/bitcoin/pull/10802 21:25 < gmaxwell> sipa: you broke the sse4 thing by renaming incompletely. fixy fixy. 21:37 < sipa> gmaxwell: fixed 21:42 < cfields> jeez, qt 5.9 made a mess of _everything_ 21:44 < gmaxwell> What did they do 21:46 < cfields> they're working on modularizing their source/build. but the result (so far) is just a new tangled mess of dependencies. And no working configs without patches 21:46 -!- JackH [~laptop@178.197.231.176] has quit [Ping timeout: 240 seconds] 21:47 < cfields> want cocoa for osx? you'll need a printer of course. And obviously printers require opengl... 21:47 < luke-jr> O.o 21:47 < sipa> any reason why we'd really want 5.9? 21:48 < sipa> cfields: they're 3D printers perhaps? :D 21:48 < cfields> sipa: lol 21:49 < cfields> sipa: ironically i was looking forward to 5.9 and its slimmer build 21:49 < gmaxwell> they probably need opengl for 'lpad()'... 21:50 < sipa> or for is_integer 21:50 < cfields> but after messing with it all day, it's not offering many advantages so far 21:51 -!- Giszmo [~leo@pc-249-180-45-190.cm.vtr.net] has quit [Ping timeout: 260 seconds] 21:51 < cfields> (other than providing me a stack of patches to upstream) 21:52 < cfields> so no, i don't think it makes sense to bump 21:52 < cfields> as-is, we don't build with 5.9. But I haven't seen a bug report yet, so I'm assuming distros aren't shipping it 21:52 < cfields> (and it'll be a pain to support once they do :( ) 21:53 < luke-jr> Qt used to care about backward compat :/ 21:54 < luke-jr> I noticed some stuff I have won't build with 5.7 because it requires C++11 >_< 21:54 < cfields> luke-jr: i suspect all is fine if you use qmake 21:54 < luke-jr> ah 21:54 < cfields> yea, c++11 became a hard dep for 5.7 i believe 21:54 < luke-jr> well, FWIW, Gentoo doesn't have 5.8 as even an option yet 21:54 < cfields> but stl is still optional i think :p 21:54 < luke-jr> hard dep makes sense; but 5.7 won't allow Qt programs to use non-C++11 :p 21:55 < sipa> gcc 6 by default already compiles with c++14 21:55 < luke-jr> anyhow, so I changed my USE flags to build that app for Qt4 <.< 21:55 < cfields> mm, that's annoying. but kinda makes sense from a support standpoint 22:05 -!- Giszmo [~leo@pc-249-180-45-190.cm.vtr.net] has joined #bitcoin-core-dev 22:05 -!- QBcrusher_ [~QBcrusher@cpe-71-72-246-231.insight.res.rr.com] has joined #bitcoin-core-dev 22:07 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.] 22:08 -!- QBcrusher [~QBcrusher@cpe-71-72-246-231.insight.res.rr.com] has quit [Ping timeout: 248 seconds] 22:23 -!- CubicEarth [~cubiceart@host-69-144-45-132.static.bresnan.net] has joined #bitcoin-core-dev 22:28 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Ping timeout: 255 seconds] 22:58 < wumpus> any reason to not just stick with our current qt for 0.15? that sounds like a nightmare, better let them sort out their problems upstream and not be a guinea pig 22:59 < wumpus> from a user PoV there seems to be no difference between different qt version for a long time now, as we basically only use the 4.x API 23:06 < luke-jr> they don't even have a Qt5.9 dance, so.. 23:06 < wumpus> hehe 23:12 < wumpus> disabling -getinfo on the day of the feature freeze, really? 23:13 < luke-jr> meh, why not. there's an option to get it back 23:13 < wumpus> I don't get it, what is the sudden rush? 23:14 < wumpus> sure, but we could have done that 100 times during 0.15's release cycle 23:14 < wumpus> but somehow it has to be added in the last day 23:14 < gmaxwell> leeroy jenkins! 23:14 < luke-jr> I suppose it adds a new string 23:14 < luke-jr> (for the -help) 23:15 < gmaxwell> I think it should be done at the beginning of a cycle. It's bound to cause severe irritation for people who use it at the CLI and we will predictably get PRs to improve other things to compensate. 23:15 < wumpus> gmaxwell: heh indeed, in this way we don't even get used to it ourself 23:15 < wumpus> before exposing it to end users 23:15 -!- CubicEarth [~cubiceart@host-69-144-45-132.static.bresnan.net] has quit [Remote host closed the connection] 23:16 < wumpus> can't we just add a comment to the getinfo output instead? 23:16 < wumpus> Warning: this will be deprecated! 23:16 < gmaxwell> (or perhaps I'm alone in continuing to use getinfo myself? :) ) 23:16 < wumpus> instead of the add a command line argument dance 23:16 < gmaxwell> "nag": "This RPC will be deprecated." 23:17 < wumpus> gmaxwell: I officially stopped using it at least, replaced it with a client-side script that shows more useful information 23:17 < luke-jr> wumpus: +1, maybe even put it in the warnings software already should look at? 23:18 < wumpus> getinfo's output is pretty meh, do you ever lok at anything besides the number of connections or the wallet balance? 23:18 < wumpus> luke-jr: not sure that's a good idea 23:18 < wumpus> luke-jr: it's not part of the node-wide warnings 23:19 < luke-jr> not sure why that'd be a reason not to do it 23:19 < wumpus> because it's a false alarm 23:19 < wumpus> it's not actually an alarm 23:20 < luke-jr> "your software is about to break" isn't? ;) 23:20 < gmaxwell> Connections, block count, balance, warings. And unfortunately, to use seperate rpcs to get this info is three rpcs (four?) and most of them each give a full screen full of information each. :) 23:20 < luke-jr> getblockcount and getbalance are scalars 23:21 < sipa> is there any rpc besides getinfo that actually lists the warning? 23:21 < wumpus> what the hell 23:21 < wumpus> BlueMatt concerned about atomicity in #8843?! 23:21 < gmaxwell> true, though I was using getblockchaininfo and getwalletinfo as replacements. 23:21 < gribble> https://github.com/bitcoin/bitcoin/issues/8843 | rpc: Handle `getinfo` client-side in bitcoin-cli w/ `-getinfo` by laanwj · Pull Request #8843 · bitcoin/bitcoin · GitHub 23:22 < wumpus> I don't... 23:22 < luke-jr> gmaxwell: "don't do that"? :p 23:22 < bitcoin-git> [bitcoin] laanwj closed pull request #8843: rpc: Handle `getinfo` client-side in bitcoin-cli w/ `-getinfo` (master...2016_09_getinfo_clientside) https://github.com/bitcoin/bitcoin/pull/8843 23:22 < wumpus> never mind, going to put this discussion on the backburner, there's more important things to worry about 23:22 < wumpus> what needs to get in today? 23:23 < luke-jr> BIP148, but I assume if the hold-outs on that had changed their mind, they'd say so :/ so probably nothing to do / discuss there 23:24 < wumpus> no no no no no 23:24 < sipa> #10831 would be nice, together with #10830 (which i hope can go in s a bugfix later) 23:24 < gribble> https://github.com/bitcoin/bitcoin/issues/10831 | Batch flushing operations to the walletdb during top up and increase keypool size. by gmaxwell · Pull Request #10831 · bitcoin/bitcoin · GitHub 23:24 < gribble> https://github.com/bitcoin/bitcoin/issues/10830 | [WIP] [wallet] keypool restore by jnewbery · Pull Request #10830 · bitcoin/bitcoin · GitHub 23:26 < wumpus> I'll just maintain my own client-side info scripts, I'm not going to try to introduce convenient info functionality in bitcoin-cli anymore 23:26 < wumpus> this is just too bizarry 23:26 < achow101> re getinfo: can we add something to the errors field warning about it being removed soon 23:26 < luke-jr> wumpus: put it in contrib/? 23:26 < wumpus> luke-jr: no, people can write their own 23:27 < wumpus> luke-jr: would probably get 100 comments again from people that want something slightly differetn 23:27 < wumpus> luke-jr: just tired of it 23:27 < luke-jr> sigh 23:27 < gmaxwell> please don't add things to the errors field. 23:28 < wumpus> that's what I said 23:28 < wumpus> just add an extra 'nag' field or so 23:28 < gmaxwell> yes, that would be okay. 23:28 < wumpus> errors would be a horrible place to add it, because it's not a block chain error 23:28 < sipa> agree 23:29 < sipa> there are more urgent things 23:29 < sipa> #10706 should get review 23:29 < gribble> https://github.com/bitcoin/bitcoin/issues/10706 | Improve wallet fee logic and fix GUI bugs by morcos · Pull Request #10706 · bitcoin/bitcoin · GitHub 23:30 < sipa> and #10829 or #10650 23:30 < gribble> https://github.com/bitcoin/bitcoin/issues/10829 | Simple, backwards compatible RPC multiwallet support. by ryanofsky · Pull Request #10829 · bitcoin/bitcoin · GitHub 23:30 < gribble> https://github.com/bitcoin/bitcoin/issues/10650 | Multiwallet: add RPC endpoint support by jonasschnelli · Pull Request #10650 · bitcoin/bitcoin · GitHub 23:31 < gmaxwell> sipa: I was just finishing testing/reviewing 10706. 23:31 < bitcoin-git> [bitcoin] luke-jr closed pull request #10074: Block size/weight fraud proofs (master...sizefp) https://github.com/bitcoin/bitcoin/pull/10074 23:47 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-qfxkunhswdscnnqn] has joined #bitcoin-core-dev 23:58 -!- mmgen [~mmgen@178-175-130-19.ip.as43289.net] has joined #bitcoin-core-dev