--- Day changed Tue Jul 25 2017
00:00 -!- DrOlmer2 [~DrOlmer@unaffiliated/drolmer] has joined #bitcoin-core-dev
00:04 -!- kexkey [~kexkey@68.168.119.227] has quit [Ping timeout: 248 seconds]
00:04 -!- DrOlmer2 [~DrOlmer@unaffiliated/drolmer] has quit [Read error: Connection reset by peer]
00:08 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
00:29 -!- J-wolf [~J-wolf@188.161.97.219] has quit [Remote host closed the connection]
00:32 -!- LeMiner [LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has quit [Read error: Connection reset by peer]
00:33 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 246 seconds]
00:34 -!- miknotauro [~miknotaur@187.207.42.68] has joined #bitcoin-core-dev
00:35 < bitcoin-git> [bitcoin] practicalswift opened pull request #10923: Use -Wthread-safety-analysis if available (+ -Werror=thread-safety-analysis if --enable-werror) (master...thread-safety-analysis) https://github.com/bitcoin/bitcoin/pull/10923
00:36 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection]
00:37 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev
00:38 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
00:42 -!- coredump_ [~quassel@vpn-qld171.vpnsolutions.com.au] has quit [Ping timeout: 246 seconds]
00:46 -!- Orion3k [~Orion3k@47-51-33-228.static.mtpk.ca.charter.com] has quit [Quit: Leaving]
00:49 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0c70e845aa92...1124328ad1e8
00:49 < bitcoin-git> bitcoin/master a5ecaf1 Steven D. Lander: Fix misspellings and remove safety verbiage
00:49 < bitcoin-git> bitcoin/master 1124328 Wladimir J. van der Laan: Merge #10789: Punctuation/grammer fixes in rpcwallet.cpp...
00:50 < bitcoin-git> [bitcoin] laanwj closed pull request #10789: Punctuation/grammer fixes in rpcwallet.cpp (master...cli-punctuation-standardization) https://github.com/bitcoin/bitcoin/pull/10789
00:52 -!- Cory [~Cory@unaffiliated/cory] has joined #bitcoin-core-dev
00:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
00:59 -!- J-wolf [~J-wolf@188.225.184.182] has joined #bitcoin-core-dev
01:00 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
01:00 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer]
01:01 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev
01:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds]
01:11 -!- iglobalvn [~iglobalvn@171.233.250.123] has quit []
01:18 < jonasschnelli> Is that comment correct? https://github.com/bitcoin/bitcoin/blob/master/src/validationinterface.h#L53 ( BlueMatt )
01:18 < jonasschnelli> Signal gets fired here: https://github.com/bitcoin/bitcoin/blob/master/src/validation.cpp#L3187
01:21 < jonasschnelli> If you request blocks B, C, D while your tip is A, then all three blocks (B, C, D, regardless of the order) would pass and be trigger the BlockChecked() signal
01:25 -!- J-wolf [~J-wolf@188.225.184.182] has quit [Remote host closed the connection]
01:25 -!- J-wolf [~J-wolf@188.225.184.182] has joined #bitcoin-core-dev
01:30 -!- J-wolf [~J-wolf@188.225.184.182] has quit [Ping timeout: 260 seconds]
01:30 -!- J-wolf [~J-wolf@188.225.184.182] has joined #bitcoin-core-dev
01:30 -!- Guest11189 [~mr_burdel@bounce.cryptolabs.net] has quit [Read error: Connection reset by peer]
01:34 -!- mr_burdell [~mr_burdel@bounce.cryptolabs.net] has joined #bitcoin-core-dev
01:34 -!- mr_burdell [~mr_burdel@bounce.cryptolabs.net] has quit [Changing host]
01:34 -!- mr_burdell [~mr_burdel@unaffiliated/mr-burdell/x-7609603] has joined #bitcoin-core-dev
01:34 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 248 seconds]
01:37 -!- str4d [~str4d@nova-153-092-136-128.cpe.nova.is] has joined #bitcoin-core-dev
01:38 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev
01:42 -!- J-wolf [~J-wolf@188.225.184.182] has quit [Remote host closed the connection]
01:42 -!- J-wolf [~J-wolf@188.225.184.182] has joined #bitcoin-core-dev
01:47 -!- J-wolf [~J-wolf@188.225.184.182] has quit [Ping timeout: 255 seconds]
01:52 -!- JackH [~laptop@host86-187-171-216.range86-187.btcentralplus.com] has joined #bitcoin-core-dev
02:10 -!- praxeology [~praxeolog@unaffiliated/praxeology] has left #bitcoin-core-dev []
02:16 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev
02:58 -!- ill [~ill@c-174-63-65-220.hsd1.ct.comcast.net] has quit [Ping timeout: 255 seconds]
03:00 < jonasschnelli> sipa: regarding the CChain object for headers, how to efficiently replace the GetDepthInMainChain in SPV mode?
03:01 < jonasschnelli> There is a chainActive->Contains(pindex) check in GetDepthInMainChain
03:01 < jonasschnelli> (which basically is a vector::[] access)
03:02 < jonasschnelli> without a CChain object this seems to be very inefficient
03:02 < sipa> jonasschnelli: GetAncestor is log(n)
03:03 < jonasschnelli> sipa: I see, GetAncestor also uses the pskip
03:03 < sipa> yes
03:03 < jonasschnelli> So replacing Contains() with GetAncestor() seems okayish?
03:04 < sipa> i believe so
03:04 < jonasschnelli> Okay. Let me benchmark then. Thanks!
03:04 -!- promag [~joao@2001:8a0:fe30:de01:24db:9495:178a:5aaa] has joined #bitcoin-core-dev
03:11 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection]
03:23 < jonasschnelli> sipa: is then the assumption 'chainActive.Tip().GetAncestor(otherBlockIndex.nHeight()) == chainActive.Contains(otherBlockIndex)' correct?
03:25 < sipa> jonasschnelli: yes
03:25 < jonasschnelli> Thanks
03:37 < bitcoin-git> [bitcoin] kore90 opened pull request #10925: bitcoin adder (master...release) https://github.com/bitcoin/bitcoin/pull/10925
03:38 < bitcoin-git> [bitcoin] fanquake closed pull request #10925: bitcoin adder (master...release) https://github.com/bitcoin/bitcoin/pull/10925
03:39 -!- tiagotrs_ [~tiago@x4db35c0c.dyn.telefonica.de] has joined #bitcoin-core-dev
03:44 -!- tiagotrs_ [~tiago@x4db35c0c.dyn.telefonica.de] has quit [Quit: leaving]
03:57 < promag> could we have some convention regarding commit messages and PR titles? for instance, prefix with "foo: " or "[foo] " and so on
03:58 < promag> I know it's not that important, but consistency is nice
03:59 < sipa> it's a balance between consistency and having people be annoyed at having too many rules :)
04:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
04:04 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds]
04:09 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
04:11 < luke-jr> promag: I always use "foo: "
04:26 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection]
04:27 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev
04:32 < wumpus> I also use foo:, but I don't care what you use
04:32 < wumpus> (foo: is the same as kernel/mesa so I can't forget that)
04:34 < jonasschnelli> sipa If use [foo]... but obviously foo: is more pure text conform.
04:34 < jonasschnelli> (sorry for the wrong highlight)
04:34 < jonasschnelli> * I use
04:35 < sipa> we should encourage html3 tags in commit titles
04:36 < sipa> improve readability on resolution!
04:36 < wumpus> commit stylesheet extensions
04:37 < instagibbs> commit messages should always be rendered in comic sans
04:37 < wumpus> color: #ff0000;
04:38 < wumpus> instagibbs: at the least in large, friendly letters
04:39 * sipa mentally sees a "DON'T PANIC" now
04:39 < wumpus> sipa: seems your latest change to 10526 made things better, repeated the test 3 times, FWIW all three times it had done the cleanup
04:40 < wumpus> will let it run a few more times just to be sure
04:40 < sipa> wumpus: great... aybe we shouldn't bother running the intermediate compactions?
04:41 < sipa> the hooe was that during the uograde process the disk usage wouldn't double
04:41 < sipa> but it does not seem to have that effect
04:42 < wumpus> I guess trying doesn't hurt either
04:43 < wumpus> maybe it sometimes works, sometimes doesn't, depending on how the records happen to be distributed on disk
04:44 -!- JackH [~laptop@host86-187-171-216.range86-187.btcentralplus.com] has quit [Ping timeout: 240 seconds]
04:45 < promag> lol ok
04:46 < wumpus> though I don't know the effect on performance
04:47 -!- JackH [~laptop@host86-187-171-216.range86-187.btcentralplus.com] has joined #bitcoin-core-dev
04:47 < wumpus> bleh, this time it was 4.5G
04:47 < wumpus> so no, it's still not entirely reliable
04:47 < wumpus> (and this is starting with exactly the same database every time!)
04:48 < sipa> but it does shrink after restart?
04:48 < wumpus> yes
04:49 < sipa> that's something at least, i guess
04:49 < wumpus> it eventually catches on and compacts, but it doesn't seem to be deterministic
04:49 < wumpus> (well, it always has done so at the next run, up until now)
04:51 < wumpus> monitoring disk usage *during* the process might be interesting too, to see when it does the compaction, but meh
04:52 < sipa> yeah
04:56 < luke-jr> [11:39:32] * sipa mentally sees a "DON'T PANIC" now <-- I noticed Android likes to capitalise "Don't Panic" when the words appear in that order.
04:57 < bitcoin-git> [bitcoin] laanwj closed pull request #10529: Improve bitcoind systemd service file (master...systemd-service) https://github.com/bitcoin/bitcoin/pull/10529
04:57 < bitcoin-git> [bitcoin] laanwj closed pull request #10531: Increased startup timeout. (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10531
04:58 -!- promag [~joao@2001:8a0:fe30:de01:24db:9495:178a:5aaa] has quit [Ping timeout: 246 seconds]
05:01 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer]
05:01 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev
05:07 -!- J-wolf [~J-wolf@188.225.184.182] has joined #bitcoin-core-dev
05:08 < luke-jr> I guess we should probably remove the systemd file altogether if nobody wants to maintain it
05:11 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1124328ad1e8...412b466d11ff
05:11 < bitcoin-git> bitcoin/master 9737572 Jonas Schnelli: [Qt] Use wallet 0 in rpc console if running with multiple wallets
05:11 < bitcoin-git> bitcoin/master 412b466 Wladimir J. van der Laan: Merge #10870: [Qt] Use wallet 0 in rpc console if running with multiple wallets...
05:11 < wumpus> well for both proposed changes there is no agreement, keeping the PR open for months doesn't help
05:11 < bitcoin-git> [bitcoin] laanwj closed pull request #10870: [Qt] Use wallet 0 in rpc console if running with multiple wallets (master...2017/07/qt_mw) https://github.com/bitcoin/bitcoin/pull/10870
05:11 < wumpus> not sure that having no example is better, but it can't accomodate everyone
05:16 < wumpus> I know nothing about systemd configuration files, so I can't help there at least
05:17 -!- J-wolf [~J-wolf@188.225.184.182] has quit [Remote host closed the connection]
05:17 < bitcoin-git> [bitcoin] laanwj closed pull request #10301: Check if sys/random.h is required for getentropy. (master...getentropy-rand) https://github.com/bitcoin/bitcoin/pull/10301
05:22 -!- elias19r [~elias19r@179.234.188.139] has joined #bitcoin-core-dev
05:23 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/412b466d11ff...1caafa6cde3b
05:23 < bitcoin-git> bitcoin/master 4f92b5f Russell Yanofsky: Run Qt wallet tests on travis...
05:23 < bitcoin-git> bitcoin/master 1caafa6 Wladimir J. van der Laan: Merge #10508: Run Qt wallet tests on travis...
05:24 < bitcoin-git> [bitcoin] laanwj closed pull request #10508: Run Qt wallet tests on travis (master...pr/travqt) https://github.com/bitcoin/bitcoin/pull/10508
05:24 < luke-jr> wumpus: 10529 sounded like the current one is just broken IIRC
05:26 < wumpus> ok, reopening then
05:26 < bitcoin-git> [bitcoin] laanwj reopened pull request #10529: Improve bitcoind systemd service file (master...systemd-service) https://github.com/bitcoin/bitcoin/pull/10529
05:45 < bitcoin-git> [bitcoin] laanwj opened pull request #10927: test: Make sure wallet.backup is created in temp path (master...2017_07_wallet_backup_temp_path) https://github.com/bitcoin/bitcoin/pull/10927
06:07 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection]
06:09 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev
06:10 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev
06:16 -!- ula [~kvirc@b2b-78-94-9-226.unitymedia.biz] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/]
06:23 -!- miknotauro [~miknotaur@187.207.42.68] has quit [Ping timeout: 268 seconds]
06:25 -!- goatpig [56f75436@gateway/web/freenode/ip.86.247.84.54] has joined #bitcoin-core-dev
06:31 -!- str4d [~str4d@nova-153-092-136-128.cpe.nova.is] has quit [Ping timeout: 240 seconds]
06:35 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has quit [Read error: Connection reset by peer]
06:35 -!- rjak [~rjak@gateway/vpn/privateinternetaccess/rjak] has quit [Quit: No Ping reply in 60 seconds.]
06:35 -!- moctos [~moctos@cpe-107-9-138-59.neo.res.rr.com] has quit [Remote host closed the connection]
06:35 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Excess Flood]
06:35 -!- rjak2 [~rjak@gateway/vpn/privateinternetaccess/rjak] has joined #bitcoin-core-dev
06:35 -!- rjak2 is now known as rjak
06:35 -!- moctos_ [~moctos@cpe-107-9-138-59.neo.res.rr.com] has joined #bitcoin-core-dev
06:35 -!- PaulCape_ [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has joined #bitcoin-core-dev
06:35 -!- phantomcircuit [~phantomci@192.241.205.97] has quit [Ping timeout: 260 seconds]
06:35 -!- johnpark_pj [~quassel@211.46.62.22] has quit [Quit: No Ping reply in 180 seconds.]
06:36 -!- johnpark_pj [~quassel@211.46.62.22] has joined #bitcoin-core-dev
06:36 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
06:36 -!- phantomcircuit [~phantomci@192.241.205.97] has joined #bitcoin-core-dev
06:37 -!- MarcoFalke [~none@198.12.116.246] has quit [Ping timeout: 259 seconds]
06:37 -!- MarcoFalke [~none@198.12.116.246] has joined #bitcoin-core-dev
07:01 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 248 seconds]
07:18 -!- Yogaqueef [~textual@dsl-hkibng42-5673c3-32.dhcp.inet.fi] has joined #bitcoin-core-dev
07:37 < BlueMatt> jonasschnelli: I believe thats still "correct", no?
07:37 < BlueMatt> jonasschnelli: though the comment may only be correct after its moved to a background thread
07:39 < BlueMatt> jonasschnelli: oh, i see your confusion, no, what you want to look at is https://github.com/bitcoin/bitcoin/blob/master/src/validation.cpp#L2197
07:39 < BlueMatt> jonasschnelli: the one you linked to is only called if the state is !IsValid()
07:43 < jonasschnelli> BlueMatt: do you know why its not also called when AcceptBlock does return true?
07:44 < jonasschnelli> because its also called during ConnectTip() then (called twice)
07:44 < BlueMatt> jonasschnelli: cause it should only be called once per block
07:44 < BlueMatt> wait, it shouldnt be?
07:44 < BlueMatt> jonasschnelli: i think the one you linked to is only AcceptBlock IsInvalid, ie it wasnt even stored on disk
07:45 < BlueMatt> the ConnectTip one can only fire if AcceptBlock took it
07:46 < jonasschnelli> i see
07:46 < BlueMatt> you should double check, but I believe that is correct
07:46 -!- promag [~joao@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
08:02 -!- promag [~joao@bl22-247-244.dsl.telepac.pt] has quit [Quit: Leaving.]
08:14 -!- promag [~joao@2001:8a0:fe30:de01:24db:9495:178a:5aaa] has joined #bitcoin-core-dev
08:28 < promag> wumpus: please restart job https://travis-ci.org/bitcoin/bitcoin/jobs/257251574
08:34 < jonasschnelli> promag: done
08:34 < promag> ty
08:36 -!- elias19r [~elias19r@179.234.188.139] has quit [Quit: Leaving]
08:37 < promag> if (foobar) vs if (foobar != nullptr) vs if (foobar != NULL) ?
08:37 < promag> don't ban me.. :P
08:38 < promag> looking the code the most frequent is the 1st..
08:40 -!- Dojixo [~Dojixo@197.51.107.144] has joined #bitcoin-core-dev
08:47 -!- jannes [~jannes@178.132.211.90] has quit [Ping timeout: 260 seconds]
08:48 -!- Dojixo [~Dojixo@197.51.107.144] has quit [Quit: Leaving]
08:48 -!- Dojixo [~Dojixo@197.51.107.144] has joined #bitcoin-core-dev
08:51 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev
08:57 -!- Dojixo [~Dojixo@197.51.107.144] has quit [Remote host closed the connection]
08:57 -!- ElDojixo [~Dojixo@197.51.107.144] has joined #bitcoin-core-dev
08:58 -!- ElDojixo [~Dojixo@197.51.107.144] has quit [Remote host closed the connection]
08:59 -!- ElDojixo [~Dojixo@197.51.107.144] has joined #bitcoin-core-dev
08:59 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #bitcoin-core-dev
08:59 -!- ElDojixo [~Dojixo@197.51.107.144] has quit [Remote host closed the connection]
09:01 -!- Dojixo [~Dojixo@197.51.107.144] has joined #bitcoin-core-dev
09:02 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer]
09:03 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev
09:03 -!- wasi [~wasi@gateway/tor-sasl/wasi] has quit [Quit: Leaving]
09:04 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
09:08 -!- Dojixo [~Dojixo@197.51.107.144] has quit [Quit: Leaving]
09:08 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds]
09:08 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]
09:09 -!- jamesob_ [~james@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
09:09 -!- Dojixo [~Dojixo@197.51.107.144] has joined #bitcoin-core-dev
09:09 -!- spinza [~spin@196.212.164.26] has quit [Ping timeout: 240 seconds]
09:17 -!- Dojixo [~Dojixo@197.51.107.144] has quit [Remote host closed the connection]
09:17 -!- jamesob_ [~james@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Ping timeout: 255 seconds]
09:17 -!- ElDojixo [~Dojixo@197.51.107.144] has joined #bitcoin-core-dev
09:17 -!- baldur [~baldur@pool-72-69-111-218.nycmny.fios.verizon.net] has quit [Ping timeout: 260 seconds]
09:17 -!- promag [~joao@2001:8a0:fe30:de01:24db:9495:178a:5aaa] has quit [Ping timeout: 246 seconds]
09:20 -!- ula [~kvirc@b2b-78-94-9-226.unitymedia.biz] has joined #bitcoin-core-dev
09:31 -!- ElDojixo [~Dojixo@197.51.107.144] has quit [Quit: Leaving]
--- Log closed Tue Jul 25 09:36:13 2017
--- Log opened Tue Jul 25 09:42:36 2017
09:42 -!- kanzure [~kanzure@unaffiliated/kanzure] has joined #bitcoin-core-dev
09:42 -!- Irssi: #bitcoin-core-dev: Total of 209 nicks [0 ops, 0 halfops, 0 voices, 209 normal]
09:44 -!- Dojixo [~Dojixo@197.51.107.144] has quit [Client Quit]
09:44 -!- You're now known as 07EABCRRW
09:44 -!- spinza [~spin@196.212.164.26] has quit [Ping timeout: 260 seconds]
09:45 -!- Dojixo [~Dojixo@197.51.107.144] has joined #bitcoin-core-dev
09:46 -!- elias19r_ [~elias19r@179.234.188.139] has joined #bitcoin-core-dev
09:46 -!- kanzure [~kanzure@unaffiliated/kanzure] has joined #bitcoin-core-dev
--- Log closed Tue Jul 25 09:46:47 2017
--- Log opened Tue Jul 25 09:47:53 2017
09:47 -!- kanzure [~kanzure@unaffiliated/kanzure] has joined #bitcoin-core-dev
09:47 -!- Irssi: #bitcoin-core-dev: Total of 209 nicks [0 ops, 0 halfops, 0 voices, 209 normal]
09:54 -!- spinza [~spin@196.212.164.26] has joined #bitcoin-core-dev
09:55 -!- cheese_ [~Cheeseo@unaffiliated/cheeseo] has joined #bitcoin-core-dev
09:55 -!- Irssi: Join to #bitcoin-core-dev was synced in 462 secs
10:02 -!- elias19r_ [~elias19r@179.234.188.139] has quit [Quit: Leaving]
10:05 -!- Dojixo [~Dojixo@197.51.107.144] has quit [Remote host closed the connection]
10:05 -!- Dojixo [~Dojixo@197.51.107.144] has joined #bitcoin-core-dev
10:05 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
10:05 -!- jamesob [~james@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
10:09 -!- Dojixo [~Dojixo@197.51.107.144] has quit [Remote host closed the connection]
10:10 -!- Dojixo [~Dojixo@197.51.107.144] has joined #bitcoin-core-dev
10:11 -!- tucenaber [~tucenaber@unaffiliated/tucenaber] has quit [Ping timeout: 240 seconds]
10:13 -!- fizzwont_ [~irc3@192.169.7.153] has joined #bitcoin-core-dev
10:13 -!- fizzwont [~irc3@unaffiliated/fizzwont] has quit [Ping timeout: 260 seconds]
10:15 -!- jamesob_ [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
10:16 -!- tucenaber [~tucenaber@unaffiliated/tucenaber] has joined #bitcoin-core-dev
10:16 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev
10:23 -!- elias19r [~elias19r@179.234.188.139] has joined #bitcoin-core-dev
10:24 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds]
10:26 -!- Dojixo [~Dojixo@197.51.107.144] has quit [Quit: Leaving]
10:30 -!- elias19r [~elias19r@179.234.188.139] has left #bitcoin-core-dev []
10:33 -!- eck [~eck@fsf/member/eck] has quit [Quit: poop]
10:34 -!- eck [~eck@fsf/member/eck] has joined #bitcoin-core-dev
10:46 -!- J-wolf [~J-wolf@188.161.97.219] has joined #bitcoin-core-dev
10:48 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev
10:56 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds]
11:01 -!- elias19r [~elias19r@179.234.188.139] has joined #bitcoin-core-dev
11:01 -!- J-wolf [~J-wolf@188.161.97.219] has quit [Remote host closed the connection]
11:03 -!- elias19r [~elias19r@179.234.188.139] has left #bitcoin-core-dev []
11:07 -!- AMaisLeveBrisa [~felco@unaffiliated/felco] has quit [Ping timeout: 258 seconds]
11:12 -!- felco [~felco@unaffiliated/felco] has joined #bitcoin-core-dev
11:13 -!- baldur [~baldur@pool-72-69-111-218.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
11:18 < BlueMatt> things that (probably) need a 15 tag: 10914, 10799
11:25 -!- miknotauro [~miknotaur@187.207.42.68] has joined #bitcoin-core-dev
11:33 -!- fizzwont_ is now known as fizzwont
11:33 -!- fizzwont [~irc3@192.169.7.153] has quit [Changing host]
11:33 -!- fizzwont [~irc3@unaffiliated/fizzwont] has joined #bitcoin-core-dev
11:44 -!- elias19r [~elias19r@179.234.188.139] has joined #bitcoin-core-dev
11:47 -!- jifenglei [daf1fb93@gateway/web/freenode/ip.218.241.251.147] has quit [Ping timeout: 260 seconds]
11:49 -!- miknotauro [~miknotaur@187.207.42.68] has quit [Ping timeout: 248 seconds]
11:49 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 255 seconds]
11:49 -!- jamesob [~james@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Remote host closed the connection]
12:01 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 260 seconds]
12:02 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev
12:08 -!- cryptapus [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev
12:08 -!- cryptapus [~cryptapus@jupiter.osmus.org] has quit [Changing host]
12:08 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
12:08 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has quit [Remote host closed the connection]
12:14 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 255 seconds]
12:19 -!- cryptapus is now known as cryptapus_afk
12:24 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1caafa6cde3b...f1f1605c22a6
12:24 < bitcoin-git> bitcoin/master d64ac3f Jonas Schnelli: [tests] Allow tests to pass when stderr is non-empty...
12:24 < bitcoin-git> bitcoin/master f1f1605 MarcoFalke: Merge #10703: [tests] Allow tests to pass when stderr is non-empty...
12:24 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #10703: [tests] Allow tests to pass when stderr is non-empty (master...test_stderr) https://github.com/bitcoin/bitcoin/pull/10703
12:26 < gmaxwell> ^ that means we can't use tsan with tests anymore, no?
12:27 < wumpus> is that so? why don't you reply that on the PR instead of after it is merged?
12:27 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev
12:27 < wumpus> I don't see why though, tests can still print things to stderr, it just won't cause them to fail
12:28 < wumpus> apparently #10882 (which has 0.15 milestone) was depending on it
12:28 < gribble> https://github.com/bitcoin/bitcoin/issues/10882 | Keypool topup by jnewbery · Pull Request #10882 · bitcoin/bitcoin · GitHub
12:29 < gmaxwell> wumpus: because you commented on it on the original pr, and I hadn't seen the second.
12:29 < wumpus> it introduces a "passed with warnings" result if a test succeeds but prints to stderr
12:29 < BlueMatt> gmaxwell: it still prints "Passed with warnings"
12:29 < wumpus> seems good enough to me
12:30 < wumpus> no need to panic
12:30 < BlueMatt> so you can see it
12:30 < gmaxwell> that wasn't a panic.
12:30 < gmaxwell> it was a question, seems you've answered it. though I'm concerned that passed with warnings will become the normal state since travis won't reject it. Can someone explain the need for this to me?
12:31 < BlueMatt> no, what my gpu makes my kernel do is a panic :(
12:32 < BlueMatt> gmaxwell: i have to assume cause the keypool topup thing prints warnings that you need to top up your keypool? dunno, havent had a chance to review that one yet
12:32 < gmaxwell> litterally the PR says "not sure how much people want this" and the original PR has no description at all beyond the title.
12:32 < wumpus> apparently #10882 (which has 0.15 milestone) was depending on it
12:32 < gribble> https://github.com/bitcoin/bitcoin/issues/10882 | Keypool topup by jnewbery · Pull Request #10882 · bitcoin/bitcoin · GitHub
12:32 < BlueMatt> ryanofsky or jnewbery may know
12:32 < wumpus> that's why it was merged
12:33 < ryanofsky> i'm actually not sure the reason for the dependency
12:33 < BlueMatt> heh, really shit time for everyone to be in japan
12:33 < wumpus> anyhow if tests don't succeed they shouldn't return success
12:34 < gmaxwell> BlueMatt: if so, then does that mean it'll always print that.. in which case, the warnings notice is not useful.
12:34 < BlueMatt> gmaxwell: ok, lets wait till jnewbery can come back and answer :)
12:34 < ryanofsky> yeah, that seems reasonable. maybe just revert the change and we can ask john about it to see if there's a better solution
12:34 < wumpus> revert it then?
12:35 < ryanofsky> sound good to me
12:35 < BlueMatt> or just wait till we get an answer
12:35 < BlueMatt> or...whatever, i dont care
12:35 < wumpus> I don't, either
12:35 < ryanofsky> me either
12:36 < gmaxwell> wumpus: in terms of the test passing, the tests still pass the the sanitizers print important notices that things have gone wrong... they've helped us find a lot of serious bugs, if there is a good reason for making changes that indirectly hobble them; okay. But I am completely clueless as to why this change is desirable, and the PRs did not justify it, AFAICT (though it's fully possibly I'm mis
12:37 < wumpus> can we now go back to discussing things before they are merged, instead of after?
12:37 < gmaxwell> sing something).
12:37 < wumpus> gmaxwell: I don't feel like defending the change at all
12:37 -!- cluelessperson [~cluelessp@unaffiliated/cluelessperson] has joined #bitcoin-core-dev
12:37 < wumpus> afaik I didn't even comment on it
12:38 < wumpus> oh I did on the previous one, months ago
12:38 < gmaxwell> wumpus: you commented on the earlier on, first comment, raising the sanitizer compatiblity concern.
12:38 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has quit [Quit: Leaving]
12:38 < wumpus> yep
12:39 < wumpus> ok, reverting it then, seems clearly a misunderstanding
12:39 < gmaxwell> Thanks.
12:48 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/60f9778abfea615beac384a08e6a13ebec65275b
12:48 < bitcoin-git> bitcoin/master 60f9778 Wladimir J. van der Laan: Revert "[tests] Allow tests to pass when stderr is non-empty"...
12:54 -!- J-wolf [~J-wolf@188.161.97.219] has joined #bitcoin-core-dev
12:57 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/60f9778abfea...9d5e8f92a7db
12:57 < bitcoin-git> bitcoin/master 88af227 Wladimir J. van der Laan: test: Make sure wallet.backup is created in temp path...
12:57 < bitcoin-git> bitcoin/master 9d5e8f9 Wladimir J. van der Laan: Merge #10927: test: Make sure wallet.backup is created in temp path...
12:57 < bitcoin-git> [bitcoin] laanwj closed pull request #10927: test: Make sure wallet.backup is created in temp path (master...2017_07_wallet_backup_temp_path) https://github.com/bitcoin/bitcoin/pull/10927
13:01 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer]
13:01 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev
13:03 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9d5e8f92a7db...8537187d4213
13:03 < bitcoin-git> bitcoin/master 99c7fc3 Matt Corallo: Prevent user from specifying conflicting parameters to fundrawtx...
13:03 < bitcoin-git> bitcoin/master 8537187 Wladimir J. van der Laan: Merge #10799: Prevent user from specifying conflicting parameters to fundrawtx...
13:03 < bitcoin-git> [bitcoin] laanwj closed pull request #10799: Prevent user from specifying conflicting parameters to fundrawtx (master...2017-07-no-fundraw-conflicts) https://github.com/bitcoin/bitcoin/pull/10799
13:15 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 246 seconds]
13:15 -!- promag [~joao@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
13:19 -!- TD-Linux [~Thomas@about/essy/indecisive/TD-Linux] has quit [Ping timeout: 260 seconds]
13:21 -!- TD-Linux [~Thomas@about/essy/indecisive/TD-Linux] has joined #bitcoin-core-dev
13:24 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has quit [Quit: conversation terminated!]
13:26 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
13:26 -!- cryptapus is now known as cryptapus_afk
13:28 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev
13:36 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 258 seconds]
13:36 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 255 seconds]
13:37 -!- J-wolf [~J-wolf@188.161.97.219] has quit [Remote host closed the connection]
13:38 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev
13:48 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev
13:55 < MarcoFalke> Sorry, I missed the discussion about the stderr thing. Agree that it should be reverted.
13:55 < MarcoFalke> Best is to apply it specifically only where needed
13:55 < MarcoFalke> Instead of per default for all tests
13:58 < MarcoFalke> The exact error message ("Number of keys in keypool is below critical minimum") can even be checked when piped into a SpooledTemporaryFile
13:59 < promag> should we disallow wallet files being symlinks?
14:05 < gmaxwell> MarcoFalke: yea, I think we should have a specific test for that error, since its intentional functionality.
14:05 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
14:05 < MarcoFalke> We already had those issues that the specific error was not tested against. And run into issues...
14:06 < MarcoFalke> Not worth repeating
14:06 < MarcoFalke> Thanks for raising the concern quickly, gmaxwell
14:07 < gmaxwell> No problem, I think I didn't see the new PR because I confused it for the old one or something.
14:07 -!- jamesob_ [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Ping timeout: 246 seconds]
14:08 -!- Yogaqueef [~textual@dsl-hkibng42-5673c3-32.dhcp.inet.fi] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
14:08 < MarcoFalke> too much going. I only keep up with pulls after they are merged atm
14:09 < MarcoFalke> jnewbery: Let me know if there are any test pulls I should look at with priority
14:13 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.]
14:17 -!- elias19r [~elias19r@179.234.188.139] has quit [Quit: Leaving.]
14:18 -!- elias19r [~elias19r@179.234.188.139] has joined #bitcoin-core-dev
14:41 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 276 seconds]
14:47 < instagibbs> assuming no priority, how does the miner select between two identical feerate transactions if it has to choose between the two?
14:48 < gmaxwell> instagibbs: whatever comes up first out of the index.
14:50 < instagibbs> well, yeah :) I guess the answer is "no particular ordering"
14:53 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev
15:03 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 255 seconds]
15:10 -!- jeep-ss [~chatzilla@78.31.64.4] has joined #bitcoin-core-dev
15:16 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev
15:21 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds]
15:21 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Ping timeout: 276 seconds]
15:21 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]
15:22 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev
15:26 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 246 seconds]
15:27 -!- Cory [~Cory@unaffiliated/cory] has quit [Remote host closed the connection]
15:34 -!- Cory [~Cory@unaffiliated/cory] has joined #bitcoin-core-dev
15:34 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev
15:39 -!- JackH [~laptop@host86-187-171-216.range86-187.btcentralplus.com] has quit [Read error: Connection reset by peer]
15:40 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
15:40 -!- JackH [~laptop@host86-187-171-216.range86-187.btcentralplus.com] has joined #bitcoin-core-dev
15:44 -!- Dizzle [~dizzle@108.171.182.16] has quit [Quit: Leaving...]
15:52 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds]
15:52 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Ping timeout: 260 seconds]
16:00 < gmaxwell> I updated my banlists: https://people.xiph.org/~greg/banlist.cli.txt https://people.xiph.org/~greg/banlist.gui.txt
16:01 -!- J-wolf [~J-wolf@188.161.97.219] has joined #bitcoin-core-dev
16:03 -!- J-wolf [~J-wolf@188.161.97.219] has quit [Read error: Connection reset by peer]
16:03 -!- J-wolf_ [~J-wolf@188.161.97.219] has joined #bitcoin-core-dev
16:04 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev
16:06 -!- J-wolf [~J-wolf@188.161.97.219] has joined #bitcoin-core-dev
16:06 -!- J-wolf_ [~J-wolf@188.161.97.219] has quit [Read error: Connection reset by peer]
16:07 -!- NewLiberty_ [~NewLibert@2602:306:b8e0:8160:5812:64d:837a:66c3] has joined #bitcoin-core-dev
16:08 -!- J-wolf [~J-wolf@188.161.97.219] has quit [Read error: Connection reset by peer]
16:11 -!- cheese_ [~Cheeseo@unaffiliated/cheeseo] has quit [Read error: Connection reset by peer]
16:11 -!- NewLiberty [~NewLibert@2602:306:b8e0:8160:d188:6361:15af:b436] has quit [Ping timeout: 276 seconds]
16:11 -!- vicenteH [~user@13.232.15.37.dynamic.jazztel.es] has quit [Ping timeout: 260 seconds]
16:14 -!- J-wolf [~J-wolf@188.161.97.219] has joined #bitcoin-core-dev
16:15 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev
16:16 -!- elias19r [~elias19r@179.234.188.139] has left #bitcoin-core-dev []
16:17 -!- J-wolf [~J-wolf@188.161.97.219] has quit [Read error: Connection reset by peer]
16:17 -!- J-wolf [~J-wolf@188.161.97.219] has joined #bitcoin-core-dev
16:20 -!- J-wolf_ [~J-wolf@188.161.97.219] has joined #bitcoin-core-dev
16:20 -!- J-wolf [~J-wolf@188.161.97.219] has quit [Read error: Connection reset by peer]
16:20 -!- ill [~ill@c-174-63-65-220.hsd1.ct.comcast.net] has joined #bitcoin-core-dev
16:21 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 276 seconds]
16:23 -!- J-wolf_ [~J-wolf@188.161.97.219] has quit [Read error: Connection reset by peer]
16:25 -!- J-wolf [~J-wolf@188.161.97.219] has joined #bitcoin-core-dev
16:28 -!- J-wolf [~J-wolf@188.161.97.219] has quit [Read error: Connection reset by peer]
16:33 -!- J-wolf [~J-wolf@188.161.97.219] has joined #bitcoin-core-dev
16:34 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev
16:35 -!- deep-book-gk_ [~1wm_su@101-170.furanet.com] has joined #bitcoin-core-dev
16:35 -!- deep-book-gk_ [~1wm_su@101-170.furanet.com] has left #bitcoin-core-dev []
16:36 -!- J-wolf [~J-wolf@188.161.97.219] has quit [Read error: Connection reset by peer]
16:36 -!- J-wolf_ [~J-wolf@188.161.97.219] has joined #bitcoin-core-dev
16:39 -!- J-wolf_ [~J-wolf@188.161.97.219] has quit [Read error: Connection reset by peer]
16:39 -!- J-wolf [~J-wolf@188.161.97.219] has joined #bitcoin-core-dev
16:41 -!- J-wolf [~J-wolf@188.161.97.219] has quit [Read error: Connection reset by peer]
16:45 -!- J-wolf [~J-wolf@188.161.97.219] has joined #bitcoin-core-dev
16:47 -!- J-wolf [~J-wolf@188.161.97.219] has quit [Read error: Connection reset by peer]
16:47 -!- J-wolf [~J-wolf@188.161.97.219] has joined #bitcoin-core-dev
16:49 -!- jamesob_ [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
16:50 -!- J-wolf [~J-wolf@188.161.97.219] has quit [Read error: Connection reset by peer]
16:50 -!- J-wolf [~J-wolf@188.161.97.219] has joined #bitcoin-core-dev
16:51 -!- jamesob [~jamesob@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds]
16:53 -!- J-wolf_ [~J-wolf@188.161.97.219] has joined #bitcoin-core-dev
16:54 -!- J-wolf [~J-wolf@188.161.97.219] has quit [Ping timeout: 240 seconds]
16:56 -!- J-wolf_ [~J-wolf@188.161.97.219] has quit [Read error: Connection reset by peer]
16:56 -!- J-wolf [~J-wolf@188.161.97.219] has joined #bitcoin-core-dev
16:58 -!- J-wolf [~J-wolf@188.161.97.219] has quit [Read error: Connection reset by peer]
17:02 -!- J-wolf [~J-wolf@188.161.97.219] has joined #bitcoin-core-dev
17:04 -!- J-wolf [~J-wolf@188.161.97.219] has quit [Read error: Connection reset by peer]
17:07 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev
17:07 -!- J-wolf [~J-wolf@188.161.97.219] has joined #bitcoin-core-dev
17:08 -!- promag [~joao@bl22-247-244.dsl.telepac.pt] has quit [Quit: Leaving.]
17:09 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 248 seconds]
17:10 -!- J-wolf_ [~J-wolf@188.161.97.219] has joined #bitcoin-core-dev
17:10 -!- J-wolf [~J-wolf@188.161.97.219] has quit [Read error: Connection reset by peer]
17:12 -!- J-wolf_ [~J-wolf@188.161.97.219] has quit [Read error: Connection reset by peer]
17:18 -!- J-wolf [~J-wolf@188.161.97.219] has joined #bitcoin-core-dev
17:20 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]
17:20 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 240 seconds]
17:20 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev
17:21 -!- J-wolf [~J-wolf@188.161.97.219] has quit [Read error: Connection reset by peer]
17:24 -!- J-wolf [~J-wolf@188.161.97.219] has joined #bitcoin-core-dev
17:24 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev
17:24 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds]
17:26 -!- J-wolf [~J-wolf@188.161.97.219] has quit [Read error: Connection reset by peer]
17:27 -!- J-wolf [~J-wolf@188.161.97.219] has joined #bitcoin-core-dev
17:28 -!- miknotauro [~miknotaur@187.207.42.68] has joined #bitcoin-core-dev
17:29 -!- J-wolf [~J-wolf@188.161.97.219] has quit [Read error: Connection reset by peer]
17:29 -!- J-wolf [~J-wolf@188.161.97.219] has joined #bitcoin-core-dev
17:32 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev
17:32 -!- J-wolf [~J-wolf@188.161.97.219] has quit [Read error: Connection reset by peer]
17:35 -!- J-wolf [~J-wolf@188.161.97.219] has joined #bitcoin-core-dev
17:36 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 255 seconds]
17:37 -!- J-wolf [~J-wolf@188.161.97.219] has quit [Read error: Connection reset by peer]
17:37 -!- J-wolf_ [~J-wolf@188.161.97.219] has joined #bitcoin-core-dev
17:42 -!- J-wolf_ [~J-wolf@188.161.97.219] has quit [Ping timeout: 248 seconds]
17:49 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds]
17:51 -!- baldur [~baldur@pool-72-69-111-218.nycmny.fios.verizon.net] has quit [Read error: Connection reset by peer]
17:52 -!- baldur [~baldur@pool-72-69-111-218.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
17:59 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-gcvaknsytsqvleky] has quit [Quit: Connection closed for inactivity]
18:08 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev
18:17 -!- rjak [~rjak@gateway/vpn/privateinternetaccess/rjak] has left #bitcoin-core-dev []
18:50 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 258 seconds]
19:14 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds]
19:17 -!- cryptapus [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev
19:17 -!- cryptapus [~cryptapus@jupiter.osmus.org] has quit [Changing host]
19:17 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
19:19 -!- aj_ [aj@cerulean.erisian.com.au] has joined #bitcoin-core-dev
19:19 -!- cryptapus_afk [~cryptapus@unaffiliated/cryptapus] has quit [Remote host closed the connection]
19:19 -!- bitbee [~bitbee@138.197.209.248] has quit [Quit: No Ping reply in 360 seconds.]
19:19 -!- aj [aj@cerulean.erisian.com.au] has quit [Remote host closed the connection]
19:20 -!- bitbee [~bitbee@138.197.209.248] has joined #bitcoin-core-dev
19:22 -!- spinza [~spin@196.212.164.26] has quit [Ping timeout: 260 seconds]
19:30 < gmaxwell> Can someone remind me why we have a setting for turning on and off the standardness of bare multisig? it has no tests but seems kind of pointless to me..
19:36 -!- spinza [~spin@196.212.164.26] has joined #bitcoin-core-dev
19:45 -!- goatpig [56f75436@gateway/web/freenode/ip.86.247.84.54] has quit [Quit: Page closed]
20:05 -!- treebeardd [~treebeard@50-248-210-131-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
20:15 -!- jeep-ss [~chatzilla@78.31.64.4] has quit [Ping timeout: 248 seconds]
20:19 -!- KevinPan [~kevinpan@static-ip-25-116-90-219.rev.dyxnet.com] has joined #bitcoin-core-dev
20:28 -!- EagleTM [~EagleTM@x4db381fb.dyn.telefonica.de] has joined #bitcoin-core-dev
20:29 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev
20:29 -!- Eagle[TM] [~EagleTM@x55b61b92.dyn.telefonica.de] has quit [Ping timeout: 255 seconds]
20:31 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
20:31 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 258 seconds]
20:32 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 248 seconds]
20:33 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev
20:35 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Client Quit]
20:36 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
20:41 -!- KevinPan [~kevinpan@static-ip-25-116-90-219.rev.dyxnet.com] has quit [Ping timeout: 255 seconds]
20:43 -!- treebeardd [~treebeard@50-248-210-131-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
20:43 -!- jamesob [~james@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
21:02 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 260 seconds]
21:05 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev
21:13 < jnewbery>
21:13 < sipa>
21:19 < jnewbery> gmaxwell : can you explain the tsan issue? The new keypool-rescan test checks that bitcoind will exit if the keypool drops below critical. bitcoind will also print to stderr if that happens. Without #10703, any output in stderr results in test failure
21:19 < gribble> https://github.com/bitcoin/bitcoin/issues/10703 | [tests] Allow tests to pass when stderr is non-empty by jnewbery · Pull Request #10703 · bitcoin/bitcoin · GitHub
21:20 < jnewbery> I'll work on it tomorrow to make it more targeted
21:22 -!- nelruk [~dax_the_c@181.122.72.30] has joined #bitcoin-core-dev
21:23 < sipa> jnewbery: tsan prints violations to stderr
21:25 < sipa> i assume it's related to that; i haven't followed the discussion
21:25 -!- deep-book-gk_ [~1wm_su@185.93.183.215] has joined #bitcoin-core-dev
21:27 -!- JackH [~laptop@host86-187-171-216.range86-187.btcentralplus.com] has quit [Ping timeout: 240 seconds]
21:30 -!- deep-book-gk_ [~1wm_su@185.93.183.215] has left #bitcoin-core-dev []
21:33 < luke-jr> gmaxwell: IIRC last time there was an effort to make it just policy-rejected always, some people didn't agree
21:34 -!- J-wolf [~J-wolf@188.161.97.219] has joined #bitcoin-core-dev
21:36 < gmaxwell> jnewbery: tsan and other dynamic analysis instrumention throws errors to stderr, so if we want to continue to use them for testing we can't just have their errors get eaten.
21:36 < gmaxwell> jnewbery: for tests that are supposted to throw errors we sould probably actually test for that, rather than generally ignore stderr. I think.
21:49 -!- nelruk [~dax_the_c@181.122.72.30] has quit [Quit: Leaving]
21:55 -!- J-wolf [~J-wolf@188.161.97.219] has quit [Remote host closed the connection]
21:57 -!- J-wolf [~J-wolf@188.161.97.219] has joined #bitcoin-core-dev
22:05 -!- J-wolf [~J-wolf@188.161.97.219] has quit [Remote host closed the connection]
22:28 -!- btcdrak [uid239175@gateway/web/irccloud.com/x-kjegbnjkffmdiyib] has quit [Quit: Connection closed for inactivity]
22:39 < bitcoin-git> [bitcoin] DevlinShepherd opened pull request #10928: [bitcoin] Nits for README description (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10928
22:40 < bitcoin-git> [bitcoin] sipa closed pull request #10928: [bitcoin] Nits for README description (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10928
22:41 -!- btcdrak [uid239175@gateway/web/irccloud.com/x-wfkivwhoffpwumlo] has joined #bitcoin-core-dev
22:41 -!- miknotauro [~miknotaur@187.207.42.68] has quit [Ping timeout: 248 seconds]
22:49 < wumpus> gmaxwell: seems to me too that if bitcoind is supposed to print to stderr, it should specifically check for that, instead of a general "succeeded with warnings"
22:58 < wumpus> BlueMatt: https://github.com/bitcoin/bitcoin/pull/10619#pullrequestreview-52181600 which automated warning?
23:00 < wumpus> I also guess if that was the case, it'd need an assertion at *all* callsites of chainactive.tip, in which case why not check in the function itself?
23:00 < wumpus> I don't see the point to randomly peppering around some assertions
23:01 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
23:03 < wumpus> if there's an automated warning I'd like to know why it triggers just there
23:03 < wumpus> not just add assertions and pray
23:12 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8537187d4213...f29d5dbd04da
23:12 < bitcoin-git> bitcoin/master 0be03c7 Brian McMichael: Qt: Use _putenv_s instead of setenv on Windows builds
23:12 < bitcoin-git> bitcoin/master f29d5db Wladimir J. van der Laan: Merge #10899: [test] Qt: Use _putenv_s instead of setenv on Windows builds...
23:13 < bitcoin-git> [bitcoin] laanwj closed pull request #10899: [test] Qt: Use _putenv_s instead of setenv on Windows builds (master...testfix) https://github.com/bitcoin/bitcoin/pull/10899
23:15 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f29d5dbd04da...b995a374f727
23:15 < bitcoin-git> bitcoin/master a56f8b0 Matt Corallo: Add missing lock in CScheduler::AreThreadsServicingQueue()...
23:15 < bitcoin-git> bitcoin/master b995a37 Wladimir J. van der Laan: Merge #10914: Add missing lock in CScheduler::AreThreadsServicingQueue()...
23:15 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 255 seconds]
23:16 < bitcoin-git> [bitcoin] laanwj closed pull request #10914: Add missing lock in CScheduler::AreThreadsServicingQueue() (master...2017-04-fix-missing-scheduler-lock) https://github.com/bitcoin/bitcoin/pull/10914
23:45 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b995a374f727...78f307b66428
23:45 < bitcoin-git> bitcoin/master 9f8a46f Ryan Havar: Properly document target_confirmations in listsinceblock
23:45 < bitcoin-git> bitcoin/master 78f307b Wladimir J. van der Laan: Merge #10655: Properly document target_confirmations in listsinceblock...
23:45 < bitcoin-git> [bitcoin] laanwj closed pull request #10655: Properly document target_confirmations in listsinceblock (master...listsinceblock) https://github.com/bitcoin/bitcoin/pull/10655
23:48 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/78f307b66428...04d395e8327d
23:48 < bitcoin-git> bitcoin/master 095b917 Gregory Maxwell: Avoid using sizes on non-fixed-width types to derive protocol constants....
23:48 < bitcoin-git> bitcoin/master 04d395e Wladimir J. van der Laan: Merge #10854: Avoid using sizes on non-fixed-width types to derive protocol constants....
23:49 < bitcoin-git> [bitcoin] laanwj closed pull request #10854: Avoid using sizes on non-fixed-width types to derive protocol constants. (master...rbf-numlimit-fix) https://github.com/bitcoin/bitcoin/pull/10854