--- Day changed Tue Aug 15 2017 00:01 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:01 -!- alreadylate [~textual@c-250e71d5.153-1-64736c10.cust.bredbandsbolaget.se] has joined #bitcoin-core-dev 00:03 -!- promag [~Adium@30.1.54.77.rev.vodafone.pt] has quit [Quit: Leaving.] 00:05 -!- promag [~Adium@30.1.54.77.rev.vodafone.pt] has joined #bitcoin-core-dev 00:07 < bitcoin-git> [bitcoin] zhiweiwong96 opened pull request #11051: Test branch (master...testBranch) https://github.com/bitcoin/bitcoin/pull/11051 00:12 -!- alreadylate [~textual@c-250e71d5.153-1-64736c10.cust.bredbandsbolaget.se] has quit [] 00:15 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 00:15 < bitcoin-git> [bitcoin] fanquake closed pull request #11051: Test branch (master...testBranch) https://github.com/bitcoin/bitcoin/pull/11051 00:16 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 00:24 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 240 seconds] 00:26 < arowser> Hi, if exists a place that can download the dbg file that split from the released bitcoin core ? 00:31 < jonasschnelli> arowser: dbg? You mean the debug symbols? 00:31 < arowser> yes 00:31 < wumpus> AFAIK no one hosts that - they're huge 00:33 < achow101> arowser: for which version? 00:33 < arowser> 0.14.2 00:33 -!- moriarty [~sjkd@unaffiliated/moriarty] has joined #bitcoin-core-dev 00:34 < achow101> hmm. I have those locally 00:34 < wumpus> I don't have them at the moment (they're easy to build though) 00:35 < achow101> is there a command line way to put release assets on github? I can upload mine to github, but I'm away from that computer right now 00:36 < wumpus> there might be a way through the API 00:36 < achow101> bleh. the API is a mess 00:37 < wumpus> that might be, but it's the way to do website things though e.g. a command line tool. Easier at least than reverse-engineering what the website does... 00:40 < bitcoin-git> [bitcoin] laanwj closed pull request #10752: Use quoted form when including primitives/transaction.h and wallet/wallet.h (master...transaction-h) https://github.com/bitcoin/bitcoin/pull/10752 00:41 < bitcoin-git> [bitcoin] JennHorng opened pull request #11052: Jennhorng dev (master...jennhorng-dev) https://github.com/bitcoin/bitcoin/pull/11052 00:42 < bitcoin-git> [bitcoin] fanquake closed pull request #11052: Jennhorng dev (master...jennhorng-dev) https://github.com/bitcoin/bitcoin/pull/11052 00:58 < wumpus> https://developer.github.com/v3/repos/releases/#upload-a-release-asset 01:10 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Ping timeout: 240 seconds] 01:12 -!- alreadylate [~textual@37-247-1-218.customers.ownit.se] has joined #bitcoin-core-dev 01:27 < achow101> arowser: https://github.com/achow101/bitcoin/releases/tag/v0.14.2 01:32 -!- promag [~Adium@30.1.54.77.rev.vodafone.pt] has quit [Quit: Leaving.] 01:39 -!- Victor_sueca is now known as Victorsueca 01:42 -!- alreadylate [~textual@37-247-1-218.customers.ownit.se] has quit [] 01:43 -!- waveprop [~user@unaffiliated/os-18137] has quit [Ping timeout: 240 seconds] 01:44 -!- waveprop [~user@64.72.212.39] has joined #bitcoin-core-dev 01:51 < arowser> achow101: thank you, downloading... 02:02 < arowser> wumus: its not easy to me if not use gitian-builder, and my gitian-builder is broker now :( 02:04 -!- jtimon [~quassel@143.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 02:15 < jonasschnelli> arowser, achow101, wumpus: would those *-debug.tar.gz files do the job: https://bitcoin.jonasschnelli.ch/build/177 02:15 < jonasschnelli> (its 0.14.1) 02:15 < jonasschnelli> (its 0.14.2) 02:23 -!- moriarty [~sjkd@unaffiliated/moriarty] has left #bitcoin-core-dev [] 02:27 -!- waveprop [~user@64.72.212.39] has quit [Ping timeout: 240 seconds] 02:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:43 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev 02:59 < wumpus> arowser: I meant it's easy for me, and I'd have built them if achow101 and jonasschnelli hadn't jump in 03:00 < wumpus> jonasschnelli: yes 03:06 -!- waveprop [~user@64.72.212.39] has joined #bitcoin-core-dev 03:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 03:25 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:33 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 03:35 -!- JackH [~laptop@79-73-189-225.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev 03:36 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 240 seconds] 03:39 -!- shesek [~shesek@bzq-84-110-177-132.red.bezeqint.net] has joined #bitcoin-core-dev 03:49 -!- shesek [~shesek@bzq-84-110-177-132.red.bezeqint.net] has quit [Ping timeout: 276 seconds] 03:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 03:56 -!- niska [~niska@68.ip-149-56-14.net] has quit [Quit: Leaving] 04:22 -!- shesek [~shesek@bzq-109-64-4-214.red.bezeqint.net] has joined #bitcoin-core-dev 04:22 -!- shesek [~shesek@bzq-109-64-4-214.red.bezeqint.net] has quit [Changing host] 04:22 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 04:26 -!- jtimon [~quassel@143.29.134.37.dynamic.jazztel.es] has quit [Remote host closed the connection] 04:26 -!- niska [~niska@68.ip-149-56-14.net] has joined #bitcoin-core-dev 04:37 -!- promag [~Adium@30.1.54.77.rev.vodafone.pt] has joined #bitcoin-core-dev 04:42 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection] 05:02 -!- paveljanik [~paveljani@79.98.72.176] has joined #bitcoin-core-dev 05:02 -!- paveljanik [~paveljani@79.98.72.176] has quit [Changing host] 05:02 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 05:02 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Client Quit] 05:05 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection] 05:05 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Read error: Connection reset by peer] 05:05 -!- sam_c [~sam_c@gateway/tor-sasl/stanley] has quit [Remote host closed the connection] 05:05 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Write error: Connection reset by peer] 05:05 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Write error: Connection reset by peer] 05:06 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev 05:07 -!- promag [~Adium@30.1.54.77.rev.vodafone.pt] has quit [Quit: Leaving.] 05:09 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 05:10 -!- sam_c [~sam_c@gateway/tor-sasl/stanley] has joined #bitcoin-core-dev 05:19 -!- Giszmo [~leo@ip-109-84-2-146.web.vodafone.de] has joined #bitcoin-core-dev 05:21 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 05:39 -!- ekerstein [~ekerstein@ip-64-134-180-44.public.wayport.net] has joined #bitcoin-core-dev 06:05 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 06:06 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #bitcoin-core-dev 06:07 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 06:12 -!- promag [~Adium@30.1.54.77.rev.vodafone.pt] has joined #bitcoin-core-dev 06:18 -!- ula [~kvirc@b2b-78-94-11-194.unitymedia.biz] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/] 06:25 -!- Giszmo [~leo@ip-109-84-2-146.web.vodafone.de] has quit [Ping timeout: 276 seconds] 06:36 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Ping timeout: 276 seconds] 06:36 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 268 seconds] 06:38 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev 06:39 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 06:48 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection] 06:48 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev 06:50 -!- atroxes [~atroxes@unaffiliated/atroxes] has quit [Quit: bye] 06:51 -!- atroxes [~atroxes@unaffiliated/atroxes] has joined #bitcoin-core-dev 06:56 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 06:59 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 07:18 -!- HellOrHighWater is now known as owowo 07:27 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 07:28 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 07:32 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 260 seconds] 07:45 -!- juscamarena_ [~justin@47.148.173.164] has joined #bitcoin-core-dev 07:45 -!- miknotauro [~miknotaur@c-67-185-35-159.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 07:45 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 07:45 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 08:01 -!- ekerstein [~ekerstein@ip-64-134-180-44.public.wayport.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 08:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 08:15 < promag> MarcoFalke: is nc something we could use in tests? 08:15 < MarcoFalke> Sorry, what is nc? 08:15 < promag> netcat 08:16 < MarcoFalke> The tests should run on windows as well, so I don't think this would be possible 08:16 < promag> right 08:17 < promag> the idea is to avoid files, have the blocknotify script write to a socket, then read it from python 08:17 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Quit: Lost terminal] 08:17 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 08:21 < MarcoFalke> oh wait. I am sure blocknotify.py is unlikely to pass on native windows, due to echo. 08:21 < MarcoFalke> So my objection is invalid 08:25 < MarcoFalke> Though, I am not convinced this warrants the extra dependency. It should be doable with just files. 08:29 < promag> we can also ship util scripts to be used in these tests? 08:34 < MarcoFalke> There should be no "loose" scripts hanging around. You can extend ./test_framework/util.py with helper functions. 08:37 -!- marcoagner [~user@187.113.134.150] has quit [Ping timeout: 240 seconds] 08:37 < promag> right 08:42 -!- treebeardd [~treebeard@73.109.61.9] has joined #bitcoin-core-dev 08:47 < bitcoin-git> [bitcoin] laanwj opened pull request #11053: refactor: Make all #includes relative to project root (master...2017_08_includes_absolute) https://github.com/bitcoin/bitcoin/pull/11053 08:48 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/140de14a1222...3841aaf05963 08:48 < bitcoin-git> bitcoin/master f4c3d2c Gregory Maxwell: Enable disablesafemode by default.... 08:48 < bitcoin-git> bitcoin/master 3841aaf Wladimir J. van der Laan: Merge #11008: Enable disablesafemode by default.... 08:49 < bitcoin-git> [bitcoin] laanwj closed pull request #11008: Enable disablesafemode by default. (master...no-safe-mode) https://github.com/bitcoin/bitcoin/pull/11008 08:50 -!- Giszmo [~leo@ip-109-84-2-146.web.vodafone.de] has joined #bitcoin-core-dev 08:51 -!- Austindoggie [~austindog@2600:380:4655:a45d:8448:6e2c:ad3f:ce86] has joined #bitcoin-core-dev 08:52 < MarcoFalke> ^ does this require mention in the release notes for 0.16? 08:56 < MarcoFalke> oh already listed: #11054 :) 08:56 < bitcoin-git> [bitcoin] jnewbery opened pull request #11055: getreceivedbyaddress should return error if called with address not owned by the wallet (master...getreceivedbyaddress_error) https://github.com/bitcoin/bitcoin/pull/11055 08:58 < gribble> https://github.com/bitcoin/bitcoin/issues/11054 | TODO for release notes 0.16.0 · Issue #11054 · bitcoin/bitcoin · GitHub 09:06 -!- pandabull [~pandabull@c-71-192-175-158.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 09:06 -!- pandabull [~pandabull@c-71-192-175-158.hsd1.ma.comcast.net] has quit [Client Quit] 09:09 -!- miknotauro [~miknotaur@c-67-185-35-159.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds] 09:11 -!- Giszmo [~leo@ip-109-84-2-146.web.vodafone.de] has quit [Quit: Leaving.] 09:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 09:31 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 255 seconds] 09:34 -!- promag [~Adium@30.1.54.77.rev.vodafone.pt] has quit [Read error: Connection reset by peer] 09:34 -!- promag [~Adium@30.1.54.77.rev.vodafone.pt] has joined #bitcoin-core-dev 09:39 < cfields> wumpus: i think #7522 broke version detection for gitian. v0.15.0rc1 binaries show -dirty :( 09:40 < cfields> imo that's no big deal for rc1. I'll try to track down the issue 09:40 < cfields> luke-jr: ^^ 09:41 < luke-jr> hmm 09:42 < cfields> luke-jr: i'm just assuming 7522 is what did it, as I can't think of what else might've changed in that regard 09:44 < gribble> https://github.com/bitcoin/bitcoin/issues/7522 | Bugfix: Only use git for build info if the repository is actually the right one by luke-jr · Pull Request #7522 · bitcoin/bitcoin · GitHub 09:49 -!- Austindoggie_ [~austindog@2601:647:ca80:1f82:ad80:26a3:bdbd:9569] has joined #bitcoin-core-dev 09:53 -!- Austindoggie [~austindog@2600:380:4655:a45d:8448:6e2c:ad3f:ce86] has quit [Ping timeout: 246 seconds] 09:58 -!- Giszmo [~leo@ip-109-84-2-146.web.vodafone.de] has joined #bitcoin-core-dev 10:08 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 10:17 -!- ekerstein [~ekerstein@ip-64-134-180-44.public.wayport.net] has joined #bitcoin-core-dev 10:17 -!- Austindoggie_ [~austindog@2601:647:ca80:1f82:ad80:26a3:bdbd:9569] has quit [Ping timeout: 240 seconds] 10:18 -!- RoyceX [~Cheeseo@unaffiliated/cheeseo] has quit [Read error: Connection reset by peer] 10:23 -!- Giszmo [~leo@ip-109-84-2-146.web.vodafone.de] has quit [Ping timeout: 240 seconds] 10:24 -!- Austindoggie_ [~austindog@96-64-238-65-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 10:29 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 10:29 < bitcoin-git> [bitcoin] instagibbs opened pull request #11056: disable jni in builds (master...disablejni) https://github.com/bitcoin/bitcoin/pull/11056 10:34 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 10:35 -!- Austindoggie_ [~austindog@96-64-238-65-static.hfc.comcastbusiness.net] has quit [Ping timeout: 276 seconds] 10:50 -!- sdaftuar [~sdaftuar@unaffiliated/sdaftuar] has quit [Quit: leaving] 10:50 -!- Giszmo [~leo@net-37-119-118-244.cust.vodafonedsl.it] has joined #bitcoin-core-dev 10:54 < cfields> luke-jr: will you kill me if i suggest simply reverting 7522? the fixes that i see require moving several things around 10:56 -!- waveprop [~user@64.72.212.39] has quit [Changing host] 10:56 -!- waveprop [~user@unaffiliated/os-18137] has joined #bitcoin-core-dev 11:09 < instagibbs> could someone give 11049 a kick 11:13 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 11:13 -!- treebeardd [~treebeard@73.109.61.9] has quit [Remote host closed the connection] 11:22 < jonasschnelli> instagibbs: done 11:28 -!- jimpo [~jimpo@ec2-54-175-255-176.compute-1.amazonaws.com] has joined #bitcoin-core-dev 11:33 -!- miknotauro [~miknotaur@71.4.37.2.ptr.us.xo.net] has joined #bitcoin-core-dev 11:43 -!- sdaftuar [~sdaftuar@unaffiliated/sdaftuar] has joined #bitcoin-core-dev 11:45 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3841aaf05963...64e66bb26288 11:45 < bitcoin-git> bitcoin/master d3d946a practicalswift: Pass SendCoinsRecipient (208 bytes) by const reference 11:45 < bitcoin-git> bitcoin/master 64e66bb Jonas Schnelli: Merge #10964: Pass SendCoinsRecipient (208 bytes) by reference... 11:45 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #10964: Pass SendCoinsRecipient (208 bytes) by reference (master...pass-big-parameters-by-reference) https://github.com/bitcoin/bitcoin/pull/10964 11:55 < jonasschnelli> Just catching up the last 1 week on mainnet with 0.15.0rc1 and the GUI is very responsive... 12:01 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 12:03 -!- jouke [~worst@2001:1c02:1600:9200:e4fa:2347:bf38:2c3a] has joined #bitcoin-core-dev 12:03 -!- jouke [~worst@2001:1c02:1600:9200:e4fa:2347:bf38:2c3a] has quit [Changing host] 12:03 -!- jouke [~worst@unaffiliated/komkommer] has joined #bitcoin-core-dev 12:03 -!- parazyd [~parazyd@2a03:b0c0:2:d0::f7:f001] has joined #bitcoin-core-dev 12:03 -!- parazyd [~parazyd@2a03:b0c0:2:d0::f7:f001] has quit [Changing host] 12:03 -!- parazyd [~parazyd@unaffiliated/parazyd] has joined #bitcoin-core-dev 12:03 -!- cfields_ [~quassel@2001:4802:7800:2:be76:4eff:fe20:5aaa] has joined #bitcoin-core-dev 12:03 -!- cfields_ [~quassel@2001:4802:7800:2:be76:4eff:fe20:5aaa] has quit [Changing host] 12:03 -!- cfields_ [~quassel@unaffiliated/cfields] has joined #bitcoin-core-dev 12:03 -!- shesek [~shesek@109.64.4.214] has joined #bitcoin-core-dev 12:04 -!- Netsplit over, joins: promag, niska, unholymachine, JackH, Deacyde 12:04 -!- Netsplit over, joins: PaulCapestany 12:17 < cfields_> gitian builders: v0.15.0rc1 detached sigs have been pushed 12:28 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds] 12:31 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/64e66bb26288...ae47724687a7 12:31 < bitcoin-git> bitcoin/master 03bc719 Karl-Johan Alm: [wallet] Close DB on error. 12:31 < bitcoin-git> bitcoin/master ae47724 Jonas Schnelli: Merge #11017: [wallet] Close DB on error.... 12:32 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #11017: [wallet] Close DB on error. (master...close-dbenv) https://github.com/bitcoin/bitcoin/pull/11017 12:33 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 12:34 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #10989: RPC: Restore backward compatibility, in multiwallet mode (master...multiwallet_rpccompat) https://github.com/bitcoin/bitcoin/pull/10989 12:38 -!- ekerstein [~ekerstein@ip-64-134-180-44.public.wayport.net] has quit [Ping timeout: 246 seconds] 12:38 -!- ekerstein [~ekerstein@ip-64-134-180-44.public.wayport.net] has joined #bitcoin-core-dev 12:49 -!- miknotauro [~miknotaur@71.4.37.2.ptr.us.xo.net] has quit [Ping timeout: 260 seconds] 12:52 -!- miknotauro [~miknotaur@71.4.37.2.ptr.us.xo.net] has joined #bitcoin-core-dev 12:52 -!- Austindoggie_ [~austindog@2600:380:4655:a45d:d153:6ff9:a71a:9cf] has joined #bitcoin-core-dev 12:58 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection] 12:58 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 13:04 < luke-jr> cfields_: 7522 is a bug fix. it should not be reverted. 13:04 < luke-jr> unless you have a better fix, I guess. 13:09 < cfields_> luke-jr: suggestions for fixing the issue, then? Setting GIT_DIR in the gitian script throws off 'git diff' in a way that i don't really understand 13:10 < luke-jr> probably the best way, would be to have the tarball-source build with the version we want, and don't rely on git at all 13:10 < luke-jr> maybe that's already the case, and we should just drop GIT_DIR? 13:11 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds] 13:11 < cfields_> luke-jr: agreed, but i think it's too late for those types of changes for 0.15 13:12 < luke-jr> what happens if we just drop GIT_DIR right now? 13:12 < cfields_> pretty sure it ends up with unknown version 13:12 < luke-jr> :/ 13:13 < luke-jr> does that mean building from the source tarball is similarly broken? 13:13 -!- shesek [~shesek@109.64.4.214] has quit [Ping timeout: 255 seconds] 13:13 < cfields_> hmm, probably 13:14 < cfields_> checking 13:15 -!- praxeology1 [~praxeolog@cpe-76-187-72-181.tx.res.rr.com] has joined #bitcoin-core-dev 13:16 -!- praxeology2 [~praxeolog@cpe-76-187-72-181.tx.res.rr.com] has joined #bitcoin-core-dev 13:18 -!- praxeology [~praxeolog@unaffiliated/praxeology] has quit [Ping timeout: 240 seconds] 13:19 -!- Giszmo [~leo@net-37-119-118-244.cust.vodafonedsl.it] has quit [Quit: Leaving.] 13:20 -!- praxeology1 [~praxeolog@cpe-76-187-72-181.tx.res.rr.com] has quit [Ping timeout: 240 seconds] 13:20 < cfields_> "Bitcoin Core Daemon version v0.15.0.0-g252ca9c" 13:20 -!- Austindoggie_ [~austindog@2600:380:4655:a45d:d153:6ff9:a71a:9cf] has quit [Ping timeout: 276 seconds] 13:20 -!- Austindoggie_ [~austindog@96-64-238-65-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 13:21 < luke-jr> I guess that's what we want? 13:22 < cfields_> well the tag would be ideal, but i don't think it's different from before 13:23 < cfields_> what's broken is the tag detection when building from git because the work-tree check now fails 13:23 < luke-jr> IMO we should have it so the result is the same as building from the source tarball, and if that isn't what is ideal, we should fix that so it is ;) 13:24 < cfields_> er, that's not right. I think that works, but 'git diff' thinks there are extra files dirtying things up 13:24 < luke-jr> the work-tree check *should* fail in gitian, since gitian doesn't build from git 13:24 -!- Giszmo [~leo@net-37-119-118-244.cust.vodafonedsl.it] has joined #bitcoin-core-dev 13:24 < cfields_> it builds from a workdir that's part of the git tree 13:25 < luke-jr> it's not part of the git tree.. 13:25 < luke-jr> it just happens to be in a directory below the git tree's root 13:25 < cfields_> it builds in a subdir of the repo 13:25 < cfields_> right 13:25 < cfields_> sorry, work-tree has a specific meaning in this discussion :) 13:26 < luke-jr> one that isn't met by what we're doing there ;) 13:27 < cfields_> yea, we need to change the gitian layout and embed the version into the tarball. But I'd really not do all that at this stage 13:28 < luke-jr> "v0.15.0.0-g252ca9c" seems fine until we do? 13:28 -!- miknotauro [~miknotaur@71.4.37.2.ptr.us.xo.net] has quit [Ping timeout: 260 seconds] 13:29 -!- Giszmo [~leo@net-37-119-118-244.cust.vodafonedsl.it] has quit [Ping timeout: 260 seconds] 13:29 < cfields_> luke-jr: it's what shows on the splash screen. All other stable versions have had the correct (tag) string. 13:33 < luke-jr> a simple hacky workaround would be to have gitian make a build.h file 13:44 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 13:45 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 13:51 -!- shesek [~shesek@bzq-84-110-177-132.cablep.bezeqint.net] has joined #bitcoin-core-dev 13:53 -!- shesek [~shesek@bzq-84-110-177-132.cablep.bezeqint.net] has quit [Changing host] 13:53 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 13:59 -!- marcoagner [~user@187.113.128.120] has joined #bitcoin-core-dev 13:59 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Ping timeout: 240 seconds] 14:09 -!- ekerstein [~ekerstein@ip-64-134-180-44.public.wayport.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 14:23 -!- treebeardd [~treebeard@73.109.63.86] has joined #bitcoin-core-dev 14:30 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds] 14:37 -!- miknotauro [~miknotaur@71.4.37.2.ptr.us.xo.net] has joined #bitcoin-core-dev 14:38 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ae47724687a7...85aec87b11ec 14:38 < bitcoin-git> bitcoin/master 7897338 John Newbery: [tests] Introduce TestNode... 14:38 < bitcoin-git> bitcoin/master 85aec87 MarcoFalke: Merge #10711: [tests] Introduce TestNode... 14:38 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #10711: [tests] Introduce TestNode (master...testnode2) https://github.com/bitcoin/bitcoin/pull/10711 15:08 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Quit: conversation terminated!] 15:13 -!- praxeology2 [~praxeolog@cpe-76-187-72-181.tx.res.rr.com] has quit [Quit: Leaving.] 15:13 -!- rjak [~rjak@gateway/vpn/privateinternetaccess/rjak] has quit [Disconnected by services] 15:13 -!- rjak2 [~rjak@gateway/vpn/privateinternetaccess/rjak] has joined #bitcoin-core-dev 15:13 -!- rjak2 is now known as rjak 15:14 -!- unholymachine [~quassel@2601:8c:c003:9f16:c9be:5618:ae6f:5485] has quit [Ping timeout: 240 seconds] 15:14 -!- unholymachine [~quassel@2601:8c:c003:9f16:c9be:5618:ae6f:5485] has joined #bitcoin-core-dev 15:14 -!- miknotauro [~miknotaur@71.4.37.2.ptr.us.xo.net] has quit [Ping timeout: 260 seconds] 15:16 -!- treebear_ [~treebeard@73.109.63.86] has joined #bitcoin-core-dev 15:19 -!- treebeardd [~treebeard@73.109.63.86] has quit [Quit: Leaving...] 15:19 -!- Deacydal [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 15:20 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has quit [Ping timeout: 240 seconds] 15:22 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 15:29 -!- vicenteH [~user@13.232.15.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds] 15:31 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 15:33 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/85aec87b11ec...d7be7b39fa10 15:33 < bitcoin-git> bitcoin/master f42fc1d klemens: doc: spelling fixes 15:33 < bitcoin-git> bitcoin/master d7be7b3 MarcoFalke: Merge #10705: Trivial: spelling fixes... 15:33 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #10705: Trivial: spelling fixes (master...feature/spelling) https://github.com/bitcoin/bitcoin/pull/10705 15:40 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d7be7b39fa10...4fb258666147 15:40 < bitcoin-git> bitcoin/master 9d5e98f practicalswift: Fix typos. 15:40 < bitcoin-git> bitcoin/master 4fb2586 MarcoFalke: Merge #10956: Fix typos... 15:41 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #10956: Fix typos (master...typos-201708) https://github.com/bitcoin/bitcoin/pull/10956 15:42 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 15:50 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/4fb258666147...636694127534 15:50 < bitcoin-git> bitcoin/master 41f3e84 MeshCollider: Fix inconsistencies and grammar in various files 15:50 < bitcoin-git> bitcoin/master 1d8df01 MeshCollider: Fix MD formatting in REST-interface.md and spelling mistake in... 15:50 < bitcoin-git> bitcoin/master 6366941 MarcoFalke: Merge #10680: Fix inconsistencies and grammar in various files... 15:50 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #10680: Fix inconsistencies and grammar in various files (master...fix_typos_and_inconsistencies) https://github.com/bitcoin/bitcoin/pull/10680 16:05 -!- btcdave [4387940c@gateway/web/freenode/ip.67.135.148.12] has joined #bitcoin-core-dev 16:10 -!- promag [~Adium@30.1.54.77.rev.vodafone.pt] has quit [Quit: Leaving.] 16:27 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 248 seconds] 16:32 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/636694127534...7db65c363a0c 16:32 < bitcoin-git> bitcoin/master 08f71c2 Gregory Maxwell: [Trivial] Add a comment on the use of prevector in script. 16:32 < bitcoin-git> bitcoin/master 7db65c3 MarcoFalke: Merge #11011: [Trivial] Add a comment on the use of prevector in script.... 16:32 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #11011: [Trivial] Add a comment on the use of prevector in script. (master...201708-prevector-comment) https://github.com/bitcoin/bitcoin/pull/11011 16:34 -!- btcdave [4387940c@gateway/web/freenode/ip.67.135.148.12] has quit [Quit: Page closed] 16:42 -!- jimpo [~jimpo@ec2-54-175-255-176.compute-1.amazonaws.com] has quit [Ping timeout: 240 seconds] 16:58 -!- jimpo [~jimpo@ec2-54-175-255-176.compute-1.amazonaws.com] has joined #bitcoin-core-dev 17:10 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 17:11 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 17:13 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7db65c363a0c...b6a48914c506 17:13 < bitcoin-git> bitcoin/master 6e8c48d practicalswift: Add const to methods that do not modify the object for which it is called 17:13 < bitcoin-git> bitcoin/master b6a4891 MarcoFalke: Merge #9964: Add const to methods that do not modify the object for which it is called... 17:13 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #9964: Add const to methods that do not modify the object for which it is called (master...const) https://github.com/bitcoin/bitcoin/pull/9964 17:17 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 17:20 -!- Austindoggie_ [~austindog@96-64-238-65-static.hfc.comcastbusiness.net] has quit [Quit: AndroIRC - Android IRC Client ( http://www.androirc.com )] 17:20 < gmaxwell> 0.15 branch has a warning now 17:20 < gmaxwell> wallet/wallet.cpp:3668:38: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] 17:20 < gmaxwell> return setExternalKeyPool.size() >= min_keys && (setInternalKeyPool.size() >= min_keys || !CanSupportFeature(FEATURE_HD_SPLIT)); 17:21 < gmaxwell> ^ 17:21 < gmaxwell> wallet/wallet.cpp:3668:80: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] 17:21 < gmaxwell> return setExternalKeyPool.size() >= min_keys && (setInternalKeyPool.size() >= min_keys || !CanSupportFeature(FEATURE_HD_SPLIT)); 17:24 < BlueMatt> well we're gonna do an rc2 anyway, for the version issue, right? 17:27 < Lightsword> has anyone verified that getentropy is getting built for release builds on osx? 17:32 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b6a48914c506...655970d9c60a 17:32 < bitcoin-git> bitcoin/master 9862550 practicalswift: Use the noexcept specifier (C++11) instead of deprecated throw() 17:32 < bitcoin-git> bitcoin/master 655970d MarcoFalke: Merge #10965: Replace deprecated throw() with noexcept specifier (C++11)... 17:33 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #10965: Replace deprecated throw() with noexcept specifier (C++11) (master...noexcept) https://github.com/bitcoin/bitcoin/pull/10965 17:34 < jimpo> Is it preferred to have function/method comments in the header files or cpp files? (I would think header?) 17:34 < sipa> yes, header 17:35 < sipa> unless they're implementation details 17:36 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 17:37 < gmaxwell> jimpo: header should comment the interface, cpp the implementation, generally. (I don't think we've documented it in our coding style docs, but it's my preference) 17:37 < jimpo> Understood, thx 17:46 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 17:47 -!- RoyceX [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 17:48 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Ping timeout: 240 seconds] 17:48 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/655970d9c60a...a46a671e2535 17:48 < bitcoin-git> bitcoin/master 3eb53b8 practicalswift: Avoid returning a BIP9Stats object with uninitialized values... 17:48 < bitcoin-git> bitcoin/master a46a671 MarcoFalke: Merge #10957: Avoid returning a BIP9Stats object with uninitialized values... 17:49 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #10957: Avoid returning a BIP9Stats object with uninitialized values (master...bip9status) https://github.com/bitcoin/bitcoin/pull/10957 17:50 -!- Deacydal [~Deacyde@unaffiliated/deacyde] has quit [Read error: Connection reset by peer] 17:51 -!- Deacydal [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 17:52 -!- Cheeseo [~Cheeseo@unaffiliated/cheeseo] has joined #bitcoin-core-dev 17:55 -!- RoyceX [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Ping timeout: 240 seconds] 18:08 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev 18:15 -!- twistedline [~quassel@unaffiliated/twistedline] has quit [Ping timeout: 240 seconds] 18:15 -!- twistedline [~quassel@unaffiliated/twistedline] has joined #bitcoin-core-dev 18:20 -!- Cheeseo [~Cheeseo@unaffiliated/cheeseo] has quit [Read error: Connection reset by peer] 18:25 < bitcoin-git> [bitcoin] jimpo opened pull request #11058: Comments: More comments on functions/globals in standard.h. (master...standard-comments) https://github.com/bitcoin/bitcoin/pull/11058 18:32 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Read error: No route to host] 18:32 -!- jimpo [~jimpo@ec2-54-175-255-176.compute-1.amazonaws.com] has quit [Ping timeout: 240 seconds] 18:32 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev 18:40 -!- jtimon [~quassel@143.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 18:41 -!- trippysalmon [~trippysal@cyberdynesys.org] has quit [Ping timeout: 248 seconds] 18:52 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds] 18:54 -!- trippysalmon [~trippysal@cyberdynesys.org] has joined #bitcoin-core-dev 19:03 -!- jimpo [~jimpo@ec2-54-175-255-176.compute-1.amazonaws.com] has joined #bitcoin-core-dev 19:05 -!- Austindoggie [~austindog@2600:380:4655:a45d:1888:3df6:8680:1dbf] has joined #bitcoin-core-dev 19:13 -!- jtimon [~quassel@143.29.134.37.dynamic.jazztel.es] has quit [Ping timeout: 260 seconds] 19:15 < bitcoin-git> [bitcoin] Ilikenumber0 opened pull request #11059: Its just for education, not a real pull request (master...master) https://github.com/bitcoin/bitcoin/pull/11059 19:17 < bitcoin-git> [bitcoin] sipa closed pull request #11059: Its just for education, not a real pull request (master...master) https://github.com/bitcoin/bitcoin/pull/11059 19:25 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Ping timeout: 240 seconds] 19:59 -!- Deacyded [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 20:02 -!- Deacydal [~Deacyde@unaffiliated/deacyde] has quit [Ping timeout: 246 seconds] 20:08 -!- jimpo [~jimpo@ec2-54-175-255-176.compute-1.amazonaws.com] has quit [Ping timeout: 246 seconds] 20:10 -!- Austindoggie_ [~austindog@2601:647:ca80:1f82:ad80:26a3:bdbd:9569] has joined #bitcoin-core-dev 20:14 -!- Austindoggie [~austindog@2600:380:4655:a45d:1888:3df6:8680:1dbf] has quit [Ping timeout: 246 seconds] 20:29 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 20:45 -!- jimpo [~jimpo@ec2-54-175-255-176.compute-1.amazonaws.com] has joined #bitcoin-core-dev 20:57 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds] 21:00 -!- jimpo [~jimpo@ec2-54-175-255-176.compute-1.amazonaws.com] has quit [Ping timeout: 260 seconds] 21:02 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 21:03 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 21:04 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 21:05 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 21:09 -!- jimpo [~jimpo@ec2-54-175-255-176.compute-1.amazonaws.com] has joined #bitcoin-core-dev 21:17 -!- jimpo [~jimpo@ec2-54-175-255-176.compute-1.amazonaws.com] has quit [Ping timeout: 260 seconds] 21:30 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 276 seconds] 21:59 -!- Deacydal [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 22:03 -!- Deacyded [~Deacyde@unaffiliated/deacyde] has quit [Ping timeout: 276 seconds] 22:08 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 22:09 -!- miknotauro [~miknotaur@c-67-185-35-159.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 22:16 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 22:17 -!- treebear_ [~treebeard@73.109.63.86] has quit [Remote host closed the connection] 22:22 -!- jimpo [~jimpo@ec2-54-175-255-176.compute-1.amazonaws.com] has joined #bitcoin-core-dev 22:26 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 22:30 -!- treebeardd [~treebeard@73.109.60.183] has joined #bitcoin-core-dev 22:41 -!- elkalamar [~elkalamar@unaffiliated/elkalamar] has quit [Ping timeout: 246 seconds] 22:51 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Ping timeout: 240 seconds] 22:56 -!- Deacyded [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 22:58 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 23:00 -!- Deacydal [~Deacyde@unaffiliated/deacyde] has quit [Ping timeout: 246 seconds] 23:11 -!- Deacydal [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 23:15 -!- Deacyded [~Deacyde@unaffiliated/deacyde] has quit [Ping timeout: 246 seconds] 23:22 < wumpus> cfields_: as long as it is deterministic, it is no big deal 23:30 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a46a671e2535...d451d0bcf15d 23:30 < bitcoin-git> bitcoin/master 844b73e Gregory Sanders: disable jni in builds 23:30 < bitcoin-git> bitcoin/master d451d0b Wladimir J. van der Laan: Merge #11056: disable jni in builds... 23:31 < bitcoin-git> [bitcoin] laanwj closed pull request #11056: disable jni in builds (master...disablejni) https://github.com/bitcoin/bitcoin/pull/11056 23:40 -!- jimpo [~jimpo@ec2-54-175-255-176.compute-1.amazonaws.com] has quit [Ping timeout: 240 seconds] 23:57 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 23:58 -!- klebs [~klebs@65.sub-70-197-15.myvzw.com] has joined #bitcoin-core-dev