--- Day changed Wed Aug 30 2017 00:13 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-bxexwwpahnzmonln] has joined #bitcoin-core-dev 00:13 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:13 -!- shesek [~shesek@bzq-84-110-234-120.red.bezeqint.net] has joined #bitcoin-core-dev 00:14 -!- EmreSokullu [~emresokul@78.180.126.218] has quit [Remote host closed the connection] 00:26 -!- goatpig [56f75436@gateway/web/freenode/ip.86.247.84.54] has quit [Quit: Page closed] 00:27 -!- goatpig [56f75436@gateway/web/freenode/ip.86.247.84.54] has joined #bitcoin-core-dev 00:30 -!- treebeardd [~treebeard@2001:558:600a:c8:c0a:3125:2083:ad3b] has joined #bitcoin-core-dev 00:34 -!- treebeardd [~treebeard@2001:558:600a:c8:c0a:3125:2083:ad3b] has quit [Ping timeout: 240 seconds] 00:59 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:00 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 01:11 -!- treebeardd [~treebeard@2001:558:600a:c8:c0a:3125:2083:ad3b] has joined #bitcoin-core-dev 01:15 -!- treebeardd [~treebeard@2001:558:600a:c8:c0a:3125:2083:ad3b] has quit [Ping timeout: 246 seconds] 01:17 -!- promag [~Adium@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:19 -!- JackH [~laptop@46.231.18.66] has joined #bitcoin-core-dev 01:27 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 240 seconds] 01:28 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:36 -!- wvr [~wvr@121.red-83-45-36.dynamicip.rima-tde.net] has quit [Quit: Leaving] 01:38 -!- Giszmo [~leo@pc-93-17-46-190.cm.vtr.net] has quit [Ping timeout: 240 seconds] 01:51 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 01:58 -!- mputter [~mputter@095-097-010-016.static.chello.nl] has joined #bitcoin-core-dev 02:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:19 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:21 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 252 seconds] 02:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 02:26 -!- vicenteH [~user@195.235.96.150] has joined #bitcoin-core-dev 02:28 -!- mkuser_ [c1c61a46@gateway/web/freenode/ip.193.198.26.70] has joined #bitcoin-core-dev 02:31 -!- treebeardd [~treebeard@2001:558:600a:c8:c0a:3125:2083:ad3b] has joined #bitcoin-core-dev 02:35 -!- treebeardd [~treebeard@2001:558:600a:c8:c0a:3125:2083:ad3b] has quit [Ping timeout: 246 seconds] 02:55 -!- mkuser_ [c1c61a46@gateway/web/freenode/ip.193.198.26.70] has quit [Quit: Page closed] 03:01 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 03:07 -!- stvn [7a3d81b4@gateway/web/freenode/ip.122.61.129.180] has joined #bitcoin-core-dev 03:10 -!- riemann [~riemann@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 03:11 -!- promag [~Adium@bl6-24-70.dsl.telepac.pt] has quit [Quit: Leaving.] 03:13 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 03:28 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #bitcoin-core-dev 03:28 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 03:37 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 03:57 -!- Vortiago [~Vortiago@2a01:7e01::f03c:91ff:fe3e:ccaf] has joined #bitcoin-core-dev 03:59 -!- shesek [~shesek@bzq-84-110-234-120.red.bezeqint.net] has quit [Changing host] 03:59 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 04:05 -!- riemann [~riemann@84-10-11-234.static.chello.pl] has quit [Ping timeout: 246 seconds] 04:19 -!- riemann [~riemann@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 04:21 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:23 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 04:33 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 04:35 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 04:38 -!- str4d [~str4d@host86-137-249-179.range86-137.btcentralplus.com] has joined #bitcoin-core-dev 04:44 -!- str4d [~str4d@host86-137-249-179.range86-137.btcentralplus.com] has quit [Ping timeout: 255 seconds] 04:53 -!- mputter [~mputter@095-097-010-016.static.chello.nl] has quit [Quit: Leaving] 05:06 -!- echonaut [~echonaut@46.101.192.134] has joined #bitcoin-core-dev 05:07 -!- harding_ [~harding@mail.dtrt.org] has joined #bitcoin-core-dev 05:07 -!- JeremyRu1in [~jlrubin@biohazard-cafe.mit.edu] has joined #bitcoin-core-dev 05:08 -!- Netsplit over, joins: earlz, Orion3k, rafalcpp 05:09 -!- Netsplit over, joins: niska 05:09 -!- alxlu [~alxlu@138.68.58.104] has quit [Ping timeout: 240 seconds] 05:10 -!- eck [~tGysJVzRq@151.56.197.35.bc.googleusercontent.com] has joined #bitcoin-core-dev 05:11 -!- Netsplit over, joins: jimpo, warren 05:12 -!- alxlu [~alxlu@138.68.58.104] has joined #bitcoin-core-dev 05:15 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection] 05:19 -!- Ruben [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 05:22 -!- Ruben is now known as 18VAB2TS5 05:22 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev 05:22 -!- gwollon [~gwillen@50.116.8.236] has joined #bitcoin-core-dev 05:22 -!- gmaxwell_ [~gmaxwell@140.211.15.28] has joined #bitcoin-core-dev 05:22 -!- unholymachine [~quassel@2601:8c:c003:9f16:b5c2:f701:9fb:1fb2] has joined #bitcoin-core-dev 05:22 -!- xHire [~xHire@kos.paskuli.cz] has joined #bitcoin-core-dev 05:22 -!- jl2012 [uid133844@gateway/web/irccloud.com/x-isdnvleermcqsayi] has joined #bitcoin-core-dev 05:22 -!- rodarmor [sid210835@gateway/web/irccloud.com/x-yxwsgkfrsforhuoq] has joined #bitcoin-core-dev 05:22 -!- trotski2000 [sid206086@gateway/web/irccloud.com/x-sbdvzrsnnukgcezr] has joined #bitcoin-core-dev 05:22 -!- profall [sid29922@gateway/web/irccloud.com/x-evibrxbziktyptcy] has joined #bitcoin-core-dev 05:22 -!- pindarhk_ [sid105966@gateway/web/irccloud.com/x-ulmouitfuooqhasz] has joined #bitcoin-core-dev 05:22 -!- rodarmor [sid210835@gateway/web/irccloud.com/x-yxwsgkfrsforhuoq] has quit [Max SendQ exceeded] 05:22 -!- profall [sid29922@gateway/web/irccloud.com/x-evibrxbziktyptcy] has quit [Max SendQ exceeded] 05:22 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 255 seconds] 05:23 -!- profall [sid29922@gateway/web/irccloud.com/x-aqtavypxyzwdxppn] has joined #bitcoin-core-dev 05:23 -!- rodarmor [sid210835@gateway/web/irccloud.com/x-krbiciduxrqbtnnc] has joined #bitcoin-core-dev 05:24 -!- warren [~warren@fedora/wombat/warren] has quit [Ping timeout: 260 seconds] 05:26 -!- warren [~warren@fedora/wombat/warren] has joined #bitcoin-core-dev 05:30 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 05:35 < morcos> instagibbs: I don't like you're new risky send addition to the corefeebot 05:35 < morcos> that is never something we would add to Bitcoin Core without a whole lot of complication to determine that that is a fee rate that would have legitimately been selected for the last block 05:36 < morcos> it could easily have been paid for out of band 05:36 < morcos> also accounting for packages correctly is not trivial, have you done that 05:37 < morcos> we shouldn't be using random ideas tweeted out to drive good practices in fee estimation. it should be the other way around 05:38 < morcos> if it's a good idea that survives rigorous peer review we should implement it in a Bitcoin Core tool or bitcoind and then we can tweet out the result 05:38 -!- bitsegwit [~seggggwit@c-217-115-42-58.cust.bredband2.com] has joined #bitcoin-core-dev 05:38 < instagibbs> morcos, ok, how about "don't use this, just for my info" 05:38 < bitsegwit> risky send with (USE RBF HERE) dialog would be fine imo 05:38 < instagibbs> Or maybe I'll do another account that just is named DANGER and tweets that 05:39 < instagibbs> I'm not going to not tweet the info, but up for any disclaimer :) 05:44 < instagibbs> removed for now, will workshop it :) 05:48 -!- echonaut3 [~echonaut@46.101.192.134] has joined #bitcoin-core-dev 05:48 -!- echonaut [~echonaut@46.101.192.134] has quit [Remote host closed the connection] 05:49 < instagibbs> I do admit that the account name would cross some wires if it started tweeting out risky info, I appreciate the feedback 05:51 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving] 05:55 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 240 seconds] 05:56 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 05:56 -!- paulcollister [~paulcolli@host-78-147-41-65.as13285.net] has joined #bitcoin-core-dev 06:06 < morcos> instagibbs: yeah thanks, i'm fine with you tweeting whatever you want obviously, just not from Bitcoin Core Fee Bot. Sounds official. 06:06 -!- Gunnie [~kamk@2.82.cust.tetanet.cz] has quit [Quit: My computer has gone to sleep. ZZZzzz…] 06:06 < morcos> and its not that i don't think that is a potentially useful piece of info, but i think it should be reviewed carefully before we do it as a project 06:10 < morcos> luke-jr: question about your node counter: http://luke.dashjr.org/programs/bitcoin/files/charts/software.html 06:11 < morcos> i assume that's lumping btc1 nodes into Bitcoin Core? What do you think about dividing that up. 06:11 < morcos> I think its super useful to show that of people who bother to run full nodes, such a very small percentage are going to be on this supposed Nov fork 06:15 < instagibbs> morcos, what's the best way of getting package feerate for a particular tx? Looking at some summary statistics for block template could be nice 06:16 < morcos> instagibbs: it's complicated. you have to basically run the whole mining algorithm over again to see what parts of its package were already included due to their own fee rate. 06:16 < morcos> and then look at the fee rate of the remaining package 06:16 < morcos> take a look at the mining code, and then you'll probably be sad 06:17 < morcos> I do think something along these lines is interesting though, i have had branches for some time now that track what the highest fee rate transactions in your mempool are that were eligble for inclusion and weren't.. which is the flip side of the coin you are looking at. 06:18 < morcos> both pieces of information are useful 06:22 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-bxexwwpahnzmonln] has quit [Quit: Connection closed for inactivity] 06:31 -!- Giszmo [~leo@ip-240-233.219.201.nextelmovil.cl] has joined #bitcoin-core-dev 06:33 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:41 < sdaftuar> morcos: instagibbs: i think we could easily add "last package feerate selected" to the set of things that CreateNewBlock spits out, eg to the debug log (or stash somewhere and return via rpc) 06:41 -!- goatpig [56f75436@gateway/web/freenode/ip.86.247.84.54] has quit [Quit: Page closed] 06:42 < sdaftuar> fyi an added bit of trickiness is at the end of a block, you might skip over higher feerate packages that don't fit, because the block is full, so it's not an easy value to reason about 06:44 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 06:46 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 240 seconds] 06:49 < luke-jr> morcos: yes, I should probably divide them out somehow 06:53 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 248 seconds] 06:56 < morcos> sdaftuar: yes, but that doesn't help the average full node that isn't running CNB 06:57 < sdaftuar> sure, but i thought it might be helpful to instagibbs' fee monitoring 06:58 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 07:01 -!- Gunnie [~kamk@2.82.cust.tetanet.cz] has joined #bitcoin-core-dev 07:04 -!- Yogaqueef [~textual@dsl-hkibng42-5673c3-32.dhcp.inet.fi] has joined #bitcoin-core-dev 07:06 -!- 18VAB2TS5 [~RubenSoms@1.217.138.142] has quit [Ping timeout: 260 seconds] 07:27 < MarcoFalke> wumpus: Mind to add the list of pulls in 0.15.0 to the release notes. I'd like to look over that before final. 07:31 -!- riemann [~riemann@84-10-11-234.static.chello.pl] has quit [Quit: Leaving] 07:50 -!- paulcollister [~paulcolli@host-78-147-41-65.as13285.net] has left #bitcoin-core-dev [] 08:00 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a90e6d2bffc4...d81dccf191a4 08:00 < bitcoin-git> bitcoin/master 49eb091 practicalswift: [tests] Avoid redundant assignments. Remove unused variables. 08:00 < bitcoin-git> bitcoin/master d81dccf MarcoFalke: Merge #10777: [tests] Avoid redundant assignments. Remove unused variables... 08:01 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #10777: [tests] Avoid redundant assignments. Remove unused variables (master...test-vars) https://github.com/bitcoin/bitcoin/pull/10777 08:10 -!- esotericnonsense [~esoteric@unaffiliated/esotericnonsense] has quit [Ping timeout: 248 seconds] 08:18 -!- Giszmo [~leo@ip-240-233.219.201.nextelmovil.cl] has quit [Read error: Connection reset by peer] 08:18 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 08:41 -!- Giszmo [~leo@pc-93-17-46-190.cm.vtr.net] has joined #bitcoin-core-dev 08:47 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 08:47 -!- vicenteH [~user@195.235.96.150] has quit [Ping timeout: 248 seconds] 08:50 -!- vicenteH [~user@195.235.96.150] has joined #bitcoin-core-dev 08:59 -!- sam_c [~sam_c@gateway/tor-sasl/stanley] has quit [Remote host closed the connection] 09:00 -!- sam_c [~sam_c@gateway/tor-sasl/stanley] has joined #bitcoin-core-dev 09:01 -!- Gunnie [~kamk@2.82.cust.tetanet.cz] has quit [Quit: My computer has gone to sleep. ZZZzzz…] 09:05 -!- sam_c [~sam_c@gateway/tor-sasl/stanley] has quit [Remote host closed the connection] 09:05 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 264 seconds] 09:06 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 09:06 -!- sam_c [~sam_c@gateway/tor-sasl/stanley] has joined #bitcoin-core-dev 09:19 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 09:24 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 09:25 -!- treebeardd [~treebeard@c-67-185-216-208.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 09:36 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 09:54 -!- Giszmo [~leo@pc-93-17-46-190.cm.vtr.net] has quit [Ping timeout: 248 seconds] 10:02 -!- jtimon [~quassel@199.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 10:03 -!- treebeardd [~treebeard@c-67-185-216-208.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 10:13 -!- Victor_sueca is now known as Victorsueca 10:14 -!- Giszmo [~leo@ip-190-233.219.201.nextelmovil.cl] has joined #bitcoin-core-dev 10:25 < instagibbs> what was the current idea for supporting segwit addresses by default? Same derivation path, just adding all variants of output types? 10:25 < instagibbs> p2sh-p2wpkh + p2wpkh 10:26 < gmaxwell_> no please don't. 10:26 < gmaxwell_> then you're inviting people to randomly convert other people's keys to segwit addresses and it will sometimes work 10:26 < instagibbs> gmaxwell_, go on... 10:26 < instagibbs> bip49, minus the bip44 part? 10:27 < instagibbs> i think a number of wallets have converged on m/49' 10:28 < gmaxwell_> It should just be a different path, I don't think doing anything with 49 provides any value whatsoever, but it doesn't really matter which other path it is. 10:28 -!- gmaxwell_ [~gmaxwell@140.211.15.28] has quit [Changing host] 10:28 -!- gmaxwell_ [~gmaxwell@wikimedia/KatWalsh/x-0001] has joined #bitcoin-core-dev 10:28 < instagibbs> Sounds good. 10:29 -!- gmaxwell_ is now known as gmaxwell 10:30 < gmaxwell> the problem I think arises in supporting multiple pools... it could be that we could be sw only except for imported keys. 10:31 < instagibbs> yes otherwise you'd have like 6 pools all said and done 10:32 < gmaxwell> we could still support turning an existing wallet into a segwit one, by generating a new master key and converting all keys to imported-like ones. 10:33 < gmaxwell> 10:31:42 < solidfox> gmaxwell, I just noticed something in 15 10:33 < gmaxwell> 10:31:58 < solidfox> gmaxwell, there is a %1 instead of "Bitcoin core" 10:33 < gmaxwell> 10:32:24 < solidfox> on the tooltip for the open config file button 10:34 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 240 seconds] 10:34 -!- treebeardd [~treebeard@c-67-185-216-208.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 10:36 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 10:38 -!- vicenteH [~user@195.235.96.150] has quit [Ping timeout: 264 seconds] 10:38 -!- Giszmo [~leo@ip-190-233.219.201.nextelmovil.cl] has quit [Ping timeout: 240 seconds] 10:42 -!- treebeardd [~treebeard@c-67-185-216-208.hsd1.wa.comcast.net] has quit [Quit: Leaving...] 10:48 -!- gwollon is now known as gwillen 10:48 -!- gwillen is now known as Guest28001 10:48 -!- Guest28001 [~gwillen@50.116.8.236] has quit [Changing host] 10:48 -!- Guest28001 [~gwillen@unaffiliated/gwillen] has joined #bitcoin-core-dev 10:49 -!- Guest28001 is now known as gwillen 10:50 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 10:54 -!- Giszmo [~leo@ip-86-233.219.201.nextelmovil.cl] has joined #bitcoin-core-dev 11:03 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 11:11 -!- esotericnonsense [~esoteric@gateway/vpn/privateinternetaccess/esotericnonsense] has joined #bitcoin-core-dev 11:14 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 11:18 -!- Veseli_Zagorec [~Veseli_Za@dh207-71-117.xnet.hr] has joined #bitcoin-core-dev 11:19 < jnewbery> wumpus (or other maintainer): can you add #10767 to the high-priority for review pile? 11:19 < bitcoin-git> [bitcoin] esotericnonsense opened pull request #11198: [Qt] Fix display of package name on 'open config file' tooltip (0.15...fix-config-tooltip) https://github.com/bitcoin/bitcoin/pull/11198 11:22 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 240 seconds] 11:23 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 11:24 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 11:27 < esotericnonsense> if anyone is around - should I have based this on 0.15.0 or master? which is more helpful to those with push access? 11:28 < sdaftuar> esotericnonsense: default is to base things on master and tag them for backport 11:29 < sdaftuar> esotericnonsense: for things that don't cherry-pick cleanly, you can open a backport PR as well that is based on the older branch, but that's more the exception than the rule 11:29 < gmaxwell> esotericnonsense: always work against master unless you're just trying out a fix for an issue you haven't reproduced against master yet. 11:31 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 11:33 < gmaxwell> esotericnonsense: looking at backscroll, I see you were asking about BDB. Yes, you can use newer bdb but they can't (reliably) be run with older software, we're not aware of any improvements in BDB that would encourage using a newer version. And the newest versions have much more restrictive licensing. I think that our plan, to the extent we have one there, is to continue using the 4.8.x series 11:33 < esotericnonsense> right, so should I open another PR against master? just testing it now 11:33 < gmaxwell> until we abandon BDB for a proper custom wallet format. 11:33 < gmaxwell> esotericnonsense: yes, please do. 11:34 < esotericnonsense> will be up soon 11:34 < gmaxwell> esotericnonsense: in general, all changes must go in master first. this prevents mistakes where a fix goes in a release branch then shows up in the next major version. It also gets the change more testing, since developers mostly work against master. 11:34 < gmaxwell> er then the issue shows up again in the next major version*. 11:35 < esotericnonsense> understood 11:36 < MarcoFalke> esotericnonsense: To prevent opening a fresh pull. You could try rebasing on c2704ec98a1b7b35b6a7c1b6b26a3f16d44e8880 11:38 < MarcoFalke> Make sure you are on the right branch and no uncommited changes! Then: git reset --hard c2704ec98a1b7b35b6a7c1b6b26a3f16d44e8880 && git cherry-pick 6c26e89 && git push origin $your_branch_name 11:38 < MarcoFalke> On GitHub there should be a dropdown to change from 0.15 branch to master branch 11:42 -!- targon [5ccd4c06@gateway/web/freenode/ip.92.205.76.6] has quit [Ping timeout: 260 seconds] 11:44 < esotericnonsense> MarcoFalke: i'd need to force push, no? 11:44 * esotericnonsense is not completely up to scratch on github's PR mechanism 11:46 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 11:47 < MarcoFalke> jup, force push 11:47 < esotericnonsense> done 11:48 -!- btcdrak [uid239175@gateway/web/irccloud.com/x-vpmoqzoxxzoqcidg] has quit [Quit: Connection closed for inactivity] 11:48 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 252 seconds] 11:49 < esotericnonsense> hang on, why rebase on c2704 and not d97fe2016cc7739929aac5c44de5037163b17ad0 ? 11:49 < esotericnonsense> https://github.com/bitcoin/bitcoin/blob/master/src/qt/optionsdialog.cpp 11:52 < MarcoFalke> d97fe2016cc7739929aac5c44de5037163b17ad0 works as well 11:52 < MarcoFalke> Those are commit from before 0.15 was branched of 11:52 < esotericnonsense> right that makes sense. 11:53 < MarcoFalke> Actually you could use any commit from master, as we usually backport by cherry-picks. But, yeah... 12:01 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 12:04 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 12:14 -!- sam_c [~sam_c@gateway/tor-sasl/stanley] has quit [Ping timeout: 268 seconds] 12:20 -!- shesek [~shesek@bzq-84-110-56-10.cablep.bezeqint.net] has joined #bitcoin-core-dev 12:21 -!- sam_c [~sam_c@gateway/tor-sasl/stanley] has joined #bitcoin-core-dev 12:47 < bitcoin-git> [bitcoin] danra opened pull request #11199: Sync module: Use std locking primitives instead of boost ones (master...refactor/sync-boost-to-std) https://github.com/bitcoin/bitcoin/pull/11199 12:52 -!- Veseli_Zagorec [~Veseli_Za@dh207-71-117.xnet.hr] has quit [Quit: Leaving] 13:07 -!- Cheeseo [~Cheeseo@unaffiliated/cheeseo] has joined #bitcoin-core-dev 13:25 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev 13:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 13:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 13:27 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 13:32 -!- vicenteH [~user@13.232.15.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 13:34 -!- Gunnie [~kamk@2.82.cust.tetanet.cz] has joined #bitcoin-core-dev 13:45 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 248 seconds] 13:52 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 13:55 < jimpo> My node is taking forever to get in sync (I'm working in a VM), but initChain state is consistency much faster with ~300K blocks in branch #1034. 13:56 < jimpo> Now that there's a DB migration that runs on boot, you should be able to test it without resyncing from scratch. 13:57 < sipa> jimpo: i'm confused 13:58 < sipa> what is initChain, what consistency, what is branch 1034? 13:58 -!- Veseli_Zagorec [~Veseli_Za@dh207-71-117.xnet.hr] has joined #bitcoin-core-dev 13:59 -!- Veseli_Zagorec [~Veseli_Za@dh207-71-117.xnet.hr] has quit [Client Quit] 14:00 -!- stvn [7a3d81b4@gateway/web/freenode/ip.122.61.129.180] has quit [Ping timeout: 260 seconds] 14:05 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-zixpqtebgrpnocms] has joined #bitcoin-core-dev 14:11 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 14:12 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 240 seconds] 14:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 14:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 14:16 -!- pigsalsa [~pigsalsa@pool-71-123-61-120.phlapa.fios.verizon.net] has joined #bitcoin-core-dev 14:24 -!- Gunnie [~kamk@2.82.cust.tetanet.cz] has quit [Quit: Textual IRC Client: www.textualapp.com] 14:27 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 14:28 -!- Gunnie [~kamk@2.82.cust.tetanet.cz] has joined #bitcoin-core-dev 14:29 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 14:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 252 seconds] 14:30 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 14:33 -!- ula [~kvirc@b2b-78-94-11-194.unitymedia.biz] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/] 14:33 < jimpo> sipa: Sorry, definitely posted that in the wrong channel 14:39 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 14:39 -!- Gunnie [~kamk@2.82.cust.tetanet.cz] has quit [Quit: My computer has gone to sleep. ZZZzzz…] 14:42 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 252 seconds] 15:11 -!- Giszmo [~leo@ip-86-233.219.201.nextelmovil.cl] has quit [Read error: Connection reset by peer] 15:13 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 15:14 -!- Cheeseo [~Cheeseo@unaffiliated/cheeseo] has quit [Read error: Connection reset by peer] 15:32 -!- Giszmo [~leo@pc-93-17-46-190.cm.vtr.net] has joined #bitcoin-core-dev 15:58 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 248 seconds] 16:01 -!- Dizzle [~dizzle@108.171.182.16] has quit [Quit: Leaving...] 16:18 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 268 seconds] 16:21 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 16:24 -!- RoyceX [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 16:27 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Ping timeout: 252 seconds] 16:27 -!- shesek [~shesek@bzq-84-110-56-10.cablep.bezeqint.net] has quit [Changing host] 16:27 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 16:46 -!- Giszmo [~leo@pc-93-17-46-190.cm.vtr.net] has quit [Ping timeout: 240 seconds] 16:52 -!- CubicEarth [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 16:56 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 16:58 -!- Giszmo [~leo@pc-93-17-46-190.cm.vtr.net] has joined #bitcoin-core-dev 17:01 -!- RoyceX [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Ping timeout: 260 seconds] 17:03 -!- Evel-Knievel [~Evel-Knie@178-119-237-211.access.telenet.be] has quit [Ping timeout: 240 seconds] 17:11 -!- jtimon [~quassel@199.31.134.37.dynamic.jazztel.es] has quit [Quit: No Ping reply in 180 seconds.] 17:12 -!- jtimon [~quassel@199.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 17:24 -!- randy-waterhouse [~kiwigb@43.228.156.196] has joined #bitcoin-core-dev 17:24 -!- randy-waterhouse [~kiwigb@43.228.156.196] has quit [Changing host] 17:24 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has joined #bitcoin-core-dev 17:39 -!- CubicEar_ [~cubiceart@64.118.50.98] has joined #bitcoin-core-dev 17:41 < bitcoin-git> [bitcoin] achow101 opened pull request #11200: Allow for aborting rescans and canceling showProgress dialogs (master...gui-recan-abort) https://github.com/bitcoin/bitcoin/pull/11200 17:42 -!- CubicEarth [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds] 17:55 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-zixpqtebgrpnocms] has quit [Quit: Connection closed for inactivity] 17:57 -!- JackH [~laptop@46.231.18.66] has quit [Ping timeout: 248 seconds] 17:58 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev 18:26 -!- CubicEar_ [~cubiceart@64.118.50.98] has quit [Read error: Connection reset by peer] 18:27 -!- CubicEarth [~cubiceart@64.118.50.98] has joined #bitcoin-core-dev 18:37 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [] 18:41 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has quit [Ping timeout: 252 seconds] 18:42 -!- randy-waterhouse [~kiwigb@43.228.156.196] has joined #bitcoin-core-dev 18:44 -!- randy-waterhouse [~kiwigb@43.228.156.196] has quit [Client Quit] 18:48 -!- Terrance [6b0ff482@gateway/web/freenode/ip.107.15.244.130] has joined #bitcoin-core-dev 18:49 -!- Terrance [6b0ff482@gateway/web/freenode/ip.107.15.244.130] has quit [Client Quit] 18:59 -!- CubicEarth [~cubiceart@64.118.50.98] has quit [Read error: Connection reset by peer] 19:06 -!- sam_c [~sam_c@gateway/tor-sasl/stanley] has quit [Remote host closed the connection] 19:08 -!- Giszmo [~leo@pc-93-17-46-190.cm.vtr.net] has quit [Ping timeout: 248 seconds] 19:08 -!- sam_c [~sam_c@gateway/tor-sasl/stanley] has joined #bitcoin-core-dev 19:24 -!- btcdrak [uid239175@gateway/web/irccloud.com/x-enajpllkbwdrsyii] has joined #bitcoin-core-dev 19:24 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 19:30 < achow101> I don't suppose it is possible to lock the comments on the first commit? 19:38 -!- Giszmo [~leo@pc-93-17-46-190.cm.vtr.net] has joined #bitcoin-core-dev 19:44 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds] 19:45 < sipa> achow101: i don't see an option to do that 19:45 < achow101> darn 19:55 < jl2012> i have a question about this line: https://github.com/bitcoin/bitcoin/blob/master/src/validation.h#L376 . Is is same as std::swap(scriptPubKey, check.scriptPubKey); ? 20:01 -!- goatpig [56f75436@gateway/web/freenode/ip.86.247.84.54] has joined #bitcoin-core-dev 20:02 < sipa> jl2012: yes 20:02 < sipa> std::swap also works for primitive types 20:04 < jl2012> thanks sipa. I have another question about my patch here: https://github.com/bitcoin/bitcoin/pull/10953/files#diff-349fbb003d5ae550a2e8fa658e475880L368 . 20:04 < jl2012> As I replace amount+scriptPubKey with CTxOut, the default value of amount becomes -1. It should be ok? 20:05 < sipa> sounds fine 20:05 < sipa> perhaps add an assert to check that it's not -1 for any actual validation 20:05 < sipa> or at least not for a witness validation 20:10 < jl2012> sipa: it sounds already like a serious bug if the validation would use the default value, 0 or -1. Maybe -1 is actually better because it must be invalid 20:19 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 20:22 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-gkztvkgudznhewpu] has joined #bitcoin-core-dev 20:27 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 20:28 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 20:35 -!- Giszmo [~leo@pc-93-17-46-190.cm.vtr.net] has quit [Ping timeout: 240 seconds] 20:38 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 248 seconds] 20:47 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 20:48 -!- Giszmo [~leo@pc-93-17-46-190.cm.vtr.net] has joined #bitcoin-core-dev 20:49 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 252 seconds] 20:54 -!- Giszmo [~leo@pc-93-17-46-190.cm.vtr.net] has quit [Ping timeout: 240 seconds] 20:56 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 21:07 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 21:16 -!- Giszmo [~leo@pc-93-17-46-190.cm.vtr.net] has joined #bitcoin-core-dev 21:19 < bitcoin-git> [bitcoin] justicz opened pull request #11201: [RPC] Add verifyrawtransaction RPC (master...maxj_add_verify_tx_rpc) https://github.com/bitcoin/bitcoin/pull/11201 21:50 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 22:02 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds] 22:06 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 22:44 -!- Victor_sueca is now known as Victorsueca 22:46 -!- Gunnie [~kamk@2.82.cust.tetanet.cz] has joined #bitcoin-core-dev 23:06 -!- ula [~kvirc@b2b-78-94-11-194.unitymedia.biz] has joined #bitcoin-core-dev 23:19 -!- clarkmoody [~clarkmood@47-218-249-135.bcstcmta04.res.dyn.suddenlink.net] has quit [Ping timeout: 240 seconds] 23:49 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 23:55 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-gkztvkgudznhewpu] has quit [Quit: Connection closed for inactivity]