--- Day changed Sun Sep 03 2017 00:45 < Victorsueca> luke-jr: thanks for correcting, I would swear I have read somewhere there was something obfuscated to prevent antivirus going nuts 00:47 < Victorsueca> ahh found it.... It was the chainstate 01:12 < sipa> indeed, the chainstate is obfuscated 02:06 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 02:07 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 02:08 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Ping timeout: 252 seconds] 02:17 -!- RealM9 [~androirc@balticom-142-92-236.balticom.lv] has joined #bitcoin-core-dev 02:21 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 02:27 -!- RealM9 [~androirc@balticom-142-92-236.balticom.lv] has quit [Ping timeout: 252 seconds] 02:27 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 03:22 -!- userbb [~userbb@pa49-195-202-226.pa.nsw.optusnet.com.au] has joined #bitcoin-core-dev 03:23 < userbb> hi, i'd like for someone to explain to me basiclly how bitcoins work 03:33 -!- paveljanik [~paveljani@79.98.72.176] has joined #bitcoin-core-dev 03:33 -!- paveljanik [~paveljani@79.98.72.176] has quit [Changing host] 03:33 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev 03:43 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 03:46 < molz> userbb, wrong channel, you can ask in #bitcoin 03:50 -!- btcdrak [uid239175@gateway/web/irccloud.com/x-ooarjojevqbbjmgb] has joined #bitcoin-core-dev 03:52 -!- userbb [~userbb@pa49-195-202-226.pa.nsw.optusnet.com.au] has quit [Quit: Leaving] 04:48 -!- Veseli_Zagorec [~Veseli_Za@dh207-67-33.xnet.hr] has joined #bitcoin-core-dev 05:03 < bitcoin-git> [bitcoin] jlopp opened pull request #11224: Tx chain stats (master...txChainStats) https://github.com/bitcoin/bitcoin/pull/11224 05:04 < bitcoin-git> [bitcoin] jlopp closed pull request #11224: Tx chain stats (master...txChainStats) https://github.com/bitcoin/bitcoin/pull/11224 05:10 -!- jtimon [~quassel@199.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 05:21 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 06:00 < bitcoin-git> [bitcoin] sdaftuar opened pull request #11225: wallet: update stored witness in AddToWallet (master...2017-09-update-tx-witness) https://github.com/bitcoin/bitcoin/pull/11225 06:02 -!- Gunnie [~kamk@2.82.cust.tetanet.cz] has quit [Quit: My computer has gone to sleep. ZZZzzz…] 06:06 -!- btcdrak [uid239175@gateway/web/irccloud.com/x-ooarjojevqbbjmgb] has quit [Quit: Connection closed for inactivity] 06:30 -!- lupi [~lupi@173-246-7-91.qc.cable.ebox.net] has quit [Quit: My Mac has gone to sleep. ZZZzzz…] 06:36 -!- Yogaqueef [~textual@dsl-hkibng42-5673c3-32.dhcp.inet.fi] has quit [Quit: Textual IRC Client: www.textualapp.com] 06:54 -!- jimmysong_ [~Jimmy@23-112-39-203.lightspeed.austtx.sbcglobal.net] has quit [Quit: Leaving] 06:55 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-tnthvgxtskvqrfay] has quit [Quit: Connection closed for inactivity] 07:12 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 07:13 -!- lupi [~lupi@173-246-7-91.qc.cable.ebox.net] has joined #bitcoin-core-dev 07:13 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 07:29 -!- rabidus [~rabidus@91-145-115-129.bb.dnainternet.fi] has joined #bitcoin-core-dev 07:29 -!- praxeology [~praxeolog@cpe-173-172-191-20.tx.res.rr.com] has quit [Quit: Leaving.] 07:42 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 07:43 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 07:44 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 07:49 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 07:57 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 08:04 -!- Gunnie [~kamk@2.82.cust.tetanet.cz] has joined #bitcoin-core-dev 08:51 -!- zxzzt [~prod@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Ping timeout: 240 seconds] 08:52 -!- jnewbery [~john@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Ping timeout: 255 seconds] 08:52 -!- morcos [~morcos@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Ping timeout: 240 seconds] 08:53 -!- sdaftuar [~sdaftuar@unaffiliated/sdaftuar] has quit [Ping timeout: 240 seconds] 08:54 -!- zxzzt [~prod@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 08:54 -!- jnewbery [~john@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 08:54 -!- sdaftuar [~sdaftuar@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 08:54 -!- sdaftuar [~sdaftuar@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Changing host] 08:54 -!- sdaftuar [~sdaftuar@unaffiliated/sdaftuar] has joined #bitcoin-core-dev 09:01 -!- morcos [~morcos@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 09:14 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Read error: Connection reset by peer] 09:14 -!- lupi [~lupi@173-246-7-91.qc.cable.ebox.net] has quit [Quit: My Mac has gone to sleep. ZZZzzz…] 09:17 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #bitcoin-core-dev 09:30 -!- lifeofguenter [~lifeofgue@bnc.pro.to.co.ls] has quit [Ping timeout: 260 seconds] 09:31 -!- brucetwain [4670aef1@gateway/web/freenode/ip.70.112.174.241] has joined #bitcoin-core-dev 09:31 < brucetwain> anyone here? 09:32 -!- lifeofguenter [~lifeofgue@bnc.pro.to.co.ls] has joined #bitcoin-core-dev 09:37 < sipa> no 09:38 < brucetwain> lol 09:38 < brucetwain> hi quick question 09:38 < brucetwain> how many active developers are in the bitcoin core project 09:44 -!- r251d [~r251d@2600:1700:e350:37f0:58d2:bc95:9959:cbde] has joined #bitcoin-core-dev 09:45 < r251d> brucetwain: https://github.com/bitcoin/bitcoin/graphs/contributors 09:46 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 09:48 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 09:52 < bitcoin-git> [bitcoin] practicalswift opened pull request #11226: Add Clang thread safety analysis annotations: GUARDED_BY(lock) / EXCLUSIVE_LOCKS_REQUIRED(lock) (master...guarded-by-trivial) https://github.com/bitcoin/bitcoin/pull/11226 09:55 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Read error: Connection reset by peer] 09:59 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 10:06 -!- r251d [~r251d@2600:1700:e350:37f0:58d2:bc95:9959:cbde] has quit [Quit: Mutter: www.mutterirc.com] 10:09 -!- RoyceX [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Read error: Connection reset by peer] 10:09 -!- Veseli_Zagorec_ [~Veseli_Za@dh207-67-33.xnet.hr] has joined #bitcoin-core-dev 10:09 -!- cheese_ [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 10:09 -!- Veseli_Zagorec_ [~Veseli_Za@dh207-67-33.xnet.hr] has quit [Client Quit] 10:11 -!- Veseli_Zagorec [~Veseli_Za@dh207-67-33.xnet.hr] has quit [Ping timeout: 240 seconds] 10:23 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 252 seconds] 10:30 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 252 seconds] 10:30 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 10:44 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 10:50 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 10:51 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 10:53 < sturles> gmaxwell: I have been running the following for a few days, after reading your tip to sdaftuar about listing segwit transactions on top of the mempool: while sleep 10; do bitcoin-cli getblocktemplate | jq '.transactions | .[] | select(.hash != .txid) | .txid' >> swtxlog; done 10:54 < sturles> swtxlog is still empty. I haven't seen a single one. Not even my own. 10:54 < sturles> Does it work? 10:55 < sturles> I have set blockmaxwight=4000000 and blockmaxsize is unset. blockmintxfee=0 10:57 < sturles> The highest total size I have seen in the CreateNewBlock() lines in debug.log is 998231, and the highest block weight is 3992816. 11:02 < sipa> sturles: you need to tell GBT that you're segwit capable 11:03 < sipa> bitcoin core supports non-segwit capable mining software; it just won't include any segwit txn for them 11:04 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 240 seconds] 11:04 < sturles> How? 11:05 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 11:07 < arubi> sturles, add '{"rules": ["csv","segwit"]}' to the getblocktemplate call 11:08 < arubi> you should be also getting a 'default_witness_commitment' field that wasn't there before 11:10 < sturles> That's better! 11:11 < sturles> Lots of transactions and total size > 1000000. 11:11 -!- shesek [~shesek@bzq-84-110-56-10.red.bezeqint.net] has joined #bitcoin-core-dev 11:20 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 11:24 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Ping timeout: 255 seconds] 11:24 -!- To7 [~theo@2604:2000:1382:b7:61b5:6b3f:64a6:f9d4] has joined #bitcoin-core-dev 11:29 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #bitcoin-core-dev 11:31 -!- lupi [~lupi@206-248-138-200.dsl.teksavvy.com] has joined #bitcoin-core-dev 11:34 -!- brucetwain [4670aef1@gateway/web/freenode/ip.70.112.174.241] has quit [Ping timeout: 260 seconds] 11:45 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 11:48 -!- jtimon [~quassel@199.31.134.37.dynamic.jazztel.es] has quit [Remote host closed the connection] 12:02 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-zppfbbufuqtpaokw] has joined #bitcoin-core-dev 12:10 -!- lupi [~lupi@206-248-138-200.dsl.teksavvy.com] has quit [Quit: My Mac has gone to sleep. ZZZzzz…] 12:27 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Ping timeout: 252 seconds] 12:32 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #bitcoin-core-dev 12:49 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 12:54 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Ping timeout: 240 seconds] 12:57 -!- CubicEarth [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 13:04 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 260 seconds] 13:06 -!- Gunnie [~kamk@2.82.cust.tetanet.cz] has quit [Quit: My computer has gone to sleep. ZZZzzz…] 13:18 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 13:18 -!- praxeology [~praxeolog@cpe-173-172-191-20.tx.res.rr.com] has joined #bitcoin-core-dev 13:27 -!- retrop99 [~retrop99@213.152.161.181] has quit [Ping timeout: 260 seconds] 13:30 -!- lupi [~lupi@104.156.75.178] has joined #bitcoin-core-dev 13:34 < gmaxwell> Does this sound like another person with an offscreen problem https://www.reddit.com/r/Bitcoin/comments/6xtr3w/bitcoin_core_problems/ 13:47 -!- seecollinshere [6970294b@gateway/web/freenode/ip.105.112.41.75] has joined #bitcoin-core-dev 13:48 < seecollinshere> Any body here? 13:49 -!- seecollinshere [6970294b@gateway/web/freenode/ip.105.112.41.75] has quit [Client Quit] 13:49 -!- lupi [~lupi@104.156.75.178] has quit [Ping timeout: 252 seconds] 13:52 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Ping timeout: 240 seconds] 13:59 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #bitcoin-core-dev 14:01 -!- lupi [~lupi@104.156.75.178] has joined #bitcoin-core-dev 14:04 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 240 seconds] 14:06 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 14:13 < bitcoin-git> [bitcoin] theuni opened pull request #11227: RFC: switch to libevent for node socket handling (master...minimal-libevent3) https://github.com/bitcoin/bitcoin/pull/11227 14:15 -!- Cheeseo [~Cheeseo@unaffiliated/cheeseo] has joined #bitcoin-core-dev 14:16 -!- CubicEarth [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 14:21 -!- Deacydal [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 14:24 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has quit [Ping timeout: 252 seconds] 14:31 -!- elkalamar [~elkalamar@unaffiliated/elkalamar] has joined #bitcoin-core-dev 14:32 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Ping timeout: 246 seconds] 14:35 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #bitcoin-core-dev 14:42 -!- bytting [~corebob@2a02:fe0:c150:1a00:8958:6277:6ca3:b2cf] has joined #bitcoin-core-dev 14:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 14:56 -!- Cheeseo [~Cheeseo@unaffiliated/cheeseo] has quit [Ping timeout: 260 seconds] 14:58 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 14:58 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 15:08 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has quit [Quit: Leaving] 15:08 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.] 15:09 -!- btcdrak [uid239175@gateway/web/irccloud.com/x-yjhemhuujalpxrpm] has joined #bitcoin-core-dev 15:10 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 15:25 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 240 seconds] 15:38 < meshcollider> gmaxwell: sounds like it to me, achow101 when you tested it on windows, does the thumbnail that pop up from the taskbar look as described or does it still show the window? 15:39 < meshcollider> I would guess that windows just takes what the window currently looks like which is nothing if its not onscreen, but im not sure 15:47 < achow101> gmaxwell: yes 15:47 < achow101> meshcollider: yes 15:51 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Ping timeout: 268 seconds] 15:52 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 15:54 < gmaxwell> ::sigh:: 15:55 < meshcollider> if we're getting this many issues with it, maybe we do need to get the fix into 0.15.0 15:59 < gmaxwell> it isn't a new issue at least, as far as I can tell. 16:00 < gmaxwell> it's just obnoxious that such a low value feature (saving the window position across starts) results in such a serious bug. 16:00 < meshcollider> achow101 have you got any further with the mem access violation crash in #11171? 16:06 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Ping timeout: 252 seconds] 16:16 < achow101> meshcollider: not really. 16:16 < achow101> see the comment I made which is about as far as I got with it 16:16 < achow101> I think it has to do with a weird string for the proxy which is causing it to get all messed up 16:27 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 246 seconds] 16:27 -!- elkalamar [~elkalamar@unaffiliated/elkalamar] has quit [Quit: Leaving] 16:28 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 16:40 < meshcollider> So it's probably a once off incident, not going to be reproduced without deliberate tampering? 16:42 < meshcollider> Btw can someone rerun Travis on #11178, failure in unrelated test 16:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 16:54 < achow101> meshcollider: done 16:54 < meshcollider> Thanks :) 16:55 < meshcollider> sipa: sorry what does your comment on #11210 mean? 16:56 < sipa> meshcollider: you're thinking that i would suggest having a single catch around the whole block - i'm pointing out that i won't suggest that, because it would be incorrect 17:02 < meshcollider> no not that one, the one about the qt test directory 17:02 < meshcollider> I got the catch statement thing haha I was only joking :) 17:02 < meshcollider> I appreciate the reviews :) 17:03 < sipa> oh 17:03 < sipa> any reason why the non-qt tests wouldn't need that datadir logic? 17:03 -!- venzen [~venzen@5.255.87.141] has quit [Ping timeout: 246 seconds] 17:05 < meshcollider> they have it I thought? Its here for example: https://github.com/bitcoin/bitcoin/blob/master/src/test/test_bitcoin.cpp#L63 17:05 < sipa> oh 17:06 < sipa> meshcollider: ignore me 17:08 < meshcollider> Ok but just this once ;) I pushed the fix for your last nit for the iswitness decode parameter btw 17:13 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:16 < sipa> awesome, thanks 17:17 -!- goatpig [56f75436@gateway/web/freenode/ip.86.247.84.54] has quit [Ping timeout: 260 seconds] 17:19 < meshcollider> I'm sitting on a bus for 8 hours today across the country, anything would be useful for me to work on while I'm sitting here? Otherwise I'll just go and review some more PRs 17:21 -!- lupi [~lupi@104.156.75.178] has quit [Ping timeout: 248 seconds] 17:23 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 17:24 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Ping timeout: 248 seconds] 17:26 -!- RoyceX [~Cheeseo@unaffiliated/cheeseo] has joined #bitcoin-core-dev 17:26 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 17:28 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Ping timeout: 240 seconds] 17:35 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Ping timeout: 240 seconds] 17:37 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 17:40 -!- bytting [~corebob@2a02:fe0:c150:1a00:8958:6277:6ca3:b2cf] has quit [Quit: WeeChat 1.9] 17:57 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev 18:00 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #bitcoin-core-dev 18:15 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 248 seconds] 18:19 -!- lupi [~lupi@104.156.75.178] has joined #bitcoin-core-dev 18:24 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection] 18:24 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 18:25 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 252 seconds] 19:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 19:18 -!- jjackson502 [4a886a3b@gateway/web/freenode/ip.74.136.106.59] has joined #bitcoin-core-dev 19:19 < jjackson502> join 19:23 -!- jjackson502 [4a886a3b@gateway/web/freenode/ip.74.136.106.59] has quit [Client Quit] 19:24 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 19:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds] 19:37 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Quit: Leaving.] 19:49 -!- RoyceX [~Cheeseo@unaffiliated/cheeseo] has quit [Ping timeout: 246 seconds] 20:18 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 20:33 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has quit [Ping timeout: 240 seconds] 20:33 -!- Dyaheon [~Dya@a91-156-192-39.elisa-laajakaista.fi] has joined #bitcoin-core-dev 20:57 < meshcollider> Is it better to keep src/test/testutil.cpp|h for future use even if they're kinda redundant, or better to remove them because it results in fewer source files? 21:01 -!- lupi [~lupi@104.156.75.178] has quit [Quit: My Mac has gone to sleep. ZZZzzz…] 21:02 < sipa> i don't think anyone cares about the number of source files, as long as the separation in files makes sense (don't make a new file for eveey function...) 21:17 < jimpo> The stall timeout for headers sync (nHeadersSyncTimeout) appears to be a single timeout to sync the whole header chain instead of a smaller timeout for each successive headers message. Why is that? 21:21 < midnightmagic> +1 no file-per-function nonsense. not everyone uses a class-browser and ignores other structure. 21:23 < gmaxwell> jimpo: it's not very sophicated right now. I'm sure it could also have several tiers of timeouts, one thing to be warry of is the sum of small timeouts if fed slowly turning into an unreasonably long wait. 21:32 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 260 seconds] 21:35 -!- Gunnie [~kamk@109.202.82.2] has joined #bitcoin-core-dev 21:44 < meshcollider> midnightmagic: I'm suggesting removing a file with only one function (a redundant function which just calls another), not adding new files 21:45 * midnightmagic shrugs 21:45 < gmaxwell> meshcollider: if you don't know you can also feel free to just make a PR to remove it per your best judgement and if you were mistaken people will explain why. No big deal. 22:28 -!- ill [~ill@c-174-63-65-220.hsd1.ct.comcast.net] has joined #bitcoin-core-dev 22:28 -!- ill [~ill@c-174-63-65-220.hsd1.ct.comcast.net] has quit [Client Quit] 22:44 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 22:54 < kallewoof> sipa: Slightly off topic, but a new file for every public class would be sort of nice though (net.h has 4, for example). 22:57 < sipa> kallewoof: i couldn't disagree more, soory:) 22:58 < kallewoof> sipa: If they're small, I can live with it, but net.cpp is 3k lines. I think that's a bit long. 22:59 < sipa> oh, absolutely 22:59 < sipa> but nrt.cpp is also way more than one class 23:01 < kallewoof> CConnman is about 2k, the rest is CNetMessage and CNode and random help functions. Not sure what you mean by 'more than one class' -- that's what I'm saying too, it's 3 classes. 23:04 < kallewoof> Anyway, it was a random thought. I like files to be less than 1k lines if possible. Maybe that's just a personal preference. 23:04 < sipa> kallewoof: what i mean is that in an ideal world a lot of the functionality in net could be split up into more classes, but i think many of them may still belong in net 23:04 < sipa> i don't see a 3k line file as a big problem, but it is suboptimal 23:05 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 23:05 < sipa> but splitting up every class into its own file is throwing away the ability for files to convey a structure themselves 23:08 -!- sam_c [~sam_c@gateway/tor-sasl/stanley] has quit [Ping timeout: 268 seconds] 23:17 < kallewoof> That makes sense, yeah. I guess my erk is really with file size, not classes in the same file.. 23:18 < sipa> right 23:18 < sipa> file structure is there to make you help find things 23:19 < sipa> if you know the name of every class in the project, and how they relate, then i guess one class per file is optimal 23:19 < sipa> but typically you don't, and if when investigating program flow you need to jump between files all the time, that's also not very helpful 23:23 < kallewoof> It feels like a lot of file jumping happens right now though. Everything and its aunt seems to at some point go into validation.cpp, for example. I really wish that file was at least 2 or 3 files with distinct purposes. 23:24 < kallewoof> I know it's been improved though. (I think it was 7k+ lines when I started and it was still called main.cpp) 23:25 < sipa> kallewoof: right, the key point is "with distinct purposes" 23:26 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 23:27 * kallewoof nods. 23:43 -!- Gunnie [~kamk@109.202.82.2] has quit [Ping timeout: 240 seconds] 23:45 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Ping timeout: 240 seconds] 23:48 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]