--- Day changed Thu Sep 07 2017 00:00 -!- Gunnie [~kamk@65.82.cust.tetanet.cz] has quit [Ping timeout: 252 seconds] 00:06 < meshcollider> thanks :) 00:10 -!- promag [~promag@2001:8a0:fe30:de01:6da0:dc50:a52d:3c27] has joined #bitcoin-core-dev 00:11 -!- jtimon [~quassel@199.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds] 00:14 -!- promag [~promag@2001:8a0:fe30:de01:6da0:dc50:a52d:3c27] has quit [Ping timeout: 255 seconds] 00:18 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:32 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 00:33 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 00:41 -!- Orion3k [~Orion3k@47-51-33-228.static.mtpk.ca.charter.com] has quit [Ping timeout: 240 seconds] 00:42 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 00:46 -!- timothy [~tredaelli@redhat/timothy] has quit [Client Quit] 00:56 < meshcollider> So no IRC meeting this week right? 00:58 -!- Gunnie [~kamk@65.82.cust.tetanet.cz] has joined #bitcoin-core-dev 01:18 -!- Orion3k [~Orion3k@47-51-33-228.static.mtpk.ca.charter.com] has joined #bitcoin-core-dev 01:22 -!- Gunnie [~kamk@65.82.cust.tetanet.cz] has quit [Quit: My computer has gone to sleep. ZZZzzz…] 01:31 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:31 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection] 01:32 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev 01:33 -!- esotericnonsense [~esoteric@gateway/vpn/privateinternetaccess/esotericnonsense] has quit [Quit: WeeChat 1.9] 01:35 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 01:38 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:38 -!- esotericnonsense [~esoteric@gateway/vpn/privateinternetaccess/esotericnonsense] has joined #bitcoin-core-dev 01:43 -!- esotericnonsens_ [~esoteric@gateway/vpn/privateinternetaccess/esotericnonsense] has joined #bitcoin-core-dev 01:45 -!- esotericnonsense [~esoteric@gateway/vpn/privateinternetaccess/esotericnonsense] has quit [Ping timeout: 255 seconds] 01:45 -!- esotericnonsens_ is now known as esotericnonsense 01:56 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 01:56 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 02:00 -!- praxeology1 [~praxeolog@cpe-173-172-191-20.tx.res.rr.com] has left #bitcoin-core-dev [] 02:02 -!- hxz [~hxz@1.198.6.186] has quit [Ping timeout: 260 seconds] 02:02 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:08 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 02:11 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 02:13 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 02:31 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 02:34 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 02:55 -!- Gunnie [~kamk@65.82.cust.tetanet.cz] has joined #bitcoin-core-dev 03:09 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 03:11 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 03:23 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 03:24 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 03:26 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 03:37 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 03:38 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 03:49 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 03:51 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 04:00 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 04:05 -!- tiagotrs [~tiago@unaffiliated/tiagotrs] has joined #bitcoin-core-dev 04:10 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection] 04:24 -!- laurentmt [~Thunderbi@92.154.68.134] has joined #bitcoin-core-dev 04:24 -!- laurentmt [~Thunderbi@92.154.68.134] has quit [Client Quit] 04:33 -!- hxz [~hxz@219.156.117.181] has joined #bitcoin-core-dev 04:34 < meshcollider> is this intended behavior? https://i.imgur.com/juKAf1O.png the credit shows the full 7 BTC which was received by the wallet, but it was received on 2 separate addresses in the same transaction (3 and 4 BTC respectively), because from looking at that transaction details window it looks like the full 7 BTC was received on just that one address 04:35 < meshcollider> heh I forgot, everyones in SF so no one will be online at 4:30am sf time 04:37 < meshcollider> but I have a feeling this might be what the change to transactiondesc.cpp in #7101 was trying to fix 04:46 < esotericnonsense> meshcollider: this is feeling oddly familiar, i think i encountered this years ago when splitting coins 04:52 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 04:53 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 04:59 -!- laurentmt [~Thunderbi@92.154.68.134] has joined #bitcoin-core-dev 05:01 -!- laurentmt [~Thunderbi@92.154.68.134] has quit [Client Quit] 05:10 < esotericnonsense> meshcollider: i just tried to test this but forgot that there's special behaviour if you send to your own wallet, doh 05:11 < meshcollider> I just ran 2 regtest nodes on the same machine to do this 05:12 < meshcollider> just run one with -port=whatever and then addnode=127.0.0.1:whatever in the other nodes config 05:13 < esotericnonsense> crafted another one by using -wallet. 05:14 < esotericnonsense> this tx, with 4 outputs, 3 to 'wallet2' and 1 to change in 'wallet1', is showing as three seperate entries/rows in the 'wallet2' node. 05:15 < meshcollider> yep but if you go into the full details of each row, do they all just give the total, not the individual received by that address? 05:15 < esotericnonsense> ah yes. 05:16 < esotericnonsense> it's a bit odd in any case. on the 'sending wallet' it apportions the fee arbitrarily to one output. 05:17 < meshcollider> indeed 05:18 < meshcollider> seems like lots of little bugs are mixed up in this 05:18 < esotericnonsense> receiving end https://i.imgur.com/w4zF6FL.png https://i.imgur.com/SjAAd4x.png https://live.blockcypher.com/btc-testnet/tx/a739c64487f122f8b41644d2f703811167e8613ef616d17346a4570d72f20698/ 05:18 < esotericnonsense> it's difficult for me to reason about what you even want it to show really :P 05:21 < meshcollider> Yeah I guess the fee being attributed to a random output kinda makes sense right, its gotta be shown somewhere and you wouldn't want to make another whole row for it in the table 05:22 < meshcollider> its just the full details page, if you open it for any row from the same transaction it should show all inputs from that same transaction right, not just the one. Then it would make sense to have a total on there 05:23 < meshcollider> in a similar way to how its shown on the sending node 05:24 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 05:25 -!- laurentmt [~Thunderbi@92.154.68.134] has joined #bitcoin-core-dev 05:26 < meshcollider> like, this makes sense for sending https://i.imgur.com/Oz5X45l.png but this doesn't make sense to me for receiving https://i.imgur.com/H5wHdmJ.png 05:27 < bitcoin-git> [bitcoin] practicalswift opened pull request #11264: [doc] Fix broken Markdown table in dependencies.md (master...dependencies-capitalization) https://github.com/bitcoin/bitcoin/pull/11264 05:37 -!- promag [~promag@2001:8a0:fe30:de01:8da2:d0a6:5841:cfcc] has joined #bitcoin-core-dev 05:41 -!- promag [~promag@2001:8a0:fe30:de01:8da2:d0a6:5841:cfcc] has quit [Ping timeout: 255 seconds] 06:02 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has quit [Ping timeout: 248 seconds] 06:03 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has joined #bitcoin-core-dev 06:10 -!- tiagotrs [~tiago@unaffiliated/tiagotrs] has quit [Ping timeout: 248 seconds] 06:13 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:17 -!- tiagotrs [~tiago@p5DC46DE1.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 06:57 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 07:18 -!- btcdrak [uid239175@gateway/web/irccloud.com/x-jqruwvzhxrzkdryr] has quit [Quit: Connection closed for inactivity] 07:40 -!- tiagotrs [~tiago@p5DC46DE1.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds] 07:51 -!- Zenton [~user@13.232.15.37.dynamic.jazztel.es] has quit [Ping timeout: 255 seconds] 07:51 -!- Zenton [~user@13.232.15.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 07:53 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 07:54 -!- laurentmt [~Thunderbi@92.154.68.134] has quit [Quit: laurentmt] 07:54 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 07:54 -!- Zenton is now known as zenton 07:55 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Ping timeout: 260 seconds] 07:59 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 264 seconds] 08:13 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 252 seconds] 08:23 -!- hxz [~hxz@219.156.117.181] has quit [Ping timeout: 240 seconds] 08:25 -!- hxz [~hxz@219.156.117.181] has joined #bitcoin-core-dev 08:33 -!- promag [~promag@2001:8a0:fe30:de01:8da2:d0a6:5841:cfcc] has joined #bitcoin-core-dev 08:40 -!- promag [~promag@2001:8a0:fe30:de01:8da2:d0a6:5841:cfcc] has quit [Remote host closed the connection] 08:43 -!- hxz [~hxz@219.156.117.181] has quit [Ping timeout: 248 seconds] 08:44 -!- jonasschnelli [~jonasschn@bitcoinsrv.jonasschnelli.ch] has quit [Changing host] 08:44 -!- jonasschnelli [~jonasschn@unaffiliated/jonasschnelli] has joined #bitcoin-core-dev 08:58 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #10731: Escape rather than remove any printable characters in UAs (master...log_more_uacomment) https://github.com/bitcoin/bitcoin/pull/10731 09:00 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #10748: [config] Help text cleanup (master...helptextcleanup) https://github.com/bitcoin/bitcoin/pull/10748 09:01 -!- promag [~promag@2001:8a0:fe30:de01:8da2:d0a6:5841:cfcc] has joined #bitcoin-core-dev 09:01 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2a56baf395bf...9c8f3655cc68 09:01 < bitcoin-git> bitcoin/master d2be7b2 James Evans: Typo in optionsdialog.ui... 09:01 < bitcoin-git> bitcoin/master 9c8f365 Jonas Schnelli: Merge #10911: [qt] Fix typo and access key in optionsdialog.ui... 09:02 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #10911: [qt] Fix typo and access key in optionsdialog.ui (master...master) https://github.com/bitcoin/bitcoin/pull/10911 09:04 < MarcoFalke> wumpus: Mind to add the git log to the release notes? 09:04 < MarcoFalke> I'd like to take a look before tagging final 09:05 -!- promag [~promag@2001:8a0:fe30:de01:8da2:d0a6:5841:cfcc] has quit [Ping timeout: 255 seconds] 09:06 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-twkfwsqhwptfeeji] has quit [Quit: Connection closed for inactivity] 09:20 < bitcoin-git> [bitcoin] laanwj opened pull request #11267: rpc: update cli for estimatefee argument rename (master...2017_09_renamed_estimatefee_arg) https://github.com/bitcoin/bitcoin/pull/11267 09:20 < wumpus> MarcoFalke: ah shit, still need to do that, good point. Not sure I have all the tooling here. 09:21 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9c8f3655cc68...ea729d55b4db 09:21 < bitcoin-git> bitcoin/master ee4d149 Matt Corallo: Drop upgrade-cancel callback registration for a generic "resumeable"... 09:21 < bitcoin-git> bitcoin/master ea729d5 Jonas Schnelli: Merge #10770: Drop upgrade-cancel callback registration for a generic "cancelable"... 09:21 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #10770: Drop upgrade-cancel callback registration for a generic "cancelable" (master...2017-07-upgrade-cancel-nits) https://github.com/bitcoin/bitcoin/pull/10770 09:23 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 248 seconds] 09:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 09:26 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 09:27 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 09:27 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 09:27 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #bitcoin-core-dev 09:30 -!- laurentmt [~Thunderbi@92.154.68.134] has joined #bitcoin-core-dev 09:36 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 09:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 09:49 -!- LeMiner [LeMiner@unaffiliated/leminer] has joined #bitcoin-core-dev 09:51 -!- LeMiner2 [LeMiner@unaffiliated/leminer] has quit [Ping timeout: 248 seconds] 09:51 -!- LeMiner is now known as LeMiner2 09:52 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #10748: [config] Help text cleanup (master...helptextcleanup) https://github.com/bitcoin/bitcoin/pull/10748 09:56 -!- Murch [~murch@199-241-203-51.PUBLIC.monkeybrains.net] has joined #bitcoin-core-dev 09:58 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds] 09:58 -!- timothy [tredaelli@redhat/timothy] has quit [Ping timeout: 252 seconds] 09:59 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 10:01 -!- blznblzn2 [~blzn@2605:6001:f28d:e600:cf36:4af4:2baf:900a] has quit [Ping timeout: 264 seconds] 10:02 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ea729d55b4db...a3624ddb1a3b 10:02 < bitcoin-git> bitcoin/master 9b348ff Dan Raviv: Fix memory leaks in qt/guiutil.cpp... 10:02 < bitcoin-git> bitcoin/master a3624dd Jonas Schnelli: Merge #11156: Fix memory leaks in qt/guiutil.cpp... 10:02 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 10:03 -!- promag [~promag@2001:8a0:fe30:de01:8da2:d0a6:5841:cfcc] has joined #bitcoin-core-dev 10:03 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #11156: Fix memory leaks in qt/guiutil.cpp (master...fix/qt-guiutil-memory-leaks) https://github.com/bitcoin/bitcoin/pull/11156 10:05 -!- blznblzn2 [~blzn@2605:6001:f28d:e600:cf36:4af4:2baf:900a] has joined #bitcoin-core-dev 10:07 -!- promag [~promag@2001:8a0:fe30:de01:8da2:d0a6:5841:cfcc] has quit [Ping timeout: 255 seconds] 10:16 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #11268: [macOS] remove Growl support, remove unused code (master...2017/09/rm_growl) https://github.com/bitcoin/bitcoin/pull/11268 10:21 -!- laurentmt [~Thunderbi@92.154.68.134] has quit [Quit: laurentmt] 10:21 -!- promag [~promag@2001:8a0:fe30:de01:8da2:d0a6:5841:cfcc] has joined #bitcoin-core-dev 10:34 -!- Murch [~murch@199-241-203-51.PUBLIC.monkeybrains.net] has quit [Quit: Plugging out.] 10:37 -!- promag [~promag@2001:8a0:fe30:de01:8da2:d0a6:5841:cfcc] has quit [Remote host closed the connection] 10:38 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:39 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 10:42 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 10:45 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 10:45 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 248 seconds] 10:49 < MarcoFalke> cfields: Our travis builds are still broken since yesterday (they bumped the trusty image) 10:49 < MarcoFalke> I have no idea what is going on 10:49 < MarcoFalke> Mind to take a look? 10:49 < MarcoFalke> https://github.com/travis-ci/travis-ci/issues/8315#issuecomment-327537437 10:50 -!- jtimon [~quassel@199.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 10:50 < MarcoFalke> We could reroll to the deprecated image, maybe 10:51 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 10:58 -!- promag [~promag@2001:8a0:fe30:de01:8da2:d0a6:5841:cfcc] has joined #bitcoin-core-dev 10:59 -!- nelruk [~dax_the_c@181.121.112.195] has joined #bitcoin-core-dev 11:01 -!- Alina-malina [~Alina-mal@37.157.223.81] has joined #bitcoin-core-dev 11:02 -!- promag [~promag@2001:8a0:fe30:de01:8da2:d0a6:5841:cfcc] has quit [Ping timeout: 246 seconds] 11:02 -!- skoko961 [3eb05837@gateway/web/freenode/ip.62.176.88.55] has joined #bitcoin-core-dev 11:05 -!- Alina-malina [~Alina-mal@37.157.223.81] has quit [Changing host] 11:05 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev 11:06 -!- skoko961 [3eb05837@gateway/web/freenode/ip.62.176.88.55] has quit [Client Quit] 11:06 -!- promag [~promag@2001:8a0:fe30:de01:8da2:d0a6:5841:cfcc] has joined #bitcoin-core-dev 11:08 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 248 seconds] 11:09 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 11:10 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 248 seconds] 11:12 -!- promag [~promag@2001:8a0:fe30:de01:8da2:d0a6:5841:cfcc] has quit [Remote host closed the connection] 11:12 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 11:15 -!- owowo [ovovo@gateway/vpn/mullvad/x-rfslonhrbtesippi] has joined #bitcoin-core-dev 11:17 < bitcoin-git> [bitcoin] donaloconnor opened pull request #11269: [Trivial Fix] CTxMemPoolEntry::UpdateAncestorState: modifySiagOps param type (master...fix_params_branch) https://github.com/bitcoin/bitcoin/pull/11269 11:20 < wumpus> uh oh, the travis upgrade thing happened? 11:20 < wumpus> travisgeddon 11:21 < MarcoFalke> Yeah, looks like other projects are switichg back to the "deprecated" image 11:22 < MarcoFalke> If someone feels like creating a pr: Add `group: deprecated-2017Q3` to .travis.yml 11:29 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 11:33 -!- promag [~promag@2001:8a0:fe30:de01:8da2:d0a6:5841:cfcc] has joined #bitcoin-core-dev 11:34 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 11:37 -!- promag [~promag@2001:8a0:fe30:de01:8da2:d0a6:5841:cfcc] has quit [Ping timeout: 246 seconds] 11:47 < kanzure> for this meeting i will be typing everyone's messages. thanks. 11:52 < aj> kanzure: always wanted to be a relay bot when you grew up? 11:55 < wumpus> MarcoFalke etc: draft PR list for 0.15.0 is here https://github.com/bitcoin-core/bitcoin-devwiki/wiki/Pulls-listing-for-0.15.0-(temporary) 11:55 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-yehvnsoqjcwzwlht] has joined #bitcoin-core-dev 11:56 < sipa> that's a long list! 11:56 < wumpus> yes, it's scary :) 11:57 < wumpus> and that's already with most trivials and refactors removed 11:57 < sipa> is it usually that long for a major release? 11:57 < wumpus> a new record every release 11:58 < wumpus> unless I screwed something up while generating it and this is the list since 0.3.x instead ;) 11:58 < sipa> ha 12:00 < sipa> MEETING 12:00 < wumpus> lol 12:01 < achow101> meeting 12:01 < sdaftuar> hi 12:01 < achow101> ? 12:01 < jnewbery> hi 12:01 < meshcollider> Hello :) 12:01 -!- fpgaminer [~fpgaminer@cpe-172-90-105-203.socal.res.rr.com] has joined #bitcoin-core-dev 12:01 < gmaxwell> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 12:01 < instagibbs> hi 12:01 < BlueMatt> no? 12:01 < bitcoin-git> [bitcoin] laanwj opened pull request #11270: travis: Use deprecated trusty image (master...2017_09_travis_deprecated_image) https://github.com/bitcoin/bitcoin/pull/11270 12:02 < MarcoFalke> wha? 12:02 < CodeShark> are we doing this meeting? lol 12:02 < MarcoFalke> topics ... ? 12:02 < cfields> hi 12:02 < BlueMatt> we already said we were not doing meeting this week 12:02 < BlueMatt> iirc 12:02 * sipa suggests: lunch 12:02 < BlueMatt> ^^^ 12:02 < wumpus> lol did you ac tually start the meeting? 12:02 < achow101> no one started it yet 12:02 < cdecker> The one time I could participate... 12:03 < jonasschnelli> hi 12:03 < achow101> how about we meet irl ad kanzure transcribes to irc 12:03 < achow101> s/ad/and/ 12:04 < gmaxwell> We can tell sdaftuar all the great work we came up with for him to handle. 12:04 < BlueMatt> yea, sdaftuar is building segwit-wallet, right? 12:04 < BlueMatt> and sipa is being force-nominated wallet maintainer, so gets to review all of it :p 12:05 < luke-jr> I thought we would meet IRL, and kanzure transcribe it all to IRC 12:05 * sdaftuar hides 12:05 < meshcollider> lol 12:06 < kanzure> hi. 12:06 < kanzure> yeah i'm fine wit hthat 12:06 < sdaftuar> if you can predict the times i'll chime in and type that up as well that'd be great k thanks 12:06 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/a3624ddb1a3b...e7f125562fbb 12:06 < bitcoin-git> bitcoin/master 3b69a08 MeshCollider: Fix division by zero in time remaining 12:06 < bitcoin-git> bitcoin/master c8d38ab MeshCollider: Refactor tipUpdate as per style guide 12:06 < bitcoin-git> bitcoin/master e7f1255 Wladimir J. van der Laan: Merge #11237: qt: Fixing division by zero in time remaining... 12:07 < bitcoin-git> [bitcoin] laanwj closed pull request #11237: qt: Fixing division by zero in time remaining (master...201709_fix_estimated_time) https://github.com/bitcoin/bitcoin/pull/11237 12:08 < jtimon> perhaps a short summary of how are things going in the phisical meeting instead of the IRC meeting? 12:08 < jtimon> or kanzure's option sounds good too 12:09 < kanzure> there's various text from last few days, although not as much as zurich 12:09 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e7f125562fbb...2f0d3e604aa9 12:09 < bitcoin-git> bitcoin/master 061297f jjz: Ensure that data types are consistent... 12:09 < bitcoin-git> bitcoin/master 2f0d3e6 Wladimir J. van der Laan: Merge #11232: Ensure that data types are consistent... 12:09 < meshcollider> wumpus: #11265 can be closed now that #11237 was merged, GitHub must not understand a comma separated list of issues being fixed 12:10 < bitcoin-git> [bitcoin] laanwj closed pull request #11232: Ensure that data types are consistent (master...master) https://github.com/bitcoin/bitcoin/pull/11232 12:10 -!- goatpig [56f75436@gateway/web/freenode/ip.86.247.84.54] has quit [Quit: Page closed] 12:11 < instagibbs> kanzure, are the digests published already 12:11 < wumpus> meshcollider: thanks for letting me know 12:12 < kanzure> there's one or two vulnerabilities that i shouldn't publish 12:15 < instagibbs> meshcollider, sdaftuar and anyone else not physically present, please bring up topics of choice if you have them. 12:17 < jtimon> so what topics have you been talking about there? 12:18 < jtimon> I assume 0.15.1 has bee na big topic 12:18 < kanzure> signature aggregation 12:18 < kanzure> coin selection 12:19 < wumpus> 0.15.1 (segwit wallet) was a big topic, yes 12:19 < kanzure> rescans 12:21 < gmaxwell> I think we know what we're doing for segwit wallet. 12:21 < gmaxwell> after discussion pieter proposed a quick path for it that basically does an addwitness on every address in the wallet. 12:21 < gmaxwell> Which we concluded didn't create any more debt than we already have, since people aleady can do that. 12:21 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Quit: WeeChat 1.4] 12:22 < gmaxwell> (We also spent a while talking about ways that things could be handled in the future and have good ideas there too) 12:23 -!- fpgaminer [~fpgaminer@cpe-172-90-105-203.socal.res.rr.com] has left #bitcoin-core-dev ["Leaving"] 12:24 < meshcollider> gmaxwell: would this happen if the user decides to do a full wallet upgrade to segwit? 12:24 < meshcollider> No mix between segwit and non-segwit right? 12:24 < kanzure> i wanted to cause more discussion about rolling utxo hashes but one of the necessary people seems to be absent today 12:24 < gmaxwell> meshcollider: we must support mixed wallets already because people already have them. 12:25 < kanzure> also jonasschnelli gave a talk on bip150 and bip151 the other day http://diyhpl.us/wiki/transcripts/sf-bitcoin-meetup/2017-09-04-jonas-schenlli-bip150-bip151/ 12:25 < wumpus> mixed wallets are pretty much a neccesity 12:25 < gmaxwell> we won't be supporting 'segwit only' in 0.15.1 at least just because it's a bigger change. (rather than the couple line core change needed to just auto-addwitness to everything) 12:25 < gmaxwell> kanzure: that talk will have a video online in a bit. 12:25 < meshcollider> addwitness newaddresses or existing addresses too? 12:26 < gmaxwell> But perhaps in the future we will have wallets that are segwit only except for imported keys. 12:26 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 12:26 < gmaxwell> meshcollider: all due to backup recovery. 12:26 < michagogo> fakeping :-( 12:26 < gmaxwell> if you only do 'new' then you need a way of storing where you started doing that. 12:27 < meshcollider> Right, makes sense yep 👍 12:29 < MarcoFalke> cfields: https://github.com/bitcoin/bitcoin/pull/10753 12:30 < kanzure> luke-jr wanted to talk about #7533 and #10391 12:32 -!- promag [~promag@2001:8a0:fe30:de01:8da2:d0a6:5841:cfcc] has joined #bitcoin-core-dev 12:32 < MarcoFalke> cfields: You can find a MWE here: https://github.com/travis-ci/travis-ci/issues/8315#issuecomment-327537437 12:32 < MarcoFalke> (scroll up a bit) 12:32 < MarcoFalke> for the yaml 12:33 < jtimon> any talks about creating a testnet for developing and testing signature aggregation? (shameless escuse to review beg https://github.com/bitcoin/bitcoin/pull/8994 ) 12:34 < kanzure> signature aggregation will land in libsecp256k1 at some point 12:35 < jtimon> yeah, still too early to create a testnet, on the bright side I'm reading a lot of test code every time I rebase that... 12:35 -!- promag [~promag@2001:8a0:fe30:de01:8da2:d0a6:5841:cfcc] has quit [Remote host closed the connection] 12:38 -!- cbits [~cbits@c83-250-193-158.bredband.comhem.se] has joined #bitcoin-core-dev 12:38 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 12:38 -!- timothy [~tredaelli@redhat/timothy] has quit [Client Quit] 12:38 -!- blogibub [b91118c3@gateway/web/freenode/ip.185.17.24.195] has joined #bitcoin-core-dev 12:40 < meshcollider> I'll review that a bit later today jtimon, I like the sound of it 12:40 < meshcollider> Any new bugs reported in rc3? 12:40 < jtimon> meshcollider: awesome! 12:41 < meshcollider> This segfault issue with Qt keeps coming up, #11262 yesterday is the third issue I've seen 12:44 < jonasschnelli> Yes. The segfault things is ugly... it seems to happen for self-compiled Bitcoin-Qts only. So it could be a Qt5.5 bug. Couldn't track it down so far 12:45 < meshcollider> Dooglus used 5.7.1 here https://github.com/bitcoin/bitcoin/issues/9883#issuecomment-325217617 12:49 < jonasschnelli> hmm... good point. 12:50 < wumpus> yes the crashes in the sorting of the transaction list are vaguely worrying 12:50 < wumpus> seems some rare race condition 12:55 -!- promag [~promag@2001:8a0:fe30:de01:1462:562:741b:14d5] has joined #bitcoin-core-dev 12:57 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has quit [Quit: .] 12:59 -!- promag [~promag@2001:8a0:fe30:de01:1462:562:741b:14d5] has quit [Remote host closed the connection] 13:00 < jtimon> end meeting? 13:01 < kanzure> it's endless 13:01 < jtimon> thanks for the summary, looking forward to see the talks and transcripts 13:01 < kanzure> there's not as much text, but there's some. 13:03 < meshcollider> Are there any PRs for things like segwit wallet ready for review yet, are they incoming next few days or what 13:04 < MarcoFalke> cfields: With group edge `pyenv versions` is empty: https://travis-ci.org/MarcoFalke/bitcoin/jobs/273047509/config 13:05 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/2f0d3e604aa9...e6ab88a4524a 13:05 < bitcoin-git> bitcoin/master 5cb3da0 Marko Bencun: keystore GetKeys(): return result instead of writing to reference... 13:05 < bitcoin-git> bitcoin/master fe09b01 Marko Bencun: add missing lock to crypter GetKeys()... 13:05 < bitcoin-git> bitcoin/master e6ab88a Wladimir J. van der Laan: Merge #10916: add missing lock to crypter GetKeys()... 13:05 < bitcoin-git> [bitcoin] laanwj closed pull request #10916: add missing lock to crypter GetKeys() (master...GetKeys) https://github.com/bitcoin/bitcoin/pull/10916 13:06 < wumpus> meshcollider: some from https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.15.1 13:07 < wumpus> so if everyone is ok with the pull list in https://github.com/bitcoin-core/bitcoin-devwiki/wiki/Pulls-listing-for-0.15.0-(temporary) I'm going to paste it into the relnotes for 0.15.0 and tag final, if anyone still plans on looking through it (to find misattributions and such) let me know 13:11 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e6ab88a4524a...52f8877525d5 13:11 < bitcoin-git> bitcoin/master fa40b0e MarcoFalke: travis: Assert default datadir isn't created, Run scripted diff only once 13:11 < bitcoin-git> bitcoin/master 52f8877 MarcoFalke: Merge #11260: travis: Assert default datadir isn't created, Run scripted diff only once... 13:11 < sipa> i'd like to see #11174 addressed 13:11 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #11260: travis: Assert default datadir isn't created, Run scripted diff only once (master...Mf1708-travisYaml) https://github.com/bitcoin/bitcoin/pull/11260 13:14 < meshcollider> #11245 got tagged for 0.15.0 four hours ago, what's happening there 13:15 < meshcollider> If the issue isnt present in rc3 then there isn't much point including the fix in 0.15.0 release notes, but we don't know if it really got fixed 13:17 -!- cbits [~cbits@c83-250-193-158.bredband.comhem.se] has quit [Quit: Leaving] 13:20 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 13:21 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 13:21 < bitcoin-git> [bitcoin] theuni opened pull request #11271: travis: filter out pyenv (master...travis-fix-pyenv) https://github.com/bitcoin/bitcoin/pull/11271 13:22 < MarcoFalke> wumpus: I will look at the pull list 13:22 -!- Gunnie [~kamk@65.82.cust.tetanet.cz] has quit [Quit: My computer has gone to sleep. ZZZzzz…] 13:27 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 246 seconds] 13:28 < bitcoin-git> [bitcoin] laanwj closed pull request #11270: travis: Use deprecated trusty image (master...2017_09_travis_deprecated_image) https://github.com/bitcoin/bitcoin/pull/11270 13:29 -!- kyzeeruz [cb578190@gateway/web/freenode/ip.203.87.129.144] has joined #bitcoin-core-dev 13:29 < bitcoin-git> [bitcoin] laanwj closed pull request #11245: [0.15] Mention offscreen issue in release notes (0.15...201709_offscreen_release_note) https://github.com/bitcoin/bitcoin/pull/11245 13:30 < kyzeeruz> Hello world! 13:31 < meshcollider> What's needed for 11174 re: rescanning? 13:31 < meshcollider> I can make a PR if no one else is going to 13:31 < kyzeeruz> what is PR? 13:32 < meshcollider> Pull request 13:32 < meshcollider> But it sounded like gmaxwell was leaving a mental note for himself 13:32 < kyzeeruz> Is there somebody can give me a free web link to learn bitcoin coding? 13:33 < meshcollider> I think you're in the wrong channel, try #bitcoin :) 13:33 < bitcoin-git> [bitcoin] rawodb closed pull request #11177: Support for SegWit Addresses in RPC calls and change addresses (master...pr/rpc_getsegwitaddresses) https://github.com/bitcoin/bitcoin/pull/11177 13:35 < kyzeeruz> I want to create and build a bitcoin web game or either transforming an online game while playing earn a real bitcoin on it live online. 13:35 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #11272: CKeystore/CCrypter: move relevant implementation out of the header (master...2017/09/wallet_refact) https://github.com/bitcoin/bitcoin/pull/11272 13:35 < meshcollider> Is the meeting over? 13:35 < bitcoin-git> [bitcoin] Xekyo opened pull request #11273: WIP: Ignore old format estimation file (master...ignoreOldFeeEstimates) https://github.com/bitcoin/bitcoin/pull/11273 13:36 < kyzeeruz> Is there any possible to use an old computer as a main miner to generate bitcoin? 13:36 < michagogo> meshcollider: it didn't happen 13:36 < michagogo> despite the ping 13:36 < jonasschnelli> meshcollider: because most of the devs are working in the same physical location right now, the meeting was not really happening... 13:36 < michagogo> kyzeeruz: short answer: no. Anyway, this is the wrong place 13:36 < jonasschnelli> yeah.. next week it will be again in the normal fashion 13:36 < jonasschnelli> sorry about that. 13:37 < kyzeeruz> thanks michagogo 13:37 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 13:38 < meshcollider> Ok sweet, just confused about the ping and thought it was started :) 13:38 < meshcollider> Hope the last day of SF goes well then 13:38 -!- promag [~promag@2001:8a0:fe30:de01:1462:562:741b:14d5] has joined #bitcoin-core-dev 13:45 < bitcoin-git> [bitcoin] mess110 opened pull request #11274: [tests] Cleanup wildcard imports in functional tests (master...cleanup-wildcard-in-functional-tests) https://github.com/bitcoin/bitcoin/pull/11274 13:54 -!- arowser [~quassel@106.120.101.38] has quit [Quit: No Ping reply in 180 seconds.] 13:55 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev 13:58 -!- nelruk [~dax_the_c@181.121.112.195] has quit [Quit: Leaving] 13:59 < kyzeeruz> What repositories maen? 13:59 < sipa> kyzeeruz: #bitcoin please 14:02 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has quit [Ping timeout: 240 seconds] 14:03 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has joined #bitcoin-core-dev 14:07 < esotericnonsense> is it expected that pruning can become a limiting factor in IBD? testing now and by increasing my prune size (essentially, temporarily disabling it) it seems to have increased sync rate by approx 30% 14:08 < esotericnonsense> the cache seems to flush on each pruning event 14:09 < esotericnonsense> testing ramdisk with prune=5000 vs ssd with prune=50000 -> 30% faster off the ssd (and seemingly improving as dbcache increases) 14:10 -!- blogibub [b91118c3@gateway/web/freenode/ip.185.17.24.195] has quit [Quit: Page closed] 14:11 -!- promag [~promag@2001:8a0:fe30:de01:1462:562:741b:14d5] has quit [Remote host closed the connection] 14:12 < MarcoFalke> wumpus: Pull list looks fine 14:28 -!- kyzeeruz [cb578190@gateway/web/freenode/ip.203.87.129.144] has quit [Ping timeout: 260 seconds] 14:31 < wumpus> MarcoFalke: thanks for checking 14:31 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 14:36 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 14:37 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:42 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Ping timeout: 240 seconds] 14:43 -!- Cheeseo [~Cheeseo@unaffiliated/cheeseo] has joined #bitcoin-core-dev 14:51 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 252 seconds] 14:58 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds] 15:04 -!- cheese_ [~Cheeseo@unaffiliated/cheeseo] has joined #bitcoin-core-dev 15:07 < BlueMatt> gah, mk229797 shows up on an issue and tells someone to download a datadir snapshot 15:07 < BlueMatt> I assume its not a real person...wumpus wanna ban that account? 15:08 < BlueMatt> hmm, maybe not? 15:08 < wumpus> banned 15:08 < BlueMatt> seems like a person, but thats a strange response 15:08 < BlueMatt> eh, whatever 15:08 < BlueMatt> they'll come here and complain if they're real 15:09 < wumpus> right, it was definitely not ok 15:15 < wumpus> hm, strange, I pushed the PR list in the release notes to the 0.15 branch and github's bot didnt trigger 15:15 < BlueMatt> :O 15:16 < wumpus> maybe it's overloaded 15:16 < BlueMatt> github has had a lot of notification delays of late...there's been a few days where their email was super slow for a few hours 15:16 < wumpus> I hope it's not our fault for merging so much :) 15:20 < BlueMatt> heh, I hope it is :p 15:20 < BlueMatt> (though other projects are larger...) 15:26 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #11276: Update CONTRIBUTRING.md to reduce unnecesarry review workload (master...2017/09/cont) https://github.com/bitcoin/bitcoin/pull/11276 15:30 < wumpus> the IRC bot is definitely backlogged 15:30 < bitcoin-git> [bitcoin] laanwj closed pull request #11205: Make fixed CAmounts and related sanity function constexpr (master...refactor/constexpr-amount) https://github.com/bitcoin/bitcoin/pull/11205 15:32 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #11274: [tests] Cleanup wildcard imports in functional tests (master...cleanup-wildcard-in-functional-tests) https://github.com/bitcoin/bitcoin/pull/11274 15:32 < bitcoin-git> [bitcoin] ryanofsky opened pull request #11277: Fix uninitialized URI in batch RPC requests (master...pr/mb) https://github.com/bitcoin/bitcoin/pull/11277 15:33 -!- promag [~promag@2001:8a0:fe30:de01:1462:562:741b:14d5] has joined #bitcoin-core-dev 15:34 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.15: https://github.com/bitcoin/bitcoin/commit/d4c9d00e7e79958dea9586f927778dba2be8230a 15:34 < bitcoin-git> bitcoin/0.15 d4c9d00 Wladimir J. van der Laan: doc: Add PRs list to release notes... 15:38 -!- promag [~promag@2001:8a0:fe30:de01:1462:562:741b:14d5] has quit [Ping timeout: 255 seconds] 15:39 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/52f8877525d5...638e6c59da4f 15:39 < bitcoin-git> bitcoin/master aa2e0f0 Cory Fields: travis: filter out pyenv 15:39 < bitcoin-git> bitcoin/master 638e6c5 MarcoFalke: Merge #11271: travis: filter out pyenv... 15:39 -!- zenton [~user@13.232.15.37.dynamic.jazztel.es] has quit [Ping timeout: 260 seconds] 15:39 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #11271: travis: filter out pyenv (master...travis-fix-pyenv) https://github.com/bitcoin/bitcoin/pull/11271 15:41 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #11279: doc: Add missing contributors to release notes (0.15...Mf1708-doc015rel) https://github.com/bitcoin/bitcoin/pull/11279 15:44 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to 0.15: https://github.com/bitcoin/bitcoin/compare/d4c9d00e7e79...adcc788f2a89 15:44 < bitcoin-git> bitcoin/0.15 fad16a9 MarcoFalke: doc: Add missing contributors to release notes... 15:44 < bitcoin-git> bitcoin/0.15 adcc788 Wladimir J. van der Laan: Merge #11279: doc: Add missing contributors to release notes... 15:44 < bitcoin-git> [bitcoin] laanwj closed pull request #11279: doc: Add missing contributors to release notes (0.15...Mf1708-doc015rel) https://github.com/bitcoin/bitcoin/pull/11279 15:49 < meshcollider> in #11174, it says to add release notes for rescanning an encrypted wallet 15:49 < meshcollider> is that basically putting https://github.com/bitcoin/bitcoin/issues/11249 into the release notes 15:51 < MarcoFalke> meshcollider: pulls welcome :) 15:51 < meshcollider> yeah I'm working on it at the moment but I'm just trying to work out what gmaxwell's mental note meant ;) 15:51 < meshcollider> < gmaxwell> mental note: we need release notes on the topup stuff and instructions for rescanning 15:52 < meshcollider> Also should this be a new section in the release notes? 'Notes for 0.15.0' or something? 15:54 < wumpus> maybe at the beginning, after the upgrade/compatibility instructions 15:57 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 16:01 < bitcoin-git> [bitcoin] MeshCollider opened pull request #11280: [0.15] Final to-do's for 0.15.0 release notes (0.15...201709_release_note_015_todo) https://github.com/bitcoin/bitcoin/pull/11280 16:02 < bitcoin-git> [bitcoin] laanwj closed pull request #10756: net processing: swap out signals for an interface class (master...no-net-signals2) https://github.com/bitcoin/bitcoin/pull/10756 16:09 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 16:13 -!- cheese_ [~Cheeseo@unaffiliated/cheeseo] has quit [Ping timeout: 240 seconds] 16:15 -!- promag [~promag@2001:8a0:fe30:de01:1462:562:741b:14d5] has joined #bitcoin-core-dev 16:18 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/723e5806578b...efb4383ef6c6 16:18 < bitcoin-git> bitcoin/master 592404f MeshCollider: Changing &vec[0] to vec.data(), what 9804 missed 16:18 < bitcoin-git> bitcoin/master efb4383 Wladimir J. van der Laan: Merge #10793: Changing &var[0] to var.data()... 16:18 < bitcoin-git> [bitcoin] laanwj closed pull request #10793: Changing &var[0] to var.data() (master...prefer-vector-data) https://github.com/bitcoin/bitcoin/pull/10793 16:19 -!- promag [~promag@2001:8a0:fe30:de01:1462:562:741b:14d5] has quit [Ping timeout: 246 seconds] 16:21 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Quit: WeeChat 1.7.1] 16:21 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 16:24 -!- PRab [~chatzilla@c-68-56-234-28.hsd1.mi.comcast.net] has quit [Read error: Connection reset by peer] 16:33 < wumpus> can people please review https://github.com/bitcoin/bitcoin/pull/11280? (final release notes updates for 0.15.0) 16:33 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 16:37 < meshcollider> especially sipa and gmaxwell since they added the todo list :) 16:37 < wumpus> yes 16:38 < wumpus> I think this is the first time that tagging a release is blocked on the release notes :) 16:39 < sipa> haha 16:40 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #11281: Avoid pemanent cs_main/cs_wallet lock during RescanFromTime (master...2017/09/rescan_locks) https://github.com/bitcoin/bitcoin/pull/11281 16:41 < bitcoin-git> [bitcoin] MarcoFalke pushed 9 new commits to master: https://github.com/bitcoin/bitcoin/compare/efb4383ef6c6...791a0e6ddade 16:41 < meshcollider> hmm i'm not sure how to fix instagibbs comment, it would sound weird to just say "(this is not a regression)" right 16:41 < bitcoin-git> bitcoin/master 9c76ba1 John Newbery: [wallet] Rename InitLoadWallet() to OpenWallets()... 16:41 < bitcoin-git> bitcoin/master 1b9cee6 John Newbery: [wallet] Rename WalletVerify() to VerifyWallets()... 16:41 < bitcoin-git> bitcoin/master 2da5eaf John Newbery: [wallet] Add FlushWallets() function to wallet/init.cpp 16:42 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #10767: [wallet] Clarify wallet initialization / destruction interface (master...walletinit2) https://github.com/bitcoin/bitcoin/pull/10767 16:42 -!- Deadhand [~deadhand@2607:fea8:e380:10f::7] has quit [Ping timeout: 246 seconds] 16:42 < meshcollider> actually dw I think I've got it 16:45 -!- Deadhand [~deadhand@2607:fea8:e380:10f::7] has joined #bitcoin-core-dev 16:52 < meshcollider> All good to go? Cancel travis again if you want :) 16:53 < luke-jr> wumpus: well, to be fair, IMO it *should* be blocked on the hiding GUI issue <.< 16:54 < meshcollider> wouldn't that require an rc4 though? 16:54 < luke-jr> yes :/ 16:56 < meshcollider> According to discussion in #11245 it might have been fixed somehow upstream or something 16:57 < meshcollider> no one is really sure so I don't think blocking release on that would be worth it, the fix can get in to 0.15.1 anyway 17:00 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-mvsvivgijxndkhjb] has quit [Read error: Connection reset by peer] 17:00 < wumpus> luke-jr: no, it's not even clear the issue exists on the rc binaries, jonasschnelli tried on a few windows VMs andcouldn't reproduce with the rcs 17:00 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-tjiwyfzsnftuhazp] has joined #bitcoin-core-dev 17:01 < jonasschnelli> luke-jr: I could reproduce the GUI offset issue with 0.14.1 on Win7, 8.1 and 10. But 0.15.0rc2 did not had the issue anymore. 17:01 < jonasschnelli> Either its fixed in Qt5.7 or without our sources 17:02 < jonasschnelli> It may still happen to users compiling with an older Qt version (not confirmed) 17:02 < jonasschnelli> (like the tray icon but, etc.) 17:02 < luke-jr> hmm 17:02 < wumpus> yes don't get started on the tray icon... :p 17:03 < luke-jr> can we contact the users who experienced it in RCs, and confirm their setup? 17:03 < luke-jr> gmaxwell said he knew of at least a few 17:05 < midnightmagic> jonasschnelli: Is there somewhere that you've more-strongly linked your GPG key to yourself? Maybe a video or something? 17:05 < wumpus> a gpg key video? lol 17:07 < wumpus> if it is an issue in 0.14.1 it's not a regression in 0.15 anyhow 17:07 < wumpus> there's 0 reasons to hold the release for it, sorry 17:07 < luke-jr> just strange that the reports came in when 0.15rc was out 17:07 < midnightmagic> wumpus: :-) peter todd did one where he reads out the fingerprint. 17:08 < luke-jr> midnightmagic: jonas has lots of signatures on his key :P 17:08 < meshcollider> gmaxwell did you see instagibbs comment on #11280 17:08 < meshcollider> there is no rescan RPC 17:09 < jonasschnelli> midnightmagic: a video? 17:10 < jonasschnelli> there are tons of merges and commits with my GPG signature... what would a video improve? 17:10 < jonasschnelli> There will soon be a video from the SF bitcoin dev meetup with my key fingerprint on the slides. 17:10 < jonasschnelli> That may help 17:11 * luke-jr modifies the slides in that video /s 17:11 < wumpus> no, there is no rescan RPC, just the command line argument 17:12 < midnightmagic> luke-jr: yep. secondary trust is sort of meaningless to me in this context 17:12 < luke-jr> also rescanning isn't possible for pruned nodes? 17:12 < meshcollider> so what's gmaxwell talking about in his comment, if restarting with -rescan won't work with encrypted wallets then is there no fix? 17:12 < wumpus> import* have a 'rescan' argument but I'm not sure that's what is meant 17:12 < luke-jr> I think the "fix" is to unlock the wallet immediately when it starts? 17:13 < meshcollider> nah I doubt that's what he meant, would be pretty hacky if people were required to use an import command to get the rescan going 17:13 < jonasschnelli> There is a rescan RPC call PR: https://github.com/bitcoin/bitcoin/pull/7061 17:13 < jonasschnelli> (begs for reviews) 17:14 < jonasschnelli> with that rescans would be possible for pruned peers (if one wants to rescan not below the pruned depth) 17:15 < meshcollider> hmm yeah that'd be good, I'll review that later too, but that means we have no fix for 0.15.0? 17:16 < meshcollider> Should I remove that section from the notes entirely or just make a note that support for rescanning will come in a new version 17:16 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 17:16 < gmaxwell> meshcollider: you can rescan from RPC. 17:16 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 17:16 < meshcollider> using import commands? 17:16 < gmaxwell> you can use yea.. 17:16 < gmaxwell> importmulti 17:17 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 17:17 < wumpus> importmulti without any actual keys or so? 17:17 < wumpus> that definitely needs to be documented, I was not aware of that 17:17 < gmaxwell> but indeed I was forgetting that there is no freestanding 'rescan'. 17:17 < jonasschnelli> with a dummy key/address generated in bip32.org or so 17:17 < gmaxwell> you can scan with a dummy. 17:17 < gmaxwell> which I guess we need to suggest. :( 17:18 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 17:18 < meshcollider> importmulti [] {"rescan":true} 17:18 < meshcollider> empty array will work or nah? 17:18 < meshcollider> it doesnt seem to throw any errors 17:18 < jonasschnelli> i don't think so 17:19 < gmaxwell> It won't rescan if there is nothing to do. 17:20 < wumpus> that kind of makes sense, though it's sad in this case 17:20 < midnightmagic> .../lastlog jonasschnelli 17:21 < midnightmagic> sorry 17:21 < luke-jr> jonasschnelli: ! no:| 17:21 < jonasschnelli> aha. :) 17:21 < luke-jr> importing random untrusted stuff is not safe and should definitely not be advised.. 17:21 < wumpus> there are certainly some risks to that 17:22 < midnightmagic> jonasschnelli: Yes. That SF bitcoin meetup is perfect. That's neat that peter todd stuffed a blockchain hash into his signature in a certificate notation. I wonder if I'm the only one that's actually checked that. :-) 17:22 < jonasschnelli> Yes. Indeed. You may import a random address from another wallet to trigger a rescan 17:22 < jonasschnelli> But that's why we need #7061 17:22 < jonasschnelli> We are claiming rescans are not required since years... but it seems like they are 17:23 < midnightmagic> jonasschnelli: The consistency of the signatures is not an identity verification of the guy that everyone else has met (but I have not.) :-) 17:24 < jonasschnelli> midnightmagic: happy to drink a coffee with you somewhere in the world. 17:24 < midnightmagic> I would be happy to have a coffee with you if we are ever in the same place together. \o 17:25 < jonasschnelli> That's the difficulty... indeed 17:27 < meshcollider> something like this fine then? https://github.com/bitcoin/bitcoin/pull/11280 17:27 < luke-jr> so encrypted HD backup tl;dr = no solution? 17:27 < meshcollider> no good solution, yeah, they'd have to load another wallet, generate a dummy address, then load their encrypted one and import with rescan 17:28 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/791a0e6ddade...c22a53cd6351 17:28 < bitcoin-git> bitcoin/master d4c18f7 Andrew Chow: Bump wallet version number to 159900 17:28 < bitcoin-git> bitcoin/master 713a920 Andrew Chow: Remove usehd option and warn when it is used... 17:28 < bitcoin-git> bitcoin/master c22a53c Wladimir J. van der Laan: Merge #11250: Bump wallet version to 159900 and remove the `usehd` option... 17:29 < bitcoin-git> [bitcoin] laanwj closed pull request #11250: Bump wallet version to 159900 and remove the `usehd` option (master...bump-wallet-version) https://github.com/bitcoin/bitcoin/pull/11250 17:30 < luke-jr> not sure if release notes are really the place for hacky workarounds for long-standing issues 17:30 < wumpus> meshcollider: thanks for doing 11280, seems it's more work than planned for 17:30 < wumpus> how long-standing? 17:31 < meshcollider> thats fine :) Yeah I'm happy to remove the rescan stuff if needed 17:31 < luke-jr> ever since HD wallets were introduced? 17:31 < meshcollider> Yeah ^ and it will be a hacky-fix-issue until the rescan RPC is merged I guess which means we should all go review jonas's PR asap lol 17:32 < wumpus> well a hacky workaround is better than losing funds 17:32 -!- promag [~promag@2001:8a0:fe30:de01:1462:562:741b:14d5] has joined #bitcoin-core-dev 17:32 < luke-jr> wumpus: right, but it's not a new issue, so maybe it should just be a blog post or smth? 17:33 < meshcollider> True, people can still ask for support on stackexchange or whatever though, doesn't have to be in the release notes I guess 17:33 * luke-jr watches wumpus put his laptop away 17:33 < meshcollider> Has anyone reported having issues with it so far or is it just a 'could happen' 17:35 < meshcollider> Well, my vote is to leave it in there, having a short Notes/Known Issues section in each release notes is quite a nice idea anyway imo 17:35 < luke-jr> meshcollider: we're all packing up and leaving, so expect a delay in response 17:36 -!- promag [~promag@2001:8a0:fe30:de01:1462:562:741b:14d5] has quit [Ping timeout: 246 seconds] 17:39 -!- hxz [~hxz@219.156.117.181] has joined #bitcoin-core-dev 17:40 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 17:51 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 17:51 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 17:55 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Quit: Leaving.] 19:02 -!- zmin [~zmin@d50-93-44-136.abhsia.telus.net] has joined #bitcoin-core-dev 19:14 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev 19:41 -!- promag [~promag@2001:8a0:fe30:de01:1462:562:741b:14d5] has joined #bitcoin-core-dev 19:45 -!- promag [~promag@2001:8a0:fe30:de01:1462:562:741b:14d5] has quit [Ping timeout: 255 seconds] 19:46 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 20:03 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 20:15 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has joined #bitcoin-core-dev 21:01 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has quit [Quit: .] 21:02 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has joined #bitcoin-core-dev 21:09 -!- hxz [~hxz@219.156.117.181] has quit [Ping timeout: 248 seconds] 21:30 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 252 seconds] 21:34 -!- jtimon [~quassel@199.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds] 21:45 -!- otoburb [~otoburb@unaffiliated/otoburb] has quit [Quit: leaving] 22:02 -!- Gunnie [~kamk@65.82.cust.tetanet.cz] has joined #bitcoin-core-dev 22:03 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has quit [Ping timeout: 240 seconds] 22:03 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has joined #bitcoin-core-dev 22:30 < bitcoin-git> [bitcoin] ajtowns opened pull request #11284: Fix invalid memory access in CScript::operator+= (master...cscript_insert) https://github.com/bitcoin/bitcoin/pull/11284 22:33 -!- zmin [~zmin@d50-93-44-136.abhsia.telus.net] has quit [Quit: Leaving] 22:35 -!- Pebblesbaby [6b4df50a@gateway/web/freenode/ip.107.77.245.10] has joined #bitcoin-core-dev 22:37 -!- Pebblesbaby [6b4df50a@gateway/web/freenode/ip.107.77.245.10] has quit [Client Quit] 22:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 248 seconds] 22:50 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 23:25 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Ping timeout: 240 seconds] 23:34 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev