--- Day changed Wed Oct 04 2017 00:00 -!- timothy [~tredaelli@redhat/timothy] has quit [Client Quit] 00:03 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 00:09 -!- jtimon [~quassel@199.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds] 00:44 -!- laurentmt [~Thunderbi@92.154.68.134] has joined #bitcoin-core-dev 00:50 -!- JackH [~laptop@2a02:a210:2e00:300:655a:7cbf:d627:81fb] has quit [Ping timeout: 264 seconds] 00:50 -!- geezas [uid253218@gateway/web/irccloud.com/x-vzqyvxcgqsysdppq] has quit [Quit: Connection closed for inactivity] 00:56 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:57 -!- Emcy [~MC@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 01:01 -!- JackH [~laptop@46.231.18.66] has joined #bitcoin-core-dev 01:20 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 01:25 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:43 -!- vicenteH [~user@195.235.96.150] has joined #bitcoin-core-dev 01:47 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-wanthhgpospxbewo] has joined #bitcoin-core-dev 01:59 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 02:31 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 02:37 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev 02:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:38 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 02:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 02:40 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:40 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 02:41 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:41 -!- EricCartman [~EricCartm@81.202.149.143.dyn.user.ono.com] has joined #bitcoin-core-dev 02:44 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds] 02:56 -!- wxxs_ [~chatzilla@37.58.58.238] has joined #bitcoin-core-dev 02:57 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 02:58 -!- wxxs [~chatzilla@45.248.79.254] has quit [Ping timeout: 240 seconds] 02:58 -!- wxxs_ is now known as wxxs 03:15 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 03:20 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 03:21 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 03:35 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 03:36 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 03:38 -!- W4RL0RD [~W4RL0RD@jh147.perfectdeals.xyz] has joined #bitcoin-core-dev 03:40 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/093074b84395...9ccafb1d7bdd 03:40 < bitcoin-git> bitcoin/master fd86f99 MarcoFalke: Squashed 'src/secp256k1/' changes from 84973d393..0b7024185... 03:40 < bitcoin-git> bitcoin/master 999968e MarcoFalke: Bump secp256k1 subtree 03:40 < bitcoin-git> bitcoin/master 9ccafb1 MarcoFalke: Merge #11421: Merge current secp256k1 subtree... 03:40 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #11421: Merge current secp256k1 subtree (master...Mf1709-subtree-secp256k1) https://github.com/bitcoin/bitcoin/pull/11421 03:58 -!- pbase [~pbase@unaffiliated/pbase] has joined #bitcoin-core-dev 04:06 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-aqlusmopxxvuazmt] has quit [Quit: Connection closed for inactivity] 04:09 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 04:38 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 04:39 -!- pbase [~pbase@unaffiliated/pbase] has quit [Quit: Leaving] 04:44 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 04:45 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 04:48 -!- mkarrer [~mkarrer@64.209.30.59] has joined #bitcoin-core-dev 04:52 -!- mkarrer [~mkarrer@64.209.30.59] has quit [Ping timeout: 240 seconds] 05:01 -!- mkarrer [~mkarrer@64.209.30.59] has joined #bitcoin-core-dev 05:04 -!- drnet [~drnett@178.165.129.199.wireless.dyn.drei.com] has joined #bitcoin-core-dev 05:05 -!- mkarrer [~mkarrer@64.209.30.59] has quit [Remote host closed the connection] 05:05 -!- mkarrer [~mkarrer@64.209.30.59] has joined #bitcoin-core-dev 05:15 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 05:23 -!- mkarrer [~mkarrer@64.209.30.59] has quit [] 05:26 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 248 seconds] 05:26 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/9ccafb1d7bdd...a4c833fec104 05:26 < bitcoin-git> bitcoin/master fae2673 MarcoFalke: qa: check-rpc-mapping must not run on empty lists 05:26 < bitcoin-git> bitcoin/master fae60e3 MarcoFalke: qa: Fix lcov for out-of-tree builds 05:26 < bitcoin-git> bitcoin/master a4c833f Wladimir J. van der Laan: Merge #11443: [qa] Allow "make cov" out-of-tree; Fix rpc mapping check... 05:26 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 05:27 < bitcoin-git> [bitcoin] laanwj closed pull request #11443: [qa] Allow "make cov" out-of-tree; Fix rpc mapping check (master...Mf1710-qaFixups) https://github.com/bitcoin/bitcoin/pull/11443 05:36 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a4c833fec104...e12522dfdaab 05:36 < bitcoin-git> bitcoin/master 6643b80 Matt Corallo: Add state message print to AcceptBlock failure message.... 05:36 < bitcoin-git> bitcoin/master e12522d Wladimir J. van der Laan: Merge #11406: Add state message print to AcceptBlock failure message.... 05:37 < bitcoin-git> [bitcoin] laanwj closed pull request #11406: Add state message print to AcceptBlock failure message. (master...2017-09-checkblock-fail-print) https://github.com/bitcoin/bitcoin/pull/11406 05:47 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 05:47 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 05:48 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection] 05:54 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/e12522dfdaab...a1f7f1870931 05:54 < bitcoin-git> bitcoin/master 6fb8f5f practicalswift: Check that -blocknotify command is non-empty before executing... 05:54 < bitcoin-git> bitcoin/master cffe85f practicalswift: Skip sys::system(...) call in case of empty command 05:54 < bitcoin-git> bitcoin/master a1f7f18 Wladimir J. van der Laan: Merge #10939: [init] Check non-emptiness of -blocknotify command prior to executing... 05:55 < bitcoin-git> [bitcoin] laanwj closed pull request #10939: [init] Check non-emptiness of -blocknotify command prior to executing (master...blocknotify-consistentcy) https://github.com/bitcoin/bitcoin/pull/10939 05:59 < bitcoin-git> [bitcoin] laanwj closed pull request #10233: Wallet: Support not reusing addresses (master...freezea) https://github.com/bitcoin/bitcoin/pull/10233 06:01 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a1f7f1870931...7f11ef260855 06:01 < bitcoin-git> bitcoin/master 0cd9273 Wladimir J. van der Laan: rpc: Prevent `dumpwallet` from overwriting files... 06:01 < bitcoin-git> bitcoin/master 7f11ef2 Wladimir J. van der Laan: Merge #9937: rpc: Prevent `dumpwallet` from overwriting files... 06:02 < bitcoin-git> [bitcoin] laanwj closed pull request #9937: rpc: Prevent `dumpwallet` from overwriting files (master...2017_03_walletdump_nooverwrite) https://github.com/bitcoin/bitcoin/pull/9937 06:03 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7f11ef260855...74123eabdd91 06:03 < bitcoin-git> bitcoin/master 96c2ce9 Matt Corallo: Fix validationinterface build on super old boost/clang... 06:03 < bitcoin-git> bitcoin/master 74123ea Wladimir J. van der Laan: Merge #11440: Fix validationinterface build on super old boost/clang... 06:03 < bitcoin-git> [bitcoin] laanwj closed pull request #11440: Fix validationinterface build on super old boost/clang (master...2017-10-cblock-validationinterface) https://github.com/bitcoin/bitcoin/pull/11440 06:12 -!- drnet [~drnett@178.165.129.199.wireless.dyn.drei.com] has quit [Quit: Leaving] 06:13 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-wanthhgpospxbewo] has quit [Quit: Connection closed for inactivity] 06:36 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/74123eabdd91...167cef8082e2 06:36 < bitcoin-git> bitcoin/master f35d033 practicalswift: build: Make "make clean" remove all files created when running "make check"... 06:36 < bitcoin-git> bitcoin/master 167cef8 Wladimir J. van der Laan: Merge #11435: build: Make "make clean" remove all files created when running "make check"... 06:36 < bitcoin-git> [bitcoin] laanwj closed pull request #11435: build: Make "make clean" remove all files created when running "make check" (master...make-cleaner) https://github.com/bitcoin/bitcoin/pull/11435 06:38 < bitcoin-git> [bitcoin] laanwj closed pull request #11046: Replace boost sleep_for with C++11 equivalent (master...2017/08/boost_sleep_for) https://github.com/bitcoin/bitcoin/pull/11046 06:39 < bitcoin-git> [bitcoin] laanwj closed pull request #10990: 0 locktime issue (master...fix0locktimebug) https://github.com/bitcoin/bitcoin/pull/10990 06:49 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 06:57 < promag> should we have only one BitcoinTestFramework subclass in each test file? 07:02 < MarcoFalke> I'd prefer so. Otherwise you'd have to run them sequentially and a failure of the first causes the others not to run. 07:03 < MarcoFalke> Also would be confusing to have (potentially) different topologies set in a single file 07:03 < promag> Regarding #10941, I think we can merge -(alert|block|wallet)notify tests later 07:03 < gribble> https://github.com/bitcoin/bitcoin/issues/10941 | Add blocknotify functional test by promag · Pull Request #10941 · bitcoin/bitcoin · GitHub 07:04 < promag> but at the moment each one has different network setups and params 07:05 < promag> I think merging those tests deserve a separate PR 07:10 -!- Tank4910 [b89bd0d3@gateway/web/freenode/ip.184.155.208.211] has joined #bitcoin-core-dev 07:10 -!- Tank4910 [b89bd0d3@gateway/web/freenode/ip.184.155.208.211] has left #bitcoin-core-dev [] 07:18 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Quit: WeeChat 1.4] 07:25 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 07:31 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has joined #bitcoin-core-dev 07:33 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Ping timeout: 246 seconds] 07:35 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev 07:39 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.] 07:47 -!- bitsko [~user@198.57.47.100] has joined #bitcoin-core-dev 07:49 -!- sanada [~bitktn@36-2-119-80.chiba.ap.gmo-isp.jp] has quit [] 07:50 < bitcoin-git> [bitcoin] promag closed pull request #11439: [test] Refactor ZMQ test to use one address per notification type (master...2017-10-clean-zmq-test) https://github.com/bitcoin/bitcoin/pull/11439 07:52 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 255 seconds] 07:54 < promag> jnewbery: ScanForWalletTransactions interface is a bit weird 07:54 -!- sanada [~bitktn@36-2-119-80.chiba.ap.gmo-isp.jp] has joined #bitcoin-core-dev 07:54 < promag> I think it should return the last block scanned 07:55 < promag> and also *all* failed blocks 07:55 < promag> not sure why only the most recent is useful 08:07 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 08:08 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 08:10 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has joined #bitcoin-core-dev 08:10 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has quit [Ping timeout: 248 seconds] 08:11 -!- wraithm [~wraithm@unaffiliated/wraithm] has joined #bitcoin-core-dev 08:12 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 08:39 -!- JackH [~laptop@46.231.18.66] has quit [Ping timeout: 255 seconds] 08:40 -!- Emcy [~MC@unaffiliated/emcy] has joined #bitcoin-core-dev 08:43 -!- sanada [~bitktn@36-2-119-80.chiba.ap.gmo-isp.jp] has quit [] 08:43 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has quit [] 08:44 -!- mess110 [~kiki@78.97.218.2] has joined #bitcoin-core-dev 08:49 -!- sanada [~bitktn@36-2-119-80.chiba.ap.gmo-isp.jp] has joined #bitcoin-core-dev 08:51 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 09:08 -!- jtimon [~quassel@199.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 09:13 -!- bitsko [~user@198.57.47.100] has quit [Quit: WeeChat 1.4] 09:16 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 09:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 09:22 -!- jb55 [~jb55@208.98.200.100] has joined #bitcoin-core-dev 09:28 -!- mess110 [~kiki@78.97.218.2] has quit [Remote host closed the connection] 09:28 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 09:32 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-tcpcyonbvlfseprt] has joined #bitcoin-core-dev 09:56 -!- timothy [tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 09:58 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev 10:00 -!- timothy [tredaelli@redhat/timothy] has quit [Client Quit] 10:02 -!- laurentmt [~Thunderbi@92.154.68.134] has quit [Quit: laurentmt] 10:15 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 10:15 -!- pergaminho [~Cleber@201.47.91.172] has joined #bitcoin-core-dev 10:20 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 10:28 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 10:33 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 10:34 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 10:35 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Write error: Connection reset by peer] 10:35 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Read error: Connection reset by peer] 10:35 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Read error: Connection reset by peer] 10:35 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Read error: Connection reset by peer] 10:35 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Write error: Connection reset by peer] 10:36 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 10:36 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 10:36 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev 10:39 -!- lifeofguenter [~lifeofgue@bnc.pro.to.co.ls] has quit [Ping timeout: 240 seconds] 10:39 -!- W4RL0RD [~W4RL0RD@jh147.perfectdeals.xyz] has quit [Remote host closed the connection] 10:40 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 10:40 -!- lifeofguenter [~lifeofgue@bnc.pro.to.co.ls] has joined #bitcoin-core-dev 10:45 -!- vicenteH [~user@195.235.96.150] has quit [Ping timeout: 260 seconds] 10:52 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection] 10:53 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 10:56 < jonasschnelli> Hopefully we can merge #7061 soon. (178 comments, open since almost two years)... :) 10:56 < gribble> https://github.com/bitcoin/bitcoin/issues/7061 | [Wallet] Add RPC call "rescanblockchain " by jonasschnelli · Pull Request #7061 · bitcoin/bitcoin · GitHub 10:56 < jonasschnelli> Needs some reacks 10:59 -!- Emcy [~MC@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 11:21 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev 11:21 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 12:09 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-bzedwblvcvztvknm] has joined #bitcoin-core-dev 12:11 -!- Emcy [~MC@unaffiliated/emcy] has joined #bitcoin-core-dev 12:22 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 12:23 < meshcollider> How long does it normally take before changes to bitcoincore.org repo go live 12:30 -!- mkarrer [~mkarrer@ip-2-61-102-190.netblk.digicelpanama.net] has joined #bitcoin-core-dev 12:37 < cfields> jonasschnelli: very late pong 12:37 < jonasschnelli> Heh... 12:37 < jonasschnelli> It's now in a comment... let me link you 12:38 < jonasschnelli> https://github.com/bitcoin/bitcoin/pull/10387#pullrequestreview-66842269 12:38 < jonasschnelli> meshcollider: ask BlueMatt. But the recent merged 0.15.0.1 changes are online 12:39 < BlueMatt> meshcollider: like....60 seconds? 12:39 < BlueMatt> unless someone fucked up the commit signatures, which folks are want to do 12:39 < BlueMatt> err, wont to do 12:40 -!- mkarrer [~mkarrer@ip-2-61-102-190.netblk.digicelpanama.net] has quit [] 12:43 < cfields> jonasschnelli: sounds good to me 12:44 < jonasschnelli> okay... there is still an issue... will fix soon, so wait with looking at the code 12:44 < cfields> I'd really rather see fLimitedNode in CNodeState though :( 12:44 < cfields> BlueMatt: thoughts on starting to migrate that way? 12:44 < cfields> (see above link for reference) 12:45 < BlueMatt> whats context? 12:45 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Ping timeout: 248 seconds] 12:46 < cfields> BlueMatt: a bool to indicate whether or not a node is limited. Stored during version. Pretty much same use case as fPreferred 12:47 -!- jb55 [~jb55@208.98.200.100] has quit [Ping timeout: 255 seconds] 12:48 < meshcollider> BlueMatt: jonasschnelli Oh I didn't see it because the 0.15.0.1 release announcement isn't in the recent posts list 12:48 < cfields> I think just used to avoid fetching old blocks. presumably jonasschnelli stuck it in CNode because that's where fClient lives (but shouldn't) 12:49 < BlueMatt> meshcollider: we only fixed it like an hour or three ago 12:49 < jonasschnelli> cfields: would always checking nServices be terrible? (instead of caching a boolen)? 12:49 < BlueMatt> cfields: so, wait, you want to add an fLimitedNode in addition to the fPreferred stuff? why not just adapt UpdatePreferredDownload to consider limited-ness and call it on our peers in the first UpdatedBlockTip with not-fInitialDownload? 12:51 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev 12:52 < BlueMatt> you may be stuck in ibd for a while, there isnt much point in filling your outbound peers with limited nodes for that duration 12:52 < BlueMatt> or am I missing something? 12:54 < BlueMatt> grr, I'll go review the pr and give real feedback instead of bullshitting, give me 20 minutes 12:55 < cfields> My initial thought was to tie it to preferred as well, but iirc that broke down somewhere 12:56 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 12:56 < cfields> I was also thinking that we'd want to avoid pruned nodes for initial headers sync, but I guess that's not really necessary 12:58 < cfields> BlueMatt: generally though, I really dislike expanding the scope of variables like that. eventualy fPreferred turns into something entirely meaningless like "whitelisted" 13:05 < jonasschnelli> Okay. Updated the PR 13:05 < jonasschnelli> Relevant parts are here: https://github.com/bitcoin/bitcoin/pull/10387/files#diff-eff7adeaec73a769788bb78858815c91R1322 13:13 < jonasschnelli> ping JeremyRu1in 13:14 < jonasschnelli> My re-check / re-test told me, rescanblockchain { start_height: 10, stop_height: 20 } does also rescan block 20 13:17 -!- jb55 [~jb55@208.98.200.100] has joined #bitcoin-core-dev 13:18 -!- JeremyRu1in is now known as JeremyRubin 13:19 < JeremyRubin> jonasschnelli: it doesn't work; see PR comment 13:19 < JeremyRubin> it's the failure mode that's broken, I should have been more clear 13:19 < JeremyRubin> but I was confused about the general range semantics too; so more clear language is good there nonetheless 13:27 < JeremyRubin> jonasschnelli: try scanning from 10 - 20 on a healthy node 13:27 < JeremyRubin> then, corrupt block 20 so it won't scan. 13:27 < JeremyRubin> now, rescan again 13:27 < JeremyRubin> same result 13:27 < JeremyRubin> now, corrupt blocks 10-20 13:27 < JeremyRubin> will return the same thing 13:28 < jonasschnelli> JeremyRubin: I added a LogPrintf below the ReadBlockFromDisk and AddToWalletIfInvolvingMe scan... and block 20 was scanned. 13:28 < jonasschnelli> But maybe I should try your setup 13:28 < BlueMatt> jonasschnelli: will you kill me if I suggest a cleanup to nRequiredServices/nRelevantServices as a first commit in your pr? 13:29 * BlueMatt feels like he's pulling a cfields here :p 13:29 < JeremyRubin> jonasschnelli: Yes, if your scanning does not fail, it is fine. 13:29 < jonasschnelli> BlueMatt: ideally we keep cleanups in a seperate PR 13:29 < BlueMatt> not like cfields ever requires it for others, but endless first-commit cleanups 13:29 < JeremyRubin> But if you have a corruption, it is not. 13:29 < jonasschnelli> BlueMatt: but I can cherry pick.. :) 13:29 < cfields> heh 13:29 < BlueMatt> jonasschnelli: let me play around a bit 13:29 < jonasschnelli> JeremyRubin: what do you mean with corruption? 13:29 < cfields> BlueMatt: only allowed if you first ack my socket changes you required :p 13:29 < jonasschnelli> invalidateblock? 13:30 < ryanofsky> jonasschnelli, if readblockfrom disk fails 13:30 < jonasschnelli> BlueMatt: yeah. Happy to pull-in a cleanup into bip159 PR 13:30 < BlueMatt> cfields: damn you 13:30 -!- jtimon [~quassel@199.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 248 seconds] 13:31 < cfields> jonasschnelli: oh that reminds me, what do you think about adding "NODE_NETWORK should be combined with NODE_NETWORK_LIMITED" to the bip (if not already) ? 13:31 < cfields> I don't think that's just an implementation detail 13:31 < jonasschnelli> JeremyRubin, ryanofsky: aha... a filed ReadBlockFromDisk falsely reports a successful scan. 13:32 < jonasschnelli> cfields: Yeah. Need to add this... is unclear in the BIP 13:32 < JeremyRubin> No 13:32 < jonasschnelli> *a failed 13:32 < JeremyRubin> It correctly reports an unsuccessful scan 13:32 < jonasschnelli> yeah.. what I meant. sry 13:32 < JeremyRubin> you incorrectly interpret that result :) 13:33 < JeremyRubin> basically ANY non-nullptr return should cause you to return "scan failed" 13:33 < jonasschnelli> JeremyRubin: this would also be undetected in classic startup -rescans? Right? 13:33 < JeremyRubin> Unsure of prior semantics of rescan 13:34 -!- vicenteH [~user@93.104.135.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 13:34 < JeremyRubin> it would be reported that you have only succeeded in scanning blocks after LAST_FAILED, so then you would need to rescan up to LAST_FAILED 13:34 < jonasschnelli> the current rescan function skips corrupted blocks IMO 13:35 < JeremyRubin> Yes, but it also tells you 'no guarantees before block N' 13:35 < JeremyRubin> where N = LAST_FAILED 13:36 < JeremyRubin> this impl, however, is happy to tell you Blocks A-B succeded 13:36 < JeremyRubin> which is incorrect 13:37 < jonasschnelli> I see.. let me see how we can fix this. 13:37 < JeremyRubin> you have 2 choices I think 13:37 < jonasschnelli> I don't want to change the way how current startup -rescans work.. 13:37 < JeremyRubin> either keep a vector of all failures 13:37 < jonasschnelli> aborting on a corrupted block seems not to be the ideal choice 13:38 < JeremyRubin> if passed in as a ptr arg with default nullptr 13:38 < JeremyRubin> And return a vector of failures 13:38 < jonasschnelli> or report "could not read all block" (bool)? 13:38 < JeremyRubin> That could work too... 13:39 < JeremyRubin> I would (personally) not return *anything* if there are any failures. 13:39 < jonasschnelli> AFAIK, ScanForWalletTransactions returns non-nullptr when detecting a corrupt block.. could use that 13:41 < JeremyRubin> yes, that's fine. I would return a `Maybe (Int,Int)`, and only return `Some (start, stop)` if there are no failures. 13:42 < JeremyRubin> I would also push you to rework the errors to differentiate when the numbers are actually invalid v.s. out of range for the current chain we're on. 13:43 < JeremyRubin> Because asking for (1000, 2000) could fail depending on how caught up you are. 13:44 < JeremyRubin> But is not an invalid request like (2000,1000), (-10, 20), etc. 13:45 < JeremyRubin> (in particular, because I think that it would be useful to issue a rescan from, let's say, (tip-10, tip+1000) and for it to return (tip-10, tip) 13:48 < jonasschnelli> JeremyRubin: I think that should do it: https://github.com/bitcoin/bitcoin/pull/7061/files#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceR3237 13:50 < JeremyRubin> jonasschnelli: I think that seems correct to me. If you have no failures reported, then all the blocks were scanned in that range 13:50 < jonasschnelli> Yes. If you get this (new) error, you may have scanned some of the blocks (but we won't tell which one) 13:51 < JeremyRubin> Correct. 13:51 < jonasschnelli> If you have a corrupted block you are alreafy in serious troubles... :) 13:51 < JeremyRubin> Yes. Maybe worth saying 'Rescan Failed. Potentially corruputed data files.' 13:52 < jonasschnelli> JeremyRubin: Thanks... let me add this 13:53 < JeremyRubin> jonasschnelli: my comment about handling of invalid ranges though still stands. differentiating between the cases of overlap is good, an you can return useful results in some of them. 13:54 < jonasschnelli> JeremyRubin: can you rephrase? I don't get your range concern 13:54 < JeremyRubin> bad ranges: ()[] ([)] good ranges: [()] ok ranges: [(]) []() 13:54 < jonasschnelli> ? 13:55 < JeremyRubin> (let '(' and ')' denote the start and stop range, and '[' and ']' denote genesis to tip on a number line) 13:55 < jonasschnelli> aha... 13:55 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 13:55 < JeremyRubin> so if i ask for (tip -10, tip+100) you should return scanned (tip-10, tip) 13:55 < jonasschnelli> stop_height is optional but start_heigt is required when stop_height is passed 13:56 < jonasschnelli> I think tip+100 should result in an error 13:56 < JeremyRubin> I don't 13:56 < JeremyRubin> because it could result from our node just being behind and syncing 13:57 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 13:57 < jonasschnelli> Yeah.. but would you silently ignore it? IMO it deserves that we inform the user (with an error) 13:57 < JeremyRubin> If you want it to be an error, it shouldn't be invalid it should be 'not synced to X yet' 13:57 < jonasschnelli> Then he can self-correct rather then auto-correct 13:57 -!- pergaminho [~Cleber@201.47.91.172] has quit [Quit: Saindo] 13:57 < JeremyRubin> if you want it to be more clear, then you should always return the current tip 13:58 < JeremyRubin> but in the 'ok ranges' cases, the type of failure is very different from the bad ranges 13:59 < JeremyRubin> bad ranges will NEVER succeed, ok ranges will succeed if you wait long enough 13:59 < JeremyRubin> So bad ranges are invalid. ok ranges are too 'soon' for our node. 14:00 -!- jtimon [~quassel@199.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 14:01 < JeremyRubin> And if you don't want to support ok ranges, then there is no point of returning the range scanned at all, you may as well return `Maybe ()` because success means the range was scanned. 14:02 < JeremyRubin> ((unless I'm not seeing some edge case? Maybe if you somehow trigger an abortrescan you would return (start, point_aborted)?)) 14:02 < jonasschnelli> JeremyRubin: but with the current fix (throw when getting a non-nullptr) there is a guarantee we have scanned the given range, right? 14:02 < JeremyRubin> Correct! 14:02 < jonasschnelli> Do you see anything else t 14:02 < jonasschnelli> to fix? 14:02 < JeremyRubin> ((Except see above abortrescan concern)) 14:03 < jonasschnelli> abortrescan leads to an explicit error thrown 14:03 < JeremyRubin> ok -- so then no point in returning the range 14:03 < jonasschnelli> https://github.com/bitcoin/bitcoin/pull/7061/files#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceR3231 14:03 < JeremyRubin> so remove the return values 14:03 < jonasschnelli> the throw will lead to not return the range 14:04 < JeremyRubin> Actually... making abortrescan return the range seems like good UX 14:04 < jonasschnelli> We could add that later,.. seems out of scope and related to #11450 14:04 < gribble> https://github.com/bitcoin/bitcoin/issues/11450 | ScanForWalletTransactions return value is incorrectly documented · Issue #11450 · bitcoin/bitcoin · GitHub 14:05 < JeremyRubin> k -- so otherwise, you should get rid of the return values. 14:05 < jtimon> I really don't get it, if someone else can try to explain, that would be welcomed re https://github.com/bitcoin/bitcoin/pull/11427#issuecomment-334033122 14:05 < JeremyRubin> Unless you want to handle the ranges I've labelled 'ok' 14:05 < jonasschnelli> You are aware that a *throw" will lead to return nothing blow that acctuall throw code line? 14:05 < JeremyRubin> (which, even if not handled, I think merit a separate designation from 'invalid') 14:06 < JeremyRubin> jonasschnelli: I'm merely pointing out that the absence of an error indicates that the request completed as requested, so the caller already knows start and stop. 14:07 < JeremyRubin> But maybe it's better interface design to not rely on that in case we improve the behavior in the future ;) 14:07 < jonasschnelli> JeremyRubin: hm... sorry for not following completely... which absence of an error you referring to? 14:08 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 14:08 < jonasschnelli> Abort rescan leads to an error: https://github.com/bitcoin/bitcoin/pull/7061/files#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceR3232 14:08 < JeremyRubin> Ok. So you're a client. You ask for rescan (tip-10,tip-5). 14:08 < JeremyRubin> I'm the server. 14:08 < JeremyRubin> I see the request, and I rescan happily. 14:09 < JeremyRubin> I now will return a range (start, stop) based on your request. 14:10 < JeremyRubin> Under what circumstance do you, the caller, not already know what that range is? 14:10 < JeremyRubin> I suppose you don't know the tip if you only pass a start? 14:11 < JeremyRubin> So maybe it merits returning just the finish height, but you never don't know what start you requested already. 14:12 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Ping timeout: 240 seconds] 14:12 < JeremyRubin> Anyways... this is secondary, it's not really an issue. But I think that handling ok ranges addresses my concern anyways. 14:13 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 14:13 < jonasschnelli> JeremyRubin: Okay. I see you point. 14:14 < jonasschnelli> I guess we could leave it away completely then.... or keep it for future extenions... 14:14 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev 14:14 < jonasschnelli> Although, if you keep away the stop height,... you should at leat get the height of the scanned tip 14:14 < jonasschnelli> Which may be important 14:18 < JeremyRubin> I think that handling ok ranges in the manner suggested gets this to have the correct semantics for the returned data 14:18 < jonasschnelli> JeremyRubin: thanks for reviewing and helping me to understand your point. :) 14:18 < JeremyRubin> yeah, sorry if my explanations were unclear 14:19 < JeremyRubin> It was a pretty subtle bug I guess, because a lot of people missed it! 14:19 < jonasschnelli> Re-reading your comments looks like I had my eyes covered with tomatos 14:20 < jonasschnelli> Yes. Glad you did a review.. and tell me, if you think other stuff needs to be changed/fixed. 14:24 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 14:27 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Ping timeout: 260 seconds] 14:28 < JeremyRubin> jonasschnelli: I would like to see ok_ranges handled in the code and then I'd ack it. If you feel strongly that they should not attempt to scan, and just fail, that's fine. But it should at least return different error strings (e.g., 'start is greater than tip', 'end is greater than tip', 'start must be positive', 'end must be positive') 14:29 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev 14:30 < JeremyRubin> but I think that it is simple to say that at least the end being greater than the tip has an obvious execution (execute as if no argument were provided). 14:32 < JeremyRubin> Start being greater than the tip requires some notion of an empty scan, which I don't think you can express easily with an inclusive range (unless you do another optional bool not_synced_fully). 14:35 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Ping timeout: 240 seconds] 14:38 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev 14:41 -!- tiktaktoe [5649df2e@gateway/web/freenode/ip.86.73.223.46] has joined #bitcoin-core-dev 14:44 -!- tiktaktoe [5649df2e@gateway/web/freenode/ip.86.73.223.46] has quit [Client Quit] 14:46 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Ping timeout: 258 seconds] 14:48 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 14:48 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev 14:49 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 14:54 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Ping timeout: 240 seconds] 14:55 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Remote host closed the connection] 14:56 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev 14:59 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 14:59 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 14:59 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 14:59 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 15:02 < JeremyRubin> jonasschnelli: ^^^ afk soon, shoot an email if questions 15:08 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 264 seconds] 15:09 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds] 15:11 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Ping timeout: 240 seconds] 15:13 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev 15:14 -!- owowo [ovovo@gateway/vpn/mullvad/x-cyazibzdnppcrxim] has joined #bitcoin-core-dev 15:22 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Ping timeout: 260 seconds] 15:23 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev 15:27 -!- wraithm [~wraithm@unaffiliated/wraithm] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 15:37 < bitcoin-git> [bitcoin] promag opened pull request #11452: Improve ZMQ functional test (master...2017-10-improve-zmq-test) https://github.com/bitcoin/bitcoin/pull/11452 16:01 -!- goatpig [56f75683@gateway/web/freenode/ip.86.247.86.131] has quit [Quit: Page closed] 16:09 -!- Dizzle [~dizzle@108.171.182.16] has quit [Remote host closed the connection] 16:11 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 16:12 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Ping timeout: 240 seconds] 16:14 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev 16:20 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Ping timeout: 248 seconds] 16:23 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev 16:25 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 16:43 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Ping timeout: 260 seconds] 16:46 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev 16:46 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 16:52 -!- jb55 [~jb55@208.98.200.100] has quit [Ping timeout: 248 seconds] 16:58 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 16:59 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Ping timeout: 240 seconds] 17:01 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev 17:12 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Ping timeout: 258 seconds] 17:13 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev 17:20 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-tcpcyonbvlfseprt] has quit [Quit: Connection closed for inactivity] 17:21 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Ping timeout: 240 seconds] 17:23 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev 17:25 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds] 17:32 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 248 seconds] 17:37 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 17:43 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Ping timeout: 258 seconds] 17:45 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev 17:53 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Ping timeout: 248 seconds] 17:56 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev 18:02 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Ping timeout: 240 seconds] 18:05 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev 18:07 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has joined #bitcoin-core-dev 18:11 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Ping timeout: 258 seconds] 18:12 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev 18:31 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 18:39 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 18:48 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 18:49 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 19:00 -!- berndj [~berndj@mail.azna.co.za] has quit [Quit: ZNC - http://znc.in] 19:01 -!- ybit [~ybit@unaffiliated/ybit] has quit [Ping timeout: 240 seconds] 19:02 -!- berndj [~berndj@mail.azna.co.za] has joined #bitcoin-core-dev 19:03 -!- ybit [~ybit@unaffiliated/ybit] has joined #bitcoin-core-dev 19:13 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Ping timeout: 248 seconds] 19:15 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev 19:21 -!- ula [~kvirc@b2b-78-94-11-194.unitymedia.biz] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/] 19:22 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 260 seconds] 19:27 -!- wxxs [~chatzilla@37.58.58.238] has quit [Remote host closed the connection] 19:35 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has quit [Ping timeout: 258 seconds] 19:38 -!- Alina-malina [~Alina-mal@unaffiliated/alina-malina] has joined #bitcoin-core-dev 19:51 -!- atroxes [~atroxes@unaffiliated/atroxes] has quit [K-Lined] 19:52 -!- atroxes [~atroxes@unaffiliated/atroxes] has joined #bitcoin-core-dev 20:05 -!- [Author] [pizzaman@2401:a400:3200:5600:bad:d09:15:90d] has quit [Ping timeout: 240 seconds] 20:24 -!- [Author] [pizzaman@2401:a400:3200:5600:bad:d09:15:90d] has joined #bitcoin-core-dev 20:29 -!- wraithm [~wraithm@unaffiliated/wraithm] has joined #bitcoin-core-dev 20:29 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-bzedwblvcvztvknm] has quit [Quit: Connection closed for inactivity] 20:33 -!- wraithm [~wraithm@unaffiliated/wraithm] has quit [Ping timeout: 240 seconds] 20:36 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #10517: Factor out CCoinsView based AreInputsStandard/IsWitnessStandard (master...2017/06/policy_compile) https://github.com/bitcoin/bitcoin/pull/10517 20:37 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #10238: Change setKeyPool to hold flexible entries (master...2017/04/keypool_fix_a) https://github.com/bitcoin/bitcoin/pull/10238 21:05 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #10251: Add balances cache / GUI: use a signal instead of a poll thread (master...2017/04/gui_rm_locks) https://github.com/bitcoin/bitcoin/pull/10251 21:09 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 248 seconds] 22:29 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-akykpqrnnxtyxzqk] has joined #bitcoin-core-dev 22:41 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has quit [Ping timeout: 240 seconds] 23:03 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 23:04 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 23:28 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection] 23:38 -!- Emcy [~MC@unaffiliated/emcy] has quit [Read error: Connection reset by peer]