--- Day changed Wed Oct 11 2017 00:05 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 00:08 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:17 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has quit [Ping timeout: 248 seconds] 00:23 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 00:25 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:40 -!- laurentmt [~Thunderbi@92.154.68.134] has joined #bitcoin-core-dev 00:41 -!- Cheeseo [~Cheeseo@unaffiliated/cheeseo] has quit [Read error: Connection reset by peer] 01:03 -!- JackH [~laptop@2a02:a210:2e00:300:655a:7cbf:d627:81fb] has quit [Quit: Leaving] 01:12 < bitcoin-git> [bitcoin] AmirAbrams opened pull request #11482: Use CPrivKey typedef for keydata in CKey (master...patch-3) https://github.com/bitcoin/bitcoin/pull/11482 01:18 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 01:21 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [] 01:21 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:44 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:44 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 240 seconds] 01:45 < bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/5a9da37fb3f4...0e3a41135157 01:45 < bitcoin-git> bitcoin/master 3f0ee3e Jorge Timón: Proper indentation for CheckTxInputs and other minor fixes 01:45 < bitcoin-git> bitcoin/master 832e074 Jorge Timón: Optimization: Minimize the number of times it is checked that no money is created... 01:45 < bitcoin-git> bitcoin/master 3e8c916 Jorge Timón: Introduce CheckInputsAndUpdateCoins static wrapper in txmempool.cpp 01:46 -!- vicenteH [~user@195.235.96.150] has joined #bitcoin-core-dev 01:48 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has joined #bitcoin-core-dev 01:48 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 01:53 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-ihoirxldgpxfkcvt] has joined #bitcoin-core-dev 01:53 < wumpus> meshcollider: listing 'available' wallets would be a lot easier with the walletdir 01:54 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/0e3a41135157...fef65c4f5e59 01:54 < bitcoin-git> bitcoin/master a2be3b6 Jim Posen: [net] Ignore getheaders requests for very old side blocks... 01:54 < bitcoin-git> bitcoin/master eff4bd8 Jim Posen: [test] P2P functional test for certain fingerprinting protections 01:54 < bitcoin-git> bitcoin/master fef65c4 Wladimir J. van der Laan: Merge #11113: [net] Ignore getheaders requests for very old side blocks... 01:55 < bitcoin-git> [bitcoin] laanwj closed pull request #11113: [net] Ignore getheaders requests for very old side blocks (master...net-getheaders-fingerprint) https://github.com/bitcoin/bitcoin/pull/11113 01:56 < meshcollider> wumpus: yes indeed, I'm just wondering whether there is any point in adding a list of `available` wallets inside the walletdir to the `listwallets` RPC 01:56 < promag> wumpus what is the real use case for that? 01:57 < wumpus> promag: for listing available wallets? would be nice in the GUI at least 01:57 < wumpus> otherwise peopel have to remember the names 01:57 < wumpus> which is okay for the first version or whatever, but in the long run would be nice to select from a list instead 01:57 < wumpus> there's no urgency in having it though 01:57 < promag> But the app is configured with the wallets, and there is no way to create wallets 01:58 < meshcollider> because the only clean-ish way I can think of to find wallets in the walletdir is looking for .dat extensions right? 01:58 < meshcollider> promag dynamic loading/unloading of wallets will be coming soon right? 01:58 < wumpus> check for berkeleydb databases 01:59 < wumpus> (requiring .dat naming is fine with me too, but not all .dats are bdb databases unfortuantely) 01:59 < promag> I feel that's not the right path 01:59 < promag> not all berkeleydb files are wallets 01:59 < wumpus> in the wallet directory they can be assumed to be 01:59 < wumpus> but if you want to add an additional check on loading, fine 01:59 < wumpus> there's some keys that are only in wallets... 01:59 < wumpus> (like the wallet version) 02:00 < wumpus> I'm more afraid of users copying valid wallets from other forks though :( 02:01 < wumpus> so if we want to add more robustness to wallet loading, yeah, we'd have to consider that... 02:01 < meshcollider> The easiest way to check if a file is a bdb file is with magic bytes like ryanofsky suggested here? https://github.com/bitcoin/bitcoin/pull/11466#discussion_r143730935 02:01 < wumpus> meshcollider: yes 02:01 -!- Emcy [~MC@unaffiliated/emcy] has joined #bitcoin-core-dev 02:01 < wumpus> certainly that's the way to do it without getting berkeleydb involved 02:01 < meshcollider> I think I'll take that commit out of my current PR and make a new one 02:01 < meshcollider> this will be too much to discuss 02:01 < wumpus> but why do you need this now? 02:02 < meshcollider> I was going to do the `listwallets` change as part of #11466 02:02 < wumpus> I think we need listing available wallets yet, yes lease separate that out 02:02 < gribble> https://github.com/bitcoin/bitcoin/issues/11466 | [WIP] Specify custom wallet directory with -walletdir param by MeshCollider · Pull Request #11466 · bitcoin/bitcoin · GitHub 02:02 < meshcollider> yep 👍 02:02 < promag> I would open the wallet, keep it open, but not load the transactions 02:03 < wumpus> I mean I *don't* think we need listing available wallets yet 02:03 < promag> listwallets change in a different PR will make your PR faster to review and merge meshcollider 02:03 < wumpus> we need to enforce some naming convention on wallets in that case (we don't even require .dat at the moment) as well as make sure wallets are somehow tagged as bitcoin wallet 02:04 < wumpus> e.g. by having a key in them that identifies them as being such 02:04 < promag> *.wlt :troll: 02:04 -!- Emcy_ [~MC@unaffiliated/emcy] has quit [Ping timeout: 255 seconds] 02:05 < meshcollider> Yep its more complicated than i initially thought, seperating it out now 02:05 -!- laurentmt [~Thunderbi@92.154.68.134] has quit [Ping timeout: 240 seconds] 02:05 < wumpus> promag: if you want to go that way it's better to go full out and use .bitcoinwallet - to rule out overlap with forks etc 02:05 < wumpus> and altcoins 02:06 < wumpus> this is a discussion topic when the wallet format is changed 02:06 < promag> I was kidding :P but maybe .bitcoin-core-wallet 02:06 < wumpus> from berkeleydb to something custom, for example 02:06 < wumpus> we certainly don't want to stick with .dat then 02:07 < promag> well, I think a good implementation will open the whatever-file-is and use/validate the content 02:08 < wumpus> I'm all for being more robust when actually opening wallets 02:08 < wumpus> but when scanning for available wallets please don't get bdb involved 02:09 < wumpus> if you need to look at magics etc, a quick read-only scan should be enough 02:09 < promag> listing an available but invalid wallet is stupid? 02:09 < wumpus> but rare! 02:09 < promag> ok then 02:09 < wumpus> opening with berkeleydb is heavy 02:09 < promag> why? does it load everything? 02:09 < wumpus> also involves potential writing, you don't want the program to write to files it's not told to touch 02:09 < wumpus> yes 02:09 < wumpus> it does various things 02:09 < promag> ok, I rest 02:10 < meshcollider> hah i dont think i can checkout a new branch while building the current one 02:10 < meshcollider> ill have to use my tablet instead 02:10 < wumpus> meshcollider: you can use git worktrees 02:11 < wumpus> and check out different branches in different directories 02:11 < meshcollider> ooh really? That's cool, I've never even heard of that being possible before 02:11 < meshcollider> I'll look it up 02:11 < wumpus> it's awesome, especially with large projects like linux where you really don't want to have multiple full clones 02:11 < meshcollider> Yeah :D 02:15 < promag> yes, thank god sipa introduced that to me a couple of months ago 02:18 < promag> wumpus: easy one #10941, just improves test suite 02:18 < wumpus> it also helps for some things to do out-of-tree builds, though mostly to keep you git tree clean, and be able to build for different architectures from one source tree - it doesn't allow you to switch the branch while building 02:19 < gribble> https://github.com/bitcoin/bitcoin/issues/10941 | Add blocknotify and walletnotify functional tests by promag · Pull Request #10941 · bitcoin/bitcoin · GitHub 02:20 < promag> I think it's time give #11006 a chance? 02:20 < gribble> https://github.com/bitcoin/bitcoin/issues/11006 | Improve shutdown process by promag · Pull Request #11006 · bitcoin/bitcoin · GitHub 02:23 -!- oakley91 [~oakley91@206.75-31-62.static.virginmediabusiness.co.uk] has joined #bitcoin-core-dev 02:26 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 02:26 < bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/fef65c4f5e59...364da2c52942 02:26 < bitcoin-git> bitcoin/master 9c72a46 John Newbery: [tests] Tidy up forknotify.py 02:26 < bitcoin-git> bitcoin/master df18d29 João Barbosa: [tests] Add -blocknotify functional test 02:26 < bitcoin-git> bitcoin/master 857b32b João Barbosa: [tests] Add -walletnotify functional test 02:27 < bitcoin-git> [bitcoin] laanwj closed pull request #10941: Add blocknotify and walletnotify functional tests (master...2017-07-blocknotify-functional-test) https://github.com/bitcoin/bitcoin/pull/10941 02:29 -!- anusorns [6ea99d0b@gateway/web/freenode/ip.110.169.157.11] has joined #bitcoin-core-dev 02:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:32 -!- anusorns [6ea99d0b@gateway/web/freenode/ip.110.169.157.11] has quit [Client Quit] 02:32 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 02:33 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:33 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 02:36 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 02:36 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 02:40 < promag_> wumpus: regarding the eye icon, are there designers contributing? or are the used icons open source? 02:41 < wumpus> what's wrong with the eye icon we alread have? 02:42 < wumpus> (I edited th4e post) 02:45 < promag_> oh there is an eye icon already 02:45 < wumpus> if you want a new icon you'd have to find an icon that has the correct license (ideally MIT or public design) or an artist that wants to create such an icon under the appropriate license 02:46 < wumpus> jonasschnelli designed most of the current ones 02:46 < promag_> this eye? src/qt/res/icons/eye.png 02:46 < wumpus> yes :) 02:46 < promag_> ok, lgtm 02:47 < wumpus> s/public design/public domain 02:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:51 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 02:52 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 02:58 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 03:02 -!- laurentmt [~Thunderbi@92.154.68.134] has joined #bitcoin-core-dev 03:11 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Ping timeout: 240 seconds] 03:12 < bitcoin-git> [bitcoin] laanwj closed pull request #11479: [Docs] Update README.md to add Freenode links (master...master) https://github.com/bitcoin/bitcoin/pull/11479 03:20 < bitcoin-git> [bitcoin] pedrobranco opened pull request #11483: Fix importmulti bug when importing an already imported key (master...bugfix/fix-importmulti-bug) https://github.com/bitcoin/bitcoin/pull/11483 03:28 -!- moctos [~moctos@cpe-107-9-138-59.neo.res.rr.com] has joined #bitcoin-core-dev 03:29 -!- niska [~niska@68.ip-149-56-14.net] has quit [Quit: Leaving] 03:34 -!- niska [~niska@68.ip-149-56-14.net] has joined #bitcoin-core-dev 03:35 < bitcoin-git> [bitcoin] pedrobranco opened pull request #11484: Optional update rescan option in importmulti RPC (master...enhancement/optional-update-rescan-on-importmulti) https://github.com/bitcoin/bitcoin/pull/11484 03:41 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has joined #bitcoin-core-dev 03:44 -!- m8tion [~m8tion@81-65-53-254.rev.numericable.fr] has joined #bitcoin-core-dev 03:48 -!- cluskinator [~cluskinat@69-26-128-235.mxu.aerioconnect.net] has joined #bitcoin-core-dev 03:48 -!- cluskinator is now known as clusk 03:51 -!- m8tion01 [~m8tion@81-65-53-254.rev.numericable.fr] has joined #bitcoin-core-dev 03:52 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 03:54 -!- m8tion [~m8tion@81-65-53-254.rev.numericable.fr] has quit [Ping timeout: 240 seconds] 03:54 -!- Emcy [~MC@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 03:55 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 03:56 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 03:57 -!- drizztbsd [~tredaelli@redhat/timothy] has quit [Ping timeout: 240 seconds] 04:02 -!- pindarhk_ [sid105966@gateway/web/irccloud.com/x-tzwzhnnmekyfrtwr] has quit [Read error: Connection reset by peer] 04:03 -!- pindarhk_ [sid105966@gateway/web/irccloud.com/x-unecgjivnrpzmuxb] has joined #bitcoin-core-dev 04:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:09 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 248 seconds] 04:10 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:13 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds] 04:14 -!- laurentmt1 [~Thunderbi@92.154.68.134] has joined #bitcoin-core-dev 04:16 -!- laurentmt [~Thunderbi@92.154.68.134] has quit [Ping timeout: 248 seconds] 04:16 -!- laurentmt1 is now known as laurentmt 04:19 -!- laurentmt [~Thunderbi@92.154.68.134] has quit [Quit: laurentmt] 04:20 -!- W4RL0RD [~W4RL0RD@173.209.61.59] has joined #bitcoin-core-dev 04:25 < bitcoin-git> [bitcoin] MeshCollider opened pull request #11485: [WIP] Add `available` field to listwallets RPC (master...201710_listwallets_available) https://github.com/bitcoin/bitcoin/pull/11485 04:28 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:30 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 04:30 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 04:35 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 04:41 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 04:43 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev 05:02 -!- wxss [~chatzilla@8c.28.01a8.ip4.static.sl-reverse.com] has joined #bitcoin-core-dev 05:02 -!- Cogito_Ergo_Sum [~Myself@80.107.149.120] has joined #bitcoin-core-dev 05:02 -!- Cogito_Ergo_Sum [~Myself@80.107.149.120] has left #bitcoin-core-dev [] 05:08 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Ping timeout: 248 seconds] 05:25 < Chris_Stewart_5> Does anyone have an idea why I wouldn't be able to generate a CPubKey from a CKey after calling k.MakeNewKey(true) 05:26 < Chris_Stewart_5> the error: test_bitcoin: key.cpp:153: CPubKey CKey::GetPubKey() const: Assertion `ret' failed. 05:26 < Chris_Stewart_5> it seems to be failing in secp256k1 05:28 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 05:35 < Chris_Stewart_5> the line it fails on: https://github.com/bitcoin/bitcoin/blob/f90603ac6d24f5263649675d51233f1fce8b2ecd/src/key.cpp#L153 05:36 -!- W4RL0RD [~W4RL0RD@173.209.61.59] has quit [Ping timeout: 248 seconds] 05:47 -!- m8tion01 [~m8tion@81-65-53-254.rev.numericable.fr] has quit [Ping timeout: 264 seconds] 05:47 -!- m8tion [~m8tion@81-65-53-254.rev.numericable.fr] has joined #bitcoin-core-dev 05:47 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 05:47 < wumpus> Chris_Stewart_5: that can only fail if the private key is not in the valid range 05:49 -!- CadelLeeStormer [536e0b82@gateway/web/freenode/ip.83.110.11.130] has joined #bitcoin-core-dev 05:51 < Chris_Stewart_5> wumpus: Hmm, is there any reason that calling .MakeNewKey(true) would generate one that is invalid? 05:52 < Chris_Stewart_5> because assert(fValid) passes on line 135 05:52 < Chris_Stewart_5> line 148* 06:00 -!- daizisheng [7b743dd4@gateway/web/freenode/ip.123.116.61.212] has joined #bitcoin-core-dev 06:03 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 06:04 -!- daizisheng [7b743dd4@gateway/web/freenode/ip.123.116.61.212] has quit [Client Quit] 06:08 -!- CadelLeeStormer [536e0b82@gateway/web/freenode/ip.83.110.11.130] has quit [Ping timeout: 260 seconds] 06:14 < wumpus> no, I don't know, it would help to print the generated key I guess 06:16 < Chris_Stewart_5> wumpus: wif: KwDiBf89QgGbjEhKnhXJuH7LrciVrZi3qYjgd9M7rFU73Nd2Mcv1 06:18 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 06:25 -!- clusk [~cluskinat@69-26-128-235.mxu.aerioconnect.net] has quit [Remote host closed the connection] 06:25 < arubi> it's 0 06:25 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #bitcoin-core-dev 06:25 < arubi> 0000000000000000000000000000000000000000000000000000000000000000 rather 06:25 < Chris_Stewart_5> hmmm... so that indicates .MakeNewKey() isn't being called? 06:26 < wumpus> indeed, and a private key of zero is not valid, should be at least one 06:26 < wumpus> either you must be doing something wrong or there's a bug 06:26 -!- dabura667 [~dabura667@240f:d:e193:1:c97f:dbfb:1fa9:880b] has joined #bitcoin-core-dev 06:27 < Chris_Stewart_5> Eh, I'm playing with #8469 06:27 < gribble> https://github.com/bitcoin/bitcoin/issues/8469 | [POC] Introducing property based testing to Core by Christewart · Pull Request #8469 · bitcoin/bitcoin · GitHub 06:27 < Chris_Stewart_5> I'm generating various standard tx types (p2pk,p2pkh,multisig) etc and then running them through the interpreter to assert our interpreter/wallet code base are consistent 06:28 < Chris_Stewart_5> When I'm generating a std::vector this bug appears, but does not appear when I generate a single CKey 06:28 < Chris_Stewart_5> arubi: Thanks by the way 06:28 < arubi> oh cheers 06:28 < wumpus> right, next step would be to figure out why it returns the zero key. I'm happy secp256k1 catches this at least. 06:30 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has quit [Remote host closed the connection] 06:30 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has joined #bitcoin-core-dev 06:30 < Chris_Stewart_5> wumpus: Agreed! It is weird because if I try to explicitly call .MakeNewKey(true) (again) before I convert it to a pubkey secp256k1 gives this error 06:31 < wumpus> yes I was still in the process of trying to convert that key to raw bytes - a google would have been faster in this case :) 06:31 < Chris_Stewart_5> [libsecp256k1] illegal argument: seckey != NULL 06:31 < Chris_Stewart_5> perhaps my generator is generating a valid 0 byte key, which is *technically* a valid key right? 06:32 < Chris_Stewart_5> and secp256k1 just says 'you really don't want to be doing this...' 06:35 < wumpus> not sure about "technically" in this case - I think it's mathemtically undefined 06:35 < arubi> it's not a valid key in secp256k1, but it's base58 encoding is valid 06:36 < wumpus> right ^^ 06:36 < arubi> so something generated it.. 06:36 < wumpus> so are you expecting a random key? 06:40 < Chris_Stewart_5> wumpus: Yes... here is the sequence I am using to generate one: https://github.com/Christewart/bitcoin/blob/af2f6f2a639d94945a73e63f9f4203071caad984/src/test/gen/crypto_gen.h#L18 06:40 < Chris_Stewart_5> do you see something inherently wrong with it? 06:42 -!- dabura667 [~dabura667@240f:d:e193:1:c97f:dbfb:1fa9:880b] has quit [Remote host closed the connection] 06:45 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-uxylvxueblwkdxnq] has quit [Quit: Connection closed for inactivity] 06:45 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-ihoirxldgpxfkcvt] has quit [Quit: Connection closed for inactivity] 06:48 -!- m8tion01 [~m8tion@81-65-53-254.rev.numericable.fr] has joined #bitcoin-core-dev 06:49 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has quit [Ping timeout: 248 seconds] 06:49 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has joined #bitcoin-core-dev 06:50 -!- m8tion [~m8tion@81-65-53-254.rev.numericable.fr] has quit [Ping timeout: 255 seconds] 06:51 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 264 seconds] 06:55 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 07:00 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #bitcoin-core-dev 07:01 < jnewbery> meshcollider: sorry - missed the discussion earlier. I think updating listwallets to list available wallets would definitely be a useful feature, but it's by no means necessary for #11466. 07:01 < gribble> https://github.com/bitcoin/bitcoin/issues/11466 | Specify custom wallet directory with -walletdir param by MeshCollider · Pull Request #11466 · bitcoin/bitcoin · GitHub 07:02 < jnewbery> promag: Both your alternative schemas in https://github.com/bitcoin/bitcoin/pull/11485#issuecomment-335813034 are fine. I'm not too concerned about the exact format, but I think it's useful for users to be able to access the information somehow 07:04 < Chris_Stewart_5> wumpus: For what it is worth it is unrelated to anyting in core. I wasn't capturing a variable correctly in a lambda 07:04 < promag> Right, I just think there is no strong use case for that 07:06 < promag> I kind of like findwallets because it can return "invalid" wallets where as listwallets is returning valid and loaded wallets 07:07 < promag> at the moment listwallet can return available "invalid" wallet that cannot be loaded 07:08 < promag> btw, do you think we should have the inverse of -experimentalrpc=? 07:08 < promag> so 0.15 introduced listwallets but to use it it should be enabled like so 07:09 < promag> sorry, **the inverse of -deprecaterpc** 07:10 < promag> therefore all experimental rpc can change 07:11 < jnewbery> The use case is being able to find and load wallets dynamically at run-time. If you have any concept feedback on that, the PR is 10740 07:13 < jnewbery> re: -experimentalrpc - I don't think that's necessary. Release notes for multiwallet stated 'Note that while multi-wallet is now fully supported, the RPC multi-wallet interface should be considered unstable for version 0.15.0, and there may backwards-incompatible changes in future versions. 07:33 < promag> ok and ok 07:58 -!- Cogito_Ergo_Sum [~Myself@80.107.149.120] has joined #bitcoin-core-dev 08:11 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has joined #bitcoin-core-dev 08:17 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has quit [Ping timeout: 248 seconds] 08:27 -!- wraithm [~wraithm@unaffiliated/wraithm] has joined #bitcoin-core-dev 08:28 -!- wraithm [~wraithm@unaffiliated/wraithm] has quit [Client Quit] 08:28 -!- wraithm [~wraithm@unaffiliated/wraithm] has joined #bitcoin-core-dev 08:29 -!- SopaXT [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 08:29 -!- wraithm [~wraithm@unaffiliated/wraithm] has quit [Client Quit] 08:29 -!- wraithm [~wraithm@unaffiliated/wraithm] has joined #bitcoin-core-dev 08:30 -!- SopaXT [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 08:46 -!- ananteris [~user@unaffiliated/ananteris] has joined #bitcoin-core-dev 08:48 -!- vicenteH [~user@195.235.96.150] has quit [Ping timeout: 248 seconds] 08:50 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 255 seconds] 08:56 < promag> wumpus: you deleted the comment in #11476? 08:56 < gribble> https://github.com/bitcoin/bitcoin/issues/11476 | Avoid opening copied wallet databases simultaneously by ryanofsky · Pull Request #11476 · bitcoin/bitcoin · GitHub 09:08 -!- m8tion03 [~m8tion@81-65-53-254.rev.numericable.fr] has joined #bitcoin-core-dev 09:10 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 09:11 -!- m8tion01 [~m8tion@81-65-53-254.rev.numericable.fr] has quit [Ping timeout: 248 seconds] 09:11 < wumpus> no? 09:14 -!- jb55 [~jb55@208.98.200.100] has joined #bitcoin-core-dev 09:17 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 09:18 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 09:19 < timothy> little-OT: do you think bitcoin gold have enough time to implement replay protection? 09:20 < timothy> if no, it may be a big problem for (some) bitcoin users too due to replay attack 09:22 < jnewbery> timothy: #bitcoin please. This channel is for discussing Bitcoin Core development 09:22 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds] 09:24 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/364da2c52942...892809309c1b 09:24 < bitcoin-git> bitcoin/master 619bb05 MarcoFalke: Squashed 'src/univalue/' changes from 16a1f7f6e..fe805ea74... 09:24 < bitcoin-git> bitcoin/master faaeeb0 MarcoFalke: Bump univalue and fix json formatting in tests... 09:24 < bitcoin-git> bitcoin/master 8928093 Wladimir J. van der Laan: Merge #11420: Bump univalue subtree and fix json formatting in tests... 09:24 < wumpus> if you get any linker errors while building master, you probably need to clean your tree after #11420 (it seems that some changes to univalue are not detected by the build system) 09:24 < gribble> https://github.com/bitcoin/bitcoin/issues/11420 | Bump univalue subtree and fix json formatting in tests by MarcoFalke · Pull Request #11420 · bitcoin/bitcoin · GitHub 09:24 < bitcoin-git> [bitcoin] laanwj closed pull request #11420: Bump univalue subtree and fix json formatting in tests (master...Mf1709-bumpUnivalue) https://github.com/bitcoin/bitcoin/pull/11420 09:30 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has quit [] 09:30 < bitcoin-git> [bitcoin] laanwj closed pull request #11445: [qa] 0.15.1 Backports (0.15...Mf1710-0151qaBackports) https://github.com/bitcoin/bitcoin/pull/11445 09:42 -!- Provoostenator [~textual@54693D0F.cm-12-2a.dynamic.ziggo.nl] has joined #bitcoin-core-dev 09:42 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 09:50 -!- Provoostenator [~textual@54693D0F.cm-12-2a.dynamic.ziggo.nl] has quit [Quit: Textual IRC Client: www.textualapp.com] 09:57 -!- Provoostenator [~textual@54693D0F.cm-12-2a.dynamic.ziggo.nl] has joined #bitcoin-core-dev 09:58 -!- m8tion [~m8tion@81-65-53-254.rev.numericable.fr] has joined #bitcoin-core-dev 09:59 < Chris_Stewart_5> Does ProduceSignature have the capability to sign a p2sh(multisig) tx? Here is how I am trying to use it https://gist.github.com/Christewart/3d930327e7b27e6a897fa6d2744ec569 09:59 < Chris_Stewart_5> if not, is there capability for this else where in the code base? 10:00 -!- m8tion03 [~m8tion@81-65-53-254.rev.numericable.fr] has quit [Ping timeout: 264 seconds] 10:04 -!- Provoostenator [~textual@54693D0F.cm-12-2a.dynamic.ziggo.nl] has quit [Quit: Textual IRC Client: www.textualapp.com] 10:04 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 10:05 < sipa> Chris_Stewart_5: yes, it does 10:05 < sipa> but you need to have the redeemscript in the keystore 10:06 < Chris_Stewart_5> I believe I did this https://gist.github.com/Christewart/3d930327e7b27e6a897fa6d2744ec569#file-produce_signature_p2sh-cpp-L14 10:06 < Chris_Stewart_5> sipa: ^ 10:06 < sipa> your redeemscript is just a key? 10:06 < sipa> or what is spk_keys 10:06 < Chris_Stewart_5> tuple 10:07 < Chris_Stewart_5> std::tuple> 10:07 < sipa> and what's the script? 10:07 < Chris_Stewart_5> one of the following: P2PK CScript, P2PKH CScript, Multisig CScript 10:07 < Chris_Stewart_5> It is randomly choosing one of those 10:09 < Chris_Stewart_5> then creating a p2sh script 10:09 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 10:10 < sipa> looks right to me 10:10 < sipa> what is the problem? 10:10 < Chris_Stewart_5> the assert fails on this line -- it should return complete right? https://gist.github.com/Christewart/3d930327e7b27e6a897fa6d2744ec569#file-produce_signature_p2sh-cpp-L20 10:10 < Chris_Stewart_5> *theoretically* haha 10:11 < sipa> yes 10:12 < sipa> i don't see anything obviously wrong 10:12 < Chris_Stewart_5> I'll dig more -- it is probably something stupid I am doing else where. I just wanted to confirm produce signature has the capability before I go deeper 10:26 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:26 -!- m8tion [~m8tion@81-65-53-254.rev.numericable.fr] has quit [Read error: Connection reset by peer] 10:27 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-wkksacfhonabfcyr] has joined #bitcoin-core-dev 10:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 248 seconds] 10:40 -!- Emcy [~MC@unaffiliated/emcy] has joined #bitcoin-core-dev 10:48 -!- LeMiner [~LeMiner@unaffiliated/leminer] has joined #bitcoin-core-dev 10:53 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Read error: Connection reset by peer] 10:54 -!- jb55 [~jb55@208.98.200.100] has quit [Ping timeout: 240 seconds] 10:56 -!- W4RL0RD [~W4RL0RD@5.157.36.102] has joined #bitcoin-core-dev 11:05 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 11:08 -!- vicenteH [~user@93.104.135.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 11:11 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds] 11:12 -!- jb55 [~jb55@208.98.200.100] has joined #bitcoin-core-dev 11:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 11:20 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 11:21 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 11:21 -!- W4RL0RD [~W4RL0RD@5.157.36.102] has quit [Remote host closed the connection] 11:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds] 11:37 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 11:40 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 11:45 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 258 seconds] 11:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 11:57 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 248 seconds] 12:01 -!- goatpig [56f75683@gateway/web/freenode/ip.86.247.86.131] has quit [Quit: Page closed] 12:03 -!- wxss [~chatzilla@8c.28.01a8.ip4.static.sl-reverse.com] has quit [Ping timeout: 255 seconds] 12:03 -!- Emcy_ [~MC@unaffiliated/emcy] has joined #bitcoin-core-dev 12:05 -!- Emcy_ [~MC@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 12:05 -!- wxss [~chatzilla@176-53-23-251.turkrdns.com] has joined #bitcoin-core-dev 12:06 -!- Emcy [~MC@unaffiliated/emcy] has quit [Ping timeout: 240 seconds] 12:07 -!- Emcy_ [~MC@unaffiliated/emcy] has joined #bitcoin-core-dev 12:07 < morcos> I'm just trying to catch up on old review by looking at what was merged.. In #11113 , what is the use case of responding to these strange getheaders requests with no locator at all? Or at the very least shouldn't we only respond if the hashStop is on our main chain 12:07 < gribble> https://github.com/bitcoin/bitcoin/issues/11113 | [net] Ignore getheaders requests for very old side blocks by jimpo · Pull Request #11113 · bitcoin/bitcoin · GitHub 12:08 < morcos> Not objection to merging the PR, it seems like a strict improvement, but just trying to understand why that functionality even exists 12:12 -!- alreadylate [~textual@c-250e71d5.153-1-64736c10.cust.bredbandsbolaget.se] has joined #bitcoin-core-dev 12:16 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 12:35 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has quit [Quit: Leaving] 12:42 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-xkfcdysqodjytzcl] has joined #bitcoin-core-dev 12:49 -!- qrestlove [~qrestlove@2605:6000:eb4a:ef00:454f:112b:9095:f0ea] has quit [Ping timeout: 258 seconds] 12:55 -!- Emcy_ [~MC@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 12:55 -!- niko__ [~niko@c-76-121-23-176.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 12:55 -!- Emcy_ [~MC@unaffiliated/emcy] has joined #bitcoin-core-dev 12:59 -!- niko__ [~niko@c-76-121-23-176.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 13:02 < bitcoin-git> [bitcoin] mess110 opened pull request #11486: [tests] Add uacomment tests (master...test_uacomment) https://github.com/bitcoin/bitcoin/pull/11486 13:06 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 13:09 -!- niko__ [~niko@c-76-121-23-176.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 13:10 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 13:13 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 13:18 -!- Emcy_ [~MC@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 13:19 -!- Emcy [~MC@94.197.120.199.threembb.co.uk] has joined #bitcoin-core-dev 13:19 -!- Emcy [~MC@94.197.120.199.threembb.co.uk] has quit [Changing host] 13:19 -!- Emcy [~MC@unaffiliated/emcy] has joined #bitcoin-core-dev 13:33 -!- qrestlove [~qrestlove@cpe-66-69-225-126.austin.res.rr.com] has joined #bitcoin-core-dev 13:35 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 13:37 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 13:38 -!- qrestlove [~qrestlove@cpe-66-69-225-126.austin.res.rr.com] has quit [Ping timeout: 255 seconds] 13:51 -!- qrestlove [~qrestlove@2605:6000:eb4a:ef00:454f:112b:9095:f0ea] has joined #bitcoin-core-dev 13:52 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 14:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 14:05 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 14:08 -!- Emcy [~MC@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 14:13 -!- niko__ [~niko@c-76-121-23-176.hsd1.wa.comcast.net] has quit [Quit: Leaving] 14:18 -!- qrestlove [~qrestlove@2605:6000:eb4a:ef00:454f:112b:9095:f0ea] has quit [Remote host closed the connection] 14:22 -!- qrestlove [~qrestlove@2605:6000:eb4a:ef00::1] has joined #bitcoin-core-dev 14:26 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #11487: Check that new headers are not a descendant of an invalid block (master...2017-10-acceptblock-validity-check) https://github.com/bitcoin/bitcoin/pull/11487 14:33 -!- Cogito_Ergo_Sum [~Myself@80.107.149.120] has quit [] 14:35 -!- alreadylate [~textual@c-250e71d5.153-1-64736c10.cust.bredbandsbolaget.se] has quit [] 14:36 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has quit [Quit: leaving] 14:40 -!- alreadylate [~textual@c-250e71d5.153-1-64736c10.cust.bredbandsbolaget.se] has joined #bitcoin-core-dev 14:46 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev 14:49 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has quit [Ping timeout: 246 seconds] 14:49 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 248 seconds] 14:49 -!- Emcy [~MC@unaffiliated/emcy] has joined #bitcoin-core-dev 14:49 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has joined #bitcoin-core-dev 14:50 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 14:50 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:59 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Read error: Connection reset by peer] 15:00 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 255 seconds] 15:14 -!- cheese_ [~Cheeseo@unaffiliated/cheeseo] has joined #bitcoin-core-dev 15:17 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 15:25 -!- qrestlove [~qrestlove@2605:6000:eb4a:ef00::1] has quit [Ping timeout: 258 seconds] 15:26 -!- alreadylate [~textual@c-250e71d5.153-1-64736c10.cust.bredbandsbolaget.se] has quit [] 15:35 -!- harrymm [~harrymm@85.203.47.33] has quit [Remote host closed the connection] 15:36 -!- harrymm [~harrymm@85.203.47.23] has joined #bitcoin-core-dev 15:38 -!- qrestlove [~qrestlove@2605:6000:eb4a:ef00:454f:112b:9095:f0ea] has joined #bitcoin-core-dev 15:47 -!- RoyceX [~Cheeseo@unaffiliated/cheeseo] has joined #bitcoin-core-dev 15:49 -!- cheese_ [~Cheeseo@unaffiliated/cheeseo] has quit [Ping timeout: 258 seconds] 16:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 16:18 -!- RoyceX [~Cheeseo@unaffiliated/cheeseo] has quit [Ping timeout: 258 seconds] 16:29 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Quit: Leaving] 16:50 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 16:57 -!- wraithm [~wraithm@unaffiliated/wraithm] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 16:57 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 16:57 < bitcoin-git> [bitcoin] C0deAi opened pull request #11488: Codeai fixes: remove dead code, prevent possible division by zero. (master...codeai-fixes) https://github.com/bitcoin/bitcoin/pull/11488 16:58 -!- dcousens [~anon@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Remote host closed the connection] 17:04 < bitcoin-git> [bitcoin] fanquake closed pull request #11488: Codeai fixes: remove dead code, prevent possible division by zero. (master...codeai-fixes) https://github.com/bitcoin/bitcoin/pull/11488 17:04 -!- fanquake [~fanquake@203-59-201-175.dyn.iinet.net.au] has joined #bitcoin-core-dev 17:04 -!- fanquake [~fanquake@203-59-201-175.dyn.iinet.net.au] has quit [Changing host] 17:04 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 17:04 < fanquake> I guess their AI didn't bother checking the open pull requests.. 17:12 -!- jb55 [~jb55@208.98.200.100] has quit [Ping timeout: 248 seconds] 17:16 < esotericnonsense> `CodeAi suggests` is hilarious 17:20 < sipa> they're pretty good suggestions 17:24 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-wkksacfhonabfcyr] has quit [Quit: Connection closed for inactivity] 17:35 < esotericnonsense> fanquake: you really missed a trick with the response. 'fanquake suggests an issue is raised on the CodeAi github regarding ...' :p 17:36 < TD-Linux> I'm impressed that none of them were false positives 17:36 < sipa> TD-Linux: perhaps they're human-filtered? 17:39 < fanquake> sipa If you're are doing some review, could you check #11073 ? 17:39 < gribble> https://github.com/bitcoin/bitcoin/issues/11073 | Remove dead store in ecdsa_signature_parse_der_lax. by BitonicEelis · Pull Request #11073 · bitcoin/bitcoin · GitHub 17:39 -!- chartractegg [~chartract@gateway/vpn/privateinternetaccess/chartractegg] has joined #bitcoin-core-dev 17:45 -!- chartractegg [~chartract@gateway/vpn/privateinternetaccess/chartractegg] has quit [Quit: Textual IRC Client: www.textualapp.com] 17:49 -!- chartractegg [~chartract@ip68-98-5-113.ph.ph.cox.net] has joined #bitcoin-core-dev 17:52 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-xkfcdysqodjytzcl] has quit [Quit: Connection closed for inactivity] 17:59 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 18:01 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev 18:07 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has joined #bitcoin-core-dev 18:17 -!- wxss [~chatzilla@176-53-23-251.turkrdns.com] has quit [Ping timeout: 255 seconds] 18:23 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has quit [K-Lined] 18:23 -!- chartractegg [~chartract@ip68-98-5-113.ph.ph.cox.net] has quit [K-Lined] 18:24 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds] 18:32 -!- wxss [~chatzilla@195.168.155.31] has joined #bitcoin-core-dev 18:37 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has joined #bitcoin-core-dev 18:42 -!- chartractegg [~chartract@ip68-98-5-113.ph.ph.cox.net] has joined #bitcoin-core-dev 18:45 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 18:54 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 19:04 -!- chartractegg [~chartract@ip68-98-5-113.ph.ph.cox.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 19:07 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 248 seconds] 19:12 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 260 seconds] 19:13 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 19:13 -!- bigtimmyc [6021a9b7@gateway/web/freenode/ip.96.33.169.183] has joined #bitcoin-core-dev 19:13 < bigtimmyc> hello 19:14 < bigtimmyc> looking for some advice fellas 19:16 < sipa> you're generally better off on #bitcoin, but without asking a question it's hard to know 19:17 < bigtimmyc> just looking for general starter advice for development 19:17 < bigtimmyc> should I go to #bitcoin? 19:18 < bigtimmyc> just a little confused with how to get started 19:19 -!- chartractegg [~chartract@ip68-98-5-113.ph.ph.cox.net] has joined #bitcoin-core-dev 19:20 < wxss> bigtimmyc: this channel is for development of the Bitcoin Core client, you may want to try #bitcoin for starting advice 19:20 < bigtimmyc> sounds good, thanks 19:20 < bigtimmyc> JOIN #bitcoin 19:20 < bigtimmyc> fuck 19:20 < sipa> almost! 19:26 -!- chartractegg [~chartract@ip68-98-5-113.ph.ph.cox.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 19:39 -!- btcdrak [uid239175@gateway/web/irccloud.com/x-olejnezdsxsubozn] has joined #bitcoin-core-dev 19:48 -!- clusk [~cluskinat@69-26-128-235.mxu.aerioconnect.net] has joined #bitcoin-core-dev 20:10 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-jmqnjwtmhgflzwdr] has joined #bitcoin-core-dev 20:14 -!- goatpig [56f75683@gateway/web/freenode/ip.86.247.86.131] has joined #bitcoin-core-dev 20:15 -!- xHire [~xHire@kos.paskuli.cz] has quit [Ping timeout: 264 seconds] 20:20 < BlueMatt> someone wanna close #11481? he's asking why there are two tx sizes (hint: segwit.....) 20:21 < gribble> https://github.com/bitcoin/bitcoin/issues/11481 | Different size and same transaction · Issue #11481 · bitcoin/bitcoin · GitHub 20:52 -!- owowo [ovovo@gateway/vpn/mullvad/x-wgiadzmmuhyusuqv] has quit [Ping timeout: 240 seconds] 20:58 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 21:08 -!- wxss [~chatzilla@195.168.155.31] has quit [Remote host closed the connection] 21:15 -!- Deacydal [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 21:17 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has quit [Ping timeout: 258 seconds] 21:26 -!- shesek [~shesek@bzq-84-110-55-42.red.bezeqint.net] has joined #bitcoin-core-dev 21:26 -!- shesek [~shesek@bzq-84-110-55-42.red.bezeqint.net] has quit [Changing host] 21:26 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 21:44 < bitcoin-git> [bitcoin] kallewoof opened pull request #11489: [wallet] sendtoaddress style argument (master...201709_segwitwallet2_sendtoaddress) https://github.com/bitcoin/bitcoin/pull/11489 21:53 -!- CubicEarth [~cubiceart@c-73-68-232-79.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 21:57 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 21:58 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 22:04 -!- goatpig [56f75683@gateway/web/freenode/ip.86.247.86.131] has quit [Ping timeout: 260 seconds] 22:28 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-lapfvduyqqjhltux] has joined #bitcoin-core-dev 22:30 -!- CubicEarth [~cubiceart@c-73-68-232-79.hsd1.ma.comcast.net] has quit [] 22:48 -!- bigtimmyc [6021a9b7@gateway/web/freenode/ip.96.33.169.183] has quit [Ping timeout: 260 seconds] 22:49 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has quit [Ping timeout: 248 seconds] 22:49 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has joined #bitcoin-core-dev 22:57 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Quit: Leaving.] 23:40 -!- clusk [~cluskinat@69-26-128-235.mxu.aerioconnect.net] has quit [Remote host closed the connection] 23:41 -!- clusk [~cluskinat@69-26-128-235.mxu.aerioconnect.net] has joined #bitcoin-core-dev 23:45 -!- clusk [~cluskinat@69-26-128-235.mxu.aerioconnect.net] has quit [Ping timeout: 255 seconds] 23:48 -!- clusk [~cluskinat@69-26-128-235.mxu.aerioconnect.net] has joined #bitcoin-core-dev 23:56 -!- h1d [~h1d@unaffiliated/h1d] has joined #bitcoin-core-dev 23:56 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]