--- Day changed Wed Oct 18 2017 00:13 -!- harrymm_ [~harrymm@85.203.47.146] has quit [] 00:14 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-fghskwtkrmkljqgt] has quit [Quit: Connection closed for inactivity] 00:17 -!- harrymm [~harrymm@85.203.47.75] has joined #bitcoin-core-dev 00:25 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:30 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-nhwivmlpilissjke] has joined #bitcoin-core-dev 00:38 -!- sybarite [~sybarite@122.15.111.165] has joined #bitcoin-core-dev 00:52 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 00:53 -!- laurentmt [~Thunderbi@92.154.68.134] has joined #bitcoin-core-dev 00:54 -!- Guest83 [~textual@2602:306:378a:6fb0:8833:60d9:81d6:303f] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 01:02 -!- victorSN [~victorSN@ec2-18-221-184-249.us-east-2.compute.amazonaws.com] has joined #bitcoin-core-dev 01:02 -!- victorSN [~victorSN@ec2-18-221-184-249.us-east-2.compute.amazonaws.com] has quit [Remote host closed the connection] 01:02 -!- victorSN [~victorSN@ec2-18-221-184-249.us-east-2.compute.amazonaws.com] has joined #bitcoin-core-dev 01:07 -!- sybarite [~sybarite@122.15.111.165] has quit [Ping timeout: 246 seconds] 01:17 -!- victorSN [~victorSN@ec2-18-221-184-249.us-east-2.compute.amazonaws.com] has quit [Remote host closed the connection] 01:18 -!- victorSN [~victorSN@ec2-18-221-184-249.us-east-2.compute.amazonaws.com] has joined #bitcoin-core-dev 01:18 -!- goatpig [56f75683@gateway/web/freenode/ip.86.247.86.131] has joined #bitcoin-core-dev 01:20 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Remote host closed the connection] 01:26 -!- jcorgan_ [~jcorgan@64-142-68-61.dsl.static.sonic.net] has joined #bitcoin-core-dev 01:26 -!- dabura667_ [~dabura667@153.142.228.110] has joined #bitcoin-core-dev 01:28 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Ping timeout: 248 seconds] 01:28 -!- jcorgan [~jcorgan@unaffiliated/jcorgan] has quit [Ping timeout: 248 seconds] 01:31 -!- lifeofguenter [~lifeofgue@bnc.pro.to.co.ls] has quit [Ping timeout: 240 seconds] 01:31 -!- Apocalyptic [~Apocalypt@unaffiliated/apocalyptic] has quit [Ping timeout: 260 seconds] 01:33 -!- lifeofguenter [~lifeofgue@bnc.pro.to.co.ls] has joined #bitcoin-core-dev 01:33 -!- Apocalyptic [~Apocalypt@unaffiliated/apocalyptic] has joined #bitcoin-core-dev 01:35 -!- ekrion [~ff@adsl201-232-238-252.epm.net.co] has quit [Ping timeout: 240 seconds] 01:38 -!- sanada [~bitktn@36-2-119-80.chiba.ap.gmo-isp.jp] has joined #bitcoin-core-dev 01:39 -!- vicenteH [~user@35.233.15.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 01:39 -!- sanada` [~bitktn@36-2-119-80.chiba.ap.gmo-isp.jp] has quit [Ping timeout: 255 seconds] 01:40 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:40 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:43 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 276 seconds] 01:49 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 01:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:50 -!- cheetah2 [~cheetah2@172.242.103.133] has joined #bitcoin-core-dev 01:51 -!- cheetah2 [~cheetah2@172.242.103.133] has quit [Client Quit] 01:54 -!- aj [aj@cerulean.erisian.com.au] has joined #bitcoin-core-dev 02:06 -!- JackH [~laptop@91.189.61.70] has joined #bitcoin-core-dev 02:07 < kallewoof> ossifrage: not seeing that on my end 02:13 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev 02:15 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 02:31 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 02:32 -!- sybarite [~sybarite@122.15.111.165] has joined #bitcoin-core-dev 02:38 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/808c84f89d0e...26fee4f6bd9a 02:38 < bitcoin-git> bitcoin/master 258d33b Karl-Johan Alm: [mempool] Mark unaccepted txs present in mempool as 'already there'.... 02:38 < bitcoin-git> bitcoin/master 26fee4f Pieter Wuille: Merge #11062: [mempool] Mark mempool import fails that were found in mempool as 'already there'... 02:38 < sipa> kallewoof: ^ i was confused to not see a 'already there' when starting up a master node, and then realized that wasn't merged yet 02:38 < bitcoin-git> [bitcoin] sipa closed pull request #11062: [mempool] Mark mempool import fails that were found in mempool as 'already there' (master...mempool-alreadythere) https://github.com/bitcoin/bitcoin/pull/11062 02:39 < gmaxwell> sipa: kallewoof: thanks. 02:48 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Ping timeout: 248 seconds] 02:48 -!- d_p [~d_p@gateway/tor-sasl/dp/x-51976874] has quit [Ping timeout: 248 seconds] 02:48 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 248 seconds] 02:48 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 248 seconds] 02:51 * kallewoof cheers :) 03:03 -!- geezas [uid253218@gateway/web/irccloud.com/x-fxbircpsnhnjvcil] has quit [Quit: Connection closed for inactivity] 03:03 -!- dabura667_ [~dabura667@153.142.228.110] has quit [Remote host closed the connection] 03:08 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 03:08 -!- d_p_ [~d_p@gateway/tor-sasl/dp/x-51976874] has joined #bitcoin-core-dev 03:14 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 03:16 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Remote host closed the connection] 03:16 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 03:30 -!- Banzai10 [b189f883@gateway/web/cgi-irc/kiwiirc.com/ip.177.137.248.131] has joined #bitcoin-core-dev 03:30 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 240 seconds] 03:41 -!- qwe_ [3e43b8e2@gateway/web/freenode/ip.62.67.184.226] has joined #bitcoin-core-dev 03:41 -!- qwe_ [3e43b8e2@gateway/web/freenode/ip.62.67.184.226] has quit [Client Quit] 03:43 -!- Emcy_ [~MC@unaffiliated/emcy] has quit [Ping timeout: 240 seconds] 03:52 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 04:10 -!- shesek [~shesek@bzq-84-110-56-145.cablep.bezeqint.net] has joined #bitcoin-core-dev 04:10 -!- shesek [~shesek@bzq-84-110-56-145.cablep.bezeqint.net] has quit [Changing host] 04:10 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 04:24 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Remote host closed the connection] 04:25 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 04:27 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 04:30 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Ping timeout: 260 seconds] 04:32 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 05:04 -!- wxss [~chatzilla@196.196.200.5] has joined #bitcoin-core-dev 05:15 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 05:20 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 05:23 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection] 05:24 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 05:24 -!- Emcy [~MC@unaffiliated/emcy] has joined #bitcoin-core-dev 05:30 -!- Emcy [~MC@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 05:31 -!- Emcy [~MC@unaffiliated/emcy] has joined #bitcoin-core-dev 05:42 -!- nelruk [~dax_the_c@host-62.58.217.201.copaco.com.py] has joined #bitcoin-core-dev 05:44 -!- Emcy [~MC@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 05:46 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 05:51 -!- unholymachine [~quassel@2601:8c:c003:9f16:a023:37f:59f4:ce3c] has quit [Remote host closed the connection] 05:54 -!- unholymachine [~quassel@2601:8c:c003:9f16:14df:87d9:3f2d:12b2] has joined #bitcoin-core-dev 05:55 -!- nelruk [~dax_the_c@host-62.58.217.201.copaco.com.py] has quit [Quit: Leaving] 05:55 -!- pergaminho [~Cleber@201.47.91.172] has joined #bitcoin-core-dev 06:00 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 248 seconds] 06:00 -!- d_p_ [~d_p@gateway/tor-sasl/dp/x-51976874] has quit [Ping timeout: 248 seconds] 06:01 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 248 seconds] 06:02 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 258 seconds] 06:03 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 06:17 -!- d_p [~d_p@gateway/tor-sasl/dp/x-51976874] has joined #bitcoin-core-dev 06:17 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 06:17 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 06:17 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 06:23 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/26fee4f6bd9a...ffa5159cefb8 06:23 < bitcoin-git> bitcoin/master 207408b Jonas Schnelli: Fix crash via division by zero assertion 06:23 < bitcoin-git> bitcoin/master ffa5159 Wladimir J. van der Laan: Merge #11508: Fix crash via division by zero assertion... 06:24 < bitcoin-git> [bitcoin] laanwj closed pull request #11508: Fix crash via division by zero assertion (master...2017/10/qt_cc_crash_zero) https://github.com/bitcoin/bitcoin/pull/11508 06:40 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ffa5159cefb8...b645f368f299 06:40 < bitcoin-git> bitcoin/master 7104de8 João Barbosa: [wallet] Fix leak in CDB constructor... 06:40 < bitcoin-git> bitcoin/master b645f36 Wladimir J. van der Laan: Merge #11492: [wallet] Fix leak in CDB constructor... 06:40 < promag> doesn't make sense to "return false" here: https://github.com/bitcoin/bitcoin/blob/master/src/validation.cpp#L941 ? 06:40 < bitcoin-git> [bitcoin] laanwj closed pull request #11492: [wallet] Fix leak in CDB constructor (master...2017-10-cdb-constructor-leak) https://github.com/bitcoin/bitcoin/pull/11492 06:41 < promag> if fTxIndex and !ReadTxIndex why continue? 06:42 < sipa> promag: makes sense 06:42 < promag> PR on the way 06:42 < promag> btw 06:42 < promag> sometimes why on earth AssertLockHeld fails on some travis jobs? 06:43 < promag> any insight? 06:43 < promag> https://travis-ci.org/bitcoin/bitcoin/builds/289428354 06:43 < sipa> that would indicate a bug.. 06:44 < promag> right, I've added the AssertLockHeld, but only some builds fail 06:44 < promag> s/builds/jobs 06:44 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-nhwivmlpilissjke] has quit [Quit: Connection closed for inactivity] 06:46 < sipa> not all are built with -DDEBUG_LOCKS 06:47 < wumpus> there is significant overhead to lock checking so it is only enabled for debug builds 06:48 < promag> you mean debug_lockorder? 06:48 < wumpus> yes 06:48 < promag> I understand, I'll check that out 06:49 < sipa> we have an ad-hoc lock contention/correctness checking, which is compiled in when you build with -DDEBUG_LOCKORDER 06:49 < Banzai10> promag, do you have the logs? 06:49 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b645f368f299...2ca518deff25 06:50 < bitcoin-git> bitcoin/master c5dfa90 Cristian Mircea Messel: [tests] Add uacomment tests... 06:50 < bitcoin-git> bitcoin/master 2ca518d Wladimir J. van der Laan: Merge #11486: [tests] Add uacomment tests... 06:50 -!- m8tion [~m8tion@81-65-53-254.rev.numericable.fr] has joined #bitcoin-core-dev 06:50 < bitcoin-git> [bitcoin] laanwj closed pull request #11486: [tests] Add uacomment tests (master...test_uacomment) https://github.com/bitcoin/bitcoin/pull/11486 06:50 < promag> Banzai10: check https://travis-ci.org/bitcoin/bitcoin/jobs/289428359 07:03 < promag> forever alone #11514 :P 07:03 < gribble> https://github.com/bitcoin/bitcoin/issues/11514 | Iterate and remove nodes without container copy by promag · Pull Request #11514 · bitcoin/bitcoin · GitHub 07:04 < promag> wumpus: now that 1 line pr is done, take this with 2 lines https://github.com/bitcoin/bitcoin/pull/11006/files 07:05 < wumpus> ah yes that one looks good to me now 07:07 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2ca518deff25...a1d78b59fc03 07:07 < bitcoin-git> bitcoin/master 793667a João Barbosa: Improve shutdown process 07:07 < bitcoin-git> bitcoin/master a1d78b5 Wladimir J. van der Laan: Merge #11006: Improve shutdown process... 07:07 < promag> :confetti: 07:07 < bitcoin-git> [bitcoin] laanwj closed pull request #11006: Improve shutdown process (master...201708-fast-shutdown) https://github.com/bitcoin/bitcoin/pull/11006 07:18 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 07:21 < wumpus> vNodes.erase(remove(vNodes.begin(), vNodes.end(), pnode), vNodes.end()); , huh 07:23 < wumpus> so std::vector::erase removes elements in a range, remove() returns the range vNodes.begin() to vNodes.end() minus pnode 07:23 < wumpus> shouldn't this remove everything but pnode? 07:27 < wumpus> std::remove "Transforms the range [first,last) into a range with all the elements that compare equal to val removed, and returns an iterator to the new end of that range." 07:28 < cfields> wumpus: https://en.wikipedia.org/wiki/Erase%E2%80%93remove_idiom 07:28 < cfields> I had to look it up first time I saw it 07:29 < wumpus> whoa that could have at least used a comment 07:32 < wumpus> oh no did i break travis? 07:33 < wumpus> E: Failed to fetch https://packagecloud.io/basho/riak/ubuntu/dists/trusty/main/source/Sources 401 Unauthorized no, apparently a download failure 07:35 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a1d78b59fc03...50d72b357081 07:35 < bitcoin-git> bitcoin/master f4c4e38 John Newbery: [trivial] Make namespace explicit for is_regular_file... 07:35 < bitcoin-git> bitcoin/master 50d72b3 Wladimir J. van der Laan: Merge #11495: [trivial] Make namespace explicit for is_regular_file... 07:36 < sdaftuar> hm, this looks like a pretty sketchy comment: https://github.com/bitcoin/bitcoin/issues/11519#issuecomment-337453387 07:36 < bitcoin-git> [bitcoin] laanwj closed pull request #11495: [trivial] Make namespace explicit for is_regular_file (master...explicit_is_regular_file) https://github.com/bitcoin/bitcoin/pull/11495 07:37 < wumpus> right, deleted it, it made no sense at all (download the app to your mobile? bitcoin.com?) 07:47 < sdaftuar> yeah, thanks - your response looks much better :) 07:52 -!- wraithm [~wraithm@unaffiliated/wraithm] has joined #bitcoin-core-dev 07:53 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/50d72b357081...6759a24eaaf7 07:53 < bitcoin-git> bitcoin/master fa9de37 MarcoFalke: qa: Make tmpdir option an absolute path... 07:53 < bitcoin-git> bitcoin/master fafa003 MarcoFalke: qa: Remove never used return value of sync_with_ping 07:53 < bitcoin-git> bitcoin/master 6759a24 Wladimir J. van der Laan: Merge #11472: qa: Make tmpdir option an absolute path, misc cleanup... 07:53 < bitcoin-git> [bitcoin] laanwj closed pull request #11472: qa: Make tmpdir option an absolute path, misc cleanup (master...Mf1710-qaMultiwalletRelDir) https://github.com/bitcoin/bitcoin/pull/11472 07:53 < wumpus> thanks :) 07:55 < wumpus> can we solve the basho riak download issue? I get an angry travis mail a few seconds after every merge now 07:56 < sipa> ? 07:56 < wumpus> I have no idea why it's downloading that package in the first place, part of travis infrastructure I guess... hm in that case there's nothing we can do 07:56 < wumpus> https://travis-ci.org/bitcoin/bitcoin/jobs/289537283 07:58 -!- d_p [~d_p@gateway/tor-sasl/dp/x-51976874] has quit [Ping timeout: 248 seconds] 08:02 < bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/6759a24eaaf7...937613d215de 08:02 < bitcoin-git> bitcoin/master c6b07fd practicalswift: Fix a vs. an typo 08:02 < bitcoin-git> bitcoin/master 68feb49 practicalswift: Use nullptr instead of NULL 08:02 < bitcoin-git> bitcoin/master 0aacfa4 practicalswift: Remove accidental stray semicolon 08:03 < bitcoin-git> [bitcoin] laanwj closed pull request #11467: Fix typos. Use nullptr instead of NULL. (master...cleanups-20171009) https://github.com/bitcoin/bitcoin/pull/11467 08:04 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 240 seconds] 08:06 -!- arubi_ [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 08:07 -!- d_p_ [~d_p@gateway/tor-sasl/dp/x-51976874] has joined #bitcoin-core-dev 08:08 -!- Guest83 [~textual@2602:306:378a:6fb0:5d6a:b4c6:9f40:e529] has joined #bitcoin-core-dev 08:08 -!- sybarite [~sybarite@122.15.111.165] has quit [Ping timeout: 248 seconds] 08:09 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 248 seconds] 08:12 -!- arubi_ is now known as arubi 08:30 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection] 08:31 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 08:43 -!- Guest83 [~textual@2602:306:378a:6fb0:5d6a:b4c6:9f40:e529] has quit [Ping timeout: 246 seconds] 08:50 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 08:55 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has joined #bitcoin-core-dev 08:59 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has quit [Client Quit] 09:09 < cfields> sdaftuar: in case you missed it, see backlog re moving addrman 09:09 < sdaftuar> cfields: thanks, i got it -- reviewing #11457 now in fact 09:10 < gribble> https://github.com/bitcoin/bitcoin/issues/11457 | Introduce BanMan by theuni · Pull Request #11457 · bitcoin/bitcoin · GitHub 09:10 -!- jb55 [~jb55@208.98.200.100] has joined #bitcoin-core-dev 09:10 < cfields> ok. with an added interface class, is that what you were after? 09:11 < sdaftuar> i think so, yeah (well i haven't looked at the addrman change yet, but if it's just like the banman change, then yes) 09:12 < sdaftuar> i think the idea would be in regtest mode, to create a special mockedaddrman and sub it in. so just would want a (minimal) interface class to have to implement 09:12 < cfields> sdaftuar: ok 09:12 < cfields> though, my hope was that creating interfaces for these would allow us to do actual c++ unit tests, rather than having to launch an entire program instance for tests 09:15 < sdaftuar> hm. that would be better! 09:15 < sdaftuar> do you think we could really unit test interactions between net and net_processing though? that seems very hard. 09:15 < sdaftuar> (then again, what i'm doing now is also very hard) 09:16 < cfields> well we're getting close. the message processor is now an interface 09:16 < cfields> so you can define your own PeerLogicValidation and ProcessMessages as necessary 09:16 < cfields> i assume you need a good bit of stuff pulled out still, though? 09:17 < cfields> you're trying to test the outgoing peer eviction here, right? 09:17 < sdaftuar> yeah i want to test the logic i'm adding in #11490 09:17 < gribble> https://github.com/bitcoin/bitcoin/issues/11490 | Disconnect from outbound peers with bad headers chains by sdaftuar · Pull Request #11490 · bitcoin/bitcoin · GitHub 09:18 < cfields> ah thaks, i didn't realize you'd already PR'd it. Will review. 09:19 < sdaftuar> i have one more commit that is possibly even harder to test than what i've pushed so far, actually. what is there now is mostly just behavior in net_processing which might be sort-of testable (i was able to rig a single peer in regtest mode that was correctly disconnected) 09:20 < sdaftuar> but the next commit, where i have net_processing set an able_to_evict flag for net.cpp to choose to use, is trickier 09:20 < sdaftuar> as i have no way to get multiple outbound connections in our regtest environment righ tnow 09:21 < sdaftuar> that's partly due to addrman behavior (no more than one peer per ip) and net (don't connect out to a peer in the same network group as an existing peer) 09:21 < cfields> sdaftuar: one thing i have in one of my libevent branches is an ip spoofer for CNode. The idea is to setup 2 CConnman, have 1 connect x times to the other, each with a specified (fake) IP. Then you can simulate the behavior of both sides of the conenection. 09:21 < sdaftuar> so that aspect of it might be easier to do in a unit test than regtest 09:23 < cfields> sounds like it would be, yes. Otherwise you have to shove in a bunch of test-specific behavior 09:23 < sdaftuar> i don't think i'm very familiar right now with the existing unit tests that use connman, i should start there 09:23 < cfields> heh, well there really aren't any. I'm desperately trying to get the interfaces stubbed out so that we can start writing them :) 09:23 < sdaftuar> well i just noticed the existing DoS_tests file while reviewing your banman pr, that is already more than i thought we could do! 09:24 < sdaftuar> so maybe it's not crazy to think i could write a unit test with just what we have now 09:24 < cfields> yes, that one is a pretty good example of where I'd like to be heading. It allows for all local behavior without relying on a global instance 09:26 < cfields> Something else I really needed when testing the libevent code was a way to flood a peer with garbage and see how it would react. Garbage from 1 peer, 100 peers, etc. I think that's the perfect use-case for this kind of testing, because it's easy to code up a quick stub of a message processor that just does ping/pong as quickly as possible. 09:27 < cfields> I could try to code that up if it'd be helpful 09:27 < sdaftuar> thanks, not sure yet what i need until i think about the unit testing framework a bit more! i'll dive into it and see what issues i run into 09:27 < cfields> ok 09:29 < cfields> sdaftuar: thanks for the review! 09:36 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 09:36 < sdaftuar> np! 10:00 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/937613d215de...02ac8c892b1f 10:00 < bitcoin-git> bitcoin/master cc9ee80 João Barbosa: Improve ZMQ functional test 10:00 < bitcoin-git> bitcoin/master 02ac8c8 Wladimir J. van der Laan: Merge #11452: Improve ZMQ functional test... 10:00 -!- JackH [~laptop@91.189.61.70] has quit [Ping timeout: 252 seconds] 10:01 < bitcoin-git> [bitcoin] laanwj closed pull request #11452: Improve ZMQ functional test (master...2017-10-improve-zmq-test) https://github.com/bitcoin/bitcoin/pull/11452 10:09 -!- laurentmt [~Thunderbi@92.154.68.134] has quit [Quit: laurentmt] 10:10 -!- m8tion [~m8tion@81-65-53-254.rev.numericable.fr] has quit [Read error: Connection reset by peer] 10:12 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has quit [Remote host closed the connection] 10:25 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 248 seconds] 10:25 -!- d_p_ [~d_p@gateway/tor-sasl/dp/x-51976874] has quit [Ping timeout: 248 seconds] 10:25 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 248 seconds] 10:27 -!- d_p_ [~d_p@gateway/tor-sasl/dp/x-51976874] has joined #bitcoin-core-dev 10:27 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 10:29 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Read error: Connection reset by peer] 10:30 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 10:31 -!- JackH [~laptop@85.219.170.195] has joined #bitcoin-core-dev 10:33 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 10:33 -!- PaulCapestany [~PaulCapes@ip72-209-228-52.dc.dc.cox.net] has quit [Quit: .] 10:46 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev 11:14 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-denvskavcbvtqygt] has joined #bitcoin-core-dev 11:18 -!- ekrion [~ff@adsl201-232-238-252.epm.net.co] has joined #bitcoin-core-dev 11:20 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Remote host closed the connection] 11:20 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 11:25 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Ping timeout: 248 seconds] 11:28 < bitcoin-git> [bitcoin] theuni opened pull request #11521: travis: move back to the minimal image (master...travis-minimal) https://github.com/bitcoin/bitcoin/pull/11521 11:43 -!- jonasschnelli [~jonasschn@2a01:4f8:172:10da::2] has quit [Changing host] 11:43 -!- jonasschnelli [~jonasschn@unaffiliated/jonasschnelli] has joined #bitcoin-core-dev 11:50 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-dgtzavnyvhsavffc] has quit [Ping timeout: 246 seconds] 11:53 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 11:53 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Ping timeout: 240 seconds] 11:55 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 11:56 < bitcoin-git> [bitcoin] laanwj pushed 26 new commits to 0.15: https://github.com/bitcoin/bitcoin/compare/51bad9195eb4...1646f9c76036 11:56 < bitcoin-git> bitcoin/0.15 9e8aae3 Karl-Johan Alm: [wallet] Close DB on error.... 11:56 < bitcoin-git> bitcoin/0.15 50bd3f6 practicalswift: Avoid returning a BIP9Stats object with uninitialized values... 11:56 < bitcoin-git> bitcoin/0.15 b278a43 Wladimir J. van der Laan: rpc: Write authcookie atomically... 11:57 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 12:01 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev 12:02 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-zcviqlwtvyzvnqqc] has joined #bitcoin-core-dev 12:03 -!- sanada [~bitktn@36-2-119-80.chiba.ap.gmo-isp.jp] has quit [] 12:07 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-mysxkbftkajsreez] has joined #bitcoin-core-dev 12:08 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 12:31 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 248 seconds] 12:33 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 12:39 -!- cheese_ [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 12:51 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has quit [Quit: The Lounge - https://thelounge.github.io] 12:52 < cfields> wumpus: I forgot to mention in the PR, but I believe 11521 would've mitigated today's travis issue 12:53 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev 13:10 -!- goksinen [~pgupta@37.205.58.146] has joined #bitcoin-core-dev 13:25 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has quit [Quit: The Lounge - https://thelounge.github.io] 13:31 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev 13:33 -!- goksinen_ [~pgupta@193.60.231.76] has joined #bitcoin-core-dev 13:36 -!- goksinen [~pgupta@37.205.58.146] has quit [Ping timeout: 260 seconds] 13:37 -!- cheese_ [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Ping timeout: 240 seconds] 13:49 -!- jimpo [~jimpo@ec2-52-42-179-84.us-west-2.compute.amazonaws.com] has quit [Ping timeout: 252 seconds] 13:52 -!- goksinen [~pgupta@193.60.220.253] has joined #bitcoin-core-dev 13:55 -!- goksinen_ [~pgupta@193.60.231.76] has quit [Ping timeout: 240 seconds] 13:56 -!- jimpo [~jimpo@ec2-52-42-179-84.us-west-2.compute.amazonaws.com] has joined #bitcoin-core-dev 13:59 -!- JackH [~laptop@85.219.170.195] has quit [Ping timeout: 248 seconds] 14:07 -!- lrvick [~weechat_u@ec2-52-27-169-212.us-west-2.compute.amazonaws.com] has quit [Ping timeout: 246 seconds] 14:09 -!- goksinen [~pgupta@193.60.220.253] has quit [Remote host closed the connection] 14:13 -!- lrvick [~weechat_u@ec2-52-27-169-212.us-west-2.compute.amazonaws.com] has joined #bitcoin-core-dev 14:14 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 248 seconds] 14:19 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 14:20 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has quit [Quit: Leaving ... but you never know maybe I come back!] 14:22 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev 14:24 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 14:27 -!- fluidjax [~fluidjax@host81-153-234-3.range81-153.btcentralplus.com] has joined #bitcoin-core-dev 14:33 -!- ecurrencyhodler_ [uid256930@gateway/web/irccloud.com/x-evlyvkhogapyzgrt] has quit [Quit: Connection closed for inactivity] 14:39 < ossifrage> This is very strange, the 'copy addess' (all copy to clipboard) functions just stop running on bitcoin-qt (0.15.0 linux), other programs talk to the cut buffer just fine, but not bitcoin-qt 14:43 < ossifrage> Ah, there is console output: "Warn Dissector bug, protocol Bitcoin, in packet 3560375: proto.c:5519: failed assertion "idx >= 0 && idx < num_tree_types"" 14:44 < ossifrage> Never mind, that has nothing to do with this... 14:44 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 252 seconds] 14:45 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 14:45 < ossifrage> I can't even copy text from the transaction details dialog... 14:59 -!- DEV_ [4ee39d6e@gateway/web/freenode/ip.78.227.157.110] has joined #bitcoin-core-dev 14:59 < DEV_> we are working on a development project of the blockchain any donations will be welcome we will update you on the progress of the project as you go btc wallet : 1LJBnabTgobc6xpgH92eV7yha36KSMvtSP 14:59 -!- DEV_ [4ee39d6e@gateway/web/freenode/ip.78.227.157.110] has quit [Client Quit] 15:02 -!- roadcrap [~roadcrypt@unaffiliated/roadcrap] has quit [Ping timeout: 255 seconds] 15:02 -!- moctos [~moctos@cpe-107-9-138-59.neo.res.rr.com] has joined #bitcoin-core-dev 15:04 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 15:05 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 15:05 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 15:10 -!- wraithm [~wraithm@unaffiliated/wraithm] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 15:18 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 15:27 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 15:55 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 16:01 -!- Dizzle [~dizzle@108.171.182.16] has quit [Ping timeout: 260 seconds] 16:09 -!- goatpig [56f75683@gateway/web/freenode/ip.86.247.86.131] has quit [Quit: Page closed] 16:23 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has quit [] 16:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 16:41 -!- Banzai10 [b189f883@gateway/web/cgi-irc/kiwiirc.com/ip.177.137.248.131] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client] 16:43 -!- Banzai10 [b189f8b5@gateway/web/cgi-irc/kiwiirc.com/ip.177.137.248.181] has joined #bitcoin-core-dev 17:02 -!- jb55 [~jb55@208.98.200.100] has quit [Ping timeout: 248 seconds] 17:24 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 264 seconds] 17:25 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 17:28 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 17:31 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 258 seconds] 17:39 -!- Emcy [~MC@unaffiliated/emcy] has joined #bitcoin-core-dev 17:51 < bitcoin-git> [bitcoin] JeremyRubin opened pull request #11523: [Refactor] CValidation State (master...dos-cleanup) https://github.com/bitcoin/bitcoin/pull/11523 17:52 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev 17:56 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has joined #bitcoin-core-dev 18:02 -!- wxss [~chatzilla@196.196.200.5] has quit [Remote host closed the connection] 18:05 -!- pergaminho [~Cleber@201.47.91.172] has quit [Quit: This computer has gone to sleep] 18:07 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 18:13 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 18:15 -!- pergaminho [~Cleber@201.47.91.172] has joined #bitcoin-core-dev 18:17 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-mysxkbftkajsreez] has quit [Quit: Connection closed for inactivity] 18:17 -!- pergaminho [~Cleber@201.47.91.172] has quit [Client Quit] 18:33 -!- roadcrap [~roadcrypt@unaffiliated/roadcrap] has joined #bitcoin-core-dev 18:35 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 248 seconds] 18:43 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 19:06 -!- Banzai10 [b189f8b5@gateway/web/cgi-irc/kiwiirc.com/ip.177.137.248.181] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client] 19:25 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds] 19:25 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 19:37 -!- PaulCapestany [~PaulCapes@ip68-100-207-53.dc.dc.cox.net] has joined #bitcoin-core-dev 19:39 -!- Banzai10 [b189f8b5@gateway/web/cgi-irc/kiwiirc.com/ip.177.137.248.181] has joined #bitcoin-core-dev 19:40 -!- Banzai10 [b189f8b5@gateway/web/cgi-irc/kiwiirc.com/ip.177.137.248.181] has quit [Client Quit] 19:57 -!- Banzai10 [b189f8b5@gateway/web/cgi-irc/kiwiirc.com/ip.177.137.248.181] has joined #bitcoin-core-dev 19:58 -!- Banzai10 [b189f8b5@gateway/web/cgi-irc/kiwiirc.com/ip.177.137.248.181] has quit [Client Quit] 20:00 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 20:05 -!- merehap_ [~sean@c-73-239-115-62.hsd1.wa.comcast.net] has quit [Read error: No route to host] 20:05 -!- merehap__ [~sean@c-73-239-115-62.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 20:13 -!- wraithm [~wraithm@unaffiliated/wraithm] has joined #bitcoin-core-dev 20:17 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 20:17 -!- wraithm [~wraithm@unaffiliated/wraithm] has quit [Ping timeout: 248 seconds] 20:19 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Client Quit] 20:23 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-denvskavcbvtqygt] has quit [Quit: Connection closed for inactivity] 21:09 -!- Nishadburhan [ca533843@gateway/web/freenode/ip.202.83.56.67] has joined #bitcoin-core-dev 21:11 -!- Nishadburhan [ca533843@gateway/web/freenode/ip.202.83.56.67] has quit [Client Quit] 21:15 -!- vicenteH` [~user@35.233.15.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 21:16 -!- vicenteH [~user@35.233.15.37.dynamic.jazztel.es] has quit [Ping timeout: 246 seconds] 21:21 -!- lrvick [~weechat_u@ec2-52-27-169-212.us-west-2.compute.amazonaws.com] has quit [Remote host closed the connection] 21:31 -!- lrvick [~weechat_u@ec2-52-27-169-212.us-west-2.compute.amazonaws.com] has joined #bitcoin-core-dev 21:45 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-gpsjbfsqolqirsrh] has joined #bitcoin-core-dev 21:58 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 22:42 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-fozbjbmbflhahbds] has joined #bitcoin-core-dev 23:03 -!- Emcy [~MC@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 23:03 -!- Emcy [~MC@unaffiliated/emcy] has joined #bitcoin-core-dev 23:09 -!- goksinen [~pgupta@193.60.220.253] has joined #bitcoin-core-dev 23:14 -!- goksinen [~pgupta@193.60.220.253] has quit [Ping timeout: 240 seconds] 23:20 -!- Cogito_Ergo_Sum [~Myself@athedsl-315161.home.otenet.gr] has joined #bitcoin-core-dev 23:20 -!- Cogito_Ergo_Sum [~Myself@athedsl-315161.home.otenet.gr] has quit [Changing host] 23:20 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev 23:28 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has joined #bitcoin-core-dev 23:28 -!- goksinen [~pgupta@193.60.220.253] has joined #bitcoin-core-dev 23:28 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has quit [Ping timeout: 240 seconds] 23:31 -!- chjj [~chjj@unaffiliated/chjj] has quit [Quit: WeeChat 1.9.1] 23:33 -!- goksinen [~pgupta@193.60.220.253] has quit [Ping timeout: 248 seconds] 23:41 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has quit [Quit: (https://github.com/mmgen) leaving] 23:53 -!- cluelessperson [~cluelessp@unaffiliated/cluelessperson] has quit [Ping timeout: 258 seconds] 23:55 -!- dcousens [~dcousens@c110-22-219-15.sunsh4.vic.optusnet.com.au] has quit [Remote host closed the connection] 23:59 -!- cluelessperson [~cluelessp@unaffiliated/cluelessperson] has joined #bitcoin-core-dev