--- Day changed Tue Oct 24 2017 00:00 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer] 00:08 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:12 -!- laurentmt [~Thunderbi@92.154.68.134] has joined #bitcoin-core-dev 00:13 -!- laurentmt [~Thunderbi@92.154.68.134] has quit [Client Quit] 00:37 -!- m8tion [~m8tion@81-65-53-254.rev.numericable.fr] has joined #bitcoin-core-dev 00:57 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:11 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:12 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:12 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has joined #bitcoin-core-dev 01:13 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has quit [Client Quit] 01:14 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has quit [Ping timeout: 240 seconds] 01:15 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has joined #bitcoin-core-dev 01:21 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 248 seconds] 01:23 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 01:37 -!- vicenteH` [~user@35.233.15.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 01:38 -!- marcoagner [~user@gateway/tor-sasl/marcoagner] has joined #bitcoin-core-dev 01:38 -!- vicenteH [~user@35.233.15.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds] 01:39 -!- vicenteH` is now known as vicenteH 01:42 -!- jonasschnelli [~jonasschn@unaffiliated/jonasschnelli] has quit [Ping timeout: 252 seconds] 01:43 -!- jonasschnelli [~jonasschn@bitcoinsrv.jonasschnelli.ch] has joined #bitcoin-core-dev 02:04 -!- JackH [~laptop@host-80-47-85-226.as13285.net] has joined #bitcoin-core-dev 02:07 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 02:12 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 02:17 -!- xxxxxxx_ [d95eff41@gateway/web/freenode/ip.217.94.255.65] has joined #bitcoin-core-dev 02:18 -!- xxxxxxx_ [d95eff41@gateway/web/freenode/ip.217.94.255.65] has quit [Client Quit] 02:23 -!- william [~william@2604:2000:71d5:e500:ef25:5b1c:d633:3daf] has quit [Quit: william] 02:24 -!- william [~william@2604:2000:71d5:e500:ef25:5b1c:d633:3daf] has joined #bitcoin-core-dev 02:28 -!- william [~william@2604:2000:71d5:e500:ef25:5b1c:d633:3daf] has quit [Client Quit] 02:28 -!- william [~william@2604:2000:71d5:e500:ef25:5b1c:d633:3daf] has joined #bitcoin-core-dev 02:33 -!- marcoagner [~user@gateway/tor-sasl/marcoagner] has quit [Ping timeout: 248 seconds] 02:34 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 02:35 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Remote host closed the connection] 02:36 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 02:36 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 02:37 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 02:49 -!- laurentmt [~Thunderbi@92.154.68.134] has joined #bitcoin-core-dev 02:50 -!- marcoagner [~user@gateway/tor-sasl/marcoagner] has joined #bitcoin-core-dev 02:58 -!- dabura667_ [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev 02:58 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Read error: No route to host] 03:08 -!- Alkhara [60e6e47c@gateway/web/cgi-irc/kiwiirc.com/ip.96.230.228.124] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client] 03:08 -!- Alkhara [60e6e47c@gateway/web/cgi-irc/kiwiirc.com/ip.96.230.228.124] has joined #bitcoin-core-dev 03:22 -!- dabura667_ [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection] 03:25 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 03:38 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Remote host closed the connection] 03:39 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 03:41 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has quit [] 03:56 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 240 seconds] 03:57 -!- jtimon [~quassel@164.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 04:00 -!- wxss [~chatzilla@82.221.112.213] has joined #bitcoin-core-dev 04:04 -!- m8tion [~m8tion@81-65-53-254.rev.numericable.fr] has quit [Read error: Connection reset by peer] 04:04 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 04:08 -!- william [~william@2604:2000:71d5:e500:ef25:5b1c:d633:3daf] has quit [Quit: william] 04:08 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 04:09 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 04:12 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has joined #bitcoin-core-dev 04:13 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 04:15 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 240 seconds] 04:22 -!- marcoagner [~user@gateway/tor-sasl/marcoagner] has quit [Quit: WeeChat 1.0.1] 04:30 -!- str4d [~str4d@27.110.123.91] has quit [Ping timeout: 246 seconds] 04:47 -!- cxr [~cxr@175.223.16.54] has joined #bitcoin-core-dev 04:49 < sdaftuar> gmaxwell: thanks, that sounds better 04:49 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Remote host closed the connection] 04:49 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 04:49 < sdaftuar> gmaxwell: i thought of another problem with that patch, that i'm not sure how to best address 04:49 -!- str4d [~str4d@27.110.123.91] has joined #bitcoin-core-dev 04:50 -!- cxr [~cxr@175.223.16.54] has quit [Quit: leaving] 04:50 < sdaftuar> it seems suboptimal to disconnect a peer that hasn't been connected very long -- eg perhaps your tip is stale, but the peer you're choosing to evict is one you just connected to 04:50 -!- cxr [~cxr@175.223.16.54] has joined #bitcoin-core-dev 04:51 < sipa> sdaftuar: years ago i experimented with a outbound connection rotation system, which kicked just based on chances that depend on connection time 04:51 < sdaftuar> or, perhaps your network was down for a few hours (say, you're running on a laptop) and then when you start up, you detect a stale tip -- so you immediately flag one of your initial 8 peers for eviction, for basically no good reason 04:52 < sipa> i believe a good approach was (by simulations, but i've lost all the code so it's hard to reproduce) to make the chance to disconnect proportional to time_connected^-0.8 04:53 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Ping timeout: 240 seconds] 04:54 < sipa> sdaftuar: well if we're considering something like peer rotation anyway (at least, i am), then occasionally randomly disconnecting someone for no reason isn't too bad 04:54 < sdaftuar> sipa: i haven't given a ton of thought to how to measure success/failure of general-purpose algorithms like that... 04:54 < sipa> at least if it only happens occasionally 04:55 < sdaftuar> ah, ok 04:55 < sdaftuar> well, i think my PR won't behave *terribly*, under the assumption that it's okay for an occasional spurious disconnect 04:55 -!- cxr [~cxr@175.223.16.54] has quit [Quit: leaving] 04:55 < sdaftuar> though it could certainly use testing 04:56 < sipa> and in general, your most recent connection is the least likely peer to be your best 04:56 < sdaftuar> right, agreed. i think my PR does have an edge-case bug, where eg your first peer could be the one disconnected (in the situation where your network is down, then comes back up, and you briefly have just one peer that is fully connected-- 04:56 < sipa> so if we're aiming for simplicity, i don't think it'll be terrible under any circumstances 04:57 < sdaftuar> it could be flagged for eviction) 04:58 < sdaftuar> i was considering another approach to the same problem, where i just connect outbound to a 9th peer when the tip looks like it might be stale, and then at some point after that disconnect one 04:58 < sdaftuar> with the idea that if no new info was learned from the 9th, then it should be the one disconnected 04:58 < sdaftuar> i think that approach has the advantage of (a) being able to trigger more often, because it seems safer to connect to an extra peer than disconnect an existing one, so you can test for stale-ness with less conservatism 04:59 < sipa> right 04:59 < sdaftuar> and (b) it seems like the outbound peer selection logic will perform better if you connect to a new peer before disconnecting an old peer (due to the netgroup diversity requirement? if i understand it right) 04:59 < sdaftuar> but i haven't quite worked out the implementation details yet 05:08 -!- cxr [~cxr@1.214.207.2] has joined #bitcoin-core-dev 05:13 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 05:20 < bitcoin-git> [bitcoin] ryanofsky opened pull request #11552: Improve wallet-accounts test (master...pr/acctt) https://github.com/bitcoin/bitcoin/pull/11552 05:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 05:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:26 -!- str4d [~str4d@27.110.123.91] has quit [Ping timeout: 248 seconds] 05:28 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 05:29 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 05:30 -!- way [7386f605@gateway/web/freenode/ip.115.134.246.5] has joined #bitcoin-core-dev 05:33 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 05:36 -!- way [7386f605@gateway/web/freenode/ip.115.134.246.5] has quit [Ping timeout: 260 seconds] 05:36 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 05:48 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 05:54 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has quit [] 05:55 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has joined #bitcoin-core-dev 05:56 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 05:56 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Client Quit] 05:58 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 06:10 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 06:12 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 06:14 -!- pedrobranco [~pedrobran@79.242.108.93.rev.vodafone.pt] has quit [Client Quit] 06:29 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 06:32 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 06:42 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 255 seconds] 06:44 -!- jouke [~jouke@unaffiliated/komkommer] has quit [Ping timeout: 240 seconds] 06:55 < aj> jtimon: hmm, googling old issues doesn't seem like there's much consensus on changing RPC from decimal BTC values? #9855 was the most recent i saw, i think 06:55 < gribble> https://github.com/bitcoin/bitcoin/issues/9855 | RPC: Use integer satoshis instead BTC with decimals by jtimon · Pull Request #9855 · bitcoin/bitcoin · GitHub 06:57 < jtimon> perhaps that's a good topic for the next meeting 06:57 < jtimon> it was my understanding that everybody considered using BTC instead of satoshis a mistake, but perhaps it's just me and I'm just assuming the opinions of others 06:58 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-xrqejfhhklzqbwad] has quit [Quit: Connection closed for inactivity] 07:00 < aj> jtimon: if i'm understanding what they're saying, sipa and wumpus seem to think string vs number is more important than btc vs satoshi 07:01 < aj> jtimon: https://github.com/bitcoin/bitcoin/pull/3759/commits/f3f8460fe51be719231612a921dd37af638df46a seems like a good idea to me? 07:01 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has quit [] 07:10 -!- promag [~promag@92.250.79.49] has joined #bitcoin-core-dev 07:15 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 07:17 -!- jouke [~jouke@a80-100-203-151.adsl.xs4all.nl] has joined #bitcoin-core-dev 07:29 -!- promag [~promag@92.250.79.49] has quit [Remote host closed the connection] 07:44 -!- promag [~promag@89.214.84.121] has joined #bitcoin-core-dev 07:51 -!- promag [~promag@89.214.84.121] has quit [Remote host closed the connection] 07:54 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 08:09 -!- promag [~promag@95.69.113.133] has joined #bitcoin-core-dev 08:31 -!- promag [~promag@95.69.113.133] has quit [Remote host closed the connection] 08:34 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds] 09:12 -!- dumnut [~me@unaffiliated/dumnut] has quit [Ping timeout: 258 seconds] 09:13 -!- Alkhara [60e6e47c@gateway/web/cgi-irc/kiwiirc.com/ip.96.230.228.124] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client] 09:16 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 09:17 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 09:21 -!- pierre_rochard [~pierre@unaffiliated/pierre-rochard/x-3593157] has quit [Quit: pierre_rochard] 09:27 -!- pigeons [~pigeons@static.208.136.40.188.clients.your-server.de] has quit [Quit: Changing server] 09:27 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 09:29 -!- laurentmt [~Thunderbi@92.154.68.134] has quit [Quit: laurentmt] 09:31 -!- xinxi [~xinxi@39.109.214.22] has joined #bitcoin-core-dev 09:32 -!- gaf_ [~fag@12.smos-linux.org] has joined #bitcoin-core-dev 09:34 < jtimon> aj: I also tried https://github.com/bitcoin/bitcoin/pull/9855 but it wasn't very well received 09:35 < jtimon> also I think string vs numbers is more important when you have decimals. for integer satoshis I don't think anyone has a problem with them being numbers 09:35 < jtimon> perhaps I'm wrong there too, not sure 09:36 < jtimon> but for the getblockstats pr, I really think using integer satoshis is the right thing to do 09:36 < jtimon> or the best option 09:52 -!- mess110 [~kiki@95.77.248.16] has joined #bitcoin-core-dev 10:02 < bitcoin-git> [bitcoin] Varunram opened pull request #11553: [P2P] Throw Warning if -peerbloomfilters is enabled (master...peerfilters) https://github.com/bitcoin/bitcoin/pull/11553 10:03 < Varunram> Hey guys! This is my first PR, please pardon me if I've done something wrong or haven't abided by any rules. Looking forward to your comments :) 10:07 -!- StopAndDecrypt__ is now known as StopAndDecrypt 10:10 -!- jb55 [~jb55@208.98.200.100] has joined #bitcoin-core-dev 10:31 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has quit [] 10:35 -!- xinxi [~xinxi@39.109.214.22] has quit [Remote host closed the connection] 10:35 -!- xinxi [~xinxi@39.109.214.22] has joined #bitcoin-core-dev 10:38 -!- vicenteH [~user@35.233.15.37.dynamic.jazztel.es] has quit [Ping timeout: 252 seconds] 10:38 -!- vicenteH [~user@35.233.15.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 10:47 -!- nik_ [ade0a245@gateway/web/freenode/ip.173.224.162.69] has joined #bitcoin-core-dev 11:05 -!- ertwro [be9e9254@gateway/web/freenode/ip.190.158.146.84] has joined #bitcoin-core-dev 11:05 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-tfblysuqdhvqgmsk] has joined #bitcoin-core-dev 11:12 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #11554: Sanity-check script sizes in bitcoin-tx (master...2017-10-bitcoin-tx-script-sizes) https://github.com/bitcoin/bitcoin/pull/11554 11:14 < BlueMatt> Varunram: heh, thanks for the pr, though sadly I dont think we can do that yet :( 11:15 < BlueMatt> Varunram: note that the -peerbloomfilters option is mostly to prevent dos issues for nodes which cannot take the potential latency increases, and not to encourage people to stop providing bloom filters until we have a viable alternative :/ 11:18 < Varunram> BlueMatt: haha, no worries :) I was going through the issues with "good first issue" labels on them and this seemed to be a good place to start. And yeah, we certainly don't want people to stop providing bloom filters, that would take a hit on SPV clients as a whole 11:19 < BlueMatt> heh, yea, maybe we should be better about tags... 11:19 < BlueMatt> someone should probably remove the "good first issue" tag there.... 11:19 < Varunram> I'll rummage through the issues repo and contribute something more useful, meanwhile do I close the PR or? 11:20 < BlueMatt> I mean you dont have to, but it'll sit for 6/12 months if you dont "waiting on someone to add a viable alternative".... 11:20 < Varunram> I had a slight notion that it might be controversial, but gave it a shot (yolo lol) 11:20 < BlueMatt> so probably easier to... 11:21 < Varunram> got it, thanks! 11:21 -!- xinxi [~xinxi@39.109.214.22] has quit [Remote host closed the connection] 11:22 -!- xinxi [~xinxi@39.109.214.22] has joined #bitcoin-core-dev 11:23 -!- ertwro [be9e9254@gateway/web/freenode/ip.190.158.146.84] has quit [Quit: Page closed] 11:23 -!- seone [~seone@unaffiliated/seone] has quit [Quit: seone] 11:23 -!- Cogito_Ergo_Sum [~Myself@athedsl-314925.home.otenet.gr] has joined #bitcoin-core-dev 11:23 -!- Cogito_Ergo_Sum [~Myself@athedsl-314925.home.otenet.gr] has quit [Changing host] 11:23 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev 11:25 < bitcoin-git> [bitcoin] Varunram closed pull request #11553: [P2P] Throw Warning if -peerbloomfilters is enabled (master...peerfilters) https://github.com/bitcoin/bitcoin/pull/11553 11:29 < jb55> seconded on adding more good first issue tags, I'm also interested in getting my feet wet.. 12:07 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 12:19 -!- riemann [~riemann@ip-222-88.ists.pl] has joined #bitcoin-core-dev 12:33 -!- str4d [~str4d@27.110.123.91] has joined #bitcoin-core-dev 12:37 < cfields> sdaftuar: sorry for the late review 12:38 * luke-jr wonders why dns seeder added a second copy of the service bits 12:39 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev 12:59 < luke-jr> dnsseed.bitcoin.dashjr.org is now servicebit-filter-enabled 12:59 -!- benji [adefdb11@gateway/web/freenode/ip.173.239.219.17] has joined #bitcoin-core-dev 12:59 < sdaftuar> cfields: thanks for taking a look! 12:59 -!- mkarrer [~mkarrer@64.209.30.59] has joined #bitcoin-core-dev 12:59 -!- benji is now known as Guest51752 13:00 < cfields> sdaftuar: don't kill me for that last comment... I know 11534 was my suggestion :\ 13:02 < sdaftuar> no problem, thanks for thinking about it. not sure if you saw the scrollback, but i'm actually working on an alternate implementation where we'd add a new peer first, and then figure out who to disconnect 13:02 < sdaftuar> i *think* that will turn out to be simpler... but the code isn't done yet, so too early for me to be sure 13:02 < sdaftuar> testing this stuff is all awful of course :( 13:04 < sdaftuar> anyway i think #11490 is closer to done, so i'll address your comments there and hopefully we can get some final acks soon 13:04 < gribble> https://github.com/bitcoin/bitcoin/issues/11490 | Disconnect from outbound peers with bad headers chains by sdaftuar · Pull Request #11490 · bitcoin/bitcoin · GitHub 13:04 < cfields> no, i didn't see that 13:04 < cfields> reading 13:07 < gmaxwell> sdaftuar: I like adding a new peer first; then we won't potentially spend a long time with one fewer peer. 13:07 < cfields> I see. The idea being that you may disconnect a node just to connect to his neighbor. But if you have a new connection first, you can make a better decision 13:08 -!- mkarrer [~mkarrer@64.209.30.59] has quit [] 13:08 < sdaftuar> cfields: yeah. i don't know how compelling that reasoning is, but that plus not being able to be more aggressive about checking whether your tip is stale both seem like good reasons 13:08 < sdaftuar> and what gmaxwell said ^ 13:11 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 13:21 < gmaxwell> this was, fwiw, how I always envisioned outbound rotation working, temporarily allowing one extra peer, then deciding which one to axe after you've talked to the new one. 13:36 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Ping timeout: 246 seconds] 13:46 -!- alreadylate [~textual@c-250e71d5.153-1-64736c10.cust.bredbandsbolaget.se] has joined #bitcoin-core-dev 13:47 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Read error: Connection reset by peer] 13:48 -!- riemann [~riemann@ip-222-88.ists.pl] has quit [Ping timeout: 264 seconds] 13:53 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 13:56 < cfields> sdaftuar: so should i let #11534 rest until you've tried out your new approach? 13:56 < gribble> https://github.com/bitcoin/bitcoin/issues/11534 | Evict outbound peers if tip is stale by sdaftuar · Pull Request #11534 · bitcoin/bitcoin · GitHub 13:57 < sdaftuar> cfields: yeah maybe give me another day or so to try to get a new approach working, and then we can compare and see which looks more viable? 13:57 < cfields> ok, np 13:57 < sdaftuar> so you don't waste your time on an approach we abandon 13:59 < cfields> also, if our p2p was more spec'd out, I'd grumpily ask for a bip for #11490. But I guess it's not worth it since we already make a bunch of assumptions. 13:59 < gribble> https://github.com/bitcoin/bitcoin/issues/11490 | Disconnect from outbound peers with bad headers chains by sdaftuar · Pull Request #11490 · bitcoin/bitcoin · GitHub 14:00 < sdaftuar> i'm not averse to documentation, but do you think it needs a bip? i feel like peer selection is something that doesn't really require coordination across implementations 14:01 < cfields> nah, i don't think it's really needed 14:02 < cfields> not the peer selection though, the "you must send MAX_HEADERS_RESULTS or be disconnected" rule. 14:02 < sdaftuar> oh, i forgot about that 14:03 < gmaxwell> We alrady have a requirement for the max results, since our headers syncinc chaining depends on it, no? 14:03 < sdaftuar> gmaxwell: yeah, that's basically how i looked at it 14:04 < sdaftuar> i think matt observed that if we added a one-off getheaders message (eg with a hashstop) before we'd completed chain sync from a peer for some reason, then that would interact badly with the new logic 14:04 < gmaxwell> since it's automatic outbound only it wouldn't harm monitoring tools or such that don't really implement the protocol correctly. 14:04 < sdaftuar> but we don't do that... and i don't know why we would 14:04 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-mrndwvsklucuhpxw] has joined #bitcoin-core-dev 14:05 < cfields> ah, so it does 14:08 -!- riemann [~riemann@ip-222-88.ists.pl] has joined #bitcoin-core-dev 14:10 -!- mess110 [~kiki@95.77.248.16] has quit [Remote host closed the connection] 14:12 -!- alreadylate [~textual@c-250e71d5.153-1-64736c10.cust.bredbandsbolaget.se] has quit [] 14:20 -!- Giszmo [~leo@pc-224-130-104-200.cm.vtr.net] has joined #bitcoin-core-dev 14:32 < gmaxwell> sdaftuar: another point why its important that we don't evict half our outbound peers in 11490. Consider, say there is a new softfork we don't know about. At the moment, a chain violating it is a block ahead. We don't want the non-upgraded network to completely partition the upgraded network, because eventually the upgraded network will get ahead and we will switch to it. 14:32 < sdaftuar> gmaxwell: great point. i should add a comment 14:33 < sdaftuar> hmm, do you think protecting the first 4 who give us headers is reasonable then? 14:34 < sdaftuar> (afk, back later) 14:37 < BlueMatt> google translate appears to think #11555 is the guy asking how to create his own altcoin....someone wanna close it? 14:37 < gribble> https://github.com/bitcoin/bitcoin/issues/11555 | ПОМОГИТЕ!!!!!!! · Issue #11555 · bitcoin/bitcoin · GitHub 14:39 < gmaxwell> sdaftuar: yes, probably. 14:39 < gmaxwell> sdaftuar: to be fair on my point, inbound connections would heal the partition, but I feel better if we can justify the behavior even in the impossible network of only hosts with outbound connections. 14:40 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 248 seconds] 14:48 -!- alreadylate [~textual@c-250e71d5.153-1-64736c10.cust.bredbandsbolaget.se] has joined #bitcoin-core-dev 14:51 -!- william [~william@2604:2000:71d5:e500:ef25:5b1c:d633:3daf] has joined #bitcoin-core-dev 14:58 < meshcollider> BlueMatt: heh I like his/Google's phrasing, "altcoin come alive and go free swimming" 14:59 -!- str4d_ [~str4d@27.110.123.91] has joined #bitcoin-core-dev 15:02 -!- str4d [~str4d@27.110.123.91] has quit [Ping timeout: 240 seconds] 15:02 -!- alreadylate [~textual@c-250e71d5.153-1-64736c10.cust.bredbandsbolaget.se] has quit [] 15:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 15:05 < esotericnonsense> does anyone have a good way to reproduce slow RPC behaviour? all I can think of at the moment is continually resyncing which doesn't seem like a good idea for my poor SSD. perhaps running a seperate thread that hits RPC with heavy queries over and over? 15:06 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 15:07 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Quit: conversation terminated!] 15:08 -!- riemann [~riemann@ip-222-88.ists.pl] has quit [Quit: Leaving] 15:11 -!- cryptapus [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev 15:11 -!- cryptapus [~cryptapus@jupiter.osmus.org] has quit [Changing host] 15:11 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 15:13 -!- william is now known as Bitnet 15:14 -!- dcousens [~dcousens@c110-22-219-15.sunsh4.vic.optusnet.com.au] has joined #bitcoin-core-dev 15:21 -!- spinza [~spin@196.212.164.26] has quit [Quit: Coyote finally caught up with me...] 15:21 -!- Cheeseo [~Cheeseo@unaffiliated/cheeseo] has joined #bitcoin-core-dev 15:31 -!- spinza [~spin@196.212.164.26] has joined #bitcoin-core-dev 15:34 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 15:35 < aj> jtimon: i think the drawback for numbers vs strings is that even without a decimal point, "integers" are treated as doubles in javascript which makes it ambiguous at best in json generally 15:38 < gmaxwell> some json implementations manage to use floats for numbers too! :( 15:38 < jtimon> aj: yeah, perhaps all data in getblocksstats should be returned as strings, I still prefer satoshis over in BTC in that case 15:38 -!- Giszmo [~leo@pc-224-130-104-200.cm.vtr.net] has quit [Ping timeout: 248 seconds] 15:41 < jb55> I find myself using sed to wrap numbers in strings before I process them with jq... 15:43 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has quit [] 15:44 -!- Giszmo [~leo@pc-224-130-104-200.cm.vtr.net] has joined #bitcoin-core-dev 15:46 < jtimon> gmaxwell: so what do you think should be done for https://github.com/bitcoin/bitcoin/pull/10757 ? all string satoshis, all string BTC ? 15:47 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 15:51 < jtimon> with that PR, I'm also kind of stuck with testing...I need to add at least one segwit tx to test some of the functionality, but some size and feerate functionality is currently not being tested due to sigs not being deterministic in size,I thought about putting hardcoded private keys in the test, but nobody confirmed that it makes any sense 15:59 -!- str4d_ [~str4d@27.110.123.91] has quit [Ping timeout: 246 seconds] 15:59 -!- geezas [uid253218@gateway/web/irccloud.com/x-iuziwfveqluicbom] has quit [Quit: Connection closed for inactivity] 15:59 < jb55> jtimon: wouldn't it make more sense to just to dump N verbose blocks and build analysis tools externally? I guess that would be a bit slower... 16:04 < jtimon> jb55: mhmm, I'm talking about the tests, but yeah, didn't thought about that...hardcoded blocks should do the trick and additionally also solve any potential concern with coin selection being non deterministic too, in case more complex tests are needed in the future. Great suggestion, now I feel bad about not thinking about it myself, but good about you not waiting for me to discover that possibility on my own 16:06 -!- vicenteH [~user@35.233.15.37.dynamic.jazztel.es] has quit [Ping timeout: 260 seconds] 16:06 -!- Dizzle [~dizzle@108.171.182.16] has quit [Quit: Leaving...] 16:07 -!- Bitnet is now known as Torrent 16:08 < jb55> just came to mind because I was trying to write a script that gave me the average block times the other day... 16:11 -!- cheese_ [~Cheeseo@unaffiliated/cheeseo] has joined #bitcoin-core-dev 16:13 < jtimon> are there any other tests that use hardcoded blocks that I can copy from ? I guess the answer is no since https://github.com/bitcoin/bitcoin/pull/8994 which changes the genesis block for all functional tests is passing, but it was recently brought to my attention that hardcoding txs (including coinbases) should be enough even to construct a compatible even with a hf that completely changes the proof of work rules from genesis 16:13 < jtimon> block (such as regtest/custom) [isn't rusty around? it was him who reminded me in a completely unrelated conversation, I vaguely remind having known this before, or perhaps was just a deja vu] 16:15 -!- Cheeseo [~Cheeseo@unaffiliated/cheeseo] has quit [Ping timeout: 252 seconds] 16:16 < jtimon> or perhaps it's been too long since last time I tried the extended tests (including pruning)... 16:16 < jtimon> (for that PR) 16:19 < jtimon> I'll stop overtly and subconsciously review begging now... 16:42 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds] 16:44 -!- nik_ [ade0a245@gateway/web/freenode/ip.173.224.162.69] has quit [Ping timeout: 260 seconds] 16:47 -!- owowo [~ovovo@31.7.59.226] has joined #bitcoin-core-dev 16:47 -!- owowo [~ovovo@31.7.59.226] has quit [Changing host] 16:47 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 16:54 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 16:55 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 17:07 -!- NielsvG [~Necrathex@unaffiliated/necrathex] has quit [Ping timeout: 258 seconds] 17:13 -!- NielsvG [~Necrathex@2001:981:9573:1:d044:2ff:fe29:ad61] has joined #bitcoin-core-dev 17:13 -!- NielsvG [~Necrathex@2001:981:9573:1:d044:2ff:fe29:ad61] has quit [Changing host] 17:13 -!- NielsvG [~Necrathex@unaffiliated/necrathex] has joined #bitcoin-core-dev 17:19 < aj> jtimon: +1 on hardcoding blocks for the tests, that's a much better idea 17:19 -!- Giszmo [~leo@pc-224-130-104-200.cm.vtr.net] has quit [Ping timeout: 240 seconds] 17:26 -!- Giszmo [~leo@pc-224-130-104-200.cm.vtr.net] has joined #bitcoin-core-dev 17:27 < jtimon> aj: thanks for the feedback again, and of course thanks jb55 for the idea, my current TODO list for #10757: 17:27 < jtimon> 1) Move from range of heights to just a single height (wait to see if anybody asks for block hash alternatively), adapt tests 17:27 < jtimon> 2) Move results from numbers to strings (keep in satoshi), adapt tests 17:27 < jtimon> 3) Move from generate(101) to hardcoded blocks in tests 17:27 < jtimon> 4) Use at least 1 segwit tx to test the dunctionality 17:27 < gribble> https://github.com/bitcoin/bitcoin/issues/10757 | RPC: Introduce getblockstats to plot things by jtimon · Pull Request #10757 · bitcoin/bitcoin · GitHub 17:29 -!- Kamin8r [Kamin8r@50-82-177-102.client.mchsi.com] has joined #bitcoin-core-dev 17:30 -!- jb55 [~jb55@208.98.200.100] has quit [Ping timeout: 258 seconds] 17:41 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-tfblysuqdhvqgmsk] has quit [Quit: Connection closed for inactivity] 17:44 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 17:47 -!- Kamin8r [Kamin8r@50-82-177-102.client.mchsi.com] has quit [] 17:57 -!- StopAndDecrypt__ [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has joined #bitcoin-core-dev 17:58 -!- mariorz [sid490@gateway/web/irccloud.com/x-idmjrgzohhjmsivi] has quit [Read error: Connection reset by peer] 17:58 -!- atroxes [~atroxes@unaffiliated/atroxes] has quit [Ping timeout: 264 seconds] 17:58 -!- mariorz [sid490@gateway/web/irccloud.com/x-fllzvoucpxikwvbr] has joined #bitcoin-core-dev 17:58 -!- asoltys [~adam@115.96.198.104.bc.googleusercontent.com] has quit [Ping timeout: 260 seconds] 17:58 -!- wxss [~chatzilla@82.221.112.213] has quit [Ping timeout: 258 seconds] 17:59 -!- atroxes [~atroxes@unaffiliated/atroxes] has joined #bitcoin-core-dev 17:59 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has quit [Ping timeout: 240 seconds] 18:00 -!- asoltys [~adam@115.96.198.104.bc.googleusercontent.com] has joined #bitcoin-core-dev 18:01 -!- wxss [~chatzilla@82.221.112.213] has joined #bitcoin-core-dev 18:04 -!- merehap_ [~sean@c-73-239-115-62.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 18:09 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has joined #bitcoin-core-dev 18:10 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev 18:12 -!- roadcrap [~roadcrypt@unaffiliated/roadcrap] has quit [Ping timeout: 240 seconds] 18:32 * luke-jr ponders if it would make sense to softfork in on-chain chain-split tokens.. 18:36 -!- wxss_ [~chatzilla@82.221.112.213] has joined #bitcoin-core-dev 18:38 -!- wxss [~chatzilla@82.221.112.213] has quit [Ping timeout: 246 seconds] 18:38 -!- wxss_ is now known as wxss 18:39 < luke-jr> hmm, or maybe when/if we finally do a hardfork, just declare that all UTXOs *without* the high tx.nVersion bit set are void.. anyone who consents to the HF must set the bit for their outputs, with the understanding that the original chain can/will softfork these to be invalid when/if the HF split 18:39 * luke-jr wonders if -wizards is more appropriate for this topic 18:42 -!- Torrent [~william@2604:2000:71d5:e500:ef25:5b1c:d633:3daf] has quit [Quit: Torrent] 19:01 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 248 seconds] 19:14 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 19:16 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 246 seconds] 19:27 -!- wxss [~chatzilla@82.221.112.213] has quit [Remote host closed the connection] 19:31 -!- Giszmo [~leo@pc-224-130-104-200.cm.vtr.net] has quit [Ping timeout: 240 seconds] 19:32 -!- mxg [~mxg@2604:2000:e8c3:c700:5de4:70d8:acf:5bc1] has joined #bitcoin-core-dev 19:35 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 248 seconds] 19:36 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 19:39 -!- Giszmo [~leo@pc-224-130-104-200.cm.vtr.net] has joined #bitcoin-core-dev 19:47 -!- ekrion [~ff@adsl201-232-238-252.epm.net.co] has quit [Remote host closed the connection] 19:56 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 260 seconds] 19:59 -!- mxg [~mxg@2604:2000:e8c3:c700:5de4:70d8:acf:5bc1] has quit [Quit: afk] 20:08 -!- arowser [~quassel@106.120.101.38] has quit [Ping timeout: 248 seconds] 20:09 -!- kinlo [~peter@unaffiliated/kinlo] has quit [Ping timeout: 240 seconds] 20:13 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 20:15 -!- kinlo [~peter@unaffiliated/kinlo] has joined #bitcoin-core-dev 20:17 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev 20:19 -!- xinxi [~xinxi@39.109.214.22] has quit [Remote host closed the connection] 20:32 -!- ekrion [~ff@adsl201-232-238-252.epm.net.co] has joined #bitcoin-core-dev 20:36 -!- xinxi [~xinxi@39.109.214.22] has joined #bitcoin-core-dev 20:51 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has joined #bitcoin-core-dev 20:52 -!- StopAndDecrypt__ [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has quit [Ping timeout: 258 seconds] 20:56 -!- Giszmo [~leo@pc-224-130-104-200.cm.vtr.net] has quit [Ping timeout: 240 seconds] 21:05 -!- Giszmo [~leo@pc-224-130-104-200.cm.vtr.net] has joined #bitcoin-core-dev 21:07 -!- BGL [eighty@75-149-171-58-Washington.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 21:13 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 260 seconds] 21:14 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has quit [Ping timeout: 240 seconds] 21:16 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection] 21:31 -!- sdaftuar [~sdaftuar@unaffiliated/sdaftuar] has quit [Ping timeout: 240 seconds] 21:31 -!- jnewbery [~john@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Ping timeout: 248 seconds] 21:32 -!- zxzzt [~prod@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Ping timeout: 248 seconds] 21:33 -!- jnewbery [~john@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 21:33 -!- sdaftuar [~sdaftuar@unaffiliated/sdaftuar] has joined #bitcoin-core-dev 21:33 -!- zxzzt [~prod@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 21:38 -!- cheese_ [~Cheeseo@unaffiliated/cheeseo] has quit [Ping timeout: 246 seconds] 21:40 -!- geezas [uid253218@gateway/web/irccloud.com/x-heyxzbkgzgalorhk] has joined #bitcoin-core-dev 21:59 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 22:00 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 22:35 -!- cxr_ [~cxr@1.214.207.2] has joined #bitcoin-core-dev 22:35 -!- cxr_ [~cxr@1.214.207.2] has quit [Client Quit] 22:49 -!- cheetah2 [~cheetah2@172.242.103.133] has joined #bitcoin-core-dev 22:51 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Ping timeout: 248 seconds] 22:57 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 23:07 -!- Cogito_Ergo_Sum [~Myself@athedsl-314925.home.otenet.gr] has joined #bitcoin-core-dev 23:07 -!- Cogito_Ergo_Sum [~Myself@athedsl-314925.home.otenet.gr] has quit [Changing host] 23:07 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev 23:16 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 23:24 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-vgkmpwaopnkopjny] has joined #bitcoin-core-dev 23:26 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Ping timeout: 248 seconds] 23:29 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 23:31 -!- cheetah2 [~cheetah2@172.242.103.133] has quit [Read error: Connection reset by peer] 23:41 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 23:53 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev 23:56 < bitcoin-git> [bitcoin] Sjors opened pull request #11556: [Qt] Improved copy for RBF checkbox and tooltip (master...rbf-ui-text) https://github.com/bitcoin/bitcoin/pull/11556 23:57 -!- qrestlove [~qrestlove@cpe-66-69-225-126.austin.res.rr.com] has quit [Ping timeout: 248 seconds]