--- Day changed Tue Dec 12 2017
00:07 -!- JackH [~laptop@abnd35.neoplus.adsl.tpnet.pl] has quit [Ping timeout: 260 seconds]     
00:07 < sipa> Provoostenator: did removing the cache help?
00:07 < sipa> if that's the case, that's unexpected on its own
00:08 < Provoostenator> sipa: my machine is not that fast; I'll tell you in 15 minutes or so :-)
00:08 < Provoostenator> But I'd that's safe to assume.
00:08 < Provoostenator> Oh ok, so the cache is supposed to be wiped? I'll see ifI can break that.
00:09 < Provoostenator> I wish Github emails would should show the comment someone replied to, so it's easier to tell what "fixed" refers to. I'll stalk them. 
00:09 < sipa> no, wiping the cache _should not_ matter for this
00:09 < sipa> i'm just saying that before jumping to conclusions, you should try to reproduce with an empty cache
00:09 < Provoostenator> That's what I meant. I'll try if wiping helps, but it shouldn't. Make is running as we speak.
00:10 < sipa> install ccache
00:10 < Provoostenator> (I've learned not to assume stuff :-)
00:10 < sipa> no need to recompile from scratch every time you switch branches
00:10 < Provoostenator> Generally I don't recompile everything. In this case I just wanted to make sure everything was clean and it wasn't some build problem.
00:11 < Provoostenator> I'll try ccache
00:11 < sipa> if ccache is installed, configure will automatically detect and use it
00:11 < Provoostenator> Any good tools that can leverage other machines (e.g. EC2 nodes) to speed op compilation?
00:12 -!- tattoovicious [~tattoovic@78.90.9.207] has joined #bitcoin-core-dev     
00:12 < sipa> distcc i guess, but i never really looked into that
00:12 < sipa> it's fast enough on an octacore machine :)
00:13 < Provoostenator> Don't make me quote CSW :-)
00:13 < sipa> hahaha
00:16 -!- Amuza [~Amuza@85.159.207.5] has joined #bitcoin-core-dev     
00:20 -!- JackH [~laptop@91.189.61.70] has joined #bitcoin-core-dev     
00:27 < Provoostenator> sipa: your comment about why self.nodes[0].generate(1) was needed just solved another mystery for me: https://medium.com/provoost-on-crypto/debugging-bitcoin-core-functional-tests-cc0aa6e7fd3e
00:29 -!- wump is now known as wumpus     
00:29 < Provoostenator> I'll see if I can make sync_mempools() throw a warning if you call it during IDB. 
00:32 < Provoostenator> And it would be nice to have a command to tell test nodes IDB is done without mining a block (cc jnewbery).  
00:34 < aj> Provoostenator: you mean IBD (initial block download), or is IDB something i don't know about?
00:34 < Provoostenator> I need to stop making that typo. Yes, IBD, IDB is a record company :-)
00:35 < Provoostenator> (or whatever it is)
00:43 -!- sugarpuff [sid92283@gateway/web/irccloud.com/x-ntnvhezktwvemzjr] has quit [Ping timeout: 258 seconds]     
00:44 -!- sugarpuff [sid92283@gateway/web/irccloud.com/x-gqxzmxdhrrzqhony] has joined #bitcoin-core-dev     
00:45 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 248 seconds]     
00:46 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev     
00:49 -!- CubicEarth [~cubiceart@xdsl-31-164-85-6.adslplus.ch] has joined #bitcoin-core-dev     
00:53 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds]     
00:57 < Provoostenator> sipa: address_types.py passes now. I'll make a Github ticket next time I notice when removing test cache fixes a test.
00:59 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev     
00:59 -!- Emcy_ [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 276 seconds]     
01:08 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev     
01:11 < bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/0e722e8879a8...c0902624b0ec
01:11 < bitcoin-git> bitcoin/master 2851b77 Pieter Wuille: Make all script verification flags softforks
01:11 < bitcoin-git> bitcoin/master 2dd6f80 Pieter Wuille: Add a test that all flags are softforks
01:11 < bitcoin-git> bitcoin/master 01013f5 Pieter Wuille: Simplify tx validation tests
01:11 < bitcoin-git> [bitcoin] laanwj closed pull request #10699: Make all script validation flags backward compatible (master...20170628_softflags) https://github.com/bitcoin/bitcoin/pull/10699
01:15 < sipa> o/     
01:17 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
01:18 < wumpus> \o     
01:19 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
01:21 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection]     
01:21 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev     
01:26 -!- tattoovicious [~tattoovic@78.90.9.207] has quit [Quit: This computer has gone to sleep]     
01:28 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c0902624b0ec...d48ab83f0053
01:28 < bitcoin-git> bitcoin/master 07c4838 Matt Corallo: Always return true if AppInitMain got to the end...
01:28 < bitcoin-git> bitcoin/master d48ab83 Wladimir J. van der Laan: Merge #11831: Always return true if AppInitMain got to the end...
01:29 < bitcoin-git> [bitcoin] laanwj closed pull request #11831: Always return true if AppInitMain got to the end (master...2017-12-startup-exit-return-code-race) https://github.com/bitcoin/bitcoin/pull/11831
01:29 -!- DvdKhl [~Arokh@ip-37-201-210-118.hsi13.unitymediagroup.de] has quit [Ping timeout: 240 seconds]     
01:43 -!- tattoovicious [~tattoovic@78.90.9.207] has joined #bitcoin-core-dev     
01:51 < Provoostenator> p2p_full_blocktests failing on me with AssertionError: 1513072096.035577 <= 1513072096.086564
01:51 < Provoostenator> Slightly differtent numbers is another run: 1513070202.4765592 <= 1513070202.517996
01:52 < wumpus> uhoh
01:52 < Provoostenator> (on the segwit branch, I'll try master as well)
01:52 < wumpus> was it one of the recent commits?
01:53 < Provoostenator> Most recent version #11403
01:53 < gribble> https://github.com/bitcoin/bitcoin/issues/11403 | SegWit wallet support by sipa · Pull Request #11403 · bitcoin/bitcoin · GitHub
01:54 < Provoostenator> I am running make in another process, so maybe it's a timing thing?
01:54 < Provoostenator> I'll play around with it.
01:54 < Provoostenator> (make in another process, but also a different directory, so I mean perhaps heavy CPU / disk usage messes with the tests)
01:57 < wumpus> tests failures due to timing are unfortunately quite common
02:02 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-mmkgvyeirbahyear] has quit [Quit: Connection closed for inactivity]     
02:04 -!- tattoovicious [~tattoovic@78.90.9.207] has quit [Quit: This computer has gone to sleep]     
02:05 < wumpus> it passes here locally
02:05 < wumpus> (on current master)
02:06 < Provoostenator> Travis is happy too, so it's obviously not deterministic.
02:11 < wumpus> yes I've been running it a few times on different hosts
02:18 < Provoostenator> Are there any good tools to generate disk / cpu background usage? (other than running an Ethereum full node :-) 
02:18 < sipa> cpuburn
02:24 -!- Babozor [~babozor@2a01:e35:8b35:8720:ddc:7de0:e66f:bab3] has quit []     
02:28 < aj> wumpus: hey, i think i found a bug in the util unit test, that's been there since 2f7f2a in 2011; https://github.com/bitcoin/bitcoin/pull/11862/commits/56ca063fd65e05b8b71fa5421592cb9f56cd4d09 (argc < length(argv), so non-option behaviour isn't actually tested)
02:30 < wumpus> aj: cool, please send a fix :)
02:33 -!- terrence [74199253@gateway/web/freenode/ip.116.25.146.83] has joined #bitcoin-core-dev     
02:34 < wumpus> Provoostenator: do you get it on master too?
02:34 < Provoostenator> wumpus: yes, just did
02:35 < terrence> I want to develop a wallet, how can I get the lowest level api, or interface? instead of existing wrapped apis
02:37 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
02:37 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
02:37 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
02:38 < wumpus> terrence: the lowest level would be to implement transaction serialization, deserialization, signing, as well as keeping the balance and unspent state up to date with the current status of the block chain yourself
02:39 < promag> wumpus: not sure if that is what he means
02:40 < promag> terrence: do you know bitcoind rpc interface?
02:40 < wumpus> promag: lol, let's leave that to them instead of arguing about it between us
02:41 < promag> heh, "existing wrapped apis" I guess he is talking about some client library or web api.. dunno... *flys away*
02:43 < promag> wumpus: should replace in Assert with annotation in #11515?
02:43 < gribble> https://github.com/bitcoin/bitcoin/issues/11515 | Assert cs_main is held when retrieving node state by promag · Pull Request #11515 · bitcoin/bitcoin · GitHub
02:43 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection]     
02:44 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has joined #bitcoin-core-dev     
02:44 < promag> or keep both?
02:44 < terrence> @promag  sorry, I dont know, I'm new to blockchain dev
02:44 < wumpus> promag: well BlueMatt has a point that if it can be checked compile time,there's no point doing it at run time
02:44 < wumpus> promag: personally I wouldn't remove the comment though
02:45 < wumpus> promag: 'this datastructure is protected by lock X' is useful information
02:45 < promag> terrence: see https://bitcoin.org/en/developer-reference#remote-procedure-calls-rpcs for instance
02:45 < wumpus> however a GUARDED_BY annotation does the same
02:45 < wumpus> and is checked by the compiler, unlike a comment
02:46 < Provoostenator> Deleting cache doesn't help either. Getting this error quite consistently now.
02:46 < promag> yes, the comment is redundant
02:46 < wumpus> IF you add the annotation
02:46 < terrence> promag: thank you, how did you 
02:46 < wumpus> I don't agree that the AssertLockHeld in one function makes the comment redundant
02:47 < terrence> I have so many questions that I cannot find on the internet...
02:47 < wumpus> locks protect data, not code
02:47 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev     
02:47 < wumpus> so the annotation or comment belongs at the data structure definition
02:48 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has quit [Ping timeout: 240 seconds]     
02:48 < promag> terrence: you have to dig, learn, experiment.. you are not in the matrix
02:49 < promag> wumpus: what I meant is to keep the assert and replace the comment with the annotation
02:49 < wumpus> I'm ok with that
02:50 < promag> it conflicts with https://github.com/bitcoin/bitcoin/pull/11226/files#diff-eff7adeaec73a769788bb78858815c91R272
02:50 < terrence> promag: exactly, I'm new to blockchain, but I'm fascinated by blockchain
02:50 < wumpus> althoug in principle the assert is redundant when the annotation is there, but it doesn't hurt to have it so I don't find it worth a long discussion
02:50 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has joined #bitcoin-core-dev     
02:50 < wumpus> better to be overcomplete here
02:50 < promag> terrence: then join #bitcoin instead
02:51 < promag> wumpus: I agree, if asserts can be removed when annotations are in place
02:52 < wumpus> promag: it's somewhat complicated because not all compilers check the annotations 
02:52 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has quit [Read error: Connection reset by peer]     
02:52 < promag> so that's a +1 for assert
02:52 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has joined #bitcoin-core-dev     
02:53 < terrence> promag: I did, seems no one active in there
02:54 < promag> terrence: try #bitcoin-dev
02:54 < wumpus> #bitcoin is the most busy channel in the bitcoin community,  if no one is active there you're just at the wrong time
02:55 < terrence> wumpus: okay... maybe wrong time
02:56 -!- alfa [uid11513@gateway/web/irccloud.com/x-aslvwbhrfjbwxejq] has quit [Quit: Connection closed for inactivity]     
02:58 < promag> wumpus: if you're bored #11870
02:58 < gribble> https://github.com/bitcoin/bitcoin/issues/11870 | wallet: Remove unnecessary mempool lock in ReacceptWalletTransactions by promag · Pull Request #11870 · bitcoin/bitcoin · GitHub
02:58 < promag> pushed #11515
02:58 < gribble> https://github.com/bitcoin/bitcoin/issues/11515 | Assert cs_main is held when retrieving node state by promag · Pull Request #11515 · bitcoin/bitcoin · GitHub
02:59 < wumpus> I'm never bored
02:59 < bitcoin-git> [bitcoin] laanwj closed pull request #11354: Coins DB: Improve handling of FRESH child with non-DIRTY parent in CCoinsViewCa… (master...fix/batch-write-clean-parent-fresh-child) https://github.com/bitcoin/bitcoin/pull/11354
03:00 < wumpus> so many things to do and so little time/energy
03:01 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev     
03:01 < promag> wumpus: are you talking about 234 open PR's? :p
03:01 < wumpus> for ex.
03:02 < fanquake> The amount of stuff I see wumpus star on GH he must have about 5 side projects on the go
03:02 < wumpus> that's... about right :)
03:03 < fanquake> Plenty todo with graphics cards and their drivers/related software.
03:18 -!- Kozuch [~Kozuch@81.0.198.168] has joined #bitcoin-core-dev     
03:21 < promag> ah I guess you don't have kids
03:24 < promag> wumpus: "I think both ways should be supported for the foreseeable future, no need to deprecate anything right now" why keep legacy? in 3 releases it should not be there IMO
03:24 < wumpus> because we don't want to break people's software just because
03:25 < wumpus> the current way apparently works for everyone well. I kind of hate RPC PRs that break the interface just because the author likes some convention better.
03:25 < wumpus> I personally would prefer using arrays as well there but that doesn't mean that all previously written software that uses createrawtransaction shoudl break
03:26 < wumpus> it's just an alternative way of specifying the same data
03:26 < promag> I don't think overloading is that great
03:26 < wumpus> fine, I'll just NACK the whole change then
03:27 -!- zombieC [~zombieC@ua-85-227-38-68.cust.bredbandsbolaget.se] has joined #bitcoin-core-dev     
03:27 < promag> heh     
03:27 -!- Cory [~Cory@unaffiliated/cory] has quit [Ping timeout: 248 seconds]     
03:27 < wumpus> keep the users in mind please
03:28 < promag> in these cases I tend to prefer new calls instead of overloading
03:28 < wumpus> which would be bs in this case
03:34 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Quit: Leaving.]     
03:35 -!- terrence [74199253@gateway/web/freenode/ip.116.25.146.83] has quit [Ping timeout: 260 seconds]     
03:35 -!- tattoovicious [~tattoovic@78.90.9.207] has joined #bitcoin-core-dev     
03:37 -!- nelruk [~dax_the_c@host-216.58.217.201.copaco.com.py] has joined #bitcoin-core-dev     
03:37 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has quit [Remote host closed the connection]     
03:37 < meshcollider> which PR are you discussing
03:37 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has joined #bitcoin-core-dev     
03:38 < meshcollider> oh, #11872 ?
03:38 < gribble> https://github.com/bitcoin/bitcoin/issues/11872 | [rpc] createrawtransaction: Accept sorted outputs by MarcoFalke · Pull Request #11872 · bitcoin/bitcoin · GitHub
03:43 < wumpus> FWIW in principle it is already possible to specify the order of outputs, but only if the client-side JSON library can emit ordered dictionaries. Python's can do this when you use Collections.OrderedDict() instead of a dictionary. The server-side (univalue) won't reorder dictionaries. But using an array is conforming to the spec instead of 'it happens to work'.
03:44 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has quit [Ping timeout: 255 seconds]     
03:48 -!- Squidicuz [~squid@pool-173-48-82-37.bstnma.fios.verizon.net] has quit [Read error: Connection reset by peer]     
03:48 -!- PaulCapestany [~PaulCapes@ip68-100-207-91.dc.dc.cox.net] has quit [Read error: Connection reset by peer]     
03:48 -!- Squidicuz [~squid@pool-173-48-82-37.bstnma.fios.verizon.net] has joined #bitcoin-core-dev     
03:49 -!- PaulCapestany [~PaulCapes@ip68-100-207-91.dc.dc.cox.net] has joined #bitcoin-core-dev     
03:52 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
03:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]     
03:59 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev     
03:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
04:10 < bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/d48ab83f0053...ad1820cbad15
04:10 < bitcoin-git> bitcoin/master 5fc6e71 John Newbery: [tests] Add network_thread_ utility functions....
04:10 < bitcoin-git> bitcoin/master 74e64f2 John Newbery: [tests] Use network_thread_start() in tests.
04:10 < bitcoin-git> bitcoin/master 34e08b3 John Newbery: [tests] Fix network threading in functional tests...
04:11 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has joined #bitcoin-core-dev     
04:15 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has quit [Remote host closed the connection]     
04:16 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has joined #bitcoin-core-dev     
04:17 -!- Babozor [~babozor@195.154.25.201] has joined #bitcoin-core-dev     
04:19 -!- nelruk [~dax_the_c@host-216.58.217.201.copaco.com.py] has quit [Read error: Connection reset by peer]     
04:19 -!- laurentmt [~Thunderbi@92.154.68.134] has joined #bitcoin-core-dev     
04:20 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has quit [Ping timeout: 240 seconds]     
04:23 -!- Babozor [~babozor@195.154.25.201] has quit []     
04:24 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has joined #bitcoin-core-dev     
04:24 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has quit [Remote host closed the connection]     
04:25 < promag> wumpus: OrderedDict doesn't allow to test duplicate output address
04:26 < wumpus> promag: that's true :)
04:26 < promag> how would we test that atm?
04:26 < wumpus> promag: I think python will let you write a dictionary class that can hold duplicate keys
04:27 < promag> there is defaultdict
04:27 < wumpus> alternatively, write the query yourself, insert raw json somehow
04:27 < wumpus> defaultdict doesn't allow that afaik
04:28 < wumpus> what you'd want is a list-kind of class with a custom json serializer that serializes as object
04:28 < wumpus> not sure how to do that or whether it's even possible
04:29 < promag> raw it is
04:32 -!- CubicEarth [~cubiceart@xdsl-31-164-85-6.adslplus.ch] has quit [Remote host closed the connection]     
04:38 < wumpus> promag: this seems to work https://gist.github.com/laanwj/822e1d8684a7ffc20cf08156654b37f7  
04:38 < Provoostenator> I forgot that I used ./configure --enable-debug. The weird test functional errors I described above when I remove that (followed by make clean && make). They issues come back when I set --enable-debug again.
04:38 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has joined #bitcoin-core-dev     
04:39 < wumpus> Provoostenator: that's very strange
04:39 < Provoostenator> They also run a lot slower with debug enabled, so that might be related.
04:39 < wumpus> --enable-debug does make locking a lot slower, so if it's some kind of race condition, it could be triggered by that
04:39 < wumpus> right.
04:39 < Provoostenator> I'll run again with jnewbery's latest commits you just merged
04:41 < promag> wumpus: nice, are you going to add the test or mind I do?
04:43 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has quit [Remote host closed the connection]     
04:46 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev     
05:09 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection]     
05:15 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev     
05:23 -!- Cory [~Cory@unaffiliated/cory] has joined #bitcoin-core-dev     
05:24 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection]     
05:25 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev     
05:32 -!- tattoovicious [~tattoovic@78.90.9.207] has quit [Quit: This computer has gone to sleep]     
05:35 -!- jtimon [~quassel@164.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev     
05:37 < bitcoin-git> [bitcoin] laanwj pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/ad1820cbad15...214046f69b19
05:37 < bitcoin-git> bitcoin/master 93a34cf Matt Corallo: Make DisconnectBlock unaware of where undo data resides on disk
05:37 < bitcoin-git> bitcoin/master 50701ba Matt Corallo: Move txindex/undo data disk location stuff out of ConnectBlock
05:37 < bitcoin-git> bitcoin/master e104f0f Matt Corallo: Move block writing out of AcceptBlock
05:37 < bitcoin-git> [bitcoin] laanwj closed pull request #10279: Add a CChainState class to validation.cpp to take another step towards clarifying internal interfaces (master...2016-12-cconsensus) https://github.com/bitcoin/bitcoin/pull/10279
05:43 -!- alcipir [~user@189-70-93-140.user.veloxzone.com.br] has joined #bitcoin-core-dev     
05:46 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
05:50 -!- alcipir [~user@189-70-93-140.user.veloxzone.com.br] has quit [Ping timeout: 248 seconds]     
05:51 -!- mrfrasha [~mrfrasha@66-188-250-34.dhcp.eucl.wi.charter.com] has joined #bitcoin-core-dev     
05:51 -!- tattoovicious [~tattoovic@78.90.9.207] has joined #bitcoin-core-dev     
05:56 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/214046f69b19...5d132e8b9746
05:56 < bitcoin-git> bitcoin/master a720b92 practicalswift: Remove includes in .cpp files for things the corresponding .h file already included
05:56 < bitcoin-git> bitcoin/master 5d132e8 Wladimir J. van der Laan: Merge #10574: Remove includes in .cpp files for things the corresponding .h file already included...
05:57 < bitcoin-git> [bitcoin] laanwj closed pull request #10574: Remove includes in .cpp files for things the corresponding .h file already included (master...redundant) https://github.com/bitcoin/bitcoin/pull/10574
06:06 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection]     
06:08 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev     
06:13 -!- Amuza [~Amuza@85.159.207.5] has quit [Quit: Leaving]     
06:15 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev     
06:17 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Client Quit]     
06:18 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev     
06:19 < pierre_rochard> Does each wallet in vpwallets have a unique identifier? The class has GetName “for logging/debugging purposes” and there is the wallet’s vector index, not sure that I can rely on either of these
06:19 -!- zombieC [~zombieC@ua-85-227-38-68.cust.bredbandsbolaget.se] has quit [Remote host closed the connection]     
06:21 < promag> don't use the index
06:21 < promag> btw, what is the purpose?
06:24 < pierre_rochard> accounting in multi-wallet world - which addresses belong to which wallet 
06:25 < promag> a wallet index can change
06:25 < promag> and a wallet name too, if you do rename the wallet
06:26 < promag> there is no embedded unique id in the wallet yet and don't know if there will be one
06:26 < pierre_rochard> ah so is the wallet name the file name? like wallet.dat? 
06:26 < promag> yes     
06:26 < pierre_rochard> If there won’t be an embedded unique ID then wallet name will have to suffice 
06:27 < pierre_rochard> Thank you!
06:27 < promag> don't recall if it is the filename or filepath though
06:29 -!- quantbot [~quantbot@38.101.106.141] has joined #bitcoin-core-dev     
06:30 -!- quantbot [~quantbot@38.101.106.141] has quit [Remote host closed the connection]     
06:30 -!- quantbot [~quantbot@38.101.106.141] has joined #bitcoin-core-dev     
06:43 -!- Kozuch [~Kozuch@81.0.198.168] has quit [Ping timeout: 260 seconds]     
06:46 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds]     
06:50 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
06:51 -!- mrfrasha [~mrfrasha@66-188-250-34.dhcp.eucl.wi.charter.com] has quit [Read error: Connection reset by peer]     
06:51 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
06:57 -!- mrfrasha_ [~mrfrasha@66-188-250-34.dhcp.eucl.wi.charter.com] has joined #bitcoin-core-dev     
06:59 -!- CubicEarth [~cubiceart@52.10.104.92.dynamic.wline.res.cust.swisscom.ch] has joined #bitcoin-core-dev     
07:01 < bitcoin-git> [bitcoin] promag opened pull request #11877: Improve createrawtransaction functional tests (master...2017-12-createrawtransaction) https://github.com/bitcoin/bitcoin/pull/11877
07:02 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection]     
07:04 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev     
07:09 < promag> wumpus: when you said "Something that I guess needs to be tested explicitly now" I thought you meant there should be a functional test :P
07:10 < wumpus> promag: adding tests is alwasys good
07:13 < wumpus> promag: but indeed I meant adding the check, which I didn't expect to be there yet
07:14 -!- pkx2 [~pkx@unaffiliated/pkx] has joined #bitcoin-core-dev     
07:14 < promag> wumpus: btw, is it really necessary to be unique? in terms of specification, is it possible to have duplicate output address?
07:14 < promag> IIRC there is no restriction there 
07:15 < wumpus> I don't think transaction validation prohibits it
07:15 < wumpus> but our software enforces it everywhere so it's good to be consistent
07:15 -!- Thora1Koelpin [~Thora1Koe@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 248 seconds]     
07:15 < promag> are we disallowing just because of the key/value parameter?
07:15 < wumpus> no, because it's always been that way, also in the GUI
07:15 < promag> I should test in the UI..
07:16 < promag> ah ok ty
07:16 < wumpus> there's no reason to do it so it's generally indicative of a bug
07:17 < promag> wumpus: why? I could split coins to the same private, no?
07:17 < wumpus> just makes the transaction bigger than it should be, to pay more fees
07:17 < wumpus> if you want to split, definitely use different keys
07:17 < promag> right, best practise there
07:18 -!- JackH [~laptop@91.189.61.70] has quit [Remote host closed the connection]     
07:21 -!- CubicEarth [~cubiceart@52.10.104.92.dynamic.wline.res.cust.swisscom.ch] has quit [Remote host closed the connection]     
07:25 -!- tattoovicious [~tattoovic@78.90.9.207] has quit [Quit: This computer has gone to sleep]     
07:25 -!- lnostdal [~lnostdal@62.90-149-73.nextgentel.com] has quit [Ping timeout: 248 seconds]     
07:26 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has quit []     
07:31 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
07:34 -!- Emcy_ [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev     
07:36 -!- mrfrasha_ [~mrfrasha@66-188-250-34.dhcp.eucl.wi.charter.com] has quit [Quit: mrfrasha_]     
07:36 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 250 seconds]     
07:38 -!- mrfrasha [~mrfrasha@66-188-250-34.dhcp.eucl.wi.charter.com] has joined #bitcoin-core-dev     
07:39 < BlueMatt> promag: was asking about a quick rebase-then-merge on #11041, which I think would be a good idea
07:39 < gribble> https://github.com/bitcoin/bitcoin/issues/11041 | Add LookupBlockIndex by promag · Pull Request #11041 · bitcoin/bitcoin · GitHub
07:39 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-aybklnhucttguaky] has quit [Quit: Connection closed for inactivity]     
07:39 < BlueMatt> mostly cause it would help me re-implement/rebase #10692 in a cleaner way
07:39 < gribble> https://github.com/bitcoin/bitcoin/issues/10692 | Make mapBlockIndex and chainActive and all CBlockIndex*es const outside of validation/CChainState by TheBlueMatt · Pull Request #10692 · bitcoin/bitcoin · GitHub
07:39 < BlueMatt> I think it has enough concept ack to merit that....promag, care to rebase?
07:40 < BlueMatt> I'll commit to reviewing it quick, and yelling at people to get it merged in a day or three
07:42  * wumpus wonders how near #11403 is
07:42 < gribble> https://github.com/bitcoin/bitcoin/issues/11403 | SegWit wallet support by sipa · Pull Request #11403 · bitcoin/bitcoin · GitHub
07:42  * BlueMatt needs to re-review today :(
07:42  * wumpus needs to review and test it too
07:43 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 248 seconds]     
07:45 < instagibbs> re-re-review time eh
07:46 -!- lnostdal [~lnostdal@62.90-149-73.nextgentel.com] has joined #bitcoin-core-dev     
07:47 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev     
07:47 -!- alcipir [~user@189-70-93-140.user.veloxzone.com.br] has joined #bitcoin-core-dev     
07:53 -!- alcipir [~user@189-70-93-140.user.veloxzone.com.br] has quit [Ping timeout: 250 seconds]     
07:56 -!- alcipir [~user@187.102.146.50] has joined #bitcoin-core-dev     
07:57 -!- R [89329d76@gateway/web/freenode/ip.137.50.157.118] has joined #bitcoin-core-dev     
07:58 < R> Hey, is anyone active here?
07:58 -!- R is now known as Guest89357     
07:59 < Guest89357> ?     
08:02 < Randolf> Guest89357:  There are many active folks here, but the discussions are usually focused on the development of the various facets of the Bitcoin project.
08:02 < Guest89357> Ok     
08:03 < Guest89357> well
08:03 < Guest89357> I have a problem related to an old bitcoin core client
08:03 < Guest89357> I don't suppose you guys could help me out with it?
08:03 < Randolf> Guest89357:  For support, the #bitcoin channel is probably your best bet.
08:04 < wumpus> better to ask in #bitcoin, this is not a support but a development channel, read the topic please
08:04 < Guest89357> Ok     
08:04 < Guest89357> sorry for bothering, will check that channel out!
08:04 -!- Guest89357 [89329d76@gateway/web/freenode/ip.137.50.157.118] has left #bitcoin-core-dev []     
08:07 -!- brugabri [bcd90138@gateway/web/freenode/ip.188.217.1.56] has joined #bitcoin-core-dev     
08:09 -!- brugabri [bcd90138@gateway/web/freenode/ip.188.217.1.56] has quit [Client Quit]     
08:10 -!- alcipir [~user@187.102.146.50] has quit [Ping timeout: 260 seconds]     
08:10 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
08:12 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
08:15 -!- PaulCapestany [~PaulCapes@ip68-100-207-91.dc.dc.cox.net] has quit [Quit: .]     
08:15 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev     
08:20 < promag> BlueMatt: ok then
08:21 -!- ula [~ula@b2b-78-94-11-194.unitymedia.biz] has joined #bitcoin-core-dev     
08:21 < promag> BlueMatt: later tonight (utc+0 here) I can do it
08:21 < BlueMatt> k, thanks
08:24 -!- alcipir [~user@187.102.146.50] has joined #bitcoin-core-dev     
08:26 -!- PaulCapestany [~PaulCapes@ip68-100-207-91.dc.dc.cox.net] has joined #bitcoin-core-dev     
08:29 < ryanofsky> pierre_rochard, wallet files do have embedded identifiers, search for "get_fileid" in the code
08:30 < ryanofsky> but for your case, i think you probably better off using wallet filename, so users can understand & choose the id
08:30 < ryanofsky> also #11687 adds CWallet::m_name and should clarify things: see comment https://github.com/bitcoin/bitcoin/pull/11687/commits/3dba60c313ae111492dafc3eb09f2c5044fb1b4d#diff-12635a58447c65585f51d32b7e04075bR724
08:30 < gribble> https://github.com/bitcoin/bitcoin/issues/11687 | External wallet files by ryanofsky · Pull Request #11687 · bitcoin/bitcoin · GitHub
08:31 < promag> ryanofsky: is get_fileid immutable?
08:32 < ryanofsky> not sure i understand but it's generated randomly, and we never change it but you can call an api to change it
08:35 < pierre_rochard> Thanks for the headsup ryanofsky - I’ll go with the wallet filename and will read through the PR
08:35 < promag> BlueMatt: I've updated the comment https://github.com/bitcoin/bitcoin/pull/11866#pullrequestreview-82808956 which I think you misinterpreted
08:39 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev     
08:40 -!- bitcoinman55 [59a65f7b@gateway/web/freenode/ip.89.166.95.123] has joined #bitcoin-core-dev     
08:40 < bitcoinman55> how do i encrypt a wallet on linux? ubuntu 16.04
08:40 < bitcoinman55> is it possible with the gui or i'll have to do it with commands
08:42 < BlueMatt> promag: no, I dont think I did
08:42 < BlueMatt> promag: I think we shouldnt be doing the duplicative check at all
08:42 < BlueMatt> bitcoinman55: #bitcoin will probably help you more, but, yes, there should be a button somewhere
08:43 < promag> but for instance, in the case there is a conflict, you say it will fire TransactionRemovedFromMempool right?
08:44 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 248 seconds]     
08:55 -!- bitcoinman55 [59a65f7b@gateway/web/freenode/ip.89.166.95.123] has quit [Ping timeout: 260 seconds]     
08:57 -!- CubicEarth [~cubiceart@178.197.239.231] has joined #bitcoin-core-dev     
09:06 -!- jb55 [~jb55@208.98.200.100] has joined #bitcoin-core-dev     
09:17 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
09:18 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
09:22 -!- CubicEarth [~cubiceart@178.197.239.231] has quit []     
09:34 -!- bitC [5c63c190@gateway/web/freenode/ip.92.99.193.144] has joined #bitcoin-core-dev     
09:35 -!- laurentmt [~Thunderbi@92.154.68.134] has quit [Quit: laurentmt]     
09:38 < sipa> instagibbs: if addresstype is bech32, addmultisigaddress should give you a bech32 address
09:39 < sipa> and passing bech32 addresses for individual keys to addmultisigaddress should work fine
09:39 < instagibbs> oh hmmm, so it only complains if you default with a different kind?
09:40 < sipa> you can't pass a P2WSH address to addmultisigaddress
09:40 < sipa> because that is not an address that refers to a key
09:40 < instagibbs> oh did I get my wires crossed and try a p2wsh
09:41 -!- bitC [5c63c190@gateway/web/freenode/ip.92.99.193.144] has quit [Ping timeout: 260 seconds]     
09:42 < instagibbs> ah yeah, thought i was testing a p2pkh
09:44 < instagibbs> still returning me a nested p2sh
09:44 < instagibbs> fwiw
09:44 < instagibbs> oh nevermind, typo in startup
09:48 < instagibbs> all comments retracted :) good work
10:01 -!- timothy [tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]     
10:01 < bitcoin-git> [bitcoin] jnewbery opened pull request #11879: [tests] remove redundant univalue_tests.cpp (master...remove_univalue_test) https://github.com/bitcoin/bitcoin/pull/11879
10:01 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-pvnilfdbvrbfuvjm] has joined #bitcoin-core-dev     
10:04 < sipa> Provoostenator: aha, snoei
10:05 < Provoostenator> I just got a new machine, so it's a good opportunity to see if any dependencies are missing in the docs...
10:05 < Provoostenator> Having some issues with make deploy not showing the icons.
10:06 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 240 seconds]     
10:11 < Provoostenator> Fixed by reboot, nvm.
10:35 < BlueMatt> hmm, re: #11873 I'm curious if anyone would maintain it or if it'd just die compared to travis where we at least theoretically work to fix failures
10:35 < gribble> https://github.com/bitcoin/bitcoin/issues/11873 | Visual studio Build setup for CI · Issue #11873 · bitcoin/bitcoin · GitHub
10:35 < BlueMatt> but it looks like its just a simple travis clone thinggy that runs windows vms instead of linux and is free for oss
10:37 < wumpus> BlueMatt: eh didn't the person more or less commit to maintaining MSVC support for forseeable future?
10:37 < wumpus> it was one of the first things I asked
10:38 < wumpus> https://github.com/bitcoin/bitcoin/pull/11526#issuecomment-338163039
10:39 < BlueMatt> oh heh
10:39 < BlueMatt> so we are gonna add this other travis-y thing to bitcoin/bitcoin?
10:40 < BlueMatt> #11854 could prolly get merged
10:40 < gribble> https://github.com/bitcoin/bitcoin/issues/11854 | Split up key and script metadata for better type safety by ryanofsky · Pull Request #11854 · bitcoin/bitcoin · GitHub
10:40  * BlueMatt likes it pre-segwit-wallet, sorry sipa :p
10:41 < sipa>  ?     
10:42 < BlueMatt> as in I'd like to see segwit wallet built on 11854, given it was partially the result of my review comments :p
10:42 < sipa> oh, no opinion there
10:42 < sipa> i'll gladly rebase if it's merged first
10:44 -!- shesek [~shesek@bzq-84-110-232-125.red.bezeqint.net] has joined #bitcoin-core-dev     
10:44 -!- shesek [~shesek@bzq-84-110-232-125.red.bezeqint.net] has quit [Changing host]     
10:44 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev     
10:44 < wumpus> BlueMatt: yes I think it's basically good to go, there was some discussion about where to put the MSVC build system that I didn't read in detail yet
10:45 < BlueMatt> ah cool
10:46 < BlueMatt> also #11870 could probably be merged
10:46 < gribble> https://github.com/bitcoin/bitcoin/issues/11870 | wallet: Remove unnecessary mempool lock in ReacceptWalletTransactions by promag · Pull Request #11870 · bitcoin/bitcoin · GitHub
10:47 < wumpus> ok     
10:48 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
10:48 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit]     
10:50 -!- tattoovicious [~tattoovic@95.111.59.133] has joined #bitcoin-core-dev     
10:58 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5d132e8b9746...22149540f9e7
10:58 < bitcoin-git> bitcoin/master 9c8eca7 Russell Yanofsky: Split up key and script metadata for better type safety...
10:58 < bitcoin-git> bitcoin/master 2214954 Wladimir J. van der Laan: Merge #11854: Split up key and script metadata for better type safety...
10:58 < bitcoin-git> [bitcoin] laanwj closed pull request #11854: Split up key and script metadata for better type safety (master...pr/scriptmet) https://github.com/bitcoin/bitcoin/pull/11854
10:59 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 240 seconds]     
10:59 -!- booyah [~bb@193.25.1.157] has quit [Ping timeout: 255 seconds]     
11:04 < BlueMatt> sipa: segwit wallet needs rebase :p
11:05 -!- tomdickharry [~dom@109.79.185.230] has quit [Ping timeout: 248 seconds]     
11:05 < sipa> BlueMatt: already on it
11:06 -!- jamesob [~james@199.230.10.198] has joined #bitcoin-core-dev     
11:09 < BlueMatt> jonasschnelli: do you mind rebasing #11281 before review? Its kind confusing when some code added in intermediary commits is likely to be removed during rebase
11:09 < gribble> https://github.com/bitcoin/bitcoin/issues/11281 | Avoid permanent cs_main/cs_wallet lock during RescanFromTime by jonasschnelli · Pull Request #11281 · bitcoin/bitcoin · GitHub
11:10 < jonasschnelli> Oh. It needs rebase.. yes. Let me do that
11:10 < jonasschnelli> BlueMatt: You mean cleanup the commit history?
11:10 < jonasschnelli> The last two commits need squashing... can do now
11:15 -!- mrfrasha [~mrfrasha@66-188-250-34.dhcp.eucl.wi.charter.com] has quit [Quit: mrfrasha]     
11:16 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
11:17 < BlueMatt> yes, squash
11:17 < BlueMatt> thanks
11:17 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
11:19 < sipa> BlueMatt: done
11:26 < jonasschnelli> BlueMatt: here you go: #11281
11:26 < gribble> https://github.com/bitcoin/bitcoin/issues/11281 | Avoid permanent cs_main/cs_wallet lock during RescanFromTime by jonasschnelli · Pull Request #11281 · bitcoin/bitcoin · GitHub
11:26 < BlueMatt> thanks
11:27 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/22149540f9e7...ef8ba7d73a48
11:27 < bitcoin-git> bitcoin/master 5b25293 João Barbosa: wallet: Remove unnecessary mempool lock in ReacceptWalletTransactions
11:27 < bitcoin-git> bitcoin/master ef8ba7d Wladimir J. van der Laan: Merge #11870: wallet: Remove unnecessary mempool lock in ReacceptWalletTransactions...
11:27 < bitcoin-git> [bitcoin] laanwj closed pull request #11870: wallet: Remove unnecessary mempool lock in ReacceptWalletTransactions (master...2017-12-reaccept-wallet-transactions) https://github.com/bitcoin/bitcoin/pull/11870
11:29 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev     
11:29 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev     
11:34 -!- shtirlic [~shtirlic@ec2-35-158-173-101.eu-central-1.compute.amazonaws.com] has quit [Quit: ZNC - http://znc.in]     
11:35 < jonasschnelli> BlueMatt: thanks for reviewing #10387, what do you think about https://github.com/bitcoin/bitcoin/pull/10387#issuecomment-343357330
11:35 < gribble> https://github.com/bitcoin/bitcoin/issues/10387 | Eventually connect to NODE_NETWORK_LIMITED peers by jonasschnelli · Pull Request #10387 · bitcoin/bitcoin · GitHub
11:35 -!- shtirlic [~shtirlic@ec2-35-158-173-101.eu-central-1.compute.amazonaws.com] has joined #bitcoin-core-dev     
11:37 -!- shtirlic [~shtirlic@ec2-35-158-173-101.eu-central-1.compute.amazonaws.com] has quit [Client Quit]     
11:38 -!- shtirlic [~shtirlic@Shtirlic-2-pt.tunnel.tserv6.fra1.ipv6.he.net] has joined #bitcoin-core-dev     
11:43 < BlueMatt> jonasschnelli: yes my comment was in response to gmaxwell's comment
11:44 < jonasschnelli> BlueMatt: overlooked that comment. Thanks
11:46 < cfields> BlueMatt: woohoo @ #10279!
11:46 < gribble> https://github.com/bitcoin/bitcoin/issues/10279 | Add a CChainState class to validation.cpp to take another step towards clarifying internal interfaces by TheBlueMatt · Pull Request #10279 · bitcoin/bitcoin · GitHub
11:46 -!- HarlequinFields [~Harlequin@c-68-52-70-169.hsd1.tn.comcast.net] has joined #bitcoin-core-dev     
11:47 < BlueMatt> cfields: heh, lol, yea
11:47 < BlueMatt> next is #10692, but want to rebase on #11041 first
11:47 < cfields> BlueMatt: that was much easier to review than I anticipated. Sorry for just getting to it.
11:47 < gribble> https://github.com/bitcoin/bitcoin/issues/10692 | Make mapBlockIndex and chainActive and all CBlockIndex*es const outside of validation/CChainState by TheBlueMatt · Pull Request #10692 · bitcoin/bitcoin · GitHub
11:47 < gribble> https://github.com/bitcoin/bitcoin/issues/11041 | Add LookupBlockIndex by promag · Pull Request #11041 · bitcoin/bitcoin · GitHub
11:48 -!- goatpig [56f75683@gateway/web/freenode/ip.86.247.86.131] has joined #bitcoin-core-dev     
11:48 < cfields> BlueMatt: could i convince you to do a quick PR to rename the class members? They're really confusing atm.
11:49 < BlueMatt> cfields: I mean you can do it, 10692 needs a *ton* of rebase, so I dont have anything important built on top of it
11:50 -!- mrfrasha [~mrfrasha@66-188-250-34.dhcp.eucl.wi.charter.com] has joined #bitcoin-core-dev     
11:50 < cfields> ok     
11:53 < bitcoin-git> [bitcoin] jnewbery opened pull request #11881: [WIP] [concept] Remove Python2 support (master...remove_python2) https://github.com/bitcoin/bitcoin/pull/11881
12:01 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection]     
12:01 -!- DvdKhl [~Arokh@ip-37-201-210-118.hsi13.unitymediagroup.de] has joined #bitcoin-core-dev     
12:09 -!- shtirlic [~shtirlic@Shtirlic-2-pt.tunnel.tserv6.fra1.ipv6.he.net] has quit [Quit: ZNC - http://znc.in]     
12:10 -!- shtirlic [~shtirlic@Shtirlic-2-pt.tunnel.tserv6.fra1.ipv6.he.net] has joined #bitcoin-core-dev     
12:14 -!- adiabat [~adiabat@45.63.20.152] has quit [Quit: WeeChat 1.4]     
12:16 -!- adiabat [~adiabat@45.63.20.152] has joined #bitcoin-core-dev     
12:19 -!- shtirlic [~shtirlic@Shtirlic-2-pt.tunnel.tserv6.fra1.ipv6.he.net] has quit [Quit: ZNC - http://znc.in]     
12:20 -!- Cogito_Ergo_Sum [~Myself@80.107.151.135] has joined #bitcoin-core-dev     
12:20 -!- Cogito_Ergo_Sum [~Myself@80.107.151.135] has quit [Changing host]     
12:20 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev     
12:20 -!- shtirlic [~shtirlic@ec2-35-158-173-101.eu-central-1.compute.amazonaws.com] has joined #bitcoin-core-dev     
12:29 -!- cnone_ [~cnone@176.216.245.180] has joined #bitcoin-core-dev     
12:29 -!- cnone_ [~cnone@176.216.245.180] has quit [Client Quit]     
12:30 -!- cnone22 [~cnone@176.216.245.180] has joined #bitcoin-core-dev     
12:30 -!- StopAndDecrypt_ [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has quit [Ping timeout: 248 seconds]     
12:31 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has joined #bitcoin-core-dev     
12:31 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has quit [Changing host]     
12:31 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev     
12:33 -!- Cogito_Ergo_Sum2 [~Myself@80.107.151.135] has joined #bitcoin-core-dev     
12:34 -!- sanada` [~bitktn@36-2-119-80.chiba.ap.gmo-isp.jp] has joined #bitcoin-core-dev     
12:34 -!- paracyst [paracyst@unaffiliated/paracyst] has quit [Ping timeout: 248 seconds]     
12:34 -!- Ge0rges [~Ge0rges@104.236.151.200] has quit [Ping timeout: 248 seconds]     
12:34 -!- paracyst_ [paracyst@unaffiliated/paracyst] has joined #bitcoin-core-dev     
12:35 -!- sanada [~bitktn@36-2-119-80.chiba.ap.gmo-isp.jp] has quit [Ping timeout: 248 seconds]     
12:35 -!- murr4y [ali@100.94.211.130.bc.googleusercontent.com] has quit [Ping timeout: 248 seconds]     
12:35 -!- kallewoof [~karl@67.205.138.199] has quit [Ping timeout: 248 seconds]     
12:35 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has quit [Ping timeout: 248 seconds]     
12:35 -!- adiabat [~adiabat@45.63.20.152] has quit [Ping timeout: 248 seconds]     
12:35 -!- LeMiner [LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has quit [Ping timeout: 248 seconds]     
12:35 -!- ryan-c [~ryan@znc.rya.nc] has quit [Ping timeout: 248 seconds]     
12:36 -!- mryandao [~mryandao@unaffiliated/mryandao] has quit [Ping timeout: 255 seconds]     
12:38 -!- kallewoof [~karl@67.205.138.199] has joined #bitcoin-core-dev     
12:39 -!- LeMiner [LeMiner@unaffiliated/leminer] has joined #bitcoin-core-dev     
12:39 -!- murr4y [ali@100.94.211.130.bc.googleusercontent.com] has joined #bitcoin-core-dev     
12:39 -!- ryan-c [~ryan@znc.rya.nc] has joined #bitcoin-core-dev     
12:40 -!- mryandao [~mryandao@unaffiliated/mryandao] has joined #bitcoin-core-dev     
12:40 -!- adiabat [~adiabat@45.63.20.152] has joined #bitcoin-core-dev     
12:41 -!- Ge0rges [~Ge0rges@104.236.151.200] has joined #bitcoin-core-dev     
12:43 < jnewbery> Provoostenator: Your p2p-fullblocktest.py failures are due to timeouts. The assert message isn't very helpful but if you look down the stack you'll see that it's a timeout
12:43 < jnewbery> most likely because the re-org test at the end of p2p-fullblocktest.py isn't completing within the required 60 seconds
12:44 < jnewbery> Take a look at https://github.com/bitcoin/bitcoin/issues/11632 and see if the suggested change helps you
12:44 < jnewbery> instagibbs: achow101: did that change fix it for you?
12:45 < jnewbery> I've also completely refactored that test in #11773. Any review of those PRs, starting with #11771 would be greatly appreciated
12:45 < gribble> https://github.com/bitcoin/bitcoin/issues/11773 | [tests] Change p2p-fullblocktest to use BitcoinTestFramework by jnewbery · Pull Request #11773 · bitcoin/bitcoin · GitHub
12:45 < gribble> https://github.com/bitcoin/bitcoin/issues/11771 | [tests] Change invalidtxrequest to use BitcoinTestFramework by jnewbery · Pull Request #11771 · bitcoin/bitcoin · GitHub
12:46 -!- Netsplit over, joins: twistedline
12:46 < instagibbs> the refactor of the test fixed it yes
12:49 < achow101> jnewbery: 11773 fixed it for me
12:54 -!- Cogito_Ergo_Sum2 is now known as Cogito_Ergo_Sum     
12:54 -!- Cogito_Ergo_Sum [~Myself@80.107.151.135] has quit []     
12:54 -!- Cogito_Ergo_Sum [~Myself@80.107.151.135] has joined #bitcoin-core-dev     
12:54 -!- Cogito_Ergo_Sum [~Myself@80.107.151.135] has quit [Changing host]     
12:54 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev     
12:55 -!- ula [~ula@b2b-78-94-11-194.unitymedia.biz] has quit [Remote host closed the connection]     
12:57 -!- tattoovicious [~tattoovic@95.111.59.133] has quit [Ping timeout: 240 seconds]     
12:57 -!- vicnicius [53a2c022@gateway/web/freenode/ip.83.162.192.34] has joined #bitcoin-core-dev     
12:58 -!- tattoovicious [~tattoovic@95.111.59.133] has joined #bitcoin-core-dev     
12:59 -!- jb55 [~jb55@208.98.200.100] has quit [Ping timeout: 248 seconds]     
12:59 -!- vicnicius [53a2c022@gateway/web/freenode/ip.83.162.192.34] has quit [Client Quit]     
13:00 < jnewbery> great. Thanks!
13:03 -!- Szadek [~Szadek@2001:ac8:28:d::3e] has joined #bitcoin-core-dev     
13:05 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 246 seconds]     
13:09 -!- tattoovicious [~tattoovic@95.111.59.133] has quit [Quit: This computer has gone to sleep]     
13:11 -!- jb55 [~jb55@S010600090fe1f16d.vc.shawcable.net] has joined #bitcoin-core-dev     
13:13 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.]     
13:14 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev     
13:21 -!- efo [58e06c51@gateway/web/freenode/ip.88.224.108.81] has joined #bitcoin-core-dev     
13:21 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
13:21 -!- jb55 [~jb55@S010600090fe1f16d.vc.shawcable.net] has quit [Ping timeout: 240 seconds]     
13:21 -!- efo [58e06c51@gateway/web/freenode/ip.88.224.108.81] has quit [Client Quit]     
13:22 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
13:28 -!- jb55 [~jb55@S010600090fe1f16d.vc.shawcable.net] has joined #bitcoin-core-dev     
13:36 -!- nxvivek [67cdafe9@gateway/web/freenode/ip.103.205.175.233] has joined #bitcoin-core-dev     
13:43 -!- Arokh [~Arokh@extknot.com] has joined #bitcoin-core-dev     
13:44 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]     
13:46 -!- nxvivek [67cdafe9@gateway/web/freenode/ip.103.205.175.233] has quit [Quit: Page closed]     
13:55 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
13:56 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
13:58 -!- quantbot_ [~quantbot@38.101.106.141] has joined #bitcoin-core-dev     
14:02 -!- quantbot [~quantbot@38.101.106.141] has quit [Ping timeout: 248 seconds]     
14:03 -!- quantbot_ [~quantbot@38.101.106.141] has quit [Ping timeout: 264 seconds]     
14:04 -!- [\\\] [~triplesla@unaffiliated/imsaguy] has quit [Ping timeout: 268 seconds]     
14:07 -!- cnone22 [~cnone@176.216.245.180] has left #bitcoin-core-dev []     
14:12 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev     
14:14 -!- Baraa [1f098292@gateway/web/freenode/ip.31.9.130.146] has joined #bitcoin-core-dev     
14:17 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
14:17 -!- HarlequinFields [~Harlequin@c-68-52-70-169.hsd1.tn.comcast.net] has quit []     
14:17 -!- tattoovicious [~tattoovic@95.111.59.133] has joined #bitcoin-core-dev     
14:18 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
14:20 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt]     
14:26 -!- tattoovicious [~tattoovic@95.111.59.133] has quit [Quit: This computer has gone to sleep]     
14:32 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.]     
14:34 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev     
14:36 -!- jb55 [~jb55@S010600090fe1f16d.vc.shawcable.net] has quit [Ping timeout: 240 seconds]     
14:41 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #11882: Improve fallback fee situations (master...2017/12/feeest_readyness) https://github.com/bitcoin/bitcoin/pull/11882
14:41 -!- Baraa [1f098292@gateway/web/freenode/ip.31.9.130.146] has quit [Quit: Page closed]     
14:42 -!- bityogi [~textual@208-104-132-26.brvd.dsl.dyn.comporium.net] has joined #bitcoin-core-dev     
14:42 -!- bityogi [~textual@208-104-132-26.brvd.dsl.dyn.comporium.net] has quit [Client Quit]     
14:42 -!- bityogi [~textual@208-104-132-26.brvd.dsl.dyn.comporium.net] has joined #bitcoin-core-dev     
14:43 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Ping timeout: 248 seconds]     
14:44 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has joined #bitcoin-core-dev     
14:44 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has quit [Changing host]     
14:44 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev     
14:51 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-rtlwmhlujbzegsgg] has joined #bitcoin-core-dev     
14:52 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Ping timeout: 248 seconds]     
14:52 -!- StopAndDecrypt_ [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has joined #bitcoin-core-dev     
14:56 -!- curious_ [57144223@gateway/web/freenode/ip.87.20.66.35] has joined #bitcoin-core-dev     
14:57 -!- curious_ [57144223@gateway/web/freenode/ip.87.20.66.35] has quit [Client Quit]     
15:01 -!- jb55 [~jb55@209.52.88.8] has joined #bitcoin-core-dev     
15:09 -!- bur [59f5cd86@gateway/web/freenode/ip.89.245.205.134] has joined #bitcoin-core-dev     
15:09 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has quit []     
15:10 -!- bur [59f5cd86@gateway/web/freenode/ip.89.245.205.134] has quit [Client Quit]     
15:11 < meshcollider> jnewbery: is there anything wrong with modifying bitcoin.conf in run_test() or should that only be done in setup_chain() ?
15:18 -!- jb55 [~jb55@209.52.88.8] has quit [Read error: Connection reset by peer]     
15:20 < jnewbery> meshcollider: by default, the test_framework will start your nodes in self.setup_nodes(), which is called *before* run_test() begins. That means if you don't restart your bitcoin nodes, then they won't see any changes in bitcoin.conf that you make in run_test()
15:21 < jnewbery> If you're stop-starting nodes and expect them to pick up changes in bitcoin.conf, then I see no problem with changing it in run_test().
15:21 -!- alcipir [~user@187.102.146.50] has quit [Ping timeout: 255 seconds]     
15:22 < jnewbery> You can get the datadir with the datadir variable in TestNode
15:22 < jonasschnelli> Travis lacks a couple of PRs behind... I wonder if we once have that situation continues, all it requires is a new PR / PR push every 2hs.
15:25 < meshcollider> jnewbery: ok sweet, thanks
15:27 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
15:29 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
15:30 -!- pkx2 [~pkx@unaffiliated/pkx] has quit [Remote host closed the connection]     
15:35 -!- jb55 [~jb55@209.52.88.8] has joined #bitcoin-core-dev     
15:38 -!- jb55 [~jb55@209.52.88.8] has quit [Read error: Connection reset by peer]     
15:40 -!- Dyaheon [~Dya@dsl-trebng21-58c19f-101.dhcp.inet.fi] has quit [Ping timeout: 276 seconds]     
15:45 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 264 seconds]     
15:45 -!- vicenteH [~user@35.233.15.37.dynamic.jazztel.es] has quit [Ping timeout: 248 seconds]     
15:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]     
15:52 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
15:59 < bitcoin-git> [bitcoin] MeshCollider opened pull request #11883: Add configuration file/argument testing (master...201712_datadir_tests) https://github.com/bitcoin/bitcoin/pull/11883
16:03 -!- Dyaheon [~Dya@dsl-trebng21-58c19f-101.dhcp.inet.fi] has joined #bitcoin-core-dev     
16:05 -!- eck [~eck@fsf/member/eck] has quit [Quit: we out here]     
16:06 -!- eck [~eck@fsf/member/eck] has joined #bitcoin-core-dev     
16:11 -!- jamesob [~james@199.230.10.198] has quit [Ping timeout: 255 seconds]     
16:12 -!- jamesob [~james@199.230.10.198] has joined #bitcoin-core-dev     
16:17 -!- eck [~eck@fsf/member/eck] has quit [Ping timeout: 264 seconds]     
16:24 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev     
16:27 -!- mrfrasha [~mrfrasha@66-188-250-34.dhcp.eucl.wi.charter.com] has quit [Quit: mrfrasha]     
16:28 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection]     
16:28 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev     
16:28 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Quit: Leaving]     
16:34 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has quit [Quit: May the Shwartz be with you]     
16:36 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev     
16:42 -!- lnostdal [~lnostdal@62.90-149-73.nextgentel.com] has quit [Ping timeout: 240 seconds]     
16:43 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has quit [Ping timeout: 250 seconds]     
16:43 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has joined #bitcoin-core-dev     
16:46 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection]     
16:46 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev     
16:48 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has quit [Ping timeout: 240 seconds]     
16:48 -!- jamesob [~james@199.230.10.198] has quit [Ping timeout: 264 seconds]     
16:49 -!- eck [~eck@fsf/member/eck] has joined #bitcoin-core-dev     
16:51 -!- eck [~eck@fsf/member/eck] has quit [Client Quit]     
16:51 -!- lnostdal [~lnostdal@62.90-149-73.nextgentel.com] has joined #bitcoin-core-dev     
16:52 -!- eck [~eck@fsf/member/eck] has joined #bitcoin-core-dev     
16:56 -!- mrfrasha [~mrfrasha@66-188-250-34.dhcp.eucl.wi.charter.com] has joined #bitcoin-core-dev     
16:57 -!- Dizzle [~dizzle@108.171.182.16] has quit [Quit: Leaving...]     
16:58 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev     
16:58 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Ping timeout: 248 seconds]     
17:02 -!- Szadek [~Szadek@2001:ac8:28:d::3e] has quit [Quit: 🔥]     
17:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds]     
17:15 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
17:17 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev     
17:18 -!- DrFeelGood [~DrFeelGoo@unaffiliated/olufunmilayo] has quit [Ping timeout: 240 seconds]     
17:23 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev     
17:28 -!- DvdKhl [~Arokh@ip-37-201-210-118.hsi13.unitymediagroup.de] has quit [Ping timeout: 240 seconds]     
17:29 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.]     
17:36 -!- DvdKhl [~Arokh@ip-37-201-210-118.hsi13.unitymediagroup.de] has joined #bitcoin-core-dev     
17:37 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 256 seconds]     
17:38 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #bitcoin-core-dev     
17:50 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
17:58 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-pvnilfdbvrbfuvjm] has quit [Quit: Connection closed for inactivity]     
18:12 -!- go1111111 [~go1111111@gateway/vpn/privateinternetaccess/go1111111] has quit [Quit: Leaving]     
18:14 -!- DvdKhl [~Arokh@ip-37-201-210-118.hsi13.unitymediagroup.de] has quit []     
18:16 -!- pkx2 [~pkx@unaffiliated/pkx] has joined #bitcoin-core-dev     
18:20 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 272 seconds]     
18:21 -!- jamesob [~james@c-73-241-180-136.hsd1.ca.comcast.net] has joined #bitcoin-core-dev     
18:23 -!- shtirlic [~shtirlic@ec2-35-158-173-101.eu-central-1.compute.amazonaws.com] has quit [Quit: ZNC - http://znc.in]     
18:26 -!- shtirlic [~shtirlic@ec2-35-158-173-101.eu-central-1.compute.amazonaws.com] has joined #bitcoin-core-dev     
18:35 -!- jb55 [~jb55@70.36.49.138] has joined #bitcoin-core-dev     
18:46 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has joined #bitcoin-core-dev     
18:50 -!- _ [451f6503@gateway/web/freenode/ip.69.31.101.3] has joined #bitcoin-core-dev     
18:51 -!- _ is now known as Guest22330     
18:51 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has quit [Ping timeout: 272 seconds]     
18:51 -!- Guest22330 [451f6503@gateway/web/freenode/ip.69.31.101.3] has quit [Client Quit]     
19:09 -!- mrfrasha [~mrfrasha@66-188-250-34.dhcp.eucl.wi.charter.com] has quit [Quit: mrfrasha]     
19:12 -!- mrfrasha [~mrfrasha@66-188-250-34.dhcp.eucl.wi.charter.com] has joined #bitcoin-core-dev     
19:14 -!- spinza [~spin@196.212.164.26] has quit [Ping timeout: 252 seconds]     
19:42 -!- go1111111 [~go1111111@gateway/vpn/privateinternetaccess/go1111111] has joined #bitcoin-core-dev     
19:59 -!- edman80 [~edman80@pool-173-70-115-60.nwrknj.fios.verizon.net] has joined #bitcoin-core-dev     
20:01 -!- bityogi [~textual@208-104-132-26.brvd.dsl.dyn.comporium.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]     
20:03 -!- spinza [~spin@196.212.164.26] has joined #bitcoin-core-dev     
20:06 -!- bityogi [~textual@208.104.132.26] has joined #bitcoin-core-dev     
20:09 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-rtlwmhlujbzegsgg] has quit [Quit: Connection closed for inactivity]     
20:16 -!- bityogi [~textual@208.104.132.26] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]     
20:21 -!- Roberto_2000 [~colin@2605:6000:cdc9:3b00:9dd0:5973:fc80:a578] has joined #bitcoin-core-dev     
20:23 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-lqfizkzjfoksyjqa] has joined #bitcoin-core-dev     
20:23 -!- xmsx [4e24bd68@gateway/web/freenode/ip.78.36.189.104] has joined #bitcoin-core-dev     
20:24 < xmsx> hey, could anyone help me with generating segwit addresses?
20:25 < meshcollider> Anyone seen this Travis failure before https://travis-ci.org/bitcoin/bitcoin/jobs/315614592
20:25 < meshcollider> xmsx: what do you need help with?
20:25 -!- goatpig [56f75683@gateway/web/freenode/ip.86.247.86.131] has quit [Quit: Page closed]     
20:27 < meshcollider> https://pastebin.com/Ek9htTQL
20:29 < xmsx> I'm trying to generate segwit address in PHP but not sure if I got it right, and my bitcoin got corrupted database for some reason so I can't test it properly
20:29 < xmsx> Here's the code I'm using: https://pastebin.com/us0qEqe1
20:30 < xmsx> My only question is -- Am I using correct  $compressed_public_key at step 1?
20:32 < xmsx> e.g. docs say: "To create a P2SH-P2WPKH address: 1) Calculate the RIPEMD160 of the SHA256 of a public key (keyhash)."
20:33 < xmsx> Do I need to use compressed version of keyhash?
20:35 < xmsx> it generates valid segwit addresses (eg. https://blockchain.info/address/37fZYysB6c2iMt2cywZyUUydqQkR6vkCri) but not sure if I base it on proper public key on step 1 :)
20:36 < xmsx> Also, don't try to run that code above, it won't work for you, it's just a pseudocode :)
20:40 -!- xmsx [4e24bd68@gateway/web/freenode/ip.78.36.189.104] has quit [Quit: Page closed]     
20:40 -!- xmsx [4e24bd68@gateway/web/freenode/ip.78.36.189.104] has joined #bitcoin-core-dev     
20:41 < sipa> xmsx: sorry, this the dev channel for bitcoin core, a c++ bitcoin client
20:42 < xmsx> Can you just import this private key: 5KAwW31HxQW5Jrp4HM3o59BPRXarMP87imDR1nrjQpGvnTzwafK and tell me if segwit for it is 37fZYysB6c2iMt2cywZyUUydqQkR6vkCri?
20:42 < bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/ef8ba7d73a48...ba2f19504c6b
20:43 < bitcoin-git> bitcoin/master 1729c29 Cory Fields: net: split socket creation out of connection...
20:43 < bitcoin-git> bitcoin/master 9e3b2f5 Cory Fields: net: Move IsSelectableSocket check into socket creation...
20:43 < bitcoin-git> bitcoin/master df3bcf8 Cory Fields: net: pass socket closing responsibility up to caller for outgoing connections...
20:43 < bitcoin-git> [bitcoin] laanwj closed pull request #11363: net: Split socket create/connect (master...split-socket-create-connect) https://github.com/bitcoin/bitcoin/pull/11363
20:59 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has joined #bitcoin-core-dev     
21:00 -!- pkx2 [~pkx@unaffiliated/pkx] has quit [Remote host closed the connection]     
21:00 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has quit [Read error: Connection reset by peer]     
21:01 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has joined #bitcoin-core-dev     
21:01 -!- jamesob [~james@c-73-241-180-136.hsd1.ca.comcast.net] has quit [Ping timeout: 264 seconds]     
21:03 -!- Roberto_2000 is now known as AegisAttack_9000     
21:08 -!- blasfem [c0ded02d@gateway/web/freenode/ip.192.222.208.45] has joined #bitcoin-core-dev     
21:12 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Ping timeout: 256 seconds]     
21:13 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #bitcoin-core-dev     
21:18 -!- blasfem [c0ded02d@gateway/web/freenode/ip.192.222.208.45] has quit [Quit: Page closed]     
21:21 -!- AegisAttack_9000 is now known as PIMP     
21:21 -!- PIMP is now known as Allah     
21:22 -!- xmsx [4e24bd68@gateway/web/freenode/ip.78.36.189.104] has quit [Quit: Page closed]     
21:22 -!- Allah is now known as AegisAttack     
21:25 -!- AegisAttack is now known as HODLGod     
21:26 -!- HODLGod is now known as AegisAttack     
21:28 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has quit [Remote host closed the connection]     
21:48 < bitcoin-git> [bitcoin] kallewoof opened pull request #11884: [trivial] Remove unused include in hash.cpp (master...20171213-unneeded-include-hash-cpp) https://github.com/bitcoin/bitcoin/pull/11884
22:17 -!- bitcoinNOOOB [ada896d9@gateway/web/freenode/ip.173.168.150.217] has joined #bitcoin-core-dev     
22:18 < bitcoinNOOOB> Hello?
22:18 < bitcoinNOOOB> Anyone here?
22:19 -!- bitcoinNOOOB [ada896d9@gateway/web/freenode/ip.173.168.150.217] has quit [Client Quit]     
22:21 -!- AegisAttack [~colin@2605:6000:cdc9:3b00:9dd0:5973:fc80:a578] has quit [Quit: Leaving]     
22:25 -!- jb55 [~jb55@70.36.49.138] has quit [Ping timeout: 256 seconds]     
22:31 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has joined #bitcoin-core-dev     
22:35 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has quit [Ping timeout: 272 seconds]     
22:37 -!- jtimon [~quassel@164.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 250 seconds]     
22:42 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection]     
22:43 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev     
22:45 -!- go1111111 [~go1111111@gateway/vpn/privateinternetaccess/go1111111] has quit [Quit: Leaving]     
22:49 < jonasschnelli> [OT] what is the fastest way to amend commit the current changes into a non HEAD commit? (instead of git stash & git rebase -i HEAD~3 (edit) & git stash apply & git commit --amend & git rebase --continue)?
22:50 < sipa> i usually just write a new commit at the end, and then move/apply/squash it with rebase -i
22:50 < wumpus> same here
22:50 < sipa> so <make changes>; git commit -am "fix"; git rebase -i HEAD~~~~~~~~, and move the last commit up in the list turning the 'pick' into 'fix'
22:50 < wumpus> I make lots of temporary commits, then at some point I merge them into the commit they belong
22:51 < sipa> if the changes are to a commit in the middle which you can't just do at the end (because they're already overwritten in a later commit), git rebase -i HEAD~~~~~~ and 'edit' the commit itself
22:52 < sipa> (i squash very liberally, but try to avoid actually rebasing0
22:53 < wumpus> if you already have changes in your working tree that need to be spread into multiple commits, git add -p is great
22:56 < jonasschnelli> thanks!
22:56 < jonasschnelli> There is no direct way for git rebase -i HEAD~3 (then select edit)? Something that directly rebased back in edit mode to ~3 (or other depth)?
22:57 < jonasschnelli> I whish my IDE would have a way to directly amend commit a line-change (or block) into a selected historical commit
22:57 < wumpus> I think everything you can do with -i (interactive) should be possible without -i, it's just a longer sequence of commands
22:58 < wumpus> in a way an interactive mode makes you lazy :)
22:59 < wumpus> yes that'd be quite useful as a command, what I usually miss is a way to refer to commits by say, a name, instead of their (ever changing) commit id
22:59 < wumpus> that would be so much easier for referring to them in rebase commands
23:01 -!- Cogito_Ergo_Sum [~Myself@80.107.151.135] has joined #bitcoin-core-dev     
23:01 -!- Cogito_Ergo_Sum [~Myself@80.107.151.135] has quit [Changing host]     
23:01 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev     
23:01 < jonasschnelli> wumpus: indeed
23:15 -!- mrfrasha [~mrfrasha@66-188-250-34.dhcp.eucl.wi.charter.com] has quit [Quit: mrfrasha]     
23:35 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
23:37 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
23:59 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-lqfizkzjfoksyjqa] has quit [Quit: Connection closed for inactivity]