--- Day changed Tue Jan 30 2018
00:00 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has joined #bitcoin-core-dev     
00:02 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer]     
00:03 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev     
00:06 -!- indistylo [~indistylo@106.216.180.124] has quit [Ping timeout: 248 seconds]     
00:08 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.]     
00:13 -!- Sinclai__ [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has quit []     
00:14 -!- Sinclair6 [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has joined #bitcoin-core-dev     
00:23 -!- atroxes [~atroxes@unaffiliated/atroxes] has quit [Quit: bye]     
00:25 -!- atroxes [~atroxes@unaffiliated/atroxes] has joined #bitcoin-core-dev     
00:33 -!- Pavle [~pavle_@unaffiliated/pavle/x-4679000] has joined #bitcoin-core-dev     
00:38 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev     
00:57 -!- dabura667 [~dabura667@240f:d:e193:1:d820:37b3:e944:c3cb] has joined #bitcoin-core-dev     
00:58 < bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/9d9c4185fada...7cf1aea5cfcc
00:58 < bitcoin-git> bitcoin/master 336685e Randolf Richardson: [build] Add db4_cxx to bitcoin_find_bdb48.m4...
00:58 < bitcoin-git> bitcoin/master 1944fa3 Randolf Richardson: [doc] Create build-netbsd.md
00:58 < bitcoin-git> bitcoin/master 11c5827 fanquake: [build] Add NETBSD leveldb target to configure.ac
00:59 < bitcoin-git> [bitcoin] laanwj closed pull request #12294: [Docs] Create NetBSD build instructions and fix compilation (master...netbsd-build-docs) https://github.com/bitcoin/bitcoin/pull/12294
00:59 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7cf1aea5cfcc...288deacdbe08
00:59 < bitcoin-git> bitcoin/master ee11121 MeshCollider: Add special error for genesis coinbase to gettransaction
00:59 < bitcoin-git> bitcoin/master 288deac Wladimir J. van der Laan: Merge #12278: Add special error for genesis coinbase to getrawtransaction...
01:00 < bitcoin-git> [bitcoin] laanwj closed pull request #12278: Add special error for genesis coinbase to getrawtransaction (master...201801_genesis_gettransaction_error) https://github.com/bitcoin/bitcoin/pull/12278
01:14 -!- jtimon [~quassel@41.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev     
01:17 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/288deacdbe08...7936446268e2
01:17 < bitcoin-git> bitcoin/master 039425c João Barbosa: [wallet] Remove duplicate mapWallet lookups
01:17 < bitcoin-git> bitcoin/master 7936446 Wladimir J. van der Laan: Merge #12276: Remove duplicate mapWallet lookups...
01:18 < bitcoin-git> [bitcoin] laanwj closed pull request #12276: Remove duplicate mapWallet lookups (master...2018-01-mapwallet) https://github.com/bitcoin/bitcoin/pull/12276
01:25 -!- promag [~promag@46.50.113.231] has joined #bitcoin-core-dev     
01:25 -!- indistylo [~indistylo@223.186.208.109] has joined #bitcoin-core-dev     
01:30 -!- aruns [~indistylo@223.186.208.109] has joined #bitcoin-core-dev     
01:30 < promag> wumpus: be sure to check #12299
01:30 < gribble> https://github.com/bitcoin/bitcoin/issues/12299 | Improve CWallet::IsFromMe for positive results by promag · Pull Request #12299 · bitcoin/bitcoin · GitHub
01:31 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
01:31 -!- indistylo [~indistylo@223.186.208.109] has quit [Read error: Connection reset by peer]     
01:34 -!- checksau_ [~checksauc@103.57.72.31] has joined #bitcoin-core-dev     
01:37 -!- checksauce [~checksauc@184.82.29.183] has quit [Ping timeout: 248 seconds]     
01:40 < gmaxwell> promag: does that actually make a measurable difference? I would assume very few transactions are fromme, so the early termination would never fire.
01:40 < gmaxwell> I'd expect a lot bigger gain from things like hoisting the locking cs_wallet out of the inner loop or similar.
01:43 < promag> GetDebit(tx) is called from a lot of places
01:43 < promag> it also avoid unnecessary IsMine calls
01:43 < promag> not saying it's a big performance improvement
01:44 < promag> regarding locks, IMO only after 0.16 is branched
01:44 < wumpus> we really need benchmarking for wallet things
01:44 < wumpus> without that, these kind of changes are really hard to evaluate, whether it's worth complicating the code more
01:45 < promag> anyway, in that case, I'd say it's a pretty obvious improvement
01:46 < gmaxwell> I don't agree. It turns one line of simple code into five lines of less clear code. I don't think it's bad, but if its not actually faster for any realistic case, why would we want it?
01:47 < gmaxwell> maybe it is-- e.g. perhaps we call IsFromMe on masses of wallet txn all the time, where its true on the first input... but I'm not aware of that.
01:48 < gmaxwell> Certantly to the extent that the function is run on transactions in the chain the early termination won't make it faster-- I doubt it would make it slower either, but not faster.
01:48 < promag> gmaxwell: I think the semantic of IsFromMe it better explained in that pr
01:48 < promag> "if from me if at least one input is debit"
01:49 < promag> s/if/is
01:49 < gmaxwell> I know what the semantics of the functions are. But early termination is not a win for a function where 99.999% of the time it will never fire, it can even be a performance loss (though I am not saying I expect that here).
01:50 < promag> also, for big wallets, with thousands of transactions, thousands of keys, avoiding IsMine is important
01:50 < gmaxwell> I'm only commenting on the IsFromMe early termination.
01:50 < promag> gmaxwell: sure, for the worst case the performance is the same (although it avoids summing)
01:50 < promag> also not sure about the average case
01:51 < gmaxwell> And, as far as I know, for the average case. If not, we're probably calling it where we shouldn't be at all.
01:52 -!- Pavle [~pavle_@unaffiliated/pavle/x-4679000] has quit [Quit: Leaving]     
01:52 < promag> gmaxwell: I'll try to measure it
01:52 < promag> gmaxwell: care to see #12297
01:52 < gribble> https://github.com/bitcoin/bitcoin/issues/12297 | Improve CWallet::IsAllFromMe for false results by promag · Pull Request #12297 · bitcoin/bitcoin · GitHub
01:56 < promag> brb     
01:56 < gmaxwell> (at least off the top of my head I only know that function being called on all blockchain/relay txn, where it'll return false almost all the time for even the largest users.  I think we also call it on some unconfirmed stuff.)
01:57 < gmaxwell> ha     
01:57 < gmaxwell> see this is silly, for example:
01:57 < gmaxwell>             int nDepth = pcoin->GetDepthInMainChain();
01:57 < gmaxwell>             if (nDepth < (pcoin->IsFromMe(ISMINE_ALL) ? 0 : 1))
01:57 < gmaxwell>                 continue;
01:58 -!- promag [~promag@46.50.113.231] has quit [Remote host closed the connection]     
01:59 < gmaxwell> so it looks like there are a couple other places it's called, but none strike me as that interesting at a glance, though some could be optimized.
02:00 < gmaxwell> (actually that code looks redundant with the efficient IsTrusted check above)
02:04 < gmaxwell> but don't listen to me, I should be asleep. :)
02:15 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has quit [Read error: Connection reset by peer]     
02:18 -!- aruns [~indistylo@223.186.208.109] has quit [Remote host closed the connection]     
02:18 -!- aruns [~indistylo@223.186.208.109] has joined #bitcoin-core-dev     
02:20 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has joined #bitcoin-core-dev     
02:24 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has quit [Ping timeout: 240 seconds]     
02:25 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has joined #bitcoin-core-dev     
02:30 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has quit [Ping timeout: 252 seconds]     
02:30 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has joined #bitcoin-core-dev     
02:32 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 255 seconds]     
02:33 -!- dabura667 [~dabura667@240f:d:e193:1:d820:37b3:e944:c3cb] has quit [Remote host closed the connection]     
02:33 -!- Sentineo [~Undefined@unaffiliated/sentineo] has joined #bitcoin-core-dev     
02:34 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has quit [Ping timeout: 240 seconds]     
02:35 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has joined #bitcoin-core-dev     
02:38 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev     
02:39 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has quit [Ping timeout: 246 seconds]     
02:40 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has joined #bitcoin-core-dev     
02:44 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has quit [Ping timeout: 240 seconds]     
02:45 -!- dabura667 [~dabura667@KD111103034253.ppp-bb.dion.ne.jp] has joined #bitcoin-core-dev     
02:45 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has joined #bitcoin-core-dev     
02:54 -!- jtimon [~quassel@41.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 248 seconds]     
02:55 < wumpus> need review for https://github.com/bitcoin/bitcoin/pull/12266   https://github.com/bitcoin/bitcoin/pull/12274
02:55 < wumpus> otherhwise I'm going to branch off 0.16 without them
02:58 -!- dx25 [~dx25@97-121-79-242.omah.qwest.net] has quit [Ping timeout: 256 seconds]     
03:00 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]     
03:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
03:02 -!- dx25 [~dx25@174-19-89-235.omah.qwest.net] has joined #bitcoin-core-dev     
03:05 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds]     
03:08 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev     
03:11 < meshcollider> I'd like to review the fd one to help but its beyond my skill level I'm afraid
03:12 < wumpus> you're not alone in that
03:12 < wumpus> I'm confused by it too
03:12 < wumpus> please do review BlueMatt's though
03:13 < wumpus> that one is not so hard to grasp as I thought initially
03:13 < wumpus> oh you did!
03:13 < wumpus> thanks
03:19 < gmaxwell> ut-sleepy-ACK from me, I'll try to setup some kind of shutdown loop to test it.
03:20 < gmaxwell> I'd bias toward including since we have known easily triggered shutdown deadlock, if users report that on rc1 without this we learn nothing, if they report it or a shutdown crash on an rc1 with this we learn something.
03:21 < wumpus> yes I'd also vote for including #12266, but I think it's quite harmless to hold up on #12274 for now
03:21 < gribble> https://github.com/bitcoin/bitcoin/issues/12266 | Move scheduler/threadGroup into common-init instead of per-app by TheBlueMatt · Pull Request #12266 · bitcoin/bitcoin · GitHub
03:21 < gribble> https://github.com/bitcoin/bitcoin/issues/12274 | http: avoid fd exhaustion by theuni · Pull Request #12274 · bitcoin/bitcoin · GitHub
03:21 < wumpus> it's a lot of logic to work around an upstream issue, and according to test reports there it doesn't even fully solve the issue yet
03:21 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 255 seconds]     
03:22 < wumpus> also it's regression in 0.15 and it only comes up under rare conditions
03:22 < gmaxwell> when I looked at the limiter I had questions about concurrency of the limiter function and didn't know where to start looking.
03:22 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev     
03:22 < wumpus> sorry I mean it's *not* regression in 0.16
03:23 < wumpus> it's an issue that has existed since we started using libevent for http, and very hard to trigger
03:23 < wumpus> I don't mean it should not be solved, but I wonder if we shouldn't take a higher level approach and try to fix upstream, instead of hack on hack on hack :(
03:23 < gmaxwell> right. we could also cut down our FD usage in some other way to give it more safty margin, I suppose?
03:25 < gmaxwell> e.g. raise MIN_CORE_FILEDESCRIPTORS
03:25 < wumpus> right - maybe the accounting of fds (how much is reserved for what) is also incorrect
03:25 < wumpus> anyhow I think this is a post-0.16 issue
03:28 -!- wxss [~user@43.249.39.215] has joined #bitcoin-core-dev     
03:31 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev     
03:34 < wumpus> milestone 0.16.1 has the fd changes now: https://github.com/bitcoin/bitcoin/milestone/34
03:45 -!- dabura667 [~dabura667@KD111103034253.ppp-bb.dion.ne.jp] has quit [Remote host closed the connection]     
04:03 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 255 seconds]     
04:04 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7936446268e2...3448907a68e0
04:04 < bitcoin-git> bitcoin/master 082a61c Matt Corallo: Move scheduler/threadGroup into common-init instead of per-app...
04:04 < bitcoin-git> bitcoin/master 3448907 Wladimir J. van der Laan: Merge #12266: Move scheduler/threadGroup into common-init instead of per-app...
04:05 < bitcoin-git> [bitcoin] laanwj closed pull request #12266: Move scheduler/threadGroup into common-init instead of per-app (master...2018-01-common-init) https://github.com/bitcoin/bitcoin/pull/12266
04:06 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev     
04:12 -!- checksau_ [~checksauc@103.57.72.31] has quit [Remote host closed the connection]     
04:13 < meshcollider> wumpus: so branch and tag 0.16 now then?
04:13 < meshcollider> Is there anything else left to do
04:15 < meshcollider> Oh, have you done the manpages update thing
04:15 -!- capa66 [capa66@gateway/vpn/privateinternetaccess/capa66] has joined #bitcoin-core-dev     
04:21 < wumpus> meshcollider: that needs to be done after the branch, after bumping version, before tagging
04:23 < wumpus> but yes I intend to branch now
04:23 < meshcollider> ooh ok yep
04:23 < meshcollider> \o/     
04:25 -!- aruns__ [~indistylo@119.82.105.106] has joined #bitcoin-core-dev     
04:27 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev     
04:28 -!- aruns [~indistylo@223.186.208.109] has quit [Ping timeout: 256 seconds]     
04:44 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/10847fe2d82bd4ffe5be499fd9ad64b6fee78a33
04:44 < bitcoin-git> bitcoin/master 10847fe Wladimir J. van der Laan: qt: Periodic translations update...
04:49 -!- xabbix [1fa894b1@gateway/web/freenode/ip.31.168.148.177] has joined #bitcoin-core-dev     
04:51 < xabbix> Can someone please explain how the mempool is filled for a new node and relayed? If I just finished syncing up my node, is it possible that I'll get a tx into my mempool that was sent a week ago (and still haven't confirmed)? Does my node request the mempool from the 8 peers it is connected to? Or does it just start collecting what is relayed to it from the point it was launched?
04:52 < gmaxwell> xabbix: the last thing.
04:53 < xabbix> gmaxwell: thanks, are there cases that a new node will get an 'old' transaction? what are those cases?
04:54 < wumpus> it will start collecting transactuins once it leaves initial sync. Normally these are new transactions, though there's nothing preventing people from re-relaying old transactions.
04:54 < gmaxwell> someone relays it.
04:54 < gmaxwell> the sender and reciever of the txn will rebroadcast every once in a while, normally...
04:54 < gmaxwell> and random other people might do so for whatever reasons they feel like.
04:54 < xabbix> gmaxwell, wumpus: ok, that makes a lot more sense now. thanks.
04:55 < gmaxwell> it won't cross peers that already have it, however.
04:56 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]     
04:57 < xabbix> As I understand from an answer that jnewbery wrote to me a few days ago, the `time` value in the mempool is saved and relayed by other nodes, so even though my node is 'new' I can get txs with `time` values of before I ever started my node, but the `height` value is not stored and therefore not very reliable. Is there an easy way of calculating what the block height was at a certain time?
04:58 < gmaxwell> it's not relayed.
04:58 < xabbix> it's = height?
04:58 < wumpus> transactions generated by modern wallets will usually be time-locked to the current (or current-1) block
04:59 < gmaxwell> xabbix: no time value is relayed.
05:00 < wumpus> if you really want to compute the height at a certain time there's no efficient way to do that because block times are not strictly increasing and also not accurate
05:01 < wumpus> (the latter making it impossible to know for sure)
05:03 < gmaxwell> xabbix: if you were asking about why you had times before your startup time, that would be because the mempool and its timestamps are saved across restarts.
05:03 < gmaxwell> The heights (IIRC) are not.
05:04 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 255 seconds]     
05:04 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/10847fe2d82b...8d573198638e
05:04 < bitcoin-git> bitcoin/master 125f4a4 Anthony Towns: [tests] Require all tests to follow naming convention
05:04 < bitcoin-git> bitcoin/master 8d57319 MarcoFalke: Merge #12252: Require all tests to follow naming convention...
05:04 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #12252: Require all tests to follow naming convention (master...rename_tests_no_leeway) https://github.com/bitcoin/bitcoin/pull/12252
05:05 < xabbix> gmaxwell: that means that I should not at any circumstances have a `time` value of two weeks ago if I installed bitcoin-core today?
05:05 < xabbix> given my machine clock is set correctly :)
05:06 -!- goatpig [56f75164@gateway/web/freenode/ip.86.247.81.100] has joined #bitcoin-core-dev     
05:07 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev     
05:07 < bitcoin-git> [bitcoin] laanwj created 0.16 (+2 new commits): https://github.com/bitcoin/bitcoin/compare/5c242b211eda^...66bc647e8c65
05:07 < bitcoin-git> bitcoin/0.16 5c242b2 Wladimir J. van der Laan: build: bump version to 0.16.0...
05:08 < bitcoin-git> bitcoin/0.16 66bc647 Wladimir J. van der Laan: doc: Update manpages to 0.16.0...
05:08 < gmaxwell> xabbix: why do you think it was two weeks ago?
05:09 < xabbix> I think that I saw a `time` value when I queried getmempoolentry that is before I created the machine I was running on.
05:09 < xabbix> I'm not 100% sure just trying to figure out if that's possible.
05:09 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/4602dc704ae83bd08d0d6e835b760cc9ab8fea37
05:09 < bitcoin-git> bitcoin/master 4602dc7 Wladimir J. van der Laan: build: Bump version to 0.16.99...
05:10 < wumpus> I guess that should not be possible, at least if you didn't install a mempool.dat somehow
05:11 < gmaxwell> I don't think it's possible, the only places in the code that is set is with the output of GetTime() (gets the current time) and when reading it from the mempool.dat file.
05:11 < gmaxwell> if you had an older mempool.dat or something then that would do it.
05:12 < wumpus> is it perhaps an ARM board without realtime clock? I've seen times all over the place with those, if they fail the ntpdate at startup
05:13 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has quit [Read error: Connection reset by peer]     
05:13 -!- xabbix [1fa894b1@gateway/web/freenode/ip.31.168.148.177] has quit [Ping timeout: 260 seconds]     
05:16 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has joined #bitcoin-core-dev     
05:20 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has quit [Ping timeout: 252 seconds]     
05:21 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has joined #bitcoin-core-dev     
05:23 -!- To7 [~theo@68.129.242.238] has joined #bitcoin-core-dev     
05:25 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/9cb2309050880c2887b4b5f7a7231e4fc6dc3f47
05:25 < bitcoin-git> bitcoin/master 9cb2309 Wladimir J. van der Laan: doc: Update manpages to 0.16.99...
05:25 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has quit [Ping timeout: 240 seconds]     
05:29 < wumpus> going to tag 0.16.0rc1 in a bit on the 0.16 branch
05:29 -!- indistylo [~indistylo@119.82.105.106] has joined #bitcoin-core-dev     
05:30 -!- indistylo [~indistylo@119.82.105.106] has quit [Client Quit]     
05:30 -!- aruns__ [~indistylo@119.82.105.106] has quit [Remote host closed the connection]     
05:31 -!- aruns__ [~indistylo@119.82.105.106] has joined #bitcoin-core-dev     
05:31 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has joined #bitcoin-core-dev     
05:34 < wumpus>  * [new tag]         v0.16.0rc1 -> v0.16.0rc1
05:35 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has quit [Ping timeout: 240 seconds]     
05:36 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has joined #bitcoin-core-dev     
05:37 -!- indistylo [~indistylo@119.82.105.106] has joined #bitcoin-core-dev     
05:40 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has quit [Ping timeout: 252 seconds]     
05:41 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has joined #bitcoin-core-dev     
05:45 < jnewbery> \o/     
05:45 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has quit [Ping timeout: 240 seconds]     
05:46 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has joined #bitcoin-core-dev     
05:50 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has quit [Ping timeout: 252 seconds]     
05:51 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has joined #bitcoin-core-dev     
05:51 -!- jamesob [~jamesob@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #bitcoin-core-dev     
05:52 -!- bajohns [bajohns@gateway/vpn/privateinternetaccess/bajohns] has quit [Remote host closed the connection]     
05:54 -!- Emcy_ [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev     
05:55 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 248 seconds]     
05:55 < jnewbery> xabbix: not sure how you interpreted "Both are set by your own node" as time is relayed by peers! Time is set by your own node when it receives the tx, and is saved in mempool.dat on shutdown/loaded on startup.
05:57 < jnewbery> you'll want to look at the AcceptToMemoryPoolWithTime() function in validation.cpp and the places where it's called
05:58 -!- james [~james@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #bitcoin-core-dev     
05:59 -!- james is now known as Guest66433     
06:04 -!- jtimon [~quassel@41.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev     
06:04 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
06:05 < promag> \o/     
06:05 < wumpus> the release notes still need work, if anyone feels like improving them please do so on the wiki, https://github.com/bitcoin/bitcoin/issues/11054  https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.16.0-Release-notes
06:10 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #bitcoin-core-dev     
06:18 -!- jojeyh [~delphi@2602:306:b8b6:b970:78db:9b9:7d1a:75de] has quit [Ping timeout: 246 seconds]     
06:20 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
06:31 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev     
06:40 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-meihvxlillhpkdwn] has quit [Quit: Connection closed for inactivity]     
07:06 -!- mandric [~mandric@108-228-58-104.lightspeed.cicril.sbcglobal.net] has quit [Ping timeout: 260 seconds]     
07:09 -!- mandric [~mandric@108-228-58-104.lightspeed.cicril.sbcglobal.net] has joined #bitcoin-core-dev     
07:17 -!- flokie [~flokie@unaffiliated/flokie] has joined #bitcoin-core-dev     
07:18 -!- Carolina35Keeble [~Carolina3@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 240 seconds]     
07:25 < achow101> yay!
07:34 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Quit: Leaving.]     
07:35 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #bitcoin-core-dev     
07:36 < wumpus> I've added changelog and author information to https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.16.0-Release-notes
07:37 -!- indistylo [~indistylo@119.82.105.106] has quit [Ping timeout: 256 seconds]     
07:38 -!- aruns__ [~indistylo@119.82.105.106] has quit [Ping timeout: 264 seconds]     
07:38 -!- wraithm [~wraithm@unaffiliated/wraithm] has joined #bitcoin-core-dev     
07:44 < wumpus> please help check for duplicate authors and such
07:52 < instagibbs> wumpus, Donal OConnor and donaloconnor
07:52 < wumpus> instagibbs: it's a wiki, you can edit it :)
07:59 -!- Trevor18Ritchie [~Trevor18R@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev     
08:01 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has quit [Read error: Connection reset by peer]     
08:02 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has joined #bitcoin-core-dev     
08:06 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has quit [Ping timeout: 240 seconds]     
08:07 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has joined #bitcoin-core-dev     
08:12 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev     
08:14 -!- Emcy_ [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 248 seconds]     
08:17 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection]     
08:18 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev     
08:20 < luke-jr> sdaftuar: I don't understand this question: https://github.com/bitcoin/bips/pull/639#issuecomment-361642505
08:21 < sdaftuar> luke-jr: I'm trying to restore a document I authored to its original text.  I don't know why this needs a discussion on bitcoin-dev?
08:22 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 268 seconds]     
08:23 < luke-jr> sdaftuar: the Layer field was added by BIP 123; the only reason BIP 90 was a BIP at all, is because it was a hardfork..
08:23 < sdaftuar> BIP 123 came after BIP 90
08:23 < sdaftuar> it was applied to that doc without my approval!
08:23 < sdaftuar> doesn't the author have the final say on changes?
08:24 < luke-jr> nobody objected before BIP 123 became activate..?
08:25 < sdaftuar> no one tagged me to let me know my document was being changed either
08:25 < luke-jr> the document wasn't really changed, just the headers, which was based on the content
08:26 < wumpus> the author is supposed to be asked in case of changes
08:26 < luke-jr> maybe I don't understand the problem - all it does is describe the BIP
08:27 < luke-jr> wumpus: to the BIP itself, yes
08:27 < wumpus> yes, I don't know the details
08:27 < sdaftuar> the point of the BIP is to explain why merely labeling things as "sfot forks" or "hard forks" is deficient
08:28 < sdaftuar> so applying BIP 123's labels to it doesn't make sense
08:28 < luke-jr> the point of the BIP was that changes were being made in Core that were objectively a hardfork, and as such should be documented as a hardfork
08:28 < sdaftuar> no     
08:30 < sdaftuar> i'm at a loss as to what the process here is.  i wrote a document, you changed it, and you seem to think i can't change it back without... what exactly?
08:30 < luke-jr> the headers aren't part of the document
08:30 < sdaftuar> ah.  we should move them out then
08:30 < luke-jr> having them in separate files would just be needlessly confusing to readers IMO
08:32 < sdaftuar> so i don't have editorial rights to the headers?
08:33 < luke-jr> "The BIP editors monitor BIP changes, and update BIP headers as appropriate."
08:34 < luke-jr> I don't see why you would want to make the headers inaccurate anyway
08:34 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev     
08:34 < sdaftuar> i think bip 123 is misguided, in its naive labeling of consensus changes as soft forks or hard forks
08:34 < sdaftuar> bip 90 demonstrates this
08:35 < sdaftuar> did you not see the quote i pasted from bip 123's author?
08:35 < sdaftuar> i think that quote reflects a view held by many
08:35 -!- ProfMac [~ProfMac@67-198-113-220.static.grandenetworks.net] has quit [Quit: Leaving]     
08:35 < luke-jr> this is a complaint that should have been brought up before BIP 123 was activated, or a new Process BIP to revise/change it
08:35 < luke-jr> bbiab
08:37 < provoostenator> I see it's Gitian o'clock?
08:39 < achow101> hmm, did I screw up my gitian build? The files produced are 0.15.99 not 0.16
08:40 < sdaftuar> luke-jr: it seems to me that BIP123's activation should have required agreement from the BIP-authors that it was applied to
08:40 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 248 seconds]     
08:41 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
08:43 < BlueMatt> has anyone ever seen a case when compiling qt where flags arent being passed through when compiling the qt stuff properly?
08:44 < BlueMatt> eg I get "No such slot" on all the slots that are inside #ifdef ENABLE_WALLET in bitcoingui.h, and some icons/images arent being compiled in (eg QImage::scaled: Image is a null image) properly
08:44 < BlueMatt> obviously wiped ccache/git clean'd
08:44 < BlueMatt> maybe cfields has some autotools-debug tips?
08:45 < cfields> BlueMatt: you forget the include, maybe?
08:46 < cfields> (config/bitcoin-config.h)
08:46 < BlueMatt> this is 0.15.1, no modifications
08:47 < cfields> BlueMatt: i'm not sure what you mean. You get "no such slot" at runtime, or build time?
08:47 < BlueMatt> runtime
08:48 < BlueMatt> and like cant click the top tabs to switch views cause of missing slot
08:49 < provoostenator> The Debian installer link in the instructions is broken, beacuse there's no more iso-cd path. Which one should I use? http://cdimage.debian.org/mirror/cdimage/archive/8.9.0/amd64/
08:49 < cfields> BlueMatt: sounds like --disable-wallet :)
08:49 < BlueMatt> nope, not --disable-wallet, and configure output lists wallet enabled
08:49 < BlueMatt> i mean also the image on the splash screen somehow didnt get compiled in so the background is blank
08:50 < cfields> BlueMatt: no clue. Sounds like maybe something didn't get regenerated when you switched tags/branches ?
08:50 < cfields> nm, i see you cleaned
08:51 < BlueMatt> full git directory wipe, re-autogen/configure, even wiped ccache
08:51 < BlueMatt> its even in a vm that just got rebooted
08:51 < BlueMatt> sooooo....wat
08:51 < cfields> achow101: bitcoin-0.16.0-osx-unsigned.dmg
08:51 < provoostenator> Looks like they got rid of iso images for the 8.9.0 release. 9.2.1 still has them. I'll try if that produces the same build and make a PR.
08:51 < achow101> cfields: I fucked up
08:52 < cfields> BlueMatt: you've verified that the ENABLE_WALLET stuff is actually being built?
08:53 < BlueMatt> it loads the wallet, lists transactions, shows a balance, etc
08:53 < BlueMatt> sooo...yes?
08:53 < cfields> BlueMatt: oh (prepare for possible red herring), kinda sounds like a define is missing when the forms are built
08:54 < BlueMatt> thats what I'm thinking, kinda, but i know almost nothing about qt/autotools
08:54 < BlueMatt> so I have a #ifndef ENABLE_WALLET #error in bitcoingui.h, but I dont know if its being compiled or if qt is doing some C++ parsing?
08:54 < BlueMatt> only change was upgrading packages....is it possible qt is now mis-parsing the .h?
08:55 < cfields> was qt itself updated?
08:56 < BlueMatt> i believe so, yes
08:56 < provoostenator> I wasnt' the first ot notice: https://github.com/bitcoin-core/docs/pull/6
08:56 < cfields> BlueMatt: all qt-generated files are bound to the versions that created them
08:56 < cfields> so moc 1.2.3 will create headers meant to be linked against qt headers/libs v1.2.3
08:57 < BlueMatt> git clean -f -x -d'd :p
08:57 < cfields> provoostenator: thanks :)
08:57 < BlueMatt> uh huh, yes, so moc-qt5 is now broken for us - in normal compile the #ifdef ENABLE_WALLETs are being ignored, if I remove the ifdefs things work (eg gotoOverviewPage will or wont show up in moc_bitcoingui.cpp)
08:58 < cfields> BlueMatt: the defines are passed along. Somehow for you they're not...
08:58 < achow101> provoostenator: the OS you build on doesn't really matter since the actual build happens within another vm/container
08:58 < achow101> that vm/container will be the same OS for everyone
08:58 -!- Trevor18Ritchie [~Trevor18R@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 240 seconds]     
08:58 < cfields> BlueMatt: https://github.com/bitcoin/bitcoin/blob/master/src/Makefile.qt.include#L455
08:59 < achow101> cfields: my gitian build has this error: https://0bin.net/paste/S+squMjJftoksqm-#HEzfaPoLdoUUf4qz5ZxzMrrbHtdelDjzCYaVCCDHKQs
09:00 < provoostenator> achow101 someone needs to draw a picture of that inception / VM (Virtual Matroesjka) situation
09:00 < BlueMatt> cfields: -DHAVE_CONFIG_H is passed to moc-qt5 (make claims it is, at least), and if I put an ENABLE_WALLET inside the if defined(HAVE_CONFIG_H) it works fine, but somehow bitcoin-config.h isnt getting included
09:01 < cfields> BlueMatt: i wonder if you somehow got messed up by the #include "foo.h" -> #include <foo.h>
09:01 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev     
09:01 < cfields> BlueMatt: out-of-tree ?
09:01 < cfields> ooh, i bet that's it...
09:01 < BlueMatt> in tree
09:02 < BlueMatt> and this is 0.15.1
09:02 < BlueMatt> so pre <foo.h>
09:02 < cfields> BlueMatt: got a stale bitcoin-config.h around somewhere?
09:02 < BlueMatt> i mean clearly qt broke our build, question is if we need to work around it or what
09:02 -!- jb55 [~jb55@d108-172-210-7.bchsia.telus.net] has joined #bitcoin-core-dev     
09:02 < BlueMatt> git clean -f -x -d :p
09:03 < cfields> damn, right, i was banking on you saying "out-of-tree"
09:03 < cfields> achow101: I'm betting you just ran out of mem
09:03 -!- mandric [~mandric@108-228-58-104.lightspeed.cicril.sbcglobal.net] has quit [Ping timeout: 264 seconds]     
09:04 < cfields> achow101: I haven't built linux yet though
09:04 < achow101> cfields: probably. I forgot to allocate more memory to kvm when I did this build
09:04 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has quit [Ping timeout: 276 seconds]     
09:05 < cfields> BlueMatt: i'm not sure what to tell you. Can you give it a shot with 0.16 so we can start there?
09:05 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has joined #bitcoin-core-dev     
09:06 < BlueMatt> yea, I still had the test_bitcoin-qt failure on 16 so i figured bug was the same but didnt actually try to run it
09:06 -!- mandric [~mandric@108-228-58-104.lightspeed.cicril.sbcglobal.net] has joined #bitcoin-core-dev     
09:09 < BlueMatt> yes, same bug
09:09 < BlueMatt> gotoOverviewPage (etc) doesn't show up in src/qt/moc_bitcoingui.cpp post-build
09:09 < cfields> ok     
09:09 < cfields> got a list of updated packages?
09:09 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has quit [Ping timeout: 252 seconds]     
09:10 < BlueMatt> errr....probably, sec
09:10 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has joined #bitcoin-core-dev     
09:11 -!- twistedline_ [~quassel@unaffiliated/twistedline] has joined #bitcoin-core-dev     
09:12 -!- twistedline [~quassel@unaffiliated/twistedline] has quit [Ping timeout: 276 seconds]     
09:13 < BlueMatt> cfields: (roughly, there's a few extras there) http://termbin.com/3zh4
09:13 < BlueMatt> i mean essentially all the things...gcc/boost/qt/etc
09:14 < cfields> BlueMatt: thanks. What distro/version?
09:14 < cfields> I already have a hunch
09:14 < BlueMatt> its an arch vm
09:14 < BlueMatt> so...all rolling release crap
09:15 < cfields> ok     
09:15 < cfields> https://github.com/qt/qtbase/commit/abcf558e49d5e8c20eda14badc30e93e2e9cba32#diff-7680dae0477922e25856c03d1058d2b7
09:15 < cfields> so they've recently switched up their option parsing. I'm wondering if they broke -D somehow
09:16 < cfields> (i realize you said it was parsed, but maybe include handling after that is busted)
09:16 < BlueMatt> no, because BITCOIN_CONFIG_H is clearly being used
09:17 < BlueMatt> so it has to be some include option blowing up
09:17 < BlueMatt> yea     
09:20 -!- promag [~promag@46.50.61.65] has joined #bitcoin-core-dev     
09:24 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has quit [Ping timeout: 246 seconds]     
09:25 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has joined #bitcoin-core-dev     
09:26 < BlueMatt> cfields: did you find anything in qt git?
09:26 < cfields> BlueMatt: still looking, nothing obvious
09:26 < cfields> BlueMatt: can you try a depends build just for a control?
09:26 < BlueMatt> ugh     
09:26 < BlueMatt> I mean I can revert to the older vm image and see what happens
09:27 < cfields> well sure, but it'd be helpful to have good/bad moc side-by-side
09:29 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has quit [Ping timeout: 252 seconds]     
09:30 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has joined #bitcoin-core-dev     
09:33 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
09:35 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 246 seconds]     
09:35 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev     
09:37 < wumpus> I don't get it, feature_uacomment.py is failing on travis, but I can't reproduce it locally
09:37 < wumpus> https://travis-ci.org/bitcoin/bitcoin/jobs/335143070
09:38 < wumpus> "Error: Total length of network version string (285) exceeds maximum length (256). Reduce the number or size of uacomments."
09:40 < sdaftuar> looks like the test is expecting a slightly different error string (286 instead of 285), and that is why the test is failing
09:40 < cfields> heh, 285 != 286
09:40 < cfields> yep     
09:41 < wumpus> but I don't understand where that comes from
09:41 < sdaftuar> yeah me either
09:41 < wumpus> oh maybe 0.16.0 i.s.o 0.16.99
09:41 < wumpus> what a dumb test in that case
09:41 < provoostenator> The guide is very clear until after the Setup Gitian section. After that there's too many options.  https://github.com/bitcoin-core/docs/blob/master/gitian-building.md#getting-and-building-the-inputs
09:42 < sdaftuar> wumpus: ouch
09:42 < provoostenator> " run it with the --setup command" should have a specific example, e.g. assuming Debian. I remember that confused me for hours half a year ago
09:43 < wumpus> sdaftuar: cfields: yep that's it, I'm going to remove the check for a specific number
09:43 < provoostenator> I'll take a snapshot of my VM before doing that...
09:43 < wumpus> can reproduce it locally now, too, I was testing with master
09:43 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 248 seconds]     
09:44 < cfields> wumpus: makes sense. I vaguely remember a conversation about using exit codes rather than testing strings. Guess that didn't pan out.
09:44 < wumpus> well it makes sense that it checks the error message, it just doesn't have to be so specific
09:49 < cfields> BlueMatt: i'm not seeing anything obvious :\
09:50 -!- xabbix [4fb34aa3@gateway/web/freenode/ip.79.179.74.163] has joined #bitcoin-core-dev     
09:58 < bitcoin-git> [bitcoin] laanwj opened pull request #12302: test: Make ua_comment test pass on 0.16.0 (master...2017_01_uacomment_test_fix) https://github.com/bitcoin/bitcoin/pull/12302
09:59 -!- Cecelia13Shanaha [~Cecelia13@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev     
10:00 -!- Randolf [~randolf@96.53.47.42] has quit [Quit: https://www.randolfrichardson.com/]     
10:01 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev     
10:14 -!- promag [~promag@46.50.61.65] has quit [Remote host closed the connection]     
10:18 -!- neha [~narula@tbilisi.csail.mit.edu] has quit [Ping timeout: 240 seconds]     
10:18 -!- Lynet [~slem@2a00:c440:20:dcd:15d0:620e:d553:12ec] has joined #bitcoin-core-dev     
10:18 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
10:19 -!- neha [~narula@tbilisi.csail.mit.edu] has joined #bitcoin-core-dev     
10:20 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has quit [Ping timeout: 265 seconds]     
10:20 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has joined #bitcoin-core-dev     
10:25 -!- DrFeelGood [~DrFeelGoo@unaffiliated/olufunmilayo] has quit [Ping timeout: 240 seconds]     
10:27 -!- Krellan [~Krellan@2601:640:4000:9258:d160:2cb1:ae2e:568b] has quit [Remote host closed the connection]     
10:27 -!- Krellan [~Krellan@2601:640:4000:9258:7c13:1213:d5cd:10d6] has joined #bitcoin-core-dev     
10:32 -!- Krellan [~Krellan@2601:640:4000:9258:7c13:1213:d5cd:10d6] has quit [Ping timeout: 252 seconds]     
10:33 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
10:36 -!- neha [~narula@tbilisi.csail.mit.edu] has quit [Ping timeout: 248 seconds]     
10:36 < arubi> daemon stopped, I mkdir 'wallet/' in datadir, moved all my wallet .dats in there, added a new 'wallet=30_01_28_btc_segwit.dat' line in bitcoin.conf, started the daemon, and the new wallet file with this name was created in the datadir root.  somewhat surprising, I'm able to getwalletinfo for both this new wallet and old wallets that are now in wallet/ using the -rpcwallet= set
10:37 < arubi> oh this is re. 0.16.0rc1
10:38 < arubi> ohh it says 'wallets' in th release notes, but 'wallet/' in the rpc call help.  my bad.  it just created a bunch of new wallets :)
10:38 < bitcoin-git> [bitcoin] laanwj closed pull request #12302: test: Make ua_comment test pass on 0.16.0 (master...2017_01_uacomment_test_fix) https://github.com/bitcoin/bitcoin/pull/12302
10:39 -!- Krellan [~Krellan@2601:640:4000:9258:b401:17bd:e687:fd48] has joined #bitcoin-core-dev     
10:43 -!- neha [~narula@tbilisi.csail.mit.edu] has joined #bitcoin-core-dev     
10:43 < jnewbery> wumpus: I'm happy to open a new PR if you think that's better, but I'm also happy for you to just force push the one-line fix in your PR
10:43 < jnewbery> whichever you prefer
10:43 < wumpus> I'm just tired of this, wanted to quickly fix the test then everyone wants to push their own solution
10:44 -!- jb55 [~jb55@d108-172-210-7.bchsia.telus.net] has quit [Read error: Connection reset by peer]     
10:44 -!- Krellan_ [~Krellan@c-73-223-240-37.hsd1.ca.comcast.net] has joined #bitcoin-core-dev     
10:44 -!- Krellan [~Krellan@2601:640:4000:9258:b401:17bd:e687:fd48] has quit [Ping timeout: 252 seconds]     
10:44 < wumpus> I think a regexp is a good idea for message matching, and could be useful in other cases too in the future where there's data embedded in the message we want to ignore
10:45 < wumpus> but I really don't feel like eternally arguing even about things like this, of course you can solve it in 20 different ways too
10:45 < jnewbery> seems over-engineered for fixing a single case. I think here it just makes sense to match on the substring
10:45 -!- SopaXorzTaker is now known as ^s     
10:46 < jnewbery> Sorry - I seem to have touched a raw nerve
10:46 < jnewbery> It wasn't a NACK, I just think it's neater to update the individual case than change the util function for this one case
10:46 < jnewbery> but if you prefer your way, that obviously also achieves the same
10:46 < wumpus> no, I don't think matching a partial message only is better than ignoring the few characters we don't care about
10:47 < jnewbery> ok, in that case re-open the PR
10:47 < wumpus> I thought about that too but thought this would cover it better
10:48 < sdaftuar> let's merge it and move on... 0.16.0 awais
10:48 < sdaftuar> awaits*
10:48 < jnewbery> many of the test cases match on substring. I agree that regex matching would be better in the general case
10:48 < wumpus> 0.16.0 is not blocked on this, we already tagged rc1
10:49 -!- Krellan_ [~Krellan@c-73-223-240-37.hsd1.ca.comcast.net] has quit [Ping timeout: 248 seconds]     
10:50 -!- flokie [~flokie@unaffiliated/flokie] has quit [Read error: Connection reset by peer]     
10:52 < sdaftuar> fair, but even if we're not immediately blocked on it, i think we make our lives easier by quickly closing out these kinds of minor issues when we can
10:54 < jnewbery> I agree. I'd argue that implementing a minimal fix that only fixes the broken test case is more appropriate than trying to expand the functionality of the test framework, but really either fix is fine.
10:54 < wumpus> yes, sorry for overreacting
10:59 < wumpus> though I don't think it was unreasonable to try to expand the test framework to do something more than it does
10:59 < wumpus> I understand the consensus code for bitcoin is set in stone, but surely the interface for the test framework isn't
11:04 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 240 seconds]     
11:06 -!- Cecelia13Shanaha [~Cecelia13@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 248 seconds]     
11:06 < jnewbery> I agree that the framework can be improved, but I think that can be done in a separate PR from a quick fix to get the tests running again
11:06 < jnewbery> But we don't need to make this a big thing. I can ACK your PR :)
11:08 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev     
11:10 -!- jb55 [~jb55@d108-172-210-7.bchsia.telus.net] has joined #bitcoin-core-dev     
11:17 < provoostenator> "lxc-execute: start.c: lxc_spawn: 1079 Failed to find gateway addresses"
11:18 < provoostenator> Pretty sure I followed this to the T: https://github.com/bitcoin-core/docs/blob/master/gitian-building/gitian-building-setup-gitian-debian.md
11:20 < provoostenator> Ah wait, I shouldn't copy paste those example IP addresses probably. Vaguely remember making that mistake last time.
11:21 < wumpus> oh great now that I pushed something else I cannot reopen the PR anymore
11:21 < wumpus> crap github
11:22 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 265 seconds]     
11:22 < jnewbery> reset to the old commit, push, open PR, reset to the new commit, force push
11:23 < wumpus> some other time
11:23 -!- flokie [~flokie@unaffiliated/flokie] has joined #bitcoin-core-dev     
11:25 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has joined #bitcoin-core-dev     
11:27 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev     
11:29 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Quit: Leaving]     
11:34 < provoostenator> I can't remember where to get the correct values for GITIAN_HOST_IP (the IP of the Debian virtual box?) and LXC_GUEST_IP.
11:35 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev     
11:35 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev     
11:35 < provoostenator> https://botbot.me/freenode/bitcoin-core-dev/2017-02-21/?msg=81301776&page=1
11:37 -!- dcousens [~dcousens@110.140.107.178] has quit [Ping timeout: 256 seconds]     
11:37 -!- wraithm_ [~wraithm@unaffiliated/wraithm] has joined #bitcoin-core-dev     
11:38 -!- dcousens [~dcousens@110.140.52.110] has joined #bitcoin-core-dev     
11:38 -!- wraithm_ [~wraithm@unaffiliated/wraithm] has quit [Client Quit]     
11:38 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 256 seconds]     
11:39 -!- wraithm_ [~wraithm@unaffiliated/wraithm] has joined #bitcoin-core-dev     
11:39 -!- wraithm [~wraithm@unaffiliated/wraithm] has quit [Ping timeout: 252 seconds]     
11:39 -!- wraithm_ [~wraithm@unaffiliated/wraithm] has quit [Client Quit]     
11:39 -!- PaulCapestany [~PaulCapes@ip72-209-228-50.dc.dc.cox.net] has quit [Ping timeout: 240 seconds]     
11:40 -!- wraithm [~wraithm@unaffiliated/wraithm] has joined #bitcoin-core-dev     
11:40 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev     
11:41 -!- wraithm [~wraithm@unaffiliated/wraithm] has quit [Client Quit]     
11:41 -!- mandric [~mandric@108-228-58-104.lightspeed.cicril.sbcglobal.net] has quit [Ping timeout: 268 seconds]     
11:41 -!- wraithm [~wraithm@unaffiliated/wraithm] has joined #bitcoin-core-dev     
11:42 -!- wraithm [~wraithm@unaffiliated/wraithm] has quit [Client Quit]     
11:42 -!- wraithm [~wraithm@unaffiliated/wraithm] has joined #bitcoin-core-dev     
11:44 -!- mandric [~mandric@108-228-58-104.lightspeed.cicril.sbcglobal.net] has joined #bitcoin-core-dev     
11:45 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 240 seconds]     
11:45 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev     
11:45 -!- wraithm_ [~wraithm@unaffiliated/wraithm] has joined #bitcoin-core-dev     
11:46 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev     
11:46 -!- wraithm_ [~wraithm@unaffiliated/wraithm] has quit [Client Quit]     
11:46 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]     
11:46 -!- wraithm [~wraithm@unaffiliated/wraithm] has quit [Ping timeout: 240 seconds]     
11:47 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev     
11:47 -!- PaulCape_ [~PaulCapes@ip72-209-228-50.dc.dc.cox.net] has joined #bitcoin-core-dev     
11:53 < provoostenator> Ah wait, it's more subtle. These instructions use "ifconfig" which isn't installed on Debian by default: https://github.com/bitcoin-core/docs/blob/master/gitian-building/gitian-building-setup-gitian-debian.md#setting-up-debian-for-gitian-building
11:54 < provoostenator> And of course, Linux being Linux, it just silently fails and let the user shoot themselves in the foot
11:54 -!- wraithm [~wraithm@unaffiliated/wraithm] has joined #bitcoin-core-dev     
11:54 < goatpig> does Core use zeromq?
11:55 < achow101> goatpig: yes
11:55 < goatpig> isn't Core under the MIT license?
11:56 < luke-jr> Core *offers* a zeromq service, but "using" it is ill-defined in this case
11:57 < luke-jr> goatpig: yes, and?
11:57 < goatpig> isn't LGPL3 (zmq) incompatible with MIT?
11:57 -!- dcousens [~dcousens@110.140.52.110] has quit [Ping timeout: 240 seconds]     
11:57 < gmaxwell> No, not at all.
11:57 < luke-jr> goatpig: LGPL is Lesser GPL. It specifically allows non-GPL stuff to use it.
11:58 < goatpig> with version of GPL is incompatible with MIT then? AGPL?
11:58 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has quit [Remote host closed the connection]     
11:58 < goatpig> ah that's what got me confused I guess
11:58 -!- dcousens [~dcousens@110.140.52.110] has joined #bitcoin-core-dev     
11:58 < luke-jr> GPL and AGPL are incompatible with non-free software, but still compatible with MIT
11:58 < gmaxwell> Nothing is incompatible with MIT, some things are more restrictive and we prefer to not use them.
11:58 < luke-jr> they're NOT compatible with OpenSSL, however, which is another dependency of ours..
11:59 < gmaxwell> (luke's They is GPL and AGPL)
11:59 < goatpig> so a MIT project can make use a LGPL dependency just fine?
11:59 -!- Ron62Deckow [~Ron62Deck@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev     
11:59 < gmaxwell> Yes.
11:59 < goatpig> ok thanks
11:59 < luke-jr> only thing to keep in mind is, you still need to release source for the dependency per the terms
12:00 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Remote host closed the connection]     
12:00 < goatpig> due noted
12:02 < cfields> yes. We could pull in a gplv3 lib and we'd be fine to distribute it as usual. Problem is that some companies would want to modify that code without publishing it, so it's unlikely that we'd add any dependencies like that
12:02 < cfields> jonasschnelli: ping
12:03 < luke-jr> cfields: well, I think as long as we depend on OpenSSL, the conflict would prevent distribution
12:03 < provoostenator> Still not seeing the br0 interface though.
12:03 < cfields> hmm?
12:05 < gmaxwell> cfields: openssl has a GPL incompatible license (it's advertising clause bsd)
12:06 -!- dcousens [~dcousens@110.140.52.110] has quit [Ping timeout: 240 seconds]     
12:07 -!- dcousens [~dcousens@110.140.52.110] has joined #bitcoin-core-dev     
12:08 < cfields> huh     
12:09 < achow101> in the test framework, how can I make it so that all of the nodes in a test are connected to each other and stay synced together without having to use sync_all?
12:10 < achow101> sync_all is very slow and it would be better if they were properly connected over the p2p network and sending data between themselves
12:12 < provoostenator> Made some progress: https://github.com/bitcoin-core/docs/issues/15
12:13 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 264 seconds]     
12:15 < instagibbs> achow101, they should be connected, sync_all just makes sure that you can order evens from the frame of reference of all the nodes
12:17 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Ping timeout: 246 seconds]     
12:18 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt]     
12:18 < bitcoin-git> [bitcoin] laanwj reopened pull request #12302: test: Make ua_comment test pass on 0.16.0 (master...2017_01_uacomment_test_fix) https://github.com/bitcoin/bitcoin/pull/12302
12:21 -!- ^s is now known as SopaXorzTaker     
12:31 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Quit: Leaving]     
12:34 -!- blueOcean [~blueOcean@249.122.34.95.customer.cdi.no] has joined #bitcoin-core-dev     
12:41 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
12:42 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit]     
12:45 -!- blueOcean [~blueOcean@249.122.34.95.customer.cdi.no] has quit [Quit: Leaving]     
12:47 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
12:49 < provoostenator> lxc-execute: conf.c: setup_rootfs: 1279 failed to mount rootfs
12:55 -!- Randolf [~randolf@24.244.32.226] has joined #bitcoin-core-dev     
12:56 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9cb230905088...f0295becbf3e
12:56 < bitcoin-git> bitcoin/master aac6bce Wladimir J. van der Laan: test: Make ua_comment test pass on 0.16.0...
12:56 < bitcoin-git> bitcoin/master f0295be MarcoFalke: Merge #12302: test: Make ua_comment test pass on 0.16.0...
12:57 -!- LumberCartel [~randolf@24.244.32.204] has joined #bitcoin-core-dev     
12:57 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #12302: test: Make ua_comment test pass on 0.16.0 (master...2017_01_uacomment_test_fix) https://github.com/bitcoin/bitcoin/pull/12302
12:58 < provoostenator> I ended up deleting the file /home/debian/gitian-builder/target-trusty-amd64 and replacing it with a directory, including /proc and /sys subdirs. That at least got me to the next error...
12:59 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
12:59 < provoostenator> lxc-execute: conf.c: setup_pts: 1407 No such file or directory - failed to create '/dev/pts'
13:00 -!- Randolf [~randolf@24.244.32.226] has quit [Ping timeout: 260 seconds]     
13:00 < provoostenator> These are different issues than I ran into half a year ago. I opened some issues on the docs repo. Will try again later. 
13:00 -!- jb55 [~jb55@d108-172-210-7.bchsia.telus.net] has quit [Read error: Connection reset by peer]     
13:01 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
13:01 -!- LumberCartel [~randolf@24.244.32.204] has quit [Ping timeout: 252 seconds]     
13:04 < wumpus> you definitely shouldn't have to replace target-something with a directory
13:04 < wumpus> that file should be auto-generated
13:05 < wumpus> as I understand base-trusty-amd64 is the file that will be created by installing gitian / building the initial image, target-trusty-amd64 should be re-generated on every run of gitian when building something, it's a working copy of the base image
13:10 -!- _203458034582340 [497212bd@gateway/web/freenode/ip.73.114.18.189] has joined #bitcoin-core-dev     
13:11 -!- _203458034582340 [497212bd@gateway/web/freenode/ip.73.114.18.189] has quit [Client Quit]     
13:11 -!- Randolf [~randolf@24.244.32.204] has joined #bitcoin-core-dev     
13:12 -!- Randolf [~randolf@24.244.32.204] has quit [Client Quit]     
13:12 -!- cloaks [~noty@unaffiliated/cloaks] has quit [Ping timeout: 248 seconds]     
13:15 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt]     
13:15 -!- jb55 [~jb55@d108-172-210-7.bchsia.telus.net] has joined #bitcoin-core-dev     
13:15 < provoostenator> Mmm, so maybe something silently failed when creating the base image?
13:16 < provoostenator> Ah I see, that's why it mounting that file.
13:18 -!- cloaks [~noty@unaffiliated/cloaks] has joined #bitcoin-core-dev     
13:19 < provoostenator> I deleted that directory again. Now it seems to be doing a bit more. But I get frequent "init.lxc: failed to mount /dev/shm" error, as well as "sudo: unable to resolve host gitian".
13:20 < wumpus> the sudo resolve warning is harmless
13:22 < provoostenator> Yeah, I think it's actually building now. Hooray!
13:28 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Quit: Leaving.]     
13:34 < bitcoin-git> [bitcoin] jnewbery opened pull request #12304: Backport 12302 (0.16...backport_12302) https://github.com/bitcoin/bitcoin/pull/12304
13:40 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has joined #bitcoin-core-dev     
13:46 < michagogo> Hrm     
13:46 < michagogo> http://paste.ubuntu.com/26491672/
13:46 < MarcoFalke> Anyone with block bit want to kick the markov chain generator https://github.com/bitcoin/bitcoin/pull/11771#issuecomment-361742013
13:46 -!- Ron62Deckow [~Ron62Deck@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 248 seconds]     
13:46 < michagogo> Got a segfault while building
13:46 -!- cloaks [~noty@unaffiliated/cloaks] has quit [Remote host closed the connection]     
13:46 < MarcoFalke> WalterBoles
13:47 -!- cloaks [~noty@unaffiliated/cloaks] has joined #bitcoin-core-dev     
13:48 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-zgxfwtyzquluxewb] has joined #bitcoin-core-dev     
13:51 < MarcoFalke> wumpus: ^
13:52 < wumpus> MarcoFalke: looking
13:53 -!- jb55 [~jb55@d108-172-210-7.bchsia.telus.net] has quit [Ping timeout: 240 seconds]     
13:55 -!- cloaks [~noty@unaffiliated/cloaks] has quit [Ping timeout: 248 seconds]     
13:58 < michagogo> provoostenator: iirc my past experience has been that Ubuntu is much smoother as a host compared to Debian
13:58 < michagogo> I pretty much just followed the gitian readme
13:59 < michagogo> I think at some point I set up a working gitian environment from scratch in a clean VM and put out a video (and ova)
14:01 -!- Neil13Bradtke [~Neil13Bra@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev     
14:02 -!- jb55 [~jb55@184.68.162.218] has joined #bitcoin-core-dev     
14:05 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Remote host closed the connection]     
14:05 < michagogo> WTF? Now it failed somewhere in the Qt build
14:06 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.16: https://github.com/bitcoin/bitcoin/commit/6c2788c7c8d45ac8f38e998c8a9739efdd0b6d18
14:06 < bitcoin-git> bitcoin/0.16 6c2788c Wladimir J. van der Laan: test: Make ua_comment test pass on 0.16.0...
14:08 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev     
14:08 -!- jb55 [~jb55@184.68.162.218] has quit [Ping timeout: 256 seconds]     
14:09 < bitcoin-git> [bitcoin] jamesob opened pull request #12305: Clarify -conf help message to mention datadir path prefix (master...jamesob/conf-flag-path-help) https://github.com/bitcoin/bitcoin/pull/12305
14:13 -!- neha [~narula@tbilisi.csail.mit.edu] has quit [Ping timeout: 240 seconds]     
14:15 -!- neha [~narula@tbilisi.csail.mit.edu] has joined #bitcoin-core-dev     
14:15 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #12304: [qa] 0.16: Backport 12302 (0.16...backport_12302) https://github.com/bitcoin/bitcoin/pull/12304
14:15 < jamesob> wumpus: worth clarifying other path-accepting configuration option help messages, or should I just close the PR?
14:16 < wumpus> jamesob: I don't know, we might want to document it somewhere in one place instead of for each argument separately
14:16 < wumpus> for things like that it helps to at least try to be consistent
14:17 < wumpus> no arguments to bitcoind are relative to the current directory
14:20 < jamesob> yeah, agree. worth a paragraph between Usage and Options, or maybe there's some other place this is already documented?
14:21 < wumpus> I don't think it's documented anywhere, agree that it should be
14:22 -!- jb55 [~jb55@184.68.162.218] has joined #bitcoin-core-dev     
14:24 -!- Neil13Bradtke [~Neil13Bra@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 248 seconds]     
14:34 < bitcoin-git> [bitcoin] axvr opened pull request #12306: Docs: Improvements to UNIX documentation (master...fix-docs) https://github.com/bitcoin/bitcoin/pull/12306
14:40 -!- cloaks [~noty@unaffiliated/cloaks] has joined #bitcoin-core-dev     
14:41 -!- jb55 [~jb55@184.68.162.218] has quit [Ping timeout: 240 seconds]     
14:44 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev     
14:47 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev     
14:49 < sdaftuar> luke-jr: could you explain your "+1" on evoskuil's last comment?  i think i've spent quite a bit of time now on that PR explaining why i find the "soft fork"/"hard fork" language deficient.  
14:49 < sdaftuar> is there something you still don't understand about my view?
14:50 < jamesob> paths like "./bitcoin.conf" are interpreted as being relative to datadir as well; is this behavior we want to retain?
14:54 -!- denis2342 [~denis@x4e37e65c.dyn.telefonica.de] has joined #bitcoin-core-dev     
14:55 < denis2342> hi     
14:55 < denis2342> I just tested bitcoin 0.16.0rc1 on freebsd and it runs fine so far
14:59 -!- ula [~ula@b2b-78-94-11-194.unitymedia.biz] has joined #bitcoin-core-dev     
14:59 -!- Eleanora26Kemmer [~Eleanora2@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev     
15:04 -!- Eleanora26Kemmer [~Eleanora2@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 248 seconds]     
15:04 < promag> ryanofsky: regarding https://github.com/bitcoin/bitcoin/pull/12287/files#r164570542
15:04 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 268 seconds]     
15:05 < promag> so if a block is in the active chain, nChainTx is final?
15:06 < ryanofsky> i think so because if it's been in the active chain, then it's been validated, and nChainTx should be set
15:06 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Ping timeout: 240 seconds]     
15:08 < promag> you say "and remove an existing lock"
15:08 < promag> which one?
15:08 < promag> my point is that cs_main is already held in all callers expect ClientModel::getVerificationProgress
15:09 < promag> and that jonas adds
15:10 < ryanofsky> the lock here could be removed: https://github.com/bitcoin/bitcoin/pull/12287/files#diff-b2bb174788c7409b671c46ccc86034bdR1681
15:10 < promag> but I agree that less locks is better
15:10 < gmaxwell> Correct software is better. :)
15:11 -!- Lynet_ [~slem@2a00:c440:20:dcd:15d0:620e:d553:12ec] has joined #bitcoin-core-dev     
15:12 -!- Lynet [~slem@2a00:c440:20:dcd:15d0:620e:d553:12ec] has quit [Read error: Connection reset by peer]     
15:12 < promag> right, in this case only comment per se doesn't prevent problems
15:13 -!- Guest66433 [~james@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds]     
15:13 -!- jamesob [~jamesob@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Ping timeout: 248 seconds]     
15:13 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]     
15:13 < promag> for instance, in that case ryanofsky, I would lock from https://github.com/bitcoin/bitcoin/pull/12287/files#diff-b2bb174788c7409b671c46ccc86034bdR1678 to L1690
15:14 < promag> ah sorry maybe that's not possible, because of ShowProgress 
15:14 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 252 seconds]     
15:15 < ryanofsky> actually seems like there is another unnecessary lock below that
15:17 < promag> how about avoid duplicate calls to GuessVerificationProgress(chainParams.TxData(), pindex) ?
15:17 < promag> just do it once where the lock exists and use that value?
15:18 < promag> right after pindex = chainActive.Next(pindex); on the loop end
15:18 < promag> and also before the loop starts
15:20 < ryanofsky> probably something like that is fine. the whole function is a mess, there's a bunch of unnecessary nesting and immediate unlocking/relocking
15:20 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev     
15:21 < Dizzle> sipa
15:22 < Dizzle> Sorry, miss-typed.
15:22 < luke-jr> sdaftuar: deficient or not, it's the language currently used for the Layer header..
15:22 < gmaxwell> Then the layer header should be removed.
15:23 < gmaxwell> It has very little value at best, and clearly is just resulting in needless arguments.
15:23 < luke-jr> I don't agree that it's deficient. It is working fine in this case as well.
15:23 < luke-jr> I don't understand why people are desperate to deny the reality that BIP 90 is a hardfork.
15:24 < gmaxwell> luke-jr: you're acting inappropriately, your ability to update documents shouldn't be used as a lever to advance arguments you want to make.
15:24 < luke-jr> …     
15:25 < gmaxwell> So you disagree about some description stuff, fine. But editing the documents to fit your world view when other people, particularly the authors of the document disagree isn't kosher.
15:25 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 248 seconds]     
15:25 < luke-jr> it's a change proposed nearly 2 years ago and implemented at least many months ago, without any dispute until this week, not used to advance any arguments at all, and in any case completely objective
15:25 < gmaxwell> The end result will only be that other people will simply walk away from the mechenism.
15:26 < gmaxwell> It's clearly not completely objective, because the decription doesn't fit the conventional definition of a hardfork.
15:26 < luke-jr> the documents are not edited, only the preamble header
15:26 < luke-jr> it does
15:26 < gmaxwell> You can argue that, but not via special privledges to edit the repository.
15:27 < luke-jr> unless you're trying to push a redefinition of hardfork, which is not the fault of a change made a long time ago
15:27 < gmaxwell> I didn't notice that you stuck a hardfork label on BIP 90 until today.
15:28 < gmaxwell> Had I noticed it I would have disagreed at any point, and you should have known that because voskuil tried arguing that on the mailing list previously and almost everyone disagreed with him.
15:28 < luke-jr> the whole reason it was made a BIP at all, was because it was a hardfork..
15:29 < gmaxwell> That is not true.
15:29 < luke-jr> then why would there be a BIP?
15:29 < gmaxwell> because there is a BIP for any protocol change with potential interoperability implications... even just documentary ones.
15:30 < luke-jr> if it is a protocol change, it is a hardfork by definition
15:30 < gmaxwell> And there has never been a hardfork performed via a BIP.
15:30 < luke-jr> the only way to argue it isn't a hardfork, is to argue that it isn't a protocol change
15:30 < gmaxwell> you are now arguing that all changes to the protocol are hardforks?
15:31 < luke-jr> no     
15:31 < gmaxwell> so segwit is a hardfork? p2sh is a hardfork?
15:31 < gmaxwell> Fee filter.. hardfork?
15:31 < gmaxwell> compact blocks hardfork
15:31 < luke-jr> Segwit and P2SH constrain the protocol, they don't loosen it
15:31 < gmaxwell> BIP32 ... totally hardfork there.
15:31 < luke-jr> Fee filter and compact blocks aren't protocol changes at all
15:31 < gmaxwell> 15:28:57 < luke-jr> the whole reason it was made a BIP at all, was because it  was a hardfork..
15:31 < gmaxwell> 15:29:35 < luke-jr> then why would there be a BIP?
15:32 < luke-jr> as a protocol change, BIP 90 loosens the rules, and is therefore a hardfork. if it is not a protocol change, then it is an implementation detail that doesn't need standardization
15:33 < luke-jr> there is no reason for standardization of this kind of change, except if we see it as a protocol change
15:33 < gmaxwell> BIP 90 doesn't losen the rules.  It changes implementation details about things burried in the past, what in the past is in the past. If there were some other chain they would possibly accept that something else would reject then there would be a distinction there. But there isn't.
15:33 < gmaxwell> it's like arguing that jtimon's changes to not validate the genesis block were a hardfork.
15:34 < luke-jr> if it's an implementation detail, then there's nothing to standardize
15:34 < gmaxwell> it turns "hardfork" into some jibberish technical defintion that doesn't map usefully to system behavior,  which serves no productive goal other than making it so that only you can decide what is and isn't one.
15:35 < gmaxwell> luke-jr: Things aren't so black and white, most of BIP90 had been done for something like a year before the BIP was written. But it's better to communicate more instead of less.
15:35 < luke-jr> where's the grey? I don't see it in this case.
15:35 < gmaxwell> Writing documentation doesn't turn something into a hardfork that had existed for a long time.
15:35 -!- denis2342 [~denis@x4e37e65c.dyn.telefonica.de] has quit [Quit: denis2342]     
15:36 < gmaxwell> luke-jr: BIP90 can't fork off nodes in any plausable situation; thats not even grey: it's not a hardfork in any meaningful sense.
15:36 < luke-jr> maybe the Layer header should just be deleted for BIP 90 (seeing as it's optional and not always applicable)
15:37 < gmaxwell> That would be an okay way to handle a dispute, I think.
15:37 < gmaxwell> The BIP describes itself, I think accurately and in detail.
15:37 < luke-jr> well, the description in the BIP is clearly a hardfork, IMO
15:38 < gmaxwell> Lets not create bad incentives for people to describe things using anything less than the most conservative language.
15:39 < luke-jr> it's a header. there is no incentive..
15:39 < gmaxwell> esp since bips can pretty much say whatever nonsense they want already.
15:39 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev     
15:39 < gmaxwell> Sure there is, it's an incentive to not be as conservative (e.g. spelling out any possible way anyone could call it a hardfork, and als possible risks) if its going to result in a misleading header.
15:39 < BlueMatt> can we just define a new term here
15:39 < luke-jr> is there some context I'm missing? to me, it looks like someone just up and randomly decided to whine about the layer header
15:40 < BlueMatt> call it "Buried Fork"
15:40 < BlueMatt> or something
15:40 < BlueMatt> then no one has to be upset
15:40 -!- denis2342 [~denis@x4e37e65c.dyn.telefonica.de] has joined #bitcoin-core-dev     
15:40 < gmaxwell>   The word fork should probably not be used, because there is no fork.
15:40 < gmaxwell> there is no split in consensus state.
15:41 < gmaxwell> "Silver spoon" :P
15:42 < luke-jr> it's essentially the same thing as adding/removing checkpoints
15:42 < gmaxwell> I think I agree with that, which we also never have BIPed.
15:42 < BlueMatt> "Buried Spoon"
15:42 < BlueMatt> that seems appropriate
15:43 < gmaxwell> we talked about this when the bip was written and thought there was technically no need to BIP it, but more documentation is better than less.
15:44 < gmaxwell> I think thats a good practice, but this showing up as some "hardfork enforce by core devs" crap would be a profound disincentive to ever do that again.
15:44 < contrapumpkin> (a BIP on the need for the layer header in BIPs?)
15:45 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer]     
15:48 < jtimon> luke-jr: of course it's good to make bip90 or sdaftuar's pr whether they're hfs, sfs or none of that. I honestly don't care if bip90 is a hf or not, it's still a good thing and should  be documented in a bip. I don't think it's good to edit bips without the author's permission unless it's for typos or tiny things
15:48 < jtimon> BlueMatt: I like more "Buried deployment", but bikeshedding...
15:48 < contrapumpkin> jtimon: it seems he got disconnected
15:49 < gmaxwell> Buried deployment sounds okay to me.
15:49 < jtimon> ops, yeah
15:49 -!- mrannanay [uid222022@gateway/web/irccloud.com/x-weraelzmleiyprzt] has quit [Quit: Connection closed for inactivity]     
15:49 < promag> ryanofsky https://github.com/promag/bitcoin/commit/74022f56f733cf0ce3c156e9432e275413dff96c
15:49 < gmaxwell> well I think a general editoral principle is that you can be liberal with changes that no one complaints about, and conservative with things that cause a fuss.
15:50 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev     
15:50 < promag> sorry ryanofsky, force push https://github.com/promag/bitcoin/commit/6e36821823b498c307787543ad59b9e9ccffcc63
15:51 -!- wraithm [~wraithm@unaffiliated/wraithm] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]     
15:54 < jtimon> yeah, nobody will ever complain for a typo being corrected
15:55 < luke-jr> if we're looking at BIP90-like changes as implementation details, then it should probably go in a Core-specific doc repo rather than BIPs since it isn't a coordinated thing
15:55 < luke-jr> (I read the IRC log to catch up)
15:55 < luke-jr> having a Core-specific place for implementation detail documentation would encourage more documentation of Core-specific stuff too
15:55 < luke-jr> ?     
15:56 < jtimon> luke-jr: it's not core specific, everybody is welcomed to do bip90 too
15:57 < gmaxwell> you can look at as as we did the analysis to determine that this was an okay thing to do and are publishing the details. 
15:58 < jtimon> was bip39 whatever-wallet-implemented-it-first-specific?
15:59 -!- Allison19Schinne [~Allison19@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev     
16:00 -!- vicenteH [~user@35.233.15.37.dynamic.jazztel.es] has quit [Ping timeout: 256 seconds]     
16:01 < jtimon> btw, iirc libbitcoin implemented bip90 as an option despite the complains
16:02 < jtimon> I don't think the option is very interesting (since the result will always be the same unless very bad things happen, just to further note is not bitcoin core specific)
16:03 -!- moctost [~moctost@173.244.200.116] has quit [Ping timeout: 256 seconds]     
16:03 < michagogo> Hm, does anyone have any idea why my gitian build is crashing?
16:06 < michagogo> http://paste.ubuntu.com/26492234/
16:07 < michagogo> (tail -n10000 build.log)
16:08 -!- Allison19Schinne [~Allison19@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 260 seconds]     
16:08 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 252 seconds]     
16:16 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
16:18 < MarcoFalke> Just noting that the 0.16 gh branch is not "protecte" like the other branches...
16:20 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev     
16:21 -!- finkan [~finkan@194-103-214-178.kund.ipswe.com] has joined #bitcoin-core-dev     
16:28 -!- jojeyh [~delphi@99-59-126-62.lightspeed.irvnca.sbcglobal.net] has joined #bitcoin-core-dev     
16:28 -!- PaulCape_ [~PaulCapes@ip72-209-228-50.dc.dc.cox.net] has quit [Ping timeout: 268 seconds]     
16:36 -!- PaulCapestany [~PaulCapes@ip72-209-228-50.dc.dc.cox.net] has joined #bitcoin-core-dev     
16:39 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Ping timeout: 268 seconds]     
16:41 < MarcoFalke> s/protecte/protected/
16:50 -!- kallewoof [~karl@fp96f94c66.tkyc515.ap.nuro.jp] has quit [Read error: Connection reset by peer]     
16:50 -!- ProfMac [~ProfMac@2001:470:b8ac:0:9538:7370:a104:11ba] has joined #bitcoin-core-dev     
16:51 -!- kallewoof [~karl@240d:1a:759:6000:a7b1:451a:8874:e1ac] has joined #bitcoin-core-dev     
16:53 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Quit: WeeChat 1.9.1]     
16:58 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev     
16:58 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Client Quit]     
16:59 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev     
17:01 -!- Dizzle [~dizzle@108.171.182.16] has quit [Quit: Leaving...]     
17:01 -!- Camryn27Rolfson [~Camryn27R@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev     
17:03 -!- finkan [~finkan@194-103-214-178.kund.ipswe.com] has quit [Read error: Connection reset by peer]     
17:04 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has joined #bitcoin-core-dev     
17:05 -!- jojeyh [~delphi@99-59-126-62.lightspeed.irvnca.sbcglobal.net] has quit [Ping timeout: 240 seconds]     
17:07 -!- jojeyh [~delphi@99-59-126-62.lightspeed.irvnca.sbcglobal.net] has joined #bitcoin-core-dev     
17:08 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Read error: Connection reset by peer]     
17:15 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
17:18 < achow101> Uhh, so it seems like sendtoaddress can sometimes make an invalid/non-standard transaction.. Or maybe my coin selection code somehow messes with that
17:19 < achow101> I'm very confused now
17:19 -!- bear_ [68e191c0@gateway/web/freenode/ip.104.225.145.192] has quit [Quit: Page closed]     
17:19 < gmaxwell> invalid in what way?!?!?!?!???!??!?!?!?
17:19 < achow101> 64: non-mandatory-script-verify-flag (Signature must be zero for failed CHECK(MULTI)SIG operation)
17:20 < achow101> that's the error I get when I try to sendrawtransaction with it
17:20 < achow101> basically what I was doing was sendtoaddress, then gettransaction, then sendrawtransaction the hex
17:20 < achow101> and then that error happened
17:32 -!- jamesob [~jamesob@pool-71-183-54-211.nycmny.fios.verizon.net] has joined #bitcoin-core-dev     
17:37 -!- james [~james@pool-71-183-54-211.nycmny.fios.verizon.net] has joined #bitcoin-core-dev     
17:37 -!- james is now known as Guest13391     
17:37 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 240 seconds]     
17:39 < achow101> so AFAICT that error means that the signature is being produced incorrectly
17:42 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
17:42 < arubi> so there is a signature in the script \ witness at all?  are you signing something malformed?
17:45 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev     
17:47 -!- jojeyh [~delphi@99-59-126-62.lightspeed.irvnca.sbcglobal.net] has quit [Ping timeout: 256 seconds]     
17:47 < achow101> There's a signature
17:48 < achow101> the transaction _looks_ right, besides the fact that I can't mentally verify signatures
17:48 < arubi> signrawtransaction along with the utxo in json should give a more verbose error about what's wrong
17:50 < arubi> unless it's really all it is and the signature is invalid for the tx..  that's pretty scary
17:52 -!- Camryn27Rolfson [~Camryn27R@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 240 seconds]     
17:59 -!- Rowena86Larkin [~Rowena86L@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev     
17:59 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]     
18:00 -!- denis2342 [~denis@x4e37e65c.dyn.telefonica.de] has quit [Quit: denis2342]     
18:08 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 248 seconds]     
18:08 -!- droark [~droark@c-24-22-123-27.hsd1.or.comcast.net] has quit [Ping timeout: 240 seconds]     
18:15 < achow101> hmm. It looks like there's a signature hash mis-calculation
18:15 < achow101> the signer signed one sighash but a different sighash was calculated when verifying before the send
18:15 < achow101> I've only observed this on segwit, so I think this may actually be a blocker for 0.16
18:20 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
18:20 < arubi> can you tell which of the hashes is the correct one?
18:20 -!- jamesob [~jamesob@pool-71-183-54-211.nycmny.fios.verizon.net] has quit [Remote host closed the connection]     
18:20 -!- jamesob [~jamesob@pool-71-183-54-211.nycmny.fios.verizon.net] has joined #bitcoin-core-dev     
18:24 < achow101> https://github.com/bitcoin/bitcoin/issues/12307
18:27 < arubi> oh cool
18:29 < arubi> achow101, can you paste the payment to this tx please?
18:29 < achow101> what do you mean "payment to"?
18:29 < achow101> Like the input txs?
18:30 < kallewoof> I'd like to see the raw tx hex as well
18:30 < arubi> right, to know the amounts
18:30 < kallewoof> oops it's there nvm
18:30 < arubi> the raw hex for the spend is in the issue, but I wanna see what the sighash is supposed to be
18:31 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #bitcoin-core-dev     
18:32 < arubi> oh it does show the amount for the failed one nValue=4.68120500 , probably stopped because it's the first one
18:32 < arubi> ah no it's the output
18:33 < achow101> there's a lot of inputs...
18:33 < achow101> I can drop the wallet file instead and you can go find the transactions yourself
18:33 < arubi> sounds good
18:35 < achow101> updated the issue
18:35 < arubi> cheers
18:38 -!- Tyth4n [325c56a1@gateway/web/freenode/ip.50.92.86.161] has joined #bitcoin-core-dev     
18:39 -!- To7 [~theo@68.129.242.238] has quit [Quit: Whatever ... bye]     
18:47 -!- Tyth4n [325c56a1@gateway/web/freenode/ip.50.92.86.161] has quit [Ping timeout: 260 seconds]     
18:49 -!- cdecker [~cdecker@mail.snyke.net] has quit [Ping timeout: 248 seconds]     
18:49 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.]     
18:50 -!- cdecker [~cdecker@mail.snyke.net] has joined #bitcoin-core-dev     
18:52 < kallewoof> newbie question but how would you dump the wallet info from that? :]
18:52 < arubi> I'm getting ba89d6d01bdfd4b611757e38802c5a09255659ae7d2d42ae3f0729e7f261de1f as sighash for the first input..
18:53 < arubi> (not 0.16)
18:53 -!- droark [~droark@c-24-22-123-27.hsd1.or.comcast.net] has joined #bitcoin-core-dev     
18:53 < arubi> kallewoof, you can 'gettransaction' for the txids in the inputs to the one posted
18:54 < arubi> pretty much only need the amounts from there
18:54 < kallewoof> Oh.. I tried listunspent but it was empty. Thanks
18:56 < kallewoof> I'm getting Invalid or non-wallet transaction id. I'm just starting a regtest instance with -datadir set to one containing that wallet.dat file, though.
18:57 < achow101> You have to use 0.16 or mater
18:57 < achow101> *master
18:58 < achow101> arubi: that's what the verifier got. it's just byteswapped
18:58 < kallewoof> This is master.. (well, as of jan 24)
18:58 < arubi> ah!     
18:59 < achow101> usual byteswap stuff
18:59 < achow101> kallewoof: really? It should be in the wallet
18:59 < achow101> use decoderawtransaction on the tx hex and then fetch the input tx with gettransaction
19:00 < arubi> I'm running this on pre-0.16 on regtest too
19:00 < kallewoof> dumpwallet gave me a ton of stuff, but yeah. I did decoderaw and tried to gettx the first input (cf0996c1b356bf7df7ef81d65c6741d5db6058826be47842ab45e18afd36dd03)
19:01 < arubi> should work.  sure you're using gettransaction and not getrawtransaction?
19:01 < achow101> arubi: if you're using a version of master after september or som ething it should be fine
19:01 < kallewoof> Yes, I'm using gettransaction.
19:02 < achow101> strange
19:02 < arubi> I'm using jl2012's latest bip114 client (vault branch)
19:03 < arubi> ah, it's from september
19:03 < cfields> achow101: regtest?
19:03 < achow101> cfields: yes. from the test framework (which is what my simulator does)
19:03 < achow101> s/does/uses
19:04 < cfields> achow101: we'll need your chain data :)
19:04 < achow101> oh, duh
19:05 < achow101> cfields: updated in the issue
19:06 < kallewoof> Doh. I put wallet.dat in datadir/ not datadir/regtest/wallets/. Works now.
19:15 < achow101> oh shit. I fucked up my coin selection stuff
19:15 < achow101> that's the problem, the amount is wrong
19:18 < arubi> phew :)
19:22 -!- echeveria [~echeveria@2604:a880:2:d0::28:f001] has quit [Ping timeout: 255 seconds]     
19:23 -!- TD-Linux [~Thomas@about/essy/indecisive/TD-Linux] has quit [Ping timeout: 255 seconds]     
19:23 -!- windsok [~windsok@unaffiliated/windsok] has quit [Ping timeout: 255 seconds]     
19:23 -!- ProfMac [~ProfMac@2001:470:b8ac:0:9538:7370:a104:11ba] has quit [Ping timeout: 240 seconds]     
19:24 < achow101> I guess this is why I shouldn't suppress exceptions :/
19:24 -!- echeveria [~echeveria@2604:a880:2:d0::28:f001] has joined #bitcoin-core-dev     
19:24 -!- TD-Linux [~Thomas@about/essy/indecisive/TD-Linux] has joined #bitcoin-core-dev     
19:25 -!- windsok [~windsok@unaffiliated/windsok] has joined #bitcoin-core-dev     
19:25 -!- ProfMac [~ProfMac@2001:470:b8ac:0:9538:7370:a104:11ba] has joined #bitcoin-core-dev     
19:28 -!- goatpig [56f75164@gateway/web/freenode/ip.86.247.81.100] has quit [Quit: Page closed]     
19:34 -!- victor__ [55e56b9c@gateway/web/freenode/ip.85.229.107.156] has joined #bitcoin-core-dev     
19:35 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has quit [Quit: WeeChat 1.9]     
19:36 -!- victor__ [55e56b9c@gateway/web/freenode/ip.85.229.107.156] has quit [Client Quit]     
19:48 -!- denis2342 [~denis@x4e37e65c.dyn.telefonica.de] has joined #bitcoin-core-dev     
19:48 -!- denis2342 [~denis@x4e37e65c.dyn.telefonica.de] has quit [Client Quit]     
19:54 -!- jojeyh [~delphi@2602:306:b8b6:b970:c8f4:db93:c916:7f70] has joined #bitcoin-core-dev     
20:03 -!- moctost [~moctost@209.95.51.99] has joined #bitcoin-core-dev     
20:04 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has joined #bitcoin-core-dev     
20:04 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev     
20:07 -!- wxss [~user@43.249.39.215] has quit [Quit: leaving]     
20:20 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has quit [Ping timeout: 240 seconds]     
20:24 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has joined #bitcoin-core-dev     
20:24 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 264 seconds]     
20:27 -!- jamesob [~jamesob@pool-71-183-54-211.nycmny.fios.verizon.net] has quit [Ping timeout: 260 seconds]     
20:28 -!- Guest13391 [~james@pool-71-183-54-211.nycmny.fios.verizon.net] has quit [Ping timeout: 268 seconds]     
20:30 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-tabzikfxyccszbso] has joined #bitcoin-core-dev     
20:31 -!- checksauce [~checksauc@184.82.29.177] has joined #bitcoin-core-dev     
20:33 -!- checksauce [~checksauc@184.82.29.177] has quit [Remote host closed the connection]     
20:33 -!- checksauce [~checksauc@184.82.29.177] has joined #bitcoin-core-dev     
20:34 -!- checksau_ [~checksauc@s91904426.blix.com] has joined #bitcoin-core-dev     
20:37 -!- checksauce [~checksauc@184.82.29.177] has quit [Ping timeout: 240 seconds]     
20:38 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has quit [Quit: WeeChat 1.9]     
20:42 -!- Lynet_ [~slem@2a00:c440:20:dcd:15d0:620e:d553:12ec] has quit [Ping timeout: 240 seconds]     
20:43 -!- unholymachine [~quassel@2601:8c:c003:9f16:a8e9:9441:247c:1190] has quit [Remote host closed the connection]     
20:54 -!- mrannanay [uid222022@gateway/web/irccloud.com/x-bdndlgalaazbcviu] has joined #bitcoin-core-dev     
21:01 -!- Rowena86Larkin [~Rowena86L@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 248 seconds]     
21:05 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 255 seconds]     
21:06 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev     
21:10 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection]     
21:10 -!- arubi_ [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev     
21:13 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Ping timeout: 268 seconds]     
21:14 -!- arubi_ [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection]     
21:15 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev     
21:21 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev     
21:22 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 248 seconds]     
21:30 -!- flokie [~flokie@unaffiliated/flokie] has quit [Quit: Leaving]     
21:30 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has quit [Remote host closed the connection]     
21:45 -!- checksau_ [~checksauc@s91904426.blix.com] has quit [Remote host closed the connection]     
21:55 -!- aruns__ [~indistylo@119.82.105.106] has joined #bitcoin-core-dev     
21:56 -!- indistylo [~indistylo@119.82.105.106] has joined #bitcoin-core-dev     
21:57 -!- aruns [~indistylo@27.59.37.152] has joined #bitcoin-core-dev     
21:59 -!- Lauriane29Rolfso [~Lauriane2@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev     
22:00 -!- aruns__ [~indistylo@119.82.105.106] has quit [Ping timeout: 240 seconds]     
22:01 -!- aruns__ [~indistylo@27.59.37.152] has joined #bitcoin-core-dev     
22:01 -!- indistylo [~indistylo@119.82.105.106] has quit [Ping timeout: 260 seconds]     
22:21 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 255 seconds]     
22:21 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev     
22:21 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev     
22:40 -!- Lauriane29Rolfso [~Lauriane2@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 240 seconds]     
22:43 -!- Krellan [~Krellan@c-73-223-240-37.hsd1.ca.comcast.net] has joined #bitcoin-core-dev     
22:44 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev     
22:47 < michagogo> Dammit. The compiler just keeps segfaulting, somewhere else every time
22:47 < gmaxwell> memtest86 time
22:47 -!- Krellan [~Krellan@c-73-223-240-37.hsd1.ca.comcast.net] has quit [Ping timeout: 265 seconds]     
22:47 < michagogo> D:     
22:48 < michagogo> Hm, I wonder if shutting down the VM and starting it again might help
22:56 < michagogo> gmaxwell: (on the physical machine, right? Or can running it in the VM also be relevant?)
22:59 -!- Charles26Aufderh [~Charles26@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev     
23:03 < kallewoof> michagogo: i get that if I don't bump the RAM of the VM. esp if i use -j with make.
23:03 < michagogo> I thought about that
23:04 -!- Charles26Aufderh [~Charles26@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 248 seconds]     
23:04 < michagogo> Took it down from -j5 to -j3, and had htop open
23:04 < michagogo> I don’t think it reached 3GB
23:04 < michagogo> (The VM has almost 6)
23:06 -!- Krellan [~Krellan@2601:640:4000:9258:b1ae:609a:d8f0:384d] has joined #bitcoin-core-dev     
23:06 -!- Krellan [~Krellan@2601:640:4000:9258:b1ae:609a:d8f0:384d] has quit [Remote host closed the connection]     
23:07 -!- Krellan [~Krellan@2601:640:4000:9258:198e:d0a0:9a01:8279] has joined #bitcoin-core-dev     
23:08 -!- indistylo [~indistylo@27.59.37.152] has joined #bitcoin-core-dev     
23:08 -!- aruns [~indistylo@27.59.37.152] has quit [Ping timeout: 264 seconds]     
23:08 -!- aruns__ [~indistylo@27.59.37.152] has quit [Ping timeout: 240 seconds]     
23:08 -!- aruns [~indistylo@27.59.37.152] has joined #bitcoin-core-dev     
23:15 -!- aruns [~indistylo@27.59.37.152] has quit [Remote host closed the connection]     
23:15 -!- aruns [~indistylo@27.59.37.152] has joined #bitcoin-core-dev     
23:15 -!- aruns__ [~indistylo@27.59.37.152] has joined #bitcoin-core-dev     
23:15 -!- indistylo [~indistylo@27.59.37.152] has quit [Read error: Connection reset by peer]     
23:18 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev     
23:20 -!- aruns__ [~indistylo@27.59.37.152] has quit [Remote host closed the connection]     
23:20 -!- indistylo [~indistylo@27.59.37.152] has joined #bitcoin-core-dev     
23:35 -!- jtimon [~quassel@41.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds]     
23:37 -!- arowser [~quassel@106.120.101.38] has joined #bitcoin-core-dev     
23:44 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-zgxfwtyzquluxewb] has quit [Quit: Connection closed for inactivity]     
23:54 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
23:56 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
23:59 -!- Ivory52Hartmann [~Ivory52Ha@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev