--- Day changed Tue Feb 06 2018 00:01 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-aedijhhoyodqthwo] has joined #bitcoin-core-dev 00:09 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has quit [Ping timeout: 255 seconds] 00:24 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 256 seconds] 00:26 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 00:30 -!- pgupta [~pgupta@host81-142-58-249.in-addr.btopenworld.com] has joined #bitcoin-core-dev 00:32 -!- pgupta [~pgupta@host81-142-58-249.in-addr.btopenworld.com] has quit [Remote host closed the connection] 00:34 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Quit: WeeChat 1.9.1] 00:35 -!- Aliencorpse [~Aliencorp@2605:a601:b024:600:2406:738d:9065:9a84] has quit [Ping timeout: 252 seconds] 00:36 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 00:41 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 00:44 -!- Aliencorpse [~Aliencorp@2605:a601:b024:600:d40e:fd5b:7049:eac7] has joined #bitcoin-core-dev 00:45 -!- pgupta [~pgupta@176.12.107.132] has joined #bitcoin-core-dev 00:51 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection] 00:52 -!- pgupta [~pgupta@176.12.107.132] has quit [] 00:52 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 00:52 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 00:53 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 01:02 -!- Krellan_ [~Krellan@c-73-223-240-37.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 01:02 -!- Krellan [~Krellan@2601:640:4000:9258:a03c:dd10:e681:c1d] has quit [Read error: Connection reset by peer] 01:06 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 01:07 -!- zautomata [~zautomata@unaffiliated/zautomata] has quit [Ping timeout: 248 seconds] 01:08 -!- Pavle [~pavle_@unaffiliated/pavle/x-4679000] has joined #bitcoin-core-dev 01:12 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 01:12 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 01:13 < promag> wumpus: is this updated https://github.com/bitcoin/bitcoin/pulls?utf8=%E2%9C%93&q=is%3Aopen+project%3Abitcoin%2Fbitcoin%2F8+ ? 01:13 < promag> which is/are more important? 01:14 < promag> #10740 is wip, not sure if it should be in that list 01:14 < gribble> https://github.com/bitcoin/bitcoin/issues/10740 | [WIP] [wallet] dynamic loading/unloading of wallets by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub 01:21 -!- Krellan_ [~Krellan@c-73-223-240-37.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds] 01:23 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:24 -!- timothy [tredaelli@redhat/timothy] has quit [Client Quit] 01:25 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:26 -!- berndj [~berndj@mail.azna.co.za] has quit [Quit: ZNC - http://znc.in] 01:27 -!- Krellan [~Krellan@2601:640:4000:9258:a03c:dd10:e681:c1d] has joined #bitcoin-core-dev 01:30 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection] 01:37 < wumpus> promag: no, that hasn't been updated for weeks, as the 0.16 milestone was effectively 'high priority for review', so we'll want to go over it next meeting and determine what still belongs there and what not 01:38 < wumpus> I agree it's somewhat strange to have a WIP there 01:40 -!- whphhg_ [~whphhg@unaffiliated/whphhg] has joined #bitcoin-core-dev 01:40 -!- whphhg [~whphhg@unaffiliated/whphhg] has quit [Read error: Connection reset by peer] 01:40 < promag> are we done regarding feature freeze? 01:41 -!- whphhg_ is now known as whphhg 01:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:47 < wumpus> yes, 0.16 is forked off 01:47 < wumpus> so we can merge new features into master, if they're ready 01:57 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [] 02:00 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 255 seconds] 02:04 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 02:06 < bitcoin-git> [bitcoin] laanwj closed pull request #12359: Update license year range to 2018 (master...master) https://github.com/bitcoin/bitcoin/pull/12359 02:07 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 02:08 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 02:09 < gmaxwell> wumpus: assuming no other issues come up do you think we'll release RC2 as final (now that we know that qt assert is not new and really fringe) or do you think we'd do an RC3 for that alone? 02:11 -!- berndj [~berndj@mail.azna.co.za] has joined #bitcoin-core-dev 02:11 < wumpus> gmaxwell: as it's only a crash on shutdown and happens only in certain circumstances, I'd say we shouldn't hold up the release just for that 02:12 < gmaxwell> thats my view. it's an assert and it looks like it requires lucky timing and a shutdown when started with reindex. 02:12 < wumpus> right, an assertion fail, not even a proper 'crash' 02:15 -!- Pavle [~pavle_@unaffiliated/pavle/x-4679000] has quit [Quit: Leaving] 02:19 < gmaxwell> anyone else see a bunch of connections from 23.92.36.0/24 ? 02:19 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 02:19 < Sentineo> let me check 02:20 -!- dabura667 [~dabura667@122x212x155x26.ap122.ftth.ucom.ne.jp] has joined #bitcoin-core-dev 02:21 < Sentineo> gmaxwell: yes, 5 02:22 < Sentineo> but I see it from tor and all bitcoinj:0.14.5 02:22 -!- dabura667 [~dabura667@122x212x155x26.ap122.ftth.ucom.ne.jp] has quit [Read error: Connection reset by peer] 02:22 -!- dabura667 [~dabura667@122x212x155x26.ap122.ftth.ucom.ne.jp] has joined #bitcoin-core-dev 02:23 < esotericnonsense> same 02:23 -!- dabura667 [~dabura667@122x212x155x26.ap122.ftth.ucom.ne.jp] has quit [Read error: Connection reset by peer] 02:23 < esotericnonsense> i also have 5 02:24 -!- LeMiner2 [LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has joined #bitcoin-core-dev 02:24 < gmaxwell> Sentineo: what do you mean 'from tor'? 02:24 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 02:25 < wumpus> connections from tor hs would come from 127.0.0.1 02:26 < esotericnonsense> i also seem to have a ton of spy nodes or something odd like that lately 02:26 * wumpus keeps typing listpeers instead of getpeerinfo now, argh 02:26 -!- LeMiner [LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has quit [Ping timeout: 248 seconds] 02:26 -!- LeMiner2 is now known as LeMiner 02:27 < esotericnonsense> actually perhaps not, i think i'm actually getting inbound peers where before i'd only get like 10 :op 02:27 < wumpus> gmaxwell: yes, five here on two nodes checked 02:30 < wumpus> a .2 .51 .62 .52 .59 b .2 .54 .57 .59. .61 02:32 < Sentineo> ah true for tor wumpus, but I do see the local address as 127.0.0.1:8333 for all of them. 02:32 < Sentineo> so that is why I thought tor, but yeh it would come through tor socks ... 02:34 < gmaxwell> wumpus: interesting, different hosts than I see too. 02:34 < esotericnonsense> i have 2, 51, 44, 42, 41 02:34 < Sentineo> not sure why some connections show for addrlocal my public IP, some show 127.0.0.1:8333 and some the ipv6 one. 02:34 < esotericnonsense> https://esotericnonsense.com/ peers tab 02:35 < gmaxwell> anyone see any outside of 23.92.36/24 but inside 23.92.32/20 ? 02:36 < Sentineo> nope 02:36 < Sentineo> http://node.ispol.sk/#!/overview - just the /24 02:36 < wumpus> nope, all .36 02:37 < gmaxwell> I think this is the first time I've added a subnet to my banlist. 02:37 < Sentineo> 34,32,2,30,29 02:41 < rabidus> .2, .56, .58, .59, .60 02:45 < gmaxwell> Updated my banlists: 02:45 < gmaxwell> https://people.xiph.org/~greg/banlist.cli.txt 02:45 < gmaxwell> https://people.xiph.org/~greg/banlist.gui.txt 02:48 < rabidus> entered those, 5 new ip address were banned 02:48 < gmaxwell> rabidus: you mean 5 got disconnected as a result of loading those? 02:49 < rabidus> yep 02:49 < rabidus> i used your list ~6 months ago 02:49 < gmaxwell> ::nods:: 02:50 < wumpus> esotericnonsense: just curious, what features prevent json rpc 2.0 from working? 02:51 < Sentineo> is there a list for ipv6 gmaxwell ? 02:53 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 02:53 -!- nehan [~nehan@18.85.34.189] has quit [Ping timeout: 256 seconds] 02:54 < wumpus> ipv6 nodes could be included in this list, there just aren't any in it at the moment 02:54 -!- nehan [~nehan@nemesis.media.mit.edu] has joined #bitcoin-core-dev 02:55 < gmaxwell> I don't run v6 nodes currently, so I can't gather data on them. 02:56 < wumpus> fwiw I have one node on ipv6 02:56 < esotericnonsense> wumpus: i believe it's the client being strict about the spec 02:56 < esotericnonsense> wumpus: see http://www.jsonrpc.org/specification#response_object 02:57 < esotericnonsense> jsonrpc: A String specifying the version of the JSON-RPC protocol. MUST be exactly "2.0". 02:57 < wumpus> esotericnonsense: sure, ok, but do you know what *specifically* it fails on 02:57 < wumpus> oh simply the version number 02:57 < esotericnonsense> there are other bits in the spec that are REQUIRED but at least in the core dev docs they're not REQUIRED (for the requests at least if not the responses) 02:57 < esotericnonsense> but I know that the developer docs are often outdated 02:57 < wumpus> can you try to lolpatch that to 2.0 and see if it works? 02:58 < esotericnonsense> it doesn't even respond with jsonrpc 02:58 -!- zautomata [~zautomata@41.232.222.118] has joined #bitcoin-core-dev 02:58 < esotericnonsense> i.e. it's not jsonrpc 1.0, it's just not there :P 02:58 -!- zautomata [~zautomata@41.232.222.118] has quit [Changing host] 02:58 -!- zautomata [~zautomata@unaffiliated/zautomata] has joined #bitcoin-core-dev 02:58 < esotericnonsense> i can yeah but not immediately (a lolhack I suppose would be to reply with whatever was in the request :P) 02:58 < wumpus> we pretty much do 2.0, there might be some small things missing 02:59 -!- Krellan [~Krellan@2601:640:4000:9258:a03c:dd10:e681:c1d] has quit [Ping timeout: 260 seconds] 03:00 < wumpus> for example features such as batching are 2.0 afaik 03:02 -!- shaowei [~textual@218.30.116.183] has joined #bitcoin-core-dev 03:03 < esotericnonsense> indeed 03:03 * esotericnonsense now has coffee which was the important bit before trying to rpc2.0ise it 03:05 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 03:07 -!- Emcy_ [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 248 seconds] 03:11 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-aedijhhoyodqthwo] has quit [Quit: Connection closed for inactivity] 03:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 264 seconds] 03:15 -!- Krellan [~Krellan@2601:640:4000:9258:a03c:dd10:e681:c1d] has joined #bitcoin-core-dev 03:15 -!- Pavle [~pavle_@unaffiliated/pavle/x-4679000] has joined #bitcoin-core-dev 03:20 -!- booyah_ [~bb@193.25.1.157] has joined #bitcoin-core-dev 03:20 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer] 03:21 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2a30e67d20f7...eaeaa2d0b4e8 03:21 < bitcoin-git> bitcoin/master c887f87 Clem Taylor: Extend #11583 to include the most common message generated by non-contributing peers (port scanners?)... 03:21 < bitcoin-git> bitcoin/master eaeaa2d Wladimir J. van der Laan: Merge #12342: Extend #11583 to include "version handshake timeout" message... 03:21 < esotericnonsense> wumpus: nah that doesn't work. from looking at the code above (github link) it's clear why 03:21 < esotericnonsense> it interprets the spec very literally. we send error: null when it wants the error field to not exist if there's a result 03:22 < esotericnonsense> from memory i think we might also send result: null when the error is non-null 03:22 < bitcoin-git> [bitcoin] laanwj closed pull request #12342: Extend #11583 to include "version handshake timeout" message (master...master) https://github.com/bitcoin/bitcoin/pull/12342 03:22 * esotericnonsense tries hacking error to not exist ... 03:22 < wumpus> in the long run we should move toward compliance with the spec, maybe first a command line option (for backwards compatiblity) 03:23 < esotericnonsense> yes that works 03:24 < esotericnonsense> lolpatch required to make it work in this specific instance: https://0bin.net/paste/d4-gThuaT2e1ZRk7#rsIjxU2jNyfmuWZHDaM76BRiVYOE723m7sP5vzVILEt 03:24 -!- Krellan [~Krellan@2601:640:4000:9258:a03c:dd10:e681:c1d] has quit [Ping timeout: 260 seconds] 03:24 < esotericnonsense> i agree, you'd need to track the client version though 03:24 -!- Krellan [~Krellan@2601:640:4000:9258:a03c:dd10:e681:c1d] has joined #bitcoin-core-dev 03:26 < esotericnonsense> it would have to be a commandline option because I think it would make sense to enforce the restrictions on the client at the same time 03:26 < wumpus> I mean to moving to strict json rpc 2.0 only, and keep the hack-1.0 compatibility as a command line option for the forseeable future for backwards compatiblity 03:27 < esotericnonsense> ah sure 03:27 < esotericnonsense> that might be something I could look at in the next few weeks :) 03:28 < wumpus> the way it is now is pretty much a historical mistake, but as a lot of software is written against our peculiar json-rpc dialect we can't and shouldn't completely drop it, but having a spec-compliant mode would be great 03:30 < wumpus> awesome 03:31 -!- whphhg [~whphhg@unaffiliated/whphhg] has quit [Quit: Leaving] 03:31 < wumpus> btcd has this option: --rpcquirks Mirror some JSON-RPC quirks of Bitcoin Core -- NOTE: Discouraged unless interoperability issues need to be worked around -- O dpm 03:32 < wumpus> I don't know what it exactly changes 03:32 -!- whphhg [~whphhg@unaffiliated/whphhg] has joined #bitcoin-core-dev 03:33 < esotericnonsense> the JSONRPCReplyObj function seems to encapsulate all the problems if you could assume the client is jsonrpc 2.0 03:34 < wumpus> ok 03:34 < esotericnonsense> on the response side at least 03:35 < esotericnonsense> i guess it's less important to be strict about what clients send you, but then you don't want to later have a 'really really jsonrpc2.0' flag 03:35 < wumpus> right might be that bitcoin-cli needs changes as well 03:35 < esotericnonsense> :P 03:35 < esotericnonsense> yes\ 03:35 < wumpus> haha no 03:36 * esotericnonsense wonders if bitcoind-ncurses would explode if the server were compliant 03:37 * esotericnonsense smashes himself in the face with a hammer after remembering how he handles rpc in general 03:40 -!- wxss [~user@80.179.42.10.forward.012.net.il] has joined #bitcoin-core-dev 03:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:49 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/eaeaa2d0b4e8...9a32114626fc 03:49 < bitcoin-git> bitcoin/master d3a185a Wladimir J. van der Laan: net: Move misbehaving logging to net logging category... 03:49 < bitcoin-git> bitcoin/master 9a32114 Wladimir J. van der Laan: Merge #12218: net: Move misbehaving logging to net logging category... 03:49 -!- CubicEarths [~cubiceart@190.140.125.142] has joined #bitcoin-core-dev 03:50 < bitcoin-git> [bitcoin] laanwj closed pull request #12218: net: Move misbehaving logging to net logging category (master...2018_01_misbehaving_logging) https://github.com/bitcoin/bitcoin/pull/12218 03:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds] 03:54 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9a32114626fc...c3451483d283 03:54 < bitcoin-git> bitcoin/master eeeb416 murrayn: Remove suggestion to make cloned repository world-writable for Windows build. 03:54 < bitcoin-git> bitcoin/master c345148 Wladimir J. van der Laan: Merge #12322: Docs: Remove step making cloned repository world-writable for Windows build.... 03:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:55 < bitcoin-git> [bitcoin] laanwj closed pull request #12322: Docs: Remove step making cloned repository world-writable for Windows build. (master...doc_change) https://github.com/bitcoin/bitcoin/pull/12322 03:57 -!- CubicEarths [~cubiceart@190.140.125.142] has quit [Remote host closed the connection] 04:02 -!- shaowei [~textual@218.30.116.183] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 04:08 -!- booyah_ [~bb@193.25.1.157] has quit [Read error: Connection reset by peer] 04:08 -!- booyah_ [~bb@193.25.1.157] has joined #bitcoin-core-dev 04:10 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 04:11 -!- michagogo [uid14316@wikia/Michagogo] has quit [] 04:12 -!- michagogo [uid14316@wikia/Michagogo] has joined #bitcoin-core-dev 04:14 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 240 seconds] 04:19 -!- mrannanay [uid222022@gateway/web/irccloud.com/x-fjwwauxebgrvyxrn] has quit [Quit: Connection closed for inactivity] 04:20 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-lbyebcchafalwrgm] has joined #bitcoin-core-dev 04:23 -!- shaowei [~textual@218.30.116.3] has joined #bitcoin-core-dev 04:24 -!- shaowei [~textual@218.30.116.3] has quit [Read error: Connection reset by peer] 04:25 -!- Pavle [~pavle_@unaffiliated/pavle/x-4679000] has quit [Quit: Leaving] 04:30 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has quit [Ping timeout: 248 seconds] 04:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 04:39 < bitcoin-git> [bitcoin] laanwj closed pull request #12325: Use dynamic_cast for downcasting instead of static_cast. (master...use_dynamic_cast_to_downcast) https://github.com/bitcoin/bitcoin/pull/12325 04:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:43 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 04:45 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 05:03 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 05:04 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Remote host closed the connection] 05:05 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 05:09 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Ping timeout: 240 seconds] 05:18 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 260 seconds] 05:20 -!- shesek [~shesek@94.230.85.140] has joined #bitcoin-core-dev 05:20 -!- shesek [~shesek@94.230.85.140] has quit [Changing host] 05:20 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 05:27 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Ping timeout: 240 seconds] 05:30 -!- CubicEarths [~cubiceart@190.140.125.142] has joined #bitcoin-core-dev 05:30 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 05:35 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds] 05:44 -!- farmerwampum [~farmerwam@173.244.200.121] has quit [Ping timeout: 240 seconds] 05:46 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #bitcoin-core-dev 05:48 -!- Emcy_ [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 05:49 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds] 05:49 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 260 seconds] 05:50 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 05:55 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 06:00 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 06:01 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 06:15 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 248 seconds] 06:15 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 06:17 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds] 06:29 -!- Krellan [~Krellan@2601:640:4000:9258:a03c:dd10:e681:c1d] has quit [Ping timeout: 276 seconds] 06:36 -!- Krellan [~Krellan@2601:640:4000:9258:a03c:dd10:e681:c1d] has joined #bitcoin-core-dev 06:45 -!- Krellan [~Krellan@2601:640:4000:9258:a03c:dd10:e681:c1d] has quit [Ping timeout: 260 seconds] 06:46 < bitcoin-git> [bitcoin] conscott opened pull request #12363: Update README after filename change (master...test-readme-update) https://github.com/bitcoin/bitcoin/pull/12363 06:50 -!- Krellan [~Krellan@2601:640:4000:9258:a03c:dd10:e681:c1d] has joined #bitcoin-core-dev 06:50 -!- shesek [~shesek@141.226.150.209] has joined #bitcoin-core-dev 06:50 -!- shesek [~shesek@141.226.150.209] has quit [Changing host] 06:50 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 06:54 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/c3451483d283...88971352f610 06:54 < bitcoin-git> bitcoin/master faeab66 MarcoFalke: contrib: Replace developer keys with list of pgp fingerprints 06:54 < bitcoin-git> bitcoin/master fabb72b MarcoFalke: contrib: Remove xpired 522739F6 key 06:54 < bitcoin-git> bitcoin/master 8897135 Wladimir J. van der Laan: Merge #11909: contrib: Replace developer keys with list of pgp fingerprints... 06:55 < bitcoin-git> [bitcoin] laanwj closed pull request #11909: contrib: Replace developer keys with list of pgp fingerprints (master...Mf1712-gitianKeysDel) https://github.com/bitcoin/bitcoin/pull/11909 07:14 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/88971352f610...f6cd41d93e12 07:14 < bitcoin-git> bitcoin/master a1e1305 James O'Beirne: Clarify help messages for path args to mention datadir prefix... 07:14 < bitcoin-git> bitcoin/master 5460460 James O'Beirne: Add AbsPathForConfigVal to consolidate datadir prefixing for path args... 07:14 < bitcoin-git> bitcoin/master f6cd41d Wladimir J. van der Laan: Merge #12305: [docs] [refactor] Add help messages for datadir path mangling... 07:15 < bitcoin-git> [bitcoin] laanwj closed pull request #12305: [docs] [refactor] Add help messages for datadir path mangling (master...jamesob/conf-flag-path-help) https://github.com/bitcoin/bitcoin/pull/12305 07:17 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 07:20 -!- Cogito_Ergo_Sum [~Myself@ppp-94-64-157-186.home.otenet.gr] has joined #bitcoin-core-dev 07:20 -!- Cogito_Ergo_Sum [~Myself@ppp-94-64-157-186.home.otenet.gr] has quit [Changing host] 07:20 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev 07:22 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 07:34 -!- sugarpuff [sid92283@gateway/web/irccloud.com/x-ppebztgkyonjqfla] has quit [] 07:34 -!- sugarpuff [sid92283@gateway/web/irccloud.com/x-vgppyqkcymdxpxdz] has joined #bitcoin-core-dev 07:35 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has joined #bitcoin-core-dev 07:40 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-lbyebcchafalwrgm] has quit [Quit: Connection closed for inactivity] 07:48 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 07:48 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Quit: WeeChat 1.9.1] 07:49 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has joined #bitcoin-core-dev 07:50 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 07:52 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev 07:53 -!- Pavle [~pavle_@unaffiliated/pavle/x-4679000] has joined #bitcoin-core-dev 07:53 -!- Dudley [181c0a94@gateway/web/freenode/ip.24.28.10.148] has joined #bitcoin-core-dev 07:54 < ossifrage> Has anyone noticed a reduction in the number of connections with v0.16.x? Normally after ~3ish days of uptime I'd be upto 90 or so peers and with the new version I'm having a hard time keeping 60 connections? 07:54 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 07:55 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 07:57 < Dudley> Should DEFAULT_WALLET_RBF be set to TRUE in wallet.h for version 0.16? 08:02 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 08:03 < Randolf> ossifrage: I wonder if some folks have simply stopped running Bitcoin nodes given the recent downturn in price. Or are you seeing the same number of initial connections as you did before? 08:05 < ossifrage> Randolf, previously I had no problem hitting ~100 connections in a few days and often >120 08:05 < ossifrage> Now I'm only hitting 50-60 08:06 < Randolf> I suppose you've been checking your logs? 08:06 < adiabat> ossifrage: I've also seen a big dropoff in nodes and also network traffic, down 50% or so in the last 2 weeks 08:07 < ossifrage> it could just be fall off in price results in a fall off in the number of nodes 08:08 < Randolf> Markets have been down a lot over the past few weeks (more than two weeks), and so I'm guessing that a number of folks might have chosen to stop running their nodes because of that. I've certainly seen some chatter about that with other cryptocurrencies too from folks getting out while the markets 08:08 < Randolf> drop. 08:09 < Randolf> It could be interesting to find out which countries are seeing the most drops in node runners. 08:09 < Randolf> ...assuming that's what's happening. 08:09 < Randolf> It would also be nice to know whether some major ISPs have actively started blocking Bitcoin node traffic. 08:09 < rabidus> i haven't seen any drop in my node peer count (.fi) 08:10 < Randolf> rabidus: Are you using v0.16? 08:10 < rabidus> ah, sry, no. 08:10 < Randolf> rabidus: It's still good to know that you haven't seen a drop. :) 08:11 < rabidus> hmmm, well now i'm very curious to test that 08:11 * Randolf smiles 08:12 < Randolf> Maybe I'll set up a node too, and let it run for a week. 08:12 < Randolf> ...at least. 08:13 < BlueMatt> I belive #12273 needs an 0.16 tag 08:13 < gribble> https://github.com/bitcoin/bitcoin/issues/12273 | rpc: Add back missing cs_main lock in getrawmempool by MarcoFalke · Pull Request #12273 · bitcoin/bitcoin · GitHub 08:15 < BlueMatt> wumpus: #12337 has two bugs, the first is a regression (so should likely be tagged 0.16, but should be an easy fix), the second is not a regression, though should also be an easy fix so dunno why we shouldnt just fix it 08:15 < gribble> https://github.com/bitcoin/bitcoin/issues/12337 | 0.16 Shutdown assertion · Issue #12337 · bitcoin/bitcoin · GitHub 08:15 < Dudley> Command line options help displays "walletrbf Send transactions with full-RBF opt-in enabled (RPC only, default: 0)" for version 0.16rc2 08:15 < BlueMatt> #12273 is a regression 08:15 < gribble> https://github.com/bitcoin/bitcoin/issues/12273 | rpc: Add back missing cs_main lock in getrawmempool by MarcoFalke · Pull Request #12273 · bitcoin/bitcoin · GitHub 08:16 < wumpus> BlueMatt: we removed the 0.16 tag from 12337, it doesn't warrant doing another r 08:16 < wumpus> rc 08:17 < wumpus> (which I also explained in my post there) 08:17 < BlueMatt> a regression causing a scarry assert on shutdown? 08:17 < wumpus> it's very rare 08:17 < wumpus> and it's only an assert, and only on shutdown 08:17 < BlueMatt> I mean I ran into it like 3 times during testing yesterday 08:17 < BlueMatt> its only rare if you never quit during startup, afaict 08:17 < wumpus> yeah... 08:18 < BlueMatt> (and other stuff probably does merit an rc3, so might as well, imo) 08:19 < wumpus> yes, if an rc3 turns out to be needed we can include the fix 08:20 < BlueMatt> #12273 could be rather annoying for a user who doesnt notice...it probably doesnt itself warrant an rc3 but that + the two bugs in 12337 might 08:20 < gribble> https://github.com/bitcoin/bitcoin/issues/12273 | rpc: Add back missing cs_main lock in getrawmempool by MarcoFalke · Pull Request #12273 · bitcoin/bitcoin · GitHub 08:20 < BlueMatt> and 12362 may by itself warrant one 08:20 < wumpus> 12273 affects more than just the tests? 08:21 < BlueMatt> its a race between eg sendrawtransaction and getrawmempool....someone who does a sendrawtransaction followed by an immediate getrawmempool to...test for something or check fee or something may suddenly start failing 08:21 < BlueMatt> its not exactly critical, especially since it doesnt effect wallet 08:21 < wumpus> right, it seems far-fetched 08:21 -!- Amuza [~Amuza@85.159.207.5] has quit [Ping timeout: 240 seconds] 08:21 < BlueMatt> but its kinda gross 08:22 < wumpus> needs to be fixed but does not warrant another rc 08:22 < BlueMatt> agreed (by itself) 08:22 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 08:23 < wumpus> #12362 is scary though, it's exactly what I was afraid of merging #12266 last minute :/ 08:23 < gribble> https://github.com/bitcoin/bitcoin/issues/12362 | bitcoind hits corrupted double-linked list error when running multiple wallet_multiwallet.py tests in parallel · Issue #12362 · bitcoin/bitcoin · GitHub 08:23 < gribble> https://github.com/bitcoin/bitcoin/issues/12266 | Move scheduler/threadGroup into common-init instead of per-app by TheBlueMatt · Pull Request #12266 · bitcoin/bitcoin · GitHub 08:24 < BlueMatt> yea, its rather surprising to me...something is really sketchy there :( 08:25 < BlueMatt> I mean this is why I wanted a full cycle of testing on all the parallell/background stuff, turns out even that seems like it wasnt enough :( 08:29 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 08:30 < Dudley> Discard my question. I guess default for walletrbf is different for RPC then the GUI 08:31 < wumpus> Dudley: yes 08:32 -!- booyah_ is now known as booyah 08:40 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 248 seconds] 08:42 -!- bizancio [~user@186.86.25.131] has joined #bitcoin-core-dev 08:43 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 08:53 -!- Pavle [~pavle_@unaffiliated/pavle/x-4679000] has quit [Quit: Leaving] 08:56 -!- Krellan [~Krellan@2601:640:4000:9258:a03c:dd10:e681:c1d] has quit [Read error: Connection reset by peer] 08:59 < provoostenator> I'm making a fresh Debian 8 VM for Gitian to see which of the issues that I encountered last week are Debian 9 specific (probably still worth fixing at some point). 08:59 < provoostenator> (for rc3) 09:00 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f6cd41d93e12...5ad320598f06 09:00 < bitcoin-git> bitcoin/master 8a6c62b Conor Scott: [tests] Update README after filename change 09:00 < bitcoin-git> bitcoin/master 5ad3205 Wladimir J. van der Laan: Merge #12363: Update README after filename change... 09:00 -!- Krellan [~Krellan@2601:640:4000:9258:a03c:dd10:e681:c1d] has joined #bitcoin-core-dev 09:01 < bitcoin-git> [bitcoin] laanwj closed pull request #12363: Update README after filename change (master...test-readme-update) https://github.com/bitcoin/bitcoin/pull/12363 09:03 < wumpus> provoostenator: yeah it would help a lot if someone worked through that guide and fixed the things that are no longer correct, it's been too long 09:03 < wumpus> most people who have a working gitian environment dread to touch it again 09:03 < provoostenator> I already left about 10 issues on the docs repo, but I suspect some of it was Debian 9 related. 09:05 < wumpus> ok cool 09:05 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5ad320598f06...1462bde767a1 09:05 < bitcoin-git> bitcoin/master bdb3231 251: Implements a virtual destructor on the BaseRequestHandler class.... 09:05 < bitcoin-git> bitcoin/master 1462bde Wladimir J. van der Laan: Merge #12050: [trivial] Implements a virtual destructor on the BaseRequestHandler class.... 09:06 < provoostenator> I'm also looking at clarifying how to build on the VM, but sign on the host machine. 09:06 < provoostenator> As well as push to github fro the host machine. 09:06 < bitcoin-git> [bitcoin] laanwj closed pull request #12050: [trivial] Implements a virtual destructor on the BaseRequestHandler class. (master...patch/BaseRequestHandler-virtual-dtor) https://github.com/bitcoin/bitcoin/pull/12050 09:07 < provoostenator> I already have a bash script for that, but need to combine that with the existing script (before or after someone converts that to Python). 09:08 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 268 seconds] 09:08 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 09:09 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 09:10 -!- Krellan [~Krellan@2601:640:4000:9258:a03c:dd10:e681:c1d] has quit [Ping timeout: 265 seconds] 09:14 < arubi> provoostenator, I'm successfully building w/ debian 9 as the host VM, here are my notes if it helps https://gist.github.com/fivepiece/4c5cd8733973b9821dba9c9c42958209 09:15 < arubi> it's also possible to set up the bridge stuff using the new `ip` commands, but I wasn't sure if the gitian builder scripts look for ifconfig and friends so I'm also pulling the net-tools package 09:16 < arubi> one plus is that it doesn't require installing an old vmbuilder as root 09:20 -!- Krellan [~Krellan@2601:640:4000:9258:a03c:dd10:e681:c1d] has joined #bitcoin-core-dev 09:27 -!- Dizzle [~dizzle@108.171.182.16] has quit [Quit: Leaving...] 09:28 -!- paracyst [paracyst@unaffiliated/paracyst] has quit [Ping timeout: 256 seconds] 09:29 -!- paracyst_ [paracyst@unaffiliated/paracyst] has joined #bitcoin-core-dev 09:31 -!- Krellan [~Krellan@2601:640:4000:9258:a03c:dd10:e681:c1d] has quit [Ping timeout: 260 seconds] 09:31 -!- spinza [~spin@196.212.164.26] has quit [Ping timeout: 260 seconds] 09:31 -!- Krellan [~Krellan@2601:640:4000:9258:a03c:dd10:e681:c1d] has joined #bitcoin-core-dev 09:34 -!- paracyst_ [paracyst@unaffiliated/paracyst] has quit [Ping timeout: 260 seconds] 09:36 -!- Krellan [~Krellan@2601:640:4000:9258:a03c:dd10:e681:c1d] has quit [Ping timeout: 252 seconds] 09:36 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-gxmsnnishrcslynn] has joined #bitcoin-core-dev 09:41 -!- bizancio [~user@186.86.25.131] has quit [Ping timeout: 240 seconds] 09:43 -!- paracyst [paracyst@unaffiliated/paracyst] has joined #bitcoin-core-dev 09:46 -!- Krellan [~Krellan@2601:640:4000:9258:a03c:dd10:e681:c1d] has joined #bitcoin-core-dev 09:49 -!- Amuza [~Amuza@78.30.18.102] has joined #bitcoin-core-dev 09:55 < BlueMatt> ok, so found the issue in #12362...trying to find minimal patch 09:56 < gribble> https://github.com/bitcoin/bitcoin/issues/12362 | bitcoind hits corrupted double-linked list error when running multiple wallet_multiwallet.py tests in parallel · Issue #12362 · bitcoin/bitcoin · GitHub 09:56 < BlueMatt> wumpus: you still around? you know this code much better than I 09:56 < wumpus> BlueMatt: yes 09:57 < wumpus> (as in still around, not sure about knowing the code better) 09:57 < BlueMatt> issue is simple: HTTPWorkQueueRun starting in a new thread may take longer to get to the queue->Run() call than it takes for us to go through InterruptHTTPServer(); StopHTTPServer() 09:57 < BlueMatt> so the thread will start after the underlying queue has been deleted 09:57 < BlueMatt> resulting in garbage 09:57 < wumpus> looks like we need a lock 09:57 < BlueMatt> prior to the commit to move the threadGroup to interrupt later, the only thing between VerifyWallets() was threadGroup.interrupt_all(), which was enough to keep from seeing this 09:58 < BlueMatt> but once that was removed if VerifyWallets() fails you essentially just immediately call InterruptHTTPServer() and then StopHTTPRPC(), StopREST(), StopRPC() and StopHTTPServer() 09:58 < BlueMatt> so you just get into a simple race there 09:59 < wumpus> yes, so when interrupthttpserver is run, we first need to wait that it is actually running 09:59 < BlueMatt> easy to test for - add a sleep at the top of HTTPWorkQueueRun and run in valgrind 09:59 < BlueMatt> you'll see it immediately 09:59 < BlueMatt> yea, just need to somehow pause until stuff is running 09:59 < BlueMatt> the stupid patch at https://github.com/bitcoin/bitcoin/issues/12362#issuecomment-363503855 apparently works 09:59 < wumpus> also, queue->run shouldn't run if it is already terminated 10:01 < BlueMatt> yea, i think that would be an equivalent fix 10:01 < wumpus> but does this fix the race? 10:02 -!- Krellan [~Krellan@2601:640:4000:9258:a03c:dd10:e681:c1d] has quit [Ping timeout: 276 seconds] 10:02 < wumpus> there's still a small window where threads_running is incrased but queue->run is not yet executed 10:02 < BlueMatt> oh yea I mean its not a sufficient fix 10:02 < BlueMatt> its just a hack for testing 10:02 < wumpus> right 10:03 < BlueMatt> wumpus: do you understand the qt init stuff well enough to fix #12337? (it just needs to have its shutdown match bitcoind - Shutdown() should always get called if AppInitMain() gets called, even if it fails) 10:03 < gribble> https://github.com/bitcoin/bitcoin/issues/12337 | 0.16 Shutdown assertion · Issue #12337 · bitcoin/bitcoin · GitHub 10:04 < BlueMatt> I mean I can do a dirty hack for an rc3 that just does it directly but I dont understand the lifetimes well enough to not break things 10:04 < wumpus> I lost track of the qt init stuff to be honest, I used to understand it, but a lot changed 10:04 < BlueMatt> :( 10:04 < wumpus> oh that part, yes that should be easy 10:04 < wumpus> it's interesting because it used to be exactly the other way around 10:05 < BlueMatt> ok, well I'd propose we do that and just fix the 4 outstanding issues and do an rc3, then 10:05 < BlueMatt> yea, that stuff got confused and bitcoind and qt diverged introducing the bug in 12337 :( 10:05 < wumpus> I think that switched around a few times 10:05 < BlueMatt> well also AppInit got split..... 10:06 < wumpus> that shouldn't change this 10:06 -!- Krellan [~Krellan@2601:640:4000:9258:a03c:dd10:e681:c1d] has joined #bitcoin-core-dev 10:06 < wumpus> the earlier appinits shouldn't require a shutdown 10:06 < wumpus> only the last one 10:06 < BlueMatt> yea, well when there was only one appinit... :p 10:06 < wumpus> as that is what is executed in the daemon process 10:07 < wumpus> the other ones are preparation 10:07 -!- Krellan [~Krellan@2601:640:4000:9258:a03c:dd10:e681:c1d] has quit [Remote host closed the connection] 10:07 < BlueMatt> so one thing we should maybe consider is a test framework that changes shutdownrequested to just start shutdown after being called N times, and then run for all N 0...inf to make sure we handle all these cases well 10:08 < BlueMatt> cause we now have, what, 2 issues that would be caught by a test like that 10:08 < wumpus> yes it definitely needs tests 10:08 -!- spinza [~spin@196.212.164.26] has joined #bitcoin-core-dev 10:08 < wumpus> the initialization sequence and shutdown are really undertested 10:13 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 10:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 10:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:14 < wumpus> so for the queue->Run() I don't understand why interrupting it before the Run is hit is a problem, interrupt should set the stopped flag on the queue, so it should just fall through and exit the thread immediately 10:15 < wumpus> or does deletion (which should happen in ShutdownHTTPServer, not Interrupt) somehow not wait for the threads to have stopped? 10:16 < BlueMatt> wumpus: I do not believe ShutdownHTTPServer does any meaningful waiting, no 10:17 < wumpus> then that is likely the issue, let me see 10:17 < BlueMatt> yea, I dont think Interrupt is the issue, I think its Shutdown 10:17 < wumpus> it does workqueue->WaitExit() 10:17 < wumpus> in Shutdown 10:18 < BlueMatt> yea, but if the thread hasnt joined (ie is still waiting to call numThreads++) then the wait is null 10:18 < ryanofsky> #11625 adds some testing for qt init code, fwiw 10:18 < gribble> https://github.com/bitcoin/bitcoin/issues/11625 | Add BitcoinApplication & RPCConsole tests by ryanofsky · Pull Request #11625 · bitcoin/bitcoin · GitHub 10:19 < wumpus> ah apparently it doesn't actually join the thread objects 10:19 < wumpus> ryanofsky: good! 10:20 < wumpus> the threads are detached and the handle is thrown away 10:20 -!- neha [~narula@tbilisi.csail.mit.edu] has quit [Ping timeout: 248 seconds] 10:20 < BlueMatt> yea 10:21 < wumpus> ok this is easy to solve 10:22 < wumpus> will PR in a minute 10:24 < wumpus> thanks for finding this, I wonder if I introduced this bug or it somehow snuck in when going from boost::thread to std::thread (probably the former) 10:25 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 10:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:28 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds] 10:28 -!- neha [~narula@tbilisi.csail.mit.edu] has joined #bitcoin-core-dev 10:29 < BlueMatt> alright, well I propose we fix all 4 bugs here and then rc3 10:29 < BlueMatt> wait, i may have another.... 10:30 < BlueMatt> yup, ok, 5 bugs 10:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds] 10:32 < bitcoin-git> [bitcoin] laanwj opened pull request #12366: http: Join worker threads before deleting work queue (master...2017_02_httpserver_join) https://github.com/bitcoin/bitcoin/pull/12366 10:34 -!- MrPaz [~PazPazPaz@c-71-57-73-68.hsd1.il.comcast.net] has joined #bitcoin-core-dev 10:36 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:37 < wumpus> as for qt, it seems it's already supposed to call Shutdown() even if AppInitMain() fails, don't know what goes wrong 10:38 < BlueMatt> wumpus: [13:15:15] BlueMatt: i think i might see the issue 10:38 < BlueMatt> [13:16:58] BlueMatt: BitcoinApplication connects requestedShutdown to shutdown(), but SplashScreen connects it to close() 10:38 < BlueMatt> [13:17:32] so it looks like we should re-route that after AppInitMain has started 10:39 < wumpus> a signal can be connected to two handlers, I don't see the problem 10:40 < wumpus> that just makes sure that the splash screen is hidden when the shutdown window is shown 10:40 < BlueMatt> ahh, well I didnt look into it that deeply, but if Shutdown() is called, nThreadsServicingQueue should be pretty clearly 0 10:40 < BlueMatt> as it join()s 10:40 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 10:40 < wumpus> I'm fairly sure that this has always worked, when closing during the splash screen the shutdown window is shown and it waits for proper shutdown 10:41 < wumpus> no idea wtf messed this up... 10:43 < wumpus> so the assertion is triggered after exiting main()? 10:44 < BlueMatt> yes 10:44 < BlueMatt> static-deinit 10:45 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #12367: Fix two fast-shutdown bugs (master...2018-02-wait-genesis-exit) https://github.com/bitcoin/bitcoin/pull/12367 10:46 < BlueMatt> ^ fixes two fast-shutdown bugs, hopefully with really-simple patches 10:46 < MarcoFalke> rc2 is basically rc1 10:46 < MarcoFalke> As we need to give users time to test, there is no downside in rc3 10:47 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has joined #bitcoin-core-dev 10:52 -!- dongcarl [~dongcarl@c-73-189-35-88.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 10:53 < dongcarl> Hi all, I've been trying to get gitian on LXC working to no avail. I'm running into the same issues kallewoof ran into on Dec 1st, 2017. where the error is "sudo: unable to resolve host gitian / cannot set terminal process group (1): Inappropriate ioctl for device / no job control in this shell" 10:53 < dongcarl> I fixed the unable to resolve host error by modifying the /etc/hosts of the base image 10:53 < wumpus> unable to resolve host is harmless at least 10:54 < wumpus> that's just a warning 10:54 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #12368: Hold mempool.cs for the duration of ATMP. (master...2018-02-getrawmempool-race) https://github.com/bitcoin/bitcoin/pull/12368 10:54 < BlueMatt> MarcoFalke: ^ 10:54 < wumpus> never saw the others though 10:55 < dongcarl> wumpus: thanks, it seems like there were case before where this happened as well, e.g. https://github.com/devrandom/gitian-builder/issues/63 10:55 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #12273: rpc: Add back missing cs_main lock in getrawmempool (master...Mf1801-rpcMempoolGetLock) https://github.com/bitcoin/bitcoin/pull/12273 10:56 < dongcarl> What happens with the error is that I get dropped into a root shell, and when I ctrl-d, a loop of "sudo: unknown user: ubuntu" and "sudo: unable to initialize policy plugin" pops up 10:56 < BlueMatt> ok, so #12368 + #12367 + #12366 + the qt bug and then rc3? I think all of those except the last are at least super-trivial patches...and at this rate getting an extra week on testing cycles seems to make sense 10:56 < gribble> https://github.com/bitcoin/bitcoin/issues/12368 | Hold mempool.cs for the duration of ATMP. by TheBlueMatt · Pull Request #12368 · bitcoin/bitcoin · GitHub 10:56 < gribble> https://github.com/bitcoin/bitcoin/issues/12367 | Fix two fast-shutdown bugs by TheBlueMatt · Pull Request #12367 · bitcoin/bitcoin · GitHub 10:56 < gribble> https://github.com/bitcoin/bitcoin/issues/12366 | http: Join worker threads before deleting work queue by laanwj · Pull Request #12366 · bitcoin/bitcoin · GitHub 10:56 * dongcarl waits patiently for a savior 11:04 -!- Amuza [~Amuza@78.30.18.102] has quit [Quit: Leaving] 11:05 -!- neha [~narula@tbilisi.csail.mit.edu] has quit [Ping timeout: 256 seconds] 11:05 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 11:06 -!- neha [~narula@tbilisi.csail.mit.edu] has joined #bitcoin-core-dev 11:06 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 11:13 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 11:15 < wumpus> dongcarl: is that perhaps with debian 9? 11:15 < dongcarl> wumpus: the base image is trusty 11:15 < wumpus> no, I mean the outer VM 11:15 < dongcarl> I'm on Arch right now 11:16 < dongcarl> am I understanding this wrong? I thought there were two layers, my laptop (Arch) and the lxc container (Trusty) 11:16 < wumpus> heh you might be the first that tries running gitian on arch 11:16 < dongcarl> wumpus: yeah I wanted to make a PR on how to workaround the kinks 11:16 < provoostenator> dongcarl: I've only used the Debian VM. Not sure if it's worth maintaining documentation for 2 distros. 11:17 < provoostenator> Although I suppose it would make the scripts more robust. 11:17 < MarcoFalke> provoostenator: We already have it for fedora as well 11:17 < dongcarl> provoostenator: I think it'll be nice if the scripts are distro-agnostic 11:17 < esotericnonsense> bah run debian or whatever in a vm and run the lxc within that. solved. :P 11:17 < dongcarl> yeah 11:17 < wumpus> well iI assumed you were following the gitian-building md, it starts out with debian VM in which the LXC based gitian is run 11:17 < wumpus> it would be nice, but not realistic I think 11:17 < wumpus> we have lots of trouble keeping it working in just debian 11:18 < dongcarl> :-/ 11:18 < provoostenator> I'm getting better at it though, having nuked and rebuilt a Gitian VM half a dozen times now. 11:18 < dongcarl> So I know the zcash people use gitian+vagrant 11:18 < dongcarl> and vagrant is pretty portable across hosts and drivers 11:18 < dongcarl> but that's a whole other thing 11:19 < dongcarl> I think I know where the problem lies... 11:19 < MarcoFalke> Maybe we can get rid of gitian ... 11:19 < sipa> in theory there shouldn't be that much dependece on the outer host 11:19 < sipa> but that's theory... 11:19 < wumpus> hahaha 11:19 < wumpus> in theory 11:19 < MarcoFalke> sipa: The lxc bridge thing usually breaks 11:19 < sipa> the difference between theory and practice is of course that in theory there is nome, but in practice... 11:19 -!- twoken [~twoken@110.177.216.235] has quit [Ping timeout: 248 seconds] 11:20 < wumpus> the lxc setup is quite fragile 11:20 < MarcoFalke> yeah 11:20 < wumpus> maybe it's easier with vagrant or another container hoster, I don't know 11:20 < wumpus> if someone has time to play around with that it'd be appreciated 11:21 < arubi> vagrant requires virtualbox right? 11:21 < dongcarl> arubi: no 11:21 < dongcarl> it can take a lot of drivers 11:21 < wumpus> I thought it was just another user of linux containers, just like lxc and docker 11:21 < arubi> oic 11:21 < arubi> I was using qemu for mine 11:21 < dongcarl> it's orchestration layer on top of multiple drivers, lxc, qemu, etc 11:21 < arubi> oh cool 11:21 < dongcarl> quite easy to write extensions 11:22 < wumpus> that sounds like another layer of complexity 11:22 < dongcarl> wumpus: right, that's why I don't know if people would want vagrant 11:22 < wumpus> the problem is that lxc is hard to set up, so switch to something that is another abstraction layer over multiple kinds of virtualization, just like gitian is already trying to be 11:22 < dongcarl> wumpus: but it's quite well-tested and easy to set up 11:23 < wumpus> gitian as-is can also be used with qemu, lxc or even virtualbox (though no one is doing the latter anymore since Gavin left, I think) 11:23 < arubi> maybe aboriginal linux -> mkroot -> build? :P 11:23 < dongcarl> wumpus: I think the end goal is for gitian to target vagrant, and for vagrant to handle interacting with the drivers 11:23 < dongcarl> which would make gitian work much easier 11:24 < dongcarl> anyways, I'll play around with it and see if it actually delivers 11:24 < dongcarl> (or just makes things more complicated) 11:24 -!- twoken [~twoken@110.177.216.172] has joined #bitcoin-core-dev 11:25 < wumpus> right, that could work I guess 11:25 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has quit [Ping timeout: 248 seconds] 11:26 < dongcarl> quick question: is anyone allowed to submit their gitian sigs or just a limited group of people? 11:27 < sipa> dongcarl: if you plan to regularly dongitian builds foe bitcoin core releases, you're very mufh encouraged to upload your key and do so:) 11:27 < sipa> that n between do and gitian is a typo, i swear! 11:27 < dongcarl> sipa: I'm definitely going to name my PR branch dongitian now ;-) 11:27 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #12349: shutdown: fix crash on shutdown with reindex-chainstate (master...fix-qt-shutdown) https://github.com/bitcoin/bitcoin/pull/12349 11:28 < wumpus> everyone is allowed to submit gitian sigs, the more the better 11:30 < dongcarl> <3 11:32 < wumpus> the only requirement is that you get the build working :) 11:33 < BlueMatt> wumpus: did you have any idea why the qt shit isnt calling Shutdown() reliably or should I try to decipher qt 11:33 < wumpus> no, I have no idea right now 11:33 < BlueMatt> k 11:34 < wumpus> from what I see it should simply work 11:36 -!- jamesob [~jamesob@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #bitcoin-core-dev 11:37 < cfields> BlueMatt: see my last comment on that ticket, I think I'm in the right ballpark 11:37 < BlueMatt> cfields: wumpus indicated that didnt seem likely 11:37 < cfields> though admittedly, I tried a million theories and probably crossed myself up in the process 11:37 < cfields> oh? 11:37 < BlueMatt> lol well I currently cant build qt due to the moc bug, so...ugh 11:37 < jnewbery> wumpus: change looks good. I can't reproduce 12362 with your PR 11:37 < cfields> eh? still? 11:37 < wumpus> cfields had a different theory there, I haven't checked that one 11:38 < wumpus> jnewbery: great! 11:38 -!- finkan [~finkan@194-103-214-178.kund.ipswe.com] has joined #bitcoin-core-dev 11:38 < BlueMatt> cfields: well I never found any resolution to it? moc doesnt build bitcoin-qt right now....no idea why 11:39 < wumpus> cfields: just that the one about re-attaching the signal was not correct, because it's perfectly valid to attach multiple listeners to a signal (or did I misunderstand what you meant?) 11:39 < BlueMatt> cfields: is it just me or is the issue simply that BitcoinCore::initialize() calls initializeResult(false) if AppInitMain() fails, which calls quit() directly instead of calling shutdown() (which would call Interrupt(), Shutdown(), and then shutdownResult() which calls quit())? 11:39 < wumpus> quit() just exits the main loop 11:39 < BlueMatt> yes, but we thus wont call Shutdown(), I think 11:39 < wumpus> after that it starts the shutdown sequence in a new main loop 11:39 < BlueMatt> oh 11:40 < wumpus> after showing the shutdown window 11:40 < BlueMatt> funny because shutdown() will call Interrupt() and then Shutdown() and then quit() 11:40 < wumpus> that should just work, I tested it a zillion times 11:40 < wumpus> yes it calls quit again 11:40 < wumpus> to exit the new mainloop (which handles exiting) 11:40 < BlueMatt> hmm, ok, well I guess I'm just confused 11:45 < wumpus> FWIW it's structured like this because existing the main window will exit the main loop, so we need a new main loop instance to handle the shutdown window while it's shutting down (in the background). There's certainly different ways to do it, but this used to work at least. 11:46 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-gxmsnnishrcslynn] has quit [Quit: Connection closed for inactivity] 11:46 < BlueMatt> well I'll debug moc a bit more and see if I can get that working again 11:47 -!- dcousens [~dcousens@110.140.105.53] has quit [Ping timeout: 240 seconds] 11:47 < cfields> BlueMatt: the problem as i saw it was that quit() is called _both_ by the failed AppInitMain(), as well as when it gets the shutdown signal. 11:48 -!- dcousens [~dcousens@101.188.220.230] has joined #bitcoin-core-dev 11:48 < cfields> I can only defer to wumpus as to whether that's an issue or not. 11:49 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 11:49 < cfields> but yes, in all of my tests, exit does wait on the shutdown procedure to finish. I can't force any other result :\ 11:50 < wumpus> cfields: wait, we don't stop the shutdown poll timer while shutting down? 11:50 < cfields> hmm? 11:50 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 11:50 < wumpus> BitcoinGUI::detectShutdown() 11:51 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Ping timeout: 255 seconds] 11:51 < wumpus> does that run while it's in the second main loop (while the shutdown window is visible)? 11:51 < wumpus> if so it will prematurely end that loop becuase, yes, it's shut down 11:52 < cfields> wumpus: ugh, no clue. I didn't even look at that. 11:52 < wumpus> cfields: I thought that's what you mean with 'when it gets the shutdown signal' 11:53 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds] 11:54 < wumpus> the other one (in shutdownResult) is for *after Shutdown() finished* so that's ok 11:54 < wumpus> and the one in initializeResult() is ok too, it means it goes into the shutdown sequence 11:54 < wumpus> but the timer might create such a weird race issue 11:55 < wumpus> ah, pollShutdownTimer is stopped 11:55 < wumpus> in requestShutdown 11:56 < wumpus> no, that should be ok 11:58 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 12:00 < cfields> wumpus: ah, so the timer sees StartShutdown() and fires requestedShutdown(). I see. I thought that was coming from the close button. So shutdown() isn't an overridden qt function? 12:00 < wumpus> cfields: no :) 12:01 < cfields> heh ok 12:01 < wumpus> shutdown() is just the background thread function that actually calls Interrupt() and Shutdown() 12:02 < wumpus> this is bound to the signal requestedShutdown(), coming from the GUI thread 12:02 < cfields> right. I know we call it, but I thought qt emitted it too as some life-cycle callback 12:02 -!- Pavle [~pavle_@unaffiliated/pavle/x-4679000] has joined #bitcoin-core-dev 12:03 < cfields> yes, I have a much better idea now, thanks 12:04 -!- timothy [tredaelli@redhat/timothy] has quit [Ping timeout: 240 seconds] 12:05 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has joined #bitcoin-core-dev 12:09 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Quit: Leaving...] 12:14 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 12:18 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 12:22 < dongcarl> If anyone has a working LXC Trusty gitian container, could they show me `ls -la /dev/tty*'? 12:30 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 12:30 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has quit [] 12:31 < arubi> dongcarl, are you running a nested lxc then? lxc host and gitian builder lxc inside it? if so fwiw it's not so straight forward 12:35 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 12:38 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 12:40 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 12:40 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 12:42 < arubi> if anybody's up for it, please kill the current running #25110 travis job. it's obsolete a waste to keep folks waiting 12:42 < gribble> https://github.com/bitcoin/bitcoin/issues/25110 | HTTP Error 404: Not Found 12:43 < sipa> do you have URL? 12:43 < arubi> sipa, https://travis-ci.org/bitcoin/bitcoin/builds/338165077 12:44 -!- cheese_ [~Cheeseo@unaffiliated/cheeseo] has quit [Read error: Connection reset by peer] 12:44 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-skbvfnxqrkxnqouz] has joined #bitcoin-core-dev 12:45 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection] 12:47 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-tteedxvlnbciitsy] has joined #bitcoin-core-dev 12:53 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 12:56 < sipa> arubi: done 12:56 < arubi> cheers 13:01 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 13:07 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 265 seconds] 13:13 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has quit [Quit: (https://github.com/mmgen) leaving] 13:18 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 13:21 -!- wunpunch [~Alli@2a02:c7f:282a:6c00:8147:dfb0:8f6a:6c2f] has joined #bitcoin-core-dev 13:23 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 255 seconds] 13:26 -!- finkan [~finkan@194-103-214-178.kund.ipswe.com] has quit [Quit: Leaving] 13:28 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 13:32 < BlueMatt> MarcoFalke: you can just close #12365 its a launchpad security issue that launchpad appears to give 0 fucks about fixing 13:32 < gribble> https://github.com/bitcoin/bitcoin/issues/12365 | Add ppa:bitcoin/bitcoin repository on linux problem · Issue #12365 · bitcoin/bitcoin · GitHub 13:32 < BlueMatt> yay ubuntu dgaf about security, apparently 13:32 < BlueMatt> well, i guess we knew that 13:33 < sipa> dgaf? 13:33 < BlueMatt> dont give a fuck 13:33 < dongcarl> (kids these days) 13:35 < dongcarl> arubi: no, it's just that I've isolated the problem down to the fact that 'sudo lxc-execute -n gitian -f var/lxc.config -- bash' doesn't work 13:35 < dongcarl> it says 'bash: cannot set terminal process group (1): Inappropriate ioctl for device' 13:36 < dongcarl> when i do s/bash/sh/ 13:36 < dongcarl> it says 'sh: 0: can't access tty; job control turned off' 13:36 < dongcarl> so something's wrong with tty somewhere... 13:37 < arubi> I see, sorry, I didn't get this error here 13:37 < dongcarl> I think it's to do with me running a newer version of lxc 13:38 < dongcarl> it complains about the config file being an old format too and I had to look at what key names changed 13:39 < arubi> oh man that sounds like a lot of work once non bleeding edge os's are updated to newer lxc.. 13:39 < dongcarl> arubi: yup, which is why I'm starting now... 13:39 < arubi> good luck 13:39 < dongcarl> <3 13:42 -!- Dudley [181c0a94@gateway/web/freenode/ip.24.28.10.148] has quit [Ping timeout: 260 seconds] 13:47 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds] 14:01 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 14:05 -!- jamesob [~jamesob@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 14:08 -!- Pavle [~pavle_@unaffiliated/pavle/x-4679000] has quit [Quit: Leaving] 14:13 < BlueMatt> cfields: were you ever able to materially reproduce #12337? 14:13 < gribble> https://github.com/bitcoin/bitcoin/issues/12337 | 0.16 Shutdown assertion · Issue #12337 · bitcoin/bitcoin · GitHub 14:13 < cfields> BlueMatt: no :( 14:14 < BlueMatt> you "killed" by just closing window? 14:14 < cfields> BlueMatt: i can confirm that Shutdown() wasn't called though 14:14 < cfields> yep 14:15 < cfields> BlueMatt: I tried all kinds of sleeps/early returns to try to hit it again, but no luck 14:15 -!- rex_4539 [~textual@ppp-2-84-167-103.home.otenet.gr] has quit [Quit: Textual IRC Client: www.textualapp.com] 14:17 < cfields> tail of log: 14:17 < cfields> 2018-02-02 20:39:50 Upgrading utxo-set database... 14:17 < cfields> 2018-02-02 20:39:50 [0%]...[CANCELLED]. 14:17 < cfields> 2018-02-02 20:39:50 Shutdown requested. Exiting 14:19 < bitcoin-git> [bitcoin] akx20000a opened pull request #12371: Add gitian PGP key: akx20000 (master...gitian-key) https://github.com/bitcoin/bitcoin/pull/12371 14:19 < BlueMatt> hmm, k 14:20 < promag> BlueMatt: https://github.com/bitcoin/bitcoin/pull/12368#issuecomment-363584547 14:20 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 14:21 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 14:22 -!- Lynet [~slem@2a00:c440:20:dcd:ade9:3daa:fe6:17d2] has joined #bitcoin-core-dev 14:24 < BlueMatt> promag: the validationinterface background-thread stuff breaks lock-order =D 14:25 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev 14:34 < promag> BlueMatt: got it, forgot about that X) 14:44 -!- rex_4539 [~textual@ppp-2-84-167-103.home.otenet.gr] has joined #bitcoin-core-dev 14:50 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 14:51 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 14:59 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-tteedxvlnbciitsy] has quit [Quit: Connection closed for inactivity] 15:03 -!- dongcarl [~dongcarl@c-73-189-35-88.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds] 15:07 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 15:07 < BlueMatt> ugh, alright cfields I give up :/ at least I found #12372 in the process 15:07 < gribble> https://github.com/bitcoin/bitcoin/issues/12372 | Qt Splash Screen is deleted (and accesses wallet) after Shutdown() (and wallets are deleted). · Issue #12372 · bitcoin/bitcoin · GitHub 15:07 < BlueMatt> hopefully it doesnt show up again in rc3 15:08 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Quit: Leaving...] 15:08 < cfields> heh 15:08 < cfields> BlueMatt: i never saw that one :\ 15:09 < BlueMatt> I have no idea how realistic it is 15:09 < BlueMatt> I was just putting sleeps in the middle of AppInitMain and closing splashscreen 15:13 < cfields> BlueMatt: how long are the sleeps? anywhere near reasonable? 15:16 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 240 seconds] 15:20 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 15:26 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 15:38 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 15:45 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 15:50 -!- vicenteH [~user@35.233.15.37.dynamic.jazztel.es] has quit [Ping timeout: 256 seconds] 15:56 -!- dongcarl [~dongcarl@c-73-189-35-88.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 16:08 < BlueMatt> cfields: just have to be enough time for you to hit "close"...I was using 5sec, but ofc any number works 16:10 -!- dongcarl [~dongcarl@c-73-189-35-88.hsd1.ca.comcast.net] has quit [Quit: leaving] 16:13 -!- ajtowns[m] [ajtownsmat@gateway/shell/matrix.org/x-mbspvdemfojxzppv] has quit [Ping timeout: 256 seconds] 16:13 -!- Masaomi[m] [masaomimat@gateway/shell/matrix.org/x-cxekekbpjsshrffc] has quit [Ping timeout: 255 seconds] 16:13 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-cgieywjopssoizrb] has quit [Ping timeout: 256 seconds] 16:14 -!- herzmeister[m] [herzmeiste@gateway/shell/matrix.org/x-lmprsltdormyivxp] has quit [Ping timeout: 276 seconds] 16:14 -!- ludens[m] [ludensturi@gateway/shell/matrix.org/x-cqiavybravnktolp] has quit [Ping timeout: 276 seconds] 16:14 -!- MrPaz [~PazPazPaz@c-71-57-73-68.hsd1.il.comcast.net] has quit [Ping timeout: 240 seconds] 16:24 -!- wunpunch [~Alli@2a02:c7f:282a:6c00:8147:dfb0:8f6a:6c2f] has quit [Read error: Connection reset by peer] 16:25 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 16:32 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 16:33 -!- echonaut [~echonaut@46.101.192.134] has quit [Remote host closed the connection] 16:33 -!- echonaut1 [~echonaut@46.101.192.134] has joined #bitcoin-core-dev 16:34 -!- droark [~droark@c-24-22-123-27.hsd1.or.comcast.net] has quit [Quit: Later.] 16:35 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 16:44 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-dgogxagqosyeypyt] has joined #bitcoin-core-dev 16:44 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Remote host closed the connection] 16:47 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 16:49 -!- wxss [~user@80.179.42.10.forward.012.net.il] has quit [Quit: leaving] 16:50 -!- n00by_d00by [~n00by_d00@2600:380:9f42:8a76:91eb:3e03:53:4caf] has joined #bitcoin-core-dev 16:53 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has quit [Ping timeout: 240 seconds] 16:53 -!- herzmeister[m] [herzmeiste@gateway/shell/matrix.org/x-adkmrcoyotjndkja] has joined #bitcoin-core-dev 16:53 -!- ajtowns[m] [ajtownsmat@gateway/shell/matrix.org/x-djptcjfzbhofcyty] has joined #bitcoin-core-dev 16:53 -!- Masaomi[m] [masaomimat@gateway/shell/matrix.org/x-fyfnnxtidnktdkec] has joined #bitcoin-core-dev 16:53 -!- ludens[m] [ludensturi@gateway/shell/matrix.org/x-bkuwpkmfqeuqcvcp] has joined #bitcoin-core-dev 16:54 -!- n00by_d00by [~n00by_d00@2600:380:9f42:8a76:91eb:3e03:53:4caf] has quit [Client Quit] 17:00 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev 17:20 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Read error: Connection reset by peer] 17:22 -!- droark [~droark@c-24-22-123-27.hsd1.or.comcast.net] has joined #bitcoin-core-dev 17:34 -!- MrPaz [~PazPazPaz@c-71-57-73-68.hsd1.il.comcast.net] has joined #bitcoin-core-dev 18:01 -!- neha [~narula@tbilisi.csail.mit.edu] has quit [Ping timeout: 256 seconds] 18:02 -!- neha [~narula@tbilisi.csail.mit.edu] has joined #bitcoin-core-dev 18:03 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 264 seconds] 18:06 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 18:11 -!- jamesob [~jamesob@cpe-67-245-233-223.nyc.res.rr.com] has joined #bitcoin-core-dev 18:12 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 255 seconds] 18:51 -!- jamesob [~jamesob@cpe-67-245-233-223.nyc.res.rr.com] has quit [Ping timeout: 255 seconds] 18:54 -!- Masaomi[m] [masaomimat@gateway/shell/matrix.org/x-fyfnnxtidnktdkec] has quit [Ping timeout: 256 seconds] 18:54 -!- herzmeister[m] [herzmeiste@gateway/shell/matrix.org/x-adkmrcoyotjndkja] has quit [Ping timeout: 240 seconds] 18:54 -!- ludens[m] [ludensturi@gateway/shell/matrix.org/x-bkuwpkmfqeuqcvcp] has quit [Ping timeout: 256 seconds] 18:54 -!- ajtowns[m] [ajtownsmat@gateway/shell/matrix.org/x-djptcjfzbhofcyty] has quit [Ping timeout: 240 seconds] 18:55 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 18:55 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-dgogxagqosyeypyt] has quit [Ping timeout: 276 seconds] 18:58 -!- Emcy_ [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 276 seconds] 19:05 < conman> hmm 0.16.0rc2 doesn't like my testnet in a box 19:05 < conman> validation.cpp:4391: void CChainState::CheckBlockIndex(const Consensus::Params&): Assertion `(pindexFirstNeverProcessed != nullptr) == (pindex->nChainTx == 0)' failed. 19:06 < conman> works fine with 0.15.x 19:17 -!- jtimon [~quassel@41.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 268 seconds] 19:27 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 19:32 -!- zautomata1 [~zautomata@41.232.198.60] has joined #bitcoin-core-dev 19:32 < BlueMatt> conman: most likely not a regression.....new defaults - checkblockindex is on by default on testnet now 19:34 -!- zautomata [~zautomata@unaffiliated/zautomata] has quit [Ping timeout: 248 seconds] 19:38 < conman> k 19:38 < conman> it's regtest obviously 19:39 -!- rex_4539 [~textual@ppp-2-84-167-103.home.otenet.gr] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 19:41 -!- MrPaz [~PazPazPaz@c-71-57-73-68.hsd1.il.comcast.net] has quit [Quit: Leaving] 19:42 < BlueMatt> will look into it tomorrow, please file issue 19:43 < BlueMatt> (if there isnt one already) 19:44 < BlueMatt> nvm, 311782 19:44 < BlueMatt> nvm, #11782 19:44 < gribble> https://github.com/bitcoin/bitcoin/issues/11782 | Assertion failure in validation.cpp:4203 (re: pindexFirstNeverProcessed) · Issue #11782 · bitcoin/bitcoin · GitHub 19:44 < BlueMatt> conman: does that match your issue? (due to an upgrade on regtest without a reindex-chainstate) 19:44 -!- neha [~narula@tbilisi.csail.mit.edu] has quit [Ping timeout: 256 seconds] 19:44 < BlueMatt> its a change in network parameters on regtest 19:45 < BlueMatt> also, probably want to release-notes this one! 19:46 -!- neha [~narula@tbilisi.csail.mit.edu] has joined #bitcoin-core-dev 19:48 < conman> looks the same 19:52 < conman> thanks 19:52 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 19:52 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Ping timeout: 260 seconds] 19:57 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 19:58 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 20:21 -!- echonaut1 [~echonaut@46.101.192.134] has quit [Remote host closed the connection] 20:21 -!- echonaut [~echonaut@46.101.192.134] has joined #bitcoin-core-dev 20:24 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-skbvfnxqrkxnqouz] has quit [Quit: Connection closed for inactivity] 20:24 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has joined #bitcoin-core-dev 20:42 -!- hanzou [8818997c@gateway/web/freenode/ip.136.24.153.124] has joined #bitcoin-core-dev 20:45 < hanzou> I notice that getblocks (NetMsgType::GETBLOCKS) seems to be defined but never used, just GETBLOCKTXN and others. 20:49 < hanzou> Well Bitcoin core has code such that a client will respond to getblocks, but it never sends it. 20:49 < hanzou> When did clients stop sending getblocks? 20:50 < sipa> BIP152 20:51 < sipa> between compatible clients, getblocks isn't used anymore as BIP152 (compact blocks) is much more efficient 20:55 < sipa> getblocks is still used while synchronizing old blocks 20:57 -!- jjjkkk [60edeb31@gateway/web/freenode/ip.96.237.235.49] has joined #bitcoin-core-dev 20:58 < jjjkkk> test 20:59 -!- jjjkkk [60edeb31@gateway/web/freenode/ip.96.237.235.49] has quit [Client Quit] 21:12 -!- CubicEarths [~cubiceart@190.140.125.142] has quit [] 21:28 < bitcoin-git> [bitcoin] murrayn opened pull request #12373: Build: Add build support for profiling. (master...profiling) https://github.com/bitcoin/bitcoin/pull/12373 21:28 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 21:30 -!- echonaut [~echonaut@46.101.192.134] has quit [Remote host closed the connection] 21:30 -!- echonaut [~echonaut@46.101.192.134] has joined #bitcoin-core-dev 21:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds] 21:35 -!- echonaut [~echonaut@46.101.192.134] has quit [Remote host closed the connection] 21:36 -!- echonaut [~echonaut@46.101.192.134] has joined #bitcoin-core-dev 21:42 -!- echonaut [~echonaut@46.101.192.134] has quit [Remote host closed the connection] 21:42 -!- echonaut [~echonaut@46.101.192.134] has joined #bitcoin-core-dev 21:51 -!- echonaut [~echonaut@46.101.192.134] has quit [Remote host closed the connection] 21:51 -!- echonaut [~echonaut@46.101.192.134] has joined #bitcoin-core-dev 21:51 -!- dafuq [~dafuq@unaffiliated/dafuq] has left #bitcoin-core-dev ["Leaving"] 21:53 -!- echonaut [~echonaut@46.101.192.134] has quit [Remote host closed the connection] 21:53 -!- echonaut [~echonaut@46.101.192.134] has joined #bitcoin-core-dev 21:54 -!- echonaut [~echonaut@46.101.192.134] has quit [Remote host closed the connection] 21:54 < hanzou> Thanks sipa 21:54 -!- echonaut2 [~echonaut@46.101.192.134] has joined #bitcoin-core-dev 21:56 -!- ajtowns[m] [ajtownsmat@gateway/shell/matrix.org/x-emeuydrgpjmcyxca] has joined #bitcoin-core-dev 21:57 -!- dafuq[m] [~dafuqm]@S01061cabc0b054b3.ok.shawcable.net] has joined #bitcoin-core-dev 21:57 -!- dafuq[m] [~dafuqm]@S01061cabc0b054b3.ok.shawcable.net] has quit [Changing host] 21:57 -!- dafuq[m] [~dafuqm]@unaffiliated/dafuq-m/x-8291849] has joined #bitcoin-core-dev 21:58 -!- murrayn [~murrayn@unaffiliated/murrayn] has joined #bitcoin-core-dev 22:01 -!- ludens[m] [ludensturi@gateway/shell/matrix.org/x-plkfrhjfjlvudqmj] has joined #bitcoin-core-dev 22:15 -!- echonaut2 [~echonaut@46.101.192.134] has quit [Remote host closed the connection] 22:16 -!- echonaut [~echonaut@46.101.192.134] has joined #bitcoin-core-dev 22:19 -!- Masaomi[m] [masaomimat@gateway/shell/matrix.org/x-rzjxgqqgktyhwzva] has joined #bitcoin-core-dev 22:20 -!- baldur [~baldur@pool-100-2-154-254.nycmny.btas.verizon.net] has quit [Ping timeout: 255 seconds] 22:25 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-mofcnckmvviddtrr] has joined #bitcoin-core-dev 22:26 -!- DougieBot5000 [~DougieBot@unaffiliated/dougiebot5000] has joined #bitcoin-core-dev 22:27 -!- herzmeister[m] [herzmeiste@gateway/shell/matrix.org/x-hvqvmndsrfslbzfb] has joined #bitcoin-core-dev 22:33 -!- dongcarl [~dongcarl@c-73-202-219-157.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 22:53 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has joined #bitcoin-core-dev 23:03 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection] 23:04 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 23:20 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection] 23:22 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 23:27 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 23:29 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 23:31 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has joined #bitcoin-core-dev 23:32 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has quit [Ping timeout: 256 seconds] 23:32 -!- ProfMac [~ProfMac@2001:470:b8ac:0:c9c0:48c6:7174:69e6] has quit [Ping timeout: 240 seconds] 23:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 264 seconds] 23:34 -!- Lynet [~slem@2a00:c440:20:dcd:ade9:3daa:fe6:17d2] has quit [Remote host closed the connection] 23:35 -!- rex_4539 [~textual@ppp-2-84-167-103.home.otenet.gr] has joined #bitcoin-core-dev 23:35 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 23:35 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Client Quit] 23:36 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 23:44 -!- ProfMac [~ProfMac@2001:470:b8ac:0:21b4:7d68:3e24:2719] has joined #bitcoin-core-dev 23:48 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has quit [Quit: (https://github.com/mmgen) leaving] 23:49 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has joined #bitcoin-core-dev