--- Day changed Thu Feb 08 2018 00:17 -!- wallet42 [sid154231@gateway/web/irccloud.com/x-ljdcntpujufbrsev] has quit [Read error: Connection reset by peer] 00:18 -!- wallet42 [sid154231@gateway/web/irccloud.com/x-miofczmzbfsqolwz] has joined #bitcoin-core-dev 00:18 -!- hsmiths [uid95325@gateway/web/irccloud.com/x-iwgqkrikrlbgelbk] has quit [Ping timeout: 256 seconds] 00:22 -!- Ruben [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 00:22 < bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/11f3eac79334...6db4fa7ad329 00:22 < bitcoin-git> bitcoin/master b1c2370 Wladimir J. van der Laan: http: Join worker threads before deleting work queue... 00:22 < bitcoin-git> bitcoin/master f946654 Wladimir J. van der Laan: http: Remove WaitExit from WorkQueue... 00:22 < bitcoin-git> bitcoin/master 11e0151 Wladimir J. van der Laan: http: Remove numThreads and ThreadCounter... 00:22 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 240 seconds] 00:23 < bitcoin-git> [bitcoin] laanwj closed pull request #12366: http: Join worker threads before deleting work queue (master...2017_02_httpserver_join) https://github.com/bitcoin/bitcoin/pull/12366 00:25 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to 0.16: https://github.com/bitcoin/bitcoin/compare/f17942a3bc81...da84760701dc 00:25 < bitcoin-git> bitcoin/0.16 d56355a MarcoFalke: 0.16: Check in current release notes draft 00:25 < bitcoin-git> bitcoin/0.16 da84760 Wladimir J. van der Laan: Merge #12380: 0.16: Check in current release notes draft... 00:32 < bitcoin-git> [bitcoin] Willtech opened pull request #12384: Docs: Edited /doc/tor.md (master...tor.md) https://github.com/bitcoin/bitcoin/pull/12384 00:38 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection] 00:39 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 00:40 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/6db4fa7ad329...d57d10ee96a6 00:40 < bitcoin-git> bitcoin/master 85aa839 Matt Corallo: Hold mempool.cs for the duration of ATMP.... 00:40 < bitcoin-git> bitcoin/master 02fc886 Matt Corallo: Add braces to meet code style on line-after-the-one-changed. 00:40 < bitcoin-git> bitcoin/master d57d10e Wladimir J. van der Laan: Merge #12368: Hold mempool.cs for the duration of ATMP.... 00:40 < bitcoin-git> [bitcoin] laanwj closed pull request #12368: Hold mempool.cs for the duration of ATMP. (master...2018-02-getrawmempool-race) https://github.com/bitcoin/bitcoin/pull/12368 00:41 < gmaxwell> FWIW, I've had that stack of patches running for a few hours without issue, plus some restart cycles in valgrind. 00:47 -!- neha [~narula@tbilisi.csail.mit.edu] has quit [Ping timeout: 248 seconds] 00:48 -!- neha [~narula@tbilisi.csail.mit.edu] has joined #bitcoin-core-dev 00:56 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d57d10ee96a6...ab4ee6e69242 00:56 < bitcoin-git> bitcoin/master 45eea40 fivepiece: Bech32 addresses in dumpwallet... 00:56 < bitcoin-git> bitcoin/master ab4ee6e Wladimir J. van der Laan: Merge #12315: Bech32 addresses in dumpwallet... 00:57 < arubi> yay :) 00:57 < bitcoin-git> [bitcoin] laanwj closed pull request #12315: Bech32 addresses in dumpwallet (master...dumpwallet-bech32) https://github.com/bitcoin/bitcoin/pull/12315 00:57 < gmaxwell> okay, that one I didn't test. 01:02 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection] 01:02 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 01:04 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 01:05 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 01:11 < wumpus> yeah, the bech32 dumpwallet one is the one of the bunch that isn't completely straightforward and might require more testing - luckily this will be rc3, not final 01:12 < wumpus> the "address type is whatever there is a label for" part is interesting 01:13 < wumpus> though correct, I think 01:15 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 01:17 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:18 < gmaxwell> the alternative construction would be to emit duplicate lines, one with each address we'd accept. 01:19 < sipa> it's just in a comment anyway 01:19 < wumpus> yes 01:20 -!- timothy [tredaelli@redhat/timothy] has quit [Client Quit] 01:23 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:25 < bitcoin-git> [bitcoin] laanwj pushed 11 new commits to 0.16: https://github.com/bitcoin/bitcoin/compare/da84760701dc...758a41e10045 01:25 < bitcoin-git> bitcoin/0.16 09fc859 Matt Corallo: Fix fast-shutdown hang on ThreadImport+GenesisWait... 01:25 < bitcoin-git> bitcoin/0.16 0f207c4 Matt Corallo: Fix fast-shutdown crash if genesis block was not loaded... 01:25 < bitcoin-git> bitcoin/0.16 604f289 MarcoFalke: qt: Poll ShutdownTimer after init is done... 01:27 -!- go1111111 [go1111111@gateway/vpn/privateinternetaccess/go1111111] has quit [Quit: Leaving] 01:28 -!- drizztbsd [tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:28 -!- timothy [tredaelli@redhat/timothy] has quit [Ping timeout: 276 seconds] 01:29 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:29 -!- rex_4539 [~textual@2a02:587:3508:ad00:c02c:f7a2:3deb:ecde] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 01:30 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:34 -!- Sinclair_ [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has joined #bitcoin-core-dev 01:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 276 seconds] 01:35 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.16: https://github.com/bitcoin/bitcoin/commit/4f63a43f6b0425b4cdd9211283017af375e18c90 01:35 < bitcoin-git> bitcoin/0.16 4f63a43 Wladimir J. van der Laan: qt: Pre-rc3 translations update... 01:35 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-wgvaenvnfgfbbwvz] has joined #bitcoin-core-dev 01:36 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 01:37 -!- Sinclair6 [~sinclair6@108-75-18-87.lightspeed.clmboh.sbcglobal.net] has quit [Ping timeout: 240 seconds] 01:41 -!- checksau_ [~checksauc@182.232.75.221] has quit [Remote host closed the connection] 01:45 -!- Sinclair_ [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has quit [] 01:47 -!- Sinclair6 [~sinclair6@2602:306:c4b1:2570:d8a4:f1d1:f7f8:efda] has joined #bitcoin-core-dev 01:50 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.16: https://github.com/bitcoin/bitcoin/commit/a5e3d44cc8f61f03a94d57302ff8c33c8f8a8689 01:50 < bitcoin-git> bitcoin/0.16 a5e3d44 Wladimir J. van der Laan: doc: Update release notes from wiki (for rc3 PRs)... 01:52 -!- Sinclair6 [~sinclair6@2602:306:c4b1:2570:d8a4:f1d1:f7f8:efda] has quit [Ping timeout: 255 seconds] 01:53 < wumpus> okay, anything I forgot before tagging rc3? 01:53 -!- [Author] [pizzaman@2401:a400:3200:5600:bad:d09:15:90d] has quit [Read error: Connection reset by peer] 01:58 < midnightmagic> YES WAIT.. 01:58 < midnightmagic> j/k 01:59 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 02:00 -!- drizztbsd is now known as timothy 02:00 -!- echonaut [~echonaut@46.101.192.134] has quit [Remote host closed the connection] 02:01 -!- echonaut [~echonaut@46.101.192.134] has joined #bitcoin-core-dev 02:01 -!- Sinclair6 [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has joined #bitcoin-core-dev 02:04 < wumpus> hehe 02:05 < wumpus> * [new tag] v0.16.0rc3 -> v0.16.0rc3 02:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:11 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ab4ee6e69242...c9ca4f6024e0 02:11 < bitcoin-git> bitcoin/master b947d38 Akira Takizawa: Add gitian PGP key: akx20000 02:11 < bitcoin-git> bitcoin/master c9ca4f6 Wladimir J. van der Laan: Merge #12371: Add gitian PGP key: akx20000... 02:12 < bitcoin-git> [bitcoin] laanwj closed pull request #12371: Add gitian PGP key: akx20000 (master...gitian-key) https://github.com/bitcoin/bitcoin/pull/12371 02:13 -!- jtimon [~quassel@41.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 248 seconds] 02:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds] 02:14 -!- hsmiths [uid95325@gateway/web/irccloud.com/x-ypcjvvqcpdfzyqtu] has joined #bitcoin-core-dev 02:21 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Read error: Connection reset by peer] 02:23 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 02:25 < promag> wumpus: no more theme release right? 02:26 < wumpus> hopefully not 02:29 < promag> wumpus: if you find the time #12333 02:29 < gribble> https://github.com/bitcoin/bitcoin/issues/12333 | Make CWallet::ListCoins atomic by promag · Pull Request #12333 · bitcoin/bitcoin · GitHub 02:29 < promag> add ?w=1 02:30 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection] 02:43 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Ping timeout: 265 seconds] 02:49 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 02:50 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 02:54 -!- murrayn [~murrayn@unaffiliated/murrayn] has quit [Quit: Adios mofos] 02:54 -!- murrayn [~murrayn@unaffiliated/murrayn] has joined #bitcoin-core-dev 02:55 < promag> wumpus: this should be ready #12298 02:57 -!- Sinclair6 [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has quit [Read error: Connection reset by peer] 02:57 -!- go1111111 [go1111111@gateway/vpn/privateinternetaccess/go1111111] has joined #bitcoin-core-dev 02:57 -!- Sinclair6 [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has joined #bitcoin-core-dev 03:02 -!- DrFeelGood [~DrFeelGoo@unaffiliated/olufunmilayo] has quit [Ping timeout: 240 seconds] 03:04 -!- DrFeelGood [~DrFeelGoo@unaffiliated/olufunmilayo] has joined #bitcoin-core-dev 03:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 03:18 -!- murrayn [~murrayn@unaffiliated/murrayn] has quit [Quit: Adios mofos] 03:19 -!- checksauce [~checksauc@184.82.28.155] has joined #bitcoin-core-dev 03:20 < provoostenator> Time to ssh into my computer, start the gitian VM, ssh into that and then have it build the vm that builds rc3. Must go deeper! 03:22 < promag> provoostenator: and play this https://www.youtube.com/watch?v=imamcajBEJs 03:22 < provoostenator> No, I'm tethering... 03:23 -!- rex_4539 [~textual@ppp-2-84-167-103.home.otenet.gr] has joined #bitcoin-core-dev 03:23 -!- murrayn [~dafuq@unaffiliated/murrayn] has joined #bitcoin-core-dev 03:24 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Ping timeout: 268 seconds] 03:25 < promag> IMO we should add the version when something is deprecated, like DEPRECATED(0.16.0) 03:26 < promag> without that a reviewer must blame to see when it was deprecated 03:26 < promag> context 12336 03:27 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #bitcoin-core-dev 03:29 -!- checksauce [~checksauc@184.82.28.155] has quit [Remote host closed the connection] 03:33 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 03:35 -!- DrFeelGood [~DrFeelGoo@unaffiliated/olufunmilayo] has quit [Ping timeout: 240 seconds] 03:42 < promag> Close 12387.. 03:45 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-wgvaenvnfgfbbwvz] has quit [Quit: Connection closed for inactivity] 03:50 < arubi> comments on #12321 ? 03:50 < gribble> https://github.com/bitcoin/bitcoin/issues/12321 | p2wsh and p2sh-p2wsh address in decodescript by fivepiece · Pull Request #12321 · bitcoin/bitcoin · GitHub 03:50 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-yaaraamphmkhxtac] has joined #bitcoin-core-dev 03:58 -!- jtimon [~quassel@41.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 04:04 < arubi> oh actually I could use GetScriptForWitness() right? 04:05 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Ping timeout: 240 seconds] 04:07 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 04:07 < arubi> well not blindly, it might return a p2wpkh instead 04:14 -!- gauravgoyal [~gauravgoy@103.227.53.19] has joined #bitcoin-core-dev 04:17 < wumpus> what's wrong with travis on rc3? 04:17 < wumpus> 0.04s$ if [ "$CHECK_DOC" = 1 ]; then contrib/devtools/git-subtree-check.sh src/crypto/ctaes; fi ERROR: src/crypto/ctaes is not a subtree 04:17 < wumpus> https://travis-ci.org/bitcoin/bitcoin/jobs/338906244 04:17 < wumpus> I cannot reproduce that error locally 04:19 -!- DrFeelGood [~DrFeelGoo@unaffiliated/olufunmilayo] has joined #bitcoin-core-dev 04:19 -!- DrFeelGood [~DrFeelGoo@unaffiliated/olufunmilayo] has quit [Remote host closed the connection] 04:21 < promag> cache? 04:24 < wumpus> deleted the cache for the 0.16 branch, we'll see 04:27 < wumpus> same issue 04:31 -!- gauravgoyal [~gauravgoy@103.227.53.19] has quit [Remote host closed the connection] 04:31 < promag> wumpus: https://github.com/bitcoin/bitcoin/commits/0.16 04:31 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c9ca4f6024e0...a1ffddb90d1b 04:31 < bitcoin-git> bitcoin/master 5bdbbdc João Barbosa: Refactor HaveKeys to early return on false result 04:31 < bitcoin-git> bitcoin/master a1ffddb Wladimir J. van der Laan: Merge #12298: Refactor HaveKeys to early return on false result... 04:32 < bitcoin-git> [bitcoin] laanwj closed pull request #12298: Refactor HaveKeys to early return on false result (master...2018-01-ismine-havekeys) https://github.com/bitcoin/bitcoin/pull/12298 04:32 < promag> this happened before https://travis-ci.org/bitcoin/bitcoin/jobs/338892886 04:36 < wumpus> "git log src/crypto/ctaes" shows the last change to ctaes was made a year and two months ago 04:37 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 04:37 < wumpus> maybe it has to do with "git clone --depth=50 --branch=0.16" , will try that 04:38 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 04:39 < wumpus> that's it: at depth 50, it cannot see that it is a subtree 04:39 < wumpus> e.g. the last change to ctaes was more than 50 commits ago, so for a shallow checkout, it's "lost" 04:40 < wumpus> the obvious solution would be to clone deeper, I guess, though it might be kicking the can down the road, I'd say to be robust the check needs to generate a warning in this case but continue 04:42 < wumpus> anyow I'll create a github issue, good to know at least this signals nothing important 04:47 < wumpus> https://github.com/bitcoin/bitcoin/issues/12388 04:51 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a1ffddb90d1b...b2645286745b 04:51 < bitcoin-git> bitcoin/master 27736f2 fivepiece: add fivepiece key fingerprint 04:51 < bitcoin-git> bitcoin/master b264528 Wladimir J. van der Laan: Merge #12354: add gpg key for fivepiece... 04:52 < arubi> oh thanks, I was about to mention after pushing rc3 sigs 04:52 < bitcoin-git> [bitcoin] laanwj closed pull request #12354: add gpg key for fivepiece (master...add-fivepiece-gpg-key) https://github.com/bitcoin/bitcoin/pull/12354 04:54 -!- Talia34Lemke [~Talia34Le@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 04:57 -!- DrFeelGood [~DrFeelGoo@unaffiliated/olufunmilayo] has joined #bitcoin-core-dev 05:08 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:10 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 05:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:13 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has joined #bitcoin-core-dev 05:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 05:27 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds] 05:28 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 05:29 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 05:33 -!- jamesob [~jamesob@172.56.34.144] has joined #bitcoin-core-dev 05:38 -!- jtimon [~quassel@41.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 248 seconds] 05:41 -!- lio17 [~lio17@80.ip-145-239-89.eu] has quit [Quit: lio17] 05:41 -!- lio17 [~lio17@80.ip-145-239-89.eu] has joined #bitcoin-core-dev 05:52 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #bitcoin-core-dev 05:57 -!- Ruben [~RubenSoms@1.217.138.142] has quit [Ping timeout: 256 seconds] 06:03 -!- jamesob [~jamesob@172.56.34.144] has quit [Ping timeout: 260 seconds] 06:12 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:13 -!- DrFeelGood [~DrFeelGoo@unaffiliated/olufunmilayo] has quit [Ping timeout: 240 seconds] 06:17 -!- DrFeelGood [~DrFeelGoo@unaffiliated/olufunmilayo] has joined #bitcoin-core-dev 06:20 -!- jamesob [~jamesob@172.56.34.144] has joined #bitcoin-core-dev 06:27 -!- conman [~con@2001:44b8:4154:d801:cd93:fa7d:88ff:158c] has quit [Quit: Konversation terminated!] 06:27 -!- jamesob_ [~jamesob@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #bitcoin-core-dev 06:29 -!- capa66 [capa66@gateway/vpn/privateinternetaccess/capa66] has joined #bitcoin-core-dev 06:29 -!- jamesob [~jamesob@172.56.34.144] has quit [Ping timeout: 240 seconds] 06:38 < bitcoin-git> [bitcoin] laanwj pushed 9 new commits to master: https://github.com/bitcoin/bitcoin/compare/b2645286745b...3843780fd8e0 06:38 < bitcoin-git> bitcoin/master d119f2e John Newbery: [tests] Fix style warnings in feature_fee_estimation.py 06:38 < bitcoin-git> bitcoin/master a5623b1 John Newbery: [tests] Remove tests for deprecated estimatefee RPC 06:38 < bitcoin-git> bitcoin/master a8e437a John Newbery: [tests] Remove estimatefee from rpc_deprecated.py test 06:39 < bitcoin-git> [bitcoin] laanwj closed pull request #12336: Remove deprecated rpc options (master...remove_deprecated_rpcs) https://github.com/bitcoin/bitcoin/pull/12336 06:44 -!- DrFeelGood [~DrFeelGoo@unaffiliated/olufunmilayo] has quit [Ping timeout: 240 seconds] 06:50 -!- DrFeelGood [~DrFeelGoo@unaffiliated/olufunmilayo] has joined #bitcoin-core-dev 06:53 < BlueMatt> wumpus: where are we managing release notes for 16? (or do you want to just make sure that they mention the change in regtest consensus rules causing a CheckBlockIndex() failure on upgrade) 06:53 < BlueMatt> ie #11782 06:53 < gribble> https://github.com/bitcoin/bitcoin/issues/11782 | Assertion failure in validation.cpp:4203 (re: pindexFirstNeverProcessed) · Issue #11782 · bitcoin/bitcoin · GitHub 06:53 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Ping timeout: 240 seconds] 06:54 < wumpus> BlueMatt: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.16.0-Release-notes 06:54 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/3843780fd8e0...935eb8de039d 06:54 < bitcoin-git> bitcoin/master 0b9207e practicalswift: Enable flake8 warning for "list comprehension redefines 'foo' from line N" (F812) 06:54 < bitcoin-git> bitcoin/master 4cbab15 practicalswift: tests: Fix accidental redefinition of previously defined variable via list comprehension 06:54 < bitcoin-git> bitcoin/master a9d0ebc practicalswift: Enable flake8 warnings for all currently non-violated rules 06:55 < wumpus> it's currently the same as the one on the 0.16 branch, but you should do editing on the wiki 06:56 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #12295: Enable flake8 warnings for all currently non-violated rules (master...accidental-redefinition-of-variable) https://github.com/bitcoin/bitcoin/pull/12295 06:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 07:00 -!- china008cn [b70ff7be@gateway/web/freenode/ip.183.15.247.190] has joined #bitcoin-core-dev 07:02 -!- neha [~narula@tbilisi.csail.mit.edu] has quit [Ping timeout: 240 seconds] 07:03 -!- neha [~narula@tbilisi.csail.mit.edu] has joined #bitcoin-core-dev 07:03 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds] 07:03 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 07:05 < BlueMatt> thanks! 07:05 -!- afilini [~textual@212.91.77.39] has joined #bitcoin-core-dev 07:05 -!- afilini [~textual@212.91.77.39] has quit [Client Quit] 07:06 < instagibbs> i was able to do a couple gitian runs, now compiling rc3 and getting: ./bin/gbuild:21:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError) 07:06 < instagibbs> ideas? 07:14 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 07:18 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 07:19 < bitcoin-git> [bitcoin] MajorFireball opened pull request #12390: Docs 0.16 - SHA verification for regular people on Windows (master...0.16) https://github.com/bitcoin/bitcoin/pull/12390 07:20 < wumpus> instagibbs: anything in build.log? 07:22 < bitcoin-git> [bitcoin] laanwj closed pull request #12390: Docs 0.16 - SHA verification for regular people on Windows (master...0.16) https://github.com/bitcoin/bitcoin/pull/12390 07:28 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 07:32 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/935eb8de039d...663911ed581d 07:32 < bitcoin-git> bitcoin/master fa795cf MarcoFalke: wallet: Disallow abandon of conflicted txes 07:32 < bitcoin-git> bitcoin/master 663911e Wladimir J. van der Laan: Merge #12282: wallet: Disallow abandon of conflicted txes... 07:33 < instagibbs> re-running with just linux build to get saner log 07:33 < bitcoin-git> [bitcoin] laanwj closed pull request #12282: wallet: Disallow abandon of conflicted txes (master...Mf1801-walletBumpAbandonOnlyNonConflictedTxes) https://github.com/bitcoin/bitcoin/pull/12282 07:33 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 07:37 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 07:38 -!- unholymachine [~quassel@2601:8c:c003:9f16:7c51:bf1f:a30a:a954] has quit [Remote host closed the connection] 07:38 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has quit [Quit: (https://github.com/mmgen) leaving] 07:39 < instagibbs> wumpus, pages and pages of file timestamps being from the future, and "Check your system clock" message, followed by exit 07:39 -!- unholymachine [~quassel@2601:8c:c003:9f16:e8b7:82a:64fd:dec3] has joined #bitcoin-core-dev 07:43 < wumpus> instagibbs: strange, never seen that before 07:44 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 264 seconds] 07:45 -!- capa66 [capa66@gateway/vpn/privateinternetaccess/capa66] has quit [Quit: ttfn] 07:53 < wumpus> gitian seems like a gambling machine sometimes 07:54 -!- [Author] [pizzaman@2401:a400:3200:5600:bad:d09:15:90d] has joined #bitcoin-core-dev 07:54 < wumpus> (though, maybe as a surprising anecdote, here it's been 100% reliable for a long time) 07:57 -!- [Author] [pizzaman@2401:a400:3200:5600:bad:d09:15:90d] has quit [Client Quit] 07:57 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 07:58 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 08:00 -!- DrFeelGood [~DrFeelGoo@unaffiliated/olufunmilayo] has quit [Ping timeout: 240 seconds] 08:01 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 08:01 < wumpus> oh crap, I've just apt-get-upgraded the VM running gitian, this might have been the last time that ^ 08:01 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 08:04 < achow101> wumpus: I highly suggest that you never do that because it will break gitian 08:05 < wumpus> so this went to debian 8.x now, not 9 08:05 -!- jigawatt [2f2ae8cc@gateway/web/freenode/ip.47.42.232.204] has quit [Ping timeout: 260 seconds] 08:06 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 08:06 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 08:09 < wumpus> oh, wrong, /etc/debian_version says 9.3 08:11 < wumpus> no it is 8.10 alright, checked the wrong VM, phew. It would have been really surprising to end up with 9 when just upgrading packages on 8.x. Now let's see if the build still works. 08:14 < instagibbs> running 8.10 here as well hm 08:15 -!- DrFeelGood [~DrFeelGoo@unaffiliated/olufunmilayo] has joined #bitcoin-core-dev 08:17 -!- Ruben [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 08:17 < MarcoFalke> debian 9 should work after the fix https://github.com/bitcoin-core/docs/pull/22 08:19 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 08:23 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 268 seconds] 08:24 -!- Chris_St1 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 08:24 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 276 seconds] 08:28 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 08:30 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has joined #bitcoin-core-dev 08:32 < provoostenator> instagibbs: I'm also getting " failed to run on-target setarch x86_64 " 08:33 < provoostenator> And that's a fresh Debian 8 that I used for rc2 two days ago. 08:36 < provoostenator> Though I used --setup that time, using -b this time. 08:38 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection] 08:38 < wumpus> buliding on (upgraded) 8.10 seems to be going ok here 08:38 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 08:39 < provoostenator> My VM clock is totally wrong though, why doesn't Debian sync it? 08:40 -!- jtimon [~quassel@41.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 08:40 < Sentineo> is it just an offset ? it does it for me on lxc ... always gmt 08:41 < wumpus> debian doesn't install as many packages by default as ubuntu does, maybe you need to install the ntp stuff 08:42 < wumpus> always compare date -u against UTC, the timezone shouldn't matter 08:42 < provoostenator> I just installed ntp. Trying gitian again. 08:43 < instagibbs> i thought mocktime somethingsomething was under the hood for these builds 08:43 < MarcoFalke> yeah, why would wall clock time matter 08:44 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 248 seconds] 08:45 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has quit [Remote host closed the connection] 08:47 < instagibbs> provoostenator, please report back, ill hold out 08:49 < provoostenator> That seems to have done the trick. 08:49 < provoostenator> So let's just add installation instructions for ntp to the docs and not worry about why :-P 08:51 < achow101> instagibbs: MarcoFalke I'm guessing that the time of the vm and the time of the lxc container need to be the same so that the vm can send commands to the container 08:51 < achow101> the container has mocktime for the build itself 08:52 < wumpus> yes, having working instruction is more important than knowing why, I've found that usually with time-related problems it's something with SSL certificates or other network communications getting confused about large time differences 08:52 < provoostenator> I wonder what made suddenly made it picky though; I never paid much attention to the time on my gitian machines thus far, and I certainly didn't leave them on non-stop. 08:52 < wumpus> also if your time is too far in the past, any .tar.gz you unpack will have dates in the future, causing problems with make 08:52 < provoostenator> I may however have frozen the state, rather than shutting it down. 08:55 < Sentineo> some daemons refuse to start when time is not going forward, especially network daemons 08:56 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has joined #bitcoin-core-dev 08:59 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 08:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 09:01 -!- jigawatt [2f2ae8cc@gateway/web/freenode/ip.47.42.232.204] has joined #bitcoin-core-dev 09:01 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has quit [Client Quit] 09:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 09:05 -!- sanada [~bitktn@36-2-119-80.chiba.ap.gmo-isp.jp] has quit [] 09:05 < instagibbs> yeah looks like it's fixed 09:07 -!- finkan [~finkan@194-103-214-178.kund.ipswe.com] has joined #bitcoin-core-dev 09:08 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 09:13 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has joined #bitcoin-core-dev 09:20 -!- promag [~promag@188.140.113.30] has joined #bitcoin-core-dev 09:24 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 09:26 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 09:30 -!- vexbuy [~vexbuy@28.red-83-52-139.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 09:39 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 268 seconds] 09:42 -!- [Author] [pizzaman@2401:a400:3200:5600:bad:d09:15:90d] has joined #bitcoin-core-dev 09:43 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 09:44 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has joined #bitcoin-core-dev 09:48 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 09:55 < promag> jnewbery: do you think bitcoind should auto-set LIBC_FATAL_STDERR_? 09:59 < wumpus> no, bitcoind should not set that, if desired it's intended to be set in the environment by calling process 10:00 -!- mandric [~mandric@108-228-58-104.lightspeed.cicril.sbcglobal.net] has quit [Read error: Connection reset by peer] 10:01 < promag> ok, I didn't know that env var 10:01 -!- mandric [~mandric@108-228-58-104.lightspeed.cicril.sbcglobal.net] has joined #bitcoin-core-dev 10:01 < wumpus> me neither; it's specific to glibc so will likely not work on other OSes 10:02 < wumpus> or at least other C libraries 10:02 -!- timothy [tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 10:03 < promag> jnewbery: https://github.com/bitcoin/bitcoin/pull/12379/commits/f70e7997d26e3e456486ab0a351b8a352de07935 s/stdout/stderr in commit message? 10:13 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev 10:14 < jnewbery> promag: yes indeed. Thanks - can you leave review comments on the PR please? 10:17 -!- [Author] [pizzaman@2401:a400:3200:5600:bad:d09:15:90d] has quit [Quit: ZNC - http://znc.sourceforge.net] 10:17 -!- LeMiner2 [LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has joined #bitcoin-core-dev 10:19 -!- LeMiner [LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has quit [Ping timeout: 248 seconds] 10:19 -!- LeMiner2 is now known as LeMiner 10:20 < promag> jnewbery: no problem 10:23 -!- promag [~promag@188.140.113.30] has quit [Remote host closed the connection] 10:23 -!- promag [~promag@188.140.113.30] has joined #bitcoin-core-dev 10:25 -!- wtabata [~wtabata@179.235.79.229] has joined #bitcoin-core-dev 10:28 -!- SeABaT [3ef0350b@gateway/web/freenode/ip.62.240.53.11] has joined #bitcoin-core-dev 10:28 -!- promag [~promag@188.140.113.30] has quit [Ping timeout: 260 seconds] 10:28 -!- SeABaT [3ef0350b@gateway/web/freenode/ip.62.240.53.11] has quit [Client Quit] 10:31 -!- sanada [~bitktn@36-2-119-80.chiba.ap.gmo-isp.jp] has joined #bitcoin-core-dev 10:31 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has quit [Remote host closed the connection] 10:32 -!- [Author] [pizzaman@2401:a400:3200:5600:bad:d09:15:90d] has joined #bitcoin-core-dev 10:37 -!- goatpig [56f75164@gateway/web/freenode/ip.86.247.81.100] has joined #bitcoin-core-dev 10:37 -!- DrFeelGood [~DrFeelGoo@unaffiliated/olufunmilayo] has quit [Ping timeout: 240 seconds] 10:37 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has joined #bitcoin-core-dev 10:47 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 10:48 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/663911ed581d...d405beea26c1 10:48 < bitcoin-git> bitcoin/master 1beea7a João Barbosa: [wallet] Make CWallet::ListCoins atomic 10:48 < bitcoin-git> bitcoin/master 2f960b5 João Barbosa: [wallet] Indent only change of CWallet::AvailableCoins 10:48 < bitcoin-git> bitcoin/master d405bee Wladimir J. van der Laan: Merge #12333: Make CWallet::ListCoins atomic... 10:49 < bitcoin-git> [bitcoin] laanwj closed pull request #12333: Make CWallet::ListCoins atomic (master...2018-02-atomic-listcoins) https://github.com/bitcoin/bitcoin/pull/12333 10:56 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has quit [Quit: (https://github.com/mmgen) leaving] 11:00 < achow101> meeting? 11:00 < sipa> *PLING* 11:00 < wumpus> #startmeeting 11:00 < lightningbot> Meeting started Thu Feb 8 19:00:27 2018 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot. 11:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 11:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 11:00 < instagibbs> hi 11:00 < cfields> hi 11:00 -!- finkan [~finkan@194-103-214-178.kund.ipswe.com] has quit [Quit: Leaving] 11:00 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator 11:01 < sdaftuar> hi 11:01 < jnewbery> hi 11:01 < achow101> hi 11:01 < wumpus> PSA: rc3 was tagged earlier today, if you haven't started your gitian build yet, please do so :) 11:01 < promag> topic suggestion, next high priority stuff 11:01 < wumpus> yes 11:01 < instagibbs> provoostenator, you filed an issue for timestamps right? 11:01 < wumpus> #topic high priority for review 11:02 < wumpus> we still have plenty of things in https://github.com/bitcoin/bitcoin/projects/8, but it hasn't been updated for a few weeks because we've effectively used the 0.16 milestone for that, so now that 0.16 has branched it's up for discussion to add/remove things 11:02 < kanzure> hi. 11:03 < promag> for instance #11383 11:03 < gribble> https://github.com/bitcoin/bitcoin/issues/11383 | Basic Multiwallet GUI support by luke-jr · Pull Request #11383 · bitcoin/bitcoin · GitHub 11:03 < jtimon> https://github.com/bitcoin/bitcoin/pull/12172 could use some tested acks, even if it's a small bug 11:04 < wumpus> jtimon: you have a comment by MarcoFalke to remove a commit IIRC 11:04 < jnewbery> #10740 needs rebase so it can be removed for now (and I think it makes sense to wait for after 11383 is in) 11:04 < gribble> https://github.com/bitcoin/bitcoin/issues/10740 | [WIP] [wallet] dynamic loading/unloading of wallets by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub 11:04 < wumpus> but yes, #12172 should stay 11:04 < gribble> https://github.com/bitcoin/bitcoin/issues/12172 | Bugfix: RPC: savemempool: Dont save until LoadMempool() is finished by jtimon · Pull Request #12172 · bitcoin/bitcoin · GitHub 11:04 < jtimon> wumpus: yes, does anyone agree? I agree with removing it. just waiting for feedback 11:04 < Randolf> Hello. 11:05 < wumpus> jtimon: well he's the tests maintainer so I tend to agree with him regarding tests things, by default 11:05 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds] 11:05 < achow101> It would be nice to get #10583 and #10579 in 11:05 < gribble> https://github.com/bitcoin/bitcoin/issues/10583 | [RPC] Split part of validateaddress into getaddressinfo by achow101 · Pull Request #10583 · bitcoin/bitcoin · GitHub 11:05 < gribble> https://github.com/bitcoin/bitcoin/issues/10579 | [RPC] Split signrawtransaction into wallet and non-wallet RPC command by achow101 · Pull Request #10579 · bitcoin/bitcoin · GitHub 11:05 < wumpus> jtimon: I haven't looked closely though 11:05 < jnewbery> fyi MarcoFalke, ryanofsky and bluematt are away from keyboard 11:05 < jtimon> ok, I'll remove it, no problem, it will still need some tested acks then 11:05 < promag> jtimon: I'll check it too 11:06 < jtimon> promag: thanks! 11:06 < jnewbery> achow101: +1 a few more ACKs please - those PRs have been rebased too many times 11:06 < wumpus> 10740 removed 11:06 < instagibbs> will takea look achow101 11:06 < wumpus> jtimon: but yes I'll take a look soon 11:07 < jtimon> awesome 11:07 < cfields> topic suggestion: PR purge before ramping up for 0.17 11:07 < instagibbs> purge as in closing? 11:07 < promag> #11882 11:07 < gribble> https://github.com/bitcoin/bitcoin/issues/11882 | Disable default fallbackfee on mainnet by jonasschnelli · Pull Request #11882 · bitcoin/bitcoin · GitHub 11:08 < cfields> well, I looked at my open PR list yesterday and noticed quite a few that I should probably just close. I suspect I'm not alone... 11:08 < wumpus> that could be a next topic, the current topic is high priority :) 11:08 < cfields> now seems like a good time to go through their own and close things that are stale 11:08 < wumpus> bjut yes I agree 11:09 < promag> Also #11913 11:09 < gribble> https://github.com/bitcoin/bitcoin/issues/11913 | Avoid cs_main during ReadBlockFromDisk Calls by TheBlueMatt · Pull Request #11913 · bitcoin/bitcoin · GitHub 11:09 < cfields> ok, sorry 11:09 < jnewbery> cfields: perhaps the upcoming Core dev tech days is a good opportunity to go through and clear out old PRs? 11:09 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-pydgmnglezwfbnxm] has joined #bitcoin-core-dev 11:09 < wumpus> achow101: I've added 10583, you already have the coin selection one I think two high prio per person is a good limit 11:09 < jtimon> yeah, there have been no interest in https://github.com/bitcoin/bitcoin/pull/9608 for a while so I'm more inclined to close it than to rebase it at this point unless someone changes my mind 11:10 < meshcollider> hi 11:11 < sipa> could i have some comments on #10785 ? 11:11 < instagibbs> jnewbery, PR triage/close session sounds like a good idea 11:11 < gribble> https://github.com/bitcoin/bitcoin/issues/10785 | Serialization improvements by sipa · Pull Request #10785 · bitcoin/bitcoin · GitHub 11:11 < achow101> wumpus: ok 11:11 < wumpus> #topic PR purge 11:12 < achow101> close old PRs? 11:12 < wumpus> if PRs should be closed you can always let me know, you don't really need to wait until a meeting 11:12 < cfields> jnewbery: agreed, as a rally. But I was really just hinting that everyone should clean up their stale pulls to get the count down. 11:12 < cfields> jnewbery: but yes, a kinda "i'm not sure if anyone cares about this or not" session in NYC would be great 11:13 < bitcoin-git> [bitcoin] sipa closed pull request #10434: [WIP] 3072-bit MuHash based hash_serialized (master...muhash) https://github.com/bitcoin/bitcoin/pull/10434 11:13 < wumpus> as I've said again and again, it's impossible for me to keep track of all PRs, so if there is something with a PR, just notify me 11:13 < bitcoin-git> [bitcoin] achow101 closed pull request #9504: [RPC] dumpmasterprivkey command (master...dumpmasterprivkey) https://github.com/bitcoin/bitcoin/pull/9504 11:13 < jnewbery> It feels like in-person is the most efficient way to do a bulk purge. Probably most efficient if a set of us make lists beforehand for what we think can be closed 11:14 < wumpus> yes 11:14 < bitcoin-git> [bitcoin] promag closed pull request #11563: Improve CheckBlockIndex performance (master...2017-10-improve-checkblockindex) https://github.com/bitcoin/bitcoin/pull/11563 11:15 < cfields> sgtm 11:15 < cfields> 11:15 < wumpus> any other topics? 11:15 < bitcoin-git> [bitcoin] jtimon closed pull request #9608: Net: Divide ProcessMessage in smaller functions (master...2017-01-split-processmessages) https://github.com/bitcoin/bitcoin/pull/9608 11:16 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 11:16 < bitcoin-git> [bitcoin] instagibbs closed pull request #10360: [WIP] [Wallet] Target effective value during transaction creation (master...feedo) https://github.com/bitcoin/bitcoin/pull/10360 11:16 < cfields> maybe that should've been the last topic :p 11:16 < wumpus> so ocongratulations everyone on rc3! we were reallly fast with the fixes this time 11:17 < achow101> hopefully this will be the last rc 11:17 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 11:17 < wumpus> hopefully, yes 11:18 < wumpus> cfields: at least the closes end up in the meeting log now 11:18 < Randolf> wumpus: Is rc3 available for download? 11:18 < wumpus> Randolf: no, it's just tagged earlier today 11:18 < Randolf> Okay. Thanks. 11:18 < wumpus> but if you have no problems with rc2, it should be ok, rc3 mostly fixed some edge cases 11:19 < wumpus> (to do with initialization and shutdown) 11:19 < cfields> wumpus: heh 11:19 < Randolf> I was planning to try rc2 this weekend. If rc3 comes out first though, then rc3 is where I'll start. 11:20 < wumpus> I think it'll be possible to upload binaries for rc3 tomorrow 11:20 < achow101> have we gotten anywhere with the MPC RSA signing thing? 11:20 < Randolf> That will be great. 11:21 < wumpus> already lots of rc3 gitian sigs 11:21 < cfields> achow101: oh, right 11:21 < cfields> gmaxwell: ping ^^. Any update? 11:23 < achow101> I'm gonna guess that gmaxwell is not here right now 11:23 < wumpus> I guess so too 11:23 < instagibbs> busy with ___root 11:23 < wumpus> I'm also not hearing any other proposals for topics, so this will be a short meeting I suppose 11:23 < Randolf> instagibbs: ...or fork (if he has kids). ;) 11:24 * wumpus just merged the rc3 signatures on bitcoin-core/gitian.sigs 11:24 < Randolf> wumpus: Moving away from Boost libraries? 11:24 -!- wallet42 [sid154231@gateway/web/irccloud.com/x-miofczmzbfsqolwz] has quit [Ping timeout: 256 seconds] 11:24 < achow101> Randolf: he doesn't have kids. I'm pretty sure he hates children 11:24 < Randolf> wumpus: ...as a topic? 11:24 < cfields> wumpus: mine just finished building. We can do binaries today if we get the osx sig :) 11:24 < wumpus> Randolf: is there anything specific to discuss about that? it's been going on, slowly, for a long time 11:25 < wumpus> Randolf: review cfields's PRs! 11:25 < Randolf> wumpus: Well, it seems to me a good idea because Boost libraries have been a problem with getting numerous things compiled on NetBSD. I guess I'm just wondering how things are going on that front. 11:25 < Randolf> More general. 11:25 < arubi> craig satoshi 11:25 < sipa> Randolf: it will be years 11:25 < arubi> holy shit roger is stupid 11:25 < sipa> arubi: not here 11:25 < cfields> Randolf: https://github.com/bitcoin/bitcoin/projects/3 11:25 < arubi> oh man sorry, wrong channel 11:25 < Randolf> sipa: Oh, so there must be a lot of things tied to it then. 11:25 < arubi> yea, missed the ctrl :) 11:26 < Randolf> cfields: Thanks. Wow, there's quite a lot to do there, and I wonder if that's everything that needs to be done. 11:26 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has joined #bitcoin-core-dev 11:26 < wumpus> there's no hurry in any case 11:26 < cfields> Randolf: short version: I think we'll be able to get rid of a few parts of boost for 0.17, but things like the unit tests will keep it hanging around for a while 11:26 < Randolf> Sure, because it's working. 11:27 < Randolf> cfields: That seems reasonable. 11:27 < wumpus> boost::filesystem can only be replaced in c++17 or so 11:27 < cfields> anyway, we can discuss after the meeting 11:27 -!- wallet42 [sid154231@gateway/web/irccloud.com/x-kxixruehuvjvowca] has joined #bitcoin-core-dev 11:27 < Randolf> Okay. 11:27 < wumpus> will be a while until we can start using that 11:27 < cfields> wumpus: right 11:28 < wumpus> or at least, mandating it, it could theoretically be an option, but meh. I'd recommend you just solve whatever build problems you have with boost and put it behind you for now 11:28 < wumpus> yes, let's close the meeting 11:28 < wumpus> #endmeeting 11:28 < lightningbot> Meeting ended Thu Feb 8 19:28:21 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 11:28 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-02-08-19.00.html 11:28 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-02-08-19.00.txt 11:28 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-02-08-19.00.log.html 11:28 < Randolf> Already did that. 11:29 < cfields> Randolf: fwiw, I think threads are probably the biggest portability issue. And it looks like we'll be rid of boost::thread very soon. 11:30 < Randolf> cfields: Indeed. And I did notice this PR: https://github.com/bitcoin/bitcoin/pull/12381 11:30 < cfields> <-- TheUni 11:30 < Randolf> Oh, that's you! 11:30 < cfields> :) 11:31 -!- vexbuy [~vexbuy@28.red-83-52-139.dynamicip.rima-tde.net] has quit [] 11:31 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 255 seconds] 11:32 < Randolf> I had a terrible problem with Boost many years ago on NetBSD when I was trying to get two different software projects compiled. They both needed different versions of Boost that had conflicting APIs. Backward compabitility seems to be a problem because I ultimately had to either run one of the 11:32 < Randolf> So, I tend to favour the idea of getting rid of stuff like that. 11:32 < Randolf> applications under a chroot or in a VM, or on a different system. 11:32 -!- Chris_St1 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 256 seconds] 11:32 < wumpus> that's terrible, bitcoind shouldn't have problems like that though, it works with a wide range of boost versions 11:33 < Randolf> Oh, Bitcoin wasn't one of the applications. 11:33 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 11:34 < cfields> Randolf: sounds familiar. Boost is basically the testing project for c++-next. So it's kinda like adding "#include " to your project :( 11:35 < Randolf> Oh. Wow. 11:36 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 11:45 < jonasschnelli> Sorry,.. missed the meeting... new timezone. :( 11:46 < Randolf> jonasschnelli: Lots of PRs were closed. It was quick. 11:46 -!- mirese [~mirese@2a02:1205:507c:3710:d9d6:938b:898f:5ff8] has joined #bitcoin-core-dev 11:46 < jonasschnelli> Randolf: Perfect! 11:47 < Randolf> http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-02-08-19.00.html 11:49 < jtimon> we're now on c++11 and the next is c++14, right? what stops us from moving to c++14 ? 11:50 -!- mirese_ [~mirese@2a02:1205:507c:3710:e0:c7cb:2f17:dafd] has quit [Ping timeout: 256 seconds] 11:50 < jonasschnelli> jtimon: too early I'd say 11:50 < jonasschnelli> jtimon: compiler support, stability 11:50 < jonasschnelli> (I would guess) 11:52 -!- wunpunch [~Alli@2a02:c7f:282a:6c00:1401:cb95:fa6d:64b4] has joined #bitcoin-core-dev 11:52 < jtimon> but for C++11 we needed to get rid of some things before worring about changing the build, no? or am I missremembering? my question is more, is there something like that? 11:52 < jtimon> some prerriquisite before even considering moving? 11:54 < wumpus> FWIW a few months ago I built bitcoind with c++17, and there were a few small changes necessary to get it to compile, I can try to find the patch, but nothing serious 11:54 -!- dcousens [~dcousens@101.188.211.44] has quit [Ping timeout: 255 seconds] 11:54 -!- dcousens [~dcousens@110.140.47.86] has joined #bitcoin-core-dev 11:55 < jtimon> wumpus: awesome, what kind of change ? can I have a look? 11:56 < wumpus> https://github.com/laanwj/bitcoin/commit/6df31f4c26805009734a620aa2d584e3936d4690 https://github.com/laanwj/bitcoin/commit/3f6bcfa283416182f2602dce357bdaedfc84efe7 https://github.com/laanwj/bitcoin/commit/efeec33d19752de7480f1e8d0fbcd79e49548910 11:56 < wumpus> especially the last one; the rest is build system 11:57 < wumpus> I am not sure all of those changes are still necessary, or that it was just working around a compiler bug 11:57 < jtimon> either way they seem pretty minimal 11:57 < wumpus> yep 11:58 < jtimon> cool 11:59 < wumpus> of course, changing to actually use any c++17 stuff will involve more changes 11:59 < wumpus> I'm not sure boost::filesystem to std::filesystem is just a drop in replacement, for exmple 12:00 < jtimon> well, yeah, but that could be considered later 12:01 < cfields> wumpus: I wrote an adapter at some point. IIRC you didn't like it, but I don't remember the exact reason 12:01 < wumpus> cfields: oh?! 12:02 < cfields> wumpus: yea, so that fs::foo would worth whether fs was std or boost 12:02 < cfields> let me see if I still have it 12:02 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 12:03 -!- wtabata [~wtabata@179.235.79.229] has quit [] 12:03 < wumpus> cfields: I think that's a nice idea at least, it's one of the reasons I introduced fs in the first place 12:03 < cfields> wumpus: right. I'm kinda on the fence about it, I maily just wanted to see how compatible they were 12:04 < cfields> *mainly 12:04 < cfields> wumpus: also, I believe you can use std::fs pre-c++17 as a compiler extension 12:05 < wumpus> but I guess that will still require a c++17 compiler 12:05 < wumpus> it will just work in non-c++17 mode? 12:05 < cfields> wumpus: https://github.com/theuni/bitcoin/commits/filesystem 12:06 < wumpus> I don't remember seeing that before 12:07 < wumpus> I'm surprised if this are all the changes needed: https://github.com/theuni/bitcoin/commit/b208705020118d2be6962c0bf7b6fcfd702f576e 12:07 < wumpus> kind of nice 12:09 < cfields> yes, I was pleasantly surprised as well 12:10 -!- flokie_ [~flokie@unaffiliated/flokie] has joined #bitcoin-core-dev 12:11 < wumpus> I guess there isn't much reason to do it yet before we even got rid of boost::thread fully, but it's good to know 12:13 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection] 12:13 < wumpus> at some point we could offer a choice with a configure option, either use boost, or c++17/experimental 12:13 -!- flokie [~flokie@unaffiliated/flokie] has quit [Ping timeout: 260 seconds] 12:13 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 12:14 -!- Ylbam_ [uid99779@gateway/web/irccloud.com/x-nkafjawypzsilgme] has joined #bitcoin-core-dev 12:14 < cfields> right 12:16 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 12:16 < wumpus> I don't understand why I didn't like it, the only thing I can think of is that I thought it was too early to do it 12:18 -!- Ruben [~RubenSoms@1.217.138.142] has quit [Ping timeout: 240 seconds] 12:20 < cfields> wumpus: ah, you objected to the idea of our own impl. You were pretty pro std impl: https://github.com/bitcoin/bitcoin/pull/9902#issuecomment-283764371 12:21 < wumpus> cfields: yes, I remember now, one idea was to wrap the entire thing, which is a lot of code, thanks 12:22 < cfields> right 12:24 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 12:26 < GitHub158> [bitcoin-detached-sigs] jonasschnelli opened pull request #3: 0.16: osx signatures for 0.16.0rc3 (0.16...0.16) https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/3 12:32 < instagibbs> achow101, ill review #10579 and #10583 if they get rebased(sorry for your rebasing) 12:32 < gribble> https://github.com/bitcoin/bitcoin/issues/10579 | [RPC] Split signrawtransaction into wallet and non-wallet RPC command by achow101 · Pull Request #10579 · bitcoin/bitcoin · GitHub 12:32 < gribble> https://github.com/bitcoin/bitcoin/issues/10583 | [RPC] Split part of validateaddress into getaddressinfo by achow101 · Pull Request #10583 · bitcoin/bitcoin · GitHub 12:34 < achow101> instagibbs: do they need rebasing again? I rebased them last week! 12:34 < instagibbs> says merged conflict with tests <_< 12:35 < achow101> bleh 12:36 < GitHub126> [bitcoin-detached-sigs] theuni closed pull request #3: 0.16: osx signatures for 0.16.0rc3 (0.16...0.16) https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/3 12:38 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Ping timeout: 264 seconds] 12:38 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 12:40 < cfields> woohoo, no crashes during sanity checks this time :) 12:42 < wumpus> awesome :) 12:44 < cfields> gitian builders: v0.16.0rc3 detached sigs are up 12:49 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 12:50 < achow101> instagibbs: rebased those again 12:51 < wumpus> cfields: thanks 12:52 < cfields> ofc 12:56 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 255 seconds] 13:07 -!- mirese_ [~mirese@2a02:1205:507c:3710:d92d:6283:51bf:d37c] has joined #bitcoin-core-dev 13:11 -!- mirese [~mirese@2a02:1205:507c:3710:d9d6:938b:898f:5ff8] has quit [Ping timeout: 256 seconds] 13:14 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 13:20 < bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/d405beea26c1...67447ba06057 13:20 < bitcoin-git> bitcoin/master 0975406 Suhas Daftuar: Correct mempool mapTx comment 13:20 < bitcoin-git> bitcoin/master e868b22 Suhas Daftuar: fee estimator: avoid sorting mempool on shutdown 13:20 < bitcoin-git> bitcoin/master 669c943 Suhas Daftuar: Avoid leaking prioritization information when relaying transactions 13:21 < bitcoin-git> [bitcoin] laanwj closed pull request #12225: Mempool cleanups (master...2018-01-mempool-cleanups) https://github.com/bitcoin/bitcoin/pull/12225 13:33 -!- DrFeelGood [~DrFeelGoo@unaffiliated/olufunmilayo] has joined #bitcoin-core-dev 13:33 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 13:38 -!- randy-waterhouse [~kiwigb@103.231.90.194] has joined #bitcoin-core-dev 13:38 -!- randy-waterhouse [~kiwigb@103.231.90.194] has quit [Changing host] 13:38 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has joined #bitcoin-core-dev 13:46 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection] 13:47 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 13:51 -!- mirese [~mirese@2a02:1205:507c:3710:9925:3eca:1f40:baaa] has joined #bitcoin-core-dev 13:53 -!- mirese__ [~mirese@2a02:1205:507c:3710:7d05:b92f:6385:f757] has joined #bitcoin-core-dev 13:54 -!- mirese_ [~mirese@2a02:1205:507c:3710:d92d:6283:51bf:d37c] has quit [Ping timeout: 255 seconds] 13:56 -!- mirese [~mirese@2a02:1205:507c:3710:9925:3eca:1f40:baaa] has quit [Ping timeout: 256 seconds] 13:56 -!- mirese [~mirese@2a02:1205:507c:3710:91b1:fe42:9ed7:4fc6] has joined #bitcoin-core-dev 13:57 -!- mirese_ [~mirese@2a02:1205:507c:3710:c0b3:83d8:ceea:9d0f] has joined #bitcoin-core-dev 13:58 -!- mirese___ [~mirese@2a02:1205:507c:3710:4173:39c4:6a3a:3e0f] has joined #bitcoin-core-dev 13:58 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #12286: Wallet: Resolve compiler warnings in ec_privkey_import_der (master...master) https://github.com/bitcoin/bitcoin/pull/12286 13:58 -!- mires____ [~mirese@2a02:1205:507c:3710:d86b:5bcb:4a9d:ceca] has joined #bitcoin-core-dev 14:00 -!- mir______ [~mirese@2a02:1205:507c:3710:18db:b588:f62c:4b87] has joined #bitcoin-core-dev 14:00 -!- mirese__ [~mirese@2a02:1205:507c:3710:7d05:b92f:6385:f757] has quit [Ping timeout: 256 seconds] 14:01 -!- mirese__ [~mirese@2a02:1205:507c:3710:c46b:b448:b841:4c3e] has joined #bitcoin-core-dev 14:01 -!- mirese [~mirese@2a02:1205:507c:3710:91b1:fe42:9ed7:4fc6] has quit [Ping timeout: 256 seconds] 14:02 -!- mirese___ [~mirese@2a02:1205:507c:3710:4173:39c4:6a3a:3e0f] has quit [Ping timeout: 256 seconds] 14:02 -!- mirese_ [~mirese@2a02:1205:507c:3710:c0b3:83d8:ceea:9d0f] has quit [Ping timeout: 256 seconds] 14:02 -!- mires____ [~mirese@2a02:1205:507c:3710:d86b:5bcb:4a9d:ceca] has quit [Ping timeout: 256 seconds] 14:04 -!- mir______ [~mirese@2a02:1205:507c:3710:18db:b588:f62c:4b87] has quit [Ping timeout: 256 seconds] 14:11 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection] 14:11 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:12 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 14:18 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 14:19 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 264 seconds] 14:26 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has quit [Quit: Leaving.] 14:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 14:36 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds] 14:42 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 14:42 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has quit [Ping timeout: 255 seconds] 14:43 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has joined #bitcoin-core-dev 14:45 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection] 14:46 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 14:50 -!- whphhg_ is now known as whphhg 14:53 -!- whphhg [~whphhg@unaffiliated/whphhg] has quit [Quit: Leaving] 15:08 -!- whphhg [~whphhg@unaffiliated/whphhg] has joined #bitcoin-core-dev 15:09 -!- grubles [~grubles@unaffiliated/grubles] has joined #bitcoin-core-dev 15:10 -!- musalbas [~musalbas@algebra.musalbas.com] has quit [Ping timeout: 240 seconds] 15:10 -!- gaf_ [~fag@12.smos-linux.org] has quit [Ping timeout: 240 seconds] 15:10 -!- zautomata1 [~zautomata@41.232.223.14] has quit [Quit: WeeChat 1.9.1] 15:10 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Ping timeout: 255 seconds] 15:10 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has quit [Ping timeout: 255 seconds] 15:10 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 255 seconds] 15:11 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 255 seconds] 15:11 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 255 seconds] 15:12 -!- musalbas [~musalbas@algebra.musalbas.com] has joined #bitcoin-core-dev 15:13 -!- DrFeelGood [~DrFeelGoo@unaffiliated/olufunmilayo] has quit [Ping timeout: 240 seconds] 15:13 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 15:16 -!- gaf_ [~fag@12.smos-linux.org] has joined #bitcoin-core-dev 15:19 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 15:22 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 264 seconds] 15:23 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 15:28 -!- grubles [~grubles@unaffiliated/grubles] has quit [Quit: Leaving] 15:28 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 15:29 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 15:30 -!- rex_4539 [~textual@ppp-2-84-167-103.home.otenet.gr] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 15:33 -!- grubles [~grubles@unaffiliated/grubles] has joined #bitcoin-core-dev 15:34 -!- vicenteH [~user@35.233.15.37.dynamic.jazztel.es] has quit [Ping timeout: 264 seconds] 15:34 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #12392: Fix ignoring tx data requests when fPauseSend is set on a peer (master...2018-02-fix-fpausesend-getdata-resp) https://github.com/bitcoin/bitcoin/pull/12392 15:39 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 15:41 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-pydgmnglezwfbnxm] has quit [Quit: Connection closed for inactivity] 15:43 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has joined #bitcoin-core-dev 15:44 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Remote host closed the connection] 15:44 -!- jamesob_ [~jamesob@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 15:52 -!- DrFeelGood [~DrFeelGoo@unaffiliated/olufunmilayo] has joined #bitcoin-core-dev 15:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 16:02 -!- jimmysong [~Jimmy@23-112-39-203.lightspeed.austtx.sbcglobal.net] has joined #bitcoin-core-dev 16:03 -!- Ylbam_ [uid99779@gateway/web/irccloud.com/x-nkafjawypzsilgme] has quit [Quit: Connection closed for inactivity] 16:06 -!- CubicEarths [~cubiceart@190.140.125.142] has joined #bitcoin-core-dev 16:16 -!- Randolf [~randolf@205.250.80.42] has joined #bitcoin-core-dev 16:20 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 16:21 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 16:38 -!- Randolf [~randolf@205.250.80.42] has quit [Ping timeout: 256 seconds] 16:40 -!- Randolf [~randolf@205.250.80.42] has joined #bitcoin-core-dev 16:41 -!- dendisuhubdy [~dendisuhu@x-132-204-243-253.xtpr.umontreal.ca] has joined #bitcoin-core-dev 16:44 -!- dendisuhubdy [~dendisuhu@x-132-204-243-253.xtpr.umontreal.ca] has quit [Remote host closed the connection] 16:50 -!- Randolf [~randolf@205.250.80.42] has quit [Ping timeout: 240 seconds] 16:54 < bitcoin-git> [bitcoin] promag closed pull request #12361: Replace unreachable error handling with assertions in feebumper (master...2018-02-feebumper) https://github.com/bitcoin/bitcoin/pull/12361 16:56 -!- Randolf [~randolf@205.250.80.42] has joined #bitcoin-core-dev 16:58 -!- Dizzle [~dizzle@108.171.182.16] has quit [Quit: Leaving...] 17:04 -!- wunpunch [~Alli@2a02:c7f:282a:6c00:1401:cb95:fa6d:64b4] has quit [Read error: Connection reset by peer] 17:17 -!- Randolf [~randolf@205.250.80.42] has quit [Read error: Connection reset by peer] 17:19 -!- Randolf [~randolf@205.250.80.225] has joined #bitcoin-core-dev 17:23 -!- Randolf [~randolf@205.250.80.225] has quit [Ping timeout: 240 seconds] 17:43 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 17:43 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 17:44 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has joined #bitcoin-core-dev 17:45 -!- mirese [~mirese@2a02:1205:507c:3710:3010:c1c3:1a6f:3f66] has joined #bitcoin-core-dev 17:48 -!- mirese__ [~mirese@2a02:1205:507c:3710:c46b:b448:b841:4c3e] has quit [Ping timeout: 240 seconds] 17:48 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 17:55 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-cgpkhxjxevmxujuj] has joined #bitcoin-core-dev 18:12 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 264 seconds] 18:26 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 18:43 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Quit: esoteric nonsense] 18:49 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev 18:53 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 18:58 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 256 seconds] 19:02 -!- checksauce [~checksauc@184.82.29.117] has joined #bitcoin-core-dev 19:05 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 19:06 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 19:09 -!- Randolf [~randolf@96.53.47.42] has quit [Quit: https://www.randolfrichardson.com/] 19:17 -!- jtimon [~quassel@41.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds] 19:18 -!- Talia34Lemke [~Talia34Le@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 240 seconds] 19:22 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 19:27 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 248 seconds] 19:28 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 19:30 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 248 seconds] 19:39 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 255 seconds] 19:41 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 19:53 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 19:56 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 255 seconds] 19:57 -!- checksauce [~checksauc@184.82.29.117] has quit [Remote host closed the connection] 19:58 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 260 seconds] 19:59 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 20:07 -!- gmaxwell [~gmaxwell@wikimedia/KatWalsh/x-0001] has left #bitcoin-core-dev [] 20:07 -!- neha [~narula@tbilisi.csail.mit.edu] has quit [Ping timeout: 240 seconds] 20:08 -!- neha [~narula@tbilisi.csail.mit.edu] has joined #bitcoin-core-dev 20:17 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 20:21 -!- MrBruceWayne [636b84d7@gateway/web/freenode/ip.99.107.132.215] has joined #bitcoin-core-dev 20:21 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 20:22 < MrBruceWayne> #bitcoin 20:22 -!- MrBruceWayne [636b84d7@gateway/web/freenode/ip.99.107.132.215] has quit [Client Quit] 20:23 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Quit: Leaving.] 20:26 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 248 seconds] 20:39 -!- CubicEarths [~cubiceart@190.140.125.142] has quit [] 21:12 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 21:19 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 255 seconds] 21:20 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has quit [Ping timeout: 255 seconds] 21:20 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 255 seconds] 21:20 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 255 seconds] 21:21 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has quit [Remote host closed the connection] 21:22 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has joined #bitcoin-core-dev 21:25 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 21:30 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-yaaraamphmkhxtac] has quit [Quit: Connection closed for inactivity] 21:40 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 21:40 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has joined #bitcoin-core-dev 21:43 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has quit [Remote host closed the connection] 21:43 -!- Lynet [~slem@2a00:c440:20:dcd:3097:a446:4297:67b5] has joined #bitcoin-core-dev 21:44 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has joined #bitcoin-core-dev 21:48 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 21:52 < sipa> achow101: the "Known issue" you added to the release notes, wasn't that fixed? 21:56 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 22:02 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 268 seconds] 22:03 -!- jtimon [~quassel@41.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 22:10 -!- flokie_ [~flokie@unaffiliated/flokie] has quit [Quit: Leaving] 22:15 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has joined #bitcoin-core-dev 22:24 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 22:29 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 248 seconds] 22:30 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has quit [Ping timeout: 248 seconds] 22:41 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 22:45 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 260 seconds] 22:53 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Quit: Leaving] 23:05 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-cgpkhxjxevmxujuj] has quit [Quit: Connection closed for inactivity] 23:06 -!- rex_4539 [~textual@ppp-2-84-167-103.home.otenet.gr] has joined #bitcoin-core-dev 23:08 -!- jtimon [~quassel@41.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 256 seconds] 23:20 -!- china008cn [b70ff7be@gateway/web/freenode/ip.183.15.247.190] has quit [Quit: Page closed] 23:36 -!- dongcarl [~dongcarl@c-73-202-219-157.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 23:39 -!- echeveria [~echeveria@2604:a880:2:d0::28:f001] has quit [Changing host] 23:39 -!- echeveria [~echeveria@unaffiliated/echeveria] has joined #bitcoin-core-dev 23:42 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 23:42 -!- jarthur [~jarthur@2605:6000:1019:42b6:6931:c87f:5cf8:38cc] has joined #bitcoin-core-dev 23:47 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 265 seconds]