--- Day changed Mon Feb 12 2018 00:35 -!- Lightsword [~Lightswor@107.170.253.193] has left #bitcoin-core-dev [] 01:06 -!- razor948 [~mlohyqs@67.44.208.212] has joined #bitcoin-core-dev 01:06 < razor948> ┬┬─┐┌─┐ ┌─┐┬ ┬┌─┐┌─┐┬─┐┌┐┌┌─┐┌┬┐┌─┐ ┌─┐┬─┐┌─┐ 01:06 < razor948> ┬┬─┐┌─┐ ┌─┐┬ ┬┌─┐┌─┐┬─┐┌┐┌┌─┐┌┬┐┌─┐ ┌─┐┬─┐┌─┐ 01:06 < razor948> ┬┬─┐┌─┐ ┌─┐┬ ┬┌─┐┌─┐┬─┐┌┐┌┌─┐┌┬┐┌─┐ ┌─┐┬─┐┌─┐ 01:06 < razor948> ┬┬─┐┌─┐ ┌─┐┬ ┬┌─┐┌─┐┬─┐┌┐┌┌─┐┌┬┐┌─┐ ┌─┐┬─┐┌─┐ 01:06 < razor948> │├┬┘│ └─┐│ │├─┘├┤ ├┬┘│││├┤ │ └─┐ │ │├┬┘│ ┬ 01:06 < razor948> │├┬┘│ └─┐│ │├─┘├┤ ├┬┘│││├┤ │ └─┐ │ │├┬┘│ ┬ 01:06 < razor948> │├┬┘│ └─┐│ │├─┘├┤ ├┬┘│││├┤ │ └─┐ │ │├┬┘│ ┬ 01:06 < razor948> │├┬┘│ └─┐│ │├─┘├┤ ├┬┘│││├┤ │ └─┐ │ │├┬┘│ ┬ 01:06 < razor948> ┴┴└─└─┘o└─┘└─┘┴ └─┘┴└─┘└┘└─┘ ┴ └─┘o└─┘┴└─└─┘ 01:06 < razor948> ┴┴└─└─┘o└─┘└─┘┴ └─┘┴└─┘└┘└─┘ ┴ └─┘o└─┘┴└─└─┘ 01:06 < razor948> ┴┴└─└─┘o└─┘└─┘┴ └─┘┴└─┘└┘└─┘ ┴ └─┘o└─┘┴└─└─┘ 01:06 < razor948> ┴┴└─└─┘o└─┘└─┘┴ └─┘┴└─┘└┘└─┘ ┴ └─┘o└─┘┴└─└─┘ 01:06 < razor948> rex_4539 eklitzke mmgen dlb76 ohnx Victorsueca intcat goatpig Sinclair6 arubi grafcaps DarylSharp dgy_ tryphe Randolf shesek Emcy meshcollider dcousens Arise2 mirese Evel-Knievel ghost43 Cory mandric DrFeelGood justanotheruser gmaxwell droark spinza unholymachine lnostdal boblee ludens[m] Masaomi[m] ajtowns[m] kewde[m] herzmeister[m] cncr04s Scrat Apocalyptic NielsvG bordeaux_facile_ Varunram Muis dagurval mariorz jnewbery mlz punch rockhouse Bas 01:07 -!- razor948 [~mlohyqs@67.44.208.212] has quit [Client Quit] 01:07 < meshcollider> not this again -_- 01:07 < wumpus> yeah... 01:07 < aj> at least it's not in colour? 01:08 < wumpus> can anyone, that uses bitcoin-tx, comment on https://github.com/bitcoin/bitcoin/pull/10694? 01:12 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fe53d5f3636a...79313d2e2040 01:12 < bitcoin-git> bitcoin/master a8b5d20 Sjors Provoost: Reset pblocktree before deleting LevelDB file 01:12 < bitcoin-git> bitcoin/master 79313d2 Wladimir J. van der Laan: Merge #12401: Reset pblocktree before deleting LevelDB file... 01:12 < bitcoin-git> [bitcoin] laanwj closed pull request #12401: Reset pblocktree before deleting LevelDB file (master...2018/02/reset-pblocktree) https://github.com/bitcoin/bitcoin/pull/12401 01:14 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/79313d2e2040...a8cbbdb07a59 01:14 < bitcoin-git> bitcoin/master c4af738 Matt Corallo: Fix ignoring tx data requests when fPauseSend is set on a peer... 01:14 < bitcoin-git> bitcoin/master a8cbbdb Wladimir J. van der Laan: Merge #12392: Fix ignoring tx data requests when fPauseSend is set on a peer... 01:15 < bitcoin-git> [bitcoin] laanwj closed pull request #12392: Fix ignoring tx data requests when fPauseSend is set on a peer (master...2018-02-fix-fpausesend-getdata-resp) https://github.com/bitcoin/bitcoin/pull/12392 01:22 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:25 < jonasschnelli> rc4? 01:26 < wumpus> maybe... 01:26 < wumpus> might be too soon 01:27 < jonasschnelli> maybe wait for other report, right. 01:27 < jonasschnelli> *reports 01:27 -!- Muis [sid26074@gateway/web/irccloud.com/x-cjqjjujsbgchknzm] has quit [] 01:27 < wumpus> if you release too many rcs in short succession the number of testers will likely drop; I've already seen the first "I'll test next weekend when rc n+1 is out" 01:27 -!- Muis [sid26074@gateway/web/irccloud.com/x-sjvztpatkpvfaytp] has joined #bitcoin-core-dev 01:28 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:29 < wumpus> so let's keep it to 1 per week 01:29 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 260 seconds] 01:29 < wumpus> going to do the backports already so people on the 0.16 branch can test 01:30 < jonasschnelli> Makes sense. 01:31 < gmaxwell> wumpus: though perhaps the things that would be in rc3 should ... nevermind you got it. :P 01:31 * gmaxwell will test as soon as the backports are merged. 01:31 -!- profall [sid29922@gateway/web/irccloud.com/x-rkzywkaokivnaxie] has quit [] 01:32 -!- profall [sid29922@gateway/web/irccloud.com/x-pznffpyslxbbwfgd] has joined #bitcoin-core-dev 01:32 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 01:34 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to 0.16: https://github.com/bitcoin/bitcoin/compare/a5e3d44cc8f6...0f616517e1f2 01:34 < bitcoin-git> bitcoin/0.16 d44cd7e Sjors Provoost: Reset pblocktree before deleting LevelDB file... 01:34 < bitcoin-git> bitcoin/0.16 0f61651 Matt Corallo: Fix ignoring tx data requests when fPauseSend is set on a peer... 01:34 < wumpus> gmaxwell: ^^ 01:35 < gmaxwell> oh lol I was already running with those two patches. 01:35 < bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/a8cbbdb07a59...0dfc25f82a01 01:35 < bitcoin-git> bitcoin/master f26866b Cory Fields: boost: drop boost threads for upnp 01:35 < bitcoin-git> bitcoin/master ba91724 Cory Fields: boost: remove useless threadGroup parameter from Discover 01:35 < bitcoin-git> bitcoin/master 0827267 Cory Fields: boost: drop boost threads from torcontrol 01:35 < wumpus> heh 01:35 -!- Lightsword [~Lightswor@107.170.253.193] has joined #bitcoin-core-dev 01:36 < bitcoin-git> [bitcoin] laanwj closed pull request #12381: Remove more boost threads (master...boost-threads-again) https://github.com/bitcoin/bitcoin/pull/12381 01:38 < Randolf> Maybe #12393 is an easy one to close? 01:39 < gribble> https://github.com/bitcoin/bitcoin/issues/12393 | Fix a-vs-an typos by practicalswift · Pull Request #12393 · bitcoin/bitcoin · GitHub 01:39 < Randolf> Merge? 01:39 < Randolf> Simple documentation fixes. 01:39 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 01:39 < Randolf> Not a high priority. 01:40 < gmaxwell> Randolf: it has pending requested changes by reviewers. 01:40 < wumpus> documentation is high priority unless. yeah, this is only typos 01:40 < Randolf> gmaxwell: Okay. Is there a place where one can see what's in the "pending requested changes by reviewers" list? Or is the fact that they're open already implying that? 01:41 < gmaxwell> Randolf: look at the last comments on it. 01:41 < gmaxwell> oh I misread, sorry! 01:41 < Randolf> I see "utACK" from luke-jr. 01:41 < gmaxwell> (I thought the last comment was asking to remove that change, and I saw no commits after it) 01:42 -!- nejon [uid38993@gateway/web/irccloud.com/x-xzjiectpokafjwbh] has quit [] 01:42 < Randolf> My curiosity on this is motivated by my desire to gain a better understanding of how this all works. 01:42 -!- nejon [sid38993@gateway/web/irccloud.com/x-udftcjuqukplaxgu] has joined #bitcoin-core-dev 01:43 < Randolf> (So far, the process overall seems to be well organized and efficient.) 01:44 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection] 01:50 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0dfc25f82a01...108af52ef75a 01:50 < bitcoin-git> bitcoin/master 11376b5 practicalswift: Fix a-vs-an typos 01:50 < bitcoin-git> bitcoin/master 108af52 Wladimir J. van der Laan: Merge #12393: Fix a-vs-an typos... 01:51 < bitcoin-git> [bitcoin] laanwj closed pull request #12393: Fix a-vs-an typos (master...a-vs-an-typos) https://github.com/bitcoin/bitcoin/pull/12393 01:53 < Randolf> wumpus: I agree. 02:00 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 02:03 < wumpus> Randolf: cool, someone finally agrees with me for once, mind if I save the quote? :) 02:06 < Sentineo> :D 02:07 -!- mturquette [sid66043@gateway/web/irccloud.com/x-lcaylmwskhvitukb] has quit [] 02:08 -!- mturquette [sid66043@gateway/web/irccloud.com/x-kgxhncpnquinmcuz] has joined #bitcoin-core-dev 02:10 -!- Cogito_Ergo_Sum [~Myself@ppp-94-64-157-186.home.otenet.gr] has joined #bitcoin-core-dev 02:10 -!- Cogito_Ergo_Sum [~Myself@ppp-94-64-157-186.home.otenet.gr] has quit [Changing host] 02:10 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev 02:10 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has joined #bitcoin-core-dev 02:16 < Randolf> wumpus: Yes, I have no objections to being quoted. (My full name is Randolf Richardson.) 02:17 < wumpus> Randolf: woohoo! 02:17 < Randolf> wumpus: I'm a big fan of writing documentation before coding. I do this with all the software that I write. 02:18 < Randolf> wumpus: It sure makes maintenance easier later on. 02:19 < wumpus> Randolf: yup; it's good to have a background idea why something was done; and the most important thing is correct documentation, comments that are deceiving and don't match the code are worse than having no comments at all 02:20 < Randolf> I like comments in code too. Sometimes they are overdone though, so I prefer to have a mixture of per-line comments (for specific things that need it) and an introductory set prior to a number of instructions / lines of code. 02:21 < wumpus> I think what is important about code comments is that they explain reasoning, not directly what the code does which is obvious to everyone with knowledge of the programming language 02:31 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/108af52ef75a...b4d85490f09e 02:31 < bitcoin-git> bitcoin/master faefd29 MarcoFalke: qa: Prepare functional tests for Windows... 02:31 < bitcoin-git> bitcoin/master b4d8549 Wladimir J. van der Laan: Merge #11858: qa: Prepare tests for Windows... 02:32 < bitcoin-git> [bitcoin] laanwj closed pull request #11858: qa: Prepare tests for Windows (master...Mf1712-qaWinForRealNow) https://github.com/bitcoin/bitcoin/pull/11858 02:36 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 02:38 -!- nOgAnOo [sid146237@gateway/web/irccloud.com/x-khiqlkfksydbeekq] has quit [] 02:38 -!- nOgAnOo [sid146237@gateway/web/irccloud.com/x-juqsjeoerlrovmio] has joined #bitcoin-core-dev 02:41 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b4d85490f09e...c8b54b2044db 02:41 < bitcoin-git> bitcoin/master a25cb0f murrayn: Use ptrdiff_t type to more precisely indicate usage and avoid compiler warnings. 02:41 < bitcoin-git> bitcoin/master c8b54b2 Wladimir J. van der Laan: Merge #12351: Libraries: Use correct type ; avoid compiler warnings.... 02:42 < bitcoin-git> [bitcoin] laanwj closed pull request #12351: Libraries: Use correct type ; avoid compiler warnings. (master...ptrdiff_t) https://github.com/bitcoin/bitcoin/pull/12351 02:44 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:44 < bitcoin-git> [bitcoin] jonasschnelli pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/c8b54b2044db...8e6f9f4ebc74 02:44 < bitcoin-git> bitcoin/master 718f05c Gregory Sanders: move more bumpfee prechecks to feebumper::PreconditionChecks 02:44 < bitcoin-git> bitcoin/master faca18d MarcoFalke: feebumper: Use PreconditionChecks to determine bump eligibility 02:44 < bitcoin-git> bitcoin/master 8e6f9f4 Jonas Schnelli: Merge #12296: wallet: Only fee-bump non-conflicted/non-confirmed txes... 02:45 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 02:45 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #12296: wallet: Only fee-bump non-conflicted/non-confirmed txes (master...Mf1801-walletFeeBumpNoConf) https://github.com/bitcoin/bitcoin/pull/12296 02:46 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 02:47 < provoostenator> In at least some cases the reference code is more clear than the BIP it implements, thanks to an abundance of comments. 02:48 < bitcoin-git> [bitcoin] laanwj closed pull request #12023: update the OpenBSD build guide (master...openbsd) https://github.com/bitcoin/bitcoin/pull/12023 02:48 < promag> is it valid or not to have the on scriptpubkey duplicated? 02:48 < wumpus> provoostenator: that's a good thing, yes :) 02:48 < promag> *the same 02:49 -!- DrFeelGood [~DrFeelGoo@unaffiliated/olufunmilayo] has quit [Ping timeout: 240 seconds] 02:49 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:50 < gmaxwell> the same scriptpubkey duplicated where? 02:50 < gmaxwell> promag: are you asking if a transaction can have multiple outputs using the same scriptpubkey? 02:51 < promag> yes, sorry if it was't clear 02:51 < gmaxwell> If so, thats valid in the consensus rules, though bitcoin core's wallet (and I assume most other wallets) won't produce it. 02:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds] 02:52 < gmaxwell> (e.g. if you do a sendmany with repeated outputs it just merges them) 02:52 < murrayn> sipa, I get that. But where's the bottleneck? I could see if one cpu was pegged. Or disk IO. But nothing seems to be happening. It's just slow. 02:52 < bitcoin-git> [bitcoin] laanwj closed pull request #11790: Add pixmaps for testnet and regtest (master...pixmaps) https://github.com/bitcoin/bitcoin/pull/11790 02:52 < promag> gmaxwell: well fundrawtransaction allows a change address to be one of the outputs 02:52 -!- Julie73Donnelly [~Julie73Do@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 02:52 < promag> gmaxwell: should probably check that? 02:53 < wumpus> sounds like an edge case that might be checked, yes. Not because it would be invalid, but because it 100% sure means someone made amistake. 02:54 < promag> maybe 99% 02:54 < promag> :P 02:54 < wumpus> I can't think of any reason why it wouldn't be 02:55 < promag> like a stupid coin split to same address 02:55 < wumpus> I see no point to doing that 02:55 < promag> anyway, should we bother to check that on these raw rpc? 02:58 < wumpus> esp. after #12257, when the coin selection is changed so that all coins sent to a certain destination will always be spent at once 02:58 < gribble> https://github.com/bitcoin/bitcoin/issues/12257 | [wallet] Use destination groups instead of coins in coin select by kallewoof · Pull Request #12257 · bitcoin/bitcoin · GitHub 03:00 < promag> wumpus: should the check be in fundrawtransaction or CWallet::CreateTransaction? 03:01 < wumpus> probably in CreateTransaction if you want to catch all cases where this is a possibility 03:02 < wumpus> e.g. otherwise you could still do the same trick from the GUI with coincontrol? 03:02 < sipa> murrayn: usually it's RAM and disk access that's the bottleneck 03:04 < murrayn> sipa I can confirm that it's neither for me. I am running dbcache 2048 and disk IO is not a factor. 03:04 < sipa> what are you observing? 03:04 < murrayn> what do you mean? 03:04 < sipa> what do you see, what do you expect to see 03:05 < murrayn> like i said i could understand if one cpu was pegged. i have a quad core processor 03:05 < murrayn> there is no heavy disk i/o 03:05 < sipa> well is it making progress? 03:05 < murrayn> it moves forward, like time itself 03:06 < sipa> is it validating blocks? 03:06 < murrayn> yes! 03:06 < sipa> what's in debug.log? 03:06 < murrayn> but if i have the hardware, why not do it quicker? i'm waiting dammit! 03:07 < gmaxwell> murrayn: bitcoin it takes hours to sync even on the fastest hardware available, its doing a tremendous amount of work. 03:07 < gmaxwell> when you say 'disk IO is not a factor' -- this isn't particularly convincing. IOwait often doesn't look like high usage. 03:08 < phantomcircuit> gmaxwell, i do experience stang performance things doing IBD over the network where there isn't any obvious bottleneck 03:08 < phantomcircuit> (vm with fsync off) 03:08 < sipa> with dbcache 2048 i would expect 100% cpu usage on one core though 03:08 < sipa> for extended periods of time between flushes 03:08 < echeveria> it comes across to me as sort of bursty for no real reason. 03:08 < wumpus> I'm missing the context, but if it doesn't max out your CPUs, don't you happen to have bad peers so it's waiting for blocks? 03:09 < murrayn> https://pastebin.com/nAipD6J3 03:09 < phantomcircuit> wumpus, yes 03:09 < echeveria> wumpus: even when directly connected to a single peer on a 200Mbit line, I've seen that. 03:09 < wumpus> in the latter stages of synchronization it will generally use all cores at 100% where it can, in my experience 03:09 < murrayn> that's the tail of debug.log 03:09 < phantomcircuit> iirc there is supposed to be logic to handle that but it doesn't seem to work great 03:09 < phantomcircuit> but it works well enough that i haven't looked carefully 03:09 < sipa> murrayn: can you show a bit more? 03:10 < murrayn> sure, how much? 03:10 < sipa> a page 03:10 < gmaxwell> stalling peers is certantly a thing, the functionality to deal with that is "simplest thing necessary to avoid totally failing" grade. 03:10 < gmaxwell> murrayn: are you doing this sync on a computer you physically have or AWS or what? 03:10 < wumpus> gmaxwell: indeed 03:10 < murrayn> https://pastebin.com/jXXLpmxE 03:11 < murrayn> gmaxwell, my desktop 03:11 < echeveria> 2018-02-12 11:06:21 version handshake timeout from 476 03:11 < echeveria> 2018-02-12 11:06:24 version handshake timeout from 477 03:11 < echeveria> that's fun. 03:12 < echeveria> it's in my log a bunch too but I've never been able to work out a pattern in it. 03:13 < sipa> murrayn: you may want to run with -debug=bench of you want to figure out what it's spending time on 03:13 < sipa> but it may just be shitty peers 03:13 < sipa> that don't give you blocks fast enough for you to process 03:13 < murrayn> well i'm afraid to start over! 03:13 < sipa> it won't 03:13 < murrayn> "only" 1 year 16 weeks behind 03:14 < sipa> if you shutdown cleanly it will continue where it left off 03:14 < murrayn> ok sipa i will try 03:15 < gmaxwell> These logs look pretty normal. 03:15 < gmaxwell> other than it being a bit slow. 03:15 < murrayn> just to add some background this is running with -reindex-chainstate because i already had all the blocks downloaded 03:15 < sipa> oh 03:15 < gmaxwell> see now all these peer theories go out the window. 03:15 < sipa> well, then it's not due to slow peers 03:16 < murrayn> no 03:16 < sipa> but in any case, don't run with -reindex-chainstate the second time or it will start over again 03:16 < murrayn> my initial sync took 10 days which i thought was crazy 03:16 < sipa> but you can shutdown and it will continue the reindex 03:17 < gmaxwell> murrayn: what OS and what version of the software is this? 03:17 < murrayn> win7, 0.15.1 03:17 < gmaxwell> some anti-virus can absurdly slow down sync. 03:17 < murrayn> n/a 03:18 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 03:18 < gmaxwell> wumpus: why are you running -reindex-chainstate? 03:19 < murrayn> gmaxwell, do you mean me? 03:19 < gmaxwell> lol yes 03:19 < murrayn> ok 03:19 < murrayn> i moved the datadir to a new disk 03:19 < gmaxwell> would it happen to be a USB hard drive? 03:19 < murrayn> and when i restarted bitcoin-qt it did it's thing 03:19 < murrayn> gmaxwell, no 03:19 < phantomcircuit> murrayn, that looks like io issues 03:19 < phantomcircuit> there's 2-3 seconds between blocks 03:20 < phantomcircuit> it's not bursty 03:20 < murrayn> i would be glad to see 2-3s/block 03:21 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Read error: Connection reset by peer] 03:21 < murrayn> phantomcircuit, it's just not IO. these aren't slow drives 03:21 < murrayn> i would hear them! 03:21 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 03:21 < bitcoin-git> [bitcoin] promag opened pull request #12415: Interrupt loading thread after shutdown request (master...2018-02-shutdown) https://github.com/bitcoin/bitcoin/pull/12415 03:22 < gmaxwell> hear them? 03:22 < murrayn> i do see memory use climb up to 2G+, but then it drops down and starts the cycle again 03:22 * gmaxwell waits to hear that he's using a shingled spinning disk... 03:22 < murrayn> it's under 1G now 03:23 < gmaxwell> murrayn: yes when the cache fills it flushes. 03:23 < murrayn> yeah, makes sense 03:23 < gmaxwell> The name cache is largely a misnomer, the main useful thing the cache does during sync is act as a buffer to prevent spent outputs from ever hitting the database. 03:24 < gmaxwell> it caches too, but that function doesn't do much for performance. 03:24 < gmaxwell> (during sync) 03:24 < murrayn> ok, well i'm using -dbcache=2048 03:25 < murrayn> just out of curiosity, when is the last time any of you guys in this conversation started a new datadir 03:26 < murrayn> i'm willing to believe it's some issue with the windows build, and willing to try to track it down. 03:27 < gmaxwell> murrayn: several times a month. 03:27 < murrayn> ok, thought so 03:27 < gmaxwell> murrayn: it's not an issue with the 'windows build' people have reported couple hour syncs in windows with 0.15.x 03:27 < murrayn> gmaxwell, from the network? 03:27 < gmaxwell> murrayn: yes, and reindexes. 03:28 < murrayn> well in any case i would like to help track it down. from what I read I'm not alone. 03:28 -!- Pavle [~pavle_@unaffiliated/pavle/x-4679000] has joined #bitcoin-core-dev 03:29 < gmaxwell> in your case either you finished syncing from blocks on disk and started pulling from the network and your slower due to peers/network.. or your IO is just super high latency on your system. 03:29 < gmaxwell> murrayn: sipa asked you earlier to turn up bench debugging. 03:30 < gmaxwell> murrayn: you can turn them on without restarting dunno why he didn't suggest that. 03:30 < murrayn> gmaxwell, yeah but i don't want to restart and lose over two days of "progress" 03:30 < murrayn> oh ok 03:30 < gmaxwell> you won't lose progress. 03:30 < gmaxwell> regardless, it'll continue from where it is. 03:30 < gmaxwell> use the logging rpc/cli command to enable bench and net 03:31 < murrayn> can you give me a tldr? 03:31 < murrayn> the command 03:31 < wumpus> I think it's time to move this to #bitcoin 03:31 < gmaxwell> murrayn: you're using the gui interface? bring up the debug console and run logging '["bench","net"]' 03:32 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #bitcoin-core-dev 03:32 < murrayn> or console. ok will try 03:32 < murrayn> done will report back in a few 03:35 -!- drizztbsd [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 03:38 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 03:41 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 03:42 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 03:44 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 03:46 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 265 seconds] 04:08 -!- Sentineo [~Undefined@unaffiliated/sentineo] has quit [Remote host closed the connection] 04:11 < dcousens> wumpus - hope https://github.com/bitcoin/bitcoin/pull/12169#issuecomment-364903510 didn't de-rail, I was genuinely curious and figured it might be useful to others to see a code example 04:13 -!- PiedPiper [~PiedPiper@189.34.46.84] has joined #bitcoin-core-dev 04:19 -!- Sentineo [~Undefined@unaffiliated/sentineo] has joined #bitcoin-core-dev 04:31 -!- PiedPiper [~PiedPiper@189.34.46.84] has left #bitcoin-core-dev [] 04:33 -!- Giszmo1 [~leo@pc-204-28-214-201.cm.vtr.net] has joined #bitcoin-core-dev 04:51 -!- Giszmo1 [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Read error: Connection reset by peer] 05:03 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-joyvjbqpwfcyyzdm] has joined #bitcoin-core-dev 05:09 -!- Aaronvan_ is now known as AaronvanW 05:19 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 05:20 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 05:22 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 05:32 -!- Jacinthe3Hermist [~Jacinthe3@static.22.144.99.88.clients.your-server.de] has joined #bitcoin-core-dev 05:40 -!- Pavle [~pavle_@unaffiliated/pavle/x-4679000] has quit [Quit: Leaving] 05:43 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 05:48 -!- mariorz [sid490@gateway/web/irccloud.com/x-mikjrxnmvepgcrpr] has quit [] 05:48 -!- jtimon [~quassel@41.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 05:48 -!- mariorz [sid490@gateway/web/irccloud.com/x-qdtcttaohpcilmju] has joined #bitcoin-core-dev 05:54 -!- hasish [~ubuntu@89.160.185.147] has joined #bitcoin-core-dev 06:02 -!- hasish [~ubuntu@89.160.185.147] has quit [Quit: leaving] 06:07 -!- DarylSharp [~DarylShar@2601:14e:101:faa0::3] has quit [Ping timeout: 252 seconds] 06:13 -!- wbnns [sid105317@21/bitcoin/binns] has quit [] 06:13 -!- wbnns [sid105317@21/bitcoin/binns] has joined #bitcoin-core-dev 06:18 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/8e6f9f4ebc74...5dc00f68c49c 06:18 < bitcoin-git> bitcoin/master a570098 MarcoFalke: Squashed 'src/univalue/' changes from 07947ff2da..51d3ab34ba... 06:18 < bitcoin-git> bitcoin/master fa1388e MarcoFalke: univalue: Bump subtree 06:18 < bitcoin-git> bitcoin/master 91986ed Karel Bilek: scripted-diff: Use UniValue.pushKV instead of push_back(Pair())... 06:19 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #12193: RPC: Consistently use UniValue.pushKV instead of push_back(Pair()) (karel-3d) (master...Mf1801-univalueDeprecatedPair) https://github.com/bitcoin/bitcoin/pull/12193 06:28 -!- ibrightly [sid113387@gateway/web/irccloud.com/x-bjtgwsnrureudwup] has quit [] 06:28 -!- ibrightly [sid113387@gateway/web/irccloud.com/x-jbkdlmiicktjnrbu] has joined #bitcoin-core-dev 06:29 -!- unholymachine [~quassel@2601:8c:c003:9f16:f9b1:1680:6eef:6406] has quit [Ping timeout: 276 seconds] 06:30 -!- unholymachine [~quassel@c-69-248-123-139.hsd1.nj.comcast.net] has joined #bitcoin-core-dev 06:33 -!- sferrini [sid115350@gateway/web/irccloud.com/x-secoscmohsqykswp] has quit [] 06:34 -!- sferrini [sid115350@gateway/web/irccloud.com/x-vpphwjambkipupkb] has joined #bitcoin-core-dev 06:51 < bitcoin-git> [bitcoin] practicalswift opened pull request #12416: Fix Windows build errors introduced in #10498 (master...fix-windows-build) https://github.com/bitcoin/bitcoin/pull/12416 07:08 -!- CodeShark [sid126576@gateway/web/irccloud.com/x-dmsxjppardkwgvpf] has quit [] 07:09 -!- CodeShark [sid126576@gateway/web/irccloud.com/x-vvmwafrwnyobaqer] has joined #bitcoin-core-dev 07:22 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-rvgbudxdnooeytzv] has quit [Quit: Connection closed for inactivity] 07:28 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-nlifvxwyhngqaywi] has quit [] 07:28 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-wlhjuvjnzvfrpwzq] has joined #bitcoin-core-dev 07:58 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 08:00 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 264 seconds] 08:20 -!- grafcaps [~haroldbr@104.137.194.255] has joined #bitcoin-core-dev 08:21 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 08:22 < instagibbs> is someone generating hashes of issues/prs somewhere? 08:22 -!- FraJah [~Fractal@unaffiliated/frajah] has joined #bitcoin-core-dev 08:22 < instagibbs> wumpus, oh i see you linked, nevermind 08:23 -!- neha [~narula@tbilisi.csail.mit.edu] has quit [Ping timeout: 276 seconds] 08:23 -!- neha [~narula@tbilisi.csail.mit.edu] has joined #bitcoin-core-dev 08:24 < wumpus> yes not so much hashes as a full mirror of information available through the API, though of course you can use it to compute hashes: https://github.com/zw/bitcoin-gh-meta 08:25 -!- grafcaps [~haroldbr@104.137.194.255] has quit [Ping timeout: 264 seconds] 08:25 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection] 08:26 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 08:28 -!- grafcaps [~haroldbr@104.137.194.255] has joined #bitcoin-core-dev 08:30 -!- trotski2000 [sid206086@gateway/web/irccloud.com/x-fvjebftmsukauvpp] has quit [] 08:30 -!- trotski2000 [sid206086@gateway/web/irccloud.com/x-hxfyarfdhrviwkgn] has joined #bitcoin-core-dev 08:32 -!- Varunram [sid210151@gateway/web/irccloud.com/x-togftzvbyjcvsieu] has quit [] 08:32 -!- Varunram [sid210151@gateway/web/irccloud.com/x-cqhjlybqqjgjotvm] has joined #bitcoin-core-dev 08:34 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev 08:42 -!- quer [~quer@unaffiliated/quer] has joined #bitcoin-core-dev 08:49 -!- JackH [~laptop@host-80-47-80-55.as13285.net] has quit [Quit: Leaving] 08:50 -!- hasish [~ubuntu@89.160.185.147] has joined #bitcoin-core-dev 09:11 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 09:40 -!- Dizzle [~dizzle@108.171.182.16] has quit [Remote host closed the connection] 09:41 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev 09:45 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 09:46 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 09:52 -!- twistedline [~quassel@unaffiliated/twistedline] has quit [Ping timeout: 264 seconds] 09:56 -!- twistedline [~quassel@unaffiliated/twistedline] has joined #bitcoin-core-dev 10:04 -!- qttmyth88 [aa347ca6@gateway/web/freenode/ip.170.52.124.166] has joined #bitcoin-core-dev 10:10 < qttmyth88> Hello, Is there a precaution to sending a request through bitcoin core. What happens if a malware classified me as a fraud because my name doesn't show as the name on the internet provider. Is there away to remove me off that alert? 10:11 -!- spinza [~spin@196.212.164.26] has quit [Ping timeout: 256 seconds] 10:16 -!- drizztbsd [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 10:18 -!- jojeyh [~delphi@2602:306:b8b6:b970:9998:324b:a5a3:1e2c] has joined #bitcoin-core-dev 10:20 -!- qttmyth88 [aa347ca6@gateway/web/freenode/ip.170.52.124.166] has quit [Quit: Page closed] 10:37 -!- Harvey_Birdman [4623aa04@gateway/web/freenode/ip.70.35.170.4] has joined #bitcoin-core-dev 10:40 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 10:45 < provoostenator> How is change_type in coincontrol used? There's no UI for it afaik, but maybe an RPC command? 10:46 -!- Harvey_Birdman [4623aa04@gateway/web/freenode/ip.70.35.170.4] has quit [Quit: Page closed] 10:46 -!- polpol [b19e7d97@gateway/web/freenode/ip.177.158.125.151] has joined #bitcoin-core-dev 10:48 < provoostenator> Or is coincontrol.h alwasys used even if the user turns off "Enable coin control features"? 10:49 < sipa> yes, it's just the interface to pass information to the coin selection algorithm 10:57 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has joined #bitcoin-core-dev 10:59 < polpol> i heard that after 0.16.0 segwit will be used "by default" is that correct? 11:00 < sipa> yes 11:02 < polpol> that means that segwit usage will be 100% or not necessarily? 11:02 < sipa> no, people may be using wallet software other than bitcoin core 11:02 < sipa> or may choose to turn it off 11:03 < sipa> or may continue to use addresses they created before 11:03 < polpol> got it, thank you sipa 11:03 < sipa> or may keep spending coins sent to earlier addresses 11:04 < michagogo> Does anyone here have any experience in working with Ubuntu packages (backports etc.)? 11:05 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 11:07 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 11:12 -!- zautomata [~zautomata@unaffiliated/zautomata] has joined #bitcoin-core-dev 11:13 -!- alephzero [~User@unaffiliated/amphetamine] has quit [Quit: leaving] 11:14 -!- AdrianG [~User@unaffiliated/amphetamine] has joined #bitcoin-core-dev 11:15 -!- AdrianG is now known as AlephZero 11:17 < instagibbs> provoostenator, yeah coin control is an overloaded term imo. consumers see it as that qt window, Core contributors see it as what sipa said 11:18 < provoostenator> Is there a good reason not to just remove that checbox and turn it on by default? 11:20 < sipa> which checkbox? 11:20 < provoostenator> There's a "Enable Coin Control Features" checkbox in the QT settings.Maybe move Coin Control Features to the bottom of the Send screen, below fees. As long as the basic stuff is at the top, it shouldn't be too intimiating. 11:21 < provoostenator> And some sort of Show / Hide toggle in the send screen itself make more sense to me in general. 11:21 < sipa> define basic stuff 11:22 < provoostenator> Basic stuff: how much, to which address 11:22 < sipa> the idea is that most users don't know and shouldn't care about things like coins, inputs, outputs, groupings, ... 11:22 < provoostenator> (and label / note) 11:23 -!- Scrat [~herp@unaffiliated/scrat] has quit [Ping timeout: 248 seconds] 11:24 < provoostenator> The Coin Control Feature at the moment are only Input selection and a custom change address. They can be hidden by default, but I don't need you need a setting to reveal them. 11:24 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has quit [Remote host closed the connection] 11:25 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has joined #bitcoin-core-dev 11:26 < provoostenator> E.g. there could be Coin Control button next to Add Recipient at the bottom of the screen to toggle that section. 11:39 -!- spinza [~spin@196.212.164.26] has joined #bitcoin-core-dev 11:40 -!- mirese_ [~mirese@2a02:1205:507c:3710:c104:300c:363b:2a5d] has joined #bitcoin-core-dev 11:41 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 248 seconds] 11:44 -!- mirese [~mirese@2a02:1205:507c:3710:2546:9e1d:7489:75d2] has quit [Ping timeout: 256 seconds] 11:44 < provoostenator> ryanofsky or someone else: re #11625, I have no idea how to use gdb other than "gdb src/qt/test/test_bitcoin-qt" 11:44 < gribble> https://github.com/bitcoin/bitcoin/issues/11625 | Add BitcoinApplication & RPCConsole tests by ryanofsky · Pull Request #11625 · bitcoin/bitcoin · GitHub 11:44 < provoostenator> And do I need to use any special configure flags? 11:46 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 11:47 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection] 11:48 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 11:58 -!- polpol [b19e7d97@gateway/web/freenode/ip.177.158.125.151] has quit [Quit: Page closed] 12:03 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 12:06 -!- dcousens [~dcousens@110.140.19.17] has quit [Ping timeout: 256 seconds] 12:07 -!- dcousens [~dcousens@101.188.141.174] has joined #bitcoin-core-dev 12:10 < michagogo> Hm 12:10 < michagogo> I tried to see if mingw-w64 was easily backportable 12:10 < michagogo> And it's not really working, something about dependencies 12:11 -!- cysm [cysm@gateway/shell/elitebnc/x-vvejkscsnntcyerm] has quit [Remote host closed the connection] 12:12 < michagogo> For all I know it's easy to fix, but I don't actually know ~anything about Ubuntu packaging, so I have no idea how to do more than run the `backportpackage` command :-/ 12:19 < cfields> sipa: 1day-ago pong. 12:25 < instagibbs> fAllowOtherInputs comment seems to be off. "//! If false, allows unselected inputs, but requires all selected inputs be used". But AvailableCoins immediately filters things not on the selected list when list is non-zero 12:25 < instagibbs> am I understanding it right 12:27 < instagibbs> SelectCoins allows you to use other inputs, but those inputs will never be fed in the normal Available->Select flow 12:32 < provoostenator> Gotta love Stack Overflow... "Here's one million ways to fix gdb on OSX...." "Oh by the way, you can use lldb" 12:33 -!- jamesob [~jamesob@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #bitcoin-core-dev 12:34 -!- Pavle [~pavle_@unaffiliated/pavle/x-4679000] has joined #bitcoin-core-dev 12:37 < bitcoin-git> [bitcoin] droark opened pull request #12417: [WIP] Delete mac_alias patch (master...master_del_mac_alias) https://github.com/bitcoin/bitcoin/pull/12417 12:38 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds] 12:41 -!- hasish [~ubuntu@89.160.185.147] has quit [Quit: leaving] 12:43 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has quit [Quit: (https://github.com/mmgen) leaving] 12:49 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has quit [Remote host closed the connection] 12:50 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has joined #bitcoin-core-dev 13:00 -!- Pavle [~pavle_@unaffiliated/pavle/x-4679000] has quit [Quit: Leaving] 13:07 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 13:08 -!- cysm [cysm@gateway/shell/elitebnc/x-xgrkvrnvzyxonoss] has joined #bitcoin-core-dev 13:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 13:26 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has quit [Ping timeout: 265 seconds] 13:35 -!- Cheeseo [Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 13:38 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 13:38 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 13:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds] 13:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 13:50 -!- jamesob [~jamesob@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Ping timeout: 248 seconds] 13:51 -!- neha [~narula@tbilisi.csail.mit.edu] has quit [Ping timeout: 240 seconds] 13:52 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 252 seconds] 13:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds] 13:55 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Ping timeout: 240 seconds] 14:00 -!- neha [~narula@tbilisi.csail.mit.edu] has joined #bitcoin-core-dev 14:00 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-gkxckesijgafxhmg] has joined #bitcoin-core-dev 14:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 14:07 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev 14:07 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has quit [] 14:08 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 14:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 14:20 -!- n1bor [~n1bor@185.9.34.66] has joined #bitcoin-core-dev 14:22 < n1bor> @murrayn how much RAM do you have? I have seen this sort of performance with 4Gig or less of RAM. Put in 8-12 Gig and same machine was 10x faster. 14:23 < n1bor> ibd hate to be short of RAM. I think the filesystem cache needs it for leveldb reads? 14:24 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 256 seconds] 14:25 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5dc00f68c49c...c997f8808256 14:25 < bitcoin-git> bitcoin/master f40df29 practicalswift: Fix Windows build errors introduced in #10498... 14:25 < bitcoin-git> bitcoin/master c997f88 MarcoFalke: Merge #12416: Fix Windows build errors introduced in #10498... 14:26 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #12416: Fix Windows build errors introduced in #10498 (master...fix-windows-build) https://github.com/bitcoin/bitcoin/pull/12416 14:34 -!- Dizzle [~dizzle@108.171.182.16] has quit [Quit: Leaving...] 14:36 -!- farmerwampum_ [~farmerwam@173.244.200.116] has joined #bitcoin-core-dev 14:37 -!- farmerwampum [~farmerwam@209.95.51.99] has quit [Ping timeout: 265 seconds] 14:37 -!- farmerwampum_ is now known as farmerwampum 14:39 -!- Aaronvan_ is now known as AaronvanW 14:39 -!- farmerwampum [~farmerwam@173.244.200.116] has quit [Client Quit] 14:40 -!- farmerwampum [~farmerwam@173.244.200.116] has joined #bitcoin-core-dev 15:05 -!- mirese [~mirese@2a02:1205:507c:3710:2d21:7894:8b77:a838] has joined #bitcoin-core-dev 15:08 -!- mirese_ [~mirese@2a02:1205:507c:3710:c104:300c:363b:2a5d] has quit [Ping timeout: 255 seconds] 15:09 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 15:10 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 15:18 -!- TheRec_ [~toto@drupal.org/user/146860/view] has quit [Ping timeout: 268 seconds] 15:18 -!- TheRec [~toto@84-75-205-212.dclient.hispeed.ch] has joined #bitcoin-core-dev 15:18 -!- TheRec [~toto@84-75-205-212.dclient.hispeed.ch] has quit [Changing host] 15:18 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 15:24 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 15:24 -!- Arise2 [Arise@gateway/vpn/privateinternetaccess/arisechikun] has quit [Read error: Connection reset by peer] 15:25 -!- Arise2 [Arise@gateway/vpn/privateinternetaccess/arisechikun] has joined #bitcoin-core-dev 15:25 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 15:32 < BlueMatt> ugh, duh 15:33 < BlueMatt> cfields: see https://github.com/bitcoin/bitcoin/pull/12349#issuecomment-365095741 15:33 < BlueMatt> #12367 only fixed the issue for non-reindex cases (ie where LoadChainTip gets called)...any other cases will simply happily initialize pcoinsTip on top of an empty chainstate and then expect to have genesis loaded in the ThreadImport 15:33 < gribble> https://github.com/bitcoin/bitcoin/issues/12367 | Fix two fast-shutdown bugs by TheBlueMatt · Pull Request #12367 · bitcoin/bitcoin · GitHub 15:34 < cfields> grr 15:36 < BlueMatt> we could revert to the initial suggestion of #12349 and just short-circuit flushing, but I really hate that 15:36 < gribble> https://github.com/bitcoin/bitcoin/issues/12349 | shutdown: fix crash on shutdown with reindex-chainstate by theuni · Pull Request #12349 · bitcoin/bitcoin · GitHub 15:36 < BlueMatt> would rather be smarter and not call FlushStateToDisk somehow 15:36 -!- goatpig [56f75164@gateway/web/freenode/ip.86.247.81.100] has quit [Quit: Page closed] 15:37 < cfields> BlueMatt: yes, I don't like that either. It was really only intended to jump of discussion about where to fix it for real. 15:37 < cfields> *jump off 15:37 < BlueMatt> I mean looking at the issue I dont really see a way to fix it that I like to begin with :( 15:37 < cfields> same, hence the punt :p 15:37 < BlueMatt> but should slip it into the next rc :( 15:38 < BlueMatt> well I liked my earlier fix...that didnt actually fix it :/ 15:39 < BlueMatt> I mean the other obvious option is to make it explicit - have some static in validation.cpp/CChainState that just means "ive gotten as far as loading the genesis block, I can flush now" 15:39 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Remote host closed the connection] 15:39 < cfields> right 15:39 < cfields> and don't we already have that, in some form? 15:40 < BlueMatt> not afaik.....I mean we just explicitly refuse to finish loading until we've gotten that far 15:41 < BlueMatt> Ive gotta run, but I'd say just do something in CChainState that gets set to true the first time we do a DisconnectBlock or ConnectBlock, and refuse to flush until then? 15:41 < BlueMatt> should fix the bug without hiding a hack in utxo flushing 15:41 < cfields> fHaveGenesis... ? 15:41 < BlueMatt> fHaveLoadedGenesis 15:42 < BlueMatt> sure 15:42 < BlueMatt> set either in LoadChainTip 15:42 < BlueMatt> or ConnectBlock 15:42 < BlueMatt> I think 15:42 < cfields> no i mean, look in init.cpp 15:42 < BlueMatt> yea, I know 15:42 < BlueMatt> it feels cleaner to duplicate it inside CChainState 15:43 < BlueMatt> so that its clearly a validation thing 15:43 < BlueMatt> instead of yet more global pollution 15:43 < BlueMatt> fHaveGenesis can continue to sit in init as a block-on-me-before-continuing 15:43 < BlueMatt> @eklitzke gets the credit for discovery, btw 15:44 * BlueMatt -> out 15:44 < cfields> looking, cya 16:06 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has quit [Ping timeout: 255 seconds] 16:14 -!- mirese_ [~mirese@2a02:1205:507c:3710:dc5c:e51f:b82c:93b] has joined #bitcoin-core-dev 16:16 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has joined #bitcoin-core-dev 16:17 -!- mirese [~mirese@2a02:1205:507c:3710:2d21:7894:8b77:a838] has quit [Ping timeout: 256 seconds] 16:20 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-gkxckesijgafxhmg] has quit [Quit: Connection closed for inactivity] 16:26 -!- rex_4539 [~textual@ppp-2-87-180-48.home.otenet.gr] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 16:33 -!- Randolf [~randolf@S01066872516d2e74.vc.shawcable.net] has joined #bitcoin-core-dev 16:50 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has joined #bitcoin-core-dev 16:57 -!- Randolf [~randolf@S01066872516d2e74.vc.shawcable.net] has quit [Ping timeout: 264 seconds] 16:58 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev 17:02 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-wifyelvjempnbhnw] has joined #bitcoin-core-dev 17:09 -!- Jacinthe3Hermist [~Jacinthe3@static.22.144.99.88.clients.your-server.de] has quit [Ping timeout: 276 seconds] 17:13 -!- grafcaps [~haroldbr@104.137.194.255] has quit [Ping timeout: 240 seconds] 17:15 -!- RezusMinus [RezusMinus@nova-153-092-135-157.cpe.nova.is] has joined #bitcoin-core-dev 17:19 -!- jonasschnelli [~jonasschn@unaffiliated/jonasschnelli] has quit [Ping timeout: 240 seconds] 17:19 < ProfMac> was there ever a time when GetBlockWork used the actual hash instead of nBits to calculate work? 17:20 -!- wolfspraul [~wolfsprau@bobbin.q-ag.de] has quit [Ping timeout: 240 seconds] 17:20 -!- wolfspraul [~wolfsprau@bobbin.q-ag.de] has joined #bitcoin-core-dev 17:20 < bitcoin-git> [bitcoin] promag opened pull request #12419: wallet: Force distinct destinations in CWallet::CreateTransaction (master...2018-02-distinct-destinations) https://github.com/bitcoin/bitcoin/pull/12419 17:20 < gmaxwell> no, that wouldn't be correct. 17:20 < ProfMac> tell me more. 17:20 -!- jonasschnelli [~jonasschn@bitcoinsrv.jonasschnelli.ch] has joined #bitcoin-core-dev 17:21 -!- dabura667_ [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev 17:21 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Read error: No route to host] 17:22 < gmaxwell> the hash reflects more than actual work, by a factor of two on average. It also has very high variance. meaning that if you got a block with ten times that 'work' expected (which you'd get in 1/10) blocks you could just delay announcing it until a couple blocks had passed, then announce it and be very likely to reorg them out. 17:22 < promag> gmaxwell: regarding duplicate outputs #12419 17:22 < gribble> https://github.com/bitcoin/bitcoin/issues/12419 | Force distinct destinations in CWallet::CreateTransaction by promag · Pull Request #12419 · bitcoin/bitcoin · GitHub 17:23 < ProfMac> Yes, gmaxwell, I agree with all that. 17:23 < ProfMac> Thanks. 17:24 < ProfMac> Not unlike "curling" or "corn hole" 17:29 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 17:36 -!- wacawacawaca [~user@wsip-66-210-9-178.dc.dc.cox.net] has joined #bitcoin-core-dev 17:37 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 17:38 -!- contrapumpkin is now known as Whale 17:38 -!- Whale is now known as contrapumpkin 17:39 -!- contrapumpkin is now known as Whale 17:39 -!- Whale is now known as contrapumpkin 17:53 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 18:34 < gmaxwell> n1bor: conversation continued in #bitcoin he posted bench logs which indicated to me that he was IO bound very badly. Today he followed up with, 18:34 < gmaxwell> n1bor: 18:28:24 < murrayn> gmaxwell, just to follow up from last night: 1) i shutdown gracefully and restarted, and the reindex started from the beginning. From what you said, it shouldn't do that? and 2) it was definitely disk IO bound. doing it on an SSD this time. much better 18:34 < gmaxwell> (1) was something sipa warned him about in here, that restarting with -reindex-chainstate would restart the reindex. 18:36 -!- TheRec_ [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 18:36 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Read error: Connection reset by peer] 18:38 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 18:39 < midnightmagic> doh 18:40 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has quit [Ping timeout: 255 seconds] 18:43 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 18:55 -!- jamesob [~jamesob@2604:2000:ee11:8700:2839:49a2:2dbc:318a] has joined #bitcoin-core-dev 19:05 -!- mandric [~mandric@108-228-58-104.lightspeed.cicril.sbcglobal.net] has quit [Quit: Computer has gone to sleep.] 19:10 < meshcollider> looks like contrib/bitcoin-cli.bash-completion needs an update, hasn't been updated for ages 19:24 < esotericnonsense> k, so i'm looking at the JSON-RPC 2.0 spec stuff now. 'strict compliance' requires two main changes as far as i can see. one of them I've made gated behind a flag 'strictjsonrpcspec' (better names accepted) 19:24 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has quit [Changing host] 19:24 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev 19:24 < esotericnonsense> that's the 'client must send jsonrpc=2.0, server must send jsonrpc=2.0, only one of 'error' or 'result' should be returned' 19:25 < esotericnonsense> the other bit is that if the client does not send an id with a request, the server should send a blank response. within a batch it should just be skipped. so if you send [a id=1, b, c id=3] you should get back [aresult, cresult]. 19:26 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [] 19:26 < esotericnonsense> i think that's enough to make it fully spec compliant. the former one is enough to get it to work with libjsonrpccpp, could probably write some unit tests based on the jsonrpc spec as well, manual tests i've done look fine 19:27 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has joined #bitcoin-core-dev 19:27 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has quit [Changing host] 19:27 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev 19:28 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Quit: Leaving.] 19:29 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Client Quit] 19:30 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev 19:30 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Client Quit] 19:31 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev 19:34 -!- dongcarl [~dongcarl@38.95.110.24] has joined #bitcoin-core-dev 19:37 -!- jamesob [~jamesob@2604:2000:ee11:8700:2839:49a2:2dbc:318a] has quit [Ping timeout: 260 seconds] 19:39 -!- zautomata1 [~zautomata@unaffiliated/zautomata] has joined #bitcoin-core-dev 19:41 -!- zautomata [~zautomata@unaffiliated/zautomata] has quit [Ping timeout: 240 seconds] 19:54 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #12349: shutdown: fix crash on shutdown with reindex-chainstate (master...fix-qt-shutdown) https://github.com/bitcoin/bitcoin/pull/12349 20:11 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 248 seconds] 20:23 -!- dongcarl_ [~dongcarl@174.127.103.180] has joined #bitcoin-core-dev 20:24 -!- dongcarl [~dongcarl@38.95.110.24] has quit [Ping timeout: 248 seconds] 20:41 -!- shesek [~shesek@bzq-84-110-234-105.red.bezeqint.net] has joined #bitcoin-core-dev 20:41 -!- shesek [~shesek@bzq-84-110-234-105.red.bezeqint.net] has quit [Changing host] 20:41 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 20:54 < kallewoof> What's going on here? Either that comment is wrong, or the check is wrong... https://github.com/bitcoin/bitcoin/blame/master/src/script/interpreter.cpp#L1233 (it says nOut out of range, but it checks nIn against txTo.vout.size()...) 20:57 < kallewoof> I guess it's because single requires the in to sign the same index out. Just weird looking. 21:06 < aj> kallewoof: yeah, "no vout corresponding to nIn" or something would make more sense to me as a comment 21:06 < aj> kallewoof: code seems right at least 21:07 -!- RezusMinus [RezusMinus@nova-153-092-135-157.cpe.nova.is] has quit [] 21:09 < aj> kallewoof: wow, that comment used to be a log output saying nOut out of range 21:13 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-joyvjbqpwfcyyzdm] has quit [Quit: Connection closed for inactivity] 21:14 < kallewoof> aj: yeah agreed! 21:15 -!- goatpig [56f75164@gateway/web/freenode/ip.86.247.81.100] has joined #bitcoin-core-dev 21:18 -!- rex_4539 [~textual@ppp-2-87-180-48.home.otenet.gr] has joined #bitcoin-core-dev 21:36 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has joined #bitcoin-core-dev 21:53 -!- Sinclair_ [~sinclair6@108-75-18-87.lightspeed.clmboh.sbcglobal.net] has joined #bitcoin-core-dev 21:55 -!- Sinclair6 [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has quit [Ping timeout: 265 seconds] 22:15 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has joined #bitcoin-core-dev 22:22 -!- dongcarl_ [~dongcarl@174.127.103.180] has quit [Ping timeout: 240 seconds] 22:23 -!- murrayn [~dafuq@unaffiliated/murrayn] has quit [Quit: Adios mofos] 22:32 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has quit [Ping timeout: 260 seconds] 22:32 -!- rex_4539 [~textual@ppp-2-87-180-48.home.otenet.gr] has quit [Quit: Textual IRC Client: www.textualapp.com] 23:00 -!- kallewoof [~karl@240d:1a:759:6000:a7b1:451a:8874:e1ac] has quit [Quit: WeeChat 1.7] 23:04 -!- kallewoof [~karl@fp96f94c66.tkyc515.ap.nuro.jp] has joined #bitcoin-core-dev 23:15 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Ping timeout: 240 seconds] 23:15 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has quit [Quit: (https://github.com/mmgen) leaving] 23:16 -!- Varunram [sid210151@gateway/web/irccloud.com/x-cqhjlybqqjgjotvm] has quit [Changing host] 23:16 -!- Varunram [sid210151@unaffiliated/varunram] has joined #bitcoin-core-dev 23:16 -!- Varunram [sid210151@unaffiliated/varunram] has quit [Changing host] 23:16 -!- Varunram [sid210151@gateway/web/irccloud.com/x-cqhjlybqqjgjotvm] has joined #bitcoin-core-dev 23:20 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 23:30 -!- bsm117532 [~mcelrath@173-9-124-61-NewEngland.hfc.comcastbusiness.net] has quit [Ping timeout: 252 seconds] 23:43 -!- dongcarl [~dongcarl@c-24-5-70-69.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 23:53 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has joined #bitcoin-core-dev