--- Day changed Thu Mar 29 2018
00:00 -!- lnostdal [~lnostdal@213.226.59.142] has joined #bitcoin-core-dev     
00:01 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev     
00:14 -!- Cogito_Ergo_Sum [~Myself@athedsl-314680.home.otenet.gr] has joined #bitcoin-core-dev     
00:14 -!- Cogito_Ergo_Sum [~Myself@athedsl-314680.home.otenet.gr] has quit [Changing host]     
00:14 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev     
00:28 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has quit []     
00:40 -!- JackH [~laptop@i25091.upc-i.chello.nl] has quit [Ping timeout: 268 seconds]     
00:50 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has joined #bitcoin-core-dev     
00:52 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Ping timeout: 240 seconds]     
00:53 -!- andytoshi [~apoelstra@wpsoftware.net] has joined #bitcoin-core-dev     
00:53 -!- JackH [~laptop@212.78.169.180] has joined #bitcoin-core-dev     
01:05 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has quit [Ping timeout: 264 seconds]     
01:07 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 246 seconds]     
01:11 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has quit [Remote host closed the connection]     
01:11 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev     
01:12 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has joined #bitcoin-core-dev     
01:12 -!- aruns__ [~indistylo@119.82.105.106] has joined #bitcoin-core-dev     
01:13 -!- CubicEarths [~cubiceart@2600:100f:b02e:7a78:cdbf:8303:4a9f:5bfe] has joined #bitcoin-core-dev     
01:16 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev     
01:16 -!- aruns [~indistylo@119.82.105.106] has quit [Ping timeout: 268 seconds]     
01:17 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 276 seconds]     
01:20 -!- aruns [~indistylo@119.82.105.106] has joined #bitcoin-core-dev     
01:22 -!- aruns__ [~indistylo@119.82.105.106] has quit [Ping timeout: 240 seconds]     
01:28 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
01:38 -!- rls [~rls@74.120.222.234] has quit [Ping timeout: 248 seconds]     
01:41 -!- psyopp [~rls@74.120.222.234] has joined #bitcoin-core-dev     
01:42 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds]     
01:44 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 276 seconds]     
01:49 -!- aruns [~indistylo@119.82.105.106] has quit [Ping timeout: 240 seconds]     
01:49 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
01:50 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev     
01:54 -!- aruns [~indistylo@119.82.105.106] has joined #bitcoin-core-dev     
02:00 -!- JackH [~laptop@212.78.169.180] has quit [Ping timeout: 268 seconds]     
02:04 -!- ohnx [notohnx@unaffiliated/ohnx] has quit [Read error: Connection reset by peer]     
02:04 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 276 seconds]     
02:07 -!- ohnx [notohnx@unaffiliated/ohnx] has joined #bitcoin-core-dev     
02:07 -!- aruns [~indistylo@119.82.105.106] has quit [Ping timeout: 256 seconds]     
02:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
02:08 -!- JackH [~laptop@212.78.169.180] has joined #bitcoin-core-dev     
02:08 -!- aruns [~indistylo@119.82.105.106] has joined #bitcoin-core-dev     
02:08 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
02:08 < murrayn> what's the best way of proceeding with this PR: https://github.com/bitcoin/bitcoin/pull/12809
02:08 < murrayn> Have I messed it up by merging master into it?
02:11 -!- CubicEarths [~cubiceart@2600:100f:b02e:7a78:cdbf:8303:4a9f:5bfe] has quit [Remote host closed the connection]     
02:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]     
02:12 -!- CubicEarths [~cubiceart@2600:100f:b02e:7a78:cdbf:8303:4a9f:5bfe] has joined #bitcoin-core-dev     
02:17 -!- CubicEar_ [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev     
02:17 < promag> murrayn: you should remove merge commit
02:20 < promag> on that branch do git rebase -i HEAD~3 
02:20 -!- CubicEarths [~cubiceart@2600:100f:b02e:7a78:cdbf:8303:4a9f:5bfe] has quit [Ping timeout: 245 seconds]     
02:20 < promag> then in the editor remove the line with the merge commit
02:20 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
02:20 < promag> save and quit, git log to verify, then force git push
02:21 < murrayn> there are a lot of lines, the merge is split into separate itms
02:21 < murrayn> remove them all?
02:22 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
02:22 < promag> murrayn: let me see
02:22 < murrayn> i.e. just leave the original commit
02:23 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
02:24 < promag> well, you can do git reset --hard master, git cherry-pick 91c8756, git cherry-pick e133491
02:25 < promag> but don't forget to git rebaes --abort first
02:26 < murrayn> e133491 was a change to something in the merge commit. so omit it?
02:29 < promag> yes     
02:30 < murrayn> ok here goes :-)
02:31 < murrayn> so the i will need to merge the cherry-pick of 91c8756
02:33 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-otrolkmkreodbupf] has quit [Quit: Connection closed for inactivity]     
02:35 < promag> what you mean by merge?
02:35 < promag> you just have to cherry pick 91c8756 after git reset --hard master
02:39 -!- drizztbsd is now known as timothy     
02:40 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt]     
02:41 < murrayn> promag, i mean i need to resolve the conflicts
02:43 -!- lnostdal [~lnostdal@213.226.59.142] has quit [Ping timeout: 240 seconds]     
02:48 < murrayn> ok, resolved the 3 or 4 conflicts in src/init.cpp
02:49 -!- lnostdal [~lnostdal@85-118-69-134.mtel.net] has joined #bitcoin-core-dev     
02:50 < murrayn> promag, now what? just commit?
02:50 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
02:50 < promag> murrayn: pm please
02:50 < murrayn> ok thanks for your help
02:53 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds]     
02:55 -!- lnostdal [~lnostdal@85-118-69-134.mtel.net] has quit [Ping timeout: 240 seconds]     
02:56 -!- karimofthecrop [~karim@rrcs-76-80-21-234.west.biz.rr.com] has joined #bitcoin-core-dev     
02:59 -!- lnostdal [~lnostdal@85-118-74-142.mtel.net] has joined #bitcoin-core-dev     
03:00 -!- karimofthecrop [~karim@rrcs-76-80-21-234.west.biz.rr.com] has quit [Ping timeout: 260 seconds]     
03:12 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
03:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds]     
03:24 -!- wxss [~user@82.221.139.119] has joined #bitcoin-core-dev     
03:36 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
03:37 -!- marcinja [~Mutter@51.37.206.3] has joined #bitcoin-core-dev     
03:38 -!- Strepsils [~textual@159.224.109.206] has joined #bitcoin-core-dev     
03:40 -!- marcinja [~Mutter@51.37.206.3] has quit [Remote host closed the connection]     
03:41 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has joined #bitcoin-core-dev     
03:42 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has quit [Client Quit]     
03:42 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has joined #bitcoin-core-dev     
03:49 -!- karimofthecrop [~karim@rrcs-76-80-21-234.west.biz.rr.com] has joined #bitcoin-core-dev     
03:51 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
03:54 -!- karimofthecrop [~karim@rrcs-76-80-21-234.west.biz.rr.com] has quit [Ping timeout: 264 seconds]     
03:59 -!- StopAndDecrypt_ [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has quit [Ping timeout: 256 seconds]     
04:00 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
04:04 < bitcoin-git> [bitcoin] conscott opened pull request #12826: Fix lint error - making travis builds fail  (master...fix_lint_error) https://github.com/bitcoin/bitcoin/pull/12826
04:05 < bitcoin-git> [bitcoin] fanquake closed pull request #12826: Fix lint error that is making travis builds fail  (master...fix_lint_error) https://github.com/bitcoin/bitcoin/pull/12826
04:06 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev     
04:14 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev     
04:17 -!- anome [~anome@unaffiliated/anome] has joined #bitcoin-core-dev     
04:19 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 264 seconds]     
04:19 -!- Strepsils [~textual@159.224.109.206] has quit [Remote host closed the connection]     
04:23 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has quit [Ping timeout: 248 seconds]     
04:28 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has quit [Quit: WeeChat 2.1]     
04:34 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has joined #bitcoin-core-dev     
04:35 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has quit [Changing host]     
04:35 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev     
04:37 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
04:37 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has joined #bitcoin-core-dev     
04:40 < bitcoin-git> [bitcoin] murrayn closed pull request #12809: Formatting changes to --help code for increased readability. (master...help_formatting) https://github.com/bitcoin/bitcoin/pull/12809
04:42 -!- anome [~anome@unaffiliated/anome] has quit []     
05:04 -!- suldev [~suldev@pool-108-52-119-134.phlapa.fios.verizon.net] has joined #bitcoin-core-dev     
05:05 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev     
05:05 < fanquake> wumpus/sipa are you around tonight? Be good to get #12821 in and get Travis back.
05:05 < gribble> https://github.com/bitcoin/bitcoin/issues/12821 | contrib: Remove unused import string by MarcoFalke · Pull Request #12821 · bitcoin/bitcoin · GitHub
05:13 < bitcoin-git> [bitcoin] matthias-g opened pull request #12827: Trivial: Don't use short version of 'tinyformat/fmt' namespace (master...tinyformat-fmt) https://github.com/bitcoin/bitcoin/pull/12827
05:26 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/624bee96597c...082e26c08bb0
05:26 < bitcoin-git> bitcoin/master 05120ee MarcoFalke: contrib: Remove unused import string
05:26 < bitcoin-git> bitcoin/master 082e26c Wladimir J. van der Laan: Merge #12821: contrib: Remove unused import string...
05:26 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Remote host closed the connection]     
05:27 < bitcoin-git> [bitcoin] laanwj closed pull request #12821: contrib: Remove unused import string (master...Mf1803-contribUnusedImportClangFormatDiff) https://github.com/bitcoin/bitcoin/pull/12821
05:27 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]     
05:28 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
05:30 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 245 seconds]     
05:32 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
05:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 248 seconds]     
05:35 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev     
05:47 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
05:52 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
05:56 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev     
05:59 < wumpus> fanquake: thanks
05:59 < fanquake> wumpus no worries. I'll go restart a few tests
06:01 < fanquake> Was also going to suggest #12495 for high-priority, but I see you've just approved it
06:01 < gribble> https://github.com/bitcoin/bitcoin/issues/12495 | Increase LevelDB max_open_files by eklitzke · Pull Request #12495 · bitcoin/bitcoin · GitHub
06:02 -!- suldev [~suldev@pool-108-52-119-134.phlapa.fios.verizon.net] has quit [Ping timeout: 256 seconds]     
06:03 < fanquake> Looks like #12787 is ready to go.
06:03 < gribble> https://github.com/bitcoin/bitcoin/issues/12787 | rpc: Adjust ifdef to avoid unreachable code by practicalswift · Pull Request #12787 · bitcoin/bitcoin · GitHub
06:04 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/082e26c08bb0...047865e8d188
06:04 < bitcoin-git> bitcoin/master ccedbaf Evan Klitzke: Increase LevelDB max_open_files unless on 32-bit Unix....
06:04 < bitcoin-git> bitcoin/master 047865e Wladimir J. van der Laan: Merge #12495: Increase LevelDB max_open_files...
06:04 < bitcoin-git> [bitcoin] laanwj closed pull request #12495: Increase LevelDB max_open_files (master...ldb_max_open_files) https://github.com/bitcoin/bitcoin/pull/12495
06:04 < fanquake> #12784 also
06:04 < gribble> https://github.com/bitcoin/bitcoin/issues/12784 | Fix bug in memory usage calculation (unintended integer division) by practicalswift · Pull Request #12784 · bitcoin/bitcoin · GitHub
06:06 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/047865e8d188...cd99e5bdc8fc
06:06 < bitcoin-git> bitcoin/master 61f8298 practicalswift: rpc: Adjust ifdef to avoid unreachable code
06:06 < bitcoin-git> bitcoin/master cd99e5b Wladimir J. van der Laan: Merge #12787: rpc: Adjust ifdef to avoid unreachable code...
06:07 < bitcoin-git> [bitcoin] laanwj closed pull request #12787: rpc: Adjust ifdef to avoid unreachable code (master...unreachable-code-ifdef-ENABLE_WALLET) https://github.com/bitcoin/bitcoin/pull/12787
06:09 < fanquake> wumpus do you want to make a decision on #12767
06:09 < gribble> https://github.com/bitcoin/bitcoin/issues/12767 | Initialize nVersionDummy to zero in deserialization code by practicalswift · Pull Request #12767 · bitcoin/bitcoin · GitHub
06:12 -!- goatpig [56f75164@gateway/web/freenode/ip.86.247.81.100] has joined #bitcoin-core-dev     
06:13 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/cd99e5bdc8fc...e80716d3b324
06:13 < bitcoin-git> bitcoin/master a16c6d2 practicalswift: Fix error in memory usage calculation (unintended integer division)
06:13 < bitcoin-git> bitcoin/master e80716d Wladimir J. van der Laan: Merge #12784: Fix bug in memory usage calculation (unintended integer division)...
06:13 < bitcoin-git> [bitcoin] laanwj closed pull request #12784: Fix bug in memory usage calculation (unintended integer division) (master...calc-error) https://github.com/bitcoin/bitcoin/pull/12784
06:14 < fanquake> #12759 also looks like it's ready. The final nit can be handled another time.
06:14 < gribble> https://github.com/bitcoin/bitcoin/issues/12759 | [Docs] Improve formatting of developer notes by eklitzke · Pull Request #12759 · bitcoin/bitcoin · GitHub
06:16 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev     
06:19 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 256 seconds]     
06:20 < wumpus> fanquake: I'm not sure about #12767 - tend to agree with sipa. We shouldn't make unbridled changed to the code everywhere just to make broken static analysis tools happy. I have a similar problem with #12827.
06:20 < gribble> https://github.com/bitcoin/bitcoin/issues/12767 | Initialize nVersionDummy to zero in deserialization code by practicalswift · Pull Request #12767 · bitcoin/bitcoin · GitHub
06:20 < gribble> https://github.com/bitcoin/bitcoin/issues/12827 | Trivial: Dont use short version of tinyformat/fmt namespace by matthias-g · Pull Request #12827 · bitcoin/bitcoin · GitHub
06:25 < bitcoin-git> [bitcoin] matthias-g closed pull request #12827: Trivial: Don't use short version of 'tinyformat/fmt' namespace (master...tinyformat-fmt) https://github.com/bitcoin/bitcoin/pull/12827
06:26 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has quit [Ping timeout: 240 seconds]     
06:26 < fanquake> wumpus heh, looks like the second issue was fixing a problem with a specific IDE?
06:27 < wumpus> fanquake: apparently! I only now see it's an IDE, thought it was another analysis tool
06:29 < wumpus> there are so many of those, and while they can be useful, they tend to have lots of false positives too. Most of the PRs resulting from them solve false positives, not actual problems found.
06:31 < fanquake> Looks like #12790 can be merged.
06:31 < gribble> https://github.com/bitcoin/bitcoin/issues/12790 | [Tests] Use blockmaxweight where tests previously had blockmaxsize by conscott · Pull Request #12790 · bitcoin/bitcoin · GitHub
06:31 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 264 seconds]     
06:33 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev     
06:35 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 240 seconds]     
06:36 < wumpus> fanquake: indeed
06:36 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e80716d3b324...490644d29e64
06:36 < bitcoin-git> bitcoin/master b466f6b Conor Scott: [Tests] Use blockmaxweight where tests previously had blockmaxsize
06:36 < bitcoin-git> bitcoin/master 490644d Wladimir J. van der Laan: Merge #12790: [Tests] Use blockmaxweight where tests previously had blockmaxsize...
06:37 < bitcoin-git> [bitcoin] laanwj closed pull request #12790: [Tests] Use blockmaxweight where tests previously had blockmaxsize (master...12768_remove_blockmaxsize) https://github.com/bitcoin/bitcoin/pull/12790
06:38 -!- lukedashjr is now known as luke-jr     
06:39 -!- aruns [~indistylo@119.82.105.106] has quit [Ping timeout: 240 seconds]     
06:40 < fanquake> wumpus also #12759 if you missed above.
06:40 < gribble> https://github.com/bitcoin/bitcoin/issues/12759 | [Docs] Improve formatting of developer notes by eklitzke · Pull Request #12759 · bitcoin/bitcoin · GitHub
06:42 < aj> wumpus: "our (or their or both)" is referring to --ours/--theirs/--union options respectively
06:42 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
06:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]     
06:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
06:44 < wumpus> fanquake: yep, still looking at that one
06:45 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev     
06:46 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/490644d29e64...d3908e2cee65
06:46 < bitcoin-git> bitcoin/master 0bd2ec5 Evan Klitzke: Improve formatting of developer notes...
06:46 < bitcoin-git> bitcoin/master d3908e2 Wladimir J. van der Laan: Merge #12759: [Docs] Improve formatting of developer notes...
06:46 < bitcoin-git> [bitcoin] laanwj closed pull request #12759: [Docs] Improve formatting of developer notes (master...developer-notes) https://github.com/bitcoin/bitcoin/pull/12759
06:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds]     
06:50 -!- indistylo [~indistylo@119.82.105.106] has joined #bitcoin-core-dev     
06:58 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev     
07:00 -!- unholymachine [~quassel@2601:8c:c003:9f16:ecc5:3da1:2ff9:a94c] has joined #bitcoin-core-dev     
07:04 -!- moneyball [~moneyball@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #bitcoin-core-dev     
07:05 -!- moneyball [~moneyball@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Client Quit]     
07:06 < bitcoin-git> [bitcoin] practicalswift closed pull request #12789: Don't return a CExtPubKey filled with random data when DecodeExt{Pub,}Key is given input not passing DecodeBase58Check(...) (master...CExtKey-junk) https://github.com/bitcoin/bitcoin/pull/12789
07:09 -!- moneyball [~moneyball@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #bitcoin-core-dev     
07:15 < jnewbery> wumpus: if you're on a merge spree, #10762 and #11773 look ready
07:15 < gribble> https://github.com/bitcoin/bitcoin/issues/10762 | [wallet] Remove Wallet dependencies from init.cpp by jnewbery · Pull Request #10762 · bitcoin/bitcoin · GitHub
07:15 < gribble> https://github.com/bitcoin/bitcoin/issues/11773 | [tests] Change feature_block.py to use BitcoinTestFramework by jnewbery · Pull Request #11773 · bitcoin/bitcoin · GitHub
07:16 < wumpus> jnewbery: thanks, I'll have a look
07:17 < jtimon> https://github.com/bitcoin/bitcoin/pull/12172 got acks, then people asked for more things and I started to work on that but we decided to leave them out at the end
07:17 < bitcoin-git> [bitcoin] jnewbery opened pull request #12829: Python3 fixup (master...python3_fixup) https://github.com/bitcoin/bitcoin/pull/12829
07:17 < jtimon> so it should be ready too, I think
07:19 -!- Randolf [~randolf@209.205.87.205.core.cipherkey.net] has joined #bitcoin-core-dev     
07:21 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection]     
07:21 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev     
07:30 < jtimon> hmm, https://travis-ci.org/bitcoin/bitcoin/builds/359681523 seems stuck or something
07:31 < wumpus> jtimon: looks like build 1 didn't even start yet?
07:32 < jtimon> I tried cancelling the job and restarting it, but yeah, it didn't even start
07:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
07:34 < wumpus> it's possible that it's hanging on a previous PR/build and cannot allocate a builder to that, yet
07:34 < jnewbery> Perhaps we should just not update release-notes.md at all in individual PRs and just have the wiki page open from the beginning of the release cycle. PRs that require release notes can be tagged as requires_release_notes so we can verify that they all got done at the end of the cycle.
07:34 < jnewbery> Maybe something to discuss in the meeting
07:35 < wumpus> I'd never have expected the release notes to become a bottleneck. One positive thing about this is: people are writing release notes for their changes!
07:36 -!- Randolf [~randolf@209.205.87.205.core.cipherkey.net] has quit [Ping timeout: 264 seconds]     
07:36 < jnewbery> it's not a huge bottleneck, but it seems like a completely avoidable annoyance to have reviews invalidated by release-notes.md conflicts
07:37 < wumpus> yes, a wiki might be better for this, though on the other hand, having the changed synced to merges makes sense
07:37 < wumpus> changes*
07:38 -!- user989098 [bca349da@gateway/web/freenode/ip.188.163.73.218] has joined #bitcoin-core-dev     
07:38 < jnewbery> yes, good point. Let's discuss in the meeting
07:38 -!- user989098 [bca349da@gateway/web/freenode/ip.188.163.73.218] has quit [Client Quit]     
07:38 -!- karimofthecrop [~karim@rrcs-76-80-21-234.west.biz.rr.com] has joined #bitcoin-core-dev     
07:39 -!- shesek` [~shesek@bzq-84-110-232-249.red.bezeqint.net] has quit [Ping timeout: 268 seconds]     
07:42 < fanquake> Forgot it was meeting night tonight. Should probably make and effort to join.
07:44 -!- karimofthecrop [~karim@rrcs-76-80-21-234.west.biz.rr.com] has quit [Ping timeout: 260 seconds]     
07:47 < wumpus> that'd be cool, though I know it's not easy for that part of the world
07:48 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
07:48 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has quit [Remote host closed the connection]     
07:48 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has joined #bitcoin-core-dev     
07:50 -!- shesek` [~shesek@bzq-84-110-232-249.cablep.bezeqint.net] has joined #bitcoin-core-dev     
07:50 -!- Krellan [~Krellan@2601:640:4000:9258:f041:1606:65ac:36b5] has quit [Read error: Connection reset by peer]     
07:51 -!- Krellan [~Krellan@2601:640:4000:9258:f041:1606:65ac:36b5] has joined #bitcoin-core-dev     
07:57 -!- Lightsword [~Lightswor@107.170.253.193] has quit [Quit: ZNC]     
08:03 < bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/d3908e2cee65...6d53663a4339
08:03 < bitcoin-git> bitcoin/master 5fb5421 John Newbery: [wallet] Move wallet init functions into WalletInit class.
08:03 < bitcoin-git> bitcoin/master caaf972 John Newbery: [wallet] Create wallet init interface.
08:03 < bitcoin-git> bitcoin/master 49baa4a John Newbery: [wallet] Use global g_wallet_init_interface to init/destroy the wallet....
08:04 < bitcoin-git> [bitcoin] laanwj closed pull request #10762: [wallet] Remove Wallet dependencies from init.cpp (master...walletinit) https://github.com/bitcoin/bitcoin/pull/10762
08:05 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 264 seconds]     
08:06 -!- psyopp [~rls@74.120.222.234] has quit [Ping timeout: 248 seconds]     
08:09 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev     
08:16 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has quit [Read error: Connection reset by peer]     
08:17 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has joined #bitcoin-core-dev     
08:17 < bitcoin-git> [bitcoin] jamesob opened pull request #12830: [qt] [tests] Clarify address book error messages, add tests (master...2018-03-27-send-recv-addressbook-error) https://github.com/bitcoin/bitcoin/pull/12830
08:23 -!- karimofthecrop [~karim@rrcs-76-80-21-234.west.biz.rr.com] has joined #bitcoin-core-dev     
08:28 -!- Cogito_Ergo_Sum [~Myself@athedsl-314680.home.otenet.gr] has joined #bitcoin-core-dev     
08:28 -!- Cogito_Ergo_Sum [~Myself@athedsl-314680.home.otenet.gr] has quit [Changing host]     
08:28 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev     
08:29 -!- juscamarena [~justin@199.102.243.31] has joined #bitcoin-core-dev     
08:32 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has joined #bitcoin-core-dev     
08:34 -!- karimofthecrop [~karim@rrcs-76-80-21-234.west.biz.rr.com] has quit [Ping timeout: 256 seconds]     
08:36 -!- bule [~bule@gateway/tor-sasl/bule] has joined #bitcoin-core-dev     
08:36 -!- indistylo [~indistylo@119.82.105.106] has quit [Ping timeout: 276 seconds]     
08:36 < bitcoin-git> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/6d53663a4339...f0f9732d05d7
08:36 < bitcoin-git> bitcoin/master 5cd01d2 John Newbery: [tests] Fix flake8 warnings in feature_block.py
08:36 < bitcoin-git> bitcoin/master 3898c4f John Newbery: [tests] Tidy up feature_block.py...
08:36 < bitcoin-git> bitcoin/master fc02c12 John Newbery: [tests] Add logging to feature_block.py
08:36 < bitcoin-git> [bitcoin] laanwj closed pull request #11773:  [tests] Change feature_block.py to use BitcoinTestFramework (master...refactor_p2pfullblocktest) https://github.com/bitcoin/bitcoin/pull/11773
08:44 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit []     
08:47 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #12831: [WIP] Run unit tests in parallel (master...Mf1803-qaUnitParallel) https://github.com/bitcoin/bitcoin/pull/12831
08:50 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
08:55 -!- moneyball [~moneyball@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]     
08:56 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has quit [Quit: zarez]     
08:57 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 276 seconds]     
08:58 -!- ProfMac [~ProfMac@2001:470:b8ac:0:78c6:533:d0e0:688f] has quit [Quit: Leaving]     
08:59 -!- ProfMac [~ProfMac@2001:470:b8ac:0:d48:394e:9157:dd75] has joined #bitcoin-core-dev     
09:00 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt]     
09:06 -!- JackH [~laptop@212.78.169.180] has quit [Ping timeout: 264 seconds]     
09:09 -!- grafcaps [~haroldbr@104.137.194.255] has joined #bitcoin-core-dev     
09:13 -!- ProfMac [~ProfMac@2001:470:b8ac:0:d48:394e:9157:dd75] has quit [Quit: Leaving]     
09:15 -!- ProfMac [~ProfMac@2001:470:b8ac:0:d48:394e:9157:dd75] has joined #bitcoin-core-dev     
09:32 -!- harrymm [~harrymm@104.207.83.39] has joined #bitcoin-core-dev     
09:37 -!- suldev [~suldev@pool-108-52-119-134.phlapa.fios.verizon.net] has joined #bitcoin-core-dev     
09:37 -!- lnostdal [~lnostdal@85-118-74-142.mtel.net] has quit [Ping timeout: 264 seconds]     
09:39 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection]     
09:40 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev     
09:52 -!- AriseChikun [Arise@gateway/vpn/privateinternetaccess/arisechikun] has joined #bitcoin-core-dev     
09:53 -!- pierre_rochard [~pierre_ro@ool-1826fb14.dyn.optonline.net] has joined #bitcoin-core-dev     
09:53 -!- pierre_rochard [~pierre_ro@ool-1826fb14.dyn.optonline.net] has quit [Changing host]     
09:53 -!- pierre_rochard [~pierre_ro@unaffiliated/pierre-rochard/x-3593157] has joined #bitcoin-core-dev     
09:56 -!- rex4539 [~textual@athedsl-342689.home.otenet.gr] has quit [Read error: Connection reset by peer]     
10:01 -!- Murch [~murch@96.74.120.81] has joined #bitcoin-core-dev     
10:09 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer]     
10:09 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev     
10:11 -!- Krellan [~Krellan@2601:640:4000:9258:f041:1606:65ac:36b5] has quit [Remote host closed the connection]     
10:15 -!- Samdney [~Samdney@178.162.209.137] has joined #bitcoin-core-dev     
10:22 -!- moneyball [~moneyball@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #bitcoin-core-dev     
10:26 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]     
10:29 -!- lnostdal [~lnostdal@85.118.80.52] has joined #bitcoin-core-dev     
10:31 -!- suldev [~suldev@pool-108-52-119-134.phlapa.fios.verizon.net] has quit [Ping timeout: 256 seconds]     
10:32 -!- ProfMac [~ProfMac@2001:470:b8ac:0:d48:394e:9157:dd75] has quit [Quit: Leaving]     
10:34 -!- ProfMac [~ProfMac@2001:470:b8ac:0:d48:394e:9157:dd75] has joined #bitcoin-core-dev     
10:36 -!- skeees [~jcohen@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #bitcoin-core-dev     
10:37 -!- lnostdal [~lnostdal@85.118.80.52] has quit [Ping timeout: 240 seconds]     
10:40 -!- warren [~warren@fedora/wombat/warren] has quit [Quit: QUIT]     
10:40 -!- adam3us [~adam3us@unaffiliated/adam3us] has quit [Quit: QUIT]     
10:40 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
10:47 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has joined #bitcoin-core-dev     
10:47 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt]     
10:48 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev     
10:49 -!- timothy [~tredaelli@redhat/timothy] has quit [Client Quit]     
10:49 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 256 seconds]     
10:49 -!- lnostdal [~lnostdal@85.118.80.52] has joined #bitcoin-core-dev     
11:00 -!- ProfMac [~ProfMac@2001:470:b8ac:0:d48:394e:9157:dd75] has quit [Ping timeout: 252 seconds]     
11:02 < wumpus> wtf is up with travis: https://travis-ci.org/bitcoin/bitcoin/jobs/359847093  - looks like it creates a shallow clone, then tries to check out an older commit
11:02 < wumpus> I think this happens before our own script kicks in
11:06 -!- lnostdal [~lnostdal@85.118.80.52] has quit [Ping timeout: 240 seconds]     
11:07 < arubi> wumpus, the config tab shows '"depth": 1'
11:07 < arubi> so for some reason .travis.yml is set to that..?  weird
11:09 < wumpus> but that's nothing new
11:09 < ken2812221> Maybe this job must be auto-cancelled
11:10 -!- lnostdal [~lnostdal@85.118.80.52] has joined #bitcoin-core-dev     
11:10 < wumpus> depth was changed to 1 in fa79016ab0d23aa3d2c0322ab6be90b37dcd01c1, that's two week ago, not sure why it'd start giving problems now
11:11 < wumpus> fa44af5cd2152a21da9ef3e48c073a668bf2df27 added depth: false
11:11 < arubi> hm     
11:11 < wumpus> (feb 10)
11:11 < wumpus> before that, we had no depth defined in the yml
11:17 < wumpus> (which effectively means depth=1 IIRC)
11:19 < arubi> it's 50 I think
11:24 < wumpus> so maybe it'd be better to remove the depth specification and leave it up to travis again
11:25 < wumpus> on the other hand, this way it spends less time building old master commits :-)
11:34 -!- skypper [5c68c889@gateway/web/freenode/ip.92.104.200.137] has joined #bitcoin-core-dev     
11:40 -!- moneyball [~moneyball@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]     
11:41 -!- ProfMac [~ProfMac@2001:470:b8ac:0:d48:394e:9157:dd75] has joined #bitcoin-core-dev     
11:47 -!- moneyball [~moneyball@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #bitcoin-core-dev     
11:49 -!- nitramiz [~nitramiz@128.110.66.235] has joined #bitcoin-core-dev     
11:58 -!- CubicEar_ [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer]     
11:59 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev     
12:00 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
12:00 < sipa> meeting time?
12:00 < jnewbery> hello
12:01 < eklitzke> hi     
12:01 < provoostenator> hi     
12:01 < bitcoin-git> [bitcoin] Sjors opened pull request #12833: WIP [qt] move QSettings to bitcoin.conf where possible (master...2018/03/bitcoin-conf-rw) https://github.com/bitcoin/bitcoin/pull/12833
12:01 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
12:01 < achow101> meting?
12:02 < sipa> meeting, me think
12:02 < jamesob_> yo     
12:03 < sipa> wumpus: ?
12:03 < jimpo> hi     
12:03 < wumpus> #startmeeting
12:03 < lightningbot> Meeting started Thu Mar 29 19:03:52 2018 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
12:03 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
12:03 < BlueMatt> my high-priority: #11775 (yay, I have one again)
12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/11775 | Move fee estimator into validationinterface/cscheduler thread by TheBlueMatt · Pull Request #11775 · bitcoin/bitcoin · GitHub
12:04 < wumpus> (DST sucks)
12:04 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
12:04 < kanzure> hi.     
12:04 < cfields> hi     
12:05 < wumpus> #topic high priority for review
12:05 -!- bule [~bule@gateway/tor-sasl/bule] has quit [Quit: Leaving]     
12:05 < jnewbery> BlueMatt: needs rebase again. Sorry!
12:05 < wumpus> BlueMatt: added
12:05 < instagibbs> hi     
12:06 < BlueMatt> jnewbery: well its a trivial rebase that shouldnt materially effect review
12:06 < jamesob_> I'd like to nominate ryanofsky's #10244. The burden of rebasing/conflict resolution is high and I think it's in pretty good shape (though needs rebase atm).
12:06 < gribble> https://github.com/bitcoin/bitcoin/issues/10244 | Refactor: separate gui from wallet and node by ryanofsky · Pull Request #10244 · bitcoin/bitcoin · GitHub
12:06 < provoostenator> agreed
12:06 < BlueMatt> can we make that a topic? I'd like to discuss it in more depth
12:07 < BlueMatt> (10244, that is)
12:07 < jnewbery> +1. Seems to be getting some review traction. It'd be a shame for that to go to waste
12:07 < wumpus> #topic separate gui from wallet and node  (#10244)
12:07 < gribble> https://github.com/bitcoin/bitcoin/issues/10244 | Refactor: separate gui from wallet and node by ryanofsky · Pull Request #10244 · bitcoin/bitcoin · GitHub
12:08 < ryanofsky> did you have a question BlueMatt?
12:08 < BlueMatt> yea, sec
12:09 < wumpus> I've... already said everything I wanted to said about that, won't repeat myself
12:09 < BlueMatt> so I guess I'm more of a fan of this than the wallet/main split, but I feel like we need to think a bit harder about the api between the gui/wallet+main before we go split it
12:09 < BlueMatt> I mean some of these things maybe shouldnt be blocking calls
12:09 < wumpus> TBH we discussed this at the new york meeting
12:09 < wumpus> and the agreement was that this could be improved after it goes in
12:09 < BlueMatt> ok, well I will shut up, then, if its been beaten to death
12:09 < BlueMatt> ok, nvm
12:10 < wumpus> I'm ok with that. I'd have preferred to make the GUI asynchronous first
12:10 < wumpus> but Iom' not going to beat that topic to death
12:10 < wumpus> right
12:10 < ryanofsky> api is definitely meant to be improved, especially the init stuff which is pretty ugly
12:10 < kanzure> are there any big blockers to asynchronous gui things?
12:10 < BlueMatt> yea, I mean that was what I was gonna say, but if there was agreement its not worth re-opening the book on that to discuss
12:10 < wumpus> no, it's just a different set of work
12:11 < wumpus> it's somewhat orthogonal to this - my gut just hates blocking RPC calls in GUI threads, it's more of an instinctive revulsion than anything I can explain, so I'll just go along
12:11 < jamesob_> this PR introduces no RPC calls
12:11 < provoostenator> I think part of the understanding was that this interface should be considered very much not final.
12:11 < BlueMatt> jamesob_: it introduces a whole new rpc interface...
12:11 < wumpus> it does, it introduces an RPC layer between the wallet and the core
12:12 < provoostenator> Just having _an_ interface was step one.
12:12 < wumpus> please don't deny that
12:12 < BlueMatt> anyway, next topic?
12:12 < wumpus> yes, any other topic suggestions?
12:12 < sipa> wumpus: i think jamesob_ means RPC as in the existing JSON RPC system
12:12 < sipa> not RPC as a generic term
12:12 < jamesob_> correct
12:12 < wumpus> ok, yes, RPC is a general term for cross-process calls
12:13 < ryanofsky> jamesob_, an earlier version of this pr did mention ipc, but i took that stuff out
12:13 < jnewbery> This first step isn't cross-process
12:13 < BlueMatt> lol, ok, so any topics *aside* from debating rpc/ipc/whatever terminology?
12:13 < wumpus> yes...
12:14 < jnewbery> topic suggestion (quick one): release notes conflicts
12:14 < wumpus> #topic release notes conflicts
12:14 < jnewbery> I don't think it's a major issue, but it is irritating to have reviews invalidated due to release notes conflicts
12:14 < jnewbery> options: 1) do nothing because it's not a huge issue
12:14 < wumpus> could do them in a separate commit, at the end
12:15 < sipa> do we know if githubdeals correctly with the gitattributes merge=union stuff?
12:15 < wumpus> oh wait that doesn't help with rebases...
12:15 < achow101> Maybe we should have the release notes dev wiki thing continuously up and people just add stuff to it as needed
12:15 < jnewbery> 2) don't use release_notes.md and just use a wiki for the whole release cycle
12:15 < jnewbery> 3) have separate release_notes files for each PR and merge them at the end
12:15 < BlueMatt> I mean as long as its a separate commit no reason to invalidate reviews
12:15 < jnewbery> 4) ?
12:16 < sipa> 4) is the merge=union thing?
12:16 < jnewbery> merge=union doesn't help with github I think
12:16 < achow101> I prefer 2
12:16 < sipa> i don't like 2
12:16 < sipa> too much process overhead
12:16 < wumpus> achow101: I think the only argument against 2 is that it decouples the merge from the release mode update
12:17 < wumpus> notes*
12:17 < ryanofsky> an option 4) would be to insert 50-100 blank lines in the file, and add release new notes in the blank space. this would avoid most conflicts
12:17 < jnewbery> sipa: https://github.com/isaacs/github/issues/487
12:17 < cfields> outside the box: notes can be added as individual files and aggregated at the end
12:17 < wumpus> so the author of the PR has to update the wiki after their thing was merged
12:17 < sipa> jnewbery: right, but we also.don't really use github for merges
12:17 < wumpus> cfields: unless they somehow interact :)
12:17 < sipa> i mean more... how does it affect our github merge scriot etc
12:17 < jnewbery> cfields: I think that's 3
12:17 < sipa> which compares with the github merge
12:17 < instagibbs> sipa, would be annoying to see conflict on GUI and just hope it's a merge we can avoid directly handling
12:18 < sipa> instagibbs: fair
12:18 < cfields> jnewbery: ah yes, missed 3.
12:18 < sipa> i think my preference is 3
12:18 < wumpus> cfields: I mean, sometimes an update to the release notes updates/extends earlier text - though
12:18 < sdaftuar> i like 3 too
12:18 < instagibbs> maybe i need to learn that tool better, might give a better view of it
12:18 < ryanofsky> link describing option 4: https://about.gitlab.com/2015/02/10/gitlab-reduced-merge-conflicts-by-90-percent-with-changelog-placeholders/
12:18 < jamesob_> I like 3
12:18 < BlueMatt> option n) leave release notes as a comment on pr and tag the release-notes-needed issue
12:18 < wumpus> cfields: storing it *per section* would still help!
12:18 < BlueMatt> easy to merge at the end
12:18 < BlueMatt> and they exist in the pr itself
12:18 < ryanofsky> i also like 3 best
12:19 < wumpus> 'leave it to the maintainer at the end' is not an option :p
12:19 < sipa> it may be a release notes file per "feature" too, i think, if multiple PRs sequentially update the se thing
12:19 < jnewbery> sipa: sounds reasonable, if they're serial
12:19 < sipa> right
12:19 < jimpo> Yeah, I like the idea of basically having a file for each section in the current release notes
12:19 < wumpus> I mean what you want to avoid is that *unrelated* PRs collide in the release notes
12:20 < sipa> wumpus: yyp
12:20 < wumpus> if PRs that already affect the same thing collide, that's not too bad, because the code likely does too
12:21 -!- phantomcircuit [~phantomci@192.241.205.97] has quit [Ping timeout: 240 seconds]     
12:21 -!- Murchone [~murch@mobile-166-137-177-159.mycingular.net] has joined #bitcoin-core-dev     
12:22 < wumpus> so yes, 3 sounds like a good idea to me, though it might be overdesign for something that doesn't cause too much trouble in practice, I wonder if anyone will actually do it
12:23 < sipa> we can see how it plays out
12:23 < jnewbery> if it's in the developer notes, then I think people will do it
12:23 < jnewbery> I'll do it for my PRs to avoid conflicts
12:24 < jamesob_> could add a lint step to the build that fails if the PR touches the main release notes files as well as src/ files
12:24 < wumpus> definitely needs to be in the developer notes, like "what directory to use for partial release notes'
12:24 < wumpus> oh no no more lints
12:24 < jnewbery> I think that's probably enough discussion. As long as the maintainers don't object to partial release notes then individual contributors can start using them
12:24 -!- Murch [~murch@96.74.120.81] has quit [Read error: Connection reset by peer]     
12:24 < wumpus> I get quite angry if yet another redundant python import breaks travis
12:24 < jamesob_> suggestion retracted :)
12:24 < instagibbs> I don't even think there's contribution notes yet
12:25 < instagibbs> for release notes
12:25 < wumpus> jamesob_: sorry :)
12:25 < instagibbs> i had to ask promag
12:25 < jnewbery> wumpus: is that not caught in the PR's travis run?
12:25 -!- Murch [~murch@96.74.120.81] has joined #bitcoin-core-dev     
12:25 < wumpus> jnewbery: I think it is
12:26 < sipa> topic suggestion: avoid undefined behaviour when it shouldn't matter? (#12789)
12:26 < gribble> https://github.com/bitcoin/bitcoin/issues/12789 | Dont return a CExtPubKey filled with random data when DecodeExt{Pub,}Key is given input not passing DecodeBase58Check(...) by practicalswift · Pull Request #12789 · bitcoin/bitcoin · GitHub
12:27 < wumpus> #topic avoid undefined behaviour when it shouldn't matter?
12:27 < jtimon> ryanofsky: why not just create a separated pr editing the release notes after the actual pr doing things has been merged?
12:27 < BlueMatt> "shouldnt"
12:27 < sipa> i bring it up here because it may be something we should or shouldn't have as a guideline
12:28 < sipa> for example,  should you initialize a variable that isn't read anywhere, because soke compiler warning fails to understand it isn't being read?
12:28 < sipa> argument in favor: more deterministic failures
12:28 < BlueMatt> oh, well that isnt "shouldnt"
12:28 < BlueMatt> that is "doesnt, but compiler warns"
12:28 < sipa> argument against: reduces the ability for tools to detect things stativally
12:29 < provoostenator> Other argument in favor: means a linter can catch all uninitialized variables.
12:29 < sipa> well i say shouldn't, because reviewers may be wrong and the compiler may be right
12:29 < wumpus> jtimon: that's a possibility too, though like the wiki option it decouples the code change from the release notes change itselff
12:29 -!- Murchone [~murch@mobile-166-137-177-159.mycingular.net] has quit [Ping timeout: 264 seconds]     
12:29 < wumpus> jtimon: also: EVEN MORE PRs :(
12:29 < jtimon> wumpus: yep, although I guess the bigger drawback is more prs
12:29 < jtimon> right
12:29 < BlueMatt> I mean if its at all tricky to show that it *wont* be read, then should def follow the compiler, but the nonstop stream of "this compiler is shit and warned on something that it shouldnt be" prs is....not ideal
12:30 < wumpus> yeah...
12:30 < BlueMatt> honestly of all those pros/cons, the pr volume is probably the most important imnsho
12:30 < wumpus> so many *fix some and some false positive for my crappy static analysis tool/compiler with warnings jacked up*
12:30 < sipa> i generally dislike the "compiler/analyzer/linter/tool doesn't understand X, let's initialize everything to shut it up"
12:30 < wumpus> me too
12:30 < wumpus> just fix your tools FFS
12:30 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #12823:  doc: Switch release-notes.md to union merge  (master...Mf1803-docGitattributes) https://github.com/bitcoin/bitcoin/pull/12823
12:31 < wumpus> if it's correct, human-understandable C++ code and we know there's no problems with it, it should not be changes because compiler blabla
12:31 < wumpus> too risky, too
12:31 < sipa> or improve the code so it is easier for tools (and humans) to see it is correct
12:31 < wumpus> if it's not broken don't change it
12:31 < sipa> true
12:31 < sipa> ok, just wanted to hear opinions about this
12:32 < wumpus> unless it's a refactor to prepare for osmething else, of course, but that wasn't the premise :)
12:32 < wumpus> so I think we agree
12:32 < sipa> yes     
12:32 < wumpus> any other topics?
12:33 < jtimon> BlueMatt: I don't know, will more volume of prs specific to release notes be that much more cumbersome?
12:34 -!- Murch [~murch@96.74.120.81] has quit [Quit: Snoozing.]     
12:34 < wumpus> jtimon: yes. In that case I prefer the wiki
12:34 < BlueMatt> less so than code-change pr volume
12:34 < BlueMatt> but whatever
12:34 < jnewbery> wumpus: I agree
12:34 < wumpus> that's why we have the wiki-phase at all before releases, to prevent a jungle of update-release-notes PRs
12:34 < jtimon> yeah, I mean, I don't have a strong opinion either way
12:34 < wumpus> (which will also conflict with each other! though easier to rebase..)
12:35 < ryanofsky> jtimon, imo including release notes along with changes makes changes easier to understand, and also probably more well thought out
12:35 < wumpus> yes, it's better than code-change PR volume that's for sure
12:35 < wumpus> ryanofsky: hey that's a good point
12:36 < jtimon> sipa: sometimes warning are useful, sometimes they are not and it's alright to leave them there. but not sure what the discussion is. nobody is proposing we use -Werror, right?
12:36 < wumpus> I remember seeing the 'release notes per item' before in some project, not sure which
12:36 < jtimon> ryanofsky: I agree, but then you have to deal with rebases, I don't see a way around it
12:37 < wumpus> jtimon: warning being good or evil wasn't what the topic was about
12:37 < sipa> jtimon: my view is (for example) that if you systemativally initialize every variable (even those for which you know won't be used), you will lose the ability for the compiler to give you warnings about accidentially uninitialized things
12:38 < jtimon> wumpus: that's what I'm saying, that I'm not sure what the topic is
12:38 < sipa> this is more general than just compiler warnings, and variable initialization though
12:38 < wumpus> at ASML we had that as part of the C coding standard - every, single, variable had to be initialized
12:38 < wumpus> no I don't think we need that here :)
12:38 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection]     
12:39 < cfields> sipa: yes, i really like newer gcc/clang's ability to warn about being unitialized for one or more paths
12:40 < wumpus> I do think all class variables should be initialized in the constructor, in general
12:40 -!- juscamarena [~justin@199.102.243.31] has quit [Remote host closed the connection]     
12:41 < cfields> wumpus: agreed, but I'd like to start using more c++11 member-initialization for trivial types as it's so much less verbose
12:41 < wumpus> cfields: they had that in the static analyzer for quite a while, now it moved to a compiler warning, a good thing
12:42 < cfields> right
12:42 -!- Murch [~murch@96.74.120.81] has joined #bitcoin-core-dev     
12:42 < wumpus> cfields: yes, that's a nicer syntax 
12:43 < wumpus> ok, any other topics?
12:44 < sipa> seems not
12:44 < wumpus> #endmeeting
12:44 < lightningbot> Meeting ended Thu Mar 29 19:44:25 2018 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
12:44 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-03-29-19.03.html
12:44 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-03-29-19.03.txt
12:44 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-03-29-19.03.log.html
12:46 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has joined #bitcoin-core-dev     
12:48 -!- jamesob_ [~jamesob@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Ping timeout: 240 seconds]     
12:57 < cfields> out of curiosity, does the c spec allow for compilers to ignore initializers if a value is always set before it's used?
12:58 < wumpus> only if there are no side effects
12:58 < cfields> i'm wondering if compilers are allowed to do the opposite optimization: you always initialize, but it removes them when possible.
12:58 < BlueMatt> the compiler could run any obvious part of your program and just change the program to have the same effective in/out results, so....yes?
12:59 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
12:59 < wumpus> ^^     
12:59 < BlueMatt> see-also: crypto-memset
12:59 < wumpus> the C spec wouldn't say anything on that, because it's not visible to the code in any path
12:59 < luke-jr> ETA until compilers try to do IBD for you?
12:59 < luke-jr> ☺     
13:00 < BlueMatt> luke-jr: they'll fail on the first net access :(
13:00 < luke-jr> BlueMatt: yes, I'm joking :P
13:01 < wumpus> luke-jr: only if you manage to do blockvalidation in c++78 metaprogramming
13:01 < wumpus> (or maybe it's already possible with current standards, at least compile time hashing is already possible :-)
13:02 < cfields> heh     
13:03 < BlueMatt> rust has a fucking full ast interpreter in the front-end compiler now, to in the future run anything with no io as a constexpr.......
13:05 < wumpus> that's an interesting choice
13:05 < BlueMatt> or, well, thats a possible future use for it, but they have an interpreter in the front-end
13:06 < wumpus> the drawback with c++ compile-time metaprogramming has always been that it's really slow, as it's circuitous because it (ab)uses features meant for something else. So, why not just include an ast interpreter.
13:06 < wumpus> (compile-time slow, I mean)
13:09 < wumpus> so apparently the Tor project is working on porting parts to rust
13:12 < wumpus> not sure what parts, but it has always been an exclusively C codebase before
13:12 < booyah> also, what for
13:12 -!- lnostdal [~lnostdal@85.118.80.52] has quit [Ping timeout: 260 seconds]     
13:12 < booyah> after decades it's probably rather safe from low-level errors, isn't it
13:12 < wumpus> hehe :)
13:12 < wumpus> that's anyone's guess, really
13:12 < BlueMatt> seems premature tbh to me, mostly cause if you want to, eg, compile it on debian stable you have to use a super-old version of rust and end up getting a billion warnings from recent versions telling you to use new syntax :(
13:13 < wumpus> debian stable is the problem there
13:13 < sipa> cfields: not only can they, i believe that SSA transforms will pretty much automatically do that
13:14 < BlueMatt> wumpus: true, but, what, you're gonna not support debian stable? so...you lose, what, 1/5 your users?
13:14 < cfields> sipa: so there's no (performance) downside of initialize-by-default as a rule?
13:15 < wumpus> BlueMatt: but the only way to pressure them into upgrading their rust version is likely for major projects to start using it, it's always a chicken/egg problem
13:15 < BlueMatt> why would they make an exception to their ship-only-insanely-out-of-date-software rule for a *compiler*?
13:15 < wumpus> if e.g. bitcoin would start using it, no one would care, but something like tor has quite a lot of influence I think
13:15 < BlueMatt> that seems like the one thing they'd be least likely to make an exception for
13:15 < wumpus> oh we'll see
13:17 < wumpus> I'm glad someone is taking the initative there that's not me
13:17 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has quit [Quit: probably someone interrupted me]     
13:18 < BlueMatt> lol, well at least we succeeded at getting them to stop shiping bitcoin
13:18 < wumpus> firefox is likely the main pusher for (decent) rust support in distros
13:18 < BlueMatt> maybe if the tor folks also succeed
13:19 < BlueMatt> debian already stopped shipping firefox a long time ago :p
13:19 < BlueMatt> (because of this exact issue, too....)
13:19 < wumpus> huh? really?
13:19 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has joined #bitcoin-core-dev     
13:19 < BlueMatt> iceweasel, yo
13:20 < wumpus> iceweasel is simply a rebranded firefox
13:20 < wumpus> because of some license issue...
13:20 < BlueMatt> yes, but they had to because they wanted to ship super old versions and that wasnt allowed
13:20 < BlueMatt> afair
13:21 < BlueMatt> (among other issues)
13:21 < wumpus> shipping old versions of browsers is really dangerous
13:21 < BlueMatt> yes, just pointing out that debian was so headstrong in their desire to do stupid insecure shit that they rebranded firefox for it....
13:22 < wumpus> yes I didn't know that was the reason
13:22 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has quit [Ping timeout: 248 seconds]     
13:23 < BlueMatt> i mean i may be misrecalling, but I believe that was one of the things that violated the acceptable-use license that firefox required to use their branding
13:23 < BlueMatt> (among a few other issues)
13:25 -!- lnostdal [~lnostdal@85.118.83.23] has joined #bitcoin-core-dev     
13:26 -!- suldev [~suldev@pool-108-52-119-134.phlapa.fios.verizon.net] has joined #bitcoin-core-dev     
13:27 < cfields> I thought debian was back to firefox now?
13:27 < cfields> iirc the tm issue was resolved somehow
13:28 < BlueMatt> seems like it, yes, still, my point stands
13:28 -!- rls [~rls@74.120.222.234] has joined #bitcoin-core-dev     
13:35 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/f0f9732d05d7...252c1b0faef4
13:35 < bitcoin-git> bitcoin/master 5de2b18 John Newbery: [contrib] fixup security-check.py Python3 support
13:35 < bitcoin-git> bitcoin/master f50975b John Newbery: [contrib] fixup symbol-check.py Python3 support
13:35 < bitcoin-git> bitcoin/master 252c1b0 Wladimir J. van der Laan: Merge #12829: Python3 fixup...
13:35 < bitcoin-git> [bitcoin] laanwj closed pull request #12829: Python3 fixup (master...python3_fixup) https://github.com/bitcoin/bitcoin/pull/12829
13:37 -!- lnostdal [~lnostdal@85.118.83.23] has quit [Ping timeout: 276 seconds]     
13:41 -!- Giszmo [~leo@ip-141-237-219-201.nextelmovil.cl] has joined #bitcoin-core-dev     
13:46 -!- Giszmo [~leo@ip-141-237-219-201.nextelmovil.cl] has quit [Ping timeout: 240 seconds]     
13:47 < sipa> cfields: there is when the compiler can't figure out the value is unused
13:48 < sipa> but in the naive situatiin where there are no branches/loops that conplicate flow analysis, sure
13:48 -!- andytoshi [~apoelstra@wpsoftware.net] has quit [Changing host]     
13:48 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #bitcoin-core-dev     
13:48 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev     
13:58 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has quit [Remote host closed the connection]     
13:58 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/252c1b0faef4...de6bdfd78f22
13:58 < bitcoin-git> bitcoin/master 6feb46c Evan Klitzke: Add --with-sanitizers option to configure...
13:58 < bitcoin-git> bitcoin/master de6bdfd Wladimir J. van der Laan: Merge #12692: Add configure options for various -fsanitize flags...
13:59 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has joined #bitcoin-core-dev     
13:59 < bitcoin-git> [bitcoin] laanwj closed pull request #12692: Add configure options for various -fsanitize flags (master...sanitize) https://github.com/bitcoin/bitcoin/pull/12692
14:00 -!- Guest2527 [75c85d79@gateway/web/cgi-irc/kiwiirc.com/ip.117.200.93.121] has joined #bitcoin-core-dev     
14:01 < bitcoin-git> [bitcoin] laanwj closed pull request #12774: Issue #10542 Signmessage doesn't work with segwit addresses (master...master) https://github.com/bitcoin/bitcoin/pull/12774
14:05 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has joined #bitcoin-core-dev     
14:06 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev     
14:08 < bitcoin-git> [bitcoin] laanwj closed pull request #12124: [wallet] Remove segwit status check (master...master) https://github.com/bitcoin/bitcoin/pull/12124
14:09 < sipa> m-m-m-multiclose PR
14:09 < wumpus> hehe
14:10 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has quit [Quit: probably someone interrupted me]     
14:13 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has joined #bitcoin-core-dev     
14:14 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has quit [Client Quit]     
14:16 -!- grafcaps [~haroldbr@104.137.194.255] has quit [Quit: Lost terminal]     
14:17 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has joined #bitcoin-core-dev     
14:19 -!- moneyball [~moneyball@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]     
14:23 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds]     
14:24 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
14:25 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
14:28 < wumpus> hm we should probably have discussed #12764 at the meeting
14:28 < gribble> https://github.com/bitcoin/bitcoin/issues/12764 | Remove field in getblocktemplate help that has never been used. by conscott · Pull Request #12764 · bitcoin/bitcoin · GitHub
14:29 < wumpus> not sure if having the help conform to BIP22 or to our current implementation of it is better
14:31 < luke-jr> wumpus: I'd be inclined to just point to BIP 22 and leave the docs at that.
14:33 -!- grafcaps [~haroldbr@104.137.194.255] has joined #bitcoin-core-dev     
14:36 < wumpus> that'd be another option
14:42 -!- grafcaps [~haroldbr@104.137.194.255] has quit [Quit: Lost terminal]     
14:46 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has joined #bitcoin-core-dev     
14:51 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-csxtrsgtilmetccm] has joined #bitcoin-core-dev     
14:55 -!- skeees [~jcohen@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Ping timeout: 268 seconds]     
14:56 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has quit []     
14:58 -!- wxss_ [~user@5.254.86.212] has joined #bitcoin-core-dev     
15:01 -!- wxss [~user@82.221.139.119] has quit [Ping timeout: 240 seconds]     
15:11 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has quit [Ping timeout: 248 seconds]     
15:12 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has joined #bitcoin-core-dev     
15:12 -!- wxss_ [~user@5.254.86.212] has quit [Quit: leaving]     
15:16 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has quit [Ping timeout: 240 seconds]     
15:18 -!- skypper [5c68c889@gateway/web/freenode/ip.92.104.200.137] has quit [Ping timeout: 260 seconds]     
15:20 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has quit [Quit: probably someone interrupted me]     
15:27 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/de6bdfd78f22...3b62a9138657
15:27 < bitcoin-git> bitcoin/master cb1e319 Jorge Timón: Bugfix: RPC: savemempool: Don't save until LoadMempool() is finished
15:27 < bitcoin-git> bitcoin/master 3b62a91 Wladimir J. van der Laan: Merge #12172: Bugfix: RPC: savemempool: Don't save until LoadMempool() is finished...
15:27 < bitcoin-git> [bitcoin] laanwj closed pull request #12172: Bugfix: RPC: savemempool: Don't save until LoadMempool() is finished (master...b16-bugfix-savemempool) https://github.com/bitcoin/bitcoin/pull/12172
15:39 -!- spinza [~spin@196.212.164.26] has quit [Quit: Coyote finally caught up with me...]     
15:44 -!- nitramiz [~nitramiz@128.110.66.235] has quit [Ping timeout: 260 seconds]     
15:55 -!- suldev [~suldev@pool-108-52-119-134.phlapa.fios.verizon.net] has quit [Ping timeout: 276 seconds]     
16:04 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 248 seconds]     
16:04 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
16:05 -!- suldev [~suldev@pool-108-52-119-134.phlapa.fios.verizon.net] has joined #bitcoin-core-dev     
16:07 -!- spinza [~spin@196.212.164.26] has joined #bitcoin-core-dev     
16:22 -!- go1111111 [go1111111@gateway/vpn/privateinternetaccess/go1111111] has quit [Quit: Leaving]     
16:31 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]     
16:35 -!- TrustTrade [~TrustTrad@212-5-158-14.ip.btc-net.bg] has joined #bitcoin-core-dev     
16:49 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev     
16:49 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev     
16:50 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 264 seconds]     
16:53 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 256 seconds]     
16:54 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Quit: Leaving]     
16:56 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev     
17:00 -!- weez17 [~isaac@unaffiliated/weez17] has quit [Remote host closed the connection]     
17:00 -!- weez17 [~isaac@unaffiliated/weez17] has joined #bitcoin-core-dev     
17:04 -!- udiWertheimer_ [sid190185@gateway/web/irccloud.com/x-wlobdrmgnzbzanid] has joined #bitcoin-core-dev     
17:05 -!- nOgAnOo_ [sid146237@gateway/web/irccloud.com/x-peimmcvousvvhnla] has joined #bitcoin-core-dev     
17:05 -!- barq_ [sid103986@gateway/web/irccloud.com/x-pztvxgxwewxmexlq] has joined #bitcoin-core-dev     
17:07 -!- sturles_ [~sturles@ulrik.uio.no] has joined #bitcoin-core-dev     
17:07 -!- sdaftuar_ [~sdaftuar@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev     
17:11 -!- BlueMatt_ [~BlueMatt@mail.bluematt.me] has joined #bitcoin-core-dev     
17:12 -!- udiWertheimer_ is now known as udiWertheimer     
17:14 -!- Netsplit over, joins: musalbas, lnostdal, BashCo, rls, CubicEarths, p3tr, asoltys, marsadm, roasbeef, merehap (+12 more)
17:14 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Excess Flood]     
17:14 -!- TrustTrade [~TrustTrad@212-5-158-14.ip.btc-net.bg] has quit [Ping timeout: 264 seconds]     
17:15 -!- derrekito_ [~derrekito@98.29.141.81] has quit [Quit: Leaving]     
17:16 -!- sturles_ is now known as Guest25997     
17:16 -!- wraithm [~wraithm@unaffiliated/wraithm] has joined #bitcoin-core-dev     
17:16 -!- so [~so@unaffiliated/so] has quit [Ping timeout: 260 seconds]     
17:17 -!- z323 [~z323@ec2-54-234-151-68.compute-1.amazonaws.com] has joined #bitcoin-core-dev     
17:18 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds]     
17:19 -!- owowo [~ovovo@s91904423.blix.com] has joined #bitcoin-core-dev     
17:19 -!- owowo [~ovovo@s91904423.blix.com] has quit [Changing host]     
17:19 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev     
17:22 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev     
17:22 -!- suldev [~suldev@pool-108-52-119-134.phlapa.fios.verizon.net] has quit [Ping timeout: 240 seconds]     
17:23 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-otnytzeefijhaekp] has quit [Ping timeout: 255 seconds]     
17:23 -!- ajtowns[m] [ajtownsmat@gateway/shell/matrix.org/x-ngvtlzculovlknlu] has quit [Ping timeout: 256 seconds]     
17:23 -!- herzmeister[m] [herzmeiste@gateway/shell/matrix.org/x-cvwnuokiuqzvblpl] has quit [Ping timeout: 245 seconds]     
17:23 -!- stepa[m] [stepamatri@gateway/shell/matrix.org/x-tnspezkzdjlipjrq] has quit [Ping timeout: 255 seconds]     
17:23 -!- Masaomi[m] [masaomimat@gateway/shell/matrix.org/x-rbfnomowkvmatpvi] has quit [Ping timeout: 248 seconds]     
17:26 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
17:27 -!- phantomcircuit [~phantomci@192.241.205.97] has joined #bitcoin-core-dev     
17:32 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-myzndnnnghkzrgno] has joined #bitcoin-core-dev     
17:41 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
17:42 -!- stepa[m] [stepamatri@gateway/shell/matrix.org/x-mvrulxgcuppjadgc] has joined #bitcoin-core-dev     
17:42 -!- ajtowns[m] [ajtownsmat@gateway/shell/matrix.org/x-huiwryycfcvpapcj] has joined #bitcoin-core-dev     
17:42 -!- herzmeister[m] [herzmeiste@gateway/shell/matrix.org/x-kqhrkorqyjchvlcu] has joined #bitcoin-core-dev     
17:43 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev     
17:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]     
17:46 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev     
17:47 -!- anome [~anome@unaffiliated/anome] has joined #bitcoin-core-dev     
17:48 -!- suldev [~suldev@pool-108-52-119-134.phlapa.fios.verizon.net] has joined #bitcoin-core-dev     
17:49 -!- anome [~anome@unaffiliated/anome] has quit [Client Quit]     
17:54 -!- jojeyh [~delphi@2602:306:b8b6:b970:9d7e:b18c:1998:cc06] has quit [Ping timeout: 240 seconds]     
17:55 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 252 seconds]     
17:56 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has quit [Remote host closed the connection]     
17:56 -!- Murch [~murch@96.74.120.81] has quit [Quit: Snoozing.]     
17:57 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has joined #bitcoin-core-dev     
17:59 -!- BlueMatt_ is now known as BlueMatt     
17:59 -!- BlueMatt [~BlueMatt@mail.bluematt.me] has quit [Changing host]     
17:59 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has joined #bitcoin-core-dev     
18:02 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev     
18:02 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Client Quit]     
18:02 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev     
18:12 -!- so [~so@unaffiliated/so] has joined #bitcoin-core-dev     
18:19 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 264 seconds]     
18:21 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-csxtrsgtilmetccm] has quit [Quit: Connection closed for inactivity]     
18:28 -!- Masaomi[m] [masaomimat@gateway/shell/matrix.org/session] has joined #bitcoin-core-dev     
18:28 -!- Deadhand [~deadhand@CPE6038e0be3871-CMf0f249a14e40.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev     
18:28 -!- cdecker [~cdecker@mail.snyke.net] has joined #bitcoin-core-dev     
18:28 -!- nullptr| [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has joined #bitcoin-core-dev     
18:28 -!- infernix [nix@unaffiliated/infernix] has joined #bitcoin-core-dev     
18:28 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev     
18:28 -!- aspect_ [sid151486@gateway/web/irccloud.com/x-fnhajkovzhagroir] has joined #bitcoin-core-dev     
18:28 -!- sugarpuff [sid92283@gateway/web/irccloud.com/x-cmmhyrlcypodaarh] has joined #bitcoin-core-dev     
18:28 -!- rubensayshi_ [sid201751@gateway/web/irccloud.com/x-yrjvdhywfuhrkddj] has joined #bitcoin-core-dev     
18:28 -!- Sentineo [~Undefined@unaffiliated/sentineo] has joined #bitcoin-core-dev     
18:28 -!- atroxes [~atroxes@unaffiliated/atroxes] has joined #bitcoin-core-dev     
18:28 -!- karelb [~karelb@163.172.146.205] has joined #bitcoin-core-dev     
18:28 -!- Masaomi[m] [masaomimat@gateway/shell/matrix.org/session] has quit [Changing host]     
18:28 -!- Masaomi[m] [masaomimat@gateway/shell/matrix.org/x-kbzdsyxpytthenhy] has joined #bitcoin-core-dev     
18:31 -!- nitramiz [~nitramiz@76.76.240.247] has joined #bitcoin-core-dev     
18:32 -!- Masaomi[m] [masaomimat@gateway/shell/matrix.org/x-kbzdsyxpytthenhy] has quit [Ping timeout: 246 seconds]     
18:32 -!- ajtowns[m] [ajtownsmat@gateway/shell/matrix.org/x-huiwryycfcvpapcj] has quit [Ping timeout: 255 seconds]     
18:32 -!- stepa[m] [stepamatri@gateway/shell/matrix.org/x-mvrulxgcuppjadgc] has quit [Ping timeout: 255 seconds]     
18:32 -!- herzmeister[m] [herzmeiste@gateway/shell/matrix.org/x-kqhrkorqyjchvlcu] has quit [Ping timeout: 256 seconds]     
18:33 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-myzndnnnghkzrgno] has quit [Ping timeout: 260 seconds]     
18:42 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Quit: drexl]     
18:47 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-pxakrddaesvkkxuj] has joined #bitcoin-core-dev     
18:47 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-pxakrddaesvkkxuj] has quit [Remote host closed the connection]     
18:53 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-rhbbqmbgggyjxtjs] has joined #bitcoin-core-dev     
19:00 < luke-jr> sipa: any obvious way to perhaps make the dnsseed.dat files compress and/or xdelta better? with 1.2 GB every day, it's starting to add up (~200 GB since 2012, compressed)
19:00 < luke-jr> maybe there's some kind of sorting that would help
19:04 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]     
19:05 -!- herzmeister[m] [herzmeiste@gateway/shell/matrix.org/x-eixfnkzypwdisdzc] has joined #bitcoin-core-dev     
19:05 -!- ajtowns[m] [ajtownsmat@gateway/shell/matrix.org/x-nonsfxnuhxnkaubh] has joined #bitcoin-core-dev     
19:05 -!- Masaomi[m] [masaomimat@gateway/shell/matrix.org/x-njlevwajkktbnhwo] has joined #bitcoin-core-dev     
19:05 -!- stepa[m] [stepamatri@gateway/shell/matrix.org/x-dteeewrfzskanqjk] has joined #bitcoin-core-dev     
19:05 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds]     
19:06 < sipa> luke-jr: the file is 276 MiB for me
19:27 -!- tryphe_ is now known as tryphe     
19:28 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
19:29 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
19:37 -!- psyopp [~rls@ip68-3-117-141.ph.ph.cox.net] has joined #bitcoin-core-dev     
19:40 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-sdnghihlowdaptle] has joined #bitcoin-core-dev     
19:41 -!- karimofthecrop [~karim@rrcs-76-80-21-234.west.biz.rr.com] has joined #bitcoin-core-dev     
19:41 -!- rls [~rls@74.120.222.234] has quit [Ping timeout: 264 seconds]     
19:42 -!- jojeyh [~delphi@99-59-126-62.lightspeed.irvnca.sbcglobal.net] has joined #bitcoin-core-dev     
19:46 -!- karimofthecrop [~karim@rrcs-76-80-21-234.west.biz.rr.com] has quit [Ping timeout: 260 seconds]     
19:47 < luke-jr> sipa: 1.2 GB for me XD
19:48 -!- Guest2527 [75c85d79@gateway/web/cgi-irc/kiwiirc.com/ip.117.200.93.121] has quit [Ping timeout: 240 seconds]     
19:48 < luke-jr> and the xdelta for today to yesterday is 295 MB
19:50 -!- jojeyh [~delphi@99-59-126-62.lightspeed.irvnca.sbcglobal.net] has quit [Ping timeout: 276 seconds]     
19:53 < midnightmagic> is there that much churn?
19:54 -!- jojeyh [~delphi@99-59-126-62.lightspeed.irvnca.sbcglobal.net] has joined #bitcoin-core-dev     
19:54 < luke-jr> dunno, I guess if I started over, mine would look closer to sipa's, but it seems more useful to have the diversity of whatever old data is in there
20:14 -!- karimofthecrop [~karim@rrcs-76-80-21-234.west.biz.rr.com] has joined #bitcoin-core-dev     
20:17 -!- jojeyh [~delphi@99-59-126-62.lightspeed.irvnca.sbcglobal.net] has quit [Ping timeout: 256 seconds]     
20:32 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev     
20:38 -!- goatpig [56f75164@gateway/web/freenode/ip.86.247.81.100] has quit [Quit: Page closed]     
20:49 -!- jojeyh [~delphi@2602:306:b8b6:b970:2d5d:ab28:fb21:e375] has joined #bitcoin-core-dev     
20:49 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 256 seconds]     
20:57 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev     
21:08 < jtimon> thoughts on https://github.com/bitcoin/bitcoin/pull/10757#issuecomment-377440180 ? specially @MarcoFalke and @aj
21:23 < ProfMac> Not totally unrelated to dnsseed.dat, I wrote my first awk script and have been looking at debug.log to see who is connecting to me.  I especially looked at IPv6 addresses, and I notice a lot of alias addresses for the same machine.  I assume my data is almost identical to the peers.dat data.
21:25 < ProfMac> https://gist.github.com/a-mcintosh/8f3e87973483fd2cba98de0079bf0327#file-prime-awk
21:32 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 264 seconds]     
21:44 -!- tknp [~tknp@unaffiliated/tknp] has joined #bitcoin-core-dev     
21:48 -!- Samdney [~Samdney@178.162.209.137] has quit [Quit: Verlassend]     
21:52 -!- tknp [~tknp@unaffiliated/tknp] has quit [Quit: tknp]     
21:55 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev     
21:58 -!- Brometheus [~TuxXXX@ool-ad02c26d.dyn.optonline.net] has joined #bitcoin-core-dev     
22:01 < aj> jtimon: sorry, i keep forgetting to send you test case code for getblockstats
22:02 < jtimon> aj: feel free to open a pr with my commits plus your tests, I really think it's the best wat to test it in concept but never wrote or seen the code
22:06 < jtimon> and of course if you do ping me for review and testing
22:13 < aj> BlueMatt: iceweasel rebranding was trademark issues (maybe "can't use firefox trademark if you ship old shit" though, i forget; thought it was just that debian did patches though), but they did away with that and introduced "extended support releases", so firefox-esr is in debian stable these days, and iceweasel is long gone
22:19 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-sdnghihlowdaptle] has quit [Quit: Connection closed for inactivity]     
22:23 -!- nitramiz [~nitramiz@76.76.240.247] has quit [Ping timeout: 256 seconds]     
22:32 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has quit [Remote host closed the connection]     
22:33 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has joined #bitcoin-core-dev     
22:37 -!- treyzania [~treyzania@troy.tr3y.io] has quit [Quit: ZNC 1.6.6 - http://znc.in]     
22:43 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 264 seconds]     
22:50 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev     
22:53 -!- Randolf [~randolf@96.53.47.42] has quit [Read error: Connection reset by peer]     
23:08 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev     
23:08 -!- indistylo [~indistylo@119.82.105.106] has joined #bitcoin-core-dev     
23:09 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Client Quit]     
23:10 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev     
23:11 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds]     
23:14 < jimpo> Do people think that the best-effort getrawtransaction lookup from CCoinsCacheView if the txindex is disabled is a useful thing?
23:14 < jimpo> As opposed to requiring either the txindex for the RPC to work or passing in the block_hash argument?
23:21 < sipa> see #3220
23:21 < gribble> https://github.com/bitcoin/bitcoin/issues/3220 | Getrawtransaction working partially without -txindex is confusing · Issue #3220 · bitcoin/bitcoin · GitHub
23:25 < jimpo> Ah, thx
23:27 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev     
23:31 -!- karimofthecrop [~karim@rrcs-76-80-21-234.west.biz.rr.com] has quit [Ping timeout: 260 seconds]     
23:32 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 260 seconds]     
23:34 -!- farsider355 [farsider35@161.43.207.14] has joined #bitcoin-core-dev     
23:34 -!- farsider355 [farsider35@161.43.207.14] has quit [Excess Flood]     
23:34 -!- farsider355 [farsider35@161.43.207.14] has joined #bitcoin-core-dev     
23:34 -!- farsider350 [farsider35@161.43.207.14] has quit [Ping timeout: 240 seconds]     
23:34 -!- farsider355 [farsider35@161.43.207.14] has quit [Client Quit]     
23:38 -!- aruns [~indistylo@119.82.105.106] has joined #bitcoin-core-dev     
23:40 -!- indistylo [~indistylo@119.82.105.106] has quit [Ping timeout: 260 seconds]     
23:41 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 264 seconds]     
23:53 -!- Brometheus [~TuxXXX@ool-ad02c26d.dyn.optonline.net] has quit [Read error: Connection reset by peer]     
23:54 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has quit [Ping timeout: 256 seconds]     
23:56 -!- karimofthecrop [~karim@rrcs-76-80-21-234.west.biz.rr.com] has joined #bitcoin-core-dev     
23:58 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has quit [Remote host closed the connection]     
23:58 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has joined #bitcoin-core-dev