--- Day changed Thu Apr 05 2018 00:00 < wumpus> some of the tests use BOOST_EQUAL and such in inner loops, while they're somewhat heavyweight 00:00 < wumpus> (IIRC, for example one of the verbosity options causes them to log everything) 00:01 -!- Samdney [~Samdney@37.58.58.248] has joined #bitcoin-core-dev 00:03 < wumpus> aj: you could use my methodology from #10026 (need to update it) to find if there are any tests that are especially show with gcc or clang 00:03 < gribble> https://github.com/bitcoin/bitcoin/issues/10026 | Overview of slow unit tests · Issue #10026 · bitcoin/bitcoin · GitHub 00:04 < aj> wumpus: well, i tried to debug it, but gcc started doing things as fast as clang so now i don't know 00:04 < aj> wumpus: better than clang doing things as slow as gcc at least 00:04 < wumpus> okay, might have been comparing a debug build against a release build 00:05 < wumpus> perf differences are brutal between those 00:05 < aj> wumpus: oh, could have been -- do you know which bit is the difference there? 00:06 < wumpus> lower optimization level as well as the mutex checking stuff overhead 00:07 < aj> wumpus: oh... if anything it seemed that --with-debug was going faster :-/ 00:10 -!- dx25_ [~dx25@97.119.181.222] has quit [Ping timeout: 256 seconds] 00:11 -!- Alan_ [4930c506@gateway/web/freenode/ip.73.48.197.6] has joined #bitcoin-core-dev 00:11 -!- Alan_ is now known as Guest85364 00:12 -!- Guest85364 [4930c506@gateway/web/freenode/ip.73.48.197.6] has quit [Client Quit] 00:13 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9a2db3b3d511...2fc94370f510 00:13 < bitcoin-git> bitcoin/master 5b10ab0 John Newbery: [trivial] Add newlines to end of log messages.... 00:13 < bitcoin-git> bitcoin/master 2fc9437 Wladimir J. van der Laan: Merge #12887: [trivial] Add newlines to end of log messages.... 00:14 < bitcoin-git> [bitcoin] laanwj closed pull request #12887: [trivial] Add newlines to end of log messages. (master...log_messages_newlines) https://github.com/bitcoin/bitcoin/pull/12887 00:14 -!- dx25 [~dx25@67-3-137-174.omah.qwest.net] has joined #bitcoin-core-dev 00:16 -!- Ishtv4n [~Ishtv4n@46.246.69.150] has joined #bitcoin-core-dev 00:26 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 00:30 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 00:33 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2fc94370f510...bd59c4395c50 00:33 < bitcoin-git> bitcoin/master a5bca13 Luke Dashjr: Bugfix: Include for std::unique_ptr 00:33 < bitcoin-git> bitcoin/master bd59c43 Wladimir J. van der Laan: Merge #12859: Bugfix: Include for std::unique_ptr... 00:34 < bitcoin-git> [bitcoin] laanwj closed pull request #12859: Bugfix: Include for std::unique_ptr (master...incl_memory) https://github.com/bitcoin/bitcoin/pull/12859 00:39 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has joined #bitcoin-core-dev 00:54 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/bd59c4395c50...2b54155a459c 00:54 < bitcoin-git> bitcoin/master a5263fb Indospace.io: doc: Use bitcoind in Tor documentation 00:54 < bitcoin-git> bitcoin/master 2b54155 Wladimir J. van der Laan: Merge #12877: doc: Use bitcoind in Tor documentation... 00:55 < bitcoin-git> [bitcoin] laanwj closed pull request #12877: doc: Use bitcoind in Tor documentation (master...patch-1) https://github.com/bitcoin/bitcoin/pull/12877 01:04 -!- LeMiner [LeMiner@unaffiliated/leminer] has quit [Read error: Connection reset by peer] 01:05 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:05 -!- LeMiner [LeMiner@unaffiliated/leminer] has joined #bitcoin-core-dev 01:06 -!- aruns [~indistylo@119.82.105.106] has quit [Ping timeout: 240 seconds] 01:09 -!- udiWertheimer [sid190185@gateway/web/irccloud.com/x-wlobdrmgnzbzanid] has quit [Read error: Connection reset by peer] 01:09 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-prodbehyiazkxmgk] has quit [Read error: Connection reset by peer] 01:10 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:10 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 276 seconds] 01:10 -!- udiWertheimer [sid190185@gateway/web/irccloud.com/x-cipricdmvaaumufc] has joined #bitcoin-core-dev 01:10 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 01:10 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-rocmopojfzpasgcg] has joined #bitcoin-core-dev 01:11 -!- BCBot_ [~BCBot@46.101.246.115] has joined #bitcoin-core-dev 01:11 -!- BCBot [~BCBot@46.101.246.115] has quit [Ping timeout: 264 seconds] 01:11 -!- cysm [cysm@gateway/shell/elitebnc/x-krzlofpjgulzdscu] has quit [Ping timeout: 264 seconds] 01:11 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 256 seconds] 01:12 -!- LeMiner [LeMiner@unaffiliated/leminer] has quit [Ping timeout: 264 seconds] 01:12 -!- spinza [~spin@196.212.164.26] has quit [Ping timeout: 264 seconds] 01:12 -!- jouke [~jouke@unaffiliated/komkommer] has quit [Ping timeout: 264 seconds] 01:12 -!- musalbas [~musalbas@algebra.musalbas.com] has quit [Ping timeout: 264 seconds] 01:12 -!- gwillen [~gwillen@unaffiliated/gwillen] has quit [Ping timeout: 256 seconds] 01:13 -!- musalbas [~musalbas@algebra.musalbas.com] has joined #bitcoin-core-dev 01:13 -!- jouke [~jouke@a80-100-203-151.adsl.xs4all.nl] has joined #bitcoin-core-dev 01:13 -!- LeMiner [LeMiner@unaffiliated/leminer] has joined #bitcoin-core-dev 01:14 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 01:14 -!- gwillen [~gwillen@unaffiliated/gwillen] has joined #bitcoin-core-dev 01:15 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev 01:15 -!- LeMiner [LeMiner@unaffiliated/leminer] has quit [Read error: Connection reset by peer] 01:15 -!- nullptr| [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has quit [Ping timeout: 240 seconds] 01:16 -!- LeMiner [LeMiner@unaffiliated/leminer] has joined #bitcoin-core-dev 01:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:17 -!- nullptr| [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has joined #bitcoin-core-dev 01:18 -!- cysm [cysm@gateway/shell/elitebnc/x-ixjmfkenztlfluec] has joined #bitcoin-core-dev 01:18 -!- gwillen [~gwillen@unaffiliated/gwillen] has quit [Ping timeout: 240 seconds] 01:18 -!- gwillen [~gwillen@unaffiliated/gwillen] has joined #bitcoin-core-dev 01:21 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 01:21 -!- spinza [~spin@196.212.164.26] has joined #bitcoin-core-dev 01:23 -!- vicenteH [~user@248.red-79-159-36.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 01:24 -!- echeveria [~echeveria@unaffiliated/echeveria] has quit [Ping timeout: 256 seconds] 01:25 -!- shtirlic [~shtirlic@Shtirlic-2-pt.tunnel.tserv6.fra1.ipv6.he.net] has quit [Ping timeout: 260 seconds] 01:25 -!- LeMiner2 [LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has joined #bitcoin-core-dev 01:26 -!- stepa[m] [stepamatri@gateway/shell/matrix.org/x-dteeewrfzskanqjk] has quit [Ping timeout: 245 seconds] 01:26 -!- Lightsword [~Lightswor@2604:a880:1:20::1d3:9001] has quit [Ping timeout: 256 seconds] 01:27 -!- ryanofsky [russ@jumpy.yanofsky.org] has quit [Ping timeout: 256 seconds] 01:27 -!- LeMiner [LeMiner@unaffiliated/leminer] has quit [Ping timeout: 264 seconds] 01:27 -!- LeMiner2 is now known as LeMiner 01:27 -!- Masaomi[m] [masaomimat@gateway/shell/matrix.org/x-njlevwajkktbnhwo] has quit [Ping timeout: 260 seconds] 01:27 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-rhbbqmbgggyjxtjs] has quit [Ping timeout: 260 seconds] 01:27 -!- ryanofsky [russ@jumpy.yanofsky.org] has joined #bitcoin-core-dev 01:29 -!- Modesta14Reynold [~Modesta14@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 240 seconds] 01:30 -!- ula [~ula@b2b-78-94-11-194.unitymedia.biz] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/] 01:30 -!- LeMiner [LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has quit [Read error: Connection reset by peer] 01:30 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-hpwutrkegutgvsnt] has joined #bitcoin-core-dev 01:31 -!- echeveria [~echeveria@2604:a880:2:d0::28:f001] has joined #bitcoin-core-dev 01:31 -!- echeveria [~echeveria@2604:a880:2:d0::28:f001] has quit [Changing host] 01:31 -!- echeveria [~echeveria@unaffiliated/echeveria] has joined #bitcoin-core-dev 01:31 -!- shtirlic [~shtirlic@ec2-35-158-173-101.eu-central-1.compute.amazonaws.com] has joined #bitcoin-core-dev 01:32 -!- Lightsword [~Lightswor@107.170.253.193] has joined #bitcoin-core-dev 01:32 -!- LeMiner [LeMiner@unaffiliated/leminer] has joined #bitcoin-core-dev 01:33 -!- Masaomi[m] [masaomimat@gateway/shell/matrix.org/x-jkspovjpdffxxylw] has joined #bitcoin-core-dev 01:35 -!- Ishtv4n [~Ishtv4n@46.246.69.150] has quit [Quit: Ishtv4n] 01:36 -!- stepa[m] [stepamatri@gateway/shell/matrix.org/x-vvbdregbufzyugxa] has joined #bitcoin-core-dev 01:36 -!- CubicEarths [~cubiceart@xdsl-188-155-63-9.adslplus.ch] has joined #bitcoin-core-dev 01:38 -!- LeMiner [LeMiner@unaffiliated/leminer] has quit [Read error: Connection reset by peer] 01:38 -!- pierre_rochard_ [~pierre_ro@unaffiliated/pierre-rochard/x-3593157] has joined #bitcoin-core-dev 01:38 -!- Ishtv4n [~Ishtv4n@46.246.69.150] has joined #bitcoin-core-dev 01:39 -!- pierre_rochard [~pierre_ro@unaffiliated/pierre-rochard/x-3593157] has quit [Ping timeout: 268 seconds] 01:39 -!- pierre_rochard_ is now known as pierre_rochard 01:39 -!- promag [~promag@bl19-45-51.dsl.telepac.pt] has joined #bitcoin-core-dev 01:40 -!- Ishtv4n [~Ishtv4n@46.246.69.150] has quit [Remote host closed the connection] 01:42 -!- Ishtv4n [~Ishtv4n@46.246.69.150] has joined #bitcoin-core-dev 01:51 -!- LeMiner [LeMiner@unaffiliated/leminer] has joined #bitcoin-core-dev 01:56 -!- promag [~promag@bl19-45-51.dsl.telepac.pt] has quit [Remote host closed the connection] 02:02 -!- Bridgette4Marks [~Bridgette@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 02:05 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-aalevjvgheuvrteu] has quit [Quit: Connection closed for inactivity] 02:15 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 02:16 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has quit [Ping timeout: 256 seconds] 02:17 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has joined #bitcoin-core-dev 02:34 -!- LeMiner2 [LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has joined #bitcoin-core-dev 02:35 -!- LeMiner [LeMiner@unaffiliated/leminer] has quit [Ping timeout: 264 seconds] 02:35 -!- LeMiner2 is now known as LeMiner 02:51 -!- Giszmo1 [~leo@pc-37-38-86-200.cm.vtr.net] has quit [Ping timeout: 240 seconds] 02:57 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has joined #bitcoin-core-dev 03:00 -!- gemian [01d13038@gateway/web/freenode/ip.1.209.48.56] has quit [Ping timeout: 260 seconds] 03:40 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has quit [Ping timeout: 260 seconds] 03:40 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has joined #bitcoin-core-dev 04:37 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has quit [Ping timeout: 276 seconds] 04:54 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has joined #bitcoin-core-dev 04:58 -!- merehap_ [~merehap@204.152.214.26] has joined #bitcoin-core-dev 05:01 < mryandao> is travis being flaky again? 05:01 -!- merehap [~merehap@67.215.231.234] has quit [Ping timeout: 276 seconds] 05:08 -!- booyah_ is now known as booyah 05:11 -!- satwo [~textual@2602:306:378a:6fb0:d8a9:e11d:a632:5890] has joined #bitcoin-core-dev 05:16 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has quit [Remote host closed the connection] 05:16 < wumpus> what's the problem? 05:17 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has joined #bitcoin-core-dev 05:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:21 < mryandao> #12240 failed due to a timeout for 2 05:21 < gribble> https://github.com/bitcoin/bitcoin/issues/12240 | [rpc] Introduced a new `fees` structure that aggregates all sub-field fee types denominated in BTC by mryandao · Pull Request #12240 · bitcoin/bitcoin · GitHub 05:22 < mryandao> "The job exceeded the maximum time limit for jobs, and has been terminated." 05:22 < wumpus> fantastic 05:22 < mryandao> ¯\_ (ツ) _/¯ 05:23 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 05:23 < wumpus> I've restarted job 2 05:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds] 05:23 < aj> i've been trying out the 32bit windows travis checks with more logging; seems like when it succeeds, the coinselection tests take about 15m. i think i'm going to have one fail now, and it's taking ages to compile before even getting to the tests 05:23 < mryandao> cant the bitcoin core project afford dedicated machines with gitlab ci? 05:23 < aj> https://travis-ci.org/ajtowns/bitcoin/builds/362589978 05:25 < aj> wallet/test/coinselector_tests.cpp(17): Leaving test suite "coinselector_tests"; testing time: 950408ms 05:27 < wumpus> mryandao: it's more of a problem of people than resources, no one really wants to babysit servers. There used to be a "pulltester" running some CI script on a VM, switching to travis was great. But yeah lately... 05:30 < wumpus> I think cfields tried pretty much everything except waving a wad of money in travis representative's face to get more capacity, but no luck 05:30 < aj> make is taking 18s on one host, but 822s on the other 05:30 < jonasschnelli> there are also the nightly gitian builds I run... though not a real CI (runs no tests) 05:30 < jonasschnelli> ideally the gitian builder would test the binaries in some VMs 05:30 < aj> (make all i mean, not make check) 05:31 -!- Samdney [~Samdney@37.58.58.248] has quit [Ping timeout: 256 seconds] 05:31 -!- laurentmt [~Thunderbi@37.58.58.232] has joined #bitcoin-core-dev 05:33 -!- Samdney [~Samdney@37.58.58.248] has joined #bitcoin-core-dev 05:34 -!- indistylo [~indistylo@119.82.105.106] has joined #bitcoin-core-dev 05:36 -!- aruns [~indistylo@119.82.105.106] has joined #bitcoin-core-dev 05:36 -!- aruns [~indistylo@119.82.105.106] has quit [Remote host closed the connection] 05:36 -!- aruns [~indistylo@119.82.105.106] has joined #bitcoin-core-dev 05:39 -!- indistylo [~indistylo@119.82.105.106] has quit [Ping timeout: 264 seconds] 05:39 -!- laurentmt [~Thunderbi@37.58.58.232] has quit [Quit: laurentmt] 05:45 < wumpus> jonasschnelli: yes, that would be nice, esp for targets not covered by travis at the moment 05:46 < wumpus> aj: yes, compile speed varies a lot between platforms - I suppose memory amount and speed plays a large role, apart from CPU speed 05:46 < aj> wumpus: this is the same platform though, i686-w64-mingw32 with DPKG_ADD_ARCH i386 05:47 -!- shesek` [~shesek@bzq-84-110-232-235.red.bezeqint.net] has quit [Ping timeout: 240 seconds] 05:48 < wumpus> wait, your'e building *on* the same platform or *for* the same platform 05:48 < wumpus> or both? 05:49 < aj> mostly difference in compile time rather than test time though -- 13m for make all, 20m for test, 11m for make depends, and that's almost the timeout 05:49 < aj> wumpus: same job twice, i just rearranged the arg order so it didn't get deduped 05:50 < wumpus> ok 05:50 < aj> with make check replaced by test_bitcoin.exe -l test_suite or so 05:51 < wumpus> your results confuse me a lot 05:51 < aj> :) 05:51 < aj> i guess it means some of their w64 hosts are overloaded/slow/broken? 05:52 < aj> (and also, our coinselector_tests are a bit slow on w64 for some reason? 15 mins seems crazy) 05:54 < sipa> that is crazy 05:54 < sipa> how fast are they on i686? 05:55 < wumpus> so I would guess that's due to boost::test, doing BOOST_EQUALS etc in an inner loop 05:57 < aj> haven't tried on other arches; running now as https://travis-ci.org/ajtowns/bitcoin/builds/362613881 06:02 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 06:03 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 06:07 -!- wxss [~user@46-227-67-54.static.obenetwork.net] has joined #bitcoin-core-dev 06:13 -!- atroxes [~atroxes@unaffiliated/atroxes] has quit [Ping timeout: 268 seconds] 06:13 < sipa> wumpus: ? 06:13 < wumpus> sipa: hm? 06:14 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has quit [Ping timeout: 260 seconds] 06:14 < wumpus> oh I can check how long the test takes, if you mean that 06:14 -!- atroxes [~atroxes@unaffiliated/atroxes] has joined #bitcoin-core-dev 06:15 < sipa> ah, can we move the inner loop checks out? 06:15 < sipa> accumulate a set of failure strings, and thwn assert that it is empty (with the set as message? 06:16 < wumpus> yes, that would be a good option 06:17 < jnewbery> wumpus: great, I'll have a shot at uncursing it 06:20 < wumpus> coinselector_tests takes 10.5 seconds here locally 06:21 < wumpus> (linux, x86_64) 06:21 < aj> sigh. "test_bitcoin.exe" doesn't work well on non windows funnily enough 06:22 < wumpus> what's the problem? 06:23 < aj> linux doesn't add ".exe" :) 06:23 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has joined #bitcoin-core-dev 06:24 < wumpus> #8650 "unit tests can be really slow under wine because BOOST_CHECK logs something for all tests. This patch makes them faster by only logging tests which fail. PR'd an alternative to #8632." 06:24 < gribble> https://github.com/bitcoin/bitcoin/issues/8650 | Make tests much faster by replacing BOOST_CHECK with FAST_CHECK by JeremyRubin · Pull Request #8650 · bitcoin/bitcoin · GitHub 06:24 < gribble> https://github.com/bitcoin/bitcoin/issues/8632 | Speed up prevector tests by parallelization by JeremyRubin · Pull Request #8632 · bitcoin/bitcoin · GitHub 06:25 < wumpus> same problem, but that solution was kind of over the top as it replaces BOOST_CHECK completely, everywhere 06:25 < wumpus> so in the end we just sped up the prevector tests instead - coinselector tests likely have the same problem 06:31 -!- Ishtv4n [~Ishtv4n@46.246.69.150] has quit [Remote host closed the connection] 06:32 -!- Krellan [~Krellan@2601:640:4000:9258:8550:d013:44d4:33e9] has quit [Read error: Connection reset by peer] 06:33 -!- Krellan [~Krellan@2601:640:4000:9258:b0b8:61dc:2255:4948] has joined #bitcoin-core-dev 06:41 < wumpus> aj: should still work if wine is installed 06:44 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 268 seconds] 06:46 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:48 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 07:00 -!- atroxes [~atroxes@unaffiliated/atroxes] has quit [Ping timeout: 276 seconds] 07:02 -!- atroxes [~atroxes@unaffiliated/atroxes] has joined #bitcoin-core-dev 07:03 -!- aruns [~indistylo@119.82.105.106] has quit [Ping timeout: 260 seconds] 07:09 < sipa> wumpus: are you sure it's due to coin selection? 07:09 < sipa> i'm looking at the total number of assertions in every test, and coin selection is tiny 07:09 < sipa> it has 7022 assertions out of 4850320 07:09 < wumpus> sipa: that's what aj said - okay in that case it's another thing that is slow in wine 07:10 < sipa> coins_tests/updatecoins_simulation_test has 1223073 assertions 07:11 < wumpus> whoa 07:12 < wumpus> aj ^^ 07:13 < sipa> what is the command used to actually run the test for windows on travis? 07:14 < sipa> wine src/bitcoin/test_bitcoin.exe ? 07:18 < wumpus> just 'make check', which will do that indirectly, I expect 07:18 < bitcoin-git> [bitcoin] sipa opened pull request #12890: [DEBUG TRAVIS] Detailed unit test report for win32 (master...201803_debugtravis) https://github.com/bitcoin/bitcoin/pull/12890 07:19 < sipa> yes but i want to modify the arguments it's being called with 07:19 < bitcoin-git> [bitcoin] jnewbery opened pull request #12891: [logging] add lint-logs.sh to check for newline termination. (master...log_lint) https://github.com/bitcoin/bitcoin/pull/12891 07:19 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 07:20 < aj> sipa: i've been running "travis_wait 50 src/test/test_bitcoin.exe -l test_suite" 07:22 < aj> wallet/test/coinselector_tests.cpp(17): Leaving test suite "coinselector_tests"; testing time: 21124667us # us not ms, so just 21s on x86-64 with qt5 07:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds] 07:25 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 07:27 -!- GtomBlam [54c7fe9c@gateway/web/freenode/ip.84.199.254.156] has joined #bitcoin-core-dev 07:28 < aj> without the wallet compiled in, all the tests seem to take 33,566,015us so 33s, which seems fine 07:28 -!- GtomBlam [54c7fe9c@gateway/web/freenode/ip.84.199.254.156] has quit [Client Quit] 07:28 < aj> and the qt4 test times are reported with units of "mks" so i don't know what that means 07:28 < aj> https://travis-ci.org/ajtowns/bitcoin/builds/362625669 07:29 -!- jamesob [~james@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Read error: Connection reset by peer] 07:30 < wumpus> https://stackoverflow.com/questions/28970229/what-is-the-mks-unit-reported-by-the-boost-unit-test-framework 07:30 < wumpus> apparently, the Russian abbreviation for millisecond... 07:31 -!- Samdney [~Samdney@37.58.58.248] has quit [Quit: Verlassend] 07:32 < ryanofsky> wumpus, had been wondering if you think #10244 is ready, pinged you here: https://github.com/bitcoin/bitcoin/pull/10244#issuecomment-378357905 07:32 < gribble> https://github.com/bitcoin/bitcoin/issues/10244 | Refactor: separate gui from wallet and node by ryanofsky · Pull Request #10244 · bitcoin/bitcoin · GitHub 07:32 -!- CubicEarths [~cubiceart@xdsl-188-155-63-9.adslplus.ch] has quit [Remote host closed the connection] 07:33 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 07:33 < wumpus> ... or microsecond (sorry, the answer is unclear too) 07:34 < wumpus> ryanofsky: looks like it! 07:34 < aj> sipa: might be faster to build with mingw32 locally, and just include test_bitcoin.exe in the debug commit 07:35 < sipa> ? 07:36 < aj> sipa: as opposed to actually compiling test_bitcoin.exe on travis, just include it in the PR and run it on travis 07:38 < sipa> then i have to make sure the binary is compatible etc 07:38 -!- BCBot_ [~BCBot@46.101.246.115] has quit [Remote host closed the connection] 07:38 -!- BCBot [~BCBot@46.101.246.115] has joined #bitcoin-core-dev 07:39 < sipa> hmm, i guess that's not an issue for win binaries 07:42 < wumpus> it's indeed not an issue; the windows binaries are self-contained except for OS libs 07:43 -!- Samdney [~Samdney@178.162.209.136] has joined #bitcoin-core-dev 07:44 < sipa> compilation is very slow on travis; don't we use ccache across runs or something? 07:44 -!- satwo [~textual@2602:306:378a:6fb0:d8a9:e11d:a632:5890] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 07:45 < wumpus> it should ($HOME/.ccache is among the travis-cached directories) 07:50 -!- unholymachine [~quassel@2601:8c:c003:9f16:8c84:ec3d:50d:a9ed] has quit [Remote host closed the connection] 07:54 < sipa> aj: any other explanations about what could make the coin selection test so slow on windows (relatively to other platforms)? 07:55 < aj> sipa: i wonder if it's hitting a slow interpretation path in wine somehow? 07:57 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 255 seconds] 07:58 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 07:59 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 07:59 < wumpus> aj: the way to find out would be to try on real windows 08:00 < wumpus> if it's also slow there, gcc-mingw64 is the problem, if not, it's wine 08:06 -!- laurentmt [~Thunderbi@37.58.58.232] has joined #bitcoin-core-dev 08:12 -!- grafcaps [~haroldbr@104.137.194.255] has joined #bitcoin-core-dev 08:13 -!- pyericz [~pyericz@183.250.230.254] has joined #bitcoin-core-dev 08:13 -!- pyericz [~pyericz@183.250.230.254] has quit [Client Quit] 08:21 -!- CubicEar_ [~cubiceart@xdsl-188-155-63-9.adslplus.ch] has joined #bitcoin-core-dev 08:23 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev 08:24 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 260 seconds] 08:50 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 255 seconds] 08:50 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 08:51 -!- Krellan [~Krellan@2601:640:4000:9258:b0b8:61dc:2255:4948] has quit [Read error: Connection reset by peer] 08:51 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 08:52 -!- Krellan [~Krellan@2601:640:4000:9258:b0b8:61dc:2255:4948] has joined #bitcoin-core-dev 08:53 -!- laurentmt [~Thunderbi@37.58.58.232] has quit [Quit: laurentmt] 08:53 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 08:58 -!- moneyball [~moneyball@65.200.72.90] has joined #bitcoin-core-dev 09:04 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has quit [Remote host closed the connection] 09:05 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has joined #bitcoin-core-dev 09:08 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has joined #bitcoin-core-dev 09:19 -!- JackH [~laptop@host-80-47-80-55.as13285.net] has quit [Quit: Leaving] 09:19 < bitcoin-git> [bitcoin] laanwj pushed 22 new commits to master: https://github.com/bitcoin/bitcoin/compare/2b54155a459c...5f0c6a7b0e47 09:20 < bitcoin-git> bitcoin/master ea73b84 Russell Yanofsky: Add src/interface/README.md 09:20 < bitcoin-git> bitcoin/master 71e0d90 Russell Yanofsky: Remove direct bitcoin calls from qt/bitcoin.cpp 09:20 < bitcoin-git> bitcoin/master c0f2756 Russell Yanofsky: Remove direct bitcoin calls from qt/optionsmodel.cpp 09:20 < bitcoin-git> [bitcoin] laanwj closed pull request #10244: Refactor: separate gui from wallet and node (master...pr/ipc-local) https://github.com/bitcoin/bitcoin/pull/10244 09:27 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 09:28 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 09:43 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 268 seconds] 09:44 -!- Krellan [~Krellan@2601:640:4000:9258:b0b8:61dc:2255:4948] has quit [Remote host closed the connection] 09:44 -!- Krellan [~Krellan@2601:640:4000:9258:9902:fd45:97ac:af89] has joined #bitcoin-core-dev 09:45 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has quit [Quit: zarez] 09:45 -!- JackH [~laptop@host-80-47-80-55.as13285.net] has joined #bitcoin-core-dev 09:46 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 09:46 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 256 seconds] 09:49 -!- Krellan [~Krellan@2601:640:4000:9258:9902:fd45:97ac:af89] has quit [Ping timeout: 276 seconds] 09:50 < BlueMatt> so we now have 4 pending PRs which rewrite CValidationState, and all of them stomp on each others' toes significantly 09:50 < BlueMatt> should probably pick one and get it merged asap instead of waiting until someone *else* decides they also want to rewrite CValidationState 09:50 -!- Krellan [~Krellan@2601:640:4000:9258:d064:2a21:4d45:ccd6] has joined #bitcoin-core-dev 09:51 < instagibbs> BlueMatt, clearly we need a standard on how to rewrite CValidationState 09:52 < BlueMatt> nono, we need someone else to sit down and *write* a standard, and then a new PR for it 09:53 < wumpus> we should get all the people that want to rewrite CValidationState into an (IRC) room and get them to agree what their goal is 09:53 < sipa> can we please create a BCIP process first? 09:54 < sipa> "bitcoin core implementation proposal" 09:54 < wumpus> definitely 09:55 < bitcoin-git> [bitcoin] jl2012 closed pull request #8654: [WIP] Reuse sighash computations across evaluation (master...sighashcache) https://github.com/bitcoin/bitcoin/pull/8654 09:55 -!- Krellan [~Krellan@2601:640:4000:9258:d064:2a21:4d45:ccd6] has quit [Ping timeout: 245 seconds] 09:55 < BlueMatt> wumpus: well it looks like Empact backed out the changes in #12463 that essentially made it into #11639, and #11523 needs rebase pretty significantly (and I'm not a huge fan of parts of it, hence #11639) 09:55 < gribble> https://github.com/bitcoin/bitcoin/issues/12463 | Drop the return and corruptionPossible arguments from CValidationState::DoS, and rename to ::Reject by Empact · Pull Request #12463 · bitcoin/bitcoin · GitHub 09:55 < gribble> https://github.com/bitcoin/bitcoin/issues/11639 | Rewrite the interface between validation and net_processing wrt DoS by TheBlueMatt · Pull Request #11639 · bitcoin/bitcoin · GitHub 09:55 < wumpus> write four BCIPs, then randomly copy/paste from them into one, which is used for the implementation guideline 09:55 < gribble> https://github.com/bitcoin/bitcoin/issues/11523 | [Refactor] CValidation State by JeremyRubin · Pull Request #11523 · bitcoin/bitcoin · GitHub 09:55 < gribble> https://github.com/bitcoin/bitcoin/issues/11639 | Rewrite the interface between validation and net_processing wrt DoS by TheBlueMatt · Pull Request #11639 · bitcoin/bitcoin · GitHub 09:55 < BlueMatt> but #11639 has been open for months and gotten no review except for suhas 09:55 < gribble> https://github.com/bitcoin/bitcoin/issues/11639 | Rewrite the interface between validation and net_processing wrt DoS by TheBlueMatt · Pull Request #11639 · bitcoin/bitcoin · GitHub 09:56 < sipa> i'll review 11639 09:56 < wumpus> would make sense to add it to high priority then, I guess 09:56 < sipa> would it help if i concept ack it quickly? 09:56 < wumpus> it can't hurt at least 09:56 < BlueMatt> it would, yes 09:56 < BlueMatt> I can rebase it, but the rebase-needed parts are pretty much in the scripted-diffs, so whatever 09:56 < wumpus> for an interface change concepts ack are important 09:57 < sipa> if it's clear that that is the approach we want to take, i think we should prioritize the larger-refactor over the patch-up small prs 09:57 < wumpus> right 09:57 < midnightmagic> '/w 2 09:57 < midnightmagic> woops, sorry. 09:57 < sipa> unless the larger refactor will take so long regardless that it's better to have small fixes actually in master 09:58 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 10:00 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 10:11 -!- Arokh [~Arokh@extknot.com] has quit [Ping timeout: 256 seconds] 10:13 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 10:14 -!- Murch [~murch@96.74.120.81] has joined #bitcoin-core-dev 10:16 -!- drizztbsd [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 10:16 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has quit [Ping timeout: 260 seconds] 10:17 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 10:19 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has joined #bitcoin-core-dev 10:19 -!- Arokh [~Arokh@extknot.com] has joined #bitcoin-core-dev 10:27 -!- Arokh [~Arokh@extknot.com] has quit [Ping timeout: 256 seconds] 10:28 -!- Murch [~murch@96.74.120.81] has quit [Quit: Snoozing.] 10:28 < bitcoin-git> [bitcoin] jnewbery opened pull request #12892: [wallet] [rpc] introduce 'label' API for wallet (master...7729_jnewbery) https://github.com/bitcoin/bitcoin/pull/12892 10:29 -!- Murch [~murch@96.74.120.81] has joined #bitcoin-core-dev 10:29 -!- Danilo_ [~quassel@201.6.135.38] has joined #bitcoin-core-dev 10:33 -!- Arokh [~Arokh@extknot.com] has joined #bitcoin-core-dev 10:41 -!- Murch [~murch@96.74.120.81] has quit [Quit: Snoozing.] 10:47 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #7729: rpc: introduce 'label' API for wallet (master...2016_03_wallet_label_api) https://github.com/bitcoin/bitcoin/pull/7729 10:47 -!- jamesob [~james@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 10:50 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 10:55 -!- zarez [~Thunderbi@176.158.31.178] has joined #bitcoin-core-dev 10:55 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 256 seconds] 10:56 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 10:57 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev 10:57 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 11:00 -!- clarkmoody [2fdaf8ce@gateway/web/freenode/ip.47.218.248.206] has joined #bitcoin-core-dev 11:00 -!- isis is now known as isis_ 11:01 < jonasschnelli> meeting? 11:01 < wumpus> I think in an hour 11:01 < jonasschnelli> Oh. I see. 11:02 < BlueMatt> Last chance to get reviews in for last week's high-priority list before you get shamed at meeting! 11:07 -!- lman [50678861@gateway/web/cgi-irc/kiwiirc.com/ip.80.103.136.97] has joined #bitcoin-core-dev 11:09 -!- JackH [~laptop@host-80-47-80-55.as13285.net] has quit [Quit: Leaving] 11:10 -!- moneyball [~moneyball@65.200.72.90] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…] 11:10 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #12873: [ci] Run functional tests using bitcoin-qt in one Travis job (master...2018-04-03-travis-func-qt) https://github.com/bitcoin/bitcoin/pull/12873 11:19 -!- Arokh [~Arokh@extknot.com] has quit [Ping timeout: 256 seconds] 11:20 -!- Arokh [~Arokh@extknot.com] has joined #bitcoin-core-dev 11:30 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 11:32 -!- Murch [~murch@96.74.120.81] has joined #bitcoin-core-dev 11:36 < MarcoFalke> > jonasschnelli ideally the gitian builder would test the binaries in some VMs 11:36 < MarcoFalke> I do, if you fix the osx build ;) 11:36 < MarcoFalke> windows is WIP 11:37 < jonasschnelli> MarcoFalke: is it broken in general or only on my builder (haven't checked)? 11:37 < MarcoFalke> jonasschnelli: On your box 11:37 < MarcoFalke> There is some network timeout to aws 11:38 < MarcoFalke> fetchin a dependency that was recently bumped 11:39 < jonasschnelli> I'll have a look. 11:39 < MarcoFalke> Awesome, thx 11:39 < jonasschnelli> Currently traveling back to CH and back in my office next week 11:40 < MarcoFalke> Cool. Wir haben uns schon gefragt wo du so lange bleibst, heh 11:42 < MarcoFalke> suggested topics for meeting: Slow unit test/Run unit tests in parallel 11:44 -!- bule [~bule@gateway/tor-sasl/bule] has joined #bitcoin-core-dev 11:45 < wumpus> good idea 11:46 < sipa> yep 11:46 < sipa> jonasschnelli: where were you? 11:52 < jonasschnelli> sipa: I was 2 month in Indonesia... meeting was 3am... Internet speed was mostly 56kbit (shared with a couple of other people) 11:53 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 11:55 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-phqokvqrxssfdnhf] has joined #bitcoin-core-dev 11:55 -!- zarez [~Thunderbi@176.158.31.178] has quit [Ping timeout: 260 seconds] 11:55 < sipa> haha 11:55 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-ivbwrxwnxeevmgyn] has joined #bitcoin-core-dev 11:55 < sipa> BlueMatt: by "air" you mean "err" ? 11:56 < BlueMatt> no? I breathe air 11:56 < BlueMatt> oh, you mean on github, no, I mean air, as in "Matt doesn't know AIR-glish" 11:58 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 260 seconds] 11:58 < sipa> i preferr to err on the side of breathing air over earth 12:00 < sipa> *BOOM* 12:00 < wumpus> #startmeeting 12:00 < lightningbot> Meeting started Thu Apr 5 19:00:20 2018 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot. 12:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 12:00 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator 12:00 < jonasschnelli> hi 12:00 < sipa> hi 12:00 < Murch> hi 12:00 < jamesob> yo 12:00 < BlueMatt> This week's high-priority-for-review stats: 11857 got a few rounds of review (me, ryanofsky and sjors), 12560 went horribly under-reviewed (with only two comments from me and one from jimpo this week, no real reviews!), 11775 got one round of review from jimpo (which I missed until today, sorry about that!). MVP: jimpo. Overall rating: Needs Significant Improvement (for everyone except jimpo, for jimpo: Good Job!). 12:00 < phantomcircuit> wat 12:00 < wumpus> hi 12:01 < meshcollider> Hi 12:01 < wumpus> #topic high priority for review 12:01 < cfields> hi 12:01 -!- moneyball [~moneyball@65.200.72.90] has joined #bitcoin-core-dev 12:02 < BlueMatt> I mean no point nominating new things if its not gonna get any additional review. Might as well just directly ping jimpo and ask him to take a look. 12:02 < wumpus> well, I guess we need to keep it at the current list then, if the current ones don't get enough review we certainly shouldn't add more :) 12:02 < jnewbery> hi 12:02 < jamesob> This PR fixes a null pointer deref that's currently in master: https://github.com/bitcoin/bitcoin/pull/12836 12:03 < MarcoFalke> ^ Needs rebase 12:03 < achow101> hi 12:04 < wumpus> if something fixes an important issue such as a null pointer dereference (an existing one, not a potential one), please mention that in the PR title! 12:04 < instagibbs> achow101, if you rebase psbt I'd nominate it for high prio, not sure you have the time to carry it right now 12:04 < wumpus> "Make WalletInitInterface and DummyWalletInit private" really doesn't communicate that 12:04 < MarcoFalke> Also, those fixes should go in without having them to put on high-prio 12:04 < achow101> instagibbs: I'll try to do that later today or tomorrow 12:05 < wumpus> yes, apart from needing rebase it seems to have enough review to go in 12:05 < jonasschnelli> indeed 12:05 < meshcollider> wumpus: maybe he wasn't aware it fixed that 12:05 < wumpus> but please, don't hide fixes in refactor PRs 12:05 < kanzure> hi. 12:05 < wumpus> meshcollider: right , okay 12:06 < jnewbery> I think he wasn't aware of the bug that he fixed when he opened the PR 12:06 < wumpus> I see MarcoFalke already improved the title 12:06 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 264 seconds] 12:07 < wumpus> #topic Slow unit test/Run unit tests in parallel 12:07 < cfields> jimpo: thanks for the reviews 12:07 < MarcoFalke> I thought that running the unit tests in parallel (similar to how the functional tests are run in parallel) is a free win 12:07 -!- Sinclair6 [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has quit [Ping timeout: 265 seconds] 12:08 < jonasschnelli> MarcoFalke: is that possible with boost? 12:08 < MarcoFalke> Seems like they can be parallelized even on a single core 12:08 < jonasschnelli> https://www.boost.org/doc/libs/1_57_0/libs/test/doc/html/open-issues.html 12:08 < BlueMatt> yea, most of them use our globals in them 12:08 < cfields> MarcoFalke: i must admit, I kinda grumbled looking at your PR. Seems like it's really just a huge failure of the boost framework 12:08 < BlueMatt> we're a *long way* off from being able to do that, no? 12:08 < MarcoFalke> jonasschnelli: I adapted the google parallel tests wrapper 12:08 < wumpus> I hope it won't cause any ugly race conditions and such 12:08 < wumpus> we have so many intermittent travis failures as is :/ 12:08 < MarcoFalke> BlueMatt: It works for me 12:08 < wumpus> at this point I'd prefer more stable tests to faster ones 12:08 < jonasschnelli> AFAIK boost test can't be run in parallel... 12:08 < MarcoFalke> at least locally 12:09 < MarcoFalke> You spin up different processes of course 12:09 < BlueMatt> oh, sorry, i didnt realize they were separate processes, was thinking no way in hell separate threads works 12:09 < wumpus> ohh smart 12:09 < cfields> jonasschnelli: iirc MarcoFalke's PR creates a wrapper that runs them individually, in parallel 12:09 < jnewbery> > I'd prefer more stable tests to faster ones 12:09 < jonasschnelli> PR #? 12:09 < MarcoFalke> like test_bitcoin -t wallet/t1 & test_bitcoin -t wallet/t2 12:09 < jnewbery> We need faster too! Travis PR builds are timing out all over the place 12:10 < MarcoFalke> jnewbery: that is a wine issue. Not sure if we can do much about it 12:10 < jonasschnelli> Yes. The amount of tests we added during the last year made SAS CI pretty hard 12:10 < MarcoFalke> I looked to realize I know not enough of wine to be of any use 12:10 < jamesob> not to mention the Travis backlog has been pretty deep lately 12:10 < wumpus> jnewbery: I was afraid of some race condition fest, but he spawns multiple processes, so that concern is gone 12:10 < achow101> what pr number? 12:11 < cfields> #12831 12:11 < wumpus> #12831 12:11 < gribble> https://github.com/bitcoin/bitcoin/issues/12831 | [WIP] Run unit tests in parallel by MarcoFalke · Pull Request #12831 · bitcoin/bitcoin · GitHub 12:11 < gribble> https://github.com/bitcoin/bitcoin/issues/12831 | [WIP] Run unit tests in parallel by MarcoFalke · Pull Request #12831 · bitcoin/bitcoin · GitHub 12:11 < MarcoFalke> Oh Chaincode Labs is willing to sponsor us additional 10 jobs for travis 12:11 < MarcoFalke> I hope that goes through until next week 12:11 < jonasschnelli> MarcoFalke: nice! 12:11 < sipa> pulling in parallel seems like huge overkill though 12:11 -!- zarez [~Thunderbi@176.158.31.178] has joined #bitcoin-core-dev 12:11 < jonasschnelli> That's what I just thought 12:12 < wumpus> MarcoFalke: nice, but does offering travis more money help? afaik what cfields said, it doens't 12:12 < cfields> didn't jeremy start on a replacement for boost_test at one point? 12:12 < cfields> yes, I've tried before, but by all means try again! 12:12 < wumpus> yes... 12:12 < MarcoFalke> wumpus: No, it will only increase the number of jobs 12:12 < MarcoFalke> So it clears the backlog faster 12:12 < jonasschnelli> wumpus: I guess money means going away from free OS travis to private support which seems to be slower even if you pay a lot? I may be wrong though. 12:12 < MarcoFalke> It doesn't increase the quality or anything 12:13 < MarcoFalke> jonasschnelli: No it is a out-of-band update 12:13 < wumpus> #8650 12:13 < gribble> https://github.com/bitcoin/bitcoin/issues/8650 | Make tests much faster by replacing BOOST_CHECK with FAST_CHECK by JeremyRubin · Pull Request #8650 · bitcoin/bitcoin · GitHub 12:13 < jonasschnelli> MarcoFalke: Okay. Good to know. 12:13 < jamesob> $$$ = more parallelism at the travis job level 12:13 < cfields> MarcoFalke: the issue that we had before is that they had no option for extra-paid open-source projects. Just paid and free. Maybe that's changed recently? 12:14 < MarcoFalke> cfields: I contacted the support 12:14 < MarcoFalke> They don't have anything listed on the public website/plans 12:14 < cfields> MarcoFalke: huh. I guess it's new then. Great :) 12:14 < MarcoFalke> apache or someone did it a few years ago, I am just trying the same 12:14 < meshcollider> Cool :) 12:15 < wumpus> great 12:15 < phantomcircuit> jamesob, i seem to remember the threshold for payed support being better than the free support for oss being pretty high 12:15 < sipa> hell yes, go for it 12:15 < jonasschnelli> 8650 looks after a huge win. 12:15 < MarcoFalke> Doing a wholesale replacement of the test framework seems not a short term solution and perpendicualr to running the tests in parallel 12:15 < jtimon> thanks chaincode for the travis jobs! 12:15 < wumpus> jtimon: +1 12:16 < MarcoFalke> 8650 seems like WIP 12:16 < wumpus> MarcoFalke: agree, would be a longer-term concern, if it can be done with boost test that's preferable 12:16 < cfields> MarcoFalke: I only mentioned it because it'll probably be done at some point anyway. And if so, we'd want to write it with parallelism in mind. 12:16 < wumpus> for now at least 12:16 < wumpus> 8650 loses boost test features 12:17 < sipa> MarcoFalke: i can't believe that what we need from parallel can't be done with 20 lines of bash 12:17 < wumpus> e.g. logging what values mismatch 12:17 < wumpus> sipa: yes - just list the test suites, then distribute them over processes 12:17 < jonasschnelli> agree 12:17 < MarcoFalke> I can't write bash, so someone else has to volunteer 12:18 < wumpus> sounds fairly doable in bash, or at least python 12:18 < sipa> MarcoFalke: i hereby volunteer 12:18 < MarcoFalke> the current thing is python 12:18 < aj> 20 lines of python sounds preferable... 12:18 < wumpus> python is preferable to me 12:18 < wumpus> at least I can help review and maintain it 12:18 < BlueMatt> ugh, y'all bash-haters 12:18 < MarcoFalke> aj: It has nice features such as a cache for the run times 12:18 < sipa> aj hereby volunteered :p 12:18 < MarcoFalke> sot the sorting would be done automatically and based on your specs 12:19 < sipa> MarcoFalke: ok, 22 lines of bash :) 12:19 < jonasschnelli> IMO the whole testing system is already pretty complex. I wouldn't set the burden higher 12:19 < MarcoFalke> sipa: Pull requests very welcome :) 12:19 < sipa> anyway, i'll see what i can do 12:20 < wumpus> ok, so we should look at 12831 12:20 < MarcoFalke> And the one sipa proposes 12:20 < sipa> #12831 12:20 < gribble> https://github.com/bitcoin/bitcoin/issues/12831 | [WIP] Run unit tests in parallel by MarcoFalke · Pull Request #12831 · bitcoin/bitcoin · GitHub 12:20 < MarcoFalke> #????? 12:20 < MarcoFalke> tba 12:20 < jamesob> at what grain does 12831 do parallelism? per file? boost test case? 12:20 < MarcoFalke> jamesob: Whatever you like 12:20 < sipa> jamesob: one test case per process 12:20 < MarcoFalke> Currently ^ 12:20 < wumpus> per test suite, which is the only parallelism that makes sense 12:21 < jonasschnelli> I guess finer (case) would result in concurrency issue 12:21 < sipa> no... 12:21 < MarcoFalke> ^ 12:21 < sipa> they're all in separate processes 12:22 < jonasschnelli> Have we made sure there are no dependencies between cases? 12:22 < sipa> concurrency doesn't even come into the pictire 12:22 < wumpus> that sounds like a ton of overhead 12:22 < wumpus> launcing a process for every test case 12:22 < sipa> wumpus: 250 process creations. 12:22 < achow101> cases should be independent of each other 12:22 < sipa> ? 12:22 < wumpus> yes 12:22 < aj> test suite is the file, test case is the function (and each case has many checks) 12:22 < jonasschnelli> achow101: Yes. But are they (ex. wallet test)? 12:23 < jonasschnelli> But however, suite is what we want not cases 12:23 < jonasschnelli> *suites 12:23 < cfields> so, the tests can be built as a library... 12:23 < MarcoFalke> The savings from --jobs=2 eat all the overhead from running in 250 processes 12:23 < wumpus> sounds like a better granularity to me too 12:23 < wumpus> in any case we need to get rid of the txt file with all the test cases 12:23 < wumpus> and generate that automatically 12:23 < meshcollider> Agree 12:23 < jonasschnelli> Yes. 12:23 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 12:24 < sipa> that seems easy 12:24 < jonasschnelli> (same should be done for the functional test IMO, *OT* though9 12:24 < wumpus> too easy to forget a test now 12:24 < sipa> we can grep for test cases/suites 12:24 < MarcoFalke> wumpus: If we keep the list it would be linted on travis of course. *ducks* 12:24 < cfields> not sure how it works, but if boost provides a reasonable api that let us fork() into each suite, we could write our own test_main.cpp to do so, no? 12:25 < wumpus> jonasschnelli: yes, there were plans for that too, embedding some metadata in a header at the top of the py files, and automatically generating the lists, but orthogonal :) 12:25 < wumpus> MarcoFalke: :-( 12:25 < jonasschnelli> +1 :( 12:25 < MarcoFalke> Fine 12:26 < jtimon> wumpus: if we have one dir with all the cases and only that, it should be simple, perhaps we want to maintain the list of extra ones to skip the slow suites by default 12:26 < wumpus> jtimon: there are some other parameters: sort order, and which list it goes into 12:26 < wumpus> jtimon: but anyhow off topic now 12:26 < MarcoFalke> Other topics 12:26 < jonasschnelli> topic proposal: multiwallet merge (luke-jr brought this up last time while I was not here) 12:26 < MarcoFalke> ? 12:26 < wumpus> #topic multiwallet GUI 12:27 < jonasschnelli> But I guess luke-jr is not here now 12:27 < jtimon> right, mhmm, I guess you can rename the tests starting with numbers to keep the order, but that's kind of ugly 12:27 < wumpus> cfields: I don't think doing it that way would change the challenges 12:27 < jonasschnelli> I heard that the merge of #12610 was done while it was still controversial... 12:27 < gribble> https://github.com/bitcoin/bitcoin/issues/12610 | Multiwallet for the GUI by jonasschnelli · Pull Request #12610 · bitcoin/bitcoin · GitHub 12:27 < wumpus> jonasschnelli: I'm happy that you merged it 12:27 < jonasschnelli> If I did so, my appologies. I only wanted to make progress. 12:27 < cfields> ok 12:27 < wumpus> if there's anything to be fixed, file a new PR 12:28 < jonasschnelli> PRs to fix design mistakes are welcome 12:28 < jonasschnelli> yes 12:28 < wumpus> luke-jr overblows that part imo 12:28 < meshcollider> Yeah it's good that something has been put in, it's been weeks of small disagreement holding it up 12:28 < jnewbery> jonasschnelli: better to get it in now so it has time to soak. Rough edges can be fixed in future PRs 12:29 < jonasschnelli> I overhauled luke-jr's version mainly because of things like this: https://github.com/bitcoin/bitcoin/pull/11383/files#diff-2c15c5b52f35ea388ebab757eaab0f1cR506 12:29 < wumpus> but in any case, the idea of open source software is collaborative development, we can't make progress with something like this if it stays a PR forever, and it had a quite lot of review IIRC 12:29 < jonasschnelli> Erm this: https://github.com/bitcoin/bitcoin/pull/11383/files#diff-2c15c5b52f35ea388ebab757eaab0f1cR903 12:29 < wumpus> yes 12:29 < jonasschnelli> Yes. I took also care to keep luke-jr authorship in commits during my overhaul. 12:30 < jonasschnelli> Okay. Done with that topic then. Thanks 12:30 < wumpus> so it's ok, any other topics? 12:31 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 12:31 < sipa> let me think 12:31 < jnewbery> I had a topic: merge #10244 12:31 < jnewbery> but wumpus already did 12:31 < gribble> https://github.com/bitcoin/bitcoin/issues/10244 | Refactor: separate gui from wallet and node by ryanofsky · Pull Request #10244 · bitcoin/bitcoin · GitHub 12:31 < jamesob> woo! 12:31 < sipa> i don't have anything 12:31 < wumpus> yes, congrats :) 12:31 < jnewbery> \o/ 12:31 < sipa> yay 12:31 < jonasschnelli> nice! Yes. 12:32 < MarcoFalke> Good to see that in 12:32 < BlueMatt> dont forget to review High-Priority PRs this week! 12:32 < BlueMatt> ? 12:32 < MarcoFalke> #action dont forget to review High-Priority PRs this week! 12:32 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 12:32 < wumpus> #endmeeting 12:32 < lightningbot> Meeting ended Thu Apr 5 19:32:44 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 12:32 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-04-05-19.00.html 12:32 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-04-05-19.00.txt 12:32 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-04-05-19.00.log.html 12:33 < aj> any chance of getting #12878 added to high-pri list? it keeps needing rebasing, and at least it's easy to review... 12:33 < gribble> https://github.com/bitcoin/bitcoin/issues/12878 | [refactor] Config handling refactoring in preparation for network-specific sections by ajtowns · Pull Request #12878 · bitcoin/bitcoin · GitHub 12:33 -!- Arokh [~Arokh@extknot.com] has quit [Ping timeout: 256 seconds] 12:34 -!- jeffree [~jeffree@unaffiliated/jeffree] has joined #bitcoin-core-dev 12:35 -!- Arokh [~Arokh@extknot.com] has joined #bitcoin-core-dev 12:36 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Quit: Leaving] 12:36 < cfields> aj: will review asap. 12:36 < wumpus> aj: added 12:37 < aj> wumpus: thanks 12:44 < bitcoin-git> [bitcoin] chivambo opened pull request #12893: junior (master...patch-1) https://github.com/bitcoin/bitcoin/pull/12893 12:45 < bitcoin-git> [bitcoin] sipa closed pull request #12893: junior (master...patch-1) https://github.com/bitcoin/bitcoin/pull/12893 12:46 -!- lman [50678861@gateway/web/cgi-irc/kiwiirc.com/ip.80.103.136.97] has quit [Ping timeout: 256 seconds] 12:49 -!- satwo [~textual@2602:306:378a:6fb0:d8a9:e11d:a632:5890] has joined #bitcoin-core-dev 12:51 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 260 seconds] 12:51 -!- zarez [~Thunderbi@176.158.31.178] has quit [Ping timeout: 276 seconds] 12:57 -!- moneyball [~moneyball@65.200.72.90] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…] 13:02 -!- promag [~promag@bl19-45-51.dsl.telepac.pt] has joined #bitcoin-core-dev 13:02 -!- mrtn_ [~mrtn_@213-47-183-131.cable.dynamic.surfer.at] has joined #bitcoin-core-dev 13:02 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #12894: tests: Avoid test suite name collision in wallet crypto_tests (master...Mf1804-testRenameWalletCryptoTests) https://github.com/bitcoin/bitcoin/pull/12894 13:04 -!- lnostdal [~lnostdal@85.118.81.26] has joined #bitcoin-core-dev 13:05 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has quit [Quit: probably someone interrupted me] 13:06 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has quit [Remote host closed the connection] 13:07 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has joined #bitcoin-core-dev 13:09 -!- booyah [~bb@193.25.1.157] has quit [Ping timeout: 246 seconds] 13:09 * sipa learned about xargs -P today 13:10 < sipa> cat src/{,wallet/,qt/}test/*.cpp | fgrep BOOST_FIXTURE_TEST_SUITE | cut -d '(' -f 2 | cut -d ',' -f 1 | shuf | xargs -n 1 -P 4 -I "{}" -- ./src/test/test_bitcoin -t "{}/*" 13:10 -!- promag [~promag@bl19-45-51.dsl.telepac.pt] has quit [Remote host closed the connection] 13:10 < sipa> MarcoFalke: ^ 13:12 < achow101> one line of bash? 13:12 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 13:13 < MarcoFalke> sipa: Needs white space stripped as well? 13:13 < sipa> hmm? 13:13 < MarcoFalke> TEST_SUITE( a , ...) 13:13 < MarcoFalke> The one before and after "a" 13:14 < MarcoFalke> Otherwise I get "Test setup error: no test cases matching filter or all test cases were disabled" 13:14 < sipa> heh 13:14 < MarcoFalke> That xargs -P is cool 13:15 < sipa> add | tr -d '[:space:]' | somewhere 13:15 < jamesob> I think `shuf -z` + `xargs -0` is recommended 13:15 < MarcoFalke> Also, nice to use one iteration of bogosort to sort by run time 13:16 < sipa> jamesob: i don't think we're particularly worried about test names with newlines in them :) 13:16 < sipa> but yes 13:16 < jamesob> sipa: I'll make it a point to include one in my next testcase ;) 13:17 < MarcoFalke> Someone should see if it works with emojis in test names 13:17 * sipa checks C++ standard 13:17 < jamesob> I mean heck, if we're gonna do this as a one-liner we can at least overengineer it a little 13:20 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev 13:23 -!- webuser323 [529a8b88@gateway/web/freenode/ip.82.154.139.136] has joined #bitcoin-core-dev 13:24 < webuser323> sipa, MarcoFalke, I was just reading meeting log and though maybe 'man parallel' since you mentioned .sh for running tests in parallel. It's a great little tool. 13:28 < sipa> webuser323: it is, and MarcoFalke wanted to use that initially 13:28 < sipa> unfortunately it's a bit of a hassle.to include it in our repo 13:28 -!- jamesob [~james@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Quit: leaving] 13:29 -!- jamesob [~james@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 13:32 -!- jamesob [~james@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Client Quit] 13:32 -!- promag [~promag@bl19-45-51.dsl.telepac.pt] has joined #bitcoin-core-dev 13:32 -!- jamesob [~james@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 13:32 -!- karimofthecrop [~karim@69.12.80.147.adsl.inet-telecom.org] has joined #bitcoin-core-dev 13:32 < webuser323> no problems, just thought I'll chime in with this in case it slipped somehow 13:33 < sipa> thanks! 13:34 -!- jamesob [~james@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Client Quit] 13:34 -!- webuser323 [529a8b88@gateway/web/freenode/ip.82.154.139.136] has left #bitcoin-core-dev [] 13:34 < bitcoin-git> [bitcoin] practicalswift opened pull request #12895: tests: Add note about test suite name uniqueness requirement to developer notes (master...check-uniqueness-of-test-suite-names) https://github.com/bitcoin/bitcoin/pull/12895 13:35 < wumpus> you could always abuse make to run things parallel *ducks* 13:37 -!- JackH [~laptop@host-80-47-80-55.as13285.net] has joined #bitcoin-core-dev 13:37 < aj> wumpus: nice 13:40 -!- jamesob [~james@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 13:41 < sipa> wumpus: oh! 13:42 < sipa> do you know how make does thread counting across processes? 13:42 < sipa> it's so cute 13:44 < achow101> instagibbs: rebased psbt 13:47 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #12894: tests: Avoid test suite name collision in wallet crypto_tests (master...Mf1804-testRenameWalletCryptoTests) https://github.com/bitcoin/bitcoin/pull/12894 13:47 < wumpus> sipa: no, I don't know 13:47 < cfields> sipa: the special fd thing? 13:48 < sipa> wumpus: it has a shared fifo; every time a thread starts, it reads a char from that fifo, and when that is done, it writes another character 13:48 < sipa> it doesn't know or care where that char goes :p 13:49 < wumpus> ahh that makes sense, nice, didn't know you could share a fifo that way 13:49 < cfields> sipa: feel free to hack that into test_runner so that we could hook it up to make and -jX would just work as intended :) 13:49 < cfields> that's been on my personal todo for ages 13:50 -!- lman [5530383d@gateway/web/cgi-irc/kiwiirc.com/ip.85.48.56.61] has joined #bitcoin-core-dev 13:51 -!- lnostdal [~lnostdal@85.118.81.26] has quit [Ping timeout: 268 seconds] 13:52 < instagibbs> achow101, great 13:56 -!- moneyball [~moneyball@65.200.72.90] has joined #bitcoin-core-dev 13:58 -!- karimofthecrop [~karim@69.12.80.147.adsl.inet-telecom.org] has quit [Ping timeout: 265 seconds] 13:59 -!- promag [~promag@bl19-45-51.dsl.telepac.pt] has quit [Remote host closed the connection] 14:01 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 14:02 -!- Murch [~murch@96.74.120.81] has quit [Quit: Snoozing.] 14:02 -!- Madars [~null@unaffiliated/madars] has quit [Ping timeout: 256 seconds] 14:03 -!- Murch [~murch@96.74.120.81] has joined #bitcoin-core-dev 14:03 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 14:04 < bitcoin-git> [bitcoin] practicalswift opened pull request #12896: docs: Fix conflicting statements about initialization in developer notes (master...remove-conflicing-statements) https://github.com/bitcoin/bitcoin/pull/12896 14:05 -!- lnostdal [~lnostdal@85.118.82.216] has joined #bitcoin-core-dev 14:05 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 14:05 -!- nitramiz [~nitramiz@76.76.240.247] has joined #bitcoin-core-dev 14:05 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 14:05 -!- mrtn_ [~mrtn_@213-47-183-131.cable.dynamic.surfer.at] has quit [Quit: Leaving] 14:06 -!- murch1 [murch@sf1.hashbang.sh] has quit [Ping timeout: 265 seconds] 14:08 -!- murch1 [murch@sf1.hashbang.sh] has joined #bitcoin-core-dev 14:09 -!- satwo [~textual@2602:306:378a:6fb0:d8a9:e11d:a632:5890] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 14:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 14:10 -!- Derrekito [~derrekito@98.29.141.81] has joined #bitcoin-core-dev 14:20 -!- promag [~promag@bl19-45-51.dsl.telepac.pt] has joined #bitcoin-core-dev 14:23 -!- bule [~bule@gateway/tor-sasl/bule] has quit [Quit: Leaving] 14:26 -!- nitramiz [~nitramiz@76.76.240.247] has quit [Ping timeout: 264 seconds] 14:30 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 264 seconds] 14:44 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-phqokvqrxssfdnhf] has quit [Quit: Connection closed for inactivity] 14:55 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 15:02 -!- wxss [~user@46-227-67-54.static.obenetwork.net] has quit [Quit: leaving] 15:05 -!- Murch [~murch@96.74.120.81] has quit [Quit: Snoozing.] 15:07 -!- lnostdal [~lnostdal@85.118.82.216] has quit [Ping timeout: 256 seconds] 15:07 -!- lman [5530383d@gateway/web/cgi-irc/kiwiirc.com/ip.85.48.56.61] has quit [Remote host closed the connection] 15:09 -!- lman [5530383d@gateway/web/cgi-irc/kiwiirc.com/ip.85.48.56.61] has joined #bitcoin-core-dev 15:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 15:19 -!- lnostdal [~lnostdal@213.226.63.238] has joined #bitcoin-core-dev 15:21 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds] 15:24 -!- lnostdal [~lnostdal@213.226.63.238] has quit [Ping timeout: 264 seconds] 15:26 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 276 seconds] 15:30 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 15:31 -!- Murch [~murch@96.74.120.81] has joined #bitcoin-core-dev 15:35 -!- moneyball [~moneyball@65.200.72.90] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…] 15:36 -!- lnostdal [~lnostdal@85-118-77-217.mtel.net] has joined #bitcoin-core-dev 15:38 < bitcoin-git> [bitcoin] practicalswift closed pull request #12782: Explicitly state our assumptions about LookupBlockIndex(...) return values (master...LookupBlockIndex-assumptions) https://github.com/bitcoin/bitcoin/pull/12782 15:40 < bitcoin-git> [bitcoin] practicalswift opened pull request #12897: Add GetBlockIndex(const uint256& hash) for when the caller assumes that the block index exists for the given block hash (master...GetBlockIndex) https://github.com/bitcoin/bitcoin/pull/12897 15:41 -!- moneyball [~moneyball@65.200.72.90] has joined #bitcoin-core-dev 15:41 -!- lnostdal [~lnostdal@85-118-77-217.mtel.net] has quit [Ping timeout: 264 seconds] 15:41 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has joined #bitcoin-core-dev 15:52 -!- Dizzle [~dizzle@108.171.182.16] has quit [Quit: Leaving...] 15:53 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 16:01 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-arkqgenuyjkmxxzt] has joined #bitcoin-core-dev 16:03 -!- Arokh [~Arokh@extknot.com] has quit [Ping timeout: 256 seconds] 16:04 -!- Arokh [~Arokh@extknot.com] has joined #bitcoin-core-dev 16:05 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-ivbwrxwnxeevmgyn] has quit [Quit: Connection closed for inactivity] 16:11 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 265 seconds] 16:16 -!- geezas [uid253218@gateway/web/irccloud.com/x-curjgbfczrppbmli] has joined #bitcoin-core-dev 16:23 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 16:25 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 16:25 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-wdhaxycumtkmodba] has joined #bitcoin-core-dev 16:26 -!- rods1 [~r251d@2600:1700:e350:37f0:bd76:a85b:4402:2605] has joined #bitcoin-core-dev 16:26 -!- r251d [~r251d@2600:1700:e350:37f0:79cb:bfe9:4e33:8a51] has quit [Ping timeout: 256 seconds] 16:32 -!- lman [5530383d@gateway/web/cgi-irc/kiwiirc.com/ip.85.48.56.61] has quit [Ping timeout: 276 seconds] 16:42 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has quit [Quit: probably someone interrupted me] 16:44 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has joined #bitcoin-core-dev 16:45 -!- rex4539 [~textual@2a02:587:3514:8600:d80:59b1:396e:6ce5] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 16:49 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 16:53 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 16:56 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Read error: Connection reset by peer] 16:56 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 16:59 -!- Madars [~null@unaffiliated/madars] has joined #bitcoin-core-dev 17:00 -!- weez17 [~isaac@unaffiliated/weez17] has quit [Remote host closed the connection] 17:00 -!- weez17 [~isaac@unaffiliated/weez17] has joined #bitcoin-core-dev 17:04 -!- promag [~promag@bl19-45-51.dsl.telepac.pt] has quit [Remote host closed the connection] 17:04 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has quit [Quit: probably someone interrupted me] 17:06 -!- Lauda [~quassel@unaffiliated/lauda] has quit [Ping timeout: 240 seconds] 17:13 -!- Lauda [~quassel@unaffiliated/lauda] has joined #bitcoin-core-dev 17:13 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has joined #bitcoin-core-dev 17:16 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Quit: drexl] 17:22 -!- Sinclair6 [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has joined #bitcoin-core-dev 17:22 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 17:22 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 17:23 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 17:25 -!- grafcaps [~haroldbr@104.137.194.255] has quit [Ping timeout: 240 seconds] 17:25 -!- Madars [~null@unaffiliated/madars] has quit [Ping timeout: 265 seconds] 17:28 -!- Lauda [~quassel@unaffiliated/lauda] has quit [Read error: Connection reset by peer] 17:30 -!- Lauda [~quassel@unaffiliated/lauda] has joined #bitcoin-core-dev 17:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 17:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:33 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer] 17:34 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 17:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds] 17:40 -!- nitramiz [~nitramiz@76.76.240.247] has joined #bitcoin-core-dev 17:40 -!- moneyball [~moneyball@65.200.72.90] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…] 17:43 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 18:06 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has quit [Quit: probably someone interrupted me] 18:08 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 264 seconds] 18:10 -!- isis_ is now known as isis 18:11 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 18:15 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Ping timeout: 240 seconds] 18:16 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has quit [Ping timeout: 264 seconds] 18:16 -!- DrOlmer [~DrOlmer@unaffiliated/drolmer] has joined #bitcoin-core-dev 18:20 < aj> right, different VMs, but same test_bitcion.exe, under wine coinselector_tests/knapsack_solver_test takes 581.8 seconds, under windows server 2016 w/ updates it takes 31.4s 18:21 < sipa> is there a way to do profiling in wine? 18:22 -!- Madars [~null@unaffiliated/madars] has joined #bitcoin-core-dev 18:22 < aj> i figure i'll try a newer version of wine than what's in trusty first 18:29 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has joined #bitcoin-core-dev 18:31 -!- shesek` [~shesek@89-139-93-16.bb.netvision.net.il] has joined #bitcoin-core-dev 18:39 < aj> same version of wine on xenial seems no better, unsurprisingly; but, wine 3.0 at home seems much faster 18:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:43 < aj> total of 236s for the entire test suite under wine 3.0 vs 193s under windows server; different hardware though 18:45 -!- shesek` [~shesek@89-139-93-16.bb.netvision.net.il] has quit [Ping timeout: 240 seconds] 18:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds] 18:49 -!- Madars [~null@unaffiliated/madars] has quit [Ping timeout: 260 seconds] 18:49 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 18:51 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-arkqgenuyjkmxxzt] has quit [Quit: Connection closed for inactivity] 19:07 < aj> wine1.8 from some random ppa on xenial also gets the entire test suite in 377s or so, different hardware yet again 19:08 < aj> oh, bugger, that's wine3.0 as well, should have paid more attention when installing 19:10 < bitcoin-git> [bitcoin] lachlangreenbank opened pull request #12898: Comment cleanup and consistency (master...patch-1) https://github.com/bitcoin/bitcoin/pull/12898 19:10 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 265 seconds] 19:15 -!- nitramiz [~nitramiz@76.76.240.247] has quit [Ping timeout: 260 seconds] 19:15 -!- dafuq_ [~dafuq@S01061cabc0b054b3.ok.shawcable.net] has quit [Quit: Adios mofos] 19:15 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has quit [Quit: probably someone interrupted me] 19:16 -!- murrayn [~dafuq@unaffiliated/murrayn] has joined #bitcoin-core-dev 19:22 -!- unholymachine [~quassel@2601:8c:c003:9f16:1188:b7f7:521a:56c4] has joined #bitcoin-core-dev 19:26 -!- Murch [~murch@96.74.120.81] has quit [Quit: Snoozing.] 19:28 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer] 19:30 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev 19:32 -!- nitramiz [~nitramiz@76.76.240.247] has joined #bitcoin-core-dev 19:34 -!- moneyball [~moneyball@c-73-223-73-149.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 19:34 -!- Madars [~null@unaffiliated/madars] has joined #bitcoin-core-dev 19:35 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-wdhaxycumtkmodba] has quit [Quit: Connection closed for inactivity] 19:50 -!- Derrekito [~derrekito@98.29.141.81] has quit [Ping timeout: 260 seconds] 19:51 -!- Derrekito [~derrekito@98.29.141.81] has joined #bitcoin-core-dev 19:53 -!- karimofthecrop [~karim@69.12.80.147.adsl.inet-telecom.org] has joined #bitcoin-core-dev 19:57 -!- Madars [~null@unaffiliated/madars] has quit [Ping timeout: 260 seconds] 19:58 -!- Derrekito [~derrekito@98.29.141.81] has quit [Ping timeout: 256 seconds] 20:12 -!- moneyball [~moneyball@c-73-223-73-149.hsd1.ca.comcast.net] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…] 20:52 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Remote host closed the connection] 20:53 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 20:54 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Remote host closed the connection] 20:54 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 20:55 -!- moneyball [~moneyball@c-73-223-73-149.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 20:56 -!- Madars [~null@unaffiliated/madars] has joined #bitcoin-core-dev 21:00 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Read error: Connection reset by peer] 21:00 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 21:05 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Remote host closed the connection] 21:05 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 21:11 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has joined #bitcoin-core-dev 21:14 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Ping timeout: 276 seconds] 21:26 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has quit [Quit: probably someone interrupted me] 21:36 -!- indistylo [~indistylo@119.82.105.106] has joined #bitcoin-core-dev 21:45 -!- nitramiz [~nitramiz@76.76.240.247] has quit [Ping timeout: 265 seconds] 21:45 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has joined #bitcoin-core-dev 21:58 -!- rex4539 [~textual@ppp-2-87-183-80.home.otenet.gr] has joined #bitcoin-core-dev 22:00 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Read error: Connection reset by peer] 22:01 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 22:02 < karl2> sipa: you can use gprof with wine binaries as normal, I found out the other day. It wasn't particularly exciting stuff when I tried to track down job #2 timeout thing the other day, though. Maybe running different wine versions will trigger it, like aj is saying! 22:02 < gribble> https://github.com/bitcoin/bitcoin/issues/2 | Long-term, safe, store-of-value · Issue #2 · bitcoin/bitcoin · GitHub 22:03 -!- karl2 is now known as kallewoof 22:06 -!- geezas [uid253218@gateway/web/irccloud.com/x-curjgbfczrppbmli] has quit [Quit: Connection closed for inactivity] 22:08 < bitcoin-git> [bitcoin] AkioNak opened pull request #12899: macOS: Prevent Xcode 9.3 build warnings (master...preventxcodebuildwarnings) https://github.com/bitcoin/bitcoin/pull/12899 22:14 -!- clarkmoody [2fdaf8ce@gateway/web/freenode/ip.47.218.248.206] has quit [Ping timeout: 260 seconds] 22:16 -!- rex4539 [~textual@ppp-2-87-183-80.home.otenet.gr] has quit [Quit: Textual IRC Client: www.textualapp.com] 22:18 -!- karimofthecrop [~karim@69.12.80.147.adsl.inet-telecom.org] has quit [Ping timeout: 265 seconds] 22:21 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 22:23 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Remote host closed the connection] 22:23 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 22:25 -!- Bridgette4Marks [~Bridgette@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 264 seconds] 22:27 -!- rex4539 [~textual@2a02:587:3514:8600:fb:9274:e68:7c8c] has joined #bitcoin-core-dev 22:29 -!- Soligor [~Soligor@unaffiliated/soligor] has quit [Ping timeout: 240 seconds] 22:31 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has quit [Quit: probably someone interrupted me] 22:32 -!- moneyball [~moneyball@c-73-223-73-149.hsd1.ca.comcast.net] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…] 22:32 -!- Soligor [~Soligor@unaffiliated/soligor] has joined #bitcoin-core-dev 22:34 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has joined #bitcoin-core-dev 22:36 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has quit [] 22:42 -!- aruns [~indistylo@119.82.105.106] has joined #bitcoin-core-dev 22:42 -!- indistylo [~indistylo@119.82.105.106] has quit [Ping timeout: 260 seconds] 23:00 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has quit [Ping timeout: 264 seconds] 23:04 -!- Madisen45Reynold [~Madisen45@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 23:12 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Remote host closed the connection] 23:13 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 23:17 < bitcoin-git> [bitcoin] martintibor40 opened pull request #12900: Update README.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/12900 23:17 < bitcoin-git> [bitcoin] fanquake closed pull request #12900: Update README.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/12900 23:17 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Ping timeout: 276 seconds] 23:24 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 23:26 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Remote host closed the connection] 23:26 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 23:26 -!- cheese_ [~Cheeseo@unaffiliated/cheeseo] has joined #bitcoin-core-dev 23:29 -!- Cheeseo [~Cheeseo@unaffiliated/cheeseo] has quit [Ping timeout: 252 seconds] 23:30 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Ping timeout: 240 seconds] 23:34 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 23:38 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Ping timeout: 264 seconds] 23:44 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has quit [Quit: probably someone interrupted me]