--- Day changed Wed Apr 11 2018 00:00 -!- zigen_ [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 00:00 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Read error: Connection reset by peer] 00:07 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 00:07 < wumpus> don't remember ever seeing that 00:08 < luke-jr> there was also an issue with dpkg-reconfigure locale, but I hacked that 00:09 -!- Krellan [~Krellan@2601:640:4000:9258:edd8:da80:aef1:8c0f] has joined #bitcoin-core-dev 00:09 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 00:21 -!- ctrlbreak [~ctrlbreak@fctnnbsc38w-47-55-95-227.dhcp-dynamic.fibreop.nb.bellaliant.net] has quit [Ping timeout: 240 seconds] 00:23 -!- ctrlbreak [~ctrlbreak@fctnnbsc38w-47-55-95-227.dhcp-dynamic.fibreop.nb.bellaliant.net] has joined #bitcoin-core-dev 00:31 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Ping timeout: 255 seconds] 00:34 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 00:36 -!- isis_ is now known as isis 00:44 -!- rls [~rls@74.120.222.234] has joined #bitcoin-core-dev 00:47 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 00:49 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 00:54 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has joined #bitcoin-core-dev 00:56 -!- Krellan [~Krellan@2601:640:4000:9258:edd8:da80:aef1:8c0f] has quit [Ping timeout: 276 seconds] 00:58 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:01 -!- zigen_ [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Remote host closed the connection] 01:01 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 01:05 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Ping timeout: 246 seconds] 01:07 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 260 seconds] 01:07 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:07 < bitcoin-git> [bitcoin] Empact opened pull request #12940: rpc: Fix estimatesmartfee to properly handle a null estimate_mode arg (master...fix-estimatesmartfee-null-estimatemode) https://github.com/bitcoin/bitcoin/pull/12940 01:10 < jonasschnelli> Since new OSX version 10.12 I get tons of warnings for the boost test framework... 01:10 < jonasschnelli> things like BOOST_CHECK_EQUAL(list.size(), 1); 01:10 < jonasschnelli> warning: comparison of integers of different signs: 'const unsigned long' and 'const int' [-Wsign-compare] 01:10 < jonasschnelli> Would it be ugly to fix it with comparing against 1l instead of 1? 01:10 < luke-jr> that won't fix it 01:11 < jonasschnelli> it did on my side... though plenty of code parts 01:11 < luke-jr> you'd need 1UL or somth 01:11 < luke-jr> odd 01:11 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 01:11 < jonasschnelli> 1UL would be more precise, right. 01:12 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 01:13 < jonasschnelli> There is apparently already a PR: #12920 01:14 < gribble> https://github.com/bitcoin/bitcoin/issues/12920 | test: Fix sign for expected values by kallewoof · Pull Request #12920 · bitcoin/bitcoin · GitHub 01:15 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:21 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #12941: [Trivial] Ignore macOS daemon() depracation warning (master...2018/04/daemon_osx) https://github.com/bitcoin/bitcoin/pull/12941 01:29 < aj> (sp: deprecation) 01:30 < bitcoin-git> [bitcoin] Empact opened pull request #12942: rpc: Drop redundant testing of signrawtransaction prevtxs args (master...redundant-type-check-signtransaction) https://github.com/bitcoin/bitcoin/pull/12942 01:31 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has joined #bitcoin-core-dev 01:37 -!- anome [~anome@unaffiliated/anome] has joined #bitcoin-core-dev 01:38 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 01:41 < jonasschnelli> If nScriptCheckThreads is == 0, CCheckQueueControl is initiated with no queue which looks like no script verification are done... though I guess it only means no concurrency. 01:41 < jonasschnelli> Though I fail to see where the script are getting checked if nScriptCheckThreads == 0... 01:57 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 01:58 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 02:04 < jonasschnelli> nm: found the part (validation.cpp / } else if (!check()) {) 02:12 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Remote host closed the connection] 02:12 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 02:15 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Remote host closed the connection] 02:15 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 02:18 < kallewoof> achow101: Would you be up for reviewing #12257, considering your work on the coin selection code? 02:18 < gribble> https://github.com/bitcoin/bitcoin/issues/12257 | [wallet] Use destination groups instead of coins in coin select by kallewoof · Pull Request #12257 · bitcoin/bitcoin · GitHub 02:21 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 02:22 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Remote host closed the connection] 02:22 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 02:26 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has quit [Quit: probably someone interrupted me] 02:26 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Ping timeout: 240 seconds] 02:27 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:27 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 02:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds] 02:34 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 02:36 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 02:41 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/0a8054e7cd5c...9b3370d1c612 02:41 < bitcoin-git> bitcoin/master 189e0ef Wladimir J. van der Laan: [wallet] [rpc] introduce 'label' API for wallet... 02:41 < bitcoin-git> bitcoin/master 41ba061 John Newbery: [docs] Add release notes for wallet 'label' API. 02:41 < bitcoin-git> bitcoin/master 9b3370d Wladimir J. van der Laan: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet... 02:42 -!- harrymm [~harrymm@104.207.83.18] has joined #bitcoin-core-dev 02:42 < bitcoin-git> [bitcoin] laanwj closed pull request #12892: [wallet] [rpc] introduce 'label' API for wallet (master...7729_jnewbery) https://github.com/bitcoin/bitcoin/pull/12892 02:42 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 02:43 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9b3370d1c612...807d2ac1867c 02:43 < bitcoin-git> bitcoin/master 12e7c55 Jonas Schnelli: Ignore macOS daemon() depracation warning 02:43 < bitcoin-git> bitcoin/master 807d2ac Wladimir J. van der Laan: Merge #12941: [Trivial] Ignore macOS daemon() depracation warning... 02:44 < fanquake> wumpus heh, was just about to say I've got some notes to add to that PR. Will add post anyways. 02:44 < wumpus> fanquake: oh sorry 02:44 < wumpus> fanquake: it seemed trivial enough to just merge on the reasoning alone 02:44 < bitcoin-git> [bitcoin] laanwj closed pull request #12941: [Trivial] Ignore macOS daemon() depracation warning (master...2018/04/daemon_osx) https://github.com/bitcoin/bitcoin/pull/12941 02:45 < fanquake> wumpus np, was just going to dump some apple deprecation info in there 02:59 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 03:08 < stevenroose> sipa: have a sec? 03:09 -!- mrannanay [uid222022@gateway/web/irccloud.com/x-zdpsagscjhnefcll] has joined #bitcoin-core-dev 03:11 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 03:12 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 03:22 -!- zautomata [~zautomata@unaffiliated/zautomata] has quit [Ping timeout: 276 seconds] 03:23 -!- zautomata [~zautomata@41.232.197.178] has joined #bitcoin-core-dev 03:24 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Excess Flood] 03:24 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 03:34 -!- Samdney [~Samdney@37.58.58.250] has joined #bitcoin-core-dev 03:48 -!- laurentmt [~Thunderbi@78.157.211.238] has joined #bitcoin-core-dev 03:52 -!- hsmiths [uid95325@gateway/web/irccloud.com/x-lwgnbdehftnwcanz] has quit [Quit: Connection closed for inactivity] 03:54 -!- zautomata1 [~zautomata@41.232.219.27] has joined #bitcoin-core-dev 03:56 -!- zautomata [~zautomata@41.232.197.178] has quit [Ping timeout: 264 seconds] 04:00 -!- zautomata2 [~zautomata@41.232.212.152] has joined #bitcoin-core-dev 04:02 -!- zautomata1 [~zautomata@41.232.219.27] has quit [Ping timeout: 276 seconds] 04:06 -!- rls [~rls@74.120.222.234] has quit [Ping timeout: 265 seconds] 04:07 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 04:09 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 04:12 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has quit [Ping timeout: 263 seconds] 04:12 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has joined #bitcoin-core-dev 04:15 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 04:17 -!- shesek [~shesek@bzq-84-110-235-224.cablep.bezeqint.net] has joined #bitcoin-core-dev 04:17 -!- shesek [~shesek@bzq-84-110-235-224.cablep.bezeqint.net] has quit [Changing host] 04:17 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 04:18 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-udcallrbcybflqdm] has joined #bitcoin-core-dev 04:27 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:29 -!- hsmiths [uid95325@gateway/web/irccloud.com/x-coexxjcovmuweqmf] has joined #bitcoin-core-dev 04:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds] 04:32 -!- anome [~anome@unaffiliated/anome] has quit [] 04:34 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection] 04:36 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 04:36 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 04:46 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 04:47 -!- laurentmt [~Thunderbi@78.157.211.238] has quit [Quit: laurentmt] 04:55 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 04:56 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Remote host closed the connection] 04:57 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Remote host closed the connection] 04:58 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 05:02 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Ping timeout: 240 seconds] 05:02 -!- anome [~anome@unaffiliated/anome] has joined #bitcoin-core-dev 05:13 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 05:14 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 05:23 -!- anome [~anome@unaffiliated/anome] has quit [] 05:24 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/807d2ac1867c...7b6041d1a70c 05:24 < bitcoin-git> bitcoin/master ece88fd Pieter Wuille: Introduce BigEndian wrapper and use it for netaddress ports 05:24 < bitcoin-git> bitcoin/master 7b6041d Wladimir J. van der Laan: Merge #12916: Introduce BigEndian wrapper and use it for netaddress ports... 05:25 < bitcoin-git> [bitcoin] laanwj closed pull request #12916: Introduce BigEndian wrapper and use it for netaddress ports (master...201804_beport) https://github.com/bitcoin/bitcoin/pull/12916 05:29 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:29 -!- CubicEar_ [~cubiceart@xdsl-188-155-63-9.adslplus.ch] has quit [Remote host closed the connection] 05:32 -!- gelango [~gelango@14-201-165-153.tpgi.com.au] has joined #bitcoin-core-dev 05:33 -!- CubicEarths [~cubiceart@xdsl-188-155-63-9.adslplus.ch] has joined #bitcoin-core-dev 05:33 -!- gelango [~gelango@14-201-165-153.tpgi.com.au] has quit [Client Quit] 05:34 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 05:45 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7b6041d1a70c...f15b72f482f0 05:45 < bitcoin-git> bitcoin/master 40c5886 251: Fix illegal default `addProxy` and `addrSeparateProxyTor` settings. 05:45 < bitcoin-git> bitcoin/master f15b72f Wladimir J. van der Laan: Merge #12650: gui: Fix issue: "default port not shown correctly in settings dialog"... 05:45 < bitcoin-git> [bitcoin] laanwj closed pull request #12650: gui: Fix issue: "default port not shown correctly in settings dialog" (master...patch/12623/default-port-not-shown) https://github.com/bitcoin/bitcoin/pull/12650 05:46 -!- CubicEarths [~cubiceart@xdsl-188-155-63-9.adslplus.ch] has quit [Remote host closed the connection] 05:50 -!- CubicEarths [~cubiceart@xdsl-188-155-63-9.adslplus.ch] has joined #bitcoin-core-dev 05:53 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 05:54 -!- Samdney [~Samdney@37.58.58.250] has quit [Quit: Verlassend] 05:55 -!- Samdney [~Samdney@37.58.58.250] has joined #bitcoin-core-dev 05:57 -!- CubicEarths [~cubiceart@xdsl-188-155-63-9.adslplus.ch] has quit [Remote host closed the connection] 05:58 -!- anome [~anome@unaffiliated/anome] has joined #bitcoin-core-dev 06:02 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f15b72f482f0...b1fdfc1a8c07 06:02 < bitcoin-git> bitcoin/master c55aa4f Karl-Johan Alm: test: Fix sign for expected values... 06:02 < bitcoin-git> bitcoin/master b1fdfc1 Wladimir J. van der Laan: Merge #12920: test: Fix sign for expected values... 06:03 < bitcoin-git> [bitcoin] laanwj closed pull request #12920: test: Fix sign for expected values (master...test-signs) https://github.com/bitcoin/bitcoin/pull/12920 06:06 -!- CubicEarths [~cubiceart@188.155.63.9] has joined #bitcoin-core-dev 06:13 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 06:15 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 06:15 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 264 seconds] 06:20 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Remote host closed the connection] 06:29 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 06:29 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/b1fdfc1a8c07...1b5723ee5748 06:29 < bitcoin-git> bitcoin/master 2311c7c practicalswift: Call FlushStateToDisk(...) regardless of fCheckForPruning... 06:29 < bitcoin-git> bitcoin/master 0000d8f practicalswift: Document how FlushStateMode::NONE is handled 06:29 < bitcoin-git> bitcoin/master 1b5723e Wladimir J. van der Laan: Merge #11617: Avoid lock: Call FlushStateToDisk(...) regardless of fCheckForPruning... 06:30 < bitcoin-git> [bitcoin] laanwj closed pull request #11617: Avoid lock: Call FlushStateToDisk(...) regardless of fCheckForPruning (master...cs_LastBlockFile-fCheckForPruning) https://github.com/bitcoin/bitcoin/pull/11617 06:30 < bitcoin-git> [bitcoin] instagibbs opened pull request #12944: [wallet] ScanforWalletTransactions should mark input txns as dirty (master...scandirty) https://github.com/bitcoin/bitcoin/pull/12944 06:30 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 06:35 < provoostenator> Just noticed on macOS 10.13.4 I had to use the depends system to build (--without-gui --disable-tests --disable-bench). That's new for me... 06:35 < provoostenator> *to be build 0.15.1 and older 06:36 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 06:37 < fanquake> provoostenator What do you mean? You can't build bitcoin-qt with homebrew installed dependencies after 0.15.1 ? 06:37 < provoostenator> I didn't build QT. 06:38 < provoostenator> I mean I can build v0.16.0 and master just fine with the homebrew stuff on my machine, but not the older versions. 06:38 < provoostenator> So I guess some recent update in a homebrew package wasn't backwards compatible. 06:39 < fanquake> Do you know which dependency is the issue? 06:39 < fanquake> Homebrew the package manager itself should still have *some* support back to osx 10.7, there are 10.7 changes in the 1.6.0 release notes. 06:39 < fanquake> As for the actual packages, I'm unsure. 06:41 < fanquake> Apparently they will now also warn if the Xcode on your machine is too old to install a certain formula, so basically, upgrade to a newer macOS. 06:41 < provoostenator> Not sure, but here's the build log: https://gist.github.com/Sjors/40eddc5bb38f6acb05058e5dd74af159 06:42 < fanquake> Off the top of my head, I think that is missing a backport 06:42 < fanquake> Probably #12032 06:42 < gribble> https://github.com/bitcoin/bitcoin/issues/12032 | [backport] #11847 Make boost::multi_index comparators const by fanquake · Pull Request #12032 · bitcoin/bitcoin · GitHub 06:43 < provoostenator> It worked for me as recent as January 12th 2018 (although I don't konw if my brews were up to date) 06:43 < provoostenator> I see, so I should try the 0.15 branch instead of the tag? 06:44 < fanquake> If you've upgraded to boost > 1.66.0 that might have been what changed 06:44 < fanquake> Yea, try the branch instead. 06:50 < provoostenator> That did the trick. 06:50 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 06:51 < provoostenator> In fact, that specific commit indeed does the trick. 06:58 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1b5723ee5748...fefb817009fc 06:58 < bitcoin-git> bitcoin/master 459ea58 Ben Woosley: rpc: Drop redundant testing of signrawtransaction prevtxs args... 06:58 < bitcoin-git> bitcoin/master fefb817 Wladimir J. van der Laan: Merge #12942: rpc: Drop redundant testing of signrawtransaction prevtxs args... 06:59 < bitcoin-git> [bitcoin] laanwj closed pull request #12942: rpc: Drop redundant testing of signrawtransaction prevtxs args (master...redundant-type-check-signtransaction) https://github.com/bitcoin/bitcoin/pull/12942 07:03 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fefb817009fc...fb17faefb8a3 07:03 < bitcoin-git> bitcoin/master 1499fdc practicalswift: Add shell script linting: Check for shellcheck warnings in shell scripts 07:03 < bitcoin-git> bitcoin/master fb17fae MarcoFalke: Merge #12871: Add shell script linting: Check for shellcheck warnings in shell scripts... 07:03 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #12871: Add shell script linting: Check for shellcheck warnings in shell scripts (master...lint-shell) https://github.com/bitcoin/bitcoin/pull/12871 07:04 < instagibbs> someone with deeper wallet knowledge check on 12944? I'm having trouble reproducing my bug in regtest, curious if someone else can figure it out 07:08 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-udcallrbcybflqdm] has quit [Quit: Connection closed for inactivity] 07:16 < fanquake> I'm sure every-time I go to retrieve a Qt patch it gets slightly more convoluted and difficult to do 07:17 < wumpus> heh 07:18 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 07:20 -!- Sinclair6 [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has quit [Ping timeout: 264 seconds] 07:20 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 07:20 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 07:21 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 07:21 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Read error: Connection reset by peer] 07:21 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 07:21 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fb17faefb8a3...6d3de17a226b 07:21 < bitcoin-git> bitcoin/master cab0824 Jonas Schnelli: Logprint the start of a rescan 07:21 < bitcoin-git> bitcoin/master 6d3de17 Wladimir J. van der Laan: Merge #12925: wallet: Logprint the start of a rescan... 07:22 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [] 07:22 < bitcoin-git> [bitcoin] laanwj closed pull request #12925: wallet: Logprint the start of a rescan (master...2018/04/rescan) https://github.com/bitcoin/bitcoin/pull/12925 07:30 -!- Krellan [~Krellan@2601:640:4000:9258:edd8:da80:aef1:8c0f] has joined #bitcoin-core-dev 07:33 -!- Murch [~murch@96.74.120.81] has joined #bitcoin-core-dev 07:34 -!- TheRec [~toto@84-72-172-174.dclient.hispeed.ch] has joined #bitcoin-core-dev 07:34 -!- TheRec [~toto@84-72-172-174.dclient.hispeed.ch] has quit [Changing host] 07:34 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 07:38 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds] 07:45 -!- setpill [~setpill@unaffiliated/setpill] has quit [Ping timeout: 265 seconds] 07:45 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 07:47 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6d3de17a226b...3cf76c23fbfc 07:47 < bitcoin-git> bitcoin/master fad0fc3 MarcoFalke: Refine travis check for duplicate includes... 07:47 < bitcoin-git> bitcoin/master 3cf76c2 MarcoFalke: Merge #12933: doc: Refine header include policy... 07:47 -!- rex4539 [~textual@2a02:587:3514:8600:e88f:bf76:43f9:f3d3] has quit [Remote host closed the connection] 07:48 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #12933: doc: Refine header include policy (master...Mf1804-docIncludes) https://github.com/bitcoin/bitcoin/pull/12933 07:49 -!- setpill [~setpill@unaffiliated/setpill] has quit [Ping timeout: 245 seconds] 07:51 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 07:53 < fanquake> "something something linter hell" 07:55 < wumpus> yes... 07:56 < fanquake> At least the whitespace linter no longer complains about .patches, otherwise I really would be groaning in a minute. 07:58 < wumpus> at least the requirement for new linters is that they should serve to find potential bugs, not style issues 07:59 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #12937: Handle witness version and OP_N results as an unsigned char (master...unsigned-char-witnessversion) https://github.com/bitcoin/bitcoin/pull/12937 08:00 -!- rex4539 [~textual@2a02:587:3514:8600:68e4:4041:bf5b:2223] has joined #bitcoin-core-dev 08:00 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #12912: Minor readability/maintainability changes to warnings.cpp (master...warnings) https://github.com/bitcoin/bitcoin/pull/12912 08:06 < bitcoin-git> [bitcoin] fanquake opened pull request #12946: depends: Fix Qt build with XCode 9.3 (master...fix-qt-xcode93) https://github.com/bitcoin/bitcoin/pull/12946 08:08 < bitcoin-git> [bitcoin] fanquake closed pull request #10619: [rpc]Avoid possibility of NULL pointer dereference in getblockchaininfo(...) (master...fix01) https://github.com/bitcoin/bitcoin/pull/10619 08:09 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 08:26 -!- tryphe_000 [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 08:28 < bitcoin-git> [bitcoin] instagibbs opened pull request #12947: Wallet hd functional test speedup and clarification (master...wallet_hd_speedup) https://github.com/bitcoin/bitcoin/pull/12947 08:30 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 264 seconds] 08:31 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 08:33 < instagibbs> re:12944, nevermind it's still valid but basically impossible to test, I think, removed errant test 08:38 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 08:49 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 264 seconds] 08:53 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has quit [Remote host closed the connection] 08:53 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 08:54 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has joined #bitcoin-core-dev 08:54 -!- anome [~anome@unaffiliated/anome] has quit [] 09:07 -!- mrannanay [uid222022@gateway/web/irccloud.com/x-zdpsagscjhnefcll] has quit [Quit: Connection closed for inactivity] 09:10 < bitcoin-git> [bitcoin] achow101 closed pull request #11497: Hide accounts system behind deprecation switch (master...deprecate-account-rpcs) https://github.com/bitcoin/bitcoin/pull/11497 09:11 < achow101> kallewoof: I'll try to review it 09:16 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 09:19 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has quit [Quit: zarez] 09:20 -!- tecneecs [~tecneecs@ool-44c1c00f.dyn.optonline.net] has joined #bitcoin-core-dev 09:22 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 09:23 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 264 seconds] 09:28 -!- zautomata2 [~zautomata@41.232.212.152] has quit [Quit: WeeChat 1.9.1] 09:34 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 09:37 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 09:38 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 09:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds] 09:48 -!- Krellan [~Krellan@2601:640:4000:9258:edd8:da80:aef1:8c0f] has quit [Read error: Connection reset by peer] 09:55 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Quit: Leaving] 10:10 -!- isis is now known as isis_ 10:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:12 -!- tecneecs [~tecneecs@ool-44c1c00f.dyn.optonline.net] has quit [Ping timeout: 240 seconds] 10:16 < provoostenator> I restarted the failed Travis job for #12946 (p2p_compactblocks.py failure seems unrelated). TIL I have that power. 10:16 < gribble> https://github.com/bitcoin/bitcoin/issues/12946 | depends: Fix Qt build with XCode 9.3 by fanquake · Pull Request #12946 · bitcoin/bitcoin · GitHub 10:16 < provoostenator> My browser is having a hard time with 6000+ line Travis logs by the way. 10:21 < wumpus> provoostenator: yes ... :( 10:23 < wumpus> provoostenator: the 'travis' command line utility would be extremely useful there (https://github.com/travis-ci/travis.rb), except that it has problems with large logs too (https://github.com/travis-ci/travis.rb/issues/578) :P 10:24 < wumpus> I have a "curl https://api.travis-ci.org/v3/job/$1/log.txt | less -r" script that's sometimes useful 10:34 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 276 seconds] 10:43 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 10:44 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 10:46 -!- Krellan [~Krellan@2601:640:4000:9258:edd8:da80:aef1:8c0f] has joined #bitcoin-core-dev 10:48 -!- Sinclair6 [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has joined #bitcoin-core-dev 10:54 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #12949: tests: Avoid copies of CTransaction (master...Mf1804-testNoCopyTx) https://github.com/bitcoin/bitcoin/pull/12949 11:01 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 245 seconds] 11:11 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has quit [Ping timeout: 240 seconds] 11:14 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #12950: bitcoin-tx: Flatten for loop over one element (master...Mf1804-bitcoinTxUnusedLoop) https://github.com/bitcoin/bitcoin/pull/12950 11:14 -!- drizztbsd [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 11:15 -!- Randolf [~randolf@96.53.76.26] has joined #bitcoin-core-dev 11:17 < bitcoin-git> [bitcoin] jamesob opened pull request #12951: [doc] Fix comment in FindForkInGlobalIndex (master...2018-04-11-findforkinglobalindex-doc) https://github.com/bitcoin/bitcoin/pull/12951 11:20 < jtimon> review/re-review begging https://github.com/bitcoin/bitcoin/pull/10757 11:28 < provoostenator> Added to list. 11:32 -!- Ishtv4n [~Ishtv4n@178-222-16-48.dynamic.isp.telekom.rs] has joined #bitcoin-core-dev 11:42 -!- Randolf [~randolf@96.53.76.26] has quit [Ping timeout: 265 seconds] 11:42 -!- Giszmo [~leo@ip-82-237-219-201.nextelmovil.cl] has joined #bitcoin-core-dev 11:46 < cfields> feel a bit out of the loop. Did the parallel tests change end up borking everything? Several PRs atm that seem unrelated to the actual changes. 11:46 < cfields> *several failing PRs 11:48 < cfields> #12899 for example 11:48 < gribble> https://github.com/bitcoin/bitcoin/issues/12899 | macOS: Prevent Xcode 9.3 build warnings by AkioNak · Pull Request #12899 · bitcoin/bitcoin · GitHub 11:49 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 11:52 < wumpus> cfields: haven't noticed any problems with the parallel unit tests yet 11:52 < wumpus> cfields: are the unit tests failing on that? 11:54 < cfields> wumpus: ah right, it's bitcoin-util-test.py 11:54 < cfields> hmm 11:57 < wumpus> oh 12:02 < bitcoin-git> [bitcoin] jnewbery opened pull request #12953: Deprecate accounts (master...deprecate_accounts) https://github.com/bitcoin/bitcoin/pull/12953 12:02 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has joined #bitcoin-core-dev 12:03 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev 12:18 < drexl> what marks an output as P2SH? 12:18 < drexl> is it the scriptPubKey starting with OP_HASH160 and ending with OP_EQUAL ? 12:24 < wumpus> drexl: correct, see CScript::IsPayToScriptHash 12:25 < drexl> great ty 12:31 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #12526: Docs: Minor description fix to build procedure on Debian wrt BerkeleyDB (master...debian9-build-hint-update) https://github.com/bitcoin/bitcoin/pull/12526 12:32 -!- Giszmo [~leo@ip-82-237-219-201.nextelmovil.cl] has quit [Read error: Connection reset by peer] 12:34 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3cf76c23fbfc...7c06171b3d26 12:34 < bitcoin-git> bitcoin/master 05c03d1 joemphilips: rpc: fix type mistmatch in listreceivedbyaddress 12:34 < bitcoin-git> bitcoin/master 7c06171 MarcoFalke: Merge #12837: rpc: fix type mistmatch in `listreceivedbyaddress`... 12:35 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #12837: rpc: fix type mistmatch in `listreceivedbyaddress` (master...fix_listreceivedbyaddress_type) https://github.com/bitcoin/bitcoin/pull/12837 12:35 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 12:40 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 12:42 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 12:43 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 12:43 < cfields> wumpus: I restarted that job and it failed again. I'm stumped as to why. 12:44 < wumpus> cfields: maybe flush the cache 12:45 -!- jojeyh [~delphi@2602:306:b8b6:b970:c60:7730:cc0c:6466] has quit [Ping timeout: 276 seconds] 12:47 -!- goatpig [56f75164@gateway/web/freenode/ip.86.247.81.100] has quit [Ping timeout: 260 seconds] 12:47 < cfields> good idea. I'd kinda hate it if that fixed it, though 12:48 < wumpus> same, though I'd prefer a cosmic ray having corrupted the cache to the trivial build system change in #12899 mysteriously corrupting the excutable enough to fail the util test 12:48 < gribble> https://github.com/bitcoin/bitcoin/issues/12899 | macOS: Prevent Xcode 9.3 build warnings by AkioNak · Pull Request #12899 · bitcoin/bitcoin · GitHub 12:49 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 12:49 < cfields> heh, true 12:54 -!- Deinogalerix21 [~Deinogale@cpc93832-hari18-2-0-cust876.20-2.cable.virginm.net] has joined #bitcoin-core-dev 12:56 < wumpus> I can't reproduce it locally at least 12:57 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has joined #bitcoin-core-dev 12:58 < cfields> wumpus: thanks for testing 12:58 -!- Deinogal1 [~Deinogale@185.169.255.9] has joined #bitcoin-core-dev 12:59 < cfields> wumpus: do you happen to have the travis-cli thing handy? The webui only shows caches for so many PRs, and 12899 isn't one of 'em :\ 12:59 -!- Deinogalerix21 [~Deinogale@cpc93832-hari18-2-0-cust876.20-2.cable.virginm.net] has quit [Ping timeout: 276 seconds] 12:59 < wumpus> yep 13:00 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 13:00 < cfields> thanks 13:01 < wumpus> deleted all caches for PR.12899 13:02 < bitcoin-git> [bitcoin] conscott closed pull request #12930: WIP Refactor large transaction generation for tests and make generic (master...CRS_tests_flexible_tx_size) https://github.com/bitcoin/bitcoin/pull/12930 13:03 < cfields> great, thanks again. restarted one. 13:05 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 13:06 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 13:06 -!- Krellan [~Krellan@2601:640:4000:9258:edd8:da80:aef1:8c0f] has quit [Read error: Connection reset by peer] 13:07 -!- Krellan [~Krellan@2601:640:4000:9258:edd8:da80:aef1:8c0f] has joined #bitcoin-core-dev 13:11 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 13:14 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 13:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 13:16 < promag> I'd love to have some feedback in #12929, ty 13:16 < gribble> https://github.com/bitcoin/bitcoin/issues/12929 | Remove CWallet dependency from CWalletTx by promag · Pull Request #12929 · bitcoin/bitcoin · GitHub 13:19 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 13:19 -!- Cheeseo [Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 13:19 -!- zivl_ [~zivl@2601:19a:837f:e4e1:60be:6c70:66d3:34bf] has joined #bitcoin-core-dev 13:20 -!- mappum_ [sid43795@gateway/web/irccloud.com/x-bemxbudvkvguzlvi] has joined #bitcoin-core-dev 13:21 -!- NicolasDorier_ [sid129442@gateway/web/irccloud.com/x-orcyccjrhpndqfzt] has joined #bitcoin-core-dev 13:21 -!- Varunram_ [sid210151@gateway/web/irccloud.com/x-hvmmktvyzmhmfmgv] has joined #bitcoin-core-dev 13:21 -!- Bosma_ [sid103570@gateway/web/irccloud.com/x-betxkiajfbsrmqrr] has joined #bitcoin-core-dev 13:22 -!- harding_ [quassel@2600:3c03::f03c:91ff:fe7b:78d1] has joined #bitcoin-core-dev 13:26 -!- schnerch- [~schnerchi@static.120.187.99.88.clients.your-server.de] has joined #bitcoin-core-dev 13:27 -!- shesek [~shesek@bzq-84-110-235-224.cablep.bezeqint.net] has joined #bitcoin-core-dev 13:27 -!- shesek [~shesek@bzq-84-110-235-224.cablep.bezeqint.net] has quit [Changing host] 13:27 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 13:27 -!- kcud_dab [~arthur@area51.powaaa.com] has joined #bitcoin-core-dev 13:28 -!- NicolasDorier_ is now known as NicolasDorier 13:28 -!- Bosma_ is now known as Bosma 13:29 -!- mappum_ is now known as mappum 13:30 -!- Netsplit over, joins: murr4y 13:30 -!- lifeofguenter [~lifeofgue@bnc.pro.to.co.ls] has quit [Ping timeout: 240 seconds] 13:31 -!- schnerch- [~schnerchi@static.120.187.99.88.clients.your-server.de] has quit [Ping timeout: 260 seconds] 13:31 -!- Masaomi[m] [masaomimat@gateway/shell/matrix.org/x-vshxmmkjnsudomjk] has joined #bitcoin-core-dev 13:32 -!- _flow_ [~none@2001:638:a000:4140::ff10:844c] has joined #bitcoin-core-dev 13:33 -!- lifeofguenter [~lifeofgue@bnc.pro.to.co.ls] has joined #bitcoin-core-dev 13:33 -!- schnerchi [~schnerchi@2a01:4f8:c0c:afe::2] has joined #bitcoin-core-dev 13:33 -!- LeMiner [LeMiner@unaffiliated/leminer] has joined #bitcoin-core-dev 13:42 -!- Deinogal1 [~Deinogale@185.169.255.9] has quit [Quit: WeeChat 2.1] 13:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 13:53 -!- Ishtv4n [~Ishtv4n@178-222-16-48.dynamic.isp.telekom.rs] has quit [Quit: Ishtv4n] 14:06 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 14:12 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7c06171b3d26...979f59850c72 14:12 < bitcoin-git> bitcoin/master 6cba60a Gregory Sanders: speed up wallet_hd.py and clarify/augment checks 14:12 < bitcoin-git> bitcoin/master 979f598 MarcoFalke: Merge #12947: Wallet hd functional test speedup and clarification... 14:13 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #12947: Wallet hd functional test speedup and clarification (master...wallet_hd_speedup) https://github.com/bitcoin/bitcoin/pull/12947 14:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 14:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 14:20 -!- rex4539 [~textual@2a02:587:3514:8600:68e4:4041:bf5b:2223] has quit [Remote host closed the connection] 14:20 -!- anome [~anome@unaffiliated/anome] has joined #bitcoin-core-dev 14:20 -!- zautomata [~zautomata@41.232.212.152] has joined #bitcoin-core-dev 14:28 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has quit [Quit: probably someone interrupted me] 14:31 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has quit [Ping timeout: 256 seconds] 14:31 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has joined #bitcoin-core-dev 14:47 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:53 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 256 seconds] 14:55 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has quit [Quit: probably someone interrupted me] 14:55 -!- Giszmo [~leo@ip-185-237-219-201.nextelmovil.cl] has joined #bitcoin-core-dev 14:59 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has joined #bitcoin-core-dev 15:04 < bitcoin-git> [bitcoin] jimpo opened pull request #12954: util: Refactor logging code into a global object (master...logging) https://github.com/bitcoin/bitcoin/pull/12954 15:07 -!- Giszmo [~leo@ip-185-237-219-201.nextelmovil.cl] has quit [Ping timeout: 260 seconds] 15:18 -!- Emcy_ [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 15:19 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 15:24 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 15:29 -!- Krellan [~Krellan@2601:640:4000:9258:edd8:da80:aef1:8c0f] has quit [Read error: Connection reset by peer] 15:30 -!- Krellan [~Krellan@2601:640:4000:9258:edd8:da80:aef1:8c0f] has joined #bitcoin-core-dev 15:35 -!- Giszmo [~leo@ip-129-237-219-201.nextelmovil.cl] has joined #bitcoin-core-dev 15:37 -!- anome [~anome@unaffiliated/anome] has quit [] 15:41 -!- Giszmo [~leo@ip-129-237-219-201.nextelmovil.cl] has quit [Ping timeout: 268 seconds] 15:44 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 15:47 -!- ula [~ula@b2b-78-94-11-194.unitymedia.biz] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/] 15:49 -!- qrestlove [~qrestlove@2605:6000:eb4a:ef00:454f:112b:9095:f0ea] has joined #bitcoin-core-dev 15:53 -!- Murch [~murch@96.74.120.81] has quit [Quit: Plugging out.] 15:55 -!- Giszmo [~leo@ip-67-236-219-201.nextelmovil.cl] has joined #bitcoin-core-dev 15:58 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 15:59 < fanquake> cfields wumpus I noticed the same on 12899, looks like wiping the cache hasn't fixed the issue either.. I'll open a new issue with some info. 16:01 -!- kakobrekla [~kako@unaffiliated/kakobrekla] has quit [Ping timeout: 256 seconds] 16:01 -!- kakobrekla [~kako@unaffiliated/kakobrekla] has joined #bitcoin-core-dev 16:08 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 16:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 264 seconds] 16:18 -!- nickler [~nickler@185.12.46.130] has quit [Ping timeout: 240 seconds] 16:19 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Quit: drexl] 16:19 -!- nickler [~nickler@185.12.46.130] has joined #bitcoin-core-dev 16:25 -!- Giszmo [~leo@ip-67-236-219-201.nextelmovil.cl] has quit [Ping timeout: 256 seconds] 16:30 < dongcarl> Looking at https://github.com/bitcoin/bitcoin/issues/3171 here, wondering about the specifics: Should we bootstrap and measure every time an RC release is tagged? Would this be on some bare metal cloud instance? How would this be funded? 16:33 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 16:38 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has joined #bitcoin-core-dev 16:39 -!- tryphe_000 is now known as tryphe 16:42 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 16:44 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has quit [Quit: probably someone interrupted me] 16:44 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 16:47 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 260 seconds] 16:54 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 264 seconds] 16:54 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 16:54 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 268 seconds] 16:54 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 16:56 -!- justanotherus3r [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 17:00 -!- weez17 [~isaac@unaffiliated/weez17] has quit [Remote host closed the connection] 17:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:00 -!- weez17 [~isaac@unaffiliated/weez17] has joined #bitcoin-core-dev 17:01 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 17:01 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-jxuvayjfbhzwkfxb] has joined #bitcoin-core-dev 17:01 < fanquake> dongcarl I think measuring towards the end of every release cycle would be a good start. Likely to be funded out of the pockets of whoever is running the tests. Unless someone donates some servers. 17:02 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 17:02 -!- shesek [~shesek@bzq-84-110-235-224.cablep.bezeqint.net] has joined #bitcoin-core-dev 17:02 -!- shesek [~shesek@bzq-84-110-235-224.cablep.bezeqint.net] has quit [Changing host] 17:02 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 17:04 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has joined #bitcoin-core-dev 17:05 -!- moneyball [~moneyball@c-73-223-73-149.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 17:23 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #12956: contrib: Only lint our src files for include guards (master...Mf1804-lintFixups) https://github.com/bitcoin/bitcoin/pull/12956 17:25 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has quit [Quit: probably someone interrupted me] 17:30 -!- moneyball [~moneyball@c-73-223-73-149.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 17:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 17:32 -!- rls [~rls@74.120.222.234] has joined #bitcoin-core-dev 17:35 < bitcoin-git> [bitcoin] sparpana opened pull request #12957: Update README.md (master...master) https://github.com/bitcoin/bitcoin/pull/12957 17:36 < bitcoin-git> [bitcoin] fanquake closed pull request #12957: Update README.md (master...master) https://github.com/bitcoin/bitcoin/pull/12957 17:42 -!- isis_ is now known as isis 17:43 -!- dafuq_ [~dafuq@S01061cabc0b054b3.ok.shawcable.net] has joined #bitcoin-core-dev 17:46 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has quit [Ping timeout: 260 seconds] 17:46 -!- murrayn [~dafuq@unaffiliated/murrayn] has quit [Ping timeout: 265 seconds] 17:47 -!- ken2812221 [~User@140.115.203.133] has joined #bitcoin-core-dev 17:50 * dongcarl nods 17:50 -!- Krellan [~Krellan@2601:640:4000:9258:edd8:da80:aef1:8c0f] has quit [Read error: Connection reset by peer] 17:50 -!- Krellan [~Krellan@2601:640:4000:9258:edd8:da80:aef1:8c0f] has joined #bitcoin-core-dev 17:51 < bitcoin-git> [bitcoin] Empact opened pull request #12959: Drop IsCompressedOrUncompressedPubKey and IsCompressedPubKey (master...is-compressed-or-uncompressed) https://github.com/bitcoin/bitcoin/pull/12959 17:56 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has joined #bitcoin-core-dev 18:01 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has quit [Client Quit] 18:04 -!- rls0 [~rls@2600:8800:1e00:9e1:1d53:9583:59e1:7557] has joined #bitcoin-core-dev 18:07 -!- rls [~rls@74.120.222.234] has quit [Ping timeout: 260 seconds] 18:08 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 240 seconds] 18:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:25 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has joined #bitcoin-core-dev 18:30 -!- Samdney [~Samdney@37.58.58.250] has quit [Quit: Verlassend] 18:32 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #12960: doc: Revert to previous header include policy (master...Mf1804-docIncludes) https://github.com/bitcoin/bitcoin/pull/12960 18:40 -!- tryphe_ is now known as tryphe 18:42 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #12956: contrib: Only lint our src files for include guards (master...Mf1804-lintFixups) https://github.com/bitcoin/bitcoin/pull/12956 18:46 -!- moneyball [~moneyball@c-73-223-73-149.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 18:49 -!- tiboclan [8713a380@gateway/web/freenode/ip.135.19.163.128] has joined #bitcoin-core-dev 18:52 -!- tiboclan [8713a380@gateway/web/freenode/ip.135.19.163.128] has quit [Client Quit] 18:52 -!- dafuq_ [~dafuq@S01061cabc0b054b3.ok.shawcable.net] has quit [Read error: Connection reset by peer] 18:54 -!- zautomata1 [~zautomata@41.232.201.113] has joined #bitcoin-core-dev 18:56 -!- zautomata [~zautomata@41.232.212.152] has quit [Ping timeout: 264 seconds] 18:57 < bitcoin-git> [bitcoin] fanquake closed pull request #12433: [qt] move SendCoinsRecipient to its own file (master...2018/02/qt-send-coins-recipient) https://github.com/bitcoin/bitcoin/pull/12433 19:01 -!- moneyball [~moneyball@c-73-223-73-149.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 19:01 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 19:02 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 19:08 -!- murrayn [~dafuq@unaffiliated/murrayn] has joined #bitcoin-core-dev 19:10 -!- moneyball [~moneyball@c-73-223-73-149.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 19:21 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-jxuvayjfbhzwkfxb] has quit [Quit: Connection closed for inactivity] 19:21 -!- moneyball [~moneyball@c-73-223-73-149.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 19:22 -!- moneyball [~moneyball@c-73-223-73-149.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 19:25 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Remote host closed the connection] 19:25 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 19:27 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Read error: Connection reset by peer] 19:27 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 19:30 < fanquake> Is there an easy way to comment on an issue like #12961 inline? 19:30 < gribble> https://github.com/bitcoin/bitcoin/issues/12961 | 979f598: Clang Static Analyzer Report · Issue #12961 · bitcoin/bitcoin · GitHub 19:32 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has quit [Quit: probably someone interrupted me] 19:32 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 19:32 < aj> fanquake: don't think so. you can copy a bit and quote it with a ">" prefix, eg "> what they said \n\n helpful response from you" ? 19:32 < kallewoof> fanquake: Maybe I should've made a PR with 'no-merge:'. That would let you inline comment. 19:33 < kallewoof> No/limited formatting though.. 19:33 < fanquake> Yes that's normally what I'd do, but copying out of an issue like that which has heaps of markdown is always a bit of a nightmare. 19:33 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 19:33 < fanquake> kallewoof, I'll have a go at adding some comments to the issue first. 19:33 < kallewoof> OK 19:53 -!- moneyball [~moneyball@c-73-223-73-149.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 19:55 -!- moneyball [~moneyball@c-73-223-73-149.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 19:55 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has quit [Quit: Leaving.] 19:56 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 20:01 -!- moneyball [~moneyball@c-73-223-73-149.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 20:09 -!- boblee [~boblee@unaffiliated/boblee] has quit [Ping timeout: 268 seconds] 20:09 -!- boblee [~boblee@199.195.253.210] has joined #bitcoin-core-dev 20:10 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-qutptyzkwnkjlybr] has joined #bitcoin-core-dev 20:10 -!- moneyball [~moneyball@c-73-223-73-149.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 20:13 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has joined #bitcoin-core-dev 20:16 -!- Krellan [~Krellan@2601:640:4000:9258:edd8:da80:aef1:8c0f] has quit [Read error: Connection reset by peer] 20:17 -!- Krellan [~Krellan@2601:640:4000:9258:edd8:da80:aef1:8c0f] has joined #bitcoin-core-dev 20:18 < mryandao> ok, i've rebased #12240 and it finally passed all the build jobs 20:18 < gribble> https://github.com/bitcoin/bitcoin/issues/12240 | [rpc] Introduced a new `fees` structure that aggregates all sub-field fee types denominated in BTC by mryandao · Pull Request #12240 · bitcoin/bitcoin · GitHub 20:27 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 20:29 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has quit [Quit: probably someone interrupted me] 20:35 < wumpus> dongcarl: funding is hardly ever the issue 20:37 < mryandao> while most open source project struggle with funding, bitcoin-core has a funny situation where there simply enough human resources to spend funding? :/ 20:37 < wumpus> if you have a good plan for that, but the problem is servers to run it on, I'm sure something can be agreed on 20:38 < wumpus> yes the problem is people 20:46 < kallewoof> Does anyone have any objections to extending the WIF format with types, so that wallet software can know what kind of key it corresponds to (P2WPKH, P2WPKH-P2SH, etc)? BIP proposal here: https://github.com/kallewoof/bips/blob/bip-typed-wif/bip-extended-privkey.mediawiki 20:46 < wumpus> kallewoof: sounds like a good idea to me 20:47 < kallewoof> luke-jr: Would you mind assigning a BIP number? I've had this on the ML for awhile, and no one replied (= no one objected). 20:51 < wumpus> kallewoof:I think non-compressed should not be suffix 0, but simply 'no suffix byte', that's better for backward compatibility 20:51 < wumpus> (you mention that yourself in Compatibility so :-) 20:52 < wumpus> looks good to me otherwise 20:54 < kallewoof> wumpus: Hm. I thought 0x00 was the same as 'no suffix byte', compatibility wise... 20:55 < wumpus> kallewoof: a lot of implementations just check the length 20:55 < kallewoof> wumpus: I mean, 0x00 is the same as 'no suffix' which means uncompressed. 20:55 < kallewoof> wumpus: Geh. Okay. 20:56 < wumpus> well I don't know about 'a lot' but I've seen it done, and I don't think there's a good reason to introduce a new encoding for P2PKH_UNCOMPRESSED - the current one is unambigious! 20:57 < kallewoof> wumpus: Yeah, makes sense. So either have no suffix byte (=P2PKH_UNCOMPRESSED), or have one that is non-zero 20:57 < luke-jr> well, then it suddenly becomes a bug to interpret it as compressed/etc 20:57 < luke-jr> kallewoof: is there a PR? 20:57 < wumpus> "all types with a suffix byte are compressed" 20:57 < kallewoof> luke-jr: There's a branch, no PR yet. Can make one easily enough. 20:58 < kallewoof> luke-jr: Will fix wumpus feedback and then make PR 20:58 < luke-jr> kallewoof: PR for the BIP I mean 20:58 < kallewoof> luke-jr: Yes 20:58 < luke-jr> that goes before # assignment these days 21:01 < kallewoof> luke-jr: https://github.com/bitcoin/bips/pull/673 21:01 < kallewoof> wumpus: I did a first draft on switching to uncompressed = no suffix. 21:02 -!- zautomata2 [~zautomata@41.239.49.73] has joined #bitcoin-core-dev 21:03 < luke-jr> kallewoof: I suggest making type 0 always p2pk or p2pkh 21:03 < luke-jr> "Legacy public key format" should be "p2pkh" 21:04 < kallewoof> luke-jr: Isn't type 0 ambiguous with 'not compressed'? Or is 'not compressed' *always* a missing suffix byte? 21:05 -!- jarthur [~jarthur@2605:6000:1019:42b6:18fd:ad96:9af1:90ae] has joined #bitcoin-core-dev 21:05 -!- zautomata1 [~zautomata@41.232.201.113] has quit [Ping timeout: 264 seconds] 21:05 < kallewoof> luke-jr: I forgot about P2PK though... 21:05 < luke-jr> might want to ask thomasv to co-author the BIP 21:05 < kallewoof> Yeah, good idea 21:06 < wumpus> yes, the important part is that other wallet authors agree 21:06 < wumpus> if they're not on one page, it's not much of a standard :) 21:08 < kallewoof> Yeah, I was sort of assuming they'd be on the ML and object if they found it offensive, but asking directly is definitely a good idea 21:09 < wumpus> that would be the ideal situation, but in practice most people are probably very busy and don't pay much attention to the mailing list day to day - a common practice would be to CC: people that should absolutely see it 21:10 < kallewoof> wumpus: I don't really know who to CC though, aside from thomasv, who is already in the thread. In fact, he's the author of it. 21:10 < wumpus> ok 21:10 < wumpus> (me neither, just have the same experience with ignored messages on MLs :-) 21:14 < wumpus> in open source projects you shouldn't be afraid to poke people, if necessarily repeatedly (after some time passed) 21:15 < kallewoof> wumpus: Haha, yeah I'm trying to get used to that idea. 21:20 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Remote host closed the connection] 21:20 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 21:23 < wumpus> kallewoof: uh oh, looking at python-bitcoinlib's WIF decoder: https://github.com/petertodd/python-bitcoinlib/blob/master/bitcoin/wallet.py#L253 they treat only keys with suffix byte AND suffix byte=1 as compressed and the rest as uncompressed 21:24 < kallewoof> wumpus: Wow... okay. Wonder why they chose that approach. 21:24 < wumpus> accidentally, I think 21:25 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Ping timeout: 268 seconds] 21:25 < wumpus> we can fix that at the same time as implementing your BIP - just a data point 21:26 < wumpus> though at some point it would be safer to create a completely new WIF format 21:26 < wumpus> especially if we find more examples of handling the suffix byte differently 21:26 < kallewoof> wumpus: I'm gonna look around at other implementations and see how they're doing it. 21:26 < kallewoof> wumpus: Yeah. 21:26 < wumpus> yes, good idea 21:32 < luke-jr> Could Bech32 it 21:32 < wumpus> luke-jr: I had that in my mind as well 21:34 < kallewoof> Yeah, that would be nice. I know sipa has talked about it in the past. 21:35 < kallewoof> btcd seems to do the "right" thing (ignoring the suffix byte, actually.. I think.. so they should be 100% compatible): https://github.com/btcsuite/btcutil/blob/501929d3d046174c3d39f0ea54ece471aa17238c/wif.go#L90-L102 21:35 < kallewoof> Oh wait, nevermind. They do check that it's 0x01 for compressed. 21:35 < luke-jr> a Bech32 format would be a clean break of compatibility 21:36 < wumpus> I've downgraded my ACK to Concept ACK for now 21:37 < kallewoof> luke-jr: I was hoping we could get a fix in for WIF soonish, as I don't believe sipa is done with the params for the private key bech32 variant. 21:37 < kallewoof> wumpus: I'll note the bech32 alternative on the BIP 21:38 < wumpus> I'm a bit afraid that this might result in funds loss in some edge cases 21:38 < wumpus> e.g. importing one of the new key types into an old wallet, there's no error, but as it is interpreted wrongly, nothing happens either 21:38 < kallewoof> That would be a display error, not a fund loss 21:39 < luke-jr> ^ 21:39 < luke-jr> even if the user throws away the WIF, you could still export the key and fix it later 21:39 < wumpus> ok 21:40 < luke-jr> kallewoof: what's the need for an interim format? WIF is fine.. 21:41 < kallewoof> luke-jr: It's fine, except you need to import every possible type of public key as you don't know what kind it is. See https://github.com/bitcoin/bitcoin/pull/12705#issuecomment-373973741 21:41 -!- wolfspraul [~wolfsprau@bobbin.q-ag.de] has quit [Ping timeout: 264 seconds] 21:42 < kallewoof> sipa said: "Relatedly, we don't have an encoding for "private key whose address is supposed to be P2SH-P2WPKH". My suggestion would be to add one (I believe Electrum has some sort of standard for this). importprivkey can't really use these, because it already has to assume it can be any type, but importmulti does not need to repeat this. It could assume just P2PKH for a legacy WIP encoding, and 21:42 < kallewoof> P2SH/P2WPKH when one of those novel encodings is used." 21:43 < wumpus> right, the problem is mostly one of inefficiency due to aspecificity 21:44 < kallewoof> *nods* 21:45 < luke-jr> kallewoof: minor enough I'd just prefer to wait for Bech32 21:46 < luke-jr> users shouldn't be touching private keys by hand anyway 21:51 < kallewoof> luke-jr: perhaps they shouldn't, but it's a pressing enough issue that wallets are making their own formats up for this, so it doesn't feel completely unwarranted. It depends of course on how far away we are from bech32-style format. 21:51 < luke-jr> I'd say let them make the BIP then ;) 21:53 < wumpus> I still think this is a good idea in itself 21:53 < kallewoof> That puts us back at square 1 on other projects, like importmulti. 21:54 < kallewoof> I agree with sipa that we should address the private key ambiguity before updating importmulti (#12705) 21:54 < gribble> https://github.com/bitcoin/bitcoin/issues/12705 | [WIP] Importmulti private key support by kallewoof · Pull Request #12705 · bitcoin/bitcoin · GitHub 21:55 < wumpus> right 21:55 < sipa> kallewoof, luke-jr, wumpus: i think we should see the existing WIF format as *just* a key with no information about associated addresses; it has to be clear from the context or irrelevant 21:56 < sipa> while the new format can be a combined key + implicit associated address 21:56 < sipa> kallewoof: i haven't worked on an extended bech32 in a while; i could pick it up again, but the design space is so big :) 21:56 < wumpus> yes 21:56 < kallewoof> sipa: Would it make sense to use bech32 as is for private keys? 21:57 < sipa> kallewoof: bech32 itself? it can only correct two errors 21:58 < kallewoof> Right. I know you were looking into optimizing that. I guess what I wonder is, does it make sense to do something without an optimized extended bech32 or should we just sit tight? 21:58 < sipa> i would expect that for private ieys you want to be able to correct more 21:59 < wumpus> you'd want to propose a completely new encoding for private keys? 21:59 < sipa> and things like extended pubkeys etc 21:59 < sipa> anything that's not specifically optimized to be short 22:00 < wumpus> right 22:01 < sipa> but again, i haven't worked on that in a while 22:02 < sipa> i believe with 13 checksum characters you can correct 4 errors easily 22:02 < wumpus> it seems a long-term thing, and there seems to be some demandfrom wallet authors for an intermediate format, I think that's what motivated the BIP 22:02 < sipa> yup 22:07 < wumpus> but yes having a robust, error correcting private key format would be very nice 22:10 < sipa> maybe i'll post a summary of the options on the ml 22:10 < kallewoof> sipa: That would be great 22:10 < kallewoof> sipa: I'd love to work on the extended bech32 format, but to be honest, I don't think I'd find an optimal solution on my own. :) 22:12 < sipa> i'll post a list of options 22:14 < sipa> i don't have the knowledge/computation to find an optimal solution either 22:14 < sipa> for bech32 it was doable due to limited search space 22:16 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has quit [Remote host closed the connection] 22:17 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has joined #bitcoin-core-dev 22:19 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-qutptyzkwnkjlybr] has quit [Quit: Connection closed for inactivity] 22:23 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 22:29 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has quit [Ping timeout: 265 seconds] 22:31 -!- dcousens [~dcousens@101.188.142.185] has joined #bitcoin-core-dev 22:57 -!- goatpig [56f75164@gateway/web/freenode/ip.86.247.81.100] has joined #bitcoin-core-dev 23:01 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has joined #bitcoin-core-dev 23:01 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 265 seconds] 23:15 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 268 seconds] 23:20 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 23:21 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 268 seconds] 23:22 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 23:24 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has quit [Quit: probably someone interrupted me] 23:30 < jonasschnelli> Currently, encodings that use more space may be more cumbersome for seed backups,... though it could be orthogonal (depening on the new concept) 23:30 < bitcoin-git> [bitcoin] practicalswift opened pull request #12963: Fix Clang Static Analyzer warnings (master...issue-12961) https://github.com/bitcoin/bitcoin/pull/12963 23:31 < jonasschnelli> Also, if length is not an issue, why not just use ? 23:32 < sipa> ? 23:32 < sipa> two privkeys? 23:35 < wumpus> could also encode to a passphrase in some dictionary and use the redundancy of e.g. english for error correction (not sure how that compares to other approaches :-) 23:36 < jonasschnelli> sipa: the same key twice 23:36 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/979f59850c72...e561cf4fa865 23:36 < bitcoin-git> bitcoin/master 3450a9b Ben Woosley: Extract consts for WITNESS_V0 hash sizes 23:36 < bitcoin-git> bitcoin/master e561cf4 Wladimir J. van der Laan: Merge #12939: Extract consts for WITNESS_V0 hash sizes... 23:38 < bitcoin-git> [bitcoin] laanwj closed pull request #12939: Extract consts for WITNESS_V0 hash sizes (master...hash-size-constants) https://github.com/bitcoin/bitcoin/pull/12939 23:38 < jonasschnelli> Maybe I got a wrong understanding of the use case. 23:39 < sipa> jonasschnelli: that's stupid :) 23:40 < sipa> you can get far better error correction with that length :) 23:40 < sipa> wumpus: you know gramtropy? 23:40 < jonasschnelli> Okay. Then I'm better be quite about encoding and error correction. :) 23:41 -!- anome [~anome@unaffiliated/anome] has joined #bitcoin-core-dev 23:41 < wumpus> sipa: I was just thinking of that, but couldn't find it, I suppose incorporating grammar would create even more redundancy 23:41 < jonasschnelli> https://github.com/sipa/gramtropy 23:42 < wumpus> though no, that's not as easy to correct for 23:46 < sipa> ha, no :) 23:48 -!- moneyball [~moneyball@c-73-223-73-149.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 23:59 < jonasschnelli> sipa: where is your long-term-wallet concept gist/wiki? 23:59 < jonasschnelli> Is there a central place for bitcoin core implementation concepts?