--- Day changed Thu Apr 12 2018 00:03 -!- Randolf [~randolf@96.53.47.42] has quit [Quit: https://www.randolfrichardson.com/] 00:03 < kallewoof> jonasschnelli: Don't think so. We could make a page on the wiki and link to stuff as we see it maybe. 00:03 < jonasschnelli> Yes. Maybe a topic for today 00:03 -!- nullptr| [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has quit [Ping timeout: 264 seconds] 00:04 -!- nullptr| [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has joined #bitcoin-core-dev 00:07 < sipa> jonasschnelli: https://gist.github.com/sipa/125cfa1615946d0c3f3eec2ad7f250a2 00:07 < jonasschnelli> thx! 00:10 < bitcoin-git> [bitcoin] lutangar closed pull request #12736: [RPC][Refactoring] Meaningful error code when called with wrong number of arguments (master...error-code-for-param-number) https://github.com/bitcoin/bitcoin/pull/12736 00:12 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Remote host closed the connection] 00:13 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 00:18 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e561cf4fa865...39439e5ab419 00:18 < bitcoin-git> bitcoin/master 72ec5b7 Gregory Sanders: debug log number of unknown wallet records on load 00:18 < bitcoin-git> bitcoin/master 39439e5 Wladimir J. van der Laan: Merge #12888: debug log number of unknown wallet records on load... 00:18 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Ping timeout: 264 seconds] 00:18 -!- anome [~anome@unaffiliated/anome] has quit [] 00:19 < bitcoin-git> [bitcoin] laanwj closed pull request #12888: debug log number of unknown wallet records on load (master...unknownrec) https://github.com/bitcoin/bitcoin/pull/12888 00:21 -!- DMTcrypto [~user@172.83.40.25] has quit [Ping timeout: 240 seconds] 00:25 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Ping timeout: 256 seconds] 00:27 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 00:30 < kallewoof> So, I've now heard several people express positive things about ":" as a way to specify key types. So if you had a bech32 public key, you would express its private key as p2wpkh:. This is apparently what Electrum is/did switch(ing) to. 00:32 < kallewoof> My only concern is if people start manually prefixing previously dumped privkeys and getting the type wrong, but that should never cause a loss of funds as discussed earlier. 00:37 < sipa> well... humans shouldn't be dealing with private keys directly, in general 00:37 < stevenroose> sipa: about the coins cache, AddCoin only checks if a new entry doesn't overwrite a non-spent entry *in the cache*. what prevents overwriting a non-spent entry that is not cached? 00:38 < sipa> stevenroose: bip30 00:38 < sipa> and bip34 00:39 < sipa> stevenroose: the checks there are consistency checks (= they protect against bugs in the code), they're not what prevents actual blocks from performing such uodates 00:39 < sipa> those are dealt with in consensus code 00:41 < kallewoof> sipa: Sure, but this encourages that behavior by being human readable, as opposed to a binary byte value embedded in the format itself. 00:43 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 00:45 -!- rls0 [~rls@2600:8800:1e00:9e1:1d53:9583:59e1:7557] has quit [Ping timeout: 276 seconds] 00:46 -!- Amuza [~Amuza@85.159.207.5] has joined #bitcoin-core-dev 00:47 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has joined #bitcoin-core-dev 00:48 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 00:48 < stevenroose> sipa: that makes sense 00:48 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 268 seconds] 00:52 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 00:52 -!- drizztbsd is now known as timothy 00:55 < sipa> kallewoof: fair point 00:55 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 00:55 < sipa> kallewoof: but then again, why do we have a concise format anyway? 00:56 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 00:59 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Read error: Connection reset by peer] 00:59 < kallewoof> sipa: well, in my case I realized I had an old GUI wallet with bitcoin in it, and it allowed me to export the private keys. I just imported those into bitcoin core, rather than sending the amount (it was tiny). In the future, this will probably be done using the HD master key instead, but I don't know. Anyway, I may not always want to import the entire wallet, just a specific key... 01:03 -!- Amuza [~Amuza@85.159.207.5] has quit [Quit: Leaving] 01:03 < jonasschnelli> kallewoof: IMO "transporting" private keys is non-ideal security practice 01:04 -!- Varunram_ [sid210151@gateway/web/irccloud.com/x-hvmmktvyzmhmfmgv] has quit [Changing host] 01:04 -!- Varunram_ [sid210151@unaffiliated/varunram] has joined #bitcoin-core-dev 01:04 -!- Varunram_ [sid210151@unaffiliated/varunram] has quit [Changing host] 01:04 -!- Varunram_ [sid210151@gateway/web/irccloud.com/x-hvmmktvyzmhmfmgv] has joined #bitcoin-core-dev 01:05 < kallewoof> jonasschnelli: It may not be ideal, but I think people will be tempted to do it between their own wallets, esp if the amounts are smallish. 01:06 -!- Varunram_ is now known as Varunram 01:11 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 01:12 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 01:15 -!- anome [~anome@unaffiliated/anome] has joined #bitcoin-core-dev 01:16 -!- anome [~anome@unaffiliated/anome] has quit [Client Quit] 01:17 -!- anome [~anome@unaffiliated/anome] has joined #bitcoin-core-dev 01:19 -!- jarthur [~jarthur@2605:6000:1019:42b6:18fd:ad96:9af1:90ae] has quit [] 01:19 -!- Samdney [~Samdney@178.162.209.136] has joined #bitcoin-core-dev 01:37 -!- Amuza [~wia@85.159.207.5] has joined #bitcoin-core-dev 01:46 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #12965: Add RPC call setscriptthreadsenabled: allow to temp. throttle CPU usage (master...2018/04/svt) https://github.com/bitcoin/bitcoin/pull/12965 01:55 -!- promag [~promag@31.22.214.151] has joined #bitcoin-core-dev 01:58 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 02:02 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [] 02:19 -!- laurentmt [~Thunderbi@62.112.9.237] has joined #bitcoin-core-dev 02:29 < bitcoin-git> [bitcoin] kallewoof opened pull request #12966: [WIP] Mempool optimized feerate (master...mempool-optimized-feerate) https://github.com/bitcoin/bitcoin/pull/12966 02:42 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 02:55 -!- anome [~anome@unaffiliated/anome] has quit [] 02:55 -!- anome [~anome@unaffiliated/anome] has joined #bitcoin-core-dev 03:08 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 03:09 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 03:12 < bitcoin-git> [bitcoin] Empact closed pull request #12459: Assert compressed keys are strictly shorter than regular (master...assert-compressed-smaller) https://github.com/bitcoin/bitcoin/pull/12459 03:16 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 03:19 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 03:20 < fanquake> wumpus I opened #12955 for the weird travis failures. I'd like to know what's happening before we merge 12899.. 03:20 < gribble> https://github.com/bitcoin/bitcoin/issues/12955 | travis: Windows build failing after -pie changes · Issue #12955 · bitcoin/bitcoin · GitHub 03:21 < wumpus> fanquake: I agree, certainly don't plan to merge it unless it passes travis 03:22 < fanquake> wumpus I'm also putting together a PR for most of the 0.16 backports. Any thoughts on a 0.16.1 release? Looks like there is 1 PR left which needs a rebase. 03:23 < wumpus> fanquake: is there a trigger for a 0.16.1 release? 03:23 < fanquake> *1 PR that should be merged before 0.16.1 that is 03:23 -!- DMTcrypto [~user@47-51-33-227.static.mtpk.ca.charter.com] has joined #bitcoin-core-dev 03:23 < wumpus> (apart from that it's a good idea to already backport some things, but just wondering) 03:24 < fanquake> wumpus no particular trigger at the moment 03:28 < bitcoin-git> [bitcoin] fanquake opened pull request #12967: backport: #12626, #12650, #12487 (0.16...backport-12626) https://github.com/bitcoin/bitcoin/pull/12967 03:28 -!- DMTcrypto [~user@47-51-33-227.static.mtpk.ca.charter.com] has quit [Ping timeout: 268 seconds] 03:36 < promag> someone knows why assert(CWallet::GetConflicts(txid).count(txid) == 0) can fail?? 03:36 < promag> can a txid conflict with itself? 03:40 -!- DMTcrypto [~user@162.251.236.4] has joined #bitcoin-core-dev 03:45 -!- promag [~promag@31.22.214.151] has quit [Remote host closed the connection] 03:54 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Excess Flood] 03:54 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 04:02 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has joined #bitcoin-core-dev 04:02 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has quit [Client Quit] 04:08 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has quit [Remote host closed the connection] 04:09 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has joined #bitcoin-core-dev 04:12 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has joined #bitcoin-core-dev 04:12 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has quit [Client Quit] 04:14 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has joined #bitcoin-core-dev 04:28 -!- shesek [~shesek@bzq-84-110-235-224.red.bezeqint.net] has joined #bitcoin-core-dev 04:28 -!- shesek [~shesek@bzq-84-110-235-224.red.bezeqint.net] has quit [Changing host] 04:28 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 04:31 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 04:40 -!- rls [~rls@2600:8800:1e00:9e1:1d53:9583:59e1:7557] has joined #bitcoin-core-dev 04:41 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 04:42 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 04:48 < instagibbs> jonasschnelli, also writing down a key twice means correlated errors. sad! 04:48 < instagibbs> if im writing down a key, get a character wrong, super likely ill do it twice 05:12 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 05:19 < wumpus> instagibbs: just munge the second time w/ some xor key *ducks* 05:23 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 05:27 -!- laurentmt [~Thunderbi@62.112.9.237] has quit [Quit: laurentmt] 05:27 -!- Samdney [~Samdney@178.162.209.136] has quit [Quit: Verlassend] 05:29 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-italiocyuvevhiuu] has joined #bitcoin-core-dev 05:32 -!- zautomata2 [~zautomata@41.239.49.73] has quit [Ping timeout: 240 seconds] 05:34 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 05:34 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 05:35 -!- zautomata2 [~zautomata@41.239.49.73] has joined #bitcoin-core-dev 05:38 -!- Krellan [~Krellan@2601:640:4000:9258:edd8:da80:aef1:8c0f] has quit [Read error: Connection reset by peer] 05:39 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 264 seconds] 05:40 -!- Krellan [~Krellan@2601:640:4000:9258:3146:da6b:2280:3443] has joined #bitcoin-core-dev 05:40 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:41 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 05:42 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds] 05:47 -!- harding_ is now known as harding 05:48 -!- harding [quassel@2600:3c03::f03c:91ff:fe7b:78d1] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.] 05:48 -!- harding [quassel@2600:3c03::f03c:91ff:fe7b:78d1] has joined #bitcoin-core-dev 05:50 -!- DMTcrypto [~user@162.251.236.4] has quit [Ping timeout: 264 seconds] 05:57 -!- rls [~rls@2600:8800:1e00:9e1:1d53:9583:59e1:7557] has quit [Ping timeout: 255 seconds] 05:58 -!- promag [~promag@89.214.216.107] has joined #bitcoin-core-dev 06:01 -!- promag_ [~promag@a89-152-20-96.cpe.netcabo.pt] has joined #bitcoin-core-dev 06:03 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:04 -!- promag [~promag@89.214.216.107] has quit [Ping timeout: 276 seconds] 06:07 -!- propumpkin is now known as contrapumpkin 06:22 -!- DMTcrypto [~user@47-51-33-227.static.mtpk.ca.charter.com] has joined #bitcoin-core-dev 06:24 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Remote host closed the connection] 06:26 -!- DMTcrypto [~user@47-51-33-227.static.mtpk.ca.charter.com] has quit [Ping timeout: 240 seconds] 06:32 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 06:34 -!- rabidus [~rabidus@91-145-120-64.bb.dnainternet.fi] has quit [Ping timeout: 240 seconds] 06:34 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 06:38 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 276 seconds] 06:38 -!- DMTcrypto [~user@162.251.236.4] has joined #bitcoin-core-dev 07:02 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has quit [Ping timeout: 255 seconds] 07:03 < jamesob> anyone have any good workarounds for the github-unicorn-of-death effect for prs with many comments? I'm basically unable to continue review on #11857 because the page won't load 07:03 < gribble> https://github.com/bitcoin/bitcoin/issues/11857 | Build tx index in parallel with validation by jimpo · Pull Request #11857 · bitcoin/bitcoin · GitHub 07:05 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 07:05 < fanquake> jamesob Pretty sure that's just GitHub having a sad 07:05 -!- musou [abd92fae@gateway/web/freenode/ip.171.217.47.174] has joined #bitcoin-core-dev 07:05 < fanquake> I'm also seeing unicorns 07:05 < jamesob> fanquake: yeah it's been pretty bad for the last 24 hours 07:05 < aj> huh, it's working fine here :-/ 07:06 -!- musou [abd92fae@gateway/web/freenode/ip.171.217.47.174] has quit [Client Quit] 07:06 < jamesob> of course their status page reports 100% uptime :) 07:07 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has joined #bitcoin-core-dev 07:24 < sipa> kallewoof: my goal here is to make sure there exists a compact description of your wallet that's human readable to the extent it has structure that matters (see my wallet design gist)... but it doesn't need to be a single string or collection thereof 07:36 -!- wvr [~wvr@3.red-88-21-184.staticip.rima-tde.net] has joined #bitcoin-core-dev 07:36 -!- DMTcrypto [~user@162.251.236.4] has quit [Ping timeout: 264 seconds] 07:39 < promag_> jnewbery: hi, did you understand my point? 07:40 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 07:43 -!- promag_ is now known as promag 07:44 < promag> jnewbery: saw your relpy in gh, ty 07:45 -!- str4d [~str4d@205-168-65-138.dia.static.qwest.net] has joined #bitcoin-core-dev 07:46 < jnewbery> promag: i don't think I fully understand! I've answered as best I can, but perhaps you can elaborate in the PR 07:46 < promag> jnewbery: I thought 0.18 won't have those dummy args 07:49 -!- DMTcrypto [~user@162.251.236.6] has joined #bitcoin-core-dev 07:49 < jnewbery> It's possible to remove the dummy args in a future version, but not necessary. Removing dummy args is an API break. 07:49 -!- str4d [~str4d@205-168-65-138.dia.static.qwest.net] has quit [Ping timeout: 240 seconds] 07:50 < jnewbery> Other RPCs have had dummy args for many releases. See priorisetransaction and move for example. 07:54 -!- promag [~promag@a89-152-20-96.cpe.netcabo.pt] has quit [Remote host closed the connection] 08:03 -!- Amuza [~wia@85.159.207.5] has quit [Ping timeout: 240 seconds] 08:24 -!- Cheeseo [Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Read error: Connection reset by peer] 08:24 -!- cheese_ [Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 08:30 -!- Emcy_ [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 08:32 -!- CubicEarths [~cubiceart@188.155.63.9] has quit [Remote host closed the connection] 08:33 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 08:34 < wumpus> how careful to be with RPC API breakage depends on how much the RPC is used (uncommon and debugging RPCs should just be changed, but e.g. not sendtoaddress), as well as the consequences when running old code and the dummy argument is provided anyway 08:36 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 265 seconds] 08:41 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-orcyccjrhpndqfzt] has quit [Ping timeout: 276 seconds] 08:41 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-gqqgjehkcoxfzqwp] has joined #bitcoin-core-dev 08:50 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has joined #bitcoin-core-dev 08:53 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection] 08:53 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 08:54 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 08:54 -!- CubicEar_ [~cubiceart@xdsl-188-155-63-9.adslplus.ch] has joined #bitcoin-core-dev 08:57 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 268 seconds] 09:14 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 09:14 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 09:17 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has quit [Quit: probably someone interrupted me] 09:24 -!- rls [~rls@2600:8800:1e00:9e1:1d53:9583:59e1:7557] has joined #bitcoin-core-dev 09:30 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has joined #bitcoin-core-dev 09:31 -!- Samdney [~Samdney@178.162.209.134] has joined #bitcoin-core-dev 09:42 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 09:42 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has quit [Quit: probably someone interrupted me] 09:44 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has joined #bitcoin-core-dev 09:44 -!- promag [~promag@83.223.234.61] has joined #bitcoin-core-dev 09:45 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 09:52 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 09:52 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has quit [Quit: probably someone interrupted me] 09:53 -!- Murch [~murch@96.74.120.81] has joined #bitcoin-core-dev 09:57 -!- Krellan [~Krellan@2601:640:4000:9258:3146:da6b:2280:3443] has quit [Remote host closed the connection] 09:58 -!- instagibbs [~instagibb@pool-100-15-128-78.washdc.fios.verizon.net] has quit [Ping timeout: 260 seconds] 09:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:00 -!- so [~so@unaffiliated/so] has quit [Read error: Connection reset by peer] 10:04 -!- anome [~anome@unaffiliated/anome] has quit [] 10:06 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has joined #bitcoin-core-dev 10:10 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 10:11 -!- rls0 [~rls@67.215.10.250] has joined #bitcoin-core-dev 10:15 -!- rls [~rls@2600:8800:1e00:9e1:1d53:9583:59e1:7557] has quit [Ping timeout: 276 seconds] 10:20 -!- moneyball [~moneyball@65.200.72.90] has joined #bitcoin-core-dev 10:22 < promag> meeting at 20 utc? 10:22 < wumpus> 19 utc 10:22 < promag> ok ty 10:23 < wumpus> which should be 1 hour and ~38 minutes from now 10:23 < promag> :+1: 10:31 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 10:31 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has quit [Quit: probably someone interrupted me] 10:37 -!- promag [~promag@83.223.234.61] has quit [Remote host closed the connection] 10:37 -!- jnewbery [~john@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Remote host closed the connection] 10:38 < bitcoin-git> [bitcoin] laanwj opened pull request #12968: leveldb: Add ARMv8 CRC32C support (master...2018_04_armv8_crc32c) https://github.com/bitcoin/bitcoin/pull/12968 10:38 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has joined #bitcoin-core-dev 10:46 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has quit [Quit: probably someone interrupted me] 10:47 -!- jnewbery [~john@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 10:48 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has quit [Quit: zarez] 10:48 < jonasschnelli> wumpus: what ARM v8 machine do you use for testing/develpoing? 10:48 < wumpus> jonasschnelli: a server at mininodes that crashes all the time! I have a i.mx8 boards that I should set up though 10:49 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-italiocyuvevhiuu] has quit [Quit: Connection closed for inactivity] 10:50 < wumpus> (https://www.nxp.com/support/developer-resources/run-time-software/i.mx-developer-resources/evaluation-kit-for-the-i.mx-8m-applications-processor:MCIMX8M-EVK) 10:50 < jonasschnelli> The Cortex A53 is also v8 and should have the crc32 ext, right? 10:51 < jonasschnelli> (RPi3, Pine64, Ordoid-C2) 10:51 < wumpus> ah yes good idea, I have an odroid C2 here which has it 10:52 < jonasschnelli> My HC2/XU4 have an A15 (v7)... will report about performance soon 10:53 < jonasschnelli> wumpus: what tool do/did you use for performance measuring, gperf? 10:53 < wumpus> thanks! 10:53 < wumpus> I didn't measure performance of bitcoind at all yet, just crcbench independently: https://github.com/laanwj/crcbench 10:54 < jonasschnelli> ok 10:56 < wumpus> (which was impressive; about 6x faster on C2) 10:56 < cfields> wumpus: nice :) 11:02 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has joined #bitcoin-core-dev 11:07 -!- moneyball [~moneyball@65.200.72.90] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 11:07 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev 11:10 -!- moneyball [~moneyball@65.200.72.90] has joined #bitcoin-core-dev 11:10 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 11:11 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 11:11 < jonasschnelli> bitcoin_bench should have some verification benchmarks (simulate connectblock() or something with -par=0[auto]) 11:11 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 11:12 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Ping timeout: 276 seconds] 11:15 < wumpus> I think that's the only one out of the couple of benchmarks I proposed that never got implemented; it's difficult to do without setting up a lot of context 11:18 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 11:25 -!- moneyball [~moneyball@65.200.72.90] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 11:28 -!- laurentmt [~Thunderbi@62.112.9.237] has joined #bitcoin-core-dev 11:29 -!- moneyball [~moneyball@65.200.72.90] has joined #bitcoin-core-dev 11:33 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has quit [Quit: probably someone interrupted me] 11:34 < drexl> is a compressed public key valid for a P2PK scriptPubKey? 11:35 < wumpus> yes 11:36 < drexl> cheers 11:37 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has joined #bitcoin-core-dev 11:37 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has quit [Changing host] 11:37 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev 11:38 < midnightmagic> wonder when it'll be time to pick up a sifive thingy.. 11:40 < wumpus> the sifive unleashed board seems really nice 11:40 < midnightmagic> bunny crapped on it :-/ 11:40 < wumpus> oh? just the closed bootloader thing or more? 11:40 < midnightmagic> dunno why, ultimately. Are you picking one up for porting? 11:41 < midnightmagic> wumpus: just the closed initial boot stuff, yes, so far. 11:41 < wumpus> well that's no worse than NXP then at least... 11:41 < wumpus> midnightmagic: yes :) 11:41 < midnightmagic> nice, I'm glad. that makes me want one now. 11:42 < wumpus> would be more worried if e.g. the performance was really bad, or worse it crashed randomly 11:43 -!- ProfMac [~ProfMac@2001:470:b8ac:0:fc22:f953:9572:4602] has quit [Ping timeout: 260 seconds] 11:43 < jonasschnelli> Our gitian -debug builds -O2 -g, right? They should be okay for performance profiling? 11:44 < wumpus> yes -O2 -g is fine for performance profiling, -g itself doesn't make your code slower, make sure the lock debugging and such is not enabled though 11:45 < jonasschnelli> I once remember reading something about -g3 for gcc... anyway, thanks wumpus 11:46 < jonasschnelli> cfields: do you know why the dependency download on OSX is timing out on gitian/master: https://bitcoin.jonasschnelli.ch/builds/564/build_osx.log 11:46 < jonasschnelli> +? 11:46 < wumpus> -g is additive, it adds metadata, -g2 -g3 (potentially, depending on the compiler) adds more metadata. But that's all separate from the .text segments afaik 11:47 < jonasschnelli> thanks 11:48 < cfields> jonasschnelli: looking 11:49 < cfields> jonasschnelli: curl: (28) Resolving timed out after 10542 milliseconds 11:49 < cfields> dns issues? 11:49 < jonasschnelli> let me check 11:50 < jonasschnelli> dig dig bitbucket.org works perfect... 11:51 < jonasschnelli> maybe an LXC container thing 11:51 < cfields> jonasschnelli: are you sure your gitian machine has dns/net access? 11:51 < cfields> right, that's what I was thinking 11:51 < jonasschnelli> the machine has,... not sure about LXC<-HOST->NET 11:51 < cfields> jonasschnelli: can you download sources as a prior step? 11:52 < jonasschnelli> cfields: Yes. But that is outside of the VM/LXC 11:52 < cfields> right 11:53 < jonasschnelli> need to check how I can get the LXC shell again... 11:54 -!- promag [~promag@204.247.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 11:55 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-ylbryioaazebtock] has joined #bitcoin-core-dev 11:55 < cfields> jonasschnelli: if you've got the right candles burning and say the right incantation, "libexec/on-target" might work. 11:55 < jonasschnelli> heh 11:57 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Ping timeout: 265 seconds] 11:57 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 12:00 < BlueMatt> mtg? 12:01 < sdaftuar> ack 12:01 < Randolf> Ack. 12:01 < BlueMatt> whereforartthou wumpus 12:01 < wumpus> #startmeeting 12:01 < lightningbot> Meeting started Thu Apr 12 19:01:49 2018 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot. 12:01 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 12:02 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator 12:02 < promag> hi 12:02 < Randolf> Hello. 12:02 < achow101> hi 12:02 < sipa> hi 12:02 < jonasschnelli> hi 12:02 < kanzure> hi. 12:02 < cfields> hi 12:02 < meshcollider> hi 12:02 < wumpus> any proposed topics? 12:02 < luke-jr> o hai 12:02 < sipa> #12874 What to do with IsMine of bare multisig? 12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/12874 | Only accept bare multisig outputs after addmultisigaddress by sipa · Pull Request #12874 · bitcoin/bitcoin · GitHub 12:03 < wumpus> thanks 12:03 < jimpo> hi 12:03 < promag> dynamic wallet load/unload 12:03 < luke-jr> I don't know why we would *ever* accept bare multisig 12:03 < wumpus> let's start with "high priority for review" as usual 12:03 < wumpus> #topic high priority for review 12:03 < wumpus> https://github.com/bitcoin/bitcoin/projects/8 12:04 < jimpo> Waiting on BlueMatt to rereview #11857 after revision 12:04 < wumpus> #11857 #12560 #11775 12:04 < BlueMatt> #11775 should probably removed and replaced with the forthcoming split of it into multiple pr's 12:04 < gribble> https://github.com/bitcoin/bitcoin/issues/11857 | Build tx index in parallel with validation by jimpo · Pull Request #11857 · bitcoin/bitcoin · GitHub 12:04 < gribble> https://github.com/bitcoin/bitcoin/issues/11857 | Build tx index in parallel with validation by jimpo · Pull Request #11857 · bitcoin/bitcoin · GitHub 12:04 < gribble> https://github.com/bitcoin/bitcoin/issues/12560 | [wallet] Upgrade path for non-HD wallets to HD by achow101 · Pull Request #12560 · bitcoin/bitcoin · GitHub 12:04 < BlueMatt> though the first few commits could still use eyeballs 12:04 < gribble> https://github.com/bitcoin/bitcoin/issues/11775 | Move fee estimator into validationinterface/cscheduler thread by TheBlueMatt · Pull Request #11775 · bitcoin/bitcoin · GitHub 12:04 < gribble> https://github.com/bitcoin/bitcoin/issues/11775 | Move fee estimator into validationinterface/cscheduler thread by TheBlueMatt · Pull Request #11775 · bitcoin/bitcoin · GitHub 12:04 < sdaftuar> BlueMatt: i'll give you my comments after you split it :P 12:04 < BlueMatt> as for 11857, yes, thats my fault :/ 12:05 < jtimon> hi 12:05 < jimpo> #12560 still has one unaddressed comment by me I think 12:05 < gribble> https://github.com/bitcoin/bitcoin/issues/12560 | [wallet] Upgrade path for non-HD wallets to HD by achow101 · Pull Request #12560 · bitcoin/bitcoin · GitHub 12:05 < wumpus> BlueMatt: ok 12:05 < BlueMatt> as for 12560...why no reivew? :/ 12:06 < wumpus> dunno github gives me the unicorn now 12:06 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has joined #bitcoin-core-dev 12:06 < jtimon> I guess https://github.com/bitcoin/bitcoin/pull/10757 is not a priority, but review beg either way now that there's many people 12:06 < Randolf> The "unicorn?" 12:06 < sipa> #10757 12:07 < gribble> https://github.com/bitcoin/bitcoin/issues/10757 | RPC: Introduce getblockstats to plot things by jtimon · Pull Request #10757 · bitcoin/bitcoin · GitHub 12:07 < wumpus> Randolf: the "This page is taking way too long to load." unicorn 12:07 < BlueMatt> lol, cancel meeting cause github broken? 12:07 < Randolf> wumpus: I haven't seen that one yet. 12:07 < Randolf> That's hilarious. 12:07 < wumpus> looks like the bot still can use the API 12:08 < jtimon> works for me just fine... 12:08 < jtimon> I got a unicorn the other day though, I reloaded and it worked 12:08 < wumpus> usually it takes a few minutes and then it works again 12:09 < promag> jtimon: I'll take a look 12:09 < jtimon> promag: awesome, thanks 12:09 < wumpus> I'll add 10757 12:09 * Randolf wonders if "Unicorns" is going to be listed as one of the topics in the log afterwards 12:10 < achow101> i believe i addressed all comments for 12560, but i could have missed one or two 12:10 < jtimon> great, I had it kind of abandoned for some time but aj helped me with the tests and I got "unstuck" 12:11 < promag> I can also look 12560, at least code wise 12:11 < jimpo> achow101: I requested that HaveKey be moved out of the RPC file and into keystore 12:11 < jimpo> not sure if others agree 12:12 < wumpus> might want to discuss that outside the meeting? 12:12 < achow101> oh, I missed that comment 12:12 -!- plorark [bd37a6d3@gateway/web/freenode/ip.189.55.166.211] has joined #bitcoin-core-dev 12:12 < jnewbery> hi 12:13 < plorark> hey 12:13 < plorark> omg 12:13 < plorark> I've found people alive 12:13 < jimpo> yeah, we can discuss offline (well, still online, but yeah) 12:13 < plorark> watshapenin 12:13 < wumpus> #topic What to do with IsMine of bare multisig? (sipa) 12:13 < sipa> hi 12:13 < wumpus> plorark: after the meeting please 12:13 < Randolf> plorark: You've joined this channel during a meeting. 12:14 < plorark> omg sorry 12:14 < sipa> so currently (and since forever) we accept bare multisig outputs to us 12:14 -!- instagibbs_ [640f804e@gateway/web/freenode/ip.100.15.128.78] has joined #bitcoin-core-dev 12:14 < sipa> this is stupid, annoying, pointless, and hard to maintain 12:14 < achow101> are there any wallets that can even make bare multisig? 12:14 < sipa> BIP70, technically :) 12:14 < achow101> ew 12:14 < sipa> because it only works when you have all the public keys 12:15 < sipa> eh, all the private keys 12:15 < wumpus> sounds completely useless 12:15 < sipa> so generally i think this is a feature that nobody should ever want 12:15 < luke-jr> we don't act as BIP70 server ever though 12:15 < sipa> however, there may be existing outputs to it 12:15 < sipa> i don't know if this is the case or not 12:15 < jtimon> do people use bip70 ? 12:15 < sipa> but it sounds scary to just stop supporting it 12:15 < wumpus> so that needs some chain analysis I suppose 12:15 < echeveria> bitpay uses bip70 exclusively. 12:16 < BlueMatt> sipa: we'd not "stop supporting it", you'd still be able to sign for them in rawtransaction rpcs 12:16 < BlueMatt> so write up a five-sentence release not and stop supporting it :p 12:16 * luke-jr wonders how much overhead there'd be to supporting it up to a certain height 12:16 < achow101> sipa: is it possible to just prevent new bare multisig? 12:16 < jtimon> sipa: perhaps deperecate it on the next release ? 12:16 < sipa> BlueMatt: i have no intention to stop supporting signing for it 12:16 < jtimon> echeveria: thanks 12:16 < BlueMatt> sipa: yes, thats my point 12:16 < sipa> this is just about IsMine 12:16 < wumpus> just stop supporting it for receiving to our wallet 12:16 < sipa> yes, that's the easy part 12:17 < jtimon> BlueMatt: sounds fair enough 12:17 < sipa> but what if there are existing outputs in people's wallet 12:17 < BlueMatt> I mean step back a minute, if we're still talking about doing another hd split to move to a address model instead of a pubkey model in the wallet, why not do it then 12:17 < BlueMatt> and keep doing the default-add of the scripts from the original keys? 12:17 < BlueMatt> incl all the stuff we support today 12:17 < sipa> BlueMatt: ah, because it's impossible to remain compatible with it in an address model 12:17 < jonasschnelli> if one has already detected bar multisig txns, they will not disappear (unless rescan)? 12:17 < sipa> (you get a cubic explosion of combinations) 12:17 < BlueMatt> I though we only supported about 4 different script types? 12:18 < instagibbs_> sipa: sorry give an example? 12:18 < BlueMatt> raw multisig, p2ph, p2pubkey, and...? 12:18 < achow101> isn't the plan to move to a script model? 12:18 < sipa> BlueMatt: yes, but raw multisig up to 3-of-3 12:18 < BlueMatt> ouch 12:18 < sipa> which means N^3 combinations if you have N private keys 12:18 < plorark> ehh... I know I was not supposed to interrupt the meeting, but it's pointless for me to wait if this is not the channel i'm looking for. Is altcoins development discussions allowed here? 12:18 < Randolf> I thought Multisig could support more than 3 signatures. 12:18 < sipa> plorark: no 12:18 < sipa> Randolf: not standard 12:18 < instagibbs_> plorark: no 12:18 < plorark> oh, ok, sorry 12:18 < plorark> see ya 12:18 < Randolf> plorark: Join the ##altcoins channel. 12:19 < plorark> thx 12:19 < plorark> thx 12:19 < luke-jr> ##altcoin-dev * 12:19 < plorark> oops 12:19 < plorark> thx and bye 12:19 < BlueMatt> I mean, anyway, does it matter much? I'd default to "dont support with release notes indicating you can use signrawtransaction" 12:19 < sipa> so the #1 reason to fix this now is because I'd like to remain compatible with whatever the wallet already supports 12:19 < gribble> https://github.com/bitcoin/bitcoin/issues/1 | JSON-RPC support for mobile devices ("ultra-lightweight" clients) · Issue #1 · bitcoin/bitcoin · GitHub 12:19 < sipa> except for bare multisig 12:19 < BlueMatt> if we really care, add an option to include them when we move to address-based 12:19 < BlueMatt> with a note indicating it will eat all your memory 12:19 < Randolf> sipa: Maintaining compatibility seems like a very good justification. 12:20 < sipa> BlueMatt: by default our keypool is 2000 keys 12:20 < sipa> the cube of that is 8 billion 12:20 < BlueMatt> yes, I know 12:20 < sipa> that's just not feasible 12:20 < jimpo> Is there a way to register bare multisigs as some sort of key-thing? 12:20 < BlueMatt> meh, so dont support it at all without manual key-adds, then 12:20 < BlueMatt> jimpo: you could register the scripts as watch only 12:20 < instagibbs_> jimpo: manual import isn't out of question i assume 12:20 < sipa> BlueMatt: that's what #12874 does! 12:20 < gribble> https://github.com/bitcoin/bitcoin/issues/12874 | Only accept bare multisig outputs after addmultisigaddress by sipa · Pull Request #12874 · bitcoin/bitcoin · GitHub 12:20 < jimpo> So that IsMine is true only if you explicitly watch the script 12:21 < sipa> jimpo: yes, that is the PR i have open 12:21 < BlueMatt> sipa: I dont even think we need to match IsMine/accept them at that point 12:21 < jimpo> Oh, cool 12:21 < BlueMatt> sipa: would prefer we get rid of it completely 12:21 < BlueMatt> and just let people mark it watchonly 12:21 < sipa> i want to bring up is: is this overkill, and should we instead just remove it 12:21 < BlueMatt> then signrawtransaction it 12:21 < sipa> can you watchonly it? 12:21 < sipa> you can only watchonly addresses, not scripts, afaik 12:21 < sipa> ok i will investigate 12:21 < sdaftuar> importmulti lets you, i thought? 12:21 < instagibbs_> does it not sneak under redeemscript field or somesuch? 12:21 < jonasschnelli> just stop supporting it and mention it in the release notes... this seems safe and okay to me. 12:22 < instagibbs_> yeah check it out 12:22 < jimpo> sipa: Do you think there's a large burden to maintaining #12874? 12:22 < gribble> https://github.com/bitcoin/bitcoin/issues/12874 | Only accept bare multisig outputs after addmultisigaddress by sipa · Pull Request #12874 · bitcoin/bitcoin · GitHub 12:23 < sipa> jimpo: no, but it'd be better not to 12:23 < jonasschnelli> bar-multisig use-cases are data-services only IMO... we could analyze the utxos first to get a idea about how many potentail users would be affected... 12:23 < jonasschnelli> but right,.. existing bare multisig wtx would not disapear, right? 12:23 < sipa> they would 12:23 < jonasschnelli> ah.. isMine(), right 12:24 < jonasschnelli> but we could detect that and warn 12:24 < jimpo> If there's not a big downside to #12874, I'd prefer that approach, but don't care much if it's deprecated 12:24 < gribble> https://github.com/bitcoin/bitcoin/issues/12874 | Only accept bare multisig outputs after addmultisigaddress by sipa · Pull Request #12874 · bitcoin/bitcoin · GitHub 12:25 < sipa> BlueMatt: it seems we can indeed watch scripts 12:25 < sipa> i think that's my preferred approach then 12:25 < sipa> remove support entirely and note a workaround for the highly unlikely case in the release notes 12:26 < BlueMatt> yes 12:26 < jonasschnelli> ack 12:26 < wumpus> yes 12:26 < BlueMatt> agreed 12:26 < sipa> end topic 12:26 < wumpus> #topic dynamic wallet load/unload (promag) 12:26 < Randolf> Ack. 12:26 < promag> not sure what you guys think 12:26 < instagibbs_> what's the controversy in this topic :) 12:27 < jonasschnelli> #10740 12:27 < sipa> it should happen, duh 12:27 < gribble> https://github.com/bitcoin/bitcoin/issues/10740 | [WIP] [wallet] dynamic loading/unloading of wallets by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub 12:27 < wumpus> seems like something we want to have at some point... 12:27 < promag> but I think luke agrees that wallet management should be with shared pointers 12:27 < sipa> how and when is another :) 12:27 < luke-jr> indeed, using names just asks for chaos with runtime-changing wallets 12:28 < promag> please read #11402 for some reasons to switch 12:28 < gribble> https://github.com/bitcoin/bitcoin/issues/11402 | Use shared pointer for wallet instances by promag · Pull Request #11402 · bitcoin/bitcoin · GitHub 12:28 < jonasschnelli> IMO 10740 can't create wallets, IMO first step would be to add a createwallet RPC call 12:29 < jonasschnelli> the whole creation/configuration setup if flawed since multiwallet 12:29 < jonasschnelli> stuff like -keypool should be per wallet 12:29 -!- isis is now known as isis_ 12:29 < jnewbery> jonasschnelli: you think createwallet should go in *before* load/unload? 12:29 < jonasschnelli> and persisted in the wallet file (as configuration section) 12:29 < jonasschnelli> jnewbery: not sure,.. just thinking 12:30 < jnewbery> seems reasonable to me 12:30 < jonasschnelli> createwallet could also *not* load the wallet in the first step (not ideal, but maybe reduces complexity) 12:30 < sipa> that seems strange... you could create a new wallet at run time but not use it? 12:30 -!- instagibbs_ [640f804e@gateway/web/freenode/ip.100.15.128.78] has quit [Quit: Page closed] 12:30 < jonasschnelli> sipa: createwallet could also directly load/use the wallet 12:30 < jnewbery> I think createwallet would also load the new wallet, no? 12:30 < promag> create implies loading 12:30 < luke-jr> sipa: iow, 0 to 1 only. 12:31 < sipa> jonasschnelli: well then you need to have loading functionality first! 12:31 < sipa> and if you have it, why not expose it 12:31 -!- plorark [bd37a6d3@gateway/web/freenode/ip.189.55.166.211] has left #bitcoin-core-dev [] 12:31 < jonasschnelli> sipa: yes. That's a point. 12:31 < jnewbery> createwallet could also be done by bitcoin-wallet-tool 12:32 < jnewbery> (#8745) 12:32 < gribble> https://github.com/bitcoin/bitcoin/issues/8745 | [PoC] Add wallet inspection and modification tool "bitcoin-wallet-tool" by jonasschnelli · Pull Request #8745 · bitcoin/bitcoin · GitHub 12:32 < jonasschnelli> Yes. Would be possible... 12:32 < jonasschnelli> I just think the create-during-startup approach is not good 12:33 < promag> also related #10973 12:33 < jnewbery> jonasschnelli: I agree 12:33 < gribble> https://github.com/bitcoin/bitcoin/issues/10973 | Refactor: separate wallet from node by ryanofsky · Pull Request #10973 · bitcoin/bitcoin · GitHub 12:33 < sipa> jonasschnelli: agree 12:33 < jonasschnelli> And as a first step I though createwallet would make sense.. but not loading it seems after a strange use-case 12:33 < luke-jr> load -> create -> unload 12:33 < jonasschnelli> but a nice first code/impl. step 12:33 < luke-jr> unload is the complex part tbh 12:33 < jnewbery> luke-jr: agree 12:34 < jonasschnelli> Agree with luke-jr. Maybe split unload away from the existing PR jnewbery ? 12:34 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 255 seconds] 12:34 < jnewbery> yes 12:34 < jnewbery> I intend to pick up 10740 again soon, rebase and rework it 12:34 < promag> consider the use case: 1) rpc rescan wallet 2) in parallel unload wallet - should 2) wait for 1) ? 12:34 < luke-jr> probably 12:35 < jonasschnelli> Great. Dynamic loading/creating is a nice feature that we probably want for 0.17! 12:35 < promag> luke-jr: and if the unload is from the UI? 12:35 < jnewbery> promag: do you consider 11402 a prereq for load/unload? What about just load? 12:36 < jonasschnelli> the wallet-tool is IMO orthogonal to wallet creation 12:36 < jonasschnelli> *via RPC 12:36 -!- anome [~anome@unaffiliated/anome] has joined #bitcoin-core-dev 12:36 < luke-jr> promag: probably the same 12:36 < promag> jnewbery: IMHO for both 12:36 < jonasschnelli> RPC seems to be a must, wallet-tool can be a better place to create some sorts of wallets (or inspect it), .. like encrypted wallets 12:36 < luke-jr> promag: at least initially 12:37 < jnewbery> promag: want to rebase and put on high priority for review then, if you consider it a blocker? 12:37 < promag> luke-jr: my point is that it should not block, you request the unload and go on, when the wallet is not used anymore it gets unloaded 12:38 < jonasschnelli> #11402 12:38 < gribble> https://github.com/bitcoin/bitcoin/issues/11402 | Use shared pointer for wallet instances by promag · Pull Request #11402 · bitcoin/bitcoin · GitHub 12:38 < luke-jr> promag: you mean leave the wallet loaded, but invisible? that seems worst outcome IMO 12:38 < luke-jr> user may unload and just shut off the PC 12:38 < wumpus> the unload should probably be in two stages: after requesting it, RPC and the GUI lose access to it. Then it waits for current operations tofinish. Then the thing really gets delted. 12:38 < luke-jr> yes 12:38 < promag> luke-jr: then the application will wait for wallets to unload 12:38 < jnewbery> I don't think we need to worry about unload at this stage. First step is add load functionality, then createwallet functionality 12:38 < luke-jr> and make it visible to the user in the meantime 12:39 < luke-jr> jnewbery: +1 12:39 < promag> wumpus: right, hence shared pointers 12:40 < wumpus> ok 12:40 < wumpus> any other topics? we've had the proposed ones 12:41 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has quit [Quit: probably someone interrupted me] 12:41 < luke-jr> gitian updates? 12:41 < luke-jr> seems we have at least a few things that need a newer VM 12:41 < luke-jr> not sure if there's anything to discuss tho 12:42 < wumpus> dunno if cfields is here, if not it makes little sense to discuss this I think 12:42 < cfields> sure 12:43 < wumpus> #topic gitian update 12:43 < wumpus> #12511 I guess 12:43 < gribble> https://github.com/bitcoin/bitcoin/issues/12511 | Switch to Ubuntu 18.04 for gitian building · Issue #12511 · bitcoin/bitcoin · GitHub 12:44 < wumpus> not sure what's there to discuss about it 12:44 < luke-jr> I guess we need a replacement for vmbuilder or something, since Canonical hasn't updated it to support anything recent :/ 12:45 < cfields> ah, i didn't realize gitian couldn't handle it :( 12:46 < wumpus> debootstrap? 12:46 < luke-jr> debootstrap is a step in vmbuilder 12:46 < cfields> anyway, concept ack 12:47 < achow101> I'm considering adding docker support to gitian so we would use a default ubuntu docker image and then build from there 12:47 < wumpus> cool 12:48 < cfields> sgtm 12:48 < jcorgan> that would be nice 12:49 < wumpus> yes 12:49 < luke-jr> so KVM would no longer work? 12:49 < wumpus> heh if you make it work it will work 12:49 < luke-jr> Docker seems to just be a LXC wrapper 12:50 < achow101> Docker avoids all of the vm setup because someone else did that for us 12:50 < luke-jr> it's also x86-64 only 12:50 < wumpus> if vmbuilder or debootstrap does't work you could always manually install ubuntu to a base image I guess... 12:51 < jtimon> achow101: please, ping me for review if you do 12:51 < wumpus> but in my experience debootstrap works very well, though I've never used it for ubuntu on x86 12:51 < wumpus> I 12:52 < achow101> jtimon: sure 12:53 < wumpus> yes, I'm willing to test the docker stuff as well 12:53 < luke-jr> I suppose fixing vmbuilder might be not too unreasonable effort, maybe I will try that :/ 12:53 < wumpus> though I agree iwht luke-jr it's not a long-term solution, can't be used from other platforms, though cfields is still working on his long-term solution I hope 12:54 < cfields> wumpus: yes, very much so. 12:54 < wumpus> great! 12:55 < wumpus> time to wrap up the meeting I think 12:55 < wumpus> unless someone has a quick topic 12:56 < wumpus> #endmeeting 12:56 < lightningbot> Meeting ended Thu Apr 12 19:56:11 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 12:56 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-04-12-19.01.html 12:56 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-04-12-19.01.txt 12:56 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-04-12-19.01.log.html 12:57 < sipa> wumpus: would you like me to not use the lifetime extension of temporaries approach in https://github.com/bitcoin/bitcoin/pull/12803#discussion_r180788539 ? 12:57 < wumpus> sipa: it's fine, I just didn't know about that 12:58 < sipa> it's a feature i knew about for years, but always wondered about it usefulness 12:58 -!- moneyball [~moneyball@65.200.72.90] has quit [Quit: Textual IRC Client: www.textualapp.com] 12:58 < wumpus> well this seems a good reason! 12:59 < sipa> i guess the reasoning was "assigning a temporary to a reference never makes any sense! ok, let's give it another meaning that does make sense then..." 13:01 < promag> that was new to me too, but could drop the reference no? 13:02 < wumpus> I like the fact that this avoids having to export the type 13:03 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has joined #bitcoin-core-dev 13:03 < sipa> promag: no 13:04 < promag> right, doesn't work with base = extended.. 13:04 < promag> see https://github.com/bitcoin/bitcoin/blob/master/src/init.cpp#L90-L92 13:04 < promag> sipa: could use your approach there right? 13:04 < promag> and turn g_wallet_init_interface to a reference instead? 13:04 < sipa> if we write it as "const BaseSignatureCreator dummy_creator = DummySignatureCreator()", a DummySignatureCreator object is created, but then *assigned* (using operator=) to a BaseSignatureCreator object which is exported 13:05 < sipa> rather than exporting the DummySignatureCreator object itself (with a hidden type) 13:05 < sipa> hmm, perhaps 13:05 < wumpus> it will get sliced 13:06 < wumpus> if you don't make it a reference or pointer 13:06 < promag> I'll try the same with g_wallet_init_interface, don't think a pointer is good for such "central" instances 13:07 < wumpus> and a pointer would have the problem of needing a scoped ptr etc 13:07 < jonasschnelli> cfields: iptables -t nat -A POSTROUTING -o eth0 -j MASQUERADE was missing... 13:07 < cfields> jonasschnelli: aha :) 13:07 < promag> wumpus: not true, see https://github.com/bitcoin/bitcoin/blob/master/src/init.cpp#L90-L91 workaround 13:08 < wumpus> promag: why would that be any better though? 13:08 < wumpus> also the initialization/freeing order is less clear that way 13:08 < promag> I'm§ ~ 13:08 < promag> \ 13:08 < promag> ops, cat.. 13:09 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has quit [Quit: probably someone interrupted me] 13:09 < promag> wumpus: not saying it's better, I prefer sipa approach 13:10 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has quit [Ping timeout: 265 seconds] 13:10 < wumpus> ok, sorry, I misunderstood you then 13:11 -!- goatpig [56f75164@gateway/web/freenode/ip.86.247.81.100] has quit [Ping timeout: 260 seconds] 13:22 -!- laurentmt [~Thunderbi@62.112.9.237] has quit [Quit: laurentmt] 13:29 -!- promag [~promag@204.247.61.94.rev.vodafone.pt] has quit [Remote host closed the connection] 13:32 < cfields> sipa: fyi, since you were looking at it earlier... on my slow (mac) laptop, the coin_selection tests spend half of their time formatting the date/time string for the debug print in AddToWallet() 13:32 < cfields> wouldn't surprise me if that's even more painful via Wine 13:34 -!- Randolf [~randolf@S01061cabc0a6f093.vc.shawcable.net] has joined #bitcoin-core-dev 13:34 < sipa> heh 13:36 < wumpus> whoops 13:36 -!- instagibbs [~instagibb@pool-100-15-128-78.washdc.fios.verizon.net] has joined #bitcoin-core-dev 13:41 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 13:43 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 13:46 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 13:47 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 13:48 < bitcoin-git> [bitcoin] Empact opened pull request #12969: Drop dead code CScript::Find (master...cscript-find) https://github.com/bitcoin/bitcoin/pull/12969 13:49 -!- anome [~anome@unaffiliated/anome] has quit [] 13:50 -!- Murch [~murch@96.74.120.81] has quit [Quit: Snoozing.] 13:50 -!- Murch [~murch@96.74.120.81] has joined #bitcoin-core-dev 13:51 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 256 seconds] 13:55 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has joined #bitcoin-core-dev 13:56 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/39439e5ab419...8480d41e0f9d 13:56 < bitcoin-git> bitcoin/master 190b8d2 Pieter Wuille: Make BaseSignatureCreator a pure interface 13:56 < bitcoin-git> bitcoin/master be67831 Pieter Wuille: Make DummySignatureCreator a singleton 13:56 < bitcoin-git> bitcoin/master 8480d41 Wladimir J. van der Laan: Merge #12803: Make BaseSignatureCreator a pure interface... 13:57 < bitcoin-git> [bitcoin] laanwj closed pull request #12803: Make BaseSignatureCreator a pure interface (master...201803_puresignaturecreator) https://github.com/bitcoin/bitcoin/pull/12803 14:04 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 14:07 < cfields> whoa 14:07 < cfields> Leaving test case "knapsack_solver_test"; testing time: 358694ms 14:07 < cfields> i386 + old wine ^^ 14:07 < cfields> Leaving test case "knapsack_solver_test"; testing time: 6781ms 14:07 < cfields> ^^ same, but with the LogPrint commented out 14:08 -!- DMTcrypto [~user@162.251.236.6] has quit [Ping timeout: 260 seconds] 14:08 < wumpus> now that's optimization 14:09 < wumpus> but I don't get it, it's the unit test, aren't all logging categories disabled? 14:09 < cfields> so, there's the recent huge slowdown. Probably also addressed in newer wine, hence the speedup in 12931 14:10 < cfields> wumpus: it's a LogPrintf :( 14:10 < wumpus> should it be in a debug category? sounds like an extremly high volume one 14:11 < cfields> wumpus: I think that test just hits it really hard 14:12 < cfields> it'd be nice to have an explicit no-logging option for these tests, though 14:13 < wumpus> if both log-to-file and log-to-console is disabled, it should probably bypass all logging 14:14 < wumpus> even without category 14:15 < jnewbery> I think #11862 is now in really good shape (and is well structured and easy to review). Perhaps concept ACKers (jonasschnelli, meshcollider, jtimon) could do some review? 14:15 < gribble> https://github.com/bitcoin/bitcoin/issues/11862 | Network specific conf sections by ajtowns · Pull Request #11862 · bitcoin/bitcoin · GitHub 14:16 < wumpus> so should that one be in high priority for review? 14:19 < jtimon> jnewbery: I think aj is right here https://github.com/bitcoin/bitcoin/pull/11862#issuecomment-379061898 and if not it should be solvable in the other pr after rebase, but I will try to upgrade the concept ack to an ut ack or tested ack 14:19 < jnewbery> it's not super important and doesn't block anything, so doesn't really fit high priority. But it has been around for a while and I think it's a well-structured easy review 14:20 < jnewbery> I'd like to make some progress on config model. There have been a bunch of PRs around for months 14:20 < jtimon> yeah, I had a glance with the concept ack, should have another look 14:21 < jnewbery> #10267 is another one, but I think that should rebase on 11862, since 11862 seems like it's closer to merge 14:21 < gribble> https://github.com/bitcoin/bitcoin/issues/10267 | New -includeconf argument for including external configuration files by kallewoof · Pull Request #10267 · bitcoin/bitcoin · GitHub 14:21 -!- DMTcrypto [~user@162.251.236.8] has joined #bitcoin-core-dev 14:22 < jnewbery> jtimon: I don't think this interacts badly with your 8994, so it shouldn't be blocked 14:23 -!- niftynei [875484e0@gateway/web/freenode/ip.135.84.132.224] has joined #bitcoin-core-dev 14:23 -!- niftynei [875484e0@gateway/web/freenode/ip.135.84.132.224] has quit [Client Quit] 14:23 < jtimon> no, not at all, I think it interacts pretty well, and that's the part of the pr that I reviewed, just asked for confirmation from the author 14:24 < jtimon> and even if it implied a little bit more work on #8994 I don't think that's a blocking reason anyway 14:24 < gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub 14:24 < jtimon> but I think it doesn't 14:25 < jnewbery> great! 14:25 < jtimon> btw, I'm not rebasing #8994 very often because I think there's a few open questions I left that haven't been answered 14:25 < gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub 14:27 < bitcoin-git> [bitcoin] theuni opened pull request #12970: logging: bypass timestamp formatting when not logging (master...slow-tests) https://github.com/bitcoin/bitcoin/pull/12970 14:27 < jtimon> in particular, is it ok to change regtest's genesis block? if so, all those changes to the python tests that always require rebase wouldn't be needed or could be done later, perhaps while introducting new more intresting tests like making sure regtest and testest2 disconnect from each other and stuff like that 14:28 < jtimon> perhaps a topic for another meeting 14:31 -!- niftynei [~niftynei@135.84.132.224] has joined #bitcoin-core-dev 14:33 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:33 < wumpus> preferably that'd be avoided, as it makes it impossible to have a regtest with two different versions of bitcoind 14:35 -!- cheese_ [Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Ping timeout: 240 seconds] 14:36 < jtimon> wumpus: ok, thanks but moving all the python tests to custom/regtest2 is fine, right? 14:37 < wumpus> why? 14:37 < jtimon> ok, I think there's 2 parts to this PR, perhaps I should separate them 14:38 < wumpus> but, no, I don't think it's problematic to move th tests to a different kind of chain, though I'm not sure I see why 14:38 < jtimon> one is having custom params, but that can be done in regtest without changing the genesis block 14:38 < wumpus> for the existing tests, the current params don't need to be changed? 14:39 -!- Randolf [~randolf@S01061cabc0a6f093.vc.shawcable.net] has quit [Ping timeout: 240 seconds] 14:39 -!- Murch [~murch@96.74.120.81] has quit [Quit: Snoozing.] 14:39 < jtimon> the sencond is introducing the -chain option, which allows you to create new regtests (well, custom chains) on demand which have different genesis blocks (well, you just need to use a different name on -chain=mycustomchain) 14:40 < jtimon> right, but this opens the door to new tests 14:40 -!- Murch [~murch@96.74.120.81] has joined #bitcoin-core-dev 14:41 < jtimon> to me, the second part is more interesting, but I now think that I should probably separate them (since many people seem confused about the purpose) 14:42 < jtimon> wumpus: does that make sense to you? (or at least one of the parts) 14:42 < wumpus> yes for new tests that make use of different parameters it'd make sense 14:43 < jtimon> another recurrent topic is whether the custom params should be loaded from conf and the regular gArgs or only from an independent file 14:44 < jtimon> well, I think one point of the custom params is to avoid things like https://github.com/bitcoin/bitcoin/blob/master/src/chainparams.cpp#L382 for testing perhaps I should start with that 14:45 < wumpus> I'd say regular args would add too many arguments 14:45 < wumpus> this is only meant for testing, after all, so by far most will have no business overriding chain parameters 14:47 < jtimon> similar things have been proposed multiple times for specific fields, and also an NonConstParams() with individual sets for everything, I think this is "the right way" for any such tests 14:47 -!- Cogito_Ergo_Sum [~Myself@athedsl-314680.home.otenet.gr] has joined #bitcoin-core-dev 14:47 -!- Cogito_Ergo_Sum [~Myself@athedsl-314680.home.otenet.gr] has quit [Changing host] 14:47 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev 14:47 < jtimon> this would only override params for regtest and/or customchain, of course 14:48 < jtimon> CMainParams should not have an UpdateFromArgs method 14:50 < jtimon> anyway, I'm fine with a separate file, I think that's what I implemented first, but I thought it was confusing people and left it for later 14:51 < jtimon> or someone preferred regular args and conf file, I don't remember 14:52 < jtimon> wumpus: thanks for the feedback, so what do you think about separating it in 2? which part you think makes the most sense? 14:52 < jtimon> or can be more useful for tests we lack 15:03 < wumpus> yes, I think that makes sense 15:04 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 15:04 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 15:05 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev 15:12 < instagibbs> listtransactions should list all transactions the wallet is involved in, yes? Including self-sends? 15:13 < instagibbs> sorry if #bitcoin, just getting odd results and help isn't clear 15:13 < sipa> yes 15:15 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 15:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds] 15:24 < instagibbs> thanks 15:34 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 15:34 -!- rls [~rls@2600:8800:1e00:9e1:d857:33c2:2e56:ea32] has joined #bitcoin-core-dev 15:38 -!- rls0 [~rls@67.215.10.250] has quit [Ping timeout: 264 seconds] 15:41 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has quit [] 15:44 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-qmzmumvyogyuavoj] has joined #bitcoin-core-dev 15:45 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 15:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 15:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 15:46 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 15:46 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 15:51 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 15:58 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 16:01 -!- Randolf [~randolf@S01061cabc0a6f093.vc.shawcable.net] has joined #bitcoin-core-dev 16:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 16:05 -!- Randolf [~randolf@S01061cabc0a6f093.vc.shawcable.net] has quit [Ping timeout: 240 seconds] 16:06 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 16:08 < drexl> why does a scriptcode start with a PUSH byte? is it supposed to be pushed on the stack? 16:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Read error: Connection reset by peer] 16:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 16:11 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev 16:22 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Read error: Connection reset by peer] 16:22 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 16:23 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Max SendQ exceeded] 16:24 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 16:33 -!- Murch [~murch@96.74.120.81] has quit [Quit: Snoozing.] 16:34 -!- vydjz88 [~wllps@189.76.82.251] has joined #bitcoin-core-dev 16:38 -!- vydjz88 [~wllps@189.76.82.251] has quit [Remote host closed the connection] 16:39 -!- isis_ is now known as isis 16:42 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 16:45 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-ylbryioaazebtock] has quit [Quit: Connection closed for inactivity] 16:48 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Read error: Connection reset by peer] 16:55 -!- yjednmgz [~eltuprag@2a03:b0c0:1:d0::e0:4001] has joined #bitcoin-core-dev 16:57 -!- yjednmgz [~eltuprag@2a03:b0c0:1:d0::e0:4001] has quit [Remote host closed the connection] 17:00 -!- weez17 [~isaac@unaffiliated/weez17] has quit [Remote host closed the connection] 17:00 -!- weez17 [~isaac@unaffiliated/weez17] has joined #bitcoin-core-dev 17:02 -!- niftynei [~niftynei@135.84.132.224] has quit [Ping timeout: 264 seconds] 17:07 < bitcoin-git> [bitcoin] TheCharlatan opened pull request #12971: Ugrade Qt depends to Qt5.9.4 (master...Qt59) https://github.com/bitcoin/bitcoin/pull/12971 17:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 17:11 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 17:23 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 17:25 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 17:26 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 17:28 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Quit: drexl] 17:40 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has quit [Quit: probably someone interrupted me] 17:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:44 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 256 seconds] 17:49 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 17:50 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has joined #bitcoin-core-dev 18:13 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 276 seconds] 18:13 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-qmzmumvyogyuavoj] has quit [Quit: Connection closed for inactivity] 18:22 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has quit [Quit: probably someone interrupted me] 18:26 < bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/8480d41e0f9d...4ba6da55743a 18:26 < bitcoin-git> bitcoin/master 45dd135 Pieter Wuille: Fix csBestBlock/cvBlockChange waiting in rpc/mining 18:26 < bitcoin-git> bitcoin/master 4a6c0e3 Pieter Wuille: Modernize best block mutex/cv/hash variable naming 18:26 < bitcoin-git> bitcoin/master 4ba6da5 Pieter Wuille: Merge #12743: Fix csBestBlock/cvBlockChange waiting in rpc/mining... 18:26 < bitcoin-git> [bitcoin] sipa closed pull request #12743: Fix csBestBlock/cvBlockChange waiting in rpc/mining (master...201803_waitblockchange) https://github.com/bitcoin/bitcoin/pull/12743 18:35 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4ba6da55743a...5df84de583c9 18:35 < bitcoin-git> bitcoin/master 339730a Cory Fields: logging: bypass timestamp formatting when not logging... 18:35 < bitcoin-git> bitcoin/master 5df84de Pieter Wuille: Merge #12970: logging: bypass timestamp formatting when not logging... 18:36 < bitcoin-git> [bitcoin] sipa closed pull request #12970: logging: bypass timestamp formatting when not logging (master...slow-tests) https://github.com/bitcoin/bitcoin/pull/12970 18:38 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has joined #bitcoin-core-dev 18:40 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 264 seconds] 18:52 -!- Ge0rges [~Ge0rges@104.236.151.200] has left #bitcoin-core-dev ["Textual IRC Client: www.textualapp.com"] 18:53 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 18:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:56 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:58 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 19:08 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 19:20 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has quit [Quit: probably someone interrupted me] 19:27 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 19:30 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has joined #bitcoin-core-dev 19:32 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has quit [Remote host closed the connection] 19:33 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 19:33 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has joined #bitcoin-core-dev 19:34 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has quit [Ping timeout: 240 seconds] 19:43 -!- zautomata2 [~zautomata@41.239.49.73] has quit [Ping timeout: 264 seconds] 19:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 19:48 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 19:50 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 19:51 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 19:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds] 20:05 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 20:06 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 20:06 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 20:09 -!- Samdney [~Samdney@178.162.209.134] has quit [Read error: Connection reset by peer] 20:21 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 265 seconds] 20:22 -!- sayo-822 [~bcicsz@177.91.215.239] has joined #bitcoin-core-dev 20:25 -!- sayo-822 [~bcicsz@177.91.215.239] has quit [Remote host closed the connection] 20:27 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 20:34 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.] 20:34 -!- HR3IECgvvg__ [~fyycpui@user-24-214-133-12.knology.net] has joined #bitcoin-core-dev 20:37 -!- HR3IECgvvg__ [~fyycpui@user-24-214-133-12.knology.net] has quit [Remote host closed the connection] 20:43 < bitcoin-git> [bitcoin] ken2812221 opened pull request #12972: trivial: Use python3 explicitly (master...explicit_python3) https://github.com/bitcoin/bitcoin/pull/12972 20:50 -!- hexa-fr [~aqrkulzf@177.220.233.26] has joined #bitcoin-core-dev 20:52 -!- hexa-fr [~aqrkulzf@177.220.233.26] has quit [Remote host closed the connection] 21:03 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has joined #bitcoin-core-dev 21:09 -!- joltkq [~oczue@116.97.87.236] has joined #bitcoin-core-dev 21:11 -!- joltkq [~oczue@116.97.87.236] has quit [Remote host closed the connection] 21:40 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 276 seconds] 21:43 -!- go1111111 [go1111111@gateway/vpn/privateinternetaccess/go1111111] has quit [Quit: Leaving] 21:43 -!- go1111111 [go1111111@gateway/vpn/privateinternetaccess/go1111111] has joined #bitcoin-core-dev 21:47 -!- go1111111 [go1111111@gateway/vpn/privateinternetaccess/go1111111] has quit [Ping timeout: 265 seconds] 21:51 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 22:03 -!- go1111111 [~go1111111@199.231.240.191] has joined #bitcoin-core-dev 22:04 -!- jarthur [~jarthur@2605:6000:1019:42b6:cc93:2c8:48c1:7a45] has joined #bitcoin-core-dev 22:32 < bitcoin-git> [bitcoin] sipa opened pull request #12973: Avoid std::locale/imbue madness in DateTimeStrFormat (master...201804_noimbue) https://github.com/bitcoin/bitcoin/pull/12973 22:43 -!- lemonwater1000 [~lemonwate@mo1-77-219-239.air.mopera.net] has joined #bitcoin-core-dev 22:45 -!- isis [~isis@abulafia.patternsinthevoid.net] has quit [Ping timeout: 264 seconds] 22:49 -!- lemonwater1000 [~lemonwate@mo1-77-219-239.air.mopera.net] has quit [Remote host closed the connection] 22:55 -!- lemonwater1000 [~lemonwate@mo1-77-219-239.air.mopera.net] has joined #bitcoin-core-dev 22:58 -!- isis [~isis@abulafia.patternsinthevoid.net] has joined #bitcoin-core-dev 22:58 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Plugging out.] 23:07 < jonasschnelli> Odroid XU4 with SSD (via USB) took already 12h for height 416292 progress=0.426028 23:08 < jonasschnelli> CPU could be used more... rarely goes over 130%. Maybe this changes when blocks get bigger 23:16 -!- lemonwater1000 [~lemonwate@mo1-77-219-239.air.mopera.net] has quit [Remote host closed the connection] 23:17 -!- goatpig [56f75164@gateway/web/freenode/ip.86.247.81.100] has joined #bitcoin-core-dev 23:23 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has quit [Quit: probably someone interrupted me] 23:25 < sipa> jonasschnelli: past the assumevalid point CPU usage will go up 23:33 < jonasschnelli> sipa: you mean skip verification for blocks in 2016 (or even until later) with assumevalid set to some block in early 2017? 23:45 -!- weez17 [~isaac@unaffiliated/weez17] has quit [Remote host closed the connection] 23:45 -!- weez17 [~isaac@unaffiliated/weez17] has joined #bitcoin-core-dev 23:55 -!- jarthur [~jarthur@2605:6000:1019:42b6:cc93:2c8:48c1:7a45] has quit []