--- Day changed Thu Apr 26 2018
00:05 -!- Sinclair_ [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has quit [Ping timeout: 276 seconds]     
00:08 < wumpus> unicorns farmed: 1.5 octodecillion
00:08 < wumpus> Randolf: a cat that is an unicorn too? is this heaven?
00:14 < sipa> wth?
00:15 < wumpus> github is working fine for me again, was another hiccup, though they do become awfully common
00:16 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
00:17 < wumpus> moving the repository would be fairly easy but all the issue managment...
00:17 < wumpus> can't see this working better with e.g. trac
00:18 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
00:20 < meshcollider> We could move back to sourceforge ;)
00:20 < kallewoof> Version control is overrated. Let's just email patches to the ML.
00:21 < kallewoof> wumpus will sort it out
00:21 < wumpus> kallewoof: I know you're sarcastic but that's how mesa/freedesktop still works, and it works ok, and they have much more patch traffic than us
00:21 < wumpus> (also way more committers though...)
00:22 < kallewoof> I'm amazed that it works ok. But I actually said it because I recall patches being tossed around on some mailing list some years ago.
00:22 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
00:22 < luke-jr> I suspect they don't have the same review standards we do
00:23 < wumpus> eh they do use git, it's not *instead* of source control, but I mean source patches are posted to the ML for review, testing etc
00:23 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has joined #bitcoin-core-dev     
00:23 < wumpus> luke-jr: that's true, the source code is also very compartimentalized, with reviewers for specific drivers and parts
00:24 < wumpus> and if you post a patch you *need* to CC: the right people otherwise it will never get picked up
00:24 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 265 seconds]     
00:24 -!- vexbuy_ [~vexbuy@46.166.142.214] has quit [Remote host closed the connection]     
00:25 < wumpus> no one reads everything on the entire ML
00:25 < wumpus> anyhow no that's not a good fit for bitcoin core...
00:30 < wumpus> meshcollider: I don't understand how they managed to make sourceforge such a mess, I don't hope that's the future for github
00:31 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev     
00:32 < meshcollider> Ugh I know :( 
00:33  * fanquake plans on attending the dev meeting tonight
00:33 < wumpus> fanquake: great!
00:34 < fanquake> wumpus Sorry for lack of review over the past few days, been very busy. Should be back to normal tomorrow/saturday
00:34  * sipa was briefly worried with "dev meeting tonight" thinking i missed something
00:35 < wumpus> fanquake: no problem, we all need a break sometimes, and I think even with that you've been more active than most of us :-)
00:35 < jonasschnelli> indeed
00:35 < wumpus> ah yes the 
00:35 < sipa> it's past midnight here, and the meeting is at noon
00:35 < wumpus> 'tonight' part must confuse some people
00:36 -!- CubicEarths [~cubiceart@xdsl-188-155-63-9.adslplus.ch] has joined #bitcoin-core-dev     
00:37 < jonasschnelli> fanquake: but wait: the meeting is 3am for you? right
00:38 < fanquake> jonasschnelli correct, and it's 3:37pm here right now.
00:38  * jonasschnelli will soon hand over the "attended-IRC-meeting-in-the-middle-of-the-night" medal to fanquake
00:39 < jonasschnelli> I also did that in Indonesia... but mixed up the timezones.. woke up 3am and was one hour to early. 
00:41 < sipa> we should have meetings at every hour for which doubleSHA256(unix_timestamp) < 2^256 / 168
00:41 < jonasschnelli> I guess you would be the only one who shows up on time sipa 
00:41 < sipa> that would at least be maximally inconvenient for everyone equally
00:41 < sipa> jonasschnelli: lol, you don't know me
00:42 < fanquake> heh     
00:43 < wumpus> randomized time-hopping meeting time allocation
00:44 < jonasschnelli> the hopping-formula should also include a probability-shift depending on last meeting-attendees timezones and expected sleep-times.
00:45 < fanquake> Entry and exit via wormhole only
00:47 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection]     
00:47 < wumpus> jonasschnelli: that wouldn't maximimize inconvenience for everyone anymore
00:48 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev     
00:48 < wumpus> fanquake: yes if it wasn't for IRC it'd have to be in a random location in space, too...
00:49 < wumpus> jonasschnelli: ideally there would be some factor (like a measurement or something that is unpredictable) that gets introduced last minute, so that it's not possible to plan ahead either
00:52 < fanquake> wupus amount of time since any GitHub PR has 404'd for you
00:52 < fanquake> *wumpus
00:52 < jonasschnelli> Heh. fanquake: can you not just move to Europe or US, it seems to be less complicated. :)
00:52 < jonasschnelli> Or do we have other non EU/US devs/timezones that want to participate at the meeting?
00:53 < wumpus> fanquake: a very long time ago, these days it's usually timeouts
00:53 < wumpus> fanquake: you're referring to disappearing issue issues?
00:54 < fanquake> wumpus yes, and using that as your unpredictable factor ^
00:54 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds]     
00:55 < fanquake> jonasschnelli sure, if I can find somewhere to sleep in the US ;)
00:55 < wumpus> fanquake: iterating the issue numbers then storing the pattern of 404 'memory holes', yes good idea
00:55 < wumpus> github is sufficiently unpredictable at least...
01:00 < wumpus> SHA256(SHA256(unix_timestamp) | num_unicorns) < 2^256 / 168
01:01 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a07e8caa5d50...646b7f6abe73
01:01 < bitcoin-git> bitcoin/master fad2958 MarcoFalke: [doc] build-windows: Switch to Artful, since Zesty is EOL
01:01 < bitcoin-git> bitcoin/master 646b7f6 Wladimir J. van der Laan: Merge #12997: [doc] build-windows: Switch to Artful, since Zesty is EOL...
01:02 < bitcoin-git> [bitcoin] laanwj closed pull request #12997: [doc] build-windows: Switch to Artful, since Zesty is EOL (master...Mf1804-docBuildWinArtful) https://github.com/bitcoin/bitcoin/pull/12997
01:04 < jonasschnelli> wumpus: lol
01:06 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev     
01:07 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev     
01:07 < wumpus> fanquake: I guess europe is an even longer trip for you than the US?
01:08 < wumpus> we could also all just move to Australia
01:08 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev     
01:08 < fanquake> ^ I heard that's the place for the next dev meetups anyways
01:10 < jonasschnelli> fanquake: I guess because this years SB is in Tokyo, the next dev meetup will be there..
01:12 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev     
01:13 < fanquake> jonasschnelli Syd/Melb would be ok. I'd suggest Perth to save myself a flight but there isn't much happening here..
01:13 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
01:13 < jonasschnelli> fanquake: Perth has better weather. :)
01:14 < jonasschnelli> (usually)
01:14 < fanquake> jonasschnelli Core-Dev @ the beach heh
01:14 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
01:14 < wumpus> hehe
01:18 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev     
01:18 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 240 seconds]     
01:28 < luke-jr> I have a beach here
01:28 -!- drizztbsd [~tredaelli@redhat/timothy] has quit [Ping timeout: 240 seconds]     
01:29 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev     
01:30 < wumpus> jnewbery: great to see so much progress on account deprecation re: #13075, should we create an issue to track the importprunedfunds issue?
01:30 < gribble> https://github.com/bitcoin/bitcoin/issues/13075 | Remove account API from wallet functional tests by jnewbery · Pull Request #13075 · bitcoin/bitcoin · GitHub
01:30 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has quit [Quit: zarez]     
01:30 < wumpus> luke-jr: but you're not in australia!
01:31 -!- zarez [~Thunderbi@93.93.44.38] has joined #bitcoin-core-dev     
01:33 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev     
01:34 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 256 seconds]     
01:36 < luke-jr> :p     
01:46 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-fxhkbjskipskffww] has joined #bitcoin-core-dev     
01:58 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev     
02:00 -!- herzmeister[m] [herzmeiste@gateway/shell/matrix.org/x-tfjoaiduchifovru] has joined #bitcoin-core-dev     
02:00 -!- ajtowns[m] [ajtownsmat@gateway/shell/matrix.org/x-avoqadequuiqbynz] has joined #bitcoin-core-dev     
02:00 -!- squarfed[m] [squarfedma@gateway/shell/matrix.org/x-tfinnkiqmbedmjyq] has joined #bitcoin-core-dev     
02:00 -!- stepa[m] [stepamatri@gateway/shell/matrix.org/x-iaqndyxwouliwnfw] has joined #bitcoin-core-dev     
02:00 -!- joshb[m] [joshbmatri@gateway/shell/matrix.org/x-kyswdjrwxuaamppp] has joined #bitcoin-core-dev     
02:00 -!- griswaalt[m] [griswaaltm@gateway/shell/matrix.org/x-fffqdhlzrzmcddby] has joined #bitcoin-core-dev     
02:00 -!- Masaomi[m] [masaomimat@gateway/shell/matrix.org/x-yeublhcfgqhjtijw] has joined #bitcoin-core-dev     
02:10 < promag> I think #13028 is merge ready, but lacking some acks..
02:10 < gribble> https://github.com/bitcoin/bitcoin/issues/13028 | Make vpwallets usage thread safe by promag · Pull Request #13028 · bitcoin/bitcoin · GitHub
02:21 -!- vicenteH [~user@123.red-83-58-239.dynamicip.rima-tde.net] has joined #bitcoin-core-dev     
02:22 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 255 seconds]     
02:26 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev     
02:32 -!- drizztbsd is now known as timothy     
02:34 < aj> fanquake: there's a lightning dev summit in Adelaide, Nov 8th/9th!
02:35 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev     
02:37 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev     
02:38 < fanquake> aj cool. Is there some info about it somewhere?
02:38 -!- griswaalt[m] [griswaaltm@gateway/shell/matrix.org/x-fffqdhlzrzmcddby] has quit [Ping timeout: 246 seconds]     
02:39 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Read error: Connection reset by peer]     
02:39 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection]     
02:39 -!- squarfed[m] [squarfedma@gateway/shell/matrix.org/x-tfinnkiqmbedmjyq] has quit [Ping timeout: 246 seconds]     
02:39 -!- stepa[m] [stepamatri@gateway/shell/matrix.org/x-iaqndyxwouliwnfw] has quit [Ping timeout: 240 seconds]     
02:39 -!- Masaomi[m] [masaomimat@gateway/shell/matrix.org/x-yeublhcfgqhjtijw] has quit [Ping timeout: 255 seconds]     
02:39 -!- joshb[m] [joshbmatri@gateway/shell/matrix.org/x-kyswdjrwxuaamppp] has quit [Ping timeout: 240 seconds]     
02:39 -!- herzmeister[m] [herzmeiste@gateway/shell/matrix.org/x-tfjoaiduchifovru] has quit [Ping timeout: 256 seconds]     
02:40 -!- ajtowns[m] [ajtownsmat@gateway/shell/matrix.org/x-avoqadequuiqbynz] has quit [Ping timeout: 256 seconds]     
02:40 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-fxhkbjskipskffww] has quit [Ping timeout: 276 seconds]     
02:42 < aj> fanquake: https://lists.linuxfoundation.org/pipermail/lightning-dev/2018-April/001168.html
02:42 < aj> fanquake: followup corrects date in subject:
02:43 -!- laurentmt [~Thunderbi@95.215.61.163] has joined #bitcoin-core-dev     
02:44 -!- laurentmt [~Thunderbi@95.215.61.163] has quit [Client Quit]     
02:51 -!- vexbuy [~vexbuy@89.39.107.194] has joined #bitcoin-core-dev     
02:52 -!- DrFeelGood [~DrFeelGoo@unaffiliated/olufunmilayo] has joined #bitcoin-core-dev     
02:58 < fanquake> aj cheers
03:01 < murrayn> any chance for eyeballs on 
03:01 < murrayn> #12881? After squash it's pretty straightforward, but it's been stuck for weeks.
03:01 < gribble> https://github.com/bitcoin/bitcoin/issues/12881 | Tighten up bech32::Decode(); add tests. by murrayn · Pull Request #12881 · bitcoin/bitcoin · GitHub
03:11 < mryandao> [O/T] is this lightning summit event in Adelaide a public event?
03:13 < mryandao> #12240 has been squashed for months
03:14 < gribble> https://github.com/bitcoin/bitcoin/issues/12240 | [rpc] Introduced a new `fees` structure that aggregates all sub-field fee types denominated in BTC by mryandao · Pull Request #12240 · bitcoin/bitcoin · GitHub
03:14 < aj> mryandao: i imagine you have to be a lightning dev and register first
03:16 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-waeksmlbxqjhcqfp] has joined #bitcoin-core-dev     
03:17 < fanquake> murrayn mryandao can bring both up at the dev meeting. Looks like both are almost ready to go.
03:18 < mryandao> when do the dev meetings happen? does it usually happen while aussies are asleep?
03:20 < fanquake> mryandao https://bitcoincore.org/en/meetings/ It is late night here yes
03:22 < mryandao> i think i'll call it a night and wake up later then. kek
03:28 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
03:29 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
03:29 -!- herzmeister[m] [herzmeiste@gateway/shell/matrix.org/x-otmpeqnkizxvwcza] has joined #bitcoin-core-dev     
03:29 -!- ajtowns[m] [ajtownsmat@gateway/shell/matrix.org/x-lakeodvzmvcgyfqv] has joined #bitcoin-core-dev     
03:29 -!- stepa[m] [stepamatri@gateway/shell/matrix.org/x-kbamxtzciyaermsn] has joined #bitcoin-core-dev     
03:29 -!- joshb[m] [joshbmatri@gateway/shell/matrix.org/x-fzzqinommccztymf] has joined #bitcoin-core-dev     
03:29 -!- squarfed[m] [squarfedma@gateway/shell/matrix.org/x-ntregtlxwrjakbxg] has joined #bitcoin-core-dev     
03:29 -!- sipa [~pw@unaffiliated/sipa1024] has quit [Ping timeout: 245 seconds]     
03:29 -!- griswaalt[m] [griswaaltm@gateway/shell/matrix.org/x-oqhlequpxwqzsiko] has joined #bitcoin-core-dev     
03:29 -!- Masaomi[m] [masaomimat@gateway/shell/matrix.org/x-kglyrilavmlrsrci] has joined #bitcoin-core-dev     
03:30 -!- sipa [~pw@2001:19f0:ac01:2fb:5400:ff:fe5b:c3ff] has joined #bitcoin-core-dev     
03:36 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/646b7f6abe73...6f8b3453f8a3
03:36 < bitcoin-git> bitcoin/master 7de1de7 mryandao: Add new fee structure with all sub-fields denominated in BTC
03:36 < bitcoin-git> bitcoin/master 6f8b345 Wladimir J. van der Laan: Merge #12240: [rpc] Introduced a new `fees` structure that aggregates all sub-field fee types denominated in BTC...
03:36 < bitcoin-git> [bitcoin] laanwj closed pull request #12240: [rpc] Introduced a new `fees` structure that aggregates all sub-field fee types denominated in BTC (master...fix-getrawmempool-fee-representation) https://github.com/bitcoin/bitcoin/pull/12240
03:40 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Read error: Connection reset by peer]     
03:40 < promag_> mryandao there you go
03:40 -!- promag_ is now known as promag     
03:41 < mryandao> promag: oh sweet. So I dont have to wake up too early :)
03:42 < promag> but you should
03:42 < promag> dev meetings are fun
03:42 < mryandao> oh man, it'd be 5am when the meeting starts
03:42 < wumpus> if PRs are ready for merge you should just let me know, no need to wait for the meeting
03:43 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
03:43 < promag> wumpus: since you ask #13028
03:43 < gribble> https://github.com/bitcoin/bitcoin/issues/13028 | Make vpwallets usage thread safe by promag · Pull Request #13028 · bitcoin/bitcoin · GitHub
03:47 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection]     
03:47 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
03:48 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev     
03:50 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev     
03:50 < wumpus> promag: only has one utACK yet
03:50 < wumpus> promag: in some more trivial cases that's enough, but changes around threading are pretty risky
03:51 < mryandao> i've been curious, why does core perfer C stdlib over C++ stdlib?
03:52 < wumpus> just a historical thing, it doesn't matter right?
03:52 < wumpus> it's just not worth wasting cycles on imo
03:52 < mryandao> i was just curious. I thought it had to do with performance
03:52 < wumpus> eh, I think you're talking about something else than me
03:52 < wumpus> I thought you meant include style eg. #include <stdio.h> instead fo #include <cstdio>
03:53 < wumpus> not sure what you mean now
03:53 < mryandao> oh no. why fprintf as oppose to just <<
03:53 < mryandao> as an example
03:53 < wumpus> << is used in some places, for example the wallet dumping
03:54 < wumpus> yes, for logging printf/fprintf is used, but that's the only thing AFAIK
03:55 < wumpus> there's a huge list of standard library functions that should be avoided, or at least used very carefully because they're locale dependent (see #13041)
03:55 < gribble> https://github.com/bitcoin/bitcoin/issues/13041 | build: Add linter checking for accidental introduction of locale dependence by practicalswift · Pull Request #13041 · bitcoin/bitcoin · GitHub
03:56 < mryandao> there's another thing I wanted to address, which is core blowing up when debuglog is set to /dev/stdout because it tries to do a shrink
03:57 < wumpus> eh definitely don't set it to a non-file
03:57 < wumpus> you can do -printtostdout you know that right?
03:57 < luke-jr> I thoguht it was -printtoconsole
03:57 < mryandao> no I didnt. Now I do.
03:57 < wumpus> printtoconsole, yes
03:57 < mryandao> printtoconsole, i know all along
03:58 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 255 seconds]     
03:58 < wumpus> if you really want to log to a device that is not a file, you can use -printtoconsole and pipe it to that. It'd be possible to add detection of special devices to the logging code, of course, and skip the shrink step...
03:59 < wumpus> but that'd be OS dependent at least
03:59 < mryandao> I was using core in a docker container, that's why I wanted to log to a file
03:59 < mryandao> s/file/device/
03:59 < wumpus> e.g. windows has a completely different convention for devices than unix
03:59 < mryandao> and i couldnt use a pipe redirect because I wanted to allow appending of more flags as needed
04:01 < wumpus> I don't understand that reasoning
04:01 -!- zautomata2 [~zautomata@41.232.199.208] has joined #bitcoin-core-dev     
04:01 < wumpus> then again, I don't know anything about docker
04:03 -!- zautomata1 [~zautomata@41.232.194.48] has quit [Ping timeout: 260 seconds]     
04:04 < mryandao> do windows users even use Core on commandline?
04:04 < mryandao> i'd expect their usage behaviour to be just running the GUI client
04:05 < wumpus> yes, surprisingly many do, even macosx users use bitcoind
04:06 < wumpus> hard to believe but windows is also used for servers
04:06 < fanquake> Maybe even more surprising given I thought it was our least tested OS
04:08 < wumpus> it's mostly hard to troubleshoot errors
04:08 < wumpus> on linux or osx you can just run the thing in gdb and get a backtrace... good luck with anything like that on windows
04:09 < fanquake> Atleast you can download a Windows 10 "Dev" VM for free and throw it straight into virtualbox. Makes some testing slightly easier
04:09 < wumpus> yes,you can use gdb on windows but it's a nightmare, and yes, other debuggers exist, but they all manage to be incompatible with mingws symbol format
04:10 < fanquake> Still a bit absurd that I'm just about running 3 OSs to build and test a windows binary though
04:11 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev     
04:11 < wumpus> it's interesting how much advances microsoft is making toward linux, I really hope win32 will disappear on the long run and it will be another POSIX-ish OS like macosx
04:12 < wumpus> pretty much everything else in the world is
04:15 < fanquake> wumpus did you want to merge #12384 even though it still has the formatting changes 
04:15 < gribble> https://github.com/bitcoin/bitcoin/issues/12384 | [Docs] Add version footnote to tor.md by Willtech · Pull Request #12384 · bitcoin/bitcoin · GitHub
04:15 < fanquake> Not quite sure why there are <a></a> tags being used
04:16 -!- goatpig [56f75200@gateway/web/freenode/ip.86.247.82.0] has joined #bitcoin-core-dev     
04:16 -!- vexbuy [~vexbuy@89.39.107.194] has quit [Ping timeout: 256 seconds]     
04:18 < wumpus> fanquake: I hate that PR...
04:19 < wumpus> (that's why I ignore it, maybe I should just close it)
04:19 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-bbultnlfdgblsowd] has quit [Quit: Connection closed for inactivity]     
04:20 < fanquake> wumpus heh I remember from ny. I can split out the actual change if you'd like it in. Dropping the other stuff.
04:20 < wumpus> tried to have a reasonable discussion with the guy but it just isn't dawn on him, and it doesn't make sense to make format changes at the same time, certainly not ones that I disgaree with in the first place
04:21 < wumpus> though he means well, I'm sure, which is why I haven't really confronted him I guess...
04:21 < wumpus> his whole point is that "torcontrol" works from version 0.2.7.0 and higher
04:22 < wumpus> if that was the whole of the change I'd be happy with it
04:22 < wumpus> what he's trying to bring into it is that manually setting up the tor settings is somehow deprecated just because the automatic control exists
04:22 < wumpus> that's just false
04:23 < wumpus> and then some completely random formatting changes on top
04:23 < fanquake> wumpus np. I'll sort something out.
04:23 < wumpus> fanquake: yes, we could do that, at least we can close it then :)
04:24 < promag> fanquake: why is <a></a> even there?
04:25 < fanquake> promag I'm not sure, you definitely don't need it to create links in .md files.
04:25 < wumpus> promag: I think that is to add an anchor, to refer to in the link above it
04:25 < wumpus> promag: sections create auto-anchors though
04:25 < promag> right
04:25 < wumpus> and <a name=""> has been deprecated for a long time in favor of <a id="">
04:26 < fanquake> Is the idea that all "Up for Grabs" labelled can be closed? Given that you can find them using the label?
04:26 < wumpus> but it shouldn't be needed
04:26 < fanquake> *labelled PRs
04:26 < wumpus> fanquake: I think so, yes
04:26 < aj> do up-for-grabs labels get removed when someone grabs them?
04:26 < wumpus> at least if the author is inactive, if they're still working on it it shouldn't have 'up for grabs' in the first place
04:26 < wumpus> aj: hopefully...
04:26 < bitcoin-git> [bitcoin] fanquake closed pull request #13068: tests: Remove unused constant MAX_INV_SZ (master...MAX_INV_SZ) https://github.com/bitcoin/bitcoin/pull/13068
04:27 < fanquake> aj ideally. Same as "Needs backport" being removed after backporting
04:27 < fanquake> At the moment pretty much all needs backporting PRs are taken care of except for one thing in the 0.15 branch
04:29 < fanquake> Which is #11809 if anyone is interested in taking a look
04:29 < gribble> https://github.com/bitcoin/bitcoin/issues/11809 | gui: Fix proxy setting options dialog crash by laanwj · Pull Request #11809 · bitcoin/bitcoin · GitHub
04:31 < wumpus> yes it's one of those 'if we're going to do a 0.15.2 for some reason, that one should be in'
04:34 < fanquake> I wonder if we should be more explicit about "You should probably be building the release.x branch if you are building an older version. Rather than the last release/tag.
04:35 < fanquake> Noticed someone having an issue building 0.15.1 on osx, (bottom of #12009), even though we've backported that fix to the 0.15 branch.
04:35 < gribble> https://github.com/bitcoin/bitcoin/issues/12009 | Cant build on macOS Sierra: likely a boost c++11 error? · Issue #12009 · bitcoin/bitcoin · GitHub
04:35 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-ivxedrdksvndxvcm] has joined #bitcoin-core-dev     
04:35 < wumpus> yes, would make sense to add something about what branch/tag to use to README.md
04:36 < wumpus> also that many people use master while they should be using e.g. the 0.16 branch
04:45 -!- shesek [~shesek@bzq-84-110-234-113.red.bezeqint.net] has joined #bitcoin-core-dev     
04:45 -!- shesek [~shesek@bzq-84-110-234-113.red.bezeqint.net] has quit [Changing host]     
04:45 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev     
04:50 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Remote host closed the connection]     
04:51 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev     
04:55 -!- Samdney [~Samdney@178.162.209.134] has joined #bitcoin-core-dev     
05:00 -!- Samdney [~Samdney@178.162.209.134] has quit [Read error: Connection reset by peer]     
05:00 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev     
05:04 -!- Samdney [~Samdney@178.162.209.140] has joined #bitcoin-core-dev     
05:12 < bitcoin-git> [bitcoin] ajtowns opened pull request #13088: Log early messages with -printtoconsole (master...earlyconsolelog) https://github.com/bitcoin/bitcoin/pull/13088
05:13 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]     
05:21 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev     
05:30 < bitcoin-git> [bitcoin] laanwj closed pull request #12183: Make use of emplace in nonassociative containers. (master...use_emplace) https://github.com/bitcoin/bitcoin/pull/12183
05:33 -!- laurentmt [~Thunderbi@95.215.61.163] has joined #bitcoin-core-dev     
05:33 < bitcoin-git> [bitcoin] laanwj closed pull request #12169: Avoid temporary copies in C++11 ranged-based for loops. (master...remove_loop_implicit_casts) https://github.com/bitcoin/bitcoin/pull/12169
05:33 < bitcoin-git> [bitcoin] laanwj closed pull request #12158: Avoid unnecessary copy of objects. (master...avoid_copies) https://github.com/bitcoin/bitcoin/pull/12158
05:34 -!- cphrmky [~cphrmky@ec2-107-23-237-131.compute-1.amazonaws.com] has joined #bitcoin-core-dev     
05:38 < bitcoin-git> [bitcoin] laanwj closed pull request #12300: [Build] Adding --enable-mainnet configuration option for running mainnet (master...mainnet_chain_config) https://github.com/bitcoin/bitcoin/pull/12300
05:43 < fanquake> wumpus possibly #11231 due to inactivity?
05:43 < gribble> https://github.com/bitcoin/bitcoin/issues/11231 | Improve netaddress implementation by danra · Pull Request #11231 · bitcoin/bitcoin · GitHub
05:44 -!- CubicEarths [~cubiceart@xdsl-188-155-63-9.adslplus.ch] has quit [Remote host closed the connection]     
05:46 < bitcoin-git> [bitcoin] fanquake closed pull request #12152: [WIP] misc. backwards compatibility tests (master...previous-release-segwit-wallet-test) https://github.com/bitcoin/bitcoin/pull/12152
05:50 < wumpus> fanquake: yep
05:50 < bitcoin-git> [bitcoin] laanwj closed pull request #11231: Improve netaddress implementation (master...refactor/safe-netaddress) https://github.com/bitcoin/bitcoin/pull/11231
05:51 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/6f8b3453f8a3...eac067ad5962
05:51 < bitcoin-git> bitcoin/master 4f933b3 fivepiece: p2wpkh, p2wsh and p2sh-nested scripts in decodescript...
05:51 < bitcoin-git> bitcoin/master 41ff967 fivepiece: list the types of scripts we should consider for a witness program
05:51 < bitcoin-git> bitcoin/master eac067a Wladimir J. van der Laan: Merge #12321: p2wsh and p2sh-p2wsh address in decodescript...
05:51 < bitcoin-git> [bitcoin] laanwj closed pull request #12321: p2wsh and p2sh-p2wsh address in decodescript (master...decodescript-p2wsh) https://github.com/bitcoin/bitcoin/pull/12321
05:56 < bitcoin-git> [bitcoin] fanquake closed pull request #11523: [Refactor] CValidation State (master...dos-cleanup) https://github.com/bitcoin/bitcoin/pull/11523
05:59 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
06:00 < bitcoin-git> [bitcoin] fanquake closed pull request #9443: Repairing the large-work fork warning system (master...forkwarning) https://github.com/bitcoin/bitcoin/pull/9443
06:00 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
06:00 < wumpus> also not sure about #10563
06:01 < gribble> https://github.com/bitcoin/bitcoin/issues/10563 | Remove safe mode by achow101 · Pull Request #10563 · bitcoin/bitcoin · GitHub
06:01 < wumpus> asking for rebase again is kind of pointless if we don't know whether to do it
06:01 -!- emzy_ is now known as Emzy     
06:01 < wumpus> (or when, at least)
06:02 < fanquake> agree. Maybe bring it up at the meeting. If there's no "let's do this and we'll review it quite soon" type consensus I think closing for now is fine.
06:03 -!- Emzy [~quassel@raspberry.emzy.de] has quit [Changing host]     
06:03 -!- Emzy [~quassel@unaffiliated/emzy] has joined #bitcoin-core-dev     
06:04 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
06:05 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
06:06 < wumpus> I do agree with the rationale though now
06:06 < wumpus> so I'll remove my concept NACK
06:09 -!- drizztbsd is now known as timothy     
06:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
06:16 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
06:19 -!- vexbuy_ [~vexbuy@46.166.142.214] has joined #bitcoin-core-dev     
06:19 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds]     
06:25 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 264 seconds]     
06:26 -!- molz [~mol@unaffiliated/molly] has quit [Quit: ZNC 1.6.6 - http://znc.in]     
06:35 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev     
06:35 < bitcoin-git> [bitcoin] laanwj opened pull request #13090: Remove Safe mode (rebased) (master...2018_04_remove_safemode_rebased) https://github.com/bitcoin/bitcoin/pull/13090
06:35 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
06:35 < bitcoin-git> [bitcoin] laanwj closed pull request #10563: Remove safe mode (master...rm-safemode) https://github.com/bitcoin/bitcoin/pull/10563
06:35 -!- laurentmt [~Thunderbi@95.215.61.163] has quit [Ping timeout: 268 seconds]     
06:38 -!- laurentmt [~Thunderbi@37.58.58.232] has joined #bitcoin-core-dev     
06:38 -!- twistedline [~quassel@unaffiliated/twistedline] has joined #bitcoin-core-dev     
06:38 -!- twistedline_ [~quassel@unaffiliated/twistedline] has quit [Ping timeout: 264 seconds]     
06:39 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-ivxedrdksvndxvcm] has quit [Quit: Connection closed for inactivity]     
06:40 < fanquake> Spent a good while compiling/installing bitcoin-qt for Windows and the .exe just refuses to run. 0 output at all.
06:42  * kallewoof & the unicorns. Out now.
06:43 < wumpus> fanquake: ugh, those errors are the worst :-(
06:43 < wumpus> later kallewoof
06:43 < kallewoof> wumpus: I was imitating an album, but yeah, am leaving for the day too. :)
06:43 < wumpus> yes I already thought so :)
06:48 -!- CubicEarths [~cubiceart@178.197.231.156] has joined #bitcoin-core-dev     
06:49 < promag> wumpus: how about this one #12151?
06:49 < gribble> https://github.com/bitcoin/bitcoin/issues/12151 | Remove cs_main lock from blockToJSON and blockheaderToJSON by promag · Pull Request #12151 · bitcoin/bitcoin · GitHub
06:55 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 240 seconds]     
06:56 < fanquake> Has anyone else noticed the Windows "SmartScreen" blocks downloading the Windows binary from bitcoincore.org ?
06:56 < fanquake> I can't remember seeing this before.
06:56 < wumpus> me neither
06:56 < wumpus> also never heard about someone else encountering that
06:57 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection]     
06:57 -!- jpe [~jpe@gb-r9-01.pixelpark.net] has quit [Ping timeout: 240 seconds]     
06:58 < fanquake> This is what I'm seeing https://0bin.net/paste/vHiSbOiO39vquNfn#WPo95lp1IycB8zhK9tPbSWwNRFcBtahbymS+aYyIYHU
07:00 < fanquake> However it doesn't block either 32 bit downloads.. Only the 64 bit .zip and .exe 
07:01 < wumpus> certainly seems like some false positive
07:05 -!- instagibbs [~instagibb@pool-100-15-128-78.washdc.fios.verizon.net] has quit [Ping timeout: 264 seconds]     
07:08 -!- instagibbs [~instagibb@pool-100-15-128-78.washdc.fios.verizon.net] has joined #bitcoin-core-dev     
07:09 < fanquake> I think the scanner must toss a coin to decide which message it's going to throw
07:09 < fanquake> https://0bin.net/paste/AwG3Gl69a32wQjQR#CT7E0d5SHrE7kdtYHkAt8glTBA7WOYaIQEXz7oXwWiY
07:09 < fanquake> Apparently the .exe now "contained a virus".
07:13 -!- CubicEarths [~cubiceart@178.197.231.156] has quit [Remote host closed the connection]     
07:13 -!- CubicEarths [~cubiceart@178.197.231.156] has joined #bitcoin-core-dev     
07:20 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
07:23 -!- CubicEarths [~cubiceart@178.197.231.156] has quit [Remote host closed the connection]     
07:24 -!- CubicEarths [~cubiceart@178.197.231.156] has joined #bitcoin-core-dev     
07:26 -!- Sinclair6 [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has joined #bitcoin-core-dev     
07:37 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Remote host closed the connection]     
07:44 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev     
07:46 -!- vexbuy_ [~vexbuy@46.166.142.214] has quit [Remote host closed the connection]     
07:47 -!- jpe [~jpe@gb-r9-01.pixelpark.net] has joined #bitcoin-core-dev     
07:49 -!- zarez [~Thunderbi@93.93.44.38] has quit [Ping timeout: 256 seconds]     
07:49 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has joined #bitcoin-core-dev     
07:51 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
07:52 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
07:53 -!- Aaronvan_ is now known as AaronvanW     
07:53 -!- zarez1 [~Thunderbi@fs-93-93-44-38.fullsave.info] has joined #bitcoin-core-dev     
07:54 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has quit [Ping timeout: 240 seconds]     
07:54 -!- zarez1 is now known as zarez     
07:59 -!- vexbuy_ [~vexbuy@46.166.142.220] has joined #bitcoin-core-dev     
08:03 -!- niska [~niska@68.ip-149-56-14.net] has quit [Quit: Leaving]     
08:04 -!- CubicEarths [~cubiceart@178.197.231.156] has quit [Remote host closed the connection]     
08:12 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev     
08:14 -!- bitcoin20 [599be217@gateway/web/freenode/ip.89.155.226.23] has joined #bitcoin-core-dev     
08:15 < bitcoin20> hello frens
08:15 < bitcoin20> happy 17m
08:17 -!- niska [~niska@68.ip-149-56-14.net] has joined #bitcoin-core-dev     
08:17 < Randolf> Hello bitcoin20.
08:22 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds]     
08:23 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev     
08:23 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/eac067ad5962...826acc9a3d02
08:23 < bitcoin-git> bitcoin/master abd58a2 Aaron Clauson: Fix for utiltime to compile with msvc.
08:23 < bitcoin-git> bitcoin/master 826acc9 Wladimir J. van der Laan: Merge #13031: Fix for utiltime to compile with msvc....
08:24 < bitcoin-git> [bitcoin] laanwj closed pull request #13031: Fix for utiltime to compile with msvc. (master...msvc_gmtime) https://github.com/bitcoin/bitcoin/pull/13031
08:24 < bitcoin20> is bitcoincore adapted to asic  technology?
08:25 < Randolf> bitcoin20:  That's a good question for the #bitcoin channel.  Please ask there.
08:25 < bitcoin20> isnt it the dev
08:27 < Randolf> This channel is focused on Bitcoin Core code development.  The question you ask seems to be a more general one.
08:33 -!- vexbuy_ [~vexbuy@46.166.142.220] has quit [Remote host closed the connection]     
08:38 < bitcoin-git> [bitcoin] fanquake opened pull request #13091: [0.15] doc: Add compilation note to README.md (0.15...0-15-0-readme) https://github.com/bitcoin/bitcoin/pull/13091
08:39 -!- laurentmt [~Thunderbi@37.58.58.232] has quit [Quit: laurentmt]     
08:44 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has joined #bitcoin-core-dev     
08:44 -!- vexbuy_ [~vexbuy@46.166.142.219] has joined #bitcoin-core-dev     
08:48 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 276 seconds]     
08:54 -!- grafcaps [~haroldbr@104.137.194.255] has joined #bitcoin-core-dev     
08:56 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has quit [Quit: WeeChat 2.1]     
09:04 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
09:07 -!- molz [~m@unaffiliated/molly] has joined #bitcoin-core-dev     
09:10 -!- mol [~molly@unaffiliated/molly] has quit [Quit: Leaving]     
09:13 -!- bitcoin20 [599be217@gateway/web/freenode/ip.89.155.226.23] has quit [Quit: Page closed]     
09:15 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has quit [Read error: Connection reset by peer]     
09:15 -!- ProfMac [~ProfMac@2001:470:1f0f:226:206c:4044:c742:8263] has quit [Remote host closed the connection]     
09:16 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev     
09:20 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev     
09:23 < bitcoin-git> [bitcoin] fanquake opened pull request #13093: [0.15] backport: depends qt patches (0.15...0-15-depends-qt-backport) https://github.com/bitcoin/bitcoin/pull/13093
09:25 -!- TheV01d [thev01d@btc.mining.ga] has quit [Remote host closed the connection]     
09:25 -!- TheV01d [thev01d@btc.mining.ga] has joined #bitcoin-core-dev     
09:33 -!- promag [~promag@83.223.249.89] has joined #bitcoin-core-dev     
09:37 -!- CubicEarths [~cubiceart@178.197.231.199] has joined #bitcoin-core-dev     
09:44 < bitcoin-git> [bitcoin] ken2812221 opened pull request #13094: tests: Add test for 64-bit Windows PE, modify 32-bit test results (master...patch-1) https://github.com/bitcoin/bitcoin/pull/13094
09:51 -!- ProfMac [~ProfMac@2001:470:1f0f:226:206c:4044:c742:8263] has joined #bitcoin-core-dev     
10:00 -!- shtirlic [~shtirlic@ec2-52-28-63-126.eu-central-1.compute.amazonaws.com] has quit [Quit: ZNC - http://znc.in]     
10:01 -!- shtirlic [~shtirlic@ec2-52-28-63-126.eu-central-1.compute.amazonaws.com] has joined #bitcoin-core-dev     
10:05 < fanquake> wumpus Agree that the note being "in" the branch isn't ideal, I'm open to other suggestions on where to put. 
10:05 < wumpus> fanquake: I think it would make sense to have a section about branches in the README.md in master, somewhere near the top
10:06 < fanquake> wumpus ok. I guess that section could get adjusted at branching time to be more specific if required as well.
10:07 -!- shtirlic_ [~shtirlic@Shtirlic-3-pt.tunnel.tserv11.ams1.ipv6.he.net] has quit [Ping timeout: 276 seconds]     
10:11 -!- mistergold [~mistergol@37.19.109.183] has joined #bitcoin-core-dev     
10:12 -!- shtirlic_ [~shtirlic@167.99.19.62] has joined #bitcoin-core-dev     
10:12 < bitcoin-git> [bitcoin] fanquake opened pull request #13095: build: update ax_boost_chrono/unit_test_framework (master...sync-boost-ax-chrono-unit-test) https://github.com/bitcoin/bitcoin/pull/13095
10:14 -!- shtirlic_ [~shtirlic@167.99.19.62] has quit [Client Quit]     
10:17 -!- CubicEarths [~cubiceart@178.197.231.199] has quit [Remote host closed the connection]     
10:24 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has quit [Ping timeout: 260 seconds]     
10:27 -!- n1bor [~n1bor@185.9.34.66] has joined #bitcoin-core-dev     
10:29 < bitcoin-git> [bitcoin] jl2012 opened pull request #13096: [Policy] Fix MAX_STANDARD_TX_WEIGHT check (master...max_std_tx_weight) https://github.com/bitcoin/bitcoin/pull/13096
10:30 -!- alex_rus [~alexn___r@31.148.138.236] has joined #bitcoin-core-dev     
10:31 < bitcoin-git> [bitcoin] promag opened pull request #13097: Support wallets loaded dynamically (master...2018-04-ui-wallet-loaded) https://github.com/bitcoin/bitcoin/pull/13097
10:32 -!- DrFeelGood [~DrFeelGoo@unaffiliated/olufunmilayo] has quit [Ping timeout: 240 seconds]     
10:33 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev     
10:34 < promag> fanquake: ui label on that one
10:34 -!- contrapumpkin [~copumpkin@haskell/developer/copumpkin] has joined #bitcoin-core-dev     
10:34 -!- DrFeelGood [~DrFeelGoo@unaffiliated/olufunmilayo] has joined #bitcoin-core-dev     
10:36 < promag> ty     
10:36 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 248 seconds]     
10:41 -!- promag [~promag@83.223.249.89] has quit [Remote host closed the connection]     
10:48 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/826acc9a3d02...8d045a0f66df
10:48 < bitcoin-git> bitcoin/master fadfbd3 MarcoFalke: qa: Add test for orphan handling
10:48 < bitcoin-git> bitcoin/master fa02c5b MarcoFalke: qa: Clarify documentation for send_txs_and_test
10:48 < bitcoin-git> bitcoin/master 8d045a0 Wladimir J. van der Laan: Merge #13003: qa: Add test for orphan handling...
10:49 < bitcoin-git> [bitcoin] laanwj closed pull request #13003: qa: Add test for orphan handling (master...Mf1804-qaOrphans) https://github.com/bitcoin/bitcoin/pull/13003
10:51 -!- laurentmt [~Thunderbi@37.58.58.232] has joined #bitcoin-core-dev     
10:52 -!- laurentmt [~Thunderbi@37.58.58.232] has quit [Client Quit]     
10:54 -!- ProfMac [~ProfMac@2001:470:1f0f:226:206c:4044:c742:8263] has quit [Ping timeout: 255 seconds]     
10:57 -!- promag [~promag@83.223.249.89] has joined #bitcoin-core-dev     
11:03 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection]     
11:07 -!- ProfMac [~ProfMac@2001:470:1f0f:226:bdd6:b46a:fbd4:d7b0] has joined #bitcoin-core-dev     
11:07 -!- promag_ [~promag@83.223.232.5] has joined #bitcoin-core-dev     
11:10 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev     
11:10 -!- promag [~promag@83.223.249.89] has quit [Ping timeout: 260 seconds]     
11:10 < bitcoin-git> [bitcoin] laanwj pushed 10 new commits to master: https://github.com/bitcoin/bitcoin/compare/8d045a0f66df...487dcbe80c20
11:10 < bitcoin-git> bitcoin/master 952d821 Pieter Wuille: Make CScript -> CScriptID conversion explicit
11:10 < bitcoin-git> bitcoin/master fb1dfbb Pieter Wuille: Remove unused IsMine overload
11:10 < bitcoin-git> bitcoin/master 19fc973 Pieter Wuille: Do not expose SigVersion argument to IsMine...
11:11 < bitcoin-git> [bitcoin] laanwj closed pull request #13002: Do not treat bare multisig outputs as IsMine unless watched (master...201804_cleanismine) https://github.com/bitcoin/bitcoin/pull/13002
11:12 -!- CubicEarths [~cubiceart@178.197.231.81] has joined #bitcoin-core-dev     
11:13 < achow101> what happened to cflatdata?
11:13 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Quit: Leaving]     
11:14 < sipa> achow101: gone!
11:14 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
11:14 < sipa> what do you need it for?
11:14 < achow101> rebasing psbt
11:14 < sipa> what kind of object are you serializing?
11:14 < achow101> std::vector<unsigned char>
11:15 < sipa> with fixed known size?
11:15 < sipa> READWRITE(MakeSpan(the_vector)) should work
11:15 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
11:16 < achow101> sipa: I have things like this: WriteCompactSize(s, entry.second.size());
11:16 < achow101>             s << CFlatData(REF(entry.second));
11:16 < achow101> entry.second is a CScript actually
11:16 < sipa> s << MakeSpan(entry.second);
11:16 < achow101> ok, thanks
11:17 < sipa> does 's << entry.second' not work (replacing the WriteCompactSize too)?
11:18 < achow101> I'm not sure
11:20 -!- alex_rus [~alexn___r@31.148.138.236] has quit [Quit: Leaving]     
11:20 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev     
11:23 -!- promag_ [~promag@83.223.232.5] has quit [Remote host closed the connection]     
11:36 < achow101> sipa: so Span effectively replaces CFlatData?
11:39 < sipa> achow101: Span is much more :)
11:39 < sipa> it's just a pointer to some data + length, that acts like a container on itself
11:39 < sipa> but Span<unsigned char> has a special serializer that works like serializing arrays
11:40 < sipa> it has a subset of the functionality of std::span that is proposed for C++20
11:41 < achow101> ah ok
11:41 < achow101> I made liberal use of CFlatData when implementing psbt so now I need to figure out how to fix all of that
11:41 -!- CubicEarths [~cubiceart@178.197.231.81] has quit [Remote host closed the connection]     
11:41 < sipa> oh, you can also serialize arrays of chars directly now
11:42 < sipa> s << array;
11:43 < achow101> What about deserializing arrays of chars?
11:45 < sipa> also works
11:45 < sipa> also on Spans
11:45 < achow101> Does it have to be length prefixed?
11:45 < sipa> no     
11:45 < sipa> vectors are serialized with length prefixed
11:45 < sipa> arrays and spans are not
11:45 < sipa> (serialized and deserialized)
11:45 < achow101> ok     
11:52 < bitcoin-git> [bitcoin] fanquake closed pull request #12583: [WIP] Unit test sub-directories (master...unittest_subdir) https://github.com/bitcoin/bitcoin/pull/12583
11:56 -!- clarkmoody [~clarkmood@47-218-248-206.bcstcmta04.res.dyn.suddenlink.net] has joined #bitcoin-core-dev     
11:57 < jonasschnelli> achow101: I need to study psbt, but was wondering if it was designed to deseialize on low mem mcus
11:57 < jonasschnelli> example: deserialize with a buffer of say 1kb, get hash and total of all outputs
11:58 < achow101> jonasschnelli: I did intend for it to be used with hardware wallets, but I'm not sure if it actually will
11:58 < sipa> i expect there will be translation layers between PSBT and every hardware device
11:58 < achow101> a psbt can be quite large
11:58 < sipa> that translation layer can present things to the device in whatever format it wants
11:59 < jonasschnelli> size does not matter too much, as long the the deser/ser is cleverly design to allow tx verification with a small buffer
11:59 < sipa> jonasschnelli: it isn't
11:59 < jonasschnelli> sipa: yes. then I guess the layer is required
11:59 < sipa> i think that's inevitable
11:59 < jonasschnelli> Though it will introduce another form of an API which is unfortunate
12:00 < wumpus> #startmeeting
12:00 < lightningbot> Meeting started Thu Apr 26 19:00:23 2018 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
12:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
12:00 < instagibbs> meeting?
12:00 < instagibbs> hi     
12:00 < jamesob_> :wave:
12:00 < sipa> meeting
12:00 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
12:00 < achow101> hi     
12:00 < sdaftuar> hi     
12:00 < cfields> hi     
12:00 < fanquake> hi     
12:00 < jonasschnelli> hi     
12:00 < sipa> hi     
12:00 < wumpus> proposed topics?
12:01 -!- jamesob_ is now known as jamesob     
12:01 < wumpus> #topic high priority for review
12:01 < kanzure> hi.     
12:01 < fanquake> Would suggest #10757 but I'm seeing unicorns..
12:01 < wumpus> #12979 #12560 #10757
12:01 < gribble> https://github.com/bitcoin/bitcoin/issues/10757 | RPC: Introduce getblockstats to plot things by jtimon · Pull Request #10757 · bitcoin/bitcoin · GitHub
12:02 < gribble> https://github.com/bitcoin/bitcoin/issues/12979 | Split validationinterface into paralell validation/mempool interfaces by TheBlueMatt · Pull Request #12979 · bitcoin/bitcoin · GitHub
12:02 < gribble> https://github.com/bitcoin/bitcoin/issues/12560 | [wallet] Upgrade path for non-HD wallets to HD by achow101 · Pull Request #12560 · bitcoin/bitcoin · GitHub
12:02 < wumpus> are currently open and on there
12:02 < gribble> https://github.com/bitcoin/bitcoin/issues/10757 | RPC: Introduce getblockstats to plot things by jtimon · Pull Request #10757 · bitcoin/bitcoin · GitHub
12:02 < instagibbs> proposed topic: the necessity of "totalFee" as an argument for bumpfee
12:02 -!- Dizzle [~dizzle@108.171.182.16] has quit [Ping timeout: 256 seconds]     
12:02 < BlueMatt> I mean we havent really been getting any review on the "high priority" list
12:02 < BlueMatt> so not sure the use of bringing it up every week
12:02 < wumpus> BlueMatt: if we don't bring it up it's even more pointless I guess
12:03 < sdaftuar> yeah we either nag or we give up -- i vote for the former
12:03  * sdaftuar nags self
12:03 < BlueMatt> I've nagged the last two weeks (sorry wasnt prepared today) but...no dice
12:03 < aj> BlueMatt: 10757's had review, and txindex made it in. yours is hard :(
12:03 < wumpus> but if it doens't help we can give up on it too, fine with me
12:03 < jonasschnelli> Agree. Though "High Priority" is probably the wrong name for that list
12:04 < wumpus> jonasschnelli: any idea for a better name?
12:04 < sipa> i wonder if the "everyone can get one of their PRs on the list" policy is very good
12:04 < wumpus> sipa: any idea for a better policy?
12:04 < jonasschnelli> I have no better name
12:04 < aj> BlueMatt: and yours needs rebase again. :( worth tracking which non-high-pri PRs conflict with high-pri issues and avoid merging them?
12:04 -!- promag [~promag@83.223.232.5] has joined #bitcoin-core-dev     
12:04 < promag> hi     
12:05 < BlueMatt> the subsection is "blockers"
12:05 < BlueMatt> ie "this is blocking my work"
12:05 < jonasschnelli> I think the policy seems pretty fair regarding the lack of a steering commitee
12:05 < BlueMatt> which is correct for a few of those
12:05 < sipa> BlueMatt: ah yes, that makes sense
12:05 < jamesob> aj: sounds like a lot of work
12:05 < wumpus> yes "blockers" might be a better name
12:05 -!- promag [~promag@83.223.232.5] has quit [Read error: Connection reset by peer]     
12:05 < aj> jamesob: i have a script that approximates it; haven't been running it regularly, but there's no reason i couldn't
12:05 < wumpus> that's why they're high priority
12:05 < BlueMatt> aj: you can still review things with trivial conflicts....
12:05 < sipa> i started reviewing #12979 but had difficulty following
12:05 < wumpus> or supposed to be, anyhow
12:05 < gribble> https://github.com/bitcoin/bitcoin/issues/12979 | Split validationinterface into paralell validation/mempool interfaces by TheBlueMatt · Pull Request #12979 · bitcoin/bitcoin · GitHub
12:06 < jamesob> aj: oh interesting
12:06 < BlueMatt> sipa: well it got split off of 11775, so its a pure refactor
12:06 < BlueMatt> all it is is moving things around, so on its face it looks useless and dumb
12:06 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
12:06 -!- LukeJr [~quassel@75.113.216.246] has joined #bitcoin-core-dev     
12:07 < sipa> also, BlueMatt, do you think #11639 may not be closer to merge (as it seems like it may conflict with 12979?)
12:07 < gribble> https://github.com/bitcoin/bitcoin/issues/11639 | Rewrite the interface between validation and net_processing wrt DoS by TheBlueMatt · Pull Request #11639 · bitcoin/bitcoin · GitHub
12:08 -!- drexl [~drexl@62.112.9.166] has joined #bitcoin-core-dev     
12:08 < BlueMatt> sipa: it is almost certainly closer to merge, but it is *not* blocking me so is not my "high-priority blocker"
12:08 < BlueMatt> whereas 12979 is blocking about 10 other things
12:08 < sipa> ah, i see
12:08 < BlueMatt> however, our high-priority policy has historically been that you can nominate someone else' pr if its blocking you
12:09 < BlueMatt> so if thats blocking someone, they can nominate it
12:09 < wumpus> sure, you can nominate someone else's pr
12:11 < wumpus> also I don't think we have enough other meeting topics every week that not discussing the high priority for review would help
12:11 < wumpus> but I'm fine with dropping the topic if there's agreement to do that
12:11 < sipa> i'd like to keep it - but if there's not much to say, not much needs to be said about it
12:11 < BlueMatt> well we keep coming back to needing *something* to make progress move when you get blocked on something
12:11 -!- drexl [~drexl@62.112.9.166] has quit [Read error: Connection reset by peer]     
12:12 -!- drexl_ [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev     
12:12 -!- drexl_ is now known as drexl     
12:12 < BlueMatt> if not the high-priority list, what?
12:12 < wumpus> yes, if there's nothing to be said we can just move on
12:12 < BlueMatt> and the high-priority list seems to be pretty reliably not working
12:12 < wumpus> well one thing got merged from it...
12:12 < instagibbs> BlueMatt, for your PRs or for all?
12:12 < BlueMatt> yes, but it only got review from like 2 people for several weeks where people were active and it sat on the list
12:12 < BlueMatt> instagibbs: all
12:13 < wumpus> so is that because it is on the list?
12:13 < LukeJr> for all IMO; I'm at least partly to blame though - usually I just pick random PRs without checking the high prio list
12:13 < BlueMatt> no, I'm saying about 2 people bothered to review it for many weeks
12:13 < BlueMatt> which clearly indicates its not working
12:13 < sipa> being on the list doesn't compel people to review
12:13 < wumpus> it's clear that things are on the list that have a hard time getting review
12:13 < BlueMatt> certainly I'm not great either, but we need something to get people to care about some blockers list
12:13 < instagibbs> take it off, see if it gets less review #science
12:13 < LukeJr> I think having the list is better than not - just a matter of remembering to use it
12:15 < wumpus> anyhow, if this topic is only about how ineffective the list is every week, I'm going to drop it
12:15 < BlueMatt> anyway, I'll shut up, instagibbs had a topic
12:15 < wumpus> #topic the necessity of "totalFee" as an argument for bumpfee (instagibbs)
12:17  * LukeJr pokes instagibbs
12:17  * sipa concludes: no necessity of "totalFee" as an argument for bumpfee ?
12:18 < instagibbs> ohhi
12:18 < instagibbs> sorry
12:18 < instagibbs> yes, is it needed
12:18 < wumpus> what is this argument used for?
12:18 < sdaftuar> it's optional, no?
12:19 < instagibbs> sdaftuar, I was hoping to upgrade rbf/cpfp in not too distant future, but it complicates logic to support
12:19 < instagibbs> I could just not support any better RBF that uses it, but was wondering if it makes sense regardless
12:19 < instagibbs> wumpus, you pay X BTC more in fees, total, rather than bump by feerate
12:20 < sdaftuar> not X more, X total, right?
12:20 < instagibbs> yes     
12:20 < wumpus> instagibbs: I suppose that is useful when all of the fee computation happens on the client side?
12:21 < sdaftuar> i dunno, i don't feel strongly about it, i think these user interface questions are hard to answer in the abstract
12:21 < sdaftuar> so if you have a proposal for some other interface, we should talk about that
12:21 < aj> instagibbs: error out if totalFee > old-fee + old-change?
12:21 < wumpus> (as the topic is necessity it's good to have some use cases?)
12:21 < LukeJr> aj: or do it as CPFP possibly
12:21 < instagibbs> aj, hm?
12:21 < instagibbs> ah, interesting
12:21 < LukeJr> I'm not sure total fee really makes sense when changing the size though
12:22 < sdaftuar> yeah i agree that seems like a confusing case at the least
12:22 < sipa> agree
12:22 < instagibbs> I redid everything to just use CreateTransaction, fwiw
12:22 < instagibbs> so it will select more coins, which changes size
12:22 < instagibbs> (if needed)
12:23 < sdaftuar> one issue we ran into with bumpfee was nailing down all the rquirements up-front. might be worth laying out what constraints we are trying to satisfy as part of the discussion, so we can ensure we're still meeting them all
12:23 < LukeJr> instagibbs: considering total fee is optional, we need to work without it regardless; so how does keeping it simplify anything?
12:23 < instagibbs> BIP125 constraints are the PITA I think
12:24 < instagibbs> LukeJr, I want to get rid of it
12:24 < instagibbs> or think about doing so
12:24 < LukeJr> oh     
12:24 < instagibbs> ok, just wanted to hear any good use cases if they thought of them
12:24 < sdaftuar> i think if you're changing tx size that's a pretty good argument for dropping it
12:24 < LukeJr> I suppose totalFee could be a kind of "if you calculated a higher fee, fail rather than bump; if lower, increase fee to match"
12:25 < aj> yeah, what lukejr said
12:25 < LukeJr> or even just the former might be the useful part
12:25 < instagibbs> If want total fee, I suppose I could just forbid any new coin selection, and fail out otherwise
12:25 < instagibbs> backwards compatible without additional cruft
12:25 < instagibbs> ok, end
12:26 < wumpus> oh I have a topic
12:26 < wumpus> #topic Remove safemode
12:26 < wumpus> #13090 #10563
12:26 < gribble> https://github.com/bitcoin/bitcoin/issues/13090 | Remove Safe mode (achow101) by laanwj · Pull Request #13090 · bitcoin/bitcoin · GitHub
12:26 < gribble> https://github.com/bitcoin/bitcoin/issues/10563 | Remove safe mode by achow101 · Pull Request #10563 · bitcoin/bitcoin · GitHub
12:27 < wumpus> this has been open for a long time, safemode was disabled since 0.16, should we complately remove it for 0.17?
12:27 < instagibbs> sdaftuar, https://github.com/bitcoin/bitcoin/issues/12271 please contribute if this issue helps (ok now done)
12:27 < LukeJr> I think safemode is a useful concept, but without anyone working to make it useful in practice (ie, detecting actual problem conditions), might as well drop it
12:28 < wumpus> it's disabled by default in 0.16 and I've heard no one complaining about it
12:28 < achow101> most people don't know it exists
12:28 < wumpus> to be honest I don't think anyone cares
12:28 < instagibbs> frankly ive never heard of anyone using it, and I still don't know what it does, if anything
12:28 < wumpus> and we should drop it to simplify the code
12:28 < jonasschnelli> agree...
12:28 < jtimon> sorry, late, yeah 10757 got review, thanks
12:28 < achow101> instagibbs: it disables a few RPCs related to the wallet
12:28 < jonasschnelli> If one cares about, it could be re-written as external RPC layer/proxy
12:29 < sdaftuar> wumpus: yep seems reasonable to me as well
12:29 < wumpus> I mean the alerts that trigger it aren't reliable in the first place
12:29 < wumpus> and then it haphazardly disables some wallet RPCs
12:29 < LukeJr> can always add it back if someone does the work
12:29 < LukeJr> tbf, if it were useful, and disabled by default, the reaction of someone to not having it would probably be to just enable it, not complain
12:29 < LukeJr> (but I don't see how it's useful as-is)
12:30 < wumpus> if someone would make the alerts useful and reliable, that'd be a first step :)
12:30 < achow101> has safemode ever been triggered before due to a chain fork?
12:30 < wumpus> there's -alertnotify!
12:30 < wumpus> achow101: not that I know of...
12:31 < LukeJr> it might make sense to have a "setsafemode" RPC instead of automatic stuff?
12:31 < wumpus> meh     
12:31  * LukeJr shrugs
12:31 < wumpus> I don't think the current selection of RPCs to disable is useful, maybe something to disable all wallet calls then? I don't know - I don't think there is demand for this inpractice
12:31 < jtimon> BlueMatt: you make something that seems useless and dumb and isn't supposed to change behaviour and don't ping me for review? I'm disappointed :p 
12:32 < achow101> What exactly is the purpose of safemode though? If we keep it/change it, what is it's goal?
12:32 < wumpus> so anyhow, that was what I wanted t osay
12:32 < wumpus> I think everyone is 'meh' about it just like me
12:32 < wumpus> other topics?
12:32 < sipa> i think it can just be removed
12:33 < wumpus> yes, I'd prefer that
12:33 < LukeJr> wumpus: walletunload :D
12:33 < LukeJr> achow101: ideally, it would detect odd network conditions and disable confirming transactions
12:33 < LukeJr> achow101: eg, if there was an invalid chain longer than the best valid one
12:33 < LukeJr> (or actually, even more ideal would be to compare the chains, and only confirm transactions common to both..)
12:33 < wumpus> #topic walletunload (Lukejr)
12:33 < sipa> disabling RPCs is not how the bitcoin ecosystem will deal with an emergency anyway - a lot of infrastructure wouldn't even notice
12:34 < promag> I already have unload working without UI reacting
12:34 < LukeJr> wumpus: I wasn't suggesting it as a topic
12:34 < wumpus> LukeJr: oh...
12:34 < sipa> #unload walletunload
12:35 -!- CubicEarths [~cubiceart@xdsl-188-155-63-9.adslplus.ch] has joined #bitcoin-core-dev     
12:35 < fanquake> maybe topic: cfields any updates on app signing/certs etc? meant to follow up with you from ny
12:35 < wumpus> #untopic
12:35 < LukeJr> wumpus: just saying it would have the same result as disabling wallet RPCs
12:35 < cfields> fanquake: need to poke gmaxwell. He might've forgotten about it
12:35 < LukeJr> promag: what happens if you try to use the GUI after unloading its wallet?
12:35 < wumpus> LukeJr: ok yes, I understand now :)
12:36 < achow101> has anyone seen gmaxwell recently? is he still alive?
12:36 < wumpus> he's still alive
12:36 < promag> LukeJr: don't know, only tested with bitcoind
12:36 < sipa> yes     
12:37 < promag> LukeJr: after #13097 I'll submit unload in the UI
12:37 < gribble> https://github.com/bitcoin/bitcoin/issues/13097 | Support wallets loaded dynamically by promag · Pull Request #13097 · bitcoin/bitcoin · GitHub
12:38 < wumpus> I think we've run out of topics
12:38 < wumpus> #endmeeting
12:38 < lightningbot> Meeting ended Thu Apr 26 19:38:21 2018 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
12:38 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-04-26-19.00.html
12:38 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-04-26-19.00.txt
12:38 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-04-26-19.00.log.html
12:40 -!- laurentmt [~Thunderbi@37.58.58.232] has joined #bitcoin-core-dev     
12:41 < jtimon> LukeJr: yeah, total fee meaning "max total fee" makes sense to me without increasing it if you pay less
12:41 -!- LukeJr [~quassel@75.113.216.246] has quit [Read error: Connection reset by peer]     
12:41 < sipa> damn peer
12:43 < jamesob> (late to party) fwiw, I like the High Priority queue. I consult it, I just rarely get a chance to actually get around to it :)
12:44 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit []     
12:45 < wumpus> jamesob: it's always the really large or difficult ones that end up the list, that doesn't help either
12:45 < jamesob> right
12:45 < wumpus> though it makes sense because the others don't need so much encouragement for review
12:47 -!- vexbuy_ [~vexbuy@46.166.142.219] has quit [Ping timeout: 264 seconds]     
12:49 < promag> i like it too
12:50 -!- laurentmt [~Thunderbi@37.58.58.232] has quit [Quit: laurentmt]     
12:52 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds]     
12:53 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev     
12:54 < jtimon> yeah, what was supposed to be the initial goal of the safe mode if nobody thinks that either the activation conditions make sense, how did it came to this state? who championed it?
12:58 < jtimon> agree with jamesob I like it to be there even though if I don't have much time to review I tend to ignore big PRs anyway
13:00 < sipa> jtimon: safe mode has existed since forever
13:00 < jtimon> I see
13:01 < harding> jtimon: didn't Nakamoto add safe mode based on the P2P protocol authenticated alert messages back in 0.3.something?  I think it's just transitioned to triggering based on local conditions (I think that was something Andresen advocated after the 0.7/0.8 consensus failure).
13:01 < sipa> jtimon: introduced in 0.3.8 under the name "lockdown"
13:02 < sipa> ah yes, there have multiple triggers for ot
13:03 < sipa> including alerts
13:04 < jtimon> harding: I had no idea, that's why I asked, but thanks
13:04 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev     
13:07 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 240 seconds]     
13:07 < jtimon> not sure if this is offtopic, but for elements we want a simpler approach (just stop and don't start again until a file with a huge scary name gets deleted). see  https://github.com/ElementsProject/elements/pull/323
13:08 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]     
13:09 < jtimon> I would be more than happy to upstream if there's any interest, but it's kind of orthogonal to removing the current safe mode I guess
13:11 < sipa> yes, seems orthogonal
13:12 < jtimon> so, sorry, were there opened prs to remove the current safe mode?
13:13 < harding> #13090
13:13 < gribble> https://github.com/bitcoin/bitcoin/issues/13090 | Remove Safe mode (achow101) by laanwj · Pull Request #13090 · bitcoin/bitcoin · GitHub
13:13 < jtimon> thanks, perhaps we can put it on https://github.com/bitcoin/bitcoin/projects/8 ?
13:14 < wumpus> right, it used to have a wider scope of triggers, in time it became less and less
13:14 < wumpus> because no one really wants half of their RPCs to break unexpectedly
13:14 < wumpus> certainly not because of a signed message from the P2P network
13:15 < promag> do we want menus "File"->"Open Wallet" and "File"->"Close Wallet" ?
13:15 < jtimon> yeah, from the people's comments just smelled like something that made sense at some point but didn't made sense anymore
13:15 < wumpus> I guess it's not high priority because it's not blocking anything
13:15 < wumpus> also I think it's the kind of thing that gets lots of attention without being on a list
13:16 < jtimon> fair enough, just an idea
13:16 < jtimon> since it seemed nothing was added to the list this week
13:17 < jtimon> to be clear 10757 isn't blocking any work I'm doing on bitcoin core directly either
13:18 < jtimon> I just thought the policy was "say it on a meeting if you don't have one there already and see if people consider it a priority or not"
13:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
13:18 < wumpus> yes, in principle it is
13:21 < jtimon> wumpus: well, you don't have any pr on the list, do you?
13:22 < jtimon> anyway, never mind
13:22 < wumpus> true
13:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 264 seconds]     
13:23 < jtimon> it is very small anyway, will get plenty of review in no time, I think
13:24 < aj> having a separate list for blockers and been-hanging-around-for-a-while-let's-knock-this-off might make sense?
13:25 < wumpus> easy enough to add another column
13:25 < aj> jtimon: are the getblockstats test failing for you now too btw?
13:25 < wumpus> jtimon: exactly my point :) the kind of PRs that need nagging about are either obscure ones, or difficult ones that change a lot of code or threading semantics and such
13:25 < jtimon> aj: no, are they failing for you? I can re-test
13:26 < aj> jtimon: yeah. i think they fail once the block timestamps are >24h old
13:26 < aj> jtimon: (i commented on the PR)
13:26 < jtimon> uhm, it is running for too long, not 1 sec as expected, I'll have a look, thanks
13:26 < aj> jtimon: yeah. should time out after 60s
13:27 < jtimon> it's failing to sync the 2 nodes...
13:27 < aj> jtimon: https://github.com/bitcoin/bitcoin/pull/10757#issuecomment-384440743
13:27 < jtimon> yeah, sorry
13:27 < aj> jtimon: np :)
13:29 -!- clarkmoody [~clarkmood@47-218-248-206.bcstcmta04.res.dyn.suddenlink.net] has quit []     
13:29 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
13:30 < jtimon> aj: mhmm, I guess it's about the timestamps of the blocks and we need to use the mocktime thing?
13:31 < aj> jtimon: yeah, that would make sense. set the mocktime based on the json data?
13:31 < jtimon> yeah, that's my thought
13:32 < jtimon> never used the mocktime before, let me grep how that looks like
13:37 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #13098: Skip tx-rehashing on historic blocks (master...Mf1804-readPureBlock) https://github.com/bitcoin/bitcoin/pull/13098
13:41 -!- mistergold [~mistergol@37.19.109.183] has quit [Read error: Connection reset by peer]     
13:44 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
13:55 < promag> how should the user load a wallet from the ui? File->OpenWallet -> FileDialog ?
13:55 < wumpus> I guess so?
13:55 < promag> another option is a Wallet menu
13:56 < promag> with all wallets in the wallet dir 
13:56 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 260 seconds]     
13:56 < promag> and then a "Open external" option
13:56 < harding> promag: instead of a Wallet menu, you could have a Recent Wallets entry in the file menu listing the last 10 walets that have been opened.
13:57 < promag> harding: I thought of that too, but IMO that's for "round 2"
13:58 < promag> harding: that needs qsettings to remember wallets, cleanup of unexisting wallets...
13:59 < promag> also, in the UI, should prompt the user if a wallet is being unloaded, for instance, via rpc? 
13:59 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
14:00 < sipa> i don't think so
14:00 < sipa> if something is done through RPC you can assume that's the user explicitly acting
14:00 < promag> just asking, I don't think so too
14:01 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Read error: Connection reset by peer]     
14:01 < harding> promag: makes sense.  I guess the question for creating a Wallets menu is whether it's something that would be around permanently or would be just temporary until a Recent Wallets submenu was added.  If it's temp, then I'd suggest not adding it at all and making the user go through the file dialog each time they want to open a particular wallet.
14:02 < promag> harding: yeah, and by default open the directory -walletdir
14:02 < promag> and "Close wallet" should close the "current" wallet correct?
14:03 < harding> If possible, I'd default to opening the last used directory.
14:03 < harding> I think most apps do that.
14:03 < promag> should we allow closing all wallets? the UI is not prepared for no wallets
14:03 < harding> (But if there's no last used directory, then -walletdir is a good default.)
14:03 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev     
14:05 < promag> harding: remembering the last user choice is probably "round 2" too
14:06 < promag> "round 1" should be basic and stable support in the UI
14:09 -!- LeMiner2 [LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has joined #bitcoin-core-dev     
14:10 -!- niftynei [~niftynei@135.84.132.224] has joined #bitcoin-core-dev     
14:11 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Quit: reboot .. brb]     
14:11 -!- LeMiner [LeMiner@unaffiliated/leminer] has quit [Ping timeout: 264 seconds]     
14:11 -!- LeMiner2 is now known as LeMiner     
14:12 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev     
14:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
14:23 < promag> "the UI is not prepared for no wallets" <- i was wrong
14:27 -!- isis is now known as isis_     
14:27 < wumpus> yes, it can run without wallet fine, e.g. -disablewallet
14:32 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds]     
14:33 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has quit [Read error: Connection reset by peer]     
14:34 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has joined #bitcoin-core-dev     
14:37 < promag> -nowallet
14:37 -!- tralfaz [67fe9963@gateway/web/freenode/ip.103.254.153.99] has joined #bitcoin-core-dev     
14:39 -!- bedotech [~bedo@62-11-53-104.dialup.tiscali.it] has quit [Ping timeout: 256 seconds]     
14:49 -!- Dizzle [~dizzle@108.171.182.16] has quit [Ping timeout: 264 seconds]     
14:53 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has quit []     
14:59 < achow101> sipa: how would I serialize a CPubKey without the leading size?
15:06 < sipa> achow101: you could use Span<const unsigned char>(pubkey.begin(), pubkey.size())
15:07 < sipa> or you could add a CPubKey::data() method, and then just use MakeSpan(pubkey)
15:19 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]     
15:22 < bitcoin-git> [bitcoin] jamesob opened pull request #13099: Use thread names in logs and deadlock diagnostics (master...2018-04-26-use-threadnames) https://github.com/bitcoin/bitcoin/pull/13099
15:34 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Quit: https://quanto.ga/]     
15:34 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Remote host closed the connection]     
15:35 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev     
15:57 -!- niftynei [~niftynei@135.84.132.224] has quit [Remote host closed the connection]     
16:01 < bitcoin-git> [bitcoin] promag opened pull request #13100: Add menu entry to open wallet (master...2018-04-ui-open-wallet) https://github.com/bitcoin/bitcoin/pull/13100
16:04 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
16:06 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
16:10 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
16:24 -!- grafcaps [~haroldbr@104.137.194.255] has quit [Ping timeout: 248 seconds]     
16:50 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Quit: https://quanto.ga/]     
16:52 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev     
17:00 -!- weez17 [~isaac@unaffiliated/weez17] has quit [Remote host closed the connection]     
17:01 -!- weez17 [~isaac@unaffiliated/weez17] has joined #bitcoin-core-dev     
17:03 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection]     
17:04 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev     
17:19 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Quit: drexl]     
17:20 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev     
17:36 -!- weez17 [~isaac@unaffiliated/weez17] has quit [Remote host closed the connection]     
17:37 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Quit: https://quanto.ga/]     
17:39 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev     
17:45 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]     
18:03 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-ejanqyrzusyyrmfk] has joined #bitcoin-core-dev     
18:04 -!- unholymachine [~quassel@2601:8c:c003:9f16:c85d:a774:2a71:15f0] has joined #bitcoin-core-dev     
18:21 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev     
18:25 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 260 seconds]     
18:40 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 240 seconds]     
18:49 -!- tralfaz [67fe9963@gateway/web/freenode/ip.103.254.153.99] has quit [Ping timeout: 260 seconds]     
18:49 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev     
18:53 -!- Samdney [~Samdney@178.162.209.140] has quit [Quit: Verlassend]     
18:54 < jtimon> what's the point of if (g_txindex) if g_txindex is never null ?
18:56 < jtimon> or I'll rephrase, what's the new way of "if (!fTxIndex)" ?
18:57 < sipa> ?     
18:57 < jtimon> sorry, I'll figure it out
18:57 < aj> g_txindex should be null without -txindex?
18:58 < sipa> indeed
18:58 < sipa> jtimon: sorry, i didn't understand your question by missing that your second line was about fTxIndex and not g_txindex
19:01 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev     
19:05 < jtimon> I just got a ‘fTxIndex’ was not declared in this scope, greped and since I'm quite sure I didn't invented fTxIndex, I thought to ask, but I copied that fTxIndex from somewhere else and now I want ot know where I copied it from and what happened to that line. but git has all the anwers I'm looking for
19:08 < sipa> in any case, g_txindex should be null when there is no index
19:30 -!- goatpig [56f75200@gateway/web/freenode/ip.86.247.82.0] has quit [Ping timeout: 260 seconds]     
20:04 -!- unholymachine [~quassel@2601:8c:c003:9f16:c85d:a774:2a71:15f0] has quit [Read error: Connection reset by peer]     
20:06 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
20:07 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
20:21 -!- isis_ is now known as isis     
20:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]     
20:25 -!- isis is now known as isis_     
20:26 -!- murrayn [~dafuq@unaffiliated/murrayn] has quit [Ping timeout: 248 seconds]     
20:36 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 260 seconds]     
21:03 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection]     
21:03 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-ejanqyrzusyyrmfk] has quit [Quit: Connection closed for inactivity]     
21:04 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev     
21:05 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection]     
21:06 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev     
21:07 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection]     
21:08 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev     
21:09 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection]     
21:10 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev     
21:11 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection]     
21:12 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev     
21:46 -!- qinfengling [~qinfengli@45.32.53.207] has quit [Read error: Connection reset by peer]     
22:00 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Read error: Connection reset by peer]     
22:00 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Read error: Connection reset by peer]     
22:00 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Read error: Connection reset by peer]     
22:00 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev     
22:01 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev     
22:26 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev     
22:30 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has quit [Ping timeout: 256 seconds]     
22:36 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has quit [Ping timeout: 264 seconds]     
22:48 -!- qinfengling [~qinfengli@45.32.53.207] has joined #bitcoin-core-dev     
22:50 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 264 seconds]     
22:51 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev     
23:03 -!- Giszmo [~leo@ip-44-226-107-190.nextelmovil.cl] has joined #bitcoin-core-dev     
23:06 -!- murrayn [~dafuq@unaffiliated/murrayn] has joined #bitcoin-core-dev     
23:10 -!- isis_ is now known as isis     
23:26 -!- Giszmo [~leo@ip-44-226-107-190.nextelmovil.cl] has quit [Read error: Connection reset by peer]     
23:32 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev     
23:36 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 240 seconds]     
23:40 -!- bedotech [~bedo@62-11-53-104.dialup.tiscali.it] has joined #bitcoin-core-dev     
23:42 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has joined #bitcoin-core-dev     
23:51 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Ping timeout: 268 seconds]     
23:57 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev