--- Day changed Thu May 03 2018 00:22 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 00:23 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 00:34 -!- brianhoffman [~brianhoff@pool-96-255-225-209.washdc.fios.verizon.net] has quit [Ping timeout: 265 seconds] 00:35 -!- brianhoffman [~brianhoff@pool-96-255-225-209.washdc.fios.verizon.net] has joined #bitcoin-core-dev 00:43 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 00:46 -!- laurentmt [~Thunderbi@37.58.58.232] has joined #bitcoin-core-dev 00:56 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 00:56 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 00:58 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 01:04 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 01:05 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 01:19 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:23 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:24 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 255 seconds] 01:26 -!- laurentmt [~Thunderbi@37.58.58.232] has quit [Quit: laurentmt] 01:28 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 01:30 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 01:30 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 01:33 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 240 seconds] 01:37 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 01:39 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 01:39 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 01:42 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 01:43 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 01:46 -!- vicenteH [~user@123.red-83-58-239.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 01:48 -!- Amuza [~Amuza@2c0f:f930:0:3::221] has joined #bitcoin-core-dev 01:48 -!- mistergold [~mistergol@77.243.22.139] has joined #bitcoin-core-dev 01:54 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 01:55 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 02:09 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 02:12 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 02:16 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 240 seconds] 02:20 < promag> wumpus: should I close #12507 or it's something that can be merged? 02:20 < gribble> https://github.com/bitcoin/bitcoin/issues/12507 | Interrupt rescan on shutdown request by promag · Pull Request #12507 · bitcoin/bitcoin · GitHub 02:27 < wumpus> promag: looks mergeable to me 02:28 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ef006d92845a...2afdc294039f 02:28 < bitcoin-git> bitcoin/master c4fda76 João Barbosa: wallet: Interrupt rescan on shutdown request 02:28 < bitcoin-git> bitcoin/master 2afdc29 Wladimir J. van der Laan: Merge #12507: Interrupt rescan on shutdown request... 02:28 < wumpus> promag: I don't really like how everything is gaining a dependency on init.h for ShutdownRequested, but that's an architectural issue that can be solved separately 02:28 < bitcoin-git> [bitcoin] laanwj closed pull request #12507: Interrupt rescan on shutdown request (master...2018-02-shutdown-on-rescan) https://github.com/bitcoin/bitcoin/pull/12507 02:31 < promag> wumpus: yeah that's the way it is atm 02:31 < promag> wumpus: I also think #12729 is mergeable 02:32 < gribble> https://github.com/bitcoin/bitcoin/issues/12729 | Get rid of ambiguous OutputType::NONE value by ryanofsky · Pull Request #12729 · bitcoin/bitcoin · GitHub 02:32 < wumpus> thanks will take a look 02:53 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2afdc294039f...979150bc2388 02:53 < bitcoin-git> bitcoin/master 1e46d8a Russell Yanofsky: Get rid of ambiguous OutputType::NONE value... 02:53 < bitcoin-git> bitcoin/master 979150b Wladimir J. van der Laan: Merge #12729: Get rid of ambiguous OutputType::NONE value... 02:54 < bitcoin-git> [bitcoin] laanwj closed pull request #12729: Get rid of ambiguous OutputType::NONE value (master...pr/nonone) https://github.com/bitcoin/bitcoin/pull/12729 03:07 -!- kinlo [~peter@unaffiliated/kinlo] has quit [Read error: Connection reset by peer] 03:07 -!- kinlo [~peter@unaffiliated/kinlo] has joined #bitcoin-core-dev 03:08 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 03:10 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 03:13 -!- zautomata3 [~zautomata@41.232.221.192] has joined #bitcoin-core-dev 03:19 -!- Arokh [~Arokh@extknot.com] has quit [Quit: This should never happen] 03:20 -!- laurentmt [~Thunderbi@37.58.58.232] has joined #bitcoin-core-dev 03:20 -!- Arokh [~Arokh@extknot.com] has joined #bitcoin-core-dev 03:21 -!- laurentmt [~Thunderbi@37.58.58.232] has quit [Client Quit] 03:22 -!- Amuza [~Amuza@2c0f:f930:0:3::221] has quit [Remote host closed the connection] 03:23 -!- antipovka_ [c1a97dae@gateway/web/freenode/ip.193.169.125.174] has joined #bitcoin-core-dev 03:24 -!- gfggg [c1a97dae@gateway/web/freenode/ip.193.169.125.174] has joined #bitcoin-core-dev 03:24 < antipovka_> Someone asked me about this Satoshi Mine Bot and here it is! this bot simply automate your actions! It has a lot of settings and actually can help you being fast. But first you have to have your winning strategy! I am not going to explain about it, you are smart people, you are going to handle it! https://www.youtube.com/watch?v=ak-JKQvbDdc&t=7s 03:30 -!- mode/#bitcoin-core-dev [+o wumpus] by ChanServ 03:30 -!- mode/#bitcoin-core-dev [+b *!*@gateway/web/freenode/ip.193.169.125.174] by wumpus 03:30 -!- antipovka_ was kicked from #bitcoin-core-dev by wumpus [Kindergarten is elsewhere!] 03:31 -!- Arokh [~Arokh@extknot.com] has quit [Quit: This should never happen] 03:31 -!- Arokh [~Arokh@extknot.com] has joined #bitcoin-core-dev 03:34 < promag> wumpus: updated #12639 03:34 < gribble> https://github.com/bitcoin/bitcoin/issues/12639 | Reduce cs_main lock in listunspent by promag · Pull Request #12639 · bitcoin/bitcoin · GitHub 03:40 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/979150bc2388...11adab39e601 03:40 < bitcoin-git> bitcoin/master 21f5680 Russell Yanofsky: Trivial: s/SetBestChain/ChainStateFlushed in comments after #13106 03:40 < bitcoin-git> bitcoin/master 11adab3 Wladimir J. van der Laan: Merge #13154: Trivial: s/SetBestChain/ChainStateFlushed in comments after #13106... 03:41 < bitcoin-git> [bitcoin] laanwj closed pull request #13154: Trivial: s/SetBestChain/ChainStateFlushed in comments after #13106 (master...pr/flushed) https://github.com/bitcoin/bitcoin/pull/13154 03:43 -!- laurentmt [~Thunderbi@37.58.58.232] has joined #bitcoin-core-dev 03:45 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 03:45 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 03:45 -!- gfggg [c1a97dae@gateway/web/freenode/ip.193.169.125.174] has quit [Quit: Page closed] 03:52 -!- drizztbsd is now known as timothy 03:52 -!- mammonpan71 [871382ce@gateway/web/freenode/ip.135.19.130.206] has quit [Quit: Page closed] 03:54 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/11adab39e601...b62b437acd44 03:54 < bitcoin-git> bitcoin/master 76f344d practicalswift: logging: Fix potential use-after-free in LogPrintStr(...) 03:54 < bitcoin-git> bitcoin/master 0bd4cd3 practicalswift: logging: remove unused return value from LogPrintStr... 03:54 < bitcoin-git> bitcoin/master b62b437 Wladimir J. van der Laan: Merge #13148: logging: Fix potential use-after-free in LogPrintStr(...)... 03:55 < bitcoin-git> [bitcoin] laanwj closed pull request #13148: logging: Fix potential use-after-free in LogPrintStr(...) (master...logprintstr-uaf) https://github.com/bitcoin/bitcoin/pull/13148 03:56 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:58 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:00 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 04:00 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 04:00 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 04:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 04:05 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 248 seconds] 04:09 -!- ExtraCrispy [~ExtraCris@185.9.18.150] has joined #bitcoin-core-dev 04:18 -!- laurentmt [~Thunderbi@37.58.58.232] has quit [Quit: laurentmt] 04:23 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 04:23 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 04:24 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has quit [Ping timeout: 264 seconds] 04:26 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has joined #bitcoin-core-dev 04:38 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:39 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 04:40 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 04:42 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 04:43 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 04:44 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 04:46 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 04:46 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 04:48 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 04:48 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 04:50 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 04:51 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 04:59 -!- zautomata3 [~zautomata@41.232.221.192] has quit [Ping timeout: 265 seconds] 05:03 < bitcoin-git> [bitcoin] laanwj opened pull request #13157: test: Handle timestamps without microseconds in combine_logs (master...2018_05_logcombine_timestamps) https://github.com/bitcoin/bitcoin/pull/13157 05:04 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 05:05 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 05:06 -!- zautomata3 [~zautomata@41.232.221.192] has joined #bitcoin-core-dev 05:08 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 05:08 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 05:10 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 05:13 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has quit [Ping timeout: 255 seconds] 05:13 -!- laurentmt [~Thunderbi@37.58.58.232] has joined #bitcoin-core-dev 05:16 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 05:16 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 05:22 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 05:24 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 05:24 -!- zivl [~zivl@2601:19a:837f:e4e1:91a5:fbb0:3a18:ed59] has quit [Quit: zivl] 05:26 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 05:27 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 256 seconds] 05:30 -!- laurentmt [~Thunderbi@37.58.58.232] has quit [Quit: laurentmt] 05:34 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 05:34 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 05:39 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 05:40 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 05:40 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 05:50 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 05:57 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 05:58 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 06:00 -!- aknb [~aknb@vpn.ist.utl.pt] has joined #bitcoin-core-dev 06:03 -!- aknb [~aknb@vpn.ist.utl.pt] has left #bitcoin-core-dev ["WeeChat 1.4"] 06:04 -!- aknb [~aknb@vpn.ist.utl.pt] has joined #bitcoin-core-dev 06:10 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 268 seconds] 06:16 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has joined #bitcoin-core-dev 06:16 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 06:18 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 06:18 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 06:21 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 255 seconds] 06:25 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 06:26 -!- promag [~promag@83.223.251.90] has joined #bitcoin-core-dev 06:34 -!- laurentmt [~Thunderbi@37.58.58.232] has joined #bitcoin-core-dev 06:34 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 06:37 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 255 seconds] 06:38 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 06:38 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/b62b437acd44...7eb7076f7007 06:38 < bitcoin-git> bitcoin/master d76962e João Barbosa: rpc: Reduce cs_main lock in listunspent 06:38 < bitcoin-git> bitcoin/master a59dac3 João Barbosa: refactor: Avoid extra lookups of mapAddressBook in listunspent RPC 06:38 < bitcoin-git> bitcoin/master 7eb7076 Wladimir J. van der Laan: Merge #12639: Reduce cs_main lock in listunspent... 06:39 < bitcoin-git> [bitcoin] laanwj closed pull request #12639: Reduce cs_main lock in listunspent (master...2018-03-reduce-cs_main_lock-listunspent) https://github.com/bitcoin/bitcoin/pull/12639 06:44 < promag> wumpus: another one in the same line #12151 06:44 < gribble> https://github.com/bitcoin/bitcoin/issues/12151 | Remove cs_main lock from blockToJSON and blockheaderToJSON by promag · Pull Request #12151 · bitcoin/bitcoin · GitHub 06:45 -!- pergaminho [~Cleber@201.47.91.172] has joined #bitcoin-core-dev 06:45 <@wumpus> I'm done with locking refactors for a bit :) 06:45 < promag> ah! out of luck :D 06:45 < promag> maybe next month :D 06:46 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 06:46 <@wumpus> time to review #12979 06:46 < gribble> https://github.com/bitcoin/bitcoin/issues/12979 | Split validationinterface into paralell validation/mempool interfaces by TheBlueMatt · Pull Request #12979 · bitcoin/bitcoin · GitHub 06:46 -!- vicenteH [~user@123.red-83-58-239.dynamicip.rima-tde.net] has quit [Read error: Connection reset by peer] 06:47 -!- vicenteH [~user@123.red-83-58-239.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 06:47 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 06:47 -!- pergaminho [~Cleber@201.47.91.172] has quit [Remote host closed the connection] 06:50 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 06:51 < promag> allright :/ heh 06:53 -!- pergaminho [~Cleber@201.47.91.172] has joined #bitcoin-core-dev 06:53 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 264 seconds] 06:55 -!- tryphe_000 [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 06:56 < BlueMatt> promag: that still makes a ton more sense after 11913 06:59 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 256 seconds] 06:59 < promag> BlueMatt: you mean 12979 after 11913 or 12151 after 11913? 07:00 < promag> if you mean #12151 then yeah for sure 07:00 < gribble> https://github.com/bitcoin/bitcoin/issues/12151 | Remove cs_main lock from blockToJSON and blockheaderToJSON by promag · Pull Request #12151 · bitcoin/bitcoin · GitHub 07:01 < BlueMatt> 12151, yea 07:01 < promag> BlueMatt: 11913 needs rebase 07:01 < BlueMatt> yea, I've been lazy about rebasing a few of my prs that arent getting review cause some of the other are 07:02 < BlueMatt> oh, no, that one i should rebase 07:02 -!- tryphe_000 [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 07:02 < BlueMatt> ugh, k 07:02 -!- tryphe_000 [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 07:19 < bitcoin-git> [bitcoin] marcoagner opened pull request #13158: [qt]: Improve sendcoinsdialog readability (master...improve_sendcoinsdialog_readability) https://github.com/bitcoin/bitcoin/pull/13158 07:19 -!- pergaminho [~Cleber@201.47.91.172] has quit [Remote host closed the connection] 07:25 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 07:26 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 07:36 -!- promag [~promag@83.223.251.90] has quit [Remote host closed the connection] 07:38 -!- tryphe_000 [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 07:38 -!- tryphe_000 [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 07:40 -!- tryphe_000 [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 07:40 -!- tryphe_000 [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 07:43 -!- tryphe_000 [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 07:43 -!- laurentmt [~Thunderbi@37.58.58.232] has quit [Quit: laurentmt] 07:44 -!- tryphe_000 [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 07:45 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Remote host closed the connection] 07:49 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 07:52 -!- tryphe_000 [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 264 seconds] 07:57 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 07:59 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 240 seconds] 08:01 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 08:05 -!- sdaftuar [~sdaftuar@238.90.227.35.bc.googleusercontent.com] has joined #bitcoin-core-dev 08:08 -!- mistergold [~mistergol@77.243.22.139] has quit [Quit: leaving] 08:23 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 08:23 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Read error: Connection reset by peer] 08:23 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Read error: Connection reset by peer] 08:23 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Read error: Connection reset by peer] 08:23 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 08:23 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 08:25 -!- sdaftuar [~sdaftuar@238.90.227.35.bc.googleusercontent.com] has quit [Changing host] 08:25 -!- sdaftuar [~sdaftuar@unaffiliated/sdaftuar] has joined #bitcoin-core-dev 08:25 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 08:36 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 08:37 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 248 seconds] 08:47 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 248 seconds] 08:52 < bitcoin-git> [bitcoin] laanwj closed pull request #13157: test: Handle timestamps without microseconds in combine_logs (master...2018_05_logcombine_timestamps) https://github.com/bitcoin/bitcoin/pull/13157 08:54 -!- bsm1175321 [~mcelrath@173-9-124-61-NewEngland.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 08:54 -!- grafcaps [~haroldbr@104.137.194.255] has joined #bitcoin-core-dev 09:09 < bitcoin-git> [bitcoin] practicalswift opened pull request #13159: Don't close old debug log file handler prematurely when trying to re-open (on SIGHUP) (master...handle-reopen-failed) https://github.com/bitcoin/bitcoin/pull/13159 09:21 -!- bsm1175321 [~mcelrath@173-9-124-61-NewEngland.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 09:22 -!- promag [~promag@31.22.202.26] has joined #bitcoin-core-dev 09:28 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 09:30 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has quit [Quit: No Ping reply in 180 seconds.] 09:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 09:31 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 09:37 < bitcoin-git> [bitcoin] promag opened pull request #13160: Unlock spent outputs (master...2018-05-unlock-spent-output) https://github.com/bitcoin/bitcoin/pull/13160 09:41 -!- Randolf [~randolf@205.250.80.42] has joined #bitcoin-core-dev 09:42 < promag> rpc and wallet labels ^ 09:42 -!- promag [~promag@31.22.202.26] has quit [Remote host closed the connection] 09:52 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-biiuthamilfbgatk] has quit [Quit: Connection closed for inactivity] 10:11 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 10:21 < bitcoin-git> [bitcoin] real-or-random opened pull request #13161: wallet: Reset BerkeleyDB handle after connection fails (master...bdb-reset) https://github.com/bitcoin/bitcoin/pull/13161 10:33 -!- isis is now known as isis_ 10:34 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 10:35 -!- Randolf [~randolf@205.250.80.42] has quit [Ping timeout: 240 seconds] 10:36 -!- riemann [~riemann@abzb242.neoplus.adsl.tpnet.pl] has joined #bitcoin-core-dev 10:40 -!- riemann [~riemann@abzb242.neoplus.adsl.tpnet.pl] has quit [Client Quit] 10:42 -!- Randolf [~randolf@205.250.80.42] has joined #bitcoin-core-dev 10:42 < MarcoFalke> wumpus: (re out of tree tests) It works because test_runner.py is aware of the srcdir 10:43 < bitcoin-git> [bitcoin] jnewbery opened pull request #13162: [logging] Don't incorrectly log that REJECT messages are unknown. (master...fix_reject_logging) https://github.com/bitcoin/bitcoin/pull/13162 10:43 <@wumpus> but I eas not running test runner, that already worked before, but individual tests 10:43 < MarcoFalke> test_runner is linked from the srcdir, so we can follow that link 10:43 < MarcoFalke> hmm 10:43 < MarcoFalke> individual tests are not available in the build dir? 10:49 -!- leval2 [~leval2@178-189-172-157.adsl.highway.telekom.at] has joined #bitcoin-core-dev 10:49 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 10:50 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 10:51 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 11:06 -!- Randolf [~randolf@205.250.80.42] has quit [Ping timeout: 260 seconds] 11:09 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 11:11 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 11:17 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 11:21 <@wumpus> MarcoFalke: indeed, so used the full path to the source dir, and it works, no matter whether the current directory is in the build directory or the source one 11:22 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 268 seconds] 11:23 <@wumpus> MarcoFalke: apparently I have a test/config.ini in the source dir, pointing to the BUILDDIR 11:23 <@wumpus> MarcoFalke: not sure this is the intention, will wipe it and reconfiguer 11:23 < MarcoFalke> Yeah, otherwise it would fail 11:23 < MarcoFalke> the config.ini is required now 11:24 <@wumpus> shouldn't it be in the build dir, though? 11:24 <@wumpus> to be clear I think this is convenient, but it probably breaks the case where one source directory is used with multiple build dirs 11:25 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 11:29 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 248 seconds] 11:32 <@wumpus> or when configuring from a read-only source dir 11:32 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev 11:32 <@wumpus> ok, after reconfiguring the config.ini appears in the build dir, not the source dir, seems to have been an anomaly 11:34 -!- adiabat [~adiabat@63.209.32.102] has quit [Quit: WeeChat 1.4] 11:36 -!- adiabat [~adiabat@63.209.32.102] has joined #bitcoin-core-dev 11:38 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 11:41 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 11:41 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 11:43 < jamesob> cfields: would it make sense to at some point move logging into a separate thread? (about to look at your changes, but was just wondering) 11:43 <@wumpus> MarcoFalke: it looks like 'make clean' does not delete config.ini 11:43 < MarcoFalke> oh 11:43 < cfields> jamesob: yea, I think just about everyone has proposed that at some point, but nobody's done it :) 11:43 < MarcoFalke> and make distclean? 11:43 <@wumpus> MarcoFalke: what happened is probably: I configured the source dir, cleaned that, then configured in a separate build directory 11:44 < cfields> jamesob: might be a good topic for the meeting today, I'm sure there are lots of thoughts on that 11:44 < jamesob> cfields: welp, I'll add it to the list :) 11:44 < MarcoFalke> Yeah, that is what I assumed 11:44 < jamesob> cfields: cool, will bring it up 11:44 <@wumpus> distclean does remove it 11:44 < MarcoFalke> Usually you are asked to disclean before doing an out of tree build, at least I am 11:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 11:45 <@wumpus> yes 11:45 <@wumpus> I think that makes sense... 11:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 11:55 < sipa> i'm going to be 10-15 min late for keeting 11:55 < sipa> meeting 11:57 <@wumpus> ok 11:59 < MarcoFalke> Proposed short topic: Delete 0.8, 0.9 and 0.10 git branches 11:59 <@wumpus> ack 11:59 <@wumpus> oh 12:00 <@wumpus> #startmeeting 12:00 < lightningbot> Meeting started Thu May 3 19:00:10 2018 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot. 12:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 12:00 < promag> hi 12:00 < jamesob> hi 12:00 <@wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator 12:00 < jnewbery> hello 12:00 < kanzure> hi. 12:00 < achow101> hi 12:00 < cfields> hi 12:00 < jonasschnelli> hi 12:01 < jimpo> hi 12:01 < jcorgan> lurking as usual 12:01 <@wumpus> any other proposed topics? 12:01 < jamesob> logging at some point? 12:02 <@wumpus> what about logging? 12:02 < jamesob> I'd like to talk about moving it into a separate thread 12:02 <@wumpus> ok 12:02 < BlueMatt> #12934 12:02 < jnewbery> +1 to moving logging to a separate thread 12:02 < gribble> https://github.com/bitcoin/bitcoin/issues/12934 | [WIP] [net] [validation] Call ProcessNewBlock() asynchronously by skeees · Pull Request #12934 · bitcoin/bitcoin · GitHub 12:02 <@wumpus> let's start with the usual topic 12:03 <@wumpus> even though it will piss off BlueMatt :) 12:03 <@wumpus> #topic High prioriity for review 12:03 <@wumpus> https://github.com/bitcoin/bitcoin/projects/8 12:03 <@wumpus> only #12979 #12560 #10757 left now 12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/12979 | Split validationinterface into paralell validation/mempool interfaces by TheBlueMatt · Pull Request #12979 · bitcoin/bitcoin · GitHub 12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/12560 | [wallet] Upgrade path for non-HD wallets to HD by achow101 · Pull Request #12560 · bitcoin/bitcoin · GitHub 12:04 < gribble> https://github.com/bitcoin/bitcoin/issues/10757 | RPC: Introduce getblockstats to plot things by jtimon · Pull Request #10757 · bitcoin/bitcoin · GitHub 12:04 <@wumpus> anything to discuss about those? 12:04 <@wumpus> anything new to add? or remove? 12:04 < jimpo> I'd like #12254 to get some review :-) 12:04 < gribble> https://github.com/bitcoin/bitcoin/issues/12254 | BIP 158: Compact Block Filters for Light Clients by jimpo · Pull Request #12254 · bitcoin/bitcoin · GitHub 12:04 -!- LukeJr [~quassel@75.113.216.246] has joined #bitcoin-core-dev 12:05 < jnewbery> There's a whole series of sequential PRs on wallet load/create/unload. It'd be good to start moving through those, but I don't know how high priority they are for others 12:05 <@wumpus> jnewbery: if it's blocking anyone, the first one on the list should be on there at least 12:05 < jtimon> perhaps put the load one in high priority? 12:05 < jnewbery> #10740 12:05 < gribble> https://github.com/bitcoin/bitcoin/issues/10740 | [wallet] `loadwallet` RPC - load wallet at runtime by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub 12:06 < jnewbery> It's only blocking because there are other ones queued behind it 12:06 < BlueMatt> jnewbery: that is the most common form of blocking 12:06 <@wumpus> so it's blocking the continuation ones 12:06 < jimpo> That's basically the definition of blocking... 12:06 <@wumpus> right, it's pretty much the definition of blocking 12:06 <@wumpus> lol 12:06 < jonasschnelli> I agree that we should add 10740 to the list 12:06 <@wumpus> #10740 given me an unicorn though 12:06 < gribble> https://github.com/bitcoin/bitcoin/issues/10740 | [wallet] `loadwallet` RPC - load wallet at runtime by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub 12:07 < jonasschnelli> has also a unicorn, reload solved 12:07 <@wumpus> yes 12:07 < LukeJr> unicorns probably have a high street value 12:07 <@wumpus> added 12:07 < jnewbery> not any more. The market's been flooded 12:07 < BlueMatt> topic: 0.15.1 12:07 < LukeJr> shows what I know of unicorn markets 12:07 < BlueMatt> err 16 12:08 <@wumpus> LukeJr: yes, I"m trying to farm them and sell them, but I have more now than atoms in the knows universe so you could say the supply is more than the demand... 12:08 < promag> wumpus: could also add #13097 too? 12:08 < gribble> https://github.com/bitcoin/bitcoin/issues/13097 | ui: Support wallets loaded dynamically by promag · Pull Request #13097 · bitcoin/bitcoin · GitHub 12:08 <@wumpus> promag: ok 12:09 < promag> ty 12:09 <@wumpus> #topic Delete 0.8, 0.9 and 0.10 git branches 12:09 < MarcoFalke> Background: Those last tagged versions on those branches are EOL for more than a year now. The tags can be kept for archival reasons, but the branches are no longer required. See https://bitcoincore.org/en/lifecycle/#schedule 12:09 -!- clarkmoody [~clarkmood@47-218-248-206.bcstcmta04.res.dyn.suddenlink.net] has joined #bitcoin-core-dev 12:09 <@wumpus> yes 12:09 < BlueMatt> ack 12:09 <@wumpus> bye 12:10 < achow101> ack 12:10 < jonasschnelli> ack 12:10 < jtimon> I didn't know we still had those 12:10 < LukeJr> is the latest commit of each tagged? 12:10 < LukeJr> If not, maybe a 0.n_final tag is appropriate 12:10 < jonasschnelli> LukeJr: i hope so 12:10 <@wumpus> LukeJr: agree, will check that first 12:10 < cfields> er, are they not tagged from their respective branches? 12:11 < LukeJr> jonasschnelli: it wouldn't be the first time we have backported fixes and never released with them 12:11 < MarcoFalke> LukeJr: For the 0.8 one not 12:11 < MarcoFalke> The others are last tag == tip of branch, last time I checked 12:11 <@wumpus> will create a v0.8_final for that 12:11 <@wumpus> +tag 12:12 < LukeJr> maybe it can be a non-object tag, to avoid confusing users with a recent date 12:12 <@wumpus> yes fine with me, just to avoid losing history 12:12 < MarcoFalke> Oh, and the 0.9 one is missing one commit (upnp) 12:13 < sipa> back 12:13 -!- moneyball [~moneyball@2600:1010:b059:bb18:39e8:cf65:1c89:c39d] has joined #bitcoin-core-dev 12:13 <@wumpus> MarcoFalke: so same for 0.9 then 12:14 <@wumpus> #topic Moving logging to a separate thread (jamesob) 12:14 < jamesob> after working on #13099, I think it may be worthwhile to move logging into a separate thread 12:14 < gribble> https://github.com/bitcoin/bitcoin/issues/13099 | Use thread names in logs and deadlock diagnostics by jamesob · Pull Request #13099 · bitcoin/bitcoin · GitHub 12:15 < jamesob> esp. given instances like #12970 12:15 < BlueMatt> ACKACKACKACKACKACKACKACKACKACK (this is a surprisingly high lag-creator for miners, at least for those with spinning-disk-backed-or-cloud-hosted machines 12:15 < gribble> https://github.com/bitcoin/bitcoin/issues/12970 | logging: bypass timestamp formatting when not logging by theuni · Pull Request #12970 · bitcoin/bitcoin · GitHub 12:15 <@wumpus> queue log messages to a ring buffer ? 12:15 < jamesob> wumpus: sure, something along those lines 12:15 <@wumpus> gmaxwell has been proposing that for ages... 12:15 < BlueMatt> see-also commit which does this at https://github.com/bitcoinfibre/bitcoinfibre/commit/6b6a3aef0663775b63bac7d0aa07ec5fc4eb9fc9 12:15 < jnewbery> I started working on a branch for this last year, but didn't get very far 12:15 < jnewbery> definite concept ACK 12:15 <@wumpus> yes, concept ACK 12:16 < BlueMatt> I did not propose it upstream as it means if we LogPrintf(); assert(false) we'll likely miss it 12:16 -!- clarkmoody [~clarkmood@47-218-248-206.bcstcmta04.res.dyn.suddenlink.net] has quit [Remote host closed the connection] 12:16 < jnewbery> means the message processing thread can't be blocked on i/o hangs 12:16 < BlueMatt> and I figured folks wouldnt want that 12:16 < skeees> ACK - should point out that it could make crash debugging substantially more complicated 12:16 < BlueMatt> jnewbery: it still will be a ton cause it ReadBlockFromDisk()s 12:16 <@wumpus> BlueMatt: we could have special priority log calls that always make it to disk? 12:16 -!- clarkmoody [~clarkmood@47-218-248-206.bcstcmta04.res.dyn.suddenlink.net] has joined #bitcoin-core-dev 12:16 < jamesob> skeees: right, I think that's the only caveat I can think of 12:16 < LukeJr> BlueMatt: surely there's a way to run log flushing at assert 12:16 <@wumpus> BlueMatt: CriticalLogPrintf? 12:16 < promag> +1 BlueMatt point 12:16 < cfields> are there any possible interactions where someone might be tailing the log and assume that it's synchronous? 12:17 < jonasschnelli> use gdb 12:17 < BlueMatt> wumpus: I mean the number of times its been helpful just to see which lines actually made it to debug.log when someone submitted a crash is super helpful 12:17 < LukeJr> cfields: it couldn't be? 12:17 < BlueMatt> and gdb isnt really an option when debugging remotely over github issues :/ 12:17 < jimpo> Does anyone know the relative performance of logging to console vs debug log file? 12:17 < BlueMatt> jimpo: on non-serial-consoles, console logging should be fast, serial consoles can block 12:17 < LukeJr> in theory, we could fork() a logging-only process, but that feels ugly 12:17 < BlueMatt> (or vtt on a slow-refresh-monitor) 12:17 < sipa> We should fork a separate process for logging, and then open a FIFO with it and pipe the log data there. If bitcoind crashes, that process hopefully survives :) 12:18 < sipa> !hi5 LukeJr 12:18 < gribble> Error: "hi5" is not a valid command. 12:18 <@wumpus> it's mostly a win for low priority debugging messages, I guess 12:18 < BlueMatt> or we could just make it optional 12:18 <@wumpus> if logging is low volume it's never a bottleneck 12:18 < BlueMatt> miners can enable it, everyone else probably doesnt need to 12:18 <@wumpus> only miners that have debug=net enabled? 12:18 < skeees> just throwing out some alternatives with a properly tuned buffer cache - logging shouldn't hit disk that often? if its still flushing frequently - could consider a more compact binary format for logs - though that means you'd need a special tool to read them 12:19 < jimpo> I feel like disabling logging to file and piping stdout through tee or something should work fine 12:19 <@wumpus> skeees: well the logging is unbuffered at this moment so can't do much worse than that... 12:19 < BlueMatt> wumpus: I mean -debug should always mean non-async loggin, I think 12:19 < cfields> skeees: it's not just hitting disk, it's serialization as well. Though I guess we couldn't defer serialization if references are passed in. 12:19 <@wumpus> even line-buffered would be better for performance 12:20 < jamesob> wumpus: I thought fwrite was buffered? 12:20 <@wumpus> BlueMatt: right 12:20 < skeees> another option is to have debug logging compiled out 12:20 < skeees> instead of just disabled via flag as it is currently 12:20 <@wumpus> jamesob: yes, but the buffer is disabled after opening 12:20 < BlueMatt> I mean I dont think people who want performance dont want a debug.log 12:20 < BlueMatt> they just dont want it to result in 8-ms pauses 12:20 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 12:21 <@wumpus> skeees: that's not the issue; debug logging is already not executed if it's disabled 12:21 * LukeJr wonders if we skip serialization when the debug log level is such that it will not be logged 12:21 <@wumpus> skeees: even formatting is bypassed in that case 12:21 <@wumpus> LukeJr: yes 12:21 < skeees> LukeJr: yeah that's exactly the question i was trying to ask 12:21 < skeees> ah ok 12:21 < skeees> i dunno actually 12:22 <@wumpus> tbh I don't think there's an actual issue here 12:22 < skeees> because theres a lot of uint256.ToString() stuff 12:22 < cfields> operations on incoming vars aren't skipped though, I believe. Like LogPrint("foo: %s", foo.get()) 12:22 < BlueMatt> the only issue here is for folks who care a shitload about small disk pauses 12:22 <@wumpus> although the ring buffer would be nice because of gmaxwell's argument (log at higher debug message, but don't log the messages to disk unless a crash) 12:22 < BlueMatt> hence why I use it in fibre 12:22 < BlueMatt> when we get ReadBlockFromDisk to be async for peer handling, then it may make more sense to revisit this 12:23 <@wumpus> so a crash would log the last low-priority debug messages even if debugging is disabled.. then agian, it's not possible to bypass formatting anymore in that case 12:23 < BlueMatt> we'd have to swap assert() for dump_log_and_crash() 12:23 <@wumpus> not sure that even requires logging to be in a sepaerate thread 12:23 < LukeJr> wumpus: not sure if formatting is a big deal tbh 12:23 < LukeJr> BlueMatt: or handle SIGABRT? 12:23 < BlueMatt> no, but then I dont get to upstream my lockless ring buffer logger :p 12:23 <@wumpus> LukeJr: well some messages are extremely high volume 12:24 < BlueMatt> luke-jr: I dont think we want to do that much work in a signal handler 12:24 <@wumpus> LukeJr: try enabling *all* debugging for fun 12:24 < BlueMatt> matt@bitcoin-seednode:~$ ls -lha ~/.bitcoin/debug.log 12:24 < BlueMatt> -rw------- 1 matt matt 8.6T May 3 19:24 /home/matt/.bitcoin/debug.log 12:24 <@wumpus> heh 12:24 < sipa> how long? 12:24 < LukeJr> BlueMatt: if it's plain old C code, we can probably get away with it 12:25 <@wumpus> hence my proposal at some point to split up net logging into low and high volume messages 12:25 * jamesob buys BlueMatt a pair of socks with the logrotate manpage on them 12:25 < BlueMatt> sipa: 2014-11-19 00:06:55 12:25 <@wumpus> #12219 12:25 < gribble> https://github.com/bitcoin/bitcoin/issues/12219 | More granular net logging · Issue #12219 · bitcoin/bitcoin · GitHub 12:25 < cfields> wumpus: +1. Will have a look. 12:26 < BlueMatt> I do like the flush-debug-ring-to-disk-on-crash idea 12:26 <@wumpus> yes 12:26 < jamesob> +1 12:26 < BlueMatt> (would mean serializing all debug messages, though) 12:26 -!- echeveria [~echeveria@unaffiliated/echeveria] has quit [Ping timeout: 265 seconds] 12:26 < LukeJr> maybe even on non-crash critical errors 12:26 < BlueMatt> non-crash critical errors should crash :p 12:27 <@wumpus> it's in the word 'critical' 12:27 < jamesob> okay so unless anyone has any objections, I'll start working on a thread-consumes-from-ring-buffer implementation in the near future 12:28 <@wumpus> I think I killed the topic 12:28 <@wumpus> oh 12:28 < jnewbery> jamesob: ACK 12:28 < BlueMatt> jamesob: I think only as optional except for disabled-debug-messages 12:28 < jamesob> i.e. async logging should be opt-in? 12:28 < BlueMatt> jamesob: but if upstream wants to maintain by fibre patches, fine by me :p 12:28 < BlueMatt> yes 12:28 < BlueMatt> also, you may want to start with https://github.com/bitcoinfibre/bitcoinfibre/commit/6b6a3aef0663775b63bac7d0aa07ec5fc4eb9fc9 12:29 < jamesob> I'll give it a look, thanks 12:29 <@wumpus> #topic 0.16.1 (BlueMatt) 12:30 < BlueMatt> so for those who weren't paying attention, skeees found some particularly novel races in block handling in #13092 12:30 < gribble> https://github.com/bitcoin/bitcoin/issues/13092 | ActivateBestChain concurrency issues · Issue #13092 · bitcoin/bitcoin · GitHub 12:30 < BlueMatt> cause they're threading issues they almost certainly wont effect anyone except submitblock users 12:30 < BlueMatt> ie miners, and only rare races 12:30 < BlueMatt> but, still, I think given that and some of the other various fixes we've had, it may be worth backporting 12:31 <@wumpus> 13092 is an issue, not a PR, can't label it for backport 12:31 < BlueMatt> further, at least personally, I'd kinda like to see #11423 make some movement, and making that kind of policy change in a non-minor-version strikes me as weird 12:31 < gribble> https://github.com/bitcoin/bitcoin/issues/11423 | [Policy] Make OP_CODESEPARATOR and FindAndDelete in non-segwit scripts non-std by jl2012 · Pull Request #11423 · bitcoin/bitcoin · GitHub 12:31 < BlueMatt> yes, it needs a pr, sdaftuar has a branch, I believe, but not open 12:31 < sdaftuar> skeees has a pr, one sec 12:31 < skeees> #13023 12:31 < sdaftuar> #13023 12:31 < BlueMatt> was the skeees pr updated for the new method? 12:31 < gribble> https://github.com/bitcoin/bitcoin/issues/13023 | Always refresh most work chain when reacquiring cs_main in ActivateBestChain() by skeees · Pull Request #13023 · bitcoin/bitcoin · GitHub 12:31 < gribble> https://github.com/bitcoin/bitcoin/issues/13023 | Always refresh most work chain when reacquiring cs_main in ActivateBestChain() by skeees · Pull Request #13023 · bitcoin/bitcoin · GitHub 12:31 < sdaftuar> no we need to settle on the right fix 12:32 < skeees> still needs a bit of work - i need to pull in some fixes @sdaftuar made 12:32 < sdaftuar> i think the fix i proposed works, but maybe someone has a better idea 12:32 <@wumpus> ok added tags 12:32 < BlueMatt> ok, yes, I think that is doable, however, and I think between that and making progress on the standardness changes from jl2012 probably are worth a minor bump 12:32 < skeees> there's also #12988 - which is a similar type of bug 12:32 < gribble> https://github.com/bitcoin/bitcoin/issues/12988 | Hold cs_main while calling UpdatedBlockTip() signal by skeees · Pull Request #12988 · bitcoin/bitcoin · GitHub 12:33 < BlueMatt> yes, indeed, that too 12:33 < sdaftuar> agreed 12:33 <@wumpus> ok 12:33 < BlueMatt> (so, obviously, for those following along at home, next-milestone usually gets auto-high-priority-for-review status :p) 12:34 <@wumpus> re: #11423, I rebased that one for jl2012, not sure if there's further things to be done there 12:34 < gribble> https://github.com/bitcoin/bitcoin/issues/11423 | [Policy] Make OP_CODESEPARATOR and FindAndDelete in non-segwit scripts non-std by jl2012 · Pull Request #11423 · bitcoin/bitcoin · GitHub 12:35 <@wumpus> added 0.16.1 tag there too 12:35 < BlueMatt> I believe jl2012 wanted to add one more policy rule there, which should be done, there was a branch floating around but I cant find it atm 12:35 < BlueMatt> anyway, thats for discussion on that pr 12:35 < BlueMatt> I'll ping jl2012 since he's probably asleep 12:36 < BlueMatt> anyway, seems no disagreement, so next topic? 12:36 <@wumpus> yes, but it is the open PR with the most (ut)ACKs so I thought it'd be almost ready for merge 12:36 <@wumpus> that's why I rebased it with the idea to merge it after final review 12:36 <@wumpus> but ok 12:36 < MarcoFalke> Yeah, would need some re-ACKs first, though 12:37 <@wumpus> right, but if the goalposts keep moving 12:37 <@wumpus> I think we've exhausted all proposed topics 12:37 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-icuusyqzgthujnta] has joined #bitcoin-core-dev 12:37 < MarcoFalke> If there are minor fix ups, they should probably happen soon 12:38 < BlueMatt> oh, no, wait i had another topic 12:38 < BlueMatt> topic: activate segwit 12:38 < BlueMatt> topic 2: #12934 12:38 < gribble> https://github.com/bitcoin/bitcoin/issues/12934 | [WIP] [net] [validation] Call ProcessNewBlock() asynchronously by skeees · Pull Request #12934 · bitcoin/bitcoin · GitHub 12:39 < BlueMatt> its certainly not ready for review, but we should maybe have a discussion about what concurrency across peers is gonna look like 12:39 <@wumpus> #topic Call ProcessNewBlock() asynchronously (skeees) 12:39 < BlueMatt> there are two main approaches, but both end up requiring similar refactors for the majority of their work 12:39 < BlueMatt> in the past I've looked at doing ProcessMessages() in parallel 12:40 < BlueMatt> in this pr skeees moves the validation processing of txn/blocks into a queue and does that in a separate thread 12:40 < sipa> how does that interact with eg sending a ping after a block, and expecting it to be processed after the pong returns? 12:40 < BlueMatt> in both cases, we end up building logic to "pause" processing of a peer until whatever message it just generated has been processed 12:40 <@wumpus> that sounds sensible, though I'm really afraid of c++ threading 12:40 < BlueMatt> sipa: ^ 12:40 < gmaxwell> Seems like it would add more locking overhead. 12:40 < BlueMatt> (which would also likely be useful for eg ReadBlockFromDisk moving to be more async) 12:41 < sipa> sound reasonable to me 12:41 < BlueMatt> and a ton of logic to move CNodeState out of cs_main (likely by creating a CNodeState2 during transision) 12:41 < BlueMatt> cfields: may have more thoughts 12:41 < sipa> that sounds even better 12:41 < skeees> the other side benefit of this approach is that ultimately it may simplify the concurrency model inside validation 12:41 < sipa> though everything depends on the details... 12:42 < BlueMatt> gmaxwell: indeed, thats a major difference between the skeees approach and the parallel ProcessMessages approach 12:42 < skeees> having a single thread processing from an ordered queue would have also solved the concurrency issues discussed before 12:42 < BlueMatt> ProcessMessages will still do the work on the processing thread, which should have a bit less locking overhead 12:42 < cfields> BlueMatt: just reading now. at a glance, this approach sounds similar to what I had in mind as well 12:42 < BlueMatt> but is definitely more complicated than the skeees approach 12:42 < BlueMatt> which draws a much cleaner boundary between validation and net_processing 12:42 < gmaxwell> The biggest gain I'm aware of from concurrency is that right now when connecting multiple blocks at a time (due to out of order fetching in IBD) we stop downloading new blocks, ... fixing that would be a big gain; so it might be worth prioritizing improvements that would let that happen. 12:42 < cfields> BlueMatt: I don't see why they'd be mutually exclusive? 12:43 < BlueMatt> gmaxwell: that and relaying compact block gettxn during block connection 12:43 < BlueMatt> which is the one big cheapish win left for block-relay-latency 12:43 < gmaxwell> (e.g. esp when fetching from slow peers, watching network traffic during IBD is comical... transfering at only a couple mbps for a while then nothing for seconds at a time while it connects) 12:43 < BlueMatt> cfields: well doing both is maybe not so useful 12:43 < BlueMatt> since they'd accomplish largely the same thing 12:44 -!- leval2 [~leval2@178-189-172-157.adsl.highway.telekom.at] has quit [Quit: Leaving] 12:44 < gmaxwell> BlueMatt: Fair enough for gettxn, though right now my own node makes almost no gettxn requests... and orphaning rates appear to be exceptionally low. 12:44 < gmaxwell> (so what I'm saying is that at the moment I don't think of latency improvements as that critical) 12:44 < BlueMatt> gmaxwell: the skeees approach is certainly better for doing things like deserialization of blocks coming in from other peers while calling ProcessNewBlock/ActivateBestChain 12:44 < BlueMatt> indeed, right now (with mempool ~empty) compact block performance is ~perfect 12:44 < BlueMatt> its not always so, however 12:45 < gmaxwell> hm. interesting point that making deserialization concurrent would potentially be a multi-core gain. 12:45 < BlueMatt> also, fibre nodes see more getblocktxn than miners 12:45 < sipa> by "mempool ~empty" you mean "mempool is a perfect match" ? 12:45 < BlueMatt> which would be equally solved by miners delaying 1 second before including new txn in blocks.... 12:45 < gmaxwell> sipa: if each block mostly clears the mempool, miner-specific prioritizaition of transactions doesn't cause as much surprise txn. 12:46 < gmaxwell> BlueMatt: and also making use of the CB facility for transmitting extra txn proactively. 12:46 < BlueMatt> yea, that too 12:46 < BlueMatt> anyway, so tl;dr: I was a bigger fan of the skeees approach and wanted a little bit of concept discussion on the idea of putting a queue in front of the entire validation stuff 12:46 < BlueMatt> since thats a huge departure from current operation 12:47 < BlueMatt> but I think the potential gain is nice 12:47 < BlueMatt> plus all our blocks are already passed in as shared_ptrs anyway..... 12:47 < gmaxwell> so right my point was that speading up IBD is probably a big win, .. improving latency and what not would be nice too but I think it's less important. 12:47 < LukeJr> +1 12:47 < BlueMatt> yes, right now that is definitely true 12:47 < BlueMatt> certainly this has the potential to address both, however 12:47 < gmaxwell> making use of more cores during sync would be nice too, e.g. if deserilization and hashing can happen on seperate threads async with connection. 12:48 < BlueMatt> we can do CheckBlock on the net_processing thread 12:48 < BlueMatt> (since, and sipa is gonna die a little bit inside, here, the result is cached in the CBlock structure) 12:48 < sdaftuar> that is kinda gross :) 12:48 < BlueMatt> its incredibly gross 12:48 < gmaxwell> (e.g. multiple message handling threads, which do deserialization and maybe stateless checks) 12:49 <@wumpus> oh no... 12:49 < bitcoin-git> [bitcoin] practicalswift opened pull request #13163: Make it clear which functions that are intended to be translation unit local (master...internal-linkage) https://github.com/bitcoin/bitcoin/pull/13163 12:49 < gmaxwell> though I did a dumb hack a while back that reordered some of the block validation steps to interleave checks that operate per transaction and got a few percent sync speed improvement... we should be mindful of memory locality and not introduce even more passes over blocks. 12:50 < BlueMatt> gmaxwell: dunno about multiple message handling threads being doable in the immediate future, but doing CheckBlock on the message processing thread (which does merkle root verification, which is a good chunk of the work) may be worth a chunk 12:50 < skeees> cool - so if no strong objections or concerns with the approach i'll continue this and come back when its more ready for review 12:51 < gmaxwell> Funny, I would have thought handling seperate peers in seperate threads would almost just work now, vs stuff that handled messages from the same peer concurrently, which violates protocol assumptions about ordering without special work to add processing barriers. 12:51 < BlueMatt> gmaxwell: CNodeState requires cs_main, so....not even close :( 12:51 < gmaxwell> (almost just work, because the critical data structues have locks ... oh CNodeState) 12:51 < BlueMatt> I've got some old branches that do that, if you want to look 12:51 < gmaxwell> cs_main lite. 12:51 < BlueMatt> but they're....not small changes 12:52 < BlueMatt> and cfields hates them, though he's probably right 12:52 < BlueMatt> anyway, so ["DIE", "XML"]? 12:52 < gmaxwell> in particular our most commons messages are transaction invs and get datas, and those should only need mempool stuff for much of their activity. 12:52 < gmaxwell> k. 12:52 < BlueMatt> gmaxwell: yes, I did all that in an old branch 12:52 < BlueMatt> that in particular is much closer than it used to be 12:52 < BlueMatt> cause now the HandleGetData stuff cant take cs_main at the top 12:53 < BlueMatt> IIRC that refactor landed for 0.16 12:54 < BlueMatt> https://github.com/TheBlueMatt/bitcoin/commits/2017-07-paralell-processmessages-redux 12:54 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 12:55 < gmaxwell> Thanks. 12:55 < BlueMatt> (it got a bunch of time in helgrind, too, and got all the issues fixed, so I'm at least kinda confident in it, but its essentially unreviewable, even by my standards) 12:56 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 12:56 -!- moneyball [~moneyball@2600:1010:b059:bb18:39e8:cf65:1c89:c39d] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 12:57 <@wumpus> #endmeeting 12:57 < lightningbot> Meeting ended Thu May 3 19:57:40 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 12:57 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-05-03-19.00.html 12:57 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-05-03-19.00.txt 12:57 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-05-03-19.00.log.html 12:57 < gmaxwell> I think it would be simpler now, a lot of changes in the last year would have made it easier (I say this without having recently looked at that branch) 12:57 -!- aknb [~aknb@vpn.ist.utl.pt] has quit [Ping timeout: 240 seconds] 12:58 < BlueMatt> yes, I agree 12:58 < BlueMatt> rather significantly 12:58 < BlueMatt> and if we took the "split CNodeState" approach instead of "pull CNodeState above cs_main in global lock order and give it its own lock all in one go" approach that that branch takes, it'd likely be wayyy simpler 13:00 -!- LukeJr [~quassel@75.113.216.246] has quit [Read error: Connection reset by peer] 13:08 -!- laurentmt [~Thunderbi@37.58.58.232] has joined #bitcoin-core-dev 13:12 < bitcoin-git> [bitcoin] laanwj deleted 0.9 at 460ccfb: https://github.com/bitcoin/bitcoin/commit/460ccfb 13:12 < bitcoin-git> [bitcoin] laanwj deleted 0.10 at 9cea169: https://github.com/bitcoin/bitcoin/commit/9cea169 13:12 <@wumpus> :x 13:12 < sdaftuar> neat 13:23 -!- jpe_ [~jpe@83-167-250-20.static.masterinter.net] has joined #bitcoin-core-dev 13:23 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 13:28 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 13:29 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 13:30 -!- Randolf [~randolf@24.244.23.214] has joined #bitcoin-core-dev 13:34 -!- jpe__ [~jpe@p2E508ABE.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 13:37 -!- jpe_ [~jpe@83-167-250-20.static.masterinter.net] has quit [Ping timeout: 256 seconds] 13:39 -!- Randolf [~randolf@24.244.23.214] has quit [Ping timeout: 248 seconds] 13:48 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 13:50 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 13:50 -!- timothy [~tredaelli@redhat/timothy] has quit [Client Quit] 13:51 -!- ExtraCrispy [~ExtraCris@185.9.18.150] has quit [Quit: ExtraCrispy] 14:02 -!- jpe__ [~jpe@p2E508ABE.dip0.t-ipconnect.de] has quit [Quit: Leaving] 14:20 < bitcoin-git> [bitcoin] jamesob closed pull request #13099: Use thread names in logs and deadlock diagnostics (master...2018-04-26-use-threadnames) https://github.com/bitcoin/bitcoin/pull/13099 14:23 < cfields> jamesob: noo! 14:23 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds] 14:25 < cfields> jamesob: I hope you don't think I'm being NIH about that PR, that wasn't my intention at all. Coding up an alternative myself helps me to understand the challenges better, it wasn't meant to replace your work. 14:26 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 14:51 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 15:00 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 240 seconds] 15:13 -!- laurentmt [~Thunderbi@37.58.58.232] has quit [Quit: laurentmt] 15:13 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Remote host closed the connection] 15:16 -!- spinza [~spin@102.177.145.17] has quit [Quit: Coyote finally caught up with me...] 15:20 <@wumpus> "Note: GitHub Services are being deprecated. Please contact your integrator for more information on how to migrate or replace a service to webhooks or GitHub Apps. " 15:20 <@wumpus> I wonder if that means the IRC notification bot will disappear 15:21 < luke-jr> isn't it a webhook? 15:22 <@wumpus> no 15:23 <@wumpus> it's under "integrations and services" which displays that 15:27 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 15:28 -!- spinza [~spin@102.177.145.17] has joined #bitcoin-core-dev 15:32 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 265 seconds] 15:35 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 15:36 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 15:42 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 256 seconds] 15:42 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 15:43 < luke-jr> IRC notifications of projects seems to have mostly died with CIA :< 15:46 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 15:52 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 15:57 -!- jonhya [574e437d@gateway/web/freenode/ip.87.78.67.125] has joined #bitcoin-core-dev 15:57 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 16:00 -!- jonhya [574e437d@gateway/web/freenode/ip.87.78.67.125] has quit [Client Quit] 16:12 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 264 seconds] 16:13 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 16:17 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Remote host closed the connection] 16:20 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 264 seconds] 16:26 -!- clarkmoody [~clarkmood@47-218-248-206.bcstcmta04.res.dyn.suddenlink.net] has quit [] 16:27 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Quit: drexl] 16:29 -!- grafcaps [~haroldbr@104.137.194.255] has quit [Ping timeout: 240 seconds] 16:31 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 16:39 < jamesob> cfields: oh no not at all! sorry if the PR close came off as me being upset 16:40 < jamesob> cfields: I just like your commits better :). Maybe I can cherry-pick them and then shuffle in my GetProcessName/SetProcessName stuff + some tests 16:40 < jamesob> if that sounds good, would it make sense to repurpose that same PR or open a new one? 16:43 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 16:44 < cfields> jamesob: ok, good 16:45 < cfields> jamesob: if you're going to do away with the suffix handling, I'd say just do a new PR 16:45 < cfields> jamesob: either way, my code is all yours if you like it 16:48 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 240 seconds] 16:53 < jamesob> cfields: yeah, should be easy to incorporate the suffix stuff inline as you suggest 16:57 < jamesob> just felt embarrassed I didn't see that earlier :) 17:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:06 < cfields> jamesob: heh, no worries 17:07 < cfields> sipa: it just occured to me that Span is begging to be used for scatter/gather 17:07 -!- isis_ is now known as isis 17:07 < sipa> ha, yes 17:08 < cfields> Span& even casts perfectly to iovec* 17:09 < cfields> trying to decide if we should encourage that with a helper, or encourage iovec vec(span.data(), span.size()) instead. 17:10 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 276 seconds] 17:11 < cfields> https://0bin.net/paste/gRcNPbxui+WjB-jK#rXShNTSfMZHh6hZXiUbjxHBzcUwb4dXmy2J3aUYkBzR 17:12 < sipa> that sounds awefully platform specific 17:12 < sipa> *awfully? 17:13 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Remote host closed the connection] 17:13 < cfields> i think it's pretty universal, the struct padding is the only thing i can see practically changing... 17:14 < cfields> but I guess you're right, it doesn't save much 17:14 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-eikbyzspiwpnkiho] has joined #bitcoin-core-dev 17:35 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 17:38 -!- moneyball [~moneyball@c-73-223-73-149.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 17:40 -!- moneyball [~moneyball@c-73-223-73-149.hsd1.ca.comcast.net] has quit [Client Quit] 17:48 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 17:51 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 18:04 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 18:08 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 18:09 -!- DrFeelGood [~DrFeelGoo@unaffiliated/olufunmilayo] has quit [Ping timeout: 240 seconds] 18:10 < fanquake> pierre_rochard nice rupdates to bitcoinacks so far. 18:18 < pierre_rochard> Thanks fanquake! ICYMI: https://bitcoinacks.com/ I have a few ideas for the next big iteration ( https://github.com/PierreRochard/bitcoin-acks/blob/acks/README.md ), happy to add more if you have anything that is dragging you down as a contributor/reviewer/maintainer. Something I was thinking about during today’s meeting was surfacing High Priority for review PRs in the UI. 18:26 < fanquake> pierre_rochard Cool, I'll take a look. Even something as simple as a different background colour on the High Priority PRs might work. 18:29 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 18:29 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 19:15 < bitcoin-git> [bitcoin] fanquake opened pull request #13165: doc: Mention good first issue list in CONTRIBUTING.md (master...good-first-issue) https://github.com/bitcoin/bitcoin/pull/13165 19:16 < luke-jr> pierre_rochard: not forcing the horizontal scrollbar off would be nice 19:16 < luke-jr> and some way to hide closed PRs 19:17 < luke-jr> not sure why adding a filter for Closed insists on the value being a date O.o 19:23 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 20:02 -!- furnace [b4a987fb@gateway/web/freenode/ip.180.169.135.251] has joined #bitcoin-core-dev 20:04 -!- furnace [b4a987fb@gateway/web/freenode/ip.180.169.135.251] has left #bitcoin-core-dev [] 20:27 < fanquake> Not the most useful error message for Core to spit out heh: https://0bin.net/paste/fIINOwfRR9GIR-SZ#c7Sx1+EM3HJjYaTx0C6c5Exa6MYt7AIO-RweISgWZcG 20:27 < fanquake> Looking at #13161, there seems to be a case where even after a database error Core just continues on, and then segfaults at shutdown. 20:27 < gribble> https://github.com/bitcoin/bitcoin/issues/13161 | wallet: Reset BerkeleyDB handle after connection fails by real-or-random · Pull Request #13161 · bitcoin/bitcoin · GitHub 20:59 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 248 seconds] 21:18 -!- thrasher`` [~thrasher@unaffiliated/thrasher/x-7291870] has quit [Quit: ZNC - 1.6.0 - http://znc.in] 21:23 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 264 seconds] 22:11 < ken2812221> fanquake: That happened while I was testing #12985 if Bitcoin Core cannot write wallet file 22:11 < gribble> https://github.com/bitcoin/bitcoin/issues/12985 | Windows: Avoid launching as admin when NSIS installer ends. by JeremyRand · Pull Request #12985 · bitcoin/bitcoin · GitHub 22:15 -!- gmaxwell [gmaxwell@mf4-xiph.osuosl.org] has joined #bitcoin-core-dev 22:16 -!- Bosma [sid103570@gateway/web/irccloud.com/x-lxytfnveimsjhiyb] has joined #bitcoin-core-dev 22:16 -!- gmaxwell is now known as Guest9910 22:16 -!- Netsplit over, joins: mdrollette, MarcoFalke, Megumiin, felco, DougieBot5000, Apocalyptic 22:18 -!- infernix [nix@unaffiliated/infernix] has quit [Ping timeout: 260 seconds] 22:18 -!- spinza [~spin@102.177.145.17] has quit [Ping timeout: 260 seconds] 22:25 -!- nsh [~lol@wikipedia/nsh] has joined #bitcoin-core-dev 22:26 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-icuusyqzgthujnta] has quit [Quit: Connection closed for inactivity] 22:27 -!- spinza [~spin@102.177.145.17] has joined #bitcoin-core-dev 22:35 -!- DrFeelGood [~DrFeelGoo@unaffiliated/olufunmilayo] has joined #bitcoin-core-dev 22:37 -!- infernix [nix@unaffiliated/infernix] has joined #bitcoin-core-dev 22:40 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has quit [Ping timeout: 276 seconds] 22:47 -!- LeMiner [~LeMiner@unaffiliated/leminer] has joined #bitcoin-core-dev 22:51 -!- JackH_ [~laptop@host-80-47-85-84.as13285.net] has joined #bitcoin-core-dev 22:52 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 22:53 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 22:53 -!- JackH [~laptop@host-80-47-81-190.as13285.net] has quit [Ping timeout: 256 seconds] 23:08 -!- amiller [~socrates1@unaffiliated/socrates1024] has quit [Ping timeout: 256 seconds] 23:26 -!- Guest9910 [gmaxwell@mf4-xiph.osuosl.org] has quit [Changing host] 23:26 -!- Guest9910 [gmaxwell@wikimedia/KatWalsh/x-0001] has joined #bitcoin-core-dev 23:27 -!- Guest9910 is now known as gmaxwell 23:38 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 23:41 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 23:47 -!- LeMiner2 [~LeMiner@ip-213-127-111-3.ip.prioritytelecom.net] has joined #bitcoin-core-dev 23:51 -!- LeMiner [~LeMiner@unaffiliated/leminer] has quit [Ping timeout: 264 seconds] 23:51 -!- LeMiner2 is now known as LeMiner 23:55 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev