--- Day changed Tue May 15 2018 00:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 00:03 -!- bzb [~bzb@135.23.193.53] has joined #bitcoin-core-dev 00:07 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 276 seconds] 00:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 00:08 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 00:17 -!- glaksmono [~glaksmono@114.124.241.217] has joined #bitcoin-core-dev 00:18 -!- Randolf [~randolf@96.53.47.38] has quit [Ping timeout: 240 seconds] 00:18 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 00:21 -!- BGL [twenty@75-149-171-58-Washington.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 00:23 -!- bzb [~bzb@135.23.193.53] has quit [Quit: Leaving] 00:27 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 260 seconds] 00:28 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 00:28 < fanquake> thanks aj 00:29 < fanquake> wumpus I just assumed you'd finally started to ignore me :p 00:29 < wumpus> fanquake: you were talking to a ghost :) 00:31 < fanquake> :o well if the real wumpus is back, I think #13234 can go in 00:31 < gribble> https://github.com/bitcoin/bitcoin/issues/13234 | Break circular dependency: chain -> pow -> chain by Empact · Pull Request #13234 · bitcoin/bitcoin · GitHub 00:33 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has joined #bitcoin-core-dev 00:36 < wumpus> fanquake: the real wumpus, or at least a newly-checked out clone. But I'll take a look. 00:39 -!- zarez1 [~Thunderbi@fs-93-93-44-38.fullsave.info] has joined #bitcoin-core-dev 00:40 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/81c533c6f481...3b84ebb5bc0d 00:40 < bitcoin-git> bitcoin/master 5b35b92 Ben Woosley: Break circular dependency: chain -> pow -> chain... 00:40 < bitcoin-git> bitcoin/master 3b84ebb Wladimir J. van der Laan: Merge #13234: Break circular dependency: chain -> pow -> chain... 00:41 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has quit [Ping timeout: 276 seconds] 00:41 -!- zarez1 is now known as zarez 00:41 < bitcoin-git> [bitcoin] laanwj closed pull request #13234: Break circular dependency: chain -> pow -> chain (master...chain-pow-chain) https://github.com/bitcoin/bitcoin/pull/13234 00:44 -!- bzb [~bzb@135-23-193-53.cpe.pppoe.ca] has joined #bitcoin-core-dev 00:45 -!- gary [43b4c5d2@gateway/web/freenode/ip.67.180.197.210] has joined #bitcoin-core-dev 00:46 -!- gary is now known as Guest34043 00:49 -!- Guest34043 [43b4c5d2@gateway/web/freenode/ip.67.180.197.210] has quit [Client Quit] 00:51 -!- glaksmono [~glaksmono@114.124.241.217] has quit [Remote host closed the connection] 00:52 -!- glaksmono [~glaksmono@114.124.203.201] has joined #bitcoin-core-dev 00:56 -!- glaksmono [~glaksmono@114.124.203.201] has quit [Read error: Connection reset by peer] 01:01 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 264 seconds] 01:01 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 01:03 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 01:33 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:33 -!- jtimon [~quassel@52.29.134.37.dynamic.jazztel.es] has quit [Ping timeout: 268 seconds] 01:37 -!- laurentmt [~Thunderbi@37.58.58.232] has joined #bitcoin-core-dev 01:40 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:40 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 256 seconds] 01:40 < bitcoin-git> [bitcoin] kallewoof closed pull request #12966: [WIP] Mempool optimized feerate (master...mempool-optimized-feerate) https://github.com/bitcoin/bitcoin/pull/12966 01:43 < kallewoof> wumpus: Is it possible to add #12634 to the high priority list? It would be very helpful in trimming down the output group (bundle address reuse UTXO) PR. 01:43 < gribble> https://github.com/bitcoin/bitcoin/issues/12634 | [refactor] Make TransactionWithinChainLimit more flexible by kallewoof · Pull Request #12634 · bitcoin/bitcoin · GitHub 01:44 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:50 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 276 seconds] 01:58 < harding> jonasschnelli, wumpus: for the website, the GitHub is setup so that I can't merge my own PRs unless they have an "Approve" review from someone else with commit access. The following PR numbers there have ACKs from known contributors and so are just waiting for someone besides me with commit access to Approve them: 546, 547, 550, 551, 552, and 553. 02:01 -!- drizztbsd is now known as timothy 02:02 < fanquake> kallewoof I've added it 02:05 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Ping timeout: 268 seconds] 02:05 -!- StopAndDecrypt [~StopAndDe@c-73-215-253-208.hsd1.nj.comcast.net] has joined #bitcoin-core-dev 02:05 -!- StopAndDecrypt [~StopAndDe@c-73-215-253-208.hsd1.nj.comcast.net] has quit [Changing host] 02:05 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev 02:13 < kallewoof> fanquake: Thanks 02:15 -!- bzb [~bzb@135-23-193-53.cpe.pppoe.ca] has quit [Quit: Leaving] 02:17 < murrayn> any chance 02:17 < murrayn> of getting some feedback on 12881? 02:17 < promag> murrayn: i think it's mergeable 02:18 < murrayn> yes i saw your utACK, thanks 02:21 < promag> murrayn: np, you can pay me by reviewing #13193 x) 02:21 < gribble> https://github.com/bitcoin/bitcoin/issues/13193 | Avoid 2nd mapTx lookup in CTxMemPool::UpdateTransactionsFromBlock by promag · Pull Request #13193 · bitcoin/bitcoin · GitHub 02:21 < wumpus> kallewoof: sure - I think it's usually most helpful to discuss the high priority list during the meeting, but we can do it in-between if you're in a hurry. Oh I see someone already added it anyway :) 02:21 < wumpus> harding: yes I'm extremely behind on website review, will take a look! 02:22 < kallewoof> wumpus: Yeah, I just tend to not be awake 4 am. I am trying to pull it off though. Maybe this week... 02:22 < wumpus> kallewoof: yes that's a crazy time, if you can't make it, no problem 02:24 < kallewoof> wumpus: It should be doable, but I tend to wake up late. 4 am is usually a few hours after I fall asleep :) 02:26 < wumpus> murrayn: I haven't looked at it since my comment about locale-specific functions, will re-review 02:36 < wumpus> murrayn: what was your motivation for optimizing bech32::Decode? is this on any critical path? 02:36 < bitcoin-git> [bitcoin] ken2812221 opened pull request #13236: break circular dependency: random -> util -> random (master...random_util) https://github.com/bitcoin/bitcoin/pull/13236 02:41 < wumpus> harding: looks like the problem is also that people are using ACKs, not the approval system 02:42 < wumpus> should probably become routine in that repository that people who utACK/ACK also 'approve' the PR 02:42 < wumpus> unfortunately github doesn't count in-text ACKs 02:43 < murrayn> promag, i have reviewed 13193 02:43 < murrayn> wumpus, the original motivation was just something that caught my eye as an optimization. 02:47 < wumpus> murrayn: right, I see your point, but at some point I wonder about the cognitive load of reviewing that a change is correct versus the reason to make it 02:52 < wumpus> murrayn: so your conclusion in https://github.com/bitcoin/bitcoin/pull/12881#issuecomment-383039089 is pretty much "it doesn't matter if compiler optimizations are enabled" 02:57 -!- lio17 [~lio17@80.ip-145-239-89.eu] has quit [Ping timeout: 240 seconds] 02:59 < murrayn> wumpus, yes i see your point re: the cognitive load. in this case the change and its effect is very localized. 03:01 < wumpus> there's certainly a place for micro-optimizations, but I'm not sure this is it 03:01 -!- glaksmono [~glaksmono@158.140.182.56] has joined #bitcoin-core-dev 03:01 < wumpus> I agree it's a very localized change, sure 03:02 < harding> wumpus: true about ACKs versus Approvals, although I think most of the ACKs on those PRs are from people without commit access, so GitHub doesn't wouldn't count their Approves towards unlocking mergability. That's a bit unfortunate to my mind, as I think it somewhat discourages people who don't alreday have commit access from reviewing. 03:03 < wumpus> murrayn: anyhow I'm going to ACK it - but please next time if you optimize, try to find something that is on the critical path (e.g. validation) and can clearly demonstrate improvement 03:04 < wumpus> murrayn: and this makes the code somewhat easier to read, that's good 03:05 < wumpus> harding: oh, I didn't know only approvals of repo members counted. Maybe we should remove this github-side requirement and leave it up to the committer to count the ACKs? 03:06 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 03:08 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 03:09 < murrayn> wumpus, ACK. as sipa pointed out, it's not an important function to optimize, so it does come down to readability. 03:09 < wumpus> murrayn: apart from validation there's some other things that would benefit from optimization: for example some GUI things with regard to handling lots of transactions/addresses, network code, RPC/web server latency 03:10 < wumpus> handling of large wallets 03:10 < murrayn> wumpus, i'm working on it, getting my feet wet :-) 03:11 < harding> wumpus: I'm in favor of that. I initially thought it was a security requirement, and it makes sense to me that you'd want to prevent any person from unilaterally pushing to the master branch for a live-deployed website. But then I realzed how easy it would be to circumvent by creating a secondary account to open PRs from, so I'd prefer to indeed just do the usual 'count PRs from known contributors and ensure there are enough 03:11 < harding> given the impact of the PR'. 03:11 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3b84ebb5bc0d...1d4662f5dcf6 03:11 < bitcoin-git> bitcoin/master 60f61f9 murrayn: Tighten up bech32::Decode(); add tests. 03:11 < bitcoin-git> bitcoin/master 1d4662f Wladimir J. van der Laan: Merge #12881: Minor optimizations to bech32::Decode(); add tests.... 03:12 < bitcoin-git> [bitcoin] laanwj closed pull request #12881: Minor optimizations to bech32::Decode(); add tests. (master...bech32_decode) https://github.com/bitcoin/bitcoin/pull/12881 03:15 -!- marcoagner [~user@gateway/tor-sasl/marcoagner] has joined #bitcoin-core-dev 03:22 < wumpus> harding: yes from a security point of view it makes some sense, espeically if only repo members are counted 03:27 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 03:30 < wumpus> harding: so are you sure only people with *write access* count, or everyone who is part of the repository team, also read-only members? if the latter we could just add everyone from the bitcoincore organization in it 03:30 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 03:32 -!- vicenteH [~user@123.red-83-58-239.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 03:35 -!- Phoebe68Witting [~Phoebe68W@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 03:38 -!- harrymm [~harrymm@104.207.83.8] has quit [Ping timeout: 276 seconds] 03:40 < harding> wumpus: good question. The GitHub UI says, "At least 1 approving review is required by reviewers with write access." Looking deeper at the documentation, it seems to confirm that, and I think that's what I observed for one of MarcoFalke's Approves (that the UI still said I needed a review by someone with write access). 03:41 < harding> wumpus: in any case, thanks for all your reviews this morning! 03:42 -!- commavir [vir@2604:180::502b:135a] has quit [Ping timeout: 255 seconds] 03:42 -!- commavir [vir@2604:180::502b:135a] has joined #bitcoin-core-dev 03:47 -!- commavir [vir@2604:180::502b:135a] has quit [Ping timeout: 255 seconds] 03:48 -!- commavir [vir@2604:180::502b:135a] has joined #bitcoin-core-dev 03:50 -!- Krellan [~Krellan@2601:640:4000:9258:ed78:cdea:c961:9352] has joined #bitcoin-core-dev 03:51 -!- harrymm [~harrymm@104.207.83.39] has joined #bitcoin-core-dev 03:55 -!- Krellan [~Krellan@2601:640:4000:9258:ed78:cdea:c961:9352] has quit [Ping timeout: 260 seconds] 03:55 -!- commavir [vir@2604:180::502b:135a] has quit [Ping timeout: 255 seconds] 03:55 -!- commavir [vir@2604:180::502b:135a] has joined #bitcoin-core-dev 04:03 < wumpus> harding: np, feel free to poke me when you need review for the website again 04:03 -!- commavir [vir@2604:180::502b:135a] has quit [Ping timeout: 256 seconds] 04:04 -!- commavir [vir@2604:180::502b:135a] has joined #bitcoin-core-dev 04:06 -!- mess110 [~kiki@unaffiliated/mess110] has joined #bitcoin-core-dev 04:06 < mess110> hi, can I please get some reviews on https://github.com/bitcoin/bitcoin/pull/11491 ? 04:06 -!- lio17 [~lio17@80.ip-145-239-89.eu] has joined #bitcoin-core-dev 04:09 -!- commavir [vir@2604:180::502b:135a] has quit [Ping timeout: 260 seconds] 04:10 < wumpus> mess110: yes 04:10 -!- jtimon [~quassel@52.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 04:10 -!- aj [aj@cerulean.erisian.com.au] has quit [Quit: .] 04:10 -!- commavir [vir@2604:180::502b:135a] has joined #bitcoin-core-dev 04:12 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has quit [Read error: Connection reset by peer] 04:13 -!- aj [aj@cerulean.erisian.com.au] has joined #bitcoin-core-dev 04:15 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has joined #bitcoin-core-dev 04:16 -!- commavir [vir@2604:180::502b:135a] has quit [Ping timeout: 265 seconds] 04:17 < provoostenator> Two PRs with baby steps towards making RBF easier to use: #12096, #12818 04:17 < gribble> https://github.com/bitcoin/bitcoin/issues/12096 | [rpc] [wallet] Allow specifying the output index when using bumpfee by kallewoof · Pull Request #12096 · bitcoin/bitcoin · GitHub 04:17 < gribble> https://github.com/bitcoin/bitcoin/issues/12818 | [qt] TransactionView: highlight replacement tx after fee bump by Sjors · Pull Request #12818 · bitcoin/bitcoin · GitHub 04:21 < bitcoin-git> [bitcoin] Sjors closed pull request #12565: [qt] bumpfee: offer user to reduce output for transactions without change (master...2018/02/qt-bumpfee-reduce-output) https://github.com/bitcoin/bitcoin/pull/12565 04:28 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 04:44 -!- glaksmono [~glaksmono@158.140.182.56] has quit [Remote host closed the connection] 04:45 -!- glaksmono [~glaksmono@158.140.182.56] has joined #bitcoin-core-dev 04:55 -!- glaksmono [~glaksmono@158.140.182.56] has quit [Remote host closed the connection] 04:55 -!- glaksmono [~glaksmono@158.140.182.56] has joined #bitcoin-core-dev 04:55 -!- commavir [vir@2604:180::502b:135a] has joined #bitcoin-core-dev 05:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:17 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 265 seconds] 05:18 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:19 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 05:19 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 05:21 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 05:34 -!- JackH [~laptop@host-80-47-85-84.as13285.net] has quit [Quit: Leaving] 05:39 -!- CubicEarths [~cubiceart@ool-44c11be6.dyn.optonline.net] has joined #bitcoin-core-dev 05:45 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1d4662f5dcf6...13da2899ae42 05:45 < bitcoin-git> bitcoin/master 244f4ba practicalswift: scheduler: Add Clang thread safety annotations for variables guarded by m_cs_callbacks_pending 05:45 < bitcoin-git> bitcoin/master 13da289 MarcoFalke: Merge #13125: scheduler: Add Clang thread safety annotations for variables guarded by m_cs_callbacks_pending... 05:46 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #13125: scheduler: Add Clang thread safety annotations for variables guarded by m_cs_callbacks_pending (master...m_cs_callbacks_pending) https://github.com/bitcoin/bitcoin/pull/13125 05:49 -!- cheese_ [Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Read error: Connection reset by peer] 05:49 -!- DougieBot5000 [~DougieBot@unaffiliated/dougiebot5000] has quit [Read error: Connection reset by peer] 05:49 -!- glaksmono [~glaksmono@158.140.182.56] has quit [Remote host closed the connection] 05:50 -!- DougieBot5000 [~DougieBot@unaffiliated/dougiebot5000] has joined #bitcoin-core-dev 05:50 -!- glaksmono [~glaksmono@158.140.182.56] has joined #bitcoin-core-dev 05:54 -!- glaksmono [~glaksmono@158.140.182.56] has quit [Ping timeout: 248 seconds] 05:56 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 05:59 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 06:02 -!- m8tion_ [~m8tion@37.169.154.58] has joined #bitcoin-core-dev 06:03 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 06:05 -!- lari_ [~quassel@195.148.220.32] has joined #bitcoin-core-dev 06:05 -!- lari [~quassel@195.148.220.32] has quit [Ping timeout: 276 seconds] 06:22 < promag> I guess could be merged #10757 06:22 < gribble> https://github.com/bitcoin/bitcoin/issues/10757 | RPC: Introduce getblockstats to plot things by jtimon · Pull Request #10757 · bitcoin/bitcoin · GitHub 06:23 < promag> jnewbery: ping 06:29 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 06:32 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 06:35 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 06:35 -!- glaksmono [~glaksmono@158.140.182.56] has joined #bitcoin-core-dev 06:41 -!- m8tion_ [~m8tion@37.169.154.58] has quit [Read error: Connection reset by peer] 06:50 -!- marcoagner [~user@gateway/tor-sasl/marcoagner] has quit [Quit: WeeChat 2.0.1] 06:50 -!- m8tion [~Agence@abo-148-111-68.mrs.modulonet.fr] has joined #bitcoin-core-dev 06:57 < jnewbery> promag: I'm here 06:59 -!- Sinclair6 [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has joined #bitcoin-core-dev 07:05 -!- CubicEarths [~cubiceart@ool-44c11be6.dyn.optonline.net] has quit [Remote host closed the connection] 07:05 -!- CubicEarths [~cubiceart@ool-44c11be6.dyn.optonline.net] has joined #bitcoin-core-dev 07:08 -!- mess110 [~kiki@unaffiliated/mess110] has quit [Quit: Leaving] 07:10 -!- CubicEarths [~cubiceart@ool-44c11be6.dyn.optonline.net] has quit [Remote host closed the connection] 07:13 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 07:15 -!- marcoagner [~user@gateway/tor-sasl/marcoagner] has joined #bitcoin-core-dev 07:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 07:30 -!- glaksmono [~glaksmono@158.140.182.56] has quit [Remote host closed the connection] 07:34 -!- marcoagner [~user@gateway/tor-sasl/marcoagner] has quit [Quit: WeeChat 2.0.1] 07:41 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 07:42 -!- Aliencorpse [~Aliencorp@2605:a601:b024:600:2500:b14f:f800:1d2d] has quit [Ping timeout: 246 seconds] 07:46 < promag> jnewbery: I see you are already checking out #10740 07:46 < gribble> https://github.com/bitcoin/bitcoin/issues/10740 | [wallet] `loadwallet` RPC - load wallet at runtime by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub 07:46 -!- Ishtv4n [~Ishtv4n@cable-89-216-155-181.dynamic.sbb.rs] has joined #bitcoin-core-dev 07:50 -!- Krellan [~Krellan@2601:640:4000:9258:ed78:cdea:c961:9352] has joined #bitcoin-core-dev 07:55 -!- Aliencorpse [~Aliencorp@2605:a601:b024:600:2533:4dff:3297:2ae0] has joined #bitcoin-core-dev 07:57 -!- Krellan [~Krellan@2601:640:4000:9258:ed78:cdea:c961:9352] has quit [Ping timeout: 276 seconds] 08:00 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 08:06 -!- Dyaheon [~Dya@dsl-trebng21-58c19c-197.dhcp.inet.fi] has quit [Ping timeout: 256 seconds] 08:12 -!- Dyaheon [~Dya@dsl-trebng21-58c19c-197.dhcp.inet.fi] has joined #bitcoin-core-dev 08:17 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 08:18 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 08:38 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 08:42 -!- marcoagner [~user@gateway/tor-sasl/marcoagner] has joined #bitcoin-core-dev 08:43 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 08:52 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 265 seconds] 08:53 -!- isis is now known as isis_ 09:03 -!- Ishtv4n [~Ishtv4n@cable-89-216-155-181.dynamic.sbb.rs] has quit [Ping timeout: 248 seconds] 09:08 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 09:14 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 09:21 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev 09:28 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 09:29 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has quit [Quit: zarez] 09:29 -!- Dizzle [~dizzle@108.171.182.16] has quit [Ping timeout: 265 seconds] 09:29 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev 09:50 < provoostenator> I have two nodes on master and a v0.16.0 which all seem to refuse to relay 1 sat / byte transactions, despite "minrelaytxfee": 0.00010000 ... 09:50 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 268 seconds] 09:51 < provoostenator> The nodes on master don't throw any errors when you use the GUI or sendrawtransaction. The 0.16.0 node however compalins that the minimum relay fee isn't met. 09:54 < sipa> provoostenator: 0.0001 is 10sat/byte, no? 09:55 < sipa> so not relaying 1sat/byte seems expected 09:59 < provoostenator> I set maxmempool to something really large, but on the 0.16 node I forgot to remove minrelaytxfee, which indeed set it to 10. 10:06 < provoostenator> The other two nodes have 0.000010000, but once I fixed the 0.16.0 node transactions get relayed as expected, so nvm... 10:09 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 10:09 -!- Dizzle [~dizzle@108.171.182.16] has quit [Remote host closed the connection] 10:10 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev 10:10 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 10:13 -!- Guest94782 [~delphi@2602:306:b8b6:b970:70ba:70b2:2216:daa8] has quit [Ping timeout: 276 seconds] 10:14 < provoostenator> Different issue: I'm comparing #12404 with master on a node with 1 GB ram. I didn't confiugre dbcache, yet it OOM'd at cache=568 MiB (on master as well as my PR) 10:14 < gribble> https://github.com/bitcoin/bitcoin/issues/12404 | Prune more aggressively during IBD by Sjors · Pull Request #12404 · bitcoin/bitcoin · GitHub 10:14 < provoostenator> Is there room wiggle room above the default 450 MB or could this be a bug? 10:22 < sipa> there's a couple hundred MB in other things, yes 10:26 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 256 seconds] 10:39 -!- marcoagner [~user@gateway/tor-sasl/marcoagner] has quit [Ping timeout: 255 seconds] 10:39 < provoostenator> Wouldn't it be better for dbache to be inclusive of these "other things"? So it would flush when the total hits 450, rather than some unpredicatable(?) point? 10:47 -!- Samdney [~Samdney@81.95.5.40] has joined #bitcoin-core-dev 10:49 -!- Dizzle [~dizzle@108.171.182.16] has quit [Remote host closed the connection] 10:50 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev 10:52 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 256 seconds] 10:53 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 10:53 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 10:53 < provoostenator> It flushed at 716 MB (April 2013), so I'll try dbcache=200 on the 1 GB machine which leave 100 MB margin of error. This is useful too: https://gist.github.com/laanwj/efe29c7661ce9b6620a7 10:54 < provoostenator> (that last number was on a machine with more RAM, I'll keep it running to see where the other peaks are) 11:05 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 11:06 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 11:07 < sipa> provoostenator: it's very hard to account for all memory 11:07 < sipa> we could include a few easily-accountable things like block headers 11:07 < sipa> and i'm generally in favor of ways of making total memory more predictable 11:08 < provoostenator> But the log entries say "cache=223.1MiB" so at least that number is known and could be kept below dbcache, right? 11:08 < sipa> yes it should be 11:08 < provoostenator> (except during the flush itself) 11:08 -!- Guest37850 [~textual@cpe-72-177-93-30.austin.res.rr.com] has joined #bitcoin-core-dev 11:08 < sipa> below dbcache+mempoolsize 11:09 < provoostenator> Ah, so setting maxmempool would also make it more predicatable? 11:10 < sipa> mempoolsize + dbcache should always be below -maxmempool + -dbcache 11:11 < provoostenator> Isn't the mempool empty during IBD? 11:11 < sipa> yes, that's the point 11:11 < sipa> dbcache can "borrow" the unused mempool memory 11:14 < sipa> because during IBD we have mempool memory to spare, and more dbcache helps a lot 11:16 -!- Guest37850 [~textual@cpe-72-177-93-30.austin.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 11:17 < provoostenator> That makes sense. Would be useful to mention that in the -dbcache command documentation. 11:18 < provoostenator> Though the "reducing bitcoind memory usage" doc does mention this. 11:30 < sipa> sounds good 11:30 < sipa> I wasn't aware it wasn't mentioned 11:40 -!- laurentmt [~Thunderbi@37.58.58.232] has quit [Quit: laurentmt] 11:53 -!- marcoagner [~user@gateway/tor-sasl/marcoagner] has joined #bitcoin-core-dev 11:58 -!- m8tion [~Agence@abo-148-111-68.mrs.modulonet.fr] has quit [Read error: Connection reset by peer] 12:02 -!- rex4539 [~textual@2a02:587:3509:b800:6cec:cecb:7abd:8bb3] has joined #bitcoin-core-dev 12:04 -!- m8tion_ [~m8tion@37.169.117.213] has joined #bitcoin-core-dev 12:19 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 12:19 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 12:33 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 12:41 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 12:42 -!- dx25 [~dx25@67-3-153-10.omah.qwest.net] has quit [Quit: ZNC 1.6.3+deb1 - http://znc.in] 12:42 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 12:42 -!- Guest18565 [~textual@cpe-72-177-93-30.austin.res.rr.com] has joined #bitcoin-core-dev 12:45 -!- m8tion_ [~m8tion@37.169.117.213] has quit [Read error: Connection reset by peer] 12:49 -!- dx25 [~dx25@67-3-153-10.omah.qwest.net] has joined #bitcoin-core-dev 12:50 < BlueMatt> sipa (or whoever): you wanna re-ack-and-merge #13023? then we can tag 16.1rc1 =D 12:50 < gribble> https://github.com/bitcoin/bitcoin/issues/13023 | Fix some concurrency issues in ActivateBestChain() by skeees · Pull Request #13023 · bitcoin/bitcoin · GitHub 12:50 < BlueMatt> (the fd things I dont think make sense to wait for, they haven't made much progress that I see, unless cfields wants to object) 12:51 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 260 seconds] 12:51 < skeees> =) 12:52 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 12:55 -!- m8tion_ [~m8tion@88.190.249.49] has joined #bitcoin-core-dev 12:59 < bitcoin-git> [bitcoin] Empact opened pull request #13239: [moveonly] Fix CConnman template methods to be fully-defined in net.h (master...net-template-methods) https://github.com/bitcoin/bitcoin/pull/13239 13:04 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 13:06 -!- sanada [~bitktn@36-2-119-80.chiba.ap.gmo-isp.jp] has quit [] 13:07 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 13:11 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 255 seconds] 13:19 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 13:20 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 256 seconds] 13:24 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 276 seconds] 13:25 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 13:29 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 13:30 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 13:30 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 13:31 -!- Arnes [arnels@stortinget.samfundet.no] has left #bitcoin-core-dev [] 13:32 -!- Dizzle [~dizzle@108.171.182.16] has quit [Ping timeout: 260 seconds] 13:33 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 256 seconds] 13:49 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 13:50 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 264 seconds] 13:58 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 260 seconds] 14:10 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 14:10 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 14:25 < cfields> BlueMatt: whoops, never ended up getting back to that 14:26 < cfields> I'm not too worried though 14:26 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:45 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev 14:48 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has quit [Quit: honeybadgerdgaf] 14:51 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has joined #bitcoin-core-dev 14:59 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has quit [Quit: honeybadgerdgaf] 15:00 -!- marcoagner [~user@gateway/tor-sasl/marcoagner] has quit [Quit: WeeChat 2.0.1] 15:09 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 255 seconds] 15:11 -!- CubicEarths [~cubiceart@ool-44c11be6.dyn.optonline.net] has joined #bitcoin-core-dev 15:11 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 15:12 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 264 seconds] 15:15 -!- CubicEarths [~cubiceart@ool-44c11be6.dyn.optonline.net] has quit [Ping timeout: 240 seconds] 15:19 < BlueMatt> cfields: yea, I'm not either 15:35 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 15:36 -!- Dizzle [~dizzle@108.171.182.16] has quit [Quit: Leaving...] 15:40 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 256 seconds] 15:40 -!- Randolf [~randolf@96.53.47.38] has joined #bitcoin-core-dev 15:51 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has joined #bitcoin-core-dev 15:58 -!- JackH [~laptop@79-73-185-29.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev 16:09 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has quit [Quit: honeybadgerdgaf] 16:11 -!- nickler [~nickler@185.12.46.130] has quit [Ping timeout: 264 seconds] 16:11 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has joined #bitcoin-core-dev 16:11 -!- nickler [~nickler@185.12.46.130] has joined #bitcoin-core-dev 16:22 < bitcoin-git> [bitcoin] Empact opened pull request #13241: scripted-diff: Avoid temporary copies when looping over std::map (master...pair-const-key) https://github.com/bitcoin/bitcoin/pull/13241 16:24 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 240 seconds] 16:27 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has quit [Quit: honeybadgerdgaf] 16:29 -!- Lynet [~slem@2001:4647:c908:0:bd87:fb59:aea6:4ae8] has joined #bitcoin-core-dev 16:35 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 16:36 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 16:52 -!- glaksmono [~glaksmono@158.140.182.56] has joined #bitcoin-core-dev 17:00 -!- glaksmono [~glaksmono@158.140.182.56] has quit [Remote host closed the connection] 17:10 -!- Randolf [~randolf@96.53.47.38] has quit [Ping timeout: 240 seconds] 17:11 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 17:24 -!- rex4539 [~textual@2a02:587:3509:b800:6cec:cecb:7abd:8bb3] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 17:34 < bitcoin-git> [bitcoin] Empact closed pull request #13223: refactor: Extract BnB-specific data from CInputCoin (master...duplicate-fee-calc) https://github.com/bitcoin/bitcoin/pull/13223 17:36 -!- isis_ is now known as isis 17:45 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 255 seconds] 17:45 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 17:49 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 17:53 < bitcoin-git> [bitcoin] kallewoof opened pull request #13242: uint256: Remove unnecessary crypto/common.h use (master...uint256-no-crypto) https://github.com/bitcoin/bitcoin/pull/13242 18:02 -!- jtimon [~quassel@52.29.134.37.dynamic.jazztel.es] has quit [Ping timeout: 265 seconds] 18:02 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Quit: Leaving] 18:09 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has joined #bitcoin-core-dev 18:11 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 18:11 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has quit [Client Quit] 18:12 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 18:14 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has joined #bitcoin-core-dev 18:16 -!- Lynet [~slem@2001:4647:c908:0:bd87:fb59:aea6:4ae8] has quit [Remote host closed the connection] 18:16 -!- Lynet_ [~slem@2001:4647:c908:0:bd87:fb59:aea6:4ae8] has joined #bitcoin-core-dev 18:18 < bitcoin-git> [bitcoin] jimpo opened pull request #13243: Make reusable base class for auxiliary indices (master...index-abstraction) https://github.com/bitcoin/bitcoin/pull/13243 18:56 -!- Lynet_ [~slem@2001:4647:c908:0:bd87:fb59:aea6:4ae8] has quit [Remote host closed the connection] 19:11 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has quit [Quit: honeybadgerdgaf] 19:12 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 19:12 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has joined #bitcoin-core-dev 19:12 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-nbskswmnmqkskwyt] has joined #bitcoin-core-dev 19:14 < fanquake> If we want to tag 0.16.1, can I get some ACKS on #12967 19:14 < gribble> https://github.com/bitcoin/bitcoin/issues/12967 | [0.16] Backports by fanquake · Pull Request #12967 · bitcoin/bitcoin · GitHub 19:34 * kallewoof rubs head at addrman_new_collisions test. 19:35 < kallewoof> It.. assumes that the first 17 IP addresses will not cause a collision. They don't. On little endian machines. 19:35 < kallewoof> It then assumes taht the 18th IP address will collide. And then it assumes that the 19th won't (where Xth = 250.1.1.). 19:36 < kallewoof> No wonder big endian systems would fail the uint256 quick hash stuff. It depended on hashes being a certain way for the tests to succeed. That's not exactly how you test collisions normally. I would totally understand if these hashes were consensus critical somehow. 19:37 < kallewoof> I honestly can't see the purpose of this test at all. 19:41 < sipa> delete it :) 19:43 < kallewoof> sipa: I might! If I can't convince myself they fulfill a purpose. 19:45 < kallewoof> I literally tried changing the IP to 250.1.2. and the tests now fail horribly.. 19:46 < kallewoof> These seem to be from an attempt to increase test coverage from a couple of yrs ago or so, according to git blame. 19:47 < kallewoof> Maybe rewrite them to assume that X % of inserted addresses should not cause a collision. That should work on all architectures. 19:51 -!- ohnx [notohnx@unaffiliated/ohnx] has joined #bitcoin-core-dev 19:57 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 20:02 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 268 seconds] 20:07 < mryandao> hmm, i noticed that the -alertnotify flag is still in the manpages for `bitcoind` -- shouldn't that be removed already since 0.14? 20:09 < mryandao> and what does 'a really long fork' even mean? 20:11 < mryandao> oh nvm, just looked into the src and its basically doing an alert if there's a fork thats >= 6 blocks 20:14 -!- unholymachine [~quassel@2601:8c:c003:9f16:68f0:5342:2afa:a57e] has joined #bitcoin-core-dev 20:32 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 20:43 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has quit [Quit: honeybadgerdgaf] 20:54 -!- unholymachine [~quassel@2601:8c:c003:9f16:68f0:5342:2afa:a57e] has quit [Remote host closed the connection] 21:01 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has joined #bitcoin-core-dev 21:28 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has quit [Quit: honeybadgerdgaf] 21:37 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has joined #bitcoin-core-dev 21:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 22:00 -!- rex4539 [~textual@2a02:587:3509:b800:c4b7:a43a:176:ae83] has joined #bitcoin-core-dev 22:02 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-nbskswmnmqkskwyt] has quit [Quit: Connection closed for inactivity] 22:08 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 22:09 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 22:17 < kallewoof> sipa: I ended up keeping the tests for now. I just checked where big endian would see collisions and changed tests to work on both. These tests are pretty bad, though, but I guess for the sake of coverage, or something. 22:23 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has quit [Quit: honeybadgerdgaf] 22:36 -!- Samdney [~Samdney@81.95.5.40] has quit [Quit: Verlassend] 22:36 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 22:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 22:40 -!- lnostdal [~lnostdal@85-118-69-245.mtel.net] has joined #bitcoin-core-dev 22:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 22:42 -!- rex4539 [~textual@2a02:587:3509:b800:c4b7:a43a:176:ae83] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 22:54 -!- lnostdal [~lnostdal@85-118-69-245.mtel.net] has quit [Ping timeout: 240 seconds] 22:54 -!- glaksmono [~glaksmono@119.10.176.150] has joined #bitcoin-core-dev 23:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 23:38 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds] 23:50 < jonasschnelli> MarcoFalke: merge with a single ack? https://github.com/bitcoin/bitcoin/pull/13158 23:54 -!- Krellan [~Krellan@2601:640:4000:9258:a938:3486:ced6:2a6] has joined #bitcoin-core-dev