--- Day changed Thu May 17 2018 00:03 < bitcoin-git> [bitcoin] kallewoof closed pull request #13242: uint256: Remove unnecessary crypto/common.h use (master...uint256-no-crypto) https://github.com/bitcoin/bitcoin/pull/13242 00:19 -!- glaksmono [~glaksmono@182.23.105.58] has joined #bitcoin-core-dev 00:23 -!- glaksmono [~glaksmono@182.23.105.58] has quit [Ping timeout: 256 seconds] 00:31 < bitcoin-git> [bitcoin] kallewoof opened pull request #13259: validation: add a macro for determining if a block is pruned or not (master...block-pruned-macro) https://github.com/bitcoin/bitcoin/pull/13259 00:40 -!- glaksmono [~glaksmono@182.23.105.58] has joined #bitcoin-core-dev 00:45 -!- glaksmono [~glaksmono@182.23.105.58] has quit [Ping timeout: 276 seconds] 00:48 -!- Krellan [~Krellan@2601:640:4000:9258:a938:3486:ced6:2a6] has quit [Read error: Connection reset by peer] 00:48 -!- Krellan [~Krellan@2601:640:4000:9258:656f:50dd:3d6f:f478] has joined #bitcoin-core-dev 01:00 -!- glaksmono [~glaksmono@182.23.105.58] has joined #bitcoin-core-dev 01:05 -!- glaksmono [~glaksmono@182.23.105.58] has quit [Ping timeout: 256 seconds] 01:08 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 01:12 -!- marcoagner [~user@gateway/tor-sasl/marcoagner] has joined #bitcoin-core-dev 01:14 < wumpus> fanquake: thanks, I'll do some review on backports today 01:21 -!- glaksmono [~glaksmono@182.23.105.58] has joined #bitcoin-core-dev 01:22 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:24 -!- marcoagner [~user@gateway/tor-sasl/marcoagner] has quit [Ping timeout: 255 seconds] 01:25 -!- glaksmono [~glaksmono@182.23.105.58] has quit [Ping timeout: 240 seconds] 01:30 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:40 -!- DougieBot5000 [~DougieBot@unaffiliated/dougiebot5000] has joined #bitcoin-core-dev 01:42 -!- glaksmono [~glaksmono@182.23.105.58] has joined #bitcoin-core-dev 01:46 -!- glaksmono [~glaksmono@182.23.105.58] has quit [Ping timeout: 248 seconds] 01:48 -!- m8tion [~Agence@abo-148-111-68.mrs.modulonet.fr] has joined #bitcoin-core-dev 01:52 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 01:52 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 01:53 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 01:56 -!- raarr [raarr@gateway/vpn/privateinternetaccess/raarr] has quit [Ping timeout: 256 seconds] 01:56 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:02 -!- glaksmono [~glaksmono@182.23.105.58] has joined #bitcoin-core-dev 02:03 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 02:05 -!- echeveria [~echeveria@unaffiliated/echeveria] has quit [Ping timeout: 268 seconds] 02:07 -!- glaksmono [~glaksmono@182.23.105.58] has quit [Ping timeout: 255 seconds] 02:08 -!- marcoagner [~user@156.97.60.94.rev.vodafone.pt] has joined #bitcoin-core-dev 02:09 -!- raarr [raarr@gateway/vpn/privateinternetaccess/raarr] has joined #bitcoin-core-dev 02:12 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 02:39 -!- goatpig [56f75200@gateway/web/freenode/ip.86.247.82.0] has joined #bitcoin-core-dev 02:44 -!- odb36 [3eb6709e@gateway/web/freenode/ip.62.182.112.158] has joined #bitcoin-core-dev 02:45 -!- odb36 [3eb6709e@gateway/web/freenode/ip.62.182.112.158] has quit [Client Quit] 04:05 -!- m8tion [~Agence@abo-148-111-68.mrs.modulonet.fr] has quit [Read error: Connection reset by peer] 04:12 -!- Samdney [~Samdney@80.255.10.204] has joined #bitcoin-core-dev 04:16 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 04:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:40 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Read error: Connection reset by peer] 04:40 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Write error: Connection reset by peer] 04:40 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Write error: Connection reset by peer] 04:41 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 04:44 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 04:46 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 04:55 -!- Ishtv4n [~Ishtv4n@46.246.69.150] has joined #bitcoin-core-dev 04:56 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #13262: Wallet/RPC: Add listsincetx with a stateless (server-side) long polling option (master...2018/05/listsincetx) https://github.com/bitcoin/bitcoin/pull/13262 04:57 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 04:57 -!- ExtraCrispy [~ExtraCris@185.9.18.150] has quit [Read error: Connection reset by peer] 05:01 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 05:01 -!- zxzzt [~prod@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Ping timeout: 264 seconds] 05:02 -!- jamesob [~james@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Ping timeout: 255 seconds] 05:02 -!- jnewbery [~john@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Ping timeout: 264 seconds] 05:03 -!- zxzzt [~prod@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 05:03 -!- jamesob [~james@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 05:03 -!- Krellan [~Krellan@2601:640:4000:9258:656f:50dd:3d6f:f478] has quit [Read error: Connection reset by peer] 05:04 -!- Krellan [~Krellan@2601:640:4000:9258:656f:50dd:3d6f:f478] has joined #bitcoin-core-dev 05:09 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 256 seconds] 05:10 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 05:10 -!- jnewbery [~john@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 05:14 -!- ExtraCrispy [~ExtraCris@185.9.18.150] has joined #bitcoin-core-dev 05:27 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 05:32 -!- laurentmt [~Thunderbi@62.112.9.237] has joined #bitcoin-core-dev 05:40 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:44 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 05:45 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 05:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 05:50 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 05:53 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 240 seconds] 05:55 -!- laurentmt [~Thunderbi@62.112.9.237] has quit [Quit: laurentmt] 05:58 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 06:05 -!- goofie [~goofie@104-7-174-119.lightspeed.hstntx.sbcglobal.net] has joined #bitcoin-core-dev 06:06 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 06:06 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has joined #bitcoin-core-dev 06:34 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 260 seconds] 06:36 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 06:39 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:41 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 06:45 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has quit [Quit: WeeChat 2.1] 06:45 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 06:51 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 06:55 -!- CubicEarths [~cubiceart@ool-44c11be6.dyn.optonline.net] has joined #bitcoin-core-dev 06:59 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 07:05 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 07:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Client Quit] 07:09 -!- Krellan [~Krellan@2601:640:4000:9258:656f:50dd:3d6f:f478] has quit [Read error: Connection reset by peer] 07:10 -!- Krellan [~Krellan@2601:640:4000:9258:656f:50dd:3d6f:f478] has joined #bitcoin-core-dev 07:12 -!- Ishtv4n [~Ishtv4n@46.246.69.150] has quit [Ping timeout: 268 seconds] 07:16 -!- Ishtv4n [~Ishtv4n@89.216.97.155] has joined #bitcoin-core-dev 07:25 -!- nullptr| [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has quit [Ping timeout: 240 seconds] 07:30 -!- nullptr| [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has joined #bitcoin-core-dev 07:35 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 07:39 < bitcoin-git> [bitcoin] GreatSock opened pull request #13264: [qt] Satoshi unit (master...satoshis) https://github.com/bitcoin/bitcoin/pull/13264 07:44 -!- CubicEarths [~cubiceart@ool-44c11be6.dyn.optonline.net] has quit [Remote host closed the connection] 07:50 -!- CubicEarths [~cubiceart@ool-44c11be6.dyn.optonline.net] has joined #bitcoin-core-dev 07:56 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 07:57 -!- moneyball [~moneyball@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #bitcoin-core-dev 08:03 -!- CubicEarths [~cubiceart@ool-44c11be6.dyn.optonline.net] has quit [Remote host closed the connection] 08:23 -!- CubicEarths [~cubiceart@ool-44c11be6.dyn.optonline.net] has joined #bitcoin-core-dev 08:23 -!- CubicEarths [~cubiceart@ool-44c11be6.dyn.optonline.net] has quit [Remote host closed the connection] 08:28 -!- bsm1175321 [~mcelrath@173-9-124-61-NewEngland.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 08:39 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 08:42 -!- moneyball [~moneyball@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 08:44 -!- moneyball [~moneyball@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #bitcoin-core-dev 08:45 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 240 seconds] 08:51 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 08:55 -!- laurentmt [~Thunderbi@62.112.9.237] has joined #bitcoin-core-dev 08:56 -!- ExtraCrispy [~ExtraCris@185.9.18.150] has quit [Quit: ExtraCrispy] 09:00 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has quit [Quit: zarez] 09:06 -!- Ishtv4n [~Ishtv4n@89.216.97.155] has quit [Ping timeout: 256 seconds] 09:06 < promag> fyi can't attend meeting today 09:10 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/4cfe17c3382b...ef0e5cd5174c 09:10 < bitcoin-git> bitcoin/master 7ab1c6f Luke Dashjr: GUI: Rephrase Bech32 checkbox text/tooltip... 09:10 < bitcoin-git> bitcoin/master 82dda6b Luke Dashjr: GUI: Allow generating Bech32 addresses with a legacy-address default 09:10 < bitcoin-git> bitcoin/master ef0e5cd MarcoFalke: Merge #13251: GUI: Rephrase Bech32 checkbox texts, and enable it with legacy address default... 09:11 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #13251: GUI: Rephrase Bech32 checkbox texts, and enable it with legacy address default (master...rephrase-bech-32) https://github.com/bitcoin/bitcoin/pull/13251 09:12 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 09:17 -!- Krellan [~Krellan@2601:640:4000:9258:656f:50dd:3d6f:f478] has quit [Read error: Connection reset by peer] 09:18 -!- Krellan [~Krellan@2601:640:4000:9258:656f:50dd:3d6f:f478] has joined #bitcoin-core-dev 09:30 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 09:30 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ef0e5cd5174c...1b53e4f67c6d 09:30 < bitcoin-git> bitcoin/master 84f4194 Chun Kuan Lee: break circular dependency: random/sync -> util -> random/sync 09:30 < bitcoin-git> bitcoin/master 1b53e4f MarcoFalke: Merge #13236: break circular dependency: random/sync -> util -> random/sync... 09:31 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #13236: break circular dependency: random/sync -> util -> random/sync (master...random_util) https://github.com/bitcoin/bitcoin/pull/13236 09:31 -!- promag [~promag@83.223.249.28] has joined #bitcoin-core-dev 09:40 -!- Murch [~murch@96.74.120.81] has joined #bitcoin-core-dev 09:45 -!- moneyball [~moneyball@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 09:46 -!- moneyball [~moneyball@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #bitcoin-core-dev 09:51 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 10:04 -!- Krellan [~Krellan@2601:640:4000:9258:656f:50dd:3d6f:f478] has quit [Remote host closed the connection] 10:05 -!- moneyball [~moneyball@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 10:14 -!- moneyball [~moneyball@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #bitcoin-core-dev 10:17 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev 10:20 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 10:23 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 10:26 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev 10:29 -!- moneyball [~moneyball@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 10:33 -!- isis is now known as isis_ 10:33 < promag> will trade reviews =) #13097 10:34 < gribble> https://github.com/bitcoin/bitcoin/issues/13097 | ui: Support wallets loaded dynamically by promag · Pull Request #13097 · bitcoin/bitcoin · GitHub 10:34 -!- promag [~promag@83.223.249.28] has quit [Remote host closed the connection] 10:36 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Quit: drexl] 10:40 -!- isis_ is now known as isis 10:43 -!- moneyball [~moneyball@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #bitcoin-core-dev 10:45 -!- Murch [~murch@96.74.120.81] has quit [Quit: Snoozing.] 10:45 -!- Murch [~murch@96.74.120.81] has joined #bitcoin-core-dev 10:46 -!- Murch [~murch@96.74.120.81] has quit [Client Quit] 11:01 -!- Guest18565 [~textual@cpe-72-177-93-30.austin.res.rr.com] has quit [Quit: Textual IRC Client: www.textualapp.com] 11:02 -!- Murch [~murch@96.74.120.81] has joined #bitcoin-core-dev 11:04 -!- drexl [~drexl@37.58.58.230] has joined #bitcoin-core-dev 11:08 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 260 seconds] 11:11 -!- promag [~promag@145.166.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 11:12 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 11:14 -!- promag [~promag@145.166.108.93.rev.vodafone.pt] has quit [Read error: Connection reset by peer] 11:14 -!- promag [~promag@145.166.108.93.rev.vodafone.pt] has joined #bitcoin-core-dev 11:17 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 11:33 < jonasschnelli> promag: you can remove the description part where it says "builds on top of" in 13097 11:34 < promag> ok 11:34 < promag> ty 11:34 < jonasschnelli> will review 11:35 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 264 seconds] 11:35 < promag> thanks! 11:36 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 11:36 < promag> https://github.com/bitcoin/bitcoin/projects/2 needs update 11:39 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 11:40 -!- drexl_ [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev 11:41 -!- drexl [~drexl@37.58.58.230] has quit [Ping timeout: 276 seconds] 11:41 -!- drexl_ is now known as drexl 11:43 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 11:47 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 11:48 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 11:51 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has quit [Remote host closed the connection] 11:55 -!- clarkmoody [~clarkmood@47-218-248-206.bcstcmta04.res.dyn.suddenlink.net] has joined #bitcoin-core-dev 11:55 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 11:56 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has quit [Remote host closed the connection] 11:56 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 12:00 < sipa> meeting? 12:00 < wumpus> #startmeeting 12:00 < lightningbot> Meeting started Thu May 17 19:00:35 2018 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot. 12:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 12:00 < jonasschnelli> hi 12:00 < sipa> hi 12:00 < promag> hi 12:00 < jamesob> howdy 12:01 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator 12:01 < kanzure> hi. 12:01 < wumpus> proposed topics: 0.16.1 I guess 12:01 < jimpo> hi 12:01 < cfields> hi 12:02 < wumpus> #topic High priority for review 12:02 < sipa> i'd like to add #13142 12:02 < gribble> https://github.com/bitcoin/bitcoin/issues/13142 | Separate IsMine from solvability by sipa · Pull Request #13142 · bitcoin/bitcoin · GitHub 12:02 -!- jtimon [~quassel@52.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 12:03 -!- Randolf [~randolf@d75-157-101-171.bchsia.telus.net] has joined #bitcoin-core-dev 12:03 < wumpus> we merged #10740 this week, #12254 #10757 #13011 #13097 #12979 #12634 are left 12:03 < jonasschnelli> I'd like to add #12196 12:03 < jnewbery> hello 12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/10740 | [wallet] `loadwallet` RPC - load wallet at runtime by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub 12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/12254 | BIP 158: Compact Block Filters for Light Clients by jimpo · Pull Request #12254 · bitcoin/bitcoin · GitHub 12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/10757 | RPC: Introduce getblockstats to plot things by jtimon · Pull Request #10757 · bitcoin/bitcoin · GitHub 12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/13011 | Cache witness hash in CTransaction by MarcoFalke · Pull Request #13011 · bitcoin/bitcoin · GitHub 12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/13097 | ui: Support wallets loaded dynamically by promag · Pull Request #13097 · bitcoin/bitcoin · GitHub 12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/12979 | Split validationinterface into parallel validation/mempool interfaces by TheBlueMatt · Pull Request #12979 · bitcoin/bitcoin · GitHub 12:03 < wumpus> there's quite a lot of things on the list yet, should we also remove something? 12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/12634 | [refactor] Make TransactionWithinChainLimit more flexible by kallewoof · Pull Request #12634 · bitcoin/bitcoin · GitHub 12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/12196 | Add scantxoutset RPC method by jonasschnelli · Pull Request #12196 · bitcoin/bitcoin · GitHub 12:04 < BlueMatt> #13011 looks merge-ableish 12:04 < gribble> https://github.com/bitcoin/bitcoin/issues/13011 | Cache witness hash in CTransaction by MarcoFalke · Pull Request #13011 · bitcoin/bitcoin · GitHub 12:04 < jtimon> hi 12:04 < BlueMatt> I dunno if #12254 should stay on there, there's now discussion of the bip on the ml so its gonna be some time yet, I think 12:04 < BlueMatt> jimpo: thoughts? 12:04 < gribble> https://github.com/bitcoin/bitcoin/issues/12254 | BIP 158: Compact Block Filters for Light Clients by jimpo · Pull Request #12254 · bitcoin/bitcoin · GitHub 12:04 < jonasschnelli> What is the maxlen for high-prio-list? 12:04 < BlueMatt> 1 per regular contributor :p 12:04 < wumpus> ok added #12196 #13142 12:04 < gribble> https://github.com/bitcoin/bitcoin/issues/12196 | Add scantxoutset RPC method by jonasschnelli · Pull Request #12196 · bitcoin/bitcoin · GitHub 12:05 < gribble> https://github.com/bitcoin/bitcoin/issues/13142 | Separate IsMine from solvability by sipa · Pull Request #13142 · bitcoin/bitcoin · GitHub 12:05 < jonasschnelli> Thanks wumpus 12:05 < jonasschnelli> Agree with BlueMatt about 12254 12:05 < wumpus> yes, what BlueMatt says, though PRs that are not actively updated should be removed 12:05 < wumpus> agree, removed 12254 12:06 < jtimon> I was expecting https://github.com/bitcoin/bitcoin/pull/10757 to be merged soonish and thus go out of the list 12:06 -!- moneyball [~moneyball@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 12:06 < BlueMatt> topic: 0.16.1 12:06 < promag> and I guess 13097 can be merged after jonasschnelli review 12:06 < wumpus> something that is still being discussed on the mailing list certainly doesn't belong in the blocker slist 12:06 < jonasschnelli> Yes. 13097 is in review here... 12:06 < jimpo> Can I get #13243 then so progress continues? :-) 12:06 < gribble> https://github.com/bitcoin/bitcoin/issues/13243 | Make reusable base class for auxiliary indices by jimpo · Pull Request #13243 · bitcoin/bitcoin · GitHub 12:06 < MarcoFalke> #12979 needs a rebase 12:06 < sipa> sgtm 12:06 < gribble> https://github.com/bitcoin/bitcoin/issues/12979 | Split validationinterface into parallel validation/mempool interfaces by TheBlueMatt · Pull Request #12979 · bitcoin/bitcoin · GitHub 12:06 < BlueMatt> MarcoFalke: yup, doing now 12:07 < BlueMatt> i was waiting on sdaftuar's review so I could take nits at the same time 12:07 -!- moneyball [~moneyball@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #bitcoin-core-dev 12:07 < jonasschnelli> unicorn for 10757 12:07 < sipa> great. 12:07 -!- Murch [~murch@96.74.120.81] has quit [Quit: Snoozing.] 12:07 < BlueMatt> topic: replacing github 12:07 < jonasschnelli> heh 12:07 < promag> wumpus: fyi 13063 on high priority after 13097 merge 12:08 < BlueMatt> topic: replacing github (not entirely unserious) 12:08 < jonasschnelli> don't make queues for highprio list. :) 12:08 < wumpus> promag: you already have one on the list! 12:08 < promag> wumpus: right, after 13097 merge 12:09 < wumpus> due to the length of the list I'm going to have to enforce one PR per person, sorry 12:09 < wumpus> #topic 0.16.1 12:09 < BlueMatt> huh? we always enforce one per person (well, one nomination per person, you can nominate someone elses') 12:09 < BlueMatt> I think we just need to finish backports and tag for 0.16.1rc1, no? 12:09 < wumpus> mostly #13253 12:10 < gribble> https://github.com/bitcoin/bitcoin/issues/13253 | [0.16] Further Backports by fanquake · Pull Request #13253 · bitcoin/bitcoin · GitHub 12:10 < wumpus> BlueMatt: we had multiple theuni PRs on there at some point :) 12:10 < BlueMatt> well those got removed, and cfields confirmed that was ok 12:11 < wumpus> there's also three issues marked 0.16.1: #13110 #12646 #12337 12:11 < gribble> https://github.com/bitcoin/bitcoin/issues/13110 | 0.16.0 bitcoin-qt: "Assertion `copyFrom failed" during launch · Issue #13110 · bitcoin/bitcoin · GitHub 12:11 < gribble> https://github.com/bitcoin/bitcoin/issues/12646 | Assertion failure during rescan · Issue #12646 · bitcoin/bitcoin · GitHub 12:11 < gribble> https://github.com/bitcoin/bitcoin/issues/12337 | 0.16 Shutdown assertion · Issue #12337 · bitcoin/bitcoin · GitHub 12:11 < wumpus> not sure whether they are critical or can just be bumped to 0.16.2 or so 12:11 < sipa> we have one issue marked 0.15.2 which i don't understand 12:12 < wumpus> I don't know either, but at least that's not a blocker for 0.16.1 12:12 < BlueMatt> jonasschnelli: was the last to comment on 12337 " I'll try to find a solution for this..." 12:12 < MarcoFalke> wumpus: The assertion is a regression if I am not mistaken 12:12 < MarcoFalke> 13110 12:13 < MarcoFalke> wasn't 12337 fixed? 12:13 < jonasschnelli> Will look into 12337... 12:13 < wumpus> I proposed a fix in 13110 and it apparently worked 12:13 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 12:13 < cfields> yes 12:14 < jonasschnelli> wumpus: can you PR https://github.com/bitcoin/bitcoin/issues/13110#issuecomment-385708583? 12:14 < wumpus> jonasschnelli: sure 12:15 < wumpus> so that leaves 12646 12:16 < jonasschnelli> maybe jnewbery can look into 12646? 12:17 < wumpus> anyone want to look int othat? or can we just bump it forward if it's not so importent 12:17 < jonasschnelli> I think its okay to bump this forward (as long as we track it) 12:17 < wumpus> yes I don't mean closing it 12:18 < jnewbery> Yes, I can look at 12646 (next week) 12:18 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 12:19 < wumpus> moved to 0.16.2 12:19 < wumpus> other proposed topics? 12:19 < BlueMatt> trashing github 12:19 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 12:19 < wumpus> #topic Trashing github 12:19 < BlueMatt> so it hasnt been working for like 3 weeks now 12:20 < BlueMatt> and I'd kinda like to have something self-hosted with better review tools anyway, which I know a lot of people wanted 12:20 < jonasschnelli> Should we give it more time?... I'm pretty sure they are aware of it 12:20 < sipa> there was some suggestiin (was it on twitter) to use gitlab 12:20 < BlueMatt> so I figured we should do a "do people think its actually a good idea to switch to something self-hosted" semi-poll 12:20 < wumpus> gitlab seems ok 12:20 < BlueMatt> or we could switch to gitlab 12:20 < jonasschnelli> BlueMatt: what alternatives would you propose? 12:20 < jtimon> I like gitlab 12:20 < sdaftuar> seems to me like it's way harder to get it right hosting ourselves 12:20 < BlueMatt> though gitlab seems to have no better review tools than github 12:20 < wumpus> self-hosted I don't know, who is going to babysit this, monitor it and apply security patches etc? 12:20 < sipa> it would e really cool if all pr comment history was in git too 12:20 < BlueMatt> sdaftuar: oh? I mean I kinda disagree 12:21 < sdaftuar> dude we can't even keep the computers in our office running 12:21 < jamesob> self-hosted is very risky and potentially time-consumptive IMO 12:21 < BlueMatt> sipa: does gitlab do that? 12:21 < BlueMatt> sdaftuar: bitcoincore.org does just fine.... 12:21 < sipa> BlueMatt: i have no clue 12:21 < wumpus> if no one is, it's going to become worse, not better, at least Github has a dedicated paid team 12:21 < sdaftuar> definitely agree with wumpus 12:21 < cfields> general nack, self-hosting issues aside, Github's network effect is too strong imo. 12:21 < sipa> blockstream uses gitlab internally, which seems to work fine (pribably due to people maintaining it) 12:21 < BlueMatt> i mean we could do self-hosted gitlab 12:22 < MarcoFalke> what advantage does that give, BlueMatt? 12:22 < jtimon> I assume the goal is less unicorns? 12:22 < jnewbery> cfields: +1 12:22 < wumpus> someone from github promised to look into the unicorn issue, maybe we should give them some more time 12:22 < MarcoFalke> gitlab also does hostign for free 12:22 < jimpo> Cursory internet search turned up reviewable.io, which is like a hosted layer on top of GitHub 12:23 < sipa> jnewbery, cfields: what do you suggest instead? waiting until github fixes it? 12:23 < jimpo> free for public repos 12:23 < BlueMatt> MarcoFalke: we can do our own security additions like putting the pr and comment history in git 12:23 < cfields> I can't be the only one who gets irrationally frustrated when the code I want to mess with is on BitBucket.. 12:23 < BlueMatt> and have stuff that verifies it 12:23 < sipa> cfields: we'd mirror on github of course 12:23 < jnewbery> In the absence of something better, we should continue nagging them 12:23 < wumpus> cfields: yes, only players like freedesktop can really afford to host on separate infrastructure, for smaller projects the lack of network effect (and having to register separately) is bad 12:24 < cfields> sipa: all things considered, yes, I'd say waiting it out makes the most sense. 12:24 < BlueMatt> jnewbery: I think we *do* have ideas for better things 12:24 < cfields> I think I'm in the minority there, though :) 12:24 < jonasschnelli> Moving away from GitHub seems meh,... especially for a self-hostes solutions... looks after centralizing development 12:24 < jimpo> Who has reached out to GitHub and through what channel so far? 12:24 < BlueMatt> the self-hosting question is more a "will it be maintained" question 12:24 < BlueMatt> not "will it be better" 12:24 < jtimon> I'm ok with both people working on a gitlab instance and people nagging github devs 12:24 < sipa> cfields: i'moretty unconfortable with the fact that network effect is making us stick with a specific provider, even in the oresence of obvious issies 12:25 < sipa> of course, it's not like we could migrate quickly anyway 12:25 < wumpus> 'will it be maintained' is really important though to not end up blaming each other 12:25 < jamesob> how much effort will, e.g., DoS protection be for something self-hosted? 12:25 < wumpus> at least now we can blame github people :) 12:25 < sipa> haha 12:25 < jtimon> we could perhaps save money on travis workers by using gitlab-CI too? 12:25 < wumpus> jamesob: exactly... 12:25 < BlueMatt> jamesob: dos protection is 6$/month 12:25 < BlueMatt> and works perfectly 12:25 < cfields> sipa: it's worth considering that the 0.16.1 issues might've never been reported if not for Github's issues 12:26 < jnewbery> BlueMatt: Yes, we have ideas, but that's different from something that's actually running. I don't have any interest in maintaining a self-hosted solution, and I don't think it's worth anyone else's time doing it either 12:26 < sipa> cfields: that's a good point 12:26 < wumpus> we could still use github for *issues* 12:26 < wumpus> gitlab would be for patches and review 12:26 < jtimon> jnewbery: yeah, I'm personally not interested in maintaining it either 12:26 < wumpus> doesn't necessarily need to be the same place 12:27 < sipa> let's move back to sourceforge 12:27 < wumpus> yes tbh I don't think we should change the issue reporting URL 12:27 < BlueMatt> I'm not a fan of using issues and patches/review being in separate places 12:27 < wumpus> I've been spamming that to so many people over the years 12:27 < jamesob> BlueMatt: I don't think CloudFlare works with git protocol, so you need to reveal underlying IPs: https://stackoverflow.com/questions/31817004/git-push-not-working-after-using-cloudflare-reverse-proxy 12:27 < jonasschnelli> if the unicorns is the showstopper, then better mirror github PR with comments > 20 via API with comment through API function 12:27 < jtimon> or just everything on gitlab, but since we have the github mirror, we will see issues created there by people who missed that the project moved 12:27 < wumpus> I don't really want to move it anywhere else. THe unicorns are only an issue for code review. 12:27 < BlueMatt> jamesob: bitcoincore.org does not use cloudflare (and costs 6$/month), cloudflare sucks ass 12:27 < jnewbery> I also think that the network effect thing is important. What percentage of new contributors/issue reports would we lose if we weren't on github? 12:28 < BlueMatt> jamesob: (and that's for redundant providers) 12:28 < BlueMatt> jonasschnelli: I'd actually be much happier with github if we had a client-side api-based cli-only github interface 12:28 < BlueMatt> (that verified eg pgp signatures on comments) 12:28 < wumpus> there is a github cli interface 12:28 < jtimon> wumpus: well the main point of using github is for code review, no? 12:28 < kanzure> email seems to work for long reviews (diffs) 12:29 < jonasschnelli> BlueMatt: that seems easyer then installing a gitlab solution on a custom server 12:29 < jonasschnelli> *easier 12:29 < BlueMatt> jonasschnelli: its the difference between building a whole app and installing one 12:29 < BlueMatt> so...no, not really 12:29 < jimpo> jnewberry: Who has reached out to GitHub and through what channel so far? 12:29 < moneyball> I am happy to follow-up with GitHub to try and accelerate a fix. Can someone provide me background info on the existing communication we have with GitHub? 12:29 < jnewbery> I've contacted Github support. I don't know who else has 12:29 < jtimon> I think someone reached to them on twitter too 12:30 < wumpus> I have contacted them through tthe contact site, and was told by support that many others have 12:30 < moneyball> Is there an open issue # that I can reference? 12:30 < jnewbery> jtimon: that was me 12:30 < jimpo> I can try asking someone I know that used to work there supporting open source projects 12:30 < jnewbery> moneyball: I'll forward you the email thread 12:30 < BlueMatt> moneyball: a few folks have emailed support@github, which historically has always gotten a response, some other projects were posting responses they got where they were saying "we dont actually know what change we made that triggered these issues, hold on" 12:30 < BlueMatt> buts its been like 3 weeks ago 12:31 < moneyball> jnewbery ok great i'll use that as context and follow-up 12:31 < moneyball> jimpo we can coordinate our efforts if you'd like 12:31 < jimpo> yeah, we can chat about it outside the meeting 12:31 < BlueMatt> ok, so it sounds like consensus is "stick with the broken shit we have now" :/ 12:32 < BlueMatt> or at least no consensus on moving to something else 12:32 < wumpus> feel fre to set up something better and convince us to use it 12:32 < sipa> yeah i believe it will require someone to set up a demo 12:32 < wumpus> if not, this is just empty talk, we *have* nothing better 12:32 < wumpus> any other topics? 12:32 < MarcoFalke> And a plan to transition all open patches to the new review system? 12:33 < sipa> right; the question is whether we should look into alternatives 12:33 < sipa> not so much whether we should or shouldn't move 12:33 < wumpus> right 12:33 < cfields> iirc some alternatives support oath login via github 12:33 < BlueMatt> yea, it seems like lack of consensus to move even if we find something good 12:33 < cfields> that would go a long way towards shutting me up 12:33 < BlueMatt> which was mostly why I brought it up 12:34 < wumpus> I'm open to being convinced to use something else, if it's really better 12:34 < jimpo> cfields: I agree a code review tool with GitHub integration (where main repo is still hosted there) is ideal 12:35 < jnewbery> BlueMatt: If there was something else better running now AND there was a way to migrate all state AND we wouldn't lose contributors by switching AND we have someone committed to maintaining it, then I'd be open to it. Without that, I think it's a non-starter. 12:35 < jonasschnelli> Something like https://github.com/piotrmurach/github_cli seems a better start to deal with the unicorns 12:35 < wumpus> jonasschnelli: yes, I plan to look into github cli commands as well, there's a few (also "hub" IIRC) 12:36 < MarcoFalke> Agree with jnewbery. I am open to switching, but not without solving the transition issues first. 12:36 < wumpus> we'd end up with parallel infrastructure for a while anyway 12:36 < jtimon> well BlueMatt I think it would be easier to get consensus to move to something else if somebody had it working with CI and all 12:36 < jnewbery> topic request: separate wallet from node (#10973) 12:36 < gribble> https://github.com/bitcoin/bitcoin/issues/10973 | Refactor: separate wallet from node by ryanofsky · Pull Request #10973 · bitcoin/bitcoin · GitHub 12:37 < jonasschnelli> Moving away from Github just because of load issues for three weeks seems insane... 12:37 < BlueMatt> jtimon: it sounds like definite "no", so I'm not gonna spend time looking into it 12:37 < jtimon> in the meantime, prs with many comments get the unicorn and we have to try again until it loads 12:37 < wumpus> #topic separate wallet from node (jnewbery) 12:37 < BlueMatt> jonasschnelli: there are way more reasons people dont like github 12:37 < sipa> jonasschnelli: not being able to move away from github just because of network effect seems scary... 12:37 < jamesob> the upside is that this is an additional incentive to keep PRs small :) 12:37 < jtimon> BlueMatt: fair enough 12:37 < cfields> jonasschnelli: I agree. But I think the frustration comes from the helplessness that it's brought to light. 12:37 < wumpus> this discussion is starting to repeat itself 12:38 < jonasschnelli> sipa: that is a point we should take into consideration,.. but stop focusing on load issues 12:38 < sipa> ok, next topic it seems 12:38 < BlueMatt> oh, I have 2 more topics.... 12:38 < wumpus> I don't think there's realistically any chance of anything replacing github until someone sets up a feasible alternative and shows us that it is better 12:38 < sipa> jnewbery: your topic 12:38 < jonasschnelli> (#topic separate wallet from node (jnewbery)) 12:39 < BlueMatt> sipa: well I'm gonna look into having a cli app that checks signatures off github api comments/etc 12:39 < jnewbery> #10973 is a big PR, but I think it's very worthwhile 12:39 < BlueMatt> cause I think that would alleviate a lot of it 12:39 < gribble> https://github.com/bitcoin/bitcoin/issues/10973 | Refactor: separate wallet from node by ryanofsky · Pull Request #10973 · bitcoin/bitcoin · GitHub 12:39 < jnewbery> jamesob and I have both reviewed now, but it requires continual rebase 12:39 < jnewbery> There are a lot of PRs competing for high priority for review, but I think it'd be great to make some progress on this one 12:40 < promag> place in high priority this week? 12:40 < jamesob> I'll start a round of manual testing if we can get another reviewer or two 12:40 < jimpo> can it be broken up at all? 12:40 < jnewbery> so, next steps would be: concecpt ACK/NACKs 12:40 < BlueMatt> sounds like a high-priority-for-review nomination? 12:40 < jnewbery> and if people think it's too much to review in one go, ryanofsky is happy to split 12:40 < jimpo> 1500+ lines is too big IMO 12:40 < wumpus> oh no, not more high priority for review 12:40 < jonasschnelli> jnewbery: this is orthogonal of using light client mode to decouple the wallet from the node? right,... it's more architectural? 12:41 < jnewbery> jimpo: it's mostly very mechanical changes, but yes it's a large +-loc 12:41 < wumpus> is it blocking anything? is it importnat for 0.17? 12:41 < jnewbery> there are only a couple of commits that require deep review 12:41 < sipa> jnewbery: thanks for bringing it up; big PRs are sometimes unnecessarily scary to dig into 12:42 < jnewbery> wumpus: it blocks (but doesn't necessarily have to lead to) process separation 12:42 < jonasschnelli> But I guess it's hard/impossible to break it into smaller PRs 12:42 < jamesob> jonasschnelli: it makes explicit the bitcoind interface that the wallet relies on, which is in itself useful but also if we want to do any kind of process separation 12:42 < jnewbery> jonasschnelli: you're correct 12:42 < wumpus> process separation is not something we'll have for 0.17 anyway 12:42 < jnewbery> so at this stage it's more of a concept review beg from me, and a poll on whether russ should spend time splitting it up 12:43 < jimpo> I'll give it a pass by tomorrow 12:43 < jnewbery> The reason I raised it is that because of the frequent rebases, reviews go stale very quickly, and it's now had two ACKs 12:43 < jnewbery> thanks jimpo 12:43 < ryanofsky> i actually don't think it's hard to split up, first 6 commits seem to group together nicely, with rest of changes more independent 12:44 < jnewbery> that's all from me. If 2 or 3 regular reviewers are happy to concept review, I think that's good progress 12:44 < jonasschnelli> If we assume the long term goal is process separation (where the wallet will turn into a pure transaction-filtering-thinkg), isn't it, that the coin-selection & signing elements in this interface will get throw away later? 12:45 < BlueMatt> topic: unverified-block-message 12:45 < BlueMatt> topic: queue drain lock assertions to avoid deadlocks 12:45 < wumpus> #topic unverified-block-message (BlueMatt) 12:45 < ryanofsky> jonasschnelli, there aren't any coin-selection or signing things in node/wallet interface in that pr 12:46 < jonasschnelli> maybe I should review the PR first... 12:46 < sipa> BlueMatt: your topic 12:47 < BlueMatt> so sdaftuar pointed out an old issue that we never really addressed where if you relay someone a script-invalid block they may announce it to their peers via compact blocks high-bandwidth-mode and then if you for some reason fall back to downloading it via getdata due to short id collision or so (we dont think there is a way to game it), then you'll end up disconnecting that peer for never responding to your request 12:47 < ryanofsky> jonasschnelli, yeah, you can just take a look at https://github.com/ryanofsky/bitcoin/blob/pr/wipc-sep/src/interfaces/chain.h to see the interface (first link in PR description) 12:47 < jtimon> re 10973 I agree I would preffer a few smaller ones, specially if there's commits that needs deeper review 12:47 < BlueMatt> we only came up with two real potential solutions: a "no, I'm not gonna send you that block" message (ie a not-batshit-insane reject message) or a "here is a block that may be invalid, but is valid pow+merkle root ala compact blocks requirement" message 12:47 < BlueMatt> or, I guess the second one is a getdata type 12:48 < sipa> BlueMatt: we have "notfound" also 12:48 < BlueMatt> sipa: isnt that a reject type? 12:48 < sipa> no 12:48 < wumpus> NetMsgType::NOTFOUND 12:48 < jnewbery> *5 chaincoders furiously grep for notfound* 12:48 < sipa> it's just a "i can't give you these INVs" 12:48 < sdaftuar> oh wow 12:48 < BlueMatt> sipa: ah, but we dont use it for blocks 12:48 < BlueMatt> only txn 12:48 < sipa> ah 12:49 < BlueMatt> still, easier would be a "here is a block that may be invalid" as that would remove the ABC in ProcessGetBlockData 12:49 < wumpus> the client ignores it just the same though 12:49 < cfields> BlueMatt: so, lots of NOTFOUNDs :) 12:49 < sipa> BlueMatt: we should have had that before compact blocks, i guess 12:49 < BlueMatt> sipa: should have had what? 12:50 < BlueMatt> sdaftuar: points out that it can be wholly independant, just a new getdata type 12:50 < sipa> a possibly invalid block relay 12:50 < sdaftuar> i think we could just add a new BLOKC response type 12:50 < sdaftuar> BLOCK_COULDBEBAD 12:50 < BlueMatt> well or both or whatever 12:50 < sipa> 0xDEADB10C 12:50 < sdaftuar> where if someone requests a block but you don't know if its valid, or you know it's invalid, you return a different message containing the block to indicate that 12:50 < wumpus> hehe 12:51 < BlueMatt> yea, so old nodes would ignore it, and you'd just be sending a new message type 12:51 < sdaftuar> currently we would let the peer time us out instead 12:51 < sipa> sdaftuar: but only if you know they support such a message 12:51 < BlueMatt> or not 12:51 < sdaftuar> meh, sure, but not even needed imo 12:51 < BlueMatt> doesnt really matter 12:51 < BlueMatt> I mean they're about to disconnect you either way 12:51 < sipa> fair 12:51 < sipa> that makes compatibility really easy 12:52 < sipa> i guess... suggest something and write a bip? 12:52 < BlueMatt> oh, wait, no, you also want a new getdata type 12:52 < BlueMatt> cause otherwise you still need the ActivateBestChain in ProcessGetBlockData 12:52 < BlueMatt> which would require negotiation 12:53 < sdaftuar> yeah ok 12:53 < BlueMatt> so either that, or we start using NOTFOUNDs, I guess 12:53 < BlueMatt> I'm not sure what I prefer, so.....thoughts? 12:53 < sdaftuar> i think notfounds are worse because of the case where the block might not have been validated either way 12:53 < sdaftuar> it complicates download logic 12:53 < wumpus> if there is no specific reason to re-use NOTFOUND, a new message is much better imo 12:53 < BlueMatt> yea, its not really "notfound" its "I may find this soon" 12:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 12:54 < BlueMatt> or, really, "I dont currently find this" 12:54 < sipa> i don't think we should do protocol design in this meeting 12:54 < BlueMatt> well, there's a few options, so...good to ask 12:54 < wumpus> not the design but discussing it as a concern is valid 12:54 < wumpus> agree BlueMatt 12:55 < BlueMatt> obviously requires BIP and whatever else 12:55 < wumpus> yes 12:55 < wumpus> #topic queue drain lock assertions to avoid deadlocks (BlueMatt) 12:56 < BlueMatt> this one is less interesting, i realize now I should just open a pr and people will see it 12:56 < BlueMatt> its kinda knotty to describe 12:56 < BlueMatt> but, essentially, if you call ABC within a validationinterface callback you're hosed 12:56 < wumpus> ok, well only 4 minutes t ogo anyhow 12:56 < BlueMatt> which sucks, but I dont think we have a way to fix it 12:56 < BlueMatt> so current approach is to document it and DEBUG_LOCKORDER-assert 12:56 < BlueMatt> we can relax the requirement a bit with skeees' proposed validation-in-its-own-thread stuff 12:57 < BlueMatt> but there will still be some call restrictions 12:57 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has quit [Remote host closed the connection] 12:58 < BlueMatt> ok endtopic 12:58 < wumpus> #endmeeting 12:58 < lightningbot> Meeting ended Thu May 17 19:58:35 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 12:58 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-05-17-19.00.html 12:58 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-05-17-19.00.txt 12:58 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-05-17-19.00.log.html 12:59 < cfields> my only request (same as always) is avoiding "if(on_thread1) foo() else bar()" type logic 13:01 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 13:02 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has quit [Remote host closed the connection] 13:02 < BlueMatt> cfields: nah, more a DUMMY_LOCK(on_thread1); AssertLockNotHeld(on_thread1) :p 13:02 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 276 seconds] 13:02 < promag> jonasschnelli: will fix 13:03 < jonasschnelli> thx 13:03 < promag> np, see you later 13:07 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 13:08 -!- laurentmt [~Thunderbi@62.112.9.237] has quit [Quit: laurentmt] 13:09 < bitcoin-git> [bitcoin] laanwj opened pull request #13265: wallet: Exit SyncMetaData if there are no transactions to sync (master...2018_05_wallet_syncmetadata_empty_range) https://github.com/bitcoin/bitcoin/pull/13265 13:09 -!- promag [~promag@145.166.108.93.rev.vodafone.pt] has quit [Remote host closed the connection] 13:14 -!- moneyball [~moneyball@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 13:14 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 13:15 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has quit [Remote host closed the connection] 13:17 < gmaxwell> cfields: I dunno if you discussed this with pieter before, but an alternative to your UHS that I suggested to him previously was that if you have a per-node secret salt S, then for all "hash-like" scriptpubkey types, you could store as a key H(s || script-type || txid || vout || scriptpubkey-data)[0:16] and value is just the compact_amount. This would allow storing almost all utxo in about 20 13:17 < gmaxwell> bytes, have a reasonable security argument, and require no network communications overhead. 13:17 < achow101> damn, I forgot there was a meeting today 13:17 < achow101> wumpus: can I get #12136 for high prio? 13:17 < gmaxwell> The security argument is that with an attacker unknown salt S, the only property you need from the hash resistance to chance collisions. (also even if there were one, it would just break a single node). 13:17 < gribble> https://github.com/bitcoin/bitcoin/issues/12136 | Implement BIP 174 Partially Signed Bitcoin Transactions by achow101 · Pull Request #12136 · bitcoin/bitcoin · GitHub 13:18 < jamesob> #13219 seems to have high review-effort:reward ratio in case anyone's bored 13:18 < gribble> https://github.com/bitcoin/bitcoin/issues/13219 | bench: Add block assemble benchmark by MarcoFalke · Pull Request #13219 · bitcoin/bitcoin · GitHub 13:19 < gmaxwell> cfields: if it isn't obvious how you verify against it, when a transaction comes in, you take its input txin and vout indexes, and look at the scriptsig and construct the appropriate scriptpubkey from it. Then check if thats in the database. 13:19 < jamesob> *low, ugh 13:19 -!- Dizzle [~dizzle@108.171.182.16] has quit [Ping timeout: 256 seconds] 13:22 -!- Randolf [~randolf@d75-157-101-171.bchsia.telus.net] has quit [Ping timeout: 264 seconds] 13:30 -!- hsmiths [uid95325@gateway/web/irccloud.com/x-gmchzjnotvxhmxrv] has quit [Quit: Connection closed for inactivity] 13:32 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 13:33 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has quit [Client Quit] 13:37 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 13:38 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 13:40 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 13:41 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 13:41 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 13:57 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 14:05 -!- Murch [~murch@96.74.120.81] has joined #bitcoin-core-dev 14:09 < cfields> gmaxwell: yea, we discussed that as well. I'm not opposed, but I wanted to introduced the idea as a near drop-in for the status-quo, security wise. That salt ends up acting as a private key somewhat, which is not major but not trivial either 14:11 < cfields> gmaxwell: please mention that on the thread though. I just wanted to introduce the paradigm, I'm sure there are lots of better ways to execute it :) 14:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 14:13 -!- kn3wt [b999b34e@gateway/web/freenode/ip.185.153.179.78] has joined #bitcoin-core-dev 14:18 -!- bsm1175321 [~mcelrath@173-9-124-61-NewEngland.hfc.comcastbusiness.net] has quit [Ping timeout: 248 seconds] 14:21 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 14:22 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 14:37 -!- Sinclair6 [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has quit [Ping timeout: 256 seconds] 14:37 -!- kn3wt [b999b34e@gateway/web/freenode/ip.185.153.179.78] has quit [Quit: Page closed] 14:57 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:59 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 256 seconds] 15:10 -!- clarkmoody [~clarkmood@47-218-248-206.bcstcmta04.res.dyn.suddenlink.net] has quit [] 15:10 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 256 seconds] 15:12 -!- hsmiths [uid95325@gateway/web/irccloud.com/x-ebwzjzcqvcyuzgtl] has joined #bitcoin-core-dev 15:28 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 15:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 15:37 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 15:38 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 15:39 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 15:40 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 15:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 15:46 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 260 seconds] 16:03 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 16:04 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 16:11 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has quit [Quit: honeybadgerdgaf] 16:12 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has joined #bitcoin-core-dev 16:12 -!- Sinclair6 [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has joined #bitcoin-core-dev 16:12 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Remote host closed the connection] 16:13 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has quit [Client Quit] 16:14 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has joined #bitcoin-core-dev 16:21 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 16:32 -!- CubicEarths [~cubiceart@c-66-30-214-9.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 16:36 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has quit [Quit: honeybadgerdgaf] 16:37 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has joined #bitcoin-core-dev 16:38 -!- CubicEarths [~cubiceart@c-66-30-214-9.hsd1.ma.comcast.net] has quit [Remote host closed the connection] 16:39 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 16:41 -!- glaksmono [~glaksmono@182.23.105.58] has joined #bitcoin-core-dev 16:44 -!- glaksmon_ [~glaksmono@182.23.105.58] has joined #bitcoin-core-dev 16:44 -!- glaksmono [~glaksmono@182.23.105.58] has quit [Read error: Connection reset by peer] 16:45 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 16:55 -!- jtimon [~quassel@52.29.134.37.dynamic.jazztel.es] has quit [Ping timeout: 256 seconds] 17:02 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 260 seconds] 17:02 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has quit [Quit: honeybadgerdgaf] 17:03 -!- goatpig [56f75200@gateway/web/freenode/ip.86.247.82.0] has quit [Ping timeout: 260 seconds] 17:04 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 17:14 < bitcoin-git> [bitcoin] Empact opened pull request #13266: refactoring: Inline DataFromTransaction via new SignatureData constructor (master...data-from-transaction) https://github.com/bitcoin/bitcoin/pull/13266 17:15 < bitcoin-git> [bitcoin] Empact opened pull request #13267: refactoring: Clean up GetWitnessCommitmentIndex, and exit early on success (master...witness-committment-index) https://github.com/bitcoin/bitcoin/pull/13267 17:16 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 17:16 -!- moneyball [~moneyball@12.250.207.42] has joined #bitcoin-core-dev 17:17 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 17:18 < fanquake> Looks like GitHub has updated the landing page again. Hopefully they haven't prioritised that over banishing the unicorns.. 17:28 < bitcoin-git> [bitcoin] Empact opened pull request #13268: Consistently bounds-check vin/vout access, and throw on out-of-bounds access (master...vout-bounds-check) https://github.com/bitcoin/bitcoin/pull/13268 17:28 -!- moneyball [~moneyball@12.250.207.42] has quit [Ping timeout: 256 seconds] 17:48 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 17:54 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 18:00 < bitcoin-git> [bitcoin] Empact opened pull request #13269: refactoring: Drop UpdateTransaction in favor of UpdateInput (master...update-transaction) https://github.com/bitcoin/bitcoin/pull/13269 18:01 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has joined #bitcoin-core-dev 18:03 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 18:05 -!- Sinclair6 [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has quit [Ping timeout: 276 seconds] 18:08 -!- glaksmon_ [~glaksmono@182.23.105.58] has quit [Remote host closed the connection] 18:21 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has quit [Quit: honeybadgerdgaf] 18:22 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 260 seconds] 18:22 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 18:23 -!- Randolf [~randolf@96.53.47.38] has joined #bitcoin-core-dev 18:24 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has joined #bitcoin-core-dev 18:27 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 256 seconds] 18:28 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has quit [Client Quit] 18:40 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has joined #bitcoin-core-dev 18:46 -!- glaksmono [~glaksmono@182.23.105.58] has joined #bitcoin-core-dev 19:06 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-ojdisbzgismsraeb] has quit [Quit: Connection closed for inactivity] 19:09 -!- glaksmono [~glaksmono@182.23.105.58] has quit [Remote host closed the connection] 19:32 -!- keymone [~keymone@ip1f13761c.dynamic.kabel-deutschland.de] has quit [Ping timeout: 248 seconds] 19:34 -!- keymone [~keymone@ip1f13761c.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev 19:34 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 255 seconds] 19:36 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 19:38 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 268 seconds] 19:51 -!- keymone [~keymone@ip1f13761c.dynamic.kabel-deutschland.de] has quit [Ping timeout: 240 seconds] 19:52 -!- keymone [~keymone@ip1f13761c.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev 19:57 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 19:59 -!- Samdney [~Samdney@80.255.10.204] has quit [Quit: Verlassend] 20:01 -!- CubicEarths [~cubiceart@c-66-30-214-9.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 20:05 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has quit [Quit: honeybadgerdgaf] 20:06 -!- JackH [~laptop@79-73-185-29.dynamic.dsl.as9105.com] has quit [Ping timeout: 240 seconds] 20:11 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 276 seconds] 20:13 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has joined #bitcoin-core-dev 20:15 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has quit [Client Quit] 20:36 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has joined #bitcoin-core-dev 20:47 -!- Murch [~murch@96.74.120.81] has quit [Quit: Snoozing.] 20:58 -!- CubicEarths [~cubiceart@c-66-30-214-9.hsd1.ma.comcast.net] has quit [] 21:05 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 21:16 -!- honeybadgerdgaf [~alastairm@203.96.123.200] has quit [Quit: honeybadgerdgaf] 21:18 -!- Sinclair6 [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has joined #bitcoin-core-dev 21:21 -!- Krellan_ [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 21:24 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 255 seconds] 21:26 -!- Krellan_ [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 260 seconds] 22:04 -!- niska [~niska@68.ip-149-56-14.net] has quit [Quit: Leaving] 22:17 -!- niska [~niska@68.ip-149-56-14.net] has joined #bitcoin-core-dev 22:19 -!- glaksmono [~glaksmono@182.23.105.58] has joined #bitcoin-core-dev 22:20 -!- DougieBot5000_ [~DougieBot@unaffiliated/dougiebot5000] has joined #bitcoin-core-dev 22:21 -!- twistedline [~quassel@unaffiliated/twistedline] has quit [Ping timeout: 248 seconds] 22:21 -!- DougieBot5000 [~DougieBot@unaffiliated/dougiebot5000] has quit [Killed (leguin.freenode.net (Nickname regained by services))] 22:21 -!- DougieBot5000_ is now known as DougieBot5000 22:27 -!- Krellan [~Krellan@c-73-223-240-37.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 22:32 -!- Krellan [~Krellan@c-73-223-240-37.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds] 22:36 -!- Krellan [~Krellan@2601:640:4000:9258:890c:f79e:1ef:2eb4] has joined #bitcoin-core-dev 22:48 -!- Randolf [~randolf@96.53.47.38] has quit [Ping timeout: 256 seconds] 22:50 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 23:06 -!- twistedline [~quassel@unaffiliated/twistedline] has joined #bitcoin-core-dev 23:11 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 23:11 -!- twistedline [~quassel@unaffiliated/twistedline] has quit [Ping timeout: 260 seconds] 23:18 -!- glaksmono [~glaksmono@182.23.105.58] has quit [Remote host closed the connection] 23:19 -!- twistedline [~quassel@unaffiliated/twistedline] has joined #bitcoin-core-dev 23:23 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 264 seconds] 23:30 -!- glaksmono [~glaksmono@182.23.105.58] has joined #bitcoin-core-dev 23:33 -!- glaksmono [~glaksmono@182.23.105.58] has quit [Remote host closed the connection] 23:44 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Plugging out.] 23:45 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-wvvhsvckjmgnuqfc] has joined #bitcoin-core-dev