--- Day changed Fri Jun 01 2018 00:00 < sipa> the wallet should not care about whether it has the private key or not 00:00 < jonasschnelli> But since multiwallet, this is no longer necesarry I gues 00:00 < jonasschnelli> *s 00:00 < sipa> please, read my gist :) 00:00 < jonasschnelli> Yes. I see. Makes sense to me... 00:00 < jonasschnelli> Yes. I should read your gist every morning... 00:00 < jonasschnelli> amen. :) 00:04 -!- lxer [~lx@ip5f5bd657.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev 00:27 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 240 seconds] 00:31 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 00:33 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 00:34 < fanquake> wumpus got a 6.3 vm setup, will get through those bsd PRs 00:45 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 250 seconds] 00:47 -!- vicenteH [~user@204.red-83-58-238.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 00:47 -!- kinlo [~peter@unaffiliated/kinlo] has joined #bitcoin-core-dev 00:47 -!- wallet42 [sid154231@gateway/web/irccloud.com/x-wprdbhoyzvvdzufo] has joined #bitcoin-core-dev 00:47 -!- gaf_ [~fag@12.smos-linux.org] has joined #bitcoin-core-dev 00:47 -!- exit70 [sid231392@gateway/web/irccloud.com/x-rbipitdljcurutho] has joined #bitcoin-core-dev 00:47 -!- rubensayshi_ [sid201751@gateway/web/irccloud.com/x-xuuylxfwggrfjusi] has joined #bitcoin-core-dev 00:47 -!- CryptAxe [~CryptAxe@2400:8902::f03c:91ff:fe92:b2bd] has joined #bitcoin-core-dev 00:47 -!- pindarhk_ [sid105966@gateway/web/irccloud.com/x-kjuxuddxjicsrvdj] has joined #bitcoin-core-dev 00:47 -!- bosma [sid103570@gateway/web/irccloud.com/x-uxpdmsncniplvyhf] has joined #bitcoin-core-dev 00:47 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev 00:47 -!- Eliel [~jojkaart@104-250-47-212.rev.cloud.scaleway.com] has joined #bitcoin-core-dev 00:47 -!- delpa^ [~punch@8.12.28.87] has joined #bitcoin-core-dev 00:47 -!- cncr04s [~cncr04s@unaffiliated/cncr04s] has joined #bitcoin-core-dev 00:47 -!- exit70 [sid231392@gateway/web/irccloud.com/x-rbipitdljcurutho] has quit [Max SendQ exceeded] 00:49 -!- exit70 [sid231392@gateway/web/irccloud.com/x-xoxkccpqvdadfykp] has joined #bitcoin-core-dev 01:00 < wumpus> fanquake: great! 01:03 -!- Cory [~Cory@unaffiliated/cory] has quit [Ping timeout: 260 seconds] 01:05 < fanquake> #13355 fixes running gmake check 01:05 < gribble> https://github.com/bitcoin/bitcoin/issues/13355 | Fix "gmake check" under OpenBSD 6.3 (probably *BSD): Avoid using GNU grep specific regexp handling by practicalswift · Pull Request #13355 · bitcoin/bitcoin · GitHub 01:06 < wumpus> thanks for checking, it seems about time to merge it 01:09 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/87a9d03c0c1e...0b1c0c462eda 01:09 < bitcoin-git> bitcoin/master db56755 practicalswift: Fix "gmake check" under OpenBSD 6.3 (probably *BSD): Avoid using GNU grep specific regexp handling 01:09 < bitcoin-git> bitcoin/master 0b1c0c4 Wladimir J. van der Laan: Merge #13355: Fix "gmake check" under OpenBSD 6.3 (probably *BSD): Avoid using GNU grep specific regexp handling... 01:09 -!- Pasha [~Cory@unaffiliated/cory] has joined #bitcoin-core-dev 01:10 < bitcoin-git> [bitcoin] laanwj closed pull request #13355: Fix "gmake check" under OpenBSD 6.3 (probably *BSD): Avoid using GNU grep specific regexp handling (master...openbsd-gmake-check) https://github.com/bitcoin/bitcoin/pull/13355 01:10 < fanquake> Obviously 13294 was submitted without running any tests, seeing as they would have been broken at the time.. ? Bit scary given the changes 01:11 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 01:11 -!- aaa_ [ca4202f4@gateway/web/freenode/ip.202.66.2.244] has joined #bitcoin-core-dev 01:12 < aaa_> join 01:12 < aaa_> ?? 01:12 -!- aaa_ is now known as Guest15263 01:12 < Guest15263> 11111 01:12 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:12 -!- Pasha is now known as Cory 01:13 < Guest15263> 31232321 01:13 < Guest15263> adad 01:13 < Guest15263> ad 01:13 < Guest15263> d 01:13 < Guest15263> d 01:13 < Guest15263> d 01:13 < Guest15263> d 01:13 < Guest15263> d 01:13 < Guest15263> d 01:13 < Guest15263> d 01:13 < Guest15263> d 01:13 < Guest15263> d 01:13 < Guest15263> d 01:13 < Guest15263> d 01:13 < fanquake> Please stop. 01:14 < Guest15263> Why no one speaks?Is this a bitcore channel? 01:15 < fanquake> This channel is for Core Development discussion. Generally there are always hundreds of people idling/watching. Actually discussion happens sporadically. 01:15 < fanquake> *actual 01:16 < Guest15263> soga 01:17 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:17 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 256 seconds] 01:26 < wumpus> fanquake: #13294 duplicates too much of the ifdef forest for my taste, Maybe empact's idea of just pre-declaring the function instead would result in less mess. 01:26 < gribble> https://github.com/bitcoin/bitcoin/issues/13294 | Fix compiler warnings emitted when compiling under stock OpenBSD 6.3 by practicalswift · Pull Request #13294 · bitcoin/bitcoin · GitHub 01:28 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 01:29 < wumpus> I think there should be a limit to how much logic to add just to avoid a compiler warning, we're at the point again where the avoidance of warnings becomes a goal in itself instead of an indication of potential problems. 01:30 < wumpus> I mean at least in #13349 I also solved an issue, while removing the warning. 01:30 < gribble> https://github.com/bitcoin/bitcoin/issues/13349 | bench: Dont return a bool from main by laanwj · Pull Request #13349 · bitcoin/bitcoin · GitHub 01:32 < fanquake> wumpus I agree. Should find out what the test plan was to ensure that no behaviour changed for any of the platforms affected by that forrest, just to silence a warning. 01:32 < fanquake> That feels like exactly the kind of place you'd subtly break something. 01:33 < wumpus> woule be a very bad place to break something too, and hard todetect 01:47 < bitcoin-git> [bitcoin] jonasschnelli pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/0b1c0c462eda...343d4e44ef4d 01:47 < bitcoin-git> bitcoin/master 9421317 John Newbery: [wallet] [rpc] Add `createwallet` RPC... 01:47 < bitcoin-git> bitcoin/master 32167e8 John Newbery: [wallet] [tests] Add tests for `createwallet` RPC. 01:47 < bitcoin-git> bitcoin/master f7e153e John Newbery: [wallets] [docs] Add release notes for createwallet RPC. 01:47 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #13058: [wallet] `createwallet` RPC - create new wallet at runtime (master...create_wallet) https://github.com/bitcoin/bitcoin/pull/13058 01:52 -!- Guest15263 [ca4202f4@gateway/web/freenode/ip.202.66.2.244] has quit [Quit: Page closed] 01:52 < fanquake> wumpus #13353 looks ok 01:52 < gribble> https://github.com/bitcoin/bitcoin/issues/13353 | qa: Fixup setting of PATH env var by MarcoFalke · Pull Request #13353 · bitcoin/bitcoin · GitHub 02:05 < wumpus> yes 02:05 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/343d4e44ef4d...d4f6dac9abf8 02:05 < bitcoin-git> bitcoin/master fa26cf0 MarcoFalke: qa: Fixup setting of PATH env var 02:05 < bitcoin-git> bitcoin/master d4f6dac Wladimir J. van der Laan: Merge #13353: qa: Fixup setting of PATH env var... 02:06 < bitcoin-git> [bitcoin] laanwj closed pull request #13353: qa: Fixup setting of PATH env var (master...Mf1806-qaPathBitcoind) https://github.com/bitcoin/bitcoin/pull/13353 02:16 < kewde[m]> https://github.com/bitcoin/bitcoin/blob/0.16/src/qt/locale/bitcoin_ru.ts#L65 02:16 < kewde[m]> What a weird translation - seems like the Russian language is adopting bitcoin addresses as new vocabulary. 02:17 < wumpus> kewde[m]: yuck 02:17 < fanquake> kewde[m] heh. Could you report it upstream? https://www.transifex.com/bitcoin/bitcoin/ 02:17 < wumpus> kewde[m]: thanks for noticing 02:17 < wumpus> fanquake: I'm just going to nuke the message 02:17 < wumpus> (on transfex) 02:17 < fanquake> wumpus np 02:18 < kewde[m]> I can't take credit for noticing it - just passing along the message. 02:18 < wumpus> good that it was caught in a rc at least 02:19 < wumpus> fanquake: maybe delete the entire Russian translation to teach them a lesson :p 02:19 < kewde[m]> https://insight.bitpay.com/address/12Ny5wkrQ5d5bVk2LANAx5R3wcMT9HLFz9 02:20 < fanquake> wumpus heh, poor translators 02:20 < wumpus> I think this is the first time this was ever tried, or at least reported. I'll change the import translations script to check for this. 02:21 < kewde[m]> It hasn't received any funds recently - but there is a tx from 2017 O_o 02:22 < wumpus> kewde[m]: bizarre 02:23 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has quit [Read error: Connection reset by peer] 02:24 < wumpus> I reverted the message on transifex (they keep a history, thankfully). https://www.transifex.com/user/profile/IVAN6015/ is the person that added the address. 02:24 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has joined #bitcoin-core-dev 02:25 < wumpus> looks like they did no other damage at least in RU 02:28 < fanquake> wumpus good to know 02:28 < fanquake> I'm heading out, will get some more review done tomorrow. 02:28 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 02:29 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has quit [Ping timeout: 244 seconds] 02:38 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.16: https://github.com/bitcoin/bitcoin/commit/4ea3e8ef070417ccc22007407d78fa0a41949bee 02:38 < bitcoin-git> bitcoin/0.16 4ea3e8e Wladimir J. van der Laan: qt: Periodic translations update... 02:39 < wumpus> the address will be gone in next rc 02:42 < wumpus> created issue #13363 02:42 < gribble> https://github.com/bitcoin/bitcoin/issues/13363 | Make update-translations.py script check for (valid) bitcoin addresses · Issue #13363 · bitcoin/bitcoin · GitHub 02:43 < wumpus> (might have a stab at this myself later, but if someone else wants to, you're very welcome) 02:47 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 02:52 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Write error: Connection reset by peer] 02:52 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Write error: Connection reset by peer] 02:54 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 03:07 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 03:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:30 < bitcoin-git> [bitcoin] mess110 opened pull request #13364: update transifex doc links (master...fix_transifex_client_config_link) https://github.com/bitcoin/bitcoin/pull/13364 03:40 -!- drizztbsd is now known as timothy 03:42 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:44 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 244 seconds] 03:46 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:50 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 244 seconds] 04:04 -!- mess110 [~kiki@95.77.248.16] has joined #bitcoin-core-dev 04:05 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 240 seconds] 04:05 < mess110> hi 04:05 < mess110> can I please get a rebuild for https://github.com/bitcoin/bitcoin/pull/13364 ? I updated some doc links but some test failed 04:09 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 04:10 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 04:15 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 240 seconds] 04:15 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 04:18 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 04:25 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 04:30 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 04:30 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 276 seconds] 04:34 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 04:39 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 244 seconds] 04:46 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 04:53 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 260 seconds] 05:01 < wumpus> mess110: I've triggered the failed build 05:01 < wumpus> going to merge #13352 as it's anoying that travis fails all the time 05:01 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 05:01 < gribble> https://github.com/bitcoin/bitcoin/issues/13352 | qa: Avoid checking reject code for now by MarcoFalke · Pull Request #13352 · bitcoin/bitcoin · GitHub 05:03 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d4f6dac9abf8...e24bf1ce184b 05:03 < bitcoin-git> bitcoin/master faac7a2 MarcoFalke: qa: Avoid checking reject code for now... 05:03 < bitcoin-git> bitcoin/master e24bf1c Wladimir J. van der Laan: Merge #13352: qa: Avoid checking reject code for now... 05:04 < bitcoin-git> [bitcoin] laanwj closed pull request #13352: qa: Avoid checking reject code for now (master...Mf1806-qaRejectCode) https://github.com/bitcoin/bitcoin/pull/13352 05:06 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 244 seconds] 05:07 < bitcoin-git> [bitcoin] yuntai opened pull request #13365: RPC/REST/ZMQ: Set label with importprivkey only requested. #13087 (master...master) https://github.com/bitcoin/bitcoin/pull/13365 05:17 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 05:18 -!- niu [~Mutter@198.181.59.68] has joined #bitcoin-core-dev 05:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 05:21 -!- niu [~Mutter@198.181.59.68] has quit [Client Quit] 05:22 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 240 seconds] 05:23 -!- jtimon [~quassel@226.110.132.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 05:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:26 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 05:28 -!- goatpig [56f75200@gateway/web/freenode/ip.86.247.82.0] has joined #bitcoin-core-dev 05:31 -!- laurentmt [~Thunderbi@185.44.76.121] has joined #bitcoin-core-dev 05:33 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 256 seconds] 05:33 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:40 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 05:41 -!- qu4ku [~qu4ku@cms149.neoplus.adsl.tpnet.pl] has joined #bitcoin-core-dev 05:42 -!- qu4ku [~qu4ku@cms149.neoplus.adsl.tpnet.pl] has quit [Read error: Connection reset by peer] 05:42 -!- Krellan [~Krellan@2601:640:4000:9258:55a6:e87:5005:e1b9] has joined #bitcoin-core-dev 05:44 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 05:44 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 05:44 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:45 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 244 seconds] 05:47 -!- Krellan [~Krellan@2601:640:4000:9258:55a6:e87:5005:e1b9] has quit [Ping timeout: 260 seconds] 05:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds] 05:49 -!- qu4ku [~qu4ku@2a01:110f:f73:1b00:782a:8d3:37e0:8224] has joined #bitcoin-core-dev 05:50 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 05:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:54 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 256 seconds] 05:55 < bitcoin-git> [bitcoin] giulio92 opened pull request #13366: Docs: Rename “OS X” to the newer “macOS” convention (master...osx-renaming) https://github.com/bitcoin/bitcoin/pull/13366 06:02 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 06:02 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 248 seconds] 06:07 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 248 seconds] 06:07 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 06:13 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 06:14 < jonasschnelli> sipa: what do you think about "address:/b/w|p" or "script:" or "p2wpkh:/r0-2000/..."? 06:15 < jonasschnelli> pub/xpub is autodetect, first char r | b | w | p is for (r)ange, (b)irthday, (w)atchonly, (p)rivatekey 06:16 < jonasschnelli> we could avoid the first "key-char" and detect the type an the length and characteristics (8byte int == birthday, – == range, etc.) 06:17 < jonasschnelli> But it smells after voodoo... so unsure 06:19 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 276 seconds] 06:21 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 06:25 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 240 seconds] 06:28 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 06:30 -!- gojo [4e1a9764@gateway/web/freenode/ip.78.26.151.100] has joined #bitcoin-core-dev 06:31 < gojo> Hi, I'm experienced developer Blockchain, C/C++, reverse engineering, compilers, drivers, GPU/OpenCL, Cryptography, Python, NodeJS, Linux, Windows, Web, mobile, embedded and more. Urgent! I'm looking for important job! 06:33 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 244 seconds] 06:36 -!- qu4ku [~qu4ku@2a01:110f:f73:1b00:782a:8d3:37e0:8224] has quit [Read error: Connection reset by peer] 06:36 < jonasschnelli> gojo: no jobs here... 06:37 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 06:41 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 240 seconds] 06:42 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Remote host closed the connection] 06:43 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 06:43 -!- drizztbsd is now known as timothy 06:47 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 06:49 < TheCharlatan> Picking up from yesterday's back compat question, I'm having the same problems with gcc-7 as ken2812221 in #12511 using same configure and environment flags as in the gitian linux descriptor. I'm not sure if there is a simple fix available for this, like currently with aliasing memcpy. 06:49 < gribble> https://github.com/bitcoin/bitcoin/issues/12511 | Switch to Ubuntu 18.04 for gitian building · Issue #12511 · bitcoin/bitcoin · GitHub 06:51 -!- laurentmt [~Thunderbi@185.44.76.121] has quit [Quit: laurentmt] 06:52 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 260 seconds] 06:59 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 07:04 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 244 seconds] 07:05 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 07:06 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 07:10 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 256 seconds] 07:15 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 07:20 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 240 seconds] 07:25 < wumpus> I've made a start with the addrv2 BIP spec: https://gist.github.com/laanwj/4fe8470881d7b9499eedc48dc9ef1ad1 07:29 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 07:34 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 244 seconds] 07:37 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 07:39 * jonasschnelli reading addrv2 BIP 07:41 < jonasschnelli> wumpus: nice. 07:41 < jonasschnelli> I like the backward compatible way (only >128bit use v2) 07:42 < jonasschnelli> Not sure about the name addrv2 (versioning of protocol commands) 07:42 < jonasschnelli> or it should be something like addr32 07:42 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 256 seconds] 07:44 < wumpus> yes the name is completely contingent, I don't care 07:44 < wumpus> as for the backwards compatibility, I think I prefer a new network version that simply uses addrv2 only, this will allow moving away from legacy addr messages at some point completely 07:45 < wumpus> I think the only advantage of the backward compatible approach is that it doesn't require a new network version, but I'm not sure how important that is 07:45 < jonasschnelli> Yes. It is a cleaner cut 07:46 < wumpus> we could even *not* rename the message, with the new protocol version, but that introduces some fragility I'm not happy with 07:47 -!- vicenteH [~user@204.red-83-58-238.dynamicip.rima-tde.net] has quit [Ping timeout: 276 seconds] 07:47 -!- vicenteH [~user@204.red-83-58-238.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 07:47 < jonasschnelli> I guess using a varint for services is probably an unnecessary optimization? It would save 33% for a IPv4 addr 07:48 < jonasschnelli> (with the current used service bits) 07:48 < jonasschnelli> AFAIK 07:48 < jonasschnelli> wumpus: I guess not using a new command would probably make a lot of stupid light clients crash. :) 07:49 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 07:49 < wumpus> jonasschnelli: that's an interesting proposal 07:49 < wumpus> jonasschnelli: I like it, don't see a reason why not 07:50 < jonasschnelli> Yes. I think its worth it. 07:50 < wumpus> jonasschnelli: even beter, it's future-proof 07:50 < jonasschnelli> Especially since the addrv2 is already varlen 07:50 < wumpus> (I guess, in a way) 07:51 < jonasschnelli> >8byte service bits?!... not sure if we ever reach that limit :) 07:51 < wumpus> yes, decided on varlen because padding everything to 32 bytes would be crazy, and I like not wasting space for v4 addresses 07:51 < jonasschnelli> Yes. Good point. 07:52 < jonasschnelli> Another redundant byte is the std::vector varlen byte 07:52 < jonasschnelli> But I guess that serialization property we can't change 07:52 < jonasschnelli> (since the length is indirectly defined by the networkID) 07:53 -!- brianhoffman [~brianhoff@pool-173-66-26-200.washdc.fios.verizon.net] has left #bitcoin-core-dev [] 07:54 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 244 seconds] 08:01 -!- m8tion [~Agence@abo-134-110-68.mrs.modulonet.fr] has joined #bitcoin-core-dev 08:02 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 08:05 < luke-jr> wumpus: it might be a good idea to include port in addr 08:05 < luke-jr> hidden services don't have ports IIRC, and non-TCP protocols might not either - or might have 64-bit ports or smth 08:06 < luke-jr> 32-bit times seem to be dying, but we probably will end up with a new addr message before 2038 I guess 08:06 < luke-jr> especially if services isn't revised now 08:07 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 268 seconds] 08:07 < jonasschnelli> makes sense to me: putting port into the addr part 08:08 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 08:13 < wumpus> hidden services have ports 08:13 < wumpus> luke-jr: we could use a VARINT for the time too 08:14 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 268 seconds] 08:15 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 08:15 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 08:15 < wumpus> luke-jr: another option would be to lower precision 08:16 < luke-jr> hmm 08:16 < luke-jr> or both 08:16 < luke-jr> epoch 2009 with 1 hour resolution seems plenty 08:17 < luke-jr> or 90 minutes to be tonal-correct :D 08:18 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has quit [Quit: Leaving.] 08:19 < wumpus> luke-jr: jonasschnelli: changed them both to VARINT, thanks for the comments 08:20 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 248 seconds] 08:23 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has joined #bitcoin-core-dev 08:24 < wumpus> I've added the concern about lowering time precision as well as rolling the port into address into a "considerations" section, I'm not sure about those 08:24 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 08:29 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 248 seconds] 08:29 < luke-jr> well, like I said, it's unlikely we'll still be using this BIP in 2038 if it doesn't improve the services field, so 32-bit time probably is fine 08:30 < luke-jr> and unsigned 32-bit time is actually even 2106, not 2038 08:31 < wumpus> having always been angry at the people that decided to use two-digit years and gave us the Y2K nonsense, I'm very happy to make it 2038-proof 08:33 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 08:38 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 240 seconds] 08:44 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 08:45 -!- Randolf [~randolf@96.53.47.38] has quit [Ping timeout: 244 seconds] 08:50 < gmaxwell> wumpus: cool! 08:50 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 08:52 < gmaxwell> So would this also accomidate I2P? I don't really recall what I2P needed, but I vaguely recall its addresses were 512 bits-ish... though it isn't unlikely that I'm mistaken. 08:52 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 276 seconds] 08:53 < luke-jr> I think that's the goal 08:54 < gmaxwell> oh nevermind I see there is a section, don't see how I missed it on the first pass. 08:54 -!- cncr04s [~cncr04s@unaffiliated/cncr04s] has quit [Ping timeout: 276 seconds] 08:55 < wumpus> gmaxwell: yep - I2P is 256 bits 08:56 -!- cncr04s [~cncr04s@unaffiliated/cncr04s] has joined #bitcoin-core-dev 08:57 < wumpus> (could trivially extend the max length to 512 bits if that turns out to be needed for something, but I like the strict length requirement as it bounds the maximum size of addr messages) 08:57 < gmaxwell> wumpus: some ideas circulating for nodes that store some fraction of the blockchain (e.g. some FEC slice, as in taek's post, or some range of blocks) need a bit of signaling to encode what is there. With 64 bits of 'services' it could be stuffed there, but I'm not sure if thats what you'd want? 08:57 < gmaxwell> yes, I like strict length checking too. 08:58 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 08:58 < gmaxwell> wumpus: so would we want to addrv3 for those things, user service bits, or add some opional field mechenism(s)? 08:58 < luke-jr> gmaxwell: services currently apply an | to the bits, so not useful for multi-bit stuff sadly 08:58 < wumpus> gmaxwell: that was brought up in the meeting yesterday as well, by sdaftuar , but I'm not sure what that would imply in practice 08:59 < wumpus> e.g. gossiping block ranges directly would not be useful as the information is outdated by time someone gets it 08:59 < luke-jr> wumpus: just a seed that nodes can deterministically calculate block numbers from 08:59 < gmaxwell> wumpus: these wouldn't be outdated by construction. 08:59 < gmaxwell> as luke-jr says. 08:59 < wumpus> but if it's some other kind of descriptor, sure, it could be added 08:59 < gmaxwell> (also, FEC slice proposals don't have that issue) 08:59 < wumpus> how many bits per address? 09:00 < gmaxwell> I haven't seen any ideas that need more than 32 bits, most probably need 8-16 bits. Perhaps just stick in a 32 bit field which has a "service flag specific interpertation" ? 09:00 < luke-jr> there might be a fingerprinting risk here with too many bits, but too few might be an issue for storage too 09:00 < wumpus> an optional field mechanism could work, but otoh, I'm a bit afraid of overdesign (also: it still has to be bounded) 09:00 < gmaxwell> luke-jr: yes but leave that problem to the other proposals. 09:01 < luke-jr> ah, true 09:01 < wumpus> ah, an optional 32-bit field per service bit? 09:02 < luke-jr> then I can make a 2k addr message.. :/ 09:02 < gmaxwell> If you care about space time field could be reduced to 16 bits easily. Turn it into a "time ago seen" quantized to 1 hour precision. (IIRC we quantize times to 2hrs regardless). 09:03 < gmaxwell> wumpus: oh I wasn't thinking of that, I was just thinking of 32 bits whos meaning is defined as "depends on the service bits". 09:03 < gmaxwell> (e.g. just to take specifying its content out of scope for this BIP) 09:03 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 268 seconds] 09:04 < gmaxwell> having a field per service bit would be nice but unfortunately would allow huge messages. 09:06 < luke-jr> I suppose nodes could policy-drop the extra data if they don't comprehend it? 09:07 < gmaxwell> wumpus: is there any particular reason why you have a potentially irrelevant port field, rather than encoding the port in the low bytes of the address as relevant for the service type? 09:07 < gmaxwell> luke-jr: then you need a mechenism to encode which extra data is there. 09:07 < luke-jr> gmaxwell: you need that anyway if it's optional? 09:08 < luke-jr> and it wouldn't make sense to have extra data for most of the current service bits 09:08 < gmaxwell> luke-jr: right well if we didn't care about size we could just define that every service bit set gets 32 bits of flags. :) 09:10 < gmaxwell> if we want optional flags. I guess the best thing would just be a byte to include the count of them, then a byte "type" for each one where the type also encodes if the payload is 0/8/16/32 bits. (using the two MSB of the type to encode the length). And then bound the count of them so that the total is still reasonably sized. 09:11 < gmaxwell> And then define nodes should strip ones they don't understand. 09:11 < gmaxwell> or something along those lines. 09:11 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 09:12 < wumpus> gmaxwell: yes, making the port optinal or rolling it into addr was mentioned by luke-jr, it's under "considerations", I'm not sure 09:12 < gmaxwell> If that kind of mechenism existed there might be less argument to make service flags anything but 32 bits? 09:13 < gmaxwell> wumpus: I don't care one way or another, it would save two bytes when not used, and perhaps eliminate some stupidity of what happens when it's non-zero for I2P or whatever doesn't use it. 09:13 < wumpus> gmaxwell: at least currently all the mechanisms have a concept of port 09:14 -!- Randolf [~randolf@96.53.47.38] has joined #bitcoin-core-dev 09:14 < gmaxwell> My memory of I2P is really bad then. 09:14 < wumpus> 32 bits "depending on the service bits" would be ok, although it leaves some difficulty if multiple service bits want to use it 09:15 < wumpus> same here, I intend to run this by one of the I2P devs before publishing it anyhow 09:15 -!- brianhoffman [~brianhoff@pool-173-66-26-200.washdc.fios.verizon.net] has joined #bitcoin-core-dev 09:16 < gmaxwell> Beyond node-flavors for striping, another thing we might want more payload for is alternative ports for other transports. E.g. if later we define a bitcoin-over-udp we might want to signal the ports for that instead of sending two addr messages for the two endpoints. I'm not currently remembering any other service flag things where we've wanted other payload. 09:16 < gmaxwell> but I'm sure we could come up with other ones. 09:16 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 260 seconds] 09:17 < gmaxwell> I don't feel that strongly about any of this of course, if we're too limited it's not like it's a big deal to define an addr3. 09:18 < wumpus> we already send multiple addr messages when listening to multiple interfaces 09:18 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 09:19 < wumpus> but indeed there's a lot of reasons adding service-specfic information to gossiping would potentiall be useful, even though we have none at the moment 09:19 < gmaxwell> yes though it would be really inefficient if almost every node were doing it. 09:19 < gmaxwell> (sending a whole seperate addr just to give another 16 bit port number) 09:20 < wumpus> yes 09:23 < wumpus> there's risk of combinatorial blowup there 09:23 < wumpus> that's a good argument for encoding the port separately though 09:23 < wumpus> that extends better to having multiple ports 09:24 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 276 seconds] 09:24 < gmaxwell> one could use the above mechenism of a byte followed by payload to do the port. 09:24 < wumpus> yes 09:26 < wumpus> that's a good idea, I think 09:27 < wumpus> though it increases the average size, port is only 2 bytes, making it a 'data item' will by definition be larger 09:28 < gmaxwell> Yes, though it's two bytes overhead assuming you used my above suggestion and had no other data items. 09:28 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 09:28 < gmaxwell> One byte overhead if you had other data items. 09:29 < wumpus> true, I just mean in practice, everything will be sending a port 09:29 < gmaxwell> And I think if the data item mechenism existed service bits could stay 32 bits, saving a byte. 09:30 < gmaxwell> or you keep the port field (or merge into the variable length addresses) for the primary port to get that savings. 09:30 < wumpus> aren't service bits 64 bits right now? 09:30 < gmaxwell> oh. hm! I thought they were 32bits! 09:31 < gmaxwell> nope, 64. 09:31 < wumpus> I thought so too yesterday 09:31 < wumpus> that's why Jonas proposed turning it into a VARINT, which I did 09:32 < sipa> they're 64 bits now 09:33 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 276 seconds] 09:36 < wumpus> I wonder if CJDNS should get its own network id, the reason I'm not sure is because they're explicitly IPv6 addresses 09:37 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 09:38 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 09:38 < gmaxwell> I suspect it should, since you can't reach them unless you use CJDNS? so it's like onion embedded tor? 09:39 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 09:39 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 09:40 < sipa> yeah, i good criterion for separate networks would be whether they need separate routing 09:41 < wumpus> gmaxwell: that's true; the differece is that cjdns runs as a network interface, so from the viewpoint of the application it's simply IPv6 networking. OTOH it's possible to set up the firewall to do the same with TOr, so I'm not sure it's a useful distinction for this. 09:41 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 09:41 < wumpus> so yes, better to just add a n ID, they're cheap 09:46 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 260 seconds] 09:47 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 09:47 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev 09:52 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 240 seconds] 09:55 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 09:59 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 245 seconds] 10:03 -!- jhfrontz [~Adium@165.171.225.5] has joined #bitcoin-core-dev 10:09 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 10:13 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 240 seconds] 10:15 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 265 seconds] 10:22 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 10:24 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 10:26 < wumpus> I guess we could save 6 bytes per Tor v2 address by not doing the onioncat thing (otoh, who's going to care about that going forward) 10:28 < gmaxwell> ah, just don't onioncat embed them. that would be nice. though who cares much about tor v2. 10:29 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 268 seconds] 10:31 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #13367: qa: Increase includeconf test coverage (master...Mf1806-qaIncludeconf) https://github.com/bitcoin/bitcoin/pull/13367 10:31 < gmaxwell> I assume that within a couple years we'll stop forwarding torv2 completely. 10:32 -!- vicenteH [~user@204.red-83-58-238.dynamicip.rima-tde.net] has quit [Ping timeout: 248 seconds] 10:36 < sipa> wumpus: for simplicity, i think it makes sense to put tor v2 in a separate class 10:36 < sipa> it needs separate routing after all 10:36 < wumpus> sipa: that's what I've done, I just kept the onioncat wrapping (so addresses are 16 bytes not 10) 10:37 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 10:37 < wumpus> gmaxwell: exactly my point, we don't really want to encourage torv2 after this work we're doing to support torv3 which is better in any way 10:37 < sipa> wumpus: sorry, i should read first 10:41 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 244 seconds] 10:45 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 10:51 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 10:56 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 255 seconds] 11:04 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 11:08 < bitcoin-git> [bitcoin] achow101 opened pull request #13368: Update gitian-build.sh for docker (master...gitian-docker) https://github.com/bitcoin/bitcoin/pull/13368 11:08 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 240 seconds] 11:14 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 11:21 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 244 seconds] 11:25 < bitcoin-git> [bitcoin] mess110 closed pull request #13364: update transifex doc links (master...fix_transifex_client_config_link) https://github.com/bitcoin/bitcoin/pull/13364 11:27 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 11:28 < bitcoin-git> [bitcoin] mess110 opened pull request #13369: [docs] update transifex doc link (master...fix_transifex_doc_link) https://github.com/bitcoin/bitcoin/pull/13369 11:31 < echeveria> wumpus: cjd is pretty much exclusively ipv6 in their own range. 11:31 < echeveria> it's really kind of its own net because you can't reach any of the peers any other way. 11:31 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 244 seconds] 11:33 < wumpus> echeveria: indeed, there are no 'exit nodes' 11:36 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 11:41 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 260 seconds] 11:41 -!- mess110 [~kiki@95.77.248.16] has quit [Quit: Leaving] 11:48 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 11:51 -!- HFRadical [~none@71.19.251.248] has joined #bitcoin-core-dev 11:51 -!- HFRadical [~none@71.19.251.248] has quit [Max SendQ exceeded] 11:53 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 260 seconds] 11:55 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 12:00 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 244 seconds] 12:02 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 12:07 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 260 seconds] 12:07 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 12:10 -!- bitconner [~conner@136.24.175.89] has quit [Read error: Connection reset by peer] 12:14 -!- Randolf [~randolf@96.53.47.38] has quit [Ping timeout: 260 seconds] 12:15 -!- Randolf [~randolf@96.53.47.38] has joined #bitcoin-core-dev 12:17 -!- promag_ [~promag@188.250.246.197] has joined #bitcoin-core-dev 12:18 -!- promag [~promag@188.250.246.197] has joined #bitcoin-core-dev 12:19 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 12:19 -!- promag [~promag@188.250.246.197] has quit [Remote host closed the connection] 12:20 < gmaxwell> cfields: re: the 4/8-way sse/avx hash calculator, one of the reasons why txid computation is a little less interesting other than the complication, is that it's not in the critical path for HB block relay, but tree computation is. 12:20 -!- Randolf [~randolf@96.53.47.38] has quit [Ping timeout: 244 seconds] 12:21 < gmaxwell> and so sipa's PR drops HB relay about 5ms per hop, which is a pretty large fraction of the total processing time. 12:21 -!- promag [~promag@188.250.246.197] has joined #bitcoin-core-dev 12:22 -!- promag_ [~promag@188.250.246.197] has quit [Ping timeout: 256 seconds] 12:22 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 12:23 -!- promag__ [~promag@188.250.246.197] has joined #bitcoin-core-dev 12:25 -!- promag [~promag@188.250.246.197] has quit [Ping timeout: 240 seconds] 12:25 -!- promag__ [~promag@188.250.246.197] has quit [Remote host closed the connection] 12:27 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 12:28 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 12:30 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 256 seconds] 12:30 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 12:43 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev 12:46 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 276 seconds] 12:46 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 12:47 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 12:55 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 240 seconds] 12:56 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 12:58 -!- domble [~domble@2a02:2788:7c4:129:1131:1b9e:76ac:79e5] has joined #bitcoin-core-dev 13:04 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 268 seconds] 13:05 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 13:05 -!- laurentmt [~Thunderbi@185.44.76.121] has joined #bitcoin-core-dev 13:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 13:11 -!- laurentmt [~Thunderbi@185.44.76.121] has quit [Quit: laurentmt] 13:11 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 240 seconds] 14:03 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 14:03 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 14:06 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 268 seconds] 14:06 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 14:26 -!- promag [~promag@188.250.246.197] has joined #bitcoin-core-dev 14:34 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:46 < sipa> wumpus: thanks, read the BIP draft now 14:47 < sipa> it seems strange to use the onioncat embedded for tor v2, if there is a separate network type anyway (it just burdens clients to add/strip/check it ) 14:48 < sipa> varint for 64-bit services... it saves a bit, but they're already 64 bits, and varint can't actually encode anything longer than 64 bits 14:48 -!- vicenteH [~user@35.233.15.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 14:52 < promag> should unloadwallet PR include UI support so that unloaded wallets are removed? 14:57 -!- bitconner [~conner@64-71-8-130.static.wiline.com] has joined #bitcoin-core-dev 14:57 < gojo> What tools you are using for debug view uint256? 14:59 < sipa> it has a GetHex() method for converting to a string 15:01 < gojo> I mean inside gdb UI 15:01 < gojo> i use GetHex() method for debug txdb my fork bugs 15:02 < gojo> I join my own live logging tool for structured logs for fix complex bugs 15:02 < gojo> I can share my code if needed 15:04 < gojo> I looking for another way with gdbgui React debug widget 15:04 < sipa> print pindexBestHeader->phashBlock->GetHex() 15:05 < sipa> $3 = '0' , "2521d8eb85294864f937918dcbdcc33f42ab0c55c5d5b9" 15:06 < gojo> Not very optimal with hidden bugs in 100k blocks. I'm looking for something more easy 15:06 < sipa> i'm not sure what you're asking for 15:07 < gojo> 1. gdb vars view is wrong for uint256 15:07 < gojo> 2. gdbgui require React dev for uint256, reason, but not much time for that 15:08 < sipa> i don't understand that 15:08 < sipa> what is react? 15:08 < gojo> 3. my own logging solution is very slow when txdb has bug in 100k+ blocks 15:08 < gojo> do you know gdbgui? 15:08 < sipa> no 15:09 < gojo> https://github.com/cs01/gdbgui 15:09 < sipa> but what are you trying to achieve? 15:09 < gojo> well customized browser frontend for gdb 15:09 < sipa> i know uint256's internal view doesn't match the normal human readable form (your point 1), but i gave you the solution (use print ....GetHex()) 15:09 < gojo> i need for debug my fork step by step each line for 100k blocks 15:10 < sipa> good luck then 15:10 < gojo> thanks 15:10 < gojo> i'm have solution that maybe helps someone 15:10 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 248 seconds] 15:11 < gojo> i made several forks for Dash, Komodo etc 15:11 < sipa> off topic here 15:11 < gojo> btc-core is not offtopic 15:11 < gojo> i have a logging system for bitcoin-core 15:11 < gojo> i want to share it for made life easier 15:11 < sipa> ok 15:12 < gojo> but maybe someone has better solution 15:12 < sipa> feel free to open a pull request to improve logging, if you have useful code 15:12 < sipa> that sounds very welcome 15:13 < gojo> ok, understand, thanks 15:30 -!- bitconner [~conner@64-71-8-130.static.wiline.com] has quit [Ping timeout: 268 seconds] 15:32 -!- bitconner [~conner@64-71-8-130.static.wiline.com] has joined #bitcoin-core-dev 15:42 -!- lxer [~lx@ip5f5bd657.dynamic.kabel-deutschland.de] has quit [Ping timeout: 260 seconds] 15:53 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 15:55 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 15:57 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 265 seconds] 16:01 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 16:08 -!- jhfrontz [~Adium@165.171.225.5] has quit [Quit: Leaving.] 16:10 -!- lobo_ [67daee45@gateway/web/freenode/ip.103.218.238.69] has joined #bitcoin-core-dev 16:11 -!- lobo_ [67daee45@gateway/web/freenode/ip.103.218.238.69] has quit [Client Quit] 16:12 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 16:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds] 16:17 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 16:20 -!- gojo [4e1a9764@gateway/web/freenode/ip.78.26.151.100] has quit [Ping timeout: 260 seconds] 16:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 16:33 -!- Dizzle [~dizzle@108.171.182.16] has quit [Ping timeout: 240 seconds] 16:34 -!- promag [~promag@188.250.246.197] has quit [Remote host closed the connection] 16:36 -!- roidster [~chatzilla@138.229.133.121] has joined #bitcoin-core-dev 17:21 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Quit: drexl] 17:23 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 265 seconds] 17:36 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 17:37 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 260 seconds] 17:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 17:53 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-hecevcdcnaxnzikk] has joined #bitcoin-core-dev 18:03 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds] 18:04 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 18:05 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 18:07 -!- ctrlbreak [~ctrlbreak@fctnnbsc38w-47-55-95-227.dhcp-dynamic.fibreop.nb.bellaliant.net] has quit [Read error: Connection reset by peer] 18:11 < mryandao> l 18:14 < sipa> m 18:16 < gmaxwell> f 19:13 -!- bitconner [~conner@64-71-8-130.static.wiline.com] has quit [Ping timeout: 240 seconds] 19:18 -!- domble [~domble@2a02:2788:7c4:129:1131:1b9e:76ac:79e5] has quit [Ping timeout: 256 seconds] 19:23 < luke-jr> k 19:29 -!- bitconner [~conner@64-71-8-130.static.wiline.com] has joined #bitcoin-core-dev 19:31 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has joined #bitcoin-core-dev 19:34 -!- bitconner [~conner@64-71-8-130.static.wiline.com] has quit [Ping timeout: 260 seconds] 20:03 < bitcoin-git> [bitcoin] steverusso opened pull request #13372: Docs: Linked to 'Building on FreeBSD' in build-unix.md (master...link-to-building-on-freebsd) https://github.com/bitcoin/bitcoin/pull/13372 20:06 -!- jtimon [~quassel@226.110.132.37.dynamic.jazztel.es] has quit [Ping timeout: 244 seconds] 20:12 -!- goatpig [56f75200@gateway/web/freenode/ip.86.247.82.0] has quit [Ping timeout: 260 seconds] 20:15 -!- Aliencorpse [~Aliencorp@2605:a601:b024:600:5825:d2d7:4b21:87b7] has quit [Quit: Leaving] 20:23 -!- ProfMac [~ProfMac@2001:470:1f0f:226:440f:7ccc:4155:52ef] has quit [Quit: Leaving] 20:24 -!- roidster [~chatzilla@138.229.133.121] has quit [Ping timeout: 265 seconds] 20:41 -!- roidster [~chatzilla@138.229.133.121] has joined #bitcoin-core-dev 20:41 -!- roidster is now known as Guest40919 21:05 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 21:05 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 22:10 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 22:13 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 240 seconds] 22:55 -!- harrymm [~harrymm@104.207.83.39] has quit [Ping timeout: 256 seconds] 23:08 -!- harrymm [~harrymm@104.207.83.39] has joined #bitcoin-core-dev 23:14 -!- lxer [~lx@ip5f5bd657.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev 23:35 < wumpus> sipa: the idea to use VARINT for the service bits is that the higher bits are not used, so on the average case this will save some bytes per entry 23:35 < wumpus> sipa: and ok, I'm fine with removing the onioncat padding for torv2, it seemed easiest for implementations 23:36 < wumpus> sipa: but if you think the VARINT doesn't help I'll change it back to just uint64_t 23:40 < sipa> wumpus: my point is more that if you're going to make it variable length... why limit to 64 bits? 23:49 -!- Guest40919 is now known as roidster 23:55 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev