--- Day changed Mon Jun 18 2018 00:41 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 00:51 -!- laurentmt [~Thunderbi@195.181.167.149] has joined #bitcoin-core-dev 00:56 -!- laurentmt [~Thunderbi@195.181.167.149] has quit [Quit: laurentmt] 01:06 -!- HearingVo [ishka@cpe-72-133-196-45.wi.res.rr.com] has joined #bitcoin-core-dev 01:06 < HearingVo> Can someone provide me with some BitCoin? 01:08 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 01:10 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 01:11 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:15 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:16 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 264 seconds] 01:19 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 01:20 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 01:22 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 01:24 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 01:29 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:35 -!- rk3y [~rk3y@vmd27150.contaboserver.net] has quit [Changing host] 01:35 -!- rk3y [~rk3y@unaffiliated/rk3y] has joined #bitcoin-core-dev 01:39 -!- HearingVo [ishka@cpe-72-133-196-45.wi.res.rr.com] has left #bitcoin-core-dev [] 01:48 < promag> jonasschnelli: friendly ping #13111 01:48 < gribble> https://github.com/bitcoin/bitcoin/issues/13111 | Add unloadwallet RPC by promag · Pull Request #13111 · bitcoin/bitcoin · GitHub 01:54 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 01:56 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 01:56 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 02:03 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 02:04 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 02:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:16 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has joined #bitcoin-core-dev 02:19 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:20 -!- Aaronvan_ is now known as AaronvanW_ 02:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 248 seconds] 02:24 -!- jtimon [~quassel@40.28.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 02:30 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 02:33 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has quit [Quit: WeeChat 2.1] 02:38 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 02:43 -!- gnappuraz [58823167@gateway/web/freenode/ip.88.130.49.103] has joined #bitcoin-core-dev 02:44 < gnappuraz> Hi, I have a question regarding some bitcoin source code i'm trying to understand. Is this the right place? 02:49 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has joined #bitcoin-core-dev 02:51 < jonasschnelli> promag: Yes. Will review this afternoon 02:51 < promag> gnappuraz: just ask 02:51 < promag> jonasschnelli: nice 02:53 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has quit [Client Quit] 02:54 < gnappuraz> I was looking at the wallet.h file, there is a mapWallet map... I was trying to figure out what this map exactly contains 02:56 < gnappuraz> it seems the main memory storage to bookkeep the transactions seen so far. Not sure if invalid txs and txs from forks are there too though 02:58 < jonasschnelli> gnappuraz: What do you mean with invalid txns? 02:58 < jonasschnelli> Yes. It is the main storage for transactions filtered out of the blockchain and mempool that are relevant to the wallet keys 02:58 < gnappuraz> also orphans? 02:58 < jonasschnelli> But they are checked for confirmation or conflicts during presentation... so you can't assume that all transactions in mapWallet are confirmed, etc. 02:58 < jonasschnelli> Orphans possible, yes. 02:59 < gnappuraz> ok thank you very much! 02:59 < jonasschnelli> Its just a set of transactions that have relevance to your keys/scripts in your wallet... 02:59 < jonasschnelli> If you want to render a balance, etc. you need to check / calculate if the transactions counts, etc. 03:00 < gnappuraz> if instead I need to fetch txs that are not related to my wallet? 03:00 < jonasschnelli> gnappuraz: depends... if you know the blockhash/heigh and the txid, you can use getrawtransaction 03:01 < jonasschnelli> If you only know the txid, you may need the -txindex=1 (enabled tx index) 03:01 < gnappuraz> right, thanks 03:02 < jonasschnelli> The wallet is a partial indexing service for the blockchain,... it "indexes" transactions relevant to the keys/scripts in the wallet 03:02 < jonasschnelli> (it not only indexes, it "extracts" the transactions) 03:02 < gnappuraz> i understand 03:31 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 03:31 < fanquake> wumpus: You commented on the wrong PR re squashing commits 03:41 < wumpus> fanquake: yep, resolved now 03:45 < fanquake> qt4 changes looking good 03:46 < fanquake> managed to engage the wrong @wumpus again 03:46 < promag> thanks jonas, will sort it out 03:57 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 03:58 < fanquake> provoostenator: As far as I can tell I've gotten ios cross builds working. Will PR some depends changes shortly. 03:58 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 04:14 < murrayn> was there not a time, not so long ago, where transaction age was a factor in prioritization? am i misremembering? 04:17 < wumpus> utxo age was 04:19 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/d6cf4bd7eb3b...45c00f841612 04:19 < bitcoin-git> bitcoin/master 3352da8 practicalswift: Add "export LC_ALL=C" to all shell scripts 04:19 < bitcoin-git> bitcoin/master 47776a9 practicalswift: Add linter: Make sure all shell scripts opt out of locale dependence using "export LC_ALL=C" 04:19 < bitcoin-git> bitcoin/master 45c00f8 Wladimir J. van der Laan: Merge #13454: Make sure LC_ALL=C is set in all shell scripts... 04:19 < bitcoin-git> [bitcoin] laanwj closed pull request #13454: Make sure LC_ALL=C is set in all shell scripts (master...avoid-locale-dependent-range-expressions) https://github.com/bitcoin/bitcoin/pull/13454 04:20 < wumpus> it used to be the sorting criterion for the free transaction area that some miners maintained in blocks 04:22 -!- vicenteH [~user@54.104.135.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 04:24 -!- gnappuraz [58823167@gateway/web/freenode/ip.88.130.49.103] has quit [Ping timeout: 260 seconds] 04:56 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 04:58 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 05:00 < promag> jonasschnelli: pushed a fix 05:01 < jonasschnelli> promag: will test asap 05:02 < promag> jonasschnelli: ty 05:03 < promag> jonasschnelli: now in the main window the wallet selector hidden when there is only 1 wallet loaded 05:03 < promag> *is hidden* 05:03 < rabidus> oispa liivit 05:03 < rabidus> oops sorry, wrong channel :( 05:04 < promag> jonasschnelli: we should create a model for wallets no? 05:04 < promag> btw, any objection to change QObject::connect to qt5 syntax (after qt4 is dropped)? 05:08 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 05:12 < fanquake> promag sounds good 05:15 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 05:18 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 05:21 < bitcoin-git> [bitcoin] practicalswift opened pull request #13494: Follow-up to #13454: Fix broken build by exporting LC_ALL=C (master...lc-all-lint-python-utf8-encoding) https://github.com/bitcoin/bitcoin/pull/13494 05:26 -!- ahp1992 [6759b260@gateway/web/freenode/ip.103.89.178.96] has joined #bitcoin-core-dev 05:26 < ahp1992> hi 05:27 < ahp1992> hello all 05:28 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 05:31 < promag> thank fanquake 05:34 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/45c00f841612...d67eff8002d7 05:34 < bitcoin-git> bitcoin/master 7b23e6e practicalswift: Follow-up to #13454: Fix broken build by exporting LC_ALL=C 05:34 < bitcoin-git> bitcoin/master d67eff8 MarcoFalke: Merge #13494: Follow-up to #13454: Fix broken build by exporting LC_ALL=C... 05:34 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #13494: Follow-up to #13454: Fix broken build by exporting LC_ALL=C (master...lc-all-lint-python-utf8-encoding) https://github.com/bitcoin/bitcoin/pull/13494 05:38 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 05:39 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 05:39 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 05:52 -!- jhfrontz [~Adium@c-73-23-68-28.hsd1.fl.comcast.net] has joined #bitcoin-core-dev 05:54 < ahp1992> let me know, how can i study to do own currency using bitcoin core. 05:58 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 06:00 -!- ahp1992 [6759b260@gateway/web/freenode/ip.103.89.178.96] has quit [Quit: Page closed] 06:03 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 265 seconds] 06:05 < fanquake> ahp1992 off-topic here. 06:05 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 06:08 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:19 -!- promag [~promag@62.28.242.62] has joined #bitcoin-core-dev 06:20 -!- ExtraCrispy [~ExtraCris@185.9.18.150] has quit [Ping timeout: 248 seconds] 06:21 -!- codyrutscher [~codyrutsc@cpe-76-92-221-26.kc.res.rr.com] has joined #bitcoin-core-dev 06:24 -!- berndj [~berndj@197.242.93.82] has quit [Quit: ZNC - http://znc.in] 06:28 -!- berndj [~berndj@azna.co.za] has joined #bitcoin-core-dev 06:31 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d67eff8002d7...2d071f5a7055 06:31 < bitcoin-git> bitcoin/master 55771b7 lucash.dev@gmail.com: Removed unused == operator from CMutableTransaction. 06:31 < bitcoin-git> bitcoin/master 2d071f5 Wladimir J. van der Laan: Merge #13443: Removed unused == operator from CMutableTransaction.... 06:32 < bitcoin-git> [bitcoin] laanwj closed pull request #13443: Removed unused == operator from CMutableTransaction. (master...remove-CMutableTransaction-equals) https://github.com/bitcoin/bitcoin/pull/13443 06:32 -!- ExtraCrispy [~ExtraCris@185.9.18.150] has joined #bitcoin-core-dev 06:33 -!- codyrutscher [~codyrutsc@cpe-76-92-221-26.kc.res.rr.com] has quit [Remote host closed the connection] 06:35 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2d071f5a7055...450055bdbdcb 06:35 < bitcoin-git> bitcoin/master 1e1eb63 Pieter Wuille: Improve coverage of SHA256 SelfTest code 06:35 < bitcoin-git> bitcoin/master 450055b Wladimir J. van der Laan: Merge #13438: Improve coverage of SHA256 SelfTest code... 06:35 < bitcoin-git> [bitcoin] laanwj closed pull request #13438: Improve coverage of SHA256 SelfTest code (master...201806_selftestsha) https://github.com/bitcoin/bitcoin/pull/13438 07:01 -!- Gnappuraz [58823167@gateway/web/cgi-irc/kiwiirc.com/ip.88.130.49.103] has joined #bitcoin-core-dev 07:06 -!- qu4ku [~qu4ku@2a01:110f:f73:1b00:e84d:f5a:5a0f:c38e] has joined #bitcoin-core-dev 07:12 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 07:17 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 07:27 -!- grafcaps [~haroldbr@107.147.175.194] has joined #bitcoin-core-dev 07:31 -!- jhfrontz [~Adium@c-73-23-68-28.hsd1.fl.comcast.net] has quit [Quit: Leaving.] 07:32 -!- grafcaps [~haroldbr@107.147.175.194] has quit [Ping timeout: 264 seconds] 07:39 -!- qu4ku [~qu4ku@2a01:110f:f73:1b00:e84d:f5a:5a0f:c38e] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 07:48 -!- jhfrontz [~Adium@c-73-23-68-28.hsd1.fl.comcast.net] has joined #bitcoin-core-dev 07:55 < jonasschnelli> sipa: would it be possible to have 3 different BCHs in Bech32X (three length of checksum)? 08:07 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has quit [Read error: Connection reset by peer] 08:08 -!- ctrlbreak [~ctrlbreak@142.162.42.47] has quit [Read error: Connection reset by peer] 08:08 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has joined #bitcoin-core-dev 08:08 -!- ctrlbreak [~ctrlbreak@142.162.42.47] has joined #bitcoin-core-dev 08:12 -!- jwhoisthat [~jodie@24.215.123.241] has quit [Ping timeout: 260 seconds] 08:13 -!- grafcaps [~haroldbr@104.137.194.255] has joined #bitcoin-core-dev 08:17 -!- miya [adefe84a@gateway/web/freenode/ip.173.239.232.74] has joined #bitcoin-core-dev 08:19 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/450055bdbdcb...ac3224c8eea9 08:19 < bitcoin-git> bitcoin/master fafa270 MarcoFalke: Make ReceivedBlockTransactions return void 08:19 < bitcoin-git> bitcoin/master ac3224c Wladimir J. van der Laan: Merge #13412: Make ReceivedBlockTransactions return void... 08:20 < bitcoin-git> [bitcoin] laanwj closed pull request #13412: Make ReceivedBlockTransactions return void (master...Mf1806-refactorReturnCodeValidation) https://github.com/bitcoin/bitcoin/pull/13412 08:21 < bitcoin-git> [bitcoin] wodry opened pull request #13496: Test: Harden lint-filenames.sh (master...harden-test-lint-filenames.sh) https://github.com/bitcoin/bitcoin/pull/13496 08:22 -!- miya [adefe84a@gateway/web/freenode/ip.173.239.232.74] has quit [Ping timeout: 260 seconds] 08:27 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-xefeopcocayosttg] has joined #bitcoin-core-dev 08:30 < sipa> jonasschnelli: sure, what lengths 08:31 < jonasschnelli> I think 7, 14, and 21 (correction) 08:32 < jonasschnelli> Or maybe 7, 14, 28 08:32 < jonasschnelli> 7 is ~5%, 14: ~10%, 28: ~20% 08:32 < jonasschnelli> (for 512bit) 08:34 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ac3224c8eea9...088240685456 08:34 < bitcoin-git> bitcoin/master faa18ca MarcoFalke: wallet: Erase wtxOrderd wtx pointer on removeprunedfunds 08:34 < bitcoin-git> bitcoin/master 0882406 Wladimir J. van der Laan: Merge #13437: wallet: Erase wtxOrderd wtx pointer on removeprunedfunds... 08:35 < bitcoin-git> [bitcoin] laanwj closed pull request #13437: wallet: Erase wtxOrderd wtx pointer on removeprunedfunds (master...Mf1806-walletPrunedFundsSegfault) https://github.com/bitcoin/bitcoin/pull/13437 08:39 -!- jwhoisthat [~jodie@24.215.123.241] has joined #bitcoin-core-dev 08:48 -!- promag [~promag@62.28.242.62] has quit [Remote host closed the connection] 08:59 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 09:00 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 09:02 -!- Ango_ [9bc60eca@gateway/web/freenode/ip.155.198.14.202] has joined #bitcoin-core-dev 09:07 -!- qu4ku [~qu4ku@2a01:110f:f73:1b00:4129:38dd:bbae:c78f] has joined #bitcoin-core-dev 09:08 -!- Krellan [~Krellan@2601:640:4000:9258:d84b:174d:f757:97ff] has quit [Ping timeout: 256 seconds] 09:13 -!- Ango_ [9bc60eca@gateway/web/freenode/ip.155.198.14.202] has quit [Quit: Page closed] 09:25 -!- Krellan [~Krellan@2601:640:4000:9258:d84b:174d:f757:97ff] has joined #bitcoin-core-dev 09:29 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 09:37 < bitcoin-git> [bitcoin] jnewbery opened pull request #13498: [wallet] Fixups from account API deprecation (master...account_deprecation_fixups) https://github.com/bitcoin/bitcoin/pull/13498 10:00 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Read error: Connection reset by peer] 10:07 -!- dendisuhubdy [~dendisuhu@keatext-srx100.isp.ip4b.net] has joined #bitcoin-core-dev 10:08 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 10:17 -!- harrymm [~harrymm@104.207.83.34] has quit [Ping timeout: 248 seconds] 10:21 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 10:29 -!- Krellan [~Krellan@2601:640:4000:9258:d84b:174d:f757:97ff] has quit [Remote host closed the connection] 10:30 -!- harrymm [~harrymm@104.207.83.34] has joined #bitcoin-core-dev 10:33 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds] 10:39 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 10:47 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-xefeopcocayosttg] has quit [Quit: Connection closed for inactivity] 10:57 -!- Gnappuraz [58823167@gateway/web/cgi-irc/kiwiirc.com/ip.88.130.49.103] has quit [Ping timeout: 264 seconds] 10:58 -!- Tester_ [4753986c@gateway/web/freenode/ip.71.83.152.108] has joined #bitcoin-core-dev 10:59 -!- Tester_ [4753986c@gateway/web/freenode/ip.71.83.152.108] has quit [Client Quit] 11:05 -!- drizztbsd [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 11:08 -!- drexl [~drexl@46.166.142.220] has joined #bitcoin-core-dev 11:08 -!- qu4ku [~qu4ku@2a01:110f:f73:1b00:4129:38dd:bbae:c78f] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 11:19 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Quit: Leaving] 12:01 -!- dendisuhubdy [~dendisuhu@keatext-srx100.isp.ip4b.net] has quit [Quit: Leaving...] 12:02 < sipa> jonasschnelli: around? 12:02 < jonasschnelli> sipa: yes (phonetyping) 12:04 < sipa> jonasschnelli: i have a few thoughts on a format for describing sets of scriptPubKey 12:04 < sipa> it's probably more complicated than what you're thinking about, but it's also pretty much what i'd want the entire wallet to migrate to 12:05 < sipa> i'll do a writeup/prototype over the next few days if you're interested 12:05 < jonasschnelli> sure. I think we could first use it for the scantxoutset 12:05 < sipa> yeah 12:06 < sipa> but it would also support things like multisig of multiple hd paths etc 12:06 < jonasschnelli> I think that's great... i guess it's related to your thoughts on PSBT 12:06 < sipa> yes 12:07 < sipa> and also for supporting hw wallets directly in core, and forward compatibility with schnorr etc 12:07 < jonasschnelli> Good. 12:08 < jonasschnelli> I wanted to comment about the encoding... 12:08 < jonasschnelli> Do you think pure binary serialization is unacceptable? 12:08 < sipa> for psbt? 12:08 < jonasschnelli> yes 12:08 < sipa> sure, that'd be the most common thing to do 12:08 < jonasschnelli> or where do you see advantages of base64 and z85, etc. 12:09 < sipa> but we can't put pure binary in an RPC response 12:09 < jonasschnelli> yes. sure. 12:09 < sipa> the common assumption i think is using hex 12:09 < jonasschnelli> yeah... I guess size won't matter to much on that layer 12:09 < sipa> but as i know how annoying raw transactions in hex can be to copy paste, i wanted to suggest something smaller 12:10 < sipa> and z85 looks pretty neat actually 12:10 < jonasschnelli> yes. I like it. 12:10 < sipa> it's 5 characters per 4 bytes 12:10 < jonasschnelli> but PSBT could also have it own file type... end user could email and dbl-click etc 12:10 < sipa> it probably should 12:11 < jonasschnelli> For RPC it will be a long chuck of text. both with hex or z85. 12:11 < sipa> yes 12:11 < sipa> but 1.6x shorter with z85 12:12 < jonasschnelli> Yes. But hassle on the client side... eventually opt-in? 12:12 < sipa> yeah, the burden of implementing z85 would be a deterrent i guess 12:12 < sipa> base64 is more common 12:13 < jonasschnelli> Yes. 12:13 < sipa> i don't care much; i just brought it up because it would be good to standardize on one 12:13 < jonasschnelli> I think z85 brings in some perfection and I generally think it's worth to explore 12:14 < sipa> cfields: what clang version will be used for 0.17 osx builds? 12:14 < jonasschnelli> and it not very complex so if one can deal with PSBT, z85 seem a trivial puzzlepiece 12:14 < jonasschnelli> *its 12:28 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 268 seconds] 12:30 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 12:30 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Ping timeout: 245 seconds] 12:30 -!- andytoshi [~apoelstra@96.53.77.134] has joined #bitcoin-core-dev 12:30 -!- andytoshi [~apoelstra@96.53.77.134] has quit [Changing host] 12:30 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #bitcoin-core-dev 12:38 -!- Randolf [~randolf@209.205.87.205.core.cipherkey.net] has joined #bitcoin-core-dev 12:39 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 12:59 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 13:03 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 13:03 < bitcoin-git> [bitcoin] JeremyRubin reopened pull request #12763: Add RPC Whitelist Feature from #12248 (master...whitelistrpc) https://github.com/bitcoin/bitcoin/pull/12763 13:06 -!- goatpig [56f7fd2b@gateway/web/freenode/ip.86.247.253.43] has quit [Ping timeout: 260 seconds] 13:08 < bitcoin-git> [bitcoin] jamesob closed pull request #12407: Ensure nStatus is set properly for all invalid blocks (master...jamesob/2018-02-mark-headers-invalid) https://github.com/bitcoin/bitcoin/pull/12407 13:15 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has quit [Remote host closed the connection] 13:15 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 13:19 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds] 13:23 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 13:35 -!- qu4ku [~qu4ku@2a01:110f:f73:1b00:4129:38dd:bbae:c78f] has joined #bitcoin-core-dev 13:40 -!- qu4ku [~qu4ku@2a01:110f:f73:1b00:4129:38dd:bbae:c78f] has quit [Ping timeout: 260 seconds] 13:45 -!- Randolf [~randolf@209.205.87.205.core.cipherkey.net] has quit [Ping timeout: 240 seconds] 14:19 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 14:30 -!- drexl_ [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev 14:32 -!- drexl [~drexl@46.166.142.220] has quit [Ping timeout: 256 seconds] 14:33 -!- drexl_ is now known as drexl 14:36 -!- jojeyh [~delphi@2602:306:b8b6:b970:30d8:d7c2:d20:7f35] has quit [Ping timeout: 245 seconds] 14:42 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 14:42 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 14:47 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 276 seconds] 14:53 -!- nkohen [~nkohen@2601:282:4101:9356:a5d3:9688:7639:ac6a] has joined #bitcoin-core-dev 14:54 -!- tryphe_ is now known as tryphe 14:55 < nkohen> Does anyone know what the intended functionality of combinerawtransaction is with bitcoind? 14:57 < sipa> nkohen: create a raw transaction for a 2-of-2 multisig, give it to both parties, each sign their part with a single signature; combinerawtransaction will turn it into a full transaction 15:01 < nkohen> Thanks! 15:05 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Quit: Leaving] 15:06 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 15:11 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 15:17 -!- grafcaps [~haroldbr@104.137.194.255] has quit [Quit: Lost terminal] 15:19 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 15:31 < bitcoin-git> [bitcoin] achow101 opened pull request #13500: [wallet] Decouple wallet version from client version (master...decouple-wallet-version) https://github.com/bitcoin/bitcoin/pull/13500 15:31 -!- nekotribal_ [~nekotriba@host-89-230-96-42.dynamic.mm.pl] has quit [Ping timeout: 245 seconds] 15:33 -!- rev_strangehope_ is now known as revstrangehope 15:35 < gmaxwell> sipa: is z85 as copy and paste friendly as base64? 15:38 -!- AaronvanW_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 15:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 15:41 < sipa> gmaxwell: probably not 15:42 < sipa> it's designed to not need escaping in typical programming languages when surrounded by quotation marks, though 15:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 15:43 < sipa> wait, what do you mean by copy-paste friendly? 15:46 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds] 15:48 -!- CubicEarths [~cubiceart@2600:100f:b010:c303:84c3:bc56:b3fe:128b] has joined #bitcoin-core-dev 15:48 < bitcoin-git> [bitcoin] promag opened pull request #13501: Remove race on shutdown between event loop exit and http reply (master...2018-06-loopexit) https://github.com/bitcoin/bitcoin/pull/13501 15:49 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-yzpbnfsoljhuwxqs] has joined #bitcoin-core-dev 15:51 < gmaxwell> sipa: mostly not having weird escape characters that will cause misbehavior when pasted. 15:52 < gmaxwell> it has / which is unfortunate for pasting into IRC. 15:52 < sipa> gmaxwell: it excludes \ ' " ; , 15:52 < sipa> and | 15:53 < sipa> if it would have excluded < / >, and included , ; | instead it would be clean html 15:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 15:53 < gmaxwell> I'm surprised it doesn't include ,;| as those are generally safe AFAIK. 15:54 < sipa> yup 15:54 < sipa> hmm, there are are 94 non-space printable ascii characters 15:55 < sipa> so 9 must be excluded 15:58 -!- nkohen [~nkohen@2601:282:4101:9356:a5d3:9688:7639:ac6a] has quit [Quit: Leaving] 15:59 < sipa> \ ' " ; , | ` ~ 15:59 < sipa> i must be missing one still 15:59 -!- Empact_ [~empact@192-195-80-238.PUBLIC.monkeybrains.net] has joined #bitcoin-core-dev 16:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 16:01 < gmaxwell> https://tools.ietf.org/html/rfc1924 has < and > but leaves out the slashes. 16:01 < gmaxwell> it gives rationale for each of the omitted characters. 16:01 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 16:02 -!- Empact [~empact@192-195-80-238.PUBLIC.monkeybrains.net] has quit [Ping timeout: 264 seconds] 16:02 < sipa> that's specific for ipv6 addresses, though 16:02 < sipa> for example the chose to exclude [ ] 16:03 < gmaxwell> Right. & is also an escape character that should be aboided. 16:03 < gmaxwell> (at that document argues, 16:04 < gmaxwell> <>"'`/\&. seem more obvious safe characters to exclude to me. 16:05 < sipa> or just base64... only 6.25% less efficient 16:05 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds] 16:05 < sipa> and far more common 16:06 < gmaxwell> it is sad that base64 has / but at least it's a common and well understood thing. 16:06 < sipa> the base85 trick of encoding 32-bit integers is neat, though 16:10 -!- CubicEarths [~cubiceart@2600:100f:b010:c303:84c3:bc56:b3fe:128b] has quit [Remote host closed the connection] 16:10 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Quit: drexl] 16:21 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 16:33 -!- vicenteH [~user@54.104.135.37.dynamic.jazztel.es] has quit [Ping timeout: 276 seconds] 16:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 16:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 16:46 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 16:50 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds] 16:55 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 16:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:04 -!- DrFeelGood [~DrFeelGoo@unaffiliated/olufunmilayo] has joined #bitcoin-core-dev 17:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 17:12 < sipa> gmaxwell: z85 also excludes _ 17:12 < sipa> that's the 9th one 17:13 < sipa> seems indeed a bit of a strange choice: "',;\_`|~ 17:16 -!- jtimon [~quassel@40.28.134.37.dynamic.jazztel.es] has quit [Ping timeout: 260 seconds] 17:26 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Quit: Leaving] 17:29 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 17:29 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Read error: Connection reset by peer] 17:30 -!- GoldenBear [~gb@104.223.31.252] has quit [Ping timeout: 240 seconds] 17:31 -!- GoldenBear [~gb@104.223.31.252] has joined #bitcoin-core-dev 17:32 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 17:38 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 17:39 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Quit: Leaving] 17:41 < gmaxwell> sipa: I wonder why _ ? 17:47 < sipa> no clue 17:53 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 17:53 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Read error: Connection reset by peer] 17:53 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 17:54 -!- tsl1125 [~tsl1125@12.161.174.234] has joined #bitcoin-core-dev 17:55 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 17:56 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Client Quit] 17:57 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has quit [Remote host closed the connection] 17:57 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 17:57 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Read error: Connection reset by peer] 17:59 -!- tsl1125 [~tsl1125@12.161.174.234] has quit [Ping timeout: 260 seconds] 17:59 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 18:09 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-yzpbnfsoljhuwxqs] has quit [Quit: Connection closed for inactivity] 18:32 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 18:37 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds] 19:09 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 19:10 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 19:10 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds] 19:26 -!- tsl1125 [~tsl1125@c-98-207-202-20.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 19:27 -!- eenoch_ is now known as eenoch 19:29 -!- tsl1125 [~tsl1125@c-98-207-202-20.hsd1.ca.comcast.net] has quit [Client Quit] 19:43 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 19:45 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 20:45 -!- harrymm [~harrymm@104.207.83.34] has quit [Read error: Connection reset by peer] 20:54 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 21:00 -!- BGL [thirty@75-149-171-58-Washington.hfc.comcastbusiness.net] has quit [Read error: Connection reset by peer] 21:00 -!- jimmysong__ [~Jimmy@72-48-253-51.dyn.grandenetworks.net] has joined #bitcoin-core-dev 21:02 -!- harrymm [~harrymm@207.244.78.74] has joined #bitcoin-core-dev 21:03 -!- jimmysong_ [~Jimmy@72-48-253-51.dyn.grandenetworks.net] has quit [Ping timeout: 240 seconds] 21:10 -!- harrymm [~harrymm@207.244.78.74] has quit [Ping timeout: 276 seconds] 21:27 -!- harrymm [~harrymm@207.189.25.147] has joined #bitcoin-core-dev 21:43 -!- Pinank [cb81d57e@gateway/web/freenode/ip.203.129.213.126] has joined #bitcoin-core-dev 21:44 -!- Pinank [cb81d57e@gateway/web/freenode/ip.203.129.213.126] has quit [Client Quit] 22:01 -!- goatpig [56f7fd2b@gateway/web/freenode/ip.86.247.253.43] has joined #bitcoin-core-dev 22:16 -!- nekotribal [~nekotriba@host-89-230-96-42.dynamic.mm.pl] has joined #bitcoin-core-dev 22:41 -!- BGL [sixty@75-149-171-58-Washington.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 22:51 -!- Krellan [~Krellan@2601:640:4000:9258:214e:c5e5:8920:cfd1] has joined #bitcoin-core-dev 23:08 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 23:09 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 23:21 -!- ExtraCrispy [~ExtraCris@185.9.18.150] has quit [Ping timeout: 240 seconds] 23:21 -!- thaumavorio [~thaumavor@thaumavor.io] has quit [Quit: ZNC 1.6.5 - http://znc.in] 23:23 -!- thaumavorio [~thaumavor@thaumavor.io] has joined #bitcoin-core-dev