--- Log opened Mon Jul 30 00:00:25 2018
00:10 -!- nodweber [~nodweber@unaffiliated/nodweber] has joined #bitcoin-core-dev
00:11 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit []
00:15 -!- nodweber [~nodweber@unaffiliated/nodweber] has quit [Ping timeout: 240 seconds]
00:20 -!- elkalamar [~elkalamar@unaffiliated/elkalamar] has quit [Remote host closed the connection]
00:21 -!- elkalamar [~elkalamar@unaffiliated/elkalamar] has joined #bitcoin-core-dev
00:22 -!- elkalamar [~elkalamar@unaffiliated/elkalamar] has quit [Max SendQ exceeded]
00:23 -!- elkalamar [~elkalamar@unaffiliated/elkalamar] has joined #bitcoin-core-dev
00:25 -!- go1111111 [go1111111@gateway/vpn/privateinternetaccess/go1111111] has quit [Ping timeout: 260 seconds]
00:28 -!- bitbee [~bitbee@138.197.209.248] has quit [Ping timeout: 240 seconds]
00:29 -!- bitbee [~bitbee@138.197.209.248] has joined #bitcoin-core-dev
00:30 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
00:31 -!- nodweber [~nodweber@unaffiliated/nodweber] has joined #bitcoin-core-dev
00:36 -!- nodweber [~nodweber@unaffiliated/nodweber] has quit [Ping timeout: 256 seconds]
00:36 -!- Sentineo [~Undefined@unaffiliated/sentineo] has quit [Quit: .]
00:37 -!- Sentineo [~Undefined@unaffiliated/sentineo] has joined #bitcoin-core-dev
00:40 -!- Guest43893 [~elkalamar@unaffiliated/elkalamar] has joined #bitcoin-core-dev
00:40 -!- go1111111 [~go1111111@199.231.240.191] has joined #bitcoin-core-dev
00:41 -!- elkalamar [~elkalamar@unaffiliated/elkalamar] has quit [Read error: Connection reset by peer]
00:44 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]
00:52 -!- nodweber [~nodweber@unaffiliated/nodweber] has joined #bitcoin-core-dev
00:57 -!- nodweber [~nodweber@unaffiliated/nodweber] has quit [Ping timeout: 256 seconds]
01:11 < Fuzzbawls> Question: (please ping me directly with answer) Given the recent acquisition of GitHub by Microsoft, is a relocation of the bitcoin source code to an alternative platform (like GitLab) being considered at all? If so, has anyone been actively working towards porting the `.travis.yml` file over to an alternative CI provider? I've had mixed results with such a port; some features can be duplicated/represented, and some cannot (like the $TRAVIS_COMMIT
01:11 < Fuzzbawls> _RANGE and the $TRAVIS_EVENT_TYPE environment variables, for example)
01:11 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
01:13 -!- nodweber [~nodweber@unaffiliated/nodweber] has joined #bitcoin-core-dev
01:16 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
01:17 -!- nodweber [~nodweber@unaffiliated/nodweber] has quit [Ping timeout: 240 seconds]
01:23 -!- Guest43893 [~elkalamar@unaffiliated/elkalamar] has quit [Quit: Leaving]
01:32 -!- nodweber [~nodweber@unaffiliated/nodweber] has joined #bitcoin-core-dev
01:34 -!- p3tr [~p3tr@srv.p3tr.cz] has joined #bitcoin-core-dev
01:34 < kallewoof> I have opened #13801 as an alternative, which replaces the dirty flag with a dest_filter=mixed/clean/dirty. More fine grained control, but slightly bigger diff. Will close one or the other based on feedback.
01:34 < gribble> https://github.com/bitcoin/bitcoin/issues/13801 | wallet: -avoidreuse with destination filters by kallewoof · Pull Request #13801 · bitcoin/bitcoin · GitHub
01:37 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev
01:57 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev
02:32 -!- face [~face@80.72.82.160.coresnet.bg] has quit [Ping timeout: 276 seconds]
02:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:44 -!- face [~face@80.72.82.160.coresnet.bg] has joined #bitcoin-core-dev
02:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
02:50 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:51 -!- face [~face@80.72.82.160.coresnet.bg] has quit [Ping timeout: 256 seconds]
03:04 -!- setpill [~setpill@unaffiliated/setpill] has quit [Ping timeout: 240 seconds]
03:06 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
03:18 -!- rex4539 [~rex4539@ppp-2-87-178-187.home.otenet.gr] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
03:19 -!- rex4539 [~rex4539@2a02:587:3516:600:9c8c:8c9f:5ed1:a13] has joined #bitcoin-core-dev
03:19 -!- rex4539 [~rex4539@2a02:587:3516:600:9c8c:8c9f:5ed1:a13] has quit [Client Quit]
03:35 -!- setpill [~setpill@unaffiliated/setpill] has quit [Ping timeout: 260 seconds]
03:37 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
03:48 -!- zivl [~zivl@2601:19a:837f:e4e1:9c2d:3da0:aae8:22b] has quit [Ping timeout: 276 seconds]
03:54 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]
03:55 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev
03:59 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Ping timeout: 256 seconds]
04:01 -!- face [~face@95.43.221.49] has joined #bitcoin-core-dev
04:03 -!- Empact [~empact@192-195-80-238.PUBLIC.monkeybrains.net] has quit [Ping timeout: 256 seconds]
04:04 -!- setpill [~setpill@unaffiliated/setpill] has quit [Ping timeout: 245 seconds]
04:05 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
04:06 -!- rex4539 [~rex4539@ppp-2-87-178-187.home.otenet.gr] has joined #bitcoin-core-dev
04:12 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
04:18 < wumpus> I really don't like all these PRs that just brush the code a bit
04:19 < wumpus> all the diff noise makes it harder to keep track of what is changing, and if it's not a clear win in, say, avoiding a class of bugs, I don't think it's generally worth it
04:19 < wumpus> it also creates endless motivations to create new PRs
04:19 < wumpus> please stop it
04:19 -!- setpill [~setpill@unaffiliated/setpill] has quit [Ping timeout: 256 seconds]
04:21 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
04:30 -!- zivl [~zivl@2601:19a:837f:e4e1:dd35:63db:b581:d413] has joined #bitcoin-core-dev
04:41 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection]
04:42 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev
04:44 -!- masonicboom [~masonicbo@2600:8802:5501:17c0:888a:5b2c:beb5:a112] has joined #bitcoin-core-dev
04:49 -!- masonicboom [~masonicbo@2600:8802:5501:17c0:888a:5b2c:beb5:a112] has quit [Ping timeout: 260 seconds]
04:53 -!- face [~face@95.43.221.49] has quit [Ping timeout: 240 seconds]
04:56 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds]
05:06 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev
05:07 < fanquake> wumpus I think I agree. 
05:07 < fanquake> There are quite a PRs with feedback/questions being left outstanding while new PRs are continually being opened (by the same author etc).
05:08 < wumpus> fanquake: thanks; I mean it's obviously not black and white, some changes make more sense than others, but sometimes it looks like they're just being dished out for the sake of making changes
05:10 < wumpus> say, #13770
05:10 < gribble> https://github.com/bitcoin/bitcoin/issues/13770 | Use explicit captures in lambda expressions by practicalswift · Pull Request #13770 · bitcoin/bitcoin · GitHub
05:10 < wumpus> I mean I'm sure there's arguments for it, but shouldn't that first be discussed, then maybe added tothe code style for *new code*
05:10 < wumpus> not just roll over the entire code, out of the blue, and change something that we weren't even aware about before
05:11 < fanquake> Yea. This one was sort of similar #13795.
05:11 < gribble> https://github.com/bitcoin/bitcoin/issues/13795 | build: Add missing [[noreturn]] to handleRunawayException(...). Enable -Wsuggest-attribute=noreturn if available. by practicalswift · Pull Request #13795 · bitcoin/bitcoin · GitHub
05:11 < wumpus> yes
05:11 < fanquake> No feature/build flag I hadn't really seen before. One build failures, and it gets closed with no more discussion?
05:11 < fanquake> *A feature..
05:12 < fanquake> Surely at least some followup or an explanation of what didn't work would be handy, even just for a future PR which might try doing the same thing.
05:17 < wumpus> the problem is that everyone is overworked, let's avoid creating unnecessary work out of the blue
05:17 < wumpus> that's basically my entire criticism
05:19 < fanquake> Yep, that's a fair call.
05:20 < fanquake> It's kinda felt like the repo has been "slowing down", over the past month or two
05:20 < fanquake> If not a longer period than that
05:20 < wumpus> I'm not sure that is true
05:24 < fanquake> Maybe it's just the fact that there is a lot of different work going on that makes it harder to gauge progress
05:26 < wumpus> sorry: https://github.com/bitcoin/bitcoin/pull/13770#issuecomment-408845832
05:28 < fanquake> The point of applying to new code is good. We've seen continual cases of follow up changes/fixing things up "just after" they were merged.
05:29 < wumpus> right!
05:39 -!- masonicboom [~masonicbo@2600:8802:5501:17c0:5125:a5f3:671c:72e4] has joined #bitcoin-core-dev
05:43 -!- masonicboom [~masonicbo@2600:8802:5501:17c0:5125:a5f3:671c:72e4] has quit [Ping timeout: 255 seconds]
05:47 < kallewoof> I agree gaining consensus for code style update (via PR and (concept) ACK's w/ merge) should be required before making changes unless the change is an obvious improvement that everyone needs. However, I also believe that we should automate EVERYTHING that can be automated, even if it is only slightly beneficial.
05:48 < kallewoof> Automating PR review seems like an obvious win.
05:54 < wumpus> at least I'm not arguing against automated PR review
05:55 < wumpus> I think checking for things that actually makes sense is good
05:57 < luke-jr> kallewoof: PR review cannot be automated..
05:58 < wumpus> but not adding vague concerns all the time that haven't actually resulted in bugs nor are likely to result in such, we're trying to build functional code here, the concern is not perfect style according to some person's preferences
05:58 < fanquake> kallewoof I agree re automation. At least in the case of the Draht bot, as it has started improving/gotten a bit less noisy, I've begun to enjoy the merge conflict notifications, as well as nearly automated? gitian builds.
05:59 < fanquake> However posting a comment to say that 15 PRs all conflict with each other is probably getting towards the less valuable end, heh.
05:59 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
06:03 < wumpus> luke-jr: I think he means the linters, so the basic trivial stuff
06:03 < wumpus> if only real code review could be automated!
06:03 < kallewoof> wumpus: I admit I haven't seen the PR in detail, I was mostly talking about past experience :)
06:04 < kallewoof> and yes, I am talking about the review that you can automate, not all review.
06:05 < wumpus> kallewoof: I think MarcoFalke's approach is better than practicalswifts in this regard; DrahtBot has a PR that updates various known things before the 0.17 branch, practicalswift on the other hand creates PR after PR after PR changing things all over the code base
06:06 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 248 seconds]
06:07 < wumpus> I think agreeing to make some such changes (certainly if they're alrady part of the coding guidelines) before a release is okay, at least it's a rare thing
06:08 < fanquake> Something like #13802 might be just that sort of thing, but I've added there that it should really be added the the build system if possible. Otherwise could lead to endless followup.
06:08 < gribble> https://github.com/bitcoin/bitcoin/issues/13802 | Dont use zero as null pointer constant by practicalswift · Pull Request #13802 · bitcoin/bitcoin · GitHub
06:09 < fanquake> i.e sweeping change just before a release
06:09 < wumpus> my concern is with sweeping changes that come out of the blue
06:09 < wumpus> suddenly there's this completely new thing you should care about and we should update the entire cod efor!
06:10 < wumpus> please, let's work on issues that affect users
06:13 -!- face [~face@80.72.82.160.coresnet.bg] has joined #bitcoin-core-dev
06:19 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
06:27 < kallewoof> Ideally, if a PR will plug a potential issue later down the road, it should be encouraged, but it can be hard to judge. I think a way to solve this is to put the weight on the PR creator -- find compelling and easy to follow reasons for why the PR is necessary, or we all agree to concept NACK saying we don't see the reason. Maybe even add that to the contributor guidelines.
06:28 < wumpus> yes, if there is a good rationale, we have a way to introduce that (through the coding guidelines), I agree
06:29 < wumpus> that's exactly what I said in my post, too
06:29 < kallewoof> *nod*
06:33 -!- masonicboom [~masonicbo@2600:8802:5501:17c0:b45d:ba01:8acc:a92b] has joined #bitcoin-core-dev
06:33 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has joined #bitcoin-core-dev
06:37 -!- masonicboom [~masonicbo@2600:8802:5501:17c0:b45d:ba01:8acc:a92b] has quit [Ping timeout: 245 seconds]
06:39 -!- satwo [~textual@2602:306:378a:6fb0:9d96:a15a:7769:a52b] has joined #bitcoin-core-dev
06:40 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Ping timeout: 256 seconds]
06:56 -!- grubles [~grubles@unaffiliated/grubles] has quit [Quit: Leaving]
06:58 < kallewoof> wumpus: Does #13803 convey the right message?
06:58 < gribble> https://github.com/bitcoin/bitcoin/issues/13803 | doc: add note to developer docs about warranted PRs by kallewoof · Pull Request #13803 · bitcoin/bitcoin · GitHub
07:02 < wumpus> kallewoof: I think so! wouldn't a better place be CONTRIBUTING.md though?
07:03 < kallewoof> I was unsure about that. I have no strong feelings about it, personally, so can move it.
07:04 < kallewoof> Actually, it fits better in contributing, I think. Moving it.
07:05 < wumpus> that's where people automatically get linked afaik
07:07 < kallewoof> Moved
07:17 -!- grubles [~grubles@unaffiliated/grubles] has joined #bitcoin-core-dev
07:17 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev
07:19 < fanquake> ken2812221 Are you following any of the upstream Windows/leveldb work? I've seen a few different PRs that also seem to be working on the unicode problems that you are.
07:21 < fanquake> i.e https://github.com/google/leveldb/pull/526
07:21 < fanquake> However progress on them seems to be stagnating.
07:22 < ken2812221> fanquake: No, I haven't seen those yet.
07:23 < ken2812221> google might not want to port leveldb to Windows.
07:25 < ken2812221> I just do the minimum changes base on current env_win.cc
07:26 < fanquake> np. Just mentioned as it was worth a look incase you could cherry-pick anything useful.
07:28 < ken2812221> Thanks, will take a look.
07:29 < fanquake> wumpus You can probably merge 13803 straight in. 13554 also ready.
07:30 < wumpus> thanks!
07:32 -!- harding [quassel@2600:3c03::f03c:91ff:fe7b:78d1] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.]
07:33 -!- masonicboom [~masonicbo@2600:8802:5501:17c0:a90c:cc5e:a29f:5565] has joined #bitcoin-core-dev
07:33 -!- harding [quassel@2600:3c03::f03c:91ff:fe7b:78d1] has joined #bitcoin-core-dev
07:34 -!- promag [~promag@83.223.250.178] has joined #bitcoin-core-dev
07:35 < fanquake> Also 13797, backporting to 0.16
07:37 -!- masonicboom [~masonicbo@2600:8802:5501:17c0:a90c:cc5e:a29f:5565] has quit [Ping timeout: 245 seconds]
07:42 -!- promag [~promag@83.223.250.178] has quit [Remote host closed the connection]
07:44 < kallewoof> wumpus: mind if I fix commit message s/developer/contributor/ on 13803? don't wanna touch if you intend to merge it now.
07:47 < kallewoof> Actually promag nit is valid so gonna fix that too. Apologies.
07:47 < wumpus> kallewoof: for sure!
07:48 < wumpus> kallewoof: this should be open for a while for discussion probably nayway
07:48 < kallewoof> Yes, good point.
07:50 < kallewoof> Although practicalswift did already ACK it. Not sure if anyone else is affected (apart from myself, of course.. I mean, this obviously means #12879 is not gonna see the light of day, ever).
07:50 < gribble> https://github.com/bitcoin/bitcoin/issues/12879 | [scripted-diff] No extern function declarations by kallewoof · Pull Request #12879 · bitcoin/bitcoin · GitHub
07:50 < satwo> Is there a more detailed guide (than what is currently found in CONTRIBUTING.md) that explains, step-by-step, the proper testing of a PR? I would assume at minimum: compile and run the patch set, make sure the intended behavior is present, make sure no unintended behaviors have been introduced (is there a systematic way to approach this?), and run (all, or just relevant?) unit tests. 
07:52 < kallewoof> satwo: Not to my knowledge. In fact, I wrote an entire framework (https://www.npmjs.com/package/bctest and https://www.npmjs.com/package/bitcointest) before I finally found out there was a pythong testing framework already :P
07:55 < fanquake> "compile and run the patch set" Quite often this needs to be done across multiple OS's, as occasionally a something will break a *BSD build, or Windows etc
07:55 < fanquake> Running all the tests suites (--extended), running any linters etc.
07:56 < fanquake> However what your testing/checking is always dependant on the actual change.
07:57 < fanquake> There was at one point a bitcoin test cases/writeups repo, but I don't think it ever got much traction
07:58 < wumpus> it depends on the change; if it is aspecific, say a refactoring, then running the test framework (both unit and functional) should be enough
07:59 < wumpus> if it is specific, for example you're adding an API call, then you need to add a functional test for that call
07:59 < wumpus> for more complex internal functionality you'd want to add unit tests
08:01 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
08:01 < satwo> kallewoof: ha! That must have been quite the learning experience, if nothing else :)
08:02 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
08:02 < satwo> fanquake: That was something I was wondering about: how does one know when a change should be tested on different platforms, and when testing on any single platform is sufficient? 
08:03 < kallewoof> Yeah I enjoyed it. :) LImited use but still
08:03 -!- michaelsdunn1 [~mdunn@38.126.31.226] has joined #bitcoin-core-dev
08:03 < gmaxwell> ISTM that the project has sped up in the last year in terms of changes, but I don't think that the number of interesting new features, performance improvements, or bug fixes have increased at the same rate which sometimes just makes it seem like more work to keep up but less interesting. 
08:03 < wumpus> satwo: in any case if you are working on something, just ask, and people here can probably answer what you need
08:04 < gmaxwell> satwo: In terms of "systematic way" -- the systematic part should be largely implemented by the automated tests.
08:04 < gmaxwell> So for testing a PR: run the automated tests, test your own use cases, and test whatever you can come up with specific to the PR that isn't automated.
08:06 < satwo> wumpus: thanks! I definitely need to familiarize myself with functional vs unit tests in bitcoin. I'll continue to come here to ask my noobish questions. 
08:06 < jonasschnelli> MarcoFalke: there are two merge commits in #13804
08:06 < gribble> https://github.com/bitcoin/bitcoin/issues/13804 | Stacked Transaction Pool Layer by MarcoFalke · Pull Request #13804 · bitcoin/bitcoin · GitHubAsset 1Asset 1
08:07 < kallewoof> satwo: functional = start up one or several nodes and try stuff out by calling them via RPC. unit = actually call C++ methods directly and check if they behave right
08:07 < fanquake> satwo: Here's one example of a PR that "silently" broke builds on FreeBSD 10 9598.
08:10 < fanquake> There gui can also get somewhat limited testing, especially on Windows. Although, that stems more from so few of the developers, at least working on Core, using Windows.
08:13 < fanquake> However that might seem to be changing if you take into account recent PRs.
08:16 -!- ExtraCrispy [~ExtraCris@185.9.18.150] has joined #bitcoin-core-dev
08:17 < wumpus> breaking FreeBSD is a good way to make me angry :)
08:17 < satwo> gmaxwell: thanks for the clarification! Very helpful.
08:18 < wumpus> but that doesn't happen that often, usually with build system changes, those I test on *BSD first before merging
08:19 < satwo> kallewoof: Thanks for the clarification! Pretty straightforward yet I'd never considered the difference until today.
08:22 < satwo> fanquake: thanks for the PR reference, very interesting. I do have Windows running on Parallels so I could certainly help out on that front.
08:25 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit []
08:29 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer]
08:29 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
08:30 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev
08:30 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
09:01 -!- booyah [~bb@193.25.1.157] has quit [Ping timeout: 260 seconds]
09:02 -!- marcinja [~marcin@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
09:04 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev
09:06 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev
09:22 -!- masonicboom [~masonicbo@ip68-108-243-131.sb.sd.cox.net] has joined #bitcoin-core-dev
09:26 -!- masonicboom [~masonicbo@ip68-108-243-131.sb.sd.cox.net] has quit [Ping timeout: 244 seconds]
09:29 -!- contrapumpkin [~copumpkin@haskell/developer/copumpkin] has joined #bitcoin-core-dev
09:30 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
09:31 -!- booyah [~bb@193.25.1.157] has quit [Ping timeout: 260 seconds]
09:32 -!- copumpkin [~copumpkin@haskell/developer/copumpkin] has quit [Ping timeout: 240 seconds]
09:36 < jamesob> did we recently bump the required version of protobuf?
09:38 < wumpus> jamesob: I don't think so, and I'd be really surprised
09:38 < wumpus> the only use of protobuf is the payment request code in bitcoin-qt and that hasn't seen serious changes since... forever
09:39 < jamesob> I just started getting some related-looking compile failures: https://gist.github.com/jamesob/70fda4b96499f7b86c938370ffe92b49
09:40 -!- Dizzle [~dizzle@108.171.182.16] has quit [Quit: Leaving...]
09:41 < wumpus> that looks like you need to make clean (or even clear your tree) and rebuild -- this is most likely caused by the protobuf version on your system changing through package managers or such
09:41 < jamesob> thanks, I'll give that a shot
09:41 < wumpus> (pb.h isn't part of the repository but generated)
09:43 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
09:52 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Read error: Connection reset by peer]
09:54 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev
09:56 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
10:00 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
10:18 -!- masonicboom [~masonicbo@2600:8802:5501:17c0:95ef:5ec0:dbab:8b71] has joined #bitcoin-core-dev
10:44 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Quit: Leaving]
10:48 -!- masonicboom [~masonicbo@2600:8802:5501:17c0:95ef:5ec0:dbab:8b71] has quit [Ping timeout: 260 seconds]
10:59 -!- masonicboom [~masonicbo@2600:8802:5501:17c0:95ef:5ec0:dbab:8b71] has joined #bitcoin-core-dev
11:01 -!- nodweber [~nodweber@unaffiliated/nodweber] has quit [Ping timeout: 276 seconds]
11:17 -!- nodweber [~nodweber@unaffiliated/nodweber] has joined #bitcoin-core-dev
11:18 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has quit [Quit: Leaving.]
11:22 -!- nodweber [~nodweber@unaffiliated/nodweber] has quit [Ping timeout: 260 seconds]
11:23 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has joined #bitcoin-core-dev
11:24 -!- rabidus [~rabidus@85-23-137-40.bb.dnainternet.fi] has quit [Ping timeout: 244 seconds]
11:26 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
11:29 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]
11:33 -!- quitobro [c436290b@gateway/web/freenode/ip.196.54.41.11] has joined #bitcoin-core-dev
11:33 < quitobro> hey guys i have a question about best practice for managing watch-only addresses
11:34 < quitobro> specifically, which RPC commands are best to use in order to *get transactions tied to an input address*
11:35 < quitobro> i was expecting `getreceivedbyaddress` to take an address param and return a list of UTXOs or tx's
11:35 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has quit [Quit: Leaving.]
11:35 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has joined #bitcoin-core-dev
11:36 < quitobro> furthermore, when i was exploring the `*byaccount` RPC commands it seems like many of them are deprecated - is the 'account' concept being deprecated or just select commands like `getreceivedbyaccount`?
11:38 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has quit [Client Quit]
11:38 < sipa> quitobro: the accounts concept is deprecated
11:38 -!- nodweber [~nodweber@unaffiliated/nodweber] has joined #bitcoin-core-dev
11:39 < sipa> quitobro: if you import a watch only address, the usual RPCs like getreceivedbyaddress will work
11:39 < sipa> but you first need to import them
11:39 < sipa> quitobro: labels will replace accounts; so you'll still be able to give a label to an address and see transactions to a label etc
11:40 < sipa> but there won't be a "label balance" like there is an account balance
11:40 < sipa> they're just a way to tag addresses for receives
11:40 < quitobro> sipa: ok thanks. yea, `getreceivedbyaddress` is nice but i want something which returns the transaction history at address, not just the balance...
11:41 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has joined #bitcoin-core-dev
11:41 < sipa> quitobro: listreceivedbyaddress
11:41 < quitobro> i suppose i can go thru `listtransactions` and filter by address?
11:43 -!- nodweber [~nodweber@unaffiliated/nodweber] has quit [Ping timeout: 265 seconds]
11:43 < quitobro> ah, ok, and then filter thru the list of tx summaries grabbing only the ones i care about, or something like that. thank you sipa!
11:43 < quitobro> this is what i needed :)
11:44 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has quit [Client Quit]
11:46 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has joined #bitcoin-core-dev
11:55 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
11:56 -!- quitobro [c436290b@gateway/web/freenode/ip.196.54.41.11] has quit [Quit: Page closed]
11:59 -!- nodweber [~nodweber@unaffiliated/nodweber] has joined #bitcoin-core-dev
12:00 < jamesob> wumpus: turns out I had a mismatch between my protoc version (newer) and libprotobuf-dev
12:01 < wumpus> jamesob: whoops
12:03 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Read error: Connection reset by peer]
12:04 -!- nodweber [~nodweber@unaffiliated/nodweber] has quit [Ping timeout: 255 seconds]
12:05 -!- quitobro [d0b9b842@gateway/web/freenode/ip.208.185.184.66] has joined #bitcoin-core-dev
12:06 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]
12:06 < quitobro> sipa: one more question - when calling `importaddress` with `rescan=true`, will that operation be blocking other reads/writes to the local blockchain database?
12:07 < sipa> quitobro: it will block pretty much everything
12:08 -!- michaelsdunn1 [~mdunn@38.126.31.226] has quit [Remote host closed the connection]
12:10 < quitobro> sipa: okay sounds like we may need to schedule our rescans very carefully then
12:10 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
12:11 < sipa> quitobro: you should import addresses before they're being used :)
12:11 < quitobro> how long do rescans take usually? relative to say initial sync time?
12:13 < sipa> a significant fraction
12:14 < gmaxwell> quitobro: Can you talk about your usecase? why are you performing rescans at all?
12:14 < quitobro> hm okay... for our application we don't manage users' keys, but want to provide essentially a blockchain explorer... is there a way to get tx & balance details for an arbitrary valid address, without importing as watch-only?
12:15 < quitobro> we looked at using a 3rd party service but we don't want those blockchain queries to potentially reveal customers' addresses
12:15 < quitobro> and would prefer to run our own nodes and fulfill those requests
12:15 < quitobro> we sell a cryptocurrency trading platform as a software service
12:16 < quitobro> so there is a large blockchain explorer-esque component as part of e.g. trade settlement
12:16 < gmaxwell> Importing as watching before issing the addresses is the canonical, supported way.  Your next best alternative is to write your own indexer. The issue is that the resource costs of indexing all transactions in history will continue to rapidly grow... so most people who setup that way will eventually need to switch to using a centeralized service due to the resource costs.
12:17 < gmaxwell> There hasn't been much interest in maintaining that kind of index in bitcoind because of the above.
12:18 < quitobro> gmaxwell: in other words everyone's index needs/requirements vary so there isn't a good way to implement arbitrary indexes in bitcoind?
12:18 < quitobro> or rather indexes for arbitrary watch-only addresses
12:20 -!- nodweber [~nodweber@unaffiliated/nodweber] has joined #bitcoin-core-dev
12:20 < gmaxwell> We may have a feature in 0.18 that makes rescan much faster (e.g. a minute maybe, instead of hours), but likely still too slow for your application.
12:22 < quitobro> gmaxwell: cool what is that feature? sounds quite nite
12:22 < gmaxwell> quitobro: diversity of needs is one issue, but scalablity is another.  At least in the community people aren't generally excited on working on technology that will only be usable on large dedicated servers, if not now, then in a couple years.  If someone showed up and wanted to add optional indexing, and was willing to jump through the right hoops to isolate it, I think the contribution would be
12:22 < gmaxwell>  welcome.
12:22 < quitobro> nice*
12:23 < gmaxwell> quitobro: use of BIP-158 filters locally. Basically for every block we'd save a small fingerprint of the addresses involved in the block.
12:23 < gmaxwell> Then scanning only has to check those, and not the whole blockchain.
12:23 < gmaxwell> it's still a linear scan, rather than an index, but of a lot less data.
12:24 < gmaxwell> There is a pull req implementing the filters, but not the wallet rescan using it, yet.
12:24 -!- nodweber [~nodweber@unaffiliated/nodweber] has quit [Ping timeout: 240 seconds]
12:25 < gmaxwell> It's too late to make 0.17 right now, but I think it's somewhat likely for 0.18. 
12:25 < quitobro> gmaxwell: i see, ok maybe if we continue down this path (as opposed to running a super beefy, indexed dedicated server) we will be able to make a contribution
12:25 < gmaxwell> If nothing else, being willing to show up and test it would help.
12:26 < quitobro> definitely; should we just keep our eyes on bitcoin-dev-mailing-list?
12:26 < gmaxwell> In general, when there are features that are mostly interesting for commerical players, we'd still welcome them, but industry needs to step up and do more of that work... there is just too much to do. :)
12:26 < gmaxwell> quitobro: you might want to also keep an eye on https://github.com/bitcoin/bitcoin/pull/12254
12:27 < gmaxwell> After it's merged presumably there will be more PRs to actually make use of it.
12:29 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]
12:37 < midnightmagic> I actually thought working on the weird higher-end functionality was the best thing I used to do professionally. (as limited as that was)
12:38 -!- nodweber [~nodweber@unaffiliated/nodweber] has joined #bitcoin-core-dev
12:39 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
12:42 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]
12:45 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 250 seconds]
12:45 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 250 seconds]
12:47 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev
12:48 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev
12:52 -!- quitobro [d0b9b842@gateway/web/freenode/ip.208.185.184.66] has quit [Ping timeout: 252 seconds]
12:53 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev
12:59 < MarcoFalke> Just a PSA for member of the GitHub-labels group:
12:59 < MarcoFalke> You can tag with "Needs gitian build" and DrahtBot will create a built in the next day or so
13:00 -!- nodweber [~nodweber@unaffiliated/nodweber] has quit [Ping timeout: 265 seconds]
13:05 -!- elkalamar [~elkalamar@unaffiliated/elkalamar] has joined #bitcoin-core-dev
13:06 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
13:17 -!- nodweber [~nodweber@unaffiliated/nodweber] has joined #bitcoin-core-dev
13:24 -!- sturles [~sturles@unaffiliated/sturles] has quit [Ping timeout: 244 seconds]
13:33 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]
13:45 -!- sturles [~sturles@unaffiliated/sturles] has joined #bitcoin-core-dev
13:47 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection]
13:48 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev
14:12 -!- booyah [~bb@193.25.1.157] has quit [Ping timeout: 256 seconds]
14:21 -!- nodweber [~nodweber@unaffiliated/nodweber] has quit [Quit: WeeChat 2.1]
14:32 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 264 seconds]
14:59 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection]
15:00 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev
15:00 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
15:01 < promag> provoostenator: let me know if you can try #13791 in windows? ty!
15:01 < gribble> https://github.com/bitcoin/bitcoin/issues/13791 | gui: Reject dialogs if key escape is pressed by promag · Pull Request #13791 · bitcoin/bitcoin · GitHubAsset 1Asset 1
15:04 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]
15:19 -!- michaelsdunn1 [~michaelsd@208.59.170.5] has joined #bitcoin-core-dev
15:19 -!- michaelsdunn1 [~michaelsd@208.59.170.5] has quit [Remote host closed the connection]
15:20 -!- michaelsdunn1 [~michaelsd@208.59.170.5] has joined #bitcoin-core-dev
15:25 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood]
15:25 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
15:28 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
15:29 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
15:29 -!- masonicboom [~masonicbo@2600:8802:5501:17c0:95ef:5ec0:dbab:8b71] has quit [Ping timeout: 240 seconds]
15:35 -!- michaelsdunn1 [~michaelsd@208.59.170.5] has quit [Remote host closed the connection]
15:39 -!- masonicboom [~masonicbo@2600:8802:5501:17c0:95ef:5ec0:dbab:8b71] has joined #bitcoin-core-dev
16:04 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
16:14 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 248 seconds]
16:22 < ken2812221> promag: It works fine on Windows.
16:22 < promag> ty ken2812221
16:22 < promag> just saw your reply there
16:22 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
16:23 < promag> ken2812221: if you change value in the options dialog, press esc, and reopen, is the value reset?
16:24 < ken2812221> promag: Yes, it does not store the setting if I press esc.
16:25 -!- masonicboom [~masonicbo@2600:8802:5501:17c0:95ef:5ec0:dbab:8b71] has quit [Remote host closed the connection]
16:26 -!- vicenteH [~user@54.104.135.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
16:26 < promag> ken2812221: ok cool
16:28 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection]
16:40 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
16:49 -!- michaelsdunn1 [~michaelsd@208.59.170.5] has joined #bitcoin-core-dev
16:59 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]
17:02 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 264 seconds]
17:06 -!- masonicboom [~masonicbo@2600:8802:5501:17c0:50a6:8002:a706:f5f4] has joined #bitcoin-core-dev
17:12 -!- masonicboom [~masonicbo@2600:8802:5501:17c0:50a6:8002:a706:f5f4] has quit [Remote host closed the connection]
17:14 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
17:16 -!- wraithm [~wraithm@unaffiliated/wraithm] has quit [Quit: ZNC 1.6.3+deb1+xenial0 - http://znc.in]
17:17 -!- wraithm [~wraithm@unaffiliated/wraithm] has joined #bitcoin-core-dev
17:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
17:20 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
17:28 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
17:30 -!- IGHOR [~quassel@93.178.216.72] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.]
17:31 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev
17:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 264 seconds]
17:34 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds]
17:50 -!- Orion3k [~Orion3k@24-176-200-142.static.mtpk.ca.charter.com] has quit [Quit: Leaving]
18:01 -!- masonicboom [~masonicbo@2600:8802:5501:17c0:b5ca:a3b9:c158:f2e8] has joined #bitcoin-core-dev
18:06 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 260 seconds]
18:06 -!- masonicboom [~masonicbo@2600:8802:5501:17c0:b5ca:a3b9:c158:f2e8] has quit [Ping timeout: 265 seconds]
18:25 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
18:27 -!- Orion3k [~Orion3k@66.133.74.90] has joined #bitcoin-core-dev
18:29 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
18:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 248 seconds]
19:01 -!- masonicboom [~masonicbo@2600:8802:5501:17c0:24d6:639f:c127:a750] has joined #bitcoin-core-dev
19:06 -!- masonicboom [~masonicbo@2600:8802:5501:17c0:24d6:639f:c127:a750] has quit [Ping timeout: 260 seconds]
19:28 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection]
19:28 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
19:42 -!- michaelsdunn1 [~michaelsd@208.59.170.5] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
20:26 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
20:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
20:31 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 256 seconds]
20:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds]
20:37 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
20:51 -!- masonicboom [~masonicbo@2600:8802:5501:17c0:342d:28b0:c99e:c517] has joined #bitcoin-core-dev
20:55 -!- masonicboom [~masonicbo@2600:8802:5501:17c0:342d:28b0:c99e:c517] has quit [Ping timeout: 265 seconds]
21:04 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
21:05 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
21:08 -!- MarcoFalke [~none@198.12.116.246] has quit [Ping timeout: 248 seconds]
21:08 -!- Orion3k [~Orion3k@66.133.74.90] has quit [Ping timeout: 248 seconds]
21:08 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 248 seconds]
21:12 -!- BCBot [~BCBot@46.101.246.115] has quit [Ping timeout: 248 seconds]
21:12 -!- MarcoFalke [~none@198.12.116.246] has joined #bitcoin-core-dev
21:13 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
21:17 -!- masonicboom [~masonicbo@2600:8802:5501:17c0:82:b84:d414:bb83] has joined #bitcoin-core-dev
21:21 -!- Orion3k [~Orion3k@66.133.74.90] has joined #bitcoin-core-dev
21:23 -!- Squidicuz [~squid@pool-173-48-82-37.bstnma.fios.verizon.net] has quit [Ping timeout: 240 seconds]
21:25 -!- dcousens [~dcousens@110.140.174.10] has quit [Quit: The Lounge - https://thelounge.github.io]
21:26 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
21:31 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 256 seconds]
21:39 -!- kerfle [~kerfle@208.124.108.147] has quit [Ping timeout: 248 seconds]
21:52 -!- ryanofsky_ [russ@jumpy.yanofsky.org] has quit [Quit: ZNC 1.7.0 - https://znc.in]
21:52 -!- ryanofsky [russ@jumpy.yanofsky.org] has joined #bitcoin-core-dev
22:04 -!- dcousens [~dcousens@110.140.174.10] has joined #bitcoin-core-dev
22:08 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
22:12 -!- mode/#bitcoin-core-dev [+o sipa] by ChanServ
22:12 -!- mode/#bitcoin-core-dev [-n] by sipa
22:12 -!- mode/#bitcoin-core-dev [-o sipa] by sipa
22:12 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 244 seconds]
22:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
22:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
22:43 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev
22:50 < bitcoin-git> [bitcoin] practicalswift opened pull request #13815: build: Add linter to make sure the return value of Parse[...](...) is checked (master...check-return-values-from-parse) https://github.com/bitcoin/bitcoin/pull/13815
23:13 < kallewoof> So confused. Why would the `allowhighfees` argument refuse to become an integer despite client.cpp listing it as 'to be converted'? self.nodes[2].sendrawtransaction(hexstring=rawTxSigned['hex'], allowhighfees=Decimal("0.00007000"))
23:14 < kallewoof> Actually, wrong line, it was this one: assert_raises_rpc_error(-26, "absurdly-high-fee", self.nodes[2].sendrawtransaction, rawTxSigned['hex'], Decimal("0.00001000"))
23:18 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 268 seconds]
23:26 < luke-jr> kallewoof: client.cpp is entirely irrelevant for this
23:26 < kallewoof> luke-jr: It determines if argument should be converted or kept as a string, right?
23:27 < luke-jr> kallewoof: for bitcoin-cli, which isn't tested by assert_raises_rpc_error
23:27  * kallewoof blinks
23:28 < kallewoof> So how does it know whether to format arguments or  keep as strings?
23:29 < sipa> kallewoof: it doesn't
23:29 < sipa> JSON-RPC on the wire is JSON
23:29 < sipa> not strings
23:29 < sipa> if you use Decinal in python, it is sent as a JSON number
23:30 < sipa> bitcoin-cli needs to know what arguments to treat as string literals and which ones not
23:30 < kallewoof> I'm confused. THis works: self.nodes[2].sendrawtransaction(hexstring=rawTxSigned['hex'], allowhighfees=0.00007000)
23:30 < kallewoof> And this doesn't: self.nodes[2].sendrawtransaction(hexstring=rawTxSigned['hex'], allowhighfees=Decimal("0.00007000"))
23:31 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
23:31 < sipa> oh, i must be wrong then
23:32 < kallewoof> Unless Decimal() gives something that univalue does not consider to be isNum().. but if I write() it, it gives me [ "0.00007000" ] (with quotes)
23:32 < sipa> this has nothing to do with univalue
23:32 < kallewoof> Wait, it does, because the error is when ! isBool() and ! isNum()
23:32 < sipa> JSON has 4 data types; numbers, strings, arrays, objects
23:33 < sipa> the *python* code is converting what you pass to the sendrawtransaction function into those 4 types
23:33 < sipa> isNum failing on the bitcoind side just means you're not sending a JSON number
23:33 < kallewoof> My code goes if isBool() {..} else if isNum() {..} else throw jsonrpcerror...
23:33 < sipa> so it's presumably sending a JSON string
23:33 < sipa> oh, bools too; sorry, 5
23:34 < kallewoof> Right -- I thought Decimal() gave a JSON number. Guess not.
23:34 < sipa> i guess not :)
23:35 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 248 seconds]
23:37 -!- ken2812221 [~User@180.217.140.78] has quit [Ping timeout: 248 seconds]
23:38 < luke-jr> probably should be made to
23:46 < kallewoof> I'm honestly pretty sure it is, and I'm screwing something up, but rounding errors are no biggie in this case so I'm going with the native variant.
23:48 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
--- Log closed Tue Jul 31 00:00:26 2018