--- Log opened Mon Aug 20 00:00:45 2018
00:15 < wumpus> luke-jr: https://github.com/laanwj/bitcoin/releases/tag/v0.17.0rc1
00:15 < wumpus> I've uploaded only the windows ones you mentioned, if you need any others let me know
00:26 -!- profmac [~ProfMac@72-48-98-98.dyn.grandenetworks.net] has quit [Read error: Connection reset by peer]
00:27 -!- profmac [~ProfMac@72-48-98-98.dyn.grandenetworks.net] has joined #bitcoin-core-dev
00:40 -!- Orion3k [~Orion3k@185.103.109.20] has quit [Ping timeout: 276 seconds]
00:42 -!- profmac [~ProfMac@72-48-98-98.dyn.grandenetworks.net] has quit [Read error: Connection reset by peer]
00:42 -!- profmac [~ProfMac@72-48-98-98.dyn.grandenetworks.net] has joined #bitcoin-core-dev
00:46 -!- csknk [~csknk@unaffiliated/csknk] has joined #bitcoin-core-dev
00:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
01:00 -!- cornfeedhobo [~cornfeedh@unaffiliated/cornfeed] has quit [Quit: ZNC - https://znc.in]
01:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds]
01:12 -!- cornfeedhobo [~cornfeedh@unaffiliated/cornfeed] has joined #bitcoin-core-dev
01:18 -!- Krellan [~Krellan@2601:640:4000:9258:5964:61d6:c932:b19] has quit [Read error: Connection reset by peer]
01:20 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-bzfnoksqguxoizcv] has joined #bitcoin-core-dev
01:25 -!- Krellan [~Krellan@2601:640:4000:9258:5964:61d6:c932:b19] has joined #bitcoin-core-dev
01:30 -!- cornfeedhobo [~cornfeedh@unaffiliated/cornfeed] has quit [Quit: ZNC - https://znc.in]
01:33 -!- Zenton [~user@195.235.96.150] has joined #bitcoin-core-dev
01:37 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
01:40 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 240 seconds]
01:41 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection]
01:41 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
01:42 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev
01:52 -!- cornfeedhobo [~cornfeedh@unaffiliated/cornfeed] has joined #bitcoin-core-dev
01:54 -!- vexbuy_ [~vexbuy@147.red-83-47-212.dynamicip.rima-tde.net] has quit [Remote host closed the connection]
01:54 -!- rls [~rls@104.250.122.134] has quit [Ping timeout: 272 seconds]
01:54 -!- vexbuy [~vexbuy@147.red-83-47-212.dynamicip.rima-tde.net] has joined #bitcoin-core-dev
01:57 -!- promag [~promag@83.223.233.83] has joined #bitcoin-core-dev
01:59 -!- vexbuy_ [~vexbuy@147.red-83-47-212.dynamicip.rima-tde.net] has joined #bitcoin-core-dev
02:00 -!- vexbuy [~vexbuy@147.red-83-47-212.dynamicip.rima-tde.net] has quit [Ping timeout: 260 seconds]
02:00 -!- Krellan [~Krellan@2601:640:4000:9258:5964:61d6:c932:b19] has quit [Ping timeout: 260 seconds]
02:01 -!- vexbuy_ [~vexbuy@147.red-83-47-212.dynamicip.rima-tde.net] has quit [Remote host closed the connection]
02:05 -!- Krellan [~Krellan@2601:640:4000:9258:5964:61d6:c932:b19] has joined #bitcoin-core-dev
02:06 -!- promag [~promag@83.223.233.83] has quit [Remote host closed the connection]
02:10 -!- itaseski [~itaseski@213.135.176.244] has joined #bitcoin-core-dev
02:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:13 -!- JackH [~laptop@host86-157-119-232.range86-157.btcentralplus.com] has joined #bitcoin-core-dev
02:15 -!- no_input_found [no_input_f@gateway/vpn/privateinternetaccess/noinputfound/x-24977668] has quit [Remote host closed the connection]
02:15 -!- no_input_found [no_input_f@gateway/vpn/privateinternetaccess/noinputfound/x-24977668] has joined #bitcoin-core-dev
02:20 -!- mess110 [~kiki@unaffiliated/mess110] has joined #bitcoin-core-dev
02:21 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev
02:22 < mess110> hi, can I get a few reviews for https://github.com/bitcoin/bitcoin/pull/13248 please?
02:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
02:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:45 -!- Amuza [~amuza@94.76.144.161] has joined #bitcoin-core-dev
03:00 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Quit: ZNC 1.7.0 - https://znc.in]
03:03 -!- profmac [~ProfMac@72-48-98-98.dyn.grandenetworks.net] has quit [Ping timeout: 272 seconds]
03:06 -!- Amuza [~amuza@94.76.144.161] has quit [Ping timeout: 240 seconds]
03:08 -!- Amuza [~amuza@94.76.144.161] has joined #bitcoin-core-dev
03:28 -!- mess110 [~kiki@unaffiliated/mess110] has quit [Quit: Leaving]
03:33 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #bitcoin-core-dev
04:09 < wumpus> #13248
04:09 < gribble> https://github.com/bitcoin/bitcoin/issues/13248 | [gui] Make proxy icon from statusbar clickable by mess110 · Pull Request #13248 · bitcoin/bitcoin · GitHub
04:14 < wumpus> looks like it has enough utACKs for a change like this, I'll give it a quick try
04:26 -!- dE7ERV [6cab81a1@gateway/web/freenode/ip.108.171.129.161] has joined #bitcoin-core-dev
04:36 -!- Traino [~Traino@2a07:5741:0:135b::1] has joined #bitcoin-core-dev
04:42 -!- Amuza [~amuza@94.76.144.161] has quit [Ping timeout: 260 seconds]
04:44 -!- Amuza [~amuza@94.76.144.161] has joined #bitcoin-core-dev
04:56 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Ping timeout: 240 seconds]
05:04 -!- dE7ERV [6cab81a1@gateway/web/freenode/ip.108.171.129.161] has quit [Ping timeout: 252 seconds]
05:09 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #bitcoin-core-dev
05:13 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Read error: Connection reset by peer]
05:22 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev
05:32 -!- Amuza [~amuza@94.76.144.161] has quit [Ping timeout: 240 seconds]
05:40 -!- copumpkin [~copumpkin@haskell/developer/copumpkin] has joined #bitcoin-core-dev
05:53 < Zenton> if I store a wallet with a strong passphrase and save that wallet dat file in an usb memory, is that security enough or do you recommend me to also encrypt all the usb memory?
06:04 < wumpus> Zenton: better ask in #bitcoin, this is a developer channel, you'd probably want to mention your perceived threat model for 'secure enough' as well
06:06 < Zenton> thanks wumpus 
06:10 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has quit [Quit: Leaving.]
06:12 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has joined #bitcoin-core-dev
06:22 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
06:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 276 seconds]
06:27 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
06:29 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
06:36 -!- vexbuy [~vexbuy@147.red-83-47-212.dynamicip.rima-tde.net] has joined #bitcoin-core-dev
06:40 -!- profmac [~ProfMac@72-48-98-98.dyn.grandenetworks.net] has joined #bitcoin-core-dev
06:51 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Remote host closed the connection]
06:53 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #bitcoin-core-dev
06:55 -!- blackbaba [~blackbaba@106.192.223.92] has joined #bitcoin-core-dev
06:55 -!- marcinja [~marcin@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
06:57 -!- blackbaba [~blackbaba@106.192.223.92] has quit [Client Quit]
06:59 -!- vexbuy [~vexbuy@147.red-83-47-212.dynamicip.rima-tde.net] has quit [Remote host closed the connection]
07:00 -!- vexbuy [~vexbuy@46.166.142.217] has joined #bitcoin-core-dev
07:03 -!- vexbuy [~vexbuy@46.166.142.217] has quit [Client Quit]
07:04 -!- jtimon [~quassel@213.28.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
07:14 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection]
07:15 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev
07:26 -!- Krellan [~Krellan@2601:640:4000:9258:5964:61d6:c932:b19] has quit [Ping timeout: 265 seconds]
07:32 -!- Krellan [~Krellan@2601:640:4000:9258:5964:61d6:c932:b19] has joined #bitcoin-core-dev
07:34 -!- Amuza [~amuza@94.76.144.161] has joined #bitcoin-core-dev
07:36 -!- Rootsudo [~textual@180.191.153.132] has joined #bitcoin-core-dev
07:43 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has joined #bitcoin-core-dev
07:47 -!- Amuza [~amuza@94.76.144.161] has quit [Ping timeout: 240 seconds]
07:48 -!- Amuza [~amuza@46.222.87.82] has joined #bitcoin-core-dev
08:16 -!- Amuza [~amuza@46.222.87.82] has quit [Read error: Connection reset by peer]
08:16 -!- Amuza [~amuza@46.222.87.82] has joined #bitcoin-core-dev
08:18 -!- Amuza [~amuza@46.222.87.82] has quit [Read error: Connection reset by peer]
08:21 -!- Amuza [~amuza@94.76.144.161] has joined #bitcoin-core-dev
08:21 -!- vexbuy [~vexbuy@46.166.142.217] has joined #bitcoin-core-dev
08:30 -!- Amuza [~amuza@94.76.144.161] has quit [Read error: Connection reset by peer]
08:36 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
08:37 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
08:55 -!- ExtraCrispy [~ExtraCris@89.39.105.101] has joined #bitcoin-core-dev
09:05 -!- Traino [~Traino@2a07:5741:0:135b::1] has quit [Ping timeout: 256 seconds]
09:09 -!- Rootsudo [~textual@180.191.153.132] has quit [Ping timeout: 244 seconds]
09:19 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
09:22 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds]
09:24 -!- itaseski [~itaseski@213.135.176.244] has quit [Quit: Leaving]
09:41 -!- vexbuy [~vexbuy@46.166.142.217] has quit [Remote host closed the connection]
09:42 -!- vexbuy [~vexbuy@46.166.142.217] has joined #bitcoin-core-dev
09:47 -!- vexbuy [~vexbuy@46.166.142.217] has quit [Ping timeout: 272 seconds]
10:00 < provoostenator> Is it a new "feature" that you can't interrupt (ctrl + c, or even ctrl + z) gitian-build.py? I forgot to run it inside a screen :-)
10:01 -!- str4d [~str4d@27.37.99.195.dyn.plus.net] has joined #bitcoin-core-dev
10:05 < arubi> oh man and I on tmux, and I hit ctrl+c on the gitian pane instead of on the `tail -f build.log` one and thought some divine intervention happened that didn't kill the build
10:06 -!- vexbuy [~vexbuy@147.red-83-47-212.dynamicip.rima-tde.net] has joined #bitcoin-core-dev
10:12 -!- profmac [~ProfMac@72-48-98-98.dyn.grandenetworks.net] has quit [Ping timeout: 244 seconds]
10:13 -!- grubles [~grubles@unaffiliated/grubles] has joined #bitcoin-core-dev
10:16 -!- cfields_ [~quassel@unaffiliated/cfields] has quit [Remote host closed the connection]
10:23 < cfields> wumpus: I didn't sign rc1 because I wasn't sure if the determinism issue was relevant. Now that we've tracked it down and it's Linux-only, would you like me to sign for rc1, or just skip and do an rc2?
10:26 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer]
10:27 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev
10:31 -!- goatpig [56eece80@gateway/web/freenode/ip.86.238.206.128] has joined #bitcoin-core-dev
10:38 -!- Zenton [~user@195.235.96.150] has quit [Ping timeout: 255 seconds]
10:38 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
10:41 -!- Amuza [~amuza@94.76.144.161] has joined #bitcoin-core-dev
10:43 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 256 seconds]
10:46 -!- echonaut9 [~echonaut@46.101.192.134] has joined #bitcoin-core-dev
10:47 -!- echonaut [~echonaut@46.101.192.134] has quit [Remote host closed the connection]
11:05 -!- vexbuy [~vexbuy@147.red-83-47-212.dynamicip.rima-tde.net] has quit [Remote host closed the connection]
11:05 -!- vexbuy [~vexbuy@147.red-83-47-212.dynamicip.rima-tde.net] has joined #bitcoin-core-dev
11:07 -!- Krellan [~Krellan@2601:640:4000:9258:5964:61d6:c932:b19] has quit [Remote host closed the connection]
11:07 -!- vexbuy_ [~vexbuy@147.red-83-47-212.dynamicip.rima-tde.net] has joined #bitcoin-core-dev
11:07 -!- itaseski [~itaseski@213.135.176.244] has joined #bitcoin-core-dev
11:10 -!- vexbuy [~vexbuy@147.red-83-47-212.dynamicip.rima-tde.net] has quit [Ping timeout: 276 seconds]
11:16 -!- cornfeedhobo [~cornfeedh@unaffiliated/cornfeed] has quit [Quit: ZNC - https://znc.in]
11:16 -!- Amuza [~amuza@94.76.144.161] has quit [Ping timeout: 240 seconds]
11:17 -!- Amuza [~amuza@94.76.144.161] has joined #bitcoin-core-dev
11:26 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev
11:27 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 255 seconds]
11:27 -!- cornfeedhobo [~cornfeedh@unaffiliated/cornfeed] has joined #bitcoin-core-dev
12:13 -!- hashist [~hashist@89.160.185.147] has joined #bitcoin-core-dev
12:15 -!- Giszmo [~leo@pc-72-54-46-190.cm.vtr.net] has joined #bitcoin-core-dev
12:16 -!- Amuza [~amuza@94.76.144.161] has quit [Ping timeout: 272 seconds]
12:29 -!- kevink [5ad952b6@gateway/web/freenode/ip.90.217.82.182] has joined #bitcoin-core-dev
12:31 < kevink> If this is true it looks like someone found a way to increase the blocksize via a soft-fork. It sounds very dangerous, I thought the Core developers might want to know https://twitter.com/StopAndDecrypt/status/1031619644627582976
12:34 < sipa> kevink: of course softforks to increase capacity are possible
12:34 < sipa> a softfork requires consensus to deploy, though
12:35 < sipa> and potential resource increases don't affect those who do not choose to follow them
12:41 -!- Zenton [~user@54.104.135.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
12:42 -!- Zenton [~user@54.104.135.37.dynamic.jazztel.es] has quit [Remote host closed the connection]
12:42 < kevink> I asked Luke before and he said further blocksize increases would require a hard-fork. Thats why I thought it was a big deal. I guess not. 😂 
12:43 < sipa> this is just research
12:43 -!- Zenton [~user@54.104.135.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
12:43 < sipa> research about upgrade mechanisms is obviously a good thing
12:44 < kevink> Are they? You don't think this is a potential attack vector? 
12:45 < sipa> no
12:45 < sipa> if it is an attack vector, it should be fixed
12:45 < sipa> so far i haven't seen anything to suggest that it is
12:46 < gmaxwell> It's a waste of everyones time to bother speculating about things that the people suggesting them won't disclose.
12:46 < kevink> Fair enough, we can talk about it after the presentation. ;)
12:46 < gmaxwell> as usual, everyone in that discussion is probably misunderstanding each other.
12:46 < gmaxwell> (as usual in the sense that it's twitter)
12:50 < StopAndDecrypt> i hold my conclusions until its presented
12:51 < sipa> thanks
12:54 -!- vexbuy [~vexbuy@147.red-83-47-212.dynamicip.rima-tde.net] has joined #bitcoin-core-dev
12:54 -!- a5m0 [~a5m0@unaffiliated/a5m0] has quit [Disconnected by services]
12:54 -!- a5m0_ [~a5m0@unaffiliated/a5m0] has joined #bitcoin-core-dev
12:55 -!- musalbas [~musalbas@algebra.musalbas.com] has quit [Ping timeout: 256 seconds]
12:55 -!- IGHOR [~quassel@93.178.216.72] has quit [Ping timeout: 256 seconds]
12:55 -!- math_ [~mario@p4FCB3FA3.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds]
12:56 -!- vexbuy_ [~vexbuy@147.red-83-47-212.dynamicip.rima-tde.net] has quit [Ping timeout: 256 seconds]
12:56 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev
12:58 -!- spinza [~spin@155.93.246.187] has quit [Ping timeout: 260 seconds]
12:59 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection]
13:00 -!- math_ [~mario@p4FCB3FA3.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
13:02 -!- str4d [~str4d@27.37.99.195.dyn.plus.net] has quit [Ping timeout: 272 seconds]
13:08 -!- minskey [uid315796@gateway/web/irccloud.com/x-dwzwikkrnzielelh] has quit [Ping timeout: 256 seconds]
13:15 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-bzfnoksqguxoizcv] has quit [Quit: Connection closed for inactivity]
13:18 -!- rex4539 [~rex4539@ppp-2-87-178-187.home.otenet.gr] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
13:26 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
13:27 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
13:30 -!- dcousens [~dcousens@110.140.174.10] has quit [Ping timeout: 244 seconds]
13:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 276 seconds]
13:33 -!- dcousens [~dcousens@110.140.174.10] has joined #bitcoin-core-dev
13:34 -!- kevink [5ad952b6@gateway/web/freenode/ip.90.217.82.182] has quit [Quit: Page closed]
13:38 -!- profmac [~ProfMac@72-48-98-98.dyn.grandenetworks.net] has joined #bitcoin-core-dev
13:39 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has quit [Remote host closed the connection]
13:48 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
13:56 -!- vexbuy [~vexbuy@147.red-83-47-212.dynamicip.rima-tde.net] has quit [Write error: Connection reset by peer]
13:56 -!- hashist [~hashist@89.160.185.147] has left #bitcoin-core-dev ["Leaving"]
14:00 -!- csknk [~csknk@unaffiliated/csknk] has quit [Quit: leaving]
14:22 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
14:25 -!- no_input_found [no_input_f@gateway/vpn/privateinternetaccess/noinputfound/x-24977668] has quit [Remote host closed the connection]
14:25 -!- no_input_found [no_input_f@gateway/vpn/privateinternetaccess/noinputfound/x-24977668] has joined #bitcoin-core-dev
14:30 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]
14:31 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has quit [Quit: Leaving.]
14:35 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev
14:39 -!- profmac [~ProfMac@72-48-98-98.dyn.grandenetworks.net] has quit [Ping timeout: 244 seconds]
14:48 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
14:55 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has quit []
14:56 -!- jhfrontz [~Adium@68.68.26.2.customer.bluemilenetworks.com] has joined #bitcoin-core-dev
15:02 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
15:05 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer]
15:06 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 240 seconds]
15:07 -!- profmac [~ProfMac@72-48-98-98.dyn.grandenetworks.net] has joined #bitcoin-core-dev
15:07 -!- jhfrontz [~Adium@68.68.26.2.customer.bluemilenetworks.com] has quit [Quit: Leaving.]
15:08 -!- jhfrontz [~Adium@68.68.26.2.customer.bluemilenetworks.com] has joined #bitcoin-core-dev
15:09 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
15:14 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Quit: WeeChat 1.4]
15:27 -!- peevsie [~peevsie@2604:2000:f18f:e300::2] has joined #bitcoin-core-dev
15:29 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
15:32 -!- jhfrontz [~Adium@68.68.26.2.customer.bluemilenetworks.com] has quit [Quit: Leaving.]
15:33 -!- jhfrontz [~Adium@68.68.26.2.customer.bluemilenetworks.com] has joined #bitcoin-core-dev
15:36 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]
15:41 -!- itaseski [~itaseski@213.135.176.244] has quit [Ping timeout: 272 seconds]
15:45 -!- profmac [~ProfMac@72-48-98-98.dyn.grandenetworks.net] has quit [Read error: Connection reset by peer]
15:46 -!- profmac [~ProfMac@72-48-98-98.dyn.grandenetworks.net] has joined #bitcoin-core-dev
15:47 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev
15:49 -!- rls [~rls@104.250.122.134] has joined #bitcoin-core-dev
15:55 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev
15:59 -!- profmac [~ProfMac@72-48-98-98.dyn.grandenetworks.net] has quit [Read error: Connection reset by peer]
16:07 -!- jhfrontz [~Adium@68.68.26.2.customer.bluemilenetworks.com] has quit [Quit: Leaving.]
16:09 -!- Dizzle [~dizzle@108.171.182.16] has quit [Ping timeout: 265 seconds]
16:09 -!- davex__ [~user@97-119-97-211.omah.qwest.net] has quit [Ping timeout: 260 seconds]
16:10 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
16:28 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev
16:41 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]
16:47 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Quit: drexl]
16:56 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has joined #bitcoin-core-dev
17:03 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Read error: Connection reset by peer]
17:12 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev
17:13 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
17:13 < fanquake> cfields I think once #14005 is merged we could just skip to an rc2? Might also be able to get #13968 in before that.
17:13 < gribble> https://github.com/bitcoin/bitcoin/issues/14005 | [0.17] depends: fix qt determinism by MarcoFalke · Pull Request #14005 · bitcoin/bitcoin · GitHub
17:13 < gribble> https://github.com/bitcoin/bitcoin/issues/13968 | [wallet] couple of walletcreatefundedpsbt fixes by instagibbs · Pull Request #13968 · bitcoin/bitcoin · GitHub
17:14 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
17:18 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection]
17:19 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev
17:33 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
17:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
17:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 276 seconds]
18:16 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Remote host closed the connection]
18:16 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 244 seconds]
18:23 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev
18:25 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
18:26 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Client Quit]
18:44 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
18:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 244 seconds]
20:44 -!- Jmabsd [~jmabsd@static-118-252-90.rpnspl.com] has joined #bitcoin-core-dev
20:44 -!- phwalkr [~phwalkr@2001:1284:f019:69b1:749a:6186:8f48:1fb2] has joined #bitcoin-core-dev
20:45 < Jmabsd> Where is Bitcoin Core's serialization and deserialization code for values in various structures such as transactions, block headers, and protocol data?  This code shows the endianness used
20:46 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
20:46 < luke-jr> serialization.h and the various class headers
20:48 < Jmabsd> luke-jr: great - in what cases (except for TCP/IP ip:s and ports) is small endian *not* useD?
20:49 < sipa> everything in bitcoin uses little endian
20:49 < sipa> *but*
20:49 < sipa> the output of hash functions is seen as byte arrays, which are just serialized byte-per-byte
20:49 < sipa> (SHA256 internally uses big endian, but that's black box - it's a function that takes as input a byte array and produces another byte array from bitcoin's pov)
20:50 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 272 seconds]
20:52 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds]
20:54 < Jmabsd> sipa, the SHA256 specific about Bitcoin is why you need to byte-reverse most(all?) SHA256 libraries' results within Bitcoin merkle tree merkle node calculations, right?
20:55 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
20:55 < sipa> Jmabsd: no
20:55 < gmaxwell> what? no. 
20:55 < sipa> Jmabsd: for human consumption the bytes are sometimes printed in reverse order
20:55 < sipa> but inside the protocol and data structures, there is never any swapping
20:57 < Jmabsd> endianness is so comical, smartphones (ARM) are big endian, derp. :)) 
20:57 < gmaxwell> I don't believe any smartphone is BE.
20:58 < gmaxwell> (ARM can run in BE mode or LE mode, but the smartphones all use them in LE mode)
20:58 < gmaxwell> (as does virtually all modern stuff)
20:58 < sipa> iOS and Android are LE
20:59 < Jmabsd> wait, where are Bitcoin Core's logics to actually enforce little-endian serialization   - say I run Bitcoin Core on an ARM.. is this the line that will cause the big endian (native to my computer) to little endian (serialization form) conversoin: https://github.com/bitcoin/bitcoin/blob/master/src/serialize.h#L89 ? 
21:00 < sipa> yes
21:00 < sipa> htole means "host to little endian"
21:00 < sipa> on LE systems that function is a dummy; on BE systems it does a byteswap
21:01 < Jmabsd> right so, posix stipulates these, https://linux.die.net/man/3/htole32 , right.
21:01 < Jmabsd> cool!
21:03 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
21:04 < luke-jr> Jmabsd: actually, htole32 isn't POSIX
21:05 < Jmabsd> luke-jr: oh you are right, but instead, .." functions are **expected** to conform to a future version of IEEE Std 1003.1 (“POSIX.1”). The other functions are extensions that should not be used when portability is required. "
21:07 < Jmabsd> (this may be more of a #bitcoin question), what is an authoritative reference on that the DER signature's max size is 72 bytes?     i see some discussion like this https://bitcoin.stackexchange.com/questions/12554/why-the-signature-is-always-65-13232-bytes-long  but it's not super clea.r
21:08 < Jmabsd> sipa writes in this thread that "This results in 71 bytes signatures (on average)" - but what's the max
21:08 < Jmabsd> and why
21:09 < sipa> Jmabsd: the R and S value are 256-bit values, which are at most 33 bytes when encoded in DER
21:09 < sipa> then there is 6 bytes of DER headers
21:09 < sipa> and bitcoin adds a 1 byte sighash to the end
21:09 < sipa> so together 33+33+6+1 = 73 max
21:10 < sipa> however, since the introduction of the low-s rule (which is just policy, not a consensus rule), S values are at most 255 bits, which encodes to at most 32 bytes, reducing the maximum to 72
21:11 < Jmabsd> aha, so when low-s is not applied, 33B R + 33B S + 6B headers + 1B sighash = 73 bytes
21:12 < sipa> right
21:12 < Jmabsd> and with low-s, S (and not R) is 255 instead of 256 bits, meaning 33B R + 32B S + 6B headers + 1B sighash = 72B.
21:13 < Jmabsd> very well noted thanks!    if you like you can add what you just wrote to me here to that stackexchange thread, as final clarification. thanks for clarifying.
21:19 -!- rls [~rls@104.250.122.134] has quit [Quit: rip]
21:24 < Jmabsd> sipa: wait, the way this max of 72/73B applies to P2PKH and P2PK sigscripts is... P2PK is only <signature>, since this is <= 75 only one byte for PUSHDATA is needed, and then follows up to **73** bytes of signature data, meaning P2PK may take **74** bytes at most?  and, P2PKH is <signature> <pubkey>, pubkey is normally 33B or for legacy uncompressed 65B, both push-datas are single-byte due to <=75B, and the signature may be **73B** 
21:24 < Jmabsd> so 1 + 73 + 1 + 33/65 = 108 or 140B sigscript max for P2PKH?
21:25 < Jmabsd> libbitcoin though says "static BC_CONSTEXPR size_t max_der_signature_size = 72;", hm
21:25 < Jmabsd> ..which is excluding sighash byte, meaning 73B max here too?
21:25 < sipa> low s is not a consensus rule
21:28 < Jmabsd> sipa: are the calculations I made about max size sigscript for P2PKH and P2PK (108/140B and 74B) correct?
21:29 < sipa> i believe they're right
21:38 -!- phwalkr [~phwalkr@2001:1284:f019:69b1:749a:6186:8f48:1fb2] has quit [Remote host closed the connection]
21:39 -!- phwalkr [~phwalkr@2001:1284:f019:69b1:749a:6186:8f48:1fb2] has joined #bitcoin-core-dev
21:39 < arubi> just like low is isn't consensus rule, neither is a clean scriptsig for p2pk\p2pkh :)
21:42 < arubi> er, low *s*
21:44 -!- phwalkr [~phwalkr@2001:1284:f019:69b1:749a:6186:8f48:1fb2] has quit [Ping timeout: 265 seconds]
21:53 -!- Jmabsd [~jmabsd@static-118-252-90.rpnspl.com] has quit [Ping timeout: 268 seconds]
21:57 -!- goatpig [56eece80@gateway/web/freenode/ip.86.238.206.128] has quit [Ping timeout: 252 seconds]
22:12 -!- jtimon [~quassel@213.28.134.37.dynamic.jazztel.es] has quit [Ping timeout: 272 seconds]
22:20 -!- jtimon [~quassel@213.28.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
22:33 -!- jtimon [~quassel@213.28.134.37.dynamic.jazztel.es] has quit [Ping timeout: 276 seconds]
22:44 -!- Jmabsd [~jmabsd@static-118-252-90.rpnspl.com] has joined #bitcoin-core-dev
22:56 < Jmabsd> arubi: wait, what do you mean?
23:14 < arubi> Jmabsd, I mean yes, you can calculate the maximum size of a signature and a pubkey, and also yes, normally it's only the signature in scriptsig for p2pk and pubkey+signature for p2pkh, but there is no rule that says that other things can't added in a p2pk or p2pkh spend scriptsig
23:15 -!- Krellan [~Krellan@2601:640:4000:9258:15b9:9c11:dff8:429b] has joined #bitcoin-core-dev
23:16 < luke-jr> wumpus: doc/man/Makefile -AWK = gawk+AWK = mawk
23:16 -!- Jmabsd [~jmabsd@static-118-252-90.rpnspl.com] has quit [Ping timeout: 256 seconds]
23:17 < arubi> so saying that 108\140 bytes is the maximum size of such a scriptsig is not /wrong/, but it's not consensus accurate.  the only reason I brought it up is because it's the same thing with low s
23:18 < wumpus> cfields: agree, no need to sign rc1
23:18 < wumpus> cfields: we can skip over it and do rc2, there's another fix that needs to be merged to IIRC
23:18 < luke-jr> so I guess I need to uninstall gawk somehow
23:18 < wumpus> luke-jr: I'm not sure I understand
23:19 < wumpus> so the difference between awk and gawk causes non-determinism?
23:20 -!- Jmabsd [~jmabsd@static-118-252-90.rpnspl.com] has joined #bitcoin-core-dev
23:20 < luke-jr> wumpus: gawk and mawk, but yes
23:21 < luke-jr> if gawk is found, configure prefers it, and it ends up in doc/man/Makefile
23:21 < luke-jr> so I guess the only way to fix it is to either guarantee all base VMs have no gawk, or to always install gawk so they do
23:22 < wumpus> what bothers me is that the different tool causes a different output
23:22 < wumpus> the build system is supposed to choose between *equivalent* tools
23:22 < wumpus> if it makes a difference which one is chosen I think it should reject either one, or we should change the usage so that the output matches
23:22 < luke-jr> wumpus: I'm sure the tools produce equivalent output
23:22 < luke-jr> the difference is the command line in the Makefile
23:23 < wumpus> then why is this a non-determinism issue?
23:23 < wumpus> how does that affect the executable?
23:23 < luke-jr> I'm not sure why the Makefile is included in the output
23:23 < wumpus> oh, me neither, are you sure that file needs to be deterministic at all? 
23:23 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Ping timeout: 268 seconds]
23:23 < wumpus> if it includes a makefile it seems it's an intermediate product for something
23:23 < luke-jr> I guess that's the real bug
23:23 < wumpus> yes
23:24 < luke-jr> the nsis script seems to just include doc/*
23:24 < wumpus> I think 'make install' is supposed to install the man pages, but not a makefile?!?
23:25 < luke-jr> it uses @abs_top_srcdir@/doc\*.*
23:25 < luke-jr> so make install isn't involved
23:26 -!- rex4539 [~rex4539@2a02:587:3516:600:498b:79b4:c41b:40fe] has joined #bitcoin-core-dev
23:27 < wumpus> right--anyhow, let's try to fix this for rc2 as well
23:27 < wumpus> thanks for narrowing this down
23:28 < luke-jr> I suppose the dumbest way would be to delete Makefile* there first, or even all of the man directory (Windows can't view them anyeway?)
23:28 < luke-jr> I'm not sure what a *good* solution would look like
23:28 < luke-jr> fwiw, removing gawk implies: The following packages will be REMOVED:  byobu gawk ubuntu-server
23:29 < luke-jr> so apparently y'all have base VMs without ubuntu-server O.o
23:30 < Jmabsd> what may arubi have meant by "just like low is isn't consensus rule, neither is a clean scriptsig for p2pk\p2pkh :)"?
23:35 < wumpus> luke-jr: I think you'd want to delete everything that isn't a man page, isn't there a VARIABLE that has the man page names?
23:35 < wumpus> luke-jr: and,say, copy those instead of everything
23:36 < Jmabsd> (ah he responded on #bitcoin, great.)
23:38 < luke-jr> wumpus: uh? Windows users want everything except the manpages I would think
23:40 < wumpus> src/doc only has manpages
23:41 < wumpus> so if you don't want the manpages then yes you can skip the entire directory
23:42 < luke-jr> it's just doc/ not src/doc/
23:42 < luke-jr> src/doc/ doesn't exist <.<
23:42 < luke-jr> doc/ has the various README files etc
23:44 < wumpus> ok
23:44 < wumpus> yes, this is a drawback of not explicitly listing files but using wildcards, cfields has been discouraging those for about forever :)
23:45 < luke-jr> don't see a nice way to delete stuff :x
23:46 < luke-jr> maybe /x Makefile* for now
23:46 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev
23:46 < luke-jr> http://nsis.sourceforge.net/Reference/File
23:47 < luke-jr> I guess /x man might work too
23:47 < luke-jr> if we definitely don't want the manpages install
23:49 -!- karelb [uid316741@gateway/web/irccloud.com/x-kkjmbsfwkkmctstz] has joined #bitcoin-core-dev
23:51 -!- vexbuy [~vexbuy@147.red-83-47-212.dynamicip.rima-tde.net] has joined #bitcoin-core-dev
23:52 < wumpus> I'd prefer to exclude copying the makefile instead of deleting it
23:52 < wumpus> yes
23:52 < wumpus> excluding it from the archive would work too I suppose
23:53 < luke-jr> wumpus: want to make a branch we both build and compare? ;)
23:55 < luke-jr> I pushed fix_nsis_makefile to my github
23:55 < luke-jr> pushing*
--- Log closed Tue Aug 21 00:00:46 2018