--- Log opened Tue Oct 16 00:00:38 2018 00:00 < meshcollider> sipa: re private keys, if youve imported the private key then the danger isnt as prominent is it 00:06 -!- Krellan [~Krellan@2601:640:4000:9258:1c0e:9922:94ec:f186] has joined #bitcoin-core-dev 00:07 -!- Krellan [~Krellan@2601:640:4000:9258:1c0e:9922:94ec:f186] has quit [Remote host closed the connection] 00:07 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 00:08 < meshcollider> because even if they send to the key directly, you have the privkey 00:11 -!- Krellan [~Krellan@2601:640:4000:9258:c2a:310e:dfc:18b3] has joined #bitcoin-core-dev 00:23 -!- JackH [~laptop@host86-182-8-23.range86-182.btcentralplus.com] has quit [Quit: Leaving] 00:24 -!- DougieBot5000_ is now known as DougieBot5000 00:25 -!- romanz [~romanz@185.3.147.213] has quit [Quit: Leaving] 00:25 -!- romanz [~romanz@185.3.147.213] has joined #bitcoin-core-dev 00:31 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #bitcoin-core-dev 00:32 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 00:33 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 00:36 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has joined #bitcoin-core-dev 00:44 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 00:49 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 252 seconds] 01:18 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 01:26 -!- Empact_ [~empact@192-195-80-207.PUBLIC.monkeybrains.net] has quit [Ping timeout: 268 seconds] 01:30 -!- murrayn_ [~murrayn@S0106f8a097f16608.ok.shawcable.net] has joined #bitcoin-core-dev 01:33 -!- murrayn [~murrayn@unaffiliated/murrayn] has quit [Ping timeout: 272 seconds] 01:35 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 01:35 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 01:35 -!- murrayn_ [~murrayn@S0106f8a097f16608.ok.shawcable.net] has quit [Ping timeout: 252 seconds] 01:36 -!- proletesseract [~proletess@219.88.232.29] has quit [Remote host closed the connection] 01:41 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 01:41 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 01:49 < wumpus> karelb: lol that's stupid 01:50 < wumpus> please don't tell me that stupid spelling check is mandatory in travis now 01:50 < karelb> wumpus: maybe it's some misconfiguration... I don't really want to deal with it so I made a commit that I will remove before doing PR 01:51 < karelb> that commit just renamed mut to mutex 01:51 < wumpus> AHH apparently it was changed to fail in e413c2ddd1240d7bacd1837fa49d25781fe6e5fa 01:51 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Remote host closed the connection] 01:52 < wumpus> yes I can imagine... 01:53 < wumpus> i've tried, in vain, to prevent all kinds of silly lints from being merged 01:54 < karelb> :D 01:54 < karelb> I wonder why is my fork failing but not bitcoin master 01:54 < karelb> but I don't wonder *that much* 01:55 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 01:58 -!- rex4539 [~rex4539@oyfsc2.static.otenet.gr] has joined #bitcoin-core-dev 01:59 < wumpus> maybe... it only runs on PRs? 02:01 -!- bralyclo_ [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has joined #bitcoin-core-dev 02:02 < wumpus> well you could always rename it 'mutt' or 'moot', i'm sure that's an improvement... 02:02 < karelb> 'mutex' seems to work, although 'mutt' has a ring to it 02:03 -!- nickler [~nickler@159.69.205.219] has joined #bitcoin-core-dev 02:03 < wumpus> i'm not sure whether this constitutes a 'variable names need to be valid english words' policy 02:05 -!- bralyclow [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has quit [Ping timeout: 276 seconds] 02:07 -!- murrayn [~murrayn@S0106f8a097f16608.ok.shawcable.net] has joined #bitcoin-core-dev 02:07 -!- murrayn [~murrayn@S0106f8a097f16608.ok.shawcable.net] has quit [Changing host] 02:07 -!- murrayn [~murrayn@unaffiliated/murrayn] has joined #bitcoin-core-dev 02:08 < promag> wumpus: from the PR discussion looks like that change slipped? 02:09 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:10 < promag> maybe the reason is because nobody checks the warnings 02:11 -!- ken2812221_ [~ken281222@2001-b011-4010-14fa-f831-0ffb-a7ac-12fc.dynamic-ip6.hinet.net] has joined #bitcoin-core-dev 02:13 < luke-jr> 'variable names need to be valid english words' sounds like a stupid policy.. 02:22 < wumpus> luke-jr: no disagreement from me, i'm sure i've protested in the PR that added this linter, but meh i don't have the energy to fight this 02:23 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 245 seconds] 02:23 * wumpus wants to add a linter that deletes all linters 02:24 < luke-jr> :P 02:26 < wumpus> soo enough about that shit, are there any serious PRs I should pay attention to? 02:26 < luke-jr> dunno, barely have time to rebase my own stuff :/ 02:26 -!- Krellan [~Krellan@2601:640:4000:9258:c2a:310e:dfc:18b3] has quit [Read error: Connection reset by peer] 02:27 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 02:28 -!- Krellan [~Krellan@2601:640:4000:9258:c2a:310e:dfc:18b3] has joined #bitcoin-core-dev 02:28 < luke-jr> the downgrading warning in 0.17 relnotes is confusing; why is it talking about 0.15? 02:29 < meshcollider> luke-jr: because that's the version at which it changed isn't it 02:29 < meshcollider> but yeah its not worded well 02:30 < luke-jr> dunno, 0.16 didn't mention it 02:30 < luke-jr> I thought we had a change in 0.17 too? 02:30 < wumpus> I *guess* it's when you want to downgrade from 0.17 to 0.15? 02:30 < meshcollider> "Wallets created in 0.16 and later are not compatible with versions prior to 0.16 and will not work if you try to use newly created wallets in older versions. Existing wallets that were created with older versions are not affected by this." 02:30 < wumpus> it's a bit late to discuss 0.17 release notes, now 02:31 < meshcollider> it looks like its just been copy+pasted from 0.15, oh well 02:31 < luke-jr> wumpus: that's not what it says though :/ 02:31 < luke-jr> yes, just noticed 02:31 < wumpus> it probably has 02:32 < wumpus> the upgrading/downgrading part tends to be copy-pasted between releases because it tends to stay relevant 02:32 < wumpus> at some point it can be removed because no one is going to downgrade to 3 major versions back, but still 02:33 < wumpus> would be good to have close scrutiny of the release notes before a release 02:33 < promag> wumpus: I'm depending on #14291 for the multiwallet support in the UI 02:33 < gribble> https://github.com/bitcoin/bitcoin/issues/14291 | wallet: Add ListWalletDir utility function by promag · Pull Request #14291 · bitcoin/bitcoin · GitHub 02:33 < wumpus> promag: yeah have that one merged locally for testing 02:34 < promag> wumpus: nice 02:41 < meshcollider> sipa: for the descriptors PR, what if we don't even import the public keys? Why not just import the private keys, otherwise just import the scriptPubKey only as watch only 02:41 -!- ken2812221 [~ken281222@110.50.135.178] has quit [Read error: Connection reset by peer] 02:45 -!- ken2812221 [~ken281222@110.50.135.178] has joined #bitcoin-core-dev 03:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:21 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has quit [Ping timeout: 260 seconds] 03:34 -!- rex4539 [~rex4539@oyfsc2.static.otenet.gr] has quit [Ping timeout: 272 seconds] 03:35 < promag> sipa: meshcollider: please also see #14303 03:35 < gribble> https://github.com/bitcoin/bitcoin/issues/14303 | rpc: Early call once CWallet::MarkDirty in import calls by promag · Pull Request #14303 · bitcoin/bitcoin · GitHub 03:36 < meshcollider> promag: Already concept ACK'ed it ;) mentioned it above, its a nice cleanup 03:36 -!- kau [67373db7@gateway/web/freenode/ip.103.55.61.183] has joined #bitcoin-core-dev 03:37 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Remote host closed the connection] 03:37 < promag> ken2812221: how do you build and run tests on windows? do you use wsl and depends? 03:41 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev 03:45 -!- ken2812221__ [~ken281222@2001-b011-4010-14fa-e1e0-9b80-35a5-5c47.dynamic-ip6.hinet.net] has joined #bitcoin-core-dev 03:45 -!- ken2812221_ [~ken281222@2001-b011-4010-14fa-f831-0ffb-a7ac-12fc.dynamic-ip6.hinet.net] has quit [Ping timeout: 276 seconds] 03:46 < ken2812221__> promag: I use both MSVC and virtual machine to build it. The IO on WSL is extremely slow. 03:47 < promag> ken2812221__: right, it is 03:48 < promag> ken2812221__: is there a guide or something so I can easily setup the same here? 03:51 < ken2812221__> Copy bitcoin-cli.exe and bitcoind.exe into src folder. Modify and copy test\config.ini.in to test\config.ini. Then you can run python test\functional\test_runner.py --force. 03:57 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 03:57 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 03:57 < promag> I suspect #14299 will create more noise 03:57 < gribble> https://github.com/bitcoin/bitcoin/issues/14299 | Deprecate wallet `generate` RPC method · Issue #14299 · bitcoin/bitcoin · GitHub 04:06 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 04:09 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 260 seconds] 04:10 < wumpus> I don't know, I think telling people to use generatetoaddress is fine 04:10 < wumpus> the mining functionality in bitcoin core is not exactly used a lot 04:12 < wumpus> seperating the mining from the wallet always made sense, not sure why it hasn't been done before 04:14 -!- ken2812221__ [~ken281222@2001-b011-4010-14fa-e1e0-9b80-35a5-5c47.dynamic-ip6.hinet.net] has quit [Ping timeout: 260 seconds] 04:16 < promag> yeap, I also think the ones using it can easily change 04:22 -!- kau [67373db7@gateway/web/freenode/ip.103.55.61.183] has quit [Ping timeout: 256 seconds] 04:24 < promag> wumpus: does my response clarifies your concern https://github.com/bitcoin/bitcoin/pull/14291/files#r225491304 ? 04:26 < wumpus> promag: i'm personally scared of that behavior, but if others think it's ok, i'll just go along... 04:26 < wumpus> promag: you're right it only scans the files at recursion depth=0 for the btree signature, though it still *nests* into all the directories nevertheless 04:26 < promag> wumpus: do you think it should do that only if walletdir != datadir? 04:28 < wumpus> that would, to me, seem like the most straightforward way to prevent this; then give the user a clear explanation *why* it won't work and what they can do to make it work 04:29 < wumpus> one specific concern: opening and closing the .lock file will nix the datadir lock, at least on some OSes 04:30 < promag> hmm, skip that filename then? 04:30 < promag> ryanofsky: ^ 04:30 < wumpus> that seems *extremely* fragile 04:31 < wumpus> maybe this brings a valid problem to light: there's just too many ways to organize the data directory with regard to wallets, all need to be handled, and tested 04:32 < wumpus> in any case, I'd prefer if the RPC simply failed in that case 04:33 < promag> but do you agree on the concept? 04:37 < wumpus> in the case where there is a separate wallet directory, certainly! 04:38 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-yhiwuybhqlicnvlm] has joined #bitcoin-core-dev 04:38 < bitcoin-git> [bitcoin] practicalswift opened pull request #14495: build: Warn (don't fail!) on spelling errors (master...revert-codespell) https://github.com/bitcoin/bitcoin/pull/14495 04:38 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-yhiwuybhqlicnvlm] has left #bitcoin-core-dev [] 04:42 < promag> wumpus: I'll push a commit with that change to see what others say 04:51 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-toipfkenpbivjwaj] has joined #bitcoin-core-dev 04:51 < bitcoin-git> [bitcoin] practicalswift opened pull request #14496: build: Pin to specific versions of Python packages we install from PyPI in Travis (master...pin-pip-installed-packages-in-travis) https://github.com/bitcoin/bitcoin/pull/14496 04:51 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-toipfkenpbivjwaj] has left #bitcoin-core-dev [] 05:05 < promag> ken2812221: just say build_msvc/README.md 05:05 < promag> s/say/saw :P 05:07 < promag> assign #14495 to MarcoFalke? 05:07 < gribble> https://github.com/bitcoin/bitcoin/issues/14495 | build: Warn (dont fail!) on spelling errors by practicalswift · Pull Request #14495 · bitcoin/bitcoin · GitHub 05:11 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 05:30 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 05:34 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 244 seconds] 05:37 -!- shesek [~shesek@bzq-84-110-234-115.red.bezeqint.net] has joined #bitcoin-core-dev 05:37 -!- shesek [~shesek@bzq-84-110-234-115.red.bezeqint.net] has quit [Changing host] 05:37 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 05:40 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev 05:42 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 05:43 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 06:01 -!- dcousens [~dcousens@124.182.9.76] has joined #bitcoin-core-dev 06:02 -!- dcousens [~dcousens@124.182.9.76] has quit [Client Quit] 06:03 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 06:04 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 246 seconds] 06:05 -!- Jmabsd [~jmabsd@14.0.154.112] has joined #bitcoin-core-dev 06:05 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 06:06 < Jmabsd> sorry for disturbing - can you give me some reference where the hash in a P2WSH pubkey script is validated or/and generated? i like to understand if it's single or dual iteration SHA256 and how the code looks. 06:09 -!- echonaut [~echonaut@46.101.192.134] has joined #bitcoin-core-dev 06:10 -!- echonaut13 [~echonaut@46.101.192.134] has quit [Read error: Connection reset by peer] 06:15 -!- promag [~promag@46.50.6.142] has joined #bitcoin-core-dev 06:16 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 06:42 -!- Deinogalerix21 [~Deinogale@89.238.176.150] has joined #bitcoin-core-dev 06:51 -!- Deinogalerix21 [~Deinogale@89.238.176.150] has quit [Quit: WeeChat 2.2] 06:59 < karelb> ad the codespell issue - it seems I have branched master *before* the codespell version was fixed, so that's why it got updated now and shouted at me 06:59 < karelb> which explains that 07:04 -!- zivl [~zivl@unaffiliated/zivl] has quit [Quit: zivl] 07:07 -!- Krellan [~Krellan@2601:640:4000:9258:c2a:310e:dfc:18b3] has quit [Read error: Connection reset by peer] 07:07 < promag> wumpus: pushed https://github.com/bitcoin/bitcoin/pull/14291/commits/4702191778eaa23152fccd4d219a649ce712e79c 07:08 -!- Krellan [~Krellan@2601:640:4000:9258:c2a:310e:dfc:18b3] has joined #bitcoin-core-dev 07:11 -!- promag [~promag@46.50.6.142] has quit [Remote host closed the connection] 07:35 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev 07:35 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection] 07:36 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 07:36 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev 07:38 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 07:39 -!- grubles [~grubles@unaffiliated/grubles] has quit [Remote host closed the connection] 07:41 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 272 seconds] 07:41 < phantomcircuit> wumpus, can you look at #14335 07:41 < gribble> https://github.com/bitcoin/bitcoin/issues/14335 | net: refactor: cleanup ThreadSocketHandler by pstratem · Pull Request #14335 · bitcoin/bitcoin · GitHub 07:52 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 07:55 -!- nullptr| [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has quit [Quit: ZNC - http://znc.in] 07:56 -!- nullptr| [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has joined #bitcoin-core-dev 08:09 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Remote host closed the connection] 08:11 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev 08:13 < wumpus> phantomcircuit: sure 08:13 -!- bergz [~berg@69.12.27.194] has joined #bitcoin-core-dev 08:14 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-cvlevjoonaorqvmd] has joined #bitcoin-core-dev 08:14 < bitcoin-git> [bitcoin] DesWurstes closed pull request #14486: Add explicit cast to base58 and bech32 string constants in order to silence GCC warning (master...patch-4) https://github.com/bitcoin/bitcoin/pull/14486 08:14 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-cvlevjoonaorqvmd] has left #bitcoin-core-dev [] 08:21 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-alrmnizgmxmbatzk] has joined #bitcoin-core-dev 08:21 < bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/2468471e1398...23419e4c4939 08:21 < bitcoin-git> bitcoin/master edb5350 Patrick Strateman: Move NotifyNumConnectionsChanged logic to private method. 08:21 < bitcoin-git> bitcoin/master 7479b63 Patrick Strateman: Move DisconnectNodes logic to private method. 08:21 < bitcoin-git> bitcoin/master 2af9cff Patrick Strateman: Move InactivityCheck logic to private method. 08:21 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-alrmnizgmxmbatzk] has left #bitcoin-core-dev [] 08:21 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 245 seconds] 08:22 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-easgrgwwhdotagqe] has joined #bitcoin-core-dev 08:22 < bitcoin-git> [bitcoin] laanwj closed pull request #14335: net: refactor: cleanup ThreadSocketHandler (master...2018-09-24-thread-handler-cleanup) https://github.com/bitcoin/bitcoin/pull/14335 08:22 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-easgrgwwhdotagqe] has left #bitcoin-core-dev [] 08:24 < phantomcircuit> wumpus, ty 08:40 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 256 seconds] 08:44 -!- JackH [~laptop@host86-182-8-23.range86-182.btcentralplus.com] has joined #bitcoin-core-dev 08:44 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Remote host closed the connection] 08:45 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 08:46 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 08:46 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 256 seconds] 08:47 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev 08:48 -!- iphelix_ [~iphelix@iphelix.powered.by.lunarbnc.net] has quit [Quit: Free ZNC ~ Powered by LunarBNC: https://LunarBNC.net] 08:49 -!- grubles [~grubles@unaffiliated/grubles] has joined #bitcoin-core-dev 08:50 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 08:53 -!- iphelix [~iphelix@iphelix.powered.by.lunarbnc.net] has joined #bitcoin-core-dev 08:54 -!- iphelix is now known as Guest3720 08:55 -!- Guest3720 [~iphelix@iphelix.powered.by.lunarbnc.net] has quit [Client Quit] 08:59 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds] 09:00 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 09:01 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Remote host closed the connection] 09:03 -!- iphelix_ [~iphelix@iphelix.powered.by.lunarbnc.net] has joined #bitcoin-core-dev 09:04 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev 09:04 -!- Krellan [~Krellan@2601:640:4000:9258:c2a:310e:dfc:18b3] has quit [Ping timeout: 260 seconds] 09:04 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection] 09:05 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev 09:06 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 09:06 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Remote host closed the connection] 09:10 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection] 09:10 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev 09:19 -!- singleSole_ [bce2a4d8@gateway/web/freenode/ip.188.226.164.216] has joined #bitcoin-core-dev 09:20 < singleSole_> hi 09:29 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev 09:31 -!- singleSole_ [bce2a4d8@gateway/web/freenode/ip.188.226.164.216] has quit [Ping timeout: 256 seconds] 09:33 -!- promag [~promag@83.223.233.109] has joined #bitcoin-core-dev 09:35 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 09:35 -!- esotericnonsens_ [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev 09:35 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Read error: Connection reset by peer] 09:35 -!- esotericnonsens_ is now known as esotericnonsense 09:38 -!- Krellan [~Krellan@2601:640:4000:9258:c2a:310e:dfc:18b3] has joined #bitcoin-core-dev 09:40 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has quit [Remote host closed the connection] 09:41 -!- sfhi [~sfhi@91-152-138-1.elisa-laajakaista.fi] has joined #bitcoin-core-dev 09:49 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 09:52 -!- bergz [~berg@69.12.27.194] has quit [Quit: bergz] 10:05 -!- sfhi [~sfhi@91-152-138-1.elisa-laajakaista.fi] has quit [Quit: Leaving] 10:16 -!- promag [~promag@83.223.233.109] has quit [Remote host closed the connection] 10:18 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 10:48 -!- bralyclow [~bralyclow@195.242.213.117] has joined #bitcoin-core-dev 10:48 -!- bralyclow [~bralyclow@195.242.213.117] has quit [Client Quit] 10:49 -!- bralyclow [~bralyclow@195.242.213.117] has joined #bitcoin-core-dev 10:51 -!- bralyclo_ [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has quit [Ping timeout: 250 seconds] 11:00 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 11:01 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Remote host closed the connection] 11:04 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 11:07 -!- bralyclo_ [~bralyclow@195.242.213.117] has joined #bitcoin-core-dev 11:07 -!- bralyclo_ [~bralyclow@195.242.213.117] has quit [Client Quit] 11:07 -!- bralyclo_ [~bralyclow@195.242.213.117] has joined #bitcoin-core-dev 11:08 -!- bralyclo_ [~bralyclow@195.242.213.117] has quit [Client Quit] 11:09 -!- bralyclo_ [~bralyclow@195.242.213.117] has joined #bitcoin-core-dev 11:09 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 11:09 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 11:10 -!- bralyclow [~bralyclow@195.242.213.117] has quit [Ping timeout: 245 seconds] 11:30 -!- bergz [~berg@69.12.27.194] has joined #bitcoin-core-dev 11:31 -!- wumpus [~wumpus@pdpc/supporter/professional/wumpus] has quit [Remote host closed the connection] 11:31 -!- MrPaz [~MrPaz@84.39.112.82] has joined #bitcoin-core-dev 11:32 -!- MrPaz [~MrPaz@84.39.112.82] has quit [Client Quit] 11:38 -!- Krellan [~Krellan@2601:640:4000:9258:c2a:310e:dfc:18b3] has quit [Remote host closed the connection] 12:01 -!- bitconner [~conner@136.24.75.121] has joined #bitcoin-core-dev 12:18 -!- bralyclo_ [~bralyclow@195.242.213.117] has quit [] 12:18 -!- bralyclow [~bralyclow@195.242.213.117] has joined #bitcoin-core-dev 12:21 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 12:40 -!- bralyclow2 [~bralyclow@195.242.213.121] has joined #bitcoin-core-dev 12:47 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 12:48 -!- bralyclow2 [~bralyclow@195.242.213.121] has quit [Quit: Mutter: www.mutterirc.com] 12:48 -!- bralyclow2 [~bralyclow@195.242.213.121] has joined #bitcoin-core-dev 12:49 -!- bralyclow2 [~bralyclow@195.242.213.121] has quit [Client Quit] 12:49 -!- bralyclow2 [~bralyclow@195.242.213.121] has joined #bitcoin-core-dev 12:50 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 12:51 -!- bralyclow2 [~bralyclow@195.242.213.121] has quit [Client Quit] 12:51 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has joined #bitcoin-core-dev 12:51 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has quit [Changing host] 12:51 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 12:53 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 12:59 -!- jarthur [~jarthur@207.114.244.5] has quit [] 13:08 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 13:11 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 13:23 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 13:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 244 seconds] 13:27 -!- Squidicuz [~squid@pool-72-74-34-120.bstnma.fios.verizon.net] has joined #bitcoin-core-dev 13:31 -!- proletesseract [~proletess@219.88.232.29] has joined #bitcoin-core-dev 13:36 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 13:41 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 13:45 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 272 seconds] 13:45 -!- lukedashjr is now known as luke-jr 13:48 < hebasto> promag: regarding "breaking change" in #14494. why? 13:48 < gribble> https://github.com/bitcoin/bitcoin/issues/14494 | Error if # is used in rpcpassword in conf by MeshCollider · Pull Request #14494 · bitcoin/bitcoin · GitHub 13:49 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 13:58 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 14:03 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.2] 14:10 -!- cryptapus [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev 14:10 -!- cryptapus [~cryptapus@jupiter.osmus.org] has quit [Changing host] 14:10 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 14:11 -!- jamesob [sid180710@gateway/web/irccloud.com/x-wevmkzgffwmumwjd] has joined #bitcoin-core-dev 14:15 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 14:16 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 14:18 -!- bitconner [~conner@136.24.75.121] has quit [Ping timeout: 252 seconds] 14:18 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ajocuvilrozsnyat] has joined #bitcoin-core-dev 14:18 < bitcoin-git> [bitcoin] hebasto opened pull request #14497: docs: Add `doc/bitcoin-conf.md` (master...20181016-bitcoin-conf-md) https://github.com/bitcoin/bitcoin/pull/14497 14:18 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ajocuvilrozsnyat] has left #bitcoin-core-dev [] 14:32 -!- proletesseract [~proletess@219.88.232.29] has quit [Remote host closed the connection] 14:37 < meshcollider> hebasto: I mentioned that idea above briefly, we can't just stop ignoring comments in-line, because many people's conf files may already use inline comments 14:37 < meshcollider> So suddenly they would all stop being ignored 14:37 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 14:41 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 256 seconds] 14:41 < meshcollider> Jmabsd: https://github.com/bitcoin/bitcoin/tree/master/src/script/standard.cpp#L24 14:45 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 14:47 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 14:49 < achow101> what if we instead just removed rpcuser and rpcpassword? they'be been deprecated for ages 14:52 < sipa> ha. 14:52 < hebasto> meshcollider: to change config file is not the same as to change code :) 14:53 < sipa> hebasto: well we can't just break compatibility with existing config files (within reason) 14:54 < esotericnonsense> surely # in rpcpassword is broken regardless. wtf. 14:54 * esotericnonsense has now made himself aware that you can have a hash in file names. great 14:54 < sipa> ha 14:55 < esotericnonsense> stat #: missing operand (of course) 14:55 < esotericnonsense> stat "#": it works 14:55 < sipa> stat \# 14:56 < promag> hebasto: what sipa said 14:56 < hebasto> agree 15:05 -!- bergz [~berg@69.12.27.194] has quit [Quit: bergz] 15:09 -!- profmac [~ProfMac@2001:470:1f0f:226:8048:6fd6:473a:b93e] has quit [Ping timeout: 252 seconds] 15:10 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 15:12 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Read error: Connection reset by peer] 15:13 -!- Krellan_ [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 15:14 -!- shesek [~shesek@bzq-84-110-234-115.red.bezeqint.net] has joined #bitcoin-core-dev 15:14 -!- shesek [~shesek@bzq-84-110-234-115.red.bezeqint.net] has quit [Changing host] 15:14 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 15:16 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 15:17 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jaxspbgtvldqtgbq] has joined #bitcoin-core-dev 15:17 < bitcoin-git> [bitcoin] mrwhythat opened pull request #14498: rpcwallet: listsentbyaddress RPC (master...listsentbyaddress-rpc) https://github.com/bitcoin/bitcoin/pull/14498 15:17 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jaxspbgtvldqtgbq] has left #bitcoin-core-dev [] 15:19 -!- jarthur [~jarthur@207.114.244.5] has quit [] 15:21 -!- profmac [~ProfMac@2001:470:1f0f:226:3def:8273:dfdb:87c6] has joined #bitcoin-core-dev 15:23 -!- bitconner [~conner@136.24.75.121] has joined #bitcoin-core-dev 15:26 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 15:26 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 15:27 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 15:32 -!- ExtraCrispy_ [~ExtraCris@gateway/tor-sasl/extracrispy] has quit [Remote host closed the connection] 15:37 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 15:40 -!- bergz [~berg@cpe-72-229-124-119.nyc.res.rr.com] has joined #bitcoin-core-dev 15:45 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 15:47 -!- OzPac [~OzPac@cpc110789-lewi20-2-0-cust636.2-4.cable.virginm.net] has joined #bitcoin-core-dev 16:13 < gmaxwell> oh come on, getblockstats run with no special aguments either works or doesn't work without txindex enabled, based on what block you call it on. 16:14 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection] 16:14 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev 16:20 -!- jarthur [~jarthur@2605:6000:1019:41ab:d4ba:cbc9:403b:5c91] has joined #bitcoin-core-dev 16:21 -!- bralyclow2 [~bralyclow@195.242.213.121] has joined #bitcoin-core-dev 16:23 -!- bralyclow2 [~bralyclow@195.242.213.121] has quit [Client Quit] 16:23 < echeveria> achow101: they kind of need to go away 16:23 < echeveria> achow101: there's fucking like, 3000+ open RPC ports on IPv4. 16:23 -!- bralyclow2 [~bralyclow@195.242.213.121] has joined #bitcoin-core-dev 16:24 < echeveria> achow101: assclowns like Samurai Wallet are telling people to bind RPC to 0.0.0.0. 16:24 -!- bralyclow3 [~bralyclow@195.242.213.120] has joined #bitcoin-core-dev 16:26 < gmaxwell> echeveria: what?! 16:27 < gmaxwell> why? 16:27 < echeveria> gmaxwell: connect your wallet to your own node, using RPC! or something. I don't know much about it other than reading some people trying to do it in #bitcoin. 16:28 * luke-jr facepalms 16:28 -!- bralyclow2 [~bralyclow@195.242.213.121] has quit [Client Quit] 16:29 < echeveria> https://support.samourai.io/article/39-enable-trusted-node-in-your-wallet 16:29 < echeveria> clowns. 16:29 < gmaxwell> actually they tell you to VPN, no rpc bind it seems? 16:30 < gmaxwell> what does this feature do? 16:30 -!- bralyclow3 [~bralyclow@195.242.213.120] has quit [Quit: Mutter: www.mutterirc.com] 16:30 < luke-jr> they also tell you to rpcallowip your LAN (or VPN) only 16:30 < luke-jr> but I guess that may bind 0.0.0.0 :/ 16:31 < gmaxwell> why are they not just using p2p? 16:31 -!- OzPac [~OzPac@cpc110789-lewi20-2-0-cust636.2-4.cable.virginm.net] has quit [Quit: OzPac] 16:31 < gmaxwell> "Use your personal node to broadcast transactions to the bitcoin network" 16:32 < gmaxwell> thats what it claims it does 16:32 < luke-jr> wtf, that's not even particularly useful 16:32 < echeveria> from the description I doubt it uses it as a data source. 16:33 < echeveria> this is the company that lied in their original software release and claimed to be decentralized, while using blockchain.info in their closed source release. 16:33 < gmaxwell> I know previously it used bc.i as its data source. I don't see how it would use your local node as a data source. 16:33 -!- bergz [~berg@cpe-72-229-124-119.nyc.res.rr.com] has quit [Quit: bergz] 16:33 < gmaxwell> "We build the software that Bitcoin deserves" ... just so. 16:38 < echeveria> all of their "privacy" tools are snake oil, to boot. it's unfortunate that they're impacting bitcoin node users as well as people fooled into using their incompetent software. 16:39 < achow101> echeveria: removing rpcuser and rpcpassword wouldn't change that though 16:39 < achow101> you can still set rpcauth 16:39 < achow101> (albeit harder to do) 16:39 < echeveria> achow101: it ends up being an automatically generated token, doesn't it? 16:40 < gmaxwell> echeveria: no thats cookie auth. 16:40 < achow101> echeveria: no, that's only the cookie auth stuff. that token goes into the .cookie file 16:40 < achow101> rpcauth is like rpcuser and rpcpassword except as one config option and the password is hashed 16:40 < echeveria> oh, I thought they were the same thing. 16:41 < echeveria> guess that doesn't implicitly solve any issue like I thought. 16:41 < achow101> i mean it's harder for people to figure out how to hash their password to use rpcauth 16:41 < gmaxwell> cookie auth is a replacement for things that read passwords out of the conf file, rpcauth is the replacement for things that have a persistant key left in another app. 16:42 < echeveria> yep, understood, I just bundled them together in my head. it sort of surprised my awfully to realise that so many RPC ports were open in public IPv4 scans. I'm not sure there's a resolution to that, it's already something that's non-trivial to do. 16:43 < gmaxwell> I hope that many of them are honeypots, etc. 16:43 < echeveria> unless the RPC bind option is changed to IM_AN_IDIOT=0.0.0. or something, which I can understand why nobody would want to do that. 16:43 < echeveria> hopefully. 16:44 < meshcollider> sipa: how about checking the flatsigningprovider only added a single pubkey for each descriptor, and import it if it did 16:44 < gmaxwell> just change the string to a new random 256 bit hex value in each release. :P 16:44 < meshcollider> Would that work? 16:45 < echeveria> gmaxwell: see I'd say remove the ability to bind anything but localhost, but I know that would mean people would refuse to upgrade for compatibility reasons. 16:45 < sipa> meshcollider: i have a bit of another strategy in mind 16:45 < achow101> or remove rpcbind and make people figure out iptables/firewall crap to get it accessible from the outside world 16:45 < sipa> meshcollider: let's focus on making importmulti work first for all supported things, and ignore descriptors 16:46 < sipa> meshcollider: i think the code can be massively simplified (but let's do that after merging your PR) 16:46 < gmaxwell> echeveria: it's not unreasonable to bind to a private lan, for example. just security wise fragile. 16:46 < meshcollider> sipa: Alright, sounds good 16:46 < sipa> and after simplification, it can share a lot of logic with the descriptor approach 16:46 < gmaxwell> echeveria: maybe {stop} should work without authentication. :P 16:47 < meshcollider> sipa: does this include change to the wallet or just the RPC code 16:47 < sipa> meshcollider: just the scope of your current PRs 16:47 < gmaxwell> echeveria: oh there you go, auto stop after 1000 invalid auth attempts. :P 16:47 < echeveria> yuck. 16:47 < sipa> echeveria: wumpus had some unix socket binding RPC stuff earlier, not sure what the state is 16:48 < sipa> perhaps that can be made default the only open thing, and you need a separate tool to proxy it to TCP/IP 16:48 < sipa> ... at some point 16:48 < gmaxwell> sipa: it was held up because the client side support needed upstream improvements in libevent. :( 16:48 < sipa> gmaxwell: right 16:48 < echeveria> sipa: I think that results in people using obsolete versions sadly. 16:48 < sipa> echeveria: quite possibly 16:48 < echeveria> that's what happened with BitPay's Insight. they stopped maintaining it so everybody who built around it is still running 0.12, as far as I can tell not behind guard nodes. 16:48 < gmaxwell> I do think that making it harder to make rpc remotely accessible might be a reasonable move, esp post domain socket support. (not that they're really related) 16:49 < jarthur> sipa gmaxwell do you remember why we needed to re-use a socket object in libevent? Is it because we wanted the unix socket file managed by Core instead of libevent? 16:49 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jwznrfrgkulnuhtm] has joined #bitcoin-core-dev 16:49 < bitcoin-git> [bitcoin] MeshCollider closed pull request #14491: Allow descriptor imports with importmulti (master...201810_importmulti_desc_2) https://github.com/bitcoin/bitcoin/pull/14491 16:49 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jwznrfrgkulnuhtm] has left #bitcoin-core-dev [] 16:49 < sipa> jarthur: no clue about the details 16:49 < gmaxwell> echeveria: disabling it would do that, but requiring an insecure_nonlocal_binding=1 16:49 < echeveria> yep. 16:50 < gmaxwell> jarthur: should be in wumpus' issue in the libevent repo. 16:50 < jarthur> sipa: alright. I think that's what wumpus' upstream PR was all about. I think we can do it in libevent today if we have libevent opening the socket in the first place. 16:51 < jarthur> Why is this remote RPC stuff coming up? IMO, it's already hard to expose an RPC port on anything but the loopback. 16:51 < echeveria> jarthur: I noticed that there's a large number of RPC sockets open. 16:52 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 16:52 < jarthur> echeveria: ah, when using Samurai? Or just listening sockets on a clean Core run? 16:52 < gmaxwell> jarthur: wumpus' major motiviation behind working on domain sockets was getting bitcoind to run in a very restrictive sandbox. 16:53 < gmaxwell> samurai is just one of many potential causes for the large number of rpc exposes hosts. 16:54 < echeveria> jarthur: just in general, many IPv4 that have 8333 open also have 8332 open. there's various tools like shodan that present this information in an easy to consume way. samourai was just one theory of mine as to why people might be doing it, as they do suggest exposing your RPC port in some way, for a very stupid reason. 16:54 < gmaxwell> (and a kind of absurd one, since it looks like they have the user open up the RPC to remote hosts just to sendrawtransaction) 16:54 < achow101> even with rpcbind=0.0.0.0, you still need to be whitelisted in rpcallowip to connect though 16:55 < achow101> unless people also did rpcallowip=0.0.0.0 16:56 < jarthur> echeveria: alright. There's also electrumx, electrum-server, electrum-personal-server, electrs, getwork proxy, stratum mining proxies, stratum mining pools. A whole lot of RPC uses out there. 16:56 < gmaxwell> none of those things should be exposing the bitcoind rpc to the wide internet. 16:56 < echeveria> jarthur: none of what you've described need a world listening RPC port. 16:56 < jarthur> Yea, not justifying the open port, just why people end up opening those ports in the first place. 16:57 < gmaxwell> achow101: perhaps we should require "massively_increased_security_vulnerablity_exposure=1" for any rpcallowip statement wider than /8. :P 16:57 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 16:57 < jarthur> I sometimes load up an EC2 Core server, open up RPC to the net and use Amazon Security group to only let myself have access. I got no shame in it :) 16:58 < echeveria> jarthur: huh? it needs extra effort to make it bind to 0.0.0.0, which you don't need for nay of the services you talk about. 16:58 < echeveria> jarthur: you're a bad sysadmin. you have SSH, forward the port locally. 16:59 < gmaxwell> jarthur: the fact that its possible to 0/0 safely (although fragile) is why its possible at all. 16:59 < jarthur> echeveria: yea, that's certainly better. Have done that too when less lazy. 17:00 < gmaxwell> But in practice it appears that a lot of people are exposing themselves, and ultimately thats an issue for us... not just because we care about people getting owned but because it increases the critical attack surface a lot. 17:00 < echeveria> ie, even if not authenticated, I don't believe the RPC server is designed to handle a lot of arbitrary connections hogging sockets. 17:01 < achow101> the rpcpassword is sent plaintext so a mitm can access everything too 17:04 < echeveria> it's not a huge issue, just something to consider. 17:07 -!- Bullit [~Bullit01@037-230-158-163.dynamic.caiway.nl] has quit [Read error: Connection reset by peer] 17:09 -!- bralyclow2 [~bralyclow@195.242.213.121] has joined #bitcoin-core-dev 17:10 -!- bralyclow2 [~bralyclow@195.242.213.121] has quit [Client Quit] 17:10 -!- bralyclow2 [~bralyclow@195.242.213.121] has joined #bitcoin-core-dev 17:10 -!- bralyclow2 [~bralyclow@195.242.213.121] has quit [Client Quit] 17:14 < gmaxwell> indeed, we've had people in #bitcoin that were having issues because some third party was trying to password bruteforce their rpc port or something like that.. 17:19 < sipa> meshcollider: you don't seem to have code for P2SH-P2WPKH 17:22 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 17:23 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 17:25 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection] 17:27 < sipa> meshcollider: also i think the tests are very insufficient; it doesn't test anything but that importmulti succeeds, not whether it actually imported anything 17:27 < sipa> meshcollider: also, no tests with solvable-but-not-spendable cases 17:31 -!- proletesseract [~proletess@123.100.73.101] has joined #bitcoin-core-dev 17:44 -!- Jmabsd2 [~jmabsd@14.0.154.112] has joined #bitcoin-core-dev 17:47 -!- leishman [~leishman@136.24.189.159] has joined #bitcoin-core-dev 17:47 -!- Jmabsd [~jmabsd@14.0.154.112] has quit [Ping timeout: 245 seconds] 17:50 -!- Jmabsd2 [~jmabsd@14.0.154.112] has quit [Quit: Leaving] 17:50 -!- prole [~proletess@12.224.224.49.dyn.cust.vf.net.nz] has joined #bitcoin-core-dev 17:51 -!- leishman [~leishman@136.24.189.159] has quit [Ping timeout: 245 seconds] 17:52 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has joined #bitcoin-core-dev 17:52 -!- proletesseract [~proletess@123.100.73.101] has quit [Ping timeout: 245 seconds] 18:03 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 18:05 -!- Jmabsd [~jmabsd@14.0.154.112] has joined #bitcoin-core-dev 18:12 < meshcollider> sipa: yeah I know the tests aren't the best, I'll make some better ones soon 18:13 < meshcollider> sipa: good point re P2SH-P2WPKH, it was there earlier when it always imported the public keys, but now I changed that I need to add the pubkey import into the P2SH if statement too 18:14 < sipa> meshcollider: i also realized that the importmulti does a whole bunch of things not that it should be doing (unrelated to your PR), which I'd like to fix, like checking that the private keys are actually used, or assigning a timestamp for imported pubkey, or checking that no unnecessary information is given 18:15 < sipa> so maybe my earlier claim that it can simplied a lot is an overstatement, but at least it should be possible to avoid all the duplication that exists now 18:15 < meshcollider> yeah that's what I had hoped at the start, but it keeps devolving into lots of if statements :( 18:16 < sipa> yeah 18:16 < sipa> let's first fix the functionality and tests 18:16 < sipa> further improvements can come later 18:16 < meshcollider> agreed 18:16 < sipa> meshcollider: btw, i realized that getaddressinfo doesn't expose issolvable 18:17 < sipa> which seems a pretty obvious improvement, and would make tests for whether importing succeeded much easier 18:19 < meshcollider> mmm I noticed that, I originally thought it did 18:20 < meshcollider> did validateaddress expose it? 18:20 < meshcollider> or was that never possible 18:20 < sipa> i don't think it did 18:22 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 276 seconds] 18:23 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 18:26 -!- prole [~proletess@12.224.224.49.dyn.cust.vf.net.nz] has quit [Remote host closed the connection] 18:32 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 18:32 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 18:33 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Remote host closed the connection] 18:38 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev 18:43 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 18:45 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 18:45 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 18:48 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 18:48 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 18:51 -!- proletesseract [~proletess@219.88.232.29] has joined #bitcoin-core-dev 18:55 -!- proletesseract [~proletess@219.88.232.29] has quit [Ping timeout: 244 seconds] 18:59 -!- Empact [~empact@192-195-80-207.PUBLIC.monkeybrains.net] has joined #bitcoin-core-dev 19:00 -!- Giszmo [~leo@190.46.54.72] has quit [Quit: Leaving.] 19:01 -!- Empact [~empact@192-195-80-207.PUBLIC.monkeybrains.net] has quit [Client Quit] 19:07 -!- proletesseract [~proletess@219.88.232.29] has joined #bitcoin-core-dev 19:24 -!- booyah [~bb@193.25.1.157] has quit [Remote host closed the connection] 19:35 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds] 19:37 -!- ken2812221 [~ken281222@110.50.135.178] has quit [Ping timeout: 245 seconds] 19:42 -!- Bullit [~Bullit01@037-230-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 19:46 < meshcollider> sipa: managed to get rid of a bit more duplication in the process, should be better now 19:51 -!- ken2812221 [~ken281222@2001-b011-4010-14fa-a106-eb82-08f4-01a2.dynamic-ip6.hinet.net] has joined #bitcoin-core-dev 19:57 -!- ken2812221 [~ken281222@2001-b011-4010-14fa-a106-eb82-08f4-01a2.dynamic-ip6.hinet.net] has quit [Remote host closed the connection] 19:57 -!- ken2812221 [~ken281222@2001-b011-4010-14fa-a106-eb82-08f4-01a2.dynamic-ip6.hinet.net] has joined #bitcoin-core-dev 20:04 -!- keymone [~keymone@ip1f109c7a.dynamic.kabel-deutschland.de] has quit [Ping timeout: 245 seconds] 20:05 -!- keymone [~keymone@ip1f109c7a.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev 20:12 -!- CubicEarth [~CubicEart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 272 seconds] 20:14 -!- CubicEarth [~CubicEart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 20:17 -!- ken2812221 [~ken281222@2001-b011-4010-14fa-a106-eb82-08f4-01a2.dynamic-ip6.hinet.net] has quit [Ping timeout: 250 seconds] 20:18 -!- bralyclow2 [~bralyclow@195.242.213.121] has joined #bitcoin-core-dev 20:19 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 20:19 -!- bralyclow2 [~bralyclow@195.242.213.121] has quit [Client Quit] 20:28 -!- ken2812221 [~ken281222@2001-b011-4010-14fa-a106-eb82-08f4-01a2.dynamic-ip6.hinet.net] has joined #bitcoin-core-dev 20:32 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 252 seconds] 20:47 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 20:54 -!- bralyclow2 [~bralyclow@195.242.213.121] has joined #bitcoin-core-dev 20:56 -!- bralyclow2 [~bralyclow@195.242.213.121] has quit [Client Quit] 20:58 -!- Jmabsd [~jmabsd@14.0.154.112] has quit [Quit: Leaving] 20:59 -!- schnerchi [~schnerchi@p3EE1C053.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 21:02 -!- schnerch_ [~schnerchi@p54A0E28F.dip0.t-ipconnect.de] has quit [Ping timeout: 246 seconds] 21:38 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.] 21:39 -!- leishman [~leishman@136.24.189.159] has joined #bitcoin-core-dev 21:39 -!- leishman [~leishman@136.24.189.159] has quit [Remote host closed the connection] 21:40 -!- leishman [~leishman@136.24.189.159] has joined #bitcoin-core-dev 21:42 -!- Krellan_ [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 21:53 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 21:53 -!- bitconner [~conner@136.24.75.121] has quit [Ping timeout: 252 seconds] 22:03 -!- leishman [~leishman@136.24.189.159] has quit [Remote host closed the connection] 22:09 -!- grubles_ [~grubles@unaffiliated/grubles] has joined #bitcoin-core-dev 22:09 -!- grubles [~grubles@unaffiliated/grubles] has quit [Ping timeout: 244 seconds] 22:31 -!- jarthur [~jarthur@2605:6000:1019:41ab:d4ba:cbc9:403b:5c91] has quit [Remote host closed the connection] 22:32 -!- jarthur [~jarthur@2605:6000:1019:41ab:d4ba:cbc9:403b:5c91] has joined #bitcoin-core-dev 22:33 -!- bralyclow2 [~bralyclow@195.242.213.121] has joined #bitcoin-core-dev 22:35 -!- bitconner [~conner@136.24.75.121] has joined #bitcoin-core-dev 22:35 -!- bralyclow2 [~bralyclow@195.242.213.121] has quit [Client Quit] 22:39 -!- bitconner [~conner@136.24.75.121] has quit [Ping timeout: 244 seconds] 22:40 -!- GAit [~GAit@unaffiliated/gait] has quit [Ping timeout: 272 seconds] 22:49 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 22:49 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 22:50 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 22:53 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 22:58 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 22:58 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 276 seconds] 23:01 < provoostenator> Github has a new review feature: "New! Suggest specific code changes that the pull request author can immediately commit. You will be attributed in the commit." 23:07 -!- GAit [~GAit@unaffiliated/gait] has joined #bitcoin-core-dev 23:08 < provoostenator> I'll try it on the importmulti segwit RPC PR, though I suspect it creates entire new (unsigned) commits, which would mess up our usual flow. 23:19 < meshcollider> well, the commits don't need to be signed except the merge commits 23:19 < meshcollider> so who knows :) 23:19 < meshcollider> but most suggested changes in PRs will be nitfixes I imagine, which should be squashed anyway 23:28 < provoostenator> Related thought: it would be very cool if it was possible to co-sign another persons commit, like a superACK. 23:30 < sipa> there is a convention to add "Signed-off-by: " to a commit message 23:31 < sipa> there's even a git option for it, git commit --signoff 23:39 -!- ken2812221 [~ken281222@2001-b011-4010-14fa-a106-eb82-08f4-01a2.dynamic-ip6.hinet.net] has quit [Remote host closed the connection] 23:39 -!- ken2812221 [~ken281222@2001-b011-4010-14fa-a106-eb82-08f4-01a2.dynamic-ip6.hinet.net] has joined #bitcoin-core-dev 23:50 < sipa> meshcollider: moar comments, starting to look good :) --- Log closed Wed Oct 17 00:00:39 2018